From owner-freebsd-transport@freebsd.org Mon Jan 11 01:13:14 2016 Return-Path: Delivered-To: freebsd-transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B770EA6AD1E for ; Mon, 11 Jan 2016 01:13:14 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from mail-n.franken.de (drew.ipv6.franken.de [IPv6:2001:638:a02:a001:20e:cff:fe4a:feaa]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.franken.de", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D4841FC0; Mon, 11 Jan 2016 01:13:14 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from [192.168.1.200] (p508F168D.dip0.t-ipconnect.de [80.143.22.141]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTP id 6901D1C0C069D; Mon, 11 Jan 2016 02:13:10 +0100 (CET) From: Michael Tuexen Content-Type: multipart/mixed; boundary="Apple-Mail=_FAF7D5DC-010B-4F9E-8E25-EFEDC758CDC5" Subject: Patch for igb driver to support Date: Mon, 11 Jan 2016 02:13:07 +0100 Message-Id: <546AAC80-FC4B-4280-BA5A-78E9A6131117@freebsd.org> Cc: freebsd-transport@freebsd.org To: Eric Joyner , Sean Bruno Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) X-Mailer: Apple Mail (2.3112) X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2016 01:13:14 -0000 --Apple-Mail=_FAF7D5DC-010B-4F9E-8E25-EFEDC758CDC5 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Hi Eric, hi Sean, in ig_igb.c the support for checksum offloading for SCTP, TCP and UDP over IPv6 is missing. The attached patch fixes it. The code is #ifdef'ed similar to the code in ixgbe/if_ix.c. Comments? OK to commit? Best regards Michael --Apple-Mail=_FAF7D5DC-010B-4F9E-8E25-EFEDC758CDC5 Content-Disposition: attachment; filename=if_igb.patch Content-Type: application/octet-stream; name="if_igb.patch" Content-Transfer-Encoding: 7bit Index: if_igb.c =================================================================== --- if_igb.c (revision 293608) +++ if_igb.c (working copy) @@ -1184,10 +1184,27 @@ } } #endif +#if __FreeBSD_version >= 1000000 + /* HW cannot turn these on/off separately */ + if (mask & (IFCAP_RXCSUM | IFCAP_RXCSUM_IPV6)) { + ifp->if_capenable ^= IFCAP_RXCSUM; + ifp->if_capenable ^= IFCAP_RXCSUM_IPV6; + reinit = 1; + } + if (mask & IFCAP_TXCSUM) { + ifp->if_capenable ^= IFCAP_TXCSUM; + reinit = 1; + } + if (mask & IFCAP_TXCSUM_IPV6) { + ifp->if_capenable ^= IFCAP_TXCSUM_IPV6; + reinit = 1; + } +#else if (mask & IFCAP_HWCSUM) { ifp->if_capenable ^= IFCAP_HWCSUM; reinit = 1; } +#endif if (mask & IFCAP_TSO4) { ifp->if_capenable ^= IFCAP_TSO4; reinit = 1; @@ -1274,6 +1291,14 @@ #endif } +#if __FreeBSD_version >= 1000000 + if (ifp->if_capenable & IFCAP_TXCSUM_IPV6) { + ifp->if_hwassist |= (CSUM_TCP_IPV6 | CSUM_UDP_IPV6); + if ((adapter->hw.mac.type == e1000_82576) || + (adapter->hw.mac.type == e1000_82580)) + ifp->if_hwassist |= CSUM_SCTP_IPV6; + } +#endif if (ifp->if_capenable & IFCAP_TSO) ifp->if_hwassist |= CSUM_TSO; @@ -3151,6 +3176,9 @@ ifp->if_capabilities = ifp->if_capenable = 0; ifp->if_capabilities = IFCAP_HWCSUM | IFCAP_VLAN_HWCSUM; +#if __FreeBSD_version >= 1000000 + ifp->if_capabilities |= IFCAP_HWCSUM_IPV6; +#endif ifp->if_capabilities |= IFCAP_TSO; ifp->if_capabilities |= IFCAP_JUMBO_MTU; ifp->if_capenable = ifp->if_capabilities; @@ -3924,17 +3952,29 @@ switch (ipproto) { case IPPROTO_TCP: +#if __FreeBSD_version >= 1000000 + if (mp->m_pkthdr.csum_flags & (CSUM_TCP | CSUM_TCP_IPV6)) +#else if (mp->m_pkthdr.csum_flags & CSUM_TCP) +#endif type_tucmd_mlhl |= E1000_ADVTXD_TUCMD_L4T_TCP; break; case IPPROTO_UDP: +#if __FreeBSD_version >= 1000000 + if (mp->m_pkthdr.csum_flags & (CSUM_UDP | CSUM_UDP_IPV6)) +#else if (mp->m_pkthdr.csum_flags & CSUM_UDP) +#endif type_tucmd_mlhl |= E1000_ADVTXD_TUCMD_L4T_UDP; break; #if __FreeBSD_version >= 800000 case IPPROTO_SCTP: +#if __FreeBSD_version >= 1000000 + if (mp->m_pkthdr.csum_flags & (CSUM_SCTP | CSUM_SCTP_IPV6)) +#else if (mp->m_pkthdr.csum_flags & CSUM_SCTP) +#endif type_tucmd_mlhl |= E1000_ADVTXD_TUCMD_L4T_SCTP; break; #endif Index: if_igb.h =================================================================== --- if_igb.h (revision 293608) +++ if_igb.h (working copy) @@ -291,7 +291,11 @@ #define ETH_ADDR_LEN 6 /* Offload bits in mbuf flag */ -#if __FreeBSD_version >= 800000 +#if __FreeBSD_version >= 1000000 +#define CSUM_OFFLOAD_IPV4 (CSUM_IP|CSUM_TCP|CSUM_UDP|CSUM_SCTP) +#define CSUM_OFFLOAD_IPV6 (CSUM_TCP_IPV6|CSUM_UDP_IPV6|CSUM_SCTP_IPV6) +#define CSUM_OFFLOAD (CSUM_OFFLOAD_IPV4|CSUM_OFFLOAD_IPV6) +#elif __FreeBSD_version >= 800000 #define CSUM_OFFLOAD (CSUM_IP|CSUM_TCP|CSUM_UDP|CSUM_SCTP) #else #define CSUM_OFFLOAD (CSUM_IP|CSUM_TCP|CSUM_UDP) --Apple-Mail=_FAF7D5DC-010B-4F9E-8E25-EFEDC758CDC5-- From owner-freebsd-transport@freebsd.org Thu Jan 14 17:48:30 2016 Return-Path: Delivered-To: freebsd-transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ECDF8A83269 for ; Thu, 14 Jan 2016 17:48:30 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id CE9351C81 for ; Thu, 14 Jan 2016 17:48:30 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mailman.ysv.freebsd.org (Postfix) id CC8BCA83268; Thu, 14 Jan 2016 17:48:30 +0000 (UTC) Delivered-To: transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B2653A83267 for ; Thu, 14 Jan 2016 17:48:30 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pa0-x234.google.com (mail-pa0-x234.google.com [IPv6:2607:f8b0:400e:c03::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 86C251C80 for ; Thu, 14 Jan 2016 17:48:30 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-pa0-x234.google.com with SMTP id uo6so364793684pac.1 for ; Thu, 14 Jan 2016 09:48:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=from:content-type:subject:message-id:date:to:mime-version; bh=aPczZlQUefXtAyNPYpzcAp/NrisoMGcMyOPk+RekEXo=; b=dobCOjnxcrvZ1qxfun50uGxLjCYEo3pcrGvndvcFP+i83qtUGnCwBkCNrYypj5eMh/ /mA/x09W3v0YrhkwbsrgpuM7lG5c0JSCvEawztHmuBWZSLrW0DyN2IvjnepJ+L2F0jdZ lXdUV4ucnmoNP1r9KW83N/E0obJzmRNK81XKk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:content-type:subject:message-id:date:to :mime-version; bh=aPczZlQUefXtAyNPYpzcAp/NrisoMGcMyOPk+RekEXo=; b=WYrYodzTkdhMVsEoKUHBTr9qQeeVrJCtqCG1B7gVZtXlzG8i1NAuavOptSU3yYQCAe WzfuJEHnKCGMeo+1VTAjz1DBjHiY2ZwTLVD8EEMW8iNhsQvVSoehieSOX3DCFkNktlxG Bx9KvHqAB9esbb6Mce2CD1dBEdFwX8mnADFOjNyrm57LnDuCj9WlVlgdplDIrfvfamn9 m1dTw0U9vm4KAdjU8Z94eH2sgu9H3bK2B4VeQPJgKaHs18abJzogNn3op5rMNnSLMbot HNnk974UspnAuVXOtg5JoA7Ovy+eqptDkhiA0mYPpLneQG8P049PDuS2Sk5pQEuuUNKs dwtQ== X-Gm-Message-State: ALoCoQk9z7YQNjqGk9nllj7RRGk0wDHUD4ejMuE8xcJwRRtxUq4palVITF5xTNiwqJ3Guj3uaYlXB4SHoMB8FobG//aarRPSQQ== X-Received: by 10.66.139.234 with SMTP id rb10mr7900763pab.82.1452793709961; Thu, 14 Jan 2016 09:48:29 -0800 (PST) Received: from [192.168.110.6] ([69.53.245.111]) by smtp.gmail.com with ESMTPSA id c90sm10698805pfd.31.2016.01.14.09.48.27 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 14 Jan 2016 09:48:28 -0800 (PST) From: Randall Stewart Subject: Interesting CC Message-Id: Date: Thu, 14 Jan 2016 12:48:24 -0500 To: FreeBSD Transports Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) X-Mailer: Apple Mail (2.1878.6) Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2016 17:48:31 -0000 As per our discussion on transports=85 Here is a interesting CC algorithm that has been recently pointed out to = me=85 Not sure its right (it may be ok .. or not) .. its something to think = about though... http://arxiv.org/pdf/1409.7092v3.pdf R -------- Randall Stewart rrs@netflix.com 803-317-4952 From owner-freebsd-transport@freebsd.org Thu Jan 14 21:18:08 2016 Return-Path: Delivered-To: freebsd-transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 96574A82B24 for ; Thu, 14 Jan 2016 21:18:08 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 835141ED2 for ; Thu, 14 Jan 2016 21:18:08 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: by mailman.ysv.freebsd.org (Postfix) id 7FBD1A82B23; Thu, 14 Jan 2016 21:18:08 +0000 (UTC) Delivered-To: transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7F5D3A82B22 for ; Thu, 14 Jan 2016 21:18:08 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from smtp.hungerhost.com (smtp.hungerhost.com [216.38.51.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 613E71ED1 for ; Thu, 14 Jan 2016 21:18:07 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from ool-44c55afc.dyn.optonline.net ([68.197.90.252]:56418 helo=[192.168.254.50]) by vps.hungerhost.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.86) (envelope-from ) id 1aJpHT-0006dZ-8Q for transport@freebsd.org; Thu, 14 Jan 2016 16:18:07 -0500 From: "George Neville-Neil" To: transport@freebsd.org Subject: Meeting on the 21st of January Date: Thu, 14 Jan 2016 16:18:06 -0500 Message-ID: <8C503E54-A814-4ABA-BEC7-92AC6D7C41D2@neville-neil.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Mailer: MailMate (1.9.3r5187) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps.hungerhost.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - neville-neil.com X-Get-Message-Sender-Via: vps.hungerhost.com: authenticated_id: gnn@neville-neil.com X-Authenticated-Sender: vps.hungerhost.com: gnn@neville-neil.com X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2016 21:18:08 -0000 Howdy, I will be missing the hangout on the 21st of January. I believe that hiren@ has volunteered to take notes. Please make sure to update the Wiki when y'all are done. Best, George From owner-freebsd-transport@freebsd.org Thu Jan 14 21:43:22 2016 Return-Path: Delivered-To: freebsd-transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 94789A833C7 for ; Thu, 14 Jan 2016 21:43:22 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 8292D12A6 for ; Thu, 14 Jan 2016 21:43:22 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: by mailman.ysv.freebsd.org (Postfix) id 811B1A833C6; Thu, 14 Jan 2016 21:43:22 +0000 (UTC) Delivered-To: transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 80AD8A833C5 for ; Thu, 14 Jan 2016 21:43:22 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: from mail.strugglingcoder.info (strugglingcoder.info [65.19.130.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.strugglingcoder.info", Issuer "mail.strugglingcoder.info" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 73E1812A5 for ; Thu, 14 Jan 2016 21:43:19 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: from localhost (unknown [10.1.1.3]) (Authenticated sender: hiren@strugglingcoder.info) by mail.strugglingcoder.info (Postfix) with ESMTPA id D1C6DD2389; Thu, 14 Jan 2016 13:43:12 -0800 (PST) Date: Thu, 14 Jan 2016 13:43:12 -0800 From: hiren panchasara To: Randall Stewart Cc: FreeBSD Transports Subject: Re: Interesting CC Message-ID: <20160114214312.GD65195@strugglingcoder.info> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="veXX9dWIonWZEC6h" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jan 2016 21:43:22 -0000 --veXX9dWIonWZEC6h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 01/14/16 at 12:48P, Randall Stewart via freebsd-transport wrote: >=20 > As per our discussion on transports? >=20 > Here is a interesting CC algorithm that has been recently pointed out to = me? >=20 > Not sure its right (it may be ok .. or not) .. its something to think abo= ut though... >=20 > http://arxiv.org/pdf/1409.7092v3.pdf Thanks Randall. Yeah, I now remember looking at it briefly. More info: http://modong.github.io/pcc-page/ The whole idea is indeed...interesting. In simple terms instead of reducing cwnd on (perceived) loss or congestion event, idea is to try and experiment with different sending rates and compare the results (based on what you are looking for in a connection) to see which of the approached helped you achieve best outcome. I've yet to go through all the details in the paper. But their claims seem very promising based on whatever testing they've done using the prototype implementation in userspace on top of UDP. Not sure if we can easily port the implementation into our modular CC framework. Cheers, Hiren --veXX9dWIonWZEC6h Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAABCgBmBQJWmBZsXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lbwoH/Apb8SppTUt65rro4HeFlwf1 oKPTnKezxpTY0I1/C4Z0j3hSqcf3uKvqrHNdYLXiezkm8EG6EP/ETw79jHtkKgDu jV7k1Wu2lUyGP4SIske/Rjrl36U+ciWpYWhRSZZJbKCPQD2GNRIPlOPCGK4HayO6 Pbw0okq6LuywI/fJqdbTy7vBTPzUVmHq6d9LeR6WzILGoOY0XuC1wJs4iqAQb40C ePIdCKmg8rRPTn7rRmYPrygyvkbiwmbokTuqo0ZCjKk6bux3ahB5dub1cUzQRdrf gZRmeAo7RxWxIPGwcd+QIDlved0EfjI3svI1i0zwZpxTPOygzfOVJUd9EBrFwXw= =5YyP -----END PGP SIGNATURE----- --veXX9dWIonWZEC6h--