From owner-freebsd-transport@freebsd.org Mon Jul 25 18:09:54 2016 Return-Path: Delivered-To: freebsd-transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AD7C8B9C775 for ; Mon, 25 Jul 2016 18:09:54 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-it0-x230.google.com (mail-it0-x230.google.com [IPv6:2607:f8b0:4001:c0b::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 725BF1469 for ; Mon, 25 Jul 2016 18:09:54 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-it0-x230.google.com with SMTP id u186so91200533ita.0 for ; Mon, 25 Jul 2016 11:09:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Z90URC3ZkcYakzOHpVpwnG1iWuPc+Wobjdoq48b1qZ8=; b=ZBDtBs7OXboV/+8uljbwfIs+OM8A9+Z3aTVfc2an+ZmoilXL1kd8RhCd5eW2bSZrM1 NSlbvMgSJ/tZh6VtAkvJGsqfHqAjyof9P3riR6zZcs0LyNi47w93wya1o+Lk1uj5N9vt gFNL5D535qLZZpsQJWSuFc5grTiqXnBHWU7CEx3C4fP3G+I6aBgzEH7Guz6P7TvO0KIk HLP/e7rlAOSLGI556WfdaB8Z8+C1KDIBWDIF9SJyBN8eR3IftoMGBBguWtFWHiNbDNnF ByJzj+3Zb/mA27iutMeLSsvDifuJ5Trh5mEzcd+spQtQLRmw6FlqOSnxHZM16lcBemp/ 8tBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Z90URC3ZkcYakzOHpVpwnG1iWuPc+Wobjdoq48b1qZ8=; b=L9wXToc9JVXymAoqIz7ZOGllctFRJJnPhkJnHLw3D9Uek4T8ttz5V+IXz6t+e5CwrP Rqg8d9f5ipy1Tf7Zu9nXjxjRIfxi/twoMlEsGFZ3bbdy6S+RlmQX1BC+NE7uLaCtQICD mev0/8OnBAO1fz1EnpUPEu6RadwbX0hiQCtaEhd+JlfqdgfwCwHmB7TpOO+YcyxIBNUt Cv1EW1QWfHI2hyH2uaZkc7hvhfOJOMf5iXywEOEvUVRuL0OtQuz5Fpjx7cToMcwo4I6Y kk8zwB4OTEkHJiBop9lyeSpQzKU1A7DuIHxFDOOPH98pPhwi/zGwdGUfquWJdJUDDc1p khzQ== X-Gm-Message-State: AEkoouuWbxmD0opzkWlbTz6p5HmaEuE0CvwyqVfOXj+iSQ0S4fvwj2zE9JJF+JwMLh7ejactAKlkvYeIAa2dlw== X-Received: by 10.36.21.65 with SMTP id 62mr22505850itq.20.1469470193988; Mon, 25 Jul 2016 11:09:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.200.71 with HTTP; Mon, 25 Jul 2016 11:09:53 -0700 (PDT) In-Reply-To: References: <559f1d0e-9d35-f458-bff5-b69a03297cf0@netflix.com> From: Ryan Stone Date: Mon, 25 Jul 2016 14:09:53 -0400 Message-ID: Subject: Re: in_broadcast() called for almost every packet in ip_output() To: Adrian Chadd Cc: Andrew Gallatin , "" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2016 18:09:54 -0000 On Wed, Jul 20, 2016 at 7:57 PM, Ryan Stone wrote: > Would it be correct to check for M_BCAST on the packet before checking for > for a broadcast IP address? I don't believe that there would be any > security concerns with that approach. If somebody injected a UDP packet > with a broadcast IP address but a unicast MAC address, we would try to look > up a pcb that matched, fail to find anything, and then drop the packet. > Ok, I've put this up for review, along with a fix for the 802.11 stack to have it set M_BCAST properly: https://reviews.freebsd.org/D7309 Are there any other L2 protocols that we support other than Ethernet and 802.11 that I should audit to ensure it sets M_BCAST properly. From owner-freebsd-transport@freebsd.org Mon Jul 25 18:37:27 2016 Return-Path: Delivered-To: freebsd-transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ED2BFB9CF86 for ; Mon, 25 Jul 2016 18:37:27 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x231.google.com (mail-io0-x231.google.com [IPv6:2607:f8b0:4001:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B2CED1629 for ; Mon, 25 Jul 2016 18:37:27 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-io0-x231.google.com with SMTP id m101so169394005ioi.2 for ; Mon, 25 Jul 2016 11:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=m5bDQzDELHT6bnLx75q9HxSrx9Mv1w/wp9jdBeyZWf0=; b=n4fuI/cZktMRpb+WOCfgoAlIVEvxPuG3NRgbfDL/cOaY8v5/IVIRjGBJdprtH0fhek cZlNPw7WuXibM8eTBgKU4Q85ASG6PUmyc1Y7ThEGeIXJPIdfqzeBt+0X15iJ4VPxZtiH 8kvbtGvJUP5qXOvjSVIxQ4Wg/FOfUHJGmppg/I4tRps91kqGh401q42P8A71Wlk9ZIKP gEgrIlR+ybQdq8pptEIt7nUhwyvCHx3jVbpcnVyx3VM77kxtOoKXYSHuZW0qDptgdko2 P8lyZfepp/KCQpEjkTgdrnnB/kOyGW+p1maqtJJ9txi4fauIuNKzl2Nhwwz2pPVuKug4 Ggig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=m5bDQzDELHT6bnLx75q9HxSrx9Mv1w/wp9jdBeyZWf0=; b=Q5qSNb+bITSElxjwRhFJG6QhbSohSS/R87QxVYbewJttip6sTCsscxMfmnSNWrqQ3D DKD7GAfE/x0OHGBF0/NkJt8HpluYlMm3XWfm14MQE9+Kr6ZSpbskfVVU4k+8aBpZxXo7 9L6r4ZCeZOeP8IWSOU5tOk8eKyx5FKoFbp+06/iPbMWu/NVTuMULE7yS9/UTNxKsic2v 9HFlapwyh4kIK3emmpcpD70U0QNt+dtdAKGVAFb7YdsP1Q/RJNuyz8uuJrwkXcg6xXu+ HKeefpwLI7uLY6rEF74Yr24fnVt6FQ7cBPE72OQEJkBNKBF7upIo5vhwSqAQsLgI1kMY sFfA== X-Gm-Message-State: AEkoouszKRlIbLf/1HjoRwRR7kUzdpvm8nOM/QTB9GoxqRKuZompKeygieJyIUZDCM3hZ2GuoxrU3ZJRP09KmA== X-Received: by 10.107.144.10 with SMTP id s10mr20980462iod.165.1469471847201; Mon, 25 Jul 2016 11:37:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.141.129 with HTTP; Mon, 25 Jul 2016 11:37:26 -0700 (PDT) In-Reply-To: References: <559f1d0e-9d35-f458-bff5-b69a03297cf0@netflix.com> From: Adrian Chadd Date: Mon, 25 Jul 2016 11:37:26 -0700 Message-ID: Subject: Re: in_broadcast() called for almost every packet in ip_output() To: Ryan Stone Cc: Andrew Gallatin , "" Content-Type: text/plain; charset=UTF-8 X-Mailman-Approved-At: Mon, 25 Jul 2016 19:11:59 +0000 X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2016 18:37:28 -0000 hi, can you post a separate patch for the 802.11 fix? I'd like to get it more widely tested! Thanks, -adrian On 25 July 2016 at 11:09, Ryan Stone wrote: > On Wed, Jul 20, 2016 at 7:57 PM, Ryan Stone wrote: >> >> Would it be correct to check for M_BCAST on the packet before checking for >> for a broadcast IP address? I don't believe that there would be any >> security concerns with that approach. If somebody injected a UDP packet >> with a broadcast IP address but a unicast MAC address, we would try to look >> up a pcb that matched, fail to find anything, and then drop the packet. > > > Ok, I've put this up for review, along with a fix for the 802.11 stack to > have it set M_BCAST properly: > https://reviews.freebsd.org/D7309 > > Are there any other L2 protocols that we support other than Ethernet and > 802.11 that I should audit to ensure it sets M_BCAST properly. From owner-freebsd-transport@freebsd.org Tue Jul 26 01:14:19 2016 Return-Path: Delivered-To: freebsd-transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9550ABA3DCB for ; Tue, 26 Jul 2016 01:14:19 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: from mail-io0-x232.google.com (mail-io0-x232.google.com [IPv6:2607:f8b0:4001:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49A3B14DC for ; Tue, 26 Jul 2016 01:14:19 +0000 (UTC) (envelope-from rysto32@gmail.com) Received: by mail-io0-x232.google.com with SMTP id q83so186870940iod.1 for ; Mon, 25 Jul 2016 18:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=4Empzy1OOZE9HscfTs6jpSYnkRbWvQpJRpvHslf67vQ=; b=dn/9E222jXt262GgxQBnMmaZAJl4w2QHWeAZ5QLJQFq/eX5Bqx8AHexTjcDUqUJ6XQ zc3DXVKP1uLIPk4ZO+co2h+/YgAAd+E9CmWsPcKXhT/VGNNTtLnjMVH4x44gxbjtMXMD 8NPxMzDPOszbQXrbrFPVOzYd/zG4+d1ilOlFu3zJ0NVldQF9yB1+FTP/m1Kky1weSy+L gGvat/Xfwf19pwaZynVNE99u98j0IPT/TokIZa+HPrQ/RtLgb7N8rSeWtG20d4ARYmr2 y23Xi/wZoHt3TSO0/BXM04MWTM+p0ApIzXVRP/+EfQsl8EQdf/XgrkRY9GJhZJsGB2jc Lv+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=4Empzy1OOZE9HscfTs6jpSYnkRbWvQpJRpvHslf67vQ=; b=CW+27TpO5KJJk36J4X78d1EVMx7deNGtxMcQFbjoSr03XTNk9V9HQJigywawGQbo7s aTbmSfnxmRvwXvYxIh1GFqxr233gGYco9ZjTdLanaFcaYIplape4y/Sc9dXm89a7857H aSx9C/97Tmx2A3L6A5Rjyn9D1JMB3GBOz6NfjKc+NGwFjAtjfQO3Mcke1RbXSHoxPWdB ZQV9JVpVxTSK9EjUVOvM/6td+Fn4ZZe9jGPb8qZbPVGpZ4maU+5H8xqtVBB8yj09niso 4NT162lIg5CrkjEO/0CChQ/ZLDoYtN2x757lDHzOmsWyYnkoRSrMKv6Nvs3+HPVkSyKw XLwg== X-Gm-Message-State: AEkoouuuS4ts286rulvFZRSonVonKb/wa96RJDbxrZv5wSVRM35G2ic1gEh4VUL++MXsV2NWtiMJroe/GXRtwg== X-Received: by 10.107.150.83 with SMTP id y80mr24378621iod.113.1469495658732; Mon, 25 Jul 2016 18:14:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.200.71 with HTTP; Mon, 25 Jul 2016 18:14:18 -0700 (PDT) In-Reply-To: References: <559f1d0e-9d35-f458-bff5-b69a03297cf0@netflix.com> From: Ryan Stone Date: Mon, 25 Jul 2016 21:14:18 -0400 Message-ID: Subject: Re: in_broadcast() called for almost every packet in ip_output() To: Adrian Chadd Cc: Andrew Gallatin , "" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jul 2016 01:14:19 -0000 On Mon, Jul 25, 2016 at 2:37 PM, Adrian Chadd wrote: > hi, > > can you post a separate patch for the 802.11 fix? I'd like to get it > more widely tested! > > Thanks, > > > -adrian > https://people.freebsd.org/~rstone/patches/wifi_m_bcast.diff From owner-freebsd-transport@freebsd.org Thu Jul 28 00:50:40 2016 Return-Path: Delivered-To: freebsd-transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8AFF8BA7F4C for ; Thu, 28 Jul 2016 00:50:40 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 762511C97 for ; Thu, 28 Jul 2016 00:50:40 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: by mailman.ysv.freebsd.org (Postfix) id 72080BA7F4B; Thu, 28 Jul 2016 00:50:40 +0000 (UTC) Delivered-To: transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6F449BA7F4A for ; Thu, 28 Jul 2016 00:50:40 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from smtp.hungerhost.com (smtp.hungerhost.com [216.38.51.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4F7791C96 for ; Thu, 28 Jul 2016 00:50:39 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from [63.149.67.7] (port=51917 helo=[192.168.64.1]) by vps.hungerhost.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.87) (envelope-from ) id 1bSZX4-00035a-Ut for transport@freebsd.org; Wed, 27 Jul 2016 20:50:38 -0400 From: "George Neville-Neil" To: transport@freebsd.org Subject: Missing the meeting tomorrow Date: Wed, 27 Jul 2016 20:50:37 -0400 Message-ID: <1D0607D4-FFF8-4597-AC3C-945E01AE0D9A@neville-neil.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Mailer: MailMate (1.9.4r5234) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps.hungerhost.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - neville-neil.com X-Get-Message-Sender-Via: vps.hungerhost.com: authenticated_id: gnn@neville-neil.com X-Authenticated-Sender: vps.hungerhost.com: gnn@neville-neil.com X-Source: X-Source-Args: X-Source-Dir: X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2016 00:50:40 -0000 Howdy, I've got an all day project meeting tomorrow. Someone else will need to run the hangout and take notes. Best, George From owner-freebsd-transport@freebsd.org Thu Jul 28 01:20:05 2016 Return-Path: Delivered-To: freebsd-transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0A76BBA554D for ; Thu, 28 Jul 2016 01:20:05 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id ED2461698 for ; Thu, 28 Jul 2016 01:20:04 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: by mailman.ysv.freebsd.org (Postfix) id E8D0ABA554A; Thu, 28 Jul 2016 01:20:04 +0000 (UTC) Delivered-To: transport@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E8727BA5549 for ; Thu, 28 Jul 2016 01:20:04 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: from mail.strugglingcoder.info (strugglingcoder.info [104.236.146.68]) by mx1.freebsd.org (Postfix) with ESMTP id DC8101697 for ; Thu, 28 Jul 2016 01:20:04 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: from localhost (unknown [10.1.1.3]) (Authenticated sender: hiren@strugglingcoder.info) by mail.strugglingcoder.info (Postfix) with ESMTPA id C306F17E9C for ; Wed, 27 Jul 2016 18:20:03 -0700 (PDT) Date: Wed, 27 Jul 2016 18:20:03 -0700 From: hiren panchasara To: transport@freebsd.org Subject: Much belated transport session notes Message-ID: <20160728012003.GL94850@strugglingcoder.info> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wxIXENaY2CYUgF8u" Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2016 01:20:05 -0000 --wxIXENaY2CYUgF8u Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Apologies in advance for the delay but I've just updated the page with session notes.=20 https://wiki.freebsd.org/DevSummit/201606/Transport Any possible errors might be my failed attempt to note/translate the original intent. Cheers, Hiren --wxIXENaY2CYUgF8u Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAABCgBmBQJXmV2dXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lEiEH/3unziVHQhoLiYeLgyXcLauq y8j8yyALj3aS5SiIyfz+YKFYHbEZaFz1thdVU/mqkAmsbglCHhBOCZqoNizAdedb OJSMKFgwNiOJe1gwqaLF3res5x1xDhVd49ApyVyvVmLo5GezVB/41kiiTOzOUELx Xbhn1RoAkUq/QTGCglKOiV1aU6zofx07HWBDovb5vnVTiisGlmBAjXlHThjORXg8 mdYkgeICZdoUQZP9K5jSk8z6pVKxhen3eLzG7jS9H7ha3jZ+UOOI4WAfZP6mnPTX RqzWIOGmC/wbM33SUB8Xxc1gyTE+t+QLDILQ4dWnMRh9reWZfB7usN5Gwoj/aKY= =ZKjQ -----END PGP SIGNATURE----- --wxIXENaY2CYUgF8u--