From owner-freebsd-virtualization@freebsd.org Sun May 1 21:00:07 2016 Return-Path: Delivered-To: freebsd-virtualization@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 581D5B2910A for ; Sun, 1 May 2016 21:00:07 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 36ECD1DE3 for ; Sun, 1 May 2016 21:00:07 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u41L015a072451 for ; Sun, 1 May 2016 21:00:07 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <201605012100.u41L015a072451@kenobi.freebsd.org> From: bugzilla-noreply@FreeBSD.org To: freebsd-virtualization@FreeBSD.org Subject: Problem reports for freebsd-virtualization@FreeBSD.org that need special attention Date: Sun, 01 May 2016 21:00:07 +0000 X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 May 2016 21:00:07 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- In Progress | 202321 | [bhyve,patch] More verbose error reporting in bhy New | 202322 | [bhyve,patch] add option to have bhyve write its 2 problems total for which you should take action. From owner-freebsd-virtualization@freebsd.org Tue May 3 22:28:18 2016 Return-Path: Delivered-To: freebsd-virtualization@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 00FEDB2CA7A for ; Tue, 3 May 2016 22:28:17 +0000 (UTC) (envelope-from saper@saper.info) Received: from m.saper.info (m.saper.info [IPv6:2a01:4f8:a0:7383::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "m.saper.info", Issuer "Marcin Cieslak 2016" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 6EE3711EE for ; Tue, 3 May 2016 22:28:17 +0000 (UTC) (envelope-from saper@saper.info) Received: from m.saper.info (saper@m.saper.info [IPv6:2a01:4f8:a0:7383::]) by m.saper.info (8.15.2/8.15.2) with ESMTPS id u43MS0OT062720 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 3 May 2016 22:28:00 GMT (envelope-from saper@saper.info) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=saper.info; s=Sep2014; t=1462314480; bh=7Is46d8BiyvfE9WD/YS1zOsQ2qrlnJ77Lof8vFspygA=; h=Date:From:To:cc:Subject:In-Reply-To:References; b=IM6/Yx5pwulksI86iz4vr7PlXXbV6eU/fCTA3cL4tRaSpXYmGzoQGCu9AlO6bmqwu lHZ0NqkdsyzZN3QzTF5oOja0aSDqvHSXOQ9qDx00hzv0qE8JIUK3PIOCUR45iSwWzZ axHFjgIApGhX9nj/emCQW/kSBXiW2B4NAoOOP/zY= Received: from localhost (saper@localhost) by m.saper.info (8.15.2/8.15.2/Submit) with ESMTP id u43MRwjX062717; Tue, 3 May 2016 22:27:59 GMT (envelope-from saper@saper.info) X-Authentication-Warning: m.saper.info: saper owned process doing -bs Date: Tue, 3 May 2016 22:27:58 +0000 From: Marcin Cieslak To: =?ISO-8859-15?Q?Roger_Pau_Monn=E9?= cc: freebsd-virtualization@freebsd.org, Ross McKelvie Subject: Re: Booting Windows/UEFI In-Reply-To: <20160426093556.oxeh5qyafe3ro6xy@mac> Message-ID: References: <20160425084714.64ejioyqgquwu4gw@mac> <20160426071151.ctzdaehgfhzij6q3@mac> <20160426074302.4i3rv7wd5ogg7ful@mac> <20160426093556.oxeh5qyafe3ro6xy@mac> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 May 2016 22:28:18 -0000 On Tue, 26 Apr 2016, Roger Pau Monné wrote: > On Tue, Apr 26, 2016 at 09:24:30AM +0000, Marcin Cieslak wrote: > > I got lazy and I have downloaded > > > > https://sourceforge.net/projects/edk2/files/OVMF/OVMF-X64-r15214.zip/download > > > > recompiled xen-tools by adding to xen-tools/Makefile > > > > CONFIGURE_ARGS+= --enable-ovmf > > CONFIGURE_ARGS+= --with-system-ovmf=/root/xen/OVMF.fd > > > > and worked pretty much out of the box. > > Oh, thanks for the info, I didn't know OVMF provided pre-compiled binaries. > This should make adding a OVMF port trivial. Would you like to take a stab > at adding such a port and wiring it into the xen-tools package? As I just found out, there are already submitted port from Ross McKelvie (CC'd): https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192012 This is not only binary firmware - Ross ported also a whole toolkit! On my amd64 machine both firmwares (ia32 and x64) can be used to boot Windows via Xen, so maybe we could make Xen depend on the ia32 port and use --with-system-ovmf=${LOCALBASE}/share/tianocore-ovmf-ia32/OVMF.fd Would that be possible to commit the port? Marcin From owner-freebsd-virtualization@freebsd.org Thu May 5 15:43:52 2016 Return-Path: Delivered-To: freebsd-virtualization@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4DFD7B2E0DB for ; Thu, 5 May 2016 15:43:52 +0000 (UTC) (envelope-from prvs=9267fa6dd=roger.pau@citrix.com) Received: from SMTP.CITRIX.COM (smtp.citrix.com [66.165.176.89]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "mail.citrix.com", Issuer "Verizon Public SureServer CA G14-SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C92201DF6 for ; Thu, 5 May 2016 15:43:51 +0000 (UTC) (envelope-from prvs=9267fa6dd=roger.pau@citrix.com) X-IronPort-AV: E=Sophos;i="5.24,582,1454976000"; d="scan'208";a="351891656" Date: Thu, 5 May 2016 17:41:36 +0200 From: Roger Pau =?iso-8859-1?Q?Monn=E9?= To: Marcin Cieslak CC: Subject: Re: Booting Solaris 11.3 (was Re: Booting r298488 as Xen Dom0 may break ZFS pool?) Message-ID: <20160505154136.ry2jq7xfavej4esg@mac> References: <20160426074302.4i3rv7wd5ogg7ful@mac> <20160426093556.oxeh5qyafe3ro6xy@mac> <20160426112925.hmijqrxt52kyswfg@mac> <20160429075716.5mykxirogrlvc5pq@mac> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.6.0-neo (2016-04-07) X-DLP: MIA1 X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2016 15:43:52 -0000 On Sat, Apr 30, 2016 at 08:56:54PM +0000, Marcin Cieslak wrote: > On Fri, 29 Apr 2016, Roger Pau Monné wrote: > > > On Thu, Apr 28, 2016 at 08:01:23PM +0000, Marcin Cieslak wrote: > > > On Tue, 26 Apr 2016, Roger Pau Monné wrote: > > > > > > > On Tue, Apr 26, 2016 at 10:39:06AM +0000, Marcin Cieslak wrote: > > > > > By the way, I just managed to crash a whole machine by trying to > > > > > boot Solaris 11.3: > > > > > > > > > > # builder = "hvm" > > > > > memory = 2048 > > > > > vcpus = 1 > > > > > name = "Solaris0" > > > > > disk = [ 'file:/root/sol-11_3-text-x86.iso,6:cdrom,r', '/dev/zvol/zroot/solaris0,raw,hda,w' ] > > > > > kernel = "/root/xen/solaris/unix" > > > > > ramdisk = "/root/xen/solaris/boot_archive" > > > > > extra = "/platform/i86xpv/kernel/amd64/unix -B console=ttya,livemode=text" > > > > > #boot = "c" > > > > > usbdevice = 'tablet' > > > > > vnc = 1 > > > > > vnclisten = '0.0.0.0' > > > > > vif = [ 'bridge=bridge0' ] > > > > > > > > > > /root/xen/solaris/unix and /root/xen/solaris/boot_archive where extracted from sol-11_3-text-x86.iso > > > > > ("Intel text-only image"). > > > > > > > > I don't think you can boot Solaris as a PV guest anymore, you should instead > > > > boot it as a HVM guest. You will have to remove the kernel and ramdisk > > > > options and instead add builder="hvm" (that you have left commented out). > > > > > > However supported or not, I think it should not crash a whole host system?... > > > > Certainly. I assumed that you meant it crashed the VM, not the whole host. > > Can you please provide the trace of the crash? > > Apologies, forgot to let Xen keep VGA: > > http://marcincieslak.com/tmp/xencrash.png > > Manual OCR: > > FreeBSD/amd64 (o.saper.info) (xc0) > > login: (XEN) vmx.c:2464:d0v0 EPT violation 0x182 (-w-/---), gpa 0x0000010178f000 Hello, I've been able to debug this and found the issue. I have two patches that should be applied to FreeBSD in order to fix it, they can be found at: https://people.freebsd.org/~royger/privcmd_fixes/ Could you please give them a try? I have however been unable to boot a Solaris 11.3 guest under PV mode, but at least the host is not crashing anymore :). Roger. From owner-freebsd-virtualization@freebsd.org Thu May 5 16:17:05 2016 Return-Path: Delivered-To: freebsd-virtualization@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1200CB2EC3A for ; Thu, 5 May 2016 16:17:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 028C712D7 for ; Thu, 5 May 2016 16:17:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u45GH3Kc077669 for ; Thu, 5 May 2016 16:17:04 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-virtualization@FreeBSD.org Subject: [Bug 198344] [virtio] virtio-balloon does not work Date: Thu, 05 May 2016 16:17:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: vivek@khera.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-virtualization@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2016 16:17:05 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D198344 --- Comment #8 from Vick Khera --- Created attachment 169998 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D169998&action= =3Dedit graph of memory usage of my VM I've been watching my 10.3 VM for a while now, and I finally found evidence that it did release some memory. The VM environment is Proxmox VE, which is basically a fancy pants GUI on top of Debian linux + KVM. The memory usage graph is attached. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-virtualization@freebsd.org Thu May 5 22:21:03 2016 Return-Path: Delivered-To: freebsd-virtualization@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 00517B2FCC2 for ; Thu, 5 May 2016 22:21:03 +0000 (UTC) (envelope-from saper@saper.info) Received: from m.saper.info (m.saper.info [IPv6:2a01:4f8:a0:7383::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "m.saper.info", Issuer "Marcin Cieslak 2016" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 6F5C11EFA for ; Thu, 5 May 2016 22:21:02 +0000 (UTC) (envelope-from saper@saper.info) Received: from m.saper.info (saper@m.saper.info [IPv6:2a01:4f8:a0:7383::]) by m.saper.info (8.15.2/8.15.2) with ESMTPS id u45MKpF8019495 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 5 May 2016 22:20:51 GMT (envelope-from saper@saper.info) Received: from localhost (saper@localhost) by m.saper.info (8.15.2/8.15.2/Submit) with ESMTP id u45MKp8F019492; Thu, 5 May 2016 22:20:51 GMT (envelope-from saper@saper.info) X-Authentication-Warning: m.saper.info: saper owned process doing -bs Date: Thu, 5 May 2016 22:20:51 +0000 From: Marcin Cieslak To: =?ISO-8859-15?Q?Roger_Pau_Monn=E9?= cc: freebsd-virtualization@freebsd.org Subject: Re: Booting Solaris 11.3 (was Re: Booting r298488 as Xen Dom0 may break ZFS pool?) In-Reply-To: <20160505154136.ry2jq7xfavej4esg@mac> Message-ID: References: <20160426074302.4i3rv7wd5ogg7ful@mac> <20160426093556.oxeh5qyafe3ro6xy@mac> <20160426112925.hmijqrxt52kyswfg@mac> <20160429075716.5mykxirogrlvc5pq@mac> <20160505154136.ry2jq7xfavej4esg@mac> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2016 22:21:03 -0000 On Thu, 5 May 2016, Roger Pau Monné wrote: > On Sat, Apr 30, 2016 at 08:56:54PM +0000, Marcin Cieslak wrote: > > > Certainly. I assumed that you meant it crashed the VM, not the whole host. > > > Can you please provide the trace of the crash? > > > > Apologies, forgot to let Xen keep VGA: > > > > http://marcincieslak.com/tmp/xencrash.png > > > > Manual OCR: > > > > FreeBSD/amd64 (o.saper.info) (xc0) > > > > login: (XEN) vmx.c:2464:d0v0 EPT violation 0x182 (-w-/---), gpa 0x0000010178f000 > > Hello, > > I've been able to debug this and found the issue. I have two patches that > should be applied to FreeBSD in order to fix it, they can be found at: > > https://people.freebsd.org/~royger/privcmd_fixes/ > > Could you please give them a try? > I have however been unable to boot a Solaris 11.3 guest under PV mode, but > at least the host is not crashing anymore :). Thanks, I can confirm that the patches fix the crash for me. The half-life of PV Solaris is still under the microsecond. Btw. I have managed to get gdbsx going by replacing "/proc/xen/privcmd" with "/dev/xen/privcmd". Indeed, the state of Solaris is pretty bad: - Solaris 11.3 under HVM boots, but the installer complains there are no local disks (which is not true, even device nodes are there under /dev/dsk/ ... ) - OpenIndiana (OI-hipster-text-20160421.iso as HVM) hangs after printing out the kernel version message - SmartOS (smartos-20160428T170316Z.iso) seems to work at first, but after the initial configuration it cannot bring the network interface up because its link state is unknown (tried model=e1000 and the default Realtek): [root@master0 ~]# dladm show-phys LINK MEDIA STATE SPEED DUPLEX DEVICE e1000g0 Ethernet unknown 0 half e1000g0 Marcin From owner-freebsd-virtualization@freebsd.org Fri May 6 16:53:02 2016 Return-Path: Delivered-To: freebsd-virtualization@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D087EB2F6CF for ; Fri, 6 May 2016 16:53:02 +0000 (UTC) (envelope-from prvs=927f2c6f3=roger.pau@citrix.com) Received: from SMTP.CITRIX.COM (smtp.citrix.com [66.165.176.89]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "mail.citrix.com", Issuer "Verizon Public SureServer CA G14-SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7428B13A1 for ; Fri, 6 May 2016 16:53:02 +0000 (UTC) (envelope-from prvs=927f2c6f3=roger.pau@citrix.com) X-IronPort-AV: E=Sophos;i="5.24,587,1454976000"; d="scan'208";a="352133121" Date: Fri, 6 May 2016 18:52:53 +0200 From: Roger Pau =?iso-8859-1?Q?Monn=E9?= To: Marcin Cieslak CC: Subject: Re: Booting Solaris 11.3 (was Re: Booting r298488 as Xen Dom0 may break ZFS pool?) Message-ID: <20160506165253.o4sphxjp7ngmwu4w@mac> References: <20160426093556.oxeh5qyafe3ro6xy@mac> <20160426112925.hmijqrxt52kyswfg@mac> <20160429075716.5mykxirogrlvc5pq@mac> <20160505154136.ry2jq7xfavej4esg@mac> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.6.0-neo (2016-04-07) X-DLP: MIA2 X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2016 16:53:02 -0000 On Thu, May 05, 2016 at 10:20:51PM +0000, Marcin Cieslak wrote: > On Thu, 5 May 2016, Roger Pau Monné wrote: > > > On Sat, Apr 30, 2016 at 08:56:54PM +0000, Marcin Cieslak wrote: > > > > Certainly. I assumed that you meant it crashed the VM, not the whole host. > > > > Can you please provide the trace of the crash? > > > > > > Apologies, forgot to let Xen keep VGA: > > > > > > http://marcincieslak.com/tmp/xencrash.png > > > > > > Manual OCR: > > > > > > FreeBSD/amd64 (o.saper.info) (xc0) > > > > > > login: (XEN) vmx.c:2464:d0v0 EPT violation 0x182 (-w-/---), gpa 0x0000010178f000 > > > > Hello, > > > > I've been able to debug this and found the issue. I have two patches that > > should be applied to FreeBSD in order to fix it, they can be found at: > > > > https://people.freebsd.org/~royger/privcmd_fixes/ > > > > Could you please give them a try? > > > I have however been unable to boot a Solaris 11.3 guest under PV mode, but > > at least the host is not crashing anymore :). > > Thanks, I can confirm that the patches fix the crash for me. > The half-life of PV Solaris is still under the microsecond. > > Btw. I have managed to get gdbsx going by replacing "/proc/xen/privcmd" > with "/dev/xen/privcmd". > > Indeed, the state of Solaris is pretty bad: > > - Solaris 11.3 under HVM boots, but the installer complains there > are no local disks (which is not true, even device nodes are there > under /dev/dsk/ ... ) That's quite weird, under HVM disks are available using both the emulated and the PV interfaces, and Solaris 11.3 should certainly support the emulated ones. IIRC they are AHCI. > - OpenIndiana (OI-hipster-text-20160421.iso as HVM) hangs after printing > out the kernel version message > > - SmartOS (smartos-20160428T170316Z.iso) > seems to work at first, but after the initial configuration > it cannot bring the network interface up because its link > state is unknown (tried model=e1000 and the default Realtek): > > [root@master0 ~]# dladm show-phys > LINK MEDIA STATE SPEED DUPLEX DEVICE > e1000g0 Ethernet unknown 0 half e1000g0 Hm, AFAICT this doesn't look related to FreeBSD, but just to be sure, could you try the same with a Linux Dom0? Roger. From owner-freebsd-virtualization@freebsd.org Sat May 7 11:34:52 2016 Return-Path: Delivered-To: freebsd-virtualization@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 123E7B2FFF8 for ; Sat, 7 May 2016 11:34:52 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id E0D231323 for ; Sat, 7 May 2016 11:34:51 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 5D584155FA; Sat, 7 May 2016 11:34:51 +0000 (UTC) Date: Sat, 7 May 2016 11:34:51 +0000 To: freebsd-virtualization@freebsd.org From: "nvass-gmx.com (Nikos Vassiliadis)" Reply-to: D1944+333+b09c6235d993877b@reviews.freebsd.org Subject: [Differential] D1944: PF and VIMAGE fixes Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: Thread-Topic: D1944: PF and VIMAGE fixes X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: NDc2NzM0MzY4OTdiYThiNTU1MjY2ZDZmMTJiIFct0ts= MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.22 List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 May 2016 11:34:52 -0000 nvass-gmx.com added a comment. Thanks for taking a look Kristof, I believe all your points are valid. Thing is that all eventhandlers need a more thorough look. They don't work as they should; be it virtualized or not, be it a VIMAGE or GENERIC kernel. I am trying to take a look but I haven't thrown enough time to it. INLINE COMMENTS > @kristof wrote in sys/netpfil/pf/pf_if.c:130 > I don't understand why this is required. Surely if an ifnet lives in V_ifnet (so, lives in the current vnet) ifp->if_vnet is always going to be curvnet? You're correct. It is plain wrong REVISION DETAIL https://reviews.freebsd.org/D1944 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri Cc: ryan_timewasted.me, mmoll, javier_ovi_yahoo.com, farrokhi, julian, robak, freebsd-virtualization-list, freebsd-pf-list, freebsd-net-list