From owner-freebsd-xen@freebsd.org Mon May 2 18:09:58 2016 Return-Path: Delivered-To: freebsd-xen@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 07D34B2A548 for ; Mon, 2 May 2016 18:09:58 +0000 (UTC) (envelope-from prvs=923ebf709=roger.pau@citrix.com) Received: from SMTP02.CITRIX.COM (smtp02.citrix.com [66.165.176.63]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (Client CN "mail.citrix.com", Issuer "Verizon Public SureServer CA G14-SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BED7B176A for ; Mon, 2 May 2016 18:09:57 +0000 (UTC) (envelope-from prvs=923ebf709=roger.pau@citrix.com) X-IronPort-AV: E=Sophos;i="5.24,568,1454976000"; d="scan'208";a="357897224" Date: Mon, 2 May 2016 20:09:48 +0200 From: Roger Pau =?iso-8859-1?Q?Monn=E9?= To: Stefano Stabellini CC: , Subject: Re: [PATCH] xen/x86: don't lose event interrupts Message-ID: <20160502180948.vqegenfsrx6zonp3@mac> References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0-neo (2016-04-07) X-DLP: MIA1 X-BeenThere: freebsd-xen@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Discussion of the freebsd port to xen - implementation and usage List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 May 2016 18:09:58 -0000 On Thu, Apr 21, 2016 at 02:34:25PM +0100, Stefano Stabellini wrote: > xen/x86: don't lose event interrupts > > On slow platforms with unreliable TSC, such as QEMU emulated machines, > it is possible for the FreeBSD kernel to request the next event in the > past. In that case, in the current implementation of > xentimer_vcpu_start_timer, we simply return -ETIME. To be precise Xen > returns -ETIME and we pass it on. As a consequence we need to loop > around to function to make sure that the timer is properly set. > > Instead it is better to always ask the hypervisor for a timer event, > even if the timeout is past. To do that, remove the VCPU_SSHOTTMR_future > flag. > > Signed-off-by: Stefano Stabellini Thanks, it's now committed: https://svnweb.freebsd.org/base?view=revision&revision=298926 Roger.