From owner-svn-doc-user@freebsd.org Sun Mar 6 22:53:39 2016 Return-Path: Delivered-To: svn-doc-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9331DAC2793 for ; Sun, 6 Mar 2016 22:53:39 +0000 (UTC) (envelope-from jgh@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 52CD7F5D; Sun, 6 Mar 2016 22:53:39 +0000 (UTC) (envelope-from jgh@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u26Mrc1C063578; Sun, 6 Mar 2016 22:53:38 GMT (envelope-from jgh@FreeBSD.org) Received: (from jgh@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u26MrcPD063577; Sun, 6 Mar 2016 22:53:38 GMT (envelope-from jgh@FreeBSD.org) Message-Id: <201603062253.u26MrcPD063577@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jgh set sender to jgh@FreeBSD.org using -f From: Jason Helfman Date: Sun, 6 Mar 2016 22:53:38 +0000 (UTC) To: doc-committers@freebsd.org, svn-doc-user@freebsd.org Subject: svn commit: r48351 - user/jgh/committers-guide X-SVN-Group: doc-user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-doc-user@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for doc experimental trees List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Mar 2016 22:53:39 -0000 Author: jgh Date: Sun Mar 6 22:53:38 2016 New Revision: 48351 URL: https://svnweb.freebsd.org/changeset/doc/48351 Log: - wip Modified: user/jgh/committers-guide/article.xml Modified: user/jgh/committers-guide/article.xml ============================================================================== --- user/jgh/committers-guide/article.xml Sun Mar 6 20:38:56 2016 (r48350) +++ user/jgh/committers-guide/article.xml Sun Mar 6 22:53:38 2016 (r48351) @@ -3056,55 +3056,55 @@ Subscribers: - The Revision Title is - mandatory. This is a one line description of the - change. - - - - The Summary is optional. - However, this should contain verbatim content of the - commit message to be used when submitting the - change. - - - - The Test Plan is optional. - Describe how to test the patch and how the reviewer - may test it. If it is difficult to draft a plan, - please reconsider. - - - - The Reviewers is optional. - However, &os; committers that are expected to review - the patch may be listed here. If such committers have - accounts on Phabricator, they will automatically be - notified of your submission. Reviewers may be added - by their nickname: + + The Revision Title is + mandatory. This is a one line description of the + change. + + + + The Summary is optional. + However, this should contain verbatim content of the + commit message to be used when submitting the + change. + + + + The Test Plan is optional. + Describe how to test the patch and how the reviewer + may test it. If it is difficult to draft a plan, + please reconsider. + + + + The Reviewers is optional. + However, &os; committers that are expected to review + the patch may be listed here. If such committers have + accounts on Phabricator, they will automatically be + notified of your submission. Reviewers may be added + by their nickname: &prompt.user; arc diff --reviewers nick or by project: &prompt.user; arc diff --reviewers #portmgr - + - - Subscribers may be individuals, project groups, - and mailing lists. - - - - The Differential Revision cannot be added here, - however it must be in the svn commit message. - - + + Subscribers may be individuals, project groups, + and mailing lists. + + + + The Differential Revision cannot be added here, + however it must be in the svn commit message. + + @@ -3117,6 +3117,34 @@ Subscribers: + Create a Revision via Web Interface + + Revisions can be created without having + arc installed by uploading a patch + via the web interface. Patches can be created by + diff, + svn, + git + or other tools. + + To make reviewing changes easier, always include as much + context as possible with a diff. Phabricator will + automatically reduce the context in the default display and + when sending emails, but it allows the full context to be + displayed on demand in the web interface. + + To create a full diff, use one of the following + commands: + + + &prompt.root; git diff -U999999 other-branch + + &prompt.root; svn diff --diff-cmd=diff -x -U999999 + + + From owner-svn-doc-user@freebsd.org Tue Mar 8 01:01:59 2016 Return-Path: Delivered-To: svn-doc-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6405EAC74C6 for ; Tue, 8 Mar 2016 01:01:59 +0000 (UTC) (envelope-from jgh@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1CF07EC6; Tue, 8 Mar 2016 01:01:59 +0000 (UTC) (envelope-from jgh@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u2811whM048437; Tue, 8 Mar 2016 01:01:58 GMT (envelope-from jgh@FreeBSD.org) Received: (from jgh@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u2811wto048436; Tue, 8 Mar 2016 01:01:58 GMT (envelope-from jgh@FreeBSD.org) Message-Id: <201603080101.u2811wto048436@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jgh set sender to jgh@FreeBSD.org using -f From: Jason Helfman Date: Tue, 8 Mar 2016 01:01:58 +0000 (UTC) To: doc-committers@freebsd.org, svn-doc-user@freebsd.org Subject: svn commit: r48357 - user/jgh/committers-guide X-SVN-Group: doc-user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-doc-user@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for doc experimental trees List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2016 01:01:59 -0000 Author: jgh Date: Tue Mar 8 01:01:57 2016 New Revision: 48357 URL: https://svnweb.freebsd.org/changeset/doc/48357 Log: - wip Modified: user/jgh/committers-guide/article.xml Modified: user/jgh/committers-guide/article.xml ============================================================================== --- user/jgh/committers-guide/article.xml Mon Mar 7 19:00:54 2016 (r48356) +++ user/jgh/committers-guide/article.xml Tue Mar 8 01:01:57 2016 (r48357) @@ -3144,6 +3144,83 @@ Subscribers: + + + + Go to + https://reviews.freebsd.org/differential/ + + + + Click Create Diff in the upper + right-hand corner. + + + + Paste the text diff or upload the patch file. + + + + Leave the drop down on + Create a new Revision and click + Continue. + + + + Enter a descriptive title and summary. + + + + Add reviewers and mailing lists that you want to be + included in the review. Mailing lists are added as + subscribers: + + + + + + + + + + Click Save. + + + + To submit an updated patch: + + + + + Go to + https://reviews.freebsd.org/differential/ + + + + Click Create Diff in the upper + right-hand corner. + + + + Paste or upload the updated diff. + + + + Select the review you want to update from the + Attach To dropdown and click + Continue. + + + + Click Save. + + + From owner-svn-doc-user@freebsd.org Thu Mar 10 17:49:07 2016 Return-Path: Delivered-To: svn-doc-user@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A7085ACBF54 for ; Thu, 10 Mar 2016 17:49:07 +0000 (UTC) (envelope-from jgh@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 781BFAF4; Thu, 10 Mar 2016 17:49:07 +0000 (UTC) (envelope-from jgh@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u2AHn64L044029; Thu, 10 Mar 2016 17:49:06 GMT (envelope-from jgh@FreeBSD.org) Received: (from jgh@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u2AHn6DP044028; Thu, 10 Mar 2016 17:49:06 GMT (envelope-from jgh@FreeBSD.org) Message-Id: <201603101749.u2AHn6DP044028@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jgh set sender to jgh@FreeBSD.org using -f From: Jason Helfman Date: Thu, 10 Mar 2016 17:49:06 +0000 (UTC) To: doc-committers@freebsd.org, svn-doc-user@freebsd.org Subject: svn commit: r48365 - user/jgh/committers-guide X-SVN-Group: doc-user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-doc-user@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for doc experimental trees List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2016 17:49:07 -0000 Author: jgh Date: Thu Mar 10 17:49:06 2016 New Revision: 48365 URL: https://svnweb.freebsd.org/changeset/doc/48365 Log: - wip Modified: user/jgh/committers-guide/article.xml Modified: user/jgh/committers-guide/article.xml ============================================================================== --- user/jgh/committers-guide/article.xml Thu Mar 10 10:18:54 2016 (r48364) +++ user/jgh/committers-guide/article.xml Thu Mar 10 17:49:06 2016 (r48365) @@ -3148,7 +3148,6 @@ Subscribers: - Go to @@ -3222,6 +3221,26 @@ Subscribers: + Address Revision Feedback + + If a reviewer does not accept the change and asks + for a modification to the, edit the files in the local + client accordingly. + + While doing so, fill in replies to any line-specific + comments that a reviewer may have left. Saving replies does + not cause them to be sent out. You must click the + Submit button for these to be sent + out. + + After addressing all comments, upload the patch. + path should included all paths that are part of the review, + even if their contents haven't changed as part of this + update. + +