From owner-svn-src-all@freebsd.org Sun Apr 24 01:38:46 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DCA3FB11B8B; Sun, 24 Apr 2016 01:38:46 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AE5821A0D; Sun, 24 Apr 2016 01:38:46 +0000 (UTC) (envelope-from jhibbits@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u3O1cj0J002617; Sun, 24 Apr 2016 01:38:45 GMT (envelope-from jhibbits@FreeBSD.org) Received: (from jhibbits@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u3O1cj1i002616; Sun, 24 Apr 2016 01:38:45 GMT (envelope-from jhibbits@FreeBSD.org) Message-Id: <201604240138.u3O1cj1i002616@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jhibbits set sender to jhibbits@FreeBSD.org using -f From: Justin Hibbits Date: Sun, 24 Apr 2016 01:38:45 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r298526 - head/sys/contrib/ncsw/user/env X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Apr 2016 01:38:47 -0000 Author: jhibbits Date: Sun Apr 24 01:38:45 2016 New Revision: 298526 URL: https://svnweb.freebsd.org/changeset/base/298526 Log: Zero the newly allocated spinlock. Not sure how this worked testing with DIAGNOSTIC set, but with it disabled this fails due to the spinlock being "initialized" with 0xdeadc0de. Modified: head/sys/contrib/ncsw/user/env/xx.c Modified: head/sys/contrib/ncsw/user/env/xx.c ============================================================================== --- head/sys/contrib/ncsw/user/env/xx.c Sat Apr 23 22:57:54 2016 (r298525) +++ head/sys/contrib/ncsw/user/env/xx.c Sun Apr 24 01:38:45 2016 (r298526) @@ -561,7 +561,7 @@ XX_InitSpinlock(void) { struct mtx *m; - m = malloc(sizeof(*m), M_NETCOMMSW, M_NOWAIT); + m = malloc(sizeof(*m), M_NETCOMMSW, M_NOWAIT | M_ZERO); if (!m) return (0);