From owner-svn-src-all@freebsd.org Sun Oct 9 03:20:59 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BC09EAF7D05; Sun, 9 Oct 2016 03:20:59 +0000 (UTC) (envelope-from allanjude@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8815C1A40; Sun, 9 Oct 2016 03:20:59 +0000 (UTC) (envelope-from allanjude@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u993KwZS008495; Sun, 9 Oct 2016 03:20:58 GMT (envelope-from allanjude@FreeBSD.org) Received: (from allanjude@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id u993KwVD008493; Sun, 9 Oct 2016 03:20:58 GMT (envelope-from allanjude@FreeBSD.org) Message-Id: <201610090320.u993KwVD008493@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: allanjude set sender to allanjude@FreeBSD.org using -f From: Allan Jude Date: Sun, 9 Oct 2016 03:20:58 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r306896 - head/sbin/ifconfig X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Oct 2016 03:20:59 -0000 Author: allanjude Date: Sun Oct 9 03:20:58 2016 New Revision: 306896 URL: https://svnweb.freebsd.org/changeset/base/306896 Log: Fix spurious white space introduced in r301059 r301059 accidently introduced a subtle change for point to point interfaces where an extra space is inserted before the netmask. This can cause issues for scripts that parse ifconfig output. Submitted by: Kevin Bowling Reviewed by: hiren MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D8199 Modified: head/sbin/ifconfig/af_inet.c head/sbin/ifconfig/af_inet6.c Modified: head/sbin/ifconfig/af_inet.c ============================================================================== --- head/sbin/ifconfig/af_inet.c Sun Oct 9 01:58:29 2016 (r306895) +++ head/sbin/ifconfig/af_inet.c Sun Oct 9 03:20:58 2016 (r306896) @@ -88,7 +88,7 @@ in_status(int s __unused, const struct i sin = (struct sockaddr_in *)ifa->ifa_dstaddr; if (sin == NULL) sin = &null_sin; - printf(" --> %s ", inet_ntoa(sin->sin_addr)); + printf(" --> %s", inet_ntoa(sin->sin_addr)); } sin = (struct sockaddr_in *)ifa->ifa_netmask; Modified: head/sbin/ifconfig/af_inet6.c ============================================================================== --- head/sbin/ifconfig/af_inet6.c Sun Oct 9 01:58:29 2016 (r306895) +++ head/sbin/ifconfig/af_inet6.c Sun Oct 9 03:20:58 2016 (r306896) @@ -237,7 +237,7 @@ in6_status(int s __unused, const struct if (error != 0) inet_ntop(AF_INET6, &sin->sin6_addr, addr_buf, sizeof(addr_buf)); - printf(" --> %s ", addr_buf); + printf(" --> %s", addr_buf); } }