From owner-freebsd-bugs@freebsd.org Sun Nov 26 04:51:51 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 44F38DFD41B for ; Sun, 26 Nov 2017 04:51:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 13CEC7DE2F for ; Sun, 26 Nov 2017 04:51:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vAQ4poba084294 for ; Sun, 26 Nov 2017 04:51:50 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 223876] [PATCH] swapinfo/pstat -s alignment is broken with swap on zvols and long paths Date: Sun, 26 Nov 2017 04:51:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ciml@nuxi.ca X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Nov 2017 04:51:51 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223876 Bug ID: 223876 Summary: [PATCH] swapinfo/pstat -s alignment is broken with swap on zvols and long paths Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: ciml@nuxi.ca Keywords: patch Created attachment 188289 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D188289&action= =3Dedit mentioned diff Hi, After using pstat(8) to see what my zvol swap looked like, the output was l= ike this: Device 1K-blocks Used Avail Capacity /dev/zvol/rpool/swap 8388608 0 8388608 0% /dev/md99 4000 0 4000 0% Total 8392608 0 8392608 0% I was a bit annoyed. I decided to simply align them to a total of 72 chars. I think it's plenty for file names, and it made the output closer to what I expected. Device 1K-blocks Used Avail Capacity /dev/zvol/rpool/swap 8388608 0 8388608 0% /dev/md99 4000 0 4000 0% Total 8392608 0 8392608 0% It might not be the most flexible solution, but I personally think it's ple= nty, as filenames directing to swap usually wouldn't be much longer than this. Attached is a proposed diff. I also took the liberty of fixing a few style bugs. Namely, static flags being explicitly initialized to 0 while others weren't, although they were all tested, and a flag being set to 1 with ++var instead of using var =3D 1 as with all the others. Good day. --=20 You are receiving this mail because: You are the assignee for the bug.=