From owner-freebsd-dtrace@freebsd.org Sun May 21 20:15:57 2017 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 950AED77C8B for ; Sun, 21 May 2017 20:15:57 +0000 (UTC) (envelope-from longwitz@incore.de) Received: from dss.incore.de (dss.incore.de [195.145.1.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5CEF1922 for ; Sun, 21 May 2017 20:15:56 +0000 (UTC) (envelope-from longwitz@incore.de) Received: from secmail.incore.de (inetdssm.dmz [10.11.0.4]) by dss.incore.de (Postfix) with ESMTP id 77A2767989; Sun, 21 May 2017 22:15:48 +0200 (CEST) Received: from lolap.longwitz (87-57-220-129-dynamic.dk.customer.tdc.net [87.57.220.129]) by secmail.incore.de (Postfix) with ESMTPS id 2A66C6797C; Sun, 21 May 2017 22:15:48 +0200 (CEST) Message-ID: <5921F56F.7090509@incore.de> Date: Sun, 21 May 2017 22:15:43 +0200 From: Andreas Longwitz User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:15.0) Gecko/20120917 Thunderbird/15.0.1 MIME-Version: 1.0 To: Mark Johnston CC: Domagoj Stolfa , Samuel Lepetit , freebsd-dtrace@freebsd.org Subject: Re: fbt:kernel:breadn_flags:entry): invalid address (0x0) in action #7 References: <591E01F5.8080208@incore.de> <6A020677-BC76-41E1-8372-10B7962F4EDE@apple.com> <20170518204534.GA37126@wraith> <20170518235207.GB37643@wkstn-mjohnston.west.isilon.com> In-Reply-To: <20170518235207.GB37643@wkstn-mjohnston.west.isilon.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 May 2017 20:15:57 -0000 Hello, thanks for answer >>> I suspect the easiest way here is just to check that your credential in args[6] is non-null in a predicate. >> >> yes, you would likely have to enable the probe twice -- once with a non-null >> argument and once with a null argument (if required). My problem is: The probe fbt:kernel:breadn_flags:entry should fire in the case args[6] == 0, the case args[6] != 0 works but is not important to me. > On FreeBSD head you can also use if-statements. :) > > fbt:kernel:breadn_flags:entry > { > if (args[6] != NULL) { > ... > } else { > ... > } > } Does this mean, my problem is solved in head even with a better if-syntax and no chance in V10 ? From owner-freebsd-dtrace@freebsd.org Sun May 21 21:02:03 2017 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5ED96D7748A for ; Sun, 21 May 2017 21:02:03 +0000 (UTC) (envelope-from domagoj.stolfa@gmail.com) Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com [IPv6:2a00:1450:400c:c09::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E3D57C4F for ; Sun, 21 May 2017 21:02:02 +0000 (UTC) (envelope-from domagoj.stolfa@gmail.com) Received: by mail-wm0-x233.google.com with SMTP id e127so13860756wmg.1 for ; Sun, 21 May 2017 14:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Tab8N8gUB+5IiL2hLsvFbbax4b/91OswfkoYVcIv01A=; b=jhIQixkUrrWoDobfWEHMV3i2Ar2HyewkWJ5eC1Tibc0DNu7keMkb2NP80bwMXGccm7 bUUQajqqJ+EVnVg4w2Kio0e+lBaCV0L5CqWGHAwNILfzvzqE2dBAk2k6Dd7KsiypGpK3 riJDsdsfoFBLCQmwpIKNzdcNbUvTt0Ew+AXLOZxvgU2DML/FxOk/3keTA8AQLdG/lDVq MiR5PjVOwf9qUYx+rts+eW2g+Y5lZc4vAo+lMSTUnMMfFR6OSDm04mS1QgNckT/IMbIQ ZZ+bwqUqXUyaLqhJu6rGAfVJByjffsP4Zp4cGQGY9zP9Imd2jhU03v93sszmcPVyOvRI zHbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Tab8N8gUB+5IiL2hLsvFbbax4b/91OswfkoYVcIv01A=; b=cGOpXJdUbVfB6nyG+rJxa8Jk2GyOnQYq6hW3Nnxu+lHz3N5O7ezScjqY+3vCdK0CW1 QxtNGJCTyxHd8ufINJPSzYCOCYEvjfkicq7WVuF0tXp3mhmoLJ1a/JWOT02kCXXLl7Q/ okK70Zj9XWJsi6lciVmhLYV2rpRr65cgkIA8eONKKK/hn6X3wQpCmoWZzkz+Vj42f6wI w1199edq2JnlnqBYllh9c8ZnZUVjRBwNHEaTR26TP6+i9/FXHoM01sWfJh4MOyszFupM ZYmd0sUv/+K7gdlTIiyg8eNG74OoQ4eyn64b/0S0ZsZrcDpIeUNZliaggGJIqt6qC5em LP2A== X-Gm-Message-State: AODbwcDBSQIdZ4DlX2ZJsozGL1F/Yx2V50r8783ZFbhPx0oDpbsDW0rE awOTndjlUxBNmTxA45Y= X-Received: by 10.28.65.65 with SMTP id o62mr11114780wma.14.1495400521218; Sun, 21 May 2017 14:02:01 -0700 (PDT) Received: from vulture.cbsd.home ([213.149.61.150]) by smtp.gmail.com with ESMTPSA id k22sm10242926wrc.12.2017.05.21.14.02.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 21 May 2017 14:02:00 -0700 (PDT) Date: Sun, 21 May 2017 23:01:58 +0200 From: Domagoj Stolfa To: Andreas Longwitz Cc: freebsd-dtrace@freebsd.org Subject: Re: fbt:kernel:breadn_flags:entry): invalid address (0x0) in action #7 Message-ID: <20170521210158.GA43079@vulture.cbsd.home> References: <591E01F5.8080208@incore.de> <6A020677-BC76-41E1-8372-10B7962F4EDE@apple.com> <20170518204534.GA37126@wraith> <20170518235207.GB37643@wkstn-mjohnston.west.isilon.com> <5921F56F.7090509@incore.de> <20170521210051.GA43039@vulture.cbsd.home> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KsGdsel6WgEHnImy" Content-Disposition: inline In-Reply-To: <20170521210051.GA43039@vulture.cbsd.home> User-Agent: Mutt/1.8.2 (2017-04-18) X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 May 2017 21:02:03 -0000 --KsGdsel6WgEHnImy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, > My problem is: The probe fbt:kernel:breadn_flags:entry should fire in=20 > the case args[6] =3D=3D 0, the case args[6] !=3D 0 works but is not impor= tant=20 > to me. =20 What you want is: fbt:kernel:breadn_flags:entry /args[6] =3D=3D 0/ { ... } Hope it helps! --=20 Best regards, Domagoj Stolfa --KsGdsel6WgEHnImy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEHQB+y96lmmv+IXofwxT+ikb0YU4FAlkiAEYACgkQwxT+ikb0 YU7jwAgAxq+GNzGbz9dD2mlmMJfEMa+mYCW5YNpEnPN4LDxV+tV3q2GI523iIPF5 1mKCyZwk/dGJ3sgaXyZQpS8RBq5+Jv6gwJCE3QOzhkZMrhNn5xhujf49Df00le2S VITxT5u6amGd8Tz7NCvW+ynaft4EHGbHwQ/4GuEkpGDXItFpi+CTx73WbGgWvRIv pYH5DZXJH23HkjC0Ow5OS10XXH2WydG3eQ2yuxvFVLFBoKBqvpgvrRr4D+x4tzP7 fH+8ufO/V8aQmCIPkYiydPSeIHmIvd6hZGcyZ21Zrtkmyej9fLMX+0A+UhIBpIgb YVrZ6bUFhc1enP7vLA0uC1+uY8lBOA== =j+5e -----END PGP SIGNATURE----- --KsGdsel6WgEHnImy-- From owner-freebsd-dtrace@freebsd.org Mon May 22 09:46:18 2017 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5BBB5D78E8D for ; Mon, 22 May 2017 09:46:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3FBCE15E7 for ; Mon, 22 May 2017 09:46:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v4M9kI5b020054 for ; Mon, 22 May 2017 09:46:18 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-dtrace@FreeBSD.org Subject: [Bug 219451] [dtrace] Certain llquantize() parameters trigger assertion Date: Mon, 22 May 2017 09:46:18 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: fk@fabiankeil.de X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter cc attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 May 2017 09:46:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D219451 Bug ID: 219451 Summary: [dtrace] Certain llquantize() parameters trigger assertion Product: Base System Version: 11.0-STABLE Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: fk@fabiankeil.de CC: freebsd-dtrace@FreeBSD.org Created attachment 182796 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D182796&action= =3Dedit libdtrace: Prevent an assertion from triggering with certain llquantize() parameters On a system based on r318579/0c33b79a4 the following dtrace command reliably triggers an assertion when printing output: fk@t520 ~ $sudo dtrace -n 'syscall::read:return /execname =3D=3D "privoxy"/ { @[execname] =3D llquantize(arg0, 100, 0, 10, 100); @m =3D max(= arg0)}' [...] 9800 | 0 9900 | 0 10000 |@@@@@@@@@@@@@@@@@@@@ 37 20000 | 0 Assertion failed: (value < next), file /usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/lib/libdtrace= /common/dt_consume.c, line 1083. Abort trap (gdb) where #0 0x00000008011effda in thr_kill () from /lib/libc.so.7 #1 0x00000008011effa4 in __raise (s=3D6) at /usr/src/lib/libc/gen/raise.c:52 #2 0x00000008011eff19 in abort () at /usr/src/lib/libc/stdlib/abort.c:65 #3 0x000000080088c3b2 in __assert (expr=3D0x8008d3172 "value < ne= xt", file=3D0x8008d3078 "/usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/lib/libdtrac= e/common/dt_consume.c", line=3D1083) at /usr/src/cddl/lib/libdtrace/../../../cddl/compat/opensolaris/include/assert= .h:56 #4 0x000000080088c190 in dt_print_llquantize (dtp=3D0x802633000, fp=3D0x8014c37e8, addr=3D0x80269a110, size=3D7840, normal=3D1) at /usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/lib/libdtrace= /common/dt_consume .c:1083 #5 0x000000080088e37d in dt_print_datum (dtp=3D0x802633000, fp=3D0x8014c37e8, rec=3D0x8026900e8, addr=3D0x80269a110 "d", size=3D7848, aggdata=3D0x802690150, normal=3D1, pd=3D0x7fffffffe750) at /usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/lib/libdtrace= /common/dt_consume.c:2211 #6 0x000000080088dc12 in dt_print_aggs (aggsdata=3D0x7fffffffe630, naggvars=3D1, arg=3D0x7fffffffe750) at /usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/lib/libdtrace= /common/dt_consume.c:2313 #7 0x000000080088e6cf in dt_print_agg (aggdata=3D0x802690150, arg=3D0x7fffffffe750) at /usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/lib/libdtrace= /common/dt_consume.c:2361 #8 0x0000000800895f8b in dt_aggregate_walk_sorted (dtp=3D0x802633= 000, func=3D0x80088e610 , arg=3D0x7fffffffe750, sfunc=3D0x0) at /usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/lib/libdtrace= /common/dt_aggregate.c:1585 #9 0x0000000800895d39 in dtrace_aggregate_walk_sorted (dtp=3D0x802633000, func=3D0x80088e610 , arg=3D0x7fffffffe750) at /usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/lib/libdtrace= /common/dt_aggregate.c:1605 #10 0x0000000800897f12 in dtrace_aggregate_print (dtp=3D0x80263300= 0, fp=3D0x8014c37e8, func=3D0x800895d10 ) at /usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/lib/libdtrace= /common/dt_aggregate.c:2130 #11 0x0000000000403a5e in main (argc=3D, argv=3D) at /usr/src/cddl/usr.sbin/dtrace/../../../cddl/contrib/opensolaris/cmd/dtrace/= dtrace.c:2005 (gdb) f 4 #4 0x000000080088c190 in dt_print_llquantize (dtp=3D0x802633000, fp=3D0x8014c37e8, addr=3D0x80269a110, size=3D7840, normal=3D1) at /usr/src/cddl/lib/libdtrace/../../../cddl/contrib/opensolaris/lib/libdtrace= /common/dt_consume .c:1083 1083 assert(value < next); (gdb) p step $2915 =3D 77662796314522419 (gdb) p value $2916 =3D 7834326075677972872 (gdb) p next $2917 =3D 7766279631452241920 It works as expected when replacing the 10 with a 5. Various other parameter combinations work as expected as well and I've used similar commands for weeks without issues. The problem is reproducible with other execnames as long as the probe fires. The "@m =3D max(arg0)" part isn't required to trigger the assertion but I o= nly noticed it after already patching the system where libdtrace is build with reduced optimizations. The attached patch prevents the assertion from triggering but may not be the best solution. The code flow in dt_print_llquantize() seems strange to me and maybe the loop should break if "bin" reaches "last_bin" instead. My impression is that it does a bunch of cycles at the end without doing meaningful work. Obtained from: ElectroBSD --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-dtrace@freebsd.org Mon May 22 11:44:02 2017 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5CA57D7629B for ; Mon, 22 May 2017 11:44:02 +0000 (UTC) (envelope-from longwitz@incore.de) Received: from dss.incore.de (dss.incore.de [195.145.1.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 239B51281 for ; Mon, 22 May 2017 11:44:01 +0000 (UTC) (envelope-from longwitz@incore.de) Received: from secmail.incore.de (inetdssm.dmz [10.11.0.4]) by dss.incore.de (Postfix) with ESMTP id 2FECE67986; Mon, 22 May 2017 13:43:59 +0200 (CEST) Received: from lolap.longwitz (87-57-220-129-dynamic.dk.customer.tdc.net [87.57.220.129]) by secmail.incore.de (Postfix) with ESMTPS id 045CF6797A; Mon, 22 May 2017 13:43:58 +0200 (CEST) Message-ID: <5922CEFC.8020306@incore.de> Date: Mon, 22 May 2017 13:43:56 +0200 From: Andreas Longwitz User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:15.0) Gecko/20120917 Thunderbird/15.0.1 MIME-Version: 1.0 To: Domagoj Stolfa CC: freebsd-dtrace@freebsd.org Subject: Re: fbt:kernel:breadn_flags:entry): invalid address (0x0) in action #7 References: <591E01F5.8080208@incore.de> <6A020677-BC76-41E1-8372-10B7962F4EDE@apple.com> <20170518204534.GA37126@wraith> <20170518235207.GB37643@wkstn-mjohnston.west.isilon.com> <5921F56F.7090509@incore.de> <20170521210051.GA43039@vulture.cbsd.home> In-Reply-To: <20170521210051.GA43039@vulture.cbsd.home> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 May 2017 11:44:02 -0000 Hello, >> My problem is: The probe fbt:kernel:breadn_flags:entry should fire in >> the case args[6] == 0, the case args[6] != 0 works but is not important >> to me. > > What you want is: > > fbt:kernel:breadn_flags:entry > /args[6] == 0/ > { > ... > } Thats exactly what I did. > > Hope it helps! > No, the error messaes "invalid address (0x0)" appears. Regards From owner-freebsd-dtrace@freebsd.org Mon May 22 12:05:08 2017 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 352ABD7778F for ; Mon, 22 May 2017 12:05:08 +0000 (UTC) (envelope-from domagoj.stolfa@gmail.com) Received: from mail-wr0-x230.google.com (mail-wr0-x230.google.com [IPv6:2a00:1450:400c:c0c::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B4CE313A0 for ; Mon, 22 May 2017 12:05:07 +0000 (UTC) (envelope-from domagoj.stolfa@gmail.com) Received: by mail-wr0-x230.google.com with SMTP id z52so37199192wrc.2 for ; Mon, 22 May 2017 05:05:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=oRZZbLukctXyiRhGMhIuV9hUhREgj6KcrRomsk4H9eA=; b=PW3RqDfuQ690fhIRb2lhtWOnfi74TSzVBRaN+hxve2cxxM7YmHGgUulZCeUqrnozKX KTuQ7k05Im0p9xXBY44FqeeXk4POxM8L8QjsoO/xE7kjRR7iuKQsOgVhfrQoiCOtSLm6 q/HslIgj62dLuD4j2ctR3HdsrFZJfN4kUw3lMLrGY54q3k51qRCFnlIPtMdqtVmCc4DY 2c3UdMbuMYf72gLR+CNo7tyNzb+cArhgMLb/WWeWgOv183G91BJPlNS6C409EmveLnsK 8OBInJ3OAitIpWdZg5WHp4iz5+oj1gxjU0kOBGHIWzorHSjJF+efcmHDcr0wmwyZRfE8 6UPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oRZZbLukctXyiRhGMhIuV9hUhREgj6KcrRomsk4H9eA=; b=PGXswRW2B6s5datoiyLL8eXmjGKNE4YkldBWIVf+Q+ptImg2Hk9LOryfM6vsVltui6 JZgBCG2U8mggny70og2hHAVdEsfbwEfbsIMOBiH/E5UF3l5Am71UKWyLHOf9Wo94+ZTQ OKlk8uv5QLkwzhmEyuKNlDJdj43vZlMGJHHSSK9eF3ccXReYz0rtal5B9yspalILovNX 1IztnuFUWHedAtNaVHe5T11Tajn1hPiXivkZxzV++k6Jzd15WgsXb5Dxp64j76c3XHdp B+aIe4taduvEXFOIF2rvkfnMJUN5SvY2X9Oss3uk3g3N9Xcf6kyYFUacdiicurEjauhZ +Hnw== X-Gm-Message-State: AODbwcDuw9CxD/6RgQZ40Al5t00cQvaIhhmveYq2RP4Bm5pVu0S2b/6A KYbxLKIwqxSq9UMzHZo= X-Received: by 10.223.161.65 with SMTP id r1mr12828651wrr.114.1495454706162; Mon, 22 May 2017 05:05:06 -0700 (PDT) Received: from vulture.cbsd.home ([213.149.61.150]) by smtp.gmail.com with ESMTPSA id w136sm19405184wmd.13.2017.05.22.05.05.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 May 2017 05:05:05 -0700 (PDT) Date: Mon, 22 May 2017 14:05:03 +0200 From: Domagoj Stolfa To: Andreas Longwitz Cc: freebsd-dtrace@freebsd.org Subject: Re: fbt:kernel:breadn_flags:entry): invalid address (0x0) in action #7 Message-ID: <20170522120503.GB46682@vulture.cbsd.home> References: <591E01F5.8080208@incore.de> <6A020677-BC76-41E1-8372-10B7962F4EDE@apple.com> <20170518204534.GA37126@wraith> <20170518235207.GB37643@wkstn-mjohnston.west.isilon.com> <5921F56F.7090509@incore.de> <20170521210051.GA43039@vulture.cbsd.home> <5922CEFC.8020306@incore.de> <20170522120326.GA45031@vulture.cbsd.home> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hHWLQfXTYDoKhP50" Content-Disposition: inline In-Reply-To: <20170522120326.GA45031@vulture.cbsd.home> User-Agent: Mutt/1.8.2 (2017-04-18) X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 May 2017 12:05:08 -0000 --hHWLQfXTYDoKhP50 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, > Thats exactly what I did. Could you please supply the full script please? It might give some clue as = to where the problem is. --=20 Best regards, Domagoj Stolfa --hHWLQfXTYDoKhP50 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEHQB+y96lmmv+IXofwxT+ikb0YU4FAlki0+4ACgkQwxT+ikb0 YU5/lwf+KVRTHUgi2lFr57OabXtNa2GAfEN2EHn9c5wfXBF+v5Da9i5Vr8KBymoJ 8rm0AeO41sF5RI4xz/fk432QTmkzTAJ45fW7MRG16vyH1ldTEhbmFuqf7S2d5Lf/ iQznL+Lz+NPiBggzMvqizlQlFUZ/cViW8LlxwkXg25nDMBBUH+K7zK9spZHzq/74 14QcPl5a/0wBOw6Z2jObez4bjyotN9BaPujri1r0TAFkGKT0p/g9whCaKRQ8wj/X ySDjMHoNEI3qAZo2cCIQGSKSpNz2YFZq3FzCAQwnMXSm91UoWKbo8edesYIIhyje AcS18QZchxhtsJlLAniW2ojdxCipWQ== =PKzA -----END PGP SIGNATURE----- --hHWLQfXTYDoKhP50-- From owner-freebsd-dtrace@freebsd.org Tue May 23 20:25:43 2017 Return-Path: Delivered-To: freebsd-dtrace@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 53525D7B091 for ; Tue, 23 May 2017 20:25:43 +0000 (UTC) (envelope-from longwitz@incore.de) Received: from dss.incore.de (dss.incore.de [195.145.1.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1B6B416E3 for ; Tue, 23 May 2017 20:25:42 +0000 (UTC) (envelope-from longwitz@incore.de) Received: from secmail.incore.de (inetdssm.dmz [10.11.0.4]) by dss.incore.de (Postfix) with ESMTP id B174F67A4A; Tue, 23 May 2017 22:25:33 +0200 (CEST) Received: from lolap.longwitz (87-57-220-129-dynamic.dk.customer.tdc.net [87.57.220.129]) by secmail.incore.de (Postfix) with ESMTPS id 857E067A2F; Tue, 23 May 2017 22:25:33 +0200 (CEST) Message-ID: <59249ABA.4020404@incore.de> Date: Tue, 23 May 2017 22:25:30 +0200 From: Andreas Longwitz User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:15.0) Gecko/20120917 Thunderbird/15.0.1 MIME-Version: 1.0 To: Domagoj Stolfa , freebsd-dtrace@freebsd.org Subject: Re: fbt:kernel:breadn_flags:entry): invalid address (0x0) in action #7 References: <591E01F5.8080208@incore.de> <6A020677-BC76-41E1-8372-10B7962F4EDE@apple.com> <20170518204534.GA37126@wraith> <20170518235207.GB37643@wkstn-mjohnston.west.isilon.com> <5921F56F.7090509@incore.de> <20170521210051.GA43039@vulture.cbsd.home> <5922CEFC.8020306@incore.de> <20170522120326.GA45031@vulture.cbsd.home> In-Reply-To: <20170522120326.GA45031@vulture.cbsd.home> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 May 2017 20:25:43 -0000 > > Could you please supply the full script please? It might give some clue as to > where the problem is. > I have found my mistake: "action #7" means line 7 in the probe and has nothing to do with the parameters of the probed function. So I could handle this NULL-problem and now my probe fires correct. This is the (corrected) probe: fbt::breadn_flags:entry /self->bread && args[6] == 0/ { this->bread_vnode = args[0]; this->bread_blkno = (unsigned long)args[1]; this->bread_inode = (struct inode *)(this->bread_vnode->v_data); this->bread_inum = this->bread_inode->i_number; this->bread_gj = this->bread_vnode->v_mount->mnt_gjprovider != NULL ? stringof(this->bread_vnode->v_mount->mnt_gjprovider) : ""; printf(" gj=%s, inum=%u, blkno=%lu\n", this->bread_gj, this->bread_inum, this->bread_blkno ); } and now it fires like this: 1 31371 breadn_flags:entry gj=, inum=0, blkno=320 Thaks for help!