From owner-freebsd-java@freebsd.org  Sun May 14 20:40:26 2017
Return-Path: <owner-freebsd-java@freebsd.org>
Delivered-To: freebsd-java@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1AAF7D6DC88
 for <freebsd-java@mailman.ysv.freebsd.org>;
 Sun, 14 May 2017 20:40:26 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3])
 by mx1.freebsd.org (Postfix) with ESMTP id 0B05FDA7
 for <freebsd-java@freebsd.org>; Sun, 14 May 2017 20:40:26 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: by mailman.ysv.freebsd.org (Postfix)
 id 0A6A5D6DC87; Sun, 14 May 2017 20:40:26 +0000 (UTC)
Delivered-To: java@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0A15AD6DC86
 for <java@mailman.ysv.freebsd.org>; Sun, 14 May 2017 20:40:26 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D5E15DA6
 for <java@FreeBSD.org>; Sun, 14 May 2017 20:40:25 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from anthias (vie-188-118-248-216.dsl.sil.at [188.118.248.216])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ainaz.pair.com (Postfix) with ESMTPSA id C6A213F4ED
 for <java@FreeBSD.org>; Sun, 14 May 2017 16:40:22 -0400 (EDT)
Date: Sun, 14 May 2017 22:40:20 +0200 (CEST)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: java@FreeBSD.org
Subject: Remove dead code from java/cacao/Makefile
Message-ID: <alpine.LSU.2.21.1705142235120.4477@anthias.pfeifer.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: freebsd-java@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Porting Java to FreeBSD <freebsd-java.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-java>,
 <mailto:freebsd-java-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-java/>
List-Post: <mailto:freebsd-java@freebsd.org>
List-Help: <mailto:freebsd-java-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-java>,
 <mailto:freebsd-java-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 May 2017 20:40:26 -0000

Hi guys,

I noticed what looks like dead code in cacao/Makefile, since WITH_GCC
is not mentioned anywhere under Mk/, nor is there an option GCC, and 
I have not seen anything similar used for many, many years.

Okay to apply?


Beyond that, this branch -- building cacao without JDK (and GCJ) --
of the Makefile has been broken for a while and GCC is abandoning
GCJ upstream, so would you consider removing it as a follow-up?

Using JDK has been an option, and on by default, since 2012-10-05.

Gerald


Index: cacao/Makefile
===================================================================
--- cacao/Makefile	(revision 440883)
+++ cacao/Makefile	(working copy)
@@ -36,9 +36,6 @@
 JAR=		${LOCALBASE}/bootstrap-openjdk/bin/jar
 JAVAC=		${LOCALBASE}/bootstrap-openjdk/bin/javac
 .else
-.if defined(WITH_GCC)
-GCC_SUFX=	${WITH_GCC:S/.//}
-.endif
 GCC_SUFX?=	46
 BUILD_DEPENDS+=	gcj${GCC_SUFX}:lang/gcc${GCC_SUFX}
 EXTRA_PATCHES=	${FILESDIR}/gcj.patch