From owner-freebsd-java@freebsd.org  Sun Dec  3 17:05:01 2017
Return-Path: <owner-freebsd-java@freebsd.org>
Delivered-To: freebsd-java@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 97C76E56A02
 for <freebsd-java@mailman.ysv.freebsd.org>;
 Sun,  3 Dec 2017 17:05:01 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org
 [IPv6:2001:1900:2254:206a::50:5])
 by mx1.freebsd.org (Postfix) with ESMTP id 824807EF6E
 for <freebsd-java@freebsd.org>; Sun,  3 Dec 2017 17:05:01 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: by mailman.ysv.freebsd.org (Postfix)
 id 7E6BAE56A00; Sun,  3 Dec 2017 17:05:01 +0000 (UTC)
Delivered-To: java@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7E0A1E569FE
 for <java@mailman.ysv.freebsd.org>; Sun,  3 Dec 2017 17:05:01 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (ainaz.pair.com [209.68.2.66])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5D0F87EF6D;
 Sun,  3 Dec 2017 17:05:01 +0000 (UTC)
 (envelope-from gerald@pfeifer.com)
Received: from ainaz.pair.com (localhost [127.0.0.1])
 by ainaz.pair.com (Postfix) with ESMTP id 36E013F6C1;
 Sun,  3 Dec 2017 12:04:54 -0500 (EST)
Received: from [172.20.10.60] (unknown [12.235.85.135])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ainaz.pair.com (Postfix) with ESMTPSA id BD3E63F6C0;
 Sun,  3 Dec 2017 12:04:53 -0500 (EST)
Date: Sun, 3 Dec 2017 10:04:52 -0700 (MST)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: java@FreeBSD.org, Joe Nosay <superbisquit@gmail.com>, 
 Rene Ladan <rene@FreeBSD.org>
Subject: Re: Remove dead code from java/cacao/Makefile
In-Reply-To: <alpine.LSU.2.21.1705280131360.3529@anthias.pfeifer.com>
Message-ID: <alpine.LSU.2.21.1712030948580.2983@anthias.pfeifer.com>
References: <alpine.LSU.2.21.1705142235120.4477@anthias.pfeifer.com>
 <CA+WntOu5d7avfVhoa-Y2a7dghQBHU8PizyRsjN1eCHe49Sz6QA@mail.gmail.com>
 <alpine.LSU.2.21.1705280131360.3529@anthias.pfeifer.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-BeenThere: freebsd-java@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: Porting Java to FreeBSD <freebsd-java.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-java>,
 <mailto:freebsd-java-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-java/>
List-Post: <mailto:freebsd-java@freebsd.org>
List-Help: <mailto:freebsd-java-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-java>,
 <mailto:freebsd-java-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Dec 2017 17:05:01 -0000

On Sun, 28 May 2017, Gerald Pfeifer wrote:
> I did not propose to remove that option, I merely wanted to relay
> that (a) currently this alternative codepath is simply broken and
> (b) remove three lines of dead code at least.

Let me follow-up on this again.

Rene, I saw that you recently updated java/cacao.  Can you approve?

I verified that WITH_GCC has exactly two occurrences in the _entire_
Ports tree, and that is this dead code in java/cacao/Makefile.

Any real objections towards removing this _dead_ code?

Gerald

PS: There is more, but let's focus on this most straightforward one
for now where I'm surprised (a) nobody else cared and (b) even this 
was hard to get in.

Index: java/cacao/Makefile
===================================================================
--- java/cacao/Makefile	(revision 455410)
+++ java/cacao/Makefile	(working copy)
@@ -37,9 +37,6 @@
 JAR=		${LOCALBASE}/bootstrap-openjdk6/bin/jar
 JAVAC=		${LOCALBASE}/bootstrap-openjdk6/bin/javac
 .else
-.if defined(WITH_GCC)
-GCC_SUFX=	${WITH_GCC:S/.//}
-.endif
 GCC_SUFX?=	46
 BUILD_DEPENDS+=	gcj${GCC_SUFX}:lang/gcc${GCC_SUFX}
 EXTRA_PATCHES=	${FILESDIR}/gcj.patch