From owner-freebsd-net@freebsd.org Sun Feb 26 15:38:01 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C8B74CEE179 for ; Sun, 26 Feb 2017 15:38:01 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id A7D2E6E7 for ; Sun, 26 Feb 2017 15:38:01 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id A428ECEE178; Sun, 26 Feb 2017 15:38:01 +0000 (UTC) Delivered-To: net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A211CCEE177 for ; Sun, 26 Feb 2017 15:38:01 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mail-ua0-x234.google.com (mail-ua0-x234.google.com [IPv6:2607:f8b0:400c:c08::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4EFDF6E5; Sun, 26 Feb 2017 15:38:01 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mail-ua0-x234.google.com with SMTP id 40so34881968uau.2; Sun, 26 Feb 2017 07:38:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=efeH44UV7NUlC1VzW/hDUAcGELcFQNSoImPzImU86M0=; b=BYuSXwLTKSkBprxkr9I6EIoJE4MMUjNnknx0hHIpLIHfKBvNDq0q2wxGolxmG4pFNn rsHg0ZycRsrEWbeWNDnFW7PUYGtnAjmbmgs5gt9V6Vazxz1H4JV6gbSbfX5WK5UV/5TL YnJyEZeIntIadM0TuyRShKeNLiGPuB0+Gl5/eAeWpjUSN7RC01Ap6Xty/sbzueskYcWo AtHAI9r+CoewEQ5IGhJzu8zQNurcjsASFAN/Zg6jTyp+1ykzvOLmxogVh7lyDt05oqJt gPzNhMr/YvQNtL1OPQHN4/0LCmx2U36UJ3fmMww1Vdc+6h0purMuhdg+GUCdAaSn2Mjw SBsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=efeH44UV7NUlC1VzW/hDUAcGELcFQNSoImPzImU86M0=; b=mV5FoEaAcZRFlQY4tuYHtwVayO0te4UP0iULM+iPIBTvEyn/pqCSBu+MECfjaa1qnl jtTz0o9bUWNlEEipVSvvv/v0r7aUZ9QcUYcSAIn0Qaazlyt42ZO5s3balX5A/TtoiB7H WUXSvFPmOND6KD9bf8EQgNmw4JdHdXl+EY6kwlPJ2iwaqoPn+TTnR+FN/7LzP9kdk6cd 8aOvfNqEjAg0aEX6z3WU5C8QWagyjdsuorTBf1oy2abtdzEuuWq82XX7XLwtZnf0ps2K VunYcz+aPGijdluFjT16L3wPC5d5ASPGxMQbzBTUm7vjQ5ttJEz/QJNXezEUmrIOI7uh vG9A== X-Gm-Message-State: AMke39n3wH4Gnxg/Gig0f5HQQte8cFNUdWFaUsr9X2A0EFitisd//EiMKLaEq+Pt3krJdKshV/E19XWQX6fXVw== X-Received: by 10.176.82.165 with SMTP id v34mr5572554uav.133.1488123479908; Sun, 26 Feb 2017 07:37:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.176.66.193 with HTTP; Sun, 26 Feb 2017 07:37:59 -0800 (PST) In-Reply-To: <20170222232704.GJ8899@FreeBSD.org> References: <20170127005251.GM2611@FreeBSD.org> <20170210063024.GE1973@FreeBSD.org> <20170216184903.GF58829@FreeBSD.org> <0858647a-ec3c-1a78-053f-d04397a82d8a@freebsd.org> <20170222232704.GJ8899@FreeBSD.org> From: Sepherosa Ziehau Date: Sun, 26 Feb 2017 23:37:59 +0800 Message-ID: Subject: Re: listening sockets as non sockets To: Gleb Smirnoff Cc: Julien Charbon , Jason Eggleston , "freebsd-net@freebsd.org" , hiren@freebsd.org, jtl@freebsd.org, rrs@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Feb 2017 15:38:01 -0000 On Thu, Feb 23, 2017 at 7:27 AM, Gleb Smirnoff wrote: > On Tue, Feb 21, 2017 at 09:58:45AM +0100, Julien Charbon wrote: > J> > T> 1) The patch worked pretty okay, but the idea of separate file type is > J> > T> abandoned. With current filedescriptor code it is almost impossible > J> > T> to racelessly switch fileops and f_data. > J> > T> For more details read the commit message, URL below. > J> > T> > J> > T> 2) I moved the work to git. It allows for easier code sharing. > J> > T> > J> > T> https://github.com/glebius/FreeBSD/commit/3a52df429889ea9c6e61013f6913aad95939f159 > J> > > J> > The current 'solisten' branch at https://github.com/glebius/FreeBSD has > J> > been running successfully for 48 hours at Netflix. But as mentioned before, > J> > our connection rate is pretty low. > J> > > J> > So, testing from Julien and Hiren will be much appreciated. > J> > J> Sound good, I will have spare time to get performance results on our > J> side w/ and w/o your change before the end of this week. > > Thanks, Julien! Looking forward for your results. Meanwhile, the code has > been running for a week on a single Netflix box. And for 24 hours on a > set of boxes as A/B test against non-patched code. Since our connection > rate is low, and we never seen accept_mtx to be a major problem in our > profiling, the A/B test didn't show any statistically significant > improvements. But my biased eye of course sees some improvements in the > graphs :) Just got enough time to do some benchmark. The configuration is pretty simple, one server box w/ 2x82599, two client boxes w/ 1x82599, connected through DAC. nginx-devel is installed through pkg; access log is disabled, 24 workers, each worker w/ 16384 max connections. I use the wrk I mentioned to you. HTTP/1.1 and 1 request/connection, 15K concurrent connections from each client boxes, so 30K concurrent connections total. Each client has been verified to be able to do 160Kreqs/s w/ 1KB web object w/ 1 request/connection. 4 different sized staic web objects are benched, see below. The solisten was checked out on Feb 25th. Several GENERIC options (NFS and SCTP related) have to be commented out and kernel is built w/ -DNO_MODULES (CAM ctl module does not compile) and GENERIC-NODEBUG on the solisten branch. Each test lasts 2 minutes. MSL on the server side has been changed to 10ms, though I don't think it matters here. Server hw: 2x2620v2 (HT enabled), 32GB ddr3-1600. Client hw: i7-3770 (HT enabled), 16GB ddr3-1600. r314268 -> solisten 1KB: Performance (reqs/s) 77916.71 -> 26240.37 Latency average 121ms -> 294ms 8KB: Performance (reqs/s) 77803.72 -> 25968.87 Latency average 121ms -> 251ms 16KB: Performance (reqs/s) 75698.77 -> 25047.23 Latency average 173ms -> 377ms 24KB: Performance (reqs/s) 73736.80 -> 24946.36 Latency average 180ms -> 379ms So what I have seen is solisten's performance is 1/3 of r314268, and average latency doubles. Thanks, sephe -- Tomorrow Will Never Die From owner-freebsd-net@freebsd.org Sun Feb 26 17:37:53 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 057B3CEE466 for ; Sun, 26 Feb 2017 17:37:53 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id DCACBF88 for ; Sun, 26 Feb 2017 17:37:52 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id CDFB1CEE465; Sun, 26 Feb 2017 17:37:52 +0000 (UTC) Delivered-To: net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CDAB4CEE464 for ; Sun, 26 Feb 2017 17:37:52 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (glebi.us [96.95.210.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9C3B8F81; Sun, 26 Feb 2017 17:37:52 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id v1QHbiBN040610 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 26 Feb 2017 09:37:44 -0800 (PST) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id v1QHbifa040609; Sun, 26 Feb 2017 09:37:44 -0800 (PST) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@FreeBSD.org using -f Date: Sun, 26 Feb 2017 09:37:44 -0800 From: Gleb Smirnoff To: Sepherosa Ziehau Cc: Julien Charbon , Jason Eggleston , "freebsd-net@freebsd.org" , hiren@freebsd.org, jtl@freebsd.org, rrs@freebsd.org Subject: Re: listening sockets as non sockets Message-ID: <20170226173744.GH8899@FreeBSD.org> References: <20170127005251.GM2611@FreeBSD.org> <20170210063024.GE1973@FreeBSD.org> <20170216184903.GF58829@FreeBSD.org> <0858647a-ec3c-1a78-053f-d04397a82d8a@freebsd.org> <20170222232704.GJ8899@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Feb 2017 17:37:53 -0000 On Sun, Feb 26, 2017 at 11:37:59PM +0800, Sepherosa Ziehau wrote: S> Just got enough time to do some benchmark. The configuration is S> pretty simple, one server box w/ 2x82599, two client boxes w/ 1x82599, S> connected through DAC. nginx-devel is installed through pkg; access S> log is disabled, 24 workers, each worker w/ 16384 max connections. I S> use the wrk I mentioned to you. HTTP/1.1 and 1 request/connection, S> 15K concurrent connections from each client boxes, so 30K concurrent S> connections total. Each client has been verified to be able to do S> 160Kreqs/s w/ 1KB web object w/ 1 request/connection. 4 different S> sized staic web objects are benched, see below. The solisten was S> checked out on Feb 25th. Several GENERIC options (NFS and SCTP S> related) have to be commented out and kernel is built w/ -DNO_MODULES S> (CAM ctl module does not compile) and GENERIC-NODEBUG on the solisten S> branch. Each test lasts 2 minutes. MSL on the server side has been S> changed to 10ms, though I don't think it matters here. Server hw: S> 2x2620v2 (HT enabled), 32GB ddr3-1600. Client hw: i7-3770 (HT S> enabled), 16GB ddr3-1600. S> S> r314268 -> solisten S> S> 1KB: S> Performance (reqs/s) S> 77916.71 -> 26240.37 S> Latency average S> 121ms -> 294ms S> S> 8KB: S> Performance (reqs/s) S> 77803.72 -> 25968.87 S> Latency average S> 121ms -> 251ms S> S> 16KB: S> Performance (reqs/s) S> 75698.77 -> 25047.23 S> Latency average S> 173ms -> 377ms S> S> 24KB: S> Performance (reqs/s) S> 73736.80 -> 24946.36 S> Latency average S> 180ms -> 379ms S> S> So what I have seen is solisten's performance is 1/3 of r314268, and S> average latency doubles. Thanks a lot! Looks like I've put something on the accept path that degrades performance. :) I will look at this tomorrow and post an update. Can you please share exact wrk command you used? Do I understand it correct that there was only 1 listening socket on the server side? -- Totus tuus, Glebius. From owner-freebsd-net@freebsd.org Sun Feb 26 20:48:29 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 23556CEC00B for ; Sun, 26 Feb 2017 20:48:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 12D25A59 for ; Sun, 26 Feb 2017 20:48:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v1QKmSPD039817 for ; Sun, 26 Feb 2017 20:48:28 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217374] fix tap(4) to be full-duplex and have non-zero speed Date: Sun, 26 Feb 2017 20:48:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: short_desc keywords assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Feb 2017 20:48:29 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217374 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|tap(4) shall be full-duplex |fix tap(4) to be |and have non-zero speed. |full-duplex and have | |non-zero speed Keywords| |patch Assignee|freebsd-bugs@FreeBSD.org |freebsd-net@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sun Feb 26 21:01:04 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D0103CECC15 for ; Sun, 26 Feb 2017 21:01:04 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C2B0AC3B for ; Sun, 26 Feb 2017 21:01:04 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v1QL01e6061275 for ; Sun, 26 Feb 2017 21:01:04 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <201702262101.v1QL01e6061275@kenobi.freebsd.org> From: bugzilla-noreply@FreeBSD.org To: freebsd-net@FreeBSD.org Subject: Problem reports for freebsd-net@FreeBSD.org that need special attention Date: Sun, 26 Feb 2017 21:01:04 +0000 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Feb 2017 21:01:04 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- In Progress | 165622 | [ndis][panic][patch] Unregistered use of FPU in k In Progress | 203422 | mpd/ppoe not working with re(4) with revision 285 In Progress | 206581 | bxe_ioctl_nvram handler is faulty New | 204438 | setsockopt() handling of kern.ipc.maxsockbuf limi New | 205592 | TCP processing in IPSec causes kernel panic New | 206053 | kqueue support code of netmap causes panic New | 215874 | [patch] [icmp] [mbuf_tags] teach icmp_error() opt Open | 148807 | [panic] "panic: sbdrop" and "panic: sbsndptr: soc Open | 193452 | Dell PowerEdge 210 II -- Kernel panic bce (broadc Open | 194485 | Userland cannot add IPv6 prefix routes Open | 194515 | Fatal Trap 12 Kernel with vimage Open | 199136 | [if_tap] Added down_on_close sysctl variable to t Open | 202510 | [CARP] advertisements sourced from CARP IP cause Open | 206544 | sendmsg(2) (sendto(2) too?) can fail with EINVAL; Open | 211031 | [panic] in ng_uncallout when argument is NULL Open | 211962 | bxe driver queue soft hangs and flooding tx_soft_ Open | 212018 | Enable IPSEC_NAT_T in GENERIC kernel configuratio 17 problems total for which you should take action. From owner-freebsd-net@freebsd.org Mon Feb 27 01:31:36 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B5C8CEFEAD for ; Mon, 27 Feb 2017 01:31:36 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 695F5AE2 for ; Mon, 27 Feb 2017 01:31:36 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 65B72CEFEAC; Mon, 27 Feb 2017 01:31:36 +0000 (UTC) Delivered-To: net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 65603CEFEAB for ; Mon, 27 Feb 2017 01:31:36 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mail-ua0-x234.google.com (mail-ua0-x234.google.com [IPv6:2607:f8b0:400c:c08::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1EE12AE1; Mon, 27 Feb 2017 01:31:36 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mail-ua0-x234.google.com with SMTP id 72so19849057uaf.3; Sun, 26 Feb 2017 17:31:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Wx14uybWlxnToZGQEBw7ygcOTtP7fwtb0ic+Nalq/k8=; b=rg5v9ZVwCt3tP4UYodtZ7sYZlu2hT+8jhK1G4goCpu3vKiRdCtPGWn9OAnpkH/YnXC E8xfGHmSIDkYZ072EKQd6n3qRIQYHS4KBPWRSfLWioXntlQ2XhVrUlHmqZvG6/1BxOtP ZE+Ynq73bg+zrelTKmeR8B7fRjBmDpwJDnNV2q+MZSD0K+lAu64qC410sIkW4iR4JK5S dlGzz6DjfEVn/Hsh6nIPEo7Jzjeo5vYDWOThJP5HlWWdHsbiTFBIdEXFBPxn/Hv4gV0B lwvJ3L0G4sQt2QExmJ1gVPuvzqW6HL/JmW1MR7Ys2eaPETBr5GcTKKWLCwgsqplvd9mc C+Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Wx14uybWlxnToZGQEBw7ygcOTtP7fwtb0ic+Nalq/k8=; b=uM+CLodahlyqiClvIQBd4bYKrvPLgMlmPFFj6NfAjP9IzO5QoQCw5HyeRznNbttaP3 rKD7+iVonx2jdKNS2mBAAJA3xXufhsdrxn5yQdgFPgnqjupFIarByJVZEt3gGGtachD2 MBz/jtYLanj/Hb2Bj6DwiRjVDGgL+APOXcsq0zIZadgOq0urzuywJB7RM6kIbz17S3Vl +HbZ1arGhNHRcF+ww0CtU9C5D6Q3+9LLfixCgdvfmbpsV8Qa5cDMSZKhOMcXpC98Q3nn whimZxTGv1BTRQUAVJaPUT25ahZSuQndlG6zJMrMD+AzJoRMUTb/EvASOc2mNN+sX3yr jRNQ== X-Gm-Message-State: AMke39mg0QFw2XkROHRuLoN33k5Kt16KQJmejZe93qACX14GkQkNmq/PpaXZSg5IKn4HgktfdESM/+zkXVDPXQ== X-Received: by 10.31.109.71 with SMTP id i68mr6061088vkc.89.1488159095220; Sun, 26 Feb 2017 17:31:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.176.66.193 with HTTP; Sun, 26 Feb 2017 17:31:34 -0800 (PST) In-Reply-To: <20170226173744.GH8899@FreeBSD.org> References: <20170127005251.GM2611@FreeBSD.org> <20170210063024.GE1973@FreeBSD.org> <20170216184903.GF58829@FreeBSD.org> <0858647a-ec3c-1a78-053f-d04397a82d8a@freebsd.org> <20170222232704.GJ8899@FreeBSD.org> <20170226173744.GH8899@FreeBSD.org> From: Sepherosa Ziehau Date: Mon, 27 Feb 2017 09:31:34 +0800 Message-ID: Subject: Re: listening sockets as non sockets To: Gleb Smirnoff Cc: Julien Charbon , Jason Eggleston , "freebsd-net@freebsd.org" , hiren@freebsd.org, jtl@freebsd.org, rrs@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 01:31:36 -0000 On Mon, Feb 27, 2017 at 1:37 AM, Gleb Smirnoff wrote: > On Sun, Feb 26, 2017 at 11:37:59PM +0800, Sepherosa Ziehau wrote: > S> Just got enough time to do some benchmark. The configuration is > S> pretty simple, one server box w/ 2x82599, two client boxes w/ 1x82599, > S> connected through DAC. nginx-devel is installed through pkg; access > S> log is disabled, 24 workers, each worker w/ 16384 max connections. I > S> use the wrk I mentioned to you. HTTP/1.1 and 1 request/connection, > S> 15K concurrent connections from each client boxes, so 30K concurrent > S> connections total. Each client has been verified to be able to do > S> 160Kreqs/s w/ 1KB web object w/ 1 request/connection. 4 different > S> sized staic web objects are benched, see below. The solisten was > S> checked out on Feb 25th. Several GENERIC options (NFS and SCTP > S> related) have to be commented out and kernel is built w/ -DNO_MODULES > S> (CAM ctl module does not compile) and GENERIC-NODEBUG on the solisten > S> branch. Each test lasts 2 minutes. MSL on the server side has been > S> changed to 10ms, though I don't think it matters here. Server hw: > S> 2x2620v2 (HT enabled), 32GB ddr3-1600. Client hw: i7-3770 (HT > S> enabled), 16GB ddr3-1600. > S> > S> r314268 -> solisten > S> > S> 1KB: > S> Performance (reqs/s) > S> 77916.71 -> 26240.37 > S> Latency average > S> 121ms -> 294ms > S> > S> 8KB: > S> Performance (reqs/s) > S> 77803.72 -> 25968.87 > S> Latency average > S> 121ms -> 251ms > S> > S> 16KB: > S> Performance (reqs/s) > S> 75698.77 -> 25047.23 > S> Latency average > S> 173ms -> 377ms > S> > S> 24KB: > S> Performance (reqs/s) > S> 73736.80 -> 24946.36 > S> Latency average > S> 180ms -> 379ms > S> > S> So what I have seen is solisten's performance is 1/3 of r314268, and > S> average latency doubles. > > Thanks a lot! Looks like I've put something on the accept path that degrades > performance. :) I will look at this tomorrow and post an update. > > Can you please share exact wrk command you used? On my testing client (8 HT). wrk -c 15000 -t 8 -d 120s --delay --latency --connreqs 1 http://server/1K.bin > Do I understand it correct that there was only 1 listening socket on the > server side? Yep, only port 80 is listened on the server side, as a normal website will do. Thanks, sephe -- Tomorrow Will Never Die From owner-freebsd-net@freebsd.org Mon Feb 27 01:36:58 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 11FCECEF137 for ; Mon, 27 Feb 2017 01:36:58 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id E40E4DB5 for ; Mon, 27 Feb 2017 01:36:57 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id E3793CEF136; Mon, 27 Feb 2017 01:36:57 +0000 (UTC) Delivered-To: net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E32AECEF135 for ; Mon, 27 Feb 2017 01:36:57 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mail-ua0-x22a.google.com (mail-ua0-x22a.google.com [IPv6:2607:f8b0:400c:c08::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9DD59DB4 for ; Mon, 27 Feb 2017 01:36:57 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mail-ua0-x22a.google.com with SMTP id e4so7548264uae.0 for ; Sun, 26 Feb 2017 17:36:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=pt6TQfMvFzwHuNYX5gtEDGSZ8IgCtqHFqbquoR8FGGk=; b=hXXIM6k/4xq78Gv7Ex/LCcbbUDjbZCTzhTien1ZhBJlXpi2DPvgnOZ3lvuH3FGi2RF 9VwShJswSuw5l9LRTVe0wrBG6TzyizYpJa93jygTQ3TAWSWNlEuCsycxZ2944m1BZRyw XXWmA8FC+/u9Y11STyU9LDxU7DujbbEk9y7zDhgEo5HT5kXGNy2GtZzTzBXZQbS1hfMg eSTGAWmqIUkRTjHmLiAf3nDphkMZrX/P2q7nTfEGp3mDinpyoN8h8zu/4OfiVX1Q9bqB Lpzwco5N+tawC1wpaGwluTDiyOw42zr/NzAFXGQtA0/ZbngjTUoyCh72PifYDtCv7iw4 LFZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=pt6TQfMvFzwHuNYX5gtEDGSZ8IgCtqHFqbquoR8FGGk=; b=oZityHQKoFE975ZmNvtHawDPuun39S27W5UUXd6W2U8nh5bwYrM07/PSxYNbSJ/f3H 2PQI4lSu/qe/LhrP8YDb/IdwTPILrUKNMs+8nGnsiqXMxYVhltNd0I4qpIF+5bf/Tg9u kHwA3AjWGf5Jc+ECS342x/ZY/hHhTYmpAd63nDiBCdN2Tb1w3wiNRlycSyKK2XqrJG8g AwrPP4nwtQAtpdE2TwUK6rgBHcRqrwX4u+4GQIljmn4y/9Z/rdyrFceJuRkxmeUa+zq+ r3t/CLZdPFBnvHMskjxRE5KVudVZJoTAmbAmI3Ksz9f9dv8HEAnugZnzlLnsDxFkYfLx oTdg== X-Gm-Message-State: AMke39nsLvMF/WXnBeJZQS6nv+DLdiYKs4bOeS2UAYoL7sgNF0zExupPJnJXELh99w8pnrbO8A+8Hdyq5iJCHA== X-Received: by 10.31.155.75 with SMTP id d72mr5808623vke.55.1488159416701; Sun, 26 Feb 2017 17:36:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.176.66.193 with HTTP; Sun, 26 Feb 2017 17:36:56 -0800 (PST) In-Reply-To: <20170225155628.GB6035@zxy.spb.ru> References: <20170127005251.GM2611@FreeBSD.org> <20170210063024.GE1973@FreeBSD.org> <20170216184903.GF58829@FreeBSD.org> <0858647a-ec3c-1a78-053f-d04397a82d8a@freebsd.org> <20170222232704.GJ8899@FreeBSD.org> <20170223153636.GI15630@zxy.spb.ru> <20170224131349.GJ15630@zxy.spb.ru> <20170225155628.GB6035@zxy.spb.ru> From: Sepherosa Ziehau Date: Mon, 27 Feb 2017 09:36:56 +0800 Message-ID: Subject: Re: listening sockets as non sockets To: Slawa Olhovchenkov Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 01:36:58 -0000 On Sat, Feb 25, 2017 at 11:56 PM, Slawa Olhovchenkov wrote: > On Sat, Feb 25, 2017 at 11:09:29PM +0800, Sepherosa Ziehau wrote: > >> > Can I use per-connection Lua script (for delays and url generation)? >> > Not per-thread. I am need to emulate many client connections (about >> > 10K-40K). >> > Currently I am have some trouble w/ >20K connections. >> >> I didn't try the Lua script. Make sure to low the MSL on the box >> running wrk, e.g. 10ms. Well, I'd recommend you to run 15K concurrent >> connections on one testing box. > > Thanks! > Can you explain some more this recomendations? If you don't lower MSL, too many sockets will sit in TIMED_WAIT state on the testing client, which consumes local port space. Local port space depletion == wrk can do more requests. 15K concurrent connection on each client box is a heuristic to make sure local ports can be recycled timely. You need to figure out your value on the testing box. But, normally, 15K ~ 10K is doable on each client machine for a given server. > > PS: I am run wrk w/ '--connreqs 600' Well, nginx's default setting is 100 requests/connection :). I use --connreqs 1 to generate "short-lived" connection bomb. Thanks, sephe -- Tomorrow Will Never Die From owner-freebsd-net@freebsd.org Mon Feb 27 01:37:34 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA4D1CEF1EB for ; Mon, 27 Feb 2017 01:37:34 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 94421E6D for ; Mon, 27 Feb 2017 01:37:34 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 93A2BCEF1EA; Mon, 27 Feb 2017 01:37:34 +0000 (UTC) Delivered-To: net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 934DFCEF1E9 for ; Mon, 27 Feb 2017 01:37:34 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mail-ua0-x22b.google.com (mail-ua0-x22b.google.com [IPv6:2607:f8b0:400c:c08::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4B309E6C for ; Mon, 27 Feb 2017 01:37:34 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mail-ua0-x22b.google.com with SMTP id 40so41708899uau.2 for ; Sun, 26 Feb 2017 17:37:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Bmy21G6UtvUq3IW6MwIiJUO0WHgZlX/A7CqEPApj8Oo=; b=dWw2EL8BEo4mr6FYwKd4cVFaDaV3P31pLVof14HessfxRN5g6s+CUZiPxpO7iLtVb9 9fuB+uPcwMhXEng0b56v9OBPq5OqjUxDvQ2N7kyxCy7aP1VJ5Xl0PTUVv174jVmVmhwA 5CS3bo2LA6KC+LGJ25PFr+rfFJP9VCRg+e0wQTxemIWa0wvmi3MpHIiHLxudkK1igy7G EJIO2cFoN22NPHful4uG1mcYAVa8koGhnKg4InAOBcOlrTviJYJRfi0jBmr/M9LeOKYY E53yh4aLoiKyPNuNMAp0XNcH4Ja2OpAIGcllhR5JkJBpdz/FJyW4Gol9PFR+kpPpv8KF qJWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Bmy21G6UtvUq3IW6MwIiJUO0WHgZlX/A7CqEPApj8Oo=; b=Krg7bmPSs/aGpGrPYhDQM+l1QbVNrFpQJpRVw1k1FgCnimFNvALjRXx1N4KGv9wriG GrBVVPnsAr6qajRctcbuSs+CqjPv4yuj1KK6lSEtFjlJocmfIjvN5gesaH1NnZo7muTy If+TNz42J6bA+/q8RBPjMYrG0MN9F4LkLgJ7U7YODJGl10+fB3R3WKgpiykwkxtv4jEK fVRqShm0kfDx4g0BjvsKB2NPY+vWADncOCLWE2SNnF2M5iYUB+2h3plNNsCpwD6VCw/q /2P+IQ183PKt7f4pf4FWiFobvwT54HWY6SN3LQF3+8pCITgVQvHEvcp+wEQlXCOmnOFM xcWg== X-Gm-Message-State: AMke39kS7jMFkZCLguftI8DRQ7hIqi/48RwFXZxYp8ZkyQO8oZBcjC0BJbC0dNgkmlgM3tnH24RmiFyKNa2DTw== X-Received: by 10.176.90.139 with SMTP id w11mr6718074uae.106.1488159453479; Sun, 26 Feb 2017 17:37:33 -0800 (PST) MIME-Version: 1.0 Received: by 10.176.66.193 with HTTP; Sun, 26 Feb 2017 17:37:32 -0800 (PST) In-Reply-To: References: <20170127005251.GM2611@FreeBSD.org> <20170210063024.GE1973@FreeBSD.org> <20170216184903.GF58829@FreeBSD.org> <0858647a-ec3c-1a78-053f-d04397a82d8a@freebsd.org> <20170222232704.GJ8899@FreeBSD.org> <20170223153636.GI15630@zxy.spb.ru> <20170224131349.GJ15630@zxy.spb.ru> <20170225155628.GB6035@zxy.spb.ru> From: Sepherosa Ziehau Date: Mon, 27 Feb 2017 09:37:32 +0800 Message-ID: Subject: Re: listening sockets as non sockets To: Slawa Olhovchenkov Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 01:37:34 -0000 On Mon, Feb 27, 2017 at 9:36 AM, Sepherosa Ziehau wrote: > On Sat, Feb 25, 2017 at 11:56 PM, Slawa Olhovchenkov wrote: >> On Sat, Feb 25, 2017 at 11:09:29PM +0800, Sepherosa Ziehau wrote: >> >>> > Can I use per-connection Lua script (for delays and url generation)? >>> > Not per-thread. I am need to emulate many client connections (about >>> > 10K-40K). >>> > Currently I am have some trouble w/ >20K connections. >>> >>> I didn't try the Lua script. Make sure to low the MSL on the box >>> running wrk, e.g. 10ms. Well, I'd recommend you to run 15K concurrent >>> connections on one testing box. >> >> Thanks! >> Can you explain some more this recomendations? > > If you don't lower MSL, too many sockets will sit in TIMED_WAIT state > on the testing client, which consumes local port space. Local port > space depletion == wrk can do more requests. Hmm, I meant 'wrk cannot do more requests' :) > > 15K concurrent connection on each client box is a heuristic to make > sure local ports can be recycled timely. You need to figure out your > value on the testing box. But, normally, 15K ~ 10K is doable on each > client machine for a given server. > >> >> PS: I am run wrk w/ '--connreqs 600' > > Well, nginx's default setting is 100 requests/connection :). I use > --connreqs 1 to generate "short-lived" connection bomb. > > Thanks, > sephe > > -- > Tomorrow Will Never Die -- Tomorrow Will Never Die From owner-freebsd-net@freebsd.org Mon Feb 27 11:29:17 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CD97CCEF4DE for ; Mon, 27 Feb 2017 11:29:17 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id B7893BC0 for ; Mon, 27 Feb 2017 11:29:17 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: by mailman.ysv.freebsd.org (Postfix) id B4077CEF4DD; Mon, 27 Feb 2017 11:29:17 +0000 (UTC) Delivered-To: net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B3ABFCEF4DC for ; Mon, 27 Feb 2017 11:29:17 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 73634BBF for ; Mon, 27 Feb 2017 11:29:17 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1ciJUL-000Il2-EQ; Mon, 27 Feb 2017 14:29:09 +0300 Date: Mon, 27 Feb 2017 14:29:09 +0300 From: Slawa Olhovchenkov To: Sepherosa Ziehau Cc: "freebsd-net@freebsd.org" Subject: Re: listening sockets as non sockets Message-ID: <20170227112909.GA70430@zxy.spb.ru> References: <20170210063024.GE1973@FreeBSD.org> <20170216184903.GF58829@FreeBSD.org> <0858647a-ec3c-1a78-053f-d04397a82d8a@freebsd.org> <20170222232704.GJ8899@FreeBSD.org> <20170223153636.GI15630@zxy.spb.ru> <20170224131349.GJ15630@zxy.spb.ru> <20170225155628.GB6035@zxy.spb.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 11:29:17 -0000 On Mon, Feb 27, 2017 at 09:36:56AM +0800, Sepherosa Ziehau wrote: > On Sat, Feb 25, 2017 at 11:56 PM, Slawa Olhovchenkov wrote: > > On Sat, Feb 25, 2017 at 11:09:29PM +0800, Sepherosa Ziehau wrote: > > > >> > Can I use per-connection Lua script (for delays and url generation)? > >> > Not per-thread. I am need to emulate many client connections (about > >> > 10K-40K). > >> > Currently I am have some trouble w/ >20K connections. > >> > >> I didn't try the Lua script. Make sure to low the MSL on the box > >> running wrk, e.g. 10ms. Well, I'd recommend you to run 15K concurrent > >> connections on one testing box. > > > > Thanks! > > Can you explain some more this recomendations? > > If you don't lower MSL, too many sockets will sit in TIMED_WAIT state > on the testing client, which consumes local port space. Local port > space depletion == wrk can do more requests. > > 15K concurrent connection on each client box is a heuristic to make > sure local ports can be recycled timely. You need to figure out your > value on the testing box. But, normally, 15K ~ 10K is doable on each > client machine for a given server. I see: you talk about tuning for workload w/ bunch connectios/seconds. I am need different workload test: many long lived connection, w/ average transfer on each about 1 mbit/s by requesting files about 600KB (and wait some time between, for effort 1 mbit/s average transfer). > > > > PS: I am run wrk w/ '--connreqs 600' > > Well, nginx's default setting is 100 requests/connection :). I use I am already tuned nginx to keepalive_requests 10000; > --connreqs 1 to generate "short-lived" connection bomb. From owner-freebsd-net@freebsd.org Mon Feb 27 16:00:33 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AA584CF0FE6 for ; Mon, 27 Feb 2017 16:00:33 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vps1.elischer.org", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 913CBF2C for ; Mon, 27 Feb 2017 16:00:33 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from Julian-MBP3.local (ppp121-45-246-6.lns20.per4.internode.on.net [121.45.246.6]) (authenticated bits=0) by vps1.elischer.org (8.15.2/8.15.2) with ESMTPSA id v1RG0Rrk008984 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 27 Feb 2017 08:00:31 -0800 (PST) (envelope-from julian@freebsd.org) Subject: Re: NETGRAPH's ng_cisco and IPv6 support To: =?UTF-8?B?xYF1a2FzeiBXw7NqY2lr?= , freebsd-net@freebsd.org References: <9980efee-f51c-2e48-59e1-099a609fc0a3@zoho.com> From: Julian Elischer Message-ID: Date: Tue, 28 Feb 2017 00:00:22 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <9980efee-f51c-2e48-59e1-099a609fc0a3@zoho.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 16:00:33 -0000 On 24/2/17 3:03 am, Łukasz Wójcik wrote: > Hello everyone, > > I've recently started to develop certain driver that uses 'ng_cisco' > netgraph module for CHDLC en-/de-capsulation. > When it connects with ng_cisco node via 'inet' hook, everything > works fine, but there is an issue when trying to > use 'inet6' node. cisco_notify() routine only sends flow control > messages to nodes connected via 'inet' hook, > completely ignoring those connected via 'inet6'. This poses some > problem if peer node relies on link status information > passed from ng_cisco. I'd therefore like to suggest/discuss a patch > (attached to this email). All it does is to make ng_cisco node > pass flow control messages to *both* 'inet' and 'inet6' peers. It > seems to me that it is both possible and sensible to > expect both mentioned hooks to be connected at the same time. > > I would appreciate any feedback. ipv6 was still a "some time in the future" thing when I wrote the ng_cisco node (or did archie do that one.?) I'm pretty sire someone who knows IPv6 needs to go through the entire suite with a broom. > > Best regards, > -ŁW > > > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" From owner-freebsd-net@freebsd.org Mon Feb 27 23:30:01 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A5C1ACF05A5 for ; Mon, 27 Feb 2017 23:30:01 +0000 (UTC) (envelope-from julien@perdition.city) Received: from relay-b01.edpnet.be (relay-b01.edpnet.be [212.71.1.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "edpnet.email", Issuer "Go Daddy Secure Certificate Authority - G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 68FB8B9A for ; Mon, 27 Feb 2017 23:30:00 +0000 (UTC) (envelope-from julien@perdition.city) X-ASG-Debug-ID: 1488237387-0a7ff549de1852f0001-Pd2ruv Received: from mordor.lan ([213.219.148.14]) by relay-b01.edpnet.be with ESMTP id tXz1an4jbuoDy8eW (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Tue, 28 Feb 2017 00:16:28 +0100 (CET) X-Barracuda-Envelope-From: julien@perdition.city X-Barracuda-Effective-Source-IP: UNKNOWN[213.219.148.14] X-Barracuda-Apparent-Source-IP: 213.219.148.14 Date: Tue, 28 Feb 2017 00:16:26 +0100 From: Julien Cigar To: freebsd-net@FreeBSD.org Subject: VLAN + CARP ? Message-ID: <20170227231626.GJ6194@mordor.lan> X-ASG-Orig-Subj: VLAN + CARP ? MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zyWBJsol2ZBPjK0b" Content-Disposition: inline User-Agent: Mutt/1.7.1 (2016-10-04) X-Barracuda-Connect: UNKNOWN[213.219.148.14] X-Barracuda-Start-Time: 1488237387 X-Barracuda-Encrypted: ECDHE-RSA-AES256-GCM-SHA384 X-Barracuda-URL: https://212.71.1.221:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 804 X-Virus-Scanned: by bsmtpd at edpnet.be X-Barracuda-BRTS-Status: 1 X-Barracuda-Bayes: INNOCENT GLOBAL 0.4999 1.0000 0.0000 X-Barracuda-Spam-Score: 0.50 X-Barracuda-Spam-Status: No, SCORE=0.50 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=6.0 tests=BSF_SC0_MV0713 X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.36844 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.50 BSF_SC0_MV0713 Custom rule MV0713 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 23:30:01 -0000 --zyWBJsol2ZBPjK0b Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, I wondered if it is possible to use CARP with VLAN interfaces? Would something like this work (on 10.3)..?: =3D /etc/rc.conf =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D vlans_em0=3D"neta netb" create_args_neta=3D"vlan 101" create_args_netb=3D"vlan 102" ifconfig_em0_neta=3D"inet 192.168.1.253/24" ifconfig_em0_netb=3D"inet 10.209.1.253/24" ifconfig_em0_neta_alias0=3D"inet vhid 3 advskew 10 pass xx alias 192.168.2.= 254/32" ifconfig_em0_netb_alias0=3D"inet vhid 4 advskew 10 pass xx alias 10.209.1.2= 54/32" =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D Thanks! Julien --=20 Julien Cigar Belgian Biodiversity Platform (http://www.biodiversity.be) PGP fingerprint: EEF9 F697 4B68 D275 7B11 6A25 B2BB 3710 A204 23C0 No trees were killed in the creation of this message. However, many electrons were terribly inconvenienced. --zyWBJsol2ZBPjK0b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE7vn2l0to0nV7EWolsrs3EKIEI8AFAli0s0cACgkQsrs3EKIE I8C7tg/+K8Kl9rtQIKS8Fuhw9nrM+J+qN1iorXssNGFqeYpEn6hXcUuoxSPjqk9F f3r7AGORVHaaPncN5HKepFC3QFdfFh9Eerq2wNjut9i0AXnzlG8zGPPtPpGl1qQf 4jQuGa2gMLBEBLJlpZeIQP0bkjR0yAF5T7QnD0h2/i7xzwQumAqBncYSz1poVBU2 YY2f0hIuUS/e29uzibxyma2QDRBx+PvzYs/u/zvkwbLXB/DKiO7HbaQUC42LLSfI aq9lXzjb0xEO7waa2QqFGeGK5/80gpPIqeFRPHryfdAXvNqHHSXItGHUixgyczpy g9WGaLJV+CqF5dKQVTraLq28QbQZ+C/lPBqrfukTR0soxD0n6OFGnRkSn4SNpFMB 87u3Jtzvgr0cufnDVsT1PyfOXbaUg/vOd7V6nDyhdhwDYdh3FTL3Mhq6j42tJawM D18qktoaxyfmGdQrwTUyi3XeiyDzdsgjqulMuewL/LmGlnJbxMB1icZEy0Yfqwrz LMFdVRdZTVyPSzaqiuaQKU0Sn38rChcs07UjQcu9/+x5AMgEEdV5El8ewZIHXF3a oxYUIzIF9uEisVzDYeyjeNPS4r7PuefuLj5TkK62hdLqHXlTfui4+n0WAdcb36oh aEFr4QspQLSopLX82Fk2DkR2nYhOtfSptjJBEEz6pWEOpPqtjeg= =B0h7 -----END PGP SIGNATURE----- --zyWBJsol2ZBPjK0b-- From owner-freebsd-net@freebsd.org Mon Feb 27 23:37:16 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1F8C6CF07BB for ; Mon, 27 Feb 2017 23:37:16 +0000 (UTC) (envelope-from fjwcash@gmail.com) Received: from mail-qk0-x230.google.com (mail-qk0-x230.google.com [IPv6:2607:f8b0:400d:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C22B5F41 for ; Mon, 27 Feb 2017 23:37:15 +0000 (UTC) (envelope-from fjwcash@gmail.com) Received: by mail-qk0-x230.google.com with SMTP id n186so46680676qkb.3 for ; Mon, 27 Feb 2017 15:37:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=pbx+aHwXfoubua4B8NPpaW8BRhbKX1HPt22BzHkCg9A=; b=hjoSKuBaA7nXQ6jBZJYLj5caS59wJyyGBeA2QgkXz4VeqOKWpBf7kl4n6VAWWxHzSP wR0Cv3vDhoUH4rxYJHOhBdURBHOD6nAV2kUGboMCKkFEmRzzFUOLvpWCjaNHGq0izlBx qrI96TU91nvgP/rDJrs0HuBN3zHMxvFPmJ9PFcycjM5KCeW3KkQEGt0jaJc9QM0oKOM9 gdq/ZPRfZL5JOGoedMjp/iKWmypPRrWNksNDqLNE5ROVXGmTB5P6izG0qolZbdmeJLdS SLTrxn0X8RMSIHtvMDaUNnk7aCeBxg5VcehDhtMnALHgH5Z4dqdAq8dIsX5QIwaWhI06 ZMEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=pbx+aHwXfoubua4B8NPpaW8BRhbKX1HPt22BzHkCg9A=; b=L8iZ6jBMUn3ipvsUrzL7GxPiGA2GQiHFF5E23o3oQB8dmZPiIXfsD+ReE3yjhV7JhT zRchDAmiXNEP06mRNTUgfIvut71tB0fZO8wEV9l88JqeYAa/NsQlN4yBHhp3+G/GUpmY btULy1n4ugAB8u4zhu0G8kY3TBPpMJlAHZrmQC7UTTSHymkRcACm00GcY1Nx908Gl+tt sH1ybAWrLWdc9CGIKKNpVHaoOw7k2cFxVj5Cwrpq1riFwyfz8LF7rGsf8EPNyKYHFJp8 yrnBO6xKfX56RUVyRZy7E3+LOxZChPOHvcBY7t8P8tBMG24uGA1OFk4fz9Jipe5Ib7/C F8DA== X-Gm-Message-State: AMke39kck7wah/5cBRCMmYAC6Cxb05x5nNmZ4hiPYTJw6NzTZ+JH5YQYXYFa6Zo9SHBVNgys3sKDezzqUnhkRQ== X-Received: by 10.237.34.59 with SMTP id n56mr6497582qtc.231.1488238634957; Mon, 27 Feb 2017 15:37:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.28.202 with HTTP; Mon, 27 Feb 2017 15:37:14 -0800 (PST) In-Reply-To: <20170227231626.GJ6194@mordor.lan> References: <20170227231626.GJ6194@mordor.lan> From: Freddie Cash Date: Mon, 27 Feb 2017 15:37:14 -0800 Message-ID: Subject: Re: VLAN + CARP ? To: Julien Cigar Cc: freebsd-net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 23:37:16 -0000 On Mon, Feb 27, 2017 at 3:16 PM, Julien Cigar wrote= : > I wondered if it is possible to use CARP with VLAN interfaces? > =E2=80=8BYes, CARP-over-vLAN works well. Used just such a setup at work fo= r a couple years. Would something like this work (on 10.3)..?: > > =3D /etc/rc.conf =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > vlans_em0=3D"neta netb" > create_args_neta=3D"vlan 101" > create_args_netb=3D"vlan 102" > > ifconfig_em0_neta=3D"inet 192.168.1.253/24" > ifconfig_em0_netb=3D"inet 10.209.1.253/24" > > ifconfig_em0_neta_alias0=3D"inet vhid 3 advskew 10 pass xx alias > 192.168.2.254/32" > ifconfig_em0_netb_alias0=3D"inet vhid 4 advskew 10 pass xx alias > 10.209.1.254/32" > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > =E2=80=8BThis is the setup we used (snipped for brevity): # em2 is the 3rd NIC port from the top of the quad-port NIC ifconfig_em2=3D"up" vlans_em2=3D"vlan110 vlan2000 vlan1000 vlan1010 vlan1110" create_args_vlan1000=3D"vlan 1000" ifconfig_vlan1000=3D"vhid 9 pass nxsp4ss =E2=80=8B1=E2=80=8B advskew 128 10.1.0.1/16" create_args_vlan2000=3D"vlan 2000" ifconfig_vlan2000=3D"vhid 20 pass nxsp4ss2 advskew 128 12.24.13.97/27" create_args_vlan1010=3D"vlan 1010" ifconfig_vlan1010=3D"vhid 21 pass nxsp4ss =E2=80=8B3 advskew 128 12.24.12.129/26" create_args_vlan1110=3D"vlan 1110" ifconfig_vlan1110=3D"vhid 11 pass nxsp4ss =E2=80=8B4 advskew 128 12.24.10.1/26" =E2=80=8Bem2 had no IPs associated with it, it was just the physical interf= ace that the vlans and carp traffic went over. We also only had a single subnet per vlan, so only a single IP per carp instance on each vlan. But you can do multiples using the alias syntax like you have.=E2=80=8B --=20 Freddie Cash fjwcash@gmail.com From owner-freebsd-net@freebsd.org Tue Feb 28 02:13:29 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 99D59CEF473 for ; Tue, 28 Feb 2017 02:13:29 +0000 (UTC) (envelope-from jordancaraballo87@gmail.com) Received: from mail-ua0-x243.google.com (mail-ua0-x243.google.com [IPv6:2607:f8b0:400c:c08::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C7F2337 for ; Tue, 28 Feb 2017 02:13:29 +0000 (UTC) (envelope-from jordancaraballo87@gmail.com) Received: by mail-ua0-x243.google.com with SMTP id 40so10213733uau.2 for ; Mon, 27 Feb 2017 18:13:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:references:message-id:date:user-agent:mime-version :in-reply-to; bh=6+rev1JnrNEk5RUGi/JMiV0jyYt2LFLSPvIn0la8Fpg=; b=itVwPi61GBYxEVb3WrSxC3StjP2d9dgI034KsOf2tA9PqeCP2XNmS5+0ZqHuo929OM Au2T0FTJLrT3sJxys4++KQSXGVqVuHx5LCzHlG+mRjJuQfwsKmgc7/G7axyHrJAGOffD QuSDu0Kq9yYMHEWW74yFvK0CC+buLCnc564pc8yMExOpbLv178aG1fsgWuhldLxSt1bW e1z4ooxnZPseYl5gjj5DKWzj0BGXt9xG2lvGWFltKDRMdUBo31Ymx1zHEMjxYXCfZGMq Olb2hBhDkVbX81bVwuaomRQzzpUBFTdhRpzT8ICFydZM3mA/dGxnOY/u0N1rN+dW94Rg WTBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:references:message-id:date :user-agent:mime-version:in-reply-to; bh=6+rev1JnrNEk5RUGi/JMiV0jyYt2LFLSPvIn0la8Fpg=; b=O6rrUKLy7b5CKqSNtZ6n/UrfG7KYOD24QCS0lZzDxqMatdHw6IXsrz8Q/pDGLpIoTg 6mREX+CkPnjQTxlXMmc35InC1hLZzGxh1Um611WAeOmF4c3W+3pVZ0enAGN9qjZcwQCP 0vNtP0kFfA66ihyC+nC3Xfr+wyd/GNHCOsB49pdCApyg90TrTCYyOUl3CYd6eIpEEJNV u5NysK5fnvD0E8CPBKtf2omCVBHDmoflRH1uVAE+JkrjZTCNjwah1PyUg3DA/aaTt62R V9Ijt680AKGueEHPgMDknb3aX7CzWqnuHHFVQVPIiscbCxgAQf2i2eNFplNnCNF8i5fy 52GQ== X-Gm-Message-State: AMke39mPCqrPBUjbaIKbvOPlESulN8En5XDMqTTDx0wb3p+tVAishncf6glUp9etl/tIkw== X-Received: by 10.159.48.69 with SMTP id i5mr9013620uab.121.1488248008239; Mon, 27 Feb 2017 18:13:28 -0800 (PST) Received: from [192.168.0.105] ([104.218.243.3]) by smtp.gmail.com with ESMTPSA id 92sm62840uas.19.2017.02.27.18.13.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Feb 2017 18:13:27 -0800 (PST) From: "Caraballo-vega, Jordan A. (GSFC-6062)[COMPUTER SCIENCE CORP]" Subject: Re: Fwd: Re: Disappointing packets-per-second performance results on a Dell,PE R530 To: freebsd-net@freebsd.org References: <40a413f3-2c44-ee9d-9961-67114d8dffca@gmail.com> <20170205175531.GA20287@dwarf> <7d349edd-0c81-2e3f-d3b9-27af232de76d@gmail.com> <20170209153409.GG41673@dwarf> Message-ID: <6ad029e0-86c6-af3d-8fc3-694d4bcdc683@gmail.com> Date: Mon, 27 Feb 2017 22:13:07 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170209153409.GG41673@dwarf> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 02:13:29 -0000 As a summarywe have a Dell R530 with a Chelsio T580 cardwith -CURRENT. In an attempt to reduce the time the system was taking to look for the cpus; we changed the BIOS setting to let the system have 8 visible cores and tested cxl* and vcxl* chelsio interfaces. Scores are still way lower than what we expected: Cxl interface root@router1:~ # netstat -w1 -h input (Total) output packets errs idrops bytes packets errs bytes colls 4.1M 0 3.4M 2.1G 725k 0 383M 0 3.7M 0 3.1M 1.9G 636k 0 336M 0 3.9M 0 3.2M 2.0G 684k 0 362M 0 4.0M 0 3.3M 2.1G 702k 0 371M 0 3.8M 0 3.2M 2.0G 658k 0 348M 0 3.9M 0 3.2M 2.0G 658k 0 348M 0 3.9M 0 3.2M 2.0G 721k 0 381M 0 3.3M 0 2.6M 1.7G 681k 0 360M 0 3.2M 0 2.5M 1.7G 666k 0 352M 0 2.6M 0 2.0M 1.4G 620k 0 328M 0 2.8M 0 2.1M 1.4G 615k 0 325M 0 3.2M 0 2.6M 1.7G 612k 0 323M 0 3.3M 0 2.7M 1.7G 664k 0 351M 0 Vcxl interface input (Total) output packets errs idrops bytes packets errs bytes colls drops 590k 7.5k 0 314M 590k 0 314M 0 0 526k 6.6k 0 280M 526k 0 280M 0 0 588k 7.1k 0 313M 588k 0 313M 0 0 532k 6.6k 0 283M 532k 0 283M 0 0 578k 7.2k 0 307M 578k 0 307M 0 0 565k 7.0k 0 300M 565k 0 300M 0 0 558k 7.0k 0 297M 558k 0 297M 0 0 533k 6.7k 0 284M 533k 0 284M 0 0 588k 7.3k 0 313M 588k 0 313M 0 0 553k 6.9k 0 295M 554k 0 295M 0 0 527k 6.7k 0 281M 527k 0 281M 0 0 585k 7.4k 0 311M 585k 0 311M 0 0 Related to pmcstat scores are: root@router1:~/PMC_Stats/Feb22 # pmcstat -R sample.out -G - | head @ CPU_CLK_UNHALTED_CORE [2091 samples] 15.35% [321] lock_delay @ /boot/kernel/kernel 94.70% [304] _mtx_lock_spin_cookie 100.0% [304] __mtx_lock_spin_flags 57.89% [176] pmclog_loop @ /boot/kernel/hwpmc.ko 100.0% [176] fork_exit @ /boot/kernel/kernel 41.12% [125] pmclog_reserve @ /boot/kernel/hwpmc.ko 100.0% [125] pmclog_process_callchain 100.0% [125] pmc_process_samples root@router1:~/PMC_Stats/Feb22 # pmcstat -R sample0.out -G - | head @ CPU_CLK_UNHALTED_CORE [480 samples] 37.29% [179] acpi_cpu_idle_mwait @ /boot/kernel/kernel 100.0% [179] acpi_cpu_idle 100.0% [179] cpu_idle_acpi 100.0% [179] cpu_idle 100.0% [179] sched_idletd 100.0% [179] fork_exit 12.92% [62] cpu_idle @ /boot/kernel/kernel When trying to run pmcstat with the vcxl interfaces enabled the system just went to a state of not responding. Based on previous scores with Centos 7 (over 3M pps), we can assume that it is not the hardware. However, we are still looking for a reason of why are we getting these scores. Any feedback or suggestion would be highly appreciated. - Jordan On 2/9/17 11:34 AM, Navdeep Parhar wrote: > The vcxl interfaces should work under current or 11-STABLE. Let me know > if you run into any trouble when trying to use netmap with cxgbe driver. > > Regards, > Navdeep > > On Thu, Feb 09, 2017 at 10:29:08AM -0500, John Jasen wrote: >> It's not the hardware. >> >> Jordan booted up CentOS on the box, and untuned, were able to obtain >> over 3 mpps. >> >> He has some pmcstat output from freebsd-current, but basically, it >> appears the system spends most of its time looking for a CPU to service >> the interrupts and keeps landing on one or two of them, as opposed to >> any of the other 16 cores on the physical silicon. >> >> We also tried swapping out the T5 card for a Mellanox, tried different >> PCIe slots, adjusted cpuset for the low and the high CPUs, no matter >> what we try, the results have been bad. >> >> Our network test environment is under reconstruction at the moment, but >> our plans afterwards are to: >> >> a) test netmap-fwd again (the VCXL enabling works under -CURRENT?) >> >> b) test without netmap-fwd, and with reduced cores/physical cpus (BIOS >> setting) >> >> c) potentially, test with netmap-fwd and reduced core count. >> >> Any other ideas out there? >> >> Thanks! >> >> >> >> >> >> >> >> >> On 02/05/2017 12:55 PM, Navdeep Parhar wrote: >>> I've been following the email thread on freebsd-net on this. The >>> numbers you're getting are well below what the hardware is capable of. >>> >>> Have you tried netmap-fwd or something that bypasses the kernel? That >>> will be a very quick way to make sure that the hardware is doing ok. >>> >>> In case you try netmap: >>> cxgbe has virtual interfaces now and those are used for netmap (instead >>> of the main interface). Add this line to /boot/loader.conf and you'll >>> see a 'vcxl' interface for every cxl interface. >>> hw.cxgbe.num_vis=2 >>> It has its own MAC address and can be used like any other interface, >>> except it has native netmap support too. You can run netmap-fwd between >>> these vcxl ports. >>> >>> Regards, >>> Navdeep >>> >>> On Tue, Jan 31, 2017 at 01:57:37PM -0400, Jordan Caraballo wrote: >>>> Navdeep, Troy, >>>> >>>> I forwarded you this email to see if we could get feedback from both of >>>> you. I talked with Troy during November about >>>> >>>> this R530 system and the use of a 40G Chelsio T-580-CR card. So far, we >>>> have not experienced results above 1.4 million or so. >>>> >>>> Any help would be appreciated. >>>> >>>> - Jordan >>>> >>>> -------- Forwarded Message -------- >>>> >>>> Subject: Re: Disappointing packets-per-second performance results on a >>>> Dell,PE R530 >>>> Date: Tue, 31 Jan 2017 13:53:15 -0400 >>>> From: Jordan Caraballo >>>> To: Slawa Olhovchenkov >>>> CC: freebsd-net@freebsd.org >>>> >>>> This are the most recent stats. No advances so far. The system has >>>> -Current right now. >>>> >>>> Any help or feedback would be appreciated. >>>> Hardware Configuration: >>>> Dell PowerEdge R530 with 2 Intel(R) Xeon(R) E52695 CPU's, 18 cores per >>>> cpu. Equipped with a Chelsio T-580-CR dual port in an 8x slot. >>>> >>>> BIOS tweaks: >>>> Hyperthreading (or Logical Processors) is turned off. >>>> loader.conf >>>> # Chelsio Modules >>>> t4fw_cfg_load="YES" >>>> t5fw_cfg_load="YES" >>>> if_cxgbe_load="YES" >>>> rc.conf >>>> # Gateway Configuration >>>> ifconfig_cxl0="inet 172.16.1.1/24" >>>> ifconfig_cxl1="inet 172.16.2.1/24" >>>> gateway_enable="YES" >>>> >>>> Last Results: >>>> packets errs idrops bytes packets errs bytes colls drops >>>> 2.7M 0 2.0M 1.4G 696k 0 368M 0 0 >>>> 2.7M 0 2.0M 1.4G 686k 0 363M 0 0 >>>> 2.6M 0 2.0M 1.4G 668k 0 353M 0 0 >>>> 2.7M 0 2.0M 1.4G 661k 0 350M 0 0 >>>> 2.8M 0 2.1M 1.5G 697k 0 369M 0 0 >>>> 2.8M 0 2.1M 1.4G 684k 0 361M 0 0 >>>> 2.7M 0 2.1M 1.4G 674k 0 356M 0 0 >>>> >>>> root@router1:~ # vmstat -i >>>> >>>> interrupt total rate >>>> irq9: acpi0 73 0 >>>> irq18: ehci0 ehci1 1155973 3 >>>> cpu0:timer 3551157 10 >>>> cpu29:timer 9303048 27 >>>> cpu9:timer 71693455 207 >>>> cpu16:timer 9798380 28 >>>> cpu18:timer 9287094 27 >>>> cpu26:timer 9342495 27 >>>> cpu20:timer 9145888 26 >>>> cpu8:timer 9791228 28 >>>> cpu22:timer 9288116 27 >>>> cpu35:timer 9376578 27 >>>> cpu30:timer 9396294 27 >>>> cpu23:timer 9248760 27 >>>> cpu10:timer 9756455 28 >>>> cpu25:timer 9300202 27 >>>> cpu27:timer 9227291 27 >>>> cpu14:timer 10083548 29 >>>> cpu28:timer 9325684 27 >>>> cpu11:timer 9906405 29 >>>> cpu34:timer 9419170 27 >>>> cpu31:timer 9392089 27 >>>> cpu33:timer 9350540 27 >>>> cpu15:timer 9804551 28 >>>> cpu32:timer 9413182 27 >>>> cpu19:timer 9231505 27 >>>> cpu12:timer 9813506 28 >>>> cpu13:timer 10872130 31 >>>> cpu4:timer 9920237 29 >>>> cpu2:timer 9786498 28 >>>> cpu3:timer 9896011 29 >>>> cpu5:timer 9890207 29 >>>> cpu6:timer 9737869 28 >>>> cpu7:timer 9790119 28 >>>> cpu1:timer 9847913 28 >>>> cpu21:timer 9192561 27 >>>> cpu24:timer 9300259 27 >>>> cpu17:timer 9786186 28 >>>> irq264: mfi0 151818 0 >>>> irq266: bge0 30466 0 >>>> irq272: t5nex0:evt 4 0 >>>> Total 402604945 1161 >>>> top -PHS >>>> last pid: 18557; load averages: 2.58, 1.90, 0.95 up 4+00:39:54 18:30:46 >>>> 231 processes: 40 running, 126 sleeping, 65 waiting >>>> CPU 0: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 1: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 2: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 3: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 4: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 5: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 6: 0.0% user, 0.0% nice, 0.4% system, 0.0% interrupt, 99.6% idle >>>> CPU 7: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 8: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 9: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 10: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 11: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 12: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 13: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 14: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 15: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 16: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 17: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 18: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 19: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 20: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 21: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 22: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 23: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 24: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 25: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 26: 0.0% user, 0.0% nice, 0.0% system, 59.6% interrupt, 40.4% idle >>>> CPU 27: 0.0% user, 0.0% nice, 0.0% system, 96.3% interrupt, 3.7% idle >>>> CPU 28: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 29: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 30: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 31: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 32: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 33: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> CPU 34: 0.0% user, 0.0% nice, 0.0% system, 100% interrupt, 0.0% idle >>>> CPU 35: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>> Mem: 15M Active, 224M Inact, 1544M Wired, 393M Buf, 29G Free >>>> Swap: 3881M Total, 3881M Free >>>> >>>> pmcstat -R sample.out -G - | head >>>> @ CPU_CLK_UNHALTED_CORE [159 samples] >>>> >>>> 39.62% [63] acpi_cpu_idle_mwait @ /boot/kernel/kernel >>>> 100.0% [63] acpi_cpu_idle >>>> 100.0% [63] cpu_idle_acpi >>>> 100.0% [63] cpu_idle >>>> 100.0% [63] sched_idletd >>>> 100.0% [63] fork_exit >>>> >>>> 17.61% [28] cpu_idle @ /boot/kernel/kernel >>>> >>>> root@router1:~ # pmcstat -R sample0.out -G - | head >>>> @ CPU_CLK_UNHALTED_CORE [750 samples] >>>> >>>> 31.60% [237] acpi_cpu_idle_mwait @ /boot/kernel/kernel >>>> 100.0% [237] acpi_cpu_idle >>>> 100.0% [237] cpu_idle_acpi >>>> 100.0% [237] cpu_idle >>>> 100.0% [237] sched_idletd >>>> 100.0% [237] fork_exit >>>> >>>> 10.67% [80] cpu_idle @ /boot/kernel/kernel >>>> >>>> On 03/01/17 13:46, Slawa Olhovchenkov wrote: >>>> >>>> On Tue, Jan 03, 2017 at 12:35:42PM -0400, Jordan Caraballo wrote: >>>> >>>> >>>> We recently tested a Dell R530 with a Chelsio T580 card, under FreeBSD 10.3, 11.0, -STABLE and -CURRENT, and Centos 7. >>>> >>>> Based on our research, including netmap-fwd and with the routing improvements project (https://wiki.freebsd.org/ProjectsRoutingProposal), >>>> we hoped for packets-per-second (pps) in the 5+ million range, or even higher. >>>> >>>> Based on prior testing (http://marc.info/?t=140604252400002&r=1&w=2), we expected 3-4 Million to be easily obtainable. >>>> >>>> Unfortunately, our current results top out at no more than 1.5 M (64 bytes length packets) with FreeBSD, and >>>> surprisingly around 3.2 M (128 bytes length packets) with Centos 7, and we are at a loss as to why. >>>> >>>> Server Description: >>>> Dell PowerEdge R530 with 2 Intel(R) Xeon(R) E52695 CPU's, 18 cores per >>>> cpu. Equipped with a Chelsio T-580-CR dual port in an 8x slot. >>>> >>>> ** Can this be a lack in support issue related to the R530's hardware? ** >>>> >>>> Any help appreciated! >>>> >>>> What hardware configuration? >>>> What BIOS setting? >>>> What loader.conf/sysctl.conf setting? >>>> What `vmstat -i`? >>>> What `top -PHS`? >>>> what >>>> ==== >>>> pmcstat -S CPU_CLK_UNHALTED_CORE -l 10 -O sample.out >>>> pmcstat -R sample.out -G out.txt >>>> pmcstat -c 0 -S CPU_CLK_UNHALTED_CORE -l 10 -O sample0.out >>>> pmcstat -R sample0.out -G out0.txt >>>> ==== From owner-freebsd-net@freebsd.org Tue Feb 28 02:47:53 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C34D9CF06AC for ; Tue, 28 Feb 2017 02:47:53 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mail-ua0-x229.google.com (mail-ua0-x229.google.com [IPv6:2607:f8b0:400c:c08::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8D97CBC1 for ; Tue, 28 Feb 2017 02:47:53 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mail-ua0-x229.google.com with SMTP id f54so47575968uaa.1 for ; Mon, 27 Feb 2017 18:47:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=vfG21kbc5bHR9YnbMUU5aqr9Ay0Rwk0668m2FDfz1D4=; b=HaG/PfzOMFyKmAJ2Xm7NAheKG2FSrykjKZbU1EjPwXLyjNfJ8htYw0HKJpzh2O0C8b Ptd02P29fDsCBcVSZ1yqVhMv3KXOmqn5/3WhOfvg2pO/Fi1i+sPeptiBIuAcNHj2lbj5 c+Zr5qvXVFBVzeKwxvYAJgqi5PJmz+Y1iatDQFy1z22P8Q09oz0uOl6JurcABW/VgROm mhsqfbDdFfi7MVmyNZNqjf/nvkhZTsjsNzy/jfKtO6c3znD91XowikRg9Fo3fTOC1Q3d 1zSEAR/+idioTH9IckpUU/gNEP7EnWLy2A3k/m4bJcc3HC4MIYi5kV34SBnaa2z+660d mOqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=vfG21kbc5bHR9YnbMUU5aqr9Ay0Rwk0668m2FDfz1D4=; b=PmEOt1GLCRA22Q0ONbHaUmC/wZdwXsRIllLF0ArBhGS4mELPtiH3yDdXAnB0QGH/wd A+tMJ0vL/BR+8PQx8jSdhc/i7oiCcomv1Oa63Y20sB5CCI0TmCRDEnFfUyjRN7CygTyZ xj79SGftOVO3oArHHAfj0/+oEM9ltC6FodTYFmBQUG2vXdCY5VjTT9w9tNZgfHJRejpr OEraZGka0SRQ757emvH7iDVPxkWQLFA8P14j168vXg5QYChm/1r40/d3iMMwfm8V3JL2 R6vKl1pQhkWelR97lKAGs37CPiqea/aEuPdFq9VSoVD+fcpJpPIvkgxkUIdk517TGTID uqeg== X-Gm-Message-State: AMke39kbvXeQuHkJQDSZBV6ivUWN3vjeLUSUDSHKcZI/0YAwPNEBv5RlO2wW97B4nEzl4O9mW6SFLSl2vrRvLQ== X-Received: by 10.31.217.7 with SMTP id q7mr4195vkg.32.1488250072384; Mon, 27 Feb 2017 18:47:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.176.66.193 with HTTP; Mon, 27 Feb 2017 18:47:51 -0800 (PST) In-Reply-To: <6ad029e0-86c6-af3d-8fc3-694d4bcdc683@gmail.com> References: <40a413f3-2c44-ee9d-9961-67114d8dffca@gmail.com> <20170205175531.GA20287@dwarf> <7d349edd-0c81-2e3f-d3b9-27af232de76d@gmail.com> <20170209153409.GG41673@dwarf> <6ad029e0-86c6-af3d-8fc3-694d4bcdc683@gmail.com> From: Sepherosa Ziehau Date: Tue, 28 Feb 2017 10:47:51 +0800 Message-ID: Subject: Re: Fwd: Re: Disappointing packets-per-second performance results on a Dell,PE R530 To: "Caraballo-vega, Jordan A. (GSFC-6062)[COMPUTER SCIENCE CORP]" Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 02:47:53 -0000 Did you compile and installed GENERIC-NODEBUG kernel for the CURRENT test? On Tue, Feb 28, 2017 at 10:13 AM, Caraballo-vega, Jordan A. (GSFC-6062)[COMPUTER SCIENCE CORP] wrote: > As a summarywe have a Dell R530 with a Chelsio T580 cardwith -CURRENT. > > In an attempt to reduce the time the system was taking to look for the > cpus; we changed the BIOS setting to let the system have 8 visible cores > and tested cxl* and vcxl* chelsio interfaces. Scores are still way lower > than what we expected: > > Cxl interface > > root@router1:~ # netstat -w1 -h > input (Total) output > packets errs idrops bytes packets errs bytes colls > 4.1M 0 3.4M 2.1G 725k 0 383M 0 > 3.7M 0 3.1M 1.9G 636k 0 336M 0 > 3.9M 0 3.2M 2.0G 684k 0 362M 0 > 4.0M 0 3.3M 2.1G 702k 0 371M 0 > 3.8M 0 3.2M 2.0G 658k 0 348M 0 > 3.9M 0 3.2M 2.0G 658k 0 348M 0 > 3.9M 0 3.2M 2.0G 721k 0 381M 0 > 3.3M 0 2.6M 1.7G 681k 0 360M 0 > 3.2M 0 2.5M 1.7G 666k 0 352M 0 > 2.6M 0 2.0M 1.4G 620k 0 328M 0 > 2.8M 0 2.1M 1.4G 615k 0 325M 0 > 3.2M 0 2.6M 1.7G 612k 0 323M 0 > 3.3M 0 2.7M 1.7G 664k 0 351M 0 > > > Vcxl interface > input (Total) output > packets errs idrops bytes packets errs bytes colls drops > 590k 7.5k 0 314M 590k 0 314M 0 0 > 526k 6.6k 0 280M 526k 0 280M 0 0 > 588k 7.1k 0 313M 588k 0 313M 0 0 > 532k 6.6k 0 283M 532k 0 283M 0 0 > 578k 7.2k 0 307M 578k 0 307M 0 0 > 565k 7.0k 0 300M 565k 0 300M 0 0 > 558k 7.0k 0 297M 558k 0 297M 0 0 > 533k 6.7k 0 284M 533k 0 284M 0 0 > 588k 7.3k 0 313M 588k 0 313M 0 0 > 553k 6.9k 0 295M 554k 0 295M 0 0 > 527k 6.7k 0 281M 527k 0 281M 0 0 > 585k 7.4k 0 311M 585k 0 311M 0 0 > > Related to pmcstat scores are: > > root@router1:~/PMC_Stats/Feb22 # pmcstat -R sample.out -G - | head > @ CPU_CLK_UNHALTED_CORE [2091 samples] > > 15.35% [321] lock_delay @ /boot/kernel/kernel > 94.70% [304] _mtx_lock_spin_cookie > 100.0% [304] __mtx_lock_spin_flags > 57.89% [176] pmclog_loop @ /boot/kernel/hwpmc.ko > 100.0% [176] fork_exit @ /boot/kernel/kernel > 41.12% [125] pmclog_reserve @ /boot/kernel/hwpmc.ko > 100.0% [125] pmclog_process_callchain > 100.0% [125] pmc_process_samples > > root@router1:~/PMC_Stats/Feb22 # pmcstat -R sample0.out -G - | head > @ CPU_CLK_UNHALTED_CORE [480 samples] > > 37.29% [179] acpi_cpu_idle_mwait @ /boot/kernel/kernel > 100.0% [179] acpi_cpu_idle > 100.0% [179] cpu_idle_acpi > 100.0% [179] cpu_idle > 100.0% [179] sched_idletd > 100.0% [179] fork_exit > > 12.92% [62] cpu_idle @ /boot/kernel/kernel > > When trying to run pmcstat with the vcxl interfaces enabled the system > just went to a state of not responding. > > Based on previous scores with Centos 7 (over 3M pps), we can assume that > it is not the hardware. However, we are still looking for a reason of > why are we getting these scores. > > Any feedback or suggestion would be highly appreciated. > > - Jordan > > On 2/9/17 11:34 AM, Navdeep Parhar wrote: >> The vcxl interfaces should work under current or 11-STABLE. Let me know >> if you run into any trouble when trying to use netmap with cxgbe driver. >> >> Regards, >> Navdeep >> >> On Thu, Feb 09, 2017 at 10:29:08AM -0500, John Jasen wrote: >>> It's not the hardware. >>> >>> Jordan booted up CentOS on the box, and untuned, were able to obtain >>> over 3 mpps. >>> >>> He has some pmcstat output from freebsd-current, but basically, it >>> appears the system spends most of its time looking for a CPU to service >>> the interrupts and keeps landing on one or two of them, as opposed to >>> any of the other 16 cores on the physical silicon. >>> >>> We also tried swapping out the T5 card for a Mellanox, tried different >>> PCIe slots, adjusted cpuset for the low and the high CPUs, no matter >>> what we try, the results have been bad. >>> >>> Our network test environment is under reconstruction at the moment, but >>> our plans afterwards are to: >>> >>> a) test netmap-fwd again (the VCXL enabling works under -CURRENT?) >>> >>> b) test without netmap-fwd, and with reduced cores/physical cpus (BIOS >>> setting) >>> >>> c) potentially, test with netmap-fwd and reduced core count. >>> >>> Any other ideas out there? >>> >>> Thanks! >>> >>> >>> >>> >>> >>> >>> >>> >>> On 02/05/2017 12:55 PM, Navdeep Parhar wrote: >>>> I've been following the email thread on freebsd-net on this. The >>>> numbers you're getting are well below what the hardware is capable of. >>>> >>>> Have you tried netmap-fwd or something that bypasses the kernel? That >>>> will be a very quick way to make sure that the hardware is doing ok. >>>> >>>> In case you try netmap: >>>> cxgbe has virtual interfaces now and those are used for netmap (instead >>>> of the main interface). Add this line to /boot/loader.conf and you'll >>>> see a 'vcxl' interface for every cxl interface. >>>> hw.cxgbe.num_vis=2 >>>> It has its own MAC address and can be used like any other interface, >>>> except it has native netmap support too. You can run netmap-fwd between >>>> these vcxl ports. >>>> >>>> Regards, >>>> Navdeep >>>> >>>> On Tue, Jan 31, 2017 at 01:57:37PM -0400, Jordan Caraballo wrote: >>>>> Navdeep, Troy, >>>>> >>>>> I forwarded you this email to see if we could get feedback from both of >>>>> you. I talked with Troy during November about >>>>> >>>>> this R530 system and the use of a 40G Chelsio T-580-CR card. So far, we >>>>> have not experienced results above 1.4 million or so. >>>>> >>>>> Any help would be appreciated. >>>>> >>>>> - Jordan >>>>> >>>>> -------- Forwarded Message -------- >>>>> >>>>> Subject: Re: Disappointing packets-per-second performance results on a >>>>> Dell,PE R530 >>>>> Date: Tue, 31 Jan 2017 13:53:15 -0400 >>>>> From: Jordan Caraballo >>>>> To: Slawa Olhovchenkov >>>>> CC: freebsd-net@freebsd.org >>>>> >>>>> This are the most recent stats. No advances so far. The system has >>>>> -Current right now. >>>>> >>>>> Any help or feedback would be appreciated. >>>>> Hardware Configuration: >>>>> Dell PowerEdge R530 with 2 Intel(R) Xeon(R) E52695 CPU's, 18 cores per >>>>> cpu. Equipped with a Chelsio T-580-CR dual port in an 8x slot. >>>>> >>>>> BIOS tweaks: >>>>> Hyperthreading (or Logical Processors) is turned off. >>>>> loader.conf >>>>> # Chelsio Modules >>>>> t4fw_cfg_load="YES" >>>>> t5fw_cfg_load="YES" >>>>> if_cxgbe_load="YES" >>>>> rc.conf >>>>> # Gateway Configuration >>>>> ifconfig_cxl0="inet 172.16.1.1/24" >>>>> ifconfig_cxl1="inet 172.16.2.1/24" >>>>> gateway_enable="YES" >>>>> >>>>> Last Results: >>>>> packets errs idrops bytes packets errs bytes colls drops >>>>> 2.7M 0 2.0M 1.4G 696k 0 368M 0 0 >>>>> 2.7M 0 2.0M 1.4G 686k 0 363M 0 0 >>>>> 2.6M 0 2.0M 1.4G 668k 0 353M 0 0 >>>>> 2.7M 0 2.0M 1.4G 661k 0 350M 0 0 >>>>> 2.8M 0 2.1M 1.5G 697k 0 369M 0 0 >>>>> 2.8M 0 2.1M 1.4G 684k 0 361M 0 0 >>>>> 2.7M 0 2.1M 1.4G 674k 0 356M 0 0 >>>>> >>>>> root@router1:~ # vmstat -i >>>>> >>>>> interrupt total rate >>>>> irq9: acpi0 73 0 >>>>> irq18: ehci0 ehci1 1155973 3 >>>>> cpu0:timer 3551157 10 >>>>> cpu29:timer 9303048 27 >>>>> cpu9:timer 71693455 207 >>>>> cpu16:timer 9798380 28 >>>>> cpu18:timer 9287094 27 >>>>> cpu26:timer 9342495 27 >>>>> cpu20:timer 9145888 26 >>>>> cpu8:timer 9791228 28 >>>>> cpu22:timer 9288116 27 >>>>> cpu35:timer 9376578 27 >>>>> cpu30:timer 9396294 27 >>>>> cpu23:timer 9248760 27 >>>>> cpu10:timer 9756455 28 >>>>> cpu25:timer 9300202 27 >>>>> cpu27:timer 9227291 27 >>>>> cpu14:timer 10083548 29 >>>>> cpu28:timer 9325684 27 >>>>> cpu11:timer 9906405 29 >>>>> cpu34:timer 9419170 27 >>>>> cpu31:timer 9392089 27 >>>>> cpu33:timer 9350540 27 >>>>> cpu15:timer 9804551 28 >>>>> cpu32:timer 9413182 27 >>>>> cpu19:timer 9231505 27 >>>>> cpu12:timer 9813506 28 >>>>> cpu13:timer 10872130 31 >>>>> cpu4:timer 9920237 29 >>>>> cpu2:timer 9786498 28 >>>>> cpu3:timer 9896011 29 >>>>> cpu5:timer 9890207 29 >>>>> cpu6:timer 9737869 28 >>>>> cpu7:timer 9790119 28 >>>>> cpu1:timer 9847913 28 >>>>> cpu21:timer 9192561 27 >>>>> cpu24:timer 9300259 27 >>>>> cpu17:timer 9786186 28 >>>>> irq264: mfi0 151818 0 >>>>> irq266: bge0 30466 0 >>>>> irq272: t5nex0:evt 4 0 >>>>> Total 402604945 1161 >>>>> top -PHS >>>>> last pid: 18557; load averages: 2.58, 1.90, 0.95 up 4+00:39:54 18:30:46 >>>>> 231 processes: 40 running, 126 sleeping, 65 waiting >>>>> CPU 0: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 1: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 2: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 3: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 4: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 5: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 6: 0.0% user, 0.0% nice, 0.4% system, 0.0% interrupt, 99.6% idle >>>>> CPU 7: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 8: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 9: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 10: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 11: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 12: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 13: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 14: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 15: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 16: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 17: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 18: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 19: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 20: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 21: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 22: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 23: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 24: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 25: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 26: 0.0% user, 0.0% nice, 0.0% system, 59.6% interrupt, 40.4% idle >>>>> CPU 27: 0.0% user, 0.0% nice, 0.0% system, 96.3% interrupt, 3.7% idle >>>>> CPU 28: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 29: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 30: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 31: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 32: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 33: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> CPU 34: 0.0% user, 0.0% nice, 0.0% system, 100% interrupt, 0.0% idle >>>>> CPU 35: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle >>>>> Mem: 15M Active, 224M Inact, 1544M Wired, 393M Buf, 29G Free >>>>> Swap: 3881M Total, 3881M Free >>>>> >>>>> pmcstat -R sample.out -G - | head >>>>> @ CPU_CLK_UNHALTED_CORE [159 samples] >>>>> >>>>> 39.62% [63] acpi_cpu_idle_mwait @ /boot/kernel/kernel >>>>> 100.0% [63] acpi_cpu_idle >>>>> 100.0% [63] cpu_idle_acpi >>>>> 100.0% [63] cpu_idle >>>>> 100.0% [63] sched_idletd >>>>> 100.0% [63] fork_exit >>>>> >>>>> 17.61% [28] cpu_idle @ /boot/kernel/kernel >>>>> >>>>> root@router1:~ # pmcstat -R sample0.out -G - | head >>>>> @ CPU_CLK_UNHALTED_CORE [750 samples] >>>>> >>>>> 31.60% [237] acpi_cpu_idle_mwait @ /boot/kernel/kernel >>>>> 100.0% [237] acpi_cpu_idle >>>>> 100.0% [237] cpu_idle_acpi >>>>> 100.0% [237] cpu_idle >>>>> 100.0% [237] sched_idletd >>>>> 100.0% [237] fork_exit >>>>> >>>>> 10.67% [80] cpu_idle @ /boot/kernel/kernel >>>>> >>>>> On 03/01/17 13:46, Slawa Olhovchenkov wrote: >>>>> >>>>> On Tue, Jan 03, 2017 at 12:35:42PM -0400, Jordan Caraballo wrote: >>>>> >>>>> >>>>> We recently tested a Dell R530 with a Chelsio T580 card, under FreeBSD 10.3, 11.0, -STABLE and -CURRENT, and Centos 7. >>>>> >>>>> Based on our research, including netmap-fwd and with the routing improvements project (https://wiki.freebsd.org/ProjectsRoutingProposal), >>>>> we hoped for packets-per-second (pps) in the 5+ million range, or even higher. >>>>> >>>>> Based on prior testing (http://marc.info/?t=140604252400002&r=1&w=2), we expected 3-4 Million to be easily obtainable. >>>>> >>>>> Unfortunately, our current results top out at no more than 1.5 M (64 bytes length packets) with FreeBSD, and >>>>> surprisingly around 3.2 M (128 bytes length packets) with Centos 7, and we are at a loss as to why. >>>>> >>>>> Server Description: >>>>> Dell PowerEdge R530 with 2 Intel(R) Xeon(R) E52695 CPU's, 18 cores per >>>>> cpu. Equipped with a Chelsio T-580-CR dual port in an 8x slot. >>>>> >>>>> ** Can this be a lack in support issue related to the R530's hardware? ** >>>>> >>>>> Any help appreciated! >>>>> >>>>> What hardware configuration? >>>>> What BIOS setting? >>>>> What loader.conf/sysctl.conf setting? >>>>> What `vmstat -i`? >>>>> What `top -PHS`? >>>>> what >>>>> ==== >>>>> pmcstat -S CPU_CLK_UNHALTED_CORE -l 10 -O sample.out >>>>> pmcstat -R sample.out -G out.txt >>>>> pmcstat -c 0 -S CPU_CLK_UNHALTED_CORE -l 10 -O sample0.out >>>>> pmcstat -R sample0.out -G out0.txt >>>>> ==== > > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" -- Tomorrow Will Never Die From owner-freebsd-net@freebsd.org Tue Feb 28 06:35:38 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 88E46CF147F for ; Tue, 28 Feb 2017 06:35:38 +0000 (UTC) (envelope-from ben.rubson@gmail.com) Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0BEC0DAF for ; Tue, 28 Feb 2017 06:35:38 +0000 (UTC) (envelope-from ben.rubson@gmail.com) Received: by mail-wm0-x230.google.com with SMTP id v186so77436995wmd.0 for ; Mon, 27 Feb 2017 22:35:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date :content-transfer-encoding:message-id:references:to; bh=UaI6MMtG9IpwdFVpbWDSFlBg8YgnTHpSiCDZdsq6oDs=; b=pxMAG1xLVYGKp+ZFvRx83Ei8Ffpn7yZrfATA+pFhBuDpANxZ3Lt9GjVJfZw/qrP358 DaayqY6rjv38DitMRd61j5rcRXIQ8F7oTVR6BGpoHphaaVmG/eg2Yx9DT350Cld7WHu9 ONv3Q/2CZnvdQx69bSiPLkB9cF9imm1DUD04D2dqEGMZrKS2hPtbBSIY5ywVsCe8CgNd xUgw5eG8LoqcoBd//NLvCb8BHRku8Rj4WJK3Bqv0ZG+BVG8eSpxSp3vDxOA586gMFJux Os3ABlHLeWAsK/Jtj6tQyRt8MFh+2d/ZZS/VBUWLUkYr+3Xqd6B5RAYHo/HQbkdwxFvK teyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date :content-transfer-encoding:message-id:references:to; bh=UaI6MMtG9IpwdFVpbWDSFlBg8YgnTHpSiCDZdsq6oDs=; b=On4vT9DO+PGiVqxuvLj5r68sJA5gM/tGnj9tiiUOuIlsgZug2eX6les/zF4QYsiAuq +249/eZGcRzyWtBMC2j/W+zS2csDjwAcd65w6Wlei5ZpSmjlL1ELkJTVqBjZMXq/3q0C /ehiQ3kGdNubDTbtf5O6IbSSwShYzZDqrcDNJLecL2G2Ge3VwBHi7GupKb6yG78hF902 ewbVdJ6iTB+g2MmZOk0xXecSrt9hvmtJmATgohoAnMYA4cwGmctecG3LkEJ9kvzfAET1 eD4f170YlSWXSGXtyKXQucSH8iVWCn+JMv85xucjvLbceJnP+RrZlDO+OwgcUwJzFDrC A5yg== X-Gm-Message-State: AMke39lDdGMWDguQ0KNqecp2mjYuqVC5KNOXr0OA5X07n7icAb5yIHnBQBTdRAqKo9/1xg== X-Received: by 10.28.20.144 with SMTP id 138mr15720505wmu.41.1488263734929; Mon, 27 Feb 2017 22:35:34 -0800 (PST) Received: from ben.home (LFbn-1-7159-4.w90-116.abo.wanadoo.fr. [90.116.90.4]) by smtp.gmail.com with ESMTPSA id v130sm7444280wmv.2.2017.02.27.22.35.33 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 27 Feb 2017 22:35:34 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: Disappointing packets-per-second performance results on a Dell, PE R530 From: Ben RUBSON In-Reply-To: <6ad029e0-86c6-af3d-8fc3-694d4bcdc683@gmail.com> Date: Tue, 28 Feb 2017 07:35:35 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <7546B456-94A9-4603-A07F-4E0AB0285E1A@gmail.com> References: <40a413f3-2c44-ee9d-9961-67114d8dffca@gmail.com> <20170205175531.GA20287@dwarf> <7d349edd-0c81-2e3f-d3b9-27af232de76d@gmail.com> <20170209153409.GG41673@dwarf> <6ad029e0-86c6-af3d-8fc3-694d4bcdc683@gmail.com> To: FreeBSD Net X-Mailer: Apple Mail (2.3124) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 06:35:38 -0000 Hi, Try disabling NUMA in your BIOS settings ? I had perf issue on a 2-CPU (24 cores) server, I was not able to run a = 40G NIC at its max throughput. We investigated a lot, disabling NUMA in the BIOS was the solution, as = NUMA is not fully supported yet (as of stable/11). Ben > On 28 Feb 2017, at 03:13, Caraballo-vega, Jordan A. = (GSFC-6062)[COMPUTER SCIENCE CORP] wrote: >=20 > As a summarywe have a Dell R530 with a Chelsio T580 cardwith -CURRENT. >=20 > In an attempt to reduce the time the system was taking to look for the > cpus; we changed the BIOS setting to let the system have 8 visible = cores > and tested cxl* and vcxl* chelsio interfaces. Scores are still way = lower > than what we expected: >=20 > Cxl interface >=20 > root@router1:~ # netstat -w1 -h > input (Total) output > packets errs idrops bytes packets errs bytes colls > 4.1M 0 3.4M 2.1G 725k 0 383M 0 > 3.7M 0 3.1M 1.9G 636k 0 336M 0 > 3.9M 0 3.2M 2.0G 684k 0 362M 0 > 4.0M 0 3.3M 2.1G 702k 0 371M 0 > 3.8M 0 3.2M 2.0G 658k 0 348M 0 > 3.9M 0 3.2M 2.0G 658k 0 348M 0 > 3.9M 0 3.2M 2.0G 721k 0 381M 0 > 3.3M 0 2.6M 1.7G 681k 0 360M 0 > 3.2M 0 2.5M 1.7G 666k 0 352M 0 > 2.6M 0 2.0M 1.4G 620k 0 328M 0 > 2.8M 0 2.1M 1.4G 615k 0 325M 0 > 3.2M 0 2.6M 1.7G 612k 0 323M 0 > 3.3M 0 2.7M 1.7G 664k 0 351M 0 >=20 >=20 > Vcxl interface > input (Total) output > packets errs idrops bytes packets errs bytes colls = drops > 590k 7.5k 0 314M 590k 0 314M 0 = 0 > 526k 6.6k 0 280M 526k 0 280M 0 = 0 > 588k 7.1k 0 313M 588k 0 313M 0 = 0 > 532k 6.6k 0 283M 532k 0 283M 0 = 0 > 578k 7.2k 0 307M 578k 0 307M 0 = 0 > 565k 7.0k 0 300M 565k 0 300M 0 = 0 > 558k 7.0k 0 297M 558k 0 297M 0 = 0 > 533k 6.7k 0 284M 533k 0 284M 0 = 0 > 588k 7.3k 0 313M 588k 0 313M 0 = 0 > 553k 6.9k 0 295M 554k 0 295M 0 = 0 > 527k 6.7k 0 281M 527k 0 281M 0 = 0 > 585k 7.4k 0 311M 585k 0 311M 0 = 0 >=20 > Related to pmcstat scores are: >=20 > root@router1:~/PMC_Stats/Feb22 # pmcstat -R sample.out -G - | head > @ CPU_CLK_UNHALTED_CORE [2091 samples] >=20 > 15.35% [321] lock_delay @ /boot/kernel/kernel > 94.70% [304] _mtx_lock_spin_cookie > 100.0% [304] __mtx_lock_spin_flags > 57.89% [176] pmclog_loop @ /boot/kernel/hwpmc.ko > 100.0% [176] fork_exit @ /boot/kernel/kernel > 41.12% [125] pmclog_reserve @ /boot/kernel/hwpmc.ko > 100.0% [125] pmclog_process_callchain > 100.0% [125] pmc_process_samples >=20 > root@router1:~/PMC_Stats/Feb22 # pmcstat -R sample0.out -G - | head > @ CPU_CLK_UNHALTED_CORE [480 samples] >=20 > 37.29% [179] acpi_cpu_idle_mwait @ /boot/kernel/kernel > 100.0% [179] acpi_cpu_idle > 100.0% [179] cpu_idle_acpi > 100.0% [179] cpu_idle > 100.0% [179] sched_idletd > 100.0% [179] fork_exit >=20 > 12.92% [62] cpu_idle @ /boot/kernel/kernel >=20 > When trying to run pmcstat with the vcxl interfaces enabled the system > just went to a state of not responding. >=20 > Based on previous scores with Centos 7 (over 3M pps), we can assume = that > it is not the hardware. However, we are still looking for a reason of > why are we getting these scores. >=20 > Any feedback or suggestion would be highly appreciated. >=20 > - Jordan >=20 > On 2/9/17 11:34 AM, Navdeep Parhar wrote: >> The vcxl interfaces should work under current or 11-STABLE. Let me = know >> if you run into any trouble when trying to use netmap with cxgbe = driver. >>=20 >> Regards, >> Navdeep >>=20 >> On Thu, Feb 09, 2017 at 10:29:08AM -0500, John Jasen wrote: >>> It's not the hardware. >>>=20 >>> Jordan booted up CentOS on the box, and untuned, were able to obtain >>> over 3 mpps. >>>=20 >>> He has some pmcstat output from freebsd-current, but basically, it >>> appears the system spends most of its time looking for a CPU to = service >>> the interrupts and keeps landing on one or two of them, as opposed = to >>> any of the other 16 cores on the physical silicon. >>>=20 >>> We also tried swapping out the T5 card for a Mellanox, tried = different >>> PCIe slots, adjusted cpuset for the low and the high CPUs, no matter >>> what we try, the results have been bad. >>>=20 >>> Our network test environment is under reconstruction at the moment, = but >>> our plans afterwards are to: >>>=20 >>> a) test netmap-fwd again (the VCXL enabling works under -CURRENT?) >>>=20 >>> b) test without netmap-fwd, and with reduced cores/physical cpus = (BIOS >>> setting) >>>=20 >>> c) potentially, test with netmap-fwd and reduced core count. >>>=20 >>> Any other ideas out there? >>>=20 >>> Thanks! >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>>=20 >>> On 02/05/2017 12:55 PM, Navdeep Parhar wrote: >>>> I've been following the email thread on freebsd-net on this. The >>>> numbers you're getting are well below what the hardware is capable = of. >>>>=20 >>>> Have you tried netmap-fwd or something that bypasses the kernel? = That >>>> will be a very quick way to make sure that the hardware is doing = ok. >>>>=20 >>>> In case you try netmap: >>>> cxgbe has virtual interfaces now and those are used for netmap = (instead >>>> of the main interface). Add this line to /boot/loader.conf and = you'll >>>> see a 'vcxl' interface for every cxl interface. >>>> hw.cxgbe.num_vis=3D2 >>>> It has its own MAC address and can be used like any other = interface, >>>> except it has native netmap support too. You can run netmap-fwd = between >>>> these vcxl ports. >>>>=20 >>>> Regards, >>>> Navdeep >>>>=20 >>>> On Tue, Jan 31, 2017 at 01:57:37PM -0400, Jordan Caraballo wrote: >>>>> Navdeep, Troy, >>>>>=20 >>>>> I forwarded you this email to see if we could get feedback from = both of >>>>> you. I talked with Troy during November about >>>>>=20 >>>>> this R530 system and the use of a 40G Chelsio T-580-CR card. So = far, we >>>>> have not experienced results above 1.4 million or so. >>>>>=20 >>>>> Any help would be appreciated. >>>>>=20 >>>>> - Jordan >>>>>=20 >>>>> -------- Forwarded Message -------- >>>>>=20 >>>>> Subject: Re: Disappointing packets-per-second performance = results on a =20 >>>>> Dell,PE R530 = =20 >>>>> Date: Tue, 31 Jan 2017 13:53:15 -0400 = =20 >>>>> From: Jordan Caraballo = =20 >>>>> To: Slawa Olhovchenkov = =20 >>>>> CC: freebsd-net@freebsd.org = =20 >>>>>=20 >>>>> This are the most recent stats. No advances so far. The system = has >>>>> -Current right now. >>>>>=20 >>>>> Any help or feedback would be appreciated. >>>>> Hardware Configuration: >>>>> Dell PowerEdge R530 with 2 Intel(R) Xeon(R) E52695 CPU's, 18 = cores per >>>>> cpu. Equipped with a Chelsio T-580-CR dual port in an 8x slot. >>>>>=20 >>>>> BIOS tweaks: >>>>> Hyperthreading (or Logical Processors) is turned off. >>>>> loader.conf >>>>> # Chelsio Modules >>>>> t4fw_cfg_load=3D"YES" >>>>> t5fw_cfg_load=3D"YES" >>>>> if_cxgbe_load=3D"YES" >>>>> rc.conf >>>>> # Gateway Configuration >>>>> ifconfig_cxl0=3D"inet 172.16.1.1/24" >>>>> ifconfig_cxl1=3D"inet 172.16.2.1/24" >>>>> gateway_enable=3D"YES" >>>>>=20 >>>>> Last Results: >>>>> packets errs idrops bytes packets errs bytes colls drops >>>>> 2.7M 0 2.0M 1.4G 696k 0 368M 0 0 >>>>> 2.7M 0 2.0M 1.4G 686k 0 363M 0 0 >>>>> 2.6M 0 2.0M 1.4G 668k 0 353M 0 0 >>>>> 2.7M 0 2.0M 1.4G 661k 0 350M 0 0 >>>>> 2.8M 0 2.1M 1.5G 697k 0 369M 0 0 >>>>> 2.8M 0 2.1M 1.4G 684k 0 361M 0 0 >>>>> 2.7M 0 2.1M 1.4G 674k 0 356M 0 0 >>>>>=20 >>>>> root@router1:~ # vmstat -i >>>>>=20 >>>>> interrupt total rate >>>>> irq9: acpi0 73 0 >>>>> irq18: ehci0 ehci1 1155973 3=20 >>>>> cpu0:timer 3551157 10 >>>>> cpu29:timer 9303048 27 >>>>> cpu9:timer 71693455 207 >>>>> cpu16:timer 9798380 28 >>>>> cpu18:timer 9287094 27 >>>>> cpu26:timer 9342495 27 >>>>> cpu20:timer 9145888 26 >>>>> cpu8:timer 9791228 28 >>>>> cpu22:timer 9288116 27 >>>>> cpu35:timer 9376578 27 >>>>> cpu30:timer 9396294 27 >>>>> cpu23:timer 9248760 27 >>>>> cpu10:timer 9756455 28 >>>>> cpu25:timer 9300202 27 >>>>> cpu27:timer 9227291 27 >>>>> cpu14:timer 10083548 29 >>>>> cpu28:timer 9325684 27 >>>>> cpu11:timer 9906405 29 >>>>> cpu34:timer 9419170 27 >>>>> cpu31:timer 9392089 27 >>>>> cpu33:timer 9350540 27 >>>>> cpu15:timer 9804551 28 >>>>> cpu32:timer 9413182 27 >>>>> cpu19:timer 9231505 27 >>>>> cpu12:timer 9813506 28 >>>>> cpu13:timer 10872130 31 >>>>> cpu4:timer 9920237 29 >>>>> cpu2:timer 9786498 28 >>>>> cpu3:timer 9896011 29 >>>>> cpu5:timer 9890207 29 >>>>> cpu6:timer 9737869 28 >>>>> cpu7:timer 9790119 28 >>>>> cpu1:timer 9847913 28 >>>>> cpu21:timer 9192561 27 >>>>> cpu24:timer 9300259 27 >>>>> cpu17:timer 9786186 28 >>>>> irq264: mfi0 151818 0 >>>>> irq266: bge0 30466 0 >>>>> irq272: t5nex0:evt 4 0 >>>>> Total 402604945 1161 >>>>> top -PHS >>>>> last pid: 18557; load averages: 2.58, 1.90, 0.95 up 4+00:39:54 = 18:30:46 >>>>> 231 processes: 40 running, 126 sleeping, 65 waiting >>>>> CPU 0: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 1: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 2: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 3: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 4: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 5: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 6: 0.0% user, 0.0% nice, 0.4% system, 0.0% interrupt, 99.6% = idle >>>>> CPU 7: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 8: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 9: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 10: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 11: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 12: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 13: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 14: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 15: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 16: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 17: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 18: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 19: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 20: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 21: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 22: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 23: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 24: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 25: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 26: 0.0% user, 0.0% nice, 0.0% system, 59.6% interrupt, = 40.4% idle >>>>> CPU 27: 0.0% user, 0.0% nice, 0.0% system, 96.3% interrupt, 3.7% = idle >>>>> CPU 28: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 29: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 30: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 31: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 32: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 33: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> CPU 34: 0.0% user, 0.0% nice, 0.0% system, 100% interrupt, 0.0% = idle >>>>> CPU 35: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>> Mem: 15M Active, 224M Inact, 1544M Wired, 393M Buf, 29G Free >>>>> Swap: 3881M Total, 3881M Free >>>>>=20 >>>>> pmcstat -R sample.out -G - | head >>>>> @ CPU_CLK_UNHALTED_CORE [159 samples] >>>>>=20 >>>>> 39.62% [63] acpi_cpu_idle_mwait @ /boot/kernel/kernel >>>>> 100.0% [63] acpi_cpu_idle >>>>> 100.0% [63] cpu_idle_acpi >>>>> 100.0% [63] cpu_idle >>>>> 100.0% [63] sched_idletd >>>>> 100.0% [63] fork_exit >>>>>=20 >>>>> 17.61% [28] cpu_idle @ /boot/kernel/kernel >>>>>=20 >>>>> root@router1:~ # pmcstat -R sample0.out -G - | head >>>>> @ CPU_CLK_UNHALTED_CORE [750 samples] >>>>>=20 >>>>> 31.60% [237] acpi_cpu_idle_mwait @ /boot/kernel/kernel >>>>> 100.0% [237] acpi_cpu_idle >>>>> 100.0% [237] cpu_idle_acpi >>>>> 100.0% [237] cpu_idle >>>>> 100.0% [237] sched_idletd >>>>> 100.0% [237] fork_exit >>>>>=20 >>>>> 10.67% [80] cpu_idle @ /boot/kernel/kernel >>>>>=20 >>>>> On 03/01/17 13:46, Slawa Olhovchenkov wrote: >>>>>=20 >>>>> On Tue, Jan 03, 2017 at 12:35:42PM -0400, Jordan Caraballo wrote: >>>>>=20 >>>>>=20 >>>>> We recently tested a Dell R530 with a Chelsio T580 card, under = FreeBSD 10.3, 11.0, -STABLE and -CURRENT, and Centos 7. >>>>>=20 >>>>> Based on our research, including netmap-fwd and with the routing = improvements project (https://wiki.freebsd.org/ProjectsRoutingProposal), >>>>> we hoped for packets-per-second (pps) in the 5+ million range, or = even higher. >>>>>=20 >>>>> Based on prior testing = (http://marc.info/?t=3D140604252400002&r=3D1&w=3D2), we expected 3-4 = Million to be easily obtainable. >>>>>=20 >>>>> Unfortunately, our current results top out at no more than 1.5 M = (64 bytes length packets) with FreeBSD, and >>>>> surprisingly around 3.2 M (128 bytes length packets) with Centos = 7, and we are at a loss as to why. >>>>>=20 >>>>> Server Description: >>>>> Dell PowerEdge R530 with 2 Intel(R) Xeon(R) E52695 CPU's, 18 cores = per >>>>> cpu. Equipped with a Chelsio T-580-CR dual port in an 8x slot. >>>>>=20 >>>>> ** Can this be a lack in support issue related to the R530's = hardware? ** >>>>>=20 >>>>> Any help appreciated! >>>>>=20 >>>>> What hardware configuration? >>>>> What BIOS setting? >>>>> What loader.conf/sysctl.conf setting? >>>>> What `vmstat -i`? >>>>> What `top -PHS`? >>>>> what >>>>> =3D=3D=3D=3D >>>>> pmcstat -S CPU_CLK_UNHALTED_CORE -l 10 -O sample.out >>>>> pmcstat -R sample.out -G out.txt >>>>> pmcstat -c 0 -S CPU_CLK_UNHALTED_CORE -l 10 -O sample0.out >>>>> pmcstat -R sample0.out -G out0.txt >>>>> =3D=3D=3D=3D >=20 > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" From owner-freebsd-net@freebsd.org Tue Feb 28 08:23:25 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 71624CF060A for ; Tue, 28 Feb 2017 08:23:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 60E35C84 for ; Tue, 28 Feb 2017 08:23:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v1S8NPDb085474 for ; Tue, 28 Feb 2017 08:23:25 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 213015] openvswitch and vnet jails - panic when bridge is destroyed and recreated Date: Tue, 28 Feb 2017 08:23:25 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: akoshibe@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 08:23:25 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213015 --- Comment #8 from akoshibe@gmail.com --- Created attachment 180356 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D180356&action= =3Dedit test - ignore interfaces being renamed --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Feb 28 08:24:43 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E9EAFCF069F for ; Tue, 28 Feb 2017 08:24:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D99FCD48 for ; Tue, 28 Feb 2017 08:24:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v1S8OhaK087109 for ; Tue, 28 Feb 2017 08:24:43 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 213015] openvswitch and vnet jails - panic when bridge is destroyed and recreated Date: Tue, 28 Feb 2017 08:24:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: akoshibe@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 08:24:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D213015 --- Comment #9 from akoshibe@gmail.com --- I finally had the chance to dig around more, myself. Open vSwitch seems to try to write something when a new switch is being cre= ated with ports. It would sometimes do so while the tap device is in the process= of being renamed, and ifp->if_bpf is null. Preventing the departure handler from setting if_bpf to null during renames stopped the panic: Index: net/bpf.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- net/bpf.c (revision 313973) +++ net/bpf.c (working copy) @@ -2678,6 +2678,9 @@ struct bpf_if *bp, *bp_temp; int nmatched =3D 0; + if (ifp->if_flags & IFF_RENAMING) + return; + BPF_LOCK(); /* * Find matching entries in free list. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Tue Feb 28 08:55:01 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 334EECF145F for ; Tue, 28 Feb 2017 08:55:01 +0000 (UTC) (envelope-from julien@perdition.city) Received: from relay-b03.edpnet.be (relay-b03.edpnet.be [212.71.1.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "edpnet.email", Issuer "Go Daddy Secure Certificate Authority - G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BAD1E37E for ; Tue, 28 Feb 2017 08:55:00 +0000 (UTC) (envelope-from julien@perdition.city) X-ASG-Debug-ID: 1488272088-0a88181bfd1a59d0001-QdxwpM Received: from mordor.lan ([213.219.148.14]) by relay-b03.edpnet.be with ESMTP id yDYMuzDRmGn2EUKg (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 28 Feb 2017 09:54:49 +0100 (CET) X-Barracuda-Envelope-From: julien@perdition.city X-Barracuda-Effective-Source-IP: UNKNOWN[213.219.148.14] X-Barracuda-Apparent-Source-IP: 213.219.148.14 Date: Tue, 28 Feb 2017 09:54:48 +0100 From: Julien Cigar To: Freddie Cash Cc: freebsd-net Subject: Re: VLAN + CARP ? Message-ID: <20170228085447.GK6194@mordor.lan> X-ASG-Orig-Subj: Re: VLAN + CARP ? References: <20170227231626.GJ6194@mordor.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EUwkhXZbCcD53YNR" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) X-Barracuda-Connect: UNKNOWN[213.219.148.14] X-Barracuda-Start-Time: 1488272088 X-Barracuda-Encrypted: ECDHE-RSA-AES256-GCM-SHA384 X-Barracuda-URL: https://212.71.1.220:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 2179 X-Virus-Scanned: by bsmtpd at edpnet.be X-Barracuda-BRTS-Status: 1 X-Barracuda-Bayes: INNOCENT GLOBAL 0.5000 1.0000 0.0100 X-Barracuda-Spam-Score: 0.01 X-Barracuda-Spam-Status: No, SCORE=0.01 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=6.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.36855 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 08:55:01 -0000 --EUwkhXZbCcD53YNR Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 27, 2017 at 03:37:14PM -0800, Freddie Cash wrote: > On Mon, Feb 27, 2017 at 3:16 PM, Julien Cigar wro= te: >=20 >=20 > > I wondered if it is possible to use CARP with VLAN interfaces? > > >=20 > =E2=80=8BYes, CARP-over-vLAN works well. Used just such a setup at work = for a > couple years. >=20 > Would something like this work (on 10.3)..?: > > > > =3D /etc/rc.conf =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > vlans_em0=3D"neta netb" > > create_args_neta=3D"vlan 101" > > create_args_netb=3D"vlan 102" > > > > ifconfig_em0_neta=3D"inet 192.168.1.253/24" > > ifconfig_em0_netb=3D"inet 10.209.1.253/24" > > > > ifconfig_em0_neta_alias0=3D"inet vhid 3 advskew 10 pass xx alias > > 192.168.2.254/32" > > ifconfig_em0_netb_alias0=3D"inet vhid 4 advskew 10 pass xx alias > > 10.209.1.254/32" > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > >=20 > =E2=80=8BThis is the setup we used (snipped for brevity): >=20 > # em2 is the 3rd NIC port from the top of the quad-port NIC > ifconfig_em2=3D"up" > vlans_em2=3D"vlan110 vlan2000 vlan1000 vlan1010 vlan1110" >=20 > create_args_vlan1000=3D"vlan 1000" > ifconfig_vlan1000=3D"vhid 9 pass nxsp4ss > =E2=80=8B1=E2=80=8B > advskew 128 10.1.0.1/16" >=20 > create_args_vlan2000=3D"vlan 2000" > ifconfig_vlan2000=3D"vhid 20 pass nxsp4ss2 advskew 128 12.24.13.97/27" >=20 > create_args_vlan1010=3D"vlan 1010" > ifconfig_vlan1010=3D"vhid 21 pass nxsp4ss > =E2=80=8B3 > advskew 128 12.24.12.129/26" >=20 > create_args_vlan1110=3D"vlan 1110" > ifconfig_vlan1110=3D"vhid 11 pass nxsp4ss > =E2=80=8B4 > advskew 128 12.24.10.1/26" >=20 > =E2=80=8Bem2 had no IPs associated with it, it was just the physical inte= rface that > the vlans and carp traffic went over. We also only had a single subnet p= er > vlan, so only a single IP per carp instance on each vlan. But you can do > multiples using the alias syntax like you have.=E2=80=8B excellent, this is exactly what I need, thanks! >=20 > --=20 > Freddie Cash > fjwcash@gmail.com --=20 Julien Cigar Belgian Biodiversity Platform (http://www.biodiversity.be) PGP fingerprint: EEF9 F697 4B68 D275 7B11 6A25 B2BB 3710 A204 23C0 No trees were killed in the creation of this message. However, many electrons were terribly inconvenienced. --EUwkhXZbCcD53YNR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE7vn2l0to0nV7EWolsrs3EKIEI8AFAli1OtQACgkQsrs3EKIE I8DoTxAAsPt/6DEPaXy+JevrWCZImudJbhRYyt3hV8pEuGoNpmrKdmgCoD9o71na k91uBmUQflognd468V/PkqKWmwM7RSr9vC/jiTi2FzRYLZ2EHMRMT+LKDhHRGhYB aAoSJ+EHjxDPyh3pYfb+w6zlW164tKngyCYL975t+oZu6PvFr00P3bgvZ/c/5g36 1CTALaowUdUIiOLbMd35W9UfEUXBf0NsN9I94J4Yvl5zcD3WAP4DSDUIeCwHkFv6 sMAHwDtMKwLYpj7Nqjk/w6i9i3UMVGmq1/CQwssCveOGDk7/auItRUAoK2jVbHCZ +lmvH5cx30HrobjL7S0pvg09t/T/OZIC9HOmLZWpO4E2i2CnBxyiGQTaMvKXm3eF CXDtLuKNZi+iZkvGANrbCXQMXdhF1RlDIu3Y0gUiUs5qN3Ou5F/YOKK/dDIcPtYm S6KP2Uobjg1DeBzcjrP8tdvwGLHRiqDkEicZvhhtEwkUFLLrmdMvlqNUl0yJTEDY ykCSMWYHKhf67MIivOA3BvsO/3s1ndq0drbKq3S+qkqTEFae1iO1cX+hNUP0dMuO 9FHQD0D8wGyFQpcFtWc2qm4P9xVPTRr8hTAchlKn44gVdICyMqiZBOfY4l78WouV eofVHdvOLcHah1iykVBxkBnYG2y2tZwU+TBGy+hFnBLHftZPSLo= =tBfI -----END PGP SIGNATURE----- --EUwkhXZbCcD53YNR-- From owner-freebsd-net@freebsd.org Tue Feb 28 20:07:24 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A2789CF2716 for ; Tue, 28 Feb 2017 20:07:24 +0000 (UTC) (envelope-from meyer.sydney@googlemail.com) Received: from mail-wr0-x22c.google.com (mail-wr0-x22c.google.com [IPv6:2a00:1450:400c:c0c::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2F633AE1 for ; Tue, 28 Feb 2017 20:07:24 +0000 (UTC) (envelope-from meyer.sydney@googlemail.com) Received: by mail-wr0-x22c.google.com with SMTP id u108so16265567wrb.3 for ; Tue, 28 Feb 2017 12:07:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:date:references :to:in-reply-to:message-id; bh=AjGsNzQptjSqZy7H/9XENLu3R8BTvuYWxLaNsX9+cZY=; b=CJBCtNWkHwXM78KCg30zIx9CbfloEQbDiEL6R4zwG2E8/C0VVUojv9K6gybAgu+kq5 bxjASUzzpyhXw5GAMKGJLuTVtsAC74Ul4QWJB9w9l2h6vOfx1GhN0gS5dTXPU0ezottV fLuG3jGBNCL84dNe/HP64/CbF+IGIYGXHLZM8DtIrTzHvKvyts5GxiQbWEs5CWHW97dY PQAM44gvqdKG18x92U6pFduutS2K9usBvSFojJzH+nv/1vmO4kCZqLx27BrLdgmi/x5g fZ574aVNz/JZlzemsw0FgLcNRtdIdMOw8SeRZNPuSDEitXfA6tKCnR0Gdh+z5EmXTLwE 9mVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:date:references:to:in-reply-to:message-id; bh=AjGsNzQptjSqZy7H/9XENLu3R8BTvuYWxLaNsX9+cZY=; b=eRdjmCsQVS4Qdlm4b374YHxFdUs5sIGVnZfvNt+FDdRqmDdmhcyRhwNlh2tFj+xiCf qFBVf5XCineyj4ao7790ttpHvoYO8lv/Oj6Ihy15eEZGnT4SMNs51LfSM9HJcdknjJ7Z WgA7pktXDs2mHB0pAhAMaWYB/sAGvrUmR818GUslE3Llg393htI1mSpAUNpgo5p/Xe7c ZSA/xqLzkVAGLwqFhyKCPC1zFqvuZUEvX2AdvzJKXT+728X9GRGZ6eBRcbkS2oi0eOCm 7FuJxKfwq+qd/skcNtD1UsDWEsWtHfbPjj71YmXuO9hg1TkUYSaBPmm8ZxPvvtf3LdZR /W7Q== X-Gm-Message-State: AMke39mAgNdxkSudsKu8UPsTLnq2e+K7f0ftxT1vlMvORFwYMLTtkujVEJlBrLXYv6aoRQ== X-Received: by 10.223.176.143 with SMTP id i15mr4084145wra.136.1488312438893; Tue, 28 Feb 2017 12:07:18 -0800 (PST) Received: from [10.13.0.1] (62.93-64-87.adsl-dyn.isp.belgacom.be. [87.64.93.62]) by smtp.googlemail.com with ESMTPSA id k76sm3065181wrc.12.2017.02.28.12.07.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Feb 2017 12:07:17 -0800 (PST) From: Sydney Meyer Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: Disappointing packets-per-second performance results on a Dell, PE R530 Date: Tue, 28 Feb 2017 21:07:15 +0100 References: <40a413f3-2c44-ee9d-9961-67114d8dffca@gmail.com> <20170205175531.GA20287@dwarf> <7d349edd-0c81-2e3f-d3b9-27af232de76d@gmail.com> <20170209153409.GG41673@dwarf> <6ad029e0-86c6-af3d-8fc3-694d4bcdc683@gmail.com> <7546B456-94A9-4603-A07F-4E0AB0285E1A@gmail.com> To: freebsd-net@freebsd.org In-Reply-To: <7546B456-94A9-4603-A07F-4E0AB0285E1A@gmail.com> Message-Id: <81FD8C20-B6AA-42A0-899A-62D4DA4A11DC@googlemail.com> X-Mailer: Apple Mail (2.3259) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 20:07:24 -0000 Hello, perhaps you've already gone through these, but this site summarizes also = a few important tweaks, e.g. disabling entropy harvest, etc.. Also, there are detailed and well documented benchmarks about FreeBSD = Routing Performance, IIRC, also with Chelsio Cards.. https://bsdrp.net/documentation/technical_docs/performance Sydney > On 28 Feb 2017, at 07:35, Ben RUBSON wrote: >=20 > Hi, >=20 > Try disabling NUMA in your BIOS settings ? > I had perf issue on a 2-CPU (24 cores) server, I was not able to run a = 40G NIC at its max throughput. > We investigated a lot, disabling NUMA in the BIOS was the solution, as = NUMA is not fully supported yet (as of stable/11). >=20 > Ben >=20 >=20 >=20 >> On 28 Feb 2017, at 03:13, Caraballo-vega, Jordan A. = (GSFC-6062)[COMPUTER SCIENCE CORP] wrote: >>=20 >> As a summarywe have a Dell R530 with a Chelsio T580 cardwith = -CURRENT. >>=20 >> In an attempt to reduce the time the system was taking to look for = the >> cpus; we changed the BIOS setting to let the system have 8 visible = cores >> and tested cxl* and vcxl* chelsio interfaces. Scores are still way = lower >> than what we expected: >>=20 >> Cxl interface >>=20 >> root@router1:~ # netstat -w1 -h >> input (Total) output >> packets errs idrops bytes packets errs bytes colls >> 4.1M 0 3.4M 2.1G 725k 0 383M 0 >> 3.7M 0 3.1M 1.9G 636k 0 336M 0 >> 3.9M 0 3.2M 2.0G 684k 0 362M 0 >> 4.0M 0 3.3M 2.1G 702k 0 371M 0 >> 3.8M 0 3.2M 2.0G 658k 0 348M 0 >> 3.9M 0 3.2M 2.0G 658k 0 348M 0 >> 3.9M 0 3.2M 2.0G 721k 0 381M 0 >> 3.3M 0 2.6M 1.7G 681k 0 360M 0 >> 3.2M 0 2.5M 1.7G 666k 0 352M 0 >> 2.6M 0 2.0M 1.4G 620k 0 328M 0 >> 2.8M 0 2.1M 1.4G 615k 0 325M 0 >> 3.2M 0 2.6M 1.7G 612k 0 323M 0 >> 3.3M 0 2.7M 1.7G 664k 0 351M 0 >>=20 >>=20 >> Vcxl interface >> input (Total) output >> packets errs idrops bytes packets errs bytes colls = drops >> 590k 7.5k 0 314M 590k 0 314M 0 = 0 >> 526k 6.6k 0 280M 526k 0 280M 0 = 0 >> 588k 7.1k 0 313M 588k 0 313M 0 = 0 >> 532k 6.6k 0 283M 532k 0 283M 0 = 0 >> 578k 7.2k 0 307M 578k 0 307M 0 = 0 >> 565k 7.0k 0 300M 565k 0 300M 0 = 0 >> 558k 7.0k 0 297M 558k 0 297M 0 = 0 >> 533k 6.7k 0 284M 533k 0 284M 0 = 0 >> 588k 7.3k 0 313M 588k 0 313M 0 = 0 >> 553k 6.9k 0 295M 554k 0 295M 0 = 0 >> 527k 6.7k 0 281M 527k 0 281M 0 = 0 >> 585k 7.4k 0 311M 585k 0 311M 0 = 0 >>=20 >> Related to pmcstat scores are: >>=20 >> root@router1:~/PMC_Stats/Feb22 # pmcstat -R sample.out -G - | head >> @ CPU_CLK_UNHALTED_CORE [2091 samples] >>=20 >> 15.35% [321] lock_delay @ /boot/kernel/kernel >> 94.70% [304] _mtx_lock_spin_cookie >> 100.0% [304] __mtx_lock_spin_flags >> 57.89% [176] pmclog_loop @ /boot/kernel/hwpmc.ko >> 100.0% [176] fork_exit @ /boot/kernel/kernel >> 41.12% [125] pmclog_reserve @ /boot/kernel/hwpmc.ko >> 100.0% [125] pmclog_process_callchain >> 100.0% [125] pmc_process_samples >>=20 >> root@router1:~/PMC_Stats/Feb22 # pmcstat -R sample0.out -G - | head >> @ CPU_CLK_UNHALTED_CORE [480 samples] >>=20 >> 37.29% [179] acpi_cpu_idle_mwait @ /boot/kernel/kernel >> 100.0% [179] acpi_cpu_idle >> 100.0% [179] cpu_idle_acpi >> 100.0% [179] cpu_idle >> 100.0% [179] sched_idletd >> 100.0% [179] fork_exit >>=20 >> 12.92% [62] cpu_idle @ /boot/kernel/kernel >>=20 >> When trying to run pmcstat with the vcxl interfaces enabled the = system >> just went to a state of not responding. >>=20 >> Based on previous scores with Centos 7 (over 3M pps), we can assume = that >> it is not the hardware. However, we are still looking for a reason of >> why are we getting these scores. >>=20 >> Any feedback or suggestion would be highly appreciated. >>=20 >> - Jordan >>=20 >> On 2/9/17 11:34 AM, Navdeep Parhar wrote: >>> The vcxl interfaces should work under current or 11-STABLE. Let me = know >>> if you run into any trouble when trying to use netmap with cxgbe = driver. >>>=20 >>> Regards, >>> Navdeep >>>=20 >>> On Thu, Feb 09, 2017 at 10:29:08AM -0500, John Jasen wrote: >>>> It's not the hardware. >>>>=20 >>>> Jordan booted up CentOS on the box, and untuned, were able to = obtain >>>> over 3 mpps. >>>>=20 >>>> He has some pmcstat output from freebsd-current, but basically, it >>>> appears the system spends most of its time looking for a CPU to = service >>>> the interrupts and keeps landing on one or two of them, as opposed = to >>>> any of the other 16 cores on the physical silicon. >>>>=20 >>>> We also tried swapping out the T5 card for a Mellanox, tried = different >>>> PCIe slots, adjusted cpuset for the low and the high CPUs, no = matter >>>> what we try, the results have been bad. >>>>=20 >>>> Our network test environment is under reconstruction at the moment, = but >>>> our plans afterwards are to: >>>>=20 >>>> a) test netmap-fwd again (the VCXL enabling works under -CURRENT?) >>>>=20 >>>> b) test without netmap-fwd, and with reduced cores/physical cpus = (BIOS >>>> setting) >>>>=20 >>>> c) potentially, test with netmap-fwd and reduced core count. >>>>=20 >>>> Any other ideas out there? >>>>=20 >>>> Thanks! >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>> On 02/05/2017 12:55 PM, Navdeep Parhar wrote: >>>>> I've been following the email thread on freebsd-net on this. The >>>>> numbers you're getting are well below what the hardware is capable = of. >>>>>=20 >>>>> Have you tried netmap-fwd or something that bypasses the kernel? = That >>>>> will be a very quick way to make sure that the hardware is doing = ok. >>>>>=20 >>>>> In case you try netmap: >>>>> cxgbe has virtual interfaces now and those are used for netmap = (instead >>>>> of the main interface). Add this line to /boot/loader.conf and = you'll >>>>> see a 'vcxl' interface for every cxl interface. >>>>> hw.cxgbe.num_vis=3D2 >>>>> It has its own MAC address and can be used like any other = interface, >>>>> except it has native netmap support too. You can run netmap-fwd = between >>>>> these vcxl ports. >>>>>=20 >>>>> Regards, >>>>> Navdeep >>>>>=20 >>>>> On Tue, Jan 31, 2017 at 01:57:37PM -0400, Jordan Caraballo wrote: >>>>>> Navdeep, Troy, >>>>>>=20 >>>>>> I forwarded you this email to see if we could get feedback from = both of >>>>>> you. I talked with Troy during November about >>>>>>=20 >>>>>> this R530 system and the use of a 40G Chelsio T-580-CR card. So = far, we >>>>>> have not experienced results above 1.4 million or so. >>>>>>=20 >>>>>> Any help would be appreciated. >>>>>>=20 >>>>>> - Jordan >>>>>>=20 >>>>>> -------- Forwarded Message -------- >>>>>>=20 >>>>>> Subject: Re: Disappointing packets-per-second performance = results on a =20 >>>>>> Dell,PE R530 = =20 >>>>>> Date: Tue, 31 Jan 2017 13:53:15 -0400 = =20 >>>>>> From: Jordan Caraballo = =20 >>>>>> To: Slawa Olhovchenkov = =20 >>>>>> CC: freebsd-net@freebsd.org = =20 >>>>>>=20 >>>>>> This are the most recent stats. No advances so far. The system = has >>>>>> -Current right now. >>>>>>=20 >>>>>> Any help or feedback would be appreciated. >>>>>> Hardware Configuration: >>>>>> Dell PowerEdge R530 with 2 Intel(R) Xeon(R) E52695 CPU's, 18 = cores per >>>>>> cpu. Equipped with a Chelsio T-580-CR dual port in an 8x slot. >>>>>>=20 >>>>>> BIOS tweaks: >>>>>> Hyperthreading (or Logical Processors) is turned off. >>>>>> loader.conf >>>>>> # Chelsio Modules >>>>>> t4fw_cfg_load=3D"YES" >>>>>> t5fw_cfg_load=3D"YES" >>>>>> if_cxgbe_load=3D"YES" >>>>>> rc.conf >>>>>> # Gateway Configuration >>>>>> ifconfig_cxl0=3D"inet 172.16.1.1/24" >>>>>> ifconfig_cxl1=3D"inet 172.16.2.1/24" >>>>>> gateway_enable=3D"YES" >>>>>>=20 >>>>>> Last Results: >>>>>> packets errs idrops bytes packets errs bytes colls drops >>>>>> 2.7M 0 2.0M 1.4G 696k 0 368M 0 0 >>>>>> 2.7M 0 2.0M 1.4G 686k 0 363M 0 0 >>>>>> 2.6M 0 2.0M 1.4G 668k 0 353M 0 0 >>>>>> 2.7M 0 2.0M 1.4G 661k 0 350M 0 0 >>>>>> 2.8M 0 2.1M 1.5G 697k 0 369M 0 0 >>>>>> 2.8M 0 2.1M 1.4G 684k 0 361M 0 0 >>>>>> 2.7M 0 2.1M 1.4G 674k 0 356M 0 0 >>>>>>=20 >>>>>> root@router1:~ # vmstat -i >>>>>>=20 >>>>>> interrupt total rate >>>>>> irq9: acpi0 73 0 >>>>>> irq18: ehci0 ehci1 1155973 3=20 >>>>>> cpu0:timer 3551157 10 >>>>>> cpu29:timer 9303048 27 >>>>>> cpu9:timer 71693455 207 >>>>>> cpu16:timer 9798380 28 >>>>>> cpu18:timer 9287094 27 >>>>>> cpu26:timer 9342495 27 >>>>>> cpu20:timer 9145888 26 >>>>>> cpu8:timer 9791228 28 >>>>>> cpu22:timer 9288116 27 >>>>>> cpu35:timer 9376578 27 >>>>>> cpu30:timer 9396294 27 >>>>>> cpu23:timer 9248760 27 >>>>>> cpu10:timer 9756455 28 >>>>>> cpu25:timer 9300202 27 >>>>>> cpu27:timer 9227291 27 >>>>>> cpu14:timer 10083548 29 >>>>>> cpu28:timer 9325684 27 >>>>>> cpu11:timer 9906405 29 >>>>>> cpu34:timer 9419170 27 >>>>>> cpu31:timer 9392089 27 >>>>>> cpu33:timer 9350540 27 >>>>>> cpu15:timer 9804551 28 >>>>>> cpu32:timer 9413182 27 >>>>>> cpu19:timer 9231505 27 >>>>>> cpu12:timer 9813506 28 >>>>>> cpu13:timer 10872130 31 >>>>>> cpu4:timer 9920237 29 >>>>>> cpu2:timer 9786498 28 >>>>>> cpu3:timer 9896011 29 >>>>>> cpu5:timer 9890207 29 >>>>>> cpu6:timer 9737869 28 >>>>>> cpu7:timer 9790119 28 >>>>>> cpu1:timer 9847913 28 >>>>>> cpu21:timer 9192561 27 >>>>>> cpu24:timer 9300259 27 >>>>>> cpu17:timer 9786186 28 >>>>>> irq264: mfi0 151818 0 >>>>>> irq266: bge0 30466 0 >>>>>> irq272: t5nex0:evt 4 0 >>>>>> Total 402604945 1161 >>>>>> top -PHS >>>>>> last pid: 18557; load averages: 2.58, 1.90, 0.95 up 4+00:39:54 = 18:30:46 >>>>>> 231 processes: 40 running, 126 sleeping, 65 waiting >>>>>> CPU 0: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 1: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 2: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 3: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 4: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 5: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 6: 0.0% user, 0.0% nice, 0.4% system, 0.0% interrupt, 99.6% = idle >>>>>> CPU 7: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 8: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 9: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 10: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 11: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 12: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 13: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 14: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 15: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 16: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 17: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 18: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 19: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 20: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 21: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 22: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 23: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 24: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 25: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 26: 0.0% user, 0.0% nice, 0.0% system, 59.6% interrupt, = 40.4% idle >>>>>> CPU 27: 0.0% user, 0.0% nice, 0.0% system, 96.3% interrupt, 3.7% = idle >>>>>> CPU 28: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 29: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 30: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 31: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 32: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 33: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> CPU 34: 0.0% user, 0.0% nice, 0.0% system, 100% interrupt, 0.0% = idle >>>>>> CPU 35: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% = idle >>>>>> Mem: 15M Active, 224M Inact, 1544M Wired, 393M Buf, 29G Free >>>>>> Swap: 3881M Total, 3881M Free >>>>>>=20 >>>>>> pmcstat -R sample.out -G - | head >>>>>> @ CPU_CLK_UNHALTED_CORE [159 samples] >>>>>>=20 >>>>>> 39.62% [63] acpi_cpu_idle_mwait @ /boot/kernel/kernel >>>>>> 100.0% [63] acpi_cpu_idle >>>>>> 100.0% [63] cpu_idle_acpi >>>>>> 100.0% [63] cpu_idle >>>>>> 100.0% [63] sched_idletd >>>>>> 100.0% [63] fork_exit >>>>>>=20 >>>>>> 17.61% [28] cpu_idle @ /boot/kernel/kernel >>>>>>=20 >>>>>> root@router1:~ # pmcstat -R sample0.out -G - | head >>>>>> @ CPU_CLK_UNHALTED_CORE [750 samples] >>>>>>=20 >>>>>> 31.60% [237] acpi_cpu_idle_mwait @ /boot/kernel/kernel >>>>>> 100.0% [237] acpi_cpu_idle >>>>>> 100.0% [237] cpu_idle_acpi >>>>>> 100.0% [237] cpu_idle >>>>>> 100.0% [237] sched_idletd >>>>>> 100.0% [237] fork_exit >>>>>>=20 >>>>>> 10.67% [80] cpu_idle @ /boot/kernel/kernel >>>>>>=20 >>>>>> On 03/01/17 13:46, Slawa Olhovchenkov wrote: >>>>>>=20 >>>>>> On Tue, Jan 03, 2017 at 12:35:42PM -0400, Jordan Caraballo wrote: >>>>>>=20 >>>>>>=20 >>>>>> We recently tested a Dell R530 with a Chelsio T580 card, under = FreeBSD 10.3, 11.0, -STABLE and -CURRENT, and Centos 7. >>>>>>=20 >>>>>> Based on our research, including netmap-fwd and with the routing = improvements project (https://wiki.freebsd.org/ProjectsRoutingProposal), >>>>>> we hoped for packets-per-second (pps) in the 5+ million range, or = even higher. >>>>>>=20 >>>>>> Based on prior testing = (http://marc.info/?t=3D140604252400002&r=3D1&w=3D2), we expected 3-4 = Million to be easily obtainable. >>>>>>=20 >>>>>> Unfortunately, our current results top out at no more than 1.5 M = (64 bytes length packets) with FreeBSD, and >>>>>> surprisingly around 3.2 M (128 bytes length packets) with Centos = 7, and we are at a loss as to why. >>>>>>=20 >>>>>> Server Description: >>>>>> Dell PowerEdge R530 with 2 Intel(R) Xeon(R) E52695 CPU's, 18 = cores per >>>>>> cpu. Equipped with a Chelsio T-580-CR dual port in an 8x slot. >>>>>>=20 >>>>>> ** Can this be a lack in support issue related to the R530's = hardware? ** >>>>>>=20 >>>>>> Any help appreciated! >>>>>>=20 >>>>>> What hardware configuration? >>>>>> What BIOS setting? >>>>>> What loader.conf/sysctl.conf setting? >>>>>> What `vmstat -i`? >>>>>> What `top -PHS`? >>>>>> what >>>>>> =3D=3D=3D=3D >>>>>> pmcstat -S CPU_CLK_UNHALTED_CORE -l 10 -O sample.out >>>>>> pmcstat -R sample.out -G out.txt >>>>>> pmcstat -c 0 -S CPU_CLK_UNHALTED_CORE -l 10 -O sample0.out >>>>>> pmcstat -R sample0.out -G out0.txt >>>>>> =3D=3D=3D=3D >>=20 >> _______________________________________________ >> freebsd-net@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-net >> To unsubscribe, send any mail to = "freebsd-net-unsubscribe@freebsd.org" >=20 > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" From owner-freebsd-net@freebsd.org Tue Feb 28 20:18:53 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0F6ECCF2AA9 for ; Tue, 28 Feb 2017 20:18:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F290E27D for ; Tue, 28 Feb 2017 20:18:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v1SKIqka030863 for ; Tue, 28 Feb 2017 20:18:52 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217413] panic: Assertion err == 0 failed at /usr/src/sys/net/iflib.c:2242 after attaching the cable with 1000m fixed speed at another end Date: Tue, 28 Feb 2017 20:18:52 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2017 20:18:53 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217413 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-bugs@FreeBSD.org |freebsd-net@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Mar 1 00:28:49 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C6987CF176E for ; Wed, 1 Mar 2017 00:28:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B5ED3CFC for ; Wed, 1 Mar 2017 00:28:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v210SmDK090136 for ; Wed, 1 Mar 2017 00:28:49 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 196361] Constrain IPv6 routes to each FIB (Consistent with IPv4 route behaviour) Date: Wed, 01 Mar 2017 00:28:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.1-RELEASE X-Bugzilla-Keywords: needs-patch, needs-qa X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 00:28:49 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D196361 --- Comment #18 from commit-hook@freebsd.org --- A commit references this bug: Author: asomers Date: Wed Mar 1 00:28:04 UTC 2017 New revision: 314442 URL: https://svnweb.freebsd.org/changeset/base/314442 Log: Add an ATF test for IPv6 SLAAC with multiple fibs Tests that an interface can get a SLAAC address and that it inserts its routes into the correct fib. Does not test anything to do with NDP. PR: 196361 Reviewed by: Erick Turnquist MFC after: 3 weeks Sponsored by: Spectra Logic Corp Differential Revision: https://reviews.freebsd.org/D9776 Changes: head/tests/sys/netinet/fibs_test.sh --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Mar 1 14:44:28 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 64B4BCF0572 for ; Wed, 1 Mar 2017 14:44:28 +0000 (UTC) (envelope-from olivier@freebsd.org) Received: from smtp.smtpout.orange.fr (smtp05.smtpout.orange.fr [80.12.242.127]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (Client CN "Bizanga Labs SMTP Client Certificate", Issuer "Bizanga Labs CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 93E4D403 for ; Wed, 1 Mar 2017 14:44:26 +0000 (UTC) (envelope-from olivier@freebsd.org) Received: from mail-yw0-f171.google.com ([209.85.161.171]) by mwinf5d62 with ME id qekJ1u0053iAumh03ekJJU; Wed, 01 Mar 2017 15:44:19 +0100 X-ME-Helo: mail-yw0-f171.google.com X-ME-Auth: Y29jaGFyZC1sYWJiZS5vbGl2aWVyQG9yYW5nZS5mcg== X-ME-Date: Wed, 01 Mar 2017 15:44:19 +0100 X-ME-IP: 209.85.161.171 Received: by mail-yw0-f171.google.com with SMTP id p77so32847541ywg.1 for ; Wed, 01 Mar 2017 06:44:18 -0800 (PST) X-Gm-Message-State: AMke39lie3XwLbRMU4bU9fZHWbFNJxxOcDaAwFGavHaJgv3NpPicuT0aExsUU/+yK3qeXH4WTEpQZ9EdxMY/IQ== X-Received: by 10.129.168.193 with SMTP id f184mr2907855ywh.278.1488379457606; Wed, 01 Mar 2017 06:44:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.37.198.205 with HTTP; Wed, 1 Mar 2017 06:43:57 -0800 (PST) In-Reply-To: <6ad029e0-86c6-af3d-8fc3-694d4bcdc683@gmail.com> References: <40a413f3-2c44-ee9d-9961-67114d8dffca@gmail.com> <20170205175531.GA20287@dwarf> <7d349edd-0c81-2e3f-d3b9-27af232de76d@gmail.com> <20170209153409.GG41673@dwarf> <6ad029e0-86c6-af3d-8fc3-694d4bcdc683@gmail.com> From: =?UTF-8?Q?Olivier_Cochard=2DLabb=C3=A9?= Date: Wed, 1 Mar 2017 15:43:57 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Fwd: Re: Disappointing packets-per-second performance results on a Dell,PE R530 To: "Caraballo-vega, Jordan A. (GSFC-6062)[COMPUTER SCIENCE CORP]" Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 14:44:28 -0000 On Tue, Feb 28, 2017 at 3:13 AM, Caraballo-vega, Jordan A. (GSFC-6062)[COMPUTER SCIENCE CORP] wrote: > As a summarywe have a Dell R530 with a Chelsio T580 cardwith -CURRENT. > > In an attempt to reduce the time the system was taking to look for the > cpus; we changed the BIOS setting to let the system have 8 visible cores > and tested cxl* and vcxl* chelsio interfaces. Scores are still way lower > than what we expected: > > > Based on previous scores with Centos 7 (over 3M pps), we can assume that > it is not the hardware. However, we are still looking for a reason of > why are we getting these scores. > > Any feedback or suggestion would be highly appreciated. > > =E2=80=8BDuring your bench load, can you display=E2=80=8B =E2=80=8Beach queue usage of your cxl interface and post the result here ? You can use this python script (from Alexander Chernikov): https://github.com/ocochard/BSDRP/blob/master/BSDRP/Files/usr/local/bin/nic= -queue-usage Here is an example showing traffic shared between all 8 queues: [root@hp]~# nic-queue-usage cxl0 [Q0 346K/s] [Q1 343K/s] [Q2 339K/s] [Q3 338K/s] [Q4 338K/s] [Q5 338K/s] [Q6 343K/s] [Q7 346K/s] [QT 2734K/s 3269K/s -> 0K/s] [Q0 347K/s] [Q1 344K/s] [Q2 339K/s] [Q3 339K/s] [Q4 338K/s] [Q5 338K/s] [Q6 343K/s] [Q7 346K/s] [QT 2735K/s 3277K/s -> 0K/s] [Q0 344K/s] [Q1 341K/s] [Q2 338K/s] [Q3 338K/s] [Q4 337K/s] [Q5 337K/s] [Q6 342K/s] [Q7 345K/s] [QT 2727K/s 3262K/s -> 0K/s] [Q0 355K/s] [Q1 352K/s] [Q2 348K/s] [Q3 349K/s] [Q4 348K/s] [Q5 347K/s] [Q6 352K/s] [Q7 355K/s] [QT 2809K/s 3381K/s -> 0K/s] [Q0 351K/s] [Q1 348K/s] [Q2 344K/s] [Q3 343K/s] [Q4 342K/s] [Q5 344K/s] [Q6 349K/s] [Q7 352K/s] [QT 2776K/s 3288K/s -> 0K/s] [Q0 344K/s] [Q1 341K/s] [Q2 338K/s] [Q3 339K/s] [Q4 338K/s] [Q5 338K/s] [Q6 343K/s] [Q7 346K/s] [QT 2731K/s 3261K/s -> 0K/s] Thanks From owner-freebsd-net@freebsd.org Wed Mar 1 15:36:12 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7E47BCF2579 for ; Wed, 1 Mar 2017 15:36:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6D6AA9FF for ; Wed, 1 Mar 2017 15:36:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v21FaBTV030731 for ; Wed, 1 Mar 2017 15:36:12 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 212749] bridge fragment can leak mbufs Date: Wed, 01 Mar 2017 15:36:12 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: aiko@torrentkino.de X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 15:36:12 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D212749 Aiko Barz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aiko@torrentkino.de --- Comment #2 from Aiko Barz --- (In reply to Olivier Cochard from comment #1) That patch you described is not yet part of the 11.0 release. Am I right? Kind regards, Aiko --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Mar 1 15:41:50 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CDA9CCF26C9 for ; Wed, 1 Mar 2017 15:41:50 +0000 (UTC) (envelope-from koue@chaosophia.net) Received: from chaosophia.net (chaosophia.net [91.121.173.144]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "chaosophia.net", Issuer "chaosophia.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 77755E7E for ; Wed, 1 Mar 2017 15:41:49 +0000 (UTC) (envelope-from koue@chaosophia.net) Received: from chaosophia.net (localhost [127.0.0.1]) by chaosophia.net (8.15.2/8.15.2) with ESMTPS id v21FJE6W055123 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Wed, 1 Mar 2017 16:19:14 +0100 (CET) (envelope-from koue@chaosophia.net) Received: (from _prayer@localhost) by chaosophia.net (8.15.2/8.15.2/Submit) id v21FJEbQ055122 for freebsd-net@freebsd.org; Wed, 1 Mar 2017 16:19:14 +0100 (CET) (envelope-from koue@chaosophia.net) Received: from [194.97.158.70] by chaosophia.net with HTTP (Prayer-1.3.5); 01 Mar 2017 16:19:13 +0100 Date: 01 Mar 2017 16:19:13 +0100 From: Nikola Kolev To: freebsd-net@freebsd.org Subject: Sockets unexpected behavior Message-ID: X-Mailer: Prayer v1.3.5 Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=ISO-8859-1 X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on chaosophia.net X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 15:41:50 -0000 Howdy, I'm maintainer of www/obhttpd - OpenBSD httpd. Currently I'm trying to update the port to current version of httpd in OpenBSD cvs and I'm facing problem with the sockets during startup. There is major change in sockets management which cause httpd to exited abnormally on FreeBSD during startup with correct configuration file: # ./httpd -d -f ~/nkolev/httpd-multi.conf startup server: invalid location lost child: pid 55160 exited abnormally server: invalid location server: invalid location lost child: pid 55159 exited abnormally lost child: pid 55161 exited abnormally logger exiting, pid 55162 parent terminating, pid 55158 and then the output of sockstat is: # sockstat -l | grep ":80 " ? ? ? ? tcp4 192.168.104.17:80 *:* ? ? ? ? tcp4 127.0.0.1:80 *:* ? ? ? ? tcp4 192.168.104.17:80 *:* ? ? ? ? tcp4 127.0.0.1:80 *:* ? ? ? ? tcp4 192.168.104.17:80 *:* ? ? ? ? tcp4 127.0.0.1:80 *:* I'm even able to connect to the socket once: # telnet localhost 80 Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. ^] telnet> quit Connection closed. I'm facing the same problem on 11-STABLE and 10-STABLE and with IPv6 configuration also. I assume sockets should not appear in sockstat output after abnormally exit of httpd. Is this httpd problem or FreeBSD kernel problem? Regards, Nikola -- Nikola Kolev koue@chaosophia.net https://github.com/koue/ From owner-freebsd-net@freebsd.org Wed Mar 1 15:44:02 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7CB04CF28D5 for ; Wed, 1 Mar 2017 15:44:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6CBF2FDA for ; Wed, 1 Mar 2017 15:44:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v21Fi2ee048107 for ; Wed, 1 Mar 2017 15:44:02 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 212749] bridge fragment can leak mbufs Date: Wed, 01 Mar 2017 15:44:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: kp@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 15:44:02 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D212749 Kristof Provost changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kp@freebsd.org --- Comment #3 from Kristof Provost --- (In reply to Aiko Barz from comment #2) It was merged to stable/11, but I don't think that was in time for 11.0. It'll turn up in 11.1 --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Mar 1 17:37:09 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6BCDECF29B8 for ; Wed, 1 Mar 2017 17:37:09 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vps1.elischer.org", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 3F24BFBD for ; Wed, 1 Mar 2017 17:37:08 +0000 (UTC) (envelope-from julian@freebsd.org) Received: from Julian-MBP3.local (220-253-188-71.dyn.iinet.net.au [220.253.188.71]) (authenticated bits=0) by vps1.elischer.org (8.15.2/8.15.2) with ESMTPSA id v21HavEK021061 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 1 Mar 2017 09:37:01 -0800 (PST) (envelope-from julian@freebsd.org) Subject: Re: VNET / netgraph jails -- Locking down? To: Jeff Kletsky , freebsd-net@freebsd.org References: From: Julian Elischer Message-ID: <4dada28e-2130-70f3-e4b1-9d20f4185437@freebsd.org> Date: Thu, 2 Mar 2017 01:36:51 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 17:37:09 -0000 many good questions but looking at what you are doing, maybe we should be asking you the questions. Certainly firewalling on the outside of the jail makes sense. I've not used ng_ipfw but it would make sense to do a quick santity check for every packet leaving each jail. On 14/2/17 9:47 am, Jeff Kletsky wrote: > For several years I've been using netgraph to provide connectivity > for "service hosts" in jails on a "jail server" > > Since I'm finally getting the jail server off FreeBSD 9 and solidly > onto 11, I've got the chance to rewrite the scripting of how I'm > handling jail connectivity and am hoping that I can lock things down > a bit better than what I have presently. > > > The approach I use looks similar to that now in the jail examples. > Basically > > /---> ng_eiface_jail1 > real_interface = ng_ether <---> ng_bridge <---> ng_eiface_jail2 > \---> ng_eiface_jail3 > > While this works well, it concerns me that the real interface has to > be in promiscuous mode (and have autosrc off). > > If one of the service jails is "taken over" then there isn't a way > that I know of to lock out changing the IP address of the interface > it has, or potentially gaining access to another VLAN through > creation of a cloned interface, especially if the bridge is off the > parent interface, not off a VLAN interface. > > > How do people manage this in practice when the jail has the risk of > compromise? > > > I prefer approaches where the jail's notion of it's own IP address > is the same as that of other hosts connecting to it, at least within > my own little private-address-space world. > > > One thing that I've been considering is: > * Configure the jail's IP on the real interface (or appropriate VLAN > interface) as an alias > * Send packets through ng_ipfw to an ng_eiface that the jail gets, > using ipfw and a lookup table > * Tag the packets on return with ng_tag with a unique identifier for > that jail's interface so ipfw can tell the only acceptable source IP > * Deny any so-tagged packets that don't have the proper source address > > (jail ID by itself is not enough for the outbound packets, as some > of the jails are dual homed.) > > > Has anyone tried this kind of method? Any other/better suggestions? > > > Would ng_ip_input be the appropriate way to "send" the packets > coming from the jail? > > > Thanks! > > > Jeff > > > > > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > From owner-freebsd-net@freebsd.org Wed Mar 1 18:06:56 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7BD47CF3883 for ; Wed, 1 Mar 2017 18:06:56 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-yw0-x22d.google.com (mail-yw0-x22d.google.com [IPv6:2607:f8b0:4002:c05::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3B93CAB4; Wed, 1 Mar 2017 18:06:56 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-yw0-x22d.google.com with SMTP id d1so39071194ywd.2; Wed, 01 Mar 2017 10:06:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=k3BnT/guWzDPv8fW3GiqZ0+zt9x/cmhGpUAh053odtw=; b=LKBM0nCfPRlxV0ojfgYAlyfgkdC0sV5XeQhZeneuv3cdE+1R6wQX3/wx//y7tSVflD 8apMNE8hu/YjrwR62cDOhzbl7RnEpeqQoYPrhI6HXVDS+x8rRGahBsY9uKNzgGxO51R0 /bll5+7E5416guLdnoFKfvQdc9KvRrZrSgbOmKKUaHZLSA/bpXdRcucPMYZivggMXVIl 0umMdASivJpq5TZxdd0cSi1/Yrv9djWEJ5dDZKJjcWVPchFya3o5rk73UGJ9xRp4B0aT MbpJW3HIvPCOh6P3n6R6o8GzlNpIdduzWJ6CUVXTWnOU++urxClouzhLBpJZbsR1evJ0 tcWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=k3BnT/guWzDPv8fW3GiqZ0+zt9x/cmhGpUAh053odtw=; b=OGmsLvaTrzPSj20HslFmtE25tfoRny0eWCfet/2xxhP1X7jILD/GnOHV8Uc0yrR2xL qLhmiTcZLFpym1UqLAwQoKfX/2j+nTe7FZkq6aKaYJ7odBaRsxbEJ1sZCNpXc1XD06DH TM3dpevlxj/yQ9zycbDpYyXTGjGFh2oKCC4iyWE1PP9hq6+N1ar91kqIWL8CRrdIv2xe b5Bp1wnn5XUxjsOUjs7fF6x/X5elxxsBKAREmh0H2h2/8c8rPGmeHl3WwgRf523T3Lty R16Ebje2PJNAtR2cGOiVPBE7IuHWBpxR5dro0v/4hfrow2rR2lXFxqn9AKoUNkq1CEsp I2eQ== X-Gm-Message-State: AMke39mbr0HM3aM1d3YNtFRW+g3wgD+wFJFczTBQUAWR+xLIzt0/oZdt8bZYMLRkHpaelgBM5zOGjXQ37aHyFA== X-Received: by 10.129.182.79 with SMTP id h15mr3346265ywk.253.1488391615290; Wed, 01 Mar 2017 10:06:55 -0800 (PST) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.129.38.133 with HTTP; Wed, 1 Mar 2017 10:06:54 -0800 (PST) In-Reply-To: <4dada28e-2130-70f3-e4b1-9d20f4185437@freebsd.org> References: <4dada28e-2130-70f3-e4b1-9d20f4185437@freebsd.org> From: Alan Somers Date: Wed, 1 Mar 2017 11:06:54 -0700 X-Google-Sender-Auth: PWz5UCuj2GF1G1P0UYBypeiu4to Message-ID: Subject: Re: VNET / netgraph jails -- Locking down? To: Julian Elischer Cc: Jeff Kletsky , FreeBSD Net Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 18:06:56 -0000 I do something similar, but I rely entirely on vnet and PF instead of netgraph. My host has two ethernet ports, so I use one for the host and one for all of the jails. That makes the pf setup easier. I use iocage to configure an ordinary vnet jail, bridged to the host's second ethernet port. Then I configure pf.conf like this. This ensures that the only traffic allowed into the jail is that destined for its intended service, and the only traffic allowed out are responses to inbound traffic. The jail is able to change its own IP address, but if it does then PF will block all of its traffic. www_services = "{ http, https, 8080 }" host_iface = "em0" dmz_iface = "em1" www_jail_iface = "vnet0:1" www_ip = "192.168.0.40" set state-policy if-bound scrub in block in all block out all pass in on $host_iface pass out on $host_iface set skip on lo0 # Allow all traffic to the DMZ. Filtering happens on individual vnet # interfaces pass in on $dmz_iface pass out on $dmz_iface # Put the www jail in a DMZ. Don't allow outgoing traffic from it except for # the webserver pass out on $www_jail_iface proto tcp to $www_ip port $www_services keep state -Alan On Wed, Mar 1, 2017 at 10:36 AM, Julian Elischer wrote: > many good questions but looking at what you are doing, maybe we should be > asking you the questions. > Certainly firewalling on the outside of the jail makes sense. I've not used > ng_ipfw but it would make sense to do a quick santity check for every packet > leaving each jail. > > > > On 14/2/17 9:47 am, Jeff Kletsky wrote: >> >> For several years I've been using netgraph to provide connectivity for >> "service hosts" in jails on a "jail server" >> >> Since I'm finally getting the jail server off FreeBSD 9 and solidly onto >> 11, I've got the chance to rewrite the scripting of how I'm handling jail >> connectivity and am hoping that I can lock things down a bit better than >> what I have presently. >> >> >> The approach I use looks similar to that now in the jail examples. >> Basically >> >> /---> ng_eiface_jail1 >> real_interface = ng_ether <---> ng_bridge <---> ng_eiface_jail2 >> \---> ng_eiface_jail3 >> >> While this works well, it concerns me that the real interface has to be in >> promiscuous mode (and have autosrc off). >> >> If one of the service jails is "taken over" then there isn't a way that I >> know of to lock out changing the IP address of the interface it has, or >> potentially gaining access to another VLAN through creation of a cloned >> interface, especially if the bridge is off the parent interface, not off a >> VLAN interface. >> >> >> How do people manage this in practice when the jail has the risk of >> compromise? >> >> >> I prefer approaches where the jail's notion of it's own IP address is the >> same as that of other hosts connecting to it, at least within my own little >> private-address-space world. >> >> >> One thing that I've been considering is: >> * Configure the jail's IP on the real interface (or appropriate VLAN >> interface) as an alias >> * Send packets through ng_ipfw to an ng_eiface that the jail gets, using >> ipfw and a lookup table >> * Tag the packets on return with ng_tag with a unique identifier for that >> jail's interface so ipfw can tell the only acceptable source IP >> * Deny any so-tagged packets that don't have the proper source address >> >> (jail ID by itself is not enough for the outbound packets, as some of the >> jails are dual homed.) >> >> >> Has anyone tried this kind of method? Any other/better suggestions? >> >> >> Would ng_ip_input be the appropriate way to "send" the packets coming from >> the jail? >> >> >> Thanks! >> >> >> Jeff >> >> >> >> >> _______________________________________________ >> freebsd-net@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/freebsd-net >> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >> > > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" From owner-freebsd-net@freebsd.org Wed Mar 1 19:22:31 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AF101CF3323 for ; Wed, 1 Mar 2017 19:22:31 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 8B34A1CE for ; Wed, 1 Mar 2017 19:22:31 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 45CA8972; Wed, 1 Mar 2017 19:22:31 +0000 (UTC) Date: Wed, 1 Mar 2017 19:22:31 +0000 To: freebsd-net@freebsd.org From: "kczekirda (Kamil Czekirda)" Reply-to: D9847+325+deba385e191bfbb6@reviews.freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: <54c107ce8d9cfe63cf773cf928c15ea5@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: Thread-Topic: D9847: Try to extract the RFC1048 data from PXE X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: Precedence: bulk In-Reply-To: References: Thread-Index: YTlhODdhNGFiNzc3NzE3ZGRmMjFjNTkwOTA3IFi3H3c= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 19:22:31 -0000 a2N6ZWtpcmRhIGFkZGVkIGEgcmV2aWV3ZXI6IGZyZWVic2QtbmV0LWxpc3QuCgpSRVZJU0lPTiBE RVRBSUwKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvRDk4NDcKCkVNQUlMIFBSRUZFUkVO Q0VTCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL3NldHRpbmdzL3BhbmVsL2VtYWlscHJl ZmVyZW5jZXMvCgpUbzoga2N6ZWtpcmRhLCBvc2hvZ2JvLCBiYXB0LCB0c29vbWUsIGdsZWJpdXMs ICNuZXR3b3JrLCBmcmVlYnNkLW5ldC1saXN0Cg== From owner-freebsd-net@freebsd.org Wed Mar 1 20:24:48 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E872CCF361D for ; Wed, 1 Mar 2017 20:24:48 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id AB42ED91 for ; Wed, 1 Mar 2017 20:24:48 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id CFE82AC6; Wed, 1 Mar 2017 20:24:47 +0000 (UTC) Date: Wed, 1 Mar 2017 20:24:47 +0000 To: freebsd-net@freebsd.org From: "asomers (Alan Somers)" Reply-to: D9451+325+eaa6f8a0c0731bfe@reviews.freebsd.org Subject: [Differential] D9451: Constrain IPv6 interface routes to each FIB Message-ID: <8d3f0b5dadbd46bcb3b69d3ae08a332b@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: Thread-Topic: D9451: Constrain IPv6 interface routes to each FIB X-Herald-Rules: <28>, <81> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: MzA4MmVhNjA3MDYxYjk1ZGE4NzFjZWJhMzgyIFi3Lg8= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 20:24:49 -0000 YXNvbWVycyBhZGRlZCBhIGNvbW1lbnQuCgoKICBUaGlzIHJldmlldyBpcyBzdGFydGluZyB0byBs b29rIHByZXR0eSBnb29kLiAgQnV0IGluIGFkZGl0aW9uIHRvIHRoZSBmZXcgdGhpbmdzIEkgbWVu dGlvbmVkIGlubGluZSwgdGhlcmUncyBvbmUgb3RoZXIgY2hhbmdlIHRoYXQgeW91IG5lZWQgdG8g bWFrZTogeW91IGdldCB0byBjbGVhciB0aGUgYGF0Zl9leHBlY3RfZmFpbGAgc3RhdGVtZW50cyBm cm9tIHRlc3RzL3N5cy9uZXRpbmV0L2ZpYnNfdGVzdC5zaC4KCklOTElORSBDT01NRU5UUwoKPiBq aHVqaGl0aV9hZGplY3RpdmlzbS5vcmcgd3JvdGUgaW4gbmQ2LmM6MTI5NQo+IEknbSByZXRoaW5r aW5nIHRoaXMgYSBsaXR0bGUgYml0LiBXaGlsZSBJIHRoaW5rIGl0J3MgdHJ1ZSB0aGF0IHRoZSBt b3N0IGNvcnJlY3Qgd2F5IHRvIGFuc3dlciB0aGUgcXVlc3Rpb24gIklzIHRoaXMgYWRkcmVzcyBh IG5laWdoYm9yPyIgaXMgdG8gY29uc2lkZXIgYWRkcmVzc2VzIGluIGFueSBGSUIsIEknbSBub3Qg c3VyZSBpdCdzIG5lY2Vzc2FyeS4gU2luY2UgdGhlIGNhbGxlciBpcyBzcGVjaWZ5aW5nIHdoaWNo IGludGVyZmFjZSB0aGlzIGFkZHJlc3Mgc2hvdWxkIGJlIGEgbmVpZ2hib3Igb24sIGl0J3Mgc2Fm ZSB0byBjb25zaWRlciBvbmx5IHRoYXQgaW50ZXJmYWNlJ3MgRklCIGJlY2F1c2UgaW50ZXJmYWNl IHJvdXRlcyAoaWUuLCB0aG9zZSByb3V0ZXMgd2l0aCBuZWlnaGJvcnMpIHdpbGwgYWx3YXlzIGJl IGFkZGVkIHRoZXJlLgoKUmVtZW1iZXIsIHRoZSBpbnRlcmZhY2UgZmliIG9ubHkgbWF0dGVycyBm b3IgZm9yd2FyZGluZyBwYWNrZXRzLiAgSXQncyB0b3RhbGx5IHZhbGlkIGZvciBhbiBpbnRlcmZh Y2UgdG8gaGF2ZSBtdWx0aXBsZSBhZGRyZXNzZXMgYXNzaWduZWQsIGVhY2ggb2Ygd2hpY2ggaXMg b24gYSBkaWZmZXJlbnQgZmliLiAgU28sIHRvIGNvcnJlY3RseSBkZXRlcm1pbmUgd2hldGhlciBg YWRkcmAgaXMgYSBuZWlnaGJvciBvZiBgaWZwYCwgd2UgbXVzdCBlaXRoZXIKCjEuIExvb3Agb3Zl ciBhbGwgZmlicywgYW5kIGNoZWNrIHdoZXRoZXIgYGFkZHJgIGlzIGEgbmVpZ2hib3Igb2YgYGlm cGAgb24gYW55IG9mIHRoZW0sIG9yCjIuIExvb3Agb3ZlciBhbGwgYWRkcmVzc2VzIGFzc2lnbmVk IHRvIGBpZnBgLCBhbmQgY2hlY2sgd2hldGhlciBgYWRkcmAgaXMgYSBuZWlnaGJvciBvZiBgaWZw YCBvbiB0aGF0IGFkZHJlc3MncyBmaWIuICBJJ20gZ3Vlc3NpbmcgdGhhdCB0aGlzIHdpbGwgYmUg dGhlIHNsb3dlciBvcHRpb24sIGJlY2F1c2UgYW4gaW50ZXJmYWNlIGNhbiBoYXZlIGFyYml0cmFy aWx5IG1hbnkgYWRkcmVzc2VzCgo+IGpodWpoaXRpX2FkamVjdGl2aXNtLm9yZyB3cm90ZSBpbiBu ZDYuYzoxMzUzCj4gU2hvdWxkIHdlIHBhc3MgdGhlIGlmcC0+aWZfZmliIGhlcmU/IFdlIGNvbXBh cmUgaWZwcyBvbiBsaW5lIDEzNTUsIHNvIHNlYXJjaGluZyBhbGwgRklCcyBpcyB1c3VhbGx5IGZp bmUsIGJ1dCBpZiB3ZSBoYXZlIHR3byBpZGVudGljYWwgYWRkcmVzc2VzIGluIHR3byBkaWZmZXJl bnQgRklCcywgd2UgY291bGQgZmluZCB0aGUgd3Jvbmcgb25lIGhlcmUgYW5kIGVuZCB1cCByZXR1 cm5pbmcgZmFsc2UuCgpUaGUgb3JpZ2luYWwgY29kZSBzZWVtcyB0b28gY29tcGxpY2F0ZWQuICBJ IHRoaW5rIGl0IHNob3VsZCBnbyBhIGxpdHRsZSBsaWtlIHRoaXMgKGxvY2tzIGVsaWRlZCk6Cgog IGlmIChpZnAtPmlmX2ZsYWdzICYgSUZGX1BPSU5UT1BPSU5UKSB7CiAgICAgICAgICBUQUlMUV9G T1JFQUNIKGlmYSwgJmlmcC0+aWZfYWRkcmhlYWQsIGlmYV9saW5rKSB7CiAgCQkJaWYgKGlmYS0+ aWZhX2FkZHItPnNhX2ZhbWlseSAhPSBhZGRyLT5zYV9mYW1pbHkpCiAgCQkJCWNvbnRpbnVlOwog IAkJCWlmIChpZmEtPmlmYV9kc3RhZGRyICE9IE5VTEwgJiYKICAJCQkgICAgc2FfZXF1YWwoYWRk ciwgaWZhLT5pZmFfZHN0YWRkcikpIHsKICAJCQkJcmV0dXJuICgxKTsKICAJCQl9CiAgCQl9CiAg fQoKTm8gdW5uZWNlc3NhcnkgbG9vcGluZyBvdmVyIGVpdGhlciBmaWJzIG9yIGludGVyZmFjZXMu Cgo+IG5kNi5jOjEzMTAKPiAgCQlpZiAoKHByLT5uZHByX3N0YXRlZmxhZ3MgJiBORFBSRl9PTkxJ TkspID09IDApIHsKPiAgCQkJLyogQWx3YXlzIHVzZSB0aGUgZGVmYXVsdCBGSUIgaGVyZS4gKi8K PiAgCQkJZHN0NiA9IChjb25zdCBzdHJ1Y3Qgc29ja2FkZHIgKikmcHItPm5kcHJfcHJlZml4OwoK VGhpcyBjb21tZW50IGlzIGluY29ycmVjdCBub3cuCgpSRVBPU0lUT1JZCiAgclMgRnJlZUJTRCBz cmMgcmVwb3NpdG9yeQoKUkVWSVNJT04gREVUQUlMCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qu b3JnL0Q5NDUxCgpFTUFJTCBQUkVGRVJFTkNFUwogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9y Zy9zZXR0aW5ncy9wYW5lbC9lbWFpbHByZWZlcmVuY2VzLwoKVG86IGpodWpoaXRpX2FkamVjdGl2 aXNtLm9yZywgI25ldHdvcmssIGJ6LCBhc29tZXJzCkNjOiBqY2gsIGJ6LCBpbXAsIGFlLCBmcmVl YnNkLW5ldC1saXN0Cg== From owner-freebsd-net@freebsd.org Wed Mar 1 22:35:57 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9A4B3CF373C for ; Wed, 1 Mar 2017 22:35:57 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 62D0520E for ; Wed, 1 Mar 2017 22:35:57 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id DD6461AADE; Wed, 1 Mar 2017 22:35:56 +0000 (UTC) Date: Wed, 1 Mar 2017 22:35:56 +0000 To: freebsd-net@freebsd.org From: "ale (Alex Dupre)" Reply-to: D9270+325+bbd470fd257eef1b@reviews.freebsd.org Subject: [Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE Message-ID: <5d0d17fed4f7ff51825b42ccacdc7321@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , , Thread-Topic: D9270: Add support for user-supplied Host-Uniq tag in Netgraph PPPoE X-Herald-Rules: <28>, <8> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: NTZkNjQzYWQxOGQ3MGJlZTIzOGZhZmQ4NGNmIFi3TMw= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_5d0d17fed4f7ff51825b42ccacdc7321" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 22:35:57 -0000 --b1_5d0d17fed4f7ff51825b42ccacdc7321 Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: base64 YWxlIHJldGl0bGVkIHRoaXMgcmV2aXNpb24gZnJvbSAiQWRkIHN1cHBvcnQgZm9yIHVzZXItc3Vw cGxpZWQgSG9zdC1VbmlxIHRhZyBpbiBOZXRncmFwaCBQUFBvRSIgdG8gIkFkZCBzdXBwb3J0IGZv ciB1c2VyLXN1cHBsaWVkIEhvc3QtVW5pcSB0YWcgYW5kIGhhbmRsZSBQQURNIG1lc3NhZ2VzIGlu IE5ldGdyYXBoIFBQUG9FIi4KYWxlIHVwZGF0ZWQgdGhlIHN1bW1hcnkgZm9yIHRoaXMgcmV2aXNp b24uCmFsZSB1cGRhdGVkIHRoZSB0ZXN0IHBsYW4gZm9yIHRoaXMgcmV2aXNpb24uCmFsZSBhZGRl ZCBhIHN1YnNjcmliZXI6IG1hdi4KYWxlIHVwZGF0ZWQgdGhpcyByZXZpc2lvbiB0byBEaWZmIDI1 ODQ5LgphbGUgYWRkZWQgYSBjb21tZW50LgpUaGlzIHJldmlzaW9uIG5vdyByZXF1aXJlcyByZXZp ZXcgdG8gcHJvY2VlZC4KCgogIC0gYWRkIGNsaWVudCBhbmQgc2VydmVyIHN1cHBvcnQgZm9yIFBB RE0gbWVzc2FnZXMsIEhVUkwgYW5kIE1PVE0KICAtIEZpeCBhIHJlZ3Jlc3Npb24gaW4gUFBQb0Ug c2VydmVyIGludHJvZHVjZWQgYnkgcHJldmlvdXMgcGF0Y2ggdmVyc2lvbgogIC0gaGFuZGxlIG1p c3Npbmcgc2VydmljZSBuYW1lIHRhZyBpbiBQQURJIHJlcXVlc3RzIHRvIGNvcGUgd2l0aCBub24g ZnVsbHkgY29tcGxpYW50IGNsaWVudCBpbXBsZW1lbnRhdGlvbnMsIHRyZWF0IGl0IGFzIGVtcHR5 IHNlcnZpY2UgbmFtZQoKUkVQT1NJVE9SWQogIHJTIEZyZWVCU0Qgc3JjIHJlcG9zaXRvcnkKCkNI QU5HRVMgU0lOQ0UgTEFTVCBVUERBVEUKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvRDky NzA/dnM9MjQzMTQmaWQ9MjU4NDkKClJFVklTSU9OIERFVEFJTAogIGh0dHBzOi8vcmV2aWV3cy5m cmVlYnNkLm9yZy9EOTI3MAoKQUZGRUNURUQgRklMRVMKICBzaGFyZS9tYW4vbWFuNC9uZ19wcHBv ZS40CiAgc3lzL25ldGdyYXBoL25nX3BwcG9lLmMKICBzeXMvbmV0Z3JhcGgvbmdfcHBwb2UuaAoK RU1BSUwgUFJFRkVSRU5DRVMKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvc2V0dGluZ3Mv cGFuZWwvZW1haWxwcmVmZXJlbmNlcy8KClRvOiBhbGUsICNtYW5wYWdlcywgYWRyaWFuLCAjbmV0 d29yaywganVsaWFuCkNjOiBtYXYsIHBvb2xyb29tX2dtYWlsLmNvbSwgbWFuZHJlZSwgaW1wLCBm cmVlYnNkLW5ldC1saXN0Cg== --b1_5d0d17fed4f7ff51825b42ccacdc7321 Content-Type: text/x-patch; charset=utf-8; name="D9270.25849.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D9270.25849.patch" ZGlmZiAtLWdpdCBhL3N5cy9uZXRncmFwaC9uZ19wcHBvZS5oIGIvc3lzL25ldGdyYXBoL25nX3Bw cG9lLmgKLS0tIGEvc3lzL25ldGdyYXBoL25nX3BwcG9lLmgKKysrIGIvc3lzL25ldGdyYXBoL25n X3BwcG9lLmgKQEAgLTUyLDggKzUyLDEwIEBACiAKICNkZWZpbmUgTkdNX1BQUE9FX0NPT0tJRQkJ MTA4OTg5MzA3MgogI2RlZmluZSBOR01fUFBQT0VfU0VUTUFYUF9DT09LSUUJMTQ0MTYyNDMyMgor I2RlZmluZSBOR01fUFBQT0VfUEFETV9DT09LSUUJCTE0ODg0MDU4MjIKIAogI2RlZmluZQlQUFBP RV9TRVJWSUNFX05BTUVfU0laRQkJNjQgLyogZm9yIG5vdyAqLworI2RlZmluZQlQUFBPRV9QQURN X1ZBTFVFX1NJWkUJCTEyOCAvKiBmb3Igbm93ICovCiAKIC8qIEhvb2sgbmFtZXMgKi8KICNkZWZp bmUgTkdfUFBQT0VfSE9PS19FVEhFUk5FVAkiZXRoZXJuZXQiCkBAIC04NCw3ICs4NiwxMSBAQAog CU5HTV9QUFBPRV9TRVRNT0RFICA9IDEyLCAvKiBzZXQgdG8gc3RhbmRhcmQgb3IgY29tcGF0IG1v ZGVzICovCiAJTkdNX1BQUE9FX0dFVE1PREUgID0gMTMsIC8qIHNlZSBjdXJyZW50IG1vZGUgKi8K IAlOR01fUFBQT0VfU0VURU5BRERSID0gMTQsIC8qIHNldCBFdGhlcm5ldCBhZGRyZXNzICovCi0J TkdNX1BQUE9FX1NFVE1BWFAgID0gMTUgLyogU2V0IFBQUC1NYXgtUGF5bG9hZCB2YWx1ZSAqLwor CU5HTV9QUFBPRV9TRVRNQVhQICAgPSAxNSwgLyogU2V0IFBQUC1NYXgtUGF5bG9hZCB2YWx1ZSAq LworCU5HTV9QUFBPRV9TRU5EX0hVUkwgPSAxNiwgLyogU2VuZCBQQURNIEhVUkwgbWVzc2FnZSAq LworCU5HTV9QUFBPRV9IVVJMICAgICAgPSAxNywgLyogSFVSTCBmb3IgaW5mb3JtYXRpb25hbCBw dXJwb3NlcyAqLworCU5HTV9QUFBPRV9TRU5EX01PVE0gPSAxOCwgLyogU2VuZCBQQURNIE1PVE0g bWVzc2FnZSAqLworCU5HTV9QUFBPRV9NT1RNICAgICAgPSAxOSAgLyogTU9UTSBmb3IgaW5mb3Jt YXRpb25hbCBwdXJwb3NlcyAqLwogfTsKIAogLyoqKioqKioqKioqKioqKioqKioqKioqCkBAIC0x NTcsNiArMTYzLDEzIEBACiAJdWludDE2X3QJZGF0YTsKIH07CiAKKy8qCisgKiBUaGlzIHN0cnVj dHVyZSBpcyB1c2VkIHRvIHNlbmQgUEFETSBtZXNzYWdlcyBmcm9tIHNlcnZlciB0byBjbGllbnQu CisgKi8KK3N0cnVjdCBuZ3BwcG9lX3BhZG0geworCWNoYXIJbXNnW1BQUE9FX1BBRE1fVkFMVUVf U0laRV07Cit9OworCiAvKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioKICAqIENvbnN0YW50cyBhbmQgZGVmaW5pdGlvbnMg c3BlY2lmaWMgdG8gcHBwb2UKICAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKi8KQEAgLTE3MSw2ICsxODQsNyBAQAogI2Rl ZmluZSBQQURSX0NPREUJMHgxOQogI2RlZmluZSBQQURTX0NPREUJMHg2NQogI2RlZmluZSBQQURU X0NPREUJMHhhNworI2RlZmluZSBQQURNX0NPREUJMHhkMwogCiAvKiBUYWcgaWRlbnRpZmllcnMg Ki8KICNpZiBCWVRFX09SREVSID09IEJJR19FTkRJQU4KQEAgLTE4MSw2ICsxOTUsOCBAQAogI2Rl ZmluZSBQVFRfQUNfQ09PS0lFCSgweDAxMDQpCiAjZGVmaW5lIFBUVF9WRU5ET1IgCSgweDAxMDUp CiAjZGVmaW5lIFBUVF9SRUxBWV9TSUQJKDB4MDExMCkKKyNkZWZpbmUgUFRUX0hVUkwJKDB4MDEx MSkJLyogUFBQb0UgRXh0ZW5zaW9ucyAoQ0FSUkVMKSAqLworI2RlZmluZSBQVFRfTU9UTQkoMHgw MTEyKQkvKiBQUFBvRSBFeHRlbnNpb25zIChDQVJSRUwpICovCiAjZGVmaW5lCVBUVF9NQVhfUEFZ TAkoMHgwMTIwKQkvKiBQUFAtTWF4LVBheWxvYWQgKFJGQzQ2MzgpICovCiAjZGVmaW5lIFBUVF9T UlZfRVJSICAgICAoMHgwMjAxKQogI2RlZmluZSBQVFRfU1lTX0VSUiAgCSgweDAyMDIpCkBAIC0x OTgsNiArMjE0LDggQEAKICNkZWZpbmUgUFRUX0FDX0NPT0tJRQkoMHgwNDAxKQogI2RlZmluZSBQ VFRfVkVORE9SIAkoMHgwNTAxKQogI2RlZmluZSBQVFRfUkVMQVlfU0lECSgweDEwMDEpCisjZGVm aW5lIFBUVF9IVVJMCSgweDExMDEpCS8qIFBQUG9FIEV4dGVuc2lvbnMgKENBUlJFTCkgKi8KKyNk ZWZpbmUgUFRUX01PVE0JKDB4MTIwMSkJLyogUFBQb0UgRXh0ZW5zaW9ucyAoQ0FSUkVMKSAqLwog I2RlZmluZQlQVFRfTUFYX1BBWUwJKDB4MjAwMSkJLyogUFBQLU1heC1QYXlsb2FkIChSRkM0NjM4 KSAqLwogI2RlZmluZSBQVFRfU1JWX0VSUiAgICAgKDB4MDEwMikKICNkZWZpbmUgUFRUX1NZU19F UlIgIAkoMHgwMjAyKQpkaWZmIC0tZ2l0IGEvc3lzL25ldGdyYXBoL25nX3BwcG9lLmMgYi9zeXMv bmV0Z3JhcGgvbmdfcHBwb2UuYwotLS0gYS9zeXMvbmV0Z3JhcGgvbmdfcHBwb2UuYworKysgYi9z eXMvbmV0Z3JhcGgvbmdfcHBwb2UuYwpAQCAtMTc1LDYgKzE3NSwyMCBAQAogCSAgJm5nX3BhcnNl X3VpbnQxNl90eXBlLAogCSAgTlVMTAogCX0sCisgICAgICAgIHsKKwkgIE5HTV9QUFBPRV9DT09L SUUsCisJICBOR01fUFBQT0VfU0VORF9IVVJMLAorCSAgInNlbmRfaHVybCIsCisJICAmbmdwcHBv ZV9pbml0X2RhdGFfc3RhdGVfdHlwZSwKKwkgIE5VTEwKKyAgICAgICAgfSwKKyAgICAgICAgewor CSAgTkdNX1BQUE9FX0NPT0tJRSwKKwkgIE5HTV9QUFBPRV9TRU5EX01PVE0sCisJICAic2VuZF9t b3RtIiwKKwkgICZuZ3BwcG9lX2luaXRfZGF0YV9zdGF0ZV90eXBlLAorCSAgTlVMTAorICAgICAg ICB9LAogCXsgMCB9CiB9OwogCkBAIC0yMjYsOSArMjQwLDExIEBACiAJY29uc3Qgc3RydWN0IHBw cG9lX3RhZwkqdGFnc1tOVU1UQUdTXTsKIAl1X2ludAkJCXNlcnZpY2VfbGVuOwogCXVfaW50CQkJ YWNfbmFtZV9sZW47CisJdV9pbnQJCQlob3N0X3VuaXFfbGVuOwogCiAJc3RydWN0IGRhdGF0YWcJ CXNlcnZpY2U7CiAJc3RydWN0IGRhdGF0YWcJCWFjX25hbWU7CisJc3RydWN0IGRhdGF0YWcJCWhv c3RfdW5pcTsKIH07CiB0eXBlZGVmIHN0cnVjdCBzZXNzX25lZyAqbmVncDsKIApAQCAtNTg5LDE4 ICs2MDUsNDAgQEAKIHBwcG9lX2ZpbmR1bmlxKG5vZGVfcCBub2RlLCBjb25zdCBzdHJ1Y3QgcHBw b2VfdGFnICp0YWcpCiB7CiAJaG9va19wCWhvb2sgPSBOVUxMOwotCXVuaW9uIHVuaXEgdW5pcTsK KwlzZXNzcAlzcDsKIAotCWJjb3B5KHRhZyArIDEsIHVuaXEuYnl0ZXMsIHNpemVvZih2b2lkICop KTsKIAkvKiBDeWNsZSB0aHJvdWdoIGFsbCBrbm93biBob29rcy4gKi8KIAlMSVNUX0ZPUkVBQ0go aG9vaywgJm5vZGUtPm5kX2hvb2tzLCBoa19ob29rcykgewogCQkvKiBTa2lwIGFueSBub25zZXNz aW9uIGhvb2suICovCiAJCWlmIChOR19IT09LX1BSSVZBVEUoaG9vaykgPT0gTlVMTCkKIAkJCWNv bnRpbnVlOwotCQlpZiAodW5pcS5wb2ludGVyID09IE5HX0hPT0tfUFJJVkFURShob29rKSkKKwkJ c3AgPSBOR19IT09LX1BSSVZBVEUoaG9vayk7CisJCWlmIChzcC0+bmVnLT5ob3N0X3VuaXFfbGVu ID09IG50b2hzKHRhZy0+dGFnX2xlbikgJiYKKwkJICAgIGJjbXAoc3AtPm5lZy0+aG9zdF91bmlx LmRhdGEsIChjb25zdCBjaGFyICopKHRhZyArIDEpLAorCQkgICAgIHNwLT5uZWctPmhvc3RfdW5p cV9sZW4pID09IDApCiAJCQlicmVhazsKIAl9Ci0JQ1RSMyhLVFJfTkVULCAiJTIwczogbWF0Y2hl ZCAlcCBmb3IgJXAiLCBfX2Z1bmNfXywgaG9vaywgdW5pcS5wb2ludGVyKTsKKwlDVFIzKEtUUl9O RVQsICIlMjBzOiBtYXRjaGVkICVwIGZvciAlcCIsIF9fZnVuY19fLCBob29rLCBzcCk7CisKKwly ZXR1cm4gKGhvb2spOworfQorCitzdGF0aWMgaG9va19wCitwcHBvZV9maW5kY29va2llKG5vZGVf cCBub2RlLCBjb25zdCBzdHJ1Y3QgcHBwb2VfdGFnICp0YWcpCit7CisJaG9va19wCWhvb2sgPSBO VUxMOworCXVuaW9uIHVuaXEgY29va2llOworCisJYmNvcHkodGFnICsgMSwgY29va2llLmJ5dGVz LCBzaXplb2Yodm9pZCAqKSk7CisJLyogQ3ljbGUgdGhyb3VnaCBhbGwga25vd24gaG9va3MuICov CisJTElTVF9GT1JFQUNIKGhvb2ssICZub2RlLT5uZF9ob29rcywgaGtfaG9va3MpIHsKKwkJLyog U2tpcCBhbnkgbm9uc2Vzc2lvbiBob29rLiAqLworCQlpZiAoTkdfSE9PS19QUklWQVRFKGhvb2sp ID09IE5VTEwpCisJCQljb250aW51ZTsKKwkJaWYgKGNvb2tpZS5wb2ludGVyID09IE5HX0hPT0tf UFJJVkFURShob29rKSkKKwkJCWJyZWFrOworCX0KKwlDVFIzKEtUUl9ORVQsICIlMjBzOiBtYXRj aGVkICVwIGZvciAlcCIsIF9fZnVuY19fLCBob29rLCBjb29raWUucG9pbnRlcik7CiAKIAlyZXR1 cm4gKGhvb2spOwogfQpAQCAtNzQ0LDE3ICs3ODIsMjkgQEAKIAkJY2FzZSBOR01fUFBQT0VfTElT VEVOOgogCQljYXNlIE5HTV9QUFBPRV9PRkZFUjoKIAkJY2FzZSBOR01fUFBQT0VfU0VSVklDRToK KwkJY2FzZSBOR01fUFBQT0VfU0VORF9IVVJMOgorCQljYXNlIE5HTV9QUFBPRV9TRU5EX01PVE06 CiAJCQlvdXJtc2cgPSAoc3RydWN0IG5ncHBwb2VfaW5pdF9kYXRhICopbXNnLT5kYXRhOwogCQkJ aWYgKG1zZy0+aGVhZGVyLmFyZ2xlbiA8IHNpemVvZigqb3VybXNnKSkgewogCQkJCWxvZyhMT0df RVJSLCAibmdfcHBwb2VbJXhdOiBpbml0IGRhdGEgdG9vICIKIAkJCQkgICAgInNtYWxsXG4iLCBu b2RlLT5uZF9JRCk7CiAJCQkJTEVBVkUoRU1TR1NJWkUpOwogCQkJfQotCQkJaWYgKG1zZy0+aGVh ZGVyLmFyZ2xlbiAtIHNpemVvZigqb3VybXNnKSA+Ci0JCQkgICAgUFBQT0VfU0VSVklDRV9OQU1F X1NJWkUpIHsKLQkJCQlsb2coTE9HX0VSUiwgIm5nX3BwcG9lWyV4XTogc2VydmljZSBuYW1lICIK LQkJCQkgICAgInRvbyBiaWdcbiIsIG5vZGUtPm5kX0lEKTsKLQkJCQlMRUFWRShFTVNHU0laRSk7 CisJCQlpZiAobXNnLT5oZWFkZXIuY21kID09IE5HTV9QUFBPRV9TRU5EX0hVUkwgfHwKKwkJCSAg ICBtc2ctPmhlYWRlci5jbWQgPT0gTkdNX1BQUE9FX1NFTkRfTU9UTSkgeworCQkJCWlmIChtc2ct PmhlYWRlci5hcmdsZW4gLSBzaXplb2YoKm91cm1zZykgPgorCQkJCSAgICBQUFBPRV9QQURNX1ZB TFVFX1NJWkUpIHsKKwkJCQkJbG9nKExPR19FUlIsICJuZ19wcHBvZVsleF06IG1lc3NhZ2UgIgor CQkJCQkgICAgInRvbyBiaWdcbiIsIG5vZGUtPm5kX0lEKTsKKwkJCQkJTEVBVkUoRU1TR1NJWkUp OworCQkJCX0KKwkJCX0gZWxzZSB7CisJCQkJaWYgKG1zZy0+aGVhZGVyLmFyZ2xlbiAtIHNpemVv Zigqb3VybXNnKSA+CisJCQkJICAgIFBQUE9FX1NFUlZJQ0VfTkFNRV9TSVpFKSB7CisJCQkJCWxv ZyhMT0dfRVJSLCAibmdfcHBwb2VbJXhdOiBzZXJ2aWNlIG5hbWUgIgorCQkJCQkgICAgInRvbyBi aWdcbiIsIG5vZGUtPm5kX0lEKTsKKwkJCQkJTEVBVkUoRU1TR1NJWkUpOworCQkJCX0KIAkJCX0K IAkJCWlmIChtc2ctPmhlYWRlci5hcmdsZW4gLSBzaXplb2YoKm91cm1zZykgPAogCQkJICAgIG91 cm1zZy0+ZGF0YV9sZW4pIHsKQEAgLTc5NCw2ICs4NDQsMjAgQEAKIAkJCWlmIChtc2ctPmhlYWRl ci5jbWQgPT0gTkdNX1BQUE9FX1NFUlZJQ0UpCiAJCQkJYnJlYWs7CiAKKwkJCS8qCisJCQkgKiBQ QURNIG1lc3NhZ2VzIGFyZSBzZXQgdXAgb24gYWN0aXZlIHNlc3Npb25zLgorCQkJICovCisJCQlp ZiAobXNnLT5oZWFkZXIuY21kID09IE5HTV9QUFBPRV9TRU5EX0hVUkwgfHwKKwkJCSAgICBtc2ct PmhlYWRlci5jbWQgPT0gTkdNX1BQUE9FX1NFTkRfTU9UTSkgeworCQkJCWlmIChzcC0+c3RhdGUg IT0gUFBQT0VfTkVXQ09OTkVDVEVEICYmCisJCQkJICAgIHNwLT5zdGF0ZSAhPSBQUFBPRV9DT05O RUNURUQpIHsKKwkJCQkJbG9nKExPR19OT1RJQ0UsICJuZ19wcHBvZVsleF06IHNlc3Npb24gaXMg bm90ICIKKwkJCQkJICAgICJhY3RpdmVcbiIsIG5vZGUtPm5kX0lEKTsKKwkJCQkJTEVBVkUoRUlT Q09OTik7CisJCQkJfQorCQkJCWJyZWFrOworCQkJfQorCiAJCQlpZiAoc3AtPnN0YXRlICE9IFBQ UE9FX1NOT05FKSB7CiAJCQkJbG9nKExPR19OT1RJQ0UsICJuZ19wcHBvZVsleF06IFNlc3Npb24g YWxyZWFkeSAiCiAJCQkJICAgICJhY3RpdmVcbiIsIG5vZGUtPm5kX0lEKTsKQEAgLTg0OCwyOCAr OTEyLDcyIEBACiAJCQkgKiBDaGVjayB0aGUgaG9vayBleGlzdHMgYW5kIGlzIFVuaW5pdGlhbGlz ZWQuCiAJCQkgKiBTZW5kIGEgUEFESSByZXF1ZXN0LCBhbmQgc3RhcnQgdGhlIHRpbWVvdXQgbG9n aWMuCiAJCQkgKiBTdG9yZSB0aGUgb3JpZ2luYXRvciBvZiB0aGlzIG1lc3NhZ2Ugc28gd2UgY2Fu IHNlbmQKLQkJCSAqIGEgc3VjY2VzcyBvZiBmYWlsIG1lc3NhZ2UgdG8gdGhlbSBsYXRlci4KKwkJ CSAqIGEgc3VjY2VzcyBvciBmYWlsIG1lc3NhZ2UgdG8gdGhlbSBsYXRlci4KIAkJCSAqIE1vdmUg dGhlIHNlc3Npb24gdG8gU0lOSVQuCiAJCQkgKiBTZXQgdXAgdGhlIHNlc3Npb24gdG8gdGhlIGNv cnJlY3Qgc3RhdGUgYW5kCiAJCQkgKiBzdGFydCBpdC4KIAkJCSAqLwotCQkJaW50CWksIGFjbmxl biA9IDAsIGFjbnNlcCA9IDAsIHNydmxlbjsKKwkJCWludAlhY25wb3MsIGFjbmxlbiA9IDAsIGFj bnNlcCA9IDA7CisJCQlpbnQJaHVwb3MsIGh1bGVuID0gMCwgaHVzZXAgPSAwOworCQkJaW50CWks IHNydnBvcywgc3J2bGVuOworCQkJYWNucG9zID0gMDsKIAkJCWZvciAoaSA9IDA7IGkgPCBvdXJt c2ctPmRhdGFfbGVuOyBpKyspIHsKIAkJCQlpZiAob3VybXNnLT5kYXRhW2ldID09ICdcXCcpIHsK IAkJCQkJYWNubGVuID0gaTsKIAkJCQkJYWNuc2VwID0gMTsKIAkJCQkJYnJlYWs7CiAJCQkJfQog CQkJfQotCQkJc3J2bGVuID0gb3VybXNnLT5kYXRhX2xlbiAtIGFjbmxlbiAtIGFjbnNlcDsKKwkJ CWh1cG9zID0gYWNubGVuICsgYWNuc2VwOworCQkJZm9yIChpID0gaHVwb3M7IGkgPCBvdXJtc2ct PmRhdGFfbGVuOyBpKyspIHsKKwkJCQlpZiAob3VybXNnLT5kYXRhW2ldID09ICd8JykgeworCQkJ CQlodWxlbiA9IGkgLSBodXBvczsKKwkJCQkJaHVzZXAgPSAxOworCQkJCQlicmVhazsKKwkJCQl9 CisJCQl9CisJCQlzcnZwb3MgPSBodXBvcyArIGh1bGVuICsgaHVzZXA7CisJCQlzcnZsZW4gPSBv dXJtc2ctPmRhdGFfbGVuIC0gc3J2cG9zOwogCi0JCQliY29weShvdXJtc2ctPmRhdGEsIG5lZy0+ YWNfbmFtZS5kYXRhLCBhY25sZW4pOworCQkJYmNvcHkob3VybXNnLT5kYXRhICsgYWNucG9zLCBu ZWctPmFjX25hbWUuZGF0YSwgYWNubGVuKTsKIAkJCW5lZy0+YWNfbmFtZV9sZW4gPSBhY25sZW47 CiAKKwkJCW5lZy0+aG9zdF91bmlxLmhkci50YWdfdHlwZSA9IFBUVF9IT1NUX1VOSVE7CisJCQlp ZiAoaHVsZW4gPT0gMCkgeworCQkJCS8qIE5vdCBwcm92aWRlZCwgZ2VuZXJhdGUgb25lICovCisJ CQkJbmVnLT5ob3N0X3VuaXEuaGRyLnRhZ19sZW4gPSBodG9ucyhzaXplb2Yoc3ApKTsKKwkJCQli Y29weSgmc3AsIG5lZy0+aG9zdF91bmlxLmRhdGEsIHNpemVvZihzcCkpOworCQkJCW5lZy0+aG9z dF91bmlxX2xlbiA9IHNpemVvZihzcCk7CisJCQl9IGVsc2UgaWYgKGh1bGVuID4gMiAmJiBvdXJt c2ctPmRhdGFbaHVwb3NdID09ICcwJyAmJgorCQkJICBvdXJtc2ctPmRhdGFbaHVwb3MgKyAxXSA9 PSAneCcgJiYgaHVsZW4gJSAyID09IDApIHsKKwkJCQkvKiBIZXggZW5jb2RlZCAqLworCQkJCXN0 YXRpYyBjb25zdCBjaGFyIGhleGRpZ1sxNl0gPSAiMDEyMzQ1Njc4OWFiY2RlZiI7CisJCQkJaW50 IGo7CisKKwkJCQluZWctPmhvc3RfdW5pcS5oZHIudGFnX2xlbiA9IGh0b25zKCh1aW50MTZfdCko aHVsZW4gLyAyIC0gMSkpOworCQkJCWZvciAoaSA9IDA7IGkgPCBodWxlbiAtIDI7IGkrKykgewor CQkJCQlmb3IgKGogPSAwOworCQkJCQkgICAgIGogPCAxNiAmJgorCQkJCQkgICAgIG91cm1zZy0+ ZGF0YVtodXBvcyArIDIgKyBpXSAhPSBoZXhkaWdbal07CisJCQkJCSAgICAgaisrKTsKKwkJCQkJ aWYgKGogPT0gMTYpCisJCQkJCQlMRUFWRShFSU5WQUwpOworCQkJCQlpZiAoaSAlIDIgPT0gMCkK KwkJCQkJCW5lZy0+aG9zdF91bmlxLmRhdGFbaSAvIDJdID0gaiA8PCA0OworCQkJCQllbHNlCisJ CQkJCQluZWctPmhvc3RfdW5pcS5kYXRhW2kgLyAyXSB8PSBqOworCQkJCX0KKwkJCQluZWctPmhv c3RfdW5pcV9sZW4gPSBodWxlbiAvIDIgLSAxOworCQkJfSBlbHNlIHsKKwkJCQkvKiBQbGFpbiBz dHJpbmcgKi8KKwkJCQluZWctPmhvc3RfdW5pcS5oZHIudGFnX2xlbiA9IGh0b25zKCh1aW50MTZf dClodWxlbik7CisJCQkJYmNvcHkob3VybXNnLT5kYXRhICsgaHVwb3MsIG5lZy0+aG9zdF91bmlx LmRhdGEsIGh1bGVuKTsKKwkJCQluZWctPmhvc3RfdW5pcV9sZW4gPSBodWxlbjsKKwkJCX0KKwog CQkJbmVnLT5zZXJ2aWNlLmhkci50YWdfdHlwZSA9IFBUVF9TUlZfTkFNRTsKIAkJCW5lZy0+c2Vy dmljZS5oZHIudGFnX2xlbiA9IGh0b25zKCh1aW50MTZfdClzcnZsZW4pOwotCQkJYmNvcHkob3Vy bXNnLT5kYXRhICsgYWNubGVuICsgYWNuc2VwLAotCQkJICAgIG5lZy0+c2VydmljZS5kYXRhLCBz cnZsZW4pOworCQkJYmNvcHkob3VybXNnLT5kYXRhICsgc3J2cG9zLCBuZWctPnNlcnZpY2UuZGF0 YSwgc3J2bGVuKTsKIAkJCW5lZy0+c2VydmljZV9sZW4gPSBzcnZsZW47CiAJCQlwcHBvZV9zdGFy dChzcCk7CiAJCQlicmVhazsKQEAgLTg3OSw3ICs5ODcsNyBAQAogCQkJICogQ2hlY2sgdGhlIGhv b2sgZXhpc3RzIGFuZCBpcyBVbmluaXRpYWxpc2VkLgogCQkJICogSW5zdGFsbCB0aGUgc2Vydmlj ZSBtYXRjaGluZyBzdHJpbmcuCiAJCQkgKiBTdG9yZSB0aGUgb3JpZ2luYXRvciBvZiB0aGlzIG1l c3NhZ2Ugc28gd2UgY2FuIHNlbmQKLQkJCSAqIGEgc3VjY2VzcyBvZiBmYWlsIG1lc3NhZ2UgdG8g dGhlbSBsYXRlci4KKwkJCSAqIGEgc3VjY2VzcyBvciBmYWlsIG1lc3NhZ2UgdG8gdGhlbSBsYXRl ci4KIAkJCSAqIE1vdmUgdGhlIGhvb2sgdG8gJ0xJU1RFTklORycKIAkJCSAqLwogCQkJbmVnLT5z ZXJ2aWNlLmhkci50YWdfdHlwZSA9IFBUVF9TUlZfTkFNRTsKQEAgLTEwMTksNiArMTEyNyw5NiBA QAogCQkJcHJpdnAtPm1heF9wYXlsb2FkLmhkci50YWdfbGVuID0gaHRvbnMoc2l6ZW9mKHVpbnQx Nl90KSk7CiAJCQlwcml2cC0+bWF4X3BheWxvYWQuZGF0YSA9IGh0b25zKCooKHVpbnQxNl90ICop bXNnLT5kYXRhKSk7CiAJCQlicmVhazsKKwkJY2FzZSBOR01fUFBQT0VfU0VORF9IVVJMOgorCQkg ICAgeworCQkJc3RydWN0IG1idWYgKm07CisKKwkJCS8qIEdlbmVyYXRlIGEgcGFja2V0IG9mIHRo YXQgdHlwZS4gKi8KKwkJCU1HRVRIRFIobSwgTV9OT1dBSVQsIE1UX0RBVEEpOworCQkJaWYgKG0g PT0gTlVMTCkKKwkJCQlsb2coTE9HX05PVElDRSwgIm5nX3BwcG9lWyV4XTogc2Vzc2lvbiBvdXQg b2YgIgorCQkJCSAgICAibWJ1ZnNcbiIsIG5vZGUtPm5kX0lEKTsKKwkJCWVsc2UgeworCQkJCXN0 cnVjdCBwcHBvZV9mdWxsX2hkciAqd2g7CisJCQkJc3RydWN0IHBwcG9lX3RhZyAqdGFnOworCQkJ CWludCAgICAgZXJyb3IgPSAwOworCisJCQkJbS0+bV9wa3RoZHIucmN2aWYgPSBOVUxMOworCQkJ CW0tPm1fcGt0aGRyLmxlbiA9IG0tPm1fbGVuID0gc2l6ZW9mKCp3aCk7CisJCQkJd2ggPSBtdG9k KG0sIHN0cnVjdCBwcHBvZV9mdWxsX2hkciAqKTsKKwkJCQliY29weSgmc3AtPnBrdF9oZHIsIHdo LCBzaXplb2YoKndoKSk7CisKKwkJCQkvKiBSZXZlcnQgdGhlIHN0b3JlZCBoZWFkZXIgdG8gRElT Qy9QQURNIG1vZGUuICovCisJCQkJd2gtPnBoLmNvZGUgPSBQQURNX0NPREU7CisJCQkJLyoKKwkJ CQkgKiBDb25maWd1cmUgZXRoZXJ0eXBlIGRlcGVuZGluZyBvbiB3aGF0CisJCQkJICogd2FzIHVz ZWQgZHVyaW5nIHNlc3Npb25zIHN0YWdlLgorCQkJCSAqLworCQkJCWlmICh3aC0+ZWguZXRoZXJf dHlwZSA9PQorCQkJCSAgICBFVEhFUlRZUEVfUFBQT0VfM0NPTV9TRVNTKQorCQkJCQl3aC0+ZWgu ZXRoZXJfdHlwZSA9IEVUSEVSVFlQRV9QUFBPRV8zQ09NX0RJU0M7CisJCQkJZWxzZQorCQkJCQl3 aC0+ZWguZXRoZXJfdHlwZSA9IEVUSEVSVFlQRV9QUFBPRV9ESVNDOworCQkJCS8qCisJCQkJICog QWRkIFBBRE0gbWVzc2FnZSBhbmQgYWRqdXN0IHNpemVzLgorCQkJCSAqLworCQkJCXRhZyA9ICh2 b2lkICopKCZ3aC0+cGggKyAxKTsKKwkJCQl0YWctPnRhZ190eXBlID0gUFRUX0hVUkw7CisJCQkJ dGFnLT50YWdfbGVuID0gaHRvbnMob3VybXNnLT5kYXRhX2xlbik7CisJCQkJc3RybmNweSgoY2hh ciAqKSh0YWcgKyAxKSwgb3VybXNnLT5kYXRhLCBvdXJtc2ctPmRhdGFfbGVuKTsKKwkJCQltLT5t X3BrdGhkci5sZW4gPSAobS0+bV9sZW4gKz0gc2l6ZW9mKCp0YWcpICsKKwkJCQkgICAgb3VybXNn LT5kYXRhX2xlbik7CisJCQkJd2gtPnBoLmxlbmd0aCA9IGh0b25zKHNpemVvZigqdGFnKSArIG91 cm1zZy0+ZGF0YV9sZW4pOworCQkJCU5HX1NFTkRfREFUQV9PTkxZKGVycm9yLAorCQkJCSAgICBw cml2cC0+ZXRoZXJuZXRfaG9vaywgbSk7CisJCQl9CisJCQlicmVhazsKKwkJICAgIH0KKwkJY2Fz ZSBOR01fUFBQT0VfU0VORF9NT1RNOgorCQkgICAgeworCQkJc3RydWN0IG1idWYgKm07CisKKwkJ CS8qIEdlbmVyYXRlIGEgcGFja2V0IG9mIHRoYXQgdHlwZS4gKi8KKwkJCU1HRVRIRFIobSwgTV9O T1dBSVQsIE1UX0RBVEEpOworCQkJaWYgKG0gPT0gTlVMTCkKKwkJCQlsb2coTE9HX05PVElDRSwg Im5nX3BwcG9lWyV4XTogc2Vzc2lvbiBvdXQgb2YgIgorCQkJCSAgICAibWJ1ZnNcbiIsIG5vZGUt Pm5kX0lEKTsKKwkJCWVsc2UgeworCQkJCXN0cnVjdCBwcHBvZV9mdWxsX2hkciAqd2g7CisJCQkJ c3RydWN0IHBwcG9lX3RhZyAqdGFnOworCQkJCWludCAgICAgZXJyb3IgPSAwOworCisJCQkJbS0+ bV9wa3RoZHIucmN2aWYgPSBOVUxMOworCQkJCW0tPm1fcGt0aGRyLmxlbiA9IG0tPm1fbGVuID0g c2l6ZW9mKCp3aCk7CisJCQkJd2ggPSBtdG9kKG0sIHN0cnVjdCBwcHBvZV9mdWxsX2hkciAqKTsK KwkJCQliY29weSgmc3AtPnBrdF9oZHIsIHdoLCBzaXplb2YoKndoKSk7CisKKwkJCQkvKiBSZXZl cnQgdGhlIHN0b3JlZCBoZWFkZXIgdG8gRElTQy9QQURNIG1vZGUuICovCisJCQkJd2gtPnBoLmNv ZGUgPSBQQURNX0NPREU7CisJCQkJLyoKKwkJCQkgKiBDb25maWd1cmUgZXRoZXJ0eXBlIGRlcGVu ZGluZyBvbiB3aGF0CisJCQkJICogd2FzIHVzZWQgZHVyaW5nIHNlc3Npb25zIHN0YWdlLgorCQkJ CSAqLworCQkJCWlmICh3aC0+ZWguZXRoZXJfdHlwZSA9PQorCQkJCSAgICBFVEhFUlRZUEVfUFBQ T0VfM0NPTV9TRVNTKQorCQkJCQl3aC0+ZWguZXRoZXJfdHlwZSA9IEVUSEVSVFlQRV9QUFBPRV8z Q09NX0RJU0M7CisJCQkJZWxzZQorCQkJCQl3aC0+ZWguZXRoZXJfdHlwZSA9IEVUSEVSVFlQRV9Q UFBPRV9ESVNDOworCQkJCS8qCisJCQkJICogQWRkIFBBRE0gbWVzc2FnZSBhbmQgYWRqdXN0IHNp emVzLgorCQkJCSAqLworCQkJCXRhZyA9ICh2b2lkICopKCZ3aC0+cGggKyAxKTsKKwkJCQl0YWct PnRhZ190eXBlID0gUFRUX01PVE07CisJCQkJdGFnLT50YWdfbGVuID0gaHRvbnMob3VybXNnLT5k YXRhX2xlbik7CisJCQkJc3RybmNweSgoY2hhciAqKSh0YWcgKyAxKSwgb3VybXNnLT5kYXRhLCBv dXJtc2ctPmRhdGFfbGVuKTsKKwkJCQltLT5tX3BrdGhkci5sZW4gPSAobS0+bV9sZW4gKz0gc2l6 ZW9mKCp0YWcpICsKKwkJCQkgICAgb3VybXNnLT5kYXRhX2xlbik7CisJCQkJd2gtPnBoLmxlbmd0 aCA9IGh0b25zKHNpemVvZigqdGFnKSArIG91cm1zZy0+ZGF0YV9sZW4pOworCQkJCU5HX1NFTkRf REFUQV9PTkxZKGVycm9yLAorCQkJCSAgICBwcml2cC0+ZXRoZXJuZXRfaG9vaywgbSk7CisJCQl9 CisJCQlicmVhazsKKwkJICAgIH0KIAkJZGVmYXVsdDoKIAkJCUxFQVZFKEVJTlZBTCk7CiAJCX0K QEAgLTEwNjEsMTAgKzEyNTksNiBAQAogCW5vZGVfcAlub2RlID0gTkdfSE9PS19OT0RFKGhvb2sp OwogCXByaXZfcAlwcml2cCA9IE5HX05PREVfUFJJVkFURShub2RlKTsKIAluZWdwCW5lZyA9IHNw LT5uZWc7Ci0Jc3RydWN0IHsKLQkJc3RydWN0IHBwcG9lX3RhZyBoZHI7Ci0JCXVuaW9uCXVuaXEJ ZGF0YTsKLQl9IF9fcGFja2VkIHVuaXF0YWc7CiAJc3RydWN0ICBtYnVmICptMDsKIAlpbnQJZXJy b3I7CiAKQEAgLTEwODAsMTEgKzEyNzQsOCBAQAogCW1lbWNweSgodm9pZCAqKSZuZWctPnBrdC0+ cGt0X2hlYWRlci5laCwgJnByaXZwLT5laCwKIAkgICAgc2l6ZW9mKHN0cnVjdCBldGhlcl9oZWFk ZXIpKTsKIAluZWctPnBrdC0+cGt0X2hlYWRlci5waC5jb2RlID0gUEFESV9DT0RFOwotCXVuaXF0 YWcuaGRyLnRhZ190eXBlID0gUFRUX0hPU1RfVU5JUTsKLQl1bmlxdGFnLmhkci50YWdfbGVuID0g aHRvbnMoKHVfaW50MTZfdClzaXplb2YodW5pcXRhZy5kYXRhKSk7Ci0JdW5pcXRhZy5kYXRhLnBv aW50ZXIgPSBzcDsKIAlpbml0X3RhZ3Moc3ApOwotCWluc2VydF90YWcoc3AsICZ1bmlxdGFnLmhk cik7CisJaW5zZXJ0X3RhZyhzcCwgJm5lZy0+aG9zdF91bmlxLmhkcik7CiAJaW5zZXJ0X3RhZyhz cCwgJm5lZy0+c2VydmljZS5oZHIpOwogCWlmIChwcml2cC0+bWF4X3BheWxvYWQuZGF0YSAhPSAw KQogCQlpbnNlcnRfdGFnKHNwLCAmcHJpdnAtPm1heF9wYXlsb2FkLmhkcik7CkBAIC0xMTYzLDYg KzEzNTQsNTIgQEAKIAlyZXR1cm4gKGVycm9yKTsKIH0KIAorc3RhdGljIGludAorc2VuZF9odXJs KHNlc3NwIHNwLCBjb25zdCBzdHJ1Y3QgcHBwb2VfdGFnICp0YWcpCit7CisJaW50IGVycm9yLCB0 bGVuOworCXN0cnVjdCBuZ19tZXNnICptc2c7CisJc3RydWN0IG5ncHBwb2VfcGFkbSAqcGFkbTsK KworCUNUUjIoS1RSX05FVCwgIiUyMHM6IGNhbGxlZCAlZCIsIF9fZnVuY19fLCBzcC0+U2Vzc2lv bl9JRCk7CisKKwlOR19NS01FU1NBR0UobXNnLCBOR01fUFBQT0VfQ09PS0lFLCBOR01fUFBQT0Vf SFVSTCwKKwkgICAgc2l6ZW9mKHN0cnVjdCBuZ3BwcG9lX3BhZG0pLCBNX05PV0FJVCk7CisJaWYg KG1zZyA9PSBOVUxMKQorCQlyZXR1cm4gKEVOT01FTSk7CisKKwlwYWRtID0gKHN0cnVjdCBuZ3Bw cG9lX3BhZG0gKiltc2ctPmRhdGE7CisJdGxlbiA9IG1pbihQUFBPRV9QQURNX1ZBTFVFX1NJWkUg LSAxLCBudG9ocyh0YWctPnRhZ19sZW4pKTsKKwlzdHJuY3B5KHBhZG0tPm1zZywgKGNvbnN0IGNo YXIgKikodGFnICsgMSksIHRsZW4pOworCXBhZG0tPm1zZ1t0bGVuXSA9ICdcMCc7CisJTkdfU0VO RF9NU0dfSUQoZXJyb3IsIE5HX0hPT0tfTk9ERShzcC0+aG9vayksIG1zZywgc3AtPmNyZWF0b3Is IDApOworCisJcmV0dXJuIChlcnJvcik7Cit9CisKK3N0YXRpYyBpbnQKK3NlbmRfbW90bShzZXNz cCBzcCwgY29uc3Qgc3RydWN0IHBwcG9lX3RhZyAqdGFnKQoreworCWludCBlcnJvciwgdGxlbjsK KwlzdHJ1Y3QgbmdfbWVzZyAqbXNnOworCXN0cnVjdCBuZ3BwcG9lX3BhZG0gKnBhZG07CisKKwlD VFIyKEtUUl9ORVQsICIlMjBzOiBjYWxsZWQgJWQiLCBfX2Z1bmNfXywgc3AtPlNlc3Npb25fSUQp OworCisJTkdfTUtNRVNTQUdFKG1zZywgTkdNX1BQUE9FX0NPT0tJRSwgTkdNX1BQUE9FX01PVE0s CisJICAgIHNpemVvZihzdHJ1Y3QgbmdwcHBvZV9wYWRtKSwgTV9OT1dBSVQpOworCWlmIChtc2cg PT0gTlVMTCkKKwkJcmV0dXJuIChFTk9NRU0pOworCisJcGFkbSA9IChzdHJ1Y3QgbmdwcHBvZV9w YWRtICopbXNnLT5kYXRhOworCXRsZW4gPSBtaW4oUFBQT0VfUEFETV9WQUxVRV9TSVpFIC0gMSwg bnRvaHModGFnLT50YWdfbGVuKSk7CisJc3RybmNweShwYWRtLT5tc2csIChjb25zdCBjaGFyICop KHRhZyArIDEpLCB0bGVuKTsKKwlwYWRtLT5tc2dbdGxlbl0gPSAnXDAnOworCU5HX1NFTkRfTVNH X0lEKGVycm9yLCBOR19IT09LX05PREUoc3AtPmhvb2spLCBtc2csIHNwLT5jcmVhdG9yLCAwKTsK KworCXJldHVybiAoZXJyb3IpOworfQorCiAvKgogICogUmVjZWl2ZSBkYXRhIGZyb20gc2Vzc2lv biBob29rIGFuZCBkbyBzb21ldGhpbmcgd2l0aCBpdC4KICAqLwpAQCAtMTMyMCw2ICsxNTU3LDcg QEAKIAljb25zdCBwcml2X3AJCXByaXZwID0gTkdfTk9ERV9QUklWQVRFKG5vZGUpOwogCXNlc3Nw CQkJc3A7CiAJY29uc3Qgc3RydWN0IHBwcG9lX3RhZwkqdXRhZyA9IE5VTEwsICp0YWcgPSBOVUxM OworCWNvbnN0IHN0cnVjdCBwcHBvZV90YWcJc250YWcgPSB7IFBUVF9TUlZfTkFNRSwgMCB9Owog CWNvbnN0IHN0cnVjdCBwcHBvZV9mdWxsX2hkciAqd2g7CiAJY29uc3Qgc3RydWN0IHBwcG9lX2hk cgkqcGg7CiAJbmVncAkJCW5lZyA9IE5VTEw7CkBAIC0xNDA5LDExICsxNjQ3LDggQEAKIAkJCSAq IHByb2Nlc3NpbmcuCiAJCQkgKi8KIAkJCXRhZyA9IGdldF90YWcocGgsIFBUVF9TUlZfTkFNRSk7 Ci0JCQlpZiAodGFnID09IE5VTEwpIHsKLQkJCQlDVFIxKEtUUl9ORVQsICIlMjBzOiBQQURJIHcv byBTZXJ2aWNlLU5hbWUiLAotCQkJCSAgICBfX2Z1bmNfXyk7Ci0JCQkJTEVBVkUoRU5FVFVOUkVB Q0gpOwotCQkJfQorCQkJaWYgKHRhZyA9PSBOVUxMKQorCQkJCXRhZyA9ICZzbnRhZzsKIAogCQkJ LyoKIAkJCSAqIEZpcnN0LCB0cnkgdG8gbWF0Y2ggU2VydmljZS1OYW1lIGFnYWluc3Qgb3VyIApA QCAtMTQzOCw4ICsxNjczLDcgQEAKIAkJCSAqIEZvciBub3cgc2ltcGx5IGFjY2VwdCB0aGUgZmly c3Qgd2UgcmVjZWl2ZS4KIAkJCSAqLwogCQkJdXRhZyA9IGdldF90YWcocGgsIFBUVF9IT1NUX1VO SVEpOwotCQkJaWYgKCh1dGFnID09IE5VTEwpIHx8Ci0JCQkgICAgKG50b2hzKHV0YWctPnRhZ19s ZW4pICE9IHNpemVvZihzcCkpKSB7CisJCQlpZiAodXRhZyA9PSBOVUxMKSB7CiAJCQkJbG9nKExP R19OT1RJQ0UsICJuZ19wcHBvZVsleF06IG5vIGhvc3QgIgogCQkJCSAgICAidW5pcXVlIGZpZWxk XG4iLCBub2RlLT5uZF9JRCk7CiAJCQkJTEVBVkUoRU5FVFVOUkVBQ0gpOwpAQCAtMTUyOSw3ICsx NzYzLDcgQEAKIAkJCQlMRUFWRShFTkVUVU5SRUFDSCk7CiAJCQl9CiAKLQkJCXNlbmRob29rID0g cHBwb2VfZmluZHVuaXEobm9kZSwgdXRhZyk7CisJCQlzZW5kaG9vayA9IHBwcG9lX2ZpbmRjb29r aWUobm9kZSwgdXRhZyk7CiAJCQlpZiAoc2VuZGhvb2sgPT0gTlVMTCkKIAkJCQlMRUFWRShFTkVU VU5SRUFDSCk7CiAKQEAgLTE2MDUsOCArMTgzOSw3IEBACiAJCQkgKiBzZXQgdXMgaW50byBTZXNz aW9uIG1vZGUuCiAJCQkgKi8KIAkJCXV0YWcgPSBnZXRfdGFnKHBoLCBQVFRfSE9TVF9VTklRKTsK LQkJCWlmICgodXRhZyA9PSBOVUxMKSB8fAotCQkJICAgIChudG9ocyh1dGFnLT50YWdfbGVuKSAh PSBzaXplb2Yoc3ApKSkgeworCQkJaWYgKHV0YWcgPT0gTlVMTCkgewogCQkJCUxFQVZFIChFTkVU VU5SRUFDSCk7CiAJCQl9CiAJCQlzZW5kaG9vayA9IHBwcG9lX2ZpbmR1bmlxKG5vZGUsIHV0YWcp OwpAQCAtMTY1OSw2ICsxODkyLDE5IEBACiAJCQkvKiBEaXNjb25uZWN0IHRoYXQgaG9vay4gKi8K IAkJCW5nX3JtaG9va19zZWxmKHNwLT5ob29rKTsKIAkJCWJyZWFrOworCQljYXNlCVBBRE1fQ09E RToKKwkJCS8qCisJCQkgKiBXZSBhcmUgYSBjbGllbnQ6CisJCQkgKiBmaW5kIG1hdGNoaW5nIHBl ZXIvc2Vzc2lvbiBjb21iaW5hdGlvbi4KKwkJCSAqLworCQkJc3AgPSBwcHBvZV9maW5kc2Vzc2lv bihwcml2cCwgd2gpOworCQkJaWYgKHNwID09IE5VTEwpCisJCQkJTEVBVkUgKEVORVRVTlJFQUNI KTsKKwkJCWlmICgodGFnID0gZ2V0X3RhZyhwaCwgUFRUX0hVUkwpKSkKKwkJCQlzZW5kX2h1cmwo c3AsIHRhZyk7CisJCQlpZiAoKHRhZyA9IGdldF90YWcocGgsIFBUVF9NT1RNKSkpCisJCQkJc2Vu ZF9tb3RtKHNwLCB0YWcpOworCQkJYnJlYWs7CiAJCWRlZmF1bHQ6CiAJCQlMRUFWRShFUEZOT1NV UFBPUlQpOwogCQl9CkBAIC0xOTMzLDYgKzIxNzksOCBAQAogCQljYXNlCVBUVF9TWVNfRVJSOgog CQljYXNlCVBUVF9HRU5fRVJSOgogCQljYXNlCVBUVF9NQVhfUEFZTDoKKwkJY2FzZQlQVFRfSFVS TDoKKwkJY2FzZQlQVFRfTU9UTToKIAkJCWJyZWFrOwogCQl9CiAJCXB0ID0gKGNvbnN0IHN0cnVj dCBwcHBvZV90YWcqKXB0bjsKZGlmZiAtLWdpdCBhL3NoYXJlL21hbi9tYW40L25nX3BwcG9lLjQg Yi9zaGFyZS9tYW4vbWFuNC9uZ19wcHBvZS40Ci0tLSBhL3NoYXJlL21hbi9tYW40L25nX3BwcG9l LjQKKysrIGIvc2hhcmUvbWFuL21hbjQvbmdfcHBwb2UuNApAQCAtMzUsNyArMzUsNyBAQAogLlwi ICRGcmVlQlNEJAogLlwiICRXaGlzdGxlOiBuZ19wcHBvZS44LHYgMS4xIDE5OTkvMDEvMjUgMjM6 NDY6MjcgYXJjaGllIEV4cCAkCiAuXCIKLS5EZCBTZXB0ZW1iZXIgMTUsIDIwMTUKKy5EZCBNYXJj aCAxLCAyMDE3CiAuRHQgTkdfUFBQT0UgNAogLk9zCiAuU2ggTkFNRQpAQCAtMTA0LDEyICsxMDQs MjIgQEAKIEl0IG11c3QgYmUgbmV3bHkgY3JlYXRlZCBhbmQgYSBzZXJ2aWNlIG5hbWUgY2FuIGJl IGdpdmVuIGFzIGFuIGFyZ3VtZW50LgogSXQgaXMgbGVnYWwgdG8gc3BlY2lmeSBhIHplcm8tbGVu Z3RoIHNlcnZpY2UgbmFtZSwgdGhpcyBpcyBjb21tb24KIG9uIHNvbWUgRFNMIHNldHVwcy4KLUl0 IGlzIHBvc3NpYmxlIHRvIHJlcXVlc3QgYSBjb25uZWN0aW9uIHRvIGEgc3BlY2lmaWMKLWFjY2Vz cyBjb25jZW50cmF0b3IgYnkgaXRzIG5hbWUgdXNpbmcgdGhlICJBQy1OYW1lXFxTZXJ2aWNlLU5h bWUiIHN5bnRheC4KK0l0IGlzIHBvc3NpYmxlIHRvIHJlcXVlc3QgYSBjb25uZWN0aW9uIHRvIGEg c3BlY2lmaWMgYWNjZXNzIGNvbmNlbnRyYXRvciwKK2FuZC9vciBzZXQgYSBzcGVjaWZpYyBob3N0 IHVuaXEgdGFnLCByZXF1aXJlZCBieSBzb21lIEludGVybmV0IHByb3ZpZGVycywKK3VzaW5nIHRo ZSAiW0FDLU5hbWVcXF1bSG9zdC1VbmlxfF1TZXJ2aWNlLU5hbWUiIHN5bnRheC4KK1RvIHNldCBh IGJpbmFyeSBIb3N0LVVuaXEsIGl0IG11c3QgYmUgZW5jb2RlZCBhcyBhIGhleGFkZWNpbWFsIGxv d2VyY2FzZQorc3RyaW5nIGFuZCBwcmVmaXhlZCB3aXRoICIweCIsIGVnLiAiMHg2ZDc5MmQ3NDYx NjciIGlzIGVxdWl2YWxlbnQgdG8KKyJteS10YWciLgogQSBzZXNzaW9uIHJlcXVlc3QgcGFja2V0 IHdpbGwgYmUgYnJvYWRjYXN0ZWQgb24gdGhlIEV0aGVybmV0LgogVGhpcyBjb21tYW5kIHVzZXMg dGhlCiAuRHYgbmdwcHBvZV9pbml0X2RhdGEKIHN0cnVjdHVyZSBzaG93biBiZWxvdy4KK0ZvciBl eGFtcGxlLCB0aGUgZm9sbG93aW5nIGluaXQgZGF0YSBhcmd1bWVudCBjYW4gYmUgdXNlZCB0bwor Y29ubmVjdCB0byAibXktaXNwIiBzZXJ2aWNlIHdpdGggIm15LWhvc3QiIHVuaXEgdGFnLCBhY2Nl cHRpbmcgb25seQorInJlbW90ZS1hYyIgYXMgYWNjZXNzIGNvbmNlbnRyYXRvcjoKKy5CZCAtbGl0 ZXJhbCAtb2Zmc2V0IGluZGVudAorInJlbW90ZS1hY1xcbXktaG9zdHxteS1pc3AiCisuRWQKIC5J dCBEdiBOR01fUFBQT0VfTElTVEVOIFBxIEljIHBwcG9lX2xpc3RlbgogVGVsbCBhIG5vbWluYXRl ZCBuZXdseSBjcmVhdGVkIGhvb2sgdGhhdCBpdHMgc2Vzc2lvbiBzaG91bGQgZW50ZXIKIHRoZSBz dGF0ZSBtYWNoaW5lIGFzIGEgc2VydmVyIGxpc3RlbmVyLgpAQCAtMjU4LDcgKzI2OCw0MSBAQAog ICAgIHVpbnQxNl90IGRhdGE7CiB9OwogLkVkCisuSXQgRHYgTkdNX1BQUE9FX1NFTkRfSFVSTCBQ cSBJYyBzZW5kX2h1cmwKK1RlbGwgYSBub21pbmF0ZWQgaG9vayB3aXRoIGFuIGFjdGl2ZSBzZXNz aW9uIHRvIHNlbmQgYSBQQURNIG1lc3NhZ2Ugd2l0aAorYSBIVVJMIHRhZy4KK1RoZSBhcmd1bWVu dCBnaXZlbiBpcyB0aGUgVVJMIHRoYXQgd2lsbCBiZSBkZWxpdmVyZWQgdG8gdGhlIGNsaWVudDoK Ky5CZCAtbGl0ZXJhbCAtb2Zmc2V0IGluZGVudAorbmdjdGwgbXNnIGZ4cDA6b3JwaGFucyBzZW5k X2h1cmwgJ3sgaG9vaz0ibXlIb29rIiBkYXRhPSJodHRwOi8vZXhhbXBsZS5uZXQvY3BlIiB9Jwor LkVkCisuSXQgRHYgTkdNX1BQUE9FX1NFTkRfTU9UTSBQcSBJYyBzZW5kX21vdG0KK1RlbGwgYSBu b21pbmF0ZWQgaG9vayB3aXRoIGFuIGFjdGl2ZSBzZXNzaW9uIHRvIHNlbmQgYSBQQURNIG1lc3Nh Z2Ugd2l0aAorYSBNT1RNIHRhZy4KK1RoZSBhcmd1bWVudCBnaXZlbiBpcyB0aGUgbWVzc2FnZSB0 aGF0IHdpbGwgYmUgZGVsaXZlcmVkIHRvIHRoZSBjbGllbnQ6CisuQmQgLWxpdGVyYWwgLW9mZnNl dCBpbmRlbnQKK25nY3RsIG1zZyBmeHAwOm9ycGhhbnMgc2VuZF9tb3RtICd7IGhvb2s9Im15SG9v ayIgZGF0YT0iV2VsY29tZSBhYm9hcmQiIH0nCisuRWQKIC5FbAorLlBwCitUaGUgdHdvIGNvbW1h bmRzIGFib3ZlIHVzZSB0aGUgc2FtZSBuZ3BwcG9lX2luaXRfZGF0YSBzdHJ1Y3R1cmUgZGVzY3Jp YmVkCithYm92ZS4KKy5CbCAtdGFnIC13aWR0aCAzbgorLkl0IER2IE5HTV9QUFBPRV9IVVJMCitU aGlzIGNvbW1hbmQgaXMgc2VudCB0byB0aGUgbm9kZSB0aGF0IHN0YXJ0ZWQgdGhpcyBzZXNzaW9u IHdoZW4gYSBQQURNCittZXNzYWdlIHdpdGggYSBIVVJMIHRhZyBpcyByZWNlaXZlZCwgYW5kIGNv bnRhaW5zIGEgVVJMIHRoYXQgdGhlIEhvc3QgbWF5CitwYXNzIHRvIGEgd2ViIGJyb3dzZXIgZm9y IHByZXNlbnRhdGlvbiB0byB0aGUgdXNlci4KKy5JdCBEdiBOR01fUFBQT0VfTU9UTQorVGhpcyBj b21tYW5kIGlzIHNlbnQgdG8gdGhlIG5vZGUgdGhhdCBzdGFydGVkIHRoaXMgc2Vzc2lvbiB3aGVu IGEgUEFETQorbWVzc2FnZSB3aXRoIGEgTU9UTSB0YWcgaXMgcmVjZWl2ZWQsIGFuZCBjb250YWlu cyBhIE1lc3NhZ2UgT2YgVGhlCitNaW51dGUgdGhhdCB0aGUgSG9zdCBtYXkgZGlzcGxheSB0byB0 aGUgdXNlci4KKy5FbAorLlBwCitUaGUgdHdvIGNvbW1hbmRzIGFib3ZlIHVzZSBhIGNvbW1vbiBk YXRhIHN0cnVjdHVyZToKKy5CZCAtbGl0ZXJhbCAtb2Zmc2V0IDRuCitzdHJ1Y3QgbmdwcHBvZV9w YWRtIHsKKyAgICBjaGFyICAgIG1zZ1tQUFBPRV9QQURNX1ZBTFVFX1NJWkVdOworfTsKKy5FZAog LlNoIFNIVVRET1dOCiBUaGlzIG5vZGUgc2h1dHMgZG93biB1cG9uIHJlY2VpcHQgb2YgYQogLkR2 IE5HTV9TSFVURE9XTgoK --b1_5d0d17fed4f7ff51825b42ccacdc7321-- From owner-freebsd-net@freebsd.org Wed Mar 1 23:05:53 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 90ECBCF4466 for ; Wed, 1 Mar 2017 23:05:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 809DCB96 for ; Wed, 1 Mar 2017 23:05:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v21N5pMe057842 for ; Wed, 1 Mar 2017 23:05:53 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217463] socket calls can cause panic after passing socket to nfssvc Date: Wed, 01 Mar 2017 23:05:51 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 23:05:53 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217463 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-bugs@FreeBSD.org |freebsd-net@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Thu Mar 2 04:34:09 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D18A0CF5443 for ; Thu, 2 Mar 2017 04:34:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C0E9AEAA for ; Thu, 2 Mar 2017 04:34:09 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v224Y9s2047559 for ; Thu, 2 Mar 2017 04:34:09 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217413] panic: Assertion err == 0 failed at /usr/src/sys/net/iflib.c:2242 after 1000m physical link shutdown Date: Thu, 02 Mar 2017 04:34:09 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: bsd@kobyla.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: short_desc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 04:34:09 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217413 bsd@kobyla.org changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|panic: Assertion err =3D=3D 0 |panic: Assertion err = =3D=3D 0 |failed at |failed at |/usr/src/sys/net/iflib.c:22 |/usr/src/sys/net/iflib.c:22 |42 after attaching the |42 after 1000m physical |cable with 1000m fixed |link shutdown |speed at another end | --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Thu Mar 2 04:38:11 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 08089CF5548 for ; Thu, 2 Mar 2017 04:38:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EAFA6FBC for ; Thu, 2 Mar 2017 04:38:10 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v224cAtT052813 for ; Thu, 2 Mar 2017 04:38:10 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217413] panic: Assertion err == 0 failed at /usr/src/sys/net/iflib.c:2242 after 1000m physical link shutdown Date: Thu, 02 Mar 2017 04:38:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: bsd@kobyla.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 04:38:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217413 --- Comment #3 from bsd@kobyla.org --- Affects all 3 types of used cards - em, igb, bce. Tested only on amd64. When router on another side of one of 4 active links reboots, this server g= ets this panic either. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Thu Mar 2 05:43:49 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 60CD0CF532E for ; Thu, 2 Mar 2017 05:43:49 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 3A8B8B8B for ; Thu, 2 Mar 2017 05:43:49 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id E4A294FF; Thu, 2 Mar 2017 05:43:48 +0000 (UTC) Date: Thu, 2 Mar 2017 05:43:48 +0000 To: freebsd-net@freebsd.org From: "mav (Alexander Motin)" Reply-to: D9270+325+bbd470fd257eef1b@reviews.freebsd.org Subject: [Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , Thread-Topic: D9270: Add support for user-supplied Host-Uniq tag in Netgraph PPPoE X-Herald-Rules: <28>, <8> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: NTZkNjQzYWQxOGQ3MGJlZTIzOGZhZmQ4NGNmIFi3sRQ= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 05:43:49 -0000 bWF2IGFjY2VwdGVkIHRoaXMgcmV2aXNpb24uCm1hdiBhZGRlZCBhIHJldmlld2VyOiBtYXYuCm1h diBhZGRlZCBhIGNvbW1lbnQuClRoaXMgcmV2aXNpb24gaGFzIGEgcG9zaXRpdmUgcmV2aWV3LgoK CiAgSXQncyBiZWVuIHllYXJzIHNpbmNlIEkgd29ya2VkIG9uIHRoaXMsIGJ1dCBJIHNlZSBubyBw cm9ibGVtcyBmcm9tIHRoaXMuCgpSRVBPU0lUT1JZCiAgclMgRnJlZUJTRCBzcmMgcmVwb3NpdG9y eQoKUkVWSVNJT04gREVUQUlMCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0Q5MjcwCgpF TUFJTCBQUkVGRVJFTkNFUwogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9zZXR0aW5ncy9w YW5lbC9lbWFpbHByZWZlcmVuY2VzLwoKVG86IGFsZSwgI21hbnBhZ2VzLCBhZHJpYW4sICNuZXR3 b3JrLCBqdWxpYW4sIG1hdgpDYzogbWF2LCBwb29scm9vbV9nbWFpbC5jb20sIG1hbmRyZWUsIGlt cCwgZnJlZWJzZC1uZXQtbGlzdAo= From owner-freebsd-net@freebsd.org Thu Mar 2 14:03:12 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BED2BCF388B for ; Thu, 2 Mar 2017 14:03:12 +0000 (UTC) (envelope-from vegeta@tuxpowered.net) Received: from mail-wm0-x22c.google.com (mail-wm0-x22c.google.com [IPv6:2a00:1450:400c:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5B4D3B2C for ; Thu, 2 Mar 2017 14:03:12 +0000 (UTC) (envelope-from vegeta@tuxpowered.net) Received: by mail-wm0-x22c.google.com with SMTP id n11so25751281wma.0 for ; Thu, 02 Mar 2017 06:03:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxpowered-net.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:organization:user-agent :mime-version; bh=umpp4tNRqUj3KaYDcC6NXb/K/bjXtzK2YtvR7/46Fww=; b=OviqK2oRu+HjrOAPvVd0tanvDh8WrXn6107YZN26iELv9Mbk2NkcuXHLedjrnsHa8o dCpohvSr/JKXbVEQ6JsMKtfYgIWUHnCU3Xox5q/dx09DjhEnW14+xlz7eaEK6ba3hjBT QCQwf4cjC/ug7Pt0xZQBNJUZ6KwczEfQrZsWEKHgY5wwsb50ueDbGbjNgP1dzRQ7YHzO DvZXOHLkXUmnJGwLPeklR5DAUuaRILaFEdePlxtGNnDqGYDZxrHQbZHxYV8ACV7l4tzh BIWUahxnXYG14T9TvwVgLOPtHQ74v2XUfOUAanvP8Y7uVZXZpZZ0DQCvLAe2HIZoipcq Qpmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:organization :user-agent:mime-version; bh=umpp4tNRqUj3KaYDcC6NXb/K/bjXtzK2YtvR7/46Fww=; b=PfaYMbB6ZSaNkEtHCpr+oFrESSEEmkQC1ok0O15rFm8xxCdI3GKYS/aEoAlVCo3RJR +mLP/USczkClpgNeAdA+e1d2gxXcEb53y/4sm1jQ5uib4JuYf180tzf3hfhvUA7FwlXP 1Ou+PrvPmFmUurI5gBxVaJ3pJOFqOWp52q74zhjJXB4UgeA39+z7hNZQ42Jcro2ddW/5 tIlGGJ10NeK6gjEQzhMwiGjdwgFguCMv+LO0JqXqOmxpJ3cY3KnUszwCVMoLJkmTGIGe nW9G4QN6vRqtsBNQsRa3m+0OaYsv5hCBY5iB30/tqDecqRYTpa+avyZIBYw3EovyDde5 aI6Q== X-Gm-Message-State: AMke39k5Vwr6M/HjETF4Vl1rCiVz2tY88a7UX5TW4ApqzGqLvQYRAUD0qNGJ4yD3kdYD2g== X-Received: by 10.28.69.194 with SMTP id l63mr8029090wmi.23.1488463388067; Thu, 02 Mar 2017 06:03:08 -0800 (PST) Received: from energia.localnet ([2a00:1f78:fffb:220:c7f7:2dda:4b51:2d6b]) by smtp.gmail.com with ESMTPSA id v102sm10981308wrb.11.2017.03.02.06.03.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Mar 2017 06:03:06 -0800 (PST) From: Kajetan Staszkiewicz To: freebsd-net@freebsd.org Subject: Why is MSI-X support disabled on bce(4)? Date: Thu, 02 Mar 2017 15:02:55 +0100 Message-ID: <1946092.tUUkk3b7I7@energia> Organization: tuxpowered.net User-Agent: KMail/5.2.3 (Linux/4.9.0-12.1-liquorix-amd64; KDE/5.28.0; x86_64; ; ) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2614754.yBO3NSJfFu"; micalg="pgp-sha1"; protocol="application/pgp-signature" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 14:03:12 -0000 --nextPart2614754.yBO3NSJfFu Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" To whom it might concern: Well, at least it does concern me. Why is support for multiple interrupts a= nd=20 queues not enabled on bce(4)? Whole block of code is surrounded with #ifdef 0 ... #endif https://github.com/freebsd/freebsd/blob/master/sys/dev/bce/if_bce.c#L1108 =2D-=20 | pozdrawiam / greetings | powered by Debian, FreeBSD and CentOS | | Kajetan Staszkiewicz | jabber,email: vegeta()tuxpowered net | | Vegeta | www: http://vegeta.tuxpowered.net | `------------------------^---------------------------------------' --nextPart2614754.yBO3NSJfFu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQSOEQZObv2B8mf0JbnjtFCvbXs6FAUCWLgmDwAKCRDjtFCvbXs6 FNwhAKCgQpfIJLJglLetEs5ABoEpswPdOACfbRd3OJyvfQ3NOeCfrl77JujL+80= =Tm8A -----END PGP SIGNATURE----- --nextPart2614754.yBO3NSJfFu-- From owner-freebsd-net@freebsd.org Thu Mar 2 16:38:45 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2D078CF5F01 for ; Thu, 2 Mar 2017 16:38:45 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 083B67A2 for ; Thu, 2 Mar 2017 16:38:45 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 6555A1A741; Thu, 2 Mar 2017 16:38:44 +0000 (UTC) Date: Thu, 2 Mar 2017 16:38:44 +0000 To: freebsd-net@freebsd.org From: "gnn (George Neville-Neil)" Reply-to: D9847+325+deba385e191bfbb6@reviews.freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , Thread-Topic: D9847: Try to extract the RFC1048 data from PXE X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: Precedence: bulk In-Reply-To: References: Thread-Index: YTlhODdhNGFiNzc3NzE3ZGRmMjFjNTkwOTA3IFi4SpQ= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 16:38:45 -0000 Z25uIGFjY2VwdGVkIHRoaXMgcmV2aXNpb24uCmdubiBhZGRlZCBhIHJldmlld2VyOiBnbm4uClRo aXMgcmV2aXNpb24gaGFzIGEgcG9zaXRpdmUgcmV2aWV3LgoKUkVWSVNJT04gREVUQUlMCiAgaHR0 cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0Q5ODQ3CgpFTUFJTCBQUkVGRVJFTkNFUwogIGh0dHBz Oi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9zZXR0aW5ncy9wYW5lbC9lbWFpbHByZWZlcmVuY2VzLwoK VG86IGtjemVraXJkYSwgb3Nob2dibywgYmFwdCwgdHNvb21lLCBnbGViaXVzLCBmcmVlYnNkLW5l dC1saXN0LCAjbmV0d29yaywgZ25uCg== From owner-freebsd-net@freebsd.org Thu Mar 2 16:44:13 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6A0B8CF51EA for ; Thu, 2 Mar 2017 16:44:13 +0000 (UTC) (envelope-from debra.berk@worldonlinetech.com) Received: from IND01-BO1-obe.outbound.protection.outlook.com (mail-bo1ind01hn0224.outbound.protection.outlook.com [104.47.101.224]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C5118C5B for ; Thu, 2 Mar 2017 16:44:11 +0000 (UTC) (envelope-from debra.berk@worldonlinetech.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NETORGFT1177539.onmicrosoft.com; s=selector1-worldonlinetech-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=/oq7YWyg86h+MIQKkJNVQRrKewgYXW+vQdF0i+eMUVw=; b=rFFiY6gVaSNdS9jhKyyiWkFQIuFX6mDX7dlTsBK06M+F+gtYWLA2ZjYOLMqV16B4oeP0cwVTXO+CenHmgtH3Muhu299G7jET7Ak/9aNQl2pk5NpkgunYdN9UbSCf6SSFLPOpBVO/vgbXo+DUL8B2FiYAdRnFdsHa1GDnFCrfnps= Received: from PN1PR01MB0269.INDPRD01.PROD.OUTLOOK.COM (10.164.140.12) by PN1PR01MB0269.INDPRD01.PROD.OUTLOOK.COM (10.164.140.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.12; Thu, 2 Mar 2017 16:44:09 +0000 Received: from PN1PR01MB0269.INDPRD01.PROD.OUTLOOK.COM ([10.164.140.12]) by PN1PR01MB0269.INDPRD01.PROD.OUTLOOK.COM ([10.164.140.12]) with mapi id 15.01.0947.012; Thu, 2 Mar 2017 16:44:09 +0000 From: Debra Berk To: "freebsd-net@freebsd.org" Subject: Wide Area Network (WAN) Users List Thread-Topic: Wide Area Network (WAN) Users List Thread-Index: AdKTce06DxGmutjqRPe4HhTTTbTDVg== Date: Thu, 2 Mar 2017 16:28:20 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=none action=none header.from=worldonlinetech.com; x-originating-ip: [106.51.17.239] x-ms-office365-filtering-correlation-id: 0ea69341-1836-424b-a3c6-08d4618b5939 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201702085551020)(201702085554020)(201702085553020)(201702085552020); SRVR:PN1PR01MB0269; x-microsoft-exchange-diagnostics: 1; PN1PR01MB0269; 7:ikGifDiiuppl7p7tand2MNeV3VZswmfiRz3tvdyTjmcRCnMjyk28gMRGngaMQ4kaawy1XPUKbndV2dRVVkUye8L30OQ4BVhG/6pVH6aM4lvfBQkjaXbtW/oomrxIItAOW7GJe4GKUFbbNbbNODjmxRlk9yhisuqRZLsxZ2jfJ3zkAndA1LnqH1hZ/GP5XK2wkX/GnKqIGmPn11Jd1NQTMJiOVl6NBBVpqKOzF5PfBEDl45KAcKlujxuAvwzqOX7cqax9t7DDYnO3agNarRxyG83ae1JX+87JzUYwosq/pscuj3ZBAuAfLBxk/BlKOkA2p6pCbdEPNDBIjPZD04D5Jg== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(21748063052155); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040375)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123558025)(20161123555025)(20161123560025)(20161123564025)(2016111802025)(20161123562025)(6072148)(6043046); SRVR:PN1PR01MB0269; BCL:0; PCL:0; RULEID:; SRVR:PN1PR01MB0269; x-forefront-prvs: 023495660C x-forefront-antispam-report: SFV:SPM; SFS:(10009020)(6009001)(7916002)(39450400003)(39840400002)(39850400002)(39410400002)(39860400002)(102836003)(189998001)(6116002)(790700001)(86362001)(33656002)(6666003)(2351001)(3846002)(54356999)(450100001)(7696004)(5660300001)(6436002)(5640700003)(54896002)(6306002)(2501003)(9686003)(6916009)(5630700001)(6506006)(77096006)(66066001)(50986999)(53936002)(74316002)(110136004)(7736002)(55016002)(92566002)(122556002)(8936002)(2906002)(9456002)(3280700002)(81166006)(38730400002)(8676002)(2900100001)(3660700001)(20910200001)(19870200002); DIR:OUT; SFP:1501; SCL:5; SRVR:PN1PR01MB0269; H:PN1PR01MB0269.INDPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; MLV:ovr; PTR:InfoNoRecords; LANG:en; spamdiagnosticoutput: 1:22 MIME-Version: 1.0 X-OriginatorOrg: worldonlinetech.com X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2017 16:28:20.2922 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 40e9ea0d-94bc-4216-99c9-a53b82937ddf X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN1PR01MB0269 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 16:44:13 -0000 Hello there, Would you be interested in acquiring Wide Area Network (WAN) Users List for= your marketing campaign? Some WAN Software Users like: CA Technologies, Dynatrace, IBM, HP, AppDynam= ics, Dell, Riverbed, BMC, AppNeta and many more... If you're interested please let me know the geography and job title you are= looking out to target for so that we can provide you with counts, pricing = and samples in my next email. If you are not the right person, please feel free to forward this email to = the right person in your organization. Await your response! Regards, Debra Berk Database Consultant To Opt Out, please respond "REMOVE" in the Subject line. From owner-freebsd-net@freebsd.org Thu Mar 2 17:15:20 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9C636CF5EFB for ; Thu, 2 Mar 2017 17:15:20 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 785AF623 for ; Thu, 2 Mar 2017 17:15:20 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id C60551A78E; Thu, 2 Mar 2017 17:15:19 +0000 (UTC) Date: Thu, 2 Mar 2017 17:15:19 +0000 To: freebsd-net@freebsd.org From: "smh (Steven Hartland)" Reply-to: D9847+325+deba385e191bfbb6@reviews.freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , Thread-Topic: D9847: Try to extract the RFC1048 data from PXE X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: YTlhODdhNGFiNzc3NzE3ZGRmMjFjNTkwOTA3IFi4Uyc= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 17:15:20 -0000 c21oIHJlcXVlc3RlZCBjaGFuZ2VzIHRvIHRoaXMgcmV2aXNpb24uCnNtaCBhZGRlZCBhIHJldmll d2VyOiBzbWguCnNtaCBhZGRlZCBpbmxpbmUgY29tbWVudHMuClRoaXMgcmV2aXNpb24gbm93IHJl cXVpcmVzIGNoYW5nZXMgdG8gcHJvY2VlZC4KCklOTElORSBDT01NRU5UUwoKPiBib290cC5oOjE1 MQo+ICsKPiArI2lmbmRlZiBCT09UUAo+ICsjZGVmaW5lIEJPT1RQCgpJcyB0aGlzIG5lZWRlZCBh cyBpdCBsb29rcyBsaWtlIGl0cyB0byBlbnN1cmUgaXRzIG9ubHkgaW5jbHVkZWQgb25jZSBieSB0 aGUgX0JPT1RQX0hfIHNob3VsZCBhY2hpZXZlIHRoYXQKCj4gcHhlLmM6MjgyCj4gKwkJCWlmIChz b2NrdG9kZXNjKHB4ZV9zb2NrKSA9PSBOVUxMKSB7Cj4gKwkJCQlwcmludGYoInB4ZV9vcGVuOiBi YWQgc29ja2V0LiAlZFxuIiwgcHhlX3NvY2spOwo+ICsJCQkJcmV0dXJuIChFTlhJTyk7CgpUaGUg Zm9ybWF0dGluZyBoZXJlIGlzIGEgYml0IG9kZCwgcmVtb3ZlIHRoZSAiLiIgPwoKPiBweGUuYzoy OTkKPiArCQkJCWJvb3RwKHB4ZV9zb2NrLCBCT09UUF9QWEUpOwo+ICsJCQl9IGVsc2UKPiArCQkJ CXByaW50ZigicHhlX29wZW46IGxvYWRlZCBSRkMxMDQ4IGRhdGEgZnJvbSBQWEUgQ2FjaGVcbiIp OwoKU2hvdWxkIHRoaXMgb25seSBiZSBvdXRwdXQgdW5kZXIgdmVyYm9zZSBib290IG9yIHB4ZV9k ZWJ1Zz8KClJFVklTSU9OIERFVEFJTAogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9EOTg0 NwoKRU1BSUwgUFJFRkVSRU5DRVMKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvc2V0dGlu Z3MvcGFuZWwvZW1haWxwcmVmZXJlbmNlcy8KClRvOiBrY3pla2lyZGEsIG9zaG9nYm8sIGJhcHQs IHRzb29tZSwgZ2xlYml1cywgZnJlZWJzZC1uZXQtbGlzdCwgI25ldHdvcmssIGdubiwgc21oCkNj OiBzbWgK From owner-freebsd-net@freebsd.org Thu Mar 2 20:40:03 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E7B1ECF6292 for ; Thu, 2 Mar 2017 20:40:03 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id C03ACBF4 for ; Thu, 2 Mar 2017 20:40:03 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 265B3166D9; Thu, 2 Mar 2017 20:40:03 +0000 (UTC) Date: Thu, 2 Mar 2017 20:40:03 +0000 To: freebsd-net@freebsd.org From: "kczekirda (Kamil Czekirda)" Reply-to: D9847+325+deba385e191bfbb6@reviews.freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: <57420d8c994ced41d3d8297b3f8f5866@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , Thread-Topic: D9847: Try to extract the RFC1048 data from PXE X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: YTlhODdhNGFiNzc3NzE3ZGRmMjFjNTkwOTA3IFi4gyM= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_57420d8c994ced41d3d8297b3f8f5866" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 20:40:04 -0000 --b1_57420d8c994ced41d3d8297b3f8f5866 Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: base64 a2N6ZWtpcmRhIHVwZGF0ZWQgdGhpcyByZXZpc2lvbiB0byBEaWZmIDI1OTEzLgprY3pla2lyZGEg bWFya2VkIDMgaW5saW5lIGNvbW1lbnRzIGFzIGRvbmUuCgpDSEFOR0VTIFNJTkNFIExBU1QgVVBE QVRFCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0Q5ODQ3P3ZzPTI1ODQzJmlkPTI1OTEz CgpSRVZJU0lPTiBERVRBSUwKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvRDk4NDcKCkFG RkVDVEVEIEZJTEVTCiAgL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmMKICAvdXNyL3NyYy9s aWIvbGlic3RhbmQvYm9vdHAuaAogIC91c3Ivc3JjL3N5cy9ib290L2kzODYvbGliaTM4Ni9weGUu YwoKRU1BSUwgUFJFRkVSRU5DRVMKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvc2V0dGlu Z3MvcGFuZWwvZW1haWxwcmVmZXJlbmNlcy8KClRvOiBrY3pla2lyZGEsIG9zaG9nYm8sIGJhcHQs IHRzb29tZSwgZ2xlYml1cywgZnJlZWJzZC1uZXQtbGlzdCwgc21oLCBnbm4sICNuZXR3b3JrCkNj OiBzbWgK --b1_57420d8c994ced41d3d8297b3f8f5866 Content-Type: text/x-patch; charset=utf-8; name="D9847.25913.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D9847.25913.patch" ZGlmZiAtLWdpdCBhLy91c3Ivc3JjL3N5cy9ib290L2kzODYvbGliaTM4Ni9weGUuYy5vbGQgYi8v dXNyL3NyYy9zeXMvYm9vdC9pMzg2L2xpYmkzODYvcHhlLmMKLS0tIGEvL3Vzci9zcmMvc3lzL2Jv b3QvaTM4Ni9saWJpMzg2L3B4ZS5jLm9sZAorKysgYi8vdXNyL3NyYy9zeXMvYm9vdC9pMzg2L2xp YmkzODYvcHhlLmMKQEAgLTEwMSw2ICsxMDEsNyBAQAogZXh0ZXJuIHVfaW50MTZfdAkJX19weGVu dnNlZzsKIGV4dGVybiB1X2ludDE2X3QJCV9fcHhlbnZvZmY7CiBleHRlcm4gdm9pZAkJCV9fcHhl bnZlbnRyeSh2b2lkKTsKK2V4dGVybiBzdHJ1Y3QgaW5fYWRkcgkJc2VydmlwOwogCiBzdHJ1Y3Qg bmV0aWZfZGlmIHB4ZV9pZnNbXSA9IHsKIC8qCWRpZl91bml0ICAgICAgICBkaWZfbnNlbCAgICAg ICAgZGlmX3N0YXRzICAgICAgIGRpZl9wcml2YXRlICAgICAqLwpAQCAtMjc2LDE3ICsyNzcsMzkg QEAKIAkJCX0KIAkJCWlmIChweGVfZGVidWcpCiAJCQkJcHJpbnRmKCJweGVfb3BlbjogbmV0aWZf b3BlbigpIHN1Y2NlZWRlZFxuIik7CisKKwkJCWlmIChzb2NrdG9kZXNjKHB4ZV9zb2NrKSA9PSBO VUxMKSB7CisJCQkJCXByaW50ZigicHhlX29wZW46IGJhZCBzb2NrZXQgJWRcbiIsIHB4ZV9zb2Nr KTsKKwkJCQkJcmV0dXJuIChFTlhJTyk7CisJCQkJfQorCiAJCX0KIAkJaWYgKHJvb3RpcC5zX2Fk ZHIgPT0gMCkgewogCQkJLyoKLQkJCSAqIERvIGEgYm9vdHAvZGhjcCByZXF1ZXN0IHRvIGZpbmQg b3V0IHdoZXJlIG91cgorCQkJICogVHJ5IHRvIGV4dHJhY3QgdGhlIFJGQzEwNDggZGF0YSBmcm9t IFBYRS4KKwkJCSAqIElmIGZhaWwgZG8gYSBib290cC9kaGNwIHJlcXVlc3QgdG8gZmluZCBvdXQg d2hlcmUgb3VyCiAJCQkgKiBORlMvVEZUUCBzZXJ2ZXIgaXMuIEV2ZW4gaWYgd2UgZG9udCBnZXQg YmFjawogCQkJICogdGhlIHByb3BlciBpbmZvcm1hdGlvbiwgZmFsbCBiYWNrIHRvIHRoZSBzZXJ2 ZXIKIAkJCSAqIHdoaWNoIGJyb3VnaHQgdXMgdG8gbGlmZSBhbmQgYSBkZWZhdWx0IHJvb3RwYXRo LgogCQkJICovCi0JCQlib290cChweGVfc29jaywgQk9PVFBfUFhFKTsKKworCQkJaWYgKGRoY3Bf dHJ5X3JmYzEwNDgoYm9vdHBsYXllci52ZW5kb3IuZCwgQk9PVFBfREhDUFZFTkQpKSB7CisJCQkJ aWYgKHB4ZV9kZWJ1ZykKKwkJCQkJcHJpbnRmKCJweGVfb3Blbjogbm8gUkZDMTA0OCBkYXRhIGlu IFBYRSBDYWNoZVxuIik7CisJCQkJYm9vdHAocHhlX3NvY2ssIEJPT1RQX1BYRSk7CisJCQl9IGVs c2UgeworCQkJCWlmIChweGVfZGVidWcpCisJCQkJCXByaW50ZigicHhlX29wZW46IGxvYWRlZCBS RkMxMDQ4IGRhdGEgZnJvbSBQWEUgQ2FjaGVcbiIpOworCQkJfQorCiAJCQlpZiAocm9vdGlwLnNf YWRkciA9PSAwKQogCQkJCXJvb3RpcC5zX2FkZHIgPSBib290cGxheWVyLnNpcDsKKwkJCWlmIChn YXRlaXAuc19hZGRyID09IDApCisJCQkJZ2F0ZWlwLnNfYWRkciA9IGJvb3RwbGF5ZXIuZ2lwOwor CQkJaWYgKG15aXAuc19hZGRyID09IDApCisJCQkJbXlpcC5zX2FkZHIgPSBib290cGxheWVyLnlp cDsKKwkJCWlmIChzZXJ2aXAuc19hZGRyID09IDApCisJCQkJc2VydmlwID0gcm9vdGlwOwogCiAJ CQluZXRwcm90byA9IE5FVF9ORlM7CiAJCQlpZiAodGZ0cGlwLnNfYWRkciAhPSAwKSB7CkBAIC0z MjMsNiArMzQ2LDkgQEAKIAkJCXByaW50ZigicHhlX29wZW46IHNlcnZlciBhZGRyOiAlc1xuIiwg aW5ldF9udG9hKHJvb3RpcCkpOwogCQkJcHJpbnRmKCJweGVfb3Blbjogc2VydmVyIHBhdGg6ICVz XG4iLCByb290cGF0aCk7CiAJCQlwcmludGYoInB4ZV9vcGVuOiBnYXRld2F5IGlwOiAgJXNcbiIs IGluZXRfbnRvYShnYXRlaXApKTsKKwkJCXByaW50ZigicHhlX29wZW46IG15IGlwOiAgICAgICAl c1xuIiwgaW5ldF9udG9hKG15aXApKTsKKwkJCXByaW50ZigicHhlX29wZW46IG5ldG1hc2s6ICAg ICAlc1xuIiwgaW50b2EobmV0bWFzaykpOworCQkJcHJpbnRmKCJweGVfb3Blbjogc2VydmlwOiAg ICAgICVzXG4iLCBpbmV0X250b2Eoc2VydmlwKSk7CiAKIAkJCWlmIChuZXRwcm90byA9PSBORVRf VEZUUCkgewogCQkJCXNldGVudigiYm9vdC50ZnRwcm9vdC5zZXJ2ZXIiLCBpbmV0X250b2Eocm9v dGlwKSwgMSk7CmRpZmYgLS1naXQgYS8vdXNyL3NyYy9saWIvbGlic3RhbmQvYm9vdHAuYy5vbGQg Yi8vdXNyL3NyYy9saWIvbGlic3RhbmQvYm9vdHAuYwotLS0gYS8vdXNyL3NyYy9saWIvbGlic3Rh bmQvYm9vdHAuYy5vbGQKKysrIGIvL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmMKQEAgLTM0 NCw2ICszNDQsMTcgQEAKIAlyZXR1cm4gKC0xKTsKIH0KIAoraW50CitkaGNwX3RyeV9yZmMxMDQ4 KHVfY2hhciAqY3AsIHVfaW50IGxlbikKK3sKKworCWV4cGVjdGVkX2RoY3Btc2d0eXBlID0gREhD UEFDSzsKKwlpZiAoYmNtcCh2bV9yZmMxMDQ4LCBjcCwgc2l6ZW9mKHZtX3JmYzEwNDgpKSA9PSAw KSB7CisJCXJldHVybiAodmVuZF9yZmMxMDQ4KGNwLCBsZW4pKTsKKwl9CisJcmV0dXJuICgtMSk7 Cit9CisKIHN0YXRpYyBpbnQKIHZlbmRfcmZjMTA0OChjcCwgbGVuKQogCXVfY2hhciAqY3A7CmRp ZmYgLS1naXQgYS8vdXNyL3NyYy9saWIvbGlic3RhbmQvYm9vdHAuaC5vbGQgYi8vdXNyL3NyYy9s aWIvbGlic3RhbmQvYm9vdHAuaAotLS0gYS8vdXNyL3NyYy9saWIvbGlic3RhbmQvYm9vdHAuaC5v bGQKKysrIGIvL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmgKQEAgLTIyLDYgKzIyLDggQEAK ICAqICRGcmVlQlNEOiBoZWFkL2xpYi9saWJzdGFuZC9ib290cC5oIDMwNTEyNSAyMDE2LTA4LTMx IDEzOjE2OjQwWiBiYXB0ICQKICAqLwogCisjaWZuZGVmIF9CT09UUF9IXworI2RlZmluZSBfQk9P VFBfSF8KIAogc3RydWN0IGJvb3RwIHsKIAl1bnNpZ25lZCBjaGFyCWJwX29wOwkJLyogcGFja2V0 IG9wY29kZSB0eXBlICovCkBAIC0xNDUsMyArMTQ3LDcgQEAKIAogLyogdl9mbGFncyB2YWx1ZXMg Ki8KICNkZWZpbmUgVkZfU01BU0sJMQkvKiBTdWJuZXQgbWFzayBmaWVsZCBjb250YWlucyB2YWxp ZCBkYXRhICovCisKK2ludAlkaGNwX3RyeV9yZmMxMDQ4KHVfY2hhciAqY3AsIHVfaW50IGxlbik7 CisKKyNlbmRpZiAvKiBfQk9PVFBfSF8gKi8KCg== --b1_57420d8c994ced41d3d8297b3f8f5866-- From owner-freebsd-net@freebsd.org Thu Mar 2 20:50:03 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DAEA5CF649A for ; Thu, 2 Mar 2017 20:50:03 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id B4ED77B for ; Thu, 2 Mar 2017 20:50:03 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 01DF716EF9; Thu, 2 Mar 2017 20:50:03 +0000 (UTC) Date: Thu, 2 Mar 2017 20:50:02 +0000 To: freebsd-net@freebsd.org From: "kczekirda (Kamil Czekirda)" Reply-to: D9847+325+deba385e191bfbb6@reviews.freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , Thread-Topic: D9847: Try to extract the RFC1048 data from PXE X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: YTlhODdhNGFiNzc3NzE3ZGRmMjFjNTkwOTA3IFi4hXo= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_ef2633f0a55dc86614c9558867fffeeb" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 20:50:04 -0000 --b1_ef2633f0a55dc86614c9558867fffeeb Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: base64 a2N6ZWtpcmRhIHVwZGF0ZWQgdGhpcyByZXZpc2lvbiB0byBEaWZmIDI1OTE0LgoKQ0hBTkdFUyBT SU5DRSBMQVNUIFVQREFURQogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9EOTg0Nz92cz0y NTkxMyZpZD0yNTkxNAoKUkVWSVNJT04gREVUQUlMCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qu b3JnL0Q5ODQ3CgpBRkZFQ1RFRCBGSUxFUwogIC91c3Ivc3JjL2xpYi9saWJzdGFuZC9ib290cC5j CiAgL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmgKICAvdXNyL3NyYy9zeXMvYm9vdC9pMzg2 L2xpYmkzODYvcHhlLmMKCkVNQUlMIFBSRUZFUkVOQ0VTCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVi c2Qub3JnL3NldHRpbmdzL3BhbmVsL2VtYWlscHJlZmVyZW5jZXMvCgpUbzoga2N6ZWtpcmRhLCBv c2hvZ2JvLCBiYXB0LCB0c29vbWUsIGdsZWJpdXMsIGZyZWVic2QtbmV0LWxpc3QsICNuZXR3b3Jr LCBnbm4sIHNtaApDYzogc21oCg== --b1_ef2633f0a55dc86614c9558867fffeeb Content-Type: text/x-patch; charset=utf-8; name="D9847.25914.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D9847.25914.patch" ZGlmZiAtLWdpdCBhLy91c3Ivc3JjL3N5cy9ib290L2kzODYvbGliaTM4Ni9weGUuYy5vbGQgYi8v dXNyL3NyYy9zeXMvYm9vdC9pMzg2L2xpYmkzODYvcHhlLmMKLS0tIGEvL3Vzci9zcmMvc3lzL2Jv b3QvaTM4Ni9saWJpMzg2L3B4ZS5jLm9sZAorKysgYi8vdXNyL3NyYy9zeXMvYm9vdC9pMzg2L2xp YmkzODYvcHhlLmMKQEAgLTEwMSw2ICsxMDEsNyBAQAogZXh0ZXJuIHVfaW50MTZfdAkJX19weGVu dnNlZzsKIGV4dGVybiB1X2ludDE2X3QJCV9fcHhlbnZvZmY7CiBleHRlcm4gdm9pZAkJCV9fcHhl bnZlbnRyeSh2b2lkKTsKK2V4dGVybiBzdHJ1Y3QgaW5fYWRkcgkJc2VydmlwOwogCiBzdHJ1Y3Qg bmV0aWZfZGlmIHB4ZV9pZnNbXSA9IHsKIC8qCWRpZl91bml0ICAgICAgICBkaWZfbnNlbCAgICAg ICAgZGlmX3N0YXRzICAgICAgIGRpZl9wcml2YXRlICAgICAqLwpAQCAtMjc2LDE3ICsyNzcsMzkg QEAKIAkJCX0KIAkJCWlmIChweGVfZGVidWcpCiAJCQkJcHJpbnRmKCJweGVfb3BlbjogbmV0aWZf b3BlbigpIHN1Y2NlZWRlZFxuIik7CisKKwkJCWlmIChzb2NrdG9kZXNjKHB4ZV9zb2NrKSA9PSBO VUxMKSB7CisJCQkJcHJpbnRmKCJweGVfb3BlbjogYmFkIHNvY2tldCAlZFxuIiwgcHhlX3NvY2sp OworCQkJCXJldHVybiAoRU5YSU8pOworCQkJfQorCiAJCX0KIAkJaWYgKHJvb3RpcC5zX2FkZHIg PT0gMCkgewogCQkJLyoKLQkJCSAqIERvIGEgYm9vdHAvZGhjcCByZXF1ZXN0IHRvIGZpbmQgb3V0 IHdoZXJlIG91cgorCQkJICogVHJ5IHRvIGV4dHJhY3QgdGhlIFJGQzEwNDggZGF0YSBmcm9tIFBY RS4KKwkJCSAqIElmIGZhaWwgZG8gYSBib290cC9kaGNwIHJlcXVlc3QgdG8gZmluZCBvdXQgd2hl cmUgb3VyCiAJCQkgKiBORlMvVEZUUCBzZXJ2ZXIgaXMuIEV2ZW4gaWYgd2UgZG9udCBnZXQgYmFj awogCQkJICogdGhlIHByb3BlciBpbmZvcm1hdGlvbiwgZmFsbCBiYWNrIHRvIHRoZSBzZXJ2ZXIK IAkJCSAqIHdoaWNoIGJyb3VnaHQgdXMgdG8gbGlmZSBhbmQgYSBkZWZhdWx0IHJvb3RwYXRoLgog CQkJICovCi0JCQlib290cChweGVfc29jaywgQk9PVFBfUFhFKTsKKworCQkJaWYgKGRoY3BfdHJ5 X3JmYzEwNDgoYm9vdHBsYXllci52ZW5kb3IuZCwgQk9PVFBfREhDUFZFTkQpKSB7CisJCQkJaWYg KHB4ZV9kZWJ1ZykKKwkJCQkJcHJpbnRmKCJweGVfb3Blbjogbm8gUkZDMTA0OCBkYXRhIGluIFBY RSBDYWNoZVxuIik7CisJCQkJYm9vdHAocHhlX3NvY2ssIEJPT1RQX1BYRSk7CisJCQl9IGVsc2Ug eworCQkJCWlmIChweGVfZGVidWcpCisJCQkJCXByaW50ZigicHhlX29wZW46IGxvYWRlZCBSRkMx MDQ4IGRhdGEgZnJvbSBQWEUgQ2FjaGVcbiIpOworCQkJfQorCiAJCQlpZiAocm9vdGlwLnNfYWRk ciA9PSAwKQogCQkJCXJvb3RpcC5zX2FkZHIgPSBib290cGxheWVyLnNpcDsKKwkJCWlmIChnYXRl aXAuc19hZGRyID09IDApCisJCQkJZ2F0ZWlwLnNfYWRkciA9IGJvb3RwbGF5ZXIuZ2lwOworCQkJ aWYgKG15aXAuc19hZGRyID09IDApCisJCQkJbXlpcC5zX2FkZHIgPSBib290cGxheWVyLnlpcDsK KwkJCWlmIChzZXJ2aXAuc19hZGRyID09IDApCisJCQkJc2VydmlwID0gcm9vdGlwOwogCiAJCQlu ZXRwcm90byA9IE5FVF9ORlM7CiAJCQlpZiAodGZ0cGlwLnNfYWRkciAhPSAwKSB7CkBAIC0zMjMs NiArMzQ2LDkgQEAKIAkJCXByaW50ZigicHhlX29wZW46IHNlcnZlciBhZGRyOiAlc1xuIiwgaW5l dF9udG9hKHJvb3RpcCkpOwogCQkJcHJpbnRmKCJweGVfb3Blbjogc2VydmVyIHBhdGg6ICVzXG4i LCByb290cGF0aCk7CiAJCQlwcmludGYoInB4ZV9vcGVuOiBnYXRld2F5IGlwOiAgJXNcbiIsIGlu ZXRfbnRvYShnYXRlaXApKTsKKwkJCXByaW50ZigicHhlX29wZW46IG15IGlwOiAgICAgICAlc1xu IiwgaW5ldF9udG9hKG15aXApKTsKKwkJCXByaW50ZigicHhlX29wZW46IG5ldG1hc2s6ICAgICAl c1xuIiwgaW50b2EobmV0bWFzaykpOworCQkJcHJpbnRmKCJweGVfb3Blbjogc2VydmlwOiAgICAg ICVzXG4iLCBpbmV0X250b2Eoc2VydmlwKSk7CiAKIAkJCWlmIChuZXRwcm90byA9PSBORVRfVEZU UCkgewogCQkJCXNldGVudigiYm9vdC50ZnRwcm9vdC5zZXJ2ZXIiLCBpbmV0X250b2Eocm9vdGlw KSwgMSk7CmRpZmYgLS1naXQgYS8vdXNyL3NyYy9saWIvbGlic3RhbmQvYm9vdHAuYy5vbGQgYi8v dXNyL3NyYy9saWIvbGlic3RhbmQvYm9vdHAuYwotLS0gYS8vdXNyL3NyYy9saWIvbGlic3RhbmQv Ym9vdHAuYy5vbGQKKysrIGIvL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmMKQEAgLTM0NCw2 ICszNDQsMTcgQEAKIAlyZXR1cm4gKC0xKTsKIH0KIAoraW50CitkaGNwX3RyeV9yZmMxMDQ4KHVf Y2hhciAqY3AsIHVfaW50IGxlbikKK3sKKworCWV4cGVjdGVkX2RoY3Btc2d0eXBlID0gREhDUEFD SzsKKwlpZiAoYmNtcCh2bV9yZmMxMDQ4LCBjcCwgc2l6ZW9mKHZtX3JmYzEwNDgpKSA9PSAwKSB7 CisJCXJldHVybiAodmVuZF9yZmMxMDQ4KGNwLCBsZW4pKTsKKwl9CisJcmV0dXJuICgtMSk7Cit9 CisKIHN0YXRpYyBpbnQKIHZlbmRfcmZjMTA0OChjcCwgbGVuKQogCXVfY2hhciAqY3A7CmRpZmYg LS1naXQgYS8vdXNyL3NyYy9saWIvbGlic3RhbmQvYm9vdHAuaC5vbGQgYi8vdXNyL3NyYy9saWIv bGlic3RhbmQvYm9vdHAuaAotLS0gYS8vdXNyL3NyYy9saWIvbGlic3RhbmQvYm9vdHAuaC5vbGQK KysrIGIvL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmgKQEAgLTIyLDYgKzIyLDggQEAKICAq ICRGcmVlQlNEOiBoZWFkL2xpYi9saWJzdGFuZC9ib290cC5oIDMwNTEyNSAyMDE2LTA4LTMxIDEz OjE2OjQwWiBiYXB0ICQKICAqLwogCisjaWZuZGVmIF9CT09UUF9IXworI2RlZmluZSBfQk9PVFBf SF8KIAogc3RydWN0IGJvb3RwIHsKIAl1bnNpZ25lZCBjaGFyCWJwX29wOwkJLyogcGFja2V0IG9w Y29kZSB0eXBlICovCkBAIC0xNDUsMyArMTQ3LDcgQEAKIAogLyogdl9mbGFncyB2YWx1ZXMgKi8K ICNkZWZpbmUgVkZfU01BU0sJMQkvKiBTdWJuZXQgbWFzayBmaWVsZCBjb250YWlucyB2YWxpZCBk YXRhICovCisKK2ludAlkaGNwX3RyeV9yZmMxMDQ4KHVfY2hhciAqY3AsIHVfaW50IGxlbik7CisK KyNlbmRpZiAvKiBfQk9PVFBfSF8gKi8KCg== --b1_ef2633f0a55dc86614c9558867fffeeb-- From owner-freebsd-net@freebsd.org Thu Mar 2 22:00:59 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 350BBCF5CA7 for ; Thu, 2 Mar 2017 22:00:59 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 1DA1C336 for ; Thu, 2 Mar 2017 22:00:59 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 1D03BCF5CA6; Thu, 2 Mar 2017 22:00:59 +0000 (UTC) Delivered-To: net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1CB3DCF5CA5 for ; Thu, 2 Mar 2017 22:00:59 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (glebi.us [96.95.210.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 03013331; Thu, 2 Mar 2017 22:00:58 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id v22M0pTK039169 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 2 Mar 2017 14:00:51 -0800 (PST) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id v22M0pgm039168; Thu, 2 Mar 2017 14:00:51 -0800 (PST) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@FreeBSD.org using -f Date: Thu, 2 Mar 2017 14:00:51 -0800 From: Gleb Smirnoff To: Sepherosa Ziehau Cc: Julien Charbon , Jason Eggleston , "freebsd-net@freebsd.org" , hiren@freebsd.org, jtl@freebsd.org, rrs@freebsd.org Subject: Re: listening sockets as non sockets Message-ID: <20170302220051.GU1044@FreeBSD.org> References: <20170127005251.GM2611@FreeBSD.org> <20170210063024.GE1973@FreeBSD.org> <20170216184903.GF58829@FreeBSD.org> <0858647a-ec3c-1a78-053f-d04397a82d8a@freebsd.org> <20170222232704.GJ8899@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 22:00:59 -0000 On Sun, Feb 26, 2017 at 11:37:59PM +0800, Sepherosa Ziehau wrote: S> r314268 -> solisten S> S> 1KB: S> Performance (reqs/s) S> 77916.71 -> 26240.37 S> Latency average S> 121ms -> 294ms ... S> So what I have seen is solisten's performance is 1/3 of r314268, and S> average latency doubles. I did similar testing, and my results are the following, for three consecutive runs: solisten head (r306199) req/s 63k,63k,63k 46k,47k,44k latency 213,214,208 232,233,223 So, I don't see latency increase, neither req/s regression. I see the opposite. What is different about my test? First, this is NetflixBSD, both head and solisten installation. Head is based on r306199 and solisten is based on r314150 and cb79de4fd2912450c4ab808c017ae395fd636bd8 from my github. To my knowledge the parts of the stack that are different in NetflixBSD do not touch sonewconn(), accept4() and other parts we are interested at. I also didn't notice any drastical changes in head between r306199 and r314150. So imho it is fair to attribute the difference to my change. The hardware is different. It is Supermicro X9SRH-7F/7TF, Xeon(R) CPU E5-2697 v2 @ 2.70GHz, 256Gb RAM and Chelsio cxl(4) at 40Gbit/s. I got two boxes of this configuration one running head and other solisten. The client box runs same CPU and mainboard, but has lagg of two cxls, capping it to 80 Gbit/s, which isn't important but, what is important providing more parallelism at sending side. The nginx has multiple listening sockets, but we bombard only one that is at AF_INET4 *:80. The nginx is configured to 64 worker processes and accept_mutex is on. So, even with 1 socket, seems like I got some improvement. I run your wrk 498d70f6da5a201f109488eeaf31c8ba891dc163, and the command used on the sending side is: ./wrk -c 15000 -t 48 -d 120s --delay --latency --connreqs 1 http://host/file The difference to your command is only threads count. My box has much more cores. The file is of size 1657 bytes. Sephe, can you please get hwpmc dumps with your test on solisten/head? In the test that shows that solisten is 3x slower. Julien, your testing will also be much appreciated. Looks like Sephe's result shouldn't block your try. -- Totus tuus, Glebius. From owner-freebsd-net@freebsd.org Thu Mar 2 22:02:24 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4B296CF5E54 for ; Thu, 2 Mar 2017 22:02:24 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 2792B898 for ; Thu, 2 Mar 2017 22:02:24 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 911504EB; Thu, 2 Mar 2017 22:02:23 +0000 (UTC) Date: Thu, 2 Mar 2017 22:02:23 +0000 To: freebsd-net@freebsd.org From: "smh (Steven Hartland)" Reply-to: D9847+325+deba385e191bfbb6@reviews.freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: <6ae2eb98a285345ab6fb7687e16b59e8@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , Thread-Topic: D9847: Try to extract the RFC1048 data from PXE X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: YTlhODdhNGFiNzc3NzE3ZGRmMjFjNTkwOTA3IFi4lm8= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 22:02:24 -0000 c21oIHJlcXVlc3RlZCBjaGFuZ2VzIHRvIHRoaXMgcmV2aXNpb24uCnNtaCBhZGRlZCBpbmxpbmUg Y29tbWVudHMuClRoaXMgcmV2aXNpb24gbm93IHJlcXVpcmVzIGNoYW5nZXMgdG8gcHJvY2VlZC4K CklOTElORSBDT01NRU5UUwoKPiBweGUuYzozMDAKPiArCQkJCWJvb3RwKHB4ZV9zb2NrLCBCT09U UF9QWEUpOwo+ICsJCQl9IGVsc2Ugewo+ICsJCQkJaWYgKHB4ZV9kZWJ1ZykKCllvdSBjYW4gc3F1 YXNoIHRoZSBlbHNlIGFuZCB5b3VyIGlmIGhlcmUKClJFVklTSU9OIERFVEFJTAogIGh0dHBzOi8v cmV2aWV3cy5mcmVlYnNkLm9yZy9EOTg0NwoKRU1BSUwgUFJFRkVSRU5DRVMKICBodHRwczovL3Jl dmlld3MuZnJlZWJzZC5vcmcvc2V0dGluZ3MvcGFuZWwvZW1haWxwcmVmZXJlbmNlcy8KClRvOiBr Y3pla2lyZGEsIG9zaG9nYm8sIGJhcHQsIHRzb29tZSwgZ2xlYml1cywgZnJlZWJzZC1uZXQtbGlz dCwgI25ldHdvcmssIGdubiwgc21oCkNjOiBzbWgK From owner-freebsd-net@freebsd.org Thu Mar 2 22:17:15 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 38ED3CF62F7 for ; Thu, 2 Mar 2017 22:17:15 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 0E4D41135 for ; Thu, 2 Mar 2017 22:17:15 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 6D8DE1A06A; Thu, 2 Mar 2017 22:17:14 +0000 (UTC) Date: Thu, 2 Mar 2017 22:17:14 +0000 To: freebsd-net@freebsd.org From: "kczekirda (Kamil Czekirda)" Reply-to: D9847+325+deba385e191bfbb6@reviews.freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: <1d7d5b2dc41f5f8a08c72b9392d35f2e@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , Thread-Topic: D9847: Try to extract the RFC1048 data from PXE X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: YTlhODdhNGFiNzc3NzE3ZGRmMjFjNTkwOTA3IFi4meo= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_1d7d5b2dc41f5f8a08c72b9392d35f2e" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 22:17:15 -0000 --b1_1d7d5b2dc41f5f8a08c72b9392d35f2e Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: base64 a2N6ZWtpcmRhIHVwZGF0ZWQgdGhpcyByZXZpc2lvbiB0byBEaWZmIDI1OTE1LgprY3pla2lyZGEg bWFya2VkIGFuIGlubGluZSBjb21tZW50IGFzIGRvbmUuCgpDSEFOR0VTIFNJTkNFIExBU1QgVVBE QVRFCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0Q5ODQ3P3ZzPTI1OTE0JmlkPTI1OTE1 CgpSRVZJU0lPTiBERVRBSUwKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvRDk4NDcKCkFG RkVDVEVEIEZJTEVTCiAgL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmMKICAvdXNyL3NyYy9s aWIvbGlic3RhbmQvYm9vdHAuaAogIC91c3Ivc3JjL3N5cy9ib290L2kzODYvbGliaTM4Ni9weGUu YwoKRU1BSUwgUFJFRkVSRU5DRVMKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvc2V0dGlu Z3MvcGFuZWwvZW1haWxwcmVmZXJlbmNlcy8KClRvOiBrY3pla2lyZGEsIG9zaG9nYm8sIGJhcHQs IHRzb29tZSwgZ2xlYml1cywgZnJlZWJzZC1uZXQtbGlzdCwgI25ldHdvcmssIGdubiwgc21oCkNj OiBzbWgK --b1_1d7d5b2dc41f5f8a08c72b9392d35f2e Content-Type: text/x-patch; charset=utf-8; name="D9847.25915.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D9847.25915.patch" ZGlmZiAtLWdpdCBhLy91c3Ivc3JjL3N5cy9ib290L2kzODYvbGliaTM4Ni9weGUuYy5vbGQgYi8v dXNyL3NyYy9zeXMvYm9vdC9pMzg2L2xpYmkzODYvcHhlLmMKLS0tIGEvL3Vzci9zcmMvc3lzL2Jv b3QvaTM4Ni9saWJpMzg2L3B4ZS5jLm9sZAorKysgYi8vdXNyL3NyYy9zeXMvYm9vdC9pMzg2L2xp YmkzODYvcHhlLmMKQEAgLTEwMSw2ICsxMDEsNyBAQAogZXh0ZXJuIHVfaW50MTZfdAkJX19weGVu dnNlZzsKIGV4dGVybiB1X2ludDE2X3QJCV9fcHhlbnZvZmY7CiBleHRlcm4gdm9pZAkJCV9fcHhl bnZlbnRyeSh2b2lkKTsKK2V4dGVybiBzdHJ1Y3QgaW5fYWRkcgkJc2VydmlwOwogCiBzdHJ1Y3Qg bmV0aWZfZGlmIHB4ZV9pZnNbXSA9IHsKIC8qCWRpZl91bml0ICAgICAgICBkaWZfbnNlbCAgICAg ICAgZGlmX3N0YXRzICAgICAgIGRpZl9wcml2YXRlICAgICAqLwpAQCAtMjc2LDE3ICsyNzcsMzgg QEAKIAkJCX0KIAkJCWlmIChweGVfZGVidWcpCiAJCQkJcHJpbnRmKCJweGVfb3BlbjogbmV0aWZf b3BlbigpIHN1Y2NlZWRlZFxuIik7CisKKwkJCWlmIChzb2NrdG9kZXNjKHB4ZV9zb2NrKSA9PSBO VUxMKSB7CisJCQkJCXByaW50ZigicHhlX29wZW46IGJhZCBzb2NrZXQgJWRcbiIsIHB4ZV9zb2Nr KTsKKwkJCQkJcmV0dXJuIChFTlhJTyk7CisJCQkJfQorCiAJCX0KIAkJaWYgKHJvb3RpcC5zX2Fk ZHIgPT0gMCkgewogCQkJLyoKLQkJCSAqIERvIGEgYm9vdHAvZGhjcCByZXF1ZXN0IHRvIGZpbmQg b3V0IHdoZXJlIG91cgorCQkJICogVHJ5IHRvIGV4dHJhY3QgdGhlIFJGQzEwNDggZGF0YSBmcm9t IFBYRS4KKwkJCSAqIElmIGZhaWwgZG8gYSBib290cC9kaGNwIHJlcXVlc3QgdG8gZmluZCBvdXQg d2hlcmUgb3VyCiAJCQkgKiBORlMvVEZUUCBzZXJ2ZXIgaXMuIEV2ZW4gaWYgd2UgZG9udCBnZXQg YmFjawogCQkJICogdGhlIHByb3BlciBpbmZvcm1hdGlvbiwgZmFsbCBiYWNrIHRvIHRoZSBzZXJ2 ZXIKIAkJCSAqIHdoaWNoIGJyb3VnaHQgdXMgdG8gbGlmZSBhbmQgYSBkZWZhdWx0IHJvb3RwYXRo LgogCQkJICovCi0JCQlib290cChweGVfc29jaywgQk9PVFBfUFhFKTsKKworCQkJaWYgKGRoY3Bf dHJ5X3JmYzEwNDgoYm9vdHBsYXllci52ZW5kb3IuZCwgQk9PVFBfREhDUFZFTkQpKSB7CisJCQkJ aWYgKHB4ZV9kZWJ1ZykKKwkJCQkJcHJpbnRmKCJweGVfb3Blbjogbm8gUkZDMTA0OCBkYXRhIGlu IFBYRSBDYWNoZVxuIik7CisJCQkJYm9vdHAocHhlX3NvY2ssIEJPT1RQX1BYRSk7CisJCQl9IGVs c2UgaWYgKHB4ZV9kZWJ1ZykKKwkJCQlwcmludGYoInB4ZV9vcGVuOiBsb2FkZWQgUkZDMTA0OCBk YXRhIGZyb20gUFhFIENhY2hlXG4iKTsKKwkJCX0KKwogCQkJaWYgKHJvb3RpcC5zX2FkZHIgPT0g MCkKIAkJCQlyb290aXAuc19hZGRyID0gYm9vdHBsYXllci5zaXA7CisJCQlpZiAoZ2F0ZWlwLnNf YWRkciA9PSAwKQorCQkJCWdhdGVpcC5zX2FkZHIgPSBib290cGxheWVyLmdpcDsKKwkJCWlmICht eWlwLnNfYWRkciA9PSAwKQorCQkJCW15aXAuc19hZGRyID0gYm9vdHBsYXllci55aXA7CisJCQlp ZiAoc2VydmlwLnNfYWRkciA9PSAwKQorCQkJCXNlcnZpcCA9IHJvb3RpcDsKIAogCQkJbmV0cHJv dG8gPSBORVRfTkZTOwogCQkJaWYgKHRmdHBpcC5zX2FkZHIgIT0gMCkgewpAQCAtMzIzLDYgKzM0 NSw5IEBACiAJCQlwcmludGYoInB4ZV9vcGVuOiBzZXJ2ZXIgYWRkcjogJXNcbiIsIGluZXRfbnRv YShyb290aXApKTsKIAkJCXByaW50ZigicHhlX29wZW46IHNlcnZlciBwYXRoOiAlc1xuIiwgcm9v dHBhdGgpOwogCQkJcHJpbnRmKCJweGVfb3BlbjogZ2F0ZXdheSBpcDogICVzXG4iLCBpbmV0X250 b2EoZ2F0ZWlwKSk7CisJCQlwcmludGYoInB4ZV9vcGVuOiBteSBpcDogICAgICAgJXNcbiIsIGlu ZXRfbnRvYShteWlwKSk7CisJCQlwcmludGYoInB4ZV9vcGVuOiBuZXRtYXNrOiAgICAgJXNcbiIs IGludG9hKG5ldG1hc2spKTsKKwkJCXByaW50ZigicHhlX29wZW46IHNlcnZpcDogICAgICAlc1xu IiwgaW5ldF9udG9hKHNlcnZpcCkpOwogCiAJCQlpZiAobmV0cHJvdG8gPT0gTkVUX1RGVFApIHsK IAkJCQlzZXRlbnYoImJvb3QudGZ0cHJvb3Quc2VydmVyIiwgaW5ldF9udG9hKHJvb3RpcCksIDEp OwpkaWZmIC0tZ2l0IGEvL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmMub2xkIGIvL3Vzci9z cmMvbGliL2xpYnN0YW5kL2Jvb3RwLmMKLS0tIGEvL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3Rw LmMub2xkCisrKyBiLy91c3Ivc3JjL2xpYi9saWJzdGFuZC9ib290cC5jCkBAIC0zNDQsNiArMzQ0 LDE3IEBACiAJcmV0dXJuICgtMSk7CiB9CiAKK2ludAorZGhjcF90cnlfcmZjMTA0OCh1X2NoYXIg KmNwLCB1X2ludCBsZW4pCit7CisKKwlleHBlY3RlZF9kaGNwbXNndHlwZSA9IERIQ1BBQ0s7CisJ aWYgKGJjbXAodm1fcmZjMTA0OCwgY3AsIHNpemVvZih2bV9yZmMxMDQ4KSkgPT0gMCkgeworCQly ZXR1cm4gKHZlbmRfcmZjMTA0OChjcCwgbGVuKSk7CisJfQorCXJldHVybiAoLTEpOworfQorCiBz dGF0aWMgaW50CiB2ZW5kX3JmYzEwNDgoY3AsIGxlbikKIAl1X2NoYXIgKmNwOwpkaWZmIC0tZ2l0 IGEvL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmgub2xkIGIvL3Vzci9zcmMvbGliL2xpYnN0 YW5kL2Jvb3RwLmgKLS0tIGEvL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmgub2xkCisrKyBi Ly91c3Ivc3JjL2xpYi9saWJzdGFuZC9ib290cC5oCkBAIC0yMiw2ICsyMiw4IEBACiAgKiAkRnJl ZUJTRDogaGVhZC9saWIvbGlic3RhbmQvYm9vdHAuaCAzMDUxMjUgMjAxNi0wOC0zMSAxMzoxNjo0 MFogYmFwdCAkCiAgKi8KIAorI2lmbmRlZiBfQk9PVFBfSF8KKyNkZWZpbmUgX0JPT1RQX0hfCiAK IHN0cnVjdCBib290cCB7CiAJdW5zaWduZWQgY2hhcglicF9vcDsJCS8qIHBhY2tldCBvcGNvZGUg dHlwZSAqLwpAQCAtMTQ1LDMgKzE0Nyw3IEBACiAKIC8qIHZfZmxhZ3MgdmFsdWVzICovCiAjZGVm aW5lIFZGX1NNQVNLCTEJLyogU3VibmV0IG1hc2sgZmllbGQgY29udGFpbnMgdmFsaWQgZGF0YSAq LworCitpbnQJZGhjcF90cnlfcmZjMTA0OCh1X2NoYXIgKmNwLCB1X2ludCBsZW4pOworCisjZW5k aWYgLyogX0JPT1RQX0hfICovCgo= --b1_1d7d5b2dc41f5f8a08c72b9392d35f2e-- From owner-freebsd-net@freebsd.org Thu Mar 2 22:19:10 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 582B4CF63F6 for ; Thu, 2 Mar 2017 22:19:10 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 30C581399 for ; Thu, 2 Mar 2017 22:19:10 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 988B31A27F; Thu, 2 Mar 2017 22:19:09 +0000 (UTC) Date: Thu, 2 Mar 2017 22:19:09 +0000 To: freebsd-net@freebsd.org From: "kczekirda (Kamil Czekirda)" Reply-to: D9847+325+deba385e191bfbb6@reviews.freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , Thread-Topic: D9847: Try to extract the RFC1048 data from PXE X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: YTlhODdhNGFiNzc3NzE3ZGRmMjFjNTkwOTA3IFi4ml0= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_d2c64be203b35e22cdb83b741568ab7c" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 22:19:10 -0000 --b1_d2c64be203b35e22cdb83b741568ab7c Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: base64 a2N6ZWtpcmRhIHVwZGF0ZWQgdGhpcyByZXZpc2lvbiB0byBEaWZmIDI1OTE2LgoKQ0hBTkdFUyBT SU5DRSBMQVNUIFVQREFURQogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9EOTg0Nz92cz0y NTkxNSZpZD0yNTkxNgoKUkVWSVNJT04gREVUQUlMCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qu b3JnL0Q5ODQ3CgpBRkZFQ1RFRCBGSUxFUwogIC91c3Ivc3JjL2xpYi9saWJzdGFuZC9ib290cC5j CiAgL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmgKICAvdXNyL3NyYy9zeXMvYm9vdC9pMzg2 L2xpYmkzODYvcHhlLmMKCkVNQUlMIFBSRUZFUkVOQ0VTCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVi c2Qub3JnL3NldHRpbmdzL3BhbmVsL2VtYWlscHJlZmVyZW5jZXMvCgpUbzoga2N6ZWtpcmRhLCBv c2hvZ2JvLCBiYXB0LCB0c29vbWUsIGdsZWJpdXMsIGZyZWVic2QtbmV0LWxpc3QsICNuZXR3b3Jr LCBnbm4sIHNtaApDYzogc21oCg== --b1_d2c64be203b35e22cdb83b741568ab7c Content-Type: text/x-patch; charset=utf-8; name="D9847.25916.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D9847.25916.patch" ZGlmZiAtLWdpdCBhLy91c3Ivc3JjL3N5cy9ib290L2kzODYvbGliaTM4Ni9weGUuYy5vbGQgYi8v dXNyL3NyYy9zeXMvYm9vdC9pMzg2L2xpYmkzODYvcHhlLmMKLS0tIGEvL3Vzci9zcmMvc3lzL2Jv b3QvaTM4Ni9saWJpMzg2L3B4ZS5jLm9sZAorKysgYi8vdXNyL3NyYy9zeXMvYm9vdC9pMzg2L2xp YmkzODYvcHhlLmMKQEAgLTEwMSw2ICsxMDEsNyBAQAogZXh0ZXJuIHVfaW50MTZfdAkJX19weGVu dnNlZzsKIGV4dGVybiB1X2ludDE2X3QJCV9fcHhlbnZvZmY7CiBleHRlcm4gdm9pZAkJCV9fcHhl bnZlbnRyeSh2b2lkKTsKK2V4dGVybiBzdHJ1Y3QgaW5fYWRkcgkJc2VydmlwOwogCiBzdHJ1Y3Qg bmV0aWZfZGlmIHB4ZV9pZnNbXSA9IHsKIC8qCWRpZl91bml0ICAgICAgICBkaWZfbnNlbCAgICAg ICAgZGlmX3N0YXRzICAgICAgIGRpZl9wcml2YXRlICAgICAqLwpAQCAtMjc2LDE3ICsyNzcsMzgg QEAKIAkJCX0KIAkJCWlmIChweGVfZGVidWcpCiAJCQkJcHJpbnRmKCJweGVfb3BlbjogbmV0aWZf b3BlbigpIHN1Y2NlZWRlZFxuIik7CisKKwkJCWlmIChzb2NrdG9kZXNjKHB4ZV9zb2NrKSA9PSBO VUxMKSB7CisJCQkJcHJpbnRmKCJweGVfb3BlbjogYmFkIHNvY2tldCAlZFxuIiwgcHhlX3NvY2sp OworCQkJCXJldHVybiAoRU5YSU8pOworCQkJfQorCiAJCX0KIAkJaWYgKHJvb3RpcC5zX2FkZHIg PT0gMCkgewogCQkJLyoKLQkJCSAqIERvIGEgYm9vdHAvZGhjcCByZXF1ZXN0IHRvIGZpbmQgb3V0 IHdoZXJlIG91cgorCQkJICogVHJ5IHRvIGV4dHJhY3QgdGhlIFJGQzEwNDggZGF0YSBmcm9tIFBY RS4KKwkJCSAqIElmIGZhaWwgZG8gYSBib290cC9kaGNwIHJlcXVlc3QgdG8gZmluZCBvdXQgd2hl cmUgb3VyCiAJCQkgKiBORlMvVEZUUCBzZXJ2ZXIgaXMuIEV2ZW4gaWYgd2UgZG9udCBnZXQgYmFj awogCQkJICogdGhlIHByb3BlciBpbmZvcm1hdGlvbiwgZmFsbCBiYWNrIHRvIHRoZSBzZXJ2ZXIK IAkJCSAqIHdoaWNoIGJyb3VnaHQgdXMgdG8gbGlmZSBhbmQgYSBkZWZhdWx0IHJvb3RwYXRoLgog CQkJICovCi0JCQlib290cChweGVfc29jaywgQk9PVFBfUFhFKTsKKworCQkJaWYgKGRoY3BfdHJ5 X3JmYzEwNDgoYm9vdHBsYXllci52ZW5kb3IuZCwgQk9PVFBfREhDUFZFTkQpKSB7CisJCQkJaWYg KHB4ZV9kZWJ1ZykKKwkJCQkJcHJpbnRmKCJweGVfb3Blbjogbm8gUkZDMTA0OCBkYXRhIGluIFBY RSBDYWNoZVxuIik7CisJCQkJYm9vdHAocHhlX3NvY2ssIEJPT1RQX1BYRSk7CisJCQl9IGVsc2Ug aWYgKHB4ZV9kZWJ1ZykKKwkJCQlwcmludGYoInB4ZV9vcGVuOiBsb2FkZWQgUkZDMTA0OCBkYXRh IGZyb20gUFhFIENhY2hlXG4iKTsKKwkJCX0KKwogCQkJaWYgKHJvb3RpcC5zX2FkZHIgPT0gMCkK IAkJCQlyb290aXAuc19hZGRyID0gYm9vdHBsYXllci5zaXA7CisJCQlpZiAoZ2F0ZWlwLnNfYWRk ciA9PSAwKQorCQkJCWdhdGVpcC5zX2FkZHIgPSBib290cGxheWVyLmdpcDsKKwkJCWlmIChteWlw LnNfYWRkciA9PSAwKQorCQkJCW15aXAuc19hZGRyID0gYm9vdHBsYXllci55aXA7CisJCQlpZiAo c2VydmlwLnNfYWRkciA9PSAwKQorCQkJCXNlcnZpcCA9IHJvb3RpcDsKIAogCQkJbmV0cHJvdG8g PSBORVRfTkZTOwogCQkJaWYgKHRmdHBpcC5zX2FkZHIgIT0gMCkgewpAQCAtMzIzLDYgKzM0NSw5 IEBACiAJCQlwcmludGYoInB4ZV9vcGVuOiBzZXJ2ZXIgYWRkcjogJXNcbiIsIGluZXRfbnRvYShy b290aXApKTsKIAkJCXByaW50ZigicHhlX29wZW46IHNlcnZlciBwYXRoOiAlc1xuIiwgcm9vdHBh dGgpOwogCQkJcHJpbnRmKCJweGVfb3BlbjogZ2F0ZXdheSBpcDogICVzXG4iLCBpbmV0X250b2Eo Z2F0ZWlwKSk7CisJCQlwcmludGYoInB4ZV9vcGVuOiBteSBpcDogICAgICAgJXNcbiIsIGluZXRf bnRvYShteWlwKSk7CisJCQlwcmludGYoInB4ZV9vcGVuOiBuZXRtYXNrOiAgICAgJXNcbiIsIGlu dG9hKG5ldG1hc2spKTsKKwkJCXByaW50ZigicHhlX29wZW46IHNlcnZpcDogICAgICAlc1xuIiwg aW5ldF9udG9hKHNlcnZpcCkpOwogCiAJCQlpZiAobmV0cHJvdG8gPT0gTkVUX1RGVFApIHsKIAkJ CQlzZXRlbnYoImJvb3QudGZ0cHJvb3Quc2VydmVyIiwgaW5ldF9udG9hKHJvb3RpcCksIDEpOwpk aWZmIC0tZ2l0IGEvL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmMub2xkIGIvL3Vzci9zcmMv bGliL2xpYnN0YW5kL2Jvb3RwLmMKLS0tIGEvL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmMu b2xkCisrKyBiLy91c3Ivc3JjL2xpYi9saWJzdGFuZC9ib290cC5jCkBAIC0zNDQsNiArMzQ0LDE3 IEBACiAJcmV0dXJuICgtMSk7CiB9CiAKK2ludAorZGhjcF90cnlfcmZjMTA0OCh1X2NoYXIgKmNw LCB1X2ludCBsZW4pCit7CisKKwlleHBlY3RlZF9kaGNwbXNndHlwZSA9IERIQ1BBQ0s7CisJaWYg KGJjbXAodm1fcmZjMTA0OCwgY3AsIHNpemVvZih2bV9yZmMxMDQ4KSkgPT0gMCkgeworCQlyZXR1 cm4gKHZlbmRfcmZjMTA0OChjcCwgbGVuKSk7CisJfQorCXJldHVybiAoLTEpOworfQorCiBzdGF0 aWMgaW50CiB2ZW5kX3JmYzEwNDgoY3AsIGxlbikKIAl1X2NoYXIgKmNwOwpkaWZmIC0tZ2l0IGEv L3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmgub2xkIGIvL3Vzci9zcmMvbGliL2xpYnN0YW5k L2Jvb3RwLmgKLS0tIGEvL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmgub2xkCisrKyBiLy91 c3Ivc3JjL2xpYi9saWJzdGFuZC9ib290cC5oCkBAIC0yMiw2ICsyMiw4IEBACiAgKiAkRnJlZUJT RDogaGVhZC9saWIvbGlic3RhbmQvYm9vdHAuaCAzMDUxMjUgMjAxNi0wOC0zMSAxMzoxNjo0MFog YmFwdCAkCiAgKi8KIAorI2lmbmRlZiBfQk9PVFBfSF8KKyNkZWZpbmUgX0JPT1RQX0hfCiAKIHN0 cnVjdCBib290cCB7CiAJdW5zaWduZWQgY2hhcglicF9vcDsJCS8qIHBhY2tldCBvcGNvZGUgdHlw ZSAqLwpAQCAtMTQ1LDMgKzE0Nyw3IEBACiAKIC8qIHZfZmxhZ3MgdmFsdWVzICovCiAjZGVmaW5l IFZGX1NNQVNLCTEJLyogU3VibmV0IG1hc2sgZmllbGQgY29udGFpbnMgdmFsaWQgZGF0YSAqLwor CitpbnQJZGhjcF90cnlfcmZjMTA0OCh1X2NoYXIgKmNwLCB1X2ludCBsZW4pOworCisjZW5kaWYg LyogX0JPT1RQX0hfICovCgo= --b1_d2c64be203b35e22cdb83b741568ab7c-- From owner-freebsd-net@freebsd.org Thu Mar 2 22:47:18 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6C91CCF6AFD for ; Thu, 2 Mar 2017 22:47:18 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 4137E11ED for ; Thu, 2 Mar 2017 22:47:18 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id AB4531A8A5; Thu, 2 Mar 2017 22:47:17 +0000 (UTC) Date: Thu, 2 Mar 2017 22:47:17 +0000 To: freebsd-net@freebsd.org From: "smh (Steven Hartland)" Reply-to: D9847+325+deba385e191bfbb6@reviews.freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: <4f6a1c8746e64dd533b94393cef5850d@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , Thread-Topic: D9847: Try to extract the RFC1048 data from PXE X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: YTlhODdhNGFiNzc3NzE3ZGRmMjFjNTkwOTA3IFi4oPU= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 22:47:18 -0000 c21oIHJlcXVlc3RlZCBjaGFuZ2VzIHRvIHRoaXMgcmV2aXNpb24uCnNtaCBhZGRlZCBpbmxpbmUg Y29tbWVudHMuClRoaXMgcmV2aXNpb24gbm93IHJlcXVpcmVzIGNoYW5nZXMgdG8gcHJvY2VlZC4K CklOTElORSBDT01NRU5UUwoKPiBweGUuYzozMDAKPiArCQkJCWJvb3RwKHB4ZV9zb2NrLCBCT09U UF9QWEUpOwo+ICsJCQl9IGVsc2UgaWYgKHB4ZV9kZWJ1ZykKPiArCQkJCXByaW50ZigicHhlX29w ZW46IGxvYWRlZCBSRkMxMDQ4IGRhdGEgZnJvbSBQWEUgQ2FjaGVcbiIpOwoKTG9va3MgbGlrZSB5 b3UgaGF2ZSBhIGJyYWNlIG1pc3MgbWF0Y2ggaGVyZSBub3cKClJFVklTSU9OIERFVEFJTAogIGh0 dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9EOTg0NwoKRU1BSUwgUFJFRkVSRU5DRVMKICBodHRw czovL3Jldmlld3MuZnJlZWJzZC5vcmcvc2V0dGluZ3MvcGFuZWwvZW1haWxwcmVmZXJlbmNlcy8K ClRvOiBrY3pla2lyZGEsIG9zaG9nYm8sIGJhcHQsIHRzb29tZSwgZ2xlYml1cywgZnJlZWJzZC1u ZXQtbGlzdCwgI25ldHdvcmssIGdubiwgc21oCkNjOiBzbWgK From owner-freebsd-net@freebsd.org Thu Mar 2 23:11:55 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8BDECCF52DB for ; Thu, 2 Mar 2017 23:11:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 773CC103B for ; Thu, 2 Mar 2017 23:11:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v22NBt2T046137 for ; Thu, 2 Mar 2017 23:11:55 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217508] admins calling nfssvc() can cause a NULL dereference and a panic while exporting a filesystem Date: Thu, 02 Mar 2017 23:11:55 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: cem@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 23:11:55 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217508 Conrad Meyer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-bugs@FreeBSD.org |freebsd-net@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Thu Mar 2 23:14:30 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 576CFCF555D for ; Thu, 2 Mar 2017 23:14:30 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 3006D137A for ; Thu, 2 Mar 2017 23:14:30 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 8B28D1AF93; Thu, 2 Mar 2017 23:14:29 +0000 (UTC) Date: Thu, 2 Mar 2017 23:14:29 +0000 To: freebsd-net@freebsd.org From: "kczekirda (Kamil Czekirda)" Reply-to: D9847+325+deba385e191bfbb6@reviews.freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: <2209b35b9fb214820ca492563671285f@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , Thread-Topic: D9847: Try to extract the RFC1048 data from PXE X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: YTlhODdhNGFiNzc3NzE3ZGRmMjFjNTkwOTA3IFi4p1U= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_2209b35b9fb214820ca492563671285f" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 23:14:30 -0000 --b1_2209b35b9fb214820ca492563671285f Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: base64 a2N6ZWtpcmRhIHVwZGF0ZWQgdGhpcyByZXZpc2lvbiB0byBEaWZmIDI1OTE3LgprY3pla2lyZGEg bWFya2VkIGFuIGlubGluZSBjb21tZW50IGFzIGRvbmUuCgpDSEFOR0VTIFNJTkNFIExBU1QgVVBE QVRFCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0Q5ODQ3P3ZzPTI1OTE2JmlkPTI1OTE3 CgpSRVZJU0lPTiBERVRBSUwKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvRDk4NDcKCkFG RkVDVEVEIEZJTEVTCiAgL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmMKICAvdXNyL3NyYy9s aWIvbGlic3RhbmQvYm9vdHAuaAogIC91c3Ivc3JjL3N5cy9ib290L2kzODYvbGliaTM4Ni9weGUu YwoKRU1BSUwgUFJFRkVSRU5DRVMKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvc2V0dGlu Z3MvcGFuZWwvZW1haWxwcmVmZXJlbmNlcy8KClRvOiBrY3pla2lyZGEsIG9zaG9nYm8sIGJhcHQs IHRzb29tZSwgZ2xlYml1cywgZnJlZWJzZC1uZXQtbGlzdCwgI25ldHdvcmssIGdubiwgc21oCkNj OiBzbWgK --b1_2209b35b9fb214820ca492563671285f Content-Type: text/x-patch; charset=utf-8; name="D9847.25917.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D9847.25917.patch" ZGlmZiAtLWdpdCBhLy91c3Ivc3JjL3N5cy9ib290L2kzODYvbGliaTM4Ni9weGUuYy5vbGQgYi8v dXNyL3NyYy9zeXMvYm9vdC9pMzg2L2xpYmkzODYvcHhlLmMKLS0tIGEvL3Vzci9zcmMvc3lzL2Jv b3QvaTM4Ni9saWJpMzg2L3B4ZS5jLm9sZAorKysgYi8vdXNyL3NyYy9zeXMvYm9vdC9pMzg2L2xp YmkzODYvcHhlLmMKQEAgLTEwMSw2ICsxMDEsNyBAQAogZXh0ZXJuIHVfaW50MTZfdAkJX19weGVu dnNlZzsKIGV4dGVybiB1X2ludDE2X3QJCV9fcHhlbnZvZmY7CiBleHRlcm4gdm9pZAkJCV9fcHhl bnZlbnRyeSh2b2lkKTsKK2V4dGVybiBzdHJ1Y3QgaW5fYWRkcgkJc2VydmlwOwogCiBzdHJ1Y3Qg bmV0aWZfZGlmIHB4ZV9pZnNbXSA9IHsKIC8qCWRpZl91bml0ICAgICAgICBkaWZfbnNlbCAgICAg ICAgZGlmX3N0YXRzICAgICAgIGRpZl9wcml2YXRlICAgICAqLwpAQCAtMjc2LDE3ICsyNzcsMzgg QEAKIAkJCX0KIAkJCWlmIChweGVfZGVidWcpCiAJCQkJcHJpbnRmKCJweGVfb3BlbjogbmV0aWZf b3BlbigpIHN1Y2NlZWRlZFxuIik7CisKKwkJCWlmIChzb2NrdG9kZXNjKHB4ZV9zb2NrKSA9PSBO VUxMKSB7CisJCQkJcHJpbnRmKCJweGVfb3BlbjogYmFkIHNvY2tldCAlZFxuIiwgcHhlX3NvY2sp OworCQkJCXJldHVybiAoRU5YSU8pOworCQkJfQorCiAJCX0KIAkJaWYgKHJvb3RpcC5zX2FkZHIg PT0gMCkgewogCQkJLyoKLQkJCSAqIERvIGEgYm9vdHAvZGhjcCByZXF1ZXN0IHRvIGZpbmQgb3V0 IHdoZXJlIG91cgorCQkJICogVHJ5IHRvIGV4dHJhY3QgdGhlIFJGQzEwNDggZGF0YSBmcm9tIFBY RS4KKwkJCSAqIElmIGZhaWwgZG8gYSBib290cC9kaGNwIHJlcXVlc3QgdG8gZmluZCBvdXQgd2hl cmUgb3VyCiAJCQkgKiBORlMvVEZUUCBzZXJ2ZXIgaXMuIEV2ZW4gaWYgd2UgZG9udCBnZXQgYmFj awogCQkJICogdGhlIHByb3BlciBpbmZvcm1hdGlvbiwgZmFsbCBiYWNrIHRvIHRoZSBzZXJ2ZXIK IAkJCSAqIHdoaWNoIGJyb3VnaHQgdXMgdG8gbGlmZSBhbmQgYSBkZWZhdWx0IHJvb3RwYXRoLgog CQkJICovCi0JCQlib290cChweGVfc29jaywgQk9PVFBfUFhFKTsKKworCQkJaWYgKGRoY3BfdHJ5 X3JmYzEwNDgoYm9vdHBsYXllci52ZW5kb3IuZCwgQk9PVFBfREhDUFZFTkQpKSB7CisJCQkJaWYg KHB4ZV9kZWJ1ZykKKwkJCQkJcHJpbnRmKCJweGVfb3Blbjogbm8gUkZDMTA0OCBkYXRhIGluIFBY RSBDYWNoZVxuIik7CisJCQkJYm9vdHAocHhlX3NvY2ssIEJPT1RQX1BYRSk7CisJCQl9IGVsc2Ug aWYgKHB4ZV9kZWJ1ZykgeworCQkJCXByaW50ZigicHhlX29wZW46IGxvYWRlZCBSRkMxMDQ4IGRh dGEgZnJvbSBQWEUgQ2FjaGVcbiIpOworCQkJfQorCiAJCQlpZiAocm9vdGlwLnNfYWRkciA9PSAw KQogCQkJCXJvb3RpcC5zX2FkZHIgPSBib290cGxheWVyLnNpcDsKKwkJCWlmIChnYXRlaXAuc19h ZGRyID09IDApCisJCQkJZ2F0ZWlwLnNfYWRkciA9IGJvb3RwbGF5ZXIuZ2lwOworCQkJaWYgKG15 aXAuc19hZGRyID09IDApCisJCQkJbXlpcC5zX2FkZHIgPSBib290cGxheWVyLnlpcDsKKwkJCWlm IChzZXJ2aXAuc19hZGRyID09IDApCisJCQkJc2VydmlwID0gcm9vdGlwOwogCiAJCQluZXRwcm90 byA9IE5FVF9ORlM7CiAJCQlpZiAodGZ0cGlwLnNfYWRkciAhPSAwKSB7CkBAIC0zMjMsNiArMzQ1 LDkgQEAKIAkJCXByaW50ZigicHhlX29wZW46IHNlcnZlciBhZGRyOiAlc1xuIiwgaW5ldF9udG9h KHJvb3RpcCkpOwogCQkJcHJpbnRmKCJweGVfb3Blbjogc2VydmVyIHBhdGg6ICVzXG4iLCByb290 cGF0aCk7CiAJCQlwcmludGYoInB4ZV9vcGVuOiBnYXRld2F5IGlwOiAgJXNcbiIsIGluZXRfbnRv YShnYXRlaXApKTsKKwkJCXByaW50ZigicHhlX29wZW46IG15IGlwOiAgICAgICAlc1xuIiwgaW5l dF9udG9hKG15aXApKTsKKwkJCXByaW50ZigicHhlX29wZW46IG5ldG1hc2s6ICAgICAlc1xuIiwg aW50b2EobmV0bWFzaykpOworCQkJcHJpbnRmKCJweGVfb3Blbjogc2VydmlwOiAgICAgICVzXG4i LCBpbmV0X250b2Eoc2VydmlwKSk7CiAKIAkJCWlmIChuZXRwcm90byA9PSBORVRfVEZUUCkgewog CQkJCXNldGVudigiYm9vdC50ZnRwcm9vdC5zZXJ2ZXIiLCBpbmV0X250b2Eocm9vdGlwKSwgMSk7 CmRpZmYgLS1naXQgYS8vdXNyL3NyYy9saWIvbGlic3RhbmQvYm9vdHAuYy5vbGQgYi8vdXNyL3Ny Yy9saWIvbGlic3RhbmQvYm9vdHAuYwotLS0gYS8vdXNyL3NyYy9saWIvbGlic3RhbmQvYm9vdHAu Yy5vbGQKKysrIGIvL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmMKQEAgLTM0NCw2ICszNDQs MTcgQEAKIAlyZXR1cm4gKC0xKTsKIH0KIAoraW50CitkaGNwX3RyeV9yZmMxMDQ4KHVfY2hhciAq Y3AsIHVfaW50IGxlbikKK3sKKworCWV4cGVjdGVkX2RoY3Btc2d0eXBlID0gREhDUEFDSzsKKwlp ZiAoYmNtcCh2bV9yZmMxMDQ4LCBjcCwgc2l6ZW9mKHZtX3JmYzEwNDgpKSA9PSAwKSB7CisJCXJl dHVybiAodmVuZF9yZmMxMDQ4KGNwLCBsZW4pKTsKKwl9CisJcmV0dXJuICgtMSk7Cit9CisKIHN0 YXRpYyBpbnQKIHZlbmRfcmZjMTA0OChjcCwgbGVuKQogCXVfY2hhciAqY3A7CmRpZmYgLS1naXQg YS8vdXNyL3NyYy9saWIvbGlic3RhbmQvYm9vdHAuaC5vbGQgYi8vdXNyL3NyYy9saWIvbGlic3Rh bmQvYm9vdHAuaAotLS0gYS8vdXNyL3NyYy9saWIvbGlic3RhbmQvYm9vdHAuaC5vbGQKKysrIGIv L3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmgKQEAgLTIyLDYgKzIyLDggQEAKICAqICRGcmVl QlNEOiBoZWFkL2xpYi9saWJzdGFuZC9ib290cC5oIDMwNTEyNSAyMDE2LTA4LTMxIDEzOjE2OjQw WiBiYXB0ICQKICAqLwogCisjaWZuZGVmIF9CT09UUF9IXworI2RlZmluZSBfQk9PVFBfSF8KIAog c3RydWN0IGJvb3RwIHsKIAl1bnNpZ25lZCBjaGFyCWJwX29wOwkJLyogcGFja2V0IG9wY29kZSB0 eXBlICovCkBAIC0xNDUsMyArMTQ3LDcgQEAKIAogLyogdl9mbGFncyB2YWx1ZXMgKi8KICNkZWZp bmUgVkZfU01BU0sJMQkvKiBTdWJuZXQgbWFzayBmaWVsZCBjb250YWlucyB2YWxpZCBkYXRhICov CisKK2ludAlkaGNwX3RyeV9yZmMxMDQ4KHVfY2hhciAqY3AsIHVfaW50IGxlbik7CisKKyNlbmRp ZiAvKiBfQk9PVFBfSF8gKi8KCg== --b1_2209b35b9fb214820ca492563671285f-- From owner-freebsd-net@freebsd.org Thu Mar 2 23:21:43 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D7333CF59F0 for ; Thu, 2 Mar 2017 23:21:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C36AB1882 for ; Thu, 2 Mar 2017 23:21:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v22NLhoJ064960 for ; Thu, 2 Mar 2017 23:21:43 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217509] [patch] netinet/netinet6: missing curly braces in inm_merge/in6m_merge Date: Thu, 02 Mar 2017 23:21:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ngie@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to bug_severity Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 23:21:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217509 Ngie Cooper changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|freebsd-bugs@FreeBSD.org |freebsd-net@FreeBSD.org Severity|Affects Only Me |Affects Some People --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Thu Mar 2 23:24:59 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2E642CF5CB5 for ; Thu, 2 Mar 2017 23:24:59 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 16D701DEB for ; Thu, 2 Mar 2017 23:24:59 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 133D7CF5CB4; Thu, 2 Mar 2017 23:24:59 +0000 (UTC) Delivered-To: net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 12E56CF5CB3 for ; Thu, 2 Mar 2017 23:24:59 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (glebi.us [96.95.210.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id EDD951DEA; Thu, 2 Mar 2017 23:24:58 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id v22NOvhS039933 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 2 Mar 2017 15:24:57 -0800 (PST) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id v22NOvB6039932; Thu, 2 Mar 2017 15:24:57 -0800 (PST) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@FreeBSD.org using -f Date: Thu, 2 Mar 2017 15:24:57 -0800 From: Gleb Smirnoff To: Sepherosa Ziehau Cc: Julien Charbon , Jason Eggleston , "freebsd-net@freebsd.org" , hiren@freebsd.org, jtl@freebsd.org, rrs@freebsd.org Subject: Re: listening sockets as non sockets Message-ID: <20170302232457.GY1044@FreeBSD.org> References: <20170127005251.GM2611@FreeBSD.org> <20170210063024.GE1973@FreeBSD.org> <20170216184903.GF58829@FreeBSD.org> <0858647a-ec3c-1a78-053f-d04397a82d8a@freebsd.org> <20170222232704.GJ8899@FreeBSD.org> <20170302220051.GU1044@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170302220051.GU1044@FreeBSD.org> User-Agent: Mutt/1.7.2 (2016-11-26) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 23:24:59 -0000 On Thu, Mar 02, 2017 at 02:00:51PM -0800, Gleb Smirnoff wrote: T> I did similar testing, and my results are the following, for three T> consecutive runs: T> T> solisten head (r306199) T> req/s 63k,63k,63k 46k,47k,44k T> latency 213,214,208 232,233,223 Pretty much the same results for a longer run (20 minutes): Running 20m test @ http://solisten/file 48 threads and 15000 connections, 1 requests/connection Thread Stats Avg Stdev Max +/- Stdev Latency 120.23ms 60.63ms 1.24s 86.93% Req/Sec 1.33k 100.25 5.62k 70.82% Latency Distribution 50% 119.82ms 75% 144.66ms 90% 166.03ms 99% 219.09ms 76049743 requests in 20.00m, 149.87GB read Socket errors: connect 0, read 0, write 0, timeout 78 Requests/sec: 63369.04 Transfer/sec: 127.88MB Running 20m test @ http://head/file 48 threads and 15000 connections, 1 requests/connection Thread Stats Avg Stdev Max +/- Stdev Latency 155.87ms 42.72ms 2.00s 75.57% Req/Sec 1.05k 624.69 8.43k 59.62% Latency Distribution 50% 164.24ms 75% 184.38ms 90% 199.33ms 99% 224.04ms 58117047 requests in 20.00m, 114.53GB read Socket errors: connect 1424, read 39737299, write 1468308, timeout 23314 Requests/sec: 48426.74 Transfer/sec: 97.72MB -- Totus tuus, Glebius. From owner-freebsd-net@freebsd.org Fri Mar 3 00:47:57 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C4D66CF5360 for ; Fri, 3 Mar 2017 00:47:57 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id A109D104D for ; Fri, 3 Mar 2017 00:47:57 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 0F68C1AB4E; Fri, 3 Mar 2017 00:47:57 +0000 (UTC) Date: Fri, 3 Mar 2017 00:47:57 +0000 To: freebsd-net@freebsd.org From: "jhujhiti_adjectivism.org (Erick Turnquist)" Reply-to: D9451+325+eaa6f8a0c0731bfe@reviews.freebsd.org Subject: [Differential] D9451: Constrain IPv6 interface routes to each FIB Message-ID: <3d82b26400f65e528b4806338d3cb080@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: Thread-Topic: D9451: Constrain IPv6 interface routes to each FIB X-Herald-Rules: <28>, <81> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: MzA4MmVhNjA3MDYxYjk1ZGE4NzFjZWJhMzgyIFi4vT0= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 00:47:57 -0000 amh1amhpdGlfYWRqZWN0aXZpc20ub3JnIGFkZGVkIGlubGluZSBjb21tZW50cy4KCklOTElORSBD T01NRU5UUwoKPiBhc29tZXJzIHdyb3RlIGluIG5kNi5jOjEyOTUKPiBSZW1lbWJlciwgdGhlIGlu dGVyZmFjZSBmaWIgb25seSBtYXR0ZXJzIGZvciBmb3J3YXJkaW5nIHBhY2tldHMuICBJdCdzIHRv dGFsbHkgdmFsaWQgZm9yIGFuIGludGVyZmFjZSB0byBoYXZlIG11bHRpcGxlIGFkZHJlc3NlcyBh c3NpZ25lZCwgZWFjaCBvZiB3aGljaCBpcyBvbiBhIGRpZmZlcmVudCBmaWIuICBTbywgdG8gY29y cmVjdGx5IGRldGVybWluZSB3aGV0aGVyIGBhZGRyYCBpcyBhIG5laWdoYm9yIG9mIGBpZnBgLCB3 ZSBtdXN0IGVpdGhlcgo+IAo+IDEuIExvb3Agb3ZlciBhbGwgZmlicywgYW5kIGNoZWNrIHdoZXRo ZXIgYGFkZHJgIGlzIGEgbmVpZ2hib3Igb2YgYGlmcGAgb24gYW55IG9mIHRoZW0sIG9yCj4gMi4g TG9vcCBvdmVyIGFsbCBhZGRyZXNzZXMgYXNzaWduZWQgdG8gYGlmcGAsIGFuZCBjaGVjayB3aGV0 aGVyIGBhZGRyYCBpcyBhIG5laWdoYm9yIG9mIGBpZnBgIG9uIHRoYXQgYWRkcmVzcydzIGZpYi4g IEknbSBndWVzc2luZyB0aGF0IHRoaXMgd2lsbCBiZSB0aGUgc2xvd2VyIG9wdGlvbiwgYmVjYXVz ZSBhbiBpbnRlcmZhY2UgY2FuIGhhdmUgYXJiaXRyYXJpbHkgbWFueSBhZGRyZXNzZXMKCj4gSXQn cyB0b3RhbGx5IHZhbGlkIGZvciBhbiBpbnRlcmZhY2UgdG8gaGF2ZSBtdWx0aXBsZSBhZGRyZXNz ZXMgYXNzaWduZWQsIGVhY2ggb2Ygd2hpY2ggaXMgb24gYSBkaWZmZXJlbnQgZmliLgoKSXMgdGhp cyB0cnVlPyBJJ20gbm90IGF3YXJlIG9mIGEgd2F5IHRoaXMgY291bGQgaGFwcGVuLiBJbnRlcmZh Y2Ugcm91dGVzIGFyZSBhZGRlZCB0byB0aGUgRklCIGFzc29jaWF0ZWQgd2l0aCB0aGUgaW50ZXJm YWNlLCBhbmQgb2YgY291cnNlIHRoZXJlIGlzIG9ubHkgb25lIEZJQiBwZXIgaW50ZXJmYWNlLiBG b3IgaW5zdGFuY2UgaW42X25ld2FkZHJtc2coKSBwcm92aWRlcyBubyBtZWNoYW5pc20gYnkgd2hp Y2ggdG8gYXNzaWduIHRoZSByb3V0ZSBmb3IgdGhlIGludGVyZmFjZSdzIGFkZHJlc3MgdG8gYW55 dGhpbmcgb3RoZXIgdGhhbiB0aGUgaW50ZXJmYWNlIEZJQi4KClJFUE9TSVRPUlkKICByUyBGcmVl QlNEIHNyYyByZXBvc2l0b3J5CgpSRVZJU0lPTiBERVRBSUwKICBodHRwczovL3Jldmlld3MuZnJl ZWJzZC5vcmcvRDk0NTEKCkVNQUlMIFBSRUZFUkVOQ0VTCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVi c2Qub3JnL3NldHRpbmdzL3BhbmVsL2VtYWlscHJlZmVyZW5jZXMvCgpUbzogamh1amhpdGlfYWRq ZWN0aXZpc20ub3JnLCAjbmV0d29yaywgYnosIGFzb21lcnMKQ2M6IGpjaCwgYnosIGltcCwgYWUs IGZyZWVic2QtbmV0LWxpc3QK From owner-freebsd-net@freebsd.org Fri Mar 3 01:16:26 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 365F1CF6360 for ; Fri, 3 Mar 2017 01:16:26 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 122601551 for ; Fri, 3 Mar 2017 01:16:26 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 9164C1A5E0; Fri, 3 Mar 2017 01:16:25 +0000 (UTC) Date: Fri, 3 Mar 2017 01:16:25 +0000 To: freebsd-net@freebsd.org From: "asomers (Alan Somers)" Reply-to: D9451+325+eaa6f8a0c0731bfe@reviews.freebsd.org Subject: [Differential] D9451: Constrain IPv6 interface routes to each FIB Message-ID: <4bd6a528077f144f2b546a0138d8355b@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: Thread-Topic: D9451: Constrain IPv6 interface routes to each FIB X-Herald-Rules: <28>, <81> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: MzA4MmVhNjA3MDYxYjk1ZGE4NzFjZWJhMzgyIFi4w+k= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 01:16:26 -0000 YXNvbWVycyBhZGRlZCBpbmxpbmUgY29tbWVudHMuCgpJTkxJTkUgQ09NTUVOVFMKCj4gamh1amhp dGlfYWRqZWN0aXZpc20ub3JnIHdyb3RlIGluIG5kNi5jOjEyOTUKPiA+IEl0J3MgdG90YWxseSB2 YWxpZCBmb3IgYW4gaW50ZXJmYWNlIHRvIGhhdmUgbXVsdGlwbGUgYWRkcmVzc2VzIGFzc2lnbmVk LCBlYWNoIG9mIHdoaWNoIGlzIG9uIGEgZGlmZmVyZW50IGZpYi4KPiAKPiBJcyB0aGlzIHRydWU/ IEknbSBub3QgYXdhcmUgb2YgYSB3YXkgdGhpcyBjb3VsZCBoYXBwZW4uIEludGVyZmFjZSByb3V0 ZXMgYXJlIGFkZGVkIHRvIHRoZSBGSUIgYXNzb2NpYXRlZCB3aXRoIHRoZSBpbnRlcmZhY2UsIGFu ZCBvZiBjb3Vyc2UgdGhlcmUgaXMgb25seSBvbmUgRklCIHBlciBpbnRlcmZhY2UuIEZvciBpbnN0 YW5jZSBpbjZfbmV3YWRkcm1zZygpIHByb3ZpZGVzIG5vIG1lY2hhbmlzbSBieSB3aGljaCB0byBh c3NpZ24gdGhlIHJvdXRlIGZvciB0aGUgaW50ZXJmYWNlJ3MgYWRkcmVzcyB0byBhbnl0aGluZyBv dGhlciB0aGFuIHRoZSBpbnRlcmZhY2UgRklCLgoKWWVwLCBpdCdzIHRydWUuICBPbmUgd2F5IGlz IHRvIGRvIGl0IHdpdGggc3RhdGljIHJvdXRlcy4gIEFub3RoZXIgd2F5IGludm9sdmVzIGNoYW5n aW5nIHRoZSBpbnRlcmZhY2VzJ3MgZmliLiAgRm9yIGV4YW1wbGUsIGxpa2UgdGhpczoKCiAgaWZj b25maWcgdGFwMCBjcmVhdGUKICBpZmNvbmZpZyB0YXAwIDEwLjEuMC4xLzI0IGZpYiAyCiAgaWZj b25maWcgdGFwMCAxMC4xLjEuMS8yNCBmaWIgMyBhbGlhcwoKUkVQT1NJVE9SWQogIHJTIEZyZWVC U0Qgc3JjIHJlcG9zaXRvcnkKClJFVklTSU9OIERFVEFJTAogIGh0dHBzOi8vcmV2aWV3cy5mcmVl YnNkLm9yZy9EOTQ1MQoKRU1BSUwgUFJFRkVSRU5DRVMKICBodHRwczovL3Jldmlld3MuZnJlZWJz ZC5vcmcvc2V0dGluZ3MvcGFuZWwvZW1haWxwcmVmZXJlbmNlcy8KClRvOiBqaHVqaGl0aV9hZGpl Y3RpdmlzbS5vcmcsICNuZXR3b3JrLCBieiwgYXNvbWVycwpDYzogamNoLCBieiwgaW1wLCBhZSwg ZnJlZWJzZC1uZXQtbGlzdAo= From owner-freebsd-net@freebsd.org Fri Mar 3 01:57:19 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 13917CF5135 for ; Fri, 3 Mar 2017 01:57:19 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id E5F861010 for ; Fri, 3 Mar 2017 01:57:18 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id E27ABCF5132; Fri, 3 Mar 2017 01:57:18 +0000 (UTC) Delivered-To: net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E2218CF512B for ; Fri, 3 Mar 2017 01:57:18 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mail-ua0-x236.google.com (mail-ua0-x236.google.com [IPv6:2607:f8b0:400c:c08::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9AB7C100F; Fri, 3 Mar 2017 01:57:18 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mail-ua0-x236.google.com with SMTP id f54so99266501uaa.1; Thu, 02 Mar 2017 17:57:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ir0YrlChUlzLU3g/0pY6jCRcH5NhAeZoI3+HW/gZOeQ=; b=eOS+pxOO5gVaxB3fIp5gVn7A2h0I23a0JygK4lxUETBy+Bj5hEsdasP7qfYoRVgqfd lN5k0ZJ3tUuk6MHmKOBLOA+TJJlE+3BK6fwHiYq/97M8eWYidqR8S+O3rftIOQZAzJhU Vu9qTAihazZZ9D3ZdsnB6UE7MBEvYeLpzGRomaFwkqXfAkKIOIwkIRsxVkGavaEuF6/L LB+1wIexRcBRI/rlvTenszC+hIzcXuzOsBb3hy0IBkt3+lqf5a2VrGDg9Ango0jWR8m7 o0B6sC6pTB0rakMQ9js1HOdAP3cDVl4VryiYcfM1SC3tHKkXLmszD7s62SOix3GiYalM cxcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ir0YrlChUlzLU3g/0pY6jCRcH5NhAeZoI3+HW/gZOeQ=; b=qRQBlnbkx5tc9Ff12tahdbZ2LaETz1dsNba5KmLNrU3KdNYZMaN8kq3SVr0n6Lz4Hz nIaGT03dqO6JGAlYYATuS7OULXNBCUzlVFB3FLLEYlqJzQTBlAfXP6oJIpZxdarn45ln owBtzgClYlNyPcsp0eUpthYDO+Gsb3YRva9E1vwGCmwNx1sgMoxXTqBPV8LggDjbOfw6 WB0r83NRenMNkT/8ygXZ8hGiDAnXmunWFUKG6QgvaifD8/cLQPevPnXIZtFGf/qaArrl RDETzboaDY+xGe4tdURWIV38YDKEP5w/dI/Ga2yud1bKjiR2jHS3A0QYzqmHzG35isDy zJew== X-Gm-Message-State: AMke39lw/3n8oPLKTVluPDcGIxdrTv3Ev1su4n3khY4RfDn9tkM3iYC7nBV0pV/Xbrb5awq3CaSOSSM/dgvksw== X-Received: by 10.176.6.233 with SMTP id g96mr130010uag.68.1488506237429; Thu, 02 Mar 2017 17:57:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.176.66.193 with HTTP; Thu, 2 Mar 2017 17:57:16 -0800 (PST) In-Reply-To: <20170302220051.GU1044@FreeBSD.org> References: <20170127005251.GM2611@FreeBSD.org> <20170210063024.GE1973@FreeBSD.org> <20170216184903.GF58829@FreeBSD.org> <0858647a-ec3c-1a78-053f-d04397a82d8a@freebsd.org> <20170222232704.GJ8899@FreeBSD.org> <20170302220051.GU1044@FreeBSD.org> From: Sepherosa Ziehau Date: Fri, 3 Mar 2017 09:57:16 +0800 Message-ID: Subject: Re: listening sockets as non sockets To: Gleb Smirnoff Cc: Julien Charbon , Jason Eggleston , "freebsd-net@freebsd.org" , hiren@freebsd.org, jtl@freebsd.org, rrs@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 01:57:19 -0000 On Fri, Mar 3, 2017 at 6:00 AM, Gleb Smirnoff wrote: > On Sun, Feb 26, 2017 at 11:37:59PM +0800, Sepherosa Ziehau wrote: > S> r314268 -> solisten > S> > S> 1KB: > S> Performance (reqs/s) > S> 77916.71 -> 26240.37 > S> Latency average > S> 121ms -> 294ms > ... > S> So what I have seen is solisten's performance is 1/3 of r314268, and > S> average latency doubles. > > I did similar testing, and my results are the following, for three > consecutive runs: > > solisten head (r306199) > req/s 63k,63k,63k 46k,47k,44k > latency 213,214,208 232,233,223 > > So, I don't see latency increase, neither req/s regression. I see > the opposite. > > What is different about my test? First, this is NetflixBSD, both head > and solisten installation. Head is based on r306199 and solisten > is based on r314150 and cb79de4fd2912450c4ab808c017ae395fd636bd8 from > my github. > > To my knowledge the parts of the stack that are different in NetflixBSD > do not touch sonewconn(), accept4() and other parts we are interested at. > I also didn't notice any drastical changes in head between r306199 and > r314150. So imho it is fair to attribute the difference to my change. > > The hardware is different. It is Supermicro X9SRH-7F/7TF, > Xeon(R) CPU E5-2697 v2 @ 2.70GHz, 256Gb RAM and Chelsio cxl(4) > at 40Gbit/s. I got two boxes of this configuration one running head > and other solisten. The client box runs same CPU and mainboard, but has > lagg of two cxls, capping it to 80 Gbit/s, which isn't important but, > what is important providing more parallelism at sending side. > > The nginx has multiple listening sockets, but we bombard only one that > is at AF_INET4 *:80. The nginx is configured to 64 worker processes > and accept_mutex is on. So, even with 1 socket, seems like I got some > improvement. > > I run your wrk 498d70f6da5a201f109488eeaf31c8ba891dc163, and the command > used on the sending side is: > > ./wrk -c 15000 -t 48 -d 120s --delay --latency --connreqs 1 http://host/file > > The difference to your command is only threads count. My box has much > more cores. Well, as I mentioned to you, I hooked up two client boxes, each runs 15000 concurrent connections; so 30K concurrent connections total. BTW, how heavy traffic your client box could generate? Each of mine client box could generate 160Kreqs/s for 1req/conn for 1KB web object, maybe that's the difference? > > The file is of size 1657 bytes. > > Sephe, can you please get hwpmc dumps with your test on solisten/head? In > the test that shows that solisten is 3x slower. Yeah, sure. I need to restore the freebsd on the server side; just wiped out the disk to do the same bench on linux. I will give you the information you want in one week or two. Could you give me the exact command I need to use for extracting the hwpmc stats? Thanks, sephe -- Tomorrow Will Never Die From owner-freebsd-net@freebsd.org Fri Mar 3 02:11:30 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8570ACF5722 for ; Fri, 3 Mar 2017 02:11:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 74081177E for ; Fri, 3 Mar 2017 02:11:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v232BTjF003108 for ; Fri, 3 Mar 2017 02:11:30 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217413] panic: Assertion err == 0 failed at /usr/src/sys/net/iflib.c:2242 after 1000m physical link shutdown Date: Fri, 03 Mar 2017 02:11:30 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: shawn.webb@hardenedbsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 02:11:30 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217413 Shawn Webb changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shawn.webb@hardenedbsd.org --- Comment #4 from Shawn Webb --- I'm affected by this, too. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Fri Mar 3 03:26:58 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2E2DBCF6CB8 for ; Fri, 3 Mar 2017 03:26:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 102EF1BFF for ; Fri, 3 Mar 2017 03:26:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v233QvEE094268 for ; Fri, 3 Mar 2017 03:26:57 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217413] panic: Assertion err == 0 failed at /usr/src/sys/net/iflib.c:2242 after 1000baseT physical link shutdown Date: Fri, 03 Mar 2017 03:26:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: bsd@kobyla.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: short_desc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 03:26:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217413 bsd@kobyla.org changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|panic: Assertion err =3D=3D 0 |panic: Assertion err = =3D=3D 0 |failed at |failed at |/usr/src/sys/net/iflib.c:22 |/usr/src/sys/net/iflib.c:22 |42 after 1000m physical |42 after 1000baseT physical |link shutdown |link shutdown --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Fri Mar 3 03:32:24 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C5050CF6F6F for ; Fri, 3 Mar 2017 03:32:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B484F1063 for ; Fri, 3 Mar 2017 03:32:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v233WOBM031130 for ; Fri, 3 Mar 2017 03:32:24 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217413] panic: Assertion err == 0 failed at /usr/src/sys/net/iflib.c:2242 after 1000baseT physical link shutdown Date: Fri, 03 Mar 2017 03:32:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: bsd@kobyla.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 03:32:24 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217413 --- Comment #5 from bsd@kobyla.org --- Sometimes link speed drops to 100baseTX (mostly on em/bce) without the any message to dmesg or syslog and then FreeBSD panics after the try of re-conn= ect the cable to fix the speed (it gets 1G speed again after boot). --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Fri Mar 3 06:53:11 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9D182CF5083 for ; Fri, 3 Mar 2017 06:53:11 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 79D461389 for ; Fri, 3 Mar 2017 06:53:11 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id E0CE41AF3B; Fri, 3 Mar 2017 06:53:10 +0000 (UTC) Date: Fri, 3 Mar 2017 06:53:10 +0000 To: freebsd-net@freebsd.org From: "smh (Steven Hartland)" Reply-to: D9847+325+deba385e191bfbb6@reviews.freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: <2488742d8120ee5758ec7e34a7f644a9@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: Thread-Topic: D9847: Try to extract the RFC1048 data from PXE X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: YTlhODdhNGFiNzc3NzE3ZGRmMjFjNTkwOTA3IFi5EtY= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 06:53:11 -0000 c21oIGFkZGVkIGlubGluZSBjb21tZW50cy4KCklOTElORSBDT01NRU5UUwoKPiBweGUuYzoyOTYK PiArCj4gKwkJCWlmIChkaGNwX3RyeV9yZmMxMDQ4KGJvb3RwbGF5ZXIudmVuZG9yLmQsIEJPT1RQ X0RIQ1BWRU5EKSkgewo+ICsJCQkJaWYgKHB4ZV9kZWJ1ZykKCkRpZG4ndCBzcG90IHRoaXMgYmVm b3JlIGJ1dCBkb2VzIHRoaXMgbmVlZCBhIG1vcmUgZXhwbGljaXQgdGVzdCBhcyB0aGlzIG1ldGhv ZCByZXR1cm5zIGFuZCBpc24ndCBub3QgYSBib29rIGFuZCBpdCdzIG5vdCBjbGVhciB3aGF0J3Mg dGhlIC0xIGlzIG1lYW50IHRvIHRyaWdnZXIgYW5kIGhvdyBpdCdzIGRlYWx0IHdpdGggaGVyZT8K ClJFVklTSU9OIERFVEFJTAogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9EOTg0NwoKRU1B SUwgUFJFRkVSRU5DRVMKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvc2V0dGluZ3MvcGFu ZWwvZW1haWxwcmVmZXJlbmNlcy8KClRvOiBrY3pla2lyZGEsIG9zaG9nYm8sIGJhcHQsIHRzb29t ZSwgZ2xlYml1cywgZnJlZWJzZC1uZXQtbGlzdCwgI25ldHdvcmssIGdubiwgc21oCkNjOiBzbWgK From owner-freebsd-net@freebsd.org Fri Mar 3 06:56:17 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C59B2CF5140 for ; Fri, 3 Mar 2017 06:56:17 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id A27981500 for ; Fri, 3 Mar 2017 06:56:17 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 1627E1A0FD; Fri, 3 Mar 2017 06:56:17 +0000 (UTC) Date: Fri, 3 Mar 2017 06:56:17 +0000 To: freebsd-net@freebsd.org From: "smh (Steven Hartland)" Reply-to: D9847+325+deba385e191bfbb6@reviews.freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: Thread-Topic: D9847: Try to extract the RFC1048 data from PXE X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: YTlhODdhNGFiNzc3NzE3ZGRmMjFjNTkwOTA3IFi5E5E= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 06:56:17 -0000 c21oIGFkZGVkIGEgY29tbWVudC4KCgogIGJvb2sgLT4gYm9vbAoKUkVWSVNJT04gREVUQUlMCiAg aHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0Q5ODQ3CgpFTUFJTCBQUkVGRVJFTkNFUwogIGh0 dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9zZXR0aW5ncy9wYW5lbC9lbWFpbHByZWZlcmVuY2Vz LwoKVG86IGtjemVraXJkYSwgb3Nob2dibywgYmFwdCwgdHNvb21lLCBnbGViaXVzLCBmcmVlYnNk LW5ldC1saXN0LCAjbmV0d29yaywgZ25uLCBzbWgKQ2M6IHNtaAo= From owner-freebsd-net@freebsd.org Fri Mar 3 10:26:11 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 63A06CF683D for ; Fri, 3 Mar 2017 10:26:11 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 394731743 for ; Fri, 3 Mar 2017 10:26:11 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id A1DB51B804; Fri, 3 Mar 2017 10:26:10 +0000 (UTC) Date: Fri, 3 Mar 2017 10:26:10 +0000 To: freebsd-net@freebsd.org From: "kczekirda (Kamil Czekirda)" Reply-to: D9847+325+deba385e191bfbb6@reviews.freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: <974007be139d0b93ba4243bb370c91ff@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , Thread-Topic: D9847: Try to extract the RFC1048 data from PXE X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: YTlhODdhNGFiNzc3NzE3ZGRmMjFjNTkwOTA3IFi5RMI= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_974007be139d0b93ba4243bb370c91ff" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 10:26:11 -0000 --b1_974007be139d0b93ba4243bb370c91ff Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: base64 a2N6ZWtpcmRhIHVwZGF0ZWQgdGhpcyByZXZpc2lvbiB0byBEaWZmIDI1OTMxLgoKQ0hBTkdFUyBT SU5DRSBMQVNUIFVQREFURQogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9EOTg0Nz92cz0y NTkxNyZpZD0yNTkzMQoKUkVWSVNJT04gREVUQUlMCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qu b3JnL0Q5ODQ3CgpBRkZFQ1RFRCBGSUxFUwogIC91c3Ivc3JjL2xpYi9saWJzdGFuZC9ib290cC5j CiAgL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmgKICAvdXNyL3NyYy9zeXMvYm9vdC9pMzg2 L2xpYmkzODYvcHhlLmMKCkVNQUlMIFBSRUZFUkVOQ0VTCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVi c2Qub3JnL3NldHRpbmdzL3BhbmVsL2VtYWlscHJlZmVyZW5jZXMvCgpUbzoga2N6ZWtpcmRhLCBv c2hvZ2JvLCBiYXB0LCB0c29vbWUsIGdsZWJpdXMsIGZyZWVic2QtbmV0LWxpc3QsICNuZXR3b3Jr LCBnbm4sIHNtaApDYzogc21oCg== --b1_974007be139d0b93ba4243bb370c91ff Content-Type: text/x-patch; charset=utf-8; name="D9847.25931.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D9847.25931.patch" ZGlmZiAtLWdpdCBhLy91c3Ivc3JjL3N5cy9ib290L2kzODYvbGliaTM4Ni9weGUuYy5vbGQgYi8v dXNyL3NyYy9zeXMvYm9vdC9pMzg2L2xpYmkzODYvcHhlLmMKLS0tIGEvL3Vzci9zcmMvc3lzL2Jv b3QvaTM4Ni9saWJpMzg2L3B4ZS5jLm9sZAorKysgYi8vdXNyL3NyYy9zeXMvYm9vdC9pMzg2L2xp YmkzODYvcHhlLmMKQEAgLTEwMSw2ICsxMDEsNyBAQAogZXh0ZXJuIHVfaW50MTZfdAkJX19weGVu dnNlZzsKIGV4dGVybiB1X2ludDE2X3QJCV9fcHhlbnZvZmY7CiBleHRlcm4gdm9pZAkJCV9fcHhl bnZlbnRyeSh2b2lkKTsKK2V4dGVybiBzdHJ1Y3QgaW5fYWRkcgkJc2VydmlwOwogCiBzdHJ1Y3Qg bmV0aWZfZGlmIHB4ZV9pZnNbXSA9IHsKIC8qCWRpZl91bml0ICAgICAgICBkaWZfbnNlbCAgICAg ICAgZGlmX3N0YXRzICAgICAgIGRpZl9wcml2YXRlICAgICAqLwpAQCAtMjc2LDE3ICsyNzcsMzgg QEAKIAkJCX0KIAkJCWlmIChweGVfZGVidWcpCiAJCQkJcHJpbnRmKCJweGVfb3BlbjogbmV0aWZf b3BlbigpIHN1Y2NlZWRlZFxuIik7CisKKwkJCWlmIChzb2NrdG9kZXNjKHB4ZV9zb2NrKSA9PSBO VUxMKSB7CisJCQkJcHJpbnRmKCJweGVfb3BlbjogYmFkIHNvY2tldCAlZFxuIiwgcHhlX3NvY2sp OworCQkJCXJldHVybiAoRU5YSU8pOworCQkJfQorCiAJCX0KIAkJaWYgKHJvb3RpcC5zX2FkZHIg PT0gMCkgewogCQkJLyoKLQkJCSAqIERvIGEgYm9vdHAvZGhjcCByZXF1ZXN0IHRvIGZpbmQgb3V0 IHdoZXJlIG91cgorCQkJICogVHJ5IHRvIGV4dHJhY3QgdGhlIFJGQzEwNDggZGF0YSBmcm9tIFBY RS4KKwkJCSAqIElmIGZhaWwgZG8gYSBib290cC9kaGNwIHJlcXVlc3QgdG8gZmluZCBvdXQgd2hl cmUgb3VyCiAJCQkgKiBORlMvVEZUUCBzZXJ2ZXIgaXMuIEV2ZW4gaWYgd2UgZG9udCBnZXQgYmFj awogCQkJICogdGhlIHByb3BlciBpbmZvcm1hdGlvbiwgZmFsbCBiYWNrIHRvIHRoZSBzZXJ2ZXIK IAkJCSAqIHdoaWNoIGJyb3VnaHQgdXMgdG8gbGlmZSBhbmQgYSBkZWZhdWx0IHJvb3RwYXRoLgog CQkJICovCi0JCQlib290cChweGVfc29jaywgQk9PVFBfUFhFKTsKKworCQkJaWYgKGRoY3BfdHJ5 X3JmYzEwNDgoYm9vdHBsYXllci52ZW5kb3IuZCwgQk9PVFBfREhDUFZFTkQpIDwgMCApIHsKKwkJ CQlpZiAocHhlX2RlYnVnKQorCQkJCQlwcmludGYoInB4ZV9vcGVuOiBubyBSRkMxMDQ4IGRhdGEg aW4gUFhFIENhY2hlXG4iKTsKKwkJCQlib290cChweGVfc29jaywgQk9PVFBfUFhFKTsKKwkJCX0g ZWxzZSBpZiAocHhlX2RlYnVnKSB7CisJCQkJcHJpbnRmKCJweGVfb3BlbjogbG9hZGVkIFJGQzEw NDggZGF0YSBmcm9tIFBYRSBDYWNoZVxuIik7CisJCQl9CisKIAkJCWlmIChyb290aXAuc19hZGRy ID09IDApCiAJCQkJcm9vdGlwLnNfYWRkciA9IGJvb3RwbGF5ZXIuc2lwOworCQkJaWYgKGdhdGVp cC5zX2FkZHIgPT0gMCkKKwkJCQlnYXRlaXAuc19hZGRyID0gYm9vdHBsYXllci5naXA7CisJCQlp ZiAobXlpcC5zX2FkZHIgPT0gMCkKKwkJCQlteWlwLnNfYWRkciA9IGJvb3RwbGF5ZXIueWlwOwor CQkJaWYgKHNlcnZpcC5zX2FkZHIgPT0gMCkKKwkJCQlzZXJ2aXAgPSByb290aXA7CiAKIAkJCW5l dHByb3RvID0gTkVUX05GUzsKIAkJCWlmICh0ZnRwaXAuc19hZGRyICE9IDApIHsKQEAgLTMyMyw2 ICszNDUsOSBAQAogCQkJcHJpbnRmKCJweGVfb3Blbjogc2VydmVyIGFkZHI6ICVzXG4iLCBpbmV0 X250b2Eocm9vdGlwKSk7CiAJCQlwcmludGYoInB4ZV9vcGVuOiBzZXJ2ZXIgcGF0aDogJXNcbiIs IHJvb3RwYXRoKTsKIAkJCXByaW50ZigicHhlX29wZW46IGdhdGV3YXkgaXA6ICAlc1xuIiwgaW5l dF9udG9hKGdhdGVpcCkpOworCQkJcHJpbnRmKCJweGVfb3BlbjogbXkgaXA6ICAgICAgICVzXG4i LCBpbmV0X250b2EobXlpcCkpOworCQkJcHJpbnRmKCJweGVfb3BlbjogbmV0bWFzazogICAgICVz XG4iLCBpbnRvYShuZXRtYXNrKSk7CisJCQlwcmludGYoInB4ZV9vcGVuOiBzZXJ2aXA6ICAgICAg JXNcbiIsIGluZXRfbnRvYShzZXJ2aXApKTsKIAogCQkJaWYgKG5ldHByb3RvID09IE5FVF9URlRQ KSB7CiAJCQkJc2V0ZW52KCJib290LnRmdHByb290LnNlcnZlciIsIGluZXRfbnRvYShyb290aXAp LCAxKTsKZGlmZiAtLWdpdCBhLy91c3Ivc3JjL2xpYi9saWJzdGFuZC9ib290cC5jLm9sZCBiLy91 c3Ivc3JjL2xpYi9saWJzdGFuZC9ib290cC5jCi0tLSBhLy91c3Ivc3JjL2xpYi9saWJzdGFuZC9i b290cC5jLm9sZAorKysgYi8vdXNyL3NyYy9saWIvbGlic3RhbmQvYm9vdHAuYwpAQCAtMzQ0LDYg KzM0NCwxNyBAQAogCXJldHVybiAoLTEpOwogfQogCitpbnQKK2RoY3BfdHJ5X3JmYzEwNDgodV9j aGFyICpjcCwgdV9pbnQgbGVuKQoreworCisJZXhwZWN0ZWRfZGhjcG1zZ3R5cGUgPSBESENQQUNL OworCWlmIChiY21wKHZtX3JmYzEwNDgsIGNwLCBzaXplb2Yodm1fcmZjMTA0OCkpID09IDApIHsK KwkJcmV0dXJuICh2ZW5kX3JmYzEwNDgoY3AsIGxlbikpOworCX0KKwlyZXR1cm4gKC0xKTsKK30K Kwogc3RhdGljIGludAogdmVuZF9yZmMxMDQ4KGNwLCBsZW4pCiAJdV9jaGFyICpjcDsKZGlmZiAt LWdpdCBhLy91c3Ivc3JjL2xpYi9saWJzdGFuZC9ib290cC5oLm9sZCBiLy91c3Ivc3JjL2xpYi9s aWJzdGFuZC9ib290cC5oCi0tLSBhLy91c3Ivc3JjL2xpYi9saWJzdGFuZC9ib290cC5oLm9sZAor KysgYi8vdXNyL3NyYy9saWIvbGlic3RhbmQvYm9vdHAuaApAQCAtMjIsNiArMjIsOCBAQAogICog JEZyZWVCU0Q6IGhlYWQvbGliL2xpYnN0YW5kL2Jvb3RwLmggMzA1MTI1IDIwMTYtMDgtMzEgMTM6 MTY6NDBaIGJhcHQgJAogICovCiAKKyNpZm5kZWYgX0JPT1RQX0hfCisjZGVmaW5lIF9CT09UUF9I XwogCiBzdHJ1Y3QgYm9vdHAgewogCXVuc2lnbmVkIGNoYXIJYnBfb3A7CQkvKiBwYWNrZXQgb3Bj b2RlIHR5cGUgKi8KQEAgLTE0NSwzICsxNDcsNyBAQAogCiAvKiB2X2ZsYWdzIHZhbHVlcyAqLwog I2RlZmluZSBWRl9TTUFTSwkxCS8qIFN1Ym5ldCBtYXNrIGZpZWxkIGNvbnRhaW5zIHZhbGlkIGRh dGEgKi8KKworaW50CWRoY3BfdHJ5X3JmYzEwNDgodV9jaGFyICpjcCwgdV9pbnQgbGVuKTsKKwor I2VuZGlmIC8qIF9CT09UUF9IXyAqLwoK --b1_974007be139d0b93ba4243bb370c91ff-- From owner-freebsd-net@freebsd.org Fri Mar 3 10:34:08 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CF6DECF6C08 for ; Fri, 3 Mar 2017 10:34:08 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id ABC461155 for ; Fri, 3 Mar 2017 10:34:08 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 6BA801BE74; Fri, 3 Mar 2017 10:34:08 +0000 (UTC) Date: Fri, 3 Mar 2017 10:34:08 +0000 To: freebsd-net@freebsd.org From: "oshogbo (Mariusz Zaborski)" Reply-to: D9847+325+deba385e191bfbb6@reviews.freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , Thread-Topic: D9847: Try to extract the RFC1048 data from PXE X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: YTlhODdhNGFiNzc3NzE3ZGRmMjFjNTkwOTA3IFi5RqA= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 10:34:08 -0000 b3Nob2dibyBhZGRlZCBhIGNvbW1lbnQuCgoKICBAc21oCiAgSXMgaXQgd29yayBmb3IgeW91IGtu b3c/CiAgSSBoYXZlIG9uZSBtb3JlIHBhdGNoIGZyb20gQGtjemVraXJkYSBzbyBpcyBpdCByZWFk eSBmb3IgY29tbWl0PwoKUkVWSVNJT04gREVUQUlMCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qu b3JnL0Q5ODQ3CgpFTUFJTCBQUkVGRVJFTkNFUwogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9y Zy9zZXR0aW5ncy9wYW5lbC9lbWFpbHByZWZlcmVuY2VzLwoKVG86IGtjemVraXJkYSwgYmFwdCwg dHNvb21lLCBnbGViaXVzLCBmcmVlYnNkLW5ldC1saXN0LCAjbmV0d29yaywgZ25uLCBzbWgsIG9z aG9nYm8KQ2M6IHNtaAo= From owner-freebsd-net@freebsd.org Fri Mar 3 14:33:34 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BD0F2CF5929 for ; Fri, 3 Mar 2017 14:33:34 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 9808911AC for ; Fri, 3 Mar 2017 14:33:34 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 52CAB1A0E4; Fri, 3 Mar 2017 14:33:34 +0000 (UTC) Date: Fri, 3 Mar 2017 14:33:34 +0000 To: freebsd-net@freebsd.org From: "bapt (Baptiste Daroussin)" Reply-to: D9847+325+deba385e191bfbb6@reviews.freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: <8987da5a79e4c75db033837432671dad@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , Thread-Topic: D9847: Try to extract the RFC1048 data from PXE X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: YTlhODdhNGFiNzc3NzE3ZGRmMjFjNTkwOTA3IFi5fr4= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 14:33:34 -0000 YmFwdCBhY2NlcHRlZCB0aGlzIHJldmlzaW9uLgoKUkVWSVNJT04gREVUQUlMCiAgaHR0cHM6Ly9y ZXZpZXdzLmZyZWVic2Qub3JnL0Q5ODQ3CgpFTUFJTCBQUkVGRVJFTkNFUwogIGh0dHBzOi8vcmV2 aWV3cy5mcmVlYnNkLm9yZy9zZXR0aW5ncy9wYW5lbC9lbWFpbHByZWZlcmVuY2VzLwoKVG86IGtj emVraXJkYSwgdHNvb21lLCBnbGViaXVzLCBmcmVlYnNkLW5ldC1saXN0LCAjbmV0d29yaywgZ25u LCBzbWgsIG9zaG9nYm8sIGJhcHQKQ2M6IHNtaAo= From owner-freebsd-net@freebsd.org Fri Mar 3 15:45:15 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B4EC1CF6339 for ; Fri, 3 Mar 2017 15:45:15 +0000 (UTC) (envelope-from vas@mpeks.tomsk.su) Received: from relay2.tomsk.ru (mail.sibptus.tomsk.ru [212.73.124.5]) by mx1.freebsd.org (Postfix) with ESMTP id 2E1651474 for ; Fri, 3 Mar 2017 15:45:14 +0000 (UTC) (envelope-from vas@mpeks.tomsk.su) X-Virus-Scanned: by clamd daemon 0.98.5_1 for FreeBSD at relay2.tomsk.ru Received: from [212.73.125.240] (HELO admin.sibptus.transneft.ru) by relay2.tomsk.ru (CommuniGate Pro SMTP 5.1.16) with ESMTPS id 39627865 for freebsd-net@freebsd.org; Fri, 03 Mar 2017 21:40:43 +0600 Received: from admin.sibptus.transneft.ru (sudakov@localhost [127.0.0.1]) by admin.sibptus.transneft.ru (8.14.9/8.14.9) with ESMTP id v23FjCxT081779 for ; Fri, 3 Mar 2017 22:45:12 +0700 (KRAT) (envelope-from vas@mpeks.tomsk.su) Received: (from sudakov@localhost) by admin.sibptus.transneft.ru (8.14.9/8.14.9/Submit) id v23Fj9t8081778 for freebsd-net@freebsd.org; Fri, 3 Mar 2017 22:45:09 +0700 (KRAT) (envelope-from vas@mpeks.tomsk.su) X-Authentication-Warning: admin.sibptus.transneft.ru: sudakov set sender to vas@mpeks.tomsk.su using -f Date: Fri, 3 Mar 2017 22:45:09 +0700 From: Victor Sudakov To: freebsd-net@freebsd.org Subject: GSSAPI and racoon Message-ID: <20170303154509.GA81714@admin.sibptus.transneft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Organization: AO "Svyaztransneft", SibPTUS X-PGP-Key: http://www.dreamwidth.org/pubkey?user=victor_sudakov X-PGP-Fingerprint: 10E3 1171 1273 E007 C2E9 3532 0DA4 F259 9B5E C634 User-Agent: Mutt/1.7.1 (2016-10-04) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 15:45:15 -0000 Dear Colleagues, Is anyone running GSSAPI+IKE (racoon)? I have a Heimdal realm with a dozen FreeBSD hosts in it. I use GSSAPI for ssh access, also for CVS and SVN authentication. So I thought it would be a good idea to use Kerberos for IPSec as well, but the documentation is scarce, in fact only the very spartan /usr/local/share/doc/ipsec-tools/README.gssapi and /usr/local/share/examples/ipsec-tools/racoon.conf.sample-gssapi The questions are: 1. Where does racoon expect to find the keytab? 2. Does the ISAKMP+GSSAPI negotiation process involve racoon requesting Kerberos tickets from the KDC (in other words, which is the Kerberos server and which the Kerberos client)? Where does the client store the ticket? 3. Does it mean that any host with a valid keytab can negotiate a SA with any other host with a valid keytab? Like, if I have host/host1.example, host/host2.example and host/host3.example all runnning racoon, they can all form SAs? 4. How do I use GSSAPI for some hosts and a preshared key for other hosts? Can I fallback to a preshared key if GSSAPI fails? 5. Is there a good howto? :-) Thank you very much in advance for any input. -- Victor Sudakov, VAS4-RIPE, VAS47-RIPN AS43859 From owner-freebsd-net@freebsd.org Fri Mar 3 16:32:24 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4C01BCF6882 for ; Fri, 3 Mar 2017 16:32:24 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 26D9119EC for ; Fri, 3 Mar 2017 16:32:24 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id D62391A70F; Fri, 3 Mar 2017 16:32:23 +0000 (UTC) Date: Fri, 3 Mar 2017 16:32:23 +0000 To: freebsd-net@freebsd.org From: "smh (Steven Hartland)" Reply-to: D9847+325+deba385e191bfbb6@reviews.freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , Thread-Topic: D9847: Try to extract the RFC1048 data from PXE X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: YTlhODdhNGFiNzc3NzE3ZGRmMjFjNTkwOTA3IFi5mpc= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 16:32:24 -0000 c21oIHJlcXVlc3RlZCBjaGFuZ2VzIHRvIHRoaXMgcmV2aXNpb24uCnNtaCBhZGRlZCBpbmxpbmUg Y29tbWVudHMuClRoaXMgcmV2aXNpb24gbm93IHJlcXVpcmVzIGNoYW5nZXMgdG8gcHJvY2VlZC4K CklOTElORSBDT01NRU5UUwoKPiBweGUuYzoyOTYKPiArCj4gKwkJCWlmIChkaGNwX3RyeV9yZmMx MDQ4KGJvb3RwbGF5ZXIudmVuZG9yLmQsIEJPT1RQX0RIQ1BWRU5EKSA8IDAgKSB7Cj4gKwkJCQlp ZiAocHhlX2RlYnVnKQoKc3BhY2UgYmVmb3JlIHRoZSBicmFjZQoKUkVWSVNJT04gREVUQUlMCiAg aHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0Q5ODQ3CgpFTUFJTCBQUkVGRVJFTkNFUwogIGh0 dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9zZXR0aW5ncy9wYW5lbC9lbWFpbHByZWZlcmVuY2Vz LwoKVG86IGtjemVraXJkYSwgdHNvb21lLCBnbGViaXVzLCBmcmVlYnNkLW5ldC1saXN0LCAjbmV0 d29yaywgZ25uLCBvc2hvZ2JvLCBiYXB0LCBzbWgKQ2M6IHNtaAo= From owner-freebsd-net@freebsd.org Fri Mar 3 16:41:00 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6843ECF6B95 for ; Fri, 3 Mar 2017 16:41:00 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 3F5821035 for ; Fri, 3 Mar 2017 16:41:00 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id F24851ADA6; Fri, 3 Mar 2017 16:40:59 +0000 (UTC) Date: Fri, 3 Mar 2017 16:40:59 +0000 To: freebsd-net@freebsd.org From: "kczekirda (Kamil Czekirda)" Reply-to: D9847+325+deba385e191bfbb6@reviews.freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: <08d2ac771893cd01590e611c043d557b@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , Thread-Topic: D9847: Try to extract the RFC1048 data from PXE X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: YTlhODdhNGFiNzc3NzE3ZGRmMjFjNTkwOTA3IFi5nJs= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_08d2ac771893cd01590e611c043d557b" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 16:41:00 -0000 --b1_08d2ac771893cd01590e611c043d557b Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: base64 a2N6ZWtpcmRhIHVwZGF0ZWQgdGhpcyByZXZpc2lvbiB0byBEaWZmIDI1OTM2LgprY3pla2lyZGEg bWFya2VkIDIgaW5saW5lIGNvbW1lbnRzIGFzIGRvbmUuCgpDSEFOR0VTIFNJTkNFIExBU1QgVVBE QVRFCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0Q5ODQ3P3ZzPTI1OTMxJmlkPTI1OTM2 CgpSRVZJU0lPTiBERVRBSUwKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvRDk4NDcKCkFG RkVDVEVEIEZJTEVTCiAgL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmMKICAvdXNyL3NyYy9s aWIvbGlic3RhbmQvYm9vdHAuaAogIC91c3Ivc3JjL3N5cy9ib290L2kzODYvbGliaTM4Ni9weGUu YwoKRU1BSUwgUFJFRkVSRU5DRVMKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvc2V0dGlu Z3MvcGFuZWwvZW1haWxwcmVmZXJlbmNlcy8KClRvOiBrY3pla2lyZGEsIHRzb29tZSwgZ2xlYml1 cywgZnJlZWJzZC1uZXQtbGlzdCwgI25ldHdvcmssIGdubiwgc21oLCBiYXB0LCBvc2hvZ2JvCkNj OiBzbWgK --b1_08d2ac771893cd01590e611c043d557b Content-Type: text/x-patch; charset=utf-8; name="D9847.25936.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D9847.25936.patch" ZGlmZiAtLWdpdCBhLy91c3Ivc3JjL3N5cy9ib290L2kzODYvbGliaTM4Ni9weGUuYy5vbGQgYi8v dXNyL3NyYy9zeXMvYm9vdC9pMzg2L2xpYmkzODYvcHhlLmMKLS0tIGEvL3Vzci9zcmMvc3lzL2Jv b3QvaTM4Ni9saWJpMzg2L3B4ZS5jLm9sZAorKysgYi8vdXNyL3NyYy9zeXMvYm9vdC9pMzg2L2xp YmkzODYvcHhlLmMKQEAgLTEwMSw2ICsxMDEsNyBAQAogZXh0ZXJuIHVfaW50MTZfdAkJX19weGVu dnNlZzsKIGV4dGVybiB1X2ludDE2X3QJCV9fcHhlbnZvZmY7CiBleHRlcm4gdm9pZAkJCV9fcHhl bnZlbnRyeSh2b2lkKTsKK2V4dGVybiBzdHJ1Y3QgaW5fYWRkcgkJc2VydmlwOwogCiBzdHJ1Y3Qg bmV0aWZfZGlmIHB4ZV9pZnNbXSA9IHsKIC8qCWRpZl91bml0ICAgICAgICBkaWZfbnNlbCAgICAg ICAgZGlmX3N0YXRzICAgICAgIGRpZl9wcml2YXRlICAgICAqLwpAQCAtMjc2LDE3ICsyNzcsMzgg QEAKIAkJCX0KIAkJCWlmIChweGVfZGVidWcpCiAJCQkJcHJpbnRmKCJweGVfb3BlbjogbmV0aWZf b3BlbigpIHN1Y2NlZWRlZFxuIik7CisKKwkJCWlmIChzb2NrdG9kZXNjKHB4ZV9zb2NrKSA9PSBO VUxMKSB7CisJCQkJcHJpbnRmKCJweGVfb3BlbjogYmFkIHNvY2tldCAlZFxuIiwgcHhlX3NvY2sp OworCQkJCXJldHVybiAoRU5YSU8pOworCQkJfQorCiAJCX0KIAkJaWYgKHJvb3RpcC5zX2FkZHIg PT0gMCkgewogCQkJLyoKLQkJCSAqIERvIGEgYm9vdHAvZGhjcCByZXF1ZXN0IHRvIGZpbmQgb3V0 IHdoZXJlIG91cgorCQkJICogVHJ5IHRvIGV4dHJhY3QgdGhlIFJGQzEwNDggZGF0YSBmcm9tIFBY RS4KKwkJCSAqIElmIGZhaWwgZG8gYSBib290cC9kaGNwIHJlcXVlc3QgdG8gZmluZCBvdXQgd2hl cmUgb3VyCiAJCQkgKiBORlMvVEZUUCBzZXJ2ZXIgaXMuIEV2ZW4gaWYgd2UgZG9udCBnZXQgYmFj awogCQkJICogdGhlIHByb3BlciBpbmZvcm1hdGlvbiwgZmFsbCBiYWNrIHRvIHRoZSBzZXJ2ZXIK IAkJCSAqIHdoaWNoIGJyb3VnaHQgdXMgdG8gbGlmZSBhbmQgYSBkZWZhdWx0IHJvb3RwYXRoLgog CQkJICovCi0JCQlib290cChweGVfc29jaywgQk9PVFBfUFhFKTsKKworCQkJaWYgKGRoY3BfdHJ5 X3JmYzEwNDgoYm9vdHBsYXllci52ZW5kb3IuZCwgQk9PVFBfREhDUFZFTkQpIDwgMCkgeworCQkJ CWlmIChweGVfZGVidWcpCisJCQkJCXByaW50ZigicHhlX29wZW46IG5vIFJGQzEwNDggZGF0YSBp biBQWEUgQ2FjaGVcbiIpOworCQkJCWJvb3RwKHB4ZV9zb2NrLCBCT09UUF9QWEUpOworCQkJfSBl bHNlIGlmIChweGVfZGVidWcpIHsKKwkJCQlwcmludGYoInB4ZV9vcGVuOiBsb2FkZWQgUkZDMTA0 OCBkYXRhIGZyb20gUFhFIENhY2hlXG4iKTsKKwkJCX0KKwogCQkJaWYgKHJvb3RpcC5zX2FkZHIg PT0gMCkKIAkJCQlyb290aXAuc19hZGRyID0gYm9vdHBsYXllci5zaXA7CisJCQlpZiAoZ2F0ZWlw LnNfYWRkciA9PSAwKQorCQkJCWdhdGVpcC5zX2FkZHIgPSBib290cGxheWVyLmdpcDsKKwkJCWlm IChteWlwLnNfYWRkciA9PSAwKQorCQkJCW15aXAuc19hZGRyID0gYm9vdHBsYXllci55aXA7CisJ CQlpZiAoc2VydmlwLnNfYWRkciA9PSAwKQorCQkJCXNlcnZpcCA9IHJvb3RpcDsKIAogCQkJbmV0 cHJvdG8gPSBORVRfTkZTOwogCQkJaWYgKHRmdHBpcC5zX2FkZHIgIT0gMCkgewpAQCAtMzIzLDYg KzM0NSw5IEBACiAJCQlwcmludGYoInB4ZV9vcGVuOiBzZXJ2ZXIgYWRkcjogJXNcbiIsIGluZXRf bnRvYShyb290aXApKTsKIAkJCXByaW50ZigicHhlX29wZW46IHNlcnZlciBwYXRoOiAlc1xuIiwg cm9vdHBhdGgpOwogCQkJcHJpbnRmKCJweGVfb3BlbjogZ2F0ZXdheSBpcDogICVzXG4iLCBpbmV0 X250b2EoZ2F0ZWlwKSk7CisJCQlwcmludGYoInB4ZV9vcGVuOiBteSBpcDogICAgICAgJXNcbiIs IGluZXRfbnRvYShteWlwKSk7CisJCQlwcmludGYoInB4ZV9vcGVuOiBuZXRtYXNrOiAgICAgJXNc biIsIGludG9hKG5ldG1hc2spKTsKKwkJCXByaW50ZigicHhlX29wZW46IHNlcnZpcDogICAgICAl c1xuIiwgaW5ldF9udG9hKHNlcnZpcCkpOwogCiAJCQlpZiAobmV0cHJvdG8gPT0gTkVUX1RGVFAp IHsKIAkJCQlzZXRlbnYoImJvb3QudGZ0cHJvb3Quc2VydmVyIiwgaW5ldF9udG9hKHJvb3RpcCks IDEpOwpkaWZmIC0tZ2l0IGEvL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmMub2xkIGIvL3Vz ci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmMKLS0tIGEvL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jv b3RwLmMub2xkCisrKyBiLy91c3Ivc3JjL2xpYi9saWJzdGFuZC9ib290cC5jCkBAIC0zNDQsNiAr MzQ0LDE3IEBACiAJcmV0dXJuICgtMSk7CiB9CiAKK2ludAorZGhjcF90cnlfcmZjMTA0OCh1X2No YXIgKmNwLCB1X2ludCBsZW4pCit7CisKKwlleHBlY3RlZF9kaGNwbXNndHlwZSA9IERIQ1BBQ0s7 CisJaWYgKGJjbXAodm1fcmZjMTA0OCwgY3AsIHNpemVvZih2bV9yZmMxMDQ4KSkgPT0gMCkgewor CQlyZXR1cm4gKHZlbmRfcmZjMTA0OChjcCwgbGVuKSk7CisJfQorCXJldHVybiAoLTEpOworfQor CiBzdGF0aWMgaW50CiB2ZW5kX3JmYzEwNDgoY3AsIGxlbikKIAl1X2NoYXIgKmNwOwpkaWZmIC0t Z2l0IGEvL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmgub2xkIGIvL3Vzci9zcmMvbGliL2xp YnN0YW5kL2Jvb3RwLmgKLS0tIGEvL3Vzci9zcmMvbGliL2xpYnN0YW5kL2Jvb3RwLmgub2xkCisr KyBiLy91c3Ivc3JjL2xpYi9saWJzdGFuZC9ib290cC5oCkBAIC0yMiw2ICsyMiw4IEBACiAgKiAk RnJlZUJTRDogaGVhZC9saWIvbGlic3RhbmQvYm9vdHAuaCAzMDUxMjUgMjAxNi0wOC0zMSAxMzox Njo0MFogYmFwdCAkCiAgKi8KIAorI2lmbmRlZiBfQk9PVFBfSF8KKyNkZWZpbmUgX0JPT1RQX0hf CiAKIHN0cnVjdCBib290cCB7CiAJdW5zaWduZWQgY2hhcglicF9vcDsJCS8qIHBhY2tldCBvcGNv ZGUgdHlwZSAqLwpAQCAtMTQ1LDMgKzE0Nyw3IEBACiAKIC8qIHZfZmxhZ3MgdmFsdWVzICovCiAj ZGVmaW5lIFZGX1NNQVNLCTEJLyogU3VibmV0IG1hc2sgZmllbGQgY29udGFpbnMgdmFsaWQgZGF0 YSAqLworCitpbnQJZGhjcF90cnlfcmZjMTA0OCh1X2NoYXIgKmNwLCB1X2ludCBsZW4pOworCisj ZW5kaWYgLyogX0JPT1RQX0hfICovCgo= --b1_08d2ac771893cd01590e611c043d557b-- From owner-freebsd-net@freebsd.org Fri Mar 3 17:15:18 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DFAEBCF74F7 for ; Fri, 3 Mar 2017 17:15:18 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id ABF71136E for ; Fri, 3 Mar 2017 17:15:18 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id DB6381A9AC; Fri, 3 Mar 2017 17:15:17 +0000 (UTC) Date: Fri, 3 Mar 2017 17:15:17 +0000 To: freebsd-net@freebsd.org From: "wblock (Warren Block)" Reply-to: D9270+325+bbd470fd257eef1b@reviews.freebsd.org Subject: [Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE Message-ID: <7346fe88c61d036fb70a339f11417bbc@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , Thread-Topic: D9270: Add support for user-supplied Host-Uniq tag in Netgraph PPPoE X-Herald-Rules: <28>, <8> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: NTZkNjQzYWQxOGQ3MGJlZTIzOGZhZmQ4NGNmIFi5pKU= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 17:15:19 -0000 d2Jsb2NrIGFkZGVkIGlubGluZSBjb21tZW50cy4KCklOTElORSBDT01NRU5UUwoKPiBuZ19wcHBv ZS40OjEwOAo+ICtJdCBpcyBwb3NzaWJsZSB0byByZXF1ZXN0IGEgY29ubmVjdGlvbiB0byBhIHNw ZWNpZmljIGFjY2VzcyBjb25jZW50cmF0b3IsCj4gK2FuZC9vciBzZXQgYSBzcGVjaWZpYyBob3N0 IHVuaXEgdGFnLCByZXF1aXJlZCBieSBzb21lIEludGVybmV0IHByb3ZpZGVycywKPiArdXNpbmcg dGhlICJbQUMtTmFtZVxcXVtIb3N0LVVuaXF8XVNlcnZpY2UtTmFtZSIgc3ludGF4LgoKImhvc3Qg dW5pcSIgc2hvdWxkIGJlIGNhcGl0YWxpemVkIG9yIG90aGVyd2lzZSBpZGVudGlmaWVkIHdpdGgg bWFya3VwLiAgU2luY2UgaXQncyB1c2VkIGJlbG93LCBqdXN0IGJlIGNvbnNpc3RlbnQgYW5kIHNh eSBgSG9zdC1VbmlxYC4KCj4gbmdfcHBwb2UuNDoxMDkKPiArYW5kL29yIHNldCBhIHNwZWNpZmlj IGhvc3QgdW5pcSB0YWcsIHJlcXVpcmVkIGJ5IHNvbWUgSW50ZXJuZXQgcHJvdmlkZXJzLAo+ICt1 c2luZyB0aGUgIltBQy1OYW1lXFxdW0hvc3QtVW5pcXxdU2VydmljZS1OYW1lIiBzeW50YXguCj4g K1RvIHNldCBhIGJpbmFyeSBIb3N0LVVuaXEsIGl0IG11c3QgYmUgZW5jb2RlZCBhcyBhIGhleGFk ZWNpbWFsIGxvd2VyY2FzZQoKVGhlIGZvcm1hdHRpbmcgbG9va3Mgb2RkLCBidXQgaXMgYXBwYXJl bnRseSBtZWFudCB0byBzaG93IHRoYXQgdGhlcmUgaXMgYW4gb3B0aW9uYWwgQUMtTmFtZSBmb2xs b3dlZCBieSBkb3VibGUgYmFja3NsYXNoZXMgaWYgcHJlc2VudCwgZm9sbG93ZWQgYnkgYW4gb3B0 aW9uYWwgSG9zdC1VbmlxIHdpdGggYSB2ZXJ0aWNhbCBiYXIgaWYgcHJlc2VudC4gIERvZXMgdGhp cyByZW5kZXIgY29ycmVjdGx5PwoKPiBuZ19wcHBvZS40OjExMwo+ICsibXktdGFnIi4KPiAgQSBz ZXNzaW9uIHJlcXVlc3QgcGFja2V0IHdpbGwgYmUgYnJvYWRjYXN0ZWQgb24gdGhlIEV0aGVybmV0 Lgo+ICBUaGlzIGNvbW1hbmQgdXNlcyB0aGUKCihOb3QgeW91cnMsIEkga25vdy4pCnMvYnJvYWRj YXN0ZWQvYnJvYWRjYXN0LwoKPiBuZ19wcHBvZS40OjExNwo+ICBzdHJ1Y3R1cmUgc2hvd24gYmVs b3cuCj4gK0ZvciBleGFtcGxlLCB0aGUgZm9sbG93aW5nIGluaXQgZGF0YSBhcmd1bWVudCBjYW4g YmUgdXNlZCB0bwo+ICtjb25uZWN0IHRvICJteS1pc3AiIHNlcnZpY2Ugd2l0aCAibXktaG9zdCIg dW5pcSB0YWcsIGFjY2VwdGluZyBvbmx5CgpzL3RoZSBmb2xsb3dpbmcvdGhpcy8KCj4gbmdfcHBw b2UuNDoxMTgKPiArRm9yIGV4YW1wbGUsIHRoZSBmb2xsb3dpbmcgaW5pdCBkYXRhIGFyZ3VtZW50 IGNhbiBiZSB1c2VkIHRvCj4gK2Nvbm5lY3QgdG8gIm15LWlzcCIgc2VydmljZSB3aXRoICJteS1o b3N0IiB1bmlxIHRhZywgYWNjZXB0aW5nIG9ubHkKPiArInJlbW90ZS1hYyIgYXMgYWNjZXNzIGNv bmNlbnRyYXRvcjoKCk1hcmt1cCBjb3VsZCBzaG93IHRoZXNlIHdpdGggb3V0LW9mLWJhbmQgaGln aGxpZ2h0aW5nIHJhdGhlciB0aGFuIHF1b3Rlcy4gIEJ1dCBJJ20gbm90IHN1cmUgd2hpY2ggbWFy a3VwIHRvIHVzZS4KCj4gbmdfcHBwb2UuNDoyNzQKPiArYSBIVVJMIHRhZy4KPiArVGhlIGFyZ3Vt ZW50IGdpdmVuIGlzIHRoZSBVUkwgdGhhdCB3aWxsIGJlIGRlbGl2ZXJlZCB0byB0aGUgY2xpZW50 Ogo+ICsuQmQgLWxpdGVyYWwgLW9mZnNldCBpbmRlbnQKClJld29yZGluZzoKCiAgVGhlIGFyZ3Vt ZW50IGlzIHRoZSBVUkwgdG8gYmUgZGVsaXZlcmVkIHRvIHRoZSBjbGllbnQ6Cgo+IG5nX3BwcG9l LjQ6MjgxCj4gK2EgTU9UTSB0YWcuCj4gK1RoZSBhcmd1bWVudCBnaXZlbiBpcyB0aGUgbWVzc2Fn ZSB0aGF0IHdpbGwgYmUgZGVsaXZlcmVkIHRvIHRoZSBjbGllbnQ6Cj4gKy5CZCAtbGl0ZXJhbCAt b2Zmc2V0IGluZGVudAoKVGhlIGFyZ3VtZW50IGlzIHRoZSBtZXNzYWdlIHRvIGJlIGRlbGl2ZXJl ZCB0byB0aGUgY2xpZW50OgoKPiBuZ19wcHBvZS40OjI5Mgo+ICtUaGlzIGNvbW1hbmQgaXMgc2Vu dCB0byB0aGUgbm9kZSB0aGF0IHN0YXJ0ZWQgdGhpcyBzZXNzaW9uIHdoZW4gYSBQQURNCj4gK21l c3NhZ2Ugd2l0aCBhIEhVUkwgdGFnIGlzIHJlY2VpdmVkLCBhbmQgY29udGFpbnMgYSBVUkwgdGhh dCB0aGUgSG9zdCBtYXkKPiArcGFzcyB0byBhIHdlYiBicm93c2VyIGZvciBwcmVzZW50YXRpb24g dG8gdGhlIHVzZXIuCgoibWF5IiB1c3VhbGx5IGltcGxpZXMgInlvdSBoYXZlIHBlcm1pc3Npb24i LCB3aGlsZSAiY2FuIiBtZWFucyAiaXQgaXMgcG9zc2libGUiLiAgU286CgogIG1lc3NhZ2Ugd2l0 aCBhIEhVUkwgdGFnIGlzIHJlY2VpdmVkLCBhbmQgY29udGFpbnMgYSBVUkwgd2hpY2ggdGhlIEhv c3QgY2FuCgpTaG91bGQgSG9zdCBiZSBjYXBpdGFsaXplZD8KCj4gbmdfcHBwb2UuNDoyOTcKPiAr bWVzc2FnZSB3aXRoIGEgTU9UTSB0YWcgaXMgcmVjZWl2ZWQsIGFuZCBjb250YWlucyBhIE1lc3Nh Z2UgT2YgVGhlCj4gK01pbnV0ZSB0aGF0IHRoZSBIb3N0IG1heSBkaXNwbGF5IHRvIHRoZSB1c2Vy Lgo+ICsuRWwKCkFzIGFib3ZlOgoKICBNaW51dGUgd2hpY2ggdGhlIEhvc3QgY2FuIGRpc3BsYXkg dG8gdGhlIHVzZXIuCgpSRVBPU0lUT1JZCiAgclMgRnJlZUJTRCBzcmMgcmVwb3NpdG9yeQoKUkVW SVNJT04gREVUQUlMCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0Q5MjcwCgpFTUFJTCBQ UkVGRVJFTkNFUwogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9zZXR0aW5ncy9wYW5lbC9l bWFpbHByZWZlcmVuY2VzLwoKVG86IGFsZSwgI21hbnBhZ2VzLCBhZHJpYW4sICNuZXR3b3JrLCBq dWxpYW4sIG1hdgpDYzogd2Jsb2NrLCBtYXYsIHBvb2xyb29tX2dtYWlsLmNvbSwgbWFuZHJlZSwg aW1wLCBmcmVlYnNkLW5ldC1saXN0Cg== From owner-freebsd-net@freebsd.org Fri Mar 3 22:13:23 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CD10CCF7C00 for ; Fri, 3 Mar 2017 22:13:23 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 9C0C51833 for ; Fri, 3 Mar 2017 22:13:23 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id C950E1B234; Fri, 3 Mar 2017 22:13:22 +0000 (UTC) Date: Fri, 3 Mar 2017 22:13:22 +0000 To: freebsd-net@freebsd.org From: "ale (Alex Dupre)" Reply-to: D9270+325+bbd470fd257eef1b@reviews.freebsd.org Subject: [Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE Message-ID: <566fae55397ff557c1feb73520a9e727@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: Thread-Topic: D9270: Add support for user-supplied Host-Uniq tag in Netgraph PPPoE X-Herald-Rules: <28>, <8> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: NTZkNjQzYWQxOGQ3MGJlZTIzOGZhZmQ4NGNmIFi56oI= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 22:13:23 -0000 YWxlIGFkZGVkIGEgY29tbWVudC4KCgogIFRoYW5rcyBmb3IgeW91ciBjb21tZW50LCBJJ2xsIGlt cHJvdmUgdGhlIG1hbiBwYWdlLgoKSU5MSU5FIENPTU1FTlRTCgo+IHdibG9jayB3cm90ZSBpbiBu Z19wcHBvZS40OjEwOAo+ICJob3N0IHVuaXEiIHNob3VsZCBiZSBjYXBpdGFsaXplZCBvciBvdGhl cndpc2UgaWRlbnRpZmllZCB3aXRoIG1hcmt1cC4gIFNpbmNlIGl0J3MgdXNlZCBiZWxvdywganVz dCBiZSBjb25zaXN0ZW50IGFuZCBzYXkgYEhvc3QtVW5pcWAuCgpBcmUgeW91IGZpbmUgd2l0aCBs b3dlciBjYXNlICJhY2Nlc3MgY29uY2VudHJhdG9yIj8KCj4gd2Jsb2NrIHdyb3RlIGluIG5nX3Bw cG9lLjQ6MTA5Cj4gVGhlIGZvcm1hdHRpbmcgbG9va3Mgb2RkLCBidXQgaXMgYXBwYXJlbnRseSBt ZWFudCB0byBzaG93IHRoYXQgdGhlcmUgaXMgYW4gb3B0aW9uYWwgQUMtTmFtZSBmb2xsb3dlZCBi eSBkb3VibGUgYmFja3NsYXNoZXMgaWYgcHJlc2VudCwgZm9sbG93ZWQgYnkgYW4gb3B0aW9uYWwg SG9zdC1VbmlxIHdpdGggYSB2ZXJ0aWNhbCBiYXIgaWYgcHJlc2VudC4gIERvZXMgdGhpcyByZW5k ZXIgY29ycmVjdGx5PwoKVGhlIGRvdWJsZSBiYWNrc2xhc2ggaXMganVzdCBmb3IgbWFuIHBhZ2Ug ZXNjYXBpbmcsIGl0J3MgYWN0dWFsbHkgYSBzaW5nbGUgYmFja3NsYXNoLiBCb3RoIEFDLU5hbWUg YW5kIEhvc3QtVW5pcSBhcmUgb3B0aW9uYWwsIHRoYXQncyB0aGUgcmVhc29uIGZvciBkaWZmZXJl bnQgc2VwYXJhdG9ycy4KCj4gd2Jsb2NrIHdyb3RlIGluIG5nX3BwcG9lLjQ6MTE4Cj4gTWFya3Vw IGNvdWxkIHNob3cgdGhlc2Ugd2l0aCBvdXQtb2YtYmFuZCBoaWdobGlnaHRpbmcgcmF0aGVyIHRo YW4gcXVvdGVzLiAgQnV0IEknbSBub3Qgc3VyZSB3aGljaCBtYXJrdXAgdG8gdXNlLgoKSSdsbCBt YWtlIGEgZmV3IHRyaWVzLCAuU3EgbWlnaHQgYmUgYSBnb29kIGNob2ljZQoKPiB3YmxvY2sgd3Jv dGUgaW4gbmdfcHBwb2UuNDoyOTIKPiAibWF5IiB1c3VhbGx5IGltcGxpZXMgInlvdSBoYXZlIHBl cm1pc3Npb24iLCB3aGlsZSAiY2FuIiBtZWFucyAiaXQgaXMgcG9zc2libGUiLiAgU286Cj4gCj4g ICBtZXNzYWdlIHdpdGggYSBIVVJMIHRhZyBpcyByZWNlaXZlZCwgYW5kIGNvbnRhaW5zIGEgVVJM IHdoaWNoIHRoZSBIb3N0IGNhbgo+IAo+IFNob3VsZCBIb3N0IGJlIGNhcGl0YWxpemVkPwoKSXQn cyBNQVkgaW4gUkZDIDIxMTkgbWVhbmluZywgYnV0IEknbGwgY2hhbmdlIGl0IHRvICJjYW4iLgoK SSBjYXBpdGFsaXplZCB0aGUgSG9zdCB0byBtYWtlIGl0IGNsZWFyZXIgd2hhdCdzIHRoZSBtZWFu aW5nIG9mIHRoZSBIIGluIEhVUkwsIGJ1dCBwcm9iYWJseSBpcyBub3QgbmVlZGVkLgoKUkVQT1NJ VE9SWQogIHJTIEZyZWVCU0Qgc3JjIHJlcG9zaXRvcnkKClJFVklTSU9OIERFVEFJTAogIGh0dHBz Oi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9EOTI3MAoKRU1BSUwgUFJFRkVSRU5DRVMKICBodHRwczov L3Jldmlld3MuZnJlZWJzZC5vcmcvc2V0dGluZ3MvcGFuZWwvZW1haWxwcmVmZXJlbmNlcy8KClRv OiBhbGUsICNtYW5wYWdlcywgYWRyaWFuLCAjbmV0d29yaywganVsaWFuLCBtYXYKQ2M6IHdibG9j aywgbWF2LCBwb29scm9vbV9nbWFpbC5jb20sIG1hbmRyZWUsIGltcCwgZnJlZWJzZC1uZXQtbGlz dAo= From owner-freebsd-net@freebsd.org Sat Mar 4 03:55:18 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CADA5CF85ED for ; Sat, 4 Mar 2017 03:55:18 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id A37DC15A8 for ; Sat, 4 Mar 2017 03:55:18 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 635D71A7F1; Sat, 4 Mar 2017 03:55:18 +0000 (UTC) Date: Sat, 4 Mar 2017 03:55:18 +0000 To: freebsd-net@freebsd.org From: "smh (Steven Hartland)" Reply-to: D9847+325+deba385e191bfbb6@reviews.freebsd.org Subject: [Differential] D9847: Try to extract the RFC1048 data from PXE Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , Thread-Topic: D9847: Try to extract the RFC1048 data from PXE X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: YTlhODdhNGFiNzc3NzE3ZGRmMjFjNTkwOTA3IFi6OqY= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Mar 2017 03:55:18 -0000 c21oIGFjY2VwdGVkIHRoaXMgcmV2aXNpb24uClRoaXMgcmV2aXNpb24gaGFzIGEgcG9zaXRpdmUg cmV2aWV3LgoKUkVWSVNJT04gREVUQUlMCiAgaHR0cHM6Ly9yZXZpZXdzLmZyZWVic2Qub3JnL0Q5 ODQ3CgpFTUFJTCBQUkVGRVJFTkNFUwogIGh0dHBzOi8vcmV2aWV3cy5mcmVlYnNkLm9yZy9zZXR0 aW5ncy9wYW5lbC9lbWFpbHByZWZlcmVuY2VzLwoKVG86IGtjemVraXJkYSwgdHNvb21lLCBnbGVi aXVzLCBmcmVlYnNkLW5ldC1saXN0LCAjbmV0d29yaywgZ25uLCBiYXB0LCBvc2hvZ2JvLCBzbWgK Q2M6IHNtaAo= From owner-freebsd-net@freebsd.org Sat Mar 4 13:04:31 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D294DCF9609 for ; Sat, 4 Mar 2017 13:04:31 +0000 (UTC) (envelope-from vas@mpeks.tomsk.su) Received: from relay2.tomsk.ru (mail.sibptus.tomsk.ru [212.73.124.5]) by mx1.freebsd.org (Postfix) with ESMTP id 101861EA6; Sat, 4 Mar 2017 13:04:30 +0000 (UTC) (envelope-from vas@mpeks.tomsk.su) X-Virus-Scanned: by clamd daemon 0.98.5_1 for FreeBSD at relay2.tomsk.ru Received: from [212.73.125.240] (HELO admin.sibptus.transneft.ru) by relay2.tomsk.ru (CommuniGate Pro SMTP 5.1.16) with ESMTPS id 39628563; Sat, 04 Mar 2017 19:00:00 +0600 Received: from admin.sibptus.transneft.ru (sudakov@localhost [127.0.0.1]) by admin.sibptus.transneft.ru (8.14.9/8.14.9) with ESMTP id v24D4SWk090857; Sat, 4 Mar 2017 20:04:28 +0700 (KRAT) (envelope-from vas@mpeks.tomsk.su) Received: (from sudakov@localhost) by admin.sibptus.transneft.ru (8.14.9/8.14.9/Submit) id v24D4QKl090856; Sat, 4 Mar 2017 20:04:26 +0700 (KRAT) (envelope-from vas@mpeks.tomsk.su) X-Authentication-Warning: admin.sibptus.transneft.ru: sudakov set sender to vas@mpeks.tomsk.su using -f Date: Sat, 4 Mar 2017 20:04:26 +0700 From: Victor Sudakov To: freebsd-net@freebsd.org Cc: vanhu@FreeBSD.org Subject: Re: GSSAPI and racoon Message-ID: <20170304130426.GA90832@admin.sibptus.transneft.ru> References: <20170303154509.GA81714@admin.sibptus.transneft.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170303154509.GA81714@admin.sibptus.transneft.ru> Organization: AO "Svyaztransneft", SibPTUS X-PGP-Key: http://www.dreamwidth.org/pubkey?user=victor_sudakov X-PGP-Fingerprint: 10E3 1171 1273 E007 C2E9 3532 0DA4 F259 9B5E C634 User-Agent: Mutt/1.7.1 (2016-10-04) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Mar 2017 13:04:31 -0000 Victor Sudakov wrote: > > Is anyone running GSSAPI+IKE (racoon)? > > I have a Heimdal realm with a dozen FreeBSD hosts in it. I use GSSAPI > for ssh access, also for CVS and SVN authentication. So I thought it > would be a good idea to use Kerberos for IPSec as well, but the > documentation is scarce, in fact only the very spartan > /usr/local/share/doc/ipsec-tools/README.gssapi and > /usr/local/share/examples/ipsec-tools/racoon.conf.sample-gssapi It's notable that I cannot even compile racoon with GSSAPI enabled: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217531 I guess nobody cares. -- Victor Sudakov, VAS4-RIPE, VAS47-RIPN AS43859 From owner-freebsd-net@freebsd.org Sat Mar 4 16:50:56 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C654ACF937D for ; Sat, 4 Mar 2017 16:50:56 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 8F7C611B7 for ; Sat, 4 Mar 2017 16:50:56 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 1908C1A5C5; Sat, 4 Mar 2017 16:50:56 +0000 (UTC) Date: Sat, 4 Mar 2017 16:50:56 +0000 To: freebsd-net@freebsd.org From: "ale (Alex Dupre)" Reply-to: D9270+325+bbd470fd257eef1b@reviews.freebsd.org Subject: [Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE Message-ID: <475d2439918cee32d5900abe663b7f0f@localhost.localdomain> X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , , Thread-Topic: D9270: Add support for user-supplied Host-Uniq tag in Netgraph PPPoE X-Herald-Rules: <28>, <8> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: NTZkNjQzYWQxOGQ3MGJlZTIzOGZhZmQ4NGNmIFi68HA= MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_475d2439918cee32d5900abe663b7f0f" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Mar 2017 16:50:56 -0000 --b1_475d2439918cee32d5900abe663b7f0f Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: base64 YWxlIHVwZGF0ZWQgdGhpcyByZXZpc2lvbiB0byBEaWZmIDI1OTc3LgphbGUgYWRkZWQgYSBjb21t ZW50LgpUaGlzIHJldmlzaW9uIG5vdyByZXF1aXJlcyByZXZpZXcgdG8gcHJvY2VlZC4KCgogIE1h biBwYWdlIGltcHJvdmVtZW50cwoKUkVQT1NJVE9SWQogIHJTIEZyZWVCU0Qgc3JjIHJlcG9zaXRv cnkKCkNIQU5HRVMgU0lOQ0UgTEFTVCBVUERBVEUKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5v cmcvRDkyNzA/dnM9MjU4NDkmaWQ9MjU5NzcKClJFVklTSU9OIERFVEFJTAogIGh0dHBzOi8vcmV2 aWV3cy5mcmVlYnNkLm9yZy9EOTI3MAoKQUZGRUNURUQgRklMRVMKICBzaGFyZS9tYW4vbWFuNC9u Z19wcHBvZS40CiAgc3lzL25ldGdyYXBoL25nX3BwcG9lLmMKICBzeXMvbmV0Z3JhcGgvbmdfcHBw b2UuaAoKRU1BSUwgUFJFRkVSRU5DRVMKICBodHRwczovL3Jldmlld3MuZnJlZWJzZC5vcmcvc2V0 dGluZ3MvcGFuZWwvZW1haWxwcmVmZXJlbmNlcy8KClRvOiBhbGUsIGp1bGlhbiwgI21hbnBhZ2Vz LCBtYXYsICNuZXR3b3JrLCBhZHJpYW4KQ2M6IHdibG9jaywgbWF2LCBwb29scm9vbV9nbWFpbC5j b20sIG1hbmRyZWUsIGltcCwgZnJlZWJzZC1uZXQtbGlzdAo= --b1_475d2439918cee32d5900abe663b7f0f Content-Type: text/x-patch; charset=utf-8; name="D9270.25977.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D9270.25977.patch" ZGlmZiAtLWdpdCBhL3N5cy9uZXRncmFwaC9uZ19wcHBvZS5oIGIvc3lzL25ldGdyYXBoL25nX3Bw cG9lLmgKLS0tIGEvc3lzL25ldGdyYXBoL25nX3BwcG9lLmgKKysrIGIvc3lzL25ldGdyYXBoL25n X3BwcG9lLmgKQEAgLTUyLDggKzUyLDEwIEBACiAKICNkZWZpbmUgTkdNX1BQUE9FX0NPT0tJRQkJ MTA4OTg5MzA3MgogI2RlZmluZSBOR01fUFBQT0VfU0VUTUFYUF9DT09LSUUJMTQ0MTYyNDMyMgor I2RlZmluZSBOR01fUFBQT0VfUEFETV9DT09LSUUJCTE0ODg0MDU4MjIKIAogI2RlZmluZQlQUFBP RV9TRVJWSUNFX05BTUVfU0laRQkJNjQgLyogZm9yIG5vdyAqLworI2RlZmluZQlQUFBPRV9QQURN X1ZBTFVFX1NJWkUJCTEyOCAvKiBmb3Igbm93ICovCiAKIC8qIEhvb2sgbmFtZXMgKi8KICNkZWZp bmUgTkdfUFBQT0VfSE9PS19FVEhFUk5FVAkiZXRoZXJuZXQiCkBAIC04NCw3ICs4NiwxMSBAQAog CU5HTV9QUFBPRV9TRVRNT0RFICA9IDEyLCAvKiBzZXQgdG8gc3RhbmRhcmQgb3IgY29tcGF0IG1v ZGVzICovCiAJTkdNX1BQUE9FX0dFVE1PREUgID0gMTMsIC8qIHNlZSBjdXJyZW50IG1vZGUgKi8K IAlOR01fUFBQT0VfU0VURU5BRERSID0gMTQsIC8qIHNldCBFdGhlcm5ldCBhZGRyZXNzICovCi0J TkdNX1BQUE9FX1NFVE1BWFAgID0gMTUgLyogU2V0IFBQUC1NYXgtUGF5bG9hZCB2YWx1ZSAqLwor CU5HTV9QUFBPRV9TRVRNQVhQICAgPSAxNSwgLyogU2V0IFBQUC1NYXgtUGF5bG9hZCB2YWx1ZSAq LworCU5HTV9QUFBPRV9TRU5EX0hVUkwgPSAxNiwgLyogU2VuZCBQQURNIEhVUkwgbWVzc2FnZSAq LworCU5HTV9QUFBPRV9IVVJMICAgICAgPSAxNywgLyogSFVSTCBmb3IgaW5mb3JtYXRpb25hbCBw dXJwb3NlcyAqLworCU5HTV9QUFBPRV9TRU5EX01PVE0gPSAxOCwgLyogU2VuZCBQQURNIE1PVE0g bWVzc2FnZSAqLworCU5HTV9QUFBPRV9NT1RNICAgICAgPSAxOSAgLyogTU9UTSBmb3IgaW5mb3Jt YXRpb25hbCBwdXJwb3NlcyAqLwogfTsKIAogLyoqKioqKioqKioqKioqKioqKioqKioqCkBAIC0x NTcsNiArMTYzLDEzIEBACiAJdWludDE2X3QJZGF0YTsKIH07CiAKKy8qCisgKiBUaGlzIHN0cnVj dHVyZSBpcyB1c2VkIHRvIHNlbmQgUEFETSBtZXNzYWdlcyBmcm9tIHNlcnZlciB0byBjbGllbnQu CisgKi8KK3N0cnVjdCBuZ3BwcG9lX3BhZG0geworCWNoYXIJbXNnW1BQUE9FX1BBRE1fVkFMVUVf U0laRV07Cit9OworCiAvKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioKICAqIENvbnN0YW50cyBhbmQgZGVmaW5pdGlvbnMg c3BlY2lmaWMgdG8gcHBwb2UKICAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKi8KQEAgLTE3MSw2ICsxODQsNyBAQAogI2Rl ZmluZSBQQURSX0NPREUJMHgxOQogI2RlZmluZSBQQURTX0NPREUJMHg2NQogI2RlZmluZSBQQURU X0NPREUJMHhhNworI2RlZmluZSBQQURNX0NPREUJMHhkMwogCiAvKiBUYWcgaWRlbnRpZmllcnMg Ki8KICNpZiBCWVRFX09SREVSID09IEJJR19FTkRJQU4KQEAgLTE4MSw2ICsxOTUsOCBAQAogI2Rl ZmluZSBQVFRfQUNfQ09PS0lFCSgweDAxMDQpCiAjZGVmaW5lIFBUVF9WRU5ET1IgCSgweDAxMDUp CiAjZGVmaW5lIFBUVF9SRUxBWV9TSUQJKDB4MDExMCkKKyNkZWZpbmUgUFRUX0hVUkwJKDB4MDEx MSkJLyogUFBQb0UgRXh0ZW5zaW9ucyAoQ0FSUkVMKSAqLworI2RlZmluZSBQVFRfTU9UTQkoMHgw MTEyKQkvKiBQUFBvRSBFeHRlbnNpb25zIChDQVJSRUwpICovCiAjZGVmaW5lCVBUVF9NQVhfUEFZ TAkoMHgwMTIwKQkvKiBQUFAtTWF4LVBheWxvYWQgKFJGQzQ2MzgpICovCiAjZGVmaW5lIFBUVF9T UlZfRVJSICAgICAoMHgwMjAxKQogI2RlZmluZSBQVFRfU1lTX0VSUiAgCSgweDAyMDIpCkBAIC0x OTgsNiArMjE0LDggQEAKICNkZWZpbmUgUFRUX0FDX0NPT0tJRQkoMHgwNDAxKQogI2RlZmluZSBQ VFRfVkVORE9SIAkoMHgwNTAxKQogI2RlZmluZSBQVFRfUkVMQVlfU0lECSgweDEwMDEpCisjZGVm aW5lIFBUVF9IVVJMCSgweDExMDEpCS8qIFBQUG9FIEV4dGVuc2lvbnMgKENBUlJFTCkgKi8KKyNk ZWZpbmUgUFRUX01PVE0JKDB4MTIwMSkJLyogUFBQb0UgRXh0ZW5zaW9ucyAoQ0FSUkVMKSAqLwog I2RlZmluZQlQVFRfTUFYX1BBWUwJKDB4MjAwMSkJLyogUFBQLU1heC1QYXlsb2FkIChSRkM0NjM4 KSAqLwogI2RlZmluZSBQVFRfU1JWX0VSUiAgICAgKDB4MDEwMikKICNkZWZpbmUgUFRUX1NZU19F UlIgIAkoMHgwMjAyKQpkaWZmIC0tZ2l0IGEvc3lzL25ldGdyYXBoL25nX3BwcG9lLmMgYi9zeXMv bmV0Z3JhcGgvbmdfcHBwb2UuYwotLS0gYS9zeXMvbmV0Z3JhcGgvbmdfcHBwb2UuYworKysgYi9z eXMvbmV0Z3JhcGgvbmdfcHBwb2UuYwpAQCAtMTc1LDYgKzE3NSwyMCBAQAogCSAgJm5nX3BhcnNl X3VpbnQxNl90eXBlLAogCSAgTlVMTAogCX0sCisgICAgICAgIHsKKwkgIE5HTV9QUFBPRV9DT09L SUUsCisJICBOR01fUFBQT0VfU0VORF9IVVJMLAorCSAgInNlbmRfaHVybCIsCisJICAmbmdwcHBv ZV9pbml0X2RhdGFfc3RhdGVfdHlwZSwKKwkgIE5VTEwKKyAgICAgICAgfSwKKyAgICAgICAgewor CSAgTkdNX1BQUE9FX0NPT0tJRSwKKwkgIE5HTV9QUFBPRV9TRU5EX01PVE0sCisJICAic2VuZF9t b3RtIiwKKwkgICZuZ3BwcG9lX2luaXRfZGF0YV9zdGF0ZV90eXBlLAorCSAgTlVMTAorICAgICAg ICB9LAogCXsgMCB9CiB9OwogCkBAIC0yMjYsOSArMjQwLDExIEBACiAJY29uc3Qgc3RydWN0IHBw cG9lX3RhZwkqdGFnc1tOVU1UQUdTXTsKIAl1X2ludAkJCXNlcnZpY2VfbGVuOwogCXVfaW50CQkJ YWNfbmFtZV9sZW47CisJdV9pbnQJCQlob3N0X3VuaXFfbGVuOwogCiAJc3RydWN0IGRhdGF0YWcJ CXNlcnZpY2U7CiAJc3RydWN0IGRhdGF0YWcJCWFjX25hbWU7CisJc3RydWN0IGRhdGF0YWcJCWhv c3RfdW5pcTsKIH07CiB0eXBlZGVmIHN0cnVjdCBzZXNzX25lZyAqbmVncDsKIApAQCAtNTg5LDE4 ICs2MDUsNDAgQEAKIHBwcG9lX2ZpbmR1bmlxKG5vZGVfcCBub2RlLCBjb25zdCBzdHJ1Y3QgcHBw b2VfdGFnICp0YWcpCiB7CiAJaG9va19wCWhvb2sgPSBOVUxMOwotCXVuaW9uIHVuaXEgdW5pcTsK KwlzZXNzcAlzcDsKIAotCWJjb3B5KHRhZyArIDEsIHVuaXEuYnl0ZXMsIHNpemVvZih2b2lkICop KTsKIAkvKiBDeWNsZSB0aHJvdWdoIGFsbCBrbm93biBob29rcy4gKi8KIAlMSVNUX0ZPUkVBQ0go aG9vaywgJm5vZGUtPm5kX2hvb2tzLCBoa19ob29rcykgewogCQkvKiBTa2lwIGFueSBub25zZXNz aW9uIGhvb2suICovCiAJCWlmIChOR19IT09LX1BSSVZBVEUoaG9vaykgPT0gTlVMTCkKIAkJCWNv bnRpbnVlOwotCQlpZiAodW5pcS5wb2ludGVyID09IE5HX0hPT0tfUFJJVkFURShob29rKSkKKwkJ c3AgPSBOR19IT09LX1BSSVZBVEUoaG9vayk7CisJCWlmIChzcC0+bmVnLT5ob3N0X3VuaXFfbGVu ID09IG50b2hzKHRhZy0+dGFnX2xlbikgJiYKKwkJICAgIGJjbXAoc3AtPm5lZy0+aG9zdF91bmlx LmRhdGEsIChjb25zdCBjaGFyICopKHRhZyArIDEpLAorCQkgICAgIHNwLT5uZWctPmhvc3RfdW5p cV9sZW4pID09IDApCiAJCQlicmVhazsKIAl9Ci0JQ1RSMyhLVFJfTkVULCAiJTIwczogbWF0Y2hl ZCAlcCBmb3IgJXAiLCBfX2Z1bmNfXywgaG9vaywgdW5pcS5wb2ludGVyKTsKKwlDVFIzKEtUUl9O RVQsICIlMjBzOiBtYXRjaGVkICVwIGZvciAlcCIsIF9fZnVuY19fLCBob29rLCBzcCk7CisKKwly ZXR1cm4gKGhvb2spOworfQorCitzdGF0aWMgaG9va19wCitwcHBvZV9maW5kY29va2llKG5vZGVf cCBub2RlLCBjb25zdCBzdHJ1Y3QgcHBwb2VfdGFnICp0YWcpCit7CisJaG9va19wCWhvb2sgPSBO VUxMOworCXVuaW9uIHVuaXEgY29va2llOworCisJYmNvcHkodGFnICsgMSwgY29va2llLmJ5dGVz LCBzaXplb2Yodm9pZCAqKSk7CisJLyogQ3ljbGUgdGhyb3VnaCBhbGwga25vd24gaG9va3MuICov CisJTElTVF9GT1JFQUNIKGhvb2ssICZub2RlLT5uZF9ob29rcywgaGtfaG9va3MpIHsKKwkJLyog U2tpcCBhbnkgbm9uc2Vzc2lvbiBob29rLiAqLworCQlpZiAoTkdfSE9PS19QUklWQVRFKGhvb2sp ID09IE5VTEwpCisJCQljb250aW51ZTsKKwkJaWYgKGNvb2tpZS5wb2ludGVyID09IE5HX0hPT0tf UFJJVkFURShob29rKSkKKwkJCWJyZWFrOworCX0KKwlDVFIzKEtUUl9ORVQsICIlMjBzOiBtYXRj aGVkICVwIGZvciAlcCIsIF9fZnVuY19fLCBob29rLCBjb29raWUucG9pbnRlcik7CiAKIAlyZXR1 cm4gKGhvb2spOwogfQpAQCAtNzQ0LDE3ICs3ODIsMjkgQEAKIAkJY2FzZSBOR01fUFBQT0VfTElT VEVOOgogCQljYXNlIE5HTV9QUFBPRV9PRkZFUjoKIAkJY2FzZSBOR01fUFBQT0VfU0VSVklDRToK KwkJY2FzZSBOR01fUFBQT0VfU0VORF9IVVJMOgorCQljYXNlIE5HTV9QUFBPRV9TRU5EX01PVE06 CiAJCQlvdXJtc2cgPSAoc3RydWN0IG5ncHBwb2VfaW5pdF9kYXRhICopbXNnLT5kYXRhOwogCQkJ aWYgKG1zZy0+aGVhZGVyLmFyZ2xlbiA8IHNpemVvZigqb3VybXNnKSkgewogCQkJCWxvZyhMT0df RVJSLCAibmdfcHBwb2VbJXhdOiBpbml0IGRhdGEgdG9vICIKIAkJCQkgICAgInNtYWxsXG4iLCBu b2RlLT5uZF9JRCk7CiAJCQkJTEVBVkUoRU1TR1NJWkUpOwogCQkJfQotCQkJaWYgKG1zZy0+aGVh ZGVyLmFyZ2xlbiAtIHNpemVvZigqb3VybXNnKSA+Ci0JCQkgICAgUFBQT0VfU0VSVklDRV9OQU1F X1NJWkUpIHsKLQkJCQlsb2coTE9HX0VSUiwgIm5nX3BwcG9lWyV4XTogc2VydmljZSBuYW1lICIK LQkJCQkgICAgInRvbyBiaWdcbiIsIG5vZGUtPm5kX0lEKTsKLQkJCQlMRUFWRShFTVNHU0laRSk7 CisJCQlpZiAobXNnLT5oZWFkZXIuY21kID09IE5HTV9QUFBPRV9TRU5EX0hVUkwgfHwKKwkJCSAg ICBtc2ctPmhlYWRlci5jbWQgPT0gTkdNX1BQUE9FX1NFTkRfTU9UTSkgeworCQkJCWlmIChtc2ct PmhlYWRlci5hcmdsZW4gLSBzaXplb2YoKm91cm1zZykgPgorCQkJCSAgICBQUFBPRV9QQURNX1ZB TFVFX1NJWkUpIHsKKwkJCQkJbG9nKExPR19FUlIsICJuZ19wcHBvZVsleF06IG1lc3NhZ2UgIgor CQkJCQkgICAgInRvbyBiaWdcbiIsIG5vZGUtPm5kX0lEKTsKKwkJCQkJTEVBVkUoRU1TR1NJWkUp OworCQkJCX0KKwkJCX0gZWxzZSB7CisJCQkJaWYgKG1zZy0+aGVhZGVyLmFyZ2xlbiAtIHNpemVv Zigqb3VybXNnKSA+CisJCQkJICAgIFBQUE9FX1NFUlZJQ0VfTkFNRV9TSVpFKSB7CisJCQkJCWxv ZyhMT0dfRVJSLCAibmdfcHBwb2VbJXhdOiBzZXJ2aWNlIG5hbWUgIgorCQkJCQkgICAgInRvbyBi aWdcbiIsIG5vZGUtPm5kX0lEKTsKKwkJCQkJTEVBVkUoRU1TR1NJWkUpOworCQkJCX0KIAkJCX0K IAkJCWlmIChtc2ctPmhlYWRlci5hcmdsZW4gLSBzaXplb2YoKm91cm1zZykgPAogCQkJICAgIG91 cm1zZy0+ZGF0YV9sZW4pIHsKQEAgLTc5NCw2ICs4NDQsMjAgQEAKIAkJCWlmIChtc2ctPmhlYWRl ci5jbWQgPT0gTkdNX1BQUE9FX1NFUlZJQ0UpCiAJCQkJYnJlYWs7CiAKKwkJCS8qCisJCQkgKiBQ QURNIG1lc3NhZ2VzIGFyZSBzZXQgdXAgb24gYWN0aXZlIHNlc3Npb25zLgorCQkJICovCisJCQlp ZiAobXNnLT5oZWFkZXIuY21kID09IE5HTV9QUFBPRV9TRU5EX0hVUkwgfHwKKwkJCSAgICBtc2ct PmhlYWRlci5jbWQgPT0gTkdNX1BQUE9FX1NFTkRfTU9UTSkgeworCQkJCWlmIChzcC0+c3RhdGUg IT0gUFBQT0VfTkVXQ09OTkVDVEVEICYmCisJCQkJICAgIHNwLT5zdGF0ZSAhPSBQUFBPRV9DT05O RUNURUQpIHsKKwkJCQkJbG9nKExPR19OT1RJQ0UsICJuZ19wcHBvZVsleF06IHNlc3Npb24gaXMg bm90ICIKKwkJCQkJICAgICJhY3RpdmVcbiIsIG5vZGUtPm5kX0lEKTsKKwkJCQkJTEVBVkUoRUlT Q09OTik7CisJCQkJfQorCQkJCWJyZWFrOworCQkJfQorCiAJCQlpZiAoc3AtPnN0YXRlICE9IFBQ UE9FX1NOT05FKSB7CiAJCQkJbG9nKExPR19OT1RJQ0UsICJuZ19wcHBvZVsleF06IFNlc3Npb24g YWxyZWFkeSAiCiAJCQkJICAgICJhY3RpdmVcbiIsIG5vZGUtPm5kX0lEKTsKQEAgLTg0OCwyOCAr OTEyLDcyIEBACiAJCQkgKiBDaGVjayB0aGUgaG9vayBleGlzdHMgYW5kIGlzIFVuaW5pdGlhbGlz ZWQuCiAJCQkgKiBTZW5kIGEgUEFESSByZXF1ZXN0LCBhbmQgc3RhcnQgdGhlIHRpbWVvdXQgbG9n aWMuCiAJCQkgKiBTdG9yZSB0aGUgb3JpZ2luYXRvciBvZiB0aGlzIG1lc3NhZ2Ugc28gd2UgY2Fu IHNlbmQKLQkJCSAqIGEgc3VjY2VzcyBvZiBmYWlsIG1lc3NhZ2UgdG8gdGhlbSBsYXRlci4KKwkJ CSAqIGEgc3VjY2VzcyBvciBmYWlsIG1lc3NhZ2UgdG8gdGhlbSBsYXRlci4KIAkJCSAqIE1vdmUg dGhlIHNlc3Npb24gdG8gU0lOSVQuCiAJCQkgKiBTZXQgdXAgdGhlIHNlc3Npb24gdG8gdGhlIGNv cnJlY3Qgc3RhdGUgYW5kCiAJCQkgKiBzdGFydCBpdC4KIAkJCSAqLwotCQkJaW50CWksIGFjbmxl biA9IDAsIGFjbnNlcCA9IDAsIHNydmxlbjsKKwkJCWludAlhY25wb3MsIGFjbmxlbiA9IDAsIGFj bnNlcCA9IDA7CisJCQlpbnQJaHVwb3MsIGh1bGVuID0gMCwgaHVzZXAgPSAwOworCQkJaW50CWks IHNydnBvcywgc3J2bGVuOworCQkJYWNucG9zID0gMDsKIAkJCWZvciAoaSA9IDA7IGkgPCBvdXJt c2ctPmRhdGFfbGVuOyBpKyspIHsKIAkJCQlpZiAob3VybXNnLT5kYXRhW2ldID09ICdcXCcpIHsK IAkJCQkJYWNubGVuID0gaTsKIAkJCQkJYWNuc2VwID0gMTsKIAkJCQkJYnJlYWs7CiAJCQkJfQog CQkJfQotCQkJc3J2bGVuID0gb3VybXNnLT5kYXRhX2xlbiAtIGFjbmxlbiAtIGFjbnNlcDsKKwkJ CWh1cG9zID0gYWNubGVuICsgYWNuc2VwOworCQkJZm9yIChpID0gaHVwb3M7IGkgPCBvdXJtc2ct PmRhdGFfbGVuOyBpKyspIHsKKwkJCQlpZiAob3VybXNnLT5kYXRhW2ldID09ICd8JykgeworCQkJ CQlodWxlbiA9IGkgLSBodXBvczsKKwkJCQkJaHVzZXAgPSAxOworCQkJCQlicmVhazsKKwkJCQl9 CisJCQl9CisJCQlzcnZwb3MgPSBodXBvcyArIGh1bGVuICsgaHVzZXA7CisJCQlzcnZsZW4gPSBv dXJtc2ctPmRhdGFfbGVuIC0gc3J2cG9zOwogCi0JCQliY29weShvdXJtc2ctPmRhdGEsIG5lZy0+ YWNfbmFtZS5kYXRhLCBhY25sZW4pOworCQkJYmNvcHkob3VybXNnLT5kYXRhICsgYWNucG9zLCBu ZWctPmFjX25hbWUuZGF0YSwgYWNubGVuKTsKIAkJCW5lZy0+YWNfbmFtZV9sZW4gPSBhY25sZW47 CiAKKwkJCW5lZy0+aG9zdF91bmlxLmhkci50YWdfdHlwZSA9IFBUVF9IT1NUX1VOSVE7CisJCQlp ZiAoaHVsZW4gPT0gMCkgeworCQkJCS8qIE5vdCBwcm92aWRlZCwgZ2VuZXJhdGUgb25lICovCisJ CQkJbmVnLT5ob3N0X3VuaXEuaGRyLnRhZ19sZW4gPSBodG9ucyhzaXplb2Yoc3ApKTsKKwkJCQli Y29weSgmc3AsIG5lZy0+aG9zdF91bmlxLmRhdGEsIHNpemVvZihzcCkpOworCQkJCW5lZy0+aG9z dF91bmlxX2xlbiA9IHNpemVvZihzcCk7CisJCQl9IGVsc2UgaWYgKGh1bGVuID4gMiAmJiBvdXJt c2ctPmRhdGFbaHVwb3NdID09ICcwJyAmJgorCQkJICBvdXJtc2ctPmRhdGFbaHVwb3MgKyAxXSA9 PSAneCcgJiYgaHVsZW4gJSAyID09IDApIHsKKwkJCQkvKiBIZXggZW5jb2RlZCAqLworCQkJCXN0 YXRpYyBjb25zdCBjaGFyIGhleGRpZ1sxNl0gPSAiMDEyMzQ1Njc4OWFiY2RlZiI7CisJCQkJaW50 IGo7CisKKwkJCQluZWctPmhvc3RfdW5pcS5oZHIudGFnX2xlbiA9IGh0b25zKCh1aW50MTZfdCko aHVsZW4gLyAyIC0gMSkpOworCQkJCWZvciAoaSA9IDA7IGkgPCBodWxlbiAtIDI7IGkrKykgewor CQkJCQlmb3IgKGogPSAwOworCQkJCQkgICAgIGogPCAxNiAmJgorCQkJCQkgICAgIG91cm1zZy0+ ZGF0YVtodXBvcyArIDIgKyBpXSAhPSBoZXhkaWdbal07CisJCQkJCSAgICAgaisrKTsKKwkJCQkJ aWYgKGogPT0gMTYpCisJCQkJCQlMRUFWRShFSU5WQUwpOworCQkJCQlpZiAoaSAlIDIgPT0gMCkK KwkJCQkJCW5lZy0+aG9zdF91bmlxLmRhdGFbaSAvIDJdID0gaiA8PCA0OworCQkJCQllbHNlCisJ CQkJCQluZWctPmhvc3RfdW5pcS5kYXRhW2kgLyAyXSB8PSBqOworCQkJCX0KKwkJCQluZWctPmhv c3RfdW5pcV9sZW4gPSBodWxlbiAvIDIgLSAxOworCQkJfSBlbHNlIHsKKwkJCQkvKiBQbGFpbiBz dHJpbmcgKi8KKwkJCQluZWctPmhvc3RfdW5pcS5oZHIudGFnX2xlbiA9IGh0b25zKCh1aW50MTZf dClodWxlbik7CisJCQkJYmNvcHkob3VybXNnLT5kYXRhICsgaHVwb3MsIG5lZy0+aG9zdF91bmlx LmRhdGEsIGh1bGVuKTsKKwkJCQluZWctPmhvc3RfdW5pcV9sZW4gPSBodWxlbjsKKwkJCX0KKwog CQkJbmVnLT5zZXJ2aWNlLmhkci50YWdfdHlwZSA9IFBUVF9TUlZfTkFNRTsKIAkJCW5lZy0+c2Vy dmljZS5oZHIudGFnX2xlbiA9IGh0b25zKCh1aW50MTZfdClzcnZsZW4pOwotCQkJYmNvcHkob3Vy bXNnLT5kYXRhICsgYWNubGVuICsgYWNuc2VwLAotCQkJICAgIG5lZy0+c2VydmljZS5kYXRhLCBz cnZsZW4pOworCQkJYmNvcHkob3VybXNnLT5kYXRhICsgc3J2cG9zLCBuZWctPnNlcnZpY2UuZGF0 YSwgc3J2bGVuKTsKIAkJCW5lZy0+c2VydmljZV9sZW4gPSBzcnZsZW47CiAJCQlwcHBvZV9zdGFy dChzcCk7CiAJCQlicmVhazsKQEAgLTg3OSw3ICs5ODcsNyBAQAogCQkJICogQ2hlY2sgdGhlIGhv b2sgZXhpc3RzIGFuZCBpcyBVbmluaXRpYWxpc2VkLgogCQkJICogSW5zdGFsbCB0aGUgc2Vydmlj ZSBtYXRjaGluZyBzdHJpbmcuCiAJCQkgKiBTdG9yZSB0aGUgb3JpZ2luYXRvciBvZiB0aGlzIG1l c3NhZ2Ugc28gd2UgY2FuIHNlbmQKLQkJCSAqIGEgc3VjY2VzcyBvZiBmYWlsIG1lc3NhZ2UgdG8g dGhlbSBsYXRlci4KKwkJCSAqIGEgc3VjY2VzcyBvciBmYWlsIG1lc3NhZ2UgdG8gdGhlbSBsYXRl ci4KIAkJCSAqIE1vdmUgdGhlIGhvb2sgdG8gJ0xJU1RFTklORycKIAkJCSAqLwogCQkJbmVnLT5z ZXJ2aWNlLmhkci50YWdfdHlwZSA9IFBUVF9TUlZfTkFNRTsKQEAgLTEwMTksNiArMTEyNyw5NiBA QAogCQkJcHJpdnAtPm1heF9wYXlsb2FkLmhkci50YWdfbGVuID0gaHRvbnMoc2l6ZW9mKHVpbnQx Nl90KSk7CiAJCQlwcml2cC0+bWF4X3BheWxvYWQuZGF0YSA9IGh0b25zKCooKHVpbnQxNl90ICop bXNnLT5kYXRhKSk7CiAJCQlicmVhazsKKwkJY2FzZSBOR01fUFBQT0VfU0VORF9IVVJMOgorCQkg ICAgeworCQkJc3RydWN0IG1idWYgKm07CisKKwkJCS8qIEdlbmVyYXRlIGEgcGFja2V0IG9mIHRo YXQgdHlwZS4gKi8KKwkJCU1HRVRIRFIobSwgTV9OT1dBSVQsIE1UX0RBVEEpOworCQkJaWYgKG0g PT0gTlVMTCkKKwkJCQlsb2coTE9HX05PVElDRSwgIm5nX3BwcG9lWyV4XTogc2Vzc2lvbiBvdXQg b2YgIgorCQkJCSAgICAibWJ1ZnNcbiIsIG5vZGUtPm5kX0lEKTsKKwkJCWVsc2UgeworCQkJCXN0 cnVjdCBwcHBvZV9mdWxsX2hkciAqd2g7CisJCQkJc3RydWN0IHBwcG9lX3RhZyAqdGFnOworCQkJ CWludCAgICAgZXJyb3IgPSAwOworCisJCQkJbS0+bV9wa3RoZHIucmN2aWYgPSBOVUxMOworCQkJ CW0tPm1fcGt0aGRyLmxlbiA9IG0tPm1fbGVuID0gc2l6ZW9mKCp3aCk7CisJCQkJd2ggPSBtdG9k KG0sIHN0cnVjdCBwcHBvZV9mdWxsX2hkciAqKTsKKwkJCQliY29weSgmc3AtPnBrdF9oZHIsIHdo LCBzaXplb2YoKndoKSk7CisKKwkJCQkvKiBSZXZlcnQgdGhlIHN0b3JlZCBoZWFkZXIgdG8gRElT Qy9QQURNIG1vZGUuICovCisJCQkJd2gtPnBoLmNvZGUgPSBQQURNX0NPREU7CisJCQkJLyoKKwkJ CQkgKiBDb25maWd1cmUgZXRoZXJ0eXBlIGRlcGVuZGluZyBvbiB3aGF0CisJCQkJICogd2FzIHVz ZWQgZHVyaW5nIHNlc3Npb25zIHN0YWdlLgorCQkJCSAqLworCQkJCWlmICh3aC0+ZWguZXRoZXJf dHlwZSA9PQorCQkJCSAgICBFVEhFUlRZUEVfUFBQT0VfM0NPTV9TRVNTKQorCQkJCQl3aC0+ZWgu ZXRoZXJfdHlwZSA9IEVUSEVSVFlQRV9QUFBPRV8zQ09NX0RJU0M7CisJCQkJZWxzZQorCQkJCQl3 aC0+ZWguZXRoZXJfdHlwZSA9IEVUSEVSVFlQRV9QUFBPRV9ESVNDOworCQkJCS8qCisJCQkJICog QWRkIFBBRE0gbWVzc2FnZSBhbmQgYWRqdXN0IHNpemVzLgorCQkJCSAqLworCQkJCXRhZyA9ICh2 b2lkICopKCZ3aC0+cGggKyAxKTsKKwkJCQl0YWctPnRhZ190eXBlID0gUFRUX0hVUkw7CisJCQkJ dGFnLT50YWdfbGVuID0gaHRvbnMob3VybXNnLT5kYXRhX2xlbik7CisJCQkJc3RybmNweSgoY2hh ciAqKSh0YWcgKyAxKSwgb3VybXNnLT5kYXRhLCBvdXJtc2ctPmRhdGFfbGVuKTsKKwkJCQltLT5t X3BrdGhkci5sZW4gPSAobS0+bV9sZW4gKz0gc2l6ZW9mKCp0YWcpICsKKwkJCQkgICAgb3VybXNn LT5kYXRhX2xlbik7CisJCQkJd2gtPnBoLmxlbmd0aCA9IGh0b25zKHNpemVvZigqdGFnKSArIG91 cm1zZy0+ZGF0YV9sZW4pOworCQkJCU5HX1NFTkRfREFUQV9PTkxZKGVycm9yLAorCQkJCSAgICBw cml2cC0+ZXRoZXJuZXRfaG9vaywgbSk7CisJCQl9CisJCQlicmVhazsKKwkJICAgIH0KKwkJY2Fz ZSBOR01fUFBQT0VfU0VORF9NT1RNOgorCQkgICAgeworCQkJc3RydWN0IG1idWYgKm07CisKKwkJ CS8qIEdlbmVyYXRlIGEgcGFja2V0IG9mIHRoYXQgdHlwZS4gKi8KKwkJCU1HRVRIRFIobSwgTV9O T1dBSVQsIE1UX0RBVEEpOworCQkJaWYgKG0gPT0gTlVMTCkKKwkJCQlsb2coTE9HX05PVElDRSwg Im5nX3BwcG9lWyV4XTogc2Vzc2lvbiBvdXQgb2YgIgorCQkJCSAgICAibWJ1ZnNcbiIsIG5vZGUt Pm5kX0lEKTsKKwkJCWVsc2UgeworCQkJCXN0cnVjdCBwcHBvZV9mdWxsX2hkciAqd2g7CisJCQkJ c3RydWN0IHBwcG9lX3RhZyAqdGFnOworCQkJCWludCAgICAgZXJyb3IgPSAwOworCisJCQkJbS0+ bV9wa3RoZHIucmN2aWYgPSBOVUxMOworCQkJCW0tPm1fcGt0aGRyLmxlbiA9IG0tPm1fbGVuID0g c2l6ZW9mKCp3aCk7CisJCQkJd2ggPSBtdG9kKG0sIHN0cnVjdCBwcHBvZV9mdWxsX2hkciAqKTsK KwkJCQliY29weSgmc3AtPnBrdF9oZHIsIHdoLCBzaXplb2YoKndoKSk7CisKKwkJCQkvKiBSZXZl cnQgdGhlIHN0b3JlZCBoZWFkZXIgdG8gRElTQy9QQURNIG1vZGUuICovCisJCQkJd2gtPnBoLmNv ZGUgPSBQQURNX0NPREU7CisJCQkJLyoKKwkJCQkgKiBDb25maWd1cmUgZXRoZXJ0eXBlIGRlcGVu ZGluZyBvbiB3aGF0CisJCQkJICogd2FzIHVzZWQgZHVyaW5nIHNlc3Npb25zIHN0YWdlLgorCQkJ CSAqLworCQkJCWlmICh3aC0+ZWguZXRoZXJfdHlwZSA9PQorCQkJCSAgICBFVEhFUlRZUEVfUFBQ T0VfM0NPTV9TRVNTKQorCQkJCQl3aC0+ZWguZXRoZXJfdHlwZSA9IEVUSEVSVFlQRV9QUFBPRV8z Q09NX0RJU0M7CisJCQkJZWxzZQorCQkJCQl3aC0+ZWguZXRoZXJfdHlwZSA9IEVUSEVSVFlQRV9Q UFBPRV9ESVNDOworCQkJCS8qCisJCQkJICogQWRkIFBBRE0gbWVzc2FnZSBhbmQgYWRqdXN0IHNp emVzLgorCQkJCSAqLworCQkJCXRhZyA9ICh2b2lkICopKCZ3aC0+cGggKyAxKTsKKwkJCQl0YWct PnRhZ190eXBlID0gUFRUX01PVE07CisJCQkJdGFnLT50YWdfbGVuID0gaHRvbnMob3VybXNnLT5k YXRhX2xlbik7CisJCQkJc3RybmNweSgoY2hhciAqKSh0YWcgKyAxKSwgb3VybXNnLT5kYXRhLCBv dXJtc2ctPmRhdGFfbGVuKTsKKwkJCQltLT5tX3BrdGhkci5sZW4gPSAobS0+bV9sZW4gKz0gc2l6 ZW9mKCp0YWcpICsKKwkJCQkgICAgb3VybXNnLT5kYXRhX2xlbik7CisJCQkJd2gtPnBoLmxlbmd0 aCA9IGh0b25zKHNpemVvZigqdGFnKSArIG91cm1zZy0+ZGF0YV9sZW4pOworCQkJCU5HX1NFTkRf REFUQV9PTkxZKGVycm9yLAorCQkJCSAgICBwcml2cC0+ZXRoZXJuZXRfaG9vaywgbSk7CisJCQl9 CisJCQlicmVhazsKKwkJICAgIH0KIAkJZGVmYXVsdDoKIAkJCUxFQVZFKEVJTlZBTCk7CiAJCX0K QEAgLTEwNjEsMTAgKzEyNTksNiBAQAogCW5vZGVfcAlub2RlID0gTkdfSE9PS19OT0RFKGhvb2sp OwogCXByaXZfcAlwcml2cCA9IE5HX05PREVfUFJJVkFURShub2RlKTsKIAluZWdwCW5lZyA9IHNw LT5uZWc7Ci0Jc3RydWN0IHsKLQkJc3RydWN0IHBwcG9lX3RhZyBoZHI7Ci0JCXVuaW9uCXVuaXEJ ZGF0YTsKLQl9IF9fcGFja2VkIHVuaXF0YWc7CiAJc3RydWN0ICBtYnVmICptMDsKIAlpbnQJZXJy b3I7CiAKQEAgLTEwODAsMTEgKzEyNzQsOCBAQAogCW1lbWNweSgodm9pZCAqKSZuZWctPnBrdC0+ cGt0X2hlYWRlci5laCwgJnByaXZwLT5laCwKIAkgICAgc2l6ZW9mKHN0cnVjdCBldGhlcl9oZWFk ZXIpKTsKIAluZWctPnBrdC0+cGt0X2hlYWRlci5waC5jb2RlID0gUEFESV9DT0RFOwotCXVuaXF0 YWcuaGRyLnRhZ190eXBlID0gUFRUX0hPU1RfVU5JUTsKLQl1bmlxdGFnLmhkci50YWdfbGVuID0g aHRvbnMoKHVfaW50MTZfdClzaXplb2YodW5pcXRhZy5kYXRhKSk7Ci0JdW5pcXRhZy5kYXRhLnBv aW50ZXIgPSBzcDsKIAlpbml0X3RhZ3Moc3ApOwotCWluc2VydF90YWcoc3AsICZ1bmlxdGFnLmhk cik7CisJaW5zZXJ0X3RhZyhzcCwgJm5lZy0+aG9zdF91bmlxLmhkcik7CiAJaW5zZXJ0X3RhZyhz cCwgJm5lZy0+c2VydmljZS5oZHIpOwogCWlmIChwcml2cC0+bWF4X3BheWxvYWQuZGF0YSAhPSAw KQogCQlpbnNlcnRfdGFnKHNwLCAmcHJpdnAtPm1heF9wYXlsb2FkLmhkcik7CkBAIC0xMTYzLDYg KzEzNTQsNTIgQEAKIAlyZXR1cm4gKGVycm9yKTsKIH0KIAorc3RhdGljIGludAorc2VuZF9odXJs KHNlc3NwIHNwLCBjb25zdCBzdHJ1Y3QgcHBwb2VfdGFnICp0YWcpCit7CisJaW50IGVycm9yLCB0 bGVuOworCXN0cnVjdCBuZ19tZXNnICptc2c7CisJc3RydWN0IG5ncHBwb2VfcGFkbSAqcGFkbTsK KworCUNUUjIoS1RSX05FVCwgIiUyMHM6IGNhbGxlZCAlZCIsIF9fZnVuY19fLCBzcC0+U2Vzc2lv bl9JRCk7CisKKwlOR19NS01FU1NBR0UobXNnLCBOR01fUFBQT0VfQ09PS0lFLCBOR01fUFBQT0Vf SFVSTCwKKwkgICAgc2l6ZW9mKHN0cnVjdCBuZ3BwcG9lX3BhZG0pLCBNX05PV0FJVCk7CisJaWYg KG1zZyA9PSBOVUxMKQorCQlyZXR1cm4gKEVOT01FTSk7CisKKwlwYWRtID0gKHN0cnVjdCBuZ3Bw cG9lX3BhZG0gKiltc2ctPmRhdGE7CisJdGxlbiA9IG1pbihQUFBPRV9QQURNX1ZBTFVFX1NJWkUg LSAxLCBudG9ocyh0YWctPnRhZ19sZW4pKTsKKwlzdHJuY3B5KHBhZG0tPm1zZywgKGNvbnN0IGNo YXIgKikodGFnICsgMSksIHRsZW4pOworCXBhZG0tPm1zZ1t0bGVuXSA9ICdcMCc7CisJTkdfU0VO RF9NU0dfSUQoZXJyb3IsIE5HX0hPT0tfTk9ERShzcC0+aG9vayksIG1zZywgc3AtPmNyZWF0b3Is IDApOworCisJcmV0dXJuIChlcnJvcik7Cit9CisKK3N0YXRpYyBpbnQKK3NlbmRfbW90bShzZXNz cCBzcCwgY29uc3Qgc3RydWN0IHBwcG9lX3RhZyAqdGFnKQoreworCWludCBlcnJvciwgdGxlbjsK KwlzdHJ1Y3QgbmdfbWVzZyAqbXNnOworCXN0cnVjdCBuZ3BwcG9lX3BhZG0gKnBhZG07CisKKwlD VFIyKEtUUl9ORVQsICIlMjBzOiBjYWxsZWQgJWQiLCBfX2Z1bmNfXywgc3AtPlNlc3Npb25fSUQp OworCisJTkdfTUtNRVNTQUdFKG1zZywgTkdNX1BQUE9FX0NPT0tJRSwgTkdNX1BQUE9FX01PVE0s CisJICAgIHNpemVvZihzdHJ1Y3QgbmdwcHBvZV9wYWRtKSwgTV9OT1dBSVQpOworCWlmIChtc2cg PT0gTlVMTCkKKwkJcmV0dXJuIChFTk9NRU0pOworCisJcGFkbSA9IChzdHJ1Y3QgbmdwcHBvZV9w YWRtICopbXNnLT5kYXRhOworCXRsZW4gPSBtaW4oUFBQT0VfUEFETV9WQUxVRV9TSVpFIC0gMSwg bnRvaHModGFnLT50YWdfbGVuKSk7CisJc3RybmNweShwYWRtLT5tc2csIChjb25zdCBjaGFyICop KHRhZyArIDEpLCB0bGVuKTsKKwlwYWRtLT5tc2dbdGxlbl0gPSAnXDAnOworCU5HX1NFTkRfTVNH X0lEKGVycm9yLCBOR19IT09LX05PREUoc3AtPmhvb2spLCBtc2csIHNwLT5jcmVhdG9yLCAwKTsK KworCXJldHVybiAoZXJyb3IpOworfQorCiAvKgogICogUmVjZWl2ZSBkYXRhIGZyb20gc2Vzc2lv biBob29rIGFuZCBkbyBzb21ldGhpbmcgd2l0aCBpdC4KICAqLwpAQCAtMTMyMCw2ICsxNTU3LDcg QEAKIAljb25zdCBwcml2X3AJCXByaXZwID0gTkdfTk9ERV9QUklWQVRFKG5vZGUpOwogCXNlc3Nw CQkJc3A7CiAJY29uc3Qgc3RydWN0IHBwcG9lX3RhZwkqdXRhZyA9IE5VTEwsICp0YWcgPSBOVUxM OworCWNvbnN0IHN0cnVjdCBwcHBvZV90YWcJc250YWcgPSB7IFBUVF9TUlZfTkFNRSwgMCB9Owog CWNvbnN0IHN0cnVjdCBwcHBvZV9mdWxsX2hkciAqd2g7CiAJY29uc3Qgc3RydWN0IHBwcG9lX2hk cgkqcGg7CiAJbmVncAkJCW5lZyA9IE5VTEw7CkBAIC0xNDA5LDExICsxNjQ3LDggQEAKIAkJCSAq IHByb2Nlc3NpbmcuCiAJCQkgKi8KIAkJCXRhZyA9IGdldF90YWcocGgsIFBUVF9TUlZfTkFNRSk7 Ci0JCQlpZiAodGFnID09IE5VTEwpIHsKLQkJCQlDVFIxKEtUUl9ORVQsICIlMjBzOiBQQURJIHcv byBTZXJ2aWNlLU5hbWUiLAotCQkJCSAgICBfX2Z1bmNfXyk7Ci0JCQkJTEVBVkUoRU5FVFVOUkVB Q0gpOwotCQkJfQorCQkJaWYgKHRhZyA9PSBOVUxMKQorCQkJCXRhZyA9ICZzbnRhZzsKIAogCQkJ LyoKIAkJCSAqIEZpcnN0LCB0cnkgdG8gbWF0Y2ggU2VydmljZS1OYW1lIGFnYWluc3Qgb3VyIApA QCAtMTQzOCw4ICsxNjczLDcgQEAKIAkJCSAqIEZvciBub3cgc2ltcGx5IGFjY2VwdCB0aGUgZmly c3Qgd2UgcmVjZWl2ZS4KIAkJCSAqLwogCQkJdXRhZyA9IGdldF90YWcocGgsIFBUVF9IT1NUX1VO SVEpOwotCQkJaWYgKCh1dGFnID09IE5VTEwpIHx8Ci0JCQkgICAgKG50b2hzKHV0YWctPnRhZ19s ZW4pICE9IHNpemVvZihzcCkpKSB7CisJCQlpZiAodXRhZyA9PSBOVUxMKSB7CiAJCQkJbG9nKExP R19OT1RJQ0UsICJuZ19wcHBvZVsleF06IG5vIGhvc3QgIgogCQkJCSAgICAidW5pcXVlIGZpZWxk XG4iLCBub2RlLT5uZF9JRCk7CiAJCQkJTEVBVkUoRU5FVFVOUkVBQ0gpOwpAQCAtMTUyOSw3ICsx NzYzLDcgQEAKIAkJCQlMRUFWRShFTkVUVU5SRUFDSCk7CiAJCQl9CiAKLQkJCXNlbmRob29rID0g cHBwb2VfZmluZHVuaXEobm9kZSwgdXRhZyk7CisJCQlzZW5kaG9vayA9IHBwcG9lX2ZpbmRjb29r aWUobm9kZSwgdXRhZyk7CiAJCQlpZiAoc2VuZGhvb2sgPT0gTlVMTCkKIAkJCQlMRUFWRShFTkVU VU5SRUFDSCk7CiAKQEAgLTE2MDUsOCArMTgzOSw3IEBACiAJCQkgKiBzZXQgdXMgaW50byBTZXNz aW9uIG1vZGUuCiAJCQkgKi8KIAkJCXV0YWcgPSBnZXRfdGFnKHBoLCBQVFRfSE9TVF9VTklRKTsK LQkJCWlmICgodXRhZyA9PSBOVUxMKSB8fAotCQkJICAgIChudG9ocyh1dGFnLT50YWdfbGVuKSAh PSBzaXplb2Yoc3ApKSkgeworCQkJaWYgKHV0YWcgPT0gTlVMTCkgewogCQkJCUxFQVZFIChFTkVU VU5SRUFDSCk7CiAJCQl9CiAJCQlzZW5kaG9vayA9IHBwcG9lX2ZpbmR1bmlxKG5vZGUsIHV0YWcp OwpAQCAtMTY1OSw2ICsxODkyLDE5IEBACiAJCQkvKiBEaXNjb25uZWN0IHRoYXQgaG9vay4gKi8K IAkJCW5nX3JtaG9va19zZWxmKHNwLT5ob29rKTsKIAkJCWJyZWFrOworCQljYXNlCVBBRE1fQ09E RToKKwkJCS8qCisJCQkgKiBXZSBhcmUgYSBjbGllbnQ6CisJCQkgKiBmaW5kIG1hdGNoaW5nIHBl ZXIvc2Vzc2lvbiBjb21iaW5hdGlvbi4KKwkJCSAqLworCQkJc3AgPSBwcHBvZV9maW5kc2Vzc2lv bihwcml2cCwgd2gpOworCQkJaWYgKHNwID09IE5VTEwpCisJCQkJTEVBVkUgKEVORVRVTlJFQUNI KTsKKwkJCWlmICgodGFnID0gZ2V0X3RhZyhwaCwgUFRUX0hVUkwpKSkKKwkJCQlzZW5kX2h1cmwo c3AsIHRhZyk7CisJCQlpZiAoKHRhZyA9IGdldF90YWcocGgsIFBUVF9NT1RNKSkpCisJCQkJc2Vu ZF9tb3RtKHNwLCB0YWcpOworCQkJYnJlYWs7CiAJCWRlZmF1bHQ6CiAJCQlMRUFWRShFUEZOT1NV UFBPUlQpOwogCQl9CkBAIC0xOTMzLDYgKzIxNzksOCBAQAogCQljYXNlCVBUVF9TWVNfRVJSOgog CQljYXNlCVBUVF9HRU5fRVJSOgogCQljYXNlCVBUVF9NQVhfUEFZTDoKKwkJY2FzZQlQVFRfSFVS TDoKKwkJY2FzZQlQVFRfTU9UTToKIAkJCWJyZWFrOwogCQl9CiAJCXB0ID0gKGNvbnN0IHN0cnVj dCBwcHBvZV90YWcqKXB0bjsKZGlmZiAtLWdpdCBhL3NoYXJlL21hbi9tYW40L25nX3BwcG9lLjQg Yi9zaGFyZS9tYW4vbWFuNC9uZ19wcHBvZS40Ci0tLSBhL3NoYXJlL21hbi9tYW40L25nX3BwcG9l LjQKKysrIGIvc2hhcmUvbWFuL21hbjQvbmdfcHBwb2UuNApAQCAtMzUsNyArMzUsNyBAQAogLlwi ICRGcmVlQlNEJAogLlwiICRXaGlzdGxlOiBuZ19wcHBvZS44LHYgMS4xIDE5OTkvMDEvMjUgMjM6 NDY6MjcgYXJjaGllIEV4cCAkCiAuXCIKLS5EZCBTZXB0ZW1iZXIgMTUsIDIwMTUKKy5EZCBNYXJj aCAxLCAyMDE3CiAuRHQgTkdfUFBQT0UgNAogLk9zCiAuU2ggTkFNRQpAQCAtMTA0LDEyICsxMDQs MzMgQEAKIEl0IG11c3QgYmUgbmV3bHkgY3JlYXRlZCBhbmQgYSBzZXJ2aWNlIG5hbWUgY2FuIGJl IGdpdmVuIGFzIGFuIGFyZ3VtZW50LgogSXQgaXMgbGVnYWwgdG8gc3BlY2lmeSBhIHplcm8tbGVu Z3RoIHNlcnZpY2UgbmFtZSwgdGhpcyBpcyBjb21tb24KIG9uIHNvbWUgRFNMIHNldHVwcy4KLUl0 IGlzIHBvc3NpYmxlIHRvIHJlcXVlc3QgYSBjb25uZWN0aW9uIHRvIGEgc3BlY2lmaWMKLWFjY2Vz cyBjb25jZW50cmF0b3IgYnkgaXRzIG5hbWUgdXNpbmcgdGhlICJBQy1OYW1lXFxTZXJ2aWNlLU5h bWUiIHN5bnRheC4KLUEgc2Vzc2lvbiByZXF1ZXN0IHBhY2tldCB3aWxsIGJlIGJyb2FkY2FzdGVk IG9uIHRoZSBFdGhlcm5ldC4KK0l0IGlzIHBvc3NpYmxlIHRvIHJlcXVlc3QgYSBjb25uZWN0aW9u IHRvIGEgc3BlY2lmaWMgYWNjZXNzIGNvbmNlbnRyYXRvciwKK2FuZC9vciBzZXQgYSBzcGVjaWZp YyBIb3N0LVVuaXEgdGFnLCByZXF1aXJlZCBieSBzb21lIEludGVybmV0IHByb3ZpZGVycywKK3Vz aW5nIHRoZQorLlFxIExpIFtBQy1OYW1lXFxdW0hvc3QtVW5pcXxdU2VydmljZS1OYW1lCitzeW50 YXguCitUbyBzZXQgYSBiaW5hcnkgSG9zdC1VbmlxLCBpdCBtdXN0IGJlIGVuY29kZWQgYXMgYSBo ZXhhZGVjaW1hbCBsb3dlcmNhc2UKK3N0cmluZyBhbmQgcHJlZml4ZWQgd2l0aCAKKy5RcSBMaSAw eCAsCitlZy4gCisuUXEgTGkgMHg2ZDc5MmQ3NDYxNjcKK2lzIGVxdWl2YWxlbnQgdG8KKy5RcSBM aSBteS10YWcgLgorQSBzZXNzaW9uIHJlcXVlc3QgcGFja2V0IHdpbGwgYmUgYnJvYWRjYXN0IG9u IHRoZSBFdGhlcm5ldC4KIFRoaXMgY29tbWFuZCB1c2VzIHRoZQogLkR2IG5ncHBwb2VfaW5pdF9k YXRhCiBzdHJ1Y3R1cmUgc2hvd24gYmVsb3cuCitGb3IgZXhhbXBsZSwgdGhpcyBpbml0IGRhdGEg YXJndW1lbnQgY2FuIGJlIHVzZWQgdG8KK2Nvbm5lY3QgdG8KKy5RcSBMaSBteS1pc3AKK3NlcnZp Y2Ugd2l0aAorLlFxIExpIG15LWhvc3QKK3VuaXEgdGFnLCBhY2NlcHRpbmcgb25seQorLlFxIExp IHJlbW90ZS1hYworYXMgYWNjZXNzIGNvbmNlbnRyYXRvcjoKKy5CZCAtbGl0ZXJhbCAtb2Zmc2V0 IGluZGVudAorInJlbW90ZS1hY1xcbXktaG9zdHxteS1pc3AiCisuRWQKIC5JdCBEdiBOR01fUFBQ T0VfTElTVEVOIFBxIEljIHBwcG9lX2xpc3RlbgogVGVsbCBhIG5vbWluYXRlZCBuZXdseSBjcmVh dGVkIGhvb2sgdGhhdCBpdHMgc2Vzc2lvbiBzaG91bGQgZW50ZXIKIHRoZSBzdGF0ZSBtYWNoaW5l IGFzIGEgc2VydmVyIGxpc3RlbmVyLgpAQCAtMjU4LDcgKzI3OSw0MSBAQAogICAgIHVpbnQxNl90 IGRhdGE7CiB9OwogLkVkCisuSXQgRHYgTkdNX1BQUE9FX1NFTkRfSFVSTCBQcSBJYyBzZW5kX2h1 cmwKK1RlbGwgYSBub21pbmF0ZWQgaG9vayB3aXRoIGFuIGFjdGl2ZSBzZXNzaW9uIHRvIHNlbmQg YSBQQURNIG1lc3NhZ2Ugd2l0aAorYSBIVVJMIHRhZy4KK1RoZSBhcmd1bWVudCBpcyB0aGUgVVJM IHRvIGJlIGRlbGl2ZXJlZCB0byB0aGUgY2xpZW50OgorLkJkIC1saXRlcmFsIC1vZmZzZXQgaW5k ZW50CituZ2N0bCBtc2cgZnhwMDpvcnBoYW5zIHNlbmRfaHVybCAneyBob29rPSJteUhvb2siIGRh dGE9Imh0dHA6Ly9leGFtcGxlLm5ldC9jcGUiIH0nCisuRWQKKy5JdCBEdiBOR01fUFBQT0VfU0VO RF9NT1RNIFBxIEljIHNlbmRfbW90bQorVGVsbCBhIG5vbWluYXRlZCBob29rIHdpdGggYW4gYWN0 aXZlIHNlc3Npb24gdG8gc2VuZCBhIFBBRE0gbWVzc2FnZSB3aXRoCithIE1PVE0gdGFnLgorVGhl IGFyZ3VtZW50IGlzIHRoZSBtZXNzYWdlIHRvIGJlIGRlbGl2ZXJlZCB0byB0aGUgY2xpZW50Ogor LkJkIC1saXRlcmFsIC1vZmZzZXQgaW5kZW50CituZ2N0bCBtc2cgZnhwMDpvcnBoYW5zIHNlbmRf bW90bSAneyBob29rPSJteUhvb2siIGRhdGE9IldlbGNvbWUgYWJvYXJkIiB9JworLkVkCiAuRWwK Ky5QcAorVGhlIHR3byBjb21tYW5kcyBhYm92ZSB1c2UgdGhlIHNhbWUgbmdwcHBvZV9pbml0X2Rh dGEgc3RydWN0dXJlIGRlc2NyaWJlZAorYWJvdmUuCisuQmwgLXRhZyAtd2lkdGggM24KKy5JdCBE diBOR01fUFBQT0VfSFVSTAorVGhpcyBjb21tYW5kIGlzIHNlbnQgdG8gdGhlIG5vZGUgdGhhdCBz dGFydGVkIHRoaXMgc2Vzc2lvbiB3aGVuIGEgUEFETQorbWVzc2FnZSB3aXRoIGEgSFVSTCB0YWcg aXMgcmVjZWl2ZWQsIGFuZCBjb250YWlucyBhIFVSTCB0aGF0IHRoZSBob3N0IGNhbgorcGFzcyB0 byBhIHdlYiBicm93c2VyIGZvciBwcmVzZW50YXRpb24gdG8gdGhlIHVzZXIuCisuSXQgRHYgTkdN X1BQUE9FX01PVE0KK1RoaXMgY29tbWFuZCBpcyBzZW50IHRvIHRoZSBub2RlIHRoYXQgc3RhcnRl ZCB0aGlzIHNlc3Npb24gd2hlbiBhIFBBRE0KK21lc3NhZ2Ugd2l0aCBhIE1PVE0gdGFnIGlzIHJl Y2VpdmVkLCBhbmQgY29udGFpbnMgYSBNZXNzYWdlIE9mIFRoZQorTWludXRlIHRoYXQgdGhlIGhv c3QgY2FuIGRpc3BsYXkgdG8gdGhlIHVzZXIuCisuRWwKKy5QcAorVGhlIHR3byBjb21tYW5kcyBh Ym92ZSB1c2UgYSBjb21tb24gZGF0YSBzdHJ1Y3R1cmU6CisuQmQgLWxpdGVyYWwgLW9mZnNldCA0 bgorc3RydWN0IG5ncHBwb2VfcGFkbSB7CisgICAgY2hhciAgICBtc2dbUFBQT0VfUEFETV9WQUxV RV9TSVpFXTsKK307CisuRWQKIC5TaCBTSFVURE9XTgogVGhpcyBub2RlIHNodXRzIGRvd24gdXBv biByZWNlaXB0IG9mIGEKIC5EdiBOR01fU0hVVERPV04KCg== --b1_475d2439918cee32d5900abe663b7f0f-- From owner-freebsd-net@freebsd.org Sat Mar 4 16:52:32 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 75D74CF9509 for ; Sat, 4 Mar 2017 16:52:32 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: from reviews.nyi.freebsd.org (reviews.nyi.freebsd.org [IPv6:2610:1c1:1:607c::16:b]) by mx1.freebsd.org (Postfix) with ESMTP id 4F869143E for ; Sat, 4 Mar 2017 16:52:32 +0000 (UTC) (envelope-from daemon-user@freebsd.org) Received: by reviews.nyi.freebsd.org (Postfix, from userid 1346) id 1AFD21A805; Sat, 4 Mar 2017 16:52:32 +0000 (UTC) Date: Sat, 4 Mar 2017 16:52:32 +0000 To: freebsd-net@freebsd.org From: "ale (Alex Dupre)" Reply-to: D9270+325+bbd470fd257eef1b@reviews.freebsd.org Subject: [Differential] D9270: Add support for user-supplied Host-Uniq tag and handle PADM messages in Netgraph PPPoE Message-ID: X-Priority: 3 X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: Thread-Topic: D9270: Add support for user-supplied Host-Uniq tag in Netgraph PPPoE X-Herald-Rules: <28>, <8> X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: Precedence: bulk In-Reply-To: References: Thread-Index: NTZkNjQzYWQxOGQ3MGJlZTIzOGZhZmQ4NGNmIFi68NA= MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Mar 2017 16:52:32 -0000 YWxlIG1hcmtlZCAxNCBpbmxpbmUgY29tbWVudHMgYXMgZG9uZS4KClJFUE9TSVRPUlkKICByUyBG cmVlQlNEIHNyYyByZXBvc2l0b3J5CgpSRVZJU0lPTiBERVRBSUwKICBodHRwczovL3Jldmlld3Mu ZnJlZWJzZC5vcmcvRDkyNzAKCkVNQUlMIFBSRUZFUkVOQ0VTCiAgaHR0cHM6Ly9yZXZpZXdzLmZy ZWVic2Qub3JnL3NldHRpbmdzL3BhbmVsL2VtYWlscHJlZmVyZW5jZXMvCgpUbzogYWxlLCBqdWxp YW4sICNtYW5wYWdlcywgbWF2LCAjbmV0d29yaywgYWRyaWFuCkNjOiB3YmxvY2ssIG1hdiwgcG9v bHJvb21fZ21haWwuY29tLCBtYW5kcmVlLCBpbXAsIGZyZWVic2QtbmV0LWxpc3QK From owner-freebsd-net@freebsd.org Sat Mar 4 21:06:53 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 97C15CF9F44 for ; Sat, 4 Mar 2017 21:06:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 876F516BF for ; Sat, 4 Mar 2017 21:06:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v24L6r6F099794 for ; Sat, 4 Mar 2017 21:06:53 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 217509] [patch] netinet/netinet6: missing curly braces in inm_merge/in6m_merge Date: Sat, 04 Mar 2017 21:06:53 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ae@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Mar 2017 21:06:53 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217509 Andrey V. Elsukov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ae@FreeBSD.org, | |bms@FreeBSD.org --- Comment #1 from Andrey V. Elsukov --- The patch looks correct to me. --=20 You are receiving this mail because: You are the assignee for the bug.=