From owner-freebsd-net@freebsd.org Sun Jun 18 03:43:20 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3F17AD87C07 for ; Sun, 18 Jun 2017 03:43:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2CE7281EA3 for ; Sun, 18 Jun 2017 03:43:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5I3hJWe010242 for ; Sun, 18 Jun 2017 03:43:20 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 219428] em network driver broken in current Date: Sun, 18 Jun 2017 03:43:19 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: gitdev@kippona.net X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2017 03:43:20 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D219428 --- Comment #7 from gitdev --- Created attachment 183588 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D183588&action= =3Dedit boot msg, panic and backtrace FreeBSD 12.0-CURRENT #0 r319859 generates panic: em1: Using MSIX interrupts with 1 vectors panic: Assertion adapter->tx_num_queues > 0 failed at /usr/src/sys/dev/e1000/if_em.c:2664 --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sun Jun 18 05:31:29 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0C943D89558; Sun, 18 Jun 2017 05:31:29 +0000 (UTC) (envelope-from kob6558@gmail.com) Received: from mail-pg0-x231.google.com (mail-pg0-x231.google.com [IPv6:2607:f8b0:400e:c05::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CB876840BD; Sun, 18 Jun 2017 05:31:28 +0000 (UTC) (envelope-from kob6558@gmail.com) Received: by mail-pg0-x231.google.com with SMTP id 132so2028439pgb.2; Sat, 17 Jun 2017 22:31:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=jpVbkf9+duGDRxNn0+O7dH8WBytsjUcZ8kcgHMyaOUQ=; b=EOrV6Ci7Rz9APjBashsYPaaoXTjMwvVq1uL1G33cvlB4x+sEnGJNcj5Zo/5xAWdiwi n9NjTaBLdbmvpWFULSxuA16szZnVXl7UO72SnQYoFGAowj5J8og0eL+Vkni4DegEKodv N9sTJ1J6/pTHkj3XEfXikRR308k10yuGsXWJF2+oN3CBX7cWI+esLvddc2YgodsMApny 4ro6vpjRqDQReoG05VNID2ARYSz9EmRmzFXzV2c6A8NO1W1ComwTLhFVdQg9GVubCWRp eAVmGxfPE7Bt80DOJ8aViEnpgVd5QYAtsEpP2ih4YBSDCyO7NGDAe5A4Piv5PYPJi4BG QNnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=jpVbkf9+duGDRxNn0+O7dH8WBytsjUcZ8kcgHMyaOUQ=; b=NQa5KLUuveZ39HiAEmiztEJXopCBxE8hBB0PAR9JbZZwyQVjTj8UWwePHUN1IC2YLX LV9WoYx7OgLOHQa7fPwZPk6NkWHXRVzXNs6VMio6xiwBHWqB4N9VuqQy03wRyR72NfGt jtIqgq7mo7FX4ml5Gwy1v02x42WTIrWvtipzkJWGZxx2wqN8vb2Wu+aTabQaPMY7DA41 KOHdH2dmOKJJajMpM/H1XmbBeiIY1hDwe58esi2BuRMRWw5enrleBtRCDOi2EzoS21o6 021wCVLgd32AtlKhMNIVMpHfaiye7n0jN+DjzhpJVnmeOtWbzFqm9nqnesNPY2/sTf02 bPdg== X-Gm-Message-State: AKS2vOy/+RaDb6ErWTTaImdZRLT0dyofw+i5u9p7sCX0xjbPh4wfZX4v ws1HaDJT221n2LBxcPgEQNRIhkgHYw== X-Received: by 10.84.225.130 with SMTP id u2mr22114218plj.255.1497763888419; Sat, 17 Jun 2017 22:31:28 -0700 (PDT) MIME-Version: 1.0 Sender: kob6558@gmail.com Received: by 10.100.140.202 with HTTP; Sat, 17 Jun 2017 22:31:27 -0700 (PDT) In-Reply-To: <7cc5abf5-f90c-c554-e54e-6f9534ef22ef@163.com> References: <7cc5abf5-f90c-c554-e54e-6f9534ef22ef@163.com> From: Kevin Oberman Date: Sat, 17 Jun 2017 22:31:27 -0700 X-Google-Sender-Auth: D0C4coGfhN1xdwQo4bPtvqfZEbA Message-ID: Subject: Re: [Bug 220032] [if_alc] sys/dev/alc/if_alc.c: sleep-under-mutex bugs To: Jia-Ju Bai Cc: freebsd-drivers@freebsd.org, "freebsd-net@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2017 05:31:29 -0000 On Fri, Jun 16, 2017 at 2:03 AM, Jia-Ju Bai wrote: > The alc driver may sleep under a mutex, and the function call paths in file > "sys/dev/alc/if_alc.c" in FreeBSD 11.0 is: > alc_resume [line 2648: acquire the mutex] > alc_init_locked [line 2664] > alc_init_rx_ring [line 3911] > alc_newbuf [line 4469] > bus_dmamap_load_mbuf_sg(BUS_DMA_WAITOK) [line 3472] --> may sleep > > alc_int_task [line 3330: acquire the mutex] > alc_start_locked [line 3372] > alc_encap [line 2942] > bus_dmamap_load_mbuf_sg(BUS_DMA_WAITOK) [line 2780] --> may sleep > > The possible fix of these bugs is to set the last parameter in > bus_dmamap_load_mbuf_sg to "BUS_DMA_NOWAIT". > > This bug is found by a static analysis tool written by myself, and it is > checked by my review of the FreeBSD code. > > By the way, I am a freshman in developing FreeBSD drivers, and I am > willing to > submit a patch. But I do not know how to write and submit a patch, and > where to > submit, so I am looking forward to useful advice :) > > Jia-Ju Bai > To submit a patch, use svn to download the source from a repository. Be sure the file in your source directory is the current, unmodified file. Edit the file or files as needed to correct the bug Generate the diff with the command "svn diff path-to-directory-containing-file(s) > diff-file.diff" Update the bug report attaching the patch (with a brief description) -- Kevin Oberman, Part time kid herder and retired Network Engineer E-mail: rkoberman@gmail.com PGP Fingerprint: D03FB98AFA78E3B78C1694B318AB39EF1B055683 From owner-freebsd-net@freebsd.org Sun Jun 18 07:47:54 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CBF0CD8B633; Sun, 18 Jun 2017 07:47:54 +0000 (UTC) (envelope-from baijiaju1990@163.com) Received: from m12-18.163.com (m12-18.163.com [220.181.12.18]) by mx1.freebsd.org (Postfix) with ESMTP id 22DAB34FD; Sun, 18 Jun 2017 07:47:53 +0000 (UTC) (envelope-from baijiaju1990@163.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Subject:From:Message-ID:Date:MIME-Version; bh=Y9Xmg Sn220IM0qmoKQUrY5F8HBdtOf/WBvRB5w/ae2Y=; b=IJQKAyCwqIurQPoavP1k2 ymbikfZtJdm3Xexz5sMH20962+eM2MLPzeNxbN7dMSgDdI9PW6hPPZeZ6so3iKYE trJ76rZYb9Lka8SRqxo1K/1HgjnVRTbwH+OMWFAC2krJ6EmpT9XhFRxo4S15W6oS biuJsmcyU7FvX5XZWjNQlY= Received: from [166.111.70.13] (unknown [166.111.70.13]) by smtp14 (Coremail) with SMTP id EsCowAA3S7wiMEZZkndnNQ--.42905S2; Sun, 18 Jun 2017 15:47:46 +0800 (CST) Subject: Re: [Bug 220032] [if_alc] sys/dev/alc/if_alc.c: sleep-under-mutex bugs To: Kevin Oberman Cc: freebsd-drivers@freebsd.org, "freebsd-net@freebsd.org" References: <7cc5abf5-f90c-c554-e54e-6f9534ef22ef@163.com> From: Jia-Ju Bai Message-ID: Date: Sun, 18 Jun 2017 15:47:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CM-TRANSID: EsCowAA3S7wiMEZZkndnNQ--.42905S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7WrWxKw47uw1DZF47Wr4DJwb_yoW8ur4rp3 yagas0yryDCrWfA3s7Ar1xAFyfX395GrZ8WF45WrZFqwn8Wry2gr1SgFWUZFyrur9xCFWI yrWUX395Zan0yaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07ja4E_UUUUU= X-Originating-IP: [166.111.70.13] X-CM-SenderInfo: xedlyx5dmximizq6il2tof0z/1tbiGAL6elXlaIY1DQAAs8 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2017 07:47:54 -0000 Thanks a lot, your advice is very helpful :) I will submit a patch according to your advice, and update my bug report. By the way, I have found many similar possible bugs in network drivers in FreeBSD. And they are all caused by "BUS_DMA_WAITOK" in bus_dmamap_load and other dmamap-load related functions. If my reported bugs can be quickly confirmed, I will write and submit patches for them as soon as possible. I am looking forward to helpful comments and advice :) Thanks, Jia-Ju Bai On 2017/6/18 13:31, Kevin Oberman wrote: > On Fri, Jun 16, 2017 at 2:03 AM, Jia-Ju Bai > wrote: > > The alc driver may sleep under a mutex, and the function call > paths in file > "sys/dev/alc/if_alc.c" in FreeBSD 11.0 is: > alc_resume [line 2648: acquire the mutex] > alc_init_locked [line 2664] > alc_init_rx_ring [line 3911] > alc_newbuf [line 4469] > bus_dmamap_load_mbuf_sg(BUS_DMA_WAITOK) [line 3472] --> > may sleep > > alc_int_task [line 3330: acquire the mutex] > alc_start_locked [line 3372] > alc_encap [line 2942] > bus_dmamap_load_mbuf_sg(BUS_DMA_WAITOK) [line 2780] --> may > sleep > > The possible fix of these bugs is to set the last parameter in > bus_dmamap_load_mbuf_sg to "BUS_DMA_NOWAIT". > > This bug is found by a static analysis tool written by myself, and > it is > checked by my review of the FreeBSD code. > > By the way, I am a freshman in developing FreeBSD drivers, and I > am willing to > submit a patch. But I do not know how to write and submit a patch, > and where to > submit, so I am looking forward to useful advice :) > > Jia-Ju Bai > > > To submit a patch, use svn to download the source from a repository. > Be sure the file in your source directory is the current, unmodified file. > Edit the file or files as needed to correct the bug > Generate the diff with the command "svn diff > path-to-directory-containing-file(s) > diff-file.diff" > Update the bug report attaching the patch (with a brief description) > -- > Kevin Oberman, Part time kid herder and retired Network Engineer > E-mail: rkoberman@gmail.com > PGP Fingerprint: D03FB98AFA78E3B78C1694B318AB39EF1B055683 From owner-freebsd-net@freebsd.org Sun Jun 18 09:04:25 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DB896D8C9C7; Sun, 18 Jun 2017 09:04:25 +0000 (UTC) (envelope-from baijiaju1990@163.com) Received: from m12-16.163.com (m12-16.163.com [220.181.12.16]) by mx1.freebsd.org (Postfix) with ESMTP id 12B1A64FB8; Sun, 18 Jun 2017 09:04:24 +0000 (UTC) (envelope-from baijiaju1990@163.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=qegnUfRz3U6eDlU+5X t9dFGsiZtZ9PmK2a2NCVwOHHs=; b=i0BxwWUSiYACzoW98ep8NMJfIxwxTKyazt 6LCYkB1AeaEma0TQZM6CGORneH/Mj2fIjnaQlY8mGsItCJwI+jUDMXTrSTpwNMWV sngd4R/sw7hKGXH4oqcxcUiMiamj5YoyvCnQL0Exh9EvWE/UuQ+N53mV8tfQoJmL UUPeTaq78= Received: from bai.tsinghua.edu.cn (unknown [166.111.70.9]) by smtp12 (Coremail) with SMTP id EMCowACXhEkSQkZZcCWbKQ--.61280S2; Sun, 18 Jun 2017 17:04:23 +0800 (CST) From: Jia-Ju Bai To: rkoberman@gmail.com, yongari@freebsd.org Cc: freebsd-drivers@freebsd.org, freebsd-net@freebsd.org, Jia-Ju Bai Subject: [Bug 220032][PATCH] if_alc: Fix possible sleep-under-mutex bugs Date: Sun, 18 Jun 2017 09:04:05 +0800 Message-Id: <20170618010405.40107-1-baijiaju1990@163.com> X-Mailer: git-send-email 2.13.0 X-CM-TRANSID: EMCowACXhEkSQkZZcCWbKQ--.61280S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7tFW7CrWDXFyrtF4rCw4rZrb_yoW8CF45pa y3WF15Ww13Aw48Aa40gF1093W8t3s3ZrWUGFW8CFZxJrn8Jr1rX3y8A3WrZrWY9rZ3CF1f JryDu3s8KFWUAFUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zRdhL5UUUUU= X-Originating-IP: [166.111.70.9] X-CM-SenderInfo: xedlyx5dmximizq6il2tof0z/1tbiYxf6elaDtdThWQAAs4 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2017 09:04:26 -0000 The alc driver may sleep under a mutex, and the function call paths in file "sys/dev/alc/if_alc.c" are: alc_resume [acquire the mutex] alc_init_locked alc_init_rx_ring alc_newbuf bus_dmamap_load_mbuf_sg(BUS_DMA_WAITOK) --> may sleep alc_start [acquire the mutex] alc_start_locked alc_encap bus_dmamap_load_mbuf_sg(BUS_DMA_WAITOK) --> may sleep The possible fix of these bugs is to set the last parameter in bus_dmamap_load_mbuf_sg to "BUS_DMA_NOWAIT". This bug is found by a static analysis tool written by myself, and it is checked by my review of the FreeBSD code. Signed-off-by: Jia-Ju Bai --- sys/dev/alc/if_alc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/alc/if_alc.c b/sys/dev/alc/if_alc.c index ca7ae9d17b5..cb0f15e223b 100644 --- a/sys/dev/alc/if_alc.c +++ b/sys/dev/alc/if_alc.c @@ -2795,7 +2795,7 @@ alc_encap(struct alc_softc *sc, struct mbuf **m_head) map = txd->tx_dmamap; error = bus_dmamap_load_mbuf_sg(sc->alc_cdata.alc_tx_tag, map, - *m_head, txsegs, &nsegs, 0); + *m_head, txsegs, &nsegs, BUS_DMA_NOWAIT); if (error == EFBIG) { m = m_collapse(*m_head, M_NOWAIT, ALC_MAXTXSEGS); if (m == NULL) { @@ -2805,7 +2805,7 @@ alc_encap(struct alc_softc *sc, struct mbuf **m_head) } *m_head = m; error = bus_dmamap_load_mbuf_sg(sc->alc_cdata.alc_tx_tag, map, - *m_head, txsegs, &nsegs, 0); + *m_head, txsegs, &nsegs, BUS_DMA_NOWAIT); if (error != 0) { m_freem(*m_head); *m_head = NULL; @@ -3487,7 +3487,7 @@ alc_newbuf(struct alc_softc *sc, struct alc_rxdesc *rxd) #endif if (bus_dmamap_load_mbuf_sg(sc->alc_cdata.alc_rx_tag, - sc->alc_cdata.alc_rx_sparemap, m, segs, &nsegs, 0) != 0) { + sc->alc_cdata.alc_rx_sparemap, m, segs, &nsegs, BUS_DMA_NOWAIT) != 0) { m_freem(m); return (ENOBUFS); } -- 2.13.0 From owner-freebsd-net@freebsd.org Sun Jun 18 09:20:38 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0B4F7D8CDE4; Sun, 18 Jun 2017 09:20:38 +0000 (UTC) (envelope-from baijiaju1990@163.com) Received: from m12-14.163.com (m12-14.163.com [220.181.12.14]) by mx1.freebsd.org (Postfix) with ESMTP id 76F9C653E6; Sun, 18 Jun 2017 09:20:35 +0000 (UTC) (envelope-from baijiaju1990@163.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=JpzRAPgRPVN/zFZn9c 5pVbrnzwwOQjEIhH14W7vwEAI=; b=I4b/qGKuCKGEGKy5IrNNRy+2lItGlBgnbZ oGjSVppCDn0uBEdu3WSyU3z7QTEMizMQHSszBLFRy6rtOEyGpbFbk1CpT9R8xNXn mnF4fUSOvMfckBqrRezChTln/Qtlm3XFjQMfPj2JRgZTsoaCGkmD/M/iJGd9fQqc ezLZumQqw= Received: from bai.tsinghua.edu.cn (unknown [166.111.70.9]) by smtp10 (Coremail) with SMTP id DsCowACHj1vYRUZZPiWOMQ--.59360S2; Sun, 18 Jun 2017 17:20:27 +0800 (CST) From: Jia-Ju Bai To: erj@freebsd.org, sbruno@FreeBSD.org Cc: freebsd-drivers@freebsd.org, freebsd-net@freebsd.org, Jia-Ju Bai Subject: [BUG 220033][PATCH] if_ixgb: Fix a possible sleep-under-mutex bug in ixge_get_buf Date: Sun, 18 Jun 2017 17:20:23 +0800 Message-Id: <20170618092023.40369-1-baijiaju1990@163.com> X-Mailer: git-send-email 2.13.0 X-CM-TRANSID: DsCowACHj1vYRUZZPiWOMQ--.59360S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7GF48Kr47KFy7JF13Cr4UJwb_yoWDKFc_ua 4Iya48AwsxKrykKw4fCr4ruryIq3y3ur18ur4ft3ZxAFW7XF95Kr93JrWfXryxW3yIkrWx XrnYqrZakF1xZjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjdHUPUUUUU== X-Originating-IP: [166.111.70.9] X-CM-SenderInfo: xedlyx5dmximizq6il2tof0z/1tbiYxz6elaDtdUXBwAAsa X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2017 09:20:38 -0000 The ixgb driver may sleep under a mutex, and the function call path is: ixgb_init [acquire the mutex] ixgb_init_locked ixgb_setup_receive_structures ixgb_allocate_receive_structures ixgb_get_buf bus_dmamap_load(BUS_DMA_WAITOK) --> may sleep The possible fix of these bugs is to set the last parameter in bus_dmamap_load to "BUS_DMA_NOWAIT". This bug is found by a static analysis tool written by myself, and it is checked by my review of the FreeBSD code. Signed-off-by: Jia-Ju Bai --- sys/dev/ixgb/if_ixgb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/ixgb/if_ixgb.c b/sys/dev/ixgb/if_ixgb.c index 430c13c72d1..e6d02dd172e 100644 --- a/sys/dev/ixgb/if_ixgb.c +++ b/sys/dev/ixgb/if_ixgb.c @@ -1811,7 +1811,7 @@ ixgb_get_buf(int i, struct adapter * adapter, */ error = bus_dmamap_load(adapter->rxtag, rx_buffer->map, mtod(mp, void *), mp->m_len, - ixgb_dmamap_cb, &paddr, 0); + ixgb_dmamap_cb, &paddr, BUS_DMA_NOWAIT); if (error) { m_free(mp); return (error); -- 2.13.0 From owner-freebsd-net@freebsd.org Sun Jun 18 09:40:46 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 372F8D8D280 for ; Sun, 18 Jun 2017 09:40:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2521F65CAB for ; Sun, 18 Jun 2017 09:40:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5I9egrE014797 for ; Sun, 18 Jun 2017 09:40:46 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 186114] net/mpd5 hangs after a certain number of users connect Date: Sun, 18 Jun 2017 09:40:42 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: eugen@freebsd.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2017 09:40:46 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D186114 --- Comment #72 from Kubilay Kocak --- (In reply to Eugene Grosbein from comment #71) Is there an issue for the syslog related changes/patch discussed with kib@ = on freebsd-current? --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Sun Jun 18 09:42:23 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5AFB5D8D420 for ; Sun, 18 Jun 2017 09:42:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 489F665F79 for ; Sun, 18 Jun 2017 09:42:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5I9gMOG023281 for ; Sun, 18 Jun 2017 09:42:23 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 186114] net/mpd5 hangs after a certain number of users connect Date: Sun, 18 Jun 2017 09:42:22 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: eugen@freebsd.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: see_also Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2017 09:42:23 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D186114 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.freebsd.org/bu | |gzilla/show_bug.cgi?id=3D2= 200 | |76, | |https://bugs.freebsd.org/bu | |gzilla/show_bug.cgi?id=3D2= 200 | |78 --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Sun Jun 18 11:37:11 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 83E07D8ED48 for ; Sun, 18 Jun 2017 11:37:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 721CB68654 for ; Sun, 18 Jun 2017 11:37:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5IBbBCd025691 for ; Sun, 18 Jun 2017 11:37:11 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220033] [if_ixgb] sys/dev/ixgb/if_ixgb.c: a sleep-under-mutex bug in ixge_get_buf Date: Sun, 18 Jun 2017 11:37:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: baijiaju1990@163.com X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Not A Bug X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2017 11:37:11 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220033 Jia-Ju Bai changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |Not A Bug Status|New |Closed --- Comment #1 from Jia-Ju Bai --- I have read the manual page, and found bus_dmamap_load is not blocked. Sorry for my wrong report. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sun Jun 18 11:41:21 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CA7E1D8EE3A; Sun, 18 Jun 2017 11:41:21 +0000 (UTC) (envelope-from baijiaju1990@163.com) Received: from m12-12.163.com (m12-12.163.com [220.181.12.12]) by mx1.freebsd.org (Postfix) with ESMTP id E8DC5688A8; Sun, 18 Jun 2017 11:41:20 +0000 (UTC) (envelope-from baijiaju1990@163.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Subject:From:Message-ID:Date:MIME-Version; bh=DZ803 I9acetEcBgiGE6FV3e2e2nRNm5qaB6FMNtp54c=; b=Wq9DDOHkn4T5qxQsY63ws ToC8b/8XUGS1RC1xx1txEvnDlPX0rpm4+gZc1diJTw8N4LSEhMsiQXTpmHgE4MRF 2hX2c+XplNObSMz0sJ/o/I3Vu4/gt//xHb1ur7VUuIY/scLjCfSygwm1oTlWl+rx BTnzZlfAaRXhl9F1Rdnp7A= Received: from [166.111.70.13] (unknown [166.111.70.13]) by smtp8 (Coremail) with SMTP id DMCowABXg6ffZkZZQUQEDA--.35208S2; Sun, 18 Jun 2017 19:41:19 +0800 (CST) Subject: Re: [Bug 220032][PATCH] if_alc: Fix possible sleep-under-mutex bugs To: rkoberman@gmail.com, yongari@freebsd.org Cc: freebsd-drivers@freebsd.org, freebsd-net@freebsd.org References: <20170618010405.40107-1-baijiaju1990@163.com> From: Jia-Ju Bai Message-ID: <069fa517-2774-c19b-f2c5-a3b81df1a812@163.com> Date: Sun, 18 Jun 2017 19:41:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20170618010405.40107-1-baijiaju1990@163.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-CM-TRANSID: DMCowABXg6ffZkZZQUQEDA--.35208S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZrW7XF43ArWDAr18ZF48Xrb_yoW8uw43pa y7WFy5uryYyw40va48KF40g3W8t34rZry5GrW8Cr93Grn8Gr1rW3yUAa1fZF4a9rZ7CFyf Xry5u3s8KrWUAFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jQ0edUUUUU= X-Originating-IP: [166.111.70.13] X-CM-SenderInfo: xedlyx5dmximizq6il2tof0z/1tbiTQD6elc69sIE9QAAsl X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2017 11:41:21 -0000 Hi, I have read the manual page of bus_dmamap_load_mbuf_sg. This call will always return immediately and will not block for any reason. Sorry for my wrong report, please ignore it. Thanks, Jia-Ju Bai On 2017/6/18 9:04, Jia-Ju Bai wrote: > The alc driver may sleep under a mutex, and the function call paths in file > "sys/dev/alc/if_alc.c" are: > alc_resume [acquire the mutex] > alc_init_locked > alc_init_rx_ring > alc_newbuf > bus_dmamap_load_mbuf_sg(BUS_DMA_WAITOK) --> may sleep > alc_start [acquire the mutex] > alc_start_locked > alc_encap > bus_dmamap_load_mbuf_sg(BUS_DMA_WAITOK) --> may sleep > > The possible fix of these bugs is to set the last parameter in > bus_dmamap_load_mbuf_sg to "BUS_DMA_NOWAIT". > > This bug is found by a static analysis tool written by myself, and it is > checked by my review of the FreeBSD code. > > Signed-off-by: Jia-Ju Bai > --- > sys/dev/alc/if_alc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/sys/dev/alc/if_alc.c b/sys/dev/alc/if_alc.c > index ca7ae9d17b5..cb0f15e223b 100644 > --- a/sys/dev/alc/if_alc.c > +++ b/sys/dev/alc/if_alc.c > @@ -2795,7 +2795,7 @@ alc_encap(struct alc_softc *sc, struct mbuf **m_head) > map = txd->tx_dmamap; > > error = bus_dmamap_load_mbuf_sg(sc->alc_cdata.alc_tx_tag, map, > - *m_head, txsegs, &nsegs, 0); > + *m_head, txsegs, &nsegs, BUS_DMA_NOWAIT); > if (error == EFBIG) { > m = m_collapse(*m_head, M_NOWAIT, ALC_MAXTXSEGS); > if (m == NULL) { > @@ -2805,7 +2805,7 @@ alc_encap(struct alc_softc *sc, struct mbuf **m_head) > } > *m_head = m; > error = bus_dmamap_load_mbuf_sg(sc->alc_cdata.alc_tx_tag, map, > - *m_head, txsegs, &nsegs, 0); > + *m_head, txsegs, &nsegs, BUS_DMA_NOWAIT); > if (error != 0) { > m_freem(*m_head); > *m_head = NULL; > @@ -3487,7 +3487,7 @@ alc_newbuf(struct alc_softc *sc, struct alc_rxdesc *rxd) > #endif > > if (bus_dmamap_load_mbuf_sg(sc->alc_cdata.alc_rx_tag, > - sc->alc_cdata.alc_rx_sparemap, m, segs, &nsegs, 0) != 0) { > + sc->alc_cdata.alc_rx_sparemap, m, segs, &nsegs, BUS_DMA_NOWAIT) != 0) { > m_freem(m); > return (ENOBUFS); > } From owner-freebsd-net@freebsd.org Sun Jun 18 11:42:41 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4DA1BD8F020; Sun, 18 Jun 2017 11:42:41 +0000 (UTC) (envelope-from baijiaju1990@163.com) Received: from m12-12.163.com (m12-12.163.com [220.181.12.12]) by mx1.freebsd.org (Postfix) with ESMTP id A836E68A67; Sun, 18 Jun 2017 11:42:40 +0000 (UTC) (envelope-from baijiaju1990@163.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Subject:From:Message-ID:Date:MIME-Version; bh=dTwY6 94F92qcjd4snrOZPQKu+7AwZaDvu+ivpZQ0/Vk=; b=k+VrEsmSRp/hkPBssP2O1 unzivYflR89zywrEdxXLGdgDjA6Q5uWzdzbeIhQ3dkAVyUN7Ff15pg5lhNkp6Xma uzjOF7EyHioVfyRAtdramzmSbl3lucl2xPsKTsdouxhsuSu2gZxXmiEcJBGdsCNw fkxBINv5o5md3RTNcjpSRU= Received: from [166.111.70.13] (unknown [166.111.70.13]) by smtp8 (Coremail) with SMTP id DMCowADHXp8vZ0ZZD2MEDA--.24469S2; Sun, 18 Jun 2017 19:42:39 +0800 (CST) Subject: Re: [Bug 220032] [if_alc] sys/dev/alc/if_alc.c: sleep-under-mutex bugs From: Jia-Ju Bai To: Kevin Oberman Cc: freebsd-drivers@freebsd.org, "freebsd-net@freebsd.org" References: <7cc5abf5-f90c-c554-e54e-6f9534ef22ef@163.com> Message-ID: <00aa0c88-70b6-cb34-461e-34e25029f481@163.com> Date: Sun, 18 Jun 2017 19:42:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CM-TRANSID: DMCowADHXp8vZ0ZZD2MEDA--.24469S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7ur17ZryxGF15Kr4UArWxtFb_yoW8KF18p3 yagas0yryDArWfA3s7Ar4xuFyfX395GrZ8GF45urZFqw15Wr12gr1SgFWUZFyrur9xCFWI vFWUX3ykZFs0yaDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jrWrZUUUUU= X-Originating-IP: [166.111.70.13] X-CM-SenderInfo: xedlyx5dmximizq6il2tof0z/1tbiHg-6elSIVqMxCQAAsA Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2017 11:42:41 -0000 Hi, I have read the manual page ofbus_dmamap_load and other dmamap-load related functions. These calls will always return immediately and will not block for any reason. Sorry for my wrong report, please ignore it. Thanks, Jia-Ju Bai On 2017/6/18 15:47, Jia-Ju Bai wrote: > Thanks a lot, your advice is very helpful :) > I will submit a patch according to your advice, and update my bug report. > > By the way, I have found many similar possible bugs in network drivers > in FreeBSD. > And they are all caused by "BUS_DMA_WAITOK" in bus_dmamap_load and > other dmamap-load related functions. > If my reported bugs can be quickly confirmed, I will write and submit > patches for them as soon as possible. > I am looking forward to helpful comments and advice :) > > Thanks, > Jia-Ju Bai > > On 2017/6/18 13:31, Kevin Oberman wrote: >> On Fri, Jun 16, 2017 at 2:03 AM, Jia-Ju Bai > > wrote: >> >> The alc driver may sleep under a mutex, and the function call >> paths in file >> "sys/dev/alc/if_alc.c" in FreeBSD 11.0 is: >> alc_resume [line 2648: acquire the mutex] >> alc_init_locked [line 2664] >> alc_init_rx_ring [line 3911] >> alc_newbuf [line 4469] >> bus_dmamap_load_mbuf_sg(BUS_DMA_WAITOK) [line 3472] --> >> may sleep >> >> alc_int_task [line 3330: acquire the mutex] >> alc_start_locked [line 3372] >> alc_encap [line 2942] >> bus_dmamap_load_mbuf_sg(BUS_DMA_WAITOK) [line 2780] --> may >> sleep >> >> The possible fix of these bugs is to set the last parameter in >> bus_dmamap_load_mbuf_sg to "BUS_DMA_NOWAIT". >> >> This bug is found by a static analysis tool written by myself, >> and it is >> checked by my review of the FreeBSD code. >> >> By the way, I am a freshman in developing FreeBSD drivers, and I >> am willing to >> submit a patch. But I do not know how to write and submit a >> patch, and where to >> submit, so I am looking forward to useful advice :) >> >> Jia-Ju Bai >> >> >> To submit a patch, use svn to download the source from a repository. >> Be sure the file in your source directory is the current, unmodified >> file. >> Edit the file or files as needed to correct the bug >> Generate the diff with the command "svn diff >> path-to-directory-containing-file(s) > diff-file.diff" >> Update the bug report attaching the patch (with a brief description) >> -- >> Kevin Oberman, Part time kid herder and retired Network Engineer >> E-mail: rkoberman@gmail.com >> PGP Fingerprint: D03FB98AFA78E3B78C1694B318AB39EF1B055683 > From owner-freebsd-net@freebsd.org Sun Jun 18 11:46:43 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 46503D8F1B2 for ; Sun, 18 Jun 2017 11:46:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 341A868CE9 for ; Sun, 18 Jun 2017 11:46:43 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5IBkhHu048813 for ; Sun, 18 Jun 2017 11:46:43 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 186114] net/mpd5 hangs after a certain number of users connect Date: Sun, 18 Jun 2017 11:46:43 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: eugen@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: eugen@freebsd.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2017 11:46:43 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D186114 --- Comment #73 from Eugene Grosbein --- (In reply to Kubilay Kocak from comment #72) This is the patch https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D183= 537 My tests show no issues with it. It really helps and I'd like to see it included in upcoming 11.1-RELEASE and merged to stable/10 too for announced 10.4. --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Sun Jun 18 11:53:55 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CF4B7D8F6FD for ; Sun, 18 Jun 2017 11:53:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BD4C26A622 for ; Sun, 18 Jun 2017 11:53:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5IBrtAl068961 for ; Sun, 18 Jun 2017 11:53:55 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220032] [if_alc] sys/dev/alc/if_alc.c: sleep-under-mutex bugs Date: Sun, 18 Jun 2017 11:53:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: baijiaju1990@163.com X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Not A Bug X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2017 11:53:55 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220032 Jia-Ju Bai changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |Not A Bug Status|New |Closed --- Comment #1 from Jia-Ju Bai --- I have read the manual page of bus_dmamap_load_mbuf_sg. This call will always return immediately and will not block for any reason. Sorry for my wrong report, please ignore it. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Sun Jun 18 15:13:36 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D3FDDD881D8; Sun, 18 Jun 2017 15:13:36 +0000 (UTC) (envelope-from baijiaju1990@163.com) Received: from m12-13.163.com (m12-13.163.com [220.181.12.13]) by mx1.freebsd.org (Postfix) with ESMTP id 91A35728FE; Sun, 18 Jun 2017 15:13:35 +0000 (UTC) (envelope-from baijiaju1990@163.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=34aDayTWt169unhpFx 3SaIJw0tUOMQyj0ngcjXEPvqY=; b=DQ8M2zG2g4Fl9ZOCPfh8SUw0H44MvCfHGH GE9vcYDL5M+f4daKBn+wKwXxHf9oLHGyrstc0aNdn3DRDUQHmSSDImRcZ6GMmyvK 3ajKK6+7XzQnvu3Idp+dXgdJs4GMeQlNIccWqjr1j9XuoqVo5KwkTddn0v8tYpiF Fq3O2w5Vg= Received: from bai.tsinghua.edu.cn (unknown [166.111.70.9]) by smtp9 (Coremail) with SMTP id DcCowAAnx1KamEZZIIkRLQ--.56364S2; Sun, 18 Jun 2017 23:13:33 +0800 (CST) From: Jia-Ju Bai To: erj@freebsd.org, sbruno@freebsd.org Cc: freebsd-drivers@freebsd.org, freebsd-bugs@freebsd.org, freebsd-net@freebsd.org, Jia-Ju Bai Subject: [PATCH] if_ixgb: Fix possible sleep-under-mutex bugs (different from Bug 220033) Date: Sun, 18 Jun 2017 23:13:29 +0800 Message-Id: <20170618151329.41975-1-baijiaju1990@163.com> X-Mailer: git-send-email 2.13.0 X-CM-TRANSID: DcCowAAnx1KamEZZIIkRLQ--.56364S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Kr4DGw4DWr1Duw4xWr4xXrb_yoW8WryUpa 18W3W3GF1UXr4jya1vvF48WFW3Ga95uryUGry8Wa4Du3W2yr1jgw409ay0k3y5Xws7Can3 CFyqkr98AF17AFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zRPrchUUUUU= X-Originating-IP: [166.111.70.9] X-CM-SenderInfo: xedlyx5dmximizq6il2tof0z/xtbBRR36elO-7qb7ZwAAsg X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2017 15:13:36 -0000 The driver may sleep under a mutex, and the function call paths are: ixgb_init [acquire the mutex] ixgb_init_locked ixgb_setup_transmit_structures bus_dma_tag_create(BUS_DMA_ALLOCNOW) --> may sleep ixgb_init [acquire the mutex] ixgb_init_locked ixgb_setup_receive_structures ixgb_allocate_receive_structures bus_dma_tag_create(BUS_DMA_ALLOCNOW) --> may sleep The possible fix of these bugs is to add "BUS_DMA_NOWAIT" in bus_dma_tag_create. These bugs are found by a static analysis tool written by myself, and it is checked by my review of the FreeBSD code. Signed-off-by: Jia-Ju Bai --- sys/dev/ixgb/if_ixgb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/ixgb/if_ixgb.c b/sys/dev/ixgb/if_ixgb.c index 430c13c72d1..4cdfe6d4c28 100644 --- a/sys/dev/ixgb/if_ixgb.c +++ b/sys/dev/ixgb/if_ixgb.c @@ -1518,7 +1518,7 @@ ixgb_setup_transmit_structures(struct adapter * adapter) MCLBYTES * IXGB_MAX_SCATTER, /* maxsize */ IXGB_MAX_SCATTER, /* nsegments */ MCLBYTES, /* maxsegsize */ - BUS_DMA_ALLOCNOW, /* flags */ + BUS_DMA_ALLOCNOW | BUS_DMA_NOWAIT, /* flags */ #if __FreeBSD_version >= 502000 NULL, /* lockfunc */ NULL, /* lockfuncarg */ @@ -1856,7 +1856,7 @@ ixgb_allocate_receive_structures(struct adapter * adapter) MCLBYTES, /* maxsize */ 1, /* nsegments */ MCLBYTES, /* maxsegsize */ - BUS_DMA_ALLOCNOW, /* flags */ + BUS_DMA_ALLOCNOW | BUS_DMA_NOWAIT, /* flags */ #if __FreeBSD_version >= 502000 NULL, /* lockfunc */ NULL, /* lockfuncarg */ -- 2.13.0 From owner-freebsd-net@freebsd.org Sun Jun 18 21:00:07 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4B790D8DEC5 for ; Sun, 18 Jun 2017 21:00:07 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 41AE07BD4E for ; Sun, 18 Jun 2017 21:00:07 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5IL01E6025316 for ; Sun, 18 Jun 2017 21:00:07 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <201706182100.v5IL01E6025316@kenobi.freebsd.org> From: bugzilla-noreply@FreeBSD.org To: freebsd-net@FreeBSD.org Subject: Problem reports for freebsd-net@FreeBSD.org that need special attention Date: Sun, 18 Jun 2017 21:00:07 +0000 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Jun 2017 21:00:07 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- In Progress | 165622 | [ndis][panic][patch] Unregistered use of FPU in k In Progress | 206581 | bxe_ioctl_nvram handler is faulty New | 204438 | setsockopt() handling of kern.ipc.maxsockbuf limi New | 205592 | TCP processing in IPSec causes kernel panic New | 206053 | kqueue support code of netmap causes panic New | 213410 | [carp] service netif restart causes hang only whe New | 215874 | [patch] [icmp] [mbuf_tags] teach icmp_error() opt New | 217748 | sys/dev/ixgbe/if_ix.c: PVS-Studio: Assignment to Open | 173444 | socket: IPV6_USE_MIN_MTU and TCP is broken Open | 194485 | Userland cannot add IPv6 prefix routes Open | 194515 | Fatal Trap 12 Kernel with vimage Open | 199136 | [if_tap] Added down_on_close sysctl variable to t Open | 202510 | [CARP] advertisements sourced from CARP IP cause Open | 206544 | sendmsg(2) (sendto(2) too?) can fail with EINVAL; Open | 211031 | [panic] in ng_uncallout when argument is NULL Open | 211962 | bxe driver queue soft hangs and flooding tx_soft_ Open | 218653 | Intel e1000 network link drops under high network 17 problems total for which you should take action. From owner-freebsd-net@freebsd.org Mon Jun 19 01:28:25 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5025FD921E3; Mon, 19 Jun 2017 01:28:25 +0000 (UTC) (envelope-from baijiaju1990@163.com) Received: from m12-13.163.com (m12-13.163.com [220.181.12.13]) by mx1.freebsd.org (Postfix) with ESMTP id 35F8B827E8; Mon, 19 Jun 2017 01:28:23 +0000 (UTC) (envelope-from baijiaju1990@163.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=CIw6Vf/V9jrdt9ZWjR iLesifxgPY60E9XLcxRzR1+Yk=; b=LsCvAXVMrLcXZZ3/7CQ9PISgCCCKz8drdA sPmB0OFYTVQ4tveMidcPr2pE6z5TelRFWICGupDYVdEYbTnO4RcpEOF2DjSxJMXr TO4yTEju0XNuxwTHXqCg0CofFmBTMABYgRp0pc3CPaSTSrRso03bvW1lQIcT71BE 8YT5uXYwg= Received: from bai.tsinghua.edu.cn (unknown [166.111.70.9]) by smtp9 (Coremail) with SMTP id DcCowAD3lVGmKEdZs3VPLQ--.57901S2; Mon, 19 Jun 2017 09:28:10 +0800 (CST) From: Jia-Ju Bai To: wpaul@ctr.columbia.edu Cc: freebsd-drivers@freebsd.org, freebsd-bugs@freebsd.org, freebsd-net@freebsd.org, Jia-Ju Bai Subject: [PATCH] if_xl: Fix a possible sleep-under-mutex bug in xl_list_rx_init Date: Mon, 19 Jun 2017 09:28:04 +0800 Message-Id: <20170619012804.43725-1-baijiaju1990@163.com> X-Mailer: git-send-email 2.13.0 X-CM-TRANSID: DcCowAD3lVGmKEdZs3VPLQ--.57901S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7XF1xWFykXw4DJw1kZr1fZwb_yoWDArXEgF WkZr1xGr4akF1xKw1kuF4I9r12y3yfWrn3uryfXanrtr17Jrn8ta1vqrn3XF95uw4IyrWr Xayjqr48CF17CjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUboGQPUUUUU== X-Originating-IP: [166.111.70.9] X-CM-SenderInfo: xedlyx5dmximizq6il2tof0z/1tbiTQz7elc69srXqwAAst X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 01:28:25 -0000 The driver may sleep under a mutex, and the code path is: xl_resume [acquire the mutex] xl_init_locked xl_list_rx_init bus_dmamap_create(BUS_DMA_WAITOK) --> may sleep The possible fix of this bug is to replace "BUS_DMA_WAITOK" in bus_dmamap_create with "BUS_DMA_NOWAIT". This bug is found by a static analysis tool written by myself, and it is checked by my review of the FreeBSD code. Signed-off-by: Jia-Ju Bai --- sys/dev/xl/if_xl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/xl/if_xl.c b/sys/dev/xl/if_xl.c index 4c1c238981d..59b29ddc7ca 100644 --- a/sys/dev/xl/if_xl.c +++ b/sys/dev/xl/if_xl.c @@ -1726,7 +1726,7 @@ xl_list_rx_init(struct xl_softc *sc) for (i = 0; i < XL_RX_LIST_CNT; i++) { cd->xl_rx_chain[i].xl_ptr = &ld->xl_rx_list[i]; - error = bus_dmamap_create(sc->xl_mtag, 0, + error = bus_dmamap_create(sc->xl_mtag, BUS_DMA_NOWAIT, &cd->xl_rx_chain[i].xl_map); if (error) return (error); -- 2.13.0 From owner-freebsd-net@freebsd.org Mon Jun 19 02:10:46 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 12D18D92D3E for ; Mon, 19 Jun 2017 02:10:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 019EF83C72 for ; Mon, 19 Jun 2017 02:10:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5J2AjGv047909 for ; Mon, 19 Jun 2017 02:10:45 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220073] iflib panic r320049 Date: Mon, 19 Jun 2017 02:10:45 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: gitdev@kippona.net X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 02:10:46 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220073 gitdev changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitdev@kippona.net --- Comment #5 from gitdev --- (In reply to Diane Bruce from comment #2) Did r320059 fix this panic with em and if_bridge? --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Mon Jun 19 12:56:33 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 09AACD9C69E for ; Mon, 19 Jun 2017 12:56:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EC4777399A for ; Mon, 19 Jun 2017 12:56:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5JCuWos096898 for ; Mon, 19 Jun 2017 12:56:32 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 210726] tcp connect() can return invalid EADDRINUSE Date: Mon, 19 Jun 2017 12:56:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: aler@playground.ru X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 12:56:33 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210726 --- Comment #4 from aler@playground.ru --- Can this be processed more fast to make it patched in upcoming 10.4? --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Mon Jun 19 15:04:04 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D94D2D9E89C for ; Mon, 19 Jun 2017 15:04:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C682A777CB for ; Mon, 19 Jun 2017 15:04:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5JF421O090965 for ; Mon, 19 Jun 2017 15:04:04 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 211219] NIC status does not pass into a state of "no carrier" after disconnecting the cable. Date: Mon, 19 Jun 2017 15:04:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: IntelNetworking X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 15:04:05 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211219 --- Comment #31 from commit-hook@freebsd.org --- A commit references this bug: Author: sbruno Date: Mon Jun 19 15:03:48 UTC 2017 New revision: 320102 URL: https://svnweb.freebsd.org/changeset/base/320102 Log: Direct commit to stable/11 to correctly setting the EIAC and IMS registers to the same values when processing interrupts. This reverts a change made in r286831 that was not fully reverted in r311979 This resolves PR https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D2112= 19 PR: 211219 Submitted by: Franco Fitchner Approved by: re (marius) Changes: stable/11/sys/dev/e1000/if_em.c --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Mon Jun 19 15:55:04 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 40936D9F99F for ; Mon, 19 Jun 2017 15:55:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2E6DC79F5E for ; Mon, 19 Jun 2017 15:55:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5JFt2n0085288 for ; Mon, 19 Jun 2017 15:55:04 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 211219] NIC status does not pass into a state of "no carrier" after disconnecting the cable. Date: Mon, 19 Jun 2017 15:55:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: IntelNetworking X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: pete@twisted.org.uk X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 15:55:04 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211219 pete@twisted.org.uk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pete@twisted.org.uk --- Comment #32 from pete@twisted.org.uk --- This patch as commited to STABLE stops my em0 working entirely. hardware details: em0@pci0:3:2:0: class=3D0x020000 card=3D0x13768086 chip=3D0x107c8086 rev=3D= 0x05 hdr=3D0x00 vendor =3D 'Intel Corporation' device =3D '82541PI Gigabit Ethernet Controller' class =3D network subclass =3D ethernet --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Mon Jun 19 15:56:54 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 287B9D9FC61 for ; Mon, 19 Jun 2017 15:56:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 09F8C7A24B for ; Mon, 19 Jun 2017 15:56:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5JFuqVP087733 for ; Mon, 19 Jun 2017 15:56:53 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 211219] NIC status does not pass into a state of "no carrier" after disconnecting the cable. Date: Mon, 19 Jun 2017 15:56:52 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: IntelNetworking X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 15:56:54 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211219 --- Comment #33 from commit-hook@freebsd.org --- A commit references this bug: Author: sbruno Date: Mon Jun 19 15:56:03 UTC 2017 New revision: 320117 URL: https://svnweb.freebsd.org/changeset/base/320117 Log: Direct commit to stable/10 to correctly setting the EIAC and IMS registers to the same values when processing interrupts. This resolves PR https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D2112= 19 PR: 211219 Submitted by: Franco Fitchner Changes: stable/10/sys/dev/e1000/if_em.c --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Mon Jun 19 16:23:59 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BA90CDA04B9 for ; Mon, 19 Jun 2017 16:23:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9B19F7B21D for ; Mon, 19 Jun 2017 16:23:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5JGNvXM071928 for ; Mon, 19 Jun 2017 16:23:59 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 211219] NIC status does not pass into a state of "no carrier" after disconnecting the cable. Date: Mon, 19 Jun 2017 16:23:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: IntelNetworking X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: pete@twisted.org.uk X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 16:23:59 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211219 --- Comment #34 from pete@twisted.org.uk --- Actually, not quyite that simple. Sometimes it works, sometimes it does not= . If it does not then ifconfig em0 down and ifconfig em0 up will get it working again. The only chnage to em0 is the application of this patch, but I hadnt rebooted the machine this aftrnoon, so am going to check elsewhere for other issues. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Mon Jun 19 16:28:51 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BBE3ADA0559 for ; Mon, 19 Jun 2017 16:28:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A1D727B397 for ; Mon, 19 Jun 2017 16:28:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5JGSpmE078068 for ; Mon, 19 Jun 2017 16:28:51 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 211219] NIC status does not pass into a state of "no carrier" after disconnecting the cable. Date: Mon, 19 Jun 2017 16:28:51 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: IntelNetworking X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: erj@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 16:28:51 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211219 --- Comment #35 from Eric Joyner --- (In reply to pete from comment #34) I don't think this change is causing your problem. It only changes somethin= g in an 82574-specific conditional. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Mon Jun 19 20:49:21 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3FF99DA4498 for ; Mon, 19 Jun 2017 20:49:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2D96283704 for ; Mon, 19 Jun 2017 20:49:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5JKnKop070327 for ; Mon, 19 Jun 2017 20:49:21 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220076] [patch] [panic] [netgraph] repeatable kernel panic due to a race in ng_iface(4) Date: Mon, 19 Jun 2017 20:49:21 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: peixoto.cassiano@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: mfc-stable10? mfc-stable11? X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 20:49:21 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220076 Cassiano Peixoto changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |freebsd-net@FreeBSD.org --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Mon Jun 19 20:49:31 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0471BDA44C0 for ; Mon, 19 Jun 2017 20:49:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E653183792 for ; Mon, 19 Jun 2017 20:49:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5JKnUWk070628 for ; Mon, 19 Jun 2017 20:49:30 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220078] [patch] [panic] [ipfw] repeatable kernel panic due to unlocked INADDR_TO_IFP usage Date: Mon, 19 Jun 2017 20:49:31 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: peixoto.cassiano@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ipfw@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 20:49:31 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220078 Cassiano Peixoto changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |freebsd-net@FreeBSD.org --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Mon Jun 19 20:51:17 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B633DA45CE for ; Mon, 19 Jun 2017 20:51:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7962383A2D for ; Mon, 19 Jun 2017 20:51:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5JKpHVd075323 for ; Mon, 19 Jun 2017 20:51:17 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220078] [patch] [panic] [ipfw] repeatable kernel panic due to unlocked INADDR_TO_IFP usage Date: Mon, 19 Jun 2017 20:51:17 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: eugen@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ipfw@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 20:51:17 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220078 --- Comment #7 from Eugene Grosbein --- (In reply to Cassiano Peixoto from comment #6) This PR presents several patches for several kernel subsystems. Apply patches for ip_mcast.c and ip_input(). The patch for ipfw is only needed if you use ipfw and have a rule with "me" keyword like "allow ip from any to me". Better use version by ae@ (https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D183590). The patch for stf(4) is only needed if you use stf(4). --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Mon Jun 19 20:55:21 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BD418DA47F8 for ; Mon, 19 Jun 2017 20:55:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AB58C83D52 for ; Mon, 19 Jun 2017 20:55:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5JKtL9E091731 for ; Mon, 19 Jun 2017 20:55:21 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220078] [patch] [panic] [ipfw] repeatable kernel panic due to unlocked INADDR_TO_IFP usage Date: Mon, 19 Jun 2017 20:55:21 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: peixoto.cassiano@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ipfw@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 20:55:21 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220078 --- Comment #8 from Cassiano Peixoto --- (In reply to Eugene Grosbein from comment #7) Do i need to recompile the world or only the kernel? --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Mon Jun 19 20:57:46 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C6251DA491B for ; Mon, 19 Jun 2017 20:57:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B3B1283EBB for ; Mon, 19 Jun 2017 20:57:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5JKvkpb095153 for ; Mon, 19 Jun 2017 20:57:46 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220078] [patch] [panic] [ipfw] repeatable kernel panic due to unlocked INADDR_TO_IFP usage Date: Mon, 19 Jun 2017 20:57:47 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: eugen@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ipfw@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 20:57:46 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220078 --- Comment #9 from Eugene Grosbein --- (In reply to Cassiano Peixoto from comment #8) Kernel only. --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Mon Jun 19 21:04:23 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B3C5EDA4B9A for ; Mon, 19 Jun 2017 21:04:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A201E84379 for ; Mon, 19 Jun 2017 21:04:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5JL4NXZ073839 for ; Mon, 19 Jun 2017 21:04:23 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220078] [patch] [panic] [ipfw] repeatable kernel panic due to unlocked INADDR_TO_IFP usage Date: Mon, 19 Jun 2017 21:04:23 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: peixoto.cassiano@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ipfw@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 21:04:23 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220078 --- Comment #10 from Cassiano Peixoto --- (In reply to Eugene Grosbein from comment #9) mcast has been reject: # patch < mcast.patch=20 Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- sys/netinet/in_mcast.c.orig 2017-04-20 15:01:10.786840000 +0700 |+++ sys/netinet/in_mcast.c 2017-06-17 18:24:34.034823000 +0700 -------------------------- Patching file sys/netinet/in_mcast.c using Plan A... Hunk #1 succeeded at 1340 (offset 2 lines). Hunk #2 succeeded at 1378 (offset 2 lines). Hunk #3 succeeded at 1878 (offset 2 lines). Hunk #4 succeeded at 1895 (offset 2 lines). Hunk #5 succeeded at 2229 (offset 2 lines). Hunk #6 failed at 2288. Hunk #7 succeeded at 2452 (offset 2 lines). Hunk #8 succeeded at 2491 (offset 2 lines). 1 out of 8 hunks failed--saving rejects to sys/netinet/in_mcast.c.rej done Exit 1 # cat sys/netinet/in_mcast.c.rej @@ -2283,9 +2288,11 @@ * XXX NOTE WELL: The RFC 3678 API is preferred because * using an IPv4 address as a key is racy. */ - if (!in_nullhost(mreqs.imr_interface)) + if (!in_nullhost(mreqs.imr_interface)) { + IN_IFADDR_RLOCK(&in_ifa_tracker); INADDR_TO_IFP(mreqs.imr_interface, ifp); - + IN_IFADDR_RUNLOCK(&in_ifa_tracker); + } CTR3(KTR_IGMPV3, "%s: imr_interface =3D 0x%08x, ifp =3D %p", __func__, ntohl(mreqs.imr_interface.s_addr), ifp); --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Mon Jun 19 21:30:17 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 53951DA5171 for ; Mon, 19 Jun 2017 21:30:17 +0000 (UTC) (envelope-from teresa@marketingprosper.com) Received: from IND01-BO1-obe.outbound.protection.outlook.com (mail-bo1ind01on0084.outbound.protection.outlook.com [104.47.101.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 679CC87 for ; Mon, 19 Jun 2017 21:30:15 +0000 (UTC) (envelope-from teresa@marketingprosper.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=saga21.onmicrosoft.com; s=selector1-saga21-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=pcAGjOeG1cDcd0RNCE4vfWjfxJdjjgqWIPurr3Soki4=; b=mJpSDmAHDUOXaRYmxC7R7uMrlQ2L0REgI/u24KJcD/kn9UqQgOpkR8wCM72Fh6FgwXlkzTQgB3lrY5/NRR8OHqXCA12LbQrrzNbZY+YBVfYFmhl7JzG9HsjnL5f1tkjfHIA8WkDNmTxUTCUnUc0R70F2STjXX83SpqSs5QmwcCM= Received: from BM1PR01MB0787.INDPRD01.PROD.OUTLOOK.COM (10.174.210.20) by BM1PR01MB0787.INDPRD01.PROD.OUTLOOK.COM (10.174.210.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1178.14; Mon, 19 Jun 2017 21:30:11 +0000 Received: from BM1PR01MB0787.INDPRD01.PROD.OUTLOOK.COM ([10.174.210.20]) by BM1PR01MB0787.INDPRD01.PROD.OUTLOOK.COM ([10.174.210.20]) with mapi id 15.01.1178.018; Mon, 19 Jun 2017 21:30:11 +0000 From: teresa a To: "freebsd-net@freebsd.org" Subject: RE: Solution Seekers| Facility Management Thread-Topic: RE: Solution Seekers| Facility Management Thread-Index: AdLpQuo0cFDndCZ2TxyL0iVZEATHiQ== Importance: high X-Priority: 1 Date: Mon, 19 Jun 2017 21:29:55 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=none action=none header.from=marketingprosper.com; x-originating-ip: [49.205.216.204] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BM1PR01MB0787; 7:ZCCGRh0ospgCPp7RDf8i88+8Y2L1ih6UOaztVyK8zG5ZO8vtr9m36uscXgZpWcmhAjCi6lXRQfYaB3GU3/qd7O9l6gYXWxk45B9Of1+WK/+s6E4+RvnrxeOVCBCc9rNdAa3CqAMZnAFDHPrXg9zdGKlLD9dw+y0LH5r16BURFa9xL40biIVVWTFRDTtN+hI2Mrs7HXteg89GF2SVACDLgolc/eMswpGwTJxeiTWlzdfRlsgXugko0oIyefjKApMsetW0XcvHC3pmcQWy/vg9oWwh041VDLsX+AjB52CzQhD8UikcDQyhLF3k4PRybyl0dBWZLT6IziU6yt1z7zqg69ZIFJlkqmtE9xeCtbf79CH+TH/OwWt5VKbPOhOaNiK+eCj4BIB3PPCgZWR8hAKa+jQ9LGDjiadLbVcRspDBD2CRqHApINQZ0Yu/Rpan6YVh1OvvEYGhTYcU0umhkXEmTPYqf7uGTrUluAvIOtx0hnOtuLnpC/Cqx6UpOMdibS2W5Bz0DEj81xxlgWgoPBdZ5t2AukbI75XsBF5GkHzCudS5WXJ+LUM+crGnyp67u4BmTClpRkY1nHOmqU6k3n0iCbH2zwP438q/+kAH327EJgFOQZoacxWpw6w1sxw4qk51Q7MxXvQdUEn2sBotwbL2OYupb4smhjiQphKWLR6BaDkGehoUEU1k9LCi7/W1jltN+XJqmp+cHsrn5p+KDDo1f167/8Y9DD6Yb2a9D833w3HJloSfFlQbvrQFeWGvEzmAa77b7tuKBM22uAg/Qc5N1DMtYgN72QP97nTW386f1wk= x-ms-office365-filtering-correlation-id: a514f4bb-4a9c-44ba-024d-08d4b75a5e09 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081); SRVR:BM1PR01MB0787; x-ms-traffictypediagnostic: BM1PR01MB0787: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(21748063052155); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(6018075)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6041248)(20161123560025)(20161123555025)(20161123558100)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BM1PR01MB0787; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BM1PR01MB0787; x-forefront-prvs: 0343AC1D30 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39830400002)(39400400002)(39410400002)(39450400003)(2501003)(77096006)(25786009)(5660300001)(122556002)(5630700001)(86362001)(2900100001)(7736002)(229853002)(66066001)(6506006)(6916009)(14454004)(2351001)(6436002)(54896002)(9686003)(6306002)(6246003)(74316002)(478600001)(6666003)(3660700001)(8936002)(3280700002)(189998001)(53936002)(2906002)(54356999)(81686999)(50986999)(102836003)(3846002)(8676002)(790700001)(7696004)(6116002)(55016002)(110136004)(86152003)(38730400002)(5640700003)(81166006)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:BM1PR01MB0787; H:BM1PR01MB0787.INDPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; MLV:ovrnspm; PTR:InfoNoRecords; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: marketingprosper.com X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jun 2017 21:29:55.6794 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 924d4210-31f9-46ad-89b6-dd67a51da0ab X-MS-Exchange-Transport-CrossTenantHeadersStamped: BM1PR01MB0787 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 21:30:17 -0000 Hi, I am Teresa from B2B Data Group., Following one of our recent market studie= s; we have compiled a list of Facility Management Professionals and this li= st can be used for your marketing initiatives, to provide them your Solutio= ns. The list has been based on the following requirements: * Key Decision Makers- (C-Level, V&D Level| O&M Operations Man= agers| Facilitators| Real Estate Management Service Provider| Business Serv= ice Builders| Developers| Realtors| Lab Operators| General Service Manager= s| Supervisors| Facility Managers| Executives| Technicians| Building Operat= ions & Real Estate Professionals| Building Managers| Manager of Mail & Copy= Services Persons| Workplace Service Coordinators| Construction Professiona= ls and more across the globe. * Industries: -Healthcare| Commercial Buildings| Janitorial Se= rvices| Office Complexes| Medical Facilities| Industrial & Warehouse| Retai= l| Educational Institutions| Retail| Building and Construction| Asset Manag= ement| Life Cycle Management| Manufacturing| Restaurant| Real Estate| Finan= ce & Banking| Logistics| and more If this sounds good let me know your target audience in below format and I'= ll get back to you with sample file for free for the same. Industry/Technology : _________(Any Industry/Technology) Job Title : _________(Any Job Title) Geography : _________(Worldwide) Looking forward to your response Best Regards, Teresa| Marketing Coordinator To discontinue receiving email from us, reply as "NO" From owner-freebsd-net@freebsd.org Mon Jun 19 21:44:50 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 55BC3DA5526 for ; Mon, 19 Jun 2017 21:44:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 438F7AC7 for ; Mon, 19 Jun 2017 21:44:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5JLinHh042818 for ; Mon, 19 Jun 2017 21:44:50 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220078] [patch] [panic] [ipfw] repeatable kernel panic due to unlocked INADDR_TO_IFP usage Date: Mon, 19 Jun 2017 21:44:49 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: eugen@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ipfw@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 21:44:50 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220078 --- Comment #11 from Eugene Grosbein --- (In reply to Cassiano Peixoto from comment #10) You have revision earlier than 315456 that changed context for this patch: - CTR3(KTR_IGMPV3, "%s: imr_interface =3D %s, ifp =3D %p", - __func__, inet_ntoa(mreqs.imr_interface), ifp); + CTR3(KTR_IGMPV3, "%s: imr_interface =3D 0x%08x, ifp =3D %p", + __func__, ntohl(mreqs.imr_interface.s_addr), ifp); That's not big deal. Either apply this small chunk manually, or update your system to latest stable/11. --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Mon Jun 19 21:47:18 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5E9F3DA572B for ; Mon, 19 Jun 2017 21:47:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4C7BFC86 for ; Mon, 19 Jun 2017 21:47:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5JLlIIq046048 for ; Mon, 19 Jun 2017 21:47:18 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220078] [patch] [panic] [ipfw] repeatable kernel panic due to unlocked INADDR_TO_IFP usage Date: Mon, 19 Jun 2017 21:47:18 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: eugen@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ipfw@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jun 2017 21:47:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220078 --- Comment #12 from Eugene Grosbein --- (In reply to Cassiano Peixoto from comment #10) You can also just skip this patch for now if your system does not process a= ny multicast traffic including routing protocols like OSPF or RIPv2. --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Tue Jun 20 03:03:36 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 38508D8B7D8 for ; Tue, 20 Jun 2017 03:03:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 25CE66F0CD for ; Tue, 20 Jun 2017 03:03:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5K33Xta030419 for ; Tue, 20 Jun 2017 03:03:35 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 186114] net/mpd5 hangs after a certain number of users connect Date: Tue, 20 Jun 2017 03:03:33 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: eugen@freebsd.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2017 03:03:36 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D186114 --- Comment #74 from Kubilay Kocak --- (In reply to Eugene Grosbein from comment #73) I order to ensure that (base) change is tracked and merged correctly, I'd recommend (as suggested in comment 69) creating a separate dependent issue = so that it can be: - Assigned to kib (as distinct from this overarching issue) - Tracked for MFC's correctly and completely - Used to notify/inform release engineering specifically and only for that change --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Tue Jun 20 09:51:58 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 80719D94122 for ; Tue, 20 Jun 2017 09:51:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6AD487B086 for ; Tue, 20 Jun 2017 09:51:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5K9puCL067323 for ; Tue, 20 Jun 2017 09:51:58 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 186114] net/mpd5 hangs after a certain number of users connect Date: Tue, 20 Jun 2017 09:51:57 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: eugen@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: eugen@freebsd.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2017 09:51:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D186114 --- Comment #75 from Eugene Grosbein --- (In reply to Kubilay Kocak from comment #74) Done: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220151 Konstantin Belousov (author of the patch) is in the re@, so this team shoul= d be aware of the problem. --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Tue Jun 20 11:02:45 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8233DD957E7 for ; Tue, 20 Jun 2017 11:02:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 679387D0E5 for ; Tue, 20 Jun 2017 11:02:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5KB2jb6072207 for ; Tue, 20 Jun 2017 11:02:45 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 186114] net/mpd5 hangs after a certain number of users connect Date: Tue, 20 Jun 2017 11:02:45 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: eugen@freebsd.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: dependson Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2017 11:02:45 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D186114 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |220151 Referenced Bugs: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220151 [Bug 220151] [libc] syslog() thread unsafety: mutex lock leak --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Tue Jun 20 12:18:25 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2644BD9731D for ; Tue, 20 Jun 2017 12:18:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0DCE37F520 for ; Tue, 20 Jun 2017 12:18:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5KCIO4O085283 for ; Tue, 20 Jun 2017 12:18:24 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220078] [patch] [panic] [ipfw] repeatable kernel panic due to unlocked INADDR_TO_IFP usage Date: Tue, 20 Jun 2017 12:18:24 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: peixoto.cassiano@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ipfw@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2017 12:18:25 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220078 --- Comment #13 from Cassiano Peixoto --- (In reply to Eugene Grosbein from comment #11) There is a reference for CTR3() 3 times in the code. Should i replace all of them? Thanks. --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Tue Jun 20 12:25:52 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A237ED97746 for ; Tue, 20 Jun 2017 12:25:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 906DB7F9AB for ; Tue, 20 Jun 2017 12:25:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5KCPpr5003710 for ; Tue, 20 Jun 2017 12:25:52 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220078] [patch] [panic] [ipfw] repeatable kernel panic due to unlocked INADDR_TO_IFP usage Date: Tue, 20 Jun 2017 12:25:52 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: eugen@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ipfw@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2017 12:25:52 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220078 --- Comment #14 from Eugene Grosbein --- (In reply to Cassiano Peixoto from comment #13) You do not need to change context of the patch. That is, do not touch lines referring to CTR3. Just make supposed change manually, e.g. add lines with IN_IFADDR_RLOCK/IN_IFADDR_RUNLOCK and fix braces. --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Tue Jun 20 13:46:55 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A9BC7D994A8 for ; Tue, 20 Jun 2017 13:46:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9777683615 for ; Tue, 20 Jun 2017 13:46:55 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5KDksWX028485 for ; Tue, 20 Jun 2017 13:46:55 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220078] [patch] [panic] [ipfw] repeatable kernel panic due to unlocked INADDR_TO_IFP usage Date: Tue, 20 Jun 2017 13:46:55 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: peixoto.cassiano@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ipfw@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2017 13:46:55 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220078 --- Comment #15 from Cassiano Peixoto --- (In reply to Eugene Grosbein from comment #14) Ok got it. Patch applied fine. Thanks. --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Tue Jun 20 17:05:19 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A77F4D9D351 for ; Tue, 20 Jun 2017 17:05:19 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from mail.ignoranthack.me (ignoranthack.me [199.102.79.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7684066CB7 for ; Tue, 20 Jun 2017 17:05:19 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from [10.246.11.20] (wsip-70-166-117-91.ph.ph.cox.net [70.166.117.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sbruno@ignoranthack.me) by mail.ignoranthack.me (Postfix) with ESMTPSA id 215321928AB for ; Tue, 20 Jun 2017 17:05:17 +0000 (UTC) From: Sean Bruno Subject: Re: igb stats double counting in 12-CURRENT r319025 To: freebsd-net@freebsd.org References: Message-ID: Date: Tue, 20 Jun 2017 11:05:16 -0600 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7aJ0eSIddRmegBUmGIIdUDnhn6xted7SU" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2017 17:05:19 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7aJ0eSIddRmegBUmGIIdUDnhn6xted7SU Content-Type: multipart/mixed; boundary="J9xU5j9h7H3le3kClVUAaJNtswIeHxktq"; protected-headers="v1" From: Sean Bruno To: freebsd-net@freebsd.org Message-ID: Subject: Re: igb stats double counting in 12-CURRENT r319025 References: In-Reply-To: --J9xU5j9h7H3le3kClVUAaJNtswIeHxktq Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 06/03/17 01:25, Ben Woods wrote: > Hi everyone, >=20 > I have noticed my networking statistics appear to be double counting on= two > of my FreeBSD 12-CURRENT boxes running r319025. Could someone please he= lp > me to find the problem (I believe it is likely to be a bug in the > networking driver). >=20 > I discovered the double counting by comparing the output of "systat > -ifstat" (which reports 988 KB/s) with the output of "iftop -B" (which > reports 491 KB/s). I know that iftop is the correct one, because my > internet speed only gives me around ~500 KB/s unfortunately. >=20 > # systat -ifstat -match igb0 > ... > Interface Traffic Peak Tot= al > igb0 in 988.008 KB/s 988.008 KB/s 36.29= 5 GB > out 16.953 KB/s 16.953 KB/s 295.77= 4 GB >=20 >=20 > # iftop -i igb0 -B > ... > TX: cum: 31.7KB peak: > 9.69KB > rates: 9.69KB 7.92KB 7.92KB > RX: 1.54MB > 491KB > 491KB 394KB 394KB >=20 >=20 > The two interfaces in these boxes are: >=20 > $ pciconf -lvv | grep igb1 -A4 > igb1@pci0:4:0:0: class=3D0x020000 card=3D0x00008086 chip=3D0x153= 98086 > rev=3D0x03 hdr=3D0x00 > vendor =3D 'Intel Corporation' > device =3D 'I211 Gigabit Network Connection' > class =3D network > subclass =3D ethernet >=20 > $ pciconf -lvv | grep igb0 -A4 > igb0@pci0:8:0:0: class=3D0x020000 card=3D0x15331849 chip=3D0x153= 38086 > rev=3D0x03 hdr=3D0x00 > vendor =3D 'Intel Corporation' > device =3D 'I210 Gigabit Network Connection' > class =3D network > subclass =3D ethernet >=20 > Regards, > Ben >=20 > -- > From: Benjamin Woods > woodsb02@gmail.com > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >=20 Huh ... I'll look at this today. If you get a chance, throw this over into bugzilla and tag me in it. sean --J9xU5j9h7H3le3kClVUAaJNtswIeHxktq-- --7aJ0eSIddRmegBUmGIIdUDnhn6xted7SU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEE6MTp+IA1BOHj9Lo0veT1/om1/LYFAllJVc1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEU4 QzRFOUY4ODAzNTA0RTFFM0Y0QkEzNEJERTRGNUZFODlCNUZDQjYACgkQveT1/om1 /LYQ7wgAv3q0LKkoFrEOntz+8HB0ul63cZPFPHrCE+/NBURctdq37Pc8zG4hLelH gywaEPrq8ciWA+j3Ie1qztXcnUlfmuWAvRFoGf5zKGDbQCpE2TUqkKtel1pjyKcf 6fieR+kgT8mU9MXAs8nxlL2oVf/lON+ExyJ4GqRcMhvd7xF3RNFfE56eWevjXZts rPMJ98abur/wUmSfyThXLNhfg+m+IMS9dS/7jwXAjxe0mf/JT2We3x5NZNjriZis 9lVA0TOJBtdNVxY9P75DEvvedAjCKUjYaqqvfNV3o56FyXxr63TicLJEyU7T+AQu FaveIA5b1fLp4o2jcZ2uQcLysde2sQ== =GaQt -----END PGP SIGNATURE----- --7aJ0eSIddRmegBUmGIIdUDnhn6xted7SU-- From owner-freebsd-net@freebsd.org Tue Jun 20 18:09:23 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF588D9E3C5 for ; Tue, 20 Jun 2017 18:09:23 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: from mail-ua0-x232.google.com (mail-ua0-x232.google.com [IPv6:2607:f8b0:400c:c08::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7DF0768C2B; Tue, 20 Jun 2017 18:09:23 +0000 (UTC) (envelope-from garga.bsd@gmail.com) Received: by mail-ua0-x232.google.com with SMTP id j53so76129428uaa.2; Tue, 20 Jun 2017 11:09:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:to:from:subject:cc:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=a5TVybPIbKrlwNXHm9zuaXqr0xA1GAwCarTA0hmfG1I=; b=m/wsLMgjyZbPpjcwz4h57BrVEviRbR/yODT+ask1vSXCUzJLh2e5JYBalkzOxeXG3u h/CnHWkYsyMww8LVHTMo6YvEX/aOWIhfd/tGHAEpFKJqCoJ4Lrvivz5hkuNl9dhGeale p4ELzbq00IJhqcFWtiXCP33GUPn2CJtbh6uIj1ndbHQ70rV0N9cQXN2Miua1VzRVw3gT bhj3Jzfi/76xab6vYs9BxQZ1xTj6uav5kcue/Wy+ovkIM9IeA/JaMsf4sw8zSBIBIIwM xAwHCFVJoyQdmcjw+4Fg1KPe0JUBkTE8piinRWiin4eJx6dzZif4KeYbdPNQ4Sj5t4Fw 26Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:to:from:subject:cc:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=a5TVybPIbKrlwNXHm9zuaXqr0xA1GAwCarTA0hmfG1I=; b=mcrOgReVxOmw15YB+HnrsWh2Ucjv+4ZiJMXdGC3mwxeWbEmdnHTVyVse4TwqEseqNX dz73J37LWwiiKJU2KXxHStO2hkYgWI0eMPmQGyOJZ8XQfV6soT3ogB0uvnTurc/uVpxn MRmGXG5uQjM2ywvScji5gNRNoAfWjuSGQWjakblzq0D6AI58KWtcLxDn8pb0Ew5nUSrR fYb/L/Xu7NJU7KZhyqLQ8KrpzKFu/mOm78NwKusyI0/O6TK6MLWzJLAUt5xVRoCGPcwc QYDVsgQ/sjS9LQfQqRS463kvjmeXTEU2bgYGVC/sCwiV9tiZzlCxNCzXq21ATsx1C346 aczQ== X-Gm-Message-State: AKS2vOxMqDFID0DuYzKb+r/YXWV3Hr8HaMpPHJ+78OA5ZlcdLMM6+WFQ xZGLI7Ukh3GHef72cJc= X-Received: by 10.176.67.98 with SMTP id k89mr3499290uak.103.1497982162036; Tue, 20 Jun 2017 11:09:22 -0700 (PDT) Received: from mbp-eth.home ([177.53.86.172]) by smtp.gmail.com with ESMTPSA id i5sm3682796uaa.6.2017.06.20.11.09.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Jun 2017 11:09:21 -0700 (PDT) Sender: Renato Botelho To: freebsd-net@freebsd.org From: Renato Botelho Subject: Failover Mode Between Ethernet and Wireless Interfaces Cc: adrian@FreeBSD.org Message-ID: <86519ec0-64f0-9395-cafc-95ab8599f1ca@FreeBSD.org> Date: Tue, 20 Jun 2017 15:09:18 -0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2017 18:09:23 -0000 Last night I was configuring a new laptop and decided to give it [1] a try. I figured out this section of handbook (similar instructions are on lagg(4) manpage) is outdated, based on FreeBSD 10.x. Then I modified a bit the commands and tried to get it configured on 12-CURRENT, without success. I spoke with adrian@, who told me this setup doesn't work on FreeBSD > 10, because on newer versions Wireless interfaces mac address cannot be changed. My next attempt was to do the other way round and make lagg to use wlan0 mac address instead of em0's. but even doing this my wireless interface ended up not working. After further investigation I noted that a simple command: # ifconfig wlan0 ether $wlan0_current_mac_address is enough to break it on 12-CURRENT. I've checked if_setlladdr() source code and noted it always replace the mac address, even if the same is already configured on the interface. Is it the expected behavior? Just as a PoC I've applied the following patch to if_setlladdr(): Index: sys/net/if.c =================================================================== --- sys/net/if.c (revision 320097) +++ sys/net/if.c (working copy) @@ -3519,6 +3519,10 @@ ifa_free(ifa); return (EINVAL); } + if (memcmp(lladdr, LLADDR(sdl), len) == 0) { + ifa_free(ifa); + return (0); + } switch (ifp->if_type) { case IFT_ETHER: case IFT_FDDI: And configured it to use wlan0 mac address on rc.conf: ifconfig_em0="ether 60:67:20:c5:2d:48 up" wlans_iwn0="wlan0" ifconfig_wlan0="WPA" cloned_interfaces="lagg0" ifconfig_lagg0="up laggproto failover laggport em0 laggport wlan0 DHCP" and it's now working as expected. Other than that, I believe if wlan interfaces cannot have their mac address changed, ifconfig should return an error when user attempts to do it, and if_setlladdr() should do the same. Thoughts? [1] https://www.freebsd.org/doc/handbook/network-aggregation.html#networking-lagg-wired-and-wireless -- Renato Botelho From owner-freebsd-net@freebsd.org Tue Jun 20 18:54:14 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 85EF0D9F757 for ; Tue, 20 Jun 2017 18:54:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 716256ED49 for ; Tue, 20 Jun 2017 18:54:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5KIs9DB079316 for ; Tue, 20 Jun 2017 18:54:14 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 186114] net/mpd5 hangs after a certain number of users connect Date: Tue, 20 Jun 2017 18:54:10 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: peixoto.cassiano@gmail.com X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: eugen@freebsd.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2017 18:54:14 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D186114 --- Comment #76 from Cassiano Peixoto --- (In reply to Eugene Grosbein from comment #75) Eugene, are you going to provide all these patches to FreeBSD 10-STABLE? --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Tue Jun 20 19:31:01 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 099D2DA03C3 for ; Tue, 20 Jun 2017 19:31:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E66DA701D4 for ; Tue, 20 Jun 2017 19:31:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5KJV0RV077301 for ; Tue, 20 Jun 2017 19:31:00 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 186114] net/mpd5 hangs after a certain number of users connect Date: Tue, 20 Jun 2017 19:31:00 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: crash, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: eugen@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: eugen@freebsd.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2017 19:31:01 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D186114 --- Comment #77 from Eugene Grosbein --- (In reply to Cassiano Peixoto from comment #76) All patches are pretty simple and should just work for 10.x --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-net@freebsd.org Wed Jun 21 03:31:54 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DB47BDA82E7 for ; Wed, 21 Jun 2017 03:31:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C6BE07E2F1 for ; Wed, 21 Jun 2017 03:31:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5L3VrpR047758 for ; Wed, 21 Jun 2017 03:31:54 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220170] Can't load tcpmd5 kernel module due to missing ipsec_support Date: Wed, 21 Jun 2017 03:31:53 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 03:31:55 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220170 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ae@FreeBSD.org Assignee|freebsd-bugs@FreeBSD.org |freebsd-net@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Jun 21 05:45:44 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E4A9DD86DFB for ; Wed, 21 Jun 2017 05:45:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C541E81166 for ; Wed, 21 Jun 2017 05:45:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5L5jikQ011849 for ; Wed, 21 Jun 2017 05:45:44 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220170] Can't load tcpmd5 kernel module due to missing ipsec_support Date: Wed, 21 Jun 2017 05:45:45 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: ae@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 05:45:45 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220170 Andrey V. Elsukov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |re@FreeBSD.org --- Comment #1 from Andrey V. Elsukov --- I didn't have the goal to make TCP-MD5 loadable. This code was related to IPsec, and I had to redo it. So, it is just a bonus of projects/ipsec. I th= ink it is too late to add IPSEC_SUPPORT to the GENERIC at time of producing the release. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Jun 21 23:25:28 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6F190D9AF4A for ; Wed, 21 Jun 2017 23:25:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5D5B6822C5 for ; Wed, 21 Jun 2017 23:25:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5LNPSe4089111 for ; Wed, 21 Jun 2017 23:25:28 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220198] igb stats double counting in 12-CURRENT Date: Wed, 21 Jun 2017 23:25:28 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: woodsb02@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 23:25:28 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220198 Ben Woods changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbruno@FreeBSD.org Assignee|freebsd-bugs@FreeBSD.org |freebsd-net@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Wed Jun 21 23:29:48 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 99572D9B144 for ; Wed, 21 Jun 2017 23:29:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 86FD082582 for ; Wed, 21 Jun 2017 23:29:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5LNTmYi095432 for ; Wed, 21 Jun 2017 23:29:48 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220198] igb stats double counting in 12-CURRENT Date: Wed, 21 Jun 2017 23:29:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: IntelNetworking X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: woodsb02@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 23:29:48 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220198 Ben Woods changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |IntelNetworking --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-net@freebsd.org Thu Jun 22 22:58:18 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BAAC7D96226 for ; Thu, 22 Jun 2017 22:58:18 +0000 (UTC) (envelope-from prvs=339ef6e64=youssef.ghorbal@pasteur.fr) Received: from mx0.pasteur.fr (mx0.pasteur.fr [157.99.45.50]) (using TLSv1.2 with cipher RC4-SHA (128/128 bits)) (Client CN "Cisco Appliance Demo Certificate", Issuer "Cisco Appliance Demo Certificate" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 1841A68D24 for ; Thu, 22 Jun 2017 22:58:17 +0000 (UTC) (envelope-from prvs=339ef6e64=youssef.ghorbal@pasteur.fr) Authentication-Results: mx0.pasteur.fr; spf=None smtp.pra=youssef.ghorbal@pasteur.fr; spf=None smtp.mailfrom=youssef.ghorbal@pasteur.fr; spf=None smtp.helo=postmaster@EXCHANGE01.corp.pasteur.fr Received-SPF: None (mx0.pasteur.fr: no sender authenticity information available from domain of youssef.ghorbal@pasteur.fr) identity=pra; client-ip=157.99.211.31; receiver=mx0.pasteur.fr; envelope-from="youssef.ghorbal@pasteur.fr"; x-sender="youssef.ghorbal@pasteur.fr"; x-conformance=sidf_compatible Received-SPF: None (mx0.pasteur.fr: no sender authenticity information available from domain of youssef.ghorbal@pasteur.fr) identity=mailfrom; client-ip=157.99.211.31; receiver=mx0.pasteur.fr; envelope-from="youssef.ghorbal@pasteur.fr"; x-sender="youssef.ghorbal@pasteur.fr"; x-conformance=sidf_compatible Received-SPF: None (mx0.pasteur.fr: no sender authenticity information available from domain of postmaster@EXCHANGE01.corp.pasteur.fr) identity=helo; client-ip=157.99.211.31; receiver=mx0.pasteur.fr; envelope-from="youssef.ghorbal@pasteur.fr"; x-sender="postmaster@EXCHANGE01.corp.pasteur.fr"; x-conformance=sidf_compatible X-IronPort-AV: E=Sophos;i="5.39,374,1493676000"; d="scan'208";a="1347628" Received: from exchange01.corp.pasteur.fr ([157.99.211.31]) by mx0.pasteur.fr with ESMTP/TLS/AES256-GCM-SHA384; 23 Jun 2017 00:57:03 +0200 Received: from exchange00.corp.pasteur.fr (157.99.211.253) by EXCHANGE01.corp.pasteur.fr (157.99.211.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34; Fri, 23 Jun 2017 00:57:03 +0200 Received: from EXCHANGE02.corp.pasteur.fr (157.99.211.32) by exchange00.corp.pasteur.fr (157.99.211.253) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34; Fri, 23 Jun 2017 00:57:03 +0200 Received: from EXCHANGE02.corp.pasteur.fr ([fe80::a819:199f:2049:3d20]) by EXCHANGE02.corp.pasteur.fr ([fe80::a819:199f:2049:3d20%18]) with mapi id 15.01.0845.034; Fri, 23 Jun 2017 00:57:01 +0200 From: "Youssef GHORBAL" To: "freebsd-net@freebsd.org" Subject: Sporadic TCP/RST sent to client Thread-Topic: Sporadic TCP/RST sent to client Thread-Index: AQHS66rbXenakl+Z70SNEJ7M0BITJQ== Date: Thu, 22 Jun 2017 22:57:01 +0000 Message-ID: <84CB0795-B28E-46DF-9593-4C1BAAB7DDF5@pasteur.fr> Accept-Language: en-US, fr-FR Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [157.99.101.114] Content-Type: text/plain; charset="us-ascii" Content-ID: <05377CD832F6314B9DC9346320657E2B@corp.pasteur.fr> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jun 2017 22:58:18 -0000 Hello, I'm having an issue with a FreeBSD 11 based system, sending sporadically T= CP/RST to clients after initial TCP session correctly initiated. The sequence goes this way : 1 Client -> Server : SYN 2 Server -> Client : SYN/ACK 3 Client -> Server : ACK 4 Client -> Server : PSH/ACK (upper protocol data sending starts here) 5 Server -> Client : RST =09 - The problem happens sporadically, same client and same server can commun= icate smoothely on the same service port. But from time to time (hours, som= etime days) the previous sequence happens. - The service running on server is not responsible for the RST sent. The s= ervice was deeply profiled and nothing happens to justify the RST. - tcpdump on the server side assures that packet arrives timely ordered. - the traffic is very light. Some TCP sessions per day. - the server is connected using a lagg enslaving two cxgb interfaces. In my effort to diagnose the problem (try to have a reproductible test cas= e) I noticed that the issue is triggered most likely when those two conditi= ons are met : - the ACK (in step 3) and the PSH/ACK (in step 4) arrive on different lagg= NICs. - the timing between those two packets is sub 10 microseconds. When searching the interwebs I came across a strangely similar issue repor= ted here 7 years ago : https://lists.freebsd.org/pipermail/freebsd-net/2010-August/026029.html (The OP seemed to have resolved his issue changing the netisr policy from = direct to hybrid. but no reference of laggs being used) I'm pretty sure that I'm hitting some race condition, a scenario where due= to multithreading the PSH/ACK is somehow handled before the ACK making the= kernel rising TCP/RST since the initial TCP handshake did'nt finish yet. I've read about netisr work and I was under the impression that even if it= 's SMP enabled it was made to keep prorocol ordering. What's the expected behaviour in this scenario on the netisr side ? How can I push the investigation further ? Youssef Ghorbal From owner-freebsd-net@freebsd.org Sat Jun 24 03:22:11 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DDC62D94788 for ; Sat, 24 Jun 2017 03:22:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id CC5CA7FD38 for ; Sat, 24 Jun 2017 03:22:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v5O3MBkl002956 for ; Sat, 24 Jun 2017 03:22:11 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 220240] sys/dev/xl/if_xl.c: A possible sleep-under-mutex bug in xl_list_rx_init Date: Sat, 24 Jun 2017 03:22:12 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: baijiaju1990@163.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Jun 2017 03:22:12 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D220240 Jia-Ju Bai changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |freebsd-net@FreeBSD.org --=20 You are receiving this mail because: You are on the CC list for the bug.=