From owner-freebsd-net@freebsd.org Mon Sep 11 03:01:54 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8C7A8E15035 for ; Mon, 11 Sep 2017 03:01:54 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mail-qt0-x236.google.com (mail-qt0-x236.google.com [IPv6:2607:f8b0:400d:c0d::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5562C6CB72; Mon, 11 Sep 2017 03:01:54 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mail-qt0-x236.google.com with SMTP id b1so6915941qtc.4; Sun, 10 Sep 2017 20:01:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=sHjsis+JsAvR0oqiHxVaaSZY5IC9dQWQ0z6vVyP/A04=; b=j2BGuY9gEatyLwp5TK6QQXrPvuFnXucN0lMKL9K5IrvWlMO9ZobZVe9BaWpEx7fyIg SHM2gFRq1kqu9ocSy33Uo0a5v4Pecn2jM39xF5lbbwukNx2ybPPMp+I7ZaSsU+vkfBSX wlvMfG9PpbeYutQB3KQ9IqbmLFcMPSrukcedbwCx1+RhywoTqRT4+bt3+3vuiv63bthy cvvaO0oUxU7p3caFEeqiPOvL0fCZ7dsU+P5cJ9sILl3o6iXonbTo4viI2yXA8iafRwHT wPre+bi2u+qhICWTjFE0dR59NB7K4kMgihnpUuPt3Fj4dEp83U2Xx3m5bQv3xz8tQ6CI X8NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=sHjsis+JsAvR0oqiHxVaaSZY5IC9dQWQ0z6vVyP/A04=; b=VuQFuJ8hTIKnQfFupP64gJsvrxaNGx/vjj1KdbcN/04+8FV57u9jydQ/18kGsvd9Bg 5mdbbfCqoTBHTVdlS8AmmDX4E6GFMsDfp7lplrDhm+gFneCYbl+iDyXGiFyMtYXgapeM zQwyhrDmeWerkYnd+Qk/JA0sOFUtlgyC9FPo7yJxOidUa7eHejH/YNDD+gHdJ5um6CT2 QEYyFuf7RY0hfbk7Q2gsBumeOynD9fDHLSdI4Z5fb1d7q7D3vFw3mAbfNJdgDu6qL7R+ Wsnb+rH7XXu+tZT9jNu5HJx8OrDunlroIJZpO8HhX9kMbsI3bsG3KKRxgYrQ2gGO1MQb R4mA== X-Gm-Message-State: AHPjjUhNldwby9P4bSKK1Fzpp0lTM+5dY0zXmxOXiVGN37RLAPWB0yMo 91QMxBxCA3XDPBCM0pkXAvkFq0xuepJ7 X-Google-Smtp-Source: AOwi7QB0Z4SX3Ya3nDWeGcIt96128wB4FsEr4AQUWtsrlkHgs86FdZ+vEc+73UqQ8H4bFVXOZw870SuYooLbpz0yS1Q= X-Received: by 10.200.24.203 with SMTP id o11mr14579278qtk.35.1505098913092; Sun, 10 Sep 2017 20:01:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.106.102 with HTTP; Sun, 10 Sep 2017 20:01:52 -0700 (PDT) From: Sepherosa Ziehau Date: Mon, 11 Sep 2017 11:01:52 +0800 Message-ID: Subject: ixl(4) RSS hash type To: "freebsd-net@freebsd.org" , Sean Bruno , erj@freebsd.org, Robert Watson , Adrian Chadd , Andrew Gallatin Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 03:01:54 -0000 Hi all, I am on the way to cleanup the UDP_IPV4_EX bit. The only effective consumer of this undefined RSS hash type is ixl. So I took a bit close look at it, then I have several question about its hash type configuration: ixl_set_rss_pctypes(). It tries to set hash for IPV6 fragment, if RSS_IPV6_EX is set for "options RSS". RSS_IPV6_EX never meant IPV6 fragments: https://docs.microsoft.com/en-us/windows-hardware/drivers/network/rss-hashing-types#ndishashipv6ex ixl_ptype_to_hash(). As far as I understand, the decoded.outer_frag means "outer packet header indicates a fragment", which has nothing to do with the any of the IPV6_EX related bits: https://docs.microsoft.com/en-us/windows-hardware/drivers/network/rss-hashing-types I believe these all should be fixed. Thanks, sephe -- Tomorrow Will Never Die