From owner-freebsd-python@freebsd.org Mon Sep 4 03:34:58 2017 Return-Path: Delivered-To: freebsd-python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D4B66E0E95D for ; Mon, 4 Sep 2017 03:34:58 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id AC7AA3617 for ; Mon, 4 Sep 2017 03:34:58 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id A8C24E0E95A; Mon, 4 Sep 2017 03:34:58 +0000 (UTC) Delivered-To: python@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A7D4BE0E959; Mon, 4 Sep 2017 03:34:58 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg0-x22e.google.com (mail-pg0-x22e.google.com [IPv6:2607:f8b0:400e:c05::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7249B3616; Mon, 4 Sep 2017 03:34:58 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg0-x22e.google.com with SMTP id t193so15323907pgc.1; Sun, 03 Sep 2017 20:34:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:references:from:cc:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=273vEYY+RKxqMR9lW1uDlYklc1HioAlrH2fTT9qTOgg=; b=n/LcbDzQYEIlJYqFkbrcII7LYjh49n93wz83KSyFQuo5+rYn52y4LZHkG4XzSFWAW3 wfdewNqDs6SA97b8cumcnXlM6iSkqdJVTlOFH8xuMYrqNazdLfcas7JgL2XlQ65F2ysm RBu/g4TXUghWVwf9Tc+GC0uz4mTc0OLx7WZDOXT32a4FokLEn/rrfZWhnPVb6Gaf2hoE ktAmgh9RLoBgzoom9Bipm22RlsYuR6B01Q3CL0ay3ID2meJznfvYd409liA4X8dNBWDg 7q3Aa50RB6P8eHyU0Wi8Vd1M/vFrV3MHiY4CdpC18zgX4c9hVegctxviJ2GJrSwRsevL Thbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:references:from:cc :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=273vEYY+RKxqMR9lW1uDlYklc1HioAlrH2fTT9qTOgg=; b=KiHdspDnFaULell2hoTGSSHARuD7gazDaNqIicTfnjEmTxkKGiAdIYm8Y2XQ18kemy sXaWewUcdurW83t6aUXO8wV2rPl62gJYOKUL7vIuJolqtsRYPtB14a0YoWvUF3+yP35K afqn9YksQj4el2FZE+zq4lywrD4Gq6dLQ97g1pxchRqEcWMz/KX6bqn4nUhRVhXW0uxC IaEf/0Okm4NCfghBVEcUFiCaqKtUSqHPeP0iNSpdHqe7pdF/Pmwajz7m0wvX8UQxz2ZS 4DGZmlz7M2ztJuofqmuwrmgE8rmql/+5BJ291cEiAdjxsHXme1RuMzOH5YsXwGPO+iw3 tUhw== X-Gm-Message-State: AHPjjUhN/8X9okJvyjq7icQp2BoDfXtCMIpaiZQ2qTWwN52pRLVJE5v3 9KwVLq5wIh83IDlSu9Q= X-Google-Smtp-Source: ADKCNb6Y6bF3ANvS5vEyTWffnRdOP9rGVrt79I5KVlr4J23Du7P+LUTuiWEBiBJye6dpLXQ6uvCwDw== X-Received: by 10.99.166.18 with SMTP id t18mr4891249pge.227.1504496097644; Sun, 03 Sep 2017 20:34:57 -0700 (PDT) Received: from ?IPv6:2001:44b8:31ae:7b01:584:283a:c57e:de2a? (2001-44b8-31ae-7b01-0584-283a-c57e-de2a.static.ipv6.internode.on.net. [2001:44b8:31ae:7b01:584:283a:c57e:de2a]) by smtp.gmail.com with ESMTPSA id i127sm9049675pgc.73.2017.09.03.20.34.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Sep 2017 20:34:57 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r449195 - head/security/py-cryptography To: Rene Ladan , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201709031028.v83AS09e027702@repo.freebsd.org> From: Kubilay Kocak Cc: "python@freebsd.org" Message-ID: <96b4bb9f-dc46-ffea-bd49-a5949b5b7365@FreeBSD.org> Date: Mon, 4 Sep 2017 13:29:05 +1000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Thunderbird/54.0a2 MIME-Version: 1.0 In-Reply-To: <201709031028.v83AS09e027702@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-AU Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Sep 2017 03:34:58 -0000 On 9/3/17 8:28 PM, Rene Ladan wrote: > Author: rene > Date: Sun Sep 3 10:28:00 2017 > New Revision: 449195 > URL: https://svnweb.freebsd.org/changeset/ports/449195 > > Log: > security/py-cryptography: remove support for expired Python 3.3 > > Modified: > head/security/py-cryptography/Makefile > > Modified: head/security/py-cryptography/Makefile > ============================================================================== > --- head/security/py-cryptography/Makefile Sun Sep 3 10:12:26 2017 (r449194) > +++ head/security/py-cryptography/Makefile Sun Sep 3 10:28:00 2017 (r449195) > @@ -35,8 +35,6 @@ RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}ipaddress>0:net/p > > .if ${PYTHON_REL} < 3300 > RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}enum34>0:devel/py-enum34 > -.elif ${PYTHON_REL} < 3400 > -RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}enum34>0:devel/py3-enum34 > .endif > > post-install: > Please revert this change: - It is *meant* to include all versions below 3.4, including 2.7 - It is not necessary to delete when a python language port version is removed. The block still semantically and correctly declares the valid version dependency requirements from the upstream, independently from what the tree has at any point in time. Also, if you could, please ask/talk to python maintainers and/or python@ with regard to port deprecation/deletions before committing. It is not always entirely obvious or explicit what is the correct thing to do is without fully understanding the versions support and semantics completely.