From owner-freebsd-rc@freebsd.org Sun Oct 1 06:13:30 2017 Return-Path: Delivered-To: freebsd-rc@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 515BCE2BFA3 for ; Sun, 1 Oct 2017 06:13:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4020D7571B for ; Sun, 1 Oct 2017 06:13:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v916DSrq097386 for ; Sun, 1 Oct 2017 06:13:30 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-rc@FreeBSD.org Subject: [Bug 216115] service -e showing sendmail enabled when it is not Date: Sun, 01 Oct 2017 06:13:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: conf X-Bugzilla-Version: 11.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: ak@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-rc@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Oct 2017 06:13:30 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D216115 Alex Kozlov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ak@FreeBSD.org --- Comment #6 from Alex Kozlov --- /etc/rc.subr checks: 933 if [ -n "$_pidcmd" ]; then 934 _keywords=3D"${_keywords} status poll" 935 fi but a few lines above $_pidcmd set to: 928 if [ -n "$pidfile" ]; then 929 _pidcmd=3D'rc_pid=3D$(check_pidfile '"$pidfile $_procname $command_interpreter"')' 930 else 931 _pidcmd=3D'rc_pid=3D$(check_process '"$_procname $command_interprete= r"')' fi so line 933 condition is always true: [ -n 'rc_pid=3D$(check_pidfile /var/run/sendmail.pid /usr/sbin/sendmail )' ] and status and poll commands are always added to keywords. This should help: Index: /etc/rc.subr @@ -930,7 +930,7 @@ else _pidcmd=3D'rc_pid=3D$(check_process '"$_procname $command_interpreter"')' fi - if [ -n "$_pidcmd" ]; then + if [ -n "$(eval "$_pidcmd")" ]; then _keywords=3D"${_keywords} status poll" fi fi --=20 You are receiving this mail because: You are the assignee for the bug.=