From owner-freebsd-stable@freebsd.org  Mon Oct 30 13:57:15 2017
Return-Path: <owner-freebsd-stable@freebsd.org>
Delivered-To: freebsd-stable@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9669DE5D8C8
 for <freebsd-stable@mailman.ysv.freebsd.org>;
 Mon, 30 Oct 2017 13:57:15 +0000 (UTC) (envelope-from mike@sentex.net)
Received: from smarthost2.sentex.ca (smarthost2.sentex.ca
 [IPv6:2607:f3e0:80:80::2])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client CN "smarthost.sentex.ca", Issuer "smarthost.sentex.ca" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2FB2A6331F
 for <freebsd-stable@freebsd.org>; Mon, 30 Oct 2017 13:57:14 +0000 (UTC)
 (envelope-from mike@sentex.net)
Received: from lava.sentex.ca (lava.sentex.ca [IPv6:2607:f3e0:0:5::11])
 by smarthost2.sentex.ca (8.15.2/8.15.2) with ESMTPS id v9UDvCwm042545
 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO)
 for <freebsd-stable@freebsd.org>; Mon, 30 Oct 2017 09:57:12 -0400 (EDT)
 (envelope-from mike@sentex.net)
Received: from [192.168.43.26] (saphire3.sentex.net [192.168.43.26])
 by lava.sentex.ca (8.15.2/8.15.2) with ESMTP id v9UDv9h6049888;
 Mon, 30 Oct 2017 09:57:10 -0400 (EDT) (envelope-from mike@sentex.net)
Subject: Re: ppp routing bug ?
To: Eugene Grosbein <eugen@grosbein.net>,
 FreeBSD-STABLE Mailing List <freebsd-stable@freebsd.org>
References: <bdb4d277-40ca-5a8e-f0e0-c1734a0c88c6@sentex.net>
 <a23ed8b3-1050-12d5-6a7c-1a1a0c174251@sentex.net>
 <59F1B650.5070107@grosbein.net>
 <22c3cbd4-2a8e-884f-ec9b-cc4d12ff818f@sentex.net>
 <59F1EA48.1090500@grosbein.net>
 <a019ac21-fd1a-6f69-257f-4c03515ec963@sentex.net>
 <59F206CB.5000006@grosbein.net>
 <98f44309-d706-4cef-c0b2-0f08e0e1855c@sentex.net>
 <59F25ED0.1010001@grosbein.net>
From: Mike Tancsa <mike@sentex.net>
Organization: Sentex Communications
Message-ID: <082408ba-b756-696f-5885-226e4ccbd2ea@sentex.net>
Date: Mon, 30 Oct 2017 09:57:09 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <59F25ED0.1010001@grosbein.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.78
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-stable>, 
 <mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable/>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
 <mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Oct 2017 13:57:15 -0000

On 10/26/2017 6:16 PM, Eugene Grosbein wrote:
> 
> That makes sense: ppp send bogus request to the routing socket and
> the request has not RTF_HOST flag nor RTA_NETMASK address.
> It seems, earlier kernel code masked this bug somehow but it does not now.
> 
> Anyway, we have two bugs here: ppp sending bad request and kernel having
> no enough checks for this somehow.
> 
> Fixing ppp part would be easy. Please try this patch:


Hi, Thanks again for the fix.
	Any chance of committing this to HEAD and then an MFC ?

	---Mike


-- 
-------------------
Mike Tancsa, tel +1 519 651 3400
Sentex Communications, mike@sentex.net
Providing Internet services since 1994 www.sentex.net
Cambridge, Ontario Canada   http://www.tancsa.com/