From owner-freebsd-wireless@freebsd.org Sun Oct 1 05:21:51 2017 Return-Path: Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A04B5E26428 for ; Sun, 1 Oct 2017 05:21:51 +0000 (UTC) (envelope-from khanzf@gmail.com) Received: from mail-qk0-x22d.google.com (mail-qk0-x22d.google.com [IPv6:2607:f8b0:400d:c09::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2CDAD73C90 for ; Sun, 1 Oct 2017 05:21:51 +0000 (UTC) (envelope-from khanzf@gmail.com) Received: by mail-qk0-x22d.google.com with SMTP id c67so2136665qkg.2 for ; Sat, 30 Sep 2017 22:21:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=6D3326gWv4sTpt4PCQ0oOEC7JUVnESKp/J4w2+DEVIE=; b=XvcDRxhsNFyYrOqnbVXC5s68xiB/RWkTQNLa1/VTNiBuhPirrvy5+PtMIgHwhFM9/w lslkwe3DxpHsl0DJtFbLxSUi2IPIjegioCEYkKHISzI0Bu5ET+KAhwOeFQCzEi2HBMbi cbcvCAiiz6f+pgGo3/BYX1NLvXqzf7hG+W3Rtfan6lw8rTtP9/H72FR8FgvVi9PKKkpg D6TNibTU3TEbHi1lUSsOZb5baMoPUzF38QwigTUEyaMv2S2+HzNVJaXRdsMnFHe3V5lF 3up1A6Q0X+4jmHAcM5GqZg98pOO+mkw+7BRM1KmUedQC8GcbWjST0zDvpqKHDWOaFS0O enJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=6D3326gWv4sTpt4PCQ0oOEC7JUVnESKp/J4w2+DEVIE=; b=tlUZzm4eXyW3G9cV1u6D4hvns6sRxjK9lUc9T5m/Wd0ZU3Z46zgmprVBEN8fJrRjOO hV3K1iaEFJU73mbXSiJGagzaS1AM0uL0CxD4RqFOq5shg3Dw31teu20E9t0/vog5/QEh D8rb5M5LBB40bqfErGzqv7isGdlpdKm65gLgaeB6+Hp1nmqNLmDsbpQ1uP2CjVkkqLTA k7y17h1THiqIZVSJGEJchGLkdlR5GJk3gUEGtpDOEOeKoHEk2p6G4qXRLsgu+RGmELY1 biBFnX76XkzS66ekXNbnTbxydyx9hCrLO4BWRa84oS3tiH/elVuH0Po02y3MWK0lfx3j YvsQ== X-Gm-Message-State: AMCzsaUF7SiZNU6OIVUgRZ/HRnr+TiEjG8uaDZL78QQ8quDhRON9p1XM WN1oQ4l1mCrDdwAdYwFNZicflMmK X-Google-Smtp-Source: AOwi7QDu1s4XCxAIJT8QmqAgynNm+wWS5GkU5Z2HZEm4rUrrPcuXCCjuKwhGZ7zPL5sez1ubXiCXSw== X-Received: by 10.55.102.13 with SMTP id a13mr9866435qkc.320.1506835310047; Sat, 30 Sep 2017 22:21:50 -0700 (PDT) Received: from pc.farhan.codes ([2001:470:8:209:ee25:a59b:55f4:7cc]) by smtp.gmail.com with ESMTPSA id q49sm5284738qta.80.2017.09.30.22.21.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 30 Sep 2017 22:21:49 -0700 (PDT) From: Farhan Khan To: freebsd-wireless@freebsd.org Subject: Register Address Size Mismatch Message-ID: <293228d3-c777-d928-8476-ee23ba487c72@gmail.com> Date: Sun, 1 Oct 2017 01:21:48 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Oct 2017 05:21:51 -0000 I am working on porting over a Linux Realtek driver to FreeBSD. I ran into a register-size issue. FreeBSD's PCI-write function is defined as follows: rtwn_pci_write_4(struct rtwn_softc *sc, uint16_t addr) Notice that the second parameter is of type uint16_t. During initialization, the rtwn driver uses the rtwn_rf_prog structure to write a pre-defined list of data to a pre-defined list of registers. The structure to hold both lists is defined here: http://src.illumos.org/source/xref/freebsd-head/sys/dev/rtwn/if_rtwnreg.h#150. Notice how the second parameter 'reg' is a uint8_t. The rtwn_pci_write_4's addr is uint16_t, the rtwn_rf_prog's addr is a uint8_t. How would I reconcile this type mismatch? Additionally, the Linux version of this block of code has all register values as a uint32_t. It is not a matter of a cast, because some values definitely use more than 1 byte (ie 0xFFE). Suggestions on how to reconcile and resolve this issue? Thanks! Farhan Khan