From owner-freebsd-wireless@freebsd.org  Wed Dec  6 10:09:47 2017
Return-Path: <owner-freebsd-wireless@freebsd.org>
Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C9071E9B4D8
 for <freebsd-wireless@mailman.ysv.freebsd.org>;
 Wed,  6 Dec 2017 10:09:47 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B66606BC62
 for <freebsd-wireless@FreeBSD.org>; Wed,  6 Dec 2017 10:09:47 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vB6A9lBw067135
 for <freebsd-wireless@FreeBSD.org>; Wed, 6 Dec 2017 10:09:47 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-wireless@FreeBSD.org
Subject: [Bug 224141] possible Off-by-one bug in the Base64 decoding in the
 wpa supplicant
Date: Wed, 06 Dec 2017 10:09:47 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: wireless
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: ikostov@gmail.com
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-wireless@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-224141-21060@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-wireless@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "Discussions of 802.11 stack,
 tools device driver development." <freebsd-wireless.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-wireless>, 
 <mailto:freebsd-wireless-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-wireless/>
List-Post: <mailto:freebsd-wireless@freebsd.org>
List-Help: <mailto:freebsd-wireless-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
 <mailto:freebsd-wireless-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Dec 2017 10:09:47 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D224141

            Bug ID: 224141
           Summary: possible Off-by-one bug in the Base64 decoding in the
                    wpa supplicant
           Product: Base System
           Version: CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: wireless
          Assignee: freebsd-wireless@FreeBSD.org
          Reporter: ikostov@gmail.com

Hi guys,

I think there is an issue with the base64 decode function:

from http://web.mit.edu/freebsd/head/contrib/wpa/src/utils/base64.c

unsigned char * base64_decode(const unsigned char *src, size_t len,
                              size_t *out_len)
{
......
        for (i =3D 0; i < sizeof(base64_table) - 1; i++)
                dtable[base64_table[i]] =3D (unsigned char) i;
.....

the problem is the for loop which initializes the dtable. It does not
initialize the last element from the table ('/') which causes the char to be
interpreted as a garbage and ignored. Please have a closer look.

Best regards,
Ivan

--=20
You are receiving this mail because:
You are the assignee for the bug.=