From owner-freebsd-xfce@freebsd.org Sun Nov 26 12:03:13 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4368EDE2387 for ; Sun, 26 Nov 2017 12:03:13 +0000 (UTC) (envelope-from portscout@FreeBSD.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 2EC6269018 for ; Sun, 26 Nov 2017 12:03:13 +0000 (UTC) (envelope-from portscout@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 2E1D5DE2386; Sun, 26 Nov 2017 12:03:13 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2DBC5DE2385 for ; Sun, 26 Nov 2017 12:03:13 +0000 (UTC) (envelope-from portscout@FreeBSD.org) Received: from portscout.ysv.freebsd.org (portscout.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1FF8869017 for ; Sun, 26 Nov 2017 12:03:13 +0000 (UTC) (envelope-from portscout@FreeBSD.org) Received: from portscout.ysv.freebsd.org ([127.0.1.123]) by portscout.ysv.freebsd.org (8.15.2/8.15.2) with ESMTP id vAQC3DCM002279 for ; Sun, 26 Nov 2017 12:03:13 GMT (envelope-from portscout@FreeBSD.org) Received: (from portscout@localhost) by portscout.ysv.freebsd.org (8.15.2/8.15.2/Submit) id vAQC3CWe002263; Sun, 26 Nov 2017 12:03:12 GMT (envelope-from portscout@FreeBSD.org) Message-Id: <201711261203.vAQC3CWe002263@portscout.ysv.freebsd.org> X-Authentication-Warning: portscout.ysv.freebsd.org: portscout set sender to portscout@FreeBSD.org using -f Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain MIME-Version: 1.0 Date: Sun, 26 Nov 2017 12:03:12 +0000 From: portscout@FreeBSD.org To: xfce@freebsd.org Subject: FreeBSD ports you maintain which are out of date X-Mailer: portscout/0.8.1 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Nov 2017 12:03:13 -0000 Dear port maintainer, The portscout new distfile checker has detected that one or more of your ports appears to be out of date. Please take the opportunity to check each of the ports listed below, and if possible and appropriate, submit/commit an update. If any ports have already been updated, you can safely ignore the entry. You will not be e-mailed again for any of the port/version combinations below. Full details can be found at the following URL: http://portscout.freebsd.org/xfce@freebsd.org.html Port | Current version | New version ------------------------------------------------+-----------------+------------ x11-fm/thunar | 1.6.12 | 1.7.0 ------------------------------------------------+-----------------+------------ If any of the above results are invalid, please check the following page for details on how to improve portscout's detection and selection of distfiles on a per-port basis: http://portscout.freebsd.org/info/portscout-portconfig.txt Thanks. From owner-freebsd-xfce@freebsd.org Sun Nov 26 20:50:05 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 457C3DF02F9 for ; Sun, 26 Nov 2017 20:50:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 2B3F577469 for ; Sun, 26 Nov 2017 20:50:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 27B81DF02F8; Sun, 26 Nov 2017 20:50:05 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 27584DF02F7 for ; Sun, 26 Nov 2017 20:50:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 12FF177468 for ; Sun, 26 Nov 2017 20:50:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vAQKo4ZZ048142 for ; Sun, 26 Nov 2017 20:50:04 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 217946] x11-fm/thunar dumps core on file or dir rename Date: Sun, 26 Nov 2017 20:50:05 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: tablooaraz@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xfce@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Nov 2017 20:50:05 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D217946 vali gholami changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tablooaraz@gmail.com --- Comment #25 from vali gholami --- =DA=86=D9=86=D8=A7=D9=86=DA=86=D9=87 =D9=86=DB=8C=D8=A7=D8=B2=D9=85=D9=86= =D8=AF =D8=A8=DA=A9 =D9=84=DB=8C=D9=86=DA=A9 =D8=AF=D8=B1 =D8=B3=D8=A7=DB= =8C=D8=AA=D9=87=D8=A7=DB=8C =D8=B2=DB=8C=D8=B1 =D8=A8=D9=88=D8=AF=DB=8C=D8= =AF =D8=AA=D9=85=D8=A7=D8=B3 =D8=A8=DA=AF=DB=8C=D8=B1=DB=8C=D8=AF=20 09125879258 =D8=BA=D9=84=D8=A7=D9=85=DB=8C http://00014.ir http://1-flymusic.ir http://8y8.ir http://abanshargh.ir http://akstoaks.ir http://alibaba-fans.ir http://alvand-ads.ir http://amingames.ir http://amlake-pasargad.ir http://androidsystem.ir http://arax24.ir http://arax724.ir http://armanhardware.ir http://arsisgame.ir http://asanban.ir http://asanbaran.ir http://asgas.ir http://ashanews.ir http://asl-ic.ir http://astakala.ir http://atromarket.ir http://azarpajang.ir http://bahartent.ir http://bartarresins.ir http://bazigaranesahne.ir http://bermudasystem.ir http://buyclockfantasy.ir http://cs8.ir http://d77.ir http://dresskade.ir http://drhesabisch.ir http://editexpert.ir http://eemenshop.ir http://ehsa30.ir http://elameharighearjmand.ir http://e-larestan.ir http://elsku.ir http://emadcenter.ir http://eta90.ir http://far30sms.ir http://fixpost.ir http://fsbigroup.ir http://gemgem.ir http://glutenfree.ir http://group-software.ir http://harim-pak.ir http://hdserial.ir http://healthplanner.ir http://homana-nikooei.ir http://honardorcheh.ir http://honarshiraz.ir http://hsplaser.ir http://insat.ir http://iranitb.ir http://iranvmag.ir http://irboiler.ir http://isuntrade.ir http://ithandmade.ir http://jahantest1.ir http://karevanhayeqadir.ir http://kashmarsalam.ir http://kconf.ir http://kore2iran.ir http://kosar-kala.ir http://mahdidevotees.ir http://marjaehamayesh.ir http://mgolden.ir http://mhosein.ir http://mohsenmirzazadeh.ir http://myalibabamusic.ir http://nama94.ir http://nettrick.ir http://niaze-rooz.ir http://noaradecor.ir http://nod32-pass.ir http://novindpfile.ir http://n-vasegh.ir http://parlpd.ir http://photoselfi.ir http://pooyawood.ir http://roofbam.ir http://saadatedu.ir http://saba-gostar.ir http://sadafwood.ir http://sadcover.ir http://s-amini.ir http://sarebanekavir.ir http://sazmansokhan.ir http://shafaghgostaran.ir http://shandizasansor.ir http://sh-iranshahr.ir http://sms7000.ir http://sogandmusic.ir http://steelfood.ir http://sticker1.ir http://technoguard.ir http://tegolestan.ir http://telegramup.ir http://torbat24.ir http://trustech.ir http://turkmenili.ir http://vray4max.ir http://winsoftware.ir http://www.3hf.ir http://www.4drupal.ir http://www.arazinet.ir http://www.arianagame.ir http://www.clickbartar.ir http://www.commaxstoreco.ir http://www.daryabchat.ir http://www.eset-ir.ir http://www.marketstudies.ir http://www.raadmehr.ir http://www.rcmb.ir http://www.shahinmag.ir http://www.starfam.ir http://www.steel-industrial.ir http://www.suqr.ir http://www.tajervenizi.ir http://www.zarrindesign.ir http://yahoo-shop.ir http://www.amar365.ir http://09123498298.ir http://pamar.ir http://arazproje.ir http://signsaras.ir http://signsaraz.ir http://signsfarahan.ir http://suleforosh.ir http://tabloosazi.ir http://zaminforosh.ir http://9125879258.ir http://9375883058.ir http://www.lbfarahan.ir http://www.ghfarahan.ir http://pix-land.blogfa.com http://projeamar.blog.ir http://projectstatis.blogfa.com http://projectstatis.rozblog.com http://projectstatistics.blog.ir http://projectstatistics.niloblog.com http://projectstats.avablog.ir http://projectstats.blog.ir http://projectstats.javanblog.ir http://projectstats.samenblog.com http://projectstats1.blogfa.com http://projectstatus.avablog.ir http://prozhe-amar.blogfa.com http://spam.blogfa.com http://stats09375883058.blogfa.com http://projeamari.blogfa.com http://projectanalysis.mihanblog.com http://statisticsproject.blogfa.com http://tahghighstan.blogfa.com http://www.amar101.blogfa.com http://saheldarya.7blog.ir http://pezeshkyar.arisfa.com http://Shabebarfi.armanblog.ir http://varzeshsara.avablog.ir http://Azadweb.azadblog.com http://Batoo.b88.ir http://dostan.bestblog.ir http://Toristi.bigsite.ir http://Tarane18.blog.ir http://Hambaazi.blogfa.com http://estekhdami.blogia.ir http://behtarinha.blogiran.net http://Musicnaab.blognovin.com http://baharnarenj.blogparsi.com http://Molodi.blogpart.ir http://Bestgirl.blograz.ir http://razesalamati1.blogsky.com http://Alghameh.blogtarin.com http://deklameh.blogtez.com http://taranoom18.blogveb.com http://dabirestani.deyblog.ir http://amozeshyar.eklablog.com http://donyayenet.epage.ir http://mamnoo.famblog.ir http://tabasom.farazblog.com http://daneshjoei.fardblog.com http://Nemonehsoal.farsiblog.com http://tabestoon.geblog.ir http://maghaleh.iran.sc http://funkadeh.iranblag.com http://fotoax.jahanblog.net http://shabgard.jasaz.com http://jazadkadeh.javanblog.ir http://khabarjadid.limooblog.com http://tanzkadeh.loxblog.com http://tahghigh18.mihanblog.com http://niazmandiha.mojblog.ir http://niazsara.monoblog.ir http://divari.nedablog.ir http://Darham.niazblog.ir http://dabestan.niloblog.com http://salamati.novinblog.net http://dehati.parsablog.com http://Baharnews.parsiblog.com http://tanhatarin.parsunit.com http://doghalb.persianblog.ir http://yadgari.ratablog.com http://baharestan.roomfa.com http://modkadeh.royablog.ir http://sargarmi724.rozblog.com http://webmasteri.samenblog.com http://mosaferati.shblog.ir http://gardeshgari.sitearia.ir http://Khandani.smu.ir http://ahangjadid.takblog.net http://filmjadid.tarlog.com http://mashinbaz.tibablog.ir http://lebasmajlesi.tinablog.ir http://backlink724.titrblog.ir http://bazigaran.toonblog.ir http://pishwaz.twoblog.ir http://madahi.wblog.xyz http://hotelyar.yektablog.net --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-xfce@freebsd.org Mon Nov 27 11:24:34 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01FB2DFE83E for ; Mon, 27 Nov 2017 11:24:34 +0000 (UTC) (envelope-from portscout@FreeBSD.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id E1E5F6D0A6 for ; Mon, 27 Nov 2017 11:24:33 +0000 (UTC) (envelope-from portscout@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id E12B5DFE83D; Mon, 27 Nov 2017 11:24:33 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E0CA8DFE83C for ; Mon, 27 Nov 2017 11:24:33 +0000 (UTC) (envelope-from portscout@FreeBSD.org) Received: from portscout.ysv.freebsd.org (portscout.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D30E36D0A5 for ; Mon, 27 Nov 2017 11:24:33 +0000 (UTC) (envelope-from portscout@FreeBSD.org) Received: from portscout.ysv.freebsd.org ([127.0.1.123]) by portscout.ysv.freebsd.org (8.15.2/8.15.2) with ESMTP id vARBOX5c060806 for ; Mon, 27 Nov 2017 11:24:33 GMT (envelope-from portscout@FreeBSD.org) Received: (from portscout@localhost) by portscout.ysv.freebsd.org (8.15.2/8.15.2/Submit) id vARBOXjD060804; Mon, 27 Nov 2017 11:24:33 GMT (envelope-from portscout@FreeBSD.org) Message-Id: <201711271124.vARBOXjD060804@portscout.ysv.freebsd.org> X-Authentication-Warning: portscout.ysv.freebsd.org: portscout set sender to portscout@FreeBSD.org using -f Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain MIME-Version: 1.0 Date: Mon, 27 Nov 2017 11:24:33 +0000 From: portscout@FreeBSD.org To: xfce@freebsd.org Subject: FreeBSD ports you maintain which are out of date X-Mailer: portscout/0.8.1 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Nov 2017 11:24:34 -0000 Dear port maintainer, The portscout new distfile checker has detected that one or more of your ports appears to be out of date. Please take the opportunity to check each of the ports listed below, and if possible and appropriate, submit/commit an update. If any ports have already been updated, you can safely ignore the entry. You will not be e-mailed again for any of the port/version combinations below. Full details can be found at the following URL: http://portscout.freebsd.org/xfce@freebsd.org.html Port | Current version | New version ------------------------------------------------+-----------------+------------ audio/xfce4-pulseaudio-plugin | 0.2.5 | 0.3.3 ------------------------------------------------+-----------------+------------ If any of the above results are invalid, please check the following page for details on how to improve portscout's detection and selection of distfiles on a per-port basis: http://portscout.freebsd.org/info/portscout-portconfig.txt Thanks. From owner-freebsd-xfce@freebsd.org Tue Nov 28 13:12:21 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 68F83E563EF for ; Tue, 28 Nov 2017 13:12:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 511A864519 for ; Tue, 28 Nov 2017 13:12:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 4D2BFE563ED; Tue, 28 Nov 2017 13:12:21 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4CD10E563EB for ; Tue, 28 Nov 2017 13:12:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3B5B064518 for ; Tue, 28 Nov 2017 13:12:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vASDCLC7087178 for ; Tue, 28 Nov 2017 13:12:21 GMT (envelope-from bugzilla-noreply@freebsd.org) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: maintainer-feedback requested: [Bug 223937] [patch] sysutils/xfce4-wavelan-plugin fix memory leak due to CSS changes Date: Tue, 28 Nov 2017 13:12:21 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xfce@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 13:12:21 -0000 J.R. Oldroyd has reassigned Bugzilla Automation 's request for maintainer-feedback to xfce@FreeBSD.or= g: Bug 223937: [patch] sysutils/xfce4-wavelan-plugin fix memory leak due to CSS changes https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223937 --- Description --- Created attachment 188351 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D188351&action= =3Dedit patch to fix memory leak due to Gtk3 CSS changes The recent upstream changes to support Gtk3 CSS introduce a rampant memory = leak because the css_provider is re-created every time through the loop. Attach= ed patch ensures that the css_provider is only created once. I am attaching a FreeBSD port patch as this memory leak is significant and needs an immediate fix. I will also submit a bug report upstream in order to have this problem fixed there, too. From owner-freebsd-xfce@freebsd.org Tue Nov 28 13:12:21 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8EA68E563F4 for ; Tue, 28 Nov 2017 13:12:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 75E246451C for ; Tue, 28 Nov 2017 13:12:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 752A1E563F2; Tue, 28 Nov 2017 13:12:21 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 74DCAE563F0 for ; Tue, 28 Nov 2017 13:12:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 62BB56451B for ; Tue, 28 Nov 2017 13:12:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vASDCLC9087178 for ; Tue, 28 Nov 2017 13:12:21 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 223937] [patch] sysutils/xfce4-wavelan-plugin fix memory leak due to CSS changes Date: Tue, 28 Nov 2017 13:12:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: fbsd@opal.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xfce@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 13:12:21 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223937 Bug ID: 223937 Summary: [patch] sysutils/xfce4-wavelan-plugin fix memory leak due to CSS changes Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: xfce@FreeBSD.org Reporter: fbsd@opal.com Keywords: patch Flags: maintainer-feedback?(xfce@FreeBSD.org) Assignee: xfce@FreeBSD.org Created attachment 188351 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D188351&action= =3Dedit patch to fix memory leak due to Gtk3 CSS changes The recent upstream changes to support Gtk3 CSS introduce a rampant memory = leak because the css_provider is re-created every time through the loop. Attach= ed patch ensures that the css_provider is only created once. I am attaching a FreeBSD port patch as this memory leak is significant and needs an immediate fix. I will also submit a bug report upstream in order to have this problem fixed there, too. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-xfce@freebsd.org Tue Nov 28 15:15:08 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E6B12DB917D for ; Tue, 28 Nov 2017 15:15:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id CD5D4681E9 for ; Tue, 28 Nov 2017 15:15:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id CCBCDDB917C; Tue, 28 Nov 2017 15:15:08 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CC661DB917B for ; Tue, 28 Nov 2017 15:15:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BA3F7681E8 for ; Tue, 28 Nov 2017 15:15:08 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vASFF8gc012408 for ; Tue, 28 Nov 2017 15:15:08 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 202192] [PATCH] x11-fm/thunar 1.6.11 change file permissions on sshfs mounted files/dirs Date: Tue, 28 Nov 2017 15:15:08 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: rozhuk.im@gmail.com X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xfce@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 15:15:09 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202192 --- Comment #4 from rozhuk.im@gmail.com --- IMHO they dont try build without HAVE_GIO_UNIX: GDesktopAppInfo is part of = gio and hey will get undefined struct/type compiler error. They patch does not work (without mine) - 100%. Upstream do many insane and crappy things, I dont want understand why :) I replace effective_user_id =3D=3D g_file_info_get_attribute_uint32 (file->info, G_FILE_ATTRIBUTE_UNIX_UID) to thunar_file_is_writable(file) All other logic not changed, just refactored to human understanding. You can use both checks via ||, like: return (effective_user_id =3D=3D g_file_info_get_attribute_uint32 (file->in= fo, G_FILE_ATTRIBUTE_UNIX_UID) || thunar_file_is_writable(file)) May be in some cases there different access levels for file data and metada= ta and original code will return TRUE is user is file owner or root. I dont know what use cases this cover, probably none. My check is simple: if file writeable than we can write metadata. This is good for most cases. I dont know how to allow user write data and restrict write metadata in unix with chmod(). In my case sshfs mounted to me (simple user), by authorized on remote side = as root. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-xfce@freebsd.org Tue Nov 28 15:22:22 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4E3DDDB94F9 for ; Tue, 28 Nov 2017 15:22:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 35EFC68797 for ; Tue, 28 Nov 2017 15:22:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 35487DB94F8; Tue, 28 Nov 2017 15:22:22 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 34EA4DB94F7 for ; Tue, 28 Nov 2017 15:22:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2235F68795 for ; Tue, 28 Nov 2017 15:22:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vASFMLWD052760 for ; Tue, 28 Nov 2017 15:22:22 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 223937] [patch] sysutils/xfce4-wavelan-plugin fix memory leak due to CSS changes Date: Tue, 28 Nov 2017 15:22:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: madpilot@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: madpilot@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: flagtypes.name assigned_to cc bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 15:22:22 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223937 Guido Falsi changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|maintainer-feedback?(xfce@F |maintainer-feedback+ |reeBSD.org) | Assignee|xfce@FreeBSD.org |madpilot@FreeBSD.org CC| |madpilot@FreeBSD.org Status|New |In Progress --- Comment #1 from Guido Falsi --- Hi, Thanks for the patch. Just to make sure I understand correctly, the "recent upstream changes" are= in the GTK3 sources? Since you are sending this upstream too, could you followup with a link to = the upstream bug so it can be tracked? It would allow avoiding to commit patches different from what is accepted upstream. In the while I'll also test it. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-xfce@freebsd.org Tue Nov 28 16:09:37 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 42942DBB049 for ; Tue, 28 Nov 2017 16:09:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 2A3616AF7C for ; Tue, 28 Nov 2017 16:09:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 269F8DBB048; Tue, 28 Nov 2017 16:09:37 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 26465DBB047 for ; Tue, 28 Nov 2017 16:09:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 138EC6AF7B for ; Tue, 28 Nov 2017 16:09:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vASG9aBq066141 for ; Tue, 28 Nov 2017 16:09:36 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 202192] [PATCH] x11-fm/thunar 1.6.11 change file permissions on sshfs mounted files/dirs Date: Tue, 28 Nov 2017 16:09:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: madpilot@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xfce@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 16:09:37 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202192 --- Comment #5 from Guido Falsi --- (In reply to rozhuk.im from comment #4) > IMHO they dont try build without HAVE_GIO_UNIX: GDesktopAppInfo is part of > gio and hey will get undefined struct/type compiler error. > They patch does not work (without mine) - 100%. >=20 > Upstream do many insane and crappy things, I dont want understand why :) First of all a general clarification: I can understand but keep in mind that ports are just that, portings. The development should happen upstream and bugfixes should go there where t= here are developers who know how the existing code works and also usually have better ability to test changes. This kind of changes which diverge from upstream tend to make maintain a po= rt difficult and could also cause regressions which end up being unjustly repo= rted upstream casting shadows on FreeBSD porting methods. I think you understand divergence with upstream should be kept to a minimum. So as a general rule I'm accepting such changes only if they are for very important bugs and have good chance of being merged upstream, or are very FreeBSD specific (which sometimes hinders upstream inclusion). For the GIO part, how do I test in the ports tree with GIO disabled? The po= rt does not have such an option, so it looks like we don't cover this condition either. >=20 > I replace > effective_user_id =3D=3D g_file_info_get_attribute_uint32 (file->info, > G_FILE_ATTRIBUTE_UNIX_UID) > to > thunar_file_is_writable(file) >=20 > All other logic not changed, just refactored to human understanding. >=20 > You can use both checks via ||, like: > return (effective_user_id =3D=3D g_file_info_get_attribute_uint32 (file->= info, > G_FILE_ATTRIBUTE_UNIX_UID) || thunar_file_is_writable(file)) >=20 > May be in some cases there different access levels for file data and > metadata and original code will return TRUE is user is file owner or root. > I dont know what use cases this cover, probably none. >=20 > My check is simple: if file writeable than we can write metadata. > This is good for most cases. > I dont know how to allow user write data and restrict write metadata in u= nix > with chmod(). As I said while I hear and understand your explanation I have no explanation about the existing code. I'm not refusing your code, and have no specific objection about it. I just need time to understand it properly. In the while if you can get your code included upstream or at least reviewe= d by an upstream developer that would greatly help this request. >=20 > In my case sshfs mounted to me (simple user), by authorized on remote side > as root. Not sure I understand, you mean that you are a plain user on the local mach= ine but authenticated as root on the ssh mount on the remote one? --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-xfce@freebsd.org Tue Nov 28 16:56:30 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 80767DE70E7 for ; Tue, 28 Nov 2017 16:56:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 639AC6E61A for ; Tue, 28 Nov 2017 16:56:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 5E062DE70E5; Tue, 28 Nov 2017 16:56:30 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5DB11DE70E3 for ; Tue, 28 Nov 2017 16:56:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4B35C6E619 for ; Tue, 28 Nov 2017 16:56:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vASGuTno084458 for ; Tue, 28 Nov 2017 16:56:30 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 202192] [PATCH] x11-fm/thunar 1.6.11 change file permissions on sshfs mounted files/dirs Date: Tue, 28 Nov 2017 16:56:30 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: madpilot@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xfce@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: flagtypes.name Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 16:56:30 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202192 Guido Falsi changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|maintainer-feedback?(xfce@F |maintainer-feedback+ |reeBSD.org) | --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-xfce@freebsd.org Tue Nov 28 18:18:07 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E01C7DEA5D8 for ; Tue, 28 Nov 2017 18:18:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id C708771FCA for ; Tue, 28 Nov 2017 18:18:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id C3316DEA5D7; Tue, 28 Nov 2017 18:18:07 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C2D15DEA5D5 for ; Tue, 28 Nov 2017 18:18:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ACE0771FC9 for ; Tue, 28 Nov 2017 18:18:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vASII7tm026854 for ; Tue, 28 Nov 2017 18:18:07 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 202192] [PATCH] x11-fm/thunar 1.6.11 change file permissions on sshfs mounted files/dirs Date: Tue, 28 Nov 2017 18:18:07 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: rozhuk.im@gmail.com X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xfce@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 18:18:08 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202192 --- Comment #6 from rozhuk.im@gmail.com --- (In reply to Guido Falsi from comment #5) https://bugzilla.xfce.org/show_bug.cgi?id=3D12863 year+ - no activity in upstream, is there are life? Yes, our port does not have GIO option, I do tests by add to makefile GIO option and uncheck it. I dont know what I need to do with upstream, they do not react on bug tacke= r. Yes, I mean that Im plain user that have sshfs root@remote mount. PS: miss null check return (thunar_file_is_writable(file) || (NULL !=3D file->info && effective_user_id =3D=3D g_file_info_get_attribute= _uint32 (file->info, G_FILE_ATTRIBUTE_UNIX_UID))) --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-xfce@freebsd.org Tue Nov 28 19:19:52 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BEC56DEBF32 for ; Tue, 28 Nov 2017 19:19:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id A5E3274606 for ; Tue, 28 Nov 2017 19:19:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id A261FDEBF2F; Tue, 28 Nov 2017 19:19:52 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A201BDEBF2E for ; Tue, 28 Nov 2017 19:19:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8F01674605 for ; Tue, 28 Nov 2017 19:19:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vASJJqXZ089431 for ; Tue, 28 Nov 2017 19:19:52 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 202192] [PATCH] x11-fm/thunar 1.6.11 change file permissions on sshfs mounted files/dirs Date: Tue, 28 Nov 2017 19:19:52 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: madpilot@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xfce@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 19:19:52 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202192 --- Comment #7 from Guido Falsi --- (In reply to rozhuk.im from comment #6) > (In reply to Guido Falsi from comment #5) >=20 > https://bugzilla.xfce.org/show_bug.cgi?id=3D12863 > year+ - no activity in upstream, is there are life? This is irrelevant and in fact against your interest to point this out. If a patch is not accepted upstream maybe there are reasons for that. Also the fact the patch is not accepted upstream, even if accepting without question it to be good, is no reason to push it in FreeBSD. It could add unexpected effects. It will also make updating the port more difficult. The patched code could = be modified upstream and the patch need reconciliation, or changes upstream can cause the patch to break. >=20 > Yes, our port does not have GIO option, I do tests by add to makefile GIO > option and uncheck it. So the GIO case is irrelevant to our ports tree. No need to diverge to fix a problem that cannot happen. >=20 >=20 > I dont know what I need to do with upstream, they do not react on bug tac= ker. >=20 While I understand your frustration I have no connection with the upstream. If you get your code accepted by upstream that is proof of a minimum qualit= y of the change and also will mean thee code will anyway get in the ports tree, = so there is no reason to hold the change. If you cannot some FreeBSD committer needs to test check and make a decisio= n, this takes time. This is a volunteer project and no one is paid for it or working full time on port bugs. Things may require time. Please give me time to evaluate your code properly. This is a "port" of the upstream code not original code. Any divergence nee= ds a good motivation. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-xfce@freebsd.org Tue Nov 28 20:59:18 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0186CDEEBA0 for ; Tue, 28 Nov 2017 20:59:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id DC51E786E7 for ; Tue, 28 Nov 2017 20:59:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id D8C2BDEEB9F; Tue, 28 Nov 2017 20:59:17 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D8681DEEB9C for ; Tue, 28 Nov 2017 20:59:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C6068786E6 for ; Tue, 28 Nov 2017 20:59:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vASKxHmU034170 for ; Tue, 28 Nov 2017 20:59:17 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 202192] [PATCH] x11-fm/thunar 1.6.11 change file permissions on sshfs mounted files/dirs Date: Tue, 28 Nov 2017 20:59:18 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: madpilot@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xfce@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 20:59:18 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202192 --- Comment #8 from Guido Falsi --- (In reply to rozhuk.im from comment #4) > My check is simple: if file writeable than we can write metadata. > This is good for most cases. > I dont know how to allow user write data and restrict write metadata in u= nix > with chmod(). Looking at the upstream code and checking how UFS works I can now say this = is definitely a wrong assumption. you can chmod any file you own, even if it is not writable, otherwise there would be no way to modify permissions on a file with 0444 permissions. obviously root can change permissions on any file. The upstream code, while a little convoluted, checks just for this, which is correct for local file systems. >=20 > In my case sshfs mounted to me (simple user), by authorized on remote side > as root. Considering the previous correction this use case is quite peculiar and difficult to accommodate. Thunar clearly checks file permissions based on the local user. But the rem= ote user is different, so it gets wrong conclusions. But I cannot see a way to = fix this except give thunar detailed knowledge of the specific remote file syst= em and the actual remote user. Anyway your patch as is cannot be accepted since it is actually wrong for t= he UFS semantics. It will work most of the time but fail in important situatio= ns (files with 0444 permissions). Looks like for some specific sshfs semantics thunar_file_is_writable(file) returns true and lets you go ahead. But it looks like a coincidence. I need= to find some information on why that checks gives a different result. The only acceptable option would be to add an || thunar_file_is_writable(fi= le) right before the "&& !thunar_file_is_trashed (file));" in the last return in the upstream code. But I still have to evaluate the consequences. I need to study sshfs a little. Your suggeestion about adding an || --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-xfce@freebsd.org Tue Nov 28 21:11:27 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B4F3BDEF153 for ; Tue, 28 Nov 2017 21:11:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 997AA78EE9 for ; Tue, 28 Nov 2017 21:11:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 95F7ADEF152; Tue, 28 Nov 2017 21:11:27 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9592DDEF151 for ; Tue, 28 Nov 2017 21:11:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 82CA278EE7 for ; Tue, 28 Nov 2017 21:11:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vASLBRvm051344 for ; Tue, 28 Nov 2017 21:11:27 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 202192] [PATCH] x11-fm/thunar 1.6.11 change file permissions on sshfs mounted files/dirs Date: Tue, 28 Nov 2017 21:11:27 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: madpilot@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Works As Intended X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xfce@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 21:11:27 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202192 Guido Falsi changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |Works As Intended Status|In Progress |Closed --- Comment #9 from Guido Falsi --- (In reply to Guido Falsi from comment #8) > (In reply to rozhuk.im from comment #4) >=20 > > My check is simple: if file writeable than we can write metadata. > > This is good for most cases. > > I dont know how to allow user write data and restrict write metadata in= unix > > with chmod(). >=20 > Looking at the upstream code and checking how UFS works I can now say this > is definitely a wrong assumption. >=20 > you can chmod any file you own, even if it is not writable, otherwise the= re > would be no way to modify permissions on a file with 0444 permissions. > obviously root can change permissions on any file. >=20 > The upstream code, while a little convoluted, checks just for this, which= is > correct for local file systems. >=20 > >=20 > > In my case sshfs mounted to me (simple user), by authorized on remote s= ide > > as root. >=20 > Considering the previous correction this use case is quite peculiar and > difficult to accommodate. >=20 > Thunar clearly checks file permissions based on the local user. But the > remote user is different, so it gets wrong conclusions. But I cannot see a > way to fix this except give thunar detailed knowledge of the specific rem= ote > file system and the actual remote user. >=20 > Anyway your patch as is cannot be accepted since it is actually wrong for > the UFS semantics. It will work most of the time but fail in important > situations (files with 0444 permissions). >=20 > Looks like for some specific sshfs semantics thunar_file_is_writable(file) > returns true and lets you go ahead. But it looks like a coincidence. I ne= ed > to find some information on why that checks gives a different result. >=20 > The only acceptable option would be to add an || > thunar_file_is_writable(file) right before the "&& !thunar_file_is_trashed > (file));" in the last return in the upstream code. But I still have to > evaluate the consequences. This is wrong too. thunar_file_is_writable(file) could return true for files you don't own (th= ink write bit on a group you are part of), so on which you can't change attribu= tes. Checking for write permissions to change attributes is unrelated. I don't know a proper way to cater for a remote file system were you access= as a different user...especially if that user is root and you are not root locally. If you find a solution please file a new bug report. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-xfce@freebsd.org Wed Nov 29 09:40:16 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8891DDFE9CB for ; Wed, 29 Nov 2017 09:40:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 6DFAB6CE92 for ; Wed, 29 Nov 2017 09:40:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 69B4BDFE9CA; Wed, 29 Nov 2017 09:40:16 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 695D0DFE9C9 for ; Wed, 29 Nov 2017 09:40:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 52C236CE8F for ; Wed, 29 Nov 2017 09:40:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vAT9eFQm096062 for ; Wed, 29 Nov 2017 09:40:16 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 202192] [PATCH] x11-fm/thunar 1.6.11 change file permissions on sshfs mounted files/dirs Date: Wed, 29 Nov 2017 09:40:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: rozhuk.im@gmail.com X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Works As Intended X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xfce@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 09:40:16 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202192 --- Comment #10 from rozhuk.im@gmail.com --- False positive - not problem, at least for me. I dont care even if it always return true without any checks. On access deny user will get error on apply, it much better than do not try chmod() because of false-negative. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-xfce@freebsd.org Wed Nov 29 10:31:24 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 485CCDFF724 for ; Wed, 29 Nov 2017 10:31:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 2F0216E9D2 for ; Wed, 29 Nov 2017 10:31:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 2DF04DFF71D; Wed, 29 Nov 2017 10:31:24 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2DA06DFF71A for ; Wed, 29 Nov 2017 10:31:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1B8566E9CF for ; Wed, 29 Nov 2017 10:31:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vATAVNbP027113 for ; Wed, 29 Nov 2017 10:31:23 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 202192] [PATCH] x11-fm/thunar 1.6.11 change file permissions on sshfs mounted files/dirs Date: Wed, 29 Nov 2017 10:31:23 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: rozhuk.im@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xfce@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: resolution bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 10:31:24 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202192 rozhuk.im@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|Works As Intended |--- Status|Closed |Open --- Comment #11 from rozhuk.im@gmail.com --- Unable to change file permissions on sshfs mounted files/dirs - cant be "wo= rk as intended". --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-xfce@freebsd.org Wed Nov 29 11:28:01 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AD5FDE4F840 for ; Wed, 29 Nov 2017 11:28:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 93CC4701AB for ; Wed, 29 Nov 2017 11:28:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 8F72FE4F83F; Wed, 29 Nov 2017 11:28:01 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8E572E4F83E for ; Wed, 29 Nov 2017 11:28:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 62283701A9 for ; Wed, 29 Nov 2017 11:28:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vATBS1kD068017 for ; Wed, 29 Nov 2017 11:28:01 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 202192] [PATCH] x11-fm/thunar 1.6.11 change file permissions on sshfs mounted files/dirs Date: Wed, 29 Nov 2017 11:28:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: madpilot@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Rejected X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xfce@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 11:28:01 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202192 Guido Falsi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Open |Closed Resolution|--- |Rejected --- Comment #12 from Guido Falsi --- (In reply to rozhuk.im from comment #10) > False positive - not problem, at least for me. > I dont care even if it always return true without any checks. >=20 > On access deny user will get error on apply, it much better than do not t= ry > chmod() because of false-negative. I agree that having that check return true would work for you, with your simplistic definition of "works". First of all consider that the ports tree is not yours, and all use cases m= ust be kept in consideration. You also must consider that the ports tree contains that, ported software. Original development must be done upstream. If the upstream does a stupid t= hing the port will also do a stupid thing. The only logical exception is when the stupid thing is caused by a specific FreeBSD difference from other OSes. In that case too at least trying to get a correct patch accepted upstream is a requirement. The upstream code shows that the xfce guys actually don't want to hit system call errors and that's the very reason why they apply such a check. Your patch is anyway definitely wrong and would give false positives and fa= lse negatives on UFS and ZFS, since write permissions are completely unrelated = to chmod usage. Returning true would be a clear breakage of upstream code. This patch is not acceptable and it looks like your use case is not catered= by upstream. So the software is "working as intended", you happen to disagree = with the intended way the upstream software should work. regarding comment 11, since you disagree on the "works as intended" resolut= ion I'll change it to a more arbitrary "rejected", so you will have one excuse = less to open this up again. I encourage you to push a correct solution with the upstream thunar develop= ers. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-xfce@freebsd.org Wed Nov 29 11:38:00 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A7AD6E4FADE for ; Wed, 29 Nov 2017 11:38:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 8F56C7053B for ; Wed, 29 Nov 2017 11:38:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 8B68CE4FADD; Wed, 29 Nov 2017 11:38:00 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B118E4FADC for ; Wed, 29 Nov 2017 11:38:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 77C647053A for ; Wed, 29 Nov 2017 11:38:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vATBc0GJ093419 for ; Wed, 29 Nov 2017 11:38:00 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 202192] [PATCH] x11-fm/thunar 1.6.11 change file permissions on sshfs mounted files/dirs Date: Wed, 29 Nov 2017 11:38:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: madpilot@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Rejected X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xfce@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 11:38:00 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202192 --- Comment #13 from Guido Falsi --- (In reply to Guido Falsi from comment #12) > I encourage you to push a correct solution with the upstream thunar > developers. BTW I can review proposed patches but they have to be correct for the common case, which is local file systems, usually UFS and/or ZFS. The thunar guys = will care a lot for ext[2-4], btrfs and other common linux file systems. Forcibly allowing a corner case in sshfs by breaking the software for all others by deliberately removing checks the upstream put in the code is definitely not acceptable. (hitting errors in chmod(2) is clearly accounted as breakage by upstream, a= nd I tend to agree with that interpretation) --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-xfce@freebsd.org Wed Nov 29 12:36:21 2017 Return-Path: Delivered-To: freebsd-xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 140AEE52EBA for ; Wed, 29 Nov 2017 12:36:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id F036D728D8 for ; Wed, 29 Nov 2017 12:36:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id EC67EE52EB9; Wed, 29 Nov 2017 12:36:20 +0000 (UTC) Delivered-To: xfce@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EC0F1E52EB7 for ; Wed, 29 Nov 2017 12:36:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D9F50728D6 for ; Wed, 29 Nov 2017 12:36:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vATCaK4Z009017 for ; Wed, 29 Nov 2017 12:36:20 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 202192] [PATCH] x11-fm/thunar 1.6.11 change file permissions on sshfs mounted files/dirs Date: Wed, 29 Nov 2017 12:36:20 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: madpilot@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Rejected X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: xfce@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2017 12:36:21 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D202192 --- Comment #14 from Guido Falsi --- I'd like to suggest a solution idea: If you can find a way, from inside the thunar_file_get_deletion_date() func= tion to discover with good confidence that you are in a sshfs filesystem and jus= t in that special case return an unconditional true or another check that fits y= our use case, that could be an acceptable strategy. --=20 You are receiving this mail because: You are the assignee for the bug.=