From owner-svn-ports-svnadmin@freebsd.org Mon Mar 6 17:48:28 2017 Return-Path: Delivered-To: svn-ports-svnadmin@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 843A9CFAA88; Mon, 6 Mar 2017 17:48:28 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 383E31862; Mon, 6 Mar 2017 17:48:28 +0000 (UTC) (envelope-from mat@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v26HmRvb077761; Mon, 6 Mar 2017 17:48:27 GMT (envelope-from mat@FreeBSD.org) Received: (from mat@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id v26HmRE6077759; Mon, 6 Mar 2017 17:48:27 GMT (envelope-from mat@FreeBSD.org) Message-Id: <201703061748.v26HmRE6077759@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: mat set sender to mat@FreeBSD.org using -f From: Mathieu Arnold Date: Mon, 6 Mar 2017 17:48:27 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-svnadmin@freebsd.org Subject: svn commit: r435559 - in svnadmin/hooks: . scripts X-SVN-Group: ports-svnadmin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-svnadmin@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for svnadmin of the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Mar 2017 17:48:28 -0000 Author: mat Date: Mon Mar 6 17:48:26 2017 New Revision: 435559 URL: https://svnweb.freebsd.org/changeset/ports/435559 Log: Add the stomp_bad_formatting hook peter wrote to prevent using arc commit. Stolen from: the src repository Sponsored by: Absolight Differential Revision: https://reviews.freebsd.org/D9893 Added: svnadmin/hooks/scripts/stomp_bad_formatting.pl (contents, props changed) Modified: svnadmin/hooks/pre-commit Modified: svnadmin/hooks/pre-commit ============================================================================== --- svnadmin/hooks/pre-commit Mon Mar 6 17:31:09 2017 (r435558) +++ svnadmin/hooks/pre-commit Mon Mar 6 17:48:26 2017 (r435559) @@ -116,6 +116,9 @@ case-insensitive.py "$REPO" "$TXN" || ex # fix log message. log-police.py -t "$TXN" "$REPO" || exit 1 +# catch some gross violations of commit template mangling. +stomp_bad_formatting.pl "$REPO" "$TXN" || exit 1 + # Nothing else, go ahead. exit 0 Added: svnadmin/hooks/scripts/stomp_bad_formatting.pl ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ svnadmin/hooks/scripts/stomp_bad_formatting.pl Mon Mar 6 17:48:26 2017 (r435559) @@ -0,0 +1,54 @@ +#!/usr/bin/perl -w +# +# $FreeBSD$ + +use strict; +my $debug = 0; + +# $ svnlook changed /home/svnmirror/base -r 12348 +# UU head/sbin/mountd/mountd.c +# UU head/usr.sbin/mountd/mountd.c +# $ svnlook log /home/svnmirror/base -r 12348 +# Avoid bogus free() of a junk pointer. +# +# Detected by: phkmalloc +# Submitted by: grog@lemis.de (Greg Lehey) +# +# Except that when called to vette a commit, it'll be "-t txn", not "-r rev" + + +my $repo = $ARGV[0]; +my $txn = $ARGV[1]; + +my $log = ""; + +open(LOG, "svnlook log $repo -t $txn |") || die "cannot open svnlook log: $!"; +foreach () { + print "$$: log: $_" if ($debug); + $log .= $_; +} +close(LOG); + +if (stomp_bad_formatting($log)) { + exit 1; +} +exit 0; + +# ============================================================ +# Look for a few specific mangled/broken template cases as a +# stopgap for checking for a proper template. + +sub stomp_bad_formatting { + my ($log) = @_; + my $rv = 0; + if ($log =~ m|\n\nReviewers:[\t ]+|s) { + printf STDERR "**** Non-standard/badly formatted template - found 'Reviewers:' instead of 'Reviewed by:'.\n"; + $rv = 1; + } + # There is really no need for this spam in log messages. + if ($log =~ m|\n\nSubscribers:[\t ]+|s) { + printf STDERR "**** Non-standard/badly formatted template - found 'Subscribers:'.\n"; + $rv = 1; + } + $rv; +} From owner-svn-ports-svnadmin@freebsd.org Wed Mar 8 16:56:24 2017 Return-Path: Delivered-To: svn-ports-svnadmin@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8473FD016AB; Wed, 8 Mar 2017 16:56:24 +0000 (UTC) (envelope-from vsevolod@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 53CE111EE; Wed, 8 Mar 2017 16:56:24 +0000 (UTC) (envelope-from vsevolod@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v28GuN3A049478; Wed, 8 Mar 2017 16:56:23 GMT (envelope-from vsevolod@FreeBSD.org) Received: (from vsevolod@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id v28GuN6k049476; Wed, 8 Mar 2017 16:56:23 GMT (envelope-from vsevolod@FreeBSD.org) Message-Id: <201703081656.v28GuN6k049476@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: vsevolod set sender to vsevolod@FreeBSD.org using -f From: Vsevolod Stakhov Date: Wed, 8 Mar 2017 16:56:23 +0000 (UTC) To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-svnadmin@freebsd.org Subject: svn commit: r435720 - svnadmin/conf X-SVN-Group: ports-svnadmin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-svnadmin@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for svnadmin of the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 16:56:24 -0000 Author: vsevolod Date: Wed Mar 8 16:56:23 2017 New Revision: 435720 URL: https://svnweb.freebsd.org/changeset/ports/435720 Log: Please welcome Eugene Grosbein (eugen@) as a new ports committer! Eugene has a long history of good quality PRs and now he deserves the traditional punishnemt. az@ and I will mentor him. Approved by: portmgr Modified: svnadmin/conf/access svnadmin/conf/mentors Modified: svnadmin/conf/access ============================================================================== --- svnadmin/conf/access Wed Mar 8 16:52:25 2017 (r435719) +++ svnadmin/conf/access Wed Mar 8 16:56:23 2017 (r435720) @@ -66,6 +66,7 @@ dumbbell dvl eadler ehaupt +eugen farrokhi feld fjoe Modified: svnadmin/conf/mentors ============================================================================== --- svnadmin/conf/mentors Wed Mar 8 16:52:25 2017 (r435719) +++ svnadmin/conf/mentors Wed Mar 8 16:56:23 2017 (r435720) @@ -17,6 +17,7 @@ alonso rakuco Co-mentor: makc brd bdrewery Co-mentor: zi, swills cmt rene dumbbell antoine Co-mentor: bapt +eugen vsevolod Co-mentor: az farrokhi philip Co-mentor: bapt, mat gnn skreuzer ian sbruno Co-mentor: mat