From owner-svn-src-head@freebsd.org  Sun May  7 09:19:44 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5156FD605CF;
 Sun,  7 May 2017 09:19:44 +0000 (UTC)
 (envelope-from trasz@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 0697ADBC;
 Sun,  7 May 2017 09:19:43 +0000 (UTC)
 (envelope-from trasz@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v479Jgqq050358;
 Sun, 7 May 2017 09:19:42 GMT (envelope-from trasz@FreeBSD.org)
Received: (from trasz@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id v479Jg5v050357;
 Sun, 7 May 2017 09:19:42 GMT (envelope-from trasz@FreeBSD.org)
Message-Id: <201705070919.v479Jg5v050357@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: trasz set sender to
 trasz@FreeBSD.org using -f
From: Edward Tomasz Napierala <trasz@FreeBSD.org>
Date: Sun, 7 May 2017 09:19:42 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r317901 - head/usr.bin/resizewin
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 07 May 2017 09:19:44 -0000

Author: trasz
Date: Sun May  7 09:19:42 2017
New Revision: 317901
URL: https://svnweb.freebsd.org/changeset/base/317901

Log:
  Improve error reporting in resizewin(1).
  
  Reviewed by:	cem (earlier version)
  MFC after:	2 weeks
  Sponsored by:	DARPA, AFRL
  Differential Revision:	https://reviews.freebsd.org/D10624

Modified:
  head/usr.bin/resizewin/resizewin.c

Modified: head/usr.bin/resizewin/resizewin.c
==============================================================================
--- head/usr.bin/resizewin/resizewin.c	Sun May  7 08:02:28 2017	(r317900)
+++ head/usr.bin/resizewin/resizewin.c	Sun May  7 09:19:42 2017	(r317901)
@@ -31,6 +31,7 @@
 __FBSDID("$FreeBSD$");
 #include <sys/ioctl.h>
 #include <sys/time.h>
+#include <err.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <stdio.h>
@@ -87,8 +88,7 @@ main(__unused int argc, __unused char **
 				gettimeofday(&now, NULL);
 				timersub(&now, &then, &now);
 				if (now.tv_sec >= 2) {
-					fprintf(stderr, "\n\n\nTimeout reading from terminal\n");
-					fprintf(stderr, "Read %d bytes, %s\n", cnt, data);
+					warnx("timeout reading from terminal");
 					err = 1;
 					goto out;
 				}
@@ -104,7 +104,7 @@ main(__unused int argc, __unused char **
 
 		cnt++;
 		if (cnt == sizeof(data) - 2) {
-			fprintf(stderr, "Response too long\n");
+			warnx("response too long");
 			err = 1;
 			goto out;
 		}
@@ -113,7 +113,7 @@ main(__unused int argc, __unused char **
 	/* Parse */
 	if (sscanf(data, "\033[%hu;%huR", &w.ws_row, &w.ws_col) != 2) {
 		err = 1;
-		fprintf(stderr, "Unable to parse response\n");
+		warnx("unable to parse response");
 		goto out;
 	}