From owner-svn-src-head@freebsd.org Sun Oct 8 05:18:44 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1BBD4E27398; Sun, 8 Oct 2017 05:18:44 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x230.google.com (mail-pf0-x230.google.com [IPv6:2607:f8b0:400e:c00::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7C94782FFD; Sun, 8 Oct 2017 05:18:43 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x230.google.com with SMTP id m63so11285142pfk.7; Sat, 07 Oct 2017 22:18:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Y5Q7Do7NLrSLRXOeBPoMMghC8nxIRsxnHBCkrbp+Zak=; b=fdRNOdtX+G5sDuxZbPnf1qB+nnEw/rNq266aTH3UUEuqcat5Fb1L6xIsYM4FuaQhpX JGGzpyejvgxBuP4Lu8ufrG6DABUFdEZXnP4iqJkRklgeCV4gcoNcrTU/eN0NTnNcHS8c bE1yZsp6vK/Lxoahiw4V+y6Za/OZMGClYGyrv08busOGJtYt9FMlYqj8aybk2R5kJ6+R j9L3biAuCLT61d2xnGDlJavDrjNOox8BKSZSRYeEU8r4H4iAkokqq7czLiQjp8aXG0if QmnOhZ1fcqOeTzvHcTamT1Hy+PfAEGmlkvLpOyb4qVSWznJyiIB+fEou1OHwy79y6J8E TkIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=Y5Q7Do7NLrSLRXOeBPoMMghC8nxIRsxnHBCkrbp+Zak=; b=VREhClHZaQ/WZf83rcUlhmxFx4TR97smpu14J6OAlkfivd1m0RR+xpEdHtWeioE2Bg +ILcY7A+eNKuCAk8OcTuJMvPqmlyEXMai9FEUusqZWks4vow/ksmhnPuh3qoxwXd1Idl S2/+h24bKLtuQrMnHc0sNd/tmrRjx6ym45+gLpLC4r+kBdX6Tdr4NfVpcc+T47tyz7fB jEDFduZ0reZ53KJbGaZ+ng2aIzCvco2eYJJdeSOhCxgGFLRZx1agjI/8Px5lYv3JpDVP TBAXA8nYl1woXX/hrLRLgNFWv99ad2u5zyQGfETJgSxFjVdljbDF8EUpDTL9yH6jn134 HTeQ== X-Gm-Message-State: AMCzsaW+JX/JbfpWgP0LVIaCGLuOOx74erB7k1fhkg9JjIESlRFZ/FrH cigmQmIISgWkZh3Ir+ToGkudlaJo X-Google-Smtp-Source: AOwi7QDLUhpvZr7gPLfPa4IIa4YkJ5XfzO/Ci0VV+6kxeRuWAFRGPkiv7KP/WfI63/CUkt19+XpR8A== X-Received: by 10.99.95.145 with SMTP id t139mr6325349pgb.344.1507439922406; Sat, 07 Oct 2017 22:18:42 -0700 (PDT) Received: from ?IPv6:2607:fb90:8120:cf90:2069:3ba:b5d:6cb7? ([2607:fb90:8120:cf90:2069:3ba:b5d:6cb7]) by smtp.gmail.com with ESMTPSA id q13sm927723pfi.166.2017.10.07.22.18.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Oct 2017 22:18:41 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r324406 - head/sys/modules/em From: Ngie Cooper X-Mailer: iPhone Mail (15A421) In-Reply-To: <201710072333.v97NXE6E044433@repo.freebsd.org> Date: Sat, 7 Oct 2017 22:18:40 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <95D45458-24C3-473C-80AF-A2C622747886@gmail.com> References: <201710072333.v97NXE6E044433@repo.freebsd.org> To: Sean Bruno X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Oct 2017 05:18:44 -0000 > On Oct 7, 2017, at 16:33, Sean Bruno wrote: >=20 > Author: sbruno > Date: Sat Oct 7 23:33:14 2017 > New Revision: 324406 > URL: https://svnweb.freebsd.org/changeset/base/324406 >=20 > Log: > Fix symlink if_igb.ko in -current such that its relative and doesn't > end up with non-standard DESTDIR information in its symlink. This > can happen very trivially if the release scripts are used. >=20 > Sponsored by: Limelight Networks >=20 > Modified: > head/sys/modules/em/Makefile >=20 > Modified: head/sys/modules/em/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/sys/modules/em/Makefile Sat Oct 7 23:30:57 2017 (r324405) > +++ head/sys/modules/em/Makefile Sat Oct 7 23:33:14 2017 (r324406) > @@ -23,6 +23,6 @@ CFLAGS +=3D -I${SRCTOP}/sys/dev/e1000 > #CFLAGS +=3D -DDEVICE_POLLING >=20 > afterinstall: > - ln -sf ${DESTDIR}${KMODDIR}/${KMOD}.ko ${DESTDIR}${KMODDIR}/if_igb.ko= > + cd ${DESTDIR}${KMODDIR} && ln -sf if_em.ko if_igb.ko While this is definitely better, the same thing could be achieved via: ln -sf if_em.ko ${DESTDIR}/.../if_igb.ko=