From owner-freebsd-acpi@freebsd.org Thu May 3 16:03:35 2018 Return-Path: Delivered-To: freebsd-acpi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D8401FAFE88; Thu, 3 May 2018 16:03:34 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from hz.grosbein.net (unknown [IPv6:2a01:4f8:d12:604::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 6A6B2843A7; Thu, 3 May 2018 16:03:34 +0000 (UTC) (envelope-from eugen@grosbein.net) X-Envelope-To: freebsd-current@freebsd.org Received: from eg.sd.rdtc.ru (root@eg.sd.rdtc.ru [62.231.161.221] (may be forged)) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id w43G3R54017197 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 3 May 2018 18:03:27 +0200 (CEST) (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net Received: from [10.58.0.4] ([10.58.0.4]) by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTPS id w43G3NSK082827 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 3 May 2018 23:03:23 +0700 (+07) (envelope-from eugen@grosbein.net) To: freebsd-acpi@freebsd.org Cc: FreeBSD Current From: Eugene Grosbein Subject: D15247: add rcorder(8) support to /etc/rc.resume Message-ID: <5AEB32BB.40502@grosbein.net> Date: Thu, 3 May 2018 23:03:07 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="36k032L4l8gnKumd9QBWBJd61wSoQqjbD" X-Spam-Status: No, score=2.2 required=5.0 tests=BAYES_00, LOCAL_FROM, RDNS_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.1 X-Spam-Report: * -0.0 SPF_PASS SPF: sender matches SPF record * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 2.6 LOCAL_FROM From my domains * 1.9 RDNS_NONE Delivered to internal network by a host with no rDNS X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on hz.grosbein.net X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2018 16:03:35 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --36k032L4l8gnKumd9QBWBJd61wSoQqjbD Content-Type: multipart/mixed; boundary="i10jINebtXcW0oxibA5jLLiOCQLXDhiWA"; protected-headers="v1" From: Eugene Grosbein To: freebsd-acpi@freebsd.org Cc: FreeBSD Current Message-ID: <5AEB32BB.40502@grosbein.net> Subject: D15247: add rcorder(8) support to /etc/rc.resume --i10jINebtXcW0oxibA5jLLiOCQLXDhiWA Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: quoted-printable Hi! While dealing with https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D22= 7866 I've found we have no easy way to insert custom "hooks" after ACPI resume procedure other than devd(8). And running devd itself may be undesirable for several reasons. Manual editing of /etc/rc.resume is not desirable too because it makes upgrades less smooth. So, I'd like to add rcorder(8) support to /etc/rc.resume: https://reviews= =2Efreebsd.org/D15247 /etc/rc.resume will call "rcorder -k resume" and run rcNG scripts containing "KEYWORD: resume" with single "resume" argument. Working example is the port sysutils/cpupdate version g20180324_1 that defines extra_commands=3D"resume" to reload CPU microcode cleared by= suspend/resume sequence. This change does nothing if system has no rcNG scripts with "KEYWORD: res= ume" inside. I'm going to commit this in a week unless told not to for a reason. --i10jINebtXcW0oxibA5jLLiOCQLXDhiWA-- --36k032L4l8gnKumd9QBWBJd61wSoQqjbD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJa6zLFAAoJELDNGvImmIsovNoH/1keONB2dbx9TMFVw8HG3LDO WGPzFtuqSwiGUv9imkftcpf9vYly4iishNqkW07lko8huNFbI1fTIkukd4d/hKwf TuB/QVcT6ABQJEzgwXqhic187p8b0HYC+PEcqLcJkIHipiDhY81RA/ek007vK6Xd 4Aj5OwOIypqU/x45wfYo+cKzDgeOhboEKm04oSV5dpWqJfVV8BpFHwVeRFHJ0DiO bDyQmVQHYGsnFy4R8B/qjdefdAhK80FwicO2+FKA9CE2hSLxcAReTpddSo34Gqbu 2dI/fd1g0Yby8oQahuNELAz2P0kp1oOiBnGLv212RfQDfpozRxJOuwH1qBmjVDU= =1l39 -----END PGP SIGNATURE----- --36k032L4l8gnKumd9QBWBJd61wSoQqjbD-- From owner-freebsd-acpi@freebsd.org Fri May 4 20:43:44 2018 Return-Path: Delivered-To: freebsd-acpi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 33F41FB77F9 for ; Fri, 4 May 2018 20:43:44 +0000 (UTC) (envelope-from dwhitteker@gmail.com) Received: from mail-ot0-x22f.google.com (mail-ot0-x22f.google.com [IPv6:2607:f8b0:4003:c0f::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B6DD87EDC0 for ; Fri, 4 May 2018 20:43:43 +0000 (UTC) (envelope-from dwhitteker@gmail.com) Received: by mail-ot0-x22f.google.com with SMTP id h8-v6so25916288otb.2 for ; Fri, 04 May 2018 13:43:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=mn5VejwCS8OBUKQjkklykNFrNxRC3d56lLaqw6KhELk=; b=cwX6GR25VyVdgZtpnIZDa62TtmT43R5cjguAuOlKZnh8fZNuatpOVuYhSaQ+hfaauL JIjGjW1MPZfw+tmFwCEi+IzR5ZrK3VfLCg2D9sfhKjmn0UNuosAwxLLDupFsZj+VwKmY MgR1uulCTa9c0YwI+gLx9y8ZYlzSGiCB5QBqM2Dfw2iY6GCtBfnwYK3bFy+0uwUzfvfa N7xHD83j2MFkbDwdtVupCDkk9haMC9XwPDaakv2iVr0BTicat++Gcy63aCjf2s5JBhJa hrn1MNye9G4eIce2nvLKuq1UfOiHd/S+SWS41gvb29Q+iEdEp8+zALIZw1IR4igVzmQ4 8APg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=mn5VejwCS8OBUKQjkklykNFrNxRC3d56lLaqw6KhELk=; b=SfDraSfyIFha0NvF2thlKiTRQn1241H5HebUnYANHPQwOhWTt3sW3Dtm5MKqWvDQ+Q Ug2ksO4+BLOB6fp/L7dj0JenqiHp6tPR10suHICHGlf57VME5mh+LEgymD5vMs0uo215 k0IfWGY/t4hXcHhrVC4W++DTMKBOieWMntYCCkrPLToyHmDJgrez6wPzWFK0XzZ2jBWN fmrOEq2wne65tyO80jqFz8I4EJgivbfzuo93KZ7suX/6LTqoTMsVD3ATFGERkrI87SDj 6ixaum83utR7E24/IF9t7X57nyRTnaweDjbMidbt5pvRPtDO9gmF/SZay4xQxlRB+Svl eVIQ== X-Gm-Message-State: ALQs6tA5uvE5ksAao+vAvFtbMsFg15fY1HnkLN+n8UcH7f/NnT7w1yzF AGPU3WnsEUJc9gHckCNkK4a/Rb6BUlh7ZyWnKMBlCA== X-Google-Smtp-Source: AB8JxZpV8ANskVl5fTRIroHziOzZFzozdSNyTBxqQYxR7hAFeX4bdWKwpXAtuTn98Tfaxufj0FlqnomW0BbXfjphFac= X-Received: by 2002:a9d:2687:: with SMTP id l7-v6mr19657711otb.97.1525466622846; Fri, 04 May 2018 13:43:42 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:439f:0:0:0:0:0 with HTTP; Fri, 4 May 2018 13:43:42 -0700 (PDT) From: Don Whitteker Date: Fri, 4 May 2018 16:43:42 -0400 Message-ID: Subject: Temorarily disabling ACPI errors To: freebsd-acpi@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2018 20:43:44 -0000 I am trying to temporarily disable my ACPI error messages I am getting on my laptop. I've tried disabling ACPI (crashed right at boot), tried hw.acpi.osname="Windows 2015" based on documentation and output from 'acpidump -td | grep "Windows"'(no change), and even tried 'hint.acpi_thermal.0.disabled="1"' since the main issue are the thermal sensors. I know these issues need to be addressed and that I can't just sweep them under the rug. However I am getting spammed with 4 lines of errors every 3-5 seconds. This is making it near impossible to type out anything but short commands at the prompt. I can't even open a file in vi to try to edit before the spam covers the first 4 lines and makes it impossible to read or edit. I would love to tackle this problem and get ACPI working (if even only partially) but I can't do tanything with these constant error messages. Is there a way to pipe the error messages to /dev/null? I have done that using the find command and similar commands but I don't know how to when it's constantly coming from the system. Thanks, Don From owner-freebsd-acpi@freebsd.org Fri May 4 20:51:58 2018 Return-Path: Delivered-To: freebsd-acpi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 40323FB7A4C for ; Fri, 4 May 2018 20:51:58 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) by mx1.freebsd.org (Postfix) with ESMTP id C8F3D839E0; Fri, 4 May 2018 20:51:57 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Subject: Re: Temorarily disabling ACPI errors To: Don Whitteker , freebsd-acpi@freebsd.org References: From: Jung-uk Kim Openpgp: preference=signencrypt Autocrypt: addr=jkim@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFJBztUBCAChqNyGqmFuNo0U7MBzsD+q/G6Cv0l7LGVrOAsgh34M8wIWhD+tztDWMVfn AhxNDd0ceCj2bYOe67sTQxAScEcbt2FfvPOLp9MEXb9qohZj172Gwkk7dnhOhZZKhVGVZKM4 NcsuBDUzgf4f3Vdzj4wg6WlqplnTZo8lPE4hZWvZHoFIyunPTJWenybeV1xnxK7JkUdSvQR0 fA59RfTTECMwTrSEfYGUnxIDBraxJ7Ecs/0hGQ7sljIj8WBvlRDU5fU1xfF35aw56T8POQRq F4E6RVJW3YGuTpSwgtGZOTfygcLRhAiq3dFC3JNLaTVTpM8PjOinJyt9AU6RoITGOKwDABEB AAHNHkp1bmctdWsgS2ltIDxqa2ltQEZyZWVCU0Qub3JnPsLAfQQTAQoAJwUCUkHO1QIbAwUJ E0/POwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRB8n5Ym/NvxRqyzB/wL7QtsIpeGfGIA ZPMtgXMucM3NWzomyQMln2j2efUkDKthzh9jBxgF53TjOr7imwIt0PT2k1bqctPrq5IRqnu9 mGroqaCLE3LG2/E3jEaao4k9PO6efwlioyivUo5NrqIQOQ4k3EAXw7d2y0Dk1VpTgdMrnUAB hj7lGlLqS4ydcrf24DdbCRGdEQwqd9DBeBgbWynxAJMgbZBhYVEyIHuQKkJ8qY0ibIPXXuF0 KYDeH0qUHtWV2K3srNyPtymUkBQD84Pl1GWRYx05XdUHDmnX0JV3lg0BfYJZgZv0ehPQrMfY Fd9abTkf9FHQYz1JtsC8wUuRgqElRd6+YAGf8Tt9zsBNBFJBztUBCADLtSrP44El2VoJmH14 OFrlOgxzZnbn+Y/Gf1k12mJBiR+A+pBeRLD50p7AiTrjHRxO3cHcl9Dh0uf1VSbXgp8Or0ye iP/86fZPd4k5HXNmDTLL0HecPE08SCqGZ0W8vllQrokB1QxxRUB+fFMPJyMCjDAZ7P9fFTOS dTw1bJSTtOD8Sx8MpZUa9ti06bXFlVYDlaqSdgk181SSx+ZbSKkQR8CIMARlHwiLsa3Z9q9O EJr20HPyxe0AlTvwvFndH61hg7ds63eRvglwRnNON28VXO/lvKXq7Br/CiiyhFdKfINIx2Z5 htYq22tgGTW7mBURbIKoECFBTX9Lv6BXz6w9ABEBAAHCwGUEGAEKAA8FAlJBztUCGwwFCRNP zzsACgkQfJ+WJvzb8UZcJQf+IsTCxUEqY7W/pT84sMg5/QD3s6ufTRncvq14fEOxCNq1Rf4Q 9P+tOFa8GZfKDGB2BFGIrW7uT5mlmKdK1vO6ZIA930y5kUsnCmBUEBJkE2ciSQk01aB/1o62 Q3Gk/F6BwtNY9OXiqF7AcAo+K/BMIaqb26QKeh+IIgK1NN9dQiq3ByTbl4zpGZa6MmsnnRTu mzGKt2nkz7vBzH6+hZp1OzGZikgjjhYWVFoJo1dvf/rv4obs0ZJEqFPQs/1Qa1dbkKBv6odB XJpPH0ssOluTY24d1XxTiKTwmWvHeQkOKRAIfD7VTtF4TesoZYkf7hsh3e3VwXhptSLFnEOi WwYofg== Message-ID: <59b7775a-e3b4-29d0-65b6-bee8a553604a@FreeBSD.org> Date: Fri, 4 May 2018 16:51:52 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UwvlXFn74tc2JdIzk2MqDJaurnR8BqsnT" X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2018 20:51:58 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UwvlXFn74tc2JdIzk2MqDJaurnR8BqsnT Content-Type: multipart/mixed; boundary="vcUApmQXb3verHrl0PUESNoPkW20kf28V"; protected-headers="v1" From: Jung-uk Kim To: Don Whitteker , freebsd-acpi@freebsd.org Message-ID: <59b7775a-e3b4-29d0-65b6-bee8a553604a@FreeBSD.org> Subject: Re: Temorarily disabling ACPI errors References: In-Reply-To: --vcUApmQXb3verHrl0PUESNoPkW20kf28V Content-Type: multipart/mixed; boundary="------------C081B726836F99DFB71AF15A" Content-Language: en-US This is a multi-part message in MIME format. --------------C081B726836F99DFB71AF15A Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/04/2018 16:43, Don Whitteker wrote: > I am trying to temporarily disable my ACPI error messages I am getting = on > my laptop. I've tried disabling ACPI (crashed right at boot), tried > hw.acpi.osname=3D"Windows 2015" based on documentation and output from > 'acpidump -td | grep "Windows"'(no change), and even tried > 'hint.acpi_thermal.0.disabled=3D"1"' since the main issue are the therm= al > sensors. I know these issues need to be addressed and that I can't just= > sweep them under the rug. However I am getting spammed with 4 lines of > errors every 3-5 seconds. This is making it near impossible to type out= > anything but short commands at the prompt. I can't even open a file in = vi > to try to edit before the spam covers the first 4 lines and makes it > impossible to read or edit. I would love to tackle this problem and get= > ACPI working (if even only partially) but I can't do tanything with the= se > constant error messages. >=20 > Is there a way to pipe the error messages to /dev/null? I have done tha= t > using the find command and similar commands but I don't know how to whe= n > it's constantly coming from the system. Are you using head? If so, can you please try the attached patch? Thanks, Jung-uk Kim --------------C081B726836F99DFB71AF15A Content-Type: text/x-patch; name="acpi_rm_load_package_init.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="acpi_rm_load_package_init.diff" --- sys/contrib/dev/acpica/components/executer/exconfig.c +++ sys/contrib/dev/acpica/components/executer/exconfig.c @@ -615,6 +615,11 @@ AcpiExLoadOp ( return_ACPI_STATUS (Status); } =20 + /* Complete the initialization/resolution of package objects */ + + Status =3D AcpiNsWalkNamespace (ACPI_TYPE_PACKAGE, ACPI_ROOT_OBJECT,= + ACPI_UINT32_MAX, 0, AcpiNsInitOnePackage, NULL, NULL, NULL); + /* Store the DdbHandle into the Target operand */ =20 Status =3D AcpiExStore (DdbHandle, Target, WalkState); --- sys/contrib/dev/acpica/components/namespace/nsinit.c +++ sys/contrib/dev/acpica/components/namespace/nsinit.c @@ -406,6 +406,61 @@ ErrorExit: } =20 =20 +/***********************************************************************= ******** + * + * FUNCTION: AcpiNsInitOnePackage + * + * PARAMETERS: ObjHandle - Node + * Level - Current nesting level + * Context - Not used + * ReturnValue - Not used + * + * RETURN: Status + * + * DESCRIPTION: Callback from AcpiWalkNamespace. Invoked for every packa= ge + * within the namespace. Used during dynamic load of an SSD= T. + * + ***********************************************************************= *******/ + +ACPI_STATUS +AcpiNsInitOnePackage ( + ACPI_HANDLE ObjHandle, + UINT32 Level, + void *Context, + void **ReturnValue) +{ + ACPI_STATUS Status; + ACPI_OPERAND_OBJECT *ObjDesc; + ACPI_NAMESPACE_NODE *Node =3D (ACPI_NAMESPACE_NODE *) ObjHandle;= + + + ObjDesc =3D AcpiNsGetAttachedObject (Node); + if (!ObjDesc) + { + return (AE_OK); + } + + /* Exit if package is already initialized */ + + if (ObjDesc->Package.Flags & AOPOBJ_DATA_VALID) + { + return (AE_OK); + } + + Status =3D AcpiDsGetPackageArguments (ObjDesc); + if (ACPI_FAILURE (Status)) + { + return (AE_OK); + } + + Status =3D AcpiUtWalkPackageTree (ObjDesc, NULL, AcpiDsInitPackageEl= ement, + NULL); + + ObjDesc->Package.Flags |=3D AOPOBJ_DATA_VALID; + return (AE_OK); +} + + /***********************************************************************= ******** * * FUNCTION: AcpiNsInitOneObject --- sys/contrib/dev/acpica/include/acnamesp.h +++ sys/contrib/dev/acpica/include/acnamesp.h @@ -204,6 +204,12 @@ ACPI_STATUS AcpiNsInitializeDevices ( UINT32 Flags); =20 +ACPI_STATUS +AcpiNsInitOnePackage ( + ACPI_HANDLE ObjHandle, + UINT32 Level, + void *Context, + void **ReturnValue); =20 /* * nsload - Namespace loading --------------C081B726836F99DFB71AF15A-- --vcUApmQXb3verHrl0PUESNoPkW20kf28V-- --UwvlXFn74tc2JdIzk2MqDJaurnR8BqsnT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEl1bqgKaRyqfWXu/CfJ+WJvzb8UYFAlrsx+gACgkQfJ+WJvzb 8UacGQgAh8Ms6yt3H/2FJSxRM119LbPXg2UlP6r+refRbqiw+v7yF5rmDM3sb/N9 gAV/xPR4g3qMSDwYKP8sjLvlFtod6RK1vgZAW/GoffId7OtKBvURStsnfPlkdoQr MlR95jy+82RN28uzKKtWRrdNHlBZYjAkpHfOR7e8pzDoPZc2Ns2Hosxl706JYxxk 06+YFrtk+M9HN4OjmnyW9buCYmqImUUfRp2aSXECZgDVbBsrxGV2+iaa4vyEIyFb HarxvSeA1xMSlM1tqeuL8DuziGfetCerw2Lj3mIOxhPZQqVXoD6202+ldza/oDnH 5U2Go9Q7kEczdHvoLFoOUNuO9rIOhQ== =/Wwy -----END PGP SIGNATURE----- --UwvlXFn74tc2JdIzk2MqDJaurnR8BqsnT-- From owner-freebsd-acpi@freebsd.org Fri May 4 21:59:31 2018 Return-Path: Delivered-To: freebsd-acpi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 30A3CFB9711 for ; Fri, 4 May 2018 21:59:31 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com [209.85.215.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6B7347606A for ; Fri, 4 May 2018 21:59:30 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-lf0-f51.google.com with SMTP id j193-v6so32911179lfg.6 for ; Fri, 04 May 2018 14:59:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=EYeILxizKPC/al35oisNIMSb2giLUTW98sUa2KNhDZY=; b=kWuyEhnMC4GUSaRY45ACVp8wfw7ch+s5x0wScUIE9aJE98s2+Fj1W6v1Z0r3kV+fOQ Py4ybKEQocx4HBH+ScwGOHOaKrpTtjf5S6+CkjoIm6L8z+ZtblwJs3o++fc+yfrZ68fO O4Ot494+Zcj0Fmju8cMdW0DwhZO9e83h9F8+/nS+IaaTRpB8KBdvgBYMTjjGxyhH/np3 IldDi0XiN+oBAgDv1K4RgC2HAdNBUoTdk0PHvLlGP/8LgcTN3/hvefHrzzlX/QqkBiRn ED5E0V5/EuHLoUP0PMHyb3Iij8DkP7qtq+b0An9dOxL/h4fb6RJV+TCrqD7YjLEeAVuj JQMA== X-Gm-Message-State: ALQs6tCEQQax3WZNxUSxieMtjXp41cxYenAE6qCLn1MQSsjDQub1Yy98 AfVmcs9Sf8S6YfcBJjnVKZqlsDEL X-Google-Smtp-Source: AB8JxZrzHIrxQMpaW1RgJeJs8v8n/+Mqdq52E6GVVd0aJMbnLf3x2lnKQjW0f8Q70r5dXhVZKKTqew== X-Received: by 2002:a2e:9ac3:: with SMTP id p3-v6mr17048385ljj.60.1525470657009; Fri, 04 May 2018 14:50:57 -0700 (PDT) Received: from [192.168.0.88] (east.meadow.volia.net. [93.72.151.96]) by smtp.googlemail.com with ESMTPSA id c26-v6sm3488039lfh.25.2018.05.04.14.50.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 May 2018 14:50:56 -0700 (PDT) Subject: Re: Temorarily disabling ACPI errors To: Don Whitteker , freebsd-acpi@freebsd.org References: From: Andriy Gapon Openpgp: preference=signencrypt Autocrypt: addr=avg@FreeBSD.org; prefer-encrypt=mutual; keydata= xsFNBFm4LIgBEADNB/3lT7f15UKeQ52xCFQx/GqHkSxEdVyLFZTmY3KyNPQGBtyvVyBfprJ7 mAeXZWfhat6cKNRAGZcL5EmewdQuUfQfBdYmKjbw3a9GFDsDNuhDA2QwFt8BmkiVMRYyvI7l N0eVzszWCUgdc3qqM6qqcgBaqsVmJluwpvwp4ZBXmch5BgDDDb1MPO8AZ2QZfIQmplkj8Y6Z AiNMknkmgaekIINSJX8IzRzKD5WwMsin70psE8dpL/iBsA2cpJGzWMObVTtCxeDKlBCNqM1i gTXta1ukdUT7JgLEFZk9ceYQQMJJtUwzWu1UHfZn0Fs29HTqawfWPSZVbulbrnu5q55R4PlQ /xURkWQUTyDpqUvb4JK371zhepXiXDwrrpnyyZABm3SFLkk2bHlheeKU6Yql4pcmSVym1AS4 dV8y0oHAfdlSCF6tpOPf2+K9nW1CFA8b/tw4oJBTtfZ1kxXOMdyZU5fiG7xb1qDgpQKgHUX8 7Rd2T1UVLVeuhYlXNw2F+a2ucY+cMoqz3LtpksUiBppJhw099gEXehcN2JbUZ2TueJdt1FdS ztnZmsHUXLxrRBtGwqnFL7GSd6snpGIKuuL305iaOGODbb9c7ne1JqBbkw1wh8ci6vvwGlzx rexzimRaBzJxlkjNfMx8WpCvYebGMydNoeEtkWldtjTNVsUAtQARAQABzR5BbmRyaXkgR2Fw b24gPGF2Z0BGcmVlQlNELm9yZz7CwZQEEwEIAD4WIQS+LEO7ngQnXA4Bjr538m7TUc1yjwUC WbgsiAIbIwUJBaOagAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRB38m7TUc1yj+JAEACV l9AK/nOWAt/9cufV2fRj0hdOqB1aCshtSrwHk/exXsDa4/FkmegxXQGY+3GWX3deIyesbVRL rYdtdK0dqJyT1SBqXK1h3/at9rxr9GQA6KWOxTjUFURsU7ok/6SIlm8uLRPNKO+yq0GDjgaO LzN+xykuBA0FlhQAXJnpZLcVfPJdWv7sSHGedL5ln8P8rxR+XnmsA5TUaaPcbhTB+mG+iKFj GghASDSfGqLWFPBlX/fpXikBDZ1gvOr8nyMY9nXhgfXpq3B6QCRYKPy58ChrZ5weeJZ29b7/ QdEO8NFNWHjSD9meiLdWQaqo9Y7uUxN3wySc/YUZxtS0bhAd8zJdNPsJYG8sXgKjeBQMVGuT eCAJFEYJqbwWvIXMfVWop4+O4xB+z2YE3jAbG/9tB/GSnQdVSj3G8MS80iLS58frnt+RSEw/ psahrfh0dh6SFHttE049xYiC+cM8J27Aaf0i9RflyITq57NuJm+AHJoU9SQUkIF0nc6lfA+o JRiyRlHZHKoRQkIg4aiKaZSWjQYRl5Txl0IZUP1dSWMX4s3XTMurC/pnja45dge/4ESOtJ9R 8XuIWg45Oq6MeIWdjKddGhRj3OohsltKgkEU3eLKYtB6qRTQypHHUawCXz88uYt5e3w4V16H lCpSTZV/EVHnNe45FVBlvK7k7HFfDDkryM7BTQRZuCyIARAAlq0slcsVboY/+IUJdcbEiJRW be9HKVz4SUchq0z9MZPX/0dcnvz/gkyYA+OuM78dNS7Mbby5dTvOqfpLJfCuhaNYOhlE0wY+ 1T6Tf1f4c/uA3U/YiadukQ3+6TJuYGAdRZD5EqYFIkreARTVWg87N9g0fT9BEqLw9lJtEGDY EWUE7L++B8o4uu3LQFEYxcrb4K/WKmgtmFcm77s0IKDrfcX4doV92QTIpLiRxcOmCC/OCYuO jB1oaaqXQzZrCutXRK0L5XN1Y1PYjIrEzHMIXmCDlLYnpFkK+itlXwlE2ZQxkfMruCWdQXye syl2fynAe8hvp7Mms9qU2r2K9EcJiR5N1t1C2/kTKNUhcRv7Yd/vwusK7BqJbhlng5ZgRx0m WxdntU/JLEntz3QBsBsWM9Y9wf2V4tLv6/DuDBta781RsCB/UrU2zNuOEkSixlUiHxw1dccI 6CVlaWkkJBxmHX22GdDFrcjvwMNIbbyfQLuBq6IOh8nvu9vuItup7qemDG3Ms6TVwA7BD3j+ 3fGprtyW8Fd/RR2bW2+LWkMrqHffAr6Y6V3h5kd2G9Q8ZWpEJk+LG6Mk3fhZhmCnHhDu6CwN MeUvxXDVO+fqc3JjFm5OxhmfVeJKrbCEUJyM8ESWLoNHLqjywdZga4Q7P12g8DUQ1mRxYg/L HgZY3zfKOqcAEQEAAcLBfAQYAQgAJhYhBL4sQ7ueBCdcDgGOvnfybtNRzXKPBQJZuCyIAhsM BQkFo5qAAAoJEHfybtNRzXKPBVwQAKfFy9P7N3OsLDMB56A4Kf+ZT+d5cIx0Yiaf4n6w7m3i ImHHHk9FIetI4Xe54a2IXh4Bq5UkAGY0667eIs+Z1Ea6I2i27Sdo7DxGwq09Qnm/Y65ADvXs 3aBvokCcm7FsM1wky395m8xUos1681oV5oxgqeRI8/76qy0hD9WR65UW+HQgZRIcIjSel9vR XDaD2HLGPTTGr7u4v00UeTMs6qvPsa2PJagogrKY8RXdFtXvweQFz78NbXhluwix2Tb9ETPk LIpDrtzV73CaE2aqBG/KrboXT2C67BgFtnk7T7Y7iKq4/XvEdDWscz2wws91BOXuMMd4c/c4 OmGW9m3RBLufFrOag1q5yUS9QbFfyqL6dftJP3Zq/xe+mr7sbWbhPVCQFrH3r26mpmy841ym dwQnNcsbIGiBASBSKksOvIDYKa2Wy8htPmWFTEOPRpFXdGQ27awcjjnB42nngyCK5ukZDHi6 w0qK5DNQQCkiweevCIC6wc3p67jl1EMFY5+z+zdTPb3h7LeVnGqW0qBQl99vVFgzLxchKcl0 R/paSFgwqXCZhAKMuUHncJuynDOP7z5LirUeFI8qsBAJi1rXpQoLJTVcW72swZ42IdPiboqx NbTMiNOiE36GqMcTPfKylCbF45JNX4nF9ElM0E+Y8gi4cizJYBRr2FBJgay0b9Cp Message-ID: Date: Sat, 5 May 2018 00:50:54 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2018 21:59:31 -0000 On 04/05/2018 23:43, Don Whitteker wrote: > However I am getting spammed with 4 lines of > errors every 3-5 seconds. What are the errors? > This is making it near impossible to type out > anything but short commands at the prompt. I can't even open a file in vi > to try to edit before the spam covers the first 4 lines and makes it > impossible to read or edit. Are you saying that the messages go to all terminals / consoles? Or are you stuck at a single console (like ttyv0) for some reason (e.g. single user mode)? -- Andriy Gapon From owner-freebsd-acpi@freebsd.org Fri May 4 22:23:43 2018 Return-Path: Delivered-To: freebsd-acpi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 63D9FFB9F9F for ; Fri, 4 May 2018 22:23:43 +0000 (UTC) (envelope-from theron.tarigo@gmail.com) Received: from mail-qt0-x231.google.com (mail-qt0-x231.google.com [IPv6:2607:f8b0:400d:c0d::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E22D17BA24; Fri, 4 May 2018 22:23:42 +0000 (UTC) (envelope-from theron.tarigo@gmail.com) Received: by mail-qt0-x231.google.com with SMTP id f13-v6so19615019qtp.10; Fri, 04 May 2018 15:23:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=q6+v3UAe47q/u4r+CwyBoBnHsgd8clQ5wFMTPco4API=; b=ruTKT84BHfx1wDF7A371cuNOkXJAUXO5ghPg8/DzRJ0NcFUSDstCOk9116SJW8eOTJ mtAvaGlMdHChmMwUJE1cgsHutTymKwgDq5wus/pxaQPXMSbAxUktJ60IHL2L0ob/6vXm cwtOVUR5ryODctFbaMzrkqZi74womHfawl1dyAKECnmHoFga3SFM3zGt6GFUev0zubNw qkrz1VW+m01BwoiDt0w/plvG5oQMpLCCMErs7mfZwQrLub3Cysz6CD2VdDJrj0ojS4z2 H+8sGIScELfsged1CSznmw90Zf+7bCcnbbciDaqUzdbeyIP/0EzHjauKKfH5rgS9MznD zPNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=q6+v3UAe47q/u4r+CwyBoBnHsgd8clQ5wFMTPco4API=; b=KU0nddBrKkBtOoYxZJe1FCCzJQgm/hjSO1EFDPWOXYGtZLuaRYRjtbVrn/q3wr2+5m 9hPWMeawYGmeb98YbJK6Jclt+BN7pncNdbgHEa/+WyZN1eEUNZFGtc8qQKiK+2thrrjb cRclANz+HeOW0x9PmDWBHvy+vKdZEf8uG6iSibzn1j3UfEmM8z70RRCXoIOjVgFK/8BS 6vkLDHKIY8R+O93H6Z6D45do0qC+6oZZtFjqE6NhSDg+vQ6GVG5XuxPv5ylrJbd96d6b OavQSjlvtr09Ia3nqndTFwrY68FutqsQXesPPZn6DOmfqR8AuTNDRTkrc4QK7rZ52e0B uErw== X-Gm-Message-State: ALKqPwd/BXU1UTFZ6n+XoRAXkrG3CaVcqG2SeLL13GZeppdehvFLFwy6 HPkb/ojSNHlXhq428xbLFXDm/lNe X-Google-Smtp-Source: AB8JxZprHqUg2COoQ0UDZeqDJswqarpnhmaZOR8lL0pYDIZtjWSc+cMGg+74nXbhk4QvNkmeyHNVLg== X-Received: by 2002:ac8:6718:: with SMTP id e24-v6mr4216790qtp.79.1525472622439; Fri, 04 May 2018 15:23:42 -0700 (PDT) Received: from [155.41.69.31] (dhcp-wifi-8021x-155-41-69-31.bu.edu. [155.41.69.31]) by smtp.gmail.com with ESMTPSA id z50-v6sm14933136qtj.74.2018.05.04.15.23.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 May 2018 15:23:42 -0700 (PDT) Sender: Theron Tarigo Subject: Re: Temorarily disabling ACPI errors To: Andriy Gapon , Don Whitteker , freebsd-acpi@freebsd.org References: From: Theron Tarigo Message-ID: Date: Fri, 4 May 2018 18:23:41 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2018 22:23:43 -0000 On 05/04/18 17:50, Andriy Gapon wrote: > On 04/05/2018 23:43, Don Whitteker wrote: >> However I am getting spammed with 4 lines of >> errors every 3-5 seconds. > What are the errors? > >> This is making it near impossible to type out >> anything but short commands at the prompt. I can't even open a file in vi >> to try to edit before the spam covers the first 4 lines and makes it >> impossible to read or edit. > Are you saying that the messages go to all terminals / consoles? > Or are you stuck at a single console (like ttyv0) for some reason (e.g. single > user mode)? > I have what sounds like it might be the same problem with my system considering you mentioned 'hint.acpi_thermal.0.disabled="1"' : Firmware Error (ACPI): Failure looking up [\134_SB.PCI0.LPCB.HEC.ECAV], AE_NOT_FOUND (20180209/psargs-503) ACPI Error: Method parse/execution failed \134_TZ.TZ01._TMP, AE_NOT_FOUND (20180209/psparse-677) Setting boot_mute=YES in the loader prevents these from being written over your first console (although they will still waste much space in dmesg and /var/log/messages*). Theron From owner-freebsd-acpi@freebsd.org Sat May 5 06:05:24 2018 Return-Path: Delivered-To: freebsd-acpi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 27382FCB829; Sat, 5 May 2018 06:05:24 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 664B487A7F; Sat, 5 May 2018 06:05:23 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-lf0-f52.google.com with SMTP id y72-v6so20005492lfd.2; Fri, 04 May 2018 23:05:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:openpgp:autocrypt:message-id :date:user-agent:mime-version:content-language :content-transfer-encoding; bh=pCT4beGxgqt88ZDLIwMAH6yRurV9doPThjuQQYU/Qko=; b=kmrzuqEJ4AgjXNhLR780DgexG7XBxnB638l76VxXupOep1YFCT+lZWV0EyhYogxtX8 YbORuO3S30ZoAsu6ja6QY2n5zkoPNvLZTTZt3k6qaCC46Z2oBASuSqOqyNAFkc6p0r2w YiObYoynNY9uYuHTlAbe8YjBiqOIh0+d564+DlcHTAJKv1wH99/QCbKeyxEDrWD1CGL7 dZ9mQqFRO97iGdzUX9bGZZTMOs2h6nAtjT4Q3gqC4cBmNv5hzXYWDd8iVq9MrfKEIm0E iedmqd/YuGT9rbN/sw5pr9u4+DBdBsMrUF4n3SedqNzx8rb3y1YoCa6aaBA0P8jv0YyK D6wQ== X-Gm-Message-State: ALQs6tBAUsyl/F3qBN3ZCWIj/J7mGkjxwy4QoKEEGFPKFAKR9LeyI3rz mCOMLB2u5DYVnh3vG8wZtxJVdON1 X-Google-Smtp-Source: AB8JxZoJXF3DylJVflHN36D8GN89yluxju6aHKpSYO/Z7KXJeMHVfbHI3+4PQxLbfHdXMieO3jgZsg== X-Received: by 2002:a19:16c2:: with SMTP id 63-v6mr2922528lfw.3.1525500315446; Fri, 04 May 2018 23:05:15 -0700 (PDT) Received: from [192.168.0.88] (east.meadow.volia.net. [93.72.151.96]) by smtp.googlemail.com with ESMTPSA id r137-v6sm3625109lfr.17.2018.05.04.23.05.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 May 2018 23:05:14 -0700 (PDT) To: FreeBSD Current , "freebsd-acpi@freebsd.org" From: Andriy Gapon Subject: [CFT] call AcpiLeaveSleepStatePrep after re-enabling interrupts Openpgp: preference=signencrypt Autocrypt: addr=avg@FreeBSD.org; prefer-encrypt=mutual; keydata= xsFNBFm4LIgBEADNB/3lT7f15UKeQ52xCFQx/GqHkSxEdVyLFZTmY3KyNPQGBtyvVyBfprJ7 mAeXZWfhat6cKNRAGZcL5EmewdQuUfQfBdYmKjbw3a9GFDsDNuhDA2QwFt8BmkiVMRYyvI7l N0eVzszWCUgdc3qqM6qqcgBaqsVmJluwpvwp4ZBXmch5BgDDDb1MPO8AZ2QZfIQmplkj8Y6Z AiNMknkmgaekIINSJX8IzRzKD5WwMsin70psE8dpL/iBsA2cpJGzWMObVTtCxeDKlBCNqM1i gTXta1ukdUT7JgLEFZk9ceYQQMJJtUwzWu1UHfZn0Fs29HTqawfWPSZVbulbrnu5q55R4PlQ /xURkWQUTyDpqUvb4JK371zhepXiXDwrrpnyyZABm3SFLkk2bHlheeKU6Yql4pcmSVym1AS4 dV8y0oHAfdlSCF6tpOPf2+K9nW1CFA8b/tw4oJBTtfZ1kxXOMdyZU5fiG7xb1qDgpQKgHUX8 7Rd2T1UVLVeuhYlXNw2F+a2ucY+cMoqz3LtpksUiBppJhw099gEXehcN2JbUZ2TueJdt1FdS ztnZmsHUXLxrRBtGwqnFL7GSd6snpGIKuuL305iaOGODbb9c7ne1JqBbkw1wh8ci6vvwGlzx rexzimRaBzJxlkjNfMx8WpCvYebGMydNoeEtkWldtjTNVsUAtQARAQABzR5BbmRyaXkgR2Fw b24gPGF2Z0BGcmVlQlNELm9yZz7CwZQEEwEIAD4WIQS+LEO7ngQnXA4Bjr538m7TUc1yjwUC WbgsiAIbIwUJBaOagAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRB38m7TUc1yj+JAEACV l9AK/nOWAt/9cufV2fRj0hdOqB1aCshtSrwHk/exXsDa4/FkmegxXQGY+3GWX3deIyesbVRL rYdtdK0dqJyT1SBqXK1h3/at9rxr9GQA6KWOxTjUFURsU7ok/6SIlm8uLRPNKO+yq0GDjgaO LzN+xykuBA0FlhQAXJnpZLcVfPJdWv7sSHGedL5ln8P8rxR+XnmsA5TUaaPcbhTB+mG+iKFj GghASDSfGqLWFPBlX/fpXikBDZ1gvOr8nyMY9nXhgfXpq3B6QCRYKPy58ChrZ5weeJZ29b7/ QdEO8NFNWHjSD9meiLdWQaqo9Y7uUxN3wySc/YUZxtS0bhAd8zJdNPsJYG8sXgKjeBQMVGuT eCAJFEYJqbwWvIXMfVWop4+O4xB+z2YE3jAbG/9tB/GSnQdVSj3G8MS80iLS58frnt+RSEw/ psahrfh0dh6SFHttE049xYiC+cM8J27Aaf0i9RflyITq57NuJm+AHJoU9SQUkIF0nc6lfA+o JRiyRlHZHKoRQkIg4aiKaZSWjQYRl5Txl0IZUP1dSWMX4s3XTMurC/pnja45dge/4ESOtJ9R 8XuIWg45Oq6MeIWdjKddGhRj3OohsltKgkEU3eLKYtB6qRTQypHHUawCXz88uYt5e3w4V16H lCpSTZV/EVHnNe45FVBlvK7k7HFfDDkryM7BTQRZuCyIARAAlq0slcsVboY/+IUJdcbEiJRW be9HKVz4SUchq0z9MZPX/0dcnvz/gkyYA+OuM78dNS7Mbby5dTvOqfpLJfCuhaNYOhlE0wY+ 1T6Tf1f4c/uA3U/YiadukQ3+6TJuYGAdRZD5EqYFIkreARTVWg87N9g0fT9BEqLw9lJtEGDY EWUE7L++B8o4uu3LQFEYxcrb4K/WKmgtmFcm77s0IKDrfcX4doV92QTIpLiRxcOmCC/OCYuO jB1oaaqXQzZrCutXRK0L5XN1Y1PYjIrEzHMIXmCDlLYnpFkK+itlXwlE2ZQxkfMruCWdQXye syl2fynAe8hvp7Mms9qU2r2K9EcJiR5N1t1C2/kTKNUhcRv7Yd/vwusK7BqJbhlng5ZgRx0m WxdntU/JLEntz3QBsBsWM9Y9wf2V4tLv6/DuDBta781RsCB/UrU2zNuOEkSixlUiHxw1dccI 6CVlaWkkJBxmHX22GdDFrcjvwMNIbbyfQLuBq6IOh8nvu9vuItup7qemDG3Ms6TVwA7BD3j+ 3fGprtyW8Fd/RR2bW2+LWkMrqHffAr6Y6V3h5kd2G9Q8ZWpEJk+LG6Mk3fhZhmCnHhDu6CwN MeUvxXDVO+fqc3JjFm5OxhmfVeJKrbCEUJyM8ESWLoNHLqjywdZga4Q7P12g8DUQ1mRxYg/L HgZY3zfKOqcAEQEAAcLBfAQYAQgAJhYhBL4sQ7ueBCdcDgGOvnfybtNRzXKPBQJZuCyIAhsM BQkFo5qAAAoJEHfybtNRzXKPBVwQAKfFy9P7N3OsLDMB56A4Kf+ZT+d5cIx0Yiaf4n6w7m3i ImHHHk9FIetI4Xe54a2IXh4Bq5UkAGY0667eIs+Z1Ea6I2i27Sdo7DxGwq09Qnm/Y65ADvXs 3aBvokCcm7FsM1wky395m8xUos1681oV5oxgqeRI8/76qy0hD9WR65UW+HQgZRIcIjSel9vR XDaD2HLGPTTGr7u4v00UeTMs6qvPsa2PJagogrKY8RXdFtXvweQFz78NbXhluwix2Tb9ETPk LIpDrtzV73CaE2aqBG/KrboXT2C67BgFtnk7T7Y7iKq4/XvEdDWscz2wws91BOXuMMd4c/c4 OmGW9m3RBLufFrOag1q5yUS9QbFfyqL6dftJP3Zq/xe+mr7sbWbhPVCQFrH3r26mpmy841ym dwQnNcsbIGiBASBSKksOvIDYKa2Wy8htPmWFTEOPRpFXdGQ27awcjjnB42nngyCK5ukZDHi6 w0qK5DNQQCkiweevCIC6wc3p67jl1EMFY5+z+zdTPb3h7LeVnGqW0qBQl99vVFgzLxchKcl0 R/paSFgwqXCZhAKMuUHncJuynDOP7z5LirUeFI8qsBAJi1rXpQoLJTVcW72swZ42IdPiboqx NbTMiNOiE36GqMcTPfKylCbF45JNX4nF9ElM0E+Y8gi4cizJYBRr2FBJgay0b9Cp Message-ID: Date: Sat, 5 May 2018 09:05:13 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2018 06:05:24 -0000 I would like ask for help with testing this change https://reviews.freebsd.org/D15306 I want to do this change because that call (actually, AcpiHwLegacyWakePrep) does a memory allocation and ACPI namespace evaluation. Although it is not very likely to run into any trouble, it is still not safe to make those calls with interrupts disabled. Also, AcpiLeaveSleepStatePrep is documented as called when interrupts are enabled. witness(4) and malloc(9) do not currently check for a context with interrupts disabled via intr_disable and we lack a facility for doing that. So, those unsafe operations fly under the radar. But if intr_disable in acpi_EnterSleepState was replaced with spinlock_enter (which it probably should be), then witness and malloc would immmediately complain. The ACPI wakeup sequence is very sensitive to changes, but I consider this change to be rather safe. What AcpiHwLegacyWakePrep essentially does is writing a value corresponding to S0 into SLP_TYPx bits of PM1 Control Register(s). According to ACPI specifications that write should be a NOP as SLP_EN bit is not set. Additionally, there are no accesses to ACPI hardware and firmware between the old location of the call and the new one. So, the move should not affect the interaction between then OS and ACPI platform. Index: sys/dev/acpica/acpi.c =================================================================== --- sys/dev/acpica/acpi.c (revision 333269) +++ sys/dev/acpica/acpi.c (working copy) @@ -2975,8 +2975,6 @@ acpi_EnterSleepState(struct acpi_softc *sc, int st if (sleep_result == 1 && state != ACPI_STATE_S4) AcpiWriteBitRegister(ACPI_BITREG_SCI_ENABLE, ACPI_ENABLE_EVENT); - AcpiLeaveSleepStatePrep(state); - if (sleep_result == 1 && state == ACPI_STATE_S3) { /* * Prevent mis-interpretation of the wakeup by power button @@ -3005,6 +3003,8 @@ acpi_EnterSleepState(struct acpi_softc *sc, int st /* call acpi_wakeup_machdep() again with interrupt enabled */ acpi_wakeup_machdep(sc, state, sleep_result, 1); + AcpiLeaveSleepStatePrep(state); + if (sleep_result == -1) goto backout; -- Andriy Gapon