From owner-freebsd-bugs@freebsd.org Sun Feb 18 03:38:54 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A9894F0B271 for ; Sun, 18 Feb 2018 03:38:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3D3027FA83 for ; Sun, 18 Feb 2018 03:38:54 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 7C01A21326 for ; Sun, 18 Feb 2018 03:38:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w1I3crrY004396 for ; Sun, 18 Feb 2018 03:38:53 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w1I3crTE004395 for freebsd-bugs@FreeBSD.org; Sun, 18 Feb 2018 03:38:53 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 225996] tftpd(8): tftpd doesn't abort on a WRQ access violation Date: Sun, 18 Feb 2018 03:38:53 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: asomers@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Feb 2018 03:38:54 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D225996 Bug ID: 225996 Summary: tftpd(8): tftpd doesn't abort on a WRQ access violation Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: asomers@FreeBSD.org On a WRQ (write request) tftpd checks whether the client has access permiss= ion for the file in question. If not, then the write is prevented. However, t= ftpd doesn't reply with an ERROR packet, nor does it abort. Instead, it tries to receive the packet anyway. The bug is in tftp_wrq() at line 543. There is= no error handling for ecode !=3D 0. The symptom is slightly different depending on the nature of the error. If= the target file is nonexistent and tftpd lacks permission to create it, then tf= tpd will willingly receive the file, but not write it anywhere. If the file ex= ists but is not writable, then tftpd will fail to ACK to WRQ. tftp> put small.txt nonexistent Try 1, didn't receive answer from remote. Sent 7 bytes during 5.1 seconds in 1 blocks tftp> put small.txt small.txt Timeout #1 on ACK 1 Timeout #3 on ACK 1 Timeout #5 send ACK 1 giving up --=20 You are receiving this mail because: You are the assignee for the bug.=