From owner-freebsd-current@freebsd.org Sun Jun 3 01:08:19 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 07462FDF532 for ; Sun, 3 Jun 2018 01:08:19 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-it0-x22d.google.com (mail-it0-x22d.google.com [IPv6:2607:f8b0:4001:c0b::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 893AB84AA9 for ; Sun, 3 Jun 2018 01:08:18 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-it0-x22d.google.com with SMTP id d10-v6so6062058itj.1 for ; Sat, 02 Jun 2018 18:08:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=V0DFp7E8zDq+yyECaXCM9SXbX3dsG3XFjYkYlo9RICg=; b=MPeBNgTQG3RjWk3Y+P9GNPjM54C4G+6wPhgwd8pRFwnuc1q9Cia2mEFgTOlBeLMg+t rF85MQEQ+s3fZeIdRjEJ3RFDcPbSZnhQQSzmRkhi3GL62EE8uy0edayWtv0oIUmDexPs iYmlNhe2WcC875LqM9PnGdVOTlu1z4nmzyXPPeTcOxpc6zO7NvnH8x1PtpsgF5QnG6NG sWgf9A6mBmrIIPj1FBjlmGx3ViObgyRK+VgEkT3yGjc/OSe3rNKDzUAxy1Kj/tw0Uu/g rYbRC4iXOCRjNYPzmziBm+4n8oAcAWAlesgBx7Lf6rhL6OHmlk3PtWc+zTWrCYKqMDoL sf1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=V0DFp7E8zDq+yyECaXCM9SXbX3dsG3XFjYkYlo9RICg=; b=HIqi9zlXVwVhrIUOAUrxZHB00MsS5WMDvI9anFU43okqTmVMdLwKxjROlp9lSQEiNS fQTXE9hl5wm3t46zAyro2WbEsRuYMny4oDKiXS6CfvHgCrSEtWOQ017CyC8CEXETueQq XhPy3LxlWIxfMXfI67i2xFOOutvv9MOU+Lf1gHe4cLfTyfXPImA7OYUphy3wHyYFmHAS X4igLKnji3EazwFIbC4ijt/MEJKYyNMn83Ae4l2W1jUVLPO90Ih8vl+7StzQxYzVGaVu hc2r7bVPhZx/TcUEKXOmkkpLQ4mP82suqmjlyJtm7D1A6M/n7kyU45suuRcw4FvIckoa 7SjQ== X-Gm-Message-State: APt69E2xXlcb/UUvsNSmj863rcgoMVdE6T6B/gZqF8ALX/9AQf5w/l0/ 0X96KR7V99L8kSX9Xq1h+vgsJl87BFaKHsZ5QQpFnB4mG5PhWGJ6XwrMyUZSzOIZQtptyF5g1Je xaMobExnzYqeqzzLEAVk/JYP9R9I3GAJIq1uZgcQGJNi8C2Y0FLDkD+yXONl1q1fh1naytdd1ob 2mkvuAPAc= X-Google-Smtp-Source: ADUXVKLNOWvcz3cjCWz1Hx3fLFJl+c0NPSDQYuhp+pvt/NkGLhEwDYxsyyMtJkyjOhfAlZqCUlT0Zw== X-Received: by 2002:a24:6214:: with SMTP id d20-v6mr9083717itc.12.1527988097645; Sat, 02 Jun 2018 18:08:17 -0700 (PDT) Received: from mutt-hbsd (tor-exit5-readme.dfri.se. [171.25.193.25]) by smtp.gmail.com with ESMTPSA id g138-v6sm3430643iog.62.2018.06.02.18.08.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 02 Jun 2018 18:08:16 -0700 (PDT) Date: Sat, 2 Jun 2018 21:07:50 -0400 From: Shawn Webb To: freebsd-current@freebsd.org Cc: mmacy@freebsd.org Subject: Weird conditional logic in lib/libpmc/Makefile Message-ID: <20180603010750.zo4qngsqouiajcpo@mutt-hbsd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6bvesglmduh72hbc" Content-Disposition: inline X-Operating-System: FreeBSD mutt-hbsd 12.0-CURRENT FreeBSD 12.0-CURRENT X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x6A84658F52456EEE User-Agent: NeoMutt/20180323 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jun 2018 01:08:19 -0000 --6bvesglmduh72hbc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hey all, Below is some logic pasted from lib/libpmc/Makefile: =2Eif ${MACHINE_ARCH} =3D=3D "amd64" || ${MACHINE_ARCH} =3D=3D "i386" =2Eif ${MACHINE_ARCH} =3D=3D "aarch64" EVENT_ARCH=3D"arm64" =2Eelif ${MACHINE_ARCH} =3D=3D "amd64" || ${MACHINE_ARCH} =3D=3D "i386" EVENT_ARCH=3D"x86" =2Eelif ${MACHINE_ARCH} =3D=3D "powerpc" EVENT_ARCH=3D"powerpc" =2Eendif JEVENTS=3D ${BTOOLSPATH:U.}/pmu-events/jevents # This file is built in a subdirectory so never try to rebuild # it here due to missing meta file. ${JEVENTS}: .NOMETA libpmc_events.c: ${JEVENTS} ${JEVENTS} ${EVENT_ARCH} ${.CURDIR}/pmu-events/arch libpmc_events.c SRCS+=3D libpmc_events.c =2Eendif Why perform the conditionals for aarch64 and powerpc when it can't be those? "Am I missing something? I'm looping in Matt Macy, who was the last person to touch the file. Thanks, --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --6bvesglmduh72hbc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAlsTP2IACgkQaoRlj1JF bu45mg/8CCfv2XCKlRlzPtqPNO+9XD4vMGeicyTV0OvIOTOp5HXiiXe72PDyBP+P D9rvgnpfK5e400k4H/ELnByaqdgyWbOiLSySBXAY8Z3aZlI2ftP0+X89DY4F5FJs yrUaKavTQGkOqXL5R+acga8CkqqvXfgz8IHScewDnjTJoa5ZaJu0LoJpf3ABQBfO 941IZ/cNsCilwbEc08cwxu01JJv0/8PASZu83ABbBKdmUBmv/KLnmkPAoLrpkri3 mHEHhGQ8N3butgUWMFXZV9sYCVxmVnMyze2s2ccD16goQDuNW3xZCimnf7wi25bS 1sl7DlTtTaWsuhN5S527wdIWeqQKirLZ5HCa2RpwuS/lVdjWaqa4pfct+S8nWRq3 5aIj31XmSCcvD3DnBLBkZaftFT6M+N3WsC7llKnVREly0MzFZkv30mVJB0rQShfn 11MThyfWWYEJnTGmRI9dFA+G6/wpvpPefkd9Yle9FbSHoNS0ySt916HwJswzoLfJ QICFJSPMNST4CMvaDEWhVZONot2FbAzNTM1nnlvY81NBFK6fobR1Jps7LTCjqiqT Om8NKtgh4/Ob4o8hCnfWbvMICL4Zt5UPLBkoaxWUDfYAWUXxPzZE1GzWVQd3v28C gpKNNYQOza0vVi7YwWBfd8rpU0wAWzBa0xNRVFIeIv7zfHlrFrw= =KB6N -----END PGP SIGNATURE----- --6bvesglmduh72hbc--