From owner-freebsd-fs@freebsd.org Sun Jun 24 21:00:50 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C6788100FC71 for ; Sun, 24 Jun 2018 21:00:50 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 5846A7A87E for ; Sun, 24 Jun 2018 21:00:50 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 18AF8100FC62; Sun, 24 Jun 2018 21:00:50 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E8E4D100FC60 for ; Sun, 24 Jun 2018 21:00:49 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 873DE7A879 for ; Sun, 24 Jun 2018 21:00:49 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id D360A9819 for ; Sun, 24 Jun 2018 21:00:48 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w5OL0m2J047041 for ; Sun, 24 Jun 2018 21:00:48 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w5OL0m3S047037 for fs@FreeBSD.org; Sun, 24 Jun 2018 21:00:48 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <201806242100.w5OL0m3S047037@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: fs@FreeBSD.org Subject: Problem reports for fs@FreeBSD.org that need special attention Date: Sun, 24 Jun 2018 21:00:48 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jun 2018 21:00:51 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- New | 203492 | mount_unionfs -o below causes panic New | 217062 | for file systems mounted with -o noexec, exec=off New | 221909 | [ZFS] Add a sysctl to toggle send_corrupt_data Open | 136470 | [nfs] Cannot mount / in read-only, over NFS Open | 139651 | [nfs] mount(8): read-only remount of NFS volume d Open | 140068 | [smbfs] [patch] smbfs does not allow semicolon in Open | 144447 | [zfs] sharenfs fsunshare() & fsshare_main() non f Open | 211491 | System hangs after "Uptime" on reboot with ZFS 8 problems total for which you should take action. From owner-freebsd-fs@freebsd.org Mon Jun 25 16:43:20 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9A9A81015F3D for ; Mon, 25 Jun 2018 16:43:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 31C4084119 for ; Mon, 25 Jun 2018 16:43:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id E23441015F3C; Mon, 25 Jun 2018 16:43:19 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CFD451015F3B for ; Mon, 25 Jun 2018 16:43:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6A7F384113 for ; Mon, 25 Jun 2018 16:43:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 9D8751424C for ; Mon, 25 Jun 2018 16:43:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w5PGhIgd072824 for ; Mon, 25 Jun 2018 16:43:18 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w5PGhIt8072822 for fs@FreeBSD.org; Mon, 25 Jun 2018 16:43:18 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 228354] mount_smbfs - long hostname causes stack overflow Date: Mon, 25 Jun 2018 16:43:18 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2018 16:43:20 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D228354 --- Comment #12 from commit-hook@freebsd.org --- A commit references this bug: Author: brooks Date: Mon Jun 25 16:42:50 UTC 2018 New revision: 335641 URL: https://svnweb.freebsd.org/changeset/base/335641 Log: Fix a stack overflow in mount_smbfs when hostname is too long. The local hostname was blindly copied into the to the nn_name array. When the hostname exceeded 16 bytes, it would overflow. Truncate the hostname to 15 bytes plus a 0 terminator which is the "workstation name" suffix. Use defensive strlcpy() when filling nn_name in all cases. PR: 228354 Reported by: donald.buchholz@intel.com Reviewed by: jpaetzel, ian (prior version) Discussed with: Security Officer (gtetlow) MFC after: 3 days Security: Stack overflow with the hostname. Sponsored by: DARPA, AFRL Differential Revision: https://reviews.freebsd.org/D15936 Changes: head/contrib/smbfs/lib/smb/ctx.c head/contrib/smbfs/lib/smb/nbns_rq.c --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Mon Jun 25 16:56:16 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 92A951016537 for ; Mon, 25 Jun 2018 16:56:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 283A684635 for ; Mon, 25 Jun 2018 16:56:16 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id D35591016535; Mon, 25 Jun 2018 16:56:15 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C00B61016534 for ; Mon, 25 Jun 2018 16:56:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4E1EB84630 for ; Mon, 25 Jun 2018 16:56:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 7ACAF143B1 for ; Mon, 25 Jun 2018 16:56:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w5PGuE3m097228 for ; Mon, 25 Jun 2018 16:56:14 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w5PGuEoi097227 for fs@FreeBSD.org; Mon, 25 Jun 2018 16:56:14 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 228354] mount_smbfs - long hostname causes stack overflow Date: Mon, 25 Jun 2018 16:56:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: brooks@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: brooks@FreeBSD.org X-Bugzilla-Flags: mfc-stable10? mfc-stable11? X-Bugzilla-Changed-Fields: flagtypes.name assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jun 2018 16:56:16 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D228354 Brooks Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |mfc-stable10?, | |mfc-stable11? Assignee|fs@FreeBSD.org |brooks@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Wed Jun 27 02:22:57 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B6BD51028752 for ; Wed, 27 Jun 2018 02:22:57 +0000 (UTC) (envelope-from esr@mail.hebrew.edu) Received: from mail-it0-x233.google.com (mail-it0-x233.google.com [IPv6:2607:f8b0:4001:c0b::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5460A8E9F1 for ; Wed, 27 Jun 2018 02:22:56 +0000 (UTC) (envelope-from esr@mail.hebrew.edu) Received: by mail-it0-x233.google.com with SMTP id 128-v6so5279511itf.1 for ; Tue, 26 Jun 2018 19:22:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail-hebrew-edu.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=hQNySRk0OkLV8rI33BOPVjcjc3fiKs/Ggl1nx7mQ2ZQ=; b=FP+B9LvTDelZvVlVywMk84AwWi9xxJO+YGLM+ON7aP9CpAdaJH+McvNejN//TUV26Z tzKfboWT8cJXpvPTDv06OYvVV9I8g3V02KGFtiIwmxqrQysc4/Xf61H5/LlJT/hD5nFN y54DnnLf1Ey+zAQV9OPSSoOqHzME8Q21CnjdqHc+fe0Uq1vwhapqfQoz58CkHIIadWXK 1npzLETMFIAeapfumoxMj6A/4BPK183zpyYIMIOUMAEf5xYxlpt8MKTJmCK/jfA3wpCv +BywvBVUqpfcQumLhEvQ6b6PiWApMySY5uL+qPW8JXa0vRW7WGMgEf/hEmjK2W7c6Qgj 97JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hQNySRk0OkLV8rI33BOPVjcjc3fiKs/Ggl1nx7mQ2ZQ=; b=mqxN8D5gFfLo6f4AvhxxY8dirv90zeGO+AoTzk6/LC7kqOk0mzpb7GCGuoqFaMv5qx 9Nq/pcF1Bxf/PrS6JSKr9SlEgqaHBs439tRNSUWs2WV8CaEplpA13FijylIVNjU/SE+Y Uf12UDz1XXyTCug9W+moh2anrv6rXAncBnH6Jjkzy4STwvf5h1aH1f/v6AuHty2br50N DJIcxbLj9RR+jj7szaCazpxH6tEmE35RsYFUzL65OCGZG34uju2S7Y0UAGOpM6dKaUBW 5sr+Bjtnha2jj/c+3bcQ3ka5SuxdYFu7/tdbuZYVkmf5oCmbS/QAwJ/D7Q+9QvxNO/Pb 2FPg== X-Gm-Message-State: APt69E1WviFfu4LGxeCYpy2vX5SNmxI1di57MQIGcNfAt5FCmhFVTnXN 9GNQT+danKzDVqLtiCrLue7BHuMQW7/aaQgpjoI+0Q== X-Google-Smtp-Source: AAOMgpeSnvrzsN3UL4CU1LyUPslohMhuyVgAHW4XFBWtpfSkK4jcb+BFQbWvlEEAhie0dvyj2MjdyjxYI+o8FHXtryo= X-Received: by 2002:a24:c106:: with SMTP id e6-v6mr1145213itg.126.1530066176200; Tue, 26 Jun 2018 19:22:56 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4f:d111:0:0:0:0:0 with HTTP; Tue, 26 Jun 2018 19:22:55 -0700 (PDT) In-Reply-To: References: From: "E.S. Rosenberg" Date: Wed, 27 Jun 2018 05:22:55 +0300 Message-ID: Subject: Re: raw filesystem counters To: "Eric A. Borisch" Cc: freebsd-fs@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 02:22:58 -0000 //I hope it's not considered a problem that I'm reviving this old thread. That is a really cool patch thanks! Will see if I can get the ZFS admins to allow me to use it... A small follow up question: Is there any easily parsable way to find what disks are part of a pool? zpool status poolname is a nightmare to parse. Your patched output would be slightly better to parse but still not ideal because depending on whether or not disks are in raidz or not they may be more or less indented... On Tue, Feb 20, 2018 at 10:24 PM, Eric A. Borisch wrote: > On Tue, Feb 13, 2018 at 1:56 PM, E.S. Rosenberg > wrote: > > Wow Eric that is exactly what I was looking for! > > Thanks! > > Nothing similar exists for ZFS correct? > > Thanks again, > > Eli > > Here's a quick patch to zpool that adds a "raw" mode when > ZPOOL_RAW_STATS is set (to anything) in the environment. Outputs are > not averaged by time, so the first output has absolute counters from > boot, and subsequent (if provided an interval, eg zpool iostat 5) *are > not* averaged over the period. You could certainly average for > interval but not initial; I just chose to remove all averaging. > > https://gist.github.com/eborisch/c610c55cd974b9d4070c2811cc04cd8f > > Could also be implemented as a -p (parsable) flag to zpool iostat, but > this was less intrusive to code up. > > On my system (with the above patch): > > $ zpool iostat > > capacity operations bandwidth > pool alloc free read write read write > ---------- ----- ----- ----- ----- ----- ----- > system 67.2G 13.8G 9 51 159K 879K > tome 2.94T 697G 19 34 949K 645K > ---------- ----- ----- ----- ----- ----- ----- > > $ ZPOOL_RAW_STATS=1 zpool iostat > > pool/dev,alloc,free,rops,wops,rbytes,wbytes > system,72199012352,14774075392,42138123,228011166,717996265472, > 3978917265408 > tome,3237433278464,748296372224,87257557,150639839,4293053411328, > 2918490030080 > > $ ZPOOL_RAW_STATS=1 zpool iostat -v > > pool/dev,alloc,free,rops,wops,rbytes,wbytes > system,72200007680,14773080064,42138142,228019481,717997350912, > 3979089575936 > ::gpt/system,72200007680,14773080064,42138142,228019481,717997350912, > 3979089575936 > tome,3237679747072,748049903616,87257714,150656638,4293054717952, > 2918798745600 > ::mirror,3237679747072,748049903616,87257682,146824479,4293052755968, > 2461179686912 > ::::diskid/DISK-NNNNNNNp1,-,-,49889874,46124191, > 3718731919360,2468656459776 > ::::diskid/DISK-NNNNNNNp1,-,-,50357481,45933366, > 3683843850240,2468656459776 > ::gpt/log,1875968,2128830464,32,3832159,1961984,457619058688 > > With an uptime of ~51 days. > > Enjoy! > - Eric > From owner-freebsd-fs@freebsd.org Wed Jun 27 11:59:44 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 56E59101F334 for ; Wed, 27 Jun 2018 11:59:44 +0000 (UTC) (envelope-from SRS0=7/i7=JN=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [94.124.105.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DF01279C2C for ; Wed, 27 Jun 2018 11:59:43 +0000 (UTC) (envelope-from SRS0=7/i7=JN=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (localhost [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id 6C7F628412; Wed, 27 Jun 2018 13:59:36 +0200 (CEST) Received: from illbsd.quip.test (ip-86-49-16-209.net.upcbroadband.cz [86.49.16.209]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id 45BA32840C; Wed, 27 Jun 2018 13:59:35 +0200 (CEST) Subject: Re: raw filesystem counters To: "E.S. Rosenberg" , "Eric A. Borisch" Cc: freebsd-fs@freebsd.org References: From: Miroslav Lachman <000.fbsd@quip.cz> Message-ID: <52505cfc-f656-f761-e92c-8a4be2c78fbf@quip.cz> Date: Wed, 27 Jun 2018 13:59:34 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.3 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 11:59:44 -0000 E.S. Rosenberg wrote on 2018/06/27 04:22: > //I hope it's not considered a problem that I'm reviving this old thread. > > That is a really cool patch thanks! > Will see if I can get the ZFS admins to allow me to use it... > > A small follow up question: > Is there any easily parsable way to find what disks are part of a pool? > zpool status poolname is a nightmare to parse. > > Your patched output would be slightly better to parse but still not ideal > because depending on whether or not disks are in raidz or not they may be > more or less indented... You are not using nested vdevs then you can use relatively simple parsing method From this standard output # zpool status tank0 pool: tank0 state: ONLINE scan: scrub repaired 0 in 160h57m with 0 errors on Wed Jun 6 20:02:52 2018 config: NAME STATE READ WRITE CKSUM tank0 ONLINE 0 0 0 raidz1-0 ONLINE 0 0 0 gpt/disk0tank0 ONLINE 0 0 0 gpt/disk1tank0 ONLINE 0 0 0 gpt/disk2tank0 ONLINE 0 0 0 gpt/disk3tank0 ONLINE 0 0 0 errors: No known data errors You can get the list of devices by this ugly command. (it can be somewhat optimised, I wrote it now in a minute, just as an example) # zpool status tank0 | sed -n '/NAME/,/^$/p' | tail -n +4 | awk '$1 != "" { print $1 }' gpt/disk0tank0 gpt/disk1tank0 gpt/disk2tank0 gpt/disk3tank0 sed -n '/NAME/,/^$/p' - this will take the part of the original output from header line starting with word NAME till the first blank line tail -n +4 - this will take the part from the fourth line (skipping NAME line, tank0 line and raidz1-0 line) Now you have the disks, awk will print just their names, skipping last empty line of output. And if you need some ugly oneliner the get the stats... # gstat -b -I 5s -f `zpool status tank0 | sed -n '/NAME/,/^$/p' | tail -n +4 | awk '$1 != "" { if (disk != "") { disk=disk"|"$1 } else { disk=$1 } } END { print disk }'` dT: 5.004s w: 5.000s filter: gpt/disk0tank0|gpt/disk1tank0|gpt/disk2tank0|gpt/disk3tank0 L(q) ops/s r/s kBps ms/r w/s kBps ms/w %busy Name 0 0 0 0 0.0 0 0 0.0 0.0 gpt/disk0tank0 0 0 0 0 0.0 0 0 0.0 0.0 gpt/disk2tank0 0 0 0 0 0.0 0 0 0.0 0.0 gpt/disk1tank0 0 0 0 0 0.0 0 0 0.0 0.0 gpt/disk3tank0 Miroslav Lachman From owner-freebsd-fs@freebsd.org Wed Jun 27 18:07:03 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 16EF21030735 for ; Wed, 27 Jun 2018 18:07:03 +0000 (UTC) (envelope-from Ethan.capricornleadszz@outlook.com) Received: from APC01-PU1-obe.outbound.protection.outlook.com (mail-oln040092254066.outbound.protection.outlook.com [40.92.254.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT TLS CA 4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C35CC8AE89 for ; Wed, 27 Jun 2018 18:07:01 +0000 (UTC) (envelope-from Ethan.capricornleadszz@outlook.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ySsR45gNIGwDunc8FokmXjSKn7UkP4r3U8vf3ILhwH8=; b=CH0YLSnmtyjGX+MxtQjs/0YIBcnZaJntYqdVdhtfWaDe3fAaDT78SibgGuYPmGByVGcEXY164aro4NFkP69a1J8fp/9Ziy6KjQuBdgwPoFrtBuJFOXN6YHA65GVXvfpm6b1xLMtgcLhklpf0wxjNmOmKM912pH+adEAZVnLLClyw/GT6PurcFSrLYADwC97Xl1ehz2rcHRoWGJBfQj48G9qn3PSlenfd5uJZDcO9dwu8FdEO4lE1WAihO1ZuH+6OcuU/MsME5VrEyFipqDENXt4Yrem/3eQ6UGidKh4FmCQ834KY7TTzjq+5z7XpfTaYFY03RvfV2Qr39bRRI5Zrjg== Received: from SG2APC01FT012.eop-APC01.prod.protection.outlook.com (10.152.250.55) by SG2APC01HT068.eop-APC01.prod.protection.outlook.com (10.152.251.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.20.906.15; Wed, 27 Jun 2018 18:06:58 +0000 Received: from HK2PR0302MB2628.apcprd03.prod.outlook.com (10.152.250.56) by SG2APC01FT012.mail.protection.outlook.com (10.152.250.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.20.906.15 via Frontend Transport; Wed, 27 Jun 2018 18:06:58 +0000 Received: from HK2PR0302MB2628.apcprd03.prod.outlook.com ([fe80::a491:44cd:3a61:8871]) by HK2PR0302MB2628.apcprd03.prod.outlook.com ([fe80::a491:44cd:3a61:8871%7]) with mapi id 15.20.0906.023; Wed, 27 Jun 2018 18:06:57 +0000 From: Ethan Ford To: "freebsd-fs@freebsd.org" Subject: Kaspersky - AntiVirus Software - Users list Thread-Topic: Kaspersky - AntiVirus Software - Users list Thread-Index: AdQOQRJqAbOf6NRCSpuLNyMTh0bHrw== Date: Wed, 27 Jun 2018 18:06:57 +0000 Message-ID: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-incomingtopheadermarker: OriginalChecksum:6BF2C1AAEFAD8A92825BE48E51F0E73843BC9F8E357EC248FD22CC54462C498B; UpperCasedChecksum:5975A42BF05EEB511B7041BD1313B313887891598CFB68FE7FB4387F1DC38A88; SizeAsReceived:7121; Count:46 x-tmn: [jQ1eTk24TiLq8b0HLl0NrmoAE6Ui5OLH] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SG2APC01HT068; 7:HwmwdoKbM64lrGTJ/XB66INrvBz7tka8xiReBilbiw2ycv0zGdmeqaAdfoHBme6bwjqN5CUBEiSl7cnu9oqetuxNG38O/B2USjTjR2bL36UFeixFXAJDWNHfQNHDCzpo1Gx5VM4ZrJdx7sKVC66J+/o7kfoYGqb0tW1Rm6q25SlazETrVf2K2TUz1511t39JIg75HsC/k61ud/PXmpJh2x+mCPLcc7xjqfAaKHccLMO12ni3MoTZEgdvMPsKK4w9 x-incomingheadercount: 46 x-eopattributedmessage: 0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1603101448)(1601125500)(1701031045); SRVR:SG2APC01HT068; x-ms-traffictypediagnostic: SG2APC01HT068: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(444000031); SRVR:SG2APC01HT068; BCL:0; PCL:0; RULEID:; SRVR:SG2APC01HT068; x-forefront-prvs: 0716E70AB6 x-forefront-antispam-report: SFV:NSPM; SFS:(7070007)(189003)(199004)(25786009)(5250100002)(6306002)(5660300001)(87572001)(54896002)(55016002)(426003)(105586002)(106356001)(33656002)(2351001)(6916009)(20460500001)(82202002)(99286004)(9326002)(6436002)(5640700003)(68736007)(2501003)(2900100001)(86362001)(256004)(14444005)(72206003)(81156014)(8936002)(6346003)(26005)(476003)(102836004)(8676002)(97736004)(626008)(14454004)(74316002)(486006)(790700001)(104016004)(7696005)(19870200002); DIR:OUT; SFP:1901; SCL:1; SRVR:SG2APC01HT068; H:HK2PR0302MB2628.apcprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:; received-spf: None (protection.outlook.com: outlook.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Ethan.capricornleadszz@outlook.com; x-microsoft-antispam-message-info: FgILgHOP8MJ4uqLTMYTlP+58DDTPa6rshDiWxUyi4x4Yz/yUD+LGsrEImAUt+/Ljl0bSEX0kaa+R1K7bjyrsJ9iWlAZvSpdcOqxvEuN2lCxv98Z4TtPE2ACzZYXSIbfLp09pKSlxM7yxbOrkaFfLFD82nybTyfACRTc8JcRk2B9JkDbJgBbKa3Jy/HMhGpAyliv2zdValLxo+YsSKbFXkmjAehIWsoBEeaQARD+AkJ4= MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 54485d23-c432-40fe-8436-6091d627118c X-MS-Exchange-CrossTenant-Network-Message-Id: e2becec8-8399-4add-6798-08d5dc58c5f8 X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 54485d23-c432-40fe-8436-6091d627118c X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jun 2018 18:06:57.8635 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2APC01HT068 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jun 2018 18:07:03 -0000 Hi, Hope you're doing great. We are a global database provider and preferred pa= rtners for Enterprise, Media and Small size companies. I am writing to you in regards to our recent lists released, and check if y= ou would be interested in acquiring our recently verified AntiVirus Softwar= e User's list and Other Related Software User's database. Every contact fro= m this database has completed verification as on 16th of January 2018 to gi= ve you 95%+ accuracy. We gather user's information from: * Kaspersky Anti-Virus * Symantec * ESET * MalwareBytes * McAfee * Avast Software * Avira * Trend Micro * BitDefender and much more... Other multi-channel programs we are mainly specialized in Technology Indust= ry Database currently holding 3200+ application users type. Please let me know your thoughts, thanks for your time and we hope to hear = from you soon. Regards, Ethan Ford Sr. Demand Generation Executive If you don't wish to receive any further emails plz reply with Opt Out. From owner-freebsd-fs@freebsd.org Sat Jun 30 20:19:36 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EDEBBFDA9D7 for ; Sat, 30 Jun 2018 20:19:35 +0000 (UTC) (envelope-from paul@mueller-blockhaus.de) Received: from wp188.webpack.hosteurope.de (wp188.webpack.hosteurope.de [IPv6:2a01:488:42:1000:50ed:84c3::]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 89B1A8B711 for ; Sat, 30 Jun 2018 20:19:35 +0000 (UTC) (envelope-from paul@mueller-blockhaus.de) Received: from p54af4f56.dip0.t-ipconnect.de ([84.175.79.86] helo=[192.168.1.26]); authenticated by wp188.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1fZMLE-0003a6-0f; Sat, 30 Jun 2018 22:19:32 +0200 To: freebsd-fs@freebsd.org From: Paul Blockhaus Subject: Question to zfs scrub code Message-ID: <5d2ccda7-e306-2b1b-090a-27f7ec564296@mueller-blockhaus.de> Date: Sat, 30 Jun 2018 22:19:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de; paul@mueller-blockhaus.de; 1530389975; 30a95cca; X-HE-SMSGID: 1fZMLE-0003a6-0f X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jun 2018 20:19:36 -0000 Hello folks, I'm not entirely shure wether this is the right place to ask, but maybe someone can help my anyway. I'm trying to understand how the zfs scrub code works, but I'm stuck at dsl_scan in dsl_scan.c, it just looks like a dead end in the code. All called functions don't seem to traverse any data blocks and just magically end in a scrubbed pool. What am I missing? Is there any documentation where the scrub continues? Or does anyone of you can explain, what happens in and after the dsl_scan function? Thanks in advance, Paul