From owner-freebsd-fs@freebsd.org Sun Nov 25 08:31:17 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B5AC114BA91 for ; Sun, 25 Nov 2018 08:31:17 +0000 (UTC) (envelope-from mckusick@mckusick.com) Received: from chez.mckusick.com (chez.mckusick.com [70.36.157.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5C51A7AA9B for ; Sun, 25 Nov 2018 08:31:16 +0000 (UTC) (envelope-from mckusick@mckusick.com) Received: from chez.mckusick.com (localhost [IPv6:::1]) by chez.mckusick.com (8.15.2/8.15.2) with ESMTP id wAP8cXoj046038; Sun, 25 Nov 2018 00:38:33 -0800 (PST) (envelope-from mckusick@mckusick.com) Message-Id: <201811250838.wAP8cXoj046038@chez.mckusick.com> From: Kirk McKusick To: soralx@cydem.org Subject: Re: [bug] fsck refuses to repair damaged UFS using backup superblock cc: "Julian H. Stacey" , freebsd-fs@freebsd.org X-URL: http://WWW.McKusick.COM/ Reply-To: Kirk McKusick In-reply-to: <201811230117.wAN1HKAT037185@fire.js.berklix.net> Comments: In-reply-to "Julian H. Stacey" message dated "Fri, 23 Nov 2018 02:17:20 +0100." MIME-Version: 1.0 Content-ID: <46001.1543135061.0@chez.mckusick.com> Date: Sun, 25 Nov 2018 00:38:33 -0800 X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,MISSING_MID, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on chez.mckusick.com X-Rspamd-Queue-Id: 5C51A7AA9B X-Spamd-Result: default: False [1.60 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[mckusick@mckusick.com]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-0.01)[-0.008,0]; MIME_GOOD(-0.10)[multipart/mixed,text/plain]; DMARC_NA(0.00)[mckusick.com]; AUTH_NA(1.00)[]; NEURAL_SPAM_SHORT(0.78)[0.780,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[chez.mckusick.com]; RCVD_IN_DNSWL_NONE(0.00)[235.157.36.70.list.dnswl.org : 127.0.10.0]; NEURAL_HAM_MEDIUM(-0.14)[-0.143,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:46375, ipnet:70.36.128.0/19, country:US]; RCVD_COUNT_TWO(0.00)[2]; IP_SCORE(-0.02)[country: US(-0.09)]; MIME_UNKNOWN(0.10)[application/text] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Nov 2018 08:31:17 -0000 > To: soralx@cydem.org > Subject: Re: [bug] fsck refuses to repair damaged UFS using backup super= block > From: "Julian H. Stacey" > Organization: http://berklix.eu BSD Unix Linux Consultants, Munich Germa= ny > Date: Fri, 23 Nov 2018 02:17:20 +0100 > = > Hi soralx@cydem.org, > Added cc: to ensure file system specialists see= this. > = > Reference: >> From: >> Date: Tue, 20 Nov 2018 05:30:00 -0800 > = > soralx@cydem.org wrote: >> = >> Howdy! >> = >> Since send-pr(1) is now gone, I guess the next option is to send a >> message directly to the developers... >> = >> Yesterday, I ran into a bug in fsck_ffs that gave me a little scare. >> = >> Short story: on -CURRENT, fsck refuses to check a FS with a corrupted >> superblock, even when an alternate (backup) SB location is given. >> = >> Long story. I've been testing a newly-built system based on an X399 >> platform with a 2950X CPU and an Optane 905P 480GB U.2 drive. The >> system ran a ~2-day old -CURRENT; when compiling newest world and >> kernel, I found the machine in a locked-up state. After a hard reset, >> boot failed because the root FS became corrupted & was not available: >> kernel: Superblock check-hash failed: recorded check-hash XXX !=3D c= omputed check-hash YYY >> = >> I have not yet figured out why the corruption happened... bad hardware= ? >> bug in the NVMe driver? >> = >> "OK", I thought, "No worries. We'll just boot using another disk, fsck >> the corrupted FS with a backup superblock, and be up in a moment". >> The machine was doing nothing but compiling, so no valuable data loss. >> = >> So I did `dumpfs -m /dev/ada0p3` on the spare disk (which was the >> source for the new disk image, thus had almost identical partitions >> and filesystems) to get the FS details, then did `newfs -N [...] >> /dev/ada0p3` to find locations of superblock backups, then finally >> ran `fsck_ffs -b 192 /dev/nvd0p3` -- only to get the same "check- >> -hash failed" message, plus another strange message: "Can't open >> /dev/nvd0p3: [...]". Then fsck quits. >> Note that `fsck_ffs -b ...` on a FS with good superblock works OK. >> = >> After fiddling with a debugger for a bit, I commented out the line >> "return (0);" in /usr/src/sbin/fsck_ffs/setup.c:136, recompiled fsck, >> and the FS was recovered successfully. >> = >> What was actually happening: fsck's setup.c calls ufs_disk_fillout() >> from libufs' type.c, which in turn calls sbread() from the same >> library, which then calls sbget(disk->d_fd, &fs, -1) [[where '-1' >> is hard-coded to indicate the primary superblock]] that then simply >> invokes ffs_sbget from ffs kernel driver -- and this returns ENOENT, >> which eventually causes fsck to give up before even looking at the >> specified backup superblock. >> = >> I don't know what exactly ufs_disk_fillout() does, but fortunately >> for me, fsck worked without the "sbread(disk)" part of that function >> having much luck on a disk with corrupted superblock. Also, I have a >> feeling that calling a kernel's ffs driver function when using fsck >> to fix a broken filesystem is not the best thing to do... >> = >> Please CC, as I am not subscribed. >> = >> -- = >> [SorAlx] ridin' VN2000 Classic LT > = > Cheers, > Julian Below is a proposed fix for fsck_ffs to properly handle superblock check-hash failures (notably to optionally search for a usable alternate superblock). Let me know if you still have a filesystem on which you can test it, and if so whether it works correctly. Kirk McKusick From owner-freebsd-fs@freebsd.org Sun Nov 25 15:25:25 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 60DE011369E2 for ; Sun, 25 Nov 2018 15:25:25 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660064.outbound.protection.outlook.com [40.107.66.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8D9806A3E1 for ; Sun, 25 Nov 2018 15:25:23 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM (52.132.50.155) by YTOPR0101MB2172.CANPRD01.PROD.OUTLOOK.COM (52.132.46.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.26; Sun, 25 Nov 2018 15:25:21 +0000 Received: from YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM ([fe80::9c71:6eb6:1bff:727b]) by YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM ([fe80::9c71:6eb6:1bff:727b%5]) with mapi id 15.20.1294.048; Sun, 25 Nov 2018 15:25:21 +0000 From: Rick Macklem To: "soralx@cydem.org" , Kirk McKusick CC: "freebsd-fs@freebsd.org" , "Julian H. Stacey" Subject: Re: [bug] fsck refuses to repair damaged UFS using backup superblock Thread-Topic: [bug] fsck refuses to repair damaged UFS using backup superblock Thread-Index: AQHUhJlTgUa5G9TQ8USwP5697EmSSKVgmAwV Date: Sun, 25 Nov 2018 15:25:21 +0000 Message-ID: References: <201811230117.wAN1HKAT037185@fire.js.berklix.net>, <201811250838.wAP8cXoj046038@chez.mckusick.com> In-Reply-To: <201811250838.wAP8cXoj046038@chez.mckusick.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rmacklem@uoguelph.ca; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; YTOPR0101MB2172; 6:39aTxq2pLdWRjxgf7bfeRRYZxGQ4s3WGaXAO1W1B3sCFDvBruCh8W8qBbWtRKcxSUaZ9k8zFEbsMhyvF90p2w80sIgEaHkgjv2XVEKkdZxAJHx7s+iaFoxNpc2i6C/31kYhYcCx7znNHqsgedYdR07yfUM7cxNaav2jmbu8KAcir5MEuv0rMGaVn4/ZKs80/OJEjSlFsF8rpzbuHGyCS585WfjLitPwzlusV1YlfwQYonF1wEh5lbKzxwzDTY7ibVFkZyyQWRVGlHicuzWGBAvq6QkflYI0FRpzoqhtrH6V9Gyiv9r0DJrNAZr3ZAqmm4O14MGmQoyLv5D1j7hOEKulpGo1WQT3LNJNb5uhsASq5bCKy4hBcBQD3aA5bRzPL5ZmegVeurSrmy5SH8B4P3r0zF73hLtWRqtt5MPqyyZUuWbDVFBxaEFhhzAPZfKyTyEVXDZlta2tkaP5CtzXDUg==; 5:2qcFXDXFkqbyDDGHEoP9/Zirm+ZanLLW/c/sHDu7qHBJ7ViBTeBqDarNYU33dRxrcsChmMXZ/aQ0YLJL5y5VKumFJhSotMEzbqunDo1SF2J2zZDvA9uWr+ULutN3MZYzrKPDNOd31vAUkgZPd9j8ImNdFu7lVNQ4KpQ6VltJKSg=; 7:haa9kBuilZWVAu4Yzsq3tj8gegsvY/NKkPaXRl2m24FuhEFAwCXFxcfbrVMA9vqttrBfXS3EruiHQI3FUp+0JcdcKF4x6Jr4Ik8DBqlojAcXzx5dXaiOTZje3Yz9uIkWpGe68ZiVRsQW35bhvxV6JA== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 12e503d1-08a6-4954-02cd-08d652ea369c x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:YTOPR0101MB2172; x-ms-traffictypediagnostic: YTOPR0101MB2172: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(10201501046)(3231442)(944501410)(4982022)(52105112)(3002001)(93006095)(93001095)(148016)(149066)(150057)(6041310)(20161123564045)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123560045)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:YTOPR0101MB2172; BCL:0; PCL:0; RULEID:; SRVR:YTOPR0101MB2172; x-forefront-prvs: 0867F4F1AA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39850400004)(396003)(366004)(136003)(199004)(189003)(53386004)(81156014)(6436002)(81166006)(8936002)(9686003)(2501003)(55016002)(6306002)(74316002)(305945005)(71190400001)(71200400001)(8676002)(99286004)(7696005)(486006)(76176011)(6246003)(14444005)(316002)(33656002)(68736007)(54906003)(110136005)(97736004)(966005)(4326008)(105586002)(478600001)(14454004)(256004)(106356001)(74482002)(2906002)(476003)(186003)(5660300001)(6506007)(446003)(25786009)(786003)(53936002)(575784001)(46003)(229853002)(86362001)(102836004)(11346002)(21314003); DIR:OUT; SFP:1101; SCL:1; SRVR:YTOPR0101MB2172; H:YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-microsoft-antispam-message-info: bSIiKSkvR4lwdErj5ZKTOaX9GAwB0aEVcfIo2UXV2rsnexrGZGCoC7nHt7F18XpWw8waipG/sDSw9HzRtXeLEuAco92H7+L2y85K/kMVz9lOMNym8oP8mhhoce+V4sIyvb+lMssV17p3q6jre3DM57Q1ktyf5kklvH+F/wRcjGqEvsX1Ebbl+7Nbbmb1yLBuR+ErDe8Kh3Q7Tfwnk9JCa++Yo9zqMTnCwA7LOVM7Js/j+n0G46K5eTnHZYef3I/npk3rCdQ4Qs3P38VlsHh+gguhwGERIroGOHKjJVjuLo4PNJTS4AuWsHWhDVn6p/Ii4LJcY9viTcy7XeyMkmSqQp1xt5K8JM1szO2tC1nrNLo= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 12e503d1-08a6-4954-02cd-08d652ea369c X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2018 15:25:21.0722 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTOPR0101MB2172 X-Rspamd-Queue-Id: 8D9806A3E1 X-Spamd-Result: default: False [-2.83 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-0.97)[-0.967,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/17]; NEURAL_HAM_LONG(-0.96)[-0.956,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[uoguelph.ca]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com]; NEURAL_HAM_SHORT(-0.59)[-0.594,0]; RCVD_IN_DNSWL_NONE(0.00)[64.66.107.40.list.dnswl.org : 127.0.3.0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Nov 2018 15:25:25 -0000 Kirk McKusick wrote: >> To: soralx@cydem.org >> Subject: Re: [bug] fsck refuses to repair damaged UFS using backup super= block >> From: "Julian H. Stacey" >> Organization: http://berklix.eu BSD Unix Linux Consultants, Munich Germa= ny >> Date: Fri, 23 Nov 2018 02:17:20 +0100 >> >> Hi soralx@cydem.org, >> Added cc: to ensure file system specialists see= this. >> >> Reference: >>> From: >>> Date: Tue, 20 Nov 2018 05:30:00 -0800 >> >> soralx@cydem.org wrote: >>> >>> Howdy! >>> >>> Since send-pr(1) is now gone, I guess the next option is to send a >>> message directly to the developers... >>> >>> Yesterday, I ran into a bug in fsck_ffs that gave me a little scare. >>> >>> Short story: on -CURRENT, fsck refuses to check a FS with a corrupted >>> superblock, even when an alternate (backup) SB location is given. >>> >>> Long story. I've been testing a newly-built system based on an X399 >>> platform with a 2950X CPU and an Optane 905P 480GB U.2 drive. The >>> system ran a ~2-day old -CURRENT; when compiling newest world and >>> kernel, I found the machine in a locked-up state. After a hard reset, >>> boot failed because the root FS became corrupted & was not available: >>> kernel: Superblock check-hash failed: recorded check-hash XXX !=3D c= omputed >check-hash YYY >>> >>> I have not yet figured out why the corruption happened... bad hardware= ? >>> bug in the NVMe driver? >>> All I did was boot a pre-r339671 kernel that used the file systems and then= , bingo... >>> "OK", I thought, "No worries. We'll just boot using another disk, fsck >>> the corrupted FS with a backup superblock, and be up in a moment". >>> The machine was doing nothing but compiling, so no valuable data loss. >>> >>> So I did `dumpfs -m /dev/ada0p3` on the spare disk (which was the >>> source for the new disk image, thus had almost identical partitions >>> and filesystems) to get the FS details, then did `newfs -N [...] >>> /dev/ada0p3` to find locations of superblock backups, then finally >>> ran `fsck_ffs -b 192 /dev/nvd0p3` -- only to get the same "check- >>> -hash failed" message, plus another strange message: "Can't open >>> /dev/nvd0p3: [...]". Then fsck quits. >>> Note that `fsck_ffs -b ...` on a FS with good superblock works OK. >>> >>> After fiddling with a debugger for a bit, I commented out the line >>> "return (0);" in /usr/src/sbin/fsck_ffs/setup.c:136, recompiled fsck, >>> and the FS was recovered successfully. >>> >>> What was actually happening: fsck's setup.c calls ufs_disk_fillout() >>> from libufs' type.c, which in turn calls sbread() from the same >>> library, which then calls sbget(disk->d_fd, &fs, -1) [[where '-1' >>> is hard-coded to indicate the primary superblock]] that then simply >>> invokes ffs_sbget from ffs kernel driver -- and this returns ENOENT, >>> which eventually causes fsck to give up before even looking at the >>> specified backup superblock. >>> >>> I don't know what exactly ufs_disk_fillout() does, but fortunately >>> for me, fsck worked without the "sbread(disk)" part of that function >>> having much luck on a disk with corrupted superblock. Also, I have a >>> feeling that calling a kernel's ffs driver function when using fsck >>> to fix a broken filesystem is not the best thing to do... >>> >>> Please CC, as I am not subscribed. >>> >>> -- >>> [SorAlx] ridin' VN2000 Classic LT >> >> Cheers, >> Julian > >Below is a proposed fix for fsck_ffs to properly handle superblock >check-hash failures (notably to optionally search for a usable >alternate superblock). Let me know if you still have a filesystem >on which you can test it, and if so whether it works correctly. As above, I think you can reproduce this by running an older kernel that mounts the file system. I ended up re-installing when I ran into this yeste= rday (no biggy, it was just a test machine). It happened after I had been runnin= g a kernel built from stable/12 on the system and then tried to boot it. (Since the root fs got these errors, I couldn't boot any kernel on the root= fs.) It would be nice if there was a way to override the check and boot the syst= em. (Is a loader tunable reasonable for this?) rick From owner-freebsd-fs@freebsd.org Sun Nov 25 18:34:45 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C82C3113CF28 for ; Sun, 25 Nov 2018 18:34:45 +0000 (UTC) (envelope-from mckusick@mckusick.com) Received: from chez.mckusick.com (chez.mckusick.com [70.36.157.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8202F71986 for ; Sun, 25 Nov 2018 18:34:44 +0000 (UTC) (envelope-from mckusick@mckusick.com) Received: from chez.mckusick.com (localhost [IPv6:::1]) by chez.mckusick.com (8.15.2/8.15.2) with ESMTP id wAPIgEpW053136; Sun, 25 Nov 2018 10:42:14 -0800 (PST) (envelope-from mckusick@mckusick.com) Message-Id: <201811251842.wAPIgEpW053136@chez.mckusick.com> From: Kirk McKusick To: Rick Macklem Subject: Re: [bug] fsck refuses to repair damaged UFS using backup superblock cc: "soralx@cydem.org" , "freebsd-fs@freebsd.org" , "Julian H. Stacey" , Konstantin Belousov X-URL: http://WWW.McKusick.COM/ Reply-To: Kirk McKusick In-reply-to: Comments: In-reply-to Rick Macklem message dated "Sun, 25 Nov 2018 15:25:21 +0000." MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <53134.1543171334.1@chez.mckusick.com> Content-Transfer-Encoding: quoted-printable Date: Sun, 25 Nov 2018 10:42:14 -0800 X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,MISSING_MID, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on chez.mckusick.com X-Rspamd-Queue-Id: 8202F71986 X-Spamd-Result: default: False [-0.26 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; HAS_REPLYTO(0.00)[mckusick@mckusick.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; NEURAL_HAM_LONG(-0.18)[-0.183,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[mckusick.com]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: chez.mckusick.com]; NEURAL_HAM_SHORT(-0.90)[-0.902,0]; RCVD_IN_DNSWL_NONE(0.00)[235.157.36.70.list.dnswl.org : 127.0.10.0]; NEURAL_HAM_MEDIUM(-0.05)[-0.047,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:46375, ipnet:70.36.128.0/19, country:US]; RCVD_COUNT_TWO(0.00)[2]; IP_SCORE(-0.02)[country: US(-0.09)] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Nov 2018 18:34:46 -0000 > From: Rick Macklem > To: "soralx@cydem.org" , > Kirk McKusick > CC: "freebsd-fs@freebsd.org" , > "Julian H. Stacey" > > Subject: Re: [bug] fsck refuses to repair damaged UFS using backup super= block > Date: Sun, 25 Nov 2018 15:25:21 +0000 > = >> Kirk McKusick wrote: >> = >> Below is a proposed fix for fsck_ffs to properly handle superblock >> check-hash failures (notably to optionally search for a usable >> alternate superblock). Let me know if you still have a filesystem >> on which you can test it, and if so whether it works correctly. > = > As above, I think you can reproduce this by running an older kernel > that mounts the file system. I ended up re-installing when I ran > into this yesterday (no biggy, it was just a test machine). It > happened after I had been running a kernel built from stable/12 on > the system and then tried to boot it. (Since the root fs got these > errors, I couldn't boot any kernel on the root fs.) Kernels before -r339671 clear the CK_SUPERBLOCK flag in the superblock. = Kernels at and after -r339671 ignore the check-hash if the CK_SUPERBLOCK flag is clear. So you should be able to run on older kernels without causing superblock check-hash failures on later kernels. Fsck will offer to enable the superblock check-hash if you are running on a kernel at or newer than -r339671. > It would be nice if there was a way to override the check and boot > the system. (Is a loader tunable reasonable for this?) > = > rick I have fixed the problem with fsck being unable to check filesystems with check-hash failures in -r340925. Rather than adding a loader tunable to override the check (which people would have to track down in the midst of a crisis), it might be better to simply have the loader print a warning when there is a mismatch and proceed to try using the filesystem. If successful, an fsck could then be run to try and clean it up. Does this seem reasonable? Kirk McKusick From owner-freebsd-fs@freebsd.org Sun Nov 25 19:01:59 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F39A4113E288 for ; Sun, 25 Nov 2018 19:01:58 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it1-x12b.google.com (mail-it1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DAEC572D19 for ; Sun, 25 Nov 2018 19:01:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it1-x12b.google.com with SMTP id x19so25042114itl.1 for ; Sun, 25 Nov 2018 11:01:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Kt3yPejAAvtxSkJTdwam9o1UxfgHUqac6OhEg/4KPrk=; b=F5Jbmy8EnuSxDd7Np/JRpKVEa2MaWlcVBW8BE1gRzCG2qplBcgy/c+WF2oUpm5Jvrp I0h6cPoTtxnuHKIqYmyk4QurvpEY9ce1Ey6sXlUqCEShO9zzK+r5okMPHUn8ybsNhqw2 4Su6r9du/3lZlHV/OfKOtPIFum3ila9Q7kZC2Lk91YdOqtaKR9rrJWjLrK0tN/wJS+xG VTvNoY5fukiO5sVNHJMrHUR8uW8QdG/1hB0pG7yLXlOko5ryZZ3SJdSVfFGs6lD/aG4i VcXeyDxs2Wc5eAT49AoGq2iNVpablG7kDU79B9BPdistSPrg4kdGdeV52OuQm27oelta sqPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Kt3yPejAAvtxSkJTdwam9o1UxfgHUqac6OhEg/4KPrk=; b=bhmt09YJRJ+wEMdkpV4ipT/zESunv2cEc8GUi1yhPyhLFohhsSU2S81Eez8Z9N6e// a99iWEVGg2zRtMf0tLdkTNi+ha2qcGXRXrz7X2DcTOJ3A1z1iP/UwcL+KSL1XVEHBARs dvz/NiYQ0stHxLo6ZcCEwajc7JpSjBHNkoPo3DbbhELyK0TnCc6FWnonrIoBbUHUO8Xk IbqYGAjJntsiR9LrxPzdCFZzOw5q08YDq58zJTIjELQpLG0MBMHjdwb3dE+SBpG6nA42 6+Qc9J+CXoWGhG1tyF7jSdEFqQHVhWqiaSOpzawoVg/sZQb85IRb7fVUxDexmLI3lE59 Hk4w== X-Gm-Message-State: AA+aEWb6ChLLwMUpsXgGqaX+9yRItaQkRLkuOmnZA6oS9YQ9TIMwhzBg 5H7Jn39Jf/8ou0BhSkMD1fvZIdJgUGJC9+kMcAccRQ== X-Google-Smtp-Source: AFSGD/UDEcvpYDZV5sdAo2XYINK0HWegibM6265ByxKk8ZXLIzrXrDMqHon1bXbvOQmBR04X2MdaBD4QX9AqZHVLP9c= X-Received: by 2002:a02:3da:: with SMTP id e87mr19587539jae.78.1543172516898; Sun, 25 Nov 2018 11:01:56 -0800 (PST) MIME-Version: 1.0 References: <201811251842.wAPIgEpW053136@chez.mckusick.com> In-Reply-To: <201811251842.wAPIgEpW053136@chez.mckusick.com> From: Warner Losh Date: Sun, 25 Nov 2018 12:01:45 -0700 Message-ID: Subject: Re: [bug] fsck refuses to repair damaged UFS using backup superblock To: Kirk McKusick Cc: Rick Macklem , FreeBSD FS , "Julian H. Stacey" , "soralx@cydem.org" X-Rspamd-Queue-Id: DAEC572D19 X-Spamd-Result: default: False [-4.50 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-fs@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[ALT1.aspmx.l.google.com,aspmx.l.google.com,ALT2.aspmx.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[b.2.1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.92)[-0.920,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-1.57)[ip: (-4.42), ipnet: 2607:f8b0::/32(-1.91), asn: 15169(-1.42), country: US(-0.09)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Nov 2018 19:01:59 -0000 On Sun, Nov 25, 2018, 11:35 AM Kirk McKusick > From: Rick Macklem > > To: "soralx@cydem.org" , > > Kirk McKusick > > CC: "freebsd-fs@freebsd.org" , > > "Julian H. Stacey" > > > > Subject: Re: [bug] fsck refuses to repair damaged UFS using backup > superblock > > Date: Sun, 25 Nov 2018 15:25:21 +0000 > > > >> Kirk McKusick wrote: > >> > >> Below is a proposed fix for fsck_ffs to properly handle superblock > >> check-hash failures (notably to optionally search for a usable > >> alternate superblock). Let me know if you still have a filesystem > >> on which you can test it, and if so whether it works correctly. > > > > As above, I think you can reproduce this by running an older kernel > > that mounts the file system. I ended up re-installing when I ran > > into this yesterday (no biggy, it was just a test machine). It > > happened after I had been running a kernel built from stable/12 on > > the system and then tried to boot it. (Since the root fs got these > > errors, I couldn't boot any kernel on the root fs.) > > Kernels before -r339671 clear the CK_SUPERBLOCK flag in the superblock. > Kernels at and after -r339671 ignore the check-hash if the CK_SUPERBLOCK > flag is clear. So you should be able to run on older kernels without > causing superblock check-hash failures on later kernels. Fsck will offer > to enable the superblock check-hash if you are running on a kernel at > or newer than -r339671. > > > It would be nice if there was a way to override the check and boot > > the system. (Is a loader tunable reasonable for this?) > > > > rick > > I have fixed the problem with fsck being unable to check filesystems > with check-hash failures in -r340925. > > Rather than adding a loader tunable to override the check (which people > would have to track down in the midst of a crisis), it might be better > to simply have the loader print a warning when there is a mismatch and > proceed to try using the filesystem. If successful, an fsck could then > be run to try and clean it up. Does this seem reasonable? > Yes. You have a big chicken and egg issue otherwise. And not booting seems like an extreme overreaction to a bad checksum. I can think of no use case where you'd want it. Let's let people ask for it with a decent use case before we do anything more than print a warning and soldier on... Warner Kirk McKusick > _______________________________________________ > freebsd-fs@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-fs > To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org" > From owner-freebsd-fs@freebsd.org Sun Nov 25 21:01:00 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8320F11423A4 for ; Sun, 25 Nov 2018 21:01:00 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 18C5676F0F for ; Sun, 25 Nov 2018 21:01:00 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id D03711142399; Sun, 25 Nov 2018 21:00:59 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 956DB114238F for ; Sun, 25 Nov 2018 21:00:59 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D355376F03 for ; Sun, 25 Nov 2018 21:00:58 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id D71F314810 for ; Sun, 25 Nov 2018 21:00:57 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wAPL0v0l002051 for ; Sun, 25 Nov 2018 21:00:57 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wAPL0vjX002041 for fs@FreeBSD.org; Sun, 25 Nov 2018 21:00:57 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <201811252100.wAPL0vjX002041@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: fs@FreeBSD.org Subject: Problem reports for fs@FreeBSD.org that need special attention Date: Sun, 25 Nov 2018 21:00:57 +0000 MIME-Version: 1.0 X-Rspamd-Queue-Id: 18C5676F0F X-Spamd-Result: default: False [2.23 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_SPAM_LONG(0.79)[0.792,0]; NEURAL_SPAM_MEDIUM(0.70)[0.698,0]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; NEURAL_SPAM_SHORT(0.74)[0.737,0] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Nov 2018 21:01:00 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- New | 203492 | mount_unionfs -o below causes panic New | 217062 | for file systems mounted with -o noexec, exec=off New | 221909 | [ZFS] Add a sysctl to toggle send_corrupt_data Open | 140068 | [smbfs] [patch] smbfs does not allow semicolon in Open | 144447 | [zfs] sharenfs fsunshare() & fsshare_main() non f Open | 211491 | System hangs after "Uptime" on reboot with ZFS 6 problems total for which you should take action. From owner-freebsd-fs@freebsd.org Sun Nov 25 23:45:09 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D701111471A8 for ; Sun, 25 Nov 2018 23:45:08 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670082.outbound.protection.outlook.com [40.107.67.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AEC347C8E1 for ; Sun, 25 Nov 2018 23:45:06 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM (52.132.50.155) by YTOPR0101MB1161.CANPRD01.PROD.OUTLOOK.COM (52.132.50.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1339.20; Sun, 25 Nov 2018 23:45:05 +0000 Received: from YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM ([fe80::9c71:6eb6:1bff:727b]) by YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM ([fe80::9c71:6eb6:1bff:727b%5]) with mapi id 15.20.1294.048; Sun, 25 Nov 2018 23:45:05 +0000 From: Rick Macklem To: Kirk McKusick CC: "soralx@cydem.org" , "freebsd-fs@freebsd.org" , "Julian H. Stacey" , Konstantin Belousov Subject: Re: [bug] fsck refuses to repair damaged UFS using backup superblock Thread-Topic: [bug] fsck refuses to repair damaged UFS using backup superblock Thread-Index: AQHUhJlTgUa5G9TQ8USwP5697EmSSKVgmAwVgAA76wCAAFAAeQ== Date: Sun, 25 Nov 2018 23:45:05 +0000 Message-ID: References: , <201811251842.wAPIgEpW053136@chez.mckusick.com> In-Reply-To: <201811251842.wAPIgEpW053136@chez.mckusick.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rmacklem@uoguelph.ca; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; YTOPR0101MB1161; 6:cEkfQgWcfsMkz3EcZ4gAQ0ZdVeqOWK8w4SKdWbkE/z7aRx039QqSDWdXgpJ4ZZ/0HAJ2dzfnP8keYt8PdRtimCk7WVUn2sG7krw9Wu+Wa6RgyIUcyblgt+13HhDxCiBKtF1c0wL0ysKmMSmU3nHAMFacwQctKnlrg3Nb093fgXO8LBOFwWDnD8hRbekXJoWUG1uZ50pBbzRrlfTT5o2IdVFQhfpxZ5Qak3zSUStJXAsF/N/AIcl8SAngZES4Ltuy4PY/FYJbU0s2H3ZgS90vkDLkwtKfr/mheTM6auT5jGXXbIZwu5e+Gmp9p4MUvORgxwKsFsdBhrmx411hElj7caIUk/n5L3iXwPIbEltiKv2NlaM+gQ3lEZXCLCKjmlrUweccAVANcpXwpQGKCW85mikXOA5yws+PWHao04EgXVukNbFmsDeROAkp+oP+nEFsgxNLKzxhr2OtPlqgeyn4RQ==; 5:k6LRq+s/9kzwNOgafmQRZX0R1/rxmDnm0gWVMp4529Ziih8MlMF7J/5ql3aYFjz78ozUYSvs4QwV+jCwZx5TqIIX80WdhlSpIZxx0Y44eWnZOEd0v9hpsHdev1CHWnt6SlQrjVcRH3+5ngcS6jrhuQ1k/29lwtDlZRk7GE5hAnQ=; 7:kD73mDHjeHeLtp+SLbKpHYBOBKu/86E3AZ3sNtxkYKGfYc8xhyJme0vAesYTaw9sNzA/QLp6TdZNTJq3RtMDOA3yH43mNq6UfY8g4dkqOeyslXicwV12ZvrbAJ0giLCSe3pLAjwVJbbDZFCcmDdUDg== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: dec99de5-e6ec-4815-48c3-08d653300677 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:YTOPR0101MB1161; x-ms-traffictypediagnostic: YTOPR0101MB1161: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(3231442)(944501410)(52105112)(3002001)(10201501046)(93006095)(93001095)(148016)(149066)(150057)(6041310)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:YTOPR0101MB1161; BCL:0; PCL:0; RULEID:; SRVR:YTOPR0101MB1161; x-forefront-prvs: 0867F4F1AA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(396003)(346002)(366004)(376002)(39860400002)(189003)(199004)(7696005)(9686003)(76176011)(446003)(476003)(33656002)(55016002)(11346002)(25786009)(8936002)(229853002)(8676002)(81166006)(305945005)(6436002)(81156014)(74316002)(316002)(786003)(486006)(54906003)(5660300001)(99286004)(105586002)(53936002)(6246003)(478600001)(68736007)(2906002)(186003)(46003)(86362001)(6506007)(39060400002)(4326008)(74482002)(6916009)(14454004)(106356001)(256004)(102836004)(71190400001)(14444005)(97736004)(71200400001); DIR:OUT; SFP:1101; SCL:1; SRVR:YTOPR0101MB1161; H:YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-microsoft-antispam-message-info: sEXOEzoHM326PLZeDvCtbXQffQfrxcbgZHMj+Ok61t2UUaLfVspXcAG+dcrILZzmKg/Q6WJNu3l1pIeM2qcG6M0EefV80jQkZEhKVvjymW/b/e2ZzTY2mUxQXyjTVXp1kJFXwqgZS6YPR516GpviCD3ZHNui8aJCJu+5p+YAxL9/YKHlfQzp5ejB90CHgeYFj876mZNSujrkFhg1uUtvC7PseytjAESsyRzl7jJyXriuLPXQnBlEm/imdZ6AjnCFtVyB4pYTAr923xVdiSjPP+Ol/IYG/O5ZPqDBlJmIHsdx4arPKSItNOBiV+Pe51THcxn7srmbW9RJC7GbstIma+l9J06e18BJRcduAgOkskw= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: dec99de5-e6ec-4815-48c3-08d653300677 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Nov 2018 23:45:05.0379 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTOPR0101MB1161 X-Rspamd-Queue-Id: AEC347C8E1 X-Spamd-Result: default: False [-4.08 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/17]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[uoguelph.ca]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: mx2.hc184-76.ca.iphmx.com]; NEURAL_HAM_SHORT(-0.94)[-0.943,0]; RCVD_IN_DNSWL_NONE(0.00)[82.67.107.40.list.dnswl.org : 127.0.3.0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; IP_SCORE(-0.83)[ipnet: 40.64.0.0/10(-2.12), asn: 8075(-1.92), country: US(-0.09)] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Nov 2018 23:45:09 -0000 Kirk McKusick wrote: >> From: Rick Macklem >> To: "soralx@cydem.org" , >> Kirk McKusick >> CC: "freebsd-fs@freebsd.org" , >> "Julian H. Stacey" >> >> Subject: Re: [bug] fsck refuses to repair damaged UFS using backup super= block >> Date: Sun, 25 Nov 2018 15:25:21 +0000 >> >>> Kirk McKusick wrote: >>> >>> Below is a proposed fix for fsck_ffs to properly handle superblock >>> check-hash failures (notably to optionally search for a usable >>> alternate superblock). Let me know if you still have a filesystem >>> on which you can test it, and if so whether it works correctly. >> >> As above, I think you can reproduce this by running an older kernel >> that mounts the file system. I ended up re-installing when I ran >> into this yesterday (no biggy, it was just a test machine). It >> happened after I had been running a kernel built from stable/12 on >> the system and then tried to boot it. (Since the root fs got these >> errors, I couldn't boot any kernel on the root fs.) > >Kernels before -r339671 clear the CK_SUPERBLOCK flag in the superblock. >Kernels at and after -r339671 ignore the check-hash if the CK_SUPERBLOCK >flag is clear. So you should be able to run on older kernels without >causing superblock check-hash failures on later kernels. Fsck will offer >to enable the superblock check-hash if you are running on a kernel at >or newer than -r339671. Not if the kernel is stable/11 (I realized that was what I booted that tras= hed the machine). For stable/11, fs_metackhash is just fs_sparecon32[22]. I'm guessing that fs_sparecon32[22] happened to hit memory with CK_SUPERBLOCK set in it when the superblock was written by the stable/11 ke= rnel. Then the file system had a bogus checksum when trying to boot it beca= use fs_ckhash was just random garbage written for fs_sparecon32[21]? Maybe setting all elements of fs_sparecon32[] to zeros before writing the superblock out would minimize these issues for the future and could be MFC'= d. (I'm not claiming that a new FFS2 should be movable between stable/11 and head, but it might be a nice feature?) >> It would be nice if there was a way to override the check and boot >> the system. (Is a loader tunable reasonable for this?) >> >> rick > >I have fixed the problem with fsck being unable to check filesystems >with check-hash failures in -r340925. > >Rather than adding a loader tunable to override the check (which people >would have to track down in the midst of a crisis), it might be better >to simply have the loader print a warning when there is a mismatch and >proceed to try using the filesystem. If successful, an fsck could then >be run to try and clean it up. Does this seem reasonable? Yes, that sounds fine to me. rick From owner-freebsd-fs@freebsd.org Mon Nov 26 00:07:39 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 81CFD1147B8A for ; Mon, 26 Nov 2018 00:07:39 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670057.outbound.protection.outlook.com [40.107.67.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 903217D0E7 for ; Mon, 26 Nov 2018 00:07:38 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM (52.132.50.155) by YTOPR0101MB1931.CANPRD01.PROD.OUTLOOK.COM (52.132.49.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.26; Mon, 26 Nov 2018 00:07:37 +0000 Received: from YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM ([fe80::9c71:6eb6:1bff:727b]) by YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM ([fe80::9c71:6eb6:1bff:727b%5]) with mapi id 15.20.1294.048; Mon, 26 Nov 2018 00:07:37 +0000 From: Rick Macklem To: Kirk McKusick CC: "soralx@cydem.org" , "freebsd-fs@freebsd.org" , "Julian H. Stacey" , Konstantin Belousov Subject: Re: [bug] fsck refuses to repair damaged UFS using backup superblock Thread-Topic: [bug] fsck refuses to repair damaged UFS using backup superblock Thread-Index: AQHUhJlTgUa5G9TQ8USwP5697EmSSKVgmAwVgAA76wCAAFAAeYAAB9ew Date: Mon, 26 Nov 2018 00:07:36 +0000 Message-ID: References: , <201811251842.wAPIgEpW053136@chez.mckusick.com>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rmacklem@uoguelph.ca; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; YTOPR0101MB1931; 6:gVxOJ3sgTbGOEd00cypJ/h4JKlmwWlW9sjSveuCrP6e+A/avt2VT6uA4hdlGH1q0akQPfeIjC/nHFEdc6iYv25TnElg27pPLaz1kMozZZoSau1Rb4rEM+8W0uSgT9M6obrkq7ws9dvy8vUFpifaNhrw+tYcMmhx2EsHVkTgLCwNUO70x8RcbmmbdCir5mwp9pp9ARi7fqxpICMNXd3nBA4KpId8e4w/28hL7NK+qXypizLtxWZBsw3lakQN9UNrrmyGbfrEcLD3Tdg2uSJQawV6vx8J/iLgpdcO5TbwSuwojnPWMfATeodfcbenFL9gQAUmTJ9wFr8YN+j3r81fqmbg5mY5GI/06i0YoN4hCyJ0R6IKqZ2pDCDL/CgY1ocb0Wv7xzo80FLKAl30x1+cxnRY/FmY2vA4tXBhTX86j/J+7ZjYLpVJGL/MO3HNuOQ/WXoKd+vSpfGBEUFdWHEUUgA==; 5:6y/PtJFIyr4dx/HIdIxzuWih+kamBLM2lYUvuZph1WdnwmW7Rlv+AdBmkt85Z7qw0A8fZ6fQlpnaMQgA5mYKx8cVBsePipf+oZnCs0A3pXw14SzvEuVsV80WOAUHngGFIUqRE3tokdqkH43WE4uJDnnFN1zinLn/HuJjHcRnrEw=; 7:d3kA4Lk+2IVQIQNF3J55Rq3ivM3pS2yQ/P4CAuMdfmS7AW4c2SytwjN+GWapOfP4/UqEs3rEQ+rIHGU5A3nfwlo9CuE07HMp299dkHc964ridpJGu1SslVVrjYoEyEhyLZJsdtrU88sKDblwBhKFng== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: daea9ecb-ec12-43a9-1407-08d653332c3e x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:YTOPR0101MB1931; x-ms-traffictypediagnostic: YTOPR0101MB1931: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(131327999870524); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(3002001)(3231442)(944501410)(52105112)(93006095)(93001095)(10201501046)(148016)(149066)(150057)(6041310)(20161123562045)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:YTOPR0101MB1931; BCL:0; PCL:0; RULEID:; SRVR:YTOPR0101MB1931; x-forefront-prvs: 086831DFB4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(39860400002)(136003)(346002)(396003)(189003)(199004)(86362001)(2906002)(97736004)(6506007)(2940100002)(476003)(229853002)(14454004)(486006)(11346002)(446003)(74482002)(71190400001)(71200400001)(33656002)(81166006)(6246003)(93156006)(186003)(105586002)(68736007)(53936002)(4326008)(46003)(256004)(6916009)(102836004)(316002)(8676002)(8936002)(54906003)(81156014)(9686003)(55016002)(99286004)(6436002)(106356001)(39060400002)(53546011)(74316002)(25786009)(7696005)(786003)(76176011)(478600001)(305945005)(5660300001)(586874002); DIR:OUT; SFP:1101; SCL:1; SRVR:YTOPR0101MB1931; H:YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-microsoft-antispam-message-info: Auy+KRjL6AffJy2o/Dh1M5IUmvZgvi6LYoVM1D0pnZ37XD65YV2nbFjH/i6BG142kiXmrUkWzBezYif9FryJCNqws0Yxl5QiV0dFgIUJchapY2DGRAo3aDiBLleo9GxQQIDF39e7yRoX/9gNbq/k2UVAdZfq+Wg1QCAmxaR0TpPLfJTy36znSiXI739Q1Xq7UTxKsHKU6ibht4EE8PRmtTpYPAw1HUC58ghJFCMbqWK5tz/5nuxjp/1i77vC3ik+RKruK+OHhD5UBCMTSmJ/zJ+0jvqfZ0T2kjaB0hXwMXoXQAF7i24AJno8oNRzsMNsXWhnn8Inb7SFZV/Lfg1/G020nWBr92tmNFSYapLJ5t8= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: daea9ecb-ec12-43a9-1407-08d653332c3e X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Nov 2018 00:07:36.9456 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTOPR0101MB1931 X-Rspamd-Queue-Id: 903217D0E7 X-Spamd-Result: default: False [-4.08 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/17]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[uoguelph.ca]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: mx2.hc184-76.ca.iphmx.com]; NEURAL_HAM_SHORT(-0.94)[-0.942,0]; RCVD_IN_DNSWL_NONE(0.00)[57.67.107.40.list.dnswl.org : 127.0.3.0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; IP_SCORE(-0.83)[ipnet: 40.64.0.0/10(-2.14), asn: 8075(-1.92), country: US(-0.09)] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2018 00:07:39 -0000 ________________________________________ From: Rick Macklem Sent: Sunday, November 25, 2018 6:45 PM To: Kirk McKusick Cc: soralx@cydem.org; freebsd-fs@freebsd.org; Julian H. Stacey; Konstantin = Belousov Subject: Re: [bug] fsck refuses to repair damaged UFS using backup superblo= ck Rick Macklem wrote: [stuff snipped] >Maybe setting all elements of fs_sparecon32[] to zeros before writing the >superblock out would minimize these issues for the future and could be MFC= 'd. >(I'm not claiming that a new FFS2 should be movable between stable/11 and > head, but it might be a nice feature?) Ok, it looks like the FS_METACKHASH flag was meant to handle the old->new kernel transition. However, if I am reading the code correctly, it needs to= be checked for sooner. Here's the code snippet: /* fetch the superblock and summary information */ 812 if ((error =3D ffs_sbget(devvp, &fs, -1, M_UFSMNT, ffs_use_bread= )) !=3D 0) 813 goto out; 814 fs->fs_fmod =3D 0; 815 /* if we ran on a kernel without metadata check hashes, disable = them */ 816 if ((fs->fs_flags & FS_METACKHASH) =3D=3D 0) 817 fs->fs_metackhash =3D 0; I think ffs_sbget() calls readsuper() which calls calc_sbhash(), so lines 8= 15-817 need to be near the top of readsuper(), I think? rick [more stuff snipped] From owner-freebsd-fs@freebsd.org Mon Nov 26 01:17:37 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A18D11149725 for ; Mon, 26 Nov 2018 01:17:37 +0000 (UTC) (envelope-from mckusick@mckusick.com) Received: from chez.mckusick.com (chez.mckusick.com [70.36.157.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 567A77FA0E for ; Mon, 26 Nov 2018 01:17:36 +0000 (UTC) (envelope-from mckusick@mckusick.com) Received: from chez.mckusick.com (localhost [IPv6:::1]) by chez.mckusick.com (8.15.2/8.15.2) with ESMTP id wAQ1P7uV059136; Sun, 25 Nov 2018 17:25:08 -0800 (PST) (envelope-from mckusick@mckusick.com) Message-Id: <201811260125.wAQ1P7uV059136@chez.mckusick.com> From: Kirk McKusick To: Rick Macklem Subject: Re: [bug] fsck refuses to repair damaged UFS using backup superblock cc: "soralx@cydem.org" , "freebsd-fs@freebsd.org" , "Julian H. Stacey" , Konstantin Belousov X-URL: http://WWW.McKusick.COM/ Reply-To: Kirk McKusick In-reply-to: Comments: In-reply-to Rick Macklem message dated "Mon, 26 Nov 2018 00:07:36 +0000." MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <59134.1543195507.1@chez.mckusick.com> Content-Transfer-Encoding: quoted-printable Date: Sun, 25 Nov 2018 17:25:07 -0800 X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,MISSING_MID, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on chez.mckusick.com X-Rspamd-Queue-Id: 567A77FA0E X-Spamd-Result: default: False [0.99 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; HAS_REPLYTO(0.00)[mckusick@mckusick.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; NEURAL_HAM_LONG(-0.18)[-0.185,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[mckusick.com]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.36)[0.356,0]; MX_GOOD(-0.01)[cached: chez.mckusick.com]; RCVD_IN_DNSWL_NONE(0.00)[235.157.36.70.list.dnswl.org : 127.0.10.0]; NEURAL_HAM_MEDIUM(-0.05)[-0.050,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:46375, ipnet:70.36.128.0/19, country:US]; RCVD_COUNT_TWO(0.00)[2]; IP_SCORE(-0.02)[country: US(-0.09)] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Nov 2018 01:17:37 -0000 > From: Rick Macklem > To: Kirk McKusick > CC: "soralx@cydem.org" , > "freebsd-fs@freebsd.org" > , > "Julian H. Stacey" , > Konstantin Belousov > Subject: Re: [bug] fsck refuses to repair damaged UFS using backup super= block > Thread-Topic: [bug] fsck refuses to repair damaged UFS using backup supe= rblock > Date: Mon, 26 Nov 2018 00:07:36 +0000 > = > Rick Macklem wrote: > [stuff snipped] > Ok, it looks like the FS_METACKHASH flag was meant to handle the > old->new kernel transition. However, if I am reading the code > correctly, it needs to be checked for sooner. Here's the code > snippet (from sys/ufs/fdfs/ffs_vfsops.c): > = > /* fetch the superblock and summary information */ > 812 if ((error =3D ffs_sbget(devvp, &fs, -1, M_UFSMNT, ffs_use_br= ead)) !=3D 0) > 813 goto out; > 814 fs->fs_fmod =3D 0; > 815 /* if we ran on a kernel without metadata check hashes, disab= le them */ > 816 if ((fs->fs_flags & FS_METACKHASH) =3D=3D 0) > 817 fs->fs_metackhash =3D 0; > = > I think ffs_sbget() calls readsuper() which calls calc_sbhash(), > so lines 815-817 need to be near the top of readsuper(), I think? > = > rick > [more stuff snipped] Quite right. I have moved the metadata check to just before the superblock check-hash is done (in sys/ufs/ffs/ffs_subr.c) as you suggested (see -r340927). I wanted to ensure that running a filesystem on an older kernel would be detected. I coopted the FS_INDEXDIRS bit (which the kernel has always cleared since UFS2 was first released) to be the FS_METACKHASH flag. Thus if that flag is cleared, none of the check-hashes can be trusted. But I failed to make that check early enough to protect the reading of the superblock. Now fixed. All kernels since the first check-hashes were added no longer clear the FS_METACKHASH flag, but do clear any of the specific hashes that they do not support so that it will continue to be safe to move filesystems between kernels as the check hashes are added. When fsck_ffs is run in manual (non-preen) mode, it checks for missing check-hashes supported by the currently running kernel and offers to add them. Kirk McKusick From owner-freebsd-fs@freebsd.org Tue Nov 27 04:00:59 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 13625113888C for ; Tue, 27 Nov 2018 04:00:59 +0000 (UTC) (envelope-from mi+thun@aldan.algebra.com) Received: from symbion.zaytman.com (symbion.zaytman.com [64.112.176.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "symbion", Issuer "Narawntapu" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 61BB7807BE for ; Tue, 27 Nov 2018 04:00:58 +0000 (UTC) (envelope-from mi+thun@aldan.algebra.com) Received: from narawntapu.narawntapu (pool-108-53-86-183.nwrknj.fios.verizon.net [108.53.86.183]) by symbion.zaytman.com (8.15.2/8.15.2) with ESMTPS id wAR3prgP024844 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 26 Nov 2018 22:51:53 -0500 (EST) (envelope-from mi+thun@aldan.algebra.com) X-Authentication-Warning: symbion.zaytman.com: Host pool-108-53-86-183.nwrknj.fios.verizon.net [108.53.86.183] claimed to be narawntapu.narawntapu Received: from aldan.narawntapu (aldan [192.168.1.10]) by narawntapu.narawntapu (8.15.2/8.15.2) with ESMTP id wAR3poED003632 for ; Mon, 26 Nov 2018 22:51:50 -0500 (EST) (envelope-from mi+thun@aldan.algebra.com) X-Authentication-Warning: narawntapu.narawntapu: Host aldan [192.168.1.10] claimed to be aldan.narawntapu To: freebsd-fs From: "Mikhail T." Subject: UFS hanging Message-ID: <7e937f87-57aa-1a10-671b-d9309ef885e6@aldan.algebra.com> Date: Mon, 26 Nov 2018 22:51:50 -0500 MIME-Version: 1.0 Content-Language: en-US X-DCC-dmv.com-Metrics: narawntapu 1095; Body=1 Fuz1=1 Fuz2=1 X-Spam-Status: No, score=-0.8 required=11.5 tests=ALL_TRUSTED,BAYES_00, HTML_MESSAGE, RATWR8_MESSID, TW_GD autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on narawntapu.narawntapu X-Rspamd-Queue-Id: 61BB7807BE X-Spamd-Result: default: False [0.52 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.03)[-0.035,0]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; IP_SCORE(-0.02)[country: US(-0.09)]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-fs@freebsd.org]; HAS_XAW(0.00)[]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-0.50)[-0.500,0]; RCVD_COUNT_THREE(0.00)[3]; DMARC_NA(0.00)[algebra.com]; TO_DN_ALL(0.00)[]; MX_GOOD(-0.01)[aldan.algebra.com]; NEURAL_SPAM_SHORT(0.19)[0.187,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:394548, ipnet:64.112.176.0/24, country:US]; TAGGED_FROM(0.00)[thun]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[183.86.53.108.zen.spamhaus.org : 127.0.0.10] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 04:00:59 -0000 Kicked off portupgrade yesterday, found it tonight hung at this point -- pressed Ctrl-T a few times... I guess, I'll have to reboot/fsck -- would anyone care to know anything else before I do that? Running on the 11.2-stable from August 24th, on amd64. Yours, -mi Installed packages to be REMOVED:         gdk-pixbuf2-2.36.11 Number of packages to be removed: 1 The operation will free 3 MiB. [1/1] Deinstalling gdk-pixbuf2-2.36.11... [1/1] Deleting files for gdk-pixbuf2-2.36.11: 100% load: 0.07  cmd: update-mime-databas 80981 [ufs] 70878.14r 0.23u 0.05s 0% 40564k load: 0.05  cmd: update-mime-databas 80981 [ufs] 70902.40r 0.23u 0.05s 0% 40564k load: 0.05  cmd: update-mime-databas 80981 [ufs] 70902.92r 0.23u 0.05s 0% 40564k load: 0.05  cmd: update-mime-databas 80981 [ufs] 70903.12r 0.23u 0.05s 0% 40564k load: 0.04  cmd: update-mime-databas 80981 [ufs] 70903.31r 0.23u 0.05s 0% 40564k From owner-freebsd-fs@freebsd.org Tue Nov 27 15:42:46 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 02A881150E96 for ; Tue, 27 Nov 2018 15:42:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 87484813A9 for ; Tue, 27 Nov 2018 15:42:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 459521150E92; Tue, 27 Nov 2018 15:42:45 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 33C631150E91 for ; Tue, 27 Nov 2018 15:42:45 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B81BA813A5 for ; Tue, 27 Nov 2018 15:42:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 084B1ADBA for ; Tue, 27 Nov 2018 15:42:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wARFghUa045217 for ; Tue, 27 Nov 2018 15:42:43 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wARFghYO045216 for fs@FreeBSD.org; Tue, 27 Nov 2018 15:42:43 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 233560] fsck_ffs(8): pfatal doesn't prevent marking filesystem clean Date: Tue, 27 Nov 2018 15:42:43 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Rspamd-Queue-Id: 87484813A9 X-Spamd-Result: default: False [1.59 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_SPAM_LONG(0.58)[0.580,0]; NEURAL_SPAM_MEDIUM(0.69)[0.692,0]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; NEURAL_SPAM_SHORT(0.32)[0.324,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 15:42:46 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233560 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@FreeBSD.org |fs@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Wed Nov 28 00:40:23 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C58621141674 for ; Wed, 28 Nov 2018 00:40:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 5E08976BE9 for ; Wed, 28 Nov 2018 00:40:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 213E01141671; Wed, 28 Nov 2018 00:40:22 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0F8721141670 for ; Wed, 28 Nov 2018 00:40:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9FCFF76BE6 for ; Wed, 28 Nov 2018 00:40:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id DBBACF8C0 for ; Wed, 28 Nov 2018 00:40:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wAS0eK2A046309 for ; Wed, 28 Nov 2018 00:40:20 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wAS0eKLN046308 for fs@FreeBSD.org; Wed, 28 Nov 2018 00:40:20 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 233560] fsck_ffs(8): pfatal doesn't prevent marking filesystem clean Date: Wed, 28 Nov 2018 00:40:20 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: mckusick@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Rspamd-Queue-Id: 5E08976BE9 X-Spamd-Result: default: False [1.72 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_SPAM_LONG(0.58)[0.580,0]; NEURAL_SPAM_MEDIUM(0.67)[0.669,0]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; NEURAL_SPAM_SHORT(0.47)[0.466,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 00:40:23 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233560 Kirk McKusick changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mckusick@FreeBSD.org --- Comment #1 from Kirk McKusick --- The pfatal call perhaps should be called preenfatal. It is only fatal when running in preen mode. In this example, fsck was not able to add "." and ".= ." to the broken directory, but the filesystem was not inconsistant, so was ma= rked clean. Or put another way, the filesystem is safe to use, so it is marked clean. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Wed Nov 28 01:18:44 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 642931142393 for ; Wed, 28 Nov 2018 01:18:44 +0000 (UTC) (envelope-from mckusick@mckusick.com) Received: from chez.mckusick.com (chez.mckusick.com [70.36.157.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 88D4177CB2 for ; Wed, 28 Nov 2018 01:18:42 +0000 (UTC) (envelope-from mckusick@mckusick.com) Received: from chez.mckusick.com (localhost [IPv6:::1]) by chez.mckusick.com (8.15.2/8.15.2) with ESMTP id wAS1PZAG034119; Tue, 27 Nov 2018 17:25:35 -0800 (PST) (envelope-from mckusick@mckusick.com) Message-Id: <201811280125.wAS1PZAG034119@chez.mckusick.com> From: Kirk McKusick To: Warner Losh Subject: Re: [bug] fsck refuses to repair damaged UFS using backup superblock cc: Rick Macklem , Konstantin Belousov , FreeBSD FS , "Julian H. Stacey" , "soralx@cydem.org" X-URL: http://WWW.McKusick.COM/ Reply-To: Kirk McKusick In-reply-to: Comments: In-reply-to Warner Losh message dated "Sun, 25 Nov 2018 12:01:45 -0700." MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <34117.1543368335.1@chez.mckusick.com> Content-Transfer-Encoding: quoted-printable Date: Tue, 27 Nov 2018 17:25:35 -0800 X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,MISSING_MID, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on chez.mckusick.com X-Rspamd-Queue-Id: 88D4177CB2 X-Spamd-Result: default: False [-0.39 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; HAS_REPLYTO(0.00)[mckusick@mckusick.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; NEURAL_HAM_LONG(-0.47)[-0.466,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[mckusick.com]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[chez.mckusick.com]; NEURAL_HAM_SHORT(-0.26)[-0.258,0]; RCVD_IN_DNSWL_NONE(0.00)[235.157.36.70.list.dnswl.org : 127.0.10.0]; NEURAL_HAM_MEDIUM(-0.54)[-0.537,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:46375, ipnet:70.36.128.0/19, country:US]; RCVD_COUNT_TWO(0.00)[2]; IP_SCORE(-0.02)[country: US(-0.09)] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 01:18:44 -0000 > From: Warner Losh > Date: Sun, 25 Nov 2018 12:01:45 -0700 > Subject: Re: [bug] fsck refuses to repair damaged UFS using backup super= block > To: Kirk McKusick > Cc: Rick Macklem , FreeBSD FS , > "Julian H. Stacey" , > "soralx@cydem.org" > = > On Sun, Nov 25, 2018, 11:35 AM Kirk McKusick = >>> From: Rick Macklem >>> To: "soralx@cydem.org" , >>> Kirk McKusick >>> CC: "freebsd-fs@freebsd.org" , >>> "Julian H. Stacey" >>> >>> Subject: Re: [bug] fsck refuses to repair damaged UFS using backup >> superblock >>> Date: Sun, 25 Nov 2018 15:25:21 +0000 >>> >>> It would be nice if there was a way to override the check and boot >>> the system. (Is a loader tunable reasonable for this?) >>> >>> rick >> >> Rather than adding a loader tunable to override the check (which people >> would have to track down in the midst of a crisis), it might be better >> to simply have the loader print a warning when there is a mismatch and >> proceed to try using the filesystem. If successful, an fsck could then >> be run to try and clean it up. Does this seem reasonable? >> >> Kirk McKusick > = > Yes. You have a big chicken and egg issue otherwise. And not booting > seems like an extreme overreaction to a bad checksum. I can think > of no use case where you'd want it. Let's let people ask for it > with a decent use case before we do anything more than print a > warning and soldier on... > = > Warner My proposal is that when a filesystem is being mounted read-only that superblock check-hash failures should be warnings only. This is true not just at boot time, but always. We should probably set the FS_NEEDSFSCK flag so that if it is updated to read-write a warning will get printed. Since booting always starts up with the filesystem in read-only mode, this should solve the booting problem. Does this seem like a sensible solution? Kirk McKusick From owner-freebsd-fs@freebsd.org Wed Nov 28 01:31:32 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7BFA111428D1 for ; Wed, 28 Nov 2018 01:31:32 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670074.outbound.protection.outlook.com [40.107.67.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6CD48782F0 for ; Wed, 28 Nov 2018 01:31:31 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM (52.132.50.155) by YTOPR0101MB1084.CANPRD01.PROD.OUTLOOK.COM (52.132.50.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1361.20; Wed, 28 Nov 2018 01:31:29 +0000 Received: from YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM ([fe80::9c71:6eb6:1bff:727b]) by YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM ([fe80::9c71:6eb6:1bff:727b%5]) with mapi id 15.20.1294.048; Wed, 28 Nov 2018 01:31:23 +0000 From: Rick Macklem To: Warner Losh , Kirk McKusick CC: Konstantin Belousov , FreeBSD FS , "Julian H. Stacey" , "soralx@cydem.org" Subject: Re: [bug] fsck refuses to repair damaged UFS using backup superblock Thread-Topic: [bug] fsck refuses to repair damaged UFS using backup superblock Thread-Index: AQHUhJlTgUa5G9TQ8USwP5697EmSSKVgmAwVgAA76wCAAAV0gIADj+iA////dAE= Date: Wed, 28 Nov 2018 01:31:23 +0000 Message-ID: References: , <201811280125.wAS1PZAG034119@chez.mckusick.com> In-Reply-To: <201811280125.wAS1PZAG034119@chez.mckusick.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rmacklem@uoguelph.ca; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; YTOPR0101MB1084; 6:4QIv5fKmO4rvDmWTJEpR7q79X/UgOXHTlrjA9YN/J51LdADxAvQxE67yxRFbD4KFtJj7auPnthYrrNiIi4wMU1f0BTmCRP8tKi1VrwkqgUFsayjKaMhMLTXkYun7GoP8PbC7FKCO2wnvDmvflxogOkZZnebkKCkzlYrYYz/R7gEyZXS3TvoJCfAV1TUEuFQC7PN3UAI0efBLGucUe/5q0M7yUU09hLB6D8Z2hBNMWQwyqxqbTusUbTPMRfxP06bWztkUFZ79eVHS4BNiUonPgcqAHeL6GEfcsfeDY58VnyC5uhRi6IC/ogdTBjcYgsbFmY0T9yBKq73silx2hn1vnqSqpQUbqjZy2b1vx7mHjOWfSsFnoyqbU9zGkzCs0teFNYPQCWg0pnyNRVE0Zg2Yxtyodk10378+3gkS7eMe1wxQyvG9KxjmZEGBIZY5SxacjtmTAd2pUT1o/xKLood21g==; 5:Bbe7hFE86RWSXFYfqrzgxFXvVCms9MTXL18HKeYHXzDmlguFwJvwT3L5LuczmfzaeRZafN8yVWozSQvWSgSgTi+ys4KeioMib5dgWOfbHs7t+jeEerba+QO1MJrAr3Fzn68eY+uZPpphe/ILSfvmuWCQRwA9F73VHWCeTUxgn0k=; 7:cSsZ/p+fhT6RM9qNHKHe5kxETa8DW5rDb5QAE8ZrxRBztpHRdx5DUyXMSpPcGkZGKd5I/0ziDfZglNOFZAuWEgGEExgGUDddaex3NoCPumpqBFpUKfB+1izVdIdULhRKcB70FE/4CUSEvh2N2jEnaQ== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 8302e5c8-1542-4c32-e554-08d654d1350c x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:YTOPR0101MB1084; x-ms-traffictypediagnostic: YTOPR0101MB1084: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(10201501046)(3231443)(944501410)(52105112)(3002001)(93006095)(93001095)(148016)(149066)(150057)(6041310)(20161123560045)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:YTOPR0101MB1084; BCL:0; PCL:0; RULEID:; SRVR:YTOPR0101MB1084; x-forefront-prvs: 0870212862 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(376002)(346002)(366004)(136003)(199004)(189003)(6246003)(76176011)(476003)(74482002)(186003)(11346002)(53936002)(4326008)(446003)(9686003)(86362001)(25786009)(8936002)(55016002)(8676002)(7696005)(6506007)(81166006)(81156014)(54906003)(110136005)(53546011)(102836004)(46003)(39060400002)(316002)(486006)(5660300001)(786003)(14454004)(74316002)(229853002)(305945005)(2906002)(99286004)(14444005)(256004)(478600001)(68736007)(71200400001)(33656002)(71190400001)(561944003)(106356001)(105586002)(97736004)(6436002); DIR:OUT; SFP:1101; SCL:1; SRVR:YTOPR0101MB1084; H:YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-microsoft-antispam-message-info: q7rUKud7ruiI1x8x2OLC7L9r/sgsh+SBAnjDmau+6WXplyRjkhG9WFDXcbaGdmaQY6ceNkmiKW58BZyx1GXY6/dysncPx1DlB+GnvAT0JBg9H/H3kR9Ce8GsfFkT1Tszrw+BSsQtcumhpLxzVRf7wMzvHmyHDXrApTl8vZYrE/JBdfuaGwLquuEp2dZZu/edKUlHe0NJHUZMd97c+puIkYs6W56wo50Zv8x6wXNnY6BYtvR1kQnmYeYgrBwqK8zSpD5xnVf+yPtg4imkYDfZf0NW4XGkWm7h0ZIg7Um1qykpmSNUUg0mnRQfz6MTZPaVue9g0lXT/jCXIl6lS6hltiiCioJ00vTvCodA1Wgp0WE= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 8302e5c8-1542-4c32-e554-08d654d1350c X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2018 01:31:23.2938 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTOPR0101MB1084 X-Rspamd-Queue-Id: 6CD48782F0 X-Spamd-Result: default: False [-2.28 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-0.93)[-0.929,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/17]; NEURAL_HAM_LONG(-0.96)[-0.963,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[uoguelph.ca]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com,mx2.hc184-76.ca.iphmx.com,mx1.hc184-76.ca.iphmx.com]; NEURAL_HAM_SHORT(-0.08)[-0.078,0]; RCVD_IN_DNSWL_NONE(0.00)[74.67.107.40.list.dnswl.org : 127.0.3.0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_CC(0.00)[gmail.com] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 01:31:32 -0000 Kirk McKusick wrote: >> From: Warner Losh >> Date: Sun, 25 Nov 2018 12:01:45 -0700 >> Subject: Re: [bug] fsck refuses to repair damaged UFS using backup super= block >> To: Kirk McKusick >> Cc: Rick Macklem , FreeBSD FS , >> "Julian H. Stacey" , >> "soralx@cydem.org" >> >> On Sun, Nov 25, 2018, 11:35 AM Kirk McKusick > >>>> From: Rick Macklem >>>> To: "soralx@cydem.org" , >>>> Kirk McKusick >>>> CC: "freebsd-fs@freebsd.org" , >>>> "Julian H. Stacey" >>>> >>>> Subject: Re: [bug] fsck refuses to repair damaged UFS using backup >>> superblock >>>> Date: Sun, 25 Nov 2018 15:25:21 +0000 >>>> >>>> It would be nice if there was a way to override the check and boot >>>> the system. (Is a loader tunable reasonable for this?) >>>> >>>> rick >>> >>> Rather than adding a loader tunable to override the check (which people >>> would have to track down in the midst of a crisis), it might be better >>> to simply have the loader print a warning when there is a mismatch and >>> proceed to try using the filesystem. If successful, an fsck could then >>> be run to try and clean it up. Does this seem reasonable? >>> >>> Kirk McKusick >> >> Yes. You have a big chicken and egg issue otherwise. And not booting >> seems like an extreme overreaction to a bad checksum. I can think >> of no use case where you'd want it. Let's let people ask for it >> with a decent use case before we do anything more than print a >> warning and soldier on... >> >> Warner > >My proposal is that when a filesystem is being mounted read-only >that superblock check-hash failures should be warnings only. This >is true not just at boot time, but always. We should probably set >the FS_NEEDSFSCK flag so that if it is updated to read-write a >warning will get printed. Since booting always starts up with >the filesystem in read-only mode, this should solve the booting >problem. Does this seem like a sensible solution? Is there a concern that a read-only mount of a corrupted non-root fs could = cause the system to panic/crash? For booting, I think Warner is correct to suggest "print a warning and sold= ier on..". However, once the system has booted (maybe only single user), I'd think it = would be better to fail the mount at least until an fsck is done on it than allow= it to be mounted read-only, unless there is no risk that doing this mount could caus= e a crash/panic. Obviously, just my opinion given that I don't know UFS. rick From owner-freebsd-fs@freebsd.org Wed Nov 28 05:11:49 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3E590114796A for ; Wed, 28 Nov 2018 05:11:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id CAE9C7F086 for ; Wed, 28 Nov 2018 05:11:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 8E1971147967; Wed, 28 Nov 2018 05:11:48 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7B2F01147966 for ; Wed, 28 Nov 2018 05:11:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 141D87F07F for ; Wed, 28 Nov 2018 05:11:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 46D9111F42 for ; Wed, 28 Nov 2018 05:11:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wAS5Bllt086731 for ; Wed, 28 Nov 2018 05:11:47 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wAS5BlqZ086721 for fs@FreeBSD.org; Wed, 28 Nov 2018 05:11:47 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 233415] 12.0-RC1 - sysutils/fusefs-exfat broken on 12.x Date: Wed, 28 Nov 2018 05:11:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-STABLE X-Bugzilla-Keywords: regression X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: keywords assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Rspamd-Queue-Id: CAE9C7F086 X-Spamd-Result: default: False [1.85 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_SPAM_LONG(0.58)[0.580,0]; NEURAL_SPAM_MEDIUM(0.67)[0.669,0]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; NEURAL_SPAM_SHORT(0.60)[0.598,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 05:11:49 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233415 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression Assignee|bugs@FreeBSD.org |fs@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Wed Nov 28 06:46:07 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 452771149B53 for ; Wed, 28 Nov 2018 06:46:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id D237B82BBF for ; Wed, 28 Nov 2018 06:46:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 95B6A1149B52; Wed, 28 Nov 2018 06:46:06 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 842251149B50 for ; Wed, 28 Nov 2018 06:46:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2400082BBE for ; Wed, 28 Nov 2018 06:46:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 5FF5612C27 for ; Wed, 28 Nov 2018 06:46:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wAS6k5Zn064477 for ; Wed, 28 Nov 2018 06:46:05 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wAS6k5ia064476 for fs@FreeBSD.org; Wed, 28 Nov 2018 06:46:05 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 226499] Partial system freeze via ZFS rename and possible other operations Date: Wed, 28 Nov 2018 06:46:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: mlavkin@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Rspamd-Queue-Id: D237B82BBF X-Spamd-Result: default: False [1.73 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_SPAM_LONG(0.58)[0.580,0]; NEURAL_SPAM_MEDIUM(0.67)[0.669,0]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; NEURAL_SPAM_SHORT(0.48)[0.484,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 06:46:07 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226499 mlavkin@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mlavkin@gmail.com --- Comment #7 from mlavkin@gmail.com --- I have same issue on 11.0R and 11.2R-p4 :( --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Wed Nov 28 06:49:35 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4CCBF1149C9C for ; Wed, 28 Nov 2018 06:49:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id D53D982D23 for ; Wed, 28 Nov 2018 06:49:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 9591E1149C9A; Wed, 28 Nov 2018 06:49:34 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 83E641149C99 for ; Wed, 28 Nov 2018 06:49:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 20FE882D21 for ; Wed, 28 Nov 2018 06:49:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 55BE612C2B for ; Wed, 28 Nov 2018 06:49:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wAS6nXnM068857 for ; Wed, 28 Nov 2018 06:49:33 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wAS6nXAg068856 for fs@FreeBSD.org; Wed, 28 Nov 2018 06:49:33 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 226499] Partial system freeze via ZFS rename and possible other operations Date: Wed, 28 Nov 2018 06:49:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 11.1-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: mlavkin@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Rspamd-Queue-Id: D53D982D23 X-Spamd-Result: default: False [1.73 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_SPAM_LONG(0.58)[0.580,0]; NEURAL_SPAM_MEDIUM(0.67)[0.669,0]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; NEURAL_SPAM_SHORT(0.48)[0.484,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 06:49:35 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226499 --- Comment #8 from mlavkin@gmail.com --- But in my case it's snapshot rename. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Wed Nov 28 07:52:31 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4A84C114B463 for ; Wed, 28 Nov 2018 07:52:31 +0000 (UTC) (envelope-from mckusick@mckusick.com) Received: from chez.mckusick.com (chez.mckusick.com [70.36.157.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4B04C85C92 for ; Wed, 28 Nov 2018 07:52:30 +0000 (UTC) (envelope-from mckusick@mckusick.com) Received: from chez.mckusick.com (localhost [IPv6:::1]) by chez.mckusick.com (8.15.2/8.15.2) with ESMTP id wAS7xabP040527; Tue, 27 Nov 2018 23:59:36 -0800 (PST) (envelope-from mckusick@mckusick.com) Message-Id: <201811280759.wAS7xabP040527@chez.mckusick.com> From: Kirk McKusick To: Rick Macklem Subject: Re: [bug] fsck refuses to repair damaged UFS using backup superblock cc: Warner Losh , Konstantin Belousov , FreeBSD FS , "Julian H. Stacey" , "soralx@cydem.org" X-URL: http://WWW.McKusick.COM/ Reply-To: Kirk McKusick In-reply-to: Comments: In-reply-to Rick Macklem message dated "Wed, 28 Nov 2018 01:31:23 +0000." MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <40525.1543391976.1@chez.mckusick.com> Content-Transfer-Encoding: quoted-printable Date: Tue, 27 Nov 2018 23:59:36 -0800 X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,MISSING_MID, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on chez.mckusick.com X-Rspamd-Queue-Id: 4B04C85C92 X-Spamd-Result: default: False [0.43 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; HAS_REPLYTO(0.00)[mckusick@mckusick.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; NEURAL_HAM_LONG(-0.46)[-0.457,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[mckusick.com]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.54)[0.545,0]; MX_GOOD(-0.01)[cached: chez.mckusick.com]; RCVD_IN_DNSWL_NONE(0.00)[235.157.36.70.list.dnswl.org : 127.0.10.0]; NEURAL_HAM_MEDIUM(-0.53)[-0.527,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:46375, ipnet:70.36.128.0/19, country:US]; RCVD_COUNT_TWO(0.00)[2]; IP_SCORE(-0.02)[country: US(-0.09)] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 07:52:31 -0000 > From: Rick Macklem > To: Warner Losh , Kirk McKusick > CC: Konstantin Belousov , > FreeBSD FS , > "Julian H. Stacey" , > "soralx@cydem.org" > Subject: Re: [bug] fsck refuses to repair damaged UFS using backup super= block > Date: Wed, 28 Nov 2018 01:31:23 +0000 > = > Kirk McKusick wrote: >> >> My proposal is that when a filesystem is being mounted read-only >> that superblock check-hash failures should be warnings only. This >> is true not just at boot time, but always. We should probably set >> the FS_NEEDSFSCK flag so that if it is updated to read-write a >> warning will get printed. Since booting always starts up with >> the filesystem in read-only mode, this should solve the booting >> problem. Does this seem like a sensible solution? > = > Is there a concern that a read-only mount of a corrupted non-root > fs could cause the system to panic/crash? > = > For booting, I think Warner is correct to suggest "print a warning > and soldier on..". However, once the system has booted (maybe only > single user), I'd think it would be better to fail the mount at > least until an fsck is done on it than allow it to be mounted > read-only, unless there is no risk that doing this mount could cause > a crash/panic. Obviously, just my opinion given that I don't know UFS. > = > rick Since the initial boot does a read-only mount, my proposal will have the effect that the boot will "print a warning and soldier on..". The root filesystem has to be intact enough to be able to read the boot code and one or more kernel and configuration files from it. If it is able to get that far, it will most likely be able to read-only mount it and get /sbin/init and /bin/sh off it to get to a single-user prompt. By setting the FS_NEEDSFSCK flag on the filesystem, a full fsck will be run as part of trying to come up and will fail to single user if the fsck is not successful. Kirk McKusick From owner-freebsd-fs@freebsd.org Wed Nov 28 11:06:19 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 01D971150997 for ; Wed, 28 Nov 2018 11:06:19 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail105.syd.optusnet.com.au (mail105.syd.optusnet.com.au [211.29.132.249]) by mx1.freebsd.org (Postfix) with ESMTP id C2A836F824 for ; Wed, 28 Nov 2018 11:06:17 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from [192.168.0.102] (c110-21-101-228.carlnfd1.nsw.optusnet.com.au [110.21.101.228]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 879891052724; Wed, 28 Nov 2018 22:06:11 +1100 (AEDT) Date: Wed, 28 Nov 2018 22:06:10 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Kirk McKusick cc: Rick Macklem , FreeBSD FS , "Julian H. Stacey" , "soralx@cydem.org" Subject: Re: [bug] fsck refuses to repair damaged UFS using backup superblock In-Reply-To: <201811280759.wAS7xabP040527@chez.mckusick.com> Message-ID: <20181128212428.H2715@besplex.bde.org> References: <201811280759.wAS7xabP040527@chez.mckusick.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=FNpr/6gs c=1 sm=1 tr=0 a=PalzARQSbocsUSjMRkwAPg==:117 a=PalzARQSbocsUSjMRkwAPg==:17 a=kj9zAlcOel0A:10 a=hF2rLc1pAAAA:8 a=Ppy-XN2iSGaChNyNUXEA:9 a=CjuIK1q_8ugA:10 a=O9OM7dhJW_8Hj9EqqvKN:22 X-Rspamd-Queue-Id: C2A836F824 X-Spamd-Result: default: False [-1.73 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-0.99)[-0.987,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:211.29.132.0/23]; FREEMAIL_FROM(0.00)[optusnet.com.au]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[optusnet.com.au]; NEURAL_HAM_LONG(-0.98)[-0.982,0]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.55)[0.553,0]; MX_GOOD(-0.01)[cached: extmail.optusnet.com.au]; IP_SCORE(-0.01)[country: AU(-0.04)]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[optusnet.com.au]; ASN(0.00)[asn:4804, ipnet:211.28.0.0/14, country:AU]; RCVD_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_LOW(-0.10)[249.132.29.211.list.dnswl.org : 127.0.5.1] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 11:06:19 -0000 On Tue, 27 Nov 2018, Kirk McKusick wrote: >> From: Rick Macklem >> ... >> Is there a concern that a read-only mount of a corrupted non-root >> fs could cause the system to panic/crash? >> ... > Since the initial boot does a read-only mount, my proposal will have > the effect that the boot will "print a warning and soldier on..". > > The root filesystem has to be intact enough to be able to read the > boot code and one or more kernel and configuration files from it. > If it is able to get that far, it will most likely be able to > read-only mount it and get /sbin/init and /bin/sh off it to get to > a single-user prompt. > > By setting the FS_NEEDSFSCK flag on the filesystem, a full fsck > will be run as part of trying to come up and will fail to single > user if the fsck is not successful. Allowing read-only mounts of dirty file systems is only good for the root file system (and the file system containing fsck if this is different). It is fairly safe for the root file system since unless the initialization order is wrong, the worst that can happen is a panic that doesn't cause further damage since no file systems are mounted read-write and no networks have been brought up. It is not safe later since panics for the garbage in the dirty file system might damage file systems mounted read-write. If mounting does more sanity checks than just checking the dirty flag. ext2fs has capability flags which control mounting. Some capabilities require special support even for read-only mounts, so if the file system needs such capabilities but the kernel doesn't support them, then even read-only mounts are denied. Supporting read-only mounts of corrupted file systems is a capability that not many kernels have, so a capability flag for this would rarely be set, and you would need a force flag to force the read-only mount, and would use this for the root file system. FreeBSD already has a force flag to force read-write mounts. It is very easy to add the force flag next to the read-only flag in vfs_mountroot.c, and easy to change ffs to make the force flag control read-only mounts. Supporting read-only mounts of dirty file systems would require close to a full fsck on every mount, or better, runtime checks for all metadata every time it is used, and non-fatal error handling when the checks fail. Bruce From owner-freebsd-fs@freebsd.org Wed Nov 28 15:44:43 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 18D701157FAE for ; Wed, 28 Nov 2018 15:44:43 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660044.outbound.protection.outlook.com [40.107.66.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1EE6C799D6 for ; Wed, 28 Nov 2018 15:44:41 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM (52.132.50.155) by YTOPR0101MB1164.CANPRD01.PROD.OUTLOOK.COM (52.132.50.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1339.21; Wed, 28 Nov 2018 15:44:40 +0000 Received: from YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM ([fe80::9c71:6eb6:1bff:727b]) by YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM ([fe80::9c71:6eb6:1bff:727b%5]) with mapi id 15.20.1294.050; Wed, 28 Nov 2018 15:44:40 +0000 From: Rick Macklem To: Kirk McKusick CC: Warner Losh , Konstantin Belousov , FreeBSD FS , "Julian H. Stacey" , "soralx@cydem.org" Subject: Re: [bug] fsck refuses to repair damaged UFS using backup superblock Thread-Topic: [bug] fsck refuses to repair damaged UFS using backup superblock Thread-Index: AQHUhJlTgUa5G9TQ8USwP5697EmSSKVgmAwVgAA76wCAAAV0gIADj+iA////dAGAAG6iAIAAgAKN Date: Wed, 28 Nov 2018 15:44:40 +0000 Message-ID: References: , <201811280759.wAS7xabP040527@chez.mckusick.com> In-Reply-To: <201811280759.wAS7xabP040527@chez.mckusick.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rmacklem@uoguelph.ca; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; YTOPR0101MB1164; 6:DpSh8z3ypsp3lralEXofLJCwAs1e4eemqwlAhkmwKueVKta2YSma4zWzzobpP0vW+mg//dq3n9ge5F/JwHwvI8J0SEu3xza4lAb6t8WLLOMaFhYNpRkG11TFf3Ugy0A8qf2Zdl/5/LITl/kmLFMMYfy6IMIO81rtwWMp00OJBqeSIOFpXaRWk38TXK/A2cIqCuR6bCMuwUIayr0BBu6+bd7oj9lItW5lh9N8rat5bmg0rhnaeWaD4zNw6Rwx2w748l5GTc39AtOPEli9etv0Abghlut22RDEmktKf8Uzf5aSASfFf9thmLwH3PyztPimIO+XYlEQcaSYus2TI/gkcWVigifcHpMtrIfjIuhxDnUiKdemSUV2W2Me45rsz+ysu+wpWkWViSGed+M31n51C95BJBDEZlLHDV7y23vstTkGWbIOiY5hInvfsReuPtTDl4lQ9/SL5jQgis5KnzBxRA==; 5:RqWQnKLlZqO3H8OK4qT5mUeGBzthp5qUJpwYw+qdM7vsz/k9taUzirKt/6EdcPZrrl8UGCSLKFwsPZb/jgsr1UelUllJMl3WYSCsbDgxLivivX5m5sxMwYO/HSW4+3RdU0bzxcg9/qCSys5rHXAHAnWipC9AZVZziW6ZKE+lDpQ=; 7:kBZdPOg2qfnqizpxIqz1K3n7DZ6+iIE6xEzW+yvDVHCiOLHfmFJCh+jvSqBS2jFAkQAnRpW2G/cBdM5YweVKbMPFbO90LecO4rsLtMmNGzExTcIIUbaUMnY/Es21AvGRZQ1N4mukt8qzKfdTdDKRfA== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 442faf51-957a-42f4-8f39-08d6554868b1 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:YTOPR0101MB1164; x-ms-traffictypediagnostic: YTOPR0101MB1164: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(5005006)(8121501046)(3231443)(999002)(944501410)(52105112)(93006095)(93001095)(3002001)(10201501046)(148016)(149066)(150057)(6041310)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281529075)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:YTOPR0101MB1164; BCL:0; PCL:0; RULEID:; SRVR:YTOPR0101MB1164; x-forefront-prvs: 0870212862 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39860400002)(366004)(346002)(136003)(376002)(189003)(199004)(2906002)(99286004)(86362001)(71190400001)(71200400001)(14454004)(316002)(476003)(55016002)(6506007)(81166006)(9686003)(81156014)(486006)(305945005)(256004)(46003)(14444005)(229853002)(8676002)(478600001)(8936002)(68736007)(186003)(6916009)(106356001)(105586002)(25786009)(561944003)(33656002)(5660300001)(6436002)(6246003)(76176011)(53936002)(97736004)(786003)(74316002)(4326008)(102836004)(54906003)(7696005)(39060400002)(74482002)(446003)(11346002); DIR:OUT; SFP:1101; SCL:1; SRVR:YTOPR0101MB1164; H:YTOPR0101MB1162.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-microsoft-antispam-message-info: rVDqRhshi8d2WKBTBUz17FuwJWV0SqiVeKOkdhPnZyGCk9pVUxC80KbTIXHrMwyfZSZ5xChxgnh9ILFjO1zRGxy0SSgHPHMpTwoH29L6FpZ8H1WBLGh5HzF4fJqeLI0QTzwyGRHDqGvxrbybwqylBePZkkZNiPbYTEKSnmJyZDAY2fbxs/70Cmc236mJ8fV+mMki4UcmnWmpsUWZb3xpCnofAwP7UxAPIuDEvkak9oLXvq1Lpjwk0iqUBTFLL7tOnA9rWFmZwt+SXHQoYPfIPRaKYkoeo7WaTY9VGiKYJSfAm2SVlQBnj17FghPrJcLvbJEfFBfphcVzHEmt/W53S9j7Adpl2+Bi1qNgRr48QZ8= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 442faf51-957a-42f4-8f39-08d6554868b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2018 15:44:40.1196 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTOPR0101MB1164 X-Rspamd-Queue-Id: 1EE6C799D6 X-Spamd-Result: default: False [-2.13 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-0.93)[-0.926,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/17]; NEURAL_HAM_LONG(-0.96)[-0.961,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[uoguelph.ca]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.07)[0.065,0]; MX_GOOD(-0.01)[cached: mx2.hc184-76.ca.iphmx.com]; RCVD_IN_DNSWL_NONE(0.00)[44.66.107.40.list.dnswl.org : 127.0.3.0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 15:44:43 -0000 Kirk McKusick wrote: [stuff snipped] I wrote: >> >> For booting, I think Warner is correct to suggest "print a warning >> and soldier on..". However, once the system has booted (maybe only >> single user), I'd think it would be better to fail the mount at >> least until an fsck is done on it than allow it to be mounted >> read-only, unless there is no risk that doing this mount could cause >> a crash/panic. Oops, I realize I missed a key phrase in the above (run on) sentence. The key phrase was "for file systems other than root". I was basically trying to say what bde@ said. >> Obviously, just my opinion given that I don't know UFS. >> >> rick > >Since the initial boot does a read-only mount, my proposal will have >the effect that the boot will "print a warning and soldier on..". > >The root filesystem has to be intact enough to be able to read the >boot code and one or more kernel and configuration files from it. >If it is able to get that far, it will most likely be able to >read-only mount it and get /sbin/init and /bin/sh off it to get to >a single-user prompt. > >By setting the FS_NEEDSFSCK flag on the filesystem, a full fsck >will be run as part of trying to come up and will fail to single >user if the fsck is not successful. Yep. Certainly sounds reasonable to me for the root fs. I had intended the above to refer to other file systems than root. rick From owner-freebsd-fs@freebsd.org Wed Nov 28 16:08:42 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A96A41158962 for ; Wed, 28 Nov 2018 16:08:42 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail106.syd.optusnet.com.au (mail106.syd.optusnet.com.au [211.29.132.42]) by mx1.freebsd.org (Postfix) with ESMTP id B99467A6C9 for ; Wed, 28 Nov 2018 16:08:41 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from [192.168.0.102] (c110-21-101-228.carlnfd1.nsw.optusnet.com.au [110.21.101.228]) by mail106.syd.optusnet.com.au (Postfix) with ESMTPS id 469633D1A04; Thu, 29 Nov 2018 03:08:37 +1100 (AEDT) Date: Thu, 29 Nov 2018 03:08:36 +1100 (EST) From: Bruce Evans X-X-Sender: bde@besplex.bde.org To: Rick Macklem cc: Kirk McKusick , FreeBSD FS , "Julian H. Stacey" , "soralx@cydem.org" Subject: Re: [bug] fsck refuses to repair damaged UFS using backup superblock In-Reply-To: Message-ID: <20181129030116.W3915@besplex.bde.org> References: , <201811280759.wAS7xabP040527@chez.mckusick.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=DZtnkrlW c=1 sm=1 tr=0 a=PalzARQSbocsUSjMRkwAPg==:117 a=PalzARQSbocsUSjMRkwAPg==:17 a=kj9zAlcOel0A:10 a=fVE82GAriznxuU0VKa8A:9 a=CjuIK1q_8ugA:10 X-Rspamd-Queue-Id: B99467A6C9 X-Spamd-Result: default: False [-4.97 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:211.29.132.0/23]; FREEMAIL_FROM(0.00)[optusnet.com.au]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[optusnet.com.au]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: extmail.optusnet.com.au]; NEURAL_HAM_SHORT(-0.97)[-0.966,0]; IP_SCORE(-1.69)[ipnet: 211.28.0.0/14(-4.68), asn: 4804(-3.74), country: AU(-0.04)]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[optusnet.com.au]; ASN(0.00)[asn:4804, ipnet:211.28.0.0/14, country:AU]; RCVD_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_LOW(-0.10)[42.132.29.211.list.dnswl.org : 127.0.5.1] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 16:08:42 -0000 On Wed, 28 Nov 2018, Rick Macklem wrote: > Kirk McKusick wrote: > [stuff snipped] > I wrote: >>> >>> For booting, I think Warner is correct to suggest "print a warning >>> and soldier on..". However, once the system has booted (maybe only >>> single user), I'd think it would be better to fail the mount at >>> least until an fsck is done on it than allow it to be mounted >>> read-only, unless there is no risk that doing this mount could cause >>> a crash/panic. > Oops, I realize I missed a key phrase in the above (run on) sentence. > The key phrase was "for file systems other than root". > > I was basically trying to say what bde@ said. I noticed after replying that I repeated what you said in a paragraph that I didn't read closely and didn't quote. Bruce From owner-freebsd-fs@freebsd.org Thu Nov 29 16:25:19 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2771A1142CAD for ; Thu, 29 Nov 2018 16:25:19 +0000 (UTC) (envelope-from info@incomemail.online) Received: from mail.incomemail.online (incomemail.online [103.39.133.78]) by mx1.freebsd.org (Postfix) with ESMTP id CE7E073698 for ; Thu, 29 Nov 2018 16:25:15 +0000 (UTC) (envelope-from info@incomemail.online) Received: from ae2f4962822c94 ([182.75.24.156]) by incomemail.online with MailEnable ESMTP; Thu, 29 Nov 2018 18:04:24 +0530 From: To: Subject: 1st On Google Date: Thu, 29 Nov 2018 18:03:10 +0530 MIME-Version: 1.0 X-Mailer: Microsoft Office Outlook, Build 11.0.5510 Thread-Index: AdSH21+ucWTPXq6CQY+mPpPbJYnW3g== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Message-ID: <370A4ED780894A6B8511A9E7ABD7D2FB.MAI@incomemail.online> X-Rspamd-Queue-Id: CE7E073698 X-Spamd-Result: default: False [8.98 / 15.00]; TO_DN_NONE(0.00)[]; MX_GOOD(-0.01)[cached: mail.incomemail.online]; RCVD_NO_TLS_LAST(0.10)[]; RECEIVED_SPAMHAUS_PBL(0.00)[156.24.75.182.zen.spamhaus.org : 127.0.0.11]; R_DKIM_NA(0.00)[]; INTRODUCTION(2.00)[]; ASN(0.00)[asn:132779, ipnet:103.39.133.0/24, country:IN]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_XBL(3.00)[156.24.75.182.zen.spamhaus.org : 127.0.0.4]; IP_SCORE(0.00)[country: IN(0.02)]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(0.98)[0.985,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[incomemail.online]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(1.00)[1.000,0]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_SPAM_LONG(1.00)[1.000,0]; FROM_NO_DN(0.00)[]; R_SPF_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; GREYLIST(0.00)[pass,body] X-Rspamd-Server: mx1.freebsd.org X-Spam: Yes Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 16:25:19 -0000 Hi, Hope you are doing well. My name is Emma and I work for a Search Marketing company. I was doing some research on your industry and see your website. Thing is I had a look at some of the other businesses who are currently ranked on Page 1 and I truly believe you have a better website and a better brand and we can make better position on web for you. Long story short, I have created a Web-Page Analysis of Your Website which addresses all of the technical and web errors on your website. I am happy to send you this Web Page Analysis of Your Website FREE. All I want is the opportunity to call you and discuss for your website in greater detail. What do you think? Can we schedule an meeting with you or can call you? Kind Regards Emma From owner-freebsd-fs@freebsd.org Fri Nov 30 02:07:13 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 14B0611546CB for ; Fri, 30 Nov 2018 02:07:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 9FABB8DBF2 for ; Fri, 30 Nov 2018 02:07:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 5ACDE11546C7; Fri, 30 Nov 2018 02:07:12 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4946111546C6 for ; Fri, 30 Nov 2018 02:07:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DD1538DBEC for ; Fri, 30 Nov 2018 02:07:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 167579523 for ; Fri, 30 Nov 2018 02:07:11 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wAU27AeZ092638 for ; Fri, 30 Nov 2018 02:07:10 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wAU27AFx092637 for fs@FreeBSD.org; Fri, 30 Nov 2018 02:07:10 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 200663] zfs allow/unallow doesn't show numeric UID when the ID no longer exists in the password file Date: Fri, 30 Nov 2018 02:07:10 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: ler@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Rspamd-Queue-Id: 9FABB8DBF2 X-Spamd-Result: default: False [2.02 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_SPAM_LONG(0.55)[0.545,0]; NEURAL_SPAM_SHORT(0.79)[0.790,0]; NEURAL_SPAM_MEDIUM(0.68)[0.683,0]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2018 02:07:13 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D200663 --- Comment #7 from Larry Rosenman --- Any new news here? Is there anything I can provide? --=20 You are receiving this mail because: You are on the CC list for the bug.= From owner-freebsd-fs@freebsd.org Fri Nov 30 14:37:40 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 25D421145F3D for ; Fri, 30 Nov 2018 14:37:40 +0000 (UTC) (envelope-from info@incomemail.online) Received: from mail.incomemail.online (incomemail.online [103.39.133.78]) by mx1.freebsd.org (Postfix) with ESMTP id 972218508A for ; Fri, 30 Nov 2018 14:37:36 +0000 (UTC) (envelope-from info@incomemail.online) Received: from ae2f4962822c94 ([182.75.24.156]) by incomemail.online with MailEnable ESMTP; Fri, 30 Nov 2018 19:55:44 +0530 From: To: Subject: Re:1st On Google Date: Fri, 30 Nov 2018 19:53:51 +0530 MIME-Version: 1.0 X-Mailer: Microsoft Office Outlook, Build 11.0.5510 Thread-Index: AdSIsod0BXkDuhk3STiTE8Mi1b5Wjw== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Message-ID: X-Rspamd-Queue-Id: 972218508A X-Spamd-Result: default: False [10.40 / 15.00]; TO_DN_NONE(0.00)[]; MX_GOOD(-0.01)[mail.incomemail.online]; RCVD_NO_TLS_LAST(0.10)[]; RECEIVED_SPAMHAUS_PBL(0.00)[156.24.75.182.zen.spamhaus.org : 127.0.0.11]; IP_SCORE(0.00)[country: IN(0.02)]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:132779, ipnet:103.39.133.0/24, country:IN]; INTRODUCTION(2.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_XBL(3.00)[156.24.75.182.zen.spamhaus.org : 127.0.0.4]; FAKE_REPLY(1.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(0.91)[0.906,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[incomemail.online]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(1.00)[1.000,0]; RCPT_COUNT_ONE(0.00)[1]; MANY_INVISIBLE_PARTS(0.50)[6]; NEURAL_SPAM_LONG(1.00)[1.000,0]; FROM_NO_DN(0.00)[]; R_SPF_NA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; GREYLIST(0.00)[pass,meta] X-Rspamd-Server: mx1.freebsd.org X-Spam: Yes Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Nov 2018 14:37:40 -0000 Hello, I recently sent you an email regarding our company and providing 1st On Google. Let me know if you are interested and we can discuss this further. I look forward to your response. Kind Regards Emma _____ From: info@incomemail.online [mailto:info@incomemail.online] Sent: Thursday, November 29, 2018 5:15 PM To: freebsd-fs@freebsd.org Subject: 1st On Google Hi, Hope you are doing well. My name is Emma and I work for a Search Marketing company. I was doing some research on your industry and see your website. Thing is I had a look at some of the other businesses who are currently ranked on Page 1 and I truly believe you have a better website and a better brand and we can make better position on web for you. Long story short, I have created a Web-Page Analysis of Your Website which addresses all of the technical and web errors on your website. I am happy to send you this Web Page Analysis of Your Website FREE. All I want is the opportunity to call you and discuss for your website in greater detail. What do you think? Can we schedule an meeting with you or can call you? Kind Regards Emma From owner-freebsd-fs@freebsd.org Sat Dec 1 16:42:27 2018 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CE107132159B for ; Sat, 1 Dec 2018 16:42:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 65A506BB0C for ; Sat, 1 Dec 2018 16:42:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 295D21321599; Sat, 1 Dec 2018 16:42:27 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 166741321597 for ; Sat, 1 Dec 2018 16:42:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A459A6BB01 for ; Sat, 1 Dec 2018 16:42:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id CF37C1D50E for ; Sat, 1 Dec 2018 16:42:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wB1GgPg1090572 for ; Sat, 1 Dec 2018 16:42:25 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wB1GgPSH090571 for fs@FreeBSD.org; Sat, 1 Dec 2018 16:42:25 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 200663] zfs allow/unallow doesn't show numeric UID when the ID no longer exists in the password file Date: Sat, 01 Dec 2018 16:42:25 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: yuripv@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Rspamd-Queue-Id: 65A506BB0C X-Spamd-Result: default: False [1.03 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_SPAM_LONG(0.55)[0.545,0]; NEURAL_SPAM_MEDIUM(0.47)[0.468,0]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; NEURAL_SPAM_SHORT(0.02)[0.020,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Dec 2018 16:42:28 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D200663 Yuri Pankov changed: What |Removed |Added ---------------------------------------------------------------------------- CC|yuripv@yuripv.net |yuripv@FreeBSD.org --- Comment #8 from Yuri Pankov --- Unfortunately, it's still waiting to be integrated in openzfs: https://github.com/openzfs/openzfs/pull/690 I wonder if I should just go with a FreeBSD review instead. --=20 You are receiving this mail because: You are on the CC list for the bug.=