From owner-freebsd-hackers@freebsd.org Sun Feb 25 01:00:03 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 54B0FF31D4A for ; Sun, 25 Feb 2018 01:00:03 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yb0-x22e.google.com (mail-yb0-x22e.google.com [IPv6:2607:f8b0:4002:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E1ACD8080B for ; Sun, 25 Feb 2018 01:00:02 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yb0-x22e.google.com with SMTP id b12-v6so4190529ybn.8 for ; Sat, 24 Feb 2018 17:00:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Kd2dMGLPbr3pBn0Vyur84L0mMaQgOERiDPJKr1Ih2cQ=; b=OQIFbIZVCbgQmovPLajQScpy2RauAqwAhVpzCaZtWnPDvrmFADPTYGiSn8Lh181MVU R71uoSrotAtmNxnqAxT7cW3Jo8uKVzb2JovxG4M9X+P0TqFaHYgugsTRSNMIzvNVtdJu wvGH+VkpMJcVfxkZmssvmtgi02Ps2biL2tLuY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Kd2dMGLPbr3pBn0Vyur84L0mMaQgOERiDPJKr1Ih2cQ=; b=kGInYqO4AHpq1hJGSV+nOJlBwb1ZEyykHVb3Zt8mcd3zDVvnME+tjiyvBxOnaSksLk DmBz9X68k4K6HJrsTAC7MVasxxQ0sPFuMVw7HeFS/BgWEkJtRQGnYSwPcVtcOp4Pi41u /Xf2wfWocVkRFu4UxdNOJr5uByixyDktQ4gyOLgesa/uzxtGDFQokUZgy4Pq9v9b+x0f 9CQEY5W6AyUsMNYmaKTxKvT0OlIVOxz0caWlyqxdngN0t2uO2hGj2N/i1XPxD06YrNGB OZ56SmFkdEsYJFDKeZ6UBw4yo8p5cDYg1DZ4Tt/AhCYe1OHiURNPje8JRz8oRr2svwhA aVNg== X-Gm-Message-State: APf1xPB9XK1ZBBuC4GQWKNkp5sU9/PL12JET3wP4xxNNk5S9ZClDGTbn uE5OPfYHWu8dtIxICX+0UYWs7zZp7vnPMNpx45cRQQ== X-Google-Smtp-Source: AG47ELtn0oF8c6fhskzkw64qQLxtk1SW2i7rWQAiVl7iqboIaZ6M2Q0TLsQgR9BdqLiSezaT5wN9oG4VlNtcWpRNYIE= X-Received: by 2002:a25:6006:: with SMTP id u6-v6mr4191129ybb.460.1519520402106; Sat, 24 Feb 2018 17:00:02 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a25:dfcb:0:0:0:0:0 with HTTP; Sat, 24 Feb 2018 16:59:31 -0800 (PST) In-Reply-To: References: <20180221032247.GA81670@ns.kevlo.org> <20180221104400.GU94212@kib.kiev.ua> <23181.46427.671514.319710@khavrinen.csail.mit.edu> <20180221185920.GA94212@kib.kiev.ua> <23181.50488.186767.579361@khavrinen.csail.mit.edu> <20180221201002.GC94212@kib.kiev.ua> <23181.54825.511195.393054@khavrinen.csail.mit.edu> <20180222212746.GB58772@stack.nl> From: Eitan Adler Date: Sat, 24 Feb 2018 16:59:31 -0800 Message-ID: Subject: Re: Marking select(2) as restrict To: cem@freebsd.org Cc: FreeBSD Hackers , FreeBSD Standards Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Feb 2018 01:00:03 -0000 On 24 February 2018 at 10:55, Conrad Meyer wrote: > On Sat, Feb 24, 2018 at 10:35 AM, Eitan Adler wrote: >> After this entire thread here is the summary. If I've misrepresented >> you here please let me know. >> ... >> >> kib@ - no benefit; concerned fallout could be hard to observe >> cem@ - concerned about warnings > > Consider me a +1 to kib@. I did not voice those concerns explicitly > in earlier email because kib did already and I didn't anticipate you > would ignore him. I am not ignoring him. As I stated above I do not believe fallout is likely since most other major libc implementations have already done this: glibc: already done - https://github.com/bminor/glibc/blob/master/misc/sys/select.h#L101 openbsd: already done https://github.com/openbsd/src/blob/master/sys/sys/select.h#L128 dragonflyBSD: alredy done: https://github.com/dragonflybsd/dragonflybsd/blob/master/sys/sys/select.h#L50 netbsd: already done: https://github.com/NetBSD/src/blob/trunk/sys/sys/select.h#L69 As a further check I went through the search results on github for select() and did not see any failures in the top few pages. -- Eitan Adler