From owner-freebsd-hackers@freebsd.org Tue Jul 17 12:12:43 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5E3CF103D5B4 for ; Tue, 17 Jul 2018 12:12:43 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from dedi548.your-server.de (dedi548.your-server.de [85.10.215.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E854386934 for ; Tue, 17 Jul 2018 12:12:42 +0000 (UTC) (envelope-from sebastian.huber@embedded-brains.de) Received: from [88.198.220.130] (helo=sslproxy01.your-server.de) by dedi548.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2) (envelope-from ) id 1ffOqH-0005e0-PI for freebsd-hackers@freebsd.org; Tue, 17 Jul 2018 14:12:33 +0200 Received: from [82.135.62.35] (helo=mail.embedded-brains.de) by sslproxy01.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1ffOqH-0002FI-JN for freebsd-hackers@freebsd.org; Tue, 17 Jul 2018 14:12:33 +0200 Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id D23732A1685 for ; Tue, 17 Jul 2018 14:12:33 +0200 (CEST) Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id jtGAc9wjzFMn for ; Tue, 17 Jul 2018 14:12:33 +0200 (CEST) Received: from localhost (localhost.localhost [127.0.0.1]) by mail.embedded-brains.de (Postfix) with ESMTP id 984BF2A1686 for ; Tue, 17 Jul 2018 14:12:33 +0200 (CEST) X-Virus-Scanned: amavisd-new at zimbra.eb.localhost Received: from mail.embedded-brains.de ([127.0.0.1]) by localhost (zimbra.eb.localhost [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id upndOo4V77vw for ; Tue, 17 Jul 2018 14:12:33 +0200 (CEST) Received: from linux-diu0.suse (unknown [192.168.96.149]) by mail.embedded-brains.de (Postfix) with ESMTP id 7965E2A1685 for ; Tue, 17 Jul 2018 14:12:33 +0200 (CEST) From: Sebastian Huber To: freebsd-hackers@freebsd.org Subject: [PATCH] Add fallthrough comment to kvprintf() Date: Tue, 17 Jul 2018 14:12:32 +0200 Message-Id: <20180717121232.18799-1-sebastian.huber@embedded-brains.de> X-Mailer: git-send-email 2.13.7 X-Authenticated-Sender: smtp-embedded@poldinet.de X-Virus-Scanned: Clear (ClamAV 0.100.0/24760/Tue Jul 17 06:40:15 2018) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jul 2018 12:12:43 -0000 STYLE(9) recommends a FALLTHROUGH comment. Coverity Scan also complained about this area. --- sys/kern/subr_prf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/kern/subr_prf.c b/sys/kern/subr_prf.c index 618d47fe81a..e93aa9cc44c 100644 --- a/sys/kern/subr_prf.c +++ b/sys/kern/subr_prf.c @@ -716,6 +716,7 @@ reswitch: switch (ch = (u_char)*fmt++) { padc = '0'; goto reswitch; } + /* FALLTHROUGH */ case '1': case '2': case '3': case '4': case '5': case '6': case '7': case '8': case '9': for (n = 0;; ++fmt) { -- 2.13.7