From owner-freebsd-jail@freebsd.org Sun Jun 24 08:04:04 2018 Return-Path: Delivered-To: freebsd-jail@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 10CD3101DC46; Sun, 24 Jun 2018 08:04:04 +0000 (UTC) (envelope-from SRS0=8X+v=JK=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [94.124.105.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8ED097E488; Sun, 24 Jun 2018 08:04:03 +0000 (UTC) (envelope-from SRS0=8X+v=JK=quip.cz=000.fbsd@elsa.codelab.cz) Received: from elsa.codelab.cz (localhost [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id 2360928411; Sun, 24 Jun 2018 10:03:55 +0200 (CEST) Received: from illbsd.quip.test (ip-86-49-16-209.net.upcbroadband.cz [86.49.16.209]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id A144828422; Sun, 24 Jun 2018 10:03:46 +0200 (CEST) Subject: Re: jail related inconsistencies in FreeBSD tools parameters To: James Gritton , bsd-lists@bsdforge.com, freebsd-jail@freebsd.org, freebsd-stable Stable References: <6dd9952452c73826a2f9c01612586bea@udns.ultimatedns.net> <18000a3b93085c91aeffbca937862786@freebsd.org> From: Miroslav Lachman <000.fbsd@quip.cz> Message-ID: <47728073-93d3-325c-d90f-6235a4d548e7@quip.cz> Date: Sun, 24 Jun 2018 10:03:45 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.3 MIME-Version: 1.0 In-Reply-To: <18000a3b93085c91aeffbca937862786@freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-jail@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "Discussion about FreeBSD jail\(8\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jun 2018 08:04:04 -0000 James Gritton wrote on 2018/06/23 17:30: > On 2018-06-22 16:03, Miroslav Lachman wrote: >> Chris H wrote on 2018/06/22 23:46: >>> On Fri, 22 Jun 2018 23:13:17 +0200 "Miroslav Lachman" >>> <000.fbsd@quip.cz> said >>> >>>> I don't know if it is better to discuss it in jail@ or stable@ list >>>> so a do cross-post. >>>> >>>> FreeBSD has many jail aware utilities but they are inconsistent in >>>> taking JID as parameter. >>>> >>>> For example "sockstat" takes -j JID "Show only sockets belonging to >>>> the specified jail ID" and it means numeric ID only. >>>> On the other hand "ps" takes -J JID "This may be either the jid or >>>> name of the jail.  Use -J 0 to display only host processes." >>>> The same apply for "top", it understands jid as a number or name of >>>> the jail too. >>>> Then again "cpuset" takes only numerical ID of the jail... >>>> >>>> Shouldn't it be consistent across all FreeBSD base utilities so all >>>> of them can use numerical ID and name? >>> Good idea! Are you offering to create a patch? ;-) >>> It'd be my guess that given they weren't all created at the same >>> time, nor >>> the same individual; that (quite probably?) the "jail" additions were >>> also >>> added at different times, and by different people. So I'd imagine that >>> unless someone with a commit bit decides one day they'd like to take >>> that >>> on. Someone(tm) maybe you? will need to propose a patch. :-) >> >> If I can understand C sources I will create the patch by myself >> instead of just posting here. Unfortunately I am able to code in sh, >> php and a bit of javascript and perl but no C. :) >> >> Miroslav Lachman > > Sure, a PR would be handy for this - it's a pretty simple thing to add, > and consistency would indeed be a good move. PR 229266 created https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229266 Kind regards Miroslav Lachman