From owner-freebsd-multimedia@freebsd.org Sun Jul 22 18:09:05 2018 Return-Path: Delivered-To: freebsd-multimedia@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5FFB11051E4B for ; Sun, 22 Jul 2018 18:09:05 +0000 (UTC) (envelope-from aliovx@gmail.com) Received: from mail-oi0-x236.google.com (mail-oi0-x236.google.com [IPv6:2607:f8b0:4003:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E858C7E73F for ; Sun, 22 Jul 2018 18:09:04 +0000 (UTC) (envelope-from aliovx@gmail.com) Received: by mail-oi0-x236.google.com with SMTP id k81-v6so29491437oib.4 for ; Sun, 22 Jul 2018 11:09:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=+SeJ1xStRP5PhGE/rN7mpaAEwUV8TZTN6z5YtdhMGWk=; b=LZut20+61oe5HkusjZNiHzQOdNm7MMoATb6JTX18/nXUNP0Cz6JuyezpOai+HrgITL KRvYwBfkYjLLVHl49G0XiLMLvm4m+V/f8nKunSwoK11woEyrWqFAjAxg+rLhrHAeqC3x +prgS6mWKX6KyULB0s17zYgM2DvNo5IQOfckHGddWgHHwWtG3unVyyZSIevXuy9ul2dk YpU+A6bE0knPr611KlRCBn3fad64b2ADXMk1gzWb49GnVwST/a37IoSGmKpZyO4Pvlvo +/b5mXuLqekBPsAF1VzfzXvpKZuZQVoSWGqLGrtmIeN53fkjF3IBC+UTZvizM9PAxrCs t1ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=+SeJ1xStRP5PhGE/rN7mpaAEwUV8TZTN6z5YtdhMGWk=; b=Ia1lWgU+J1hFlzoTfqKBvw/rUPXkNaZK6F/iE4mhg2pXbSLuibDmJmsLSmsDEcdF47 0qFGnJ2onyVGjxDYzZ7tZBefFhqHupbyPZ9cN3/o0L/xSARk6E5FLw7ESOEvUhJu1lQH g0dU3KbhDug3WJfNlivlftu+DDInMbsJP9I1fLTJlJ1rWpLCBBNSmodvXT0GxGgeV2Y/ SX8pFMgcNVCMHI70I87+1CHrcTgYXXcyvBI54zdrvF1fQjIW94UPshRqbU/Ax3EpedL9 GNEJFqshs98cEDKRF0n3N2fU5xIe1n/CW+T5+Qebn/cU6ROVNUWf0wiWQ4SOj1pry7JJ 82mw== X-Gm-Message-State: AOUpUlEML4iqKfP2eUYwZnKtiznWhFA/ZUE7lUwwByEb8D5mv80tDJkU AtyfIIcuMuTi8AjiPRe2Guv/22chfBtYphym0cX1NdaF X-Google-Smtp-Source: AAOMgpd8xJCXnY5MFlfOyUdoP7J3i95eoE+isSFg5i32bHM3xFP6tIv6FwPt7yrByvcgqNMgZxReIPOXEXu9JX6CqgQ= X-Received: by 2002:aca:b256:: with SMTP id b83-v6mr5089825oif.235.1532282944224; Sun, 22 Jul 2018 11:09:04 -0700 (PDT) MIME-Version: 1.0 From: Ali Abdallah Date: Sun, 22 Jul 2018 20:08:53 +0200 Message-ID: Subject: mixer_info modify_counter To: freebsd-multimedia@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Jul 2018 18:09:05 -0000 Hello, Any reason why the modify_counter bit of mixer_info is not incremented when the mixer gets changed? >From sys/dev/sound/pcm/mixer.c:70 /** * Counter is incremented when applications change any of this * mixer's controls. A change in value indicates that persistent * mixer applications should update their displays. */ But reading the code, it is clear that this is not the case, and the counter remains 0. It is enough to call m->modify_counter++ in mixer_set on line 327 for example to make persistent mixer applications work correctly. Currently they have to poll for all mixer controls, even if no changes were made to the mixer. Best, Ali