From owner-freebsd-pf@freebsd.org Thu Feb 8 12:40:35 2018 Return-Path: Delivered-To: freebsd-pf@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C1E12F20E4F for ; Thu, 8 Feb 2018 12:40:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5EF4F84FF1 for ; Thu, 8 Feb 2018 12:40:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 83A2270D1 for ; Thu, 8 Feb 2018 12:40:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w18CeYww037453 for ; Thu, 8 Feb 2018 12:40:34 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w18CeYGE037448 for freebsd-pf@FreeBSD.org; Thu, 8 Feb 2018 12:40:34 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: freebsd-pf@FreeBSD.org Subject: [Bug 209475] pf didn't check if enough free RAM for net.pf.states_hashsize Date: Thu, 08 Feb 2018 12:40:34 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 10.3-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: fnoyanisi@yahoo.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-pf@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-pf@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "Technical discussion and general questions about packet filter \(pf\)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 12:40:35 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209475 fehmi noyan isi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176410|0 |1 is obsolete| | --- Comment #24 from fehmi noyan isi --- Created attachment 190429 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D190429&action= =3Dedit patch that uses mallocarray(9) and printf(9) I have been tied by other commitments, so could not send this patch, which I wrote about a a week or so ago. This patch attempts to allocate requested memory by using mallocarray(9) wi= th NO_WAIT flag and if the call fails, it falls back and makes another mallocarray(9) call. Second call, however, is done by using the default PF_HASHSIZ value and M_WAITOK flag. Please note, even with this patch, pf.ko still crashes during initialisation phase if you set the value of net.pf.states_hashsize sysctl tunable large enough to consume all physical memory, something like 2147483648 on a machi= ne with 512MB RAM (this check has been opted out during the discussions). The patch also adds some logging mechanism, by using printf(9), in case any= of the mallocarray(9) calls fails. The patch was generated the pf.c found in 12.0-CURRENT --=20 You are receiving this mail because: You are the assignee for the bug.=