Date: Sun, 28 Jan 2018 00:05:29 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 225320] New port: lang/RETRO: clean, elegant, and pragmatic dialect of Forth Message-ID: <bug-225320-13-jE6VUL36b3@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-225320-13@https.bugs.freebsd.org/bugzilla/> References: <bug-225320-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D225320 --- Comment #2 from Mateusz Piotrowski <mpp302@gmail.com> --- (In reply to Matthew Seaman from comment #1) > * With certain narrow exceptions, port and pkg names=20 > are usually all lower-case.=20 Sure, I'll update the patch soon.=20 I'd like to add that the NetBSD port is called "lang/forth-retro", and Lite= BSD ports are called retro12 and retro11.. > * It also seems like the '12' part of the version number is intrinsic to= =20 > the software name, and the version number is just the encoded date >=20=20=20=20 > - Could you rename the to lang/retro12 and the PORTNAME to retro12=20 > please? > - Use DISTVERSION=3D2018.1 rather than inventing a PORTVERSION > - Given that, you shouldn't need to set DISTNAME as the default will=20 > do the right thing. > - Similarly you shouldn't need to override the setting for WRKSRC I tried to follow the format mentioned in the section 5.2.5.: "0.0.yyyy.mm.= dd", because (as you've probably seen here [1]) the versioning of RETRO fits perfectly this format. I'll apply the suggestions you mentioned in the next version of the patch. > * You've listed the maintainer as 0mp@FreeBSD.org -- I can't find=20 > that as a known user. You should put your own e-mail address=20 > in as the maintainer. I am a former Google Summer of Code student and I use 0mp@ daily, although = I do not have any commit bit. I am already mentioned like this as a maintainer of accessibility/sct. I cannot use this email address as my primary address on Buzilla, however, because FreeBSD.org emails are automatically considered t= o be in the committer group or something. > * You don't need to explain all about the location of=20 > documentation and examples and other data in pkg-descr -- this is=20 > standard functionality and applies automatically for every port. >=20=20=20=20 > * Similarly for pkg.message -- you're describing boiler-plate=20 > functionality. I'd remove pkg-message entirely: remember,=20 > less is more here and pkg-message should be reserved only for=20 > those occasions where it is really needed. Sure, I'll remember about it in the next version. Thank you for your review! I'll submit an updated patch soon. [1]: https://forthworks.com/retro/r --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-225320-13-jE6VUL36b3>