From owner-freebsd-scsi@freebsd.org Sun Nov 11 21:01:14 2018 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3D1131124366 for ; Sun, 11 Nov 2018 21:01:14 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id AD06E6DD67 for ; Sun, 11 Nov 2018 21:01:13 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 725821124362; Sun, 11 Nov 2018 21:01:13 +0000 (UTC) Delivered-To: scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 50A791124361 for ; Sun, 11 Nov 2018 21:01:13 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8E6216DD5A for ; Sun, 11 Nov 2018 21:01:12 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id C71B7E3CC for ; Sun, 11 Nov 2018 21:01:11 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wABL1Brw044487 for ; Sun, 11 Nov 2018 21:01:11 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wABL1BQx044481 for scsi@FreeBSD.org; Sun, 11 Nov 2018 21:01:11 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <201811112101.wABL1BQx044481@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: scsi@FreeBSD.org Subject: Problem reports for scsi@FreeBSD.org that need special attention Date: Sun, 11 Nov 2018 21:01:11 +0000 MIME-Version: 1.0 X-Rspamd-Queue-Id: AD06E6DD67 X-Spamd-Result: default: False [-105.89 / 200.00]; FORGED_RECIPIENTS_FORWARDING(0.00)[]; ALLOW_DOMAIN_WHITELIST(-100.00)[FreeBSD.org]; FORWARDED(0.00)[scsi@mailman.ysv.freebsd.org]; SPF_FAIL_FORWARDING(0.00)[]; TO_DN_NONE(0.00)[]; HAS_XAW(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; URI_COUNT_ODD(1.00)[3]; RCVD_IN_DNSWL_MED(-0.20)[5.0.0.0.0.5.0.0.0.0.0.0.0.0.0.0.a.6.0.2.4.5.2.2.0.0.9.1.1.0.0.2.list.dnswl.org : 127.0.9.2]; MX_GOOD(-0.01)[cached: mx1.FreeBSD.org]; NEURAL_HAM_SHORT(-1.00)[-1.000,0]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; IP_SCORE(-3.68)[ip: (-9.84), ipnet: 2001:1900:2254::/48(-4.76), asn: 10310(-3.69), country: US(-0.09)]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; FORGED_RECIPIENTS(0.00)[scsi@FreeBSD.org,freebsd-scsi@freebsd.org]; TO_DOM_EQ_FROM_DOM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[FreeBSD.org]; RCPT_COUNT_ONE(0.00)[1]; FROM_NO_DN(0.00)[]; RCVD_COUNT_SEVEN(0.00)[7] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Nov 2018 21:01:14 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- New | 221952 | cam iosched: Fix trim statistics 1 problems total for which you should take action. From owner-freebsd-scsi@freebsd.org Mon Nov 12 17:03:32 2018 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CFB79110B57B for ; Mon, 12 Nov 2018 17:03:32 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 45349776EA for ; Mon, 12 Nov 2018 17:03:32 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: by mailman.ysv.freebsd.org (Postfix) id 09E66110B579; Mon, 12 Nov 2018 17:03:32 +0000 (UTC) Delivered-To: scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D9F23110B578; Mon, 12 Nov 2018 17:03:31 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DB71C776E9; Mon, 12 Nov 2018 17:03:25 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (ezra.dcm1.omnilan.net [78.138.80.135]) by mx0.gentlemail.de (8.14.5/8.14.5) with ESMTP id wACH3Mot074266; Mon, 12 Nov 2018 18:03:22 +0100 (CET) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (s1.omnilan.de [217.91.127.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id A175A5A9; Mon, 12 Nov 2018 18:03:22 +0100 (CET) Subject: MSI allocation regression, still to be corrected in HEAD and please MFC before release/12.0 gets branched From: Harry Schmalzbauer To: scsi@freebsd.org, freebsd-stable References: <201707300653.v6U6rwLN099096@repo.freebsd.org> <597DA578.6030101@omnilan.de> <597F56A8.1060603@omnilan.de> <59804C8C.1020003@omnilan.de> <78611650-D7A4-4B1D-A254-DB058E1AC1C6@samsco.org> <6e1e5f9f-4ece-dc9d-b059-08d52c9e6965@omnilan.de> Organization: OmniLAN Message-ID: <042090da-f73f-ce80-517c-0b1729d3d6e1@omnilan.de> Date: Mon, 12 Nov 2018 18:03:22 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <6e1e5f9f-4ece-dc9d-b059-08d52c9e6965@omnilan.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Greylist: ACL 130 matched, not delayed by milter-greylist-4.2.7 (mx0.gentlemail.de [78.138.80.130]); Mon, 12 Nov 2018 18:03:23 +0100 (CET) X-Milter: Spamilter (Reciever: mx0.gentlemail.de; Sender-ip: 78.138.80.135; Sender-helo: mh0.gentlemail.de; ) X-Rspamd-Queue-Id: 45349776EA X-Spamd-Result: default: False [-7.05 / 200.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+a:mx2.freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[omnilan.de]; TO_DN_SOME(0.00)[]; HAS_ORG_HEADER(0.00)[]; RCVD_IN_DNSWL_MED(-0.20)[5.0.0.0.0.5.0.0.0.0.0.0.0.0.0.0.a.6.0.2.4.5.2.2.0.0.9.1.1.0.0.2.list.dnswl.org : 127.0.9.2]; MX_GOOD(-0.01)[cached: mx0.gentlemail.de]; NEURAL_HAM_SHORT(-0.96)[-0.958,0]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; IP_SCORE(-3.68)[ip: (-9.84), ipnet: 2001:1900:2254::/48(-4.77), asn: 10310(-3.71), country: US(-0.09)]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; FORGED_RECIPIENTS(0.00)[scsi@freebsd.org ..,freebsd-scsi@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2018 17:03:33 -0000 Am 11.06.2018 um 20:28 schrieb Harry Schmalzbauer: > Am 05.06.2018 um 19:54 schrieb Scott Long: > … >>>>> Late in the 11.2 phase, I identified this commit as a regression >>>>> for MSI (non-x) alloctaion. >>>>> I have an idea what probably causes the problem here (INTx >>>>> allocation, although MSI (and MSI-x) capability): >>>>> disable_msix is not 0 (I need to disable MSI-x because of >>>>> ESXi-passthru…). >>>>> >>>>> Corresponding lines: >>>>> { >>>>>          device_t dev; >>>>>          int error, msgs; >>>>> >>>>>          dev = sc->mps_dev; >>>>>          error = 0; >>>>>          msgs = 0; >>>>> >>>>>          if ((sc->disable_msix == 0) && >>>>>              ((msgs = pci_msix_count(dev)) >= MPS_MSI_COUNT)) >>>>>                  error = mps_alloc_msix(sc, MPS_MSI_COUNT); >>>>>          if ((error != 0) && (sc->disable_msi == 0) && >>>>>              ((msgs = pci_msi_count(dev)) >= MPS_MSI_COUNT)) >>>>>                  error = mps_alloc_msi(sc, MPS_MSI_COUNT); >>>>>          if (error != 0) >>>>>                  msgs = 0; >>>>> >>>>>          sc->msi_msgs = msgs; >>>>>          return (error); >>>>> } >>>>> … >>>> Hi Harry, >>>> You are correct about the bug.  Please change the line at the top >>>> of the function that reads >>>> error = 0; >>>> to >>>> error = ENXIO; >>>> Let me know if that fixes the MSI problem for you. > > … > … > Index: src/sys/dev/mps/mps_pci.c > =================================================================== > --- sys/dev/mps/mps_pci.c   (Revision 334948) > +++ sys/dev/mps/mps_pci.c   (Arbeitskopie) > @@ -244,7 +244,7 @@ >         int error, msgs; > >         dev = sc->mps_dev; > -       error = 0; > +       error = ENXIO; >         msgs = 0; > >         if ((sc->disable_msix == 0) && > To my understanding, it's obvious that the way mps_pci_alloc_interrupts() currently works is unintended. This might not affect too many people, but is there a reason not to fix it? I already created a coresponding problem report: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229267 Anything else I should do? Thanks, -harry From owner-freebsd-scsi@freebsd.org Tue Nov 13 18:02:39 2018 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D6AB7112C4E7 for ; Tue, 13 Nov 2018 18:02:38 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 41F50705DA for ; Tue, 13 Nov 2018 18:02:38 +0000 (UTC) (envelope-from scottl@samsco.org) Received: by mailman.ysv.freebsd.org (Postfix) id 02D74112C4E4; Tue, 13 Nov 2018 18:02:38 +0000 (UTC) Delivered-To: scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D4A81112C4E3; Tue, 13 Nov 2018 18:02:37 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D3EA6705D7; Tue, 13 Nov 2018 18:02:35 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id AD3D13CF; Tue, 13 Nov 2018 13:02:27 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 13 Nov 2018 13:02:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsco.org; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm1; bh=U P34BGG1g4P1l6baWnDOhKU+PNkW77ED4DUg2SbcpcQ=; b=MswhBgOBJJ1pOVr7E iKabJUqtEZ7z1YD0yX6A6Z5iJd9r2ryomMEbmQrZAZjwzfdVsbnDuJ5Ir1Db9J6p z/xLm+Q8K4nPGzN8BenQN2pULJIfOQzVJ0ACnATd63zUJODTHCknPKUY5kSfaGH7 pEPZSiqRqh8ErllyyVQT1EQKSd1UMJz0PqlJonnQcKQiUNotsIebf1tCzWSyCmHP +aGY7oKUcd3wLVXQejZXCquySboT1eUc3shzlEzDqhOrtLLadrwNUjt5thlfKO9j YBjnnLg54Ca9AjRFMR9S88fmjIhNRzH4I//MWKHqpMwlccdgq+orQZt/34grdNaX RPLRg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=UP34BGG1g4P1l6baWnDOhKU+PNkW77ED4DUg2Sbcp cQ=; b=Baw5KMY6ofLmLREjwzyKBcl1xlffw+QBuH2CJj/jKaV/CESL7dtIt5P/i pZj1ofSQ8Ltji+ouOFLzBzKasOUPNJOTuH+IErH749y3u9LwCvpUDsR6mwo5YbYx n1yY4qM4IWstk+aGIp0fwGhoar+NxbNooolF3FGMW3Hrh33JmwEb34Qp6/Ptrv6f P1Mr/M9QlUZccueDQYNoCAudB6M16eUo+m+Q0Y3IE8QwPfELmqRx+AX2XzQ5GrQe tNwHqGaZIhbug9+y98vaWe4vCf9W5pwqdVIuv865o/aRxfmrlu1NMb1AN5B0qTWY nPCkIZcoejfdwcRUxh0HWBoN6YQTA== X-ME-Sender: X-ME-Proxy: Received: from [192.168.0.137] (unknown [8.46.89.213]) by mail.messagingengine.com (Postfix) with ESMTPA id 5EA0DE49CA; Tue, 13 Nov 2018 13:02:26 -0500 (EST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\)) Subject: Re: MSI allocation regression, still to be corrected in HEAD and please MFC before release/12.0 gets branched From: Scott Long In-Reply-To: <042090da-f73f-ce80-517c-0b1729d3d6e1@omnilan.de> Date: Tue, 13 Nov 2018 11:02:25 -0700 Cc: scsi@freebsd.org, freebsd-stable Content-Transfer-Encoding: quoted-printable Message-Id: <05D94EC4-D797-4246-96B5-6DC1494E7EA9@samsco.org> References: <201707300653.v6U6rwLN099096@repo.freebsd.org> <597DA578.6030101@omnilan.de> <597F56A8.1060603@omnilan.de> <59804C8C.1020003@omnilan.de> <78611650-D7A4-4B1D-A254-DB058E1AC1C6@samsco.org> <6e1e5f9f-4ece-dc9d-b059-08d52c9e6965@omnilan.de> <042090da-f73f-ce80-517c-0b1729d3d6e1@omnilan.de> To: Harry Schmalzbauer X-Mailer: Apple Mail (2.3445.100.39) X-Rspamd-Queue-Id: 41F50705DA X-Spamd-Result: default: False [-7.04 / 200.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[samsco.org,messagingengine.com]; RCVD_COUNT_SEVEN(0.00)[7]; R_SPF_NEUTRAL(0.00)[?all]; FROM_HAS_DN(0.00)[]; MV_CASE(0.50)[]; RCPT_COUNT_THREE(0.00)[3]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[samsco.org]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; DKIM_TRACE(0.00)[samsco.org:+,messagingengine.com:+]; RCVD_IN_DNSWL_MED(-0.20)[5.0.0.0.0.5.0.0.0.0.0.0.0.0.0.0.a.6.0.2.4.5.2.2.0.0.9.1.1.0.0.2.list.dnswl.org : 127.0.9.2]; MX_GOOD(-0.01)[cached: in2-smtp.messagingengine.com]; NEURAL_HAM_SHORT(-0.94)[-0.935,0]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(-3.69)[ip: (-9.85), ipnet: 2001:1900:2254::/48(-4.79), asn: 10310(-3.73), country: US(-0.09)]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; FORGED_RECIPIENTS(0.00)[scsi@freebsd.org ..,freebsd-scsi@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 18:02:39 -0000 > On Nov 12, 2018, at 10:03 AM, Harry Schmalzbauer = wrote: >=20 > Am 11.06.2018 um 20:28 schrieb Harry Schmalzbauer: >> Am 05.06.2018 um 19:54 schrieb Scott Long: >> =E2=80=A6 >>>>>> Late in the 11.2 phase, I identified this commit as a regression = for MSI (non-x) alloctaion. >>>>>> I have an idea what probably causes the problem here (INTx = allocation, although MSI (and MSI-x) capability): >>>>>> disable_msix is not 0 (I need to disable MSI-x because of = ESXi-passthru=E2=80=A6). >>>>>>=20 >>>>>> Corresponding lines: >>>>>> { >>>>>> device_t dev; >>>>>> int error, msgs; >>>>>>=20 >>>>>> dev =3D sc->mps_dev; >>>>>> error =3D 0; >>>>>> msgs =3D 0; >>>>>>=20 >>>>>> if ((sc->disable_msix =3D=3D 0) && >>>>>> ((msgs =3D pci_msix_count(dev)) >=3D MPS_MSI_COUNT)) >>>>>> error =3D mps_alloc_msix(sc, MPS_MSI_COUNT); >>>>>> if ((error !=3D 0) && (sc->disable_msi =3D=3D 0) && >>>>>> ((msgs =3D pci_msi_count(dev)) >=3D MPS_MSI_COUNT)) >>>>>> error =3D mps_alloc_msi(sc, MPS_MSI_COUNT); >>>>>> if (error !=3D 0) >>>>>> msgs =3D 0; >>>>>>=20 >>>>>> sc->msi_msgs =3D msgs; >>>>>> return (error); >>>>>> } >>>>>>=20 > =E2=80=A6 >>>>> Hi Harry, >>>>> You are correct about the bug. Please change the line at the top = of the function that reads >>>>> error =3D 0; >>>>> to >>>>> error =3D ENXIO; >>>>> Let me know if that fixes the MSI problem for you. >>=20 >> =E2=80=A6 >>=20 > =E2=80=A6 >> Index: src/sys/dev/mps/mps_pci.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- sys/dev/mps/mps_pci.c (Revision 334948) >> +++ sys/dev/mps/mps_pci.c (Arbeitskopie) >> @@ -244,7 +244,7 @@ >> int error, msgs; >>=20 >> dev =3D sc->mps_dev; >> - error =3D 0; >> + error =3D ENXIO; >> msgs =3D 0; >>=20 >> if ((sc->disable_msix =3D=3D 0) && >>=20 >=20 > To my understanding, it's obvious that the way = mps_pci_alloc_interrupts() currently works is unintended. > This might not affect too many people, but is there a reason not to = fix it? >=20 > I already created a coresponding problem report: = https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229267 > Anything else I should do? >=20 Hi Harry, Sorry for ignoring this for so long. I=E2=80=99m going to commit a fix = today, but it won=E2=80=99t be the same one-line change. Upon reviewing the code, I=E2=80=99d going to refactor it so it=E2=80=99s = not so confusing and prone to these kinds of mistakes. Thank you for the continued reminders to finish this. Scott From owner-freebsd-scsi@freebsd.org Tue Nov 13 18:11:23 2018 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3C62B112CE17 for ; Tue, 13 Nov 2018 18:11:23 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id B141D70E20 for ; Tue, 13 Nov 2018 18:11:22 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: by mailman.ysv.freebsd.org (Postfix) id 75881112CE15; Tue, 13 Nov 2018 18:11:22 +0000 (UTC) Delivered-To: scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5319E112CE14; Tue, 13 Nov 2018 18:11:22 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 265FD70E0A; Tue, 13 Nov 2018 18:11:15 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (ezra.dcm1.omnilan.net [78.138.80.135]) by mx0.gentlemail.de (8.14.5/8.14.5) with ESMTP id wADIBDXK087943; Tue, 13 Nov 2018 19:11:13 +0100 (CET) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (s1.omnilan.de [217.91.127.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id 155F87E1; Tue, 13 Nov 2018 19:11:13 +0100 (CET) Subject: Re: MSI allocation regression, still to be corrected in HEAD and please MFC before release/12.0 gets branched To: Scott Long Cc: scsi@freebsd.org, freebsd-stable References: <201707300653.v6U6rwLN099096@repo.freebsd.org> <597DA578.6030101@omnilan.de> <597F56A8.1060603@omnilan.de> <59804C8C.1020003@omnilan.de> <78611650-D7A4-4B1D-A254-DB058E1AC1C6@samsco.org> <6e1e5f9f-4ece-dc9d-b059-08d52c9e6965@omnilan.de> <042090da-f73f-ce80-517c-0b1729d3d6e1@omnilan.de> <05D94EC4-D797-4246-96B5-6DC1494E7EA9@samsco.org> From: Harry Schmalzbauer Organization: OmniLAN Message-ID: Date: Tue, 13 Nov 2018 19:11:11 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <05D94EC4-D797-4246-96B5-6DC1494E7EA9@samsco.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: ACL 130 matched, not delayed by milter-greylist-4.2.7 (mx0.gentlemail.de [78.138.80.130]); Tue, 13 Nov 2018 19:11:13 +0100 (CET) X-Milter: Spamilter (Reciever: mx0.gentlemail.de; Sender-ip: 78.138.80.135; Sender-helo: mh0.gentlemail.de; ) X-Rspamd-Queue-Id: B141D70E20 X-Spamd-Result: default: False [-7.09 / 200.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+a:mx2.freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[omnilan.de]; TO_DN_SOME(0.00)[]; HAS_ORG_HEADER(0.00)[]; RCVD_IN_DNSWL_MED(-0.20)[5.0.0.0.0.5.0.0.0.0.0.0.0.0.0.0.a.6.0.2.4.5.2.2.0.0.9.1.1.0.0.2.list.dnswl.org : 127.0.9.2]; MX_GOOD(-0.01)[cached: mx0.gentlemail.de]; NEURAL_HAM_SHORT(-0.98)[-0.984,0]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; IP_SCORE(-3.69)[ip: (-9.85), ipnet: 2001:1900:2254::/48(-4.79), asn: 10310(-3.73), country: US(-0.09)]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; FORGED_RECIPIENTS(0.00)[scottl@samsco.org ..,freebsd-scsi@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 18:11:23 -0000 Am 13.11.2018 um 19:02 schrieb Scott Long: > > >> On Nov 12, 2018, at 10:03 AM, Harry Schmalzbauer wrote: >> >> Am 11.06.2018 um 20:28 schrieb Harry Schmalzbauer: >>> Am 05.06.2018 um 19:54 schrieb Scott Long: >>> … >>>>>>> Late in the 11.2 phase, I identified this commit as a regression for MSI (non-x) alloctaion. >>>>>>> I have an idea what probably causes the problem here (INTx allocation, although MSI (and MSI-x) capability): >>>>>>> disable_msix is not 0 (I need to disable MSI-x because of ESXi-passthru…). >>>>>>> >>>>>>> Corresponding lines: >>>>>>> { >>>>>>> device_t dev; >>>>>>> int error, msgs; >>>>>>> >>>>>>> dev = sc->mps_dev; >>>>>>> error = 0; >>>>>>> msgs = 0; >>>>>>> >>>>>>> if ((sc->disable_msix == 0) && >>>>>>> ((msgs = pci_msix_count(dev)) >= MPS_MSI_COUNT)) >>>>>>> error = mps_alloc_msix(sc, MPS_MSI_COUNT); >>>>>>> if ((error != 0) && (sc->disable_msi == 0) && >>>>>>> ((msgs = pci_msi_count(dev)) >= MPS_MSI_COUNT)) >>>>>>> error = mps_alloc_msi(sc, MPS_MSI_COUNT); >>>>>>> if (error != 0) >>>>>>> msgs = 0; >>>>>>> >>>>>>> sc->msi_msgs = msgs; >>>>>>> return (error); >>>>>>> } >>>>>>> >> … >>>>>> Hi Harry, >>>>>> You are correct about the bug. Please change the line at the top of the function that reads >>>>>> error = 0; >>>>>> to >>>>>> error = ENXIO; >>>>>> Let me know if that fixes the MSI problem for you. >>> >>> … >>> >> … >>> Index: src/sys/dev/mps/mps_pci.c >>> =================================================================== >>> --- sys/dev/mps/mps_pci.c (Revision 334948) >>> +++ sys/dev/mps/mps_pci.c (Arbeitskopie) >>> @@ -244,7 +244,7 @@ >>> int error, msgs; >>> >>> dev = sc->mps_dev; >>> - error = 0; >>> + error = ENXIO; >>> msgs = 0; >>> >>> if ((sc->disable_msix == 0) && >>> >> >> To my understanding, it's obvious that the way mps_pci_alloc_interrupts() currently works is unintended. >> This might not affect too many people, but is there a reason not to fix it? >> >> I already created a coresponding problem report: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229267 >> Anything else I should do? >> > > Hi Harry, > > Sorry for ignoring this for so long. I’m going to commit a fix today, but it won’t be the same one-line change. > Upon reviewing the code, I’d going to refactor it so it’s not so confusing and prone to these kinds of mistakes. > Thank you for the continued reminders to finish this. Hi Scott, thanks a lot, in fact I'm not surprised that you come up with a better solution than that quick fix :-) Had hoped someone else would do an intermediate commit to get it into 12.0 in time, so you won't feel any time pressure - good job needs the time it needs, as long as the right person is doing the job. Unfortunately I don't have a non-productive setup where I could test before release/12.0 will be branched – might be subject to change... best, -harry From owner-freebsd-scsi@freebsd.org Tue Nov 13 18:45:16 2018 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 79744112DAFA for ; Tue, 13 Nov 2018 18:45:16 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id DF3CC725E8 for ; Tue, 13 Nov 2018 18:45:15 +0000 (UTC) (envelope-from scottl@samsco.org) Received: by mailman.ysv.freebsd.org (Postfix) id 9FACC112DAF8; Tue, 13 Nov 2018 18:45:15 +0000 (UTC) Delivered-To: scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 63469112DAF7; Tue, 13 Nov 2018 18:45:15 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 98F2B725E7; Tue, 13 Nov 2018 18:45:14 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 153E3C49; Tue, 13 Nov 2018 13:45:13 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 13 Nov 2018 13:45:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsco.org; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm1; bh=t h6KK8aZ9c3jc2rsyaZihPd1Veh+tchumH4k/HTNKcg=; b=px6ET2vNOpADKvMPZ o7yhoe+irlqegCmJl/BXA4RHHJ3AedPX6xCjj9J6ni4TyiyN/05fWCnYBIN28e// bzcL47T5mstgumL8Q84DxsO//dwuwALiau/nTc/AJtJwLQpNLxgudntuFY1irgmF W8fn5gzG0XzcoWwQanWdV0Xo/QgVCY35FARqm5weE0hf2r5DT64fqufNBMl71IXz 5Lsxt2d+H9TJPnEhOXx/6MKux7Ryi5fcFNwcBmxrDFk8aR7z7XqyOFYSDBNC22mX KYRgjohgOFG43IGEimJfV3L8oM3DQkY6kFMbNc4E6lokhZqfq0redjb8Nblq5gm6 CWJsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=th6KK8aZ9c3jc2rsyaZihPd1Veh+tchumH4k/HTNK cg=; b=ajmZZO95BxbiiZhJjV7anWWj2YcdndsAK2dwgaXoniKxly37VfvB2T3dj 8+4zc4UgNHb3+2F3yPeTpxBl7G5u+y96X9g0Gt6ovXVXfqaqpTHgHxKb5S3yIBpy R6RKYSbYPR50hCki6vuef8QT6E1joawI/tXC5Qu2klmfbOB26V6t4caADVEb7eko rV2hHz45SS9IuyCnN61iYGvhVhB6rmvQt9fKAhJZxAmWycsldClN2hBJYNHJQDn5 hpop6sdoVvetv8wcrtL3eZzAw+Mps4Or6BJC9W9eOcjmbPqCCMhPeLIjL+xMPUyf 3lQvwnyumUPp6h5MBPSCtsiVDQkWw== X-ME-Sender: X-ME-Proxy: Received: from [192.168.0.137] (unknown [8.46.89.213]) by mail.messagingengine.com (Postfix) with ESMTPA id B41F4E40E6; Tue, 13 Nov 2018 13:45:11 -0500 (EST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\)) Subject: Re: MSI allocation regression, still to be corrected in HEAD and please MFC before release/12.0 gets branched From: Scott Long In-Reply-To: Date: Tue, 13 Nov 2018 11:45:10 -0700 Cc: scsi@freebsd.org, freebsd-stable Content-Transfer-Encoding: quoted-printable Message-Id: <34515651-9883-4490-A3EE-7206AE973757@samsco.org> References: <201707300653.v6U6rwLN099096@repo.freebsd.org> <597DA578.6030101@omnilan.de> <597F56A8.1060603@omnilan.de> <59804C8C.1020003@omnilan.de> <78611650-D7A4-4B1D-A254-DB058E1AC1C6@samsco.org> <6e1e5f9f-4ece-dc9d-b059-08d52c9e6965@omnilan.de> <042090da-f73f-ce80-517c-0b1729d3d6e1@omnilan.de> <05D94EC4-D797-4246-96B5-6DC1494E7EA9@samsco.org> To: Harry Schmalzbauer X-Mailer: Apple Mail (2.3445.100.39) X-Rspamd-Queue-Id: DF3CC725E8 X-Spamd-Result: default: False [-7.04 / 200.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[samsco.org,messagingengine.com]; RCVD_COUNT_SEVEN(0.00)[7]; R_SPF_NEUTRAL(0.00)[?all]; FROM_HAS_DN(0.00)[]; MV_CASE(0.50)[]; RCPT_COUNT_THREE(0.00)[3]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[samsco.org]; RCVD_DKIM_ARC_DNSWL_MED(-0.50)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; DKIM_TRACE(0.00)[samsco.org:+,messagingengine.com:+]; RCVD_IN_DNSWL_MED(-0.20)[5.0.0.0.0.5.0.0.0.0.0.0.0.0.0.0.a.6.0.2.4.5.2.2.0.0.9.1.1.0.0.2.list.dnswl.org : 127.0.9.2]; MX_GOOD(-0.01)[cached: in2-smtp.messagingengine.com]; NEURAL_HAM_SHORT(-0.94)[-0.936,0]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(-3.69)[ip: (-9.86), ipnet: 2001:1900:2254::/48(-4.79), asn: 10310(-3.73), country: US(-0.09)]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; FORGED_RECIPIENTS(0.00)[scsi@freebsd.org ..,freebsd-scsi@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 18:45:16 -0000 > On Nov 13, 2018, at 11:11 AM, Harry Schmalzbauer = wrote: >=20 > Am 13.11.2018 um 19:02 schrieb Scott Long: >>> On Nov 12, 2018, at 10:03 AM, Harry Schmalzbauer = wrote: >>>=20 >>> Am 11.06.2018 um 20:28 schrieb Harry Schmalzbauer: >>>> Am 05.06.2018 um 19:54 schrieb Scott Long: >>>> =E2=80=A6 >>>>>>>> Late in the 11.2 phase, I identified this commit as a = regression for MSI (non-x) alloctaion. >>>>>>>> I have an idea what probably causes the problem here (INTx = allocation, although MSI (and MSI-x) capability): >>>>>>>> disable_msix is not 0 (I need to disable MSI-x because of = ESXi-passthru=E2=80=A6). >>>>>>>>=20 >>>>>>>> Corresponding lines: >>>>>>>> { >>>>>>>> device_t dev; >>>>>>>> int error, msgs; >>>>>>>>=20 >>>>>>>> dev =3D sc->mps_dev; >>>>>>>> error =3D 0; >>>>>>>> msgs =3D 0; >>>>>>>>=20 >>>>>>>> if ((sc->disable_msix =3D=3D 0) && >>>>>>>> ((msgs =3D pci_msix_count(dev)) >=3D = MPS_MSI_COUNT)) >>>>>>>> error =3D mps_alloc_msix(sc, MPS_MSI_COUNT); >>>>>>>> if ((error !=3D 0) && (sc->disable_msi =3D=3D 0) && >>>>>>>> ((msgs =3D pci_msi_count(dev)) >=3D = MPS_MSI_COUNT)) >>>>>>>> error =3D mps_alloc_msi(sc, MPS_MSI_COUNT); >>>>>>>> if (error !=3D 0) >>>>>>>> msgs =3D 0; >>>>>>>>=20 >>>>>>>> sc->msi_msgs =3D msgs; >>>>>>>> return (error); >>>>>>>> } >>>>>>>>=20 >>> =E2=80=A6 >>>>>>> Hi Harry, >>>>>>> You are correct about the bug. Please change the line at the = top of the function that reads >>>>>>> error =3D 0; >>>>>>> to >>>>>>> error =3D ENXIO; >>>>>>> Let me know if that fixes the MSI problem for you. >>>>=20 >>>> =E2=80=A6 >>>>=20 >>> =E2=80=A6 >>>> Index: src/sys/dev/mps/mps_pci.c >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>> --- sys/dev/mps/mps_pci.c (Revision 334948) >>>> +++ sys/dev/mps/mps_pci.c (Arbeitskopie) >>>> @@ -244,7 +244,7 @@ >>>> int error, msgs; >>>>=20 >>>> dev =3D sc->mps_dev; >>>> - error =3D 0; >>>> + error =3D ENXIO; >>>> msgs =3D 0; >>>>=20 >>>> if ((sc->disable_msix =3D=3D 0) && >>>>=20 >>>=20 >>> To my understanding, it's obvious that the way = mps_pci_alloc_interrupts() currently works is unintended. >>> This might not affect too many people, but is there a reason not to = fix it? >>>=20 >>> I already created a coresponding problem report: = https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D229267 >>> Anything else I should do? >>>=20 >> Hi Harry, >> Sorry for ignoring this for so long. I=E2=80=99m going to commit a = fix today, but it won=E2=80=99t be the same one-line change. >> Upon reviewing the code, I=E2=80=99d going to refactor it so it=E2=80=99= s not so confusing and prone to these kinds of mistakes. >> Thank you for the continued reminders to finish this. >=20 > Hi Scott, >=20 > thanks a lot, in fact I'm not surprised that you come up with a better = solution than that quick fix :-) > Had hoped someone else would do an intermediate commit to get it into = 12.0 in time, so you won't feel any time pressure - good job needs the = time it needs, as long as the right person is doing the job. >=20 > Unfortunately I don't have a non-productive setup where I could test = before release/12.0 will be branched =E2=80=93 might be subject to = change... 12.0 has completely different code from 11.x, and from my review of it = last night it should be fine. If you have evidence that what=E2=80=99s = currently in 12 is not working, please let me know ASAP. Scott From owner-freebsd-scsi@freebsd.org Tue Nov 13 19:07:06 2018 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 019F4112E2C1 for ; Tue, 13 Nov 2018 19:07:06 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 66977733C8 for ; Tue, 13 Nov 2018 19:07:05 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: by mailman.ysv.freebsd.org (Postfix) id 27BCA112E2BE; Tue, 13 Nov 2018 19:07:05 +0000 (UTC) Delivered-To: scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E1688112E2BD; Tue, 13 Nov 2018 19:07:04 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 982C4733C7; Tue, 13 Nov 2018 19:07:03 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (mh0.gentlemail.de [78.138.80.135]) by mx0.gentlemail.de (8.14.5/8.14.5) with ESMTP id wADJ712E088446; Tue, 13 Nov 2018 20:07:01 +0100 (CET) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (s1.omnilan.de [217.91.127.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id 437597F7; Tue, 13 Nov 2018 20:07:01 +0100 (CET) Subject: Re: MSI allocation regression, still to be corrected in HEAD and please MFC before release/12.0 gets branched To: Scott Long Cc: scsi@freebsd.org, freebsd-stable References: <201707300653.v6U6rwLN099096@repo.freebsd.org> <597DA578.6030101@omnilan.de> <597F56A8.1060603@omnilan.de> <59804C8C.1020003@omnilan.de> <78611650-D7A4-4B1D-A254-DB058E1AC1C6@samsco.org> <6e1e5f9f-4ece-dc9d-b059-08d52c9e6965@omnilan.de> <042090da-f73f-ce80-517c-0b1729d3d6e1@omnilan.de> <05D94EC4-D797-4246-96B5-6DC1494E7EA9@samsco.org> <34515651-9883-4490-A3EE-7206AE973757@samsco.org> From: Harry Schmalzbauer Organization: OmniLAN Message-ID: <0a8ea65b-f408-05f1-c45d-31ae5e0eb902@omnilan.de> Date: Tue, 13 Nov 2018 20:07:00 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <34515651-9883-4490-A3EE-7206AE973757@samsco.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: ACL 130 matched, not delayed by milter-greylist-4.2.7 (mx0.gentlemail.de [78.138.80.130]); Tue, 13 Nov 2018 20:07:02 +0100 (CET) X-Milter: Spamilter (Reciever: mx0.gentlemail.de; Sender-ip: 78.138.80.135; Sender-helo: mh0.gentlemail.de; ) X-Rspamd-Queue-Id: 66977733C8 X-Spamd-Result: default: False [-7.08 / 200.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+a:mx2.freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[omnilan.de]; TO_DN_SOME(0.00)[]; HAS_ORG_HEADER(0.00)[]; RCVD_IN_DNSWL_MED(-0.20)[5.0.0.0.0.5.0.0.0.0.0.0.0.0.0.0.a.6.0.2.4.5.2.2.0.0.9.1.1.0.0.2.list.dnswl.org : 127.0.9.2]; MX_GOOD(-0.01)[cached: mx0.gentlemail.de]; NEURAL_HAM_SHORT(-0.97)[-0.972,0]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; IP_SCORE(-3.69)[ip: (-9.86), ipnet: 2001:1900:2254::/48(-4.79), asn: 10310(-3.73), country: US(-0.09)]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; FORGED_RECIPIENTS(0.00)[scottl@samsco.org ..,freebsd-scsi@freebsd.org]; MID_RHS_MATCH_FROM(0.00)[] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 19:07:06 -0000 Am 13.11.2018 um 19:45 schrieb Scott Long: > > >> On Nov 13, 2018, at 11:11 AM, Harry Schmalzbauer wrote: >> >> Am 13.11.2018 um 19:02 schrieb Scott Long: >>>> On Nov 12, 2018, at 10:03 AM, Harry Schmalzbauer wrote: >>>> >>>> Am 11.06.2018 um 20:28 schrieb Harry Schmalzbauer: >>>>> Am 05.06.2018 um 19:54 schrieb Scott Long: >>>>> … >>>>>>>>> Late in the 11.2 phase, I identified this commit as a regression for MSI (non-x) alloctaion. … >> >> thanks a lot, in fact I'm not surprised that you come up with a better solution than that quick fix :-) >> Had hoped someone else would do an intermediate commit to get it into 12.0 in time, so you won't feel any time pressure - good job needs the time it needs, as long as the right person is doing the job. >> >> Unfortunately I don't have a non-productive setup where I could test before release/12.0 will be branched – might be subject to change... > > 12.0 has completely different code from 11.x, and from my review of it last night it should be fine. If you have evidence that what’s currently in 12 is not working, please let me know ASAP. Sorry for the confusion, I missed that. I just verified that I do apply the patch (without errors) to local stable/12 source tree for local releases... That's probably a mistake. I can't remember if I ever checked whether stable/12 (for sure not stable/12, but -current back then) MSI fallback allocation does work without the patch or not. Like metioned, I don't have a non-productive machine of that kind for testing, but it's superfluous anyways if you know that code paths differ in that part. Please ignore my 12.0 referings, sorry. -harry From owner-freebsd-scsi@freebsd.org Thu Nov 15 00:45:05 2018 Return-Path: Delivered-To: freebsd-scsi@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 473C11105EF3 for ; Thu, 15 Nov 2018 00:45:05 +0000 (UTC) (envelope-from aklassen@nectarcorp.com) Received: from us-smtp-delivery-212.mimecast.com (us-smtp-delivery-212.mimecast.com [216.205.24.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "*.mimecast.com", Issuer "DigiCert Global CA G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 00FE476A4A for ; Thu, 15 Nov 2018 00:45:03 +0000 (UTC) (envelope-from aklassen@nectarcorp.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nectarcorp.com; s=mimecast; t=1542242703; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references; bh=FPXZJboDF/3QDh9hZthdwXxPugpM6F8JDugXvzSUQ24=; b=h9ahqArho9QyqRYpdpZEux0ZJfWL0O4P4nnK4tlIq+uO0Ofw0d/9ffX2f0wN0C6YQRq9COZX18KgnAGjqB4pmwluSizLUESMu2FKLR9qpBBchSMA8uMClwBTrvVY28OjW+XwWwEfXJk/a4n8eKhYvVhzW6zEAq5gzCdl5U1oNog= Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02lp0022.outbound.protection.outlook.com [216.32.180.22]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-55-dx0YtiJNO22pCdRfjVZVwg-1; Wed, 14 Nov 2018 19:44:59 -0500 Received: from BYAPR02MB5576.namprd02.prod.outlook.com (20.177.230.86) by BYAPR02MB4087.namprd02.prod.outlook.com (20.176.249.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.26; Thu, 15 Nov 2018 00:44:56 +0000 Received: from BYAPR02MB5576.namprd02.prod.outlook.com ([fe80::915b:e376:6c59:da9e]) by BYAPR02MB5576.namprd02.prod.outlook.com ([fe80::915b:e376:6c59:da9e%5]) with mapi id 15.20.1273.027; Thu, 15 Nov 2018 00:44:56 +0000 From: Andrew Klassen To: "freebsd-scsi@freebsd.org" Subject: Re: Driver support for Dell PERC H740p adapter Thread-Topic: Re: Driver support for Dell PERC H740p adapter Thread-Index: AdR8d6n4ZuPThG9aR8O7APhdEuZVoQ== Date: Thu, 15 Nov 2018 00:44:56 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [209.48.211.146] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BYAPR02MB4087; 6:iaC9F9z/j/9wYhdUJa46RgiMaoMN8NsXonOXOAtyxf0SVVtRfqjAbTPfVnkSf/ljFouWre2aGUzObm3zqbE+7HJMhkchZXN4vAOgCDWNgUI5Ct3TAGTsbCK0nW6oLJ1hgV5wHumqcjZkAroFPAsi4W2BoWH5wXeU1vL+/r94YAb1PcxMfjPxcD7IDGakHKsS2ChNuuhGm+f/okasKeJc5YUMAFTsqvdLxpf8CFjTZP1szDU7Bko64OxFLf60k6vAx10GawDq2syEldQGP1JFExJPoYnx6rSjcwnIziM+B0WXyRqGFH5UVgJloEdxKuqAKOBq7LSbgDgGj9qdiD3U56zav9m1f0Ajx/1GIDcpejpfHxTDyv8Vc2oelx6Ou+0Zt4cfkI9xe10c6OO8e+OCf7A+jL4pO21EilmVvayo0PedAHEq67UP1pMSLB2DIDnML36M7rny653HASGG2YPLQQ==; 5:ocD8BOdJTqq0yX9MzlR9f5r8WHv/9+RC+6zUaUTnTpBNjFBWtGFZT9bQuHCEm7E/wN2rffvdjJBRVb+YumkQ+qo3X+R8w587pzlFyyXSLtgajBS3l3cVUX1EyHWzMxaHxpuc+sLAZ9ix3KeVZua+PQmERcDwDoBGuchwYxmakhU=; 7:8dmOWbfZ0LLPVdeOJgbNm94tOIy7UJOttP976NvldpLTDPopZfAkKJHU2rw9+c2qjApjzhQX9134JOiCeR7GYxAa3Xa5SfyFfbClpcO0PJka2f+I2vguNpTob2MiNHqfGuREAUkq1QDUZDC0H5L7GA== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: d5739e9d-d949-463e-396e-08d64a9390a5 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(7021145)(8989299)(5600074)(711020)(4534185)(7022145)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(2017052603328)(7153060)(7193020); SRVR:BYAPR02MB4087; x-ms-traffictypediagnostic: BYAPR02MB4087: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(21748063052155)(28532068793085)(190501279198761)(227612066756510); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231415)(944501410)(52105112)(148016)(149066)(150057)(6041310)(2016111802025)(20161123562045)(20161123564045)(20161123560045)(20161123558120)(6043046)(201708071742011)(7699051)(76991095); SRVR:BYAPR02MB4087; BCL:0; PCL:0; RULEID:; SRVR:BYAPR02MB4087; x-forefront-prvs: 08572BD77F x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39840400004)(396003)(366004)(376002)(136003)(346002)(40764003)(38564003)(189003)(199004)(33656002)(97736004)(74316002)(790700001)(3846002)(6116002)(2900100001)(102836004)(68736007)(81156014)(6916009)(14454004)(8936002)(508600001)(229853002)(81166006)(8676002)(105586002)(2351001)(106356001)(25786009)(86362001)(345774005)(6436002)(476003)(316002)(55016002)(9686003)(54896002)(99286004)(5660300001)(6306002)(53936002)(5640700003)(486006)(7736002)(2501003)(66066001)(186003)(5024004)(14444005)(2906002)(26005)(71190400001)(7696005)(71200400001)(6246003)(6506007)(256004); DIR:OUT; SFP:1102; SCL:1; SRVR:BYAPR02MB4087; H:BYAPR02MB5576.namprd02.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-microsoft-antispam-message-info: eXAP6L3L8mxWXHpdJHyzb+HJEMVaRUOTKF6aXk+42g2Qh+yzoosMrSIRrI5jrpp0hWTVFBkPxOxyJoMazzka0ZNaXhtnwSc47uk4MqibiJuirfDMbyvPeBA6tGMJmFHnwk8wx2lnSwFyC10kd8jpyvbz3Csrr4puoBmQM+dkWM38OYyooLKZcbp3LnOdq4P4V46mWtPrCjW+P2HmbbJtpNz686PqNelC7M/ds5LjBu9cTtuat858G84B2t9t/+xlsH6lSxlwqJ4UGt7jrOqaT8+zCSjmHcDugVTiFoexISVbVdJSPe8SX+tT6WCoa8hxmXk9ClNMqwZkqWpzG+5tJnFL5rXJ+8Hu07s8asnwabs= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nectarcorp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5739e9d-d949-463e-396e-08d64a9390a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2018 00:44:56.5788 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 11a6e6d0-8549-43dc-8cd3-6cf1e94d71f0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB4087 X-MC-Unique: dx0YtiJNO22pCdRfjVZVwg-1 X-Rspamd-Queue-Id: 00FE476A4A X-Spamd-Result: default: False [-1.65 / 200.00]; ARC_NA(0.00)[]; FAKE_REPLY(1.00)[]; R_DKIM_ALLOW(-0.20)[nectarcorp.com]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:216.205.24.0/24]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[nectarcorp.com]; NEURAL_HAM_LONG(-0.88)[-0.877,0]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[4]; NEURAL_HAM_MEDIUM(-0.88)[-0.883,0]; MX_GOOD(-0.01)[cached: us-smtp-inbound-1.mimecast.com]; DKIM_TRACE(0.00)[nectarcorp.com:+]; NEURAL_HAM_SHORT(-0.06)[-0.061,0]; TO_DN_EQ_ADDR_ALL(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[212.24.205.216.list.dnswl.org : 127.0.3.1]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:30031, ipnet:216.205.24.0/24, country:US]; IP_SCORE(-0.22)[asn: 30031(-0.99), country: US(-0.10)] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2018 00:45:05 -0000 I would like to build a kernel with the updated mrsas driver as well. I am = currently running FreeBSD 10.3. While reading through the FreeBSDInstallation_LSIDriver.txt file it says th= at I need to consider the mfi driver. In my case, I need to have an mfi driver. The notes say to upgrade to mfi 4= .8 or newer. I apologize for not being able to figure this out on my own, but where do I get an updated mfi driver= . Do I just use a FreeBSD 11.x version or I should I download the driver from somewhere else? Thank you for your help. Andrew DISCLAIMER: CONFIDENTIALITY NOTICE: This e-mail message, and any documents,= files, or previous e-mail messages attached to it, may contain information= that is confidential, proprietary, and/or legally privileged. If the reade= r of this e-mail message is neither the intended recipient nor an employee = or an agent responsible for delivering this e-mail message to the intended = recipient, you are hereby notified that any unauthorized review, use, discl= osure, or distribution of this communication is strictly prohibited. Disclo= sing this e-mail message, or any document, file or previous e-mail message = attached to it to anyone other than the intended recipient may cause the br= eaching party to be liable to Nectar Services Corp. for damages. If you hav= e received this communication in error, please notify the sender by replyin= g to the e-mail message and delete it from your computer, without saving it= in any manner.