From owner-freebsd-stable@freebsd.org Sun Jul 1 08:48:11 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5745BFE6303 for ; Sun, 1 Jul 2018 08:48:11 +0000 (UTC) (envelope-from ht7261@ot.x0.to) Received: from www1607.sakura.ne.jp (www1607.sakura.ne.jp [219.94.192.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A40268670A for ; Sun, 1 Jul 2018 08:48:10 +0000 (UTC) (envelope-from ht7261@ot.x0.to) Received: from fsav303.sakura.ne.jp (fsav303.sakura.ne.jp [153.120.85.134]) by www1607.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id w617r4kh092251; Sun, 1 Jul 2018 16:53:04 +0900 (JST) (envelope-from ht7261@ot.x0.to) Received: from www1607.sakura.ne.jp (219.94.192.17) by fsav303.sakura.ne.jp (F-Secure/fsigk_smtp/530/fsav303.sakura.ne.jp); Sun, 01 Jul 2018 16:53:04 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/530/fsav303.sakura.ne.jp) Received: from www1607.sakura.ne.jp (localhost [127.0.0.1]) by www1607.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id w617r3FB092243; Sun, 1 Jul 2018 16:53:03 +0900 (JST) (envelope-from ht7261@ot.x0.to) Received: (from amuletic@localhost) by www1607.sakura.ne.jp (8.15.2/8.15.2/Submit) id w617r38G092240; Sun, 1 Jul 2018 16:53:03 +0900 (JST) (envelope-from ht7261@ot.x0.to) Message-Id: <201807010753.w617r38G092240@www1607.sakura.ne.jp> X-Authentication-Warning: www1607.sakura.ne.jp: amuletic set sender to ht7261@ot.x0.to using -f Subject: zfs rootfs mount failure after upgrade to 11.2R from 11.1R-p10 From: ht7261@ot.x0.to To: freebsd-stable@freebsd.org MIME-Version: 1.0 Date: Sun, 01 Jul 2018 16:53:03 +0900 Content-Type: text/plain; charset="ISO-2022-JP" Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jul 2018 08:48:11 -0000 Hello, zfs rootfs mount fails for me after an upgrade from 11.1R-p10 to the recent 11.2R. I upgraded my amd64 11.1R-p10 system to 11.2R using "freebsd-update upgrade". On the first reboot after the first "freebsd-update install", the system fails when the new kernel is about to mount its root filesystem. -------------------- : FreeBSD 11.2-RELEASE #0 r335510: Fri Jun 22 04:32:14 UTC 2018 root@releng2.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64 : : ukbd0 on uhub1 ukbd0: on usbus0 kbd2 at ukbd0 Mounting from zfs:zpool1/ROOT/default failed with error 6; retrying for 3 more seconds Mounting from zfs:zpool1/ROOT/default failed with error 6. Loader variables: vfs.root.mountfrom=zfs:zpool1/ROOT/default : : mountroot> ? List of GEOM managed disk devices: gpt/zfs0 msdosfs/EFI gpt/swap0 msdosfs/EFISYS gpt/EFI nvd0p3 nvd0p2 nvd0p1 cd0 nvd0 mountroot> -------------------- If I choose 'kernel.old' at the Beastie menu, the system boots the previous 11.1-p10 fine. (This was also updated from previous 11.1-pX by freebsd-update.) Below is the case for single user mode boot that I tried AFTER the above mentioned error. -------------------- : FreeBSD 11.1-RELEASE-p10 #0 Tue May 8 05:21:56 UTC 2018 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64 : : ukbd0 on uhub1 ukbd0: on usbus0 kbd2 at ukbd0 Enter full pathname of shell or RETRUN for /bin/sh: Cannot read termcap database; using dumb terminal settings. # mount zpool1/ROOT/default on / (zfs, local, noatime, read-only, nfsv4acls) devfs on /dev (devfs, local, multilabel) # zpool status pool: zpool1 state: ONLINE scan: scrub repaired 0 in (..snip..) config: NAME STATE READ WRITE CKSUM zpool1 ONLINE 0 0 0 nvd0p3 ONLINE 0 0 0 errors: No known data errors # gpart show => 40 500118112 nvd0 GPT (238G) 40 1600 1 efi (800K) 1640 480 - free - (204K) 2048 134217728 2 freebsd-swap (64G) 134219776 365897728 3 freebsd-zfs (174G) 500117504 648 - free - (324K) -------------------- No hardware configuration nor BIOS/UEFI settings were touched in between the two cases. Were there anything that might have caused this problem between 11.1 and 11.2? This is an UEFI-only setup with NVMe SSD configured for root-on-zfs, zfs-only boot. and it is an 'Intel Core i5-7600T @ 2.00GHz' system on 'ASRock H270 Pro4' M/B with 64GB RAM, and 'PM951 NVMe SAMSUNG 256GB' NVMe-SSD, in case if it matters. I am going to create another filesystem on this pool, set it as bootfs in zpool property, and install a pristine OS there to see what happens. In the meantime, am I safe to run: # freebsd-upgrade rollback while the system is up in kernel.old (11.1p10) mode, to get my system back to boot 11.1p10 by default? Thank you in advance. Hiroharu From owner-freebsd-stable@freebsd.org Sun Jul 1 10:13:49 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 14A5BFEECBD for ; Sun, 1 Jul 2018 10:13:49 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from constantine.ingresso.co.uk (unknown [IPv6:2a02:b90:3002:411::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A3A2B89A69 for ; Sun, 1 Jul 2018 10:13:48 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from [2a02:b90:3002:411::6] (helo=dilbert.ingresso.co.uk) by constantine.ingresso.co.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89 (FreeBSD)) (envelope-from ) id 1fZZMW-000HWY-F4; Sun, 01 Jul 2018 10:13:44 +0000 Received: from petefrench by dilbert.ingresso.co.uk with local (Exim 4.91 (FreeBSD)) (envelope-from ) id 1fZZMW-0001Es-CH; Sun, 01 Jul 2018 11:13:44 +0100 To: cpghost@cordula.ws, freebsd-stable@freebsd.org Subject: Re: Ryzen issues on FreeBSD ? (with sort of workaround) Cc: kostikbel@gmail.com In-Reply-To: <70feb5c9-4755-ebe7-f802-c36ea21288e4@cordula.ws> Message-Id: From: Pete French Date: Sun, 01 Jul 2018 11:13:44 +0100 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jul 2018 10:13:49 -0000 > % sudo x86info -a | grep Microcode > Microcode patch level: 0x8001136 > > Without that script, the system would lockup up to 5-6 times a day. > Now running without any lockup at all for 3 days, with all kinds > of workload from idle to torture tests. Too early to tell, but it > looks good for now. This is interseting to me because (as per previous emial) I have tried *without* the script, and it seems stable to me with that too! root@dilbert:/home/petefrench # x86info -a | grep Microcode Microcode patch level: 0x8001137 So, I am running a slightly later microcode than you are - want to give that a try without the atch maybe ? Though I see its going into the kernel which makes me very happy, as I prefer stability over pretty much anything else on my machines :-) -pete. From owner-freebsd-stable@freebsd.org Sun Jul 1 10:15:59 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 21CA5FEEF76 for ; Sun, 1 Jul 2018 10:15:59 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from constantine.ingresso.co.uk (unknown [IPv6:2a02:b90:3002:411::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AA9E689AC4; Sun, 1 Jul 2018 10:15:58 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from [2a02:b90:3002:411::6] (helo=dilbert.ingresso.co.uk) by constantine.ingresso.co.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89 (FreeBSD)) (envelope-from ) id 1fZZOe-000HY4-KO; Sun, 01 Jul 2018 10:15:56 +0000 Received: from petefrench by dilbert.ingresso.co.uk with local (Exim 4.91 (FreeBSD)) (envelope-from ) id 1fZZOe-0001FU-I7; Sun, 01 Jul 2018 11:15:56 +0100 To: kostikbel@gmail.com, petefrench@ingresso.co.uk Subject: Re: Ryzen issues on FreeBSD ? (with sort of workaround) Cc: avg@freebsd.org, eric@vangyzen.net, freebsd-stable@freebsd.org, freebsd@hda3.com, mike@sentex.net, truckman@FreeBSD.org In-Reply-To: <20180630165508.GT2430@kib.kiev.ua> Message-Id: From: Pete French Date: Sun, 01 Jul 2018 11:15:56 +0100 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jul 2018 10:15:59 -0000 > This should be the kernel patch equivalent to the script. Ah, thankyou. I shall give this a try on tuesday when I am physically back in front of the machine. I have been trying without the oath as you asked by the way, and with the latest microcode update (0x8001137) it also seems stable, without these tweaks. But I havent stressed it too much - if the errata says to set the bits then we should set the bits. > According to the revision document, some of the erratas are applicable > to the Ryzen 2, but I do not want to do the bit tweaking without a > confirmation. I was wndeting about that - but I dont have a Ryzen 2 to hand to test with unfortunately. Will let you know how the patch goes next week, thanks, -pete. From owner-freebsd-stable@freebsd.org Sun Jul 1 10:55:53 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EFC4BFF29E1 for ; Sun, 1 Jul 2018 10:55:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6A4448B0F4; Sun, 1 Jul 2018 10:55:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w61Ate2D034112 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 1 Jul 2018 13:55:43 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w61Ate2D034112 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w61Ate2m034111; Sun, 1 Jul 2018 13:55:40 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 1 Jul 2018 13:55:40 +0300 From: Konstantin Belousov To: Pete French Cc: avg@freebsd.org, eric@vangyzen.net, freebsd-stable@freebsd.org, freebsd@hda3.com, mike@sentex.net, truckman@FreeBSD.org Subject: Re: Ryzen issues on FreeBSD ? (with sort of workaround) Message-ID: <20180701105540.GX2430@kib.kiev.ua> References: <20180630165508.GT2430@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jul 2018 10:55:53 -0000 On Sun, Jul 01, 2018 at 11:15:56AM +0100, Pete French wrote: > > This should be the kernel patch equivalent to the script. > > Ah, thankyou. I shall give this a try on tuesday when I am > physically back in front of the machine. I have been trying without > the oath as you asked by the way, and with the latest microcode > update (0x8001137) it also seems stable, without these tweaks. But I > havent stressed it too much - if the errata says to set the bits then > we should set the bits. It is very likely that the latest microcode sets the chicken bits for the known erratas already. AFAIK, this is the best that a ucode update can typically do anyway. From owner-freebsd-stable@freebsd.org Sun Jul 1 21:00:44 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2479FFDBD53 for ; Sun, 1 Jul 2018 21:00:44 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 3F9A67DCC2 for ; Sun, 1 Jul 2018 21:00:43 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 00762FDBD37; Sun, 1 Jul 2018 21:00:43 +0000 (UTC) Delivered-To: stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D3185FDBD35 for ; Sun, 1 Jul 2018 21:00:42 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5A5767DCB7 for ; Sun, 1 Jul 2018 21:00:42 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 997D9219D8 for ; Sun, 1 Jul 2018 21:00:41 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w61L0fM2012908 for ; Sun, 1 Jul 2018 21:00:41 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w61L0fNs012899 for stable@FreeBSD.org; Sun, 1 Jul 2018 21:00:41 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <201807012100.w61L0fNs012899@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: stable@FreeBSD.org Subject: Problem reports for stable@FreeBSD.org that need special attention Date: Sun, 1 Jul 2018 21:00:41 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jul 2018 21:00:46 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- Open | 227213 | FreeBSD 10.4 kernel deadlocks on sysctlmemlock 1 problems total for which you should take action. From owner-freebsd-stable@freebsd.org Tue Jul 3 09:27:11 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 812E1102E2E4 for ; Tue, 3 Jul 2018 09:27:11 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from constantine.ingresso.co.uk (unknown [IPv6:2a02:b90:3002:411::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1CCA07642A; Tue, 3 Jul 2018 09:27:11 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from dilbert.london-internal.ingresso.co.uk ([10.64.50.6]) by constantine.ingresso.co.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89 (FreeBSD)) (envelope-from ) id 1faHaU-0002NP-Eo; Tue, 03 Jul 2018 09:27:06 +0000 Subject: Re: Ryzen issues on FreeBSD ? (with sort of workaround) To: Konstantin Belousov Cc: avg@freebsd.org, eric@vangyzen.net, freebsd-stable@freebsd.org, freebsd@hda3.com, mike@sentex.net, truckman@FreeBSD.org References: <20180630165508.GT2430@kib.kiev.ua> <20180701105540.GX2430@kib.kiev.ua> From: Pete French Message-ID: Date: Tue, 3 Jul 2018 10:27:06 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180701105540.GX2430@kib.kiev.ua> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 09:27:11 -0000 > It is very likely that the latest microcode sets the chicken bits for the > known erratas already. AFAIK, this is the best that a ucode update > can typically do anyway. > I just did some testing - it does do these bits: cpucontrol -m '0xc0011029|=0x2000' $x cpucontrol -m '0xc0011020|=0x10' $x but it does not do these bits: cpucontrol -m '0xc0011028|=0x10' $x cpucontrol -m '0xc0011020|=0x200000000000000' $x (though someone else might want to doubel check that as I may have miscounted the bits!) am going to trey your patch today -pete. From owner-freebsd-stable@freebsd.org Tue Jul 3 10:09:25 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2AAA21031C06 for ; Tue, 3 Jul 2018 10:09:25 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 94BF278726; Tue, 3 Jul 2018 10:09:24 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w63A9FZV075316 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 3 Jul 2018 13:09:18 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w63A9FZV075316 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w63A9Fst075315; Tue, 3 Jul 2018 13:09:15 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Tue, 3 Jul 2018 13:09:15 +0300 From: Konstantin Belousov To: Pete French Cc: avg@freebsd.org, eric@vangyzen.net, freebsd-stable@freebsd.org, freebsd@hda3.com, mike@sentex.net, truckman@FreeBSD.org Subject: Re: Ryzen issues on FreeBSD ? (with sort of workaround) Message-ID: <20180703100914.GC2430@kib.kiev.ua> References: <20180630165508.GT2430@kib.kiev.ua> <20180701105540.GX2430@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 10:09:25 -0000 On Tue, Jul 03, 2018 at 10:27:06AM +0100, Pete French wrote: > > > It is very likely that the latest microcode sets the chicken bits for the > > known erratas already. AFAIK, this is the best that a ucode update > > can typically do anyway. > > > > I just did some testing - it does do these bits: By 'it' you mean the microcode update/BIOS on your board ? > > > cpucontrol -m '0xc0011029|=0x2000' $x > cpucontrol -m '0xc0011020|=0x10' $x > > but it does not do these bits: > > cpucontrol -m '0xc0011028|=0x10' $x > cpucontrol -m '0xc0011020|=0x200000000000000' $x > > (though someone else might want to doubel check that as I may have > miscounted the bits!) > > am going to trey your patch today > > -pete. From owner-freebsd-stable@freebsd.org Tue Jul 3 12:06:19 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 70078103CEDB for ; Tue, 3 Jul 2018 12:06:19 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from constantine.ingresso.co.uk (unknown [IPv6:2a02:b90:3002:411::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0AAB57D478; Tue, 3 Jul 2018 12:06:18 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from dilbert.london-internal.ingresso.co.uk ([10.64.50.6]) by constantine.ingresso.co.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89 (FreeBSD)) (envelope-from ) id 1faK4W-0004TZ-OJ; Tue, 03 Jul 2018 12:06:16 +0000 Subject: Re: Ryzen issues on FreeBSD ? (with sort of workaround) To: Konstantin Belousov Cc: avg@freebsd.org, eric@vangyzen.net, freebsd-stable@freebsd.org, freebsd@hda3.com, mike@sentex.net, truckman@FreeBSD.org References: <20180630165508.GT2430@kib.kiev.ua> <20180701105540.GX2430@kib.kiev.ua> <20180703100914.GC2430@kib.kiev.ua> From: Pete French Message-ID: <343bb693-850b-92b0-9749-5c722b90f817@ingresso.co.uk> Date: Tue, 3 Jul 2018 13:06:16 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180703100914.GC2430@kib.kiev.ua> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 12:06:19 -0000 On 03/07/2018 11:09, Konstantin Belousov wrote: > On Tue, Jul 03, 2018 at 10:27:06AM +0100, Pete French wrote: >> >>> It is very likely that the latest microcode sets the chicken bits for the >>> known erratas already. AFAIK, this is the best that a ucode update >>> can typically do anyway. >>> >> >> I just did some testing - it does do these bits: > By 'it' you mean the microcode update/BIOS on your board ? Yes, sorry. As I was testing without the patch I looked to see what the values were that it had set. I may have got my hex wrong on the last two though I have to say - it may be setting all four bits. -pete. From owner-freebsd-stable@freebsd.org Tue Jul 3 16:40:49 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 31C051030092 for ; Tue, 3 Jul 2018 16:40:49 +0000 (UTC) (envelope-from bounce@ims9.isendservice.com.br) Received: from ims9.isendservice.com.br (ims9.isendservice.com.br [54.232.186.15]) by mx1.freebsd.org (Postfix) with ESMTP id 8B3FA8AF16 for ; Tue, 3 Jul 2018 16:40:48 +0000 (UTC) (envelope-from bounce@ims9.isendservice.com.br) Received: from localhost (localhost [127.0.0.1]) by ims9.isendservice.com.br (Postfix) with ESMTP id 44F774210B for ; Tue, 3 Jul 2018 13:38:21 -0300 (BRT) Date: Tue, 3 Jul 2018 13:38:21 -0300 (BRT) From: SENAI | FATEC - Faculdade SENAI Reply-To: posgraduacao@senairs.org.br To: freebsd-stable@freebsd.org Message-ID: <636101638.169441.1530635901081.JavaMail.root@ims9> Subject: =?ISO-8859-1?Q?P=F3s-Gradua=E7=E3o_SENAI_|_FATEC?= =?ISO-8859-1?Q?_-_MBA_em_Gest=E3o_de_Projetos?= bounce-key: <2420-22522874-2174893> MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 16:40:49 -0000 From owner-freebsd-stable@freebsd.org Tue Jul 3 19:19:47 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E4AB3103F769 for ; Tue, 3 Jul 2018 19:19:46 +0000 (UTC) (envelope-from mike@sentex.net) Received: from smarthost2.sentex.ca (smarthost2.sentex.ca [IPv6:2607:f3e0:80:80::2]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "smarthost.sentex.ca", Issuer "smarthost.sentex.ca" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 7DB9993459 for ; Tue, 3 Jul 2018 19:19:46 +0000 (UTC) (envelope-from mike@sentex.net) Received: from lava.sentex.ca (lava.sentex.ca [IPv6:2607:f3e0:0:5::11]) by smarthost2.sentex.ca (8.15.2/8.15.2) with ESMTPS id w63JJigN021366 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO) for ; Tue, 3 Jul 2018 15:19:45 -0400 (EDT) (envelope-from mike@sentex.net) Received: from [192.168.43.26] (saphire3.sentex.net [192.168.43.26]) by lava.sentex.ca (8.15.2/8.15.2) with ESMTP id w63JJh4N028142 for ; Tue, 3 Jul 2018 15:19:43 -0400 (EDT) (envelope-from mike@sentex.net) To: FreeBSD-STABLE Mailing List From: Mike Tancsa Subject: ZFS destroy caused panic ? 11.2 (r335771) Openpgp: preference=signencrypt Autocrypt: addr=mike@sentex.net; prefer-encrypt=mutual; keydata= xsBNBEzcA24BCACpwI/iqOrs0GfQSfhA1v6Z8AcXVeGsRyKEKUpxoOYxXWc2z3vndbYlIP6E YJeifzKhS/9E+VjhhICaepLHfw865TDTUPr5D0Ed+edSsKjlnDtb6hfNJC00P7eoiuvi85TW F/gAxRY269A5d856bYrzLbkWp2lKUR3Bg6NnORtflGzx9ZWAltZbjYjjRqegPv0EQNYcHqWo eRpXilEo1ahT6nmOU8V7yEvT2j4wlLcQ6qg7w+N/vcBvyd/weiwHU+vTQ9mT61x5/wUrQhdw 2gJHeQXeDGMJV49RT2EEz+QVxaf477eyWsdQzPVjAKRMT3BVdK8WvpYAEfBAbXmkboOxABEB AAHNHG1pa2UgdGFuY3NhIDxtaWtlQHNlbnRleC5jYT7CwHgEEwECACIFAkzcA24CGwMGCwkI BwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEJXHwM2kc8rX+sMH/2V6pTBKsQ5mpWWLgs6wVP2k BC+6r/YKNXv9Rw/PrC6+9hTbgA+sSjJ+8gxsCbJsOQXZrxF0x3l9oYdYfuKcwdwXFX1/FS8p HfBeDkmlH+dI709xT9wgrR4dS5aMmKp0scPrXPIAKiYVOHjOlNItcLYTEEWEFBepheEVsgmk GrNbcrHwOx/u4igUQ8vcpyXPyUki+BsftPw8ZQvBU887igh0OxaCR8AurJppQ5UQd63r81cX E1ZjoFoWCaGK/SjPb/OhpYpu5swoZIhOxQbn7OtakYPsDd5t2A5KhvjI8BMTnd5Go+2xsCmr jlIEq8Bi29gCcfQUvNiClevi13ifmnnOwE0ETNwDbgEIALWGNJHRAhpd0A4vtd3G0oRqMBcM FGThQr3qORmEBTPPEomTdBaHcn+Xl+3YUvTBD/67/mutWBwgp2R5gQOSqcM7axvgMSHbKqBL 9sd1LsLw0UT2O5AYxv3EwzhG84pwRg3XcUqvWA4lA8tIj/1q4Jzi5qOkg1zxq4W9qr9oiYK5 bBR638JUvr3eHMaz/Nz+sDVFgwHmXZj3M6aE5Ce9reCGbvrae7H5D5PPvtT3r22X8SqfVAiO TFKedCf/6jbSOedPN931FJQYopj9P6b3m0nI3ZiCDVSqeyOAIBLzm+RBUIU3brzoxDhYR8pz CJc2sK8l6YjqivPakrD86bFDff8AEQEAAcLAXwQYAQIACQUCTNwDbgIbDAAKCRCVx8DNpHPK 1+iQB/99aqNtez9ZTBWELj269La8ntuRx6gCpzfPXfn6SDIfTItDxTh1hrdRVP5QNGGF5wus N4EMwXouskva1hbFX3Pv72csYSxxEJXjW16oV8WK4KjKXoskLg2RyRP4uXqL7Mp2ezNtVY5F 9nu3fj4ydpHCSaqKy5xd70A8D50PfZsFgkrsa5gdQhPiGGEdxhq/XSeAAnZ4uVLJKarH+mj5 MEhgZPEBWkGrbDZpezl9qbFcUem/uT9x8FYT/JIztMVh9qDcdP5tzANW5J7nvgXjska+VFGY ryZK4SPDczh74mn6GI/+RBi7OUzXXPgpPBrhS5FByjwCqjjsSpTjTds+NGIY Organization: Sentex Communications Message-ID: Date: Tue, 3 Jul 2018 15:19:43 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 19:19:47 -0000 I got the following panic while deleting a test snapshot panic: unprotected error in call to Lua API (Invalid value type 'function' for key 'error') cpuid = 4 KDB: stack backtrace: #0 0xffffffff806fb437 at kdb_backtrace+0x67 #1 0xffffffff806b4a57 at vpanic+0x177 #2 0xffffffff806b48d3 at panic+0x43 #3 0xffffffff814500e4 at zcp_panic_cb+0x24 #4 0xffffffff8149b591 at luaD_throw+0x31 #5 0xffffffff814a4042 at luaG_errormsg+0x72 #6 0xffffffff814ae109 at lua_error+0x9 #7 0xffffffff8144f376 at zcp_convert_return_values+0x96 #8 0xffffffff8144ff4f at zcp_eval+0x71f #9 0xffffffff813fe9f1 at dsl_destroy_snapshots_nvl+0x1b1 #10 0xffffffff81478644 at zfs_ioc_destroy_snaps+0x164 #11 0xffffffff8147f269 at zfsdev_ioctl+0x6f9 #12 0xffffffff80582418 at devfs_ioctl_f+0x128 #13 0xffffffff807174bd at kern_ioctl+0x26d #14 0xffffffff807171dc at sys_ioctl+0x15c #15 0xffffffff80945078 at amd64_syscall+0xa38 #16 0xffffffff80923cfd at fast_syscall_common+0x101 I was not able to get a backtrace saved. Any ideas what this might be about ? -- ------------------- Mike Tancsa, tel +1 519 651 3400 x203 Sentex Communications, mike@sentex.net Providing Internet services since 1994 www.sentex.net Cambridge, Ontario Canada From owner-freebsd-stable@freebsd.org Wed Jul 4 06:47:44 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 140CF10385CE for ; Wed, 4 Jul 2018 06:47:44 +0000 (UTC) (envelope-from aliovx@gmail.com) Received: from mail-oi0-x22e.google.com (mail-oi0-x22e.google.com [IPv6:2607:f8b0:4003:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 845B98A3DE for ; Wed, 4 Jul 2018 06:47:43 +0000 (UTC) (envelope-from aliovx@gmail.com) Received: by mail-oi0-x22e.google.com with SMTP id k12-v6so8697334oiw.8 for ; Tue, 03 Jul 2018 23:47:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=sIhj8rzRIXsC0DqaEMSGGODruNFXfCvL5GDci9/XJSA=; b=rWzNV9W9h/L+e+6GaZQ98UjQndb2iXZdZujKMrK7GcW3zWvU+PteaXmXFQ9JeGr+2+ d9letRHIEdeMjGG/2gKfYsQ7gDzSAzc0MfyUHx4FcC+8gwZWQOgRjQz7IzykUUeho9jG n6URd+RfcqpcJ88O362rpJ5dEpGV9o//BpAYpZ5H+UMdMmoZ0I/IHI/ZIpReJJyIwHD8 zkbEp/GW31FA6FwvdKxEwhHVM2Mg4ixeeEt4kYwEJuQjJOVHIu1YrAuKOxeWbC1HysrE RH5DfSLY6rTbpNLuimtUE2N97nKJAasBWKCLMnbT1ullosnthabcuuAgQ6vKyZgBYl8A we9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=sIhj8rzRIXsC0DqaEMSGGODruNFXfCvL5GDci9/XJSA=; b=A9UNQdOzEjnjiRqErg8pWrb5mHB9XdHIhuAdTVidcDdGwZcb//EsW34MA4b1wybWhv 7e49glERVbEzi5Whm4F945kp/a5YSA1pHVcY8F6UycPPKuezoREB95XCx7k1Yl6InMOD JV/pUS09poZSbSiKr3VUcHcDTsioFGiy2eS8kWVDXhjX4UDfEMzHWiulEz6T47sQ6OF0 8QUqELlMIwME0vFiWyEwYUETzsb6eKgiv0GO3TCfJI5m6rIJmZOATeXaBEKvaNSDDjkH crrhAFLB1LPK8oUkWqUqqPGO55shHxOBAWMrOnpgzBKzDSWB4FU37w/8THo19YOugDnf hNBQ== X-Gm-Message-State: APt69E3X53+t3wgnvCpZDrztN32qKPgrxK2gjmgT/0P5ldtMu3Jwzrvt UdwFS0dlNl/scoJKTt/x9yMpFTWGJJ7JLXTJ4pJTzTdL X-Google-Smtp-Source: AAOMgpevZbrmr++VvukEgAxYVEhXzCi0T7O0HaGNkzFg6MmBE1MpwtQbLWzA8qVO7F6sb8Sqg+0rqPgnDABOuU5MVVo= X-Received: by 2002:aca:400b:: with SMTP id n11-v6mr928353oia.44.1530686862557; Tue, 03 Jul 2018 23:47:42 -0700 (PDT) MIME-Version: 1.0 From: Ali Abdallah Date: Wed, 4 Jul 2018 08:47:32 +0200 Message-ID: Subject: Prevent auto reboot on system crash To: freebsd-stable@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jul 2018 06:47:44 -0000 The problem is that, on crash the kernel drops crash messages on the tty0 console and reboots immediately, making it impossible to read them. (they are not saved in /var/log/console.log for some reason). According to https://lists.freebsd.org/pipermail/freebsd-questions/2009-July/202210.html, if debugging enabled in the kernel (KDB, DDB), setting debug.debugger_on_panic: 1, should prevent the system from auto-reboot on crash. Apparently this is not working, at least for me. Also I've set kern.panic_reboot_wait_time=-1, with no apparent effect. One way to trigger system crash on 11.2 is to load the vboxdrv (installed from pkg 'virtualbox-ose-kmod-5.2.8', not compiled from source). This will crash the system reproducing the behavior described above. Any help is highly appreciated. Ali From owner-freebsd-stable@freebsd.org Thu Jul 5 10:13:15 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 06901103D8F7 for ; Thu, 5 Jul 2018 10:13:15 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from constantine.ingresso.co.uk (unknown [IPv6:2a02:b90:3002:411::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 54FA373997; Thu, 5 Jul 2018 10:13:14 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from [2a02:b90:3002:411::6] (helo=dilbert.ingresso.co.uk) by constantine.ingresso.co.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89 (FreeBSD)) (envelope-from ) id 1fb1GA-000PmI-8i; Thu, 05 Jul 2018 10:13:10 +0000 Received: from petefrench by dilbert.ingresso.co.uk with local (Exim 4.91 (FreeBSD)) (envelope-from ) id 1fb1GA-0000s2-Cy; Thu, 05 Jul 2018 11:13:10 +0100 To: kostikbel@gmail.com, petefrench@ingresso.co.uk Subject: Re: Ryzen issues on FreeBSD ? (with sort of workaround) Cc: avg@freebsd.org, eric@vangyzen.net, freebsd-stable@freebsd.org, freebsd@hda3.com, truckman@FreeBSD.org In-Reply-To: <343bb693-850b-92b0-9749-5c722b90f817@ingresso.co.uk> Message-Id: From: Pete French Date: Thu, 05 Jul 2018 11:13:10 +0100 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 10:13:15 -0000 So, I got my first lockup in weeks, testing with the latest stable and the patch which sets the kernel bits. But I cant say it its Ryzen related or not. Meanwhile I also got access to an Epyc server in Azure. Am also runing the latest STABLE on that tp see how it goes. Interesting thing there is that there appears to be no access to the MSR's. They all appear as zerousing cpucontrol. I am not entirely surprised by this as the are very low level, but I di think they were saved and restored during context switches between virtual machines so I was hoping to be able to set them. Is this normal ? -pete. From owner-freebsd-stable@freebsd.org Thu Jul 5 10:31:48 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7B94B103EEAF for ; Thu, 5 Jul 2018 10:31:48 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E36887444F; Thu, 5 Jul 2018 10:31:47 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w65AVaJx006756 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 5 Jul 2018 13:31:39 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w65AVaJx006756 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w65AVZuA006755; Thu, 5 Jul 2018 13:31:35 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 5 Jul 2018 13:31:35 +0300 From: Konstantin Belousov To: Pete French Cc: avg@freebsd.org, eric@vangyzen.net, freebsd-stable@freebsd.org, freebsd@hda3.com, truckman@FreeBSD.org Subject: Re: Ryzen issues on FreeBSD ? (with sort of workaround) Message-ID: <20180705103135.GD5562@kib.kiev.ua> References: <343bb693-850b-92b0-9749-5c722b90f817@ingresso.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 10:31:48 -0000 On Thu, Jul 05, 2018 at 11:13:10AM +0100, Pete French wrote: > So, I got my first lockup in weeks, testing with the latest stable > and the patch which sets the kernel bits. But I cant say it its > Ryzen related or not. > > Meanwhile I also got access to an Epyc server in Azure. Am also > runing the latest STABLE on that tp see how it goes. Interesting > thing there is that there appears to be no access to the MSR's. > They all appear as zerousing cpucontrol. I am not entirely surprised > by this as the are very low level, but I di think they were saved > and restored during context switches between virtual machines so I > was hoping to be able to set them. Is this normal ? It does not make any sense to even try to access the chicken bits MSRs when running under virtualization. It is the duty of the hypervisor to configure hardware. I updated the patch. diff --git a/sys/amd64/amd64/initcpu.c b/sys/amd64/amd64/initcpu.c index ccc5e64d0c4..bb342f42dec 100644 --- a/sys/amd64/amd64/initcpu.c +++ b/sys/amd64/amd64/initcpu.c @@ -130,6 +130,30 @@ init_amd(void) } } + /* Ryzen erratas. */ + if (CPUID_TO_FAMILY(cpu_id) == 0x17 && CPUID_TO_MODEL(cpu_id) == 0x1 && + (cpu_feature2 & CPUID2_HV) == 0) { + /* 1021 */ + msr = rdmsr(0xc0011029); + msr |= 0x2000; + wrmsr(0xc0011029, msr); + + /* 1033 */ + msr = rdmsr(0xc0011020); + msr |= 0x10; + wrmsr(0xc0011020, msr); + + /* 1049 */ + msr = rdmsr(0xc0011028); + msr |= 0x10; + wrmsr(0xc0011028, msr); + + /* 1095 */ + msr = rdmsr(0xc0011020); + msr |= 0x200000000000000; + wrmsr(0xc0011020, msr); + } + /* * Work around a problem on Ryzen that is triggered by executing * code near the top of user memory, in our case the signal From owner-freebsd-stable@freebsd.org Thu Jul 5 10:43:31 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1F60B103FC5F for ; Thu, 5 Jul 2018 10:43:31 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from constantine.ingresso.co.uk (unknown [IPv6:2a02:b90:3002:411::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B819574DC5; Thu, 5 Jul 2018 10:43:30 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from [2a02:b90:3002:411::6] (helo=dilbert.ingresso.co.uk) by constantine.ingresso.co.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89 (FreeBSD)) (envelope-from ) id 1fb1jV-0000A4-8F; Thu, 05 Jul 2018 10:43:29 +0000 Received: from petefrench by dilbert.ingresso.co.uk with local (Exim 4.91 (FreeBSD)) (envelope-from ) id 1fb1jV-0000yT-B2; Thu, 05 Jul 2018 11:43:29 +0100 To: kostikbel@gmail.com, petefrench@ingresso.co.uk Subject: Re: Ryzen issues on FreeBSD ? (with sort of workaround) Cc: avg@freebsd.org, eric@vangyzen.net, freebsd-stable@freebsd.org, freebsd@hda3.com, truckman@FreeBSD.org In-Reply-To: <20180705103135.GD5562@kib.kiev.ua> Message-Id: From: Pete French Date: Thu, 05 Jul 2018 11:43:29 +0100 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 10:43:31 -0000 > It does not make any sense to even try to access the chicken bits > MSRs when running under virtualization. It is the duty of the > hypervisor to configure hardware. I would tend to agree with you :-) I was kind of surprised to read that they are actually saved and restored as part of a VM context switch in fact. > I updated the patch. Thanks I shall try this now on my workstation and the Epyc virtual machine -pete. From owner-freebsd-stable@freebsd.org Thu Jul 5 10:47:32 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0BF0A1040144 for ; Thu, 5 Jul 2018 10:47:32 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 77BFA75142; Thu, 5 Jul 2018 10:47:31 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w65AlKJD010274 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 5 Jul 2018 13:47:23 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w65AlKJD010274 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w65AlK1b010273; Thu, 5 Jul 2018 13:47:20 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 5 Jul 2018 13:47:20 +0300 From: Konstantin Belousov To: Pete French Cc: avg@freebsd.org, eric@vangyzen.net, freebsd-stable@freebsd.org, freebsd@hda3.com, truckman@FreeBSD.org Subject: Re: Ryzen issues on FreeBSD ? (with sort of workaround) Message-ID: <20180705104720.GE5562@kib.kiev.ua> References: <20180705103135.GD5562@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 10:47:32 -0000 On Thu, Jul 05, 2018 at 11:43:29AM +0100, Pete French wrote: > > It does not make any sense to even try to access the chicken bits > > MSRs when running under virtualization. It is the duty of the > > hypervisor to configure hardware. > > I would tend to agree with you :-) I was kind of surprised to read that they > are actually saved and restored as part of a VM context switch in fact. Why do you state that they are saved/restored ? What is the evidence ? > > > I updated the patch. > > Thanks I shall try this now on my workstation and the Epyc virtual machine On VM the patch should be NOP, testing it is a waste of time IMO. From owner-freebsd-stable@freebsd.org Thu Jul 5 10:54:53 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5D44410409B3 for ; Thu, 5 Jul 2018 10:54:53 +0000 (UTC) (envelope-from driesm.michiels@gmail.com) Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com [IPv6:2a00:1450:400c:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C9B5175793 for ; Thu, 5 Jul 2018 10:54:52 +0000 (UTC) (envelope-from driesm.michiels@gmail.com) Received: by mail-wm0-x231.google.com with SMTP id w16-v6so10327290wmc.2 for ; Thu, 05 Jul 2018 03:54:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version:content-language :thread-index; bh=CcahRGblD6rLH6I9Fn3pqOFE5nNYerTrTC50o7TsY2w=; b=LluSv8VgP3vPE8q7eamPquKN0yxmSiy0Eq89IObk20L6R4nWFBaxcYPp4vOlpzbN5v 2jaoL2IQCGgMFng+lw1fxV9Ut4EpxKmQCodmpzVbIvY0Qv1jsK0eheasm1/aOuyqhC4k SWWZ7PkrTYYCaiu8aygcYuVJrdhFhxkO3+nKross69O3pFFl6B2YbDTHJ7jaaBbHmGi/ 2qnx3pXdn2XlWCNvYe2zMEshhJLngy5rrbyeIYUUGnVPMtwtpb37llxXLHeVNB9XGMhW ajl3VP0JtqqIBQ5jsqfE8tF/lehOwzfg1Ns5ZvDKbrvtxwnn9jQya9br1Zvr8KxREzGG jjoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-language:thread-index; bh=CcahRGblD6rLH6I9Fn3pqOFE5nNYerTrTC50o7TsY2w=; b=Q1pAsgDHhI6dHXUM1hZT2yPATQ3K7QssCEF/5jM4/kmkgKMlItYhyMJVy+nA6Cduxv HSiZDOfEBlW+YB1G35YcMbzY7jnIt7iSHsMFcEYvYAm0zM0/uLcYc+IqPszHe8nPNC9C VcIQs/A2+MLkA3Q+3oUfyf30HBHqa+iW2HQ+QjaF4TI0vU7PA4knxkBgQOUFtZv48yu+ Tu0x58s1dHazdYvCWoPNJxZQKb35U2zTtXe7VKze5ysrSfSHeeMQYdY/gioLgLfn6+W0 IAKgrViBAOXFw7q9mbZMqZYVaX/0DztwNhAH1TMgOYsXkBS7auBbHDXGx3Ri8V/e4dSo hkug== X-Gm-Message-State: APt69E13uDWG63Ot4ZDUH1a/TTjnho4C+vNrzFLklNEUs6Q8Jg1uk31X CX9elBXkGtYqzH9KjHTVMmJtaMB1 X-Google-Smtp-Source: AAOMgpdTdLg4W1fX2iRkBRWWbN7p5toxEMdsIpE7nNPjcUWGbzygVeZNvL0sqk/2E0QleKvDwyVeeA== X-Received: by 2002:adf:b60d:: with SMTP id f13-v6mr3997441wre.186.1530788091315; Thu, 05 Jul 2018 03:54:51 -0700 (PDT) Received: from DriesPC (ptr-8sibhe27nh9xc4j1ahg.18120a2.ip6.access.telenet.be. [2a02:1811:2503:a700:39f5:ab63:beca:6e54]) by smtp.gmail.com with ESMTPSA id 77-v6sm5523652wmq.22.2018.07.05.03.54.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jul 2018 03:54:50 -0700 (PDT) From: "Dries Michiels" To: Subject: Kernel build fails Date: Thu, 5 Jul 2018 12:54:50 +0200 Message-ID: <006601d4144e$993ad000$cbb07000$@gmail.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Content-Language: nl-be Thread-Index: AdQUTmEPVAR/USxzRNaoLgYhhRjSxA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 10:54:53 -0000 Hello, Today I wanted to upgrade to newest revision of the 11-stable branch but I have the following kernel build error: --- kern_kthread.o --- cc -target x86_64-unknown-freebsd11.2 --sysroot=/usr/obj/usr/src/tmp -B/usr/obj/usr/src/tmp/usr/bin -c -O2 -pipe -fno-strict-aliasing -g -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -MD -MF.depend.kern_kthread.o -MTkern_kthread.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-error-address-of-packed-member -mno-aes -mno-avx -std=iso9899:1999 -Werror /usr/src/sys/kern/kern_kthread.c --- kern_exit.o --- ctfconvert -L VERSION -g kern_exit.o --- kern_jail.o --- /usr/src/sys/kern/kern_jail.c:3943:15: error: unused variable 'p' [-Werror,-Wunused-variable] struct proc *p; ^ /usr/src/sys/kern/kern_jail.c:3944:16: error: unused variable 'cred' [-Werror,-Wunused-variable] struct ucred *cred; ^ 2 errors generated. --- kern_ktrace.o --- cc -target x86_64-unknown-freebsd11.2 --sysroot=/usr/obj/usr/src/tmp -B/usr/obj/usr/src/tmp/usr/bin -c -O2 -pipe -fno-strict-aliasing -g -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -MD -MF.depend.kern_ktrace.o -MTkern_ktrace.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-error-address-of-packed-member -mno-aes -mno-avx -std=iso9899:1999 -Werror /usr/src/sys/kern/kern_ktrace.c --- kern_jail.o --- *** [kern_jail.o] Error code 1 make[2]: stopped in /usr/obj/usr/src/sys/VADOS --- kern_exec.o --- ctfconvert -L VERSION -g kern_exec.o --- kern_intr.o --- ctfconvert -L VERSION -g kern_intr.o --- kern_kthread.o --- ctfconvert -L VERSION -g kern_kthread.o --- kern_fork.o --- ctfconvert -L VERSION -g kern_fork.o --- kern_event.o --- ctfconvert -L VERSION -g kern_event.o --- kern_descrip.o --- ctfconvert -L VERSION -g kern_descrip.o --- kern_ktrace.o --- ctfconvert -L VERSION -g kern_ktrace.o 1 error make[2]: stopped in /usr/obj/usr/src/sys/VADOS *** [buildkernel] Error code 2 make[1]: stopped in /usr/src 1 error make[1]: stopped in /usr/src *** [buildkernel] Error code 2 make: stopped in /usr/src 1 error make: stopped in /usr/src Any ideas? Regards, Dries From owner-freebsd-stable@freebsd.org Thu Jul 5 11:05:17 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1E5511041649 for ; Thu, 5 Jul 2018 11:05:17 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 63EAB76012 for ; Thu, 5 Jul 2018 11:05:16 +0000 (UTC) (envelope-from kib@freebsd.org) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w65B55rc013791 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 5 Jul 2018 14:05:08 +0300 (EEST) (envelope-from kib@freebsd.org) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w65B55rc013791 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w65B55RZ013790; Thu, 5 Jul 2018 14:05:05 +0300 (EEST) (envelope-from kib@freebsd.org) X-Authentication-Warning: tom.home: kostik set sender to kib@freebsd.org using -f Date: Thu, 5 Jul 2018 14:05:05 +0300 From: Konstantin Belousov To: Dries Michiels Cc: freebsd-stable@freebsd.org Subject: Re: Kernel build fails Message-ID: <20180705110505.GF5562@kib.kiev.ua> References: <006601d4144e$993ad000$cbb07000$@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <006601d4144e$993ad000$cbb07000$@gmail.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 11:05:17 -0000 On Thu, Jul 05, 2018 at 12:54:50PM +0200, Dries Michiels wrote: > Hello, > > > Today I wanted to upgrade to newest revision of the 11-stable branch but I > have the following kernel build error: > > > > --- kern_kthread.o --- > > cc -target x86_64-unknown-freebsd11.2 --sysroot=/usr/obj/usr/src/tmp > -B/usr/obj/usr/src/tmp/usr/bin -c -O2 -pipe -fno-strict-aliasing -g > -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/libfdt -D_KERNEL > -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-omit-frame-pointer > -mno-omit-leaf-frame-pointer -MD -MF.depend.kern_kthread.o > -MTkern_kthread.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse > -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fwrapv > -fstack-protector -gdwarf-2 -Wall -Wredundant-decls -Wnested-externs > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline > -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ > -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas > -Wno-error-tautological-compare -Wno-error-empty-body > -Wno-error-parentheses-equality -Wno-error-unused-function > -Wno-error-pointer-sign -Wno-error-shift-negative-value > -Wno-error-address-of-packed-member -mno-aes -mno-avx -std=iso9899:1999 > -Werror /usr/src/sys/kern/kern_kthread.c > > --- kern_exit.o --- > > ctfconvert -L VERSION -g kern_exit.o > > --- kern_jail.o --- > > /usr/src/sys/kern/kern_jail.c:3943:15: error: unused variable 'p' > [-Werror,-Wunused-variable] > > struct proc *p; > > ^ > > /usr/src/sys/kern/kern_jail.c:3944:16: error: unused variable 'cred' > [-Werror,-Wunused-variable] > > struct ucred *cred; > > ^ > > 2 errors generated. You have RACCT but not RCTL in the kernel config ? Try this. diff --git a/sys/kern/kern_jail.c b/sys/kern/kern_jail.c index b8bcbd49420..457a590cdf5 100644 --- a/sys/kern/kern_jail.c +++ b/sys/kern/kern_jail.c @@ -3988,8 +3988,10 @@ prison_racct_attach(struct prison *pr) static void prison_racct_modify(struct prison *pr) { +#ifdef RCTL struct proc *p; struct ucred *cred; +#endif struct prison_racct *oldprr; ASSERT_RACCT_ENABLED(); From owner-freebsd-stable@freebsd.org Thu Jul 5 11:58:53 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 36C3A10449EF for ; Thu, 5 Jul 2018 11:58:53 +0000 (UTC) (envelope-from driesm.michiels@gmail.com) Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A7BAB77E5D; Thu, 5 Jul 2018 11:58:52 +0000 (UTC) (envelope-from driesm.michiels@gmail.com) Received: by mail-wm0-x244.google.com with SMTP id v3-v6so6795299wmh.0; Thu, 05 Jul 2018 04:58:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=yJA9w1YioNvtWmcv0I/Z2mNa3SrylSHkkGy4vPmMwnc=; b=d65+8irMVtruqldFycdB0tyPGH54ZuM0Ze8oKOiEbFQ54lumXwh/GQkTYnMbSj2LU0 gO7iuPteB2yEcnQfm3/kHuAfT+qQRoEzX9fm7cjs1NlATltRqFFheq4MnX08OaTlry4R bAUkCvOs9j+Gb7MBpOffNgoERA+xACNSI34w0rEepZ7uRbClzPo0RIx2ht5TQnI/x4Gg EUGLhnGgbK/sYRpLZaPP6xoWaEGXFFcrPHupKCBzW/VS1cq09Ow/Chx+4tIDVnxEHP/N d30uDm3bcqIBn7tAy8BEEanwIOlSViB3Cq0jNVgt39sl7J8VP9jSp+qWdC80WAa7cAtP GrPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:references:in-reply-to:subject:date :message-id:mime-version:content-transfer-encoding:content-language :thread-index; bh=yJA9w1YioNvtWmcv0I/Z2mNa3SrylSHkkGy4vPmMwnc=; b=acPBNMP0Q0vRKtte1NiTN7DB1g+qkKMmNDwXQWU1ILK0C8l3vApPsRQ74nviG+eC6l IoEwFzxg1DPotv1dsmkCCh6n6Yn+Lca+FRgLeU/gbbJrvQoH5gxnsU7/5GK6nNtmyDJi PoCtI/nKxvJeObMW6VgeNv5y+SKdtk8O3Wabr8axw6QYr6PY0+Y2hIOkYQHfAAGuY07n 6JzhS6HDtactys6etpBw0vv1khxZnRFhiVe2N8aR1aei+uFvJXdpDn+5Xl+YJAkJ5qfe gHTur/ERrUAJdJ7TbkXrLb6Zlaf9jbM6ycPjTdomDYWiT8FR4WS/zF2bVTbR/BbjExIU 5yRA== X-Gm-Message-State: APt69E28D+WJ2WHBQ0RLuZ8hBsoaMo4aJIDFNPgVaDkm4JJyNgwg7VnE JUyVtexpgrPUvHp0/ZuhrLDNBw6b X-Google-Smtp-Source: AAOMgpe5bjx4iS6bR+IG7BPnJ1Dz8niLq0Qd7Bsi+j3a4PKgueW3So7iM/L0bZP9cBCexKrg/fzsDA== X-Received: by 2002:a5d:4452:: with SMTP id x18-v6mr4700561wrr.227.1530791931216; Thu, 05 Jul 2018 04:58:51 -0700 (PDT) Received: from DriesPC (ptr-8sibhe27nh9xc4j1ahg.18120a2.ip6.access.telenet.be. [2a02:1811:2503:a700:39f5:ab63:beca:6e54]) by smtp.gmail.com with ESMTPSA id a203-v6sm8009704wme.46.2018.07.05.04.58.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jul 2018 04:58:50 -0700 (PDT) From: "Dries Michiels" To: "'Konstantin Belousov'" Cc: References: <006601d4144e$993ad000$cbb07000$@gmail.com> <20180705110505.GF5562@kib.kiev.ua> In-Reply-To: <20180705110505.GF5562@kib.kiev.ua> Subject: RE: Kernel build fails Date: Thu, 5 Jul 2018 13:58:50 +0200 Message-ID: <007601d41457$89f91620$9deb4260$@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: nl-be Thread-Index: AQG53nWcD+kRNyE/ZnRCJifu5BxaVQLs0/ZppJ2HxnA= X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 11:58:53 -0000 > > --- kern_jail.o --- > > > > /usr/src/sys/kern/kern_jail.c:3943:15: error: unused variable 'p' > > [-Werror,-Wunused-variable] > > > > struct proc *p; > > > > ^ > > > > /usr/src/sys/kern/kern_jail.c:3944:16: error: unused variable 'cred' > > [-Werror,-Wunused-variable] > > > > struct ucred *cred; > > > > ^ > > > > 2 errors generated. > > You have RACCT but not RCTL in the kernel config ? Try this. This is correct! > diff --git a/sys/kern/kern_jail.c b/sys/kern/kern_jail.c index > b8bcbd49420..457a590cdf5 100644 > --- a/sys/kern/kern_jail.c > +++ b/sys/kern/kern_jail.c > @@ -3988,8 +3988,10 @@ prison_racct_attach(struct prison *pr) static > void prison_racct_modify(struct prison *pr) { > +#ifdef RCTL > struct proc *p; > struct ucred *cred; > +#endif > struct prison_racct *oldprr; > > ASSERT_RACCT_ENABLED(); I'm trying the patch as we speak thanks kib. Atlough after some digging I see that the kernel option RACCT on itself isn't really useful and should probably be combined with RCTL. Do you agree? From owner-freebsd-stable@freebsd.org Thu Jul 5 12:13:46 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 329051022CAA for ; Thu, 5 Jul 2018 12:13:46 +0000 (UTC) (envelope-from driesm.michiels@gmail.com) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 90FA579182; Thu, 5 Jul 2018 12:13:45 +0000 (UTC) (envelope-from driesm.michiels@gmail.com) Received: by mail-wr1-x442.google.com with SMTP id q10-v6so1052906wrd.4; Thu, 05 Jul 2018 05:13:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=CBEbXYVutc/zZBc6IZGjknVjtgE16xJqdMSER8/7tZ4=; b=D1QgF6YCQW2p/7w7H/XHDSQpVPRnxPZjqm00VoYu0sZIH/zeme108OpKp1+Yk8ErhB AJ4smOLbi1CEw2Pi7p1rAeAQJx2Lyf5aBlVyU5ZTcuQn1cjw2t4dHq/10no2ZGZQSaQq Xjr3LLp12/B8TBg8QV40gXUIHT6EBhhalaCP/3I8whLnMCgFhfJt8kOWmwDMsZEDx96q vCFX1RZZ8EEKJgPfmnKDawAeT8BvAxk5gZ8e1KneN6nl7Vd3H7Xh1NLHYkaEQpibisMg dWS+2vOEXUjxOItt96XCjXwpgEk2Z/tIKxGea3ONbv/4tGWRp4SOQxD3it5/F81Fnbr7 Ms0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:references:in-reply-to:subject:date :message-id:mime-version:content-transfer-encoding:content-language :thread-index; bh=CBEbXYVutc/zZBc6IZGjknVjtgE16xJqdMSER8/7tZ4=; b=Lxm8xfTqFKJ1yaljNmEU3QkH2NKpc8zc/tzvAwvsvuvJhs8lqWxCTI0+JHfGw4ho4F gDJ9Q2sBMBuAlhP1Mdeny6ZWsIX/9acI+aQwgBhSgxAeRCfzvhV0JnwNO5DZrDeKM6sx NMRWEZOxzg0kNqljQtdAKC0ppbCNIKJjOlF0VhROhoDuv9/heh1xBK3vaTuxdGcfR4Vz bY2lhEYDPGoil0BAeVAhYhZ5s4mbt5bgsR4Q2z+jzTolXRTyOG1K73NNKyMSQRt3EHMq f53bDf1cBAyIZ3huO3tGMpVIwNcC8irBTH7GiWdMqQY+5/6yTyoRKNw7FwD5TfEBk42M lcKw== X-Gm-Message-State: APt69E2NHy78s76IGzuuMiHTsux+JoGwLkd3dikdsKRigbyaxZxeKBg2 r8YxxOQ3Wlu8PfHwW/LqG+hvY3Be X-Google-Smtp-Source: AAOMgpcX4a1kOWHwAv62Tz7zQCdM0m6DQ8SGC+35JXX18zoanhdjm7weWDpjxqces6+X7QnE9Pcifw== X-Received: by 2002:adf:fb43:: with SMTP id c3-v6mr4716985wrs.32.1530792824168; Thu, 05 Jul 2018 05:13:44 -0700 (PDT) Received: from DriesPC (ptr-8sibhe27nh9xc4j1ahg.18120a2.ip6.access.telenet.be. [2a02:1811:2503:a700:39f5:ab63:beca:6e54]) by smtp.gmail.com with ESMTPSA id r194-v6sm11421557wmd.36.2018.07.05.05.13.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jul 2018 05:13:43 -0700 (PDT) From: "Dries Michiels" To: "'Konstantin Belousov'" Cc: References: <006601d4144e$993ad000$cbb07000$@gmail.com> <20180705110505.GF5562@kib.kiev.ua> <007601d41457$89f91620$9deb4260$@gmail.com> In-Reply-To: <007601d41457$89f91620$9deb4260$@gmail.com> Subject: RE: Kernel build fails Date: Thu, 5 Jul 2018 14:13:42 +0200 Message-ID: <007701d41459$9e2189f0$da649dd0$@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: nl-be Thread-Index: AQG53nWcD+kRNyE/ZnRCJifu5BxaVQLs0/ZpAZ2VLpWkkKJhcA== X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 12:13:46 -0000 > > You have RACCT but not RCTL in the kernel config ? Try this. > > This is correct! > > > diff --git a/sys/kern/kern_jail.c b/sys/kern/kern_jail.c index > > b8bcbd49420..457a590cdf5 100644 > > --- a/sys/kern/kern_jail.c > > +++ b/sys/kern/kern_jail.c > > @@ -3988,8 +3988,10 @@ prison_racct_attach(struct prison *pr) static > > void prison_racct_modify(struct prison *pr) { > > +#ifdef RCTL > > struct proc *p; > > struct ucred *cred; > > +#endif > > struct prison_racct *oldprr; > > > > ASSERT_RACCT_ENABLED(); > > I'm trying the patch as we speak thanks kib. Patch works fine. Kernel builds without problems. Will probably add RCTL to my kernel config though. Thanks! From owner-freebsd-stable@freebsd.org Thu Jul 5 12:19:10 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 58DA5102354F for ; Thu, 5 Jul 2018 12:19:10 +0000 (UTC) (envelope-from freebsd-stable=freebsd.org@mail224.pae1.iasrv.net) Received: from mail224.pae1.iasrv.net (mail224.pae1.iasrv.net [177.85.221.224]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BE83D79475 for ; Thu, 5 Jul 2018 12:19:09 +0000 (UTC) (envelope-from freebsd-stable=freebsd.org@mail224.pae1.iasrv.net) Received: from mail224.pae1.iasrv.net (unknown [168.196.188.33]) by mail224.pae1.iasrv.net (Postfix) with ESMTP id E090B7F7B699 for ; Thu, 5 Jul 2018 09:18:00 -0300 (BRT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=mail224.pae1.iasrv.net; s=k1; t=1530793080; i=anunciosweb=3Dtrindadeimoveis.com.br@mail224.pae1.iasrv.net; bh=oMEBj1d8cDri81tF4s9i2blgnWk=; h=Date:To:From:Reply-to:Subject:Message-ID:List-Unsubscribe; b=o7Upn7EpItibxmxLM8WsHSl0ofoutRtgxipyXkLSvvMJ5q9oebY+8udXOeXRbe7Eb SH42nYc1qfd2pfSraHDzpX7pav5lJYQnnBzI5CikjsOJoNtjx6WjRbKG3xuIj9XvkM HoRECY5wba1mst5MDcFCMSM5NVnWxEcCMOZYRvTc= Date: Thu, 5 Jul 2018 09:18:36 -0300 To: Freebsd-stable From: Trindade Imoveis Reply-to: Trindade Imoveis Subject: =?iso-8859-1?Q?Salas_Comercias_e_Andares_Corporativos_(C=F3pia)_(C=F3pia)?= Message-ID: X-Priority: 3 X-ClienteID: 3513 X-AgendamentoID: 380971 X-CadastroID: 76318598 X-Destinatario: freebsd-stable@freebsd.org X-Mailer: IAMAIL-3513 X-P: MTc3Ljg1LjIyMS4yMjQ= Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset = "iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 12:19:10 -0000 Esta mensagem foi enviada para o endereco freebsd-stable@freebsd.org. Se voce estiver com problemas para visualizar esta mensagem, copie o endereco abaixo e cole no seu navegador. http://e.trindadeimoveis.com.br/v3/TRC/P/3513/380971/76318598/ Para garantir o recebimento desta mensagem em sua caixa de entrada, = adicione anunciosweb@trindadeimoveis.com.br a lista de remetentes confiaveis ou ao seu catalogo de enderecos. Caso voce queira cancelar o recebimento das mensagens e/ou denunciar abuso = deste remetente, solicitamos que copie o endereco abaixo e cole no seu navegador. http://e.trindadeimoveis.com.br/v3/TRC/R/3513/380971/76318598/ From owner-freebsd-stable@freebsd.org Thu Jul 5 13:23:18 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AB580102895C for ; Thu, 5 Jul 2018 13:23:18 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from constantine.ingresso.co.uk (unknown [IPv6:2a02:b90:3002:411::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 44CF97BDF2; Thu, 5 Jul 2018 13:23:18 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from dilbert.london-internal.ingresso.co.uk ([10.64.50.6]) by constantine.ingresso.co.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89 (FreeBSD)) (envelope-from ) id 1fb4E7-0002G7-7n; Thu, 05 Jul 2018 13:23:15 +0000 Subject: Re: Ryzen issues on FreeBSD ? (with sort of workaround) To: Konstantin Belousov Cc: avg@freebsd.org, eric@vangyzen.net, freebsd-stable@freebsd.org, freebsd@hda3.com, truckman@FreeBSD.org References: <20180705103135.GD5562@kib.kiev.ua> <20180705104720.GE5562@kib.kiev.ua> From: Pete French Message-ID: Date: Thu, 5 Jul 2018 14:23:15 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180705104720.GE5562@kib.kiev.ua> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 13:23:18 -0000 On 05/07/2018 11:47, Konstantin Belousov wrote: > Why do you state that they are saved/restored ? What is the evidence ? https://software.intel.com/en-us/blogs/2009/06/25/virtualization-and-performance-understanding-vm-exits specificly... 3) "Save MSRs in the VM-exit MSR-store area." and 5) "Load MSRs from the VM-exit MSR-load area." but maybe thats not actyually true, I assumed it was given its an Intel document, but admittedly its not an actual specification. > On VM the patch should be NOP, testing it is a waste of time IMO. OK, will ignore that then. I am running the new patch on my workstation now - I still need the old patch for the other files, yes ? -pete. From owner-freebsd-stable@freebsd.org Thu Jul 5 13:35:50 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE01E1029A70 for ; Thu, 5 Jul 2018 13:35:50 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3BAC37C687; Thu, 5 Jul 2018 13:35:50 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w65DZgDC048674 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 5 Jul 2018 16:35:45 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w65DZgDC048674 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w65DZgxQ048673; Thu, 5 Jul 2018 16:35:42 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 5 Jul 2018 16:35:42 +0300 From: Konstantin Belousov To: Pete French Cc: avg@freebsd.org, eric@vangyzen.net, freebsd-stable@freebsd.org, freebsd@hda3.com, truckman@FreeBSD.org Subject: Re: Ryzen issues on FreeBSD ? (with sort of workaround) Message-ID: <20180705133542.GG5562@kib.kiev.ua> References: <20180705103135.GD5562@kib.kiev.ua> <20180705104720.GE5562@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 13:35:50 -0000 On Thu, Jul 05, 2018 at 02:23:15PM +0100, Pete French wrote: > > > On 05/07/2018 11:47, Konstantin Belousov wrote: > > Why do you state that they are saved/restored ? What is the evidence ? > > > https://software.intel.com/en-us/blogs/2009/06/25/virtualization-and-performance-understanding-vm-exits > > specificly... > > 3) "Save MSRs in the VM-exit MSR-store area." > > and > > 5) "Load MSRs from the VM-exit MSR-load area." > > but maybe thats not actyually true, I assumed it was given its an Intel > document, but admittedly its not an actual specification. This is true, but absolutely irrelevant. Modern CPUs have hundreds, if not thousands, MSR registers. Only some of them define architectural state, and saved/restored on the context switches. Chicken bits are global knobs not relevant to the vmm entry. > > > > On VM the patch should be NOP, testing it is a waste of time IMO. > > > OK, will ignore that then. I am running the new patch on my workstation > now - I still need the old patch for the other files, yes ? Which other files ? From owner-freebsd-stable@freebsd.org Thu Jul 5 13:58:31 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3E0D102BED1 for ; Thu, 5 Jul 2018 13:58:31 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from constantine.ingresso.co.uk (unknown [IPv6:2a02:b90:3002:411::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49FF37DF4B; Thu, 5 Jul 2018 13:58:31 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from [2a02:b90:3002:411::6] (helo=dilbert.ingresso.co.uk) by constantine.ingresso.co.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89 (FreeBSD)) (envelope-from ) id 1fb4mD-0002gb-SM; Thu, 05 Jul 2018 13:58:29 +0000 Received: from petefrench by dilbert.ingresso.co.uk with local (Exim 4.91 (FreeBSD)) (envelope-from ) id 1fb4mD-0006j7-SY; Thu, 05 Jul 2018 14:58:29 +0100 To: kostikbel@gmail.com, petefrench@ingresso.co.uk Subject: Re: Ryzen issues on FreeBSD ? (with sort of workaround) Cc: avg@freebsd.org, eric@vangyzen.net, freebsd-stable@freebsd.org, freebsd@hda3.com, truckman@FreeBSD.org In-Reply-To: <20180705133542.GG5562@kib.kiev.ua> Message-Id: From: Pete French Date: Thu, 05 Jul 2018 14:58:29 +0100 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 13:58:31 -0000 > This is true, but absolutely irrelevant. > > Modern CPUs have hundreds, if not thousands, MSR registers. Only some of > them define architectural state, and saved/restored on the context switches. > Chicken bits are global knobs not relevant to the vmm entry. That actually makes far more sense. I was kind of puzzled as to how it would work if they were per VM :-) > Which other files ? sys/x86/include/specialreg.h and sys/x86/x86/cpu_machdep.c Those are in your original patch as well as the change to sys/amd64/amd64/initcpu.c, but your email earlier only patches sys/amd64/amd64/initcpu.c and not the others. So I assumed I would keep the changes to the other two files ? -pete. From owner-freebsd-stable@freebsd.org Thu Jul 5 14:51:39 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9E0C210301B1 for ; Thu, 5 Jul 2018 14:51:39 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 01264808A3; Thu, 5 Jul 2018 14:51:38 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w65EpV50065804 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 5 Jul 2018 17:51:34 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w65EpV50065804 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w65EpUqm065803; Thu, 5 Jul 2018 17:51:30 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 5 Jul 2018 17:51:30 +0300 From: Konstantin Belousov To: Pete French Cc: avg@freebsd.org, eric@vangyzen.net, freebsd-stable@freebsd.org, freebsd@hda3.com, truckman@FreeBSD.org Subject: Re: Ryzen issues on FreeBSD ? (with sort of workaround) Message-ID: <20180705145130.GH5562@kib.kiev.ua> References: <20180705133542.GG5562@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.0 (2018-05-17) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 14:51:39 -0000 On Thu, Jul 05, 2018 at 02:58:29PM +0100, Pete French wrote: > > Which other files ? > > sys/x86/include/specialreg.h and sys/x86/x86/cpu_machdep.c > > Those are in your original patch as well as the change > to sys/amd64/amd64/initcpu.c, but your email earlier only > patches sys/amd64/amd64/initcpu.c and not the others. > > So I assumed I would keep the changes to the other two files ? Right, I forgot about mwait. specialreg.h is cosmetics which I already committed. diff --git a/sys/amd64/amd64/initcpu.c b/sys/amd64/amd64/initcpu.c index ccc5e64d0c4..bb342f42dec 100644 --- a/sys/amd64/amd64/initcpu.c +++ b/sys/amd64/amd64/initcpu.c @@ -130,6 +130,30 @@ init_amd(void) } } + /* Ryzen erratas. */ + if (CPUID_TO_FAMILY(cpu_id) == 0x17 && CPUID_TO_MODEL(cpu_id) == 0x1 && + (cpu_feature2 & CPUID2_HV) == 0) { + /* 1021 */ + msr = rdmsr(0xc0011029); + msr |= 0x2000; + wrmsr(0xc0011029, msr); + + /* 1033 */ + msr = rdmsr(0xc0011020); + msr |= 0x10; + wrmsr(0xc0011020, msr); + + /* 1049 */ + msr = rdmsr(0xc0011028); + msr |= 0x10; + wrmsr(0xc0011028, msr); + + /* 1095 */ + msr = rdmsr(0xc0011020); + msr |= 0x200000000000000; + wrmsr(0xc0011020, msr); + } + /* * Work around a problem on Ryzen that is triggered by executing * code near the top of user memory, in our case the signal diff --git a/sys/x86/x86/cpu_machdep.c b/sys/x86/x86/cpu_machdep.c index d897d518cbc..3416f949686 100644 --- a/sys/x86/x86/cpu_machdep.c +++ b/sys/x86/x86/cpu_machdep.c @@ -709,6 +709,13 @@ cpu_idle_tun(void *unused __unused) if (TUNABLE_STR_FETCH("machdep.idle", tunvar, sizeof(tunvar))) cpu_idle_selector(tunvar); + else if (cpu_vendor_id == CPU_VENDOR_AMD && + CPUID_TO_FAMILY(cpu_id) == 0x17 && CPUID_TO_MODEL(cpu_id) == 0x1) { + /* Ryzen erratas 1057, 1109. */ + cpu_idle_selector("hlt"); + idle_mwait = 0; + } + if (cpu_vendor_id == CPU_VENDOR_INTEL && cpu_id == 0x506c9) { /* * Apollo Lake errata APL31 (public errata APL30). From owner-freebsd-stable@freebsd.org Thu Jul 5 16:17:21 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3ED7010398D3 for ; Thu, 5 Jul 2018 16:17:21 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mx0.gentlemail.de (mx0.gentlemail.de [IPv6:2a00:e10:2800::a130]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C730C85938 for ; Thu, 5 Jul 2018 16:17:20 +0000 (UTC) (envelope-from freebsd@omnilan.de) Received: from mh0.gentlemail.de (ezra.dcm1.omnilan.net [78.138.80.135]) by mx0.gentlemail.de (8.14.5/8.14.5) with ESMTP id w65GHIZB019562 for ; Thu, 5 Jul 2018 18:17:18 +0200 (CEST) (envelope-from freebsd@omnilan.de) Received: from titan.inop.mo1.omnilan.net (s1.omnilan.de [217.91.127.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mh0.gentlemail.de (Postfix) with ESMTPSA id 973ABD6F for ; Thu, 5 Jul 2018 18:17:18 +0200 (CEST) Subject: ctld(8) 11.2-release lockup with w2k16 [Was: Re: ctld(8), multiple 'portal-group' on same socket (individual 'discovery-auth-group' restrictions)] To: FreeBSD Stable References: <5444C94C.4050705@omnilan.de> <20141021104308.GA5990@brick.home> From: Harry Schmalzbauer Organization: OmniLAN Message-ID: <3613504a-b017-bc3a-cd62-54d8bb051ea1@omnilan.de> Date: Thu, 5 Jul 2018 18:17:18 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20141021104308.GA5990@brick.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Greylist: ACL 130 matched, not delayed by milter-greylist-4.2.7 (mx0.gentlemail.de [78.138.80.130]); Thu, 05 Jul 2018 18:17:18 +0200 (CEST) X-Milter: Spamilter (Reciever: mx0.gentlemail.de; Sender-ip: 78.138.80.135; Sender-helo: mh0.gentlemail.de; ) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 16:17:21 -0000 Am 21.10.2014 um 12:43 schrieb Edward Tomasz Napierała: > On 1020T1035, Harald Schmalzbauer wrote: >> Hello, >> >> I'm trying to move from istgt(1) to ctld(8), but it seems my setup isn't >> possible with ctld. >> Besides missing support for virtual-DVDs ('UnitType DVD' in istgt) and >> real ODD-devices ('UnitType pass' in istgt), > Yup, we don't implement virtual DVDs and passthrough. Especially the > latter would be a nice feature to have. Hello Edward, my current problem is unrelated. But this old mail illustrates the timeframe I've been happily using ctld(8) without problems :-) Thanks! Recently, I discovered that WindowsServerBackup fails with Win2k16 (never used 2k12). Old initiators running 2008R2 (or ESXi 5.5) are still able to use ctld(8) ZVOL targets for WindowsServerBackup on 11.2-release without problems. I haven't had time to do much analysis and I'm lacking skills/equipment to do them down at debugger level, but I wanted to ask if you're aware about problems with Windows Server 2016 as ctld(8) initiator. The Symptoms: The system locks up for about 30-60 seconds with iSCSI load from w2k16. When the lockup happens, systat(1) shows 25% intr usage (which is one core) and not even the login session is responsive anymore. Neither updating userland-output nor reacting to input. But, the input is queued and gets processed after the lockup releases. The lockup vanishes as soon as iSCSI session was reset: Jun 28 06:14:09 bansta kernel: WARNING: 172.24.32.172 (iqn.1991-05.com.microsoft:dafus.mgn.mo1.psw-online.de): no ping reply (NOP-Out) after 5 seconds; dropping connection Jun 28 06:14:09 bansta kernel: WARNING: 172.24.32.172 (iqn.1991-05.com.microsoft:dafus.mgn.mo1.psw-online.de): waiting for CTL to terminate 94 tasks Jun 28 06:14:09 bansta kernel: WARNING: 172.24.32.172 (iqn.1991-05.com.microsoft:dafus.mgn.mo1.psw-online.de): tasks terminated Sometimes it's possible to transfer 30GB before the lockup happens, sometimes even a NTFS-quick-format leads to the lockup. Yesterday I used istgt(1) instead of ctld(8) to export the exactly same ZVOL using the exactly same network backend, with exactly the same initiator. The lockup hasn't occured anymore, the complete WindowsServerBackup taks finishes successfully on the Windows Server 2016 initiator.  So I strongly suspect a ctld(8) locking problem. Like mentioned, target backed is a ZFS volume.  I already used a HDD as target backed (and observed a much better performance, which drops even if I use a UFS vnode backend on the same HDD), but I'm not sure anymore whether the lockup also occured... For now I can't tell anything helpfuly, just describe the symptoms and ask if you have any hints for me what to try next to narrow down the problem, or if this is a already known problem. Thanks, -harry From owner-freebsd-stable@freebsd.org Fri Jul 6 12:50:30 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E287F10235B3 for ; Fri, 6 Jul 2018 12:50:30 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 84B9E7F192 for ; Fri, 6 Jul 2018 12:50:30 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: by mailman.ysv.freebsd.org (Postfix) id 3E43510235AE; Fri, 6 Jul 2018 12:50:30 +0000 (UTC) Delivered-To: stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2BD0610235AD for ; Fri, 6 Jul 2018 12:50:30 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from constantine.ingresso.co.uk (unknown [IPv6:2a02:b90:3002:411::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C51787F18F for ; Fri, 6 Jul 2018 12:50:29 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from [2a02:b90:3002:411::6] (helo=dilbert.ingresso.co.uk) by constantine.ingresso.co.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89 (FreeBSD)) (envelope-from ) id 1fbQBu-000J9N-To for stable@freebsd.org; Fri, 06 Jul 2018 12:50:26 +0000 Received: from petefrench by dilbert.ingresso.co.uk with local (Exim 4.91 (FreeBSD)) (envelope-from ) id 1fbQBu-0004wS-W4 for stable@freebsd.org; Fri, 06 Jul 2018 13:50:27 +0100 To: stable@freebsd.org Subject: mail coredumping on yesterdays STABLE Message-Id: From: Pete French Date: Fri, 06 Jul 2018 13:50:26 +0100 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 12:50:31 -0000 /usr/bin.mail (still my preferred mail reader) has just started coredumping on me when I delete seom messages. A trace is below, and I notice http://www.freshbsd.org/commit/freebsd/r335693 is applying some fixes in the area I am seeing coredumps -pete. #0 sigchild (signo=) at /usr/src/usr.bin/mail/popen.c:347 347 if (cp->free) (gdb) bt #0 sigchild (signo=) at /usr/src/usr.bin/mail/popen.c:347 #1 #2 0x0000000800993218 in _read () from /lib/libc.so.7 #3 0x0000000800991850 in _sread (fp=0x800bd5e10, buf=, n=) at /usr/src/lib/libc/stdio/stdio.c:91 #4 0x0000000800984011 in __srefill (fp=0x800bd5e10) at /usr/src/lib/libc/stdio/refill.c:134 #5 0x00000008009758e5 in fgets (buf=, n=, fp=0x800bd5e10) at /usr/src/lib/libc/stdio/fgets.c:76 #6 0x0000000000407d38 in readline (ibuf=0x800bd5e10, linebuf=0x7fffffffd530 "p", linesize=1024) at /usr/src/usr.bin/mail/fio.c:190 #7 0x00000000004091bc in commands () at /usr/src/usr.bin/mail/lex.c:234 #8 0x000000000040b851 in main (argc=, argv=) at /usr/src/usr.bin/mail/main.c:293 #9 0x00000000004027d4 in _start () #10 0x000000080063b000 in ?? () #11 0x0000000000000000 in ?? () Current language: auto; currently minimal From owner-freebsd-stable@freebsd.org Fri Jul 6 12:57:12 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6A8B9102428D for ; Fri, 6 Jul 2018 12:57:12 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id F00D17F7B6 for ; Fri, 6 Jul 2018 12:57:11 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mailman.ysv.freebsd.org (Postfix) id A9F63102428A; Fri, 6 Jul 2018 12:57:11 +0000 (UTC) Delivered-To: stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9792C1024289 for ; Fri, 6 Jul 2018 12:57:11 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yb0-x236.google.com (mail-yb0-x236.google.com [IPv6:2607:f8b0:4002:c09::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3B94F7F7B4 for ; Fri, 6 Jul 2018 12:57:11 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yb0-x236.google.com with SMTP id e84-v6so4517308ybb.0 for ; Fri, 06 Jul 2018 05:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L9BvndPqM5cbSLNQjH5ZDjOMRh/AIh19B8mcbyl7SDo=; b=q7Ovs9aa9SXx5dy+u/zdtLizhTHslnq0aD75jeXNbhvo3jH2b92IWSOYnzFMy501l8 yuDAkBqOJJeAEovyIY48lvrJSR2O3uTnWags+T7FSUrqL2LrDl2Y00ZRmvlKLU3obwLd DPwSeMFRDtVpjXZVUyr47d5TNE0Diq5QIJWbw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L9BvndPqM5cbSLNQjH5ZDjOMRh/AIh19B8mcbyl7SDo=; b=qEyv1sFzo6UlP/fkFKyOIy81TAk7FGgsdZOvgzmbfCirgM+biJKiiM/ayh+io8wANg FJmyXFIGT5vI3WnbyFyAWUShgkcZe7uUbWDcUlru8RD7m2fYugiph+pNbGhsPCdfy0pZ f5cP1u1sfCZ60FZ96Z4X4iIRdE8aiJNWsohEjIVvLmwN7VuOGkXBfxVlwmKjZB7ZH3f8 jVu74Dyy4NakgZh0TETIRUKZcPcQuYzKLoXGtwkDjefZwgOohF9Atm9LR6+7xL7O7DkK i3dzbfTrkfGk1XlxxhV6zw93Uu6/3HFbVrkMELnY1slS4c1ANAFfJPOem1yJaDtcoYxU x5UA== X-Gm-Message-State: APt69E1UDd5XyGGU5sIxfJtZIKpeVC5QEKyfSYT8c5mzvTD0v4vo0J0P Sn1t7cUHdISKvLj+1D1+UtScjd4wczxRfyejs0Bi7A== X-Google-Smtp-Source: AAOMgpdMvj14FL93DRoke9/EzB+q6zKu6+TqRLTdiSyQ1P+00cmFuKOIITLYFrhXyNY7yKbJJ5EkdG1fpxJk8oDuLgs= X-Received: by 2002:a25:786:: with SMTP id 128-v6mr5450593ybh.338.1530881830389; Fri, 06 Jul 2018 05:57:10 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Eitan Adler Date: Fri, 6 Jul 2018 05:56:43 -0700 Message-ID: Subject: Re: mail coredumping on yesterdays STABLE To: Pete French Cc: stable@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 12:57:12 -0000 On Fri, 6 Jul 2018 at 05:52, Pete French wrote: > > /usr/bin.mail (still my preferred mail reader) has just started > coredumping on me when I delete seom messages. A trace is below, > and I notice http://www.freshbsd.org/commit/freebsd/r335693 > is applying some fixes in the area I am seeing coredumps If you revert the change does it succeed? My development machine is completely dead right now, but it is possible I missed a commit or otherwise made an error. -- Eitan Adler From owner-freebsd-stable@freebsd.org Fri Jul 6 13:05:02 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7C7E4102517D for ; Fri, 6 Jul 2018 13:05:02 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 1CBA27FEF3 for ; Fri, 6 Jul 2018 13:05:02 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: by mailman.ysv.freebsd.org (Postfix) id CE316102517A; Fri, 6 Jul 2018 13:05:01 +0000 (UTC) Delivered-To: stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BBBF31025179 for ; Fri, 6 Jul 2018 13:05:01 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from constantine.ingresso.co.uk (unknown [IPv6:2a02:b90:3002:411::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5E8277FEF0 for ; Fri, 6 Jul 2018 13:05:01 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from [82.47.240.30] (helo=foula.drayhouse.twisted.org.uk) by constantine.ingresso.co.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.89 (FreeBSD)) (envelope-from ) id 1fbQQ0-000JKd-1V; Fri, 06 Jul 2018 13:05:00 +0000 Subject: Re: mail coredumping on yesterdays STABLE To: Eitan Adler Cc: stable@freebsd.org References: From: Pete French Message-ID: <897f17ab-e49d-7e09-2e0e-76fae2d7a036@ingresso.co.uk> Date: Fri, 6 Jul 2018 14:04:59 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:52.0) Gecko/20100101 Thunderbird/52.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 13:05:02 -0000 Am going to try that. I should have added that the cordeump happens when I am viewing an email inside 'more' and I quit out of it, not when I try and delete it, I was wrong about that. Will give it a go with that chnage revertsed and let you know.... -pete. On 06/07/2018 13:56, Eitan Adler wrote: > On Fri, 6 Jul 2018 at 05:52, Pete French wrote: >> >> /usr/bin.mail (still my preferred mail reader) has just started >> coredumping on me when I delete seom messages. A trace is below, >> and I notice http://www.freshbsd.org/commit/freebsd/r335693 >> is applying some fixes in the area I am seeing coredumps > > If you revert the change does it succeed? My development machine is > completely dead right now, but it is possible I missed a commit or > otherwise made an error. > > > From owner-freebsd-stable@freebsd.org Fri Jul 6 13:45:05 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 116381028F1B for ; Fri, 6 Jul 2018 13:45:05 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id A5BB581DBA for ; Fri, 6 Jul 2018 13:45:04 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: by mailman.ysv.freebsd.org (Postfix) id 634B91028F19; Fri, 6 Jul 2018 13:45:04 +0000 (UTC) Delivered-To: stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5103F1028F18 for ; Fri, 6 Jul 2018 13:45:04 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from constantine.ingresso.co.uk (unknown [IPv6:2a02:b90:3002:411::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DEFF681DB8 for ; Fri, 6 Jul 2018 13:45:03 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from [2a02:b90:3002:411::6] (helo=dilbert.ingresso.co.uk) by constantine.ingresso.co.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89 (FreeBSD)) (envelope-from ) id 1fbR2k-000JnT-R2; Fri, 06 Jul 2018 13:45:02 +0000 Received: from petefrench by dilbert.ingresso.co.uk with local (Exim 4.91 (FreeBSD)) (envelope-from ) id 1fbR2k-0000XQ-Ud; Fri, 06 Jul 2018 14:45:02 +0100 To: lists@eitanadler.com, petefrench@ingresso.co.uk Subject: Re: mail coredumping on yesterdays STABLE Cc: stable@freebsd.org In-Reply-To: <897f17ab-e49d-7e09-2e0e-76fae2d7a036@ingresso.co.uk> Message-Id: From: Pete French Date: Fri, 06 Jul 2018 14:45:02 +0100 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 13:45:05 -0000 > Am going to try that. I should have added that the cordeump happens when > I am viewing an email inside 'more' and I quit out of it, not when I try > and delete it, I was wrong about that. > > Will give it a go with that chnage revertsed and let you know.... Reverting the chnage makes the coredump go away, so am back to using command line mail again. Appologies for the top-positing of the pervious post! -pete. From owner-freebsd-stable@freebsd.org Fri Jul 6 13:47:41 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6C3E610292C3 for ; Fri, 6 Jul 2018 13:47:41 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 035AA82038 for ; Fri, 6 Jul 2018 13:47:41 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mailman.ysv.freebsd.org (Postfix) id B7F2710292C2; Fri, 6 Jul 2018 13:47:40 +0000 (UTC) Delivered-To: stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A4FF710292C1 for ; Fri, 6 Jul 2018 13:47:40 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yb0-x234.google.com (mail-yb0-x234.google.com [IPv6:2607:f8b0:4002:c09::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EFBFF82037 for ; Fri, 6 Jul 2018 13:47:39 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yb0-x234.google.com with SMTP id i9-v6so4571948ybo.5 for ; Fri, 06 Jul 2018 06:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5IGtveMf9G2AcutMPokYDE6KEbJInT7X8pldghRPqEw=; b=C4hS8At81JSJUzKGIdyYw1bLhcR+0Fss6LHZJCajgGcJ4U6tFKcugrDGUaXD7u/UDa ofwVNGtpYEmNmyTbu2Bvq2ewQ0RTsNusec9Uf14/ANOtggwmWxUvByw4eThXK+BbbW0N oo3jOpY+Kk9DZPqHQjhLucn5USb4evfAFAc1c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5IGtveMf9G2AcutMPokYDE6KEbJInT7X8pldghRPqEw=; b=tExiQLEnDXuMl4lc49nbPP5QyAPG0bvPXt551b33sn5cszsB6VazJIGNMjfp2s+DRo P+YrMREyl+CrBajeJpzAPF8vf6QU4RLjvlbmbdauFRCMC+jWCZJDcYz9KtKqwiqKFgWi Blrhg+T3rnQ8hm9lPH1MJU3D2YZA3l/hexPQQVtKRr66+uh3yUtlDh84GVS4fxj6+L10 DRstiKiFOTwwWt0zke8IxDjmzRWdVwWLH/rF7rUzDvtgsFv2AbLDLTEJQr0UTtC5kzBZ tNyhinwaRrxYA4YzObIeWtgm24XatXqdhFe98lbwxoku51rIV+1Ofebxd+875hDyx+Ov fQ8g== X-Gm-Message-State: APt69E1Xm36vd5HC77hKssk0SWMiBDLAVEZVS5GoRE6diqHYXv3da1CB y1FuSq+8wSJ4xuAq1cOjypyWuxtzSW6K2xfNHfU6Rw== X-Google-Smtp-Source: AAOMgpe5TSl5eRwUWlTVFVSOTditopqVtsoI5JGXXH2RyaOx1RLZdArpbm+KInLnuhed0KN0aeIGcuBWIgzqnPqj6PQ= X-Received: by 2002:a25:730c:: with SMTP id o12-v6mr5109543ybc.69.1530884858974; Fri, 06 Jul 2018 06:47:38 -0700 (PDT) MIME-Version: 1.0 References: <897f17ab-e49d-7e09-2e0e-76fae2d7a036@ingresso.co.uk> In-Reply-To: From: Eitan Adler Date: Fri, 6 Jul 2018 06:47:13 -0700 Message-ID: Subject: Re: mail coredumping on yesterdays STABLE To: Pete French Cc: stable@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 13:47:41 -0000 On Fri, 6 Jul 2018 at 06:45, Pete French wrote: > > > Am going to try that. I should have added that the cordeump happens when > > I am viewing an email inside 'more' and I quit out of it, not when I try > > and delete it, I was wrong about that. > > > > Will give it a go with that chnage revertsed and let you know.... > > Reverting the chnage makes the coredump go away, so am back to > using command line mail again. Appologies for the top-positing > of the pervious post! Understood. Like I said, my development box is dead, so expect nothing for the next couple of weeks [0] unless someone gets to it first. [0] even once it gets fixed, I have to catch up on several projects. -- Eitan Adler From owner-freebsd-stable@freebsd.org Fri Jul 6 14:06:32 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B8525102AEE9 for ; Fri, 6 Jul 2018 14:06:32 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 40F8682D38 for ; Fri, 6 Jul 2018 14:06:32 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: by mailman.ysv.freebsd.org (Postfix) id E458E102AEE4; Fri, 6 Jul 2018 14:06:31 +0000 (UTC) Delivered-To: stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CD26F102AEE3 for ; Fri, 6 Jul 2018 14:06:31 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from constantine.ingresso.co.uk (unknown [IPv6:2a02:b90:3002:411::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5CFEC82D35 for ; Fri, 6 Jul 2018 14:06:31 +0000 (UTC) (envelope-from petefrench@ingresso.co.uk) Received: from [2a02:b90:3002:411::6] (helo=dilbert.ingresso.co.uk) by constantine.ingresso.co.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89 (FreeBSD)) (envelope-from ) id 1fbRNS-000K44-Jy; Fri, 06 Jul 2018 14:06:26 +0000 Received: from petefrench by dilbert.ingresso.co.uk with local (Exim 4.91 (FreeBSD)) (envelope-from ) id 1fbRNR-0001IV-Sm; Fri, 06 Jul 2018 15:06:25 +0100 To: lists@eitanadler.com, petefrench@ingresso.co.uk Subject: Re: mail coredumping on yesterdays STABLE Cc: stable@freebsd.org In-Reply-To: Message-Id: From: Pete French Date: Fri, 06 Jul 2018 15:06:25 +0100 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 14:06:32 -0000 > Understood. Like I said, my development box is dead, so expect nothing > for the next couple of weeks [0] unless someone gets to it first. Ok, no worries. Will you revert the chnage in STABLE until then, or should I continue running with it reverted locally ? I will try and look at it myself if I get a moment. thanks, -pete. From owner-freebsd-stable@freebsd.org Fri Jul 6 14:28:43 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4E95A102CB61 for ; Fri, 6 Jul 2018 14:28:43 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id DA73183819 for ; Fri, 6 Jul 2018 14:28:42 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mailman.ysv.freebsd.org (Postfix) id 97C72102CB53; Fri, 6 Jul 2018 14:28:42 +0000 (UTC) Delivered-To: stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 856A2102CB52 for ; Fri, 6 Jul 2018 14:28:42 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yb0-x235.google.com (mail-yb0-x235.google.com [IPv6:2607:f8b0:4002:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2298A83818 for ; Fri, 6 Jul 2018 14:28:42 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yb0-x235.google.com with SMTP id r3-v6so4631602ybo.4 for ; Fri, 06 Jul 2018 07:28:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NAxty9aDFcTCYIsJyjHwo6mDDdXRgl0khFGdlIhExLA=; b=ABtigDoPNl2G+kYudI/OWwRFHDr+YinwXsyThBjJwtbkK6q35XZ1DcX8VRWUKWpHAB sUBua9JQWRZMxWxCxqAqzU3bI1F1c55DI7fVTSJ5hf8VmN8E+zb3z7F9Tr1Bh9WuiS1f 0qRha14x8ZJMihuGsFdFAkJQ1vCiw6NhinKpE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NAxty9aDFcTCYIsJyjHwo6mDDdXRgl0khFGdlIhExLA=; b=Cr0VO8nTdlGitwv7fUDwYj8noMd11HQMOpqVo49hfrRslISgcmwdJylhSj6MYmjsCS a3TI94Qn2cV+Vg5YyzgPnwg/o3ArZxrPB69oam0Z/NyTFcK2BExWbrqj2jzCv3zyaGb+ THU6PXXK/E8bEoy5Jgeey9fVlphuCJMrh+jAgClwSq/HmUP/63dLpxEuVZlU09rvcOcf BynyI6Cl24Mjw+FHq+/VbrpknkOS0cv9ZXi9GymxRsGeWS1AQOWEkPGk95RiCy2Rjdo6 2un1+OOMfHQ1FESeTBKO8U7zLb4TNIG83zI62i+1FzHtMNj+eMfSlryvg50EmppchOJH Gzew== X-Gm-Message-State: APt69E1EqBvtCRM3MShFmYvYanOAoZm2glnRlK4+W58O/eXdc9TTkeQB FFYZRFGU/g2HQv8VVgO85xSKikvUq256Syf9VKDszg== X-Google-Smtp-Source: AAOMgpcuFSGhseKbykfyFeUQEvdqXzdofdM0xON2LU3aeXVPFWnttkT3DWyo/ZoAZoVIA50KxWh+PXv22GJsFkUdhH8= X-Received: by 2002:a25:a05:: with SMTP id 5-v6mr5389767ybk.479.1530887321061; Fri, 06 Jul 2018 07:28:41 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Eitan Adler Date: Fri, 6 Jul 2018 07:28:14 -0700 Message-ID: Subject: Re: mail coredumping on yesterdays STABLE To: Pete French Cc: stable@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 14:28:43 -0000 On Fri, 6 Jul 2018 at 07:06, Pete French wrote: > > > Understood. Like I said, my development box is dead, so expect nothing > > for the next couple of weeks [0] unless someone gets to it first. > > Ok, no worries. Will you revert the chnage in STABLE until then, or > should I continue running with it reverted locally ? I will try and > look at it myself if I get a moment. I don't have the capability to commit right now. -- Eitan Adler