From owner-freebsd-testing@freebsd.org Sun Jul 29 17:23:37 2018 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 21478105BCBE for ; Sun, 29 Jul 2018 17:23:37 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 63B0E88194 for ; Sun, 29 Jul 2018 17:23:36 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-x232.google.com with SMTP id p6-v6so8426802ljc.5 for ; Sun, 29 Jul 2018 10:23:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:from:date:message-id:subject:to; bh=ueFnf9NG3R2i40kJWS/5J7xb2tsWuosQ9sND0ofT2Sc=; b=oaMrGK3H+MtccV+mmoIl/iUEUeNzgB31IvmADuZp/j8hBvG0ISEcA3ZKvj4BZkN4Xf UaMEqVeIiMDn89brBRT3UDcL5jyN13NshnGLRKoRme41OVipsGY1LyTJlCAr0BdaD3Qe DQZV6tGnOT5a2ZjMPuJ4ITqQaozRjCrjYVNraS0GWQo78fzpCMUDfpCRN1cP7oi4H7wQ xr1lqYEx6JTJ46cza7pOeTsQXZ/8GI8w/wiosKjCZVbh+9Ay+IK+vJWdmiy52k+qVxe/ pTVwqIICsBnbQ71hjPOj0N7nhREOKGfqBR0FQUYxUbfCmDF1H4n7RakmUfsmJRe/QdWM 0eVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=ueFnf9NG3R2i40kJWS/5J7xb2tsWuosQ9sND0ofT2Sc=; b=n81ndIzynsyfUjV1qgDLMQ3kwdTEQZ6D23DOyAFDVd4RdvKlg/uI8V/9Sdi3nT1oa5 8pNJOoQW1Njeg3pXfUDdPbS6E9zIhHzsNWlezh6p/hXL2wOi+YNaO9OT6c6VWv2iuObS w1PwVzmR+wxTRMVIlIV2dWNAU6K076+k63YYXyPA8Ybku1g7UcwHoblPBl9hxcYpZrJ7 l1oqeb/qlXsYroAkjdOY7dY/RBbzrYeRzBwSlvBv99ei4K1NC3gS9zFSXt57kwPI/wDY W4P+iT8PV45ZmiVor4dQ5sRJ2S5pAs1CRRURGON9oGuhuJuRP/Xa3wISUXmaP6+HDjho emog== X-Gm-Message-State: AOUpUlHVxExjvyeGmEI5d+1hW65uIGkrwwCwiG9/Cbhmca+D2gdvKU6s ElTOnWAtTV4KEPi3TPsoCAr6M5BBk5mqXSYW6MNPDg== X-Google-Smtp-Source: AAOMgpexnMDFSC+ucVk5EDmzWxhKCi2U/LwviXx1/uyMFkkWlFLLJwHL/+oW0JciOgIBN7MsG1ljiP1qMBK/LsgR9R8= X-Received: by 2002:a2e:4401:: with SMTP id r1-v6mr11004633lja.21.1532885013880; Sun, 29 Jul 2018 10:23:33 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 2002:ab3:7851:0:0:0:0:0 with HTTP; Sun, 29 Jul 2018 10:23:33 -0700 (PDT) From: Alan Somers Date: Sun, 29 Jul 2018 11:23:33 -0600 X-Google-Sender-Auth: 1YrrHO1SFIWKF78Ix_mNF9wZpBs Message-ID: Subject: Skipping tests that are unimplemented in 32-bit emulation To: "freebsd-testing@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jul 2018 17:23:37 -0000 I recently tried running the i386 test suite in a chroot on an amd64 system. 162 tests failed, and 33 were broken. Some of the failures were due to system calls that haven't been implemented in 32-bit emulation. setfib(2) is an example. I think it's unlikely that anybody will ever need 32-bit emulation for setfib(2), so perhaps we should just skip the test? What's the best way to do that? I can come up with two ways: 1) At runtime, check the hw.machine sysctl and see if it matches some compile time preprocessor constant. I don't know what constant to use, though. Checking __amd64__ would only work for i386 binaries on amd64 kernels, and not something else like mips binaries on mips64 kernels (I don't know if we support that, but I don't want to rule it out). 2) At buildtime, put an "allowed_architectures=i386" metadata property into the Kyuafile for that test program. This would require support in /usr/share/mk/bsd.test.mk. It would also require patching Kyua itself, because currently "Kyua config" returns the architecture for which it was built, not the one on which it's running. Thoughts?