From owner-freebsd-testing@freebsd.org Mon Aug 6 19:14:14 2018 Return-Path: Delivered-To: freebsd-testing@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0D2B41062797 for ; Mon, 6 Aug 2018 19:14:14 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-pl0-x235.google.com (mail-pl0-x235.google.com [IPv6:2607:f8b0:400e:c01::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 87073853DE; Mon, 6 Aug 2018 19:14:13 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-pl0-x235.google.com with SMTP id x6-v6so6031236plv.10; Mon, 06 Aug 2018 12:14:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ipfLJ315KLYWNHdhYIs/giaDLf6dm2TjkiQ9kE5wXCk=; b=p2Tuw2A4Me/D2EtpnGRE+b/Av8DvZlilifkkY2HcpW/hZ9Fih7cgAooVaLezU0XKcs zwbxGnEZsG5v9RSVB4E+Ml9nsYzdl7DcTieZr8e9R6t++e5l7ivDyAul3Y1ZDXnbfoE7 Z4L0Z3Jj3i5zjPveCLr+iVAdkF/+YhJJyH39KOu4qC54+Q9CWMyqeqtevy24X0mmo0AS owfow6JZ7jIM0DDic7tmZbSMSVQeBNzm02MybOgRIUYHfcgLMIdRHrUFvuII3PTdGhK6 TB4roX6Guq+TecVhZ395GOQIA/MLbeMaLAWfyltLTqdB5Jig+O/TYM2ny+VJ3tVJLEKL 6tkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=ipfLJ315KLYWNHdhYIs/giaDLf6dm2TjkiQ9kE5wXCk=; b=qBrHHpPNzyEDIha7+m2r7ty0+p6CozngMDO0pCigVRLcbFQdLTUYpL/fW6daUjXW8t 114R7M98LTrc7l2CfCxQlyJmGic5s1d/q0BKzlyh7sKDRaBZjrpoxgYJCeVIWY4683/C O+fbEQv5GZxYTvVDTRxnrGqQDA60IRaHhDzsu/o5XyAx9FFCrn6esIP6hRT5kCaq0tIb xAVH1BVeXNp2x7sdMPUZG1it/JWUppRXjXHWomU4ot7EbVF1g/XSYrDVttUwUrV7byX8 tcillv6Z+49oE35+PN9CAtUGdEenCItTWkm/iR/OgsZze8kNokASfU/8JhY2WV6EmvDX YC6g== X-Gm-Message-State: AOUpUlEjDHqowfaVjkixMetX40ivQWJlHj0p6Qp3AxIRLrctLd0/p+9e ddBrr0BzfIgZZd3McZRXzvnL7yZG X-Google-Smtp-Source: AAOMgpfmV5ysQJEuO/ODmpgBtzqxXQlxqKQ8EGUkO1TaMm470hKehpckOowudQaK0e4VnOPjLE30pQ== X-Received: by 2002:a17:902:aa8f:: with SMTP id d15-v6mr15165631plr.64.1533582852230; Mon, 06 Aug 2018 12:14:12 -0700 (PDT) Received: from raichu (toroon0560w-lp130-09-70-52-224-239.dsl.bell.ca. [70.52.224.239]) by smtp.gmail.com with ESMTPSA id y63-v6sm20746846pgd.94.2018.08.06.12.14.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Aug 2018 12:14:11 -0700 (PDT) Sender: Mark Johnston Date: Mon, 6 Aug 2018 15:14:06 -0400 From: Mark Johnston To: Alan Somers Cc: "freebsd-testing@freebsd.org" Subject: Re: Skipping tests that are unimplemented in 32-bit emulation Message-ID: <20180806191406.GA77150@raichu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Aug 2018 19:14:14 -0000 On Sun, Jul 29, 2018 at 11:23:33AM -0600, Alan Somers wrote: > I recently tried running the i386 test suite in a chroot on an amd64 > system. 162 tests failed, and 33 were broken. Some of the failures were > due to system calls that haven't been implemented in 32-bit emulation. > setfib(2) is an example. I think it's unlikely that anybody will ever need > 32-bit emulation for setfib(2), so perhaps we should just skip the test? > What's the best way to do that? I can come up with two ways: > > 1) At runtime, check the hw.machine sysctl and see if it matches some > compile time preprocessor constant. I don't know what constant to use, > though. Checking __amd64__ would only work for i386 binaries on amd64 > kernels, and not something else like mips binaries on mips64 kernels (I > don't know if we support that, but I don't want to rule it out). > > 2) At buildtime, put an "allowed_architectures=i386" metadata property into > the Kyuafile for that test program. This would require support in > /usr/share/mk/bsd.test.mk. It would also require patching Kyua itself, > because currently "Kyua config" returns the architecture for which it was > built, not the one on which it's running. > > Thoughts? I don't have any particular suggestions, but I'd personally rather avoid a solution that requires tests to opt-in to running under 32-bit emulation, which I think excludes 2). I'd be happy to help annotate any failing tests as required. It bugs me that the test suite currently doesn't cover such relatively complicated functions as freebsd32_copy_msg_out().