From owner-freebsd-toolchain@freebsd.org Sun Jul 8 15:47:43 2018 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ED68310321AF for ; Sun, 8 Jul 2018 15:47:42 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic312-21.consmr.mail.ne1.yahoo.com (sonic312-21.consmr.mail.ne1.yahoo.com [66.163.191.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7F7CD7A776 for ; Sun, 8 Jul 2018 15:47:42 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: s9y2gmUVM1kbCX0M6bfRbvwfnJcY49TES96JUtiMJPWHlLl8YJ31xPx2Qog6QAY Yf03FYNIA857ASaud9UP9wz2ys0youkq1HNQ4VlMkocs.bVQ5MzTEB_xfwqsV0LdUxUG1s8qFW3G DWj.7Snbocp1aaE9dSjlcyilwW6S8mCMYvHrpMch7olTlUy_P8wIEYy6msKSGulJVsYQVS7EjfLz s9HE20V0_A7_uzWE.GtYm9gR2PFNmcNxDc6QTk.0VzSix80m7ALGCSz0EAkdU3XJULnzmFvu20WT 5Gbg9jHfflAhoqFyfpedtT8AOWJ_XA6kviVesuWb09JA7JGTAtgE2hqxLaI3aifSmmVMgRA6.Plp LwToPk3n.LPiq8F9FGV14rl6olXShpgl1Vz7jlqfc6gbuELFSpBf0ptK7xGqVK0EeSsVPblWd6wc Net8q1okMA8OFAPrkT7jJAFQ1XhfotVXZMvYUGo5NF27FSdUyVEJW85RK5atAP.ptrxNPpm7.T.N JfHeZveT05EHYhDqdDJkomgJLClfPJUkWv_wF7KjGjcSDX3MBKQLXXJKHpJBXFMLFbPWf7IHNVt3 yt358q5uJTJ8F5zoVzyx3A9twH_gfeZAIO5xcKFafcmfXQpbPoHJlumM2ZtE6MBNxZRx4EDU7hRB d9yfrvJxTQm8tOe0N7u6Dh.wxGoPkrudgZkShlUJWg1nP.wqSYkH1ZMgqe.lCFLuF59zV0eYsZOs 6aMFZg0O.5lL9iXddLtYMa.kbFuiPkv_MSiYeq87g4zLicSB7rFNywh5Mfe1rTNqODaERIuWlVQP c0rJCHvwSjgThTN7cHU4xhbw8MpJf9_iwGP0H1MKy_0HRU4eApEHvJHRbNdLCUHi8p_xS8Q5AG6o RJG75jrHQTh18nKfEoWksk9NBDmzjFVfVb8BfE.qgyM2tkYjy1nwbSvSrJxPISe4qpj0jtkMKpiv OI2hH1YdDFVBZllqLwpMUqZtrowt1szmhE6KWOxNuXgIn Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Sun, 8 Jul 2018 15:47:41 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.105]) ([70.189.131.151]) by smtp412.mail.ne1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 015257d5c8c2cc5bc0d45abc7e5ee1f0 for ; Sun, 08 Jul 2018 15:47:39 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: src/contrib/elftoolchain/elfcopy/sections.c underallocates for Elf64_Rela and Elf32_Rela? Message-Id: <79954D9E-0A93-4148-A2C6-B5113E59AE28@yahoo.com> Date: Sun, 8 Jul 2018 08:47:38 -0700 To: FreeBSD Toolchain X-Mailer: Apple Mail (2.3445.8.2) X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2018 15:47:43 -0000 src/contrib/elftoolchain/elfcopy/sections.c has and uses the macro: 716 #define COPYREL(REL, SZ) do { = \ 717 if (nrels =3D=3D 0) { = \ 718 if ((REL##SZ =3D malloc(cap * = \ 719 sizeof(Elf##SZ##_Rel))) =3D=3D NULL) = \ 720 err(EXIT_FAILURE, "malloc failed"); = \ 721 } = \ 722 if (nrels >=3D cap) { = \ 723 cap *=3D 2; = \ 724 if ((REL##SZ =3D realloc(REL##SZ, cap * = \ 725 sizeof(Elf##SZ##_Rel))) =3D=3D NULL) = \ 726 err(EXIT_FAILURE, "realloc failed"); = \ 727 } = \ 728 REL##SZ[nrels].r_offset =3D REL.r_offset; = \ 729 REL##SZ[nrels].r_info =3D REL.r_info; = \ 730 if (s->type =3D=3D SHT_RELA) = \ 731 rela##SZ[nrels].r_addend =3D rela.r_addend; = \ 732 nrels++; = \ 733 } while (0) The context has: 687 Elf32_Rel *rel32; 688 Elf64_Rel *rel64; 689 Elf32_Rela *rela32; 690 Elf64_Rela *rela64; So for, say, COPYREL(rela,64), the macro uses sizeof(Elf64_Rel) instead of sizeof(ELF64_Rela) in malloc and realloc but Elf64_Rela is the larger structure of the two ELF64_ types (by also having .r_addend). The scan build on ci.freebsd.org complains about this: Result of 'realloc' is converted to a pointer of type 'Elf64_Rela', = which is incompatible with sizeof operand type 'Elf64_Rel' So far it does not look like a false-positive to me. =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-toolchain@freebsd.org Sun Jul 8 16:03:54 2018 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D77DD1034228 for ; Sun, 8 Jul 2018 16:03:53 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 488B87BA60 for ; Sun, 8 Jul 2018 16:03:53 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-wm0-x235.google.com with SMTP id n17-v6so18372768wmh.2 for ; Sun, 08 Jul 2018 09:03:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cGgd/95cA4gv72G93o1N+4H1dHdcIkkPw+3WdFBWY9U=; b=BWvfJpui/gCChzcrM4T+XmbzCt1HumAo9jpis6dVimmiE+ynOFL5zmFRJaDc/y7iPn sYmioSpV+IVn56jDyXAeCnfn3GzKgGTV2Y6Vh9q91rCW5Y9GyjTp72ppGZ9bvcDysFWS 4MfxtiAipNdLYtRnta6ao4SmnjQ5zvJmBivnuOnbOHWhX9qTl5PS8n7q0mAV9NGPUWUS CwfSBK0RQTJIzRK00VpuXSTIQ1F1KvnprqDTw1vv4bk1C+d1XYHk2781Z/jVP7y2ARxG WiSFgzf/BSH6DJ4gjbytbe7z43p/lRNzP9bjeINFHVcV2lvVrLIpiLCQJsO8A3Tg+s3a vx8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cGgd/95cA4gv72G93o1N+4H1dHdcIkkPw+3WdFBWY9U=; b=Z075apWY84iY1x+vyE1K0W1E6n6r5P06d0J8ARLpBKIkztVQNWtCEqUbFMLZUJSTCZ GhW3jsS9fXEC2GLOe5VvnZQ387TmAbIt3Fw0074GDZiJfjodIL1ld/JfKmCYRit0CgUe VsnQA/b8E3UpkhwIix7cqrVmYUWx0PbS2vnDJTAKfKRMs7rjeadX+WnDMz4xwXptDsie aVOf2PakhnkJXyKkgRN/3fYd3XQZwzWuLz3zeMX0G90wTvfujsJ6rLEWp1r4Rkvpen7C dVHx+mpo4gWgIq6Ywemxpn5BK3YCKGIgL4O5sQJcU259PqNznbNoZAZ9eSnRtaxndLO9 Omiw== X-Gm-Message-State: APt69E35PzkRWC/yyQRCZxHytaibw8tW9sa5WQtM02F+Y3zNWJWNQhd2 FZZBHQIeu/BXSx7+9iex9O4= X-Google-Smtp-Source: AAOMgpdy3q700l5cDXQhmBO+fhULUfzJFnZarX666+E96lZctcjGOO8Ia3rt69P3IDp+WZK631/3cg== X-Received: by 2002:a1c:9382:: with SMTP id v124-v6mr11850517wmd.52.1531065832238; Sun, 08 Jul 2018 09:03:52 -0700 (PDT) Received: from pesky (174.red-81-43-74.staticip.rima-tde.net. [81.43.74.174]) by smtp.gmail.com with ESMTPSA id r17-v6sm4433205wrt.44.2018.07.08.09.03.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Jul 2018 09:03:51 -0700 (PDT) Date: Sun, 8 Jul 2018 12:03:49 -0400 From: Mark Johnston To: Mark Millard Cc: FreeBSD Toolchain Subject: Re: src/contrib/elftoolchain/elfcopy/sections.c underallocates for Elf64_Rela and Elf32_Rela? Message-ID: <20180708160349.GC18193@pesky> References: <79954D9E-0A93-4148-A2C6-B5113E59AE28@yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <79954D9E-0A93-4148-A2C6-B5113E59AE28@yahoo.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jul 2018 16:03:54 -0000 On Sun, Jul 08, 2018 at 08:47:38AM -0700, Mark Millard via freebsd-toolchain wrote: > src/contrib/elftoolchain/elfcopy/sections.c has and uses the macro: > > 716 #define COPYREL(REL, SZ) do { \ > 717 if (nrels == 0) { \ > 718 if ((REL##SZ = malloc(cap * \ > 719 sizeof(Elf##SZ##_Rel))) == NULL) \ > 720 err(EXIT_FAILURE, "malloc failed"); \ > 721 } \ > 722 if (nrels >= cap) { \ > 723 cap *= 2; \ > 724 if ((REL##SZ = realloc(REL##SZ, cap * \ > 725 sizeof(Elf##SZ##_Rel))) == NULL) \ > 726 err(EXIT_FAILURE, "realloc failed"); \ > 727 } \ > 728 REL##SZ[nrels].r_offset = REL.r_offset; \ > 729 REL##SZ[nrels].r_info = REL.r_info; \ > 730 if (s->type == SHT_RELA) \ > 731 rela##SZ[nrels].r_addend = rela.r_addend; \ > 732 nrels++; \ > 733 } while (0) > > The context has: > > 687 Elf32_Rel *rel32; > 688 Elf64_Rel *rel64; > 689 Elf32_Rela *rela32; > 690 Elf64_Rela *rela64; > > So for, say, COPYREL(rela,64), the macro uses sizeof(Elf64_Rel) instead > of sizeof(ELF64_Rela) in malloc and realloc but Elf64_Rela is the > larger structure of the two ELF64_ types (by also having .r_addend). > > The scan build on ci.freebsd.org complains about this: > > Result of 'realloc' is converted to a pointer of type 'Elf64_Rela', which is incompatible with sizeof operand type 'Elf64_Rel' > > So far it does not look like a false-positive to me. Looks like a valid bug to me. I think the following patch is needed: diff --git a/contrib/elftoolchain/elfcopy/sections.c b/contrib/elftoolchain/elfcopy/sections.c index b292d18693b4..92265289c7d1 100644 --- a/contrib/elftoolchain/elfcopy/sections.c +++ b/contrib/elftoolchain/elfcopy/sections.c @@ -716,13 +716,13 @@ filter_reloc(struct elfcopy *ecp, struct section *s) #define COPYREL(REL, SZ) do { \ if (nrels == 0) { \ if ((REL##SZ = malloc(cap * \ - sizeof(Elf##SZ##_Rel))) == NULL) \ + sizeof(*REL##SZ))) == NULL) \ err(EXIT_FAILURE, "malloc failed"); \ } \ if (nrels >= cap) { \ cap *= 2; \ if ((REL##SZ = realloc(REL##SZ, cap * \ - sizeof(Elf##SZ##_Rel))) == NULL) \ + sizeof(*REL##SZ))) == NULL) \ err(EXIT_FAILURE, "realloc failed"); \ } \ REL##SZ[nrels].r_offset = REL.r_offset; \ From owner-freebsd-toolchain@freebsd.org Tue Jul 10 17:40:20 2018 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 390DE103FAC2 for ; Tue, 10 Jul 2018 17:40:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id C6E84820DE for ; Tue, 10 Jul 2018 17:40:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 87E4A103FAB5; Tue, 10 Jul 2018 17:40:19 +0000 (UTC) Delivered-To: toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7687A103FAB2 for ; Tue, 10 Jul 2018 17:40:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 16D9D820D2 for ; Tue, 10 Jul 2018 17:40:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 592E711402 for ; Tue, 10 Jul 2018 17:40:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w6AHeILU067885 for ; Tue, 10 Jul 2018 17:40:18 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w6AHeIoI067884 for toolchain@FreeBSD.org; Tue, 10 Jul 2018 17:40:18 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: toolchain@FreeBSD.org Subject: [Bug 222858] Clang doesn't find and libomp.so when compiling with -fopenmp Date: Tue, 10 Jul 2018 17:40:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: 11.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: mi@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: toolchain@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2018 17:40:20 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D222858 Mikhail Teterin changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jbeich@FreeBSD.org, | |mi@FreeBSD.org, | |portmgr@FreeBSD.org --- Comment #2 from Mikhail Teterin --- Meanwhile, perhaps, Uses/compiler.mk can be taught to use the base clang wi= th the right options, when compiler:openmp is among ${USES} -- instead of insisting on gcc? --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-toolchain@freebsd.org Tue Jul 10 18:37:05 2018 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1ADC01044A50 for ; Tue, 10 Jul 2018 18:37:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id A82C784F91 for ; Tue, 10 Jul 2018 18:37:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 68BBC1044A4F; Tue, 10 Jul 2018 18:37:04 +0000 (UTC) Delivered-To: toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 54BCB1044A4E for ; Tue, 10 Jul 2018 18:37:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DE36E84F86 for ; Tue, 10 Jul 2018 18:37:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 2710911C7F for ; Tue, 10 Jul 2018 18:37:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w6AIb30S041317 for ; Tue, 10 Jul 2018 18:37:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w6AIb3LG041316 for toolchain@FreeBSD.org; Tue, 10 Jul 2018 18:37:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: toolchain@FreeBSD.org Subject: [Bug 222858] Clang doesn't find and libomp.so when compiling with -fopenmp Date: Tue, 10 Jul 2018 18:37:02 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: misc X-Bugzilla-Version: 11.1-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: toolchain@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2018 18:37:05 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D222858 --- Comment #3 from Jan Beich --- (In reply to Mikhail Teterin from comment #2) That would be bug 210337. USES=3Dcompiler:openmp cannot use Clang in base on FreeBSD 10.* because -fopenmp is ignored there, cannot use Clang from devel/llvm60 on FreeBSD 10.* because OPENMP is unconditionally disabled in = the port, cannot use Clang on non-x86 where LLVM openmp isn't supported (on FreeBSD) and Clang cannot use libgomp (from lang/gcc*). And lang/gcc* is of= ten required by USES=3Dfortran consumers directly or via libgcc_s pollution. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-toolchain@freebsd.org Wed Jul 11 16:21:23 2018 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4C5121022B0E for ; Wed, 11 Jul 2018 16:21:23 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic304-11.consmr.mail.bf2.yahoo.com (sonic304-11.consmr.mail.bf2.yahoo.com [74.6.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E31F679CB6 for ; Wed, 11 Jul 2018 16:21:22 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: FzJZtDsVM1laMAzoMkgUJmeFZ6LTReUB_EPmfqM5J.d7wN.T8PO50DKdWjWW6PQ HFPmtlGGF1bNTlDeUJ4WVe.TdNEntkXpgNfsynFUUTDqrb7hWpo7G5ZxvoIANsUkRyEn.NiiTgTc m2QXfNoV1BTsx13xD3FHqpQK7Vi5xanxmZVI.EoAZItS4CaOONvLqMnJHx1R7.999_KCkyVycRCq akZRbs007.fWVKxTjX3D_qnVLTCondgKxZDLGlDUG3znUW3R8pu0.lQQX2noT0uBGhYWmxJ24Qpd wLAcOmKAUCqNyRBo2e5QWD_n2QG7I_SV8yR02nZhwSzOmvFVwIix5rN1gORnAt3byWW.ehYhcZAq G947MTWvQyghblVL6NSzlrHgoe1TpF2G2n48eMHNNYcNnWK6oSVkY7rpHRhZBbkSamLeGuXiVb9P vMswX0F5AIfjh2N4Dp11Hj9GgNyZMIiDIJBksZwNzoo.BPLrPYmQlmhkIihV1BT9Hkm16q4qBmJo rL0vh9AJ8MCZtiahifO93T3pIed5UWXULBC8AAvvx2xETOsnbJDKbA2n.LqXzQgq8uysCsBYoUCd 6xYmug83ceU9c6t51a18.QV2PF7M5N6DhLWqo.JZFPfpUnyC2mysZZ1k6_E2FRWVoi6Tvv0nZ1C7 jVENf0dhK8qBljpT_xbjtdS5ursbSqiPJAuqw1_kC.aQ3dk0lUi5bU0DsFo4_p9vII9t_hMQkVa8 oAoRJlMoAzWuROzVupO501Wq0N5pMHLwoXuJRGh.bQynTbU8l4eIN7LuB0Fzp9Tv_XTZ_yo86dMs ki9qZSgXy_MI1jLew7iT1nNgIrAX.r_fxRdaKd_rkMPDNJr5MCWN.rNzLXBVVbvuyz39e3hhVlj9 sbUXCd0wiTbrc2wrIlzRgkDrwH5kHFCnOJp8.jNny_T34IuDdvn_IuNCKnzk5i2B_ocdkivTCnqm LwTaFF1UZOVpft2B1eSckkwFaMAvb.h0LTzGCJb2r31lakuXIAnrKUtQ17wSDqQEZhA5CShs- Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.bf2.yahoo.com with HTTP; Wed, 11 Jul 2018 16:21:22 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.105]) ([70.189.131.151]) by smtp411.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID ccafd419de053a23f276ec87f9262c21; Wed, 11 Jul 2018 16:21:19 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: aarch64-arm64 fails to build kernel 12-current raspberry pi 3 Message-Id: Date: Wed, 11 Jul 2018 09:21:17 -0700 To: FreeBSD Current , freebsd-arm , FreeBSD Toolchain X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2018 16:21:23 -0000 tech-lists tech-lists at zyxst.net wrote on Wed Jul 11 11:42:58 UTC 2018 : > Hello lists [x-posted to -current where it's also relevant] >=20 > 12-current-arm64 fails to build generic-nodebug kernel >=20 > context: > 12.0-CURRENT #0 r336134: Mon Jul 9 GENERIC arm64 (this is the older = rpi3B+) >=20 >=20 > root at rpi3 > :/usr/src# svnlite info > Path: . > Working Copy Root Path: /ext/src > URL:=20 > https://svn.freebsd.org/base/head >=20 > Relative URL: ^/head > Repository Root:=20 > https://svn.freebsd.org/base >=20 > Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f > Revision: 336195 > Node Kind: directory > Schedule: normal > Last Changed Author: eugen > Last Changed Rev: 336195 > Last Changed Date: 2018-07-11 10:41:50 +0100 (Wed, 11 Jul 2018) >=20 > Some dirs on /usr are symlinked to a 1TB external disk. Swap is on the=20= > external disk. Made sure there was no src.conf or make.conf present: >=20 >=20 > root at rpi3 > :/root# cd /etc >=20 > root at rpi3 > :/etc# mv src.conf old.src.conf >=20 > root at rpi3 > :/etc# mv make.conf old.make.conf >=20 > root at rpi3 > :/etc# cd /usr/src >=20 >=20 > root at rpi3 > :/usr/src# rm -rf /ext/obj >=20 > root at rpi3 > :/usr/src# mkdir /ext/obj >=20 > root at rpi3 > :/usr/src# ls -lah /usr > total 72 > drwxr-xr-x 12 root wheel 512B Jul 10 11:15 . > drwxr-xr-x 20 root wheel 512B Jul 10 18:45 .. > drwxr-xr-x 2 root wheel 7.5K Jul 9 20:45 bin > drwxr-xr-x 2 root wheel 512B Jul 10 11:15 home > drwxr-xr-x 56 root wheel 6.5K Jul 9 20:44 include > drwxr-xr-x 10 root wheel 16K Jul 9 20:45 lib > drwxr-xr-x 5 root wheel 512B Jul 9 20:28 lib32 > drwxr-xr-x 5 root wheel 512B Jul 9 20:28 libdata > drwxr-xr-x 9 root wheel 1.5K Jul 9 20:45 libexec > lrwxr-xr-x 1 root wheel 10B Jul 10 11:43 local -> /ext/local > lrwxr-xr-x 1 root wheel 8B Jul 10 11:41 obj -> /ext/obj > lrwxr-xr-x 1 root wheel 10B Jul 10 11:41 ports -> /ext/ports > drwxr-xr-x 2 root wheel 5.0K Jul 9 20:45 sbin > drwxr-xr-x 29 root wheel 512B Jul 9 20:28 share > lrwxr-xr-x 1 root wheel 8B Jul 10 11:41 src -> /ext/src > drwxr-xr-x 15 root wheel 512B Jul 9 20:46 tests >=20 >=20 > root at rpi3 > :/usr/src# make -j10 cleanworld && make -j10 cleandir && make=20 > -j10 clean <--- just to make absolutely sure >=20 > [...] >=20 > RPI3 is just a copy of GENERIC-NODEBUG. it looks like this: >=20 > include GENERIC >=20 > ident RPI3 >=20 > nooptions INVARIANTS > nooptions INVARIANT_SUPPORT > nooptions WITNESS > nooptions WITNESS_SKIPSPIN > nooptions DEADLKRES > nooptions USB_DEBUG >=20 >=20 > root at rpi3 > :/usr/src# make -j1 buildkernel KERNCONF=3DRPI3 >=20 > [...] [Like a answered in freebsd-arm . . .] Bugzilla 220125 (from over a year ago) is a non-fixed report about this = for the likes of: make kernel-toolchain buildkernel Over the time since then the workaround was to use: make buildworld buildkernel buildworld put the needed stdint.h in place, kernel-toolchain did not. If kernel-toolchain was in use, then the recent bugzilla 229702 and this exchange is a duplicate. If buildworld was in use then 229702 and this exchange is new. [Added note . . .] It seems from the quoted material that neither kernel-toolchain nor build world was done before buildkernel . My understanding is that the intent is that one or the other be done first. (But for aarch64 currently only buildworld works.) =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-toolchain@freebsd.org Thu Jul 12 09:44:11 2018 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9FB4010479BC; Thu, 12 Jul 2018 09:44:11 +0000 (UTC) (envelope-from tech-lists@zyxst.net) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3886B867A8; Thu, 12 Jul 2018 09:44:11 +0000 (UTC) (envelope-from tech-lists@zyxst.net) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id DEA442FF; Thu, 12 Jul 2018 05:44:02 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 12 Jul 2018 05:44:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zyxst.net; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=EMaXimHYrrdwjfoLDZYA2Mh9PsoDZ fqkBUQyA1Xm27g=; b=BpHBge6vwlsNpJToPgMayqyEEJJOv4vZiV1AT3iRJiFO8 i9UqhltNg7ZkL53dXwYqdpohQA5ueRPYT+XjO8nU+4Oc9Iyh1gqmI7ome6m//uJx cQiSkvrSR673IImoqPH2sqv8ER03ailK2F0lk08/7yiZ5BEfrEiF+JYvjmlJ1Uvd R75uoOseWu9Khz7HWOLa03xxtZu9MdIL5/6kXlj+MauXay09AmM6UcYqDEKAzbZc kdlgz6WLLQ3cMMZYatK6Mk55hqJh53AjxED789u5Y9cA5Nj77o5oKB1UZ++/82sr GaVDulsoVvBQAmq4hSXygFjF+0krG449OY7syrn+w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=EMaXim HYrrdwjfoLDZYA2Mh9PsoDZfqkBUQyA1Xm27g=; b=M2EAaGPZ1sYNbvnFjuTRjD 9q5qpHm1TjmqOsv0tp/dyO6T2Y05da1V1a4KvCsdzBTROoqSOLDCdkrFkDFxD+MN RrFJLwXV4c2cz6JzBZzRRlpslYkXRCC0I+3b1LAKO15zcNYv0o2ayJF2J7A4Xca5 NfTdP+mU8IfYQKJ23jsbuNwXh8ds2DDP3/siroPdw/Bt+R8EhuMsSLvXE/sF29jS TaGjY8bdvgiOlimbq/02g0zbVyLdkJlgExdWWcCDI1d9sLQfpQ8ekaPhN72CmQ/r TwljdAPkleiEuGb0feoNrJLkDERWvLNCP/s5EYD3acNDm86ZjlKdF72IVCLkoKLA == X-ME-Proxy: X-ME-Sender: Received: from desktop.local (parsley.growveg.org [82.70.91.97]) by mail.messagingengine.com (Postfix) with ESMTPA id 56A871026B; Thu, 12 Jul 2018 05:44:01 -0400 (EDT) Subject: Re: aarch64-arm64 fails to build kernel 12-current raspberry pi 3 To: Mark Millard , FreeBSD Current , freebsd-arm , FreeBSD Toolchain References: From: tech-lists Organization: none Message-ID: Date: Thu, 12 Jul 2018 10:44:00 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 09:44:11 -0000 On 11/07/2018 17:21, Mark Millard wrote: > It seems from the quoted material that neither kernel-toolchain nor > build world was done before buildkernel . My understanding is that > the intent is that one or the other be done first. (But for aarch64 > currently only buildworld works.) Thanks for this. I'm running a buildworld now. For how long has it been the case that buildworld is needed for buildkernel? Coming from amd64 and before that, i386, in situations where I've only wanted to install a custom kernel, I was firstly used to making and installing it from /sys/{i386,amd64}/conf. Then that broke a number of years ago. Then got used to making kernel in /usr/src with make buildkernel && make installkernel. And now this is broken, on aarch64-arm64. Nobody knows if it's accidental or policy. -- J. From owner-freebsd-toolchain@freebsd.org Thu Jul 12 13:34:07 2018 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 82C9D1039D73 for ; Thu, 12 Jul 2018 13:34:07 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic301-21.consmr.mail.gq1.yahoo.com (sonic301-21.consmr.mail.gq1.yahoo.com [98.137.64.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 075F3917BD for ; Thu, 12 Jul 2018 13:34:06 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: OEY7IvoVM1le6b8GP7GhYjAG4CyYHT3qP1VlNmQ3sxV8jd3Ezvfrj7rHc0guaFk pLHrvaOTp.YOJ8ohWiphXmu0Hr.4bNMRJ6k8aAC1JYdNtiBAsspnuBkxDv4IzrZso.d9NVXhUJLe G15UtsLMRBfn6bWmGMaOfHguahm0KKKHc2PSLSYSU9ku9nXR92cBWhv2hrA3WL_CR4X22PIjIQUz KUOBlA2rGiYqDkHeMOHm.b3IUa42oDH3H2xQSyQ5WxfzW7IQjOPiy0FpxYmsJ6tQFadllm8nVHlo edC6Oa95qGHwLirSwXEaWkHUQCHgTqbaaU0DFRgUWiWdjsD9bq86Ajzj22.0J2YG0gObRdAFTWPT RLTeXwO.SMttMBpCU918G0pQGGDofqOcete.G0yTlijtbKKZqYnUaqiI3j4gkiNnOUF4IxHaIxYt yq3_b5dffO2bSakQSUJAz10kT9GkTrP_vJaM9jimb5R7AcKaHFB5jWoNfj53Zv58q_RAfZNVkLhZ esBBnG0XU0OcX7FXbqybiwoOU1VOzfYxiqI7uuA2Fuuw6SGrN5DY5HXaAEld3U9xaCSpsy_SGr5g qQGV2eeKXTfwtsLITZ3mUMvyHIbOlnc0cWriwkZgPB38L02zx.xImrPYPXrLCaO.9bSgd9e8qY8K s2xzGkZxIiRnjuhuXAMhCHX2bokDkNl75R4fL1qOAeq1F66hDlGMkQ.B9os3N5w.zipnaaIxKLGN IvO9ZmSfgclVmhuuPAlGcSi7TBRa0fOLGGaeCEVl6yia4dOwXubr3S5.FdaPZs1hdoF007yoTMk5 psY6qtTFy6Fys7XbElqT9gKcinjibJ6LHP9rLKuUsynmlRHgdcOv7OfSddJMc9oocYqo4zQHnSCH hgniFp.bCIWPwPm7G_qTG.25M_UIraMHAmeL89CD01sjuaJTpdMxbaM74QogvvWudQUu3RkAGuHu afA0gItpgfkW9NGotujA9S9WHwox_zlvEqRQu3x.dyE._VGf3WtRTW7xnszN33NrMhTdi Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.gq1.yahoo.com with HTTP; Thu, 12 Jul 2018 13:34:00 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.105]) ([70.189.131.151]) by smtp422.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID a5dfb848dc8c05f45d2906755df2006c; Thu, 12 Jul 2018 13:23:51 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: aarch64-arm64 fails to build kernel 12-current raspberry pi 3 From: Mark Millard In-Reply-To: Date: Thu, 12 Jul 2018 06:23:49 -0700 Cc: FreeBSD Current , freebsd-arm , FreeBSD Toolchain Content-Transfer-Encoding: quoted-printable Message-Id: <2F72F7DB-F5DD-471A-B644-9CDE3FABFAC1@yahoo.com> References: To: tech-lists X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 13:34:07 -0000 On 2018-Jul-12, at 2:44 AM, tech-lists wrote: > On 11/07/2018 17:21, Mark Millard wrote: >> It seems from the quoted material that neither kernel-toolchain nor >> build world was done before buildkernel . My understanding is that >> the intent is that one or the other be done first. (But for aarch64 >> currently only buildworld works.) >=20 > Thanks for this. I'm running a buildworld now. >=20 > For how long has it been the case that buildworld is needed for = buildkernel? Coming from amd64 and before that, i386, in situations = where I've only wanted to install a custom kernel, I was firstly used to = making and installing it from /sys/{i386,amd64}/conf. Then that broke a = number of years ago. Then got used to making kernel in /usr/src with = make buildkernel && make installkernel. And now this is broken, on = aarch64-arm64. Nobody knows if it's accidental or policy. It has been true since clang added use of stdint.h to the kernel build. Prior to this stdint.h was not needed to build the kernel for any architecture (as far as I know). As I remember, in C99 or later stdint.h is one of the headers required for a conforming freestanding implementation of C99+. stdint.h was added to C in C99. It was intended to be the subset of the older inttypes.h that was suitable for freestanding environments. inttypes.h is defined to include stdint.h for C99 and later as I remember (or to behave as-if it had?). https://www.freebsd.org/cgi/man.cgi?build(7) is very explicit about what is supposed to be the case relative to kernel-toolchain use: kernel-toolchain Rebuild the tools needed for kernel compilation. = Use this if you did not do a buildworld first. In other words: buildkernel is not intended to be = self-contained/sufficient according to the build documentation but buildworld should not be = required. Note the difference in the buildkernel and buildworld descriptions, = given the above: buildkernel Rebuild the kernel and the kernel modules. The = object directory can be changed from the default = /usr/obj by setting the MAKEOBJDIRPREFIX make(1) variable. vs. buildworld Build everything but the kernel, configure files = in etc, and release. The object directory can be changed = from the default /usr/obj by setting the = MAKEOBJDIRPREFIX make(1) variable. The actual build location = prefix used is ${MAKEOBJDIRPREFIX}${.CURDIR} for native = builds, and ${MAKEOBJDIRPREFIX}/${TARGET}${.CURDIR} for cross = builds and native builds with variable = CROSS_BUILD_TESTING set. Currently, overall, FreeBSD does not meet its own criteria for aarch64 = relative to kernel-toolchain . As far as I can tell the issue can be summarized relative to = kernel-toolchain by saying that kernel-toolchain does not currently establish a (full) freestanding C99 environment relative to the headers but clang requires (at least) one of the missing items ( stdint.h ) for aarch64. =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-toolchain@freebsd.org Thu Jul 12 18:32:48 2018 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4689C103134A; Thu, 12 Jul 2018 18:32:48 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CE46877ADC; Thu, 12 Jul 2018 18:32:47 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from coleburn.home.andric.com (coleburn.home.andric.com [192.168.0.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 6F3285701C; Thu, 12 Jul 2018 20:32:39 +0200 (CEST) From: Dimitry Andric Message-Id: <6DDED0A0-588D-4323-8E22-1267AA06615E@FreeBSD.org> Content-Type: multipart/signed; boundary="Apple-Mail=_538A729A-DF98-48DA-807D-508A89EBF62C"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: aarch64-arm64 fails to build kernel 12-current raspberry pi 3 Date: Thu, 12 Jul 2018 20:32:30 +0200 In-Reply-To: <2F72F7DB-F5DD-471A-B644-9CDE3FABFAC1@yahoo.com> Cc: tech-lists , freebsd-arm , FreeBSD Current , FreeBSD Toolchain To: Mark Millard References: <2F72F7DB-F5DD-471A-B644-9CDE3FABFAC1@yahoo.com> X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 18:32:48 -0000 --Apple-Mail=_538A729A-DF98-48DA-807D-508A89EBF62C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 12 Jul 2018, at 15:23, Mark Millard via freebsd-toolchain = wrote: >=20 > On 2018-Jul-12, at 2:44 AM, tech-lists = wrote: >=20 >> On 11/07/2018 17:21, Mark Millard wrote: >>> It seems from the quoted material that neither kernel-toolchain nor >>> build world was done before buildkernel . My understanding is that >>> the intent is that one or the other be done first. (But for aarch64 >>> currently only buildworld works.) >>=20 >> Thanks for this. I'm running a buildworld now. >>=20 >> For how long has it been the case that buildworld is needed for = buildkernel? Coming from amd64 and before that, i386, in situations = where I've only wanted to install a custom kernel, I was firstly used to = making and installing it from /sys/{i386,amd64}/conf. Then that broke a = number of years ago. Then got used to making kernel in /usr/src with = make buildkernel && make installkernel. And now this is broken, on = aarch64-arm64. Nobody knows if it's accidental or policy. >=20 > It has been true since clang added use of stdint.h to the kernel = build. > Prior to this stdint.h was not needed to build the kernel for any > architecture (as far as I know). No, it's because sys/crypto/armv8/armv8_crypto_wrap.c includes , an intrinsics header, which in turn requires . This was introduced in https://svnweb.freebsd.org/changeset/base/308921, and at the time resulted in similar build failures, specifically when one attempted to build a new kernel, without building world or a new toolchain first. -Dimitry --Apple-Mail=_538A729A-DF98-48DA-807D-508A89EBF62C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCW0eevgAKCRCwXqMKLiCW o2PxAKDD0fu/b9FzE0adQQw7NOoggolVPgCfWlY233kbNrNJXnvnQCIFOD4OAhY= =e9Ml -----END PGP SIGNATURE----- --Apple-Mail=_538A729A-DF98-48DA-807D-508A89EBF62C-- From owner-freebsd-toolchain@freebsd.org Thu Jul 12 20:07:42 2018 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B1B79103F598 for ; Thu, 12 Jul 2018 20:07:42 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic311-22.consmr.mail.gq1.yahoo.com (sonic311-22.consmr.mail.gq1.yahoo.com [98.137.65.203]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2D0727D22E for ; Thu, 12 Jul 2018 20:07:41 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: rm40ypUVM1nNNXMc5qhht29uIIVeK6g8VtwLjCllCZcpLOQ6Ml8cOrCZ3qzcYGA cBZc6qSqPawwK64Ib.46IvjG5xxX0W8Gb8XRNwRWqihFWkUHjNTW2hzBc6BQJZAe_fvYmuadxhUB IEs8kWmlM256WwqVNSqAEqzrcBE09GSzQLnqdqTJfmlWVGAqZsSu4X.ndsS8d6o315CTSsSqfjDv 8otGbWGLIRNVpns0Vi7LNOh.UP7WOEUxHJzsMv4HtTc5_3FomS0iodjiVeh1jA.vA1YJccIY6KMs Xgu56_Pqu31xqXrHMITm_lcgkHx8I9TQ89Vz1Zp8T16_3pGieAV_DavV7e_l7XWPslGNDXD1gGl0 OkYdjO3XqA8B8gSaqRpIJ9z3_6V7qem8aKSVDdlJ.ZWmJrMz88WWCbQ5Q.xrW.Npxb4LImfMPfN5 IsUuEEsliFMGN7fWs51KSfA4OxpgOOlmHHTmwnR7drg3wGbhMqjB0KEHq1MrMGpIXhLp_5oKjmSm LxoWZDoM8eSv3G4SAd4DsgI5qqBNSV5E3f9WiUT0BzPal3oRl8LuZK0y9lobAkGIISs2E7COALvS Mrd5XZg2Q8ryLP2rhOjyGIgNmjtO1Z8Vaz75nW7gY3QlPEBaGXEVvktzZtUBUWYDFnvpf5HUHcY6 WWaK9m4_f5szWm9QcDnfco.1Hc3rVLVDirzQsJsg2AspiUxJgR2Vuni0xLy.ex3idMV_2algS0oa FzqVbZO0rTke_cTwE0PgyNTbtIRATnx3UNlZwUXs1KXlilQ6epSMd3IVFn.t0AaQhIQtgBKfWby0 OTwF9ukLEwDGp7c7OZiFVFe7_Wr6Wr3anMAslWV1FPpNpfYJuYcTM6lKQzhDYjRVIECAnV8.0fpx ktLr5pX3NDXYJQVPWBS58vY.MIbIVqgsCL.cxMU0i6GyNtq_YzjV.VyL4PhJlfF_qGSa.Aj7cfIR rE8W2V4iBgLxQGT5.9zNZJspD9jk5zHz7Z67Gjv1fi7P9BnSrG6bTqrnsayEBw0hfqf5A Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.gq1.yahoo.com with HTTP; Thu, 12 Jul 2018 20:07:35 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.105]) ([70.189.131.151]) by smtp418.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID d319fa0f46a596cc767bf15d582c1f37; Thu, 12 Jul 2018 20:07:33 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: aarch64-arm64 fails to build kernel 12-current raspberry pi 3 From: Mark Millard In-Reply-To: <6DDED0A0-588D-4323-8E22-1267AA06615E@FreeBSD.org> Date: Thu, 12 Jul 2018 13:07:32 -0700 Cc: tech-lists , freebsd-arm , FreeBSD Current , FreeBSD Toolchain Content-Transfer-Encoding: quoted-printable Message-Id: <3723A682-71BD-4654-9DCB-6FCBF12BEC49@yahoo.com> References: <2F72F7DB-F5DD-471A-B644-9CDE3FABFAC1@yahoo.com> <6DDED0A0-588D-4323-8E22-1267AA06615E@FreeBSD.org> To: Dimitry Andric X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 20:07:43 -0000 On 2018-Jul-12, at 11:32 AM, Dimitry Andric wrote: > On 12 Jul 2018, at 15:23, Mark Millard via freebsd-toolchain = wrote: >>=20 >> On 2018-Jul-12, at 2:44 AM, tech-lists = wrote: >>=20 >>> On 11/07/2018 17:21, Mark Millard wrote: >>>> It seems from the quoted material that neither kernel-toolchain nor >>>> build world was done before buildkernel . My understanding is that >>>> the intent is that one or the other be done first. (But for aarch64 >>>> currently only buildworld works.) >>>=20 >>> Thanks for this. I'm running a buildworld now. >>>=20 >>> For how long has it been the case that buildworld is needed for = buildkernel? Coming from amd64 and before that, i386, in situations = where I've only wanted to install a custom kernel, I was firstly used to = making and installing it from /sys/{i386,amd64}/conf. Then that broke a = number of years ago. Then got used to making kernel in /usr/src with = make buildkernel && make installkernel. And now this is broken, on = aarch64-arm64. Nobody knows if it's accidental or policy. >>=20 >> It has been true since clang added use of stdint.h to the kernel = build. >> Prior to this stdint.h was not needed to build the kernel for any >> architecture (as far as I know). >=20 > No, it's because sys/crypto/armv8/armv8_crypto_wrap.c includes > , an intrinsics header, which in turn requires . >=20 > This was introduced in = https://svnweb.freebsd.org/changeset/base/308921, > and at the time resulted in similar build failures, specifically when > one attempted to build a new kernel, without building world or a new > toolchain first. Sorry. I was distracted this morning and should have cross checked my claims instead of quickly babbling off the top of my head. =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-toolchain@freebsd.org Fri Jul 13 10:15:32 2018 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D6E21103244C; Fri, 13 Jul 2018 10:15:31 +0000 (UTC) (envelope-from tech-lists@zyxst.net) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 797D57E795; Fri, 13 Jul 2018 10:15:31 +0000 (UTC) (envelope-from tech-lists@zyxst.net) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 14A6D21FE5; Fri, 13 Jul 2018 06:15:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 13 Jul 2018 06:15:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zyxst.net; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=OippaRKapkCahOpgibX+QMrsj8rux X9DVzhDXdn4DBk=; b=CcIyeix5WyR1WXWVNWAJzgUSkbRMm7yiZraEuf/XiOmF9 FjoFw6fpb7kdFT1ITZeysTat4NmBozMgb0QqQi/Pk1OTrZILlvs23jsFa4hwQ6m0 SObHe4Q/2WRxEnKl1oCZh5f1N27kT1pV/QSiWzUIF/wjH3ldg621KnjKbcJVvDsy JBGqlRz5K29kK75JGUj4aBYVpHs86uQBHQiDQHg0C8DN95qfOUzQSmQWawOThpoo aFw+ntWkVpMS43HBiYMSn2spX4D0ryepuv60lx5xuRRXEYusp04aK6Z0szKPMtvK 19WFVXaZT8Yr8Y+2GR1RA1j8HYQnCKHIL9R65X37g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=OippaR KapkCahOpgibX+QMrsj8ruxX9DVzhDXdn4DBk=; b=HEv9AfKGy/2e/wguTFT+ZH +5lhtWKD+Y5JnMBBDz3Pnr0uorXnCxxAuroUq6XIxLyZrnLKQh6owWdC2oEVx0lw KmkZ65TQjTzTo48oxs1P8llBLYcVESbfzrzk8oDFLzEqRki62KHHZ4Q2MEDwQBeS eeflVOGNfp+Akzb7Eh8JJ5uhinlf0ZuGjIje+gJClvFgkvGtQdm+jk2N+5UgJ+4g eO68QmDef7xZX6fTsKnCDcNNoP0NhKr6xYZkuAqeP1TEcLax4TWLtMYTYiSkM7Be eTTR8zVsYuRxYIowEllOCZNNel9nbijp1vK7L6L+QxERiYbQO1yRRIImndpSH2Nw == X-ME-Proxy: X-ME-Sender: Received: from desktop.local (parsley.growveg.org [82.70.91.97]) by mail.messagingengine.com (Postfix) with ESMTPA id E7F13E4636; Fri, 13 Jul 2018 06:15:23 -0400 (EDT) Subject: Re: aarch64-arm64 fails to build kernel 12-current raspberry pi 3 To: Dimitry Andric , Mark Millard Cc: freebsd-arm , FreeBSD Current , FreeBSD Toolchain References: <2F72F7DB-F5DD-471A-B644-9CDE3FABFAC1@yahoo.com> <6DDED0A0-588D-4323-8E22-1267AA06615E@FreeBSD.org> From: tech-lists Organization: none Message-ID: Date: Fri, 13 Jul 2018 11:15:22 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <6DDED0A0-588D-4323-8E22-1267AA06615E@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 10:15:32 -0000 On 12/07/2018 19:32, Dimitry Andric wrote: > No, it's because sys/crypto/armv8/armv8_crypto_wrap.c includes > , an intrinsics header, which in turn requires . > > This was introduced inhttps://svnweb.freebsd.org/changeset/base/308921, > and at the time resulted in similar build failures, specifically when > one attempted to build a new kernel, without building world or a new > toolchain first. Hi, Ok, it's finished building and installing. The command I used was this: # make -j10 buildworld && make -j10 buildkernel KERNCONF=RPI3 and it all built, (so I'll close the PR I opened). Then I did make installkernel KERNCONF=RPI3 and because I thought might as well install everything now it's built, mergemaster -p and make installworld && mergemaster -Ui. So I take it then, that every time I want to build a kernel, I either have to do the above or use make kernel-toolchain. Is this correct? thanks, -- J. From owner-freebsd-toolchain@freebsd.org Fri Jul 13 12:30:22 2018 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2A30E103A935 for ; Fri, 13 Jul 2018 12:30:22 +0000 (UTC) (envelope-from jonathan@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D88CD83B16 for ; Fri, 13 Jul 2018 12:30:21 +0000 (UTC) (envelope-from jonathan@FreeBSD.org) Received: from [134.153.3.180] (jacob.engr.mun.ca [134.153.27.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: jonathan/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 97F34F1DB for ; Fri, 13 Jul 2018 12:30:21 +0000 (UTC) (envelope-from jonathan@FreeBSD.org) From: "Jonathan Anderson" To: freebsd-toolchain@freebsd.org Subject: Clang 6.0.[01]: UNREACHABLE executed Date: Fri, 13 Jul 2018 10:00:19 -0230 X-Mailer: MailMate (1.11.3r5509) Message-ID: <95573ED5-49CD-4BC6-863D-849C1CAA774D@FreeBSD.org> MIME-Version: 1.0 X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 12:30:22 -0000 Hi all, I recently ran into an unreachable statement execution in Clang 6, both with v6.0.0 from the llvm60 package and v6.0.1 from HEAD (FreeBSD r335799 / LLVM r335540). I don't see this issue in Clang 5 or in the version that ships with macOS High Sierra (which they're calling 9.1.0, but that's apparently more of a "marketing version" than a true version number). creduce managed to shrink my 2.8 MiB preprocessed sources down to a 604 B test case: https://gist.github.com/trombonehero/2da555bd1292be973f9d14c843c56ae5 This isn't a valid C++ file (e.g., it cuts off after `return o` on line 23), but I would expect it to cause compiler errors rather than a compiler crash. You can see the output from the crash at: https://gist.github.com/trombonehero/8fce4a8f39ae121a2f9f14b45b0b65a1 Any thoughts? Jonathan Anderson -- jonathan@FreeBSD.org From owner-freebsd-toolchain@freebsd.org Fri Jul 13 15:27:21 2018 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4B35D104088D for ; Fri, 13 Jul 2018 15:27:21 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic310-14.consmr.mail.bf2.yahoo.com (sonic310-14.consmr.mail.bf2.yahoo.com [74.6.135.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DA1668B16B for ; Fri, 13 Jul 2018 15:27:20 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: unhdnzIVM1kWBto7x6j6I96FGZ.etS60DFg4U3OTBLiyk4Q7rYcUlxDkykJe1dM iNM5PL9MaacU90ETusGM_3hEP9bZr6KZvQNffxnpkpUxsAXaQPROyQv4Sg5.Lo5Q1bp.H91xq25R i3tb_eiidhIVBsjhmDJJuYywJISahG9zIWQizmhz7EPCPYB0LwP1pT9Ij_8xjkIfsR0sU7mnDdP2 KmqtN9FDUIWD_9GXdBviJLne56XJZ5f77Vmldp.q38mx69J3CeGGR8hwSHdmRS0hUCtLfr9.qYUI 9BDUy4Bu8MkeMOFTMTkf1WoOgV0Pe_tJK0UL4C6vWirbak9SFJb_kakRuI6C8RKHdGR364H7l.6p zb4N.lUdyeme3RMVHHkRjMeNob2YY643DiH3l70RC.i6Otik1D2QQrmPP4JSB0DzrHixjth0LlSs kjW776_NrTQ.QFI.hzlVAS2iSbuj9XbLAyJrv4wCraadYmJ6aSr6tJVHeFGe.V.DohpOGwnfvKxk Df5.rcUFxavVeYlEKN_9aZi7_jBYcXRU5LJ5RwkjcQ1KI_3HhKVmBYL8eOenyVsFUD7Icq7YMM9W 0NSs2T8J5Yjon4EMiSIIxv_vWeaFMKC3_LZ34c.DS_nS9YXTEMHPWN6FJ1q9XqCbgURIX4P158rL um69AkVAkEsyw5lGdIbzuakBZwXRllJguCn1FVwEQaF7G34WxpIoJDhHuD8dBkZSzTfaBWKfhRJ3 1rygbxDnGi8RmQitqjud.ObdEarDYaQCsmKLkILn.E6.DS2leG3WO5XT.8c7LZcChXAbbwjWPT4j 7Zfbt5aZbz_CMZkKvyUEUulhMMcrVc8L_wyojOcUxfuYiMmvXee28vU9EdGp1pLNY.PEIZ7blebL TkYlQN6pOXYo7sxu_qxjqXHUKtfRiforw2b543yp5UwOFRWSvMLNg4nMG0.iU6rhFzd0Mje2CqkE tdSMIaMHLexPH0kD12hosgNinexwv08eTyuS9WW4PncrMNXp0tiKNj0qpp75d5Vka.3zkkg-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.bf2.yahoo.com with HTTP; Fri, 13 Jul 2018 15:27:14 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.105]) ([70.189.131.151]) by smtp404.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 397c607cf7ff4eb30e9b1315c185d34f; Fri, 13 Jul 2018 15:27:12 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: aarch64-arm64 fails to build kernel 12-current raspberry pi 3 From: Mark Millard In-Reply-To: Date: Fri, 13 Jul 2018 08:27:10 -0700 Cc: Dimitry Andric , freebsd-arm , FreeBSD Current , FreeBSD Toolchain Content-Transfer-Encoding: quoted-printable Message-Id: <43C85CB9-2F8A-4DB2-85F3-CAE6371666E4@yahoo.com> References: <2F72F7DB-F5DD-471A-B644-9CDE3FABFAC1@yahoo.com> <6DDED0A0-588D-4323-8E22-1267AA06615E@FreeBSD.org> To: tech-lists X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 15:27:21 -0000 On 2018-Jul-13, at 3:15 AM, tech-lists wrote: > On 12/07/2018 19:32, Dimitry Andric wrote: >> No, it's because sys/crypto/armv8/armv8_crypto_wrap.c includes >> , an intrinsics header, which in turn requires = . >> This was introduced = inhttps://svnweb.freebsd.org/changeset/base/308921, >> and at the time resulted in similar build failures, specifically when >> one attempted to build a new kernel, without building world or a new >> toolchain first. >=20 > Hi, >=20 > Ok, it's finished building and installing. The command I used was = this: >=20 > # make -j10 buildworld && make -j10 buildkernel KERNCONF=3DRPI3 make -j10 buildworld buildkernel KERNCONF=3DRPI3 would have worked. > and it all built, (so I'll close the PR I opened). Then I did make = installkernel KERNCONF=3DRPI3 and because I thought might as well = install everything now it's built, mergemaster -p and make installworld = && mergemaster -Ui. >=20 > So I take it then, that every time I want to build a kernel, I either = have to do the above or use make kernel-toolchain. Is this correct? If you first clear out the old build, then such would be true. (Where, for targeting aarch64, kernel-toolchain needs to be avoided.) But you can buildkernel using the results of the existing buildworld (or kernel-toolchain if it applies) when it is okay to not clear out the old build first. (kernel developers doing kernel development likely do this a lot.) Another way to make tradeoffs is to use META_MODE so that partial rebuilds are done, avoiding some of the strictly unnecessary rebuild activity. This would involve buildworld or kernel-toolchain (as appropriate for the target architecture). =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-toolchain@freebsd.org Fri Jul 13 16:45:44 2018 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5519510439FF for ; Fri, 13 Jul 2018 16:45:44 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DE6E38E726; Fri, 13 Jul 2018 16:45:43 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from coleburn.home.andric.com (coleburn.home.andric.com [192.168.0.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id D0250570BC; Fri, 13 Jul 2018 18:45:41 +0200 (CEST) From: Dimitry Andric Message-Id: <51FD8F40-A5B8-4292-ACD4-A0105E428311@FreeBSD.org> Content-Type: multipart/signed; boundary="Apple-Mail=_16AB790B-1DE4-4E11-A041-73E0BDB3F471"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: Clang 6.0.[01]: UNREACHABLE executed Date: Fri, 13 Jul 2018 18:45:38 +0200 In-Reply-To: <95573ED5-49CD-4BC6-863D-849C1CAA774D@FreeBSD.org> Cc: freebsd-toolchain@freebsd.org To: Jonathan Anderson References: <95573ED5-49CD-4BC6-863D-849C1CAA774D@FreeBSD.org> X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 16:45:44 -0000 --Apple-Mail=_16AB790B-1DE4-4E11-A041-73E0BDB3F471 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 13 Jul 2018, at 14:30, Jonathan Anderson = wrote: >=20 > I recently ran into an unreachable statement execution in Clang 6, = both > with v6.0.0 from the llvm60 package and v6.0.1 from HEAD (FreeBSD > r335799 / LLVM r335540). I don't see this issue in Clang 5 or in the > version that ships with macOS High Sierra (which they're calling = 9.1.0, > but that's apparently more of a "marketing version" than a true = version > number). >=20 > creduce managed to shrink my 2.8 MiB preprocessed sources down to a = 604 > B test case: >=20 > https://gist.github.com/trombonehero/2da555bd1292be973f9d14c843c56ae5 >=20 > This isn't a valid C++ file (e.g., it cuts off after `return o` on = line > 23), but I would expect it to cause compiler errors rather than a > compiler crash. You can see the output from the crash at: >=20 > https://gist.github.com/trombonehero/8fce4a8f39ae121a2f9f14b45b0b65a1 >=20 > Any thoughts? It doesn't crash for me, at least not with the command line you provided in the gist. It just gives a large number of parse errors: $ clang -v FreeBSD clang version 6.0.0 (tags/RELEASE_600/final 326565) (based on = LLVM 6.0.0) Target: x86_64-unknown-freebsd11.2 Thread model: posix InstalledDir: /usr/bin $ clang -cc1 -triple x86_64-portbld-freebsd12.0 -emit-obj -mrelax-all = -disable-free -main-file-name test-8fd60b.cpp -mrelocation-model static = -mthread-model posix -mdisable-fp-elim -masm-verbose = -mconstructor-aliases -munwind-tables -target-cpu x86-64 = -dwarf-column-info -debugger-tuning=3Dgdb -coverage-notes-file = /usr/home/jon/Desktop/test-8fd60b.gcno -resource-dir = /usr/local/llvm60/lib/clang/6.0.0 -internal-isystem /usr/include/c++/v1 = -fdeprecated-macro -fdebug-compilation-dir /usr/home/jon/Desktop = -ferror-limit 19 -fmessage-length 80 -fobjc-runtime=3Dgnustep = -fcxx-exceptions -fexceptions -fdiagnostics-show-option = -fcolor-diagnostics -o test-8fd60b.o -x c++ foo.cpp foo.cpp:2:13: error: expected '{' after base class list struct b : a template ^ foo.cpp:2:13: error: expected ';' after struct struct b : a template ^ ; foo.cpp:4:23: error: expected ';' at end of declaration __declval() template ^ ; foo.cpp:6:36: error: expected ';' at end of declaration -> decltype(g(h...)) template ^ ; foo.cpp:8:18: error: no template named 'declval'; did you mean = '__declval'? : decltype(f(declval(), e()...)) template ^~~~~~~ __declval foo.cpp:4:12: note: '__declval' declared here __declval() template ^ foo.cpp:8:40: error: expected '{' after base class list : decltype(f(declval(), e()...)) template ^ foo.cpp:8:40: error: expected ';' after struct : decltype(f(declval(), e()...)) template ^ ; foo.cpp:10:33: error: expected ';' after struct template struct function ^ ; foo.cpp:13:6: error: unknown class name '_Rp0'; did you mean '_Rp'? :_Rp0 ^~~~ _Rp foo.cpp:11:16: note: '_Rp' declared here template ^ foo.cpp:13:10: error: expected '{' after base class list :_Rp0 ^ { foo.cpp:18:1: error: expected ')' } ^ foo.cpp:17:13: note: to match this '(' function(d ^ foo.cpp:17:15: error: expected ';' at end of declaration list function(d ^ ; foo.cpp:18:2: error: expected ';' after struct } ^ ; foo.cpp:23:17: error: expected '}' return o ^ foo.cpp:20:1: note: to match this '{' { ^ foo.cpp:13:6: error: base specifier must name a class :_Rp0 ^~~~ foo.cpp:21:23: note: in instantiation of template class 'function' requested here function n() { ^ foo.cpp:23:16: error: use of undeclared identifier 'o' return o ^ foo.cpp:23:17: error: expected '}' return o ^ foo.cpp:22:21: note: to match this '{' return [](m, m) { ^ foo.cpp:22:12: error: no viable conversion from returned value of type = '(lambda at foo.cpp:22:12)' to function return type 'function' return [](m, m) { ^~~~~~~~~~ foo.cpp:12:8: note: candidate constructor (the implicit copy = constructor) not viable: no known conversion from '(lambda at foo.cpp:22:12)' to = 'const function &' for 1st argument struct function<_Rp(k...)> ^ foo.cpp:12:8: note: candidate constructor (the implicit move = constructor) not viable: no known conversion from '(lambda at foo.cpp:22:12)' to 'function &&' for 1st argument struct function<_Rp(k...)> ^ foo.cpp:17:5: note: candidate template ignored: substitution failure = [with d =3D (lambda at foo.cpp:22:12)]: no member named 'l' in 'b >' function(d ^ foo.cpp:22:12: note: candidate function return [](m, m) { ^ foo.cpp:23:17: error: expected '}' return o ^ foo.cpp:21:27: note: to match this '{' function n() { ^ fatal error: too many errors emitted, stopping now [-ferror-limit=3D] 20 errors generated. -Dimitry --Apple-Mail=_16AB790B-1DE4-4E11-A041-73E0BDB3F471 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCW0jXMgAKCRCwXqMKLiCW o4iZAKD8TJQPmWQm6B8BA35ZkJWUYdXCAACfcrKUNsSzAI4LRSorAQNpQMk8sfU= =Gtm7 -----END PGP SIGNATURE----- --Apple-Mail=_16AB790B-1DE4-4E11-A041-73E0BDB3F471-- From owner-freebsd-toolchain@freebsd.org Fri Jul 13 21:06:51 2018 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 863EF102509B for ; Fri, 13 Jul 2018 21:06:51 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1CA1478F94; Fri, 13 Jul 2018 21:06:51 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from coleburn.home.andric.com (coleburn.home.andric.com [192.168.0.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 9B937570DC; Fri, 13 Jul 2018 23:06:43 +0200 (CEST) From: Dimitry Andric Message-Id: <0CAE4E5F-E501-4173-8716-72EAAEF5C55F@FreeBSD.org> Content-Type: multipart/signed; boundary="Apple-Mail=_C790293D-CDC5-4B58-9D6F-4CD3C310FD4E"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: Clang 6.0.[01]: UNREACHABLE executed Date: Fri, 13 Jul 2018 23:06:39 +0200 In-Reply-To: <51FD8F40-A5B8-4292-ACD4-A0105E428311@FreeBSD.org> Cc: freebsd-toolchain@freebsd.org To: Jonathan Anderson References: <95573ED5-49CD-4BC6-863D-849C1CAA774D@FreeBSD.org> <51FD8F40-A5B8-4292-ACD4-A0105E428311@FreeBSD.org> X-Mailer: Apple Mail (2.3445.9.1) X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 21:06:51 -0000 --Apple-Mail=_C790293D-CDC5-4B58-9D6F-4CD3C310FD4E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 13 Jul 2018, at 18:45, Dimitry Andric wrote: >=20 > On 13 Jul 2018, at 14:30, Jonathan Anderson = wrote: >>=20 >> I recently ran into an unreachable statement execution in Clang 6, = both >> with v6.0.0 from the llvm60 package and v6.0.1 from HEAD (FreeBSD >> r335799 / LLVM r335540). I don't see this issue in Clang 5 or in the >> version that ships with macOS High Sierra (which they're calling = 9.1.0, >> but that's apparently more of a "marketing version" than a true = version >> number). >>=20 >> creduce managed to shrink my 2.8 MiB preprocessed sources down to a = 604 >> B test case: >>=20 >> https://gist.github.com/trombonehero/2da555bd1292be973f9d14c843c56ae5 >>=20 >> This isn't a valid C++ file (e.g., it cuts off after `return o` on = line >> 23), but I would expect it to cause compiler errors rather than a >> compiler crash. You can see the output from the crash at: >>=20 >> https://gist.github.com/trombonehero/8fce4a8f39ae121a2f9f14b45b0b65a1 >>=20 >> Any thoughts? >=20 > It doesn't crash for me, at least not with the command line you = provided > in the gist. Ah, I had a clang without assertions, but with assertions enabled, it indeed results in: Invalid operator call kind UNREACHABLE executed at = /usr/src/contrib/llvm/tools/clang/lib/AST/StmtProfile.cpp:1250! Abort trap This looks very much like https://bugs.llvm.org/show_bug.cgi?id=3D28793, which is also something about a lamdba function with an invalid or incomplete syntax. I will dig a bit further; if it is the same bug, and reproduces with clang trunk, I can bump the upstream bug, and/or ping a few people that might be able to fix it. -Dimitry --Apple-Mail=_C790293D-CDC5-4B58-9D6F-4CD3C310FD4E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCW0kUYAAKCRCwXqMKLiCW oz+ZAKDxO3VDkmna60zdDoK8zpF9LYWSYQCcCTCUVGSNafolfdDmf1B90jtGXzo= =V+jU -----END PGP SIGNATURE----- --Apple-Mail=_C790293D-CDC5-4B58-9D6F-4CD3C310FD4E-- From owner-freebsd-toolchain@freebsd.org Sat Jul 14 10:15:11 2018 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF1B61049EA8; Sat, 14 Jul 2018 10:15:11 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Received: from smarthost1.greenhost.nl (smarthost1.greenhost.nl [195.190.28.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 84E9073F92; Sat, 14 Jul 2018 10:15:09 +0000 (UTC) (envelope-from ronald-lists@klop.ws) Received: from smtp.greenhost.nl ([213.108.110.112]) by smarthost1.greenhost.nl with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1feHZz-00068w-Rh; Sat, 14 Jul 2018 12:15:08 +0200 Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes To: "Dimitry Andric" , "Mark Millard" , tech-lists Cc: freebsd-arm , "FreeBSD Current" , "FreeBSD Toolchain" Subject: Re: aarch64-arm64 fails to build kernel 12-current raspberry pi 3 References: <2F72F7DB-F5DD-471A-B644-9CDE3FABFAC1@yahoo.com> <6DDED0A0-588D-4323-8E22-1267AA06615E@FreeBSD.org> Date: Sat, 14 Jul 2018 12:15:07 +0200 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Ronald Klop" Message-ID: In-Reply-To: User-Agent: Opera Mail/12.16 (FreeBSD) X-Authenticated-As-Hash: 398f5522cb258ce43cb679602f8cfe8b62a256d1 X-Virus-Scanned: by clamav at smarthost1.samage.net X-Spam-Level: / X-Spam-Score: -0.2 X-Spam-Status: No, score=-0.2 required=5.0 tests=ALL_TRUSTED, BAYES_50 autolearn=disabled version=3.4.0 X-Scan-Signature: 523f42b60907f92a5b98f162865e3e4b X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jul 2018 10:15:11 -0000 On Fri, 13 Jul 2018 12:15:22 +0200, tech-lists wrote: > On 12/07/2018 19:32, Dimitry Andric wrote: >> No, it's because sys/crypto/armv8/armv8_crypto_wrap.c includes >> , an intrinsics header, which in turn requires . >> This was introduced inhttps://svnweb.freebsd.org/changeset/base/308921, >> and at the time resulted in similar build failures, specifically when >> one attempted to build a new kernel, without building world or a new >> toolchain first. > > Hi, > > Ok, it's finished building and installing. The command I used was this: > > # make -j10 buildworld && make -j10 buildkernel KERNCONF=RPI3 What is RPI3? Mine runs GENERIC and there is no RPI3 config in /usr/src/sys/arm64/conf. I can find RPI2 in sys/arm/conf. Regards, Ronald. From owner-freebsd-toolchain@freebsd.org Sat Jul 14 11:24:32 2018 Return-Path: Delivered-To: freebsd-toolchain@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A719C104C817; Sat, 14 Jul 2018 11:24:32 +0000 (UTC) (envelope-from tech-lists@zyxst.net) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 379A975F71; Sat, 14 Jul 2018 11:24:32 +0000 (UTC) (envelope-from tech-lists@zyxst.net) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 7BA76345; Sat, 14 Jul 2018 07:24:24 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 14 Jul 2018 07:24:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zyxst.net; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=oTcfaA2ZCTZaaVfcRRhgslDRXGUrC n2nbGubSZuN0gY=; b=MeV6zaFl9vJHdE8dRG1Dsl40wqV8ZTGiXXmFeDzd72NbW A1VXMMPbwKf3DUPVdWFufjkJ2H2YD8WIWwmeM/KRSkc/k56vHrikXqCGNbu+2yVA g9d463N+f0KtsTGfNPJsqv3p+dMrgROzYTYyDer51IUv72ZdJ9Tq9Y3jlEad0P3L XfC55zJyX8Ur13/6XyUzHdLWGj/+/n4cbSNp9cQyeIsRoJwcFwmNjvPAN1aSlZG5 7P1mEejciVd27Ypq84H7m08lDC4PTAFh7DSS4ZnYvWVVUDHv4nKQ6/Z34BKnsLZ/ pRQgPRVWre/6Mrk63Ap86p13+F2l3ENNDgAVQSWbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=oTcfaA 2ZCTZaaVfcRRhgslDRXGUrCn2nbGubSZuN0gY=; b=TlcWi8/O432vwroczQgAyh XIoVEPFU0KZHa1m7RmgPHmRZN7m5Dh2fmhoovqxLLYLoN1/4j8eXAw+4vhwWRPF3 WYxuN1H0zy/X6GdA2HQzKqwyYUG2laMTBqjjtFZnpMH5z17FFxeOnmkqumy+bm9u MHHoV6XlmDfJC8xYz4SSaeSeZ/8dafVvalpY1mysyCaUy3szrQXK1Cfva/5Eb6wc hWeO1DHaY86O1zU4P+NEf9581IfrjrbBVTIYjKnUjX4uLUp5jmtY9RGB7YSsuBZz esmXY1O3Xp+Pfgq2RSbw7e1NTYAdTmDRKLuiFxbGmZQZWTSjwFJ1Syr8iGa+Y5gQ == X-ME-Proxy: X-ME-Sender: Received: from desktop.local (parsley.growveg.org [82.70.91.97]) by mail.messagingengine.com (Postfix) with ESMTPA id F42221026B; Sat, 14 Jul 2018 07:24:22 -0400 (EDT) Subject: Re: aarch64-arm64 fails to build kernel 12-current raspberry pi 3 To: Ronald Klop , Dimitry Andric , Mark Millard Cc: freebsd-arm , FreeBSD Current , FreeBSD Toolchain References: <2F72F7DB-F5DD-471A-B644-9CDE3FABFAC1@yahoo.com> <6DDED0A0-588D-4323-8E22-1267AA06615E@FreeBSD.org> From: tech-lists Organization: none Message-ID: <2350edc7-44a9-c04d-3b30-66bb6998e9e2@zyxst.net> Date: Sat, 14 Jul 2018 12:24:21 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jul 2018 11:24:32 -0000 On 14/07/2018 11:15, Ronald Klop wrote: > What is RPI3? Mine runs GENERIC and there is no RPI3 config in > /usr/src/sys/arm64/conf. I can find RPI2 in sys/arm/conf. RPI3 is the same as GENERIC-NODEBUG, apart from the ident string which is also RPI3. (was mentioned at the start of the thread which branched off) -- J.