Date: Mon, 13 Aug 2018 05:56:11 -0700 From: John-Mark Gurney <jmg@funkthat.com> To: uboot@FreeBSD.org Subject: u-boot-master slight mismatch in Makefile... Message-ID: <20180813125611.GJ97145@funkthat.com>
next in thread | raw e-mail | index | archive | help
In the Makefile for u-boot-master:
63 # Overrides for ALLWINNER family
64 UBOOT_PLIST_ALLWINNER=u-boot-sunxi-with-spl.bin
65 UBOOT_METADATA_ALLWINNER_FILES= ${UBOOT_PLIST_ALLWINNER}
66 UBOOT_METADATA_ALLWINNER_METHOD= raw
67 UBOOT_METADATA_ALLWINNER_RAW_OFFSET= 8
68 UBOOT_METADATA_ALLWINNER_RAW_BS= 1k
69
70 # Overrides for ALLWINNER64 family
71 UBOOT_PLIST_ALLWINNER64=u-boot-sunxi-with-spl.bin
72 UBOOT_ARCH_ALLWINNER64=aarch64
73 UBOOT_METADATA_ALLWINNER64_FILES= ${UBOOT_PLIST_ALLWINNER}
This last line should probably be:
73 UBOOT_METADATA_ALLWINNER64_FILES= ${UBOOT_PLIST_ALLWINNER64}
and to make the change cascading since 71 and 64 are the same:
71 UBOOT_PLIST_ALLWINNER64=${UBOOT_PLIST_ALLWINNER}
These changes won't change the behavior, but prevent POLA when someone
changes UBOOT_PLIST_ALLWINNER64 and nothing changes...
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180813125611.GJ97145>