From owner-freebsd-usb@freebsd.org Sun Dec 23 14:07:15 2018 Return-Path: Delivered-To: freebsd-usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9D3E21335408 for ; Sun, 23 Dec 2018 14:07:15 +0000 (UTC) (envelope-from dev@submerge.ch) Received: from c3po.matrixx.ch (c3po.matrixx.ch [80.74.145.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3B4A575C2A for ; Sun, 23 Dec 2018 14:07:13 +0000 (UTC) (envelope-from dev@submerge.ch) Received: from [217.22.143.245] (port=34957 helo=z800.localnet) by c3po.matrixx.ch with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1gb4PG-0002tt-Fh for freebsd-usb@freebsd.org; Sun, 23 Dec 2018 15:07:04 +0100 From: Florian Walpen To: freebsd-usb@freebsd.org Subject: SPL Crimson (rev 1) and snd_uaudio Date: Sun, 23 Dec 2018 15:07:02 +0100 Message-ID: <1898371.YXp4yczo3S@z800> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - c3po.matrixx.ch X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - submerge.ch X-Get-Message-Sender-Via: c3po.matrixx.ch: authenticated_id: florian.walpen@submerge.ch X-Authenticated-Sender: c3po.matrixx.ch: florian.walpen@submerge.ch X-Source: X-Source-Args: X-Source-Dir: X-Rspamd-Queue-Id: 3B4A575C2A X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of dev@submerge.ch designates 80.74.145.109 as permitted sender) smtp.mailfrom=dev@submerge.ch X-Spamd-Result: default: False [-0.54 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+a]; HAS_X_SOURCE(0.00)[]; TO_DN_NONE(0.00)[]; MX_GOOD(-0.01)[submerge.ch]; NEURAL_HAM_SHORT(-0.77)[-0.772,0]; HAS_X_ANTIABUSE(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; CTE_CASE(0.50)[]; ASN(0.00)[asn:21069, ipnet:80.74.144.0/20, country:CH]; HAS_X_AS(0.00)[florian.walpen@submerge.ch]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.50)[-0.504,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[submerge.ch]; NEURAL_SPAM_MEDIUM(0.05)[0.050,0]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(-0.00)[country: CH(-0.00)]; RCVD_IN_DNSWL_NONE(0.00)[109.145.74.80.list.dnswl.org : 127.0.10.0]; HAS_X_GMSV(0.00)[florian.walpen@submerge.ch]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Dec 2018 14:07:15 -0000 Hello all, this is my first post here, so apologies if this isn't the most appropriate list - but i thought this topic is more related to USB than to multimedia. I treated myself to an SPL Crimson (rev 1), which is a well-built USB audio interface for musicians (4 in 4 out + SPDIF) that hits the second hand market here now for around 200$. See https://spl.audio/studio/crimson/?lang=en It is indeed USB 2.0 Audio Class compliant as advertised, but still made me jump quite some hurdles before i got it to work with FreeBSD. For the records: 1. This device is a shape-shifter and will present different USB descriptors to Windows and macOS. A USB 1.0 Audio Class compliant header is always there and works (2 in 2 out at 48000), but the USB 2.0 configuration is hidden in Windows and only appears in macOS. Moreover, the Crimson keeps that state between power cycles, so my solution was to plug it into macOS once and never into Windows again. 2. The USB 2.0 header is in the second USB configuration, which is easy enough to fix with a quirk added to /boot/loader.conf: hw.usb.quirk.0="0x0a4a 0xc150 0x0000 0xffff UQ_CFG_INDEX_1" 3. Still, there are no play and record channels detected and uaudio takes minutes to attach to the device. As it turns out, the Crimson chokes on the sample rate request messages, resulting in USB timeouts. The implementation in FreeBSD is somewhat simplistic in this regard, and i have a patch now for 12.0-RELEASE which mimics the more subtle behaviour of macOS. This gave me a working audio device with 6 in 6 out channels and sample rates up to 96000. Output seems to work fine, i didn't test recording yet since i don't have my gear here at home. Now my questions would be: a) What about adding the quirk permanently to FreeBSD? I'm unsure because it could make a Crimson in crippled Windows mode unusable, even though the device is not too useful in that state anyway. Maybe i should investigate what triggers the shape-shifting first, i do have USB dumps from macOS. b) Regarding the patch for issue 3., how would i post it for discussion and inclusion into FreeBSD? Should i file a PR or just post it here on the list, inline (~30 lines) or in an attachment? I couldn't find any policy on that for the mailing lists. Mimicking the behaviour of macOS could be beneficial in general, i see a lot of new class compliant audio interfaces coming out that are explicitly tested with apple software (iPad compatible). Thanks & best regards Florian Walpen From owner-freebsd-usb@freebsd.org Sun Dec 23 21:00:05 2018 Return-Path: Delivered-To: freebsd-usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6D3E61347A87 for ; Sun, 23 Dec 2018 21:00:05 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 0A8368DD06 for ; Sun, 23 Dec 2018 21:00:05 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id C2FBD1347A7E; Sun, 23 Dec 2018 21:00:04 +0000 (UTC) Delivered-To: usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B18891347A7D for ; Sun, 23 Dec 2018 21:00:04 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 52EA98DCFD for ; Sun, 23 Dec 2018 21:00:04 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 66BFF13108 for ; Sun, 23 Dec 2018 21:00:03 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wBNL03S6015621 for ; Sun, 23 Dec 2018 21:00:03 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wBNL03HG015618 for usb@FreeBSD.org; Sun, 23 Dec 2018 21:00:03 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <201812232100.wBNL03HG015618@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: usb@FreeBSD.org Subject: Problem reports for usb@FreeBSD.org that need special attention Date: Sun, 23 Dec 2018 21:00:03 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Dec 2018 21:00:05 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- Open | 213877 | xhci reset causes panic on SuperMicro A1SRi-2758F 1 problems total for which you should take action. From owner-freebsd-usb@freebsd.org Sun Dec 23 20:58:43 2018 Return-Path: Delivered-To: freebsd-usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DE85A134796E for ; Sun, 23 Dec 2018 20:58:42 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9348F8DBE9 for ; Sun, 23 Dec 2018 20:58:41 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [178.17.145.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id A17ED2601E2; Sun, 23 Dec 2018 21:58:38 +0100 (CET) Subject: Re: SPL Crimson (rev 1) and snd_uaudio To: Florian Walpen , freebsd-usb@freebsd.org References: <1898371.YXp4yczo3S@z800> From: Hans Petter Selasky Message-ID: <569736da-5b33-44cb-4ad8-2986b38c10d0@selasky.org> Date: Sun, 23 Dec 2018 21:56:20 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <1898371.YXp4yczo3S@z800> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9348F8DBE9 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 2a01:4f8:c17:6c4b::2 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-6.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[mail.turbocat.net]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.91)[-0.907,0]; IP_SCORE(-2.88)[ip: (-8.96), ipnet: 2a01:4f8::/29(-2.96), asn: 24940(-2.47), country: DE(-0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Dec 2018 20:58:43 -0000 On 12/23/18 3:07 PM, Florian Walpen wrote: > Hello all, > > this is my first post here, so apologies if this isn't the most appropriate > list - but i thought this topic is more related to USB than to multimedia. > > I treated myself to an SPL Crimson (rev 1), which is a well-built USB audio > interface for musicians (4 in 4 out + SPDIF) that hits the second hand market > here now for around 200$. See > https://spl.audio/studio/crimson/?lang=en > > It is indeed USB 2.0 Audio Class compliant as advertised, but still made me > jump quite some hurdles before i got it to work with FreeBSD. > For the records: > > 1. This device is a shape-shifter and will present different USB descriptors > to Windows and macOS. A USB 1.0 Audio Class compliant header is always there > and works (2 in 2 out at 48000), but the USB 2.0 configuration is hidden in > Windows and only appears in macOS. Moreover, the Crimson keeps that state > between power cycles, so my solution was to plug it into macOS once and never > into Windows again. > > 2. The USB 2.0 header is in the second USB configuration, which is easy enough > to fix with a quirk added to /boot/loader.conf: > > hw.usb.quirk.0="0x0a4a 0xc150 0x0000 0xffff UQ_CFG_INDEX_1" > > 3. Still, there are no play and record channels detected and uaudio takes > minutes to attach to the device. As it turns out, the Crimson chokes on the > sample rate request messages, resulting in USB timeouts. The implementation in > FreeBSD is somewhat simplistic in this regard, and i have a patch now for > 12.0-RELEASE which mimics the more subtle behaviour of macOS. > > This gave me a working audio device with 6 in 6 out channels and sample rates > up to 96000. Output seems to work fine, i didn't test recording yet since i > don't have my gear here at home. > > > Now my questions would be: > a) What about adding the quirk permanently to FreeBSD? > I'm unsure because it could make a Crimson in crippled Windows mode unusable, > even though the device is not too useful in that state anyway. Maybe i should > investigate what triggers the shape-shifting first, i do have USB dumps from > macOS. Hi, If you want to add the patch permanently, add it to sys/dev/usb/quirk/usb_quirk.c . There should already be quirks for Fast Track Ultra R8 from M-audio, which are halfway class compliant. Did you look at Linux for any quirks for your device? > > b) Regarding the patch for issue 3., how would i post it for discussion and > inclusion into FreeBSD? > Should i file a PR or just post it here on the list, inline (~30 lines) or in > an attachment? I couldn't find any policy on that for the mailing lists. Filing a PR and referring it here is fine. If the patch is big, you might want to post it at differential revision at FreeBSD.org. > > Mimicking the behaviour of macOS could be beneficial in general, i see a lot > of new class compliant audio interfaces coming out that are explicitly tested > with apple software (iPad compatible). It is not so good that the device dies on basic USB audio commands. It might indicate that the software has not undergone proper negative testing and that it might be possible to hack the firmware using the commands that timeout :-( Anyway I'm glad you got your device working improving the state of USB audio in FreeBSD and looking forward to a patch. --HPS From owner-freebsd-usb@freebsd.org Mon Dec 24 00:43:39 2018 Return-Path: Delivered-To: freebsd-usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E8A8E13510E0 for ; Mon, 24 Dec 2018 00:43:38 +0000 (UTC) (envelope-from dev@submerge.ch) Received: from c3po.matrixx.ch (c3po.matrixx.ch [80.74.145.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4AF1596A1D for ; Mon, 24 Dec 2018 00:43:34 +0000 (UTC) (envelope-from dev@submerge.ch) Received: from [217.22.143.245] (port=62901 helo=z800.localnet) by c3po.matrixx.ch with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1gbEL7-0005Bi-K9 for freebsd-usb@freebsd.org; Mon, 24 Dec 2018 01:43:28 +0100 From: Florian Walpen To: freebsd-usb@freebsd.org Subject: Re: SPL Crimson (rev 1) and snd_uaudio Date: Mon, 24 Dec 2018 01:43:26 +0100 Message-ID: <5738623.nAnukg6brD@z800> In-Reply-To: <569736da-5b33-44cb-4ad8-2986b38c10d0@selasky.org> References: <1898371.YXp4yczo3S@z800> <569736da-5b33-44cb-4ad8-2986b38c10d0@selasky.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - c3po.matrixx.ch X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - submerge.ch X-Get-Message-Sender-Via: c3po.matrixx.ch: authenticated_id: florian.walpen@submerge.ch X-Authenticated-Sender: c3po.matrixx.ch: florian.walpen@submerge.ch X-Source: X-Source-Args: X-Source-Dir: X-Rspamd-Queue-Id: 4AF1596A1D X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of dev@submerge.ch designates 80.74.145.109 as permitted sender) smtp.mailfrom=dev@submerge.ch X-Spamd-Result: default: False [0.32 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+a]; HAS_X_SOURCE(0.00)[]; TO_DN_NONE(0.00)[]; MX_GOOD(-0.01)[cached: submerge.ch]; HAS_X_ANTIABUSE(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; CTE_CASE(0.50)[]; ASN(0.00)[asn:21069, ipnet:80.74.144.0/20, country:CH]; HAS_X_AS(0.00)[florian.walpen@submerge.ch]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.14)[-0.139,0]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.56)[-0.565,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[submerge.ch]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(-0.00)[country: CH(-0.00)]; NEURAL_SPAM_SHORT(0.33)[0.329,0]; RCVD_IN_DNSWL_NONE(0.00)[109.145.74.80.list.dnswl.org : 127.0.10.0]; HAS_X_GMSV(0.00)[florian.walpen@submerge.ch]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Dec 2018 00:43:39 -0000 On Sunday, December 23, 2018 9:56:20 PM CET Hans Petter Selasky wrote: > On 12/23/18 3:07 PM, Florian Walpen wrote: > > Hello all, > > > > this is my first post here, so apologies if this isn't the most > > appropriate > > list - but i thought this topic is more related to USB than to multimedia. > > > > I treated myself to an SPL Crimson (rev 1), which is a well-built USB > > audio > > interface for musicians (4 in 4 out + SPDIF) that hits the second hand > > market here now for around 200$. See > > https://spl.audio/studio/crimson/?lang=en > > > > It is indeed USB 2.0 Audio Class compliant as advertised, but still made > > me > > jump quite some hurdles before i got it to work with FreeBSD. > > For the records: > > > > 1. This device is a shape-shifter and will present different USB > > descriptors to Windows and macOS. A USB 1.0 Audio Class compliant header > > is always there and works (2 in 2 out at 48000), but the USB 2.0 > > configuration is hidden in Windows and only appears in macOS. Moreover, > > the Crimson keeps that state between power cycles, so my solution was to > > plug it into macOS once and never into Windows again. > > > > 2. The USB 2.0 header is in the second USB configuration, which is easy > > enough to fix with a quirk added to /boot/loader.conf: > > > > hw.usb.quirk.0="0x0a4a 0xc150 0x0000 0xffff UQ_CFG_INDEX_1" > > > > 3. Still, there are no play and record channels detected and uaudio takes > > minutes to attach to the device. As it turns out, the Crimson chokes on > > the > > sample rate request messages, resulting in USB timeouts. The > > implementation in FreeBSD is somewhat simplistic in this regard, and i > > have a patch now for 12.0-RELEASE which mimics the more subtle behaviour > > of macOS. > > > > This gave me a working audio device with 6 in 6 out channels and sample > > rates up to 96000. Output seems to work fine, i didn't test recording yet > > since i don't have my gear here at home. > > > > > > Now my questions would be: > > a) What about adding the quirk permanently to FreeBSD? > > I'm unsure because it could make a Crimson in crippled Windows mode > > unusable, even though the device is not too useful in that state anyway. > > Maybe i should investigate what triggers the shape-shifting first, i do > > have USB dumps from macOS. > > Hi, > > If you want to add the patch permanently, add it to > sys/dev/usb/quirk/usb_quirk.c . There should already be quirks for Fast > Track Ultra R8 from M-audio, which are halfway class compliant. Did you > look at Linux for any quirks for your device? Hi, thanks for the hints, I suppose the vendor and product id have to be added to sys/dev/usb/usbdevs first? Also I just searched the linux sources for quirks and neither found vendor and product id nor anything related to the manufacturers (Ploytec GmbH and SPL). > > > b) Regarding the patch for issue 3., how would i post it for discussion > > and > > inclusion into FreeBSD? > > Should i file a PR or just post it here on the list, inline (~30 lines) or > > in an attachment? I couldn't find any policy on that for the mailing > > lists. > Filing a PR and referring it here is fine. If the patch is big, you > might want to post it at differential revision at FreeBSD.org. I will file a PR then tomorrow, the patch is small (~30 lines). > > > Mimicking the behaviour of macOS could be beneficial in general, i see a > > lot of new class compliant audio interfaces coming out that are > > explicitly tested with apple software (iPad compatible). > > It is not so good that the device dies on basic USB audio commands. It > might indicate that the software has not undergone proper negative > testing and that it might be possible to hack the firmware using the > commands that timeout :-( Anyway I'm glad you got your device working > improving the state of USB audio in FreeBSD and looking forward to a patch. > > --HPS I don't know how severe an issue like this is, but it is certainly not a sign of thorough testing and robust implementation. Being realistic though, there will always be devices tested and tailored to one of the popular OSes, not according to standards. All I want to say is that this situation is an opportunity to support more devices out of the box, under the condition that the mimicked behaviour also adheres to the standard. You will probably see what I mean when reading the details of the patch. Thanks again Florian Walpen From owner-freebsd-usb@freebsd.org Mon Dec 24 10:28:44 2018 Return-Path: Delivered-To: freebsd-usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 70BC1133D9FD for ; Mon, 24 Dec 2018 10:28:44 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DC56D809D9 for ; Mon, 24 Dec 2018 10:28:42 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [178.17.145.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 0336926022D; Mon, 24 Dec 2018 11:28:39 +0100 (CET) Subject: Re: SPL Crimson (rev 1) and snd_uaudio To: Florian Walpen , freebsd-usb@freebsd.org References: <1898371.YXp4yczo3S@z800> <569736da-5b33-44cb-4ad8-2986b38c10d0@selasky.org> <5738623.nAnukg6brD@z800> From: Hans Petter Selasky Message-ID: <68abf39b-7c6f-d9a9-bb6c-3cfeb2b569ea@selasky.org> Date: Mon, 24 Dec 2018 11:26:21 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <5738623.nAnukg6brD@z800> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: DC56D809D9 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 2a01:4f8:c17:6c4b::2 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-6.01 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: mail.turbocat.net]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_SHORT(-0.83)[-0.834,0]; IP_SCORE(-2.87)[ip: (-8.98), ipnet: 2a01:4f8::/29(-2.87), asn: 24940(-2.46), country: DE(-0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Dec 2018 10:28:44 -0000 On 12/24/18 1:43 AM, Florian Walpen wrote: > On Sunday, December 23, 2018 9:56:20 PM CET Hans Petter Selasky wrote: >> On 12/23/18 3:07 PM, Florian Walpen wrote: >>> Hello all, >>> >>> this is my first post here, so apologies if this isn't the most >>> appropriate >>> list - but i thought this topic is more related to USB than to multimedia. >>> >>> I treated myself to an SPL Crimson (rev 1), which is a well-built USB >>> audio >>> interface for musicians (4 in 4 out + SPDIF) that hits the second hand >>> market here now for around 200$. See >>> https://spl.audio/studio/crimson/?lang=en >>> >>> It is indeed USB 2.0 Audio Class compliant as advertised, but still made >>> me >>> jump quite some hurdles before i got it to work with FreeBSD. >>> For the records: >>> >>> 1. This device is a shape-shifter and will present different USB >>> descriptors to Windows and macOS. A USB 1.0 Audio Class compliant header >>> is always there and works (2 in 2 out at 48000), but the USB 2.0 >>> configuration is hidden in Windows and only appears in macOS. Moreover, >>> the Crimson keeps that state between power cycles, so my solution was to >>> plug it into macOS once and never into Windows again. >>> >>> 2. The USB 2.0 header is in the second USB configuration, which is easy >>> enough to fix with a quirk added to /boot/loader.conf: >>> >>> hw.usb.quirk.0="0x0a4a 0xc150 0x0000 0xffff UQ_CFG_INDEX_1" >>> >>> 3. Still, there are no play and record channels detected and uaudio takes >>> minutes to attach to the device. As it turns out, the Crimson chokes on >>> the >>> sample rate request messages, resulting in USB timeouts. The >>> implementation in FreeBSD is somewhat simplistic in this regard, and i >>> have a patch now for 12.0-RELEASE which mimics the more subtle behaviour >>> of macOS. >>> >>> This gave me a working audio device with 6 in 6 out channels and sample >>> rates up to 96000. Output seems to work fine, i didn't test recording yet >>> since i don't have my gear here at home. >>> >>> >>> Now my questions would be: >>> a) What about adding the quirk permanently to FreeBSD? >>> I'm unsure because it could make a Crimson in crippled Windows mode >>> unusable, even though the device is not too useful in that state anyway. >>> Maybe i should investigate what triggers the shape-shifting first, i do >>> have USB dumps from macOS. >> >> Hi, >> >> If you want to add the patch permanently, add it to >> sys/dev/usb/quirk/usb_quirk.c . There should already be quirks for Fast >> Track Ultra R8 from M-audio, which are halfway class compliant. Did you >> look at Linux for any quirks for your device? > > Hi, > > thanks for the hints, I suppose the vendor and product id have to be added to > sys/dev/usb/usbdevs first? Also I just searched the linux sources for quirks > and neither found vendor and product id nor anything related to the > manufacturers (Ploytec GmbH and SPL). > Hi, Adding the vendor and product ID to usbdevs is correct. >> >>> b) Regarding the patch for issue 3., how would i post it for discussion >>> and >>> inclusion into FreeBSD? >>> Should i file a PR or just post it here on the list, inline (~30 lines) or >>> in an attachment? I couldn't find any policy on that for the mailing >>> lists. >> Filing a PR and referring it here is fine. If the patch is big, you >> might want to post it at differential revision at FreeBSD.org. > > I will file a PR then tomorrow, the patch is small (~30 lines). > >> >>> Mimicking the behaviour of macOS could be beneficial in general, i see a >>> lot of new class compliant audio interfaces coming out that are >>> explicitly tested with apple software (iPad compatible). >> >> It is not so good that the device dies on basic USB audio commands. It >> might indicate that the software has not undergone proper negative >> testing and that it might be possible to hack the firmware using the >> commands that timeout :-( Anyway I'm glad you got your device working >> improving the state of USB audio in FreeBSD and looking forward to a patch. >> >> --HPS > > I don't know how severe an issue like this is, but it is certainly not a sign > of thorough testing and robust implementation. Being realistic though, there > will always be devices tested and tailored to one of the popular OSes, not > according to standards. > All I want to say is that this situation is an opportunity to support more > devices out of the box, under the condition that the mimicked behaviour also > adheres to the standard. > You will probably see what I mean when reading the details of the patch. Looking forward to seeing your patch! --HPS From owner-freebsd-usb@freebsd.org Mon Dec 24 16:05:38 2018 Return-Path: Delivered-To: freebsd-usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF95413481C6 for ; Mon, 24 Dec 2018 16:05:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 49B018B492 for ; Mon, 24 Dec 2018 16:05:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 04C1113481C5; Mon, 24 Dec 2018 16:05:38 +0000 (UTC) Delivered-To: usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E72BF13481C4 for ; Mon, 24 Dec 2018 16:05:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 867078B491 for ; Mon, 24 Dec 2018 16:05:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id D965A1D962 for ; Mon, 24 Dec 2018 16:05:36 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wBOG5amI078364 for ; Mon, 24 Dec 2018 16:05:36 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wBOG5a0w078363 for usb@FreeBSD.org; Mon, 24 Dec 2018 16:05:36 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: usb@FreeBSD.org Subject: [Bug 140849] [ums] USB mouse doesn't work under FreeBSD 8.0-RELEASE Date: Mon, 24 Dec 2018 16:05:36 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: usb X-Bugzilla-Version: 8.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: egypcio@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: usb@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Dec 2018 16:05:38 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D140849 --- Comment #8 from Vin=C3=ADcius Zavam --- looks like this one can be closed, right? it works fine for me on HEAD, and was reported to be fixed in releng/12.0 as well. as I am not part of usb@, I will leave it as is and want more feedbac= k. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-usb@freebsd.org Mon Dec 24 23:16:21 2018 Return-Path: Delivered-To: freebsd-usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 07EE61351F84 for ; Mon, 24 Dec 2018 23:16:21 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 96E2670279 for ; Mon, 24 Dec 2018 23:16:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 56F831351F83; Mon, 24 Dec 2018 23:16:20 +0000 (UTC) Delivered-To: usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 345021351F82 for ; Mon, 24 Dec 2018 23:16:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AA30670278 for ; Mon, 24 Dec 2018 23:16:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id C29E21867 for ; Mon, 24 Dec 2018 23:16:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wBONGIeU005266 for ; Mon, 24 Dec 2018 23:16:18 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wBONGIxg005264 for usb@FreeBSD.org; Mon, 24 Dec 2018 23:16:18 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: usb@FreeBSD.org Subject: [Bug 234380] [snd_uaudio] Sample rate detection fails for SPL Crimson Rev 1 Date: Mon, 24 Dec 2018 23:16:18 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: usb X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: dev@submerge.ch X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: usb@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Dec 2018 23:16:21 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234380 Bug ID: 234380 Summary: [snd_uaudio] Sample rate detection fails for SPL Crimson Rev 1 Product: Base System Version: 12.0-RELEASE Hardware: amd64 OS: Any Status: New Severity: Affects Only Me Priority: --- Component: usb Assignee: usb@FreeBSD.org Reporter: dev@submerge.ch Created attachment 200478 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D200478&action= =3Dedit Implement sample rate table requests in two steps. The SPL Crimson Revision 1 is a (mostly) class compliant USB 2.0 audio interface for musicians. Due to a firmware bug the device will not return a sample rate table on request when using the current implementation in the snd_uaudio module. How to reproduce: 1. Set a quirk for the device to use the second USB configuration, which provides the full USB 2.0 audio interface: usbconfig add_dev_quirk_vplh 0x0a4a 0xc150 0x0000 0xffff UQ_CFG_INDEX_1 2. Plug the SPL Crimson into a USB 2.0 port. Results: The snd_uaudio module takes very long to attach to the device (some minutes= ). No playback or recording channels are found since the sample rates are miss= ing. Expected: Creation of a 6 in 6 out pcm device for up to 96kHz sample rate within seco= nds. Hard- and Software: SPL Crimson Revision 1 at firmware 1.0.9, the newest available on their website. FreeBSD 11.2-RELEASE and 12.0-RELEASE for amd64. Analysis: For USB 2.0 audio devices, snd_uaudio sends a request to get a table of the supported sample rates, possibly multiple times. Since the length of this table is not known, it requests 255 bytes of sample rate table regardless of its actual length. Due to the firmware bug the SPL Crimson only answers requests for up to about 100 bytes length. The unanswered requests for 255 bytes will result in USB timeouts and missing sample rates. When plugged into macOS (High Sierra), the device works as expected and the sample rates are detected correctly. This is because macOS requests only one row of sample rates at first. The table header indicates the actual length, which is then used for a second request. Both approaches should be valid according to the USB 2.0 audio specs. Proposed solution: The patch provided implements exactly the behavior of macOS. It sends one short request first for the header and one table row (2 + 1 * 12 bytes). If answered, a second request is sent using the actual length derived from the header (2 + n * 12 bytes). What is not implemented yet is a wrap-up into an optional USB quirk. But it may also prove beneficial to adopt the macOS behavior in general, many class compliant devices are explicitly tested against Apple software. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-usb@freebsd.org Tue Dec 25 10:16:39 2018 Return-Path: Delivered-To: freebsd-usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3134C134CC0C for ; Tue, 25 Dec 2018 10:16:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id C07346F226 for ; Tue, 25 Dec 2018 10:16:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 83586134CC0A; Tue, 25 Dec 2018 10:16:38 +0000 (UTC) Delivered-To: usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 71CCE134CC09 for ; Tue, 25 Dec 2018 10:16:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 106C96F224 for ; Tue, 25 Dec 2018 10:16:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 5499F7AFB for ; Tue, 25 Dec 2018 10:16:37 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wBPAGb5X009930 for ; Tue, 25 Dec 2018 10:16:37 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wBPAGbMJ009929 for usb@FreeBSD.org; Tue, 25 Dec 2018 10:16:37 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: usb@FreeBSD.org Subject: [Bug 234380] [snd_uaudio] Sample rate detection fails for SPL Crimson Rev 1 Date: Tue, 25 Dec 2018 10:16:37 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: usb X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: hselasky@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: usb@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Dec 2018 10:16:39 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234380 Hans Petter Selasky changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hselasky@FreeBSD.org --- Comment #1 from Hans Petter Selasky --- I made some modification to your patch. Please verify. Please also attach the usbdevs and usb_quirk.c patch here! --HPS --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-usb@freebsd.org Tue Dec 25 10:16:48 2018 Return-Path: Delivered-To: freebsd-usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EB2D9134CC45 for ; Tue, 25 Dec 2018 10:16:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 8524C6F243 for ; Tue, 25 Dec 2018 10:16:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 4293F134CC43; Tue, 25 Dec 2018 10:16:47 +0000 (UTC) Delivered-To: usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 30EA8134CC41 for ; Tue, 25 Dec 2018 10:16:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C43406F23F for ; Tue, 25 Dec 2018 10:16:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 0D74D7AFF for ; Tue, 25 Dec 2018 10:16:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wBPAGjvd010107 for ; Tue, 25 Dec 2018 10:16:45 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wBPAGjpA010106 for usb@FreeBSD.org; Tue, 25 Dec 2018 10:16:45 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: usb@FreeBSD.org Subject: [Bug 234380] [snd_uaudio] Sample rate detection fails for SPL Crimson Rev 1 Date: Tue, 25 Dec 2018 10:16:46 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: usb X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: usb@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Dec 2018 10:16:48 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234380 --- Comment #2 from commit-hook@freebsd.org --- A commit references this bug: Author: hselasky Date: Tue Dec 25 10:15:48 UTC 2018 New revision: 342456 URL: https://svnweb.freebsd.org/changeset/base/342456 Log: Fix reading of USB sample rate descriptor for SPL Crimson Rev 1. Read first one entry, then try to read the full rate descriptor table. PR: 234380 MFC after: 1 week Sponsored by: Mellanox Technologies Changes: head/sys/dev/sound/usb/uaudio.c --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-usb@freebsd.org Wed Dec 26 16:33:03 2018 Return-Path: Delivered-To: freebsd-usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2D815135608A for ; Wed, 26 Dec 2018 16:33:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id AF3E8892AE for ; Wed, 26 Dec 2018 16:33:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 725721356089; Wed, 26 Dec 2018 16:33:02 +0000 (UTC) Delivered-To: usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 60C191356088 for ; Wed, 26 Dec 2018 16:33:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 002C9892AC for ; Wed, 26 Dec 2018 16:33:02 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 443DF18533 for ; Wed, 26 Dec 2018 16:33:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wBQGX1ga036627 for ; Wed, 26 Dec 2018 16:33:01 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wBQGX1OC036624 for usb@FreeBSD.org; Wed, 26 Dec 2018 16:33:01 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: usb@FreeBSD.org Subject: [Bug 234380] [snd_uaudio] Sample rate detection fails for SPL Crimson Rev 1 Date: Wed, 26 Dec 2018 16:33:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: usb X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: dev@submerge.ch X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: usb@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Dec 2018 16:33:03 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234380 --- Comment #3 from Florian Walpen --- (In reply to commit-hook from comment #2) Thanks, much appreciated. I can confirm that this commit works as intended and fixes the issues with sample rate detection on the Crimson. Unfortunately I cannot test it with my other devices since they are all USB 1.1 only. The code looks robust to me functionality-wise, I think both the fallback to the old behavior (request ~255 bytes) and the support for longer tables are good ideas, I didn't consider that in my patch. Some comments if I may: 1. The comment for the fallback ("Likely the descriptor...") is confusing to me. Isn't that the case for devices that either don't support a request for only one row or don't support the request type at all? 2. Using the error code as a condition for the second request is a bit misleading I think, wouldn't it be easier to just check for 'rates > 1'? Th= at would make the code shorter and the intention more understandable. But these are minor issues, I'm happy with fixing it either way. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-usb@freebsd.org Wed Dec 26 16:42:19 2018 Return-Path: Delivered-To: freebsd-usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2F88C13567EC for ; Wed, 26 Dec 2018 16:42:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id B7AED897FE for ; Wed, 26 Dec 2018 16:42:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 7A9F813567EB; Wed, 26 Dec 2018 16:42:18 +0000 (UTC) Delivered-To: usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 67AE113567EA for ; Wed, 26 Dec 2018 16:42:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F3908897FA for ; Wed, 26 Dec 2018 16:42:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 45A0F186A9 for ; Wed, 26 Dec 2018 16:42:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wBQGgHJ9053255 for ; Wed, 26 Dec 2018 16:42:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wBQGgHfC053254 for usb@FreeBSD.org; Wed, 26 Dec 2018 16:42:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: usb@FreeBSD.org Subject: [Bug 234380] [snd_uaudio] Sample rate detection fails for SPL Crimson Rev 1 Date: Wed, 26 Dec 2018 16:42:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: usb X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: dev@submerge.ch X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: usb@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Dec 2018 16:42:19 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234380 --- Comment #4 from Florian Walpen --- Created attachment 200531 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D200531&action= =3Dedit Quirk to use the second USB configuration for SPL Crimson Rev 1 And here is the patch for the USB quirk based on 13.0-CURRENT, also tested. As stated before, the SPL Crimson Rev 1 has the standard compliant USB 2.0 audio interface in the second USB configuration. I hope the patch is ok like this. Thanks again Florian Walpen --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-usb@freebsd.org Thu Dec 27 08:29:20 2018 Return-Path: Delivered-To: freebsd-usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF4B913515FB for ; Thu, 27 Dec 2018 08:29:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 4815D8E18D for ; Thu, 27 Dec 2018 08:29:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 0C06A13515FA; Thu, 27 Dec 2018 08:29:20 +0000 (UTC) Delivered-To: usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ED5F913515F9 for ; Thu, 27 Dec 2018 08:29:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3FC5A8E182 for ; Thu, 27 Dec 2018 08:29:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id F36231083 for ; Thu, 27 Dec 2018 08:29:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wBR8TDFm070794 for ; Thu, 27 Dec 2018 08:29:13 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wBR8TD0n070793 for usb@FreeBSD.org; Thu, 27 Dec 2018 08:29:13 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: usb@FreeBSD.org Subject: [Bug 234380] [snd_uaudio] Sample rate detection fails for SPL Crimson Rev 1 Date: Thu, 27 Dec 2018 08:29:14 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: usb X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: hselasky@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: usb@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Dec 2018 08:29:20 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234380 Hans Petter Selasky changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Closed Resolution|--- |FIXED --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-usb@freebsd.org Thu Dec 27 08:29:27 2018 Return-Path: Delivered-To: freebsd-usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D60BD1351612 for ; Thu, 27 Dec 2018 08:29:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 5E4788E1D3 for ; Thu, 27 Dec 2018 08:29:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 21C931351610; Thu, 27 Dec 2018 08:29:27 +0000 (UTC) Delivered-To: usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 10633135160F for ; Thu, 27 Dec 2018 08:29:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A4A568E1D0 for ; Thu, 27 Dec 2018 08:29:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id E03851087 for ; Thu, 27 Dec 2018 08:29:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wBR8TP0s070994 for ; Thu, 27 Dec 2018 08:29:25 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wBR8TP9v070993 for usb@FreeBSD.org; Thu, 27 Dec 2018 08:29:25 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: usb@FreeBSD.org Subject: [Bug 234380] [snd_uaudio] Sample rate detection fails for SPL Crimson Rev 1 Date: Thu, 27 Dec 2018 08:29:25 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: usb X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: FIXED X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: usb@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Dec 2018 08:29:28 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234380 --- Comment #5 from commit-hook@freebsd.org --- A commit references this bug: Author: hselasky Date: Thu Dec 27 08:29:06 UTC 2018 New revision: 342549 URL: https://svnweb.freebsd.org/changeset/base/342549 Log: Add USB quirk for SPL Crimson Rev 1. PR: 234380 MFC after: 1 week Sponsored by: Mellanox Technologies Changes: head/sys/dev/usb/quirk/usb_quirk.c head/sys/dev/usb/usbdevs --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-usb@freebsd.org Fri Dec 28 21:22:40 2018 Return-Path: Delivered-To: freebsd-usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 932021422FA7 for ; Fri, 28 Dec 2018 21:22:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 2BBFB6C59E for ; Fri, 28 Dec 2018 21:22:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id E35371422FA4; Fri, 28 Dec 2018 21:22:39 +0000 (UTC) Delivered-To: usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D05161422FA3 for ; Fri, 28 Dec 2018 21:22:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6B7B46C59C for ; Fri, 28 Dec 2018 21:22:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id C4F46157F2 for ; Fri, 28 Dec 2018 21:22:38 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wBSLMcq2048963 for ; Fri, 28 Dec 2018 21:22:38 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wBSLMcKZ048961 for usb@FreeBSD.org; Fri, 28 Dec 2018 21:22:38 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: usb@FreeBSD.org Subject: [Bug 234469] USB mouses, keyboards and quirks Date: Fri, 28 Dec 2018 21:22:38 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: cem@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: usb@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: keywords cc assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Dec 2018 21:22:40 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234469 Conrad Meyer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch CC| |cem@freebsd.org Assignee|bugs@FreeBSD.org |usb@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-usb@freebsd.org Fri Dec 28 21:43:50 2018 Return-Path: Delivered-To: freebsd-usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A7C4F1423E83 for ; Fri, 28 Dec 2018 21:43:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 42C546D488 for ; Fri, 28 Dec 2018 21:43:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 064DC1423E82; Fri, 28 Dec 2018 21:43:50 +0000 (UTC) Delivered-To: usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E764A1423E81 for ; Fri, 28 Dec 2018 21:43:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7B5066D486 for ; Fri, 28 Dec 2018 21:43:49 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id D4DA815ACF for ; Fri, 28 Dec 2018 21:43:48 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wBSLhm68090021 for ; Fri, 28 Dec 2018 21:43:48 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wBSLhm5q090020 for usb@FreeBSD.org; Fri, 28 Dec 2018 21:43:48 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: usb@FreeBSD.org Subject: [Bug 234469] USB mouses, keyboards and quirks Date: Fri, 28 Dec 2018 21:43:48 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: hselasky@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: usb@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Dec 2018 21:43:50 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234469 Hans Petter Selasky changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hselasky@FreeBSD.org --- Comment #1 from Hans Petter Selasky --- Patch looks good. Maybe wrap the long resulting line? --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-usb@freebsd.org Sat Dec 29 04:08:20 2018 Return-Path: Delivered-To: freebsd-usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 90D1C1430770 for ; Sat, 29 Dec 2018 04:08:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 2614A83C5D for ; Sat, 29 Dec 2018 04:08:20 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id D5784143076F; Sat, 29 Dec 2018 04:08:19 +0000 (UTC) Delivered-To: usb@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C214E143076E for ; Sat, 29 Dec 2018 04:08:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 57F3283C5C for ; Sat, 29 Dec 2018 04:08:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id A950419266 for ; Sat, 29 Dec 2018 04:08:18 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id wBT48IWg041437 for ; Sat, 29 Dec 2018 04:08:18 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id wBT48IqV041434 for usb@FreeBSD.org; Sat, 29 Dec 2018 04:08:18 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: usb@FreeBSD.org Subject: [Bug 234469] USB mouses, keyboards and quirks Date: Sat, 29 Dec 2018 04:08:18 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: usb X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: linimon@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: usb@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: component Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Dec 2018 04:08:20 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234469 Mark Linimon changed: What |Removed |Added ---------------------------------------------------------------------------- Component|kern |usb --=20 You are receiving this mail because: You are the assignee for the bug.=