From owner-freebsd-xen@freebsd.org  Mon Jun 18 12:41:44 2018
Return-Path: <owner-freebsd-xen@freebsd.org>
Delivered-To: freebsd-xen@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6FBF51004AE5
 for <freebsd-xen@mailman.ysv.freebsd.org>;
 Mon, 18 Jun 2018 12:41:44 +0000 (UTC)
 (envelope-from pratiy0100@gmail.com)
Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id F2AE07D065;
 Mon, 18 Jun 2018 12:41:43 +0000 (UTC)
 (envelope-from pratiy0100@gmail.com)
Received: by mail-wm0-f43.google.com with SMTP id p126-v6so13846827wmb.2;
 Mon, 18 Jun 2018 05:41:43 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc;
 bh=42j14pnwHPSY8vEOQ0+/bTPrSeYeZ+PSQq4Sx4tWyc0=;
 b=e6GMKnl4mJIl8pUKccos8qVdZt03GNani2Td3G/qrvrDkiKeQZHfl6aDXkFWEQXmRr
 doFWlkxseVUXK0OdxZnRNPvw0nJHFv3OXSIKrze9QNzXRENRaZZwHAJ/iQ0Vc21APCun
 ecidJ4TFLlN3MIIMmPUVbXna3be2tYQATUCC+D9bArsiLGYWYQ1uAb5HUcRkUrlXRAyi
 y5KBdRwal2IJ8V4vWFUpzR9k8v+z2PxZZQvfz+0I/ePWqx17NYSrQtWbwD/1NZS/i7yX
 G2zRzLy4fvjBGEajMeebfHwxTV9jtisan/gGvdK0gNqfv2jyYvEZY6+EQAuXD1giqWPM
 aefw==
X-Gm-Message-State: APt69E0249gyhpQE+fiD7FJaQVf71aAWC9Z10fRBbPu7QK4N+a4Bba0B
 xdIqHF1Ru40EohbcsDU33gcwWWmd
X-Google-Smtp-Source: ADUXVKIjB1ldAfP/BQhkV+44KUNX78W3VZ+QYKAzIEj7O/p1I5Xcy3bkHTs0TazD1XoBR3WGKfgPbA==
X-Received: by 2002:a50:a247:: with SMTP id
 65-v6mr11065360edl.189.1529325696672; 
 Mon, 18 Jun 2018 05:41:36 -0700 (PDT)
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com.
 [74.125.82.42])
 by smtp.gmail.com with ESMTPSA id f2-v6sm5821379edq.28.2018.06.18.05.41.36
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 18 Jun 2018 05:41:36 -0700 (PDT)
Received: by mail-wm0-f42.google.com with SMTP id v131-v6so15315097wma.1;
 Mon, 18 Jun 2018 05:41:36 -0700 (PDT)
X-Received: by 2002:a50:e70d:: with SMTP id
 a13-v6mr11201661edn.158.1529325696437; 
 Mon, 18 Jun 2018 05:41:36 -0700 (PDT)
MIME-Version: 1.0
From: Pratyush Yadav <pratyush@freebsd.org>
Date: Mon, 18 Jun 2018 18:11:00 +0530
X-Gmail-Original-Message-ID: <CA+X=3TKXTo6OjKXyhYwCBT=o5C_tXkuNf9OTQTcZLEW_gr0z+Q@mail.gmail.com>
Message-ID: <CA+X=3TKXTo6OjKXyhYwCBT=o5C_tXkuNf9OTQTcZLEW_gr0z+Q@mail.gmail.com>
Subject: gnttab_end_foreign_access_ref() leaking grant entries?
To: FreeBSD-Xen <freebsd-xen@freebsd.org>
Cc: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= <royger@freebsd.org>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: freebsd-xen@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: Discussion of the freebsd port to xen - implementation and usage
 <freebsd-xen.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-xen>,
 <mailto:freebsd-xen-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-xen/>
List-Post: <mailto:freebsd-xen@freebsd.org>
List-Help: <mailto:freebsd-xen-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-xen>,
 <mailto:freebsd-xen-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jun 2018 12:41:44 -0000

Hi everyone,

I was looking at gnttab_end_foreign_access_ref() and I notice that
while gnttab_end_foreign_access_ref() ends the foreign access, it does
not free the grant reference.

gnttab_end_foreign_access() free the reference by calling put_free_entry(ref).

gnttab_end_foreign_access_references() also frees the grant entries.

Shouldn't gnttab_end_foreign_access_ref() also free the grant entry?
It is an inconsistency at best and a bug at worst.

Is it ok if I submit a patch that calls put_free_entry(ref) in
gnttab_end_foreign_access_ref()?

-- 
Regards,
Pratyush Yadav