From owner-svn-src-all@freebsd.org Sun Jun 3 02:42:42 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 383C2FE6D86 for ; Sun, 3 Jun 2018 02:42:42 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DCBEB68A7F for ; Sun, 3 Jun 2018 02:42:41 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: from mail-yw0-f181.google.com (mail-yw0-f181.google.com [209.85.161.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: eadler) by smtp.freebsd.org (Postfix) with ESMTPSA id A159227158 for ; Sun, 3 Jun 2018 02:42:41 +0000 (UTC) (envelope-from eadler@freebsd.org) Received: by mail-yw0-f181.google.com with SMTP id q7-v6so9488858ywd.9 for ; Sat, 02 Jun 2018 19:42:41 -0700 (PDT) X-Gm-Message-State: ALKqPwdlfXIj/XcSk2h8DciTFe7tCg7Ustw1b+RXjf9rgIVejiMP0uYt y8Jdpnqe6jeOv32J8p6SDp6mys9dPEZbwQPnRowxww== X-Google-Smtp-Source: ADUXVKL0qYfXIX5HpvGVvlRryB3EGSDiQKPgqhQAGOoUGMDHxCfPGvJRXVDsTTKW9TURcmj/B2Rg/gFg+WlAJCHEFes= X-Received: by 2002:a81:b70b:: with SMTP id v11-v6mr8248434ywh.182.1527993760847; Sat, 02 Jun 2018 19:42:40 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:ef50:0:0:0:0:0 with HTTP; Sat, 2 Jun 2018 19:42:10 -0700 (PDT) In-Reply-To: <201806022353.w52Nr1LA088636@pdx.rh.CN85.dnsmgr.net> References: <201806022140.w52LejjF005616@repo.freebsd.org> <201806022353.w52Nr1LA088636@pdx.rh.CN85.dnsmgr.net> From: Eitan Adler Date: Sat, 2 Jun 2018 19:42:10 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r334540 - head/usr.bin/top To: "Rodney W. Grimes" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jun 2018 02:42:42 -0000 On 2 June 2018 at 16:53, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] >> Author: eadler >> Date: Sat Jun 2 21:40:45 2018 >> New Revision: 334540 >> URL: https://svnweb.freebsd.org/changeset/base/334540 >> >> Log: >> top(1): cleanup memory allocation and warnings >> >> - Prefer calloc over malloc. This is more predicable and we're not in a >> performance sensitive context. [1] >> - Remove bogus comment (obsolete from prior commit). [2] >> - Remove void casts and type casts of NULL >> - Remove redundant declaration of 'quit' >> - Add additional const >> >> Reported by: kib [1], vangyzen [2] >> >> Modified: >> head/usr.bin/top/display.c >> head/usr.bin/top/machine.c >> head/usr.bin/top/screen.c >> head/usr.bin/top/screen.h >> head/usr.bin/top/utils.c > ... > >> >> Modified: head/usr.bin/top/screen.c >> ============================================================================== >> --- head/usr.bin/top/screen.c Sat Jun 2 21:16:20 2018 (r334539) >> +++ head/usr.bin/top/screen.c Sat Jun 2 21:40:45 2018 (r334540) >> @@ -3,7 +3,7 @@ >> * Version 3 >> * >> * This program may be freely redistributed, >> - * but this entire comment MUST remain intact. >> + * but this entire ceomment MUST remain intact. > > I know you have already fixed this spelling error, > but I believe there are some other commits that actually > removed either this string, or some part of "this entire" > comment that is to "remain intact". I just went through my commits to top(1) and don't see any others. Did I miss any? Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams