From owner-svn-src-head@freebsd.org  Sun Feb 11 00:10:34 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E2F8BF09965;
 Sun, 11 Feb 2018 00:10:33 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 96D6A7A2E9;
 Sun, 11 Feb 2018 00:10:33 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (ralph.baldwin.cx [66.234.199.215])
 by mail.baldwin.cx (Postfix) with ESMTPSA id F3EC310A7DB;
 Sat, 10 Feb 2018 19:10:31 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Alexey Dokuchaev <danfe@freebsd.org>
Cc: Warner Losh <imp@bsdimp.com>, svn-src-head@freebsd.org,
 svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>,
 Warner Losh <imp@freebsd.org>
Subject: Re: svn commit: r329064 - head/share/zoneinfo
Date: Sat, 10 Feb 2018 16:02:48 -0800
Message-ID: <9220095.UvqZmaNGKz@ralph.baldwin.cx>
User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; )
In-Reply-To: <20180209190450.GA85711@FreeBSD.org>
References: <201802091550.w19FoXEb018181@repo.freebsd.org>
 <CANCZdfrz4ph4YQnS6AvfKhtMMpAT74-7cnZcONfs2w-9r9tG_Q@mail.gmail.com>
 <20180209190450.GA85711@FreeBSD.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mail.baldwin.cx); Sat, 10 Feb 2018 19:10:32 -0500 (EST)
X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx
X-Virus-Status: Clean
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Feb 2018 00:10:34 -0000

On Friday, February 09, 2018 07:04:50 PM Alexey Dokuchaev wrote:
> On Fri, Feb 09, 2018 at 11:50:35AM -0700, Warner Losh wrote:
> > On Fri, Feb 9, 2018 at 10:49 AM, John Baldwin <jhb@freebsd.org> wrote:
> > > On Friday, February 09, 2018 03:50:33 PM Warner Losh wrote:
> > > > New Revision: 329064
> > > > URL: https://svnweb.freebsd.org/changeset/base/329064
> > > >
> > > > Log:
> > > >   We don't actually need env here, so drop it. All shells allow setting
> > > >   of shell variables for the next command like this.
> > >
> > > Eh:
> > >
> > > % LC_ALL=C env
> > > LC_ALL=C: Command not found.
> > >
> > > csh and tcsh don't let you set environment variables as a prefix.
> > >
> > > That said, if you try to use csh as the SHELL for make I bet many things
> > > would break.
> > 
> > Right, all shells supported as SHELL for make. csh isn't on the list of
> > supported shells. Your bet is right: a lot of things do break.
> 
> I don't really understand why we're discussing it: (t)csh, fish, whatever
> are for interactive use *only*.  Scripts (and makefiles) should only be
> written for standard plain POSIX shell.

I think the trigger is that "All shells" is a bit ambiguous.  "All shells
supported by make" or some such would have been clearer.

-- 
John Baldwin