From owner-svn-src-head@freebsd.org  Sun May 27 06:09:18 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2463EF7CA0A;
 Sun, 27 May 2018 06:09:18 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id CAC8F710C8;
 Sun, 27 May 2018 06:09:17 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id A37791DC6E; Sun, 27 May 2018 06:09:17 +0000 (UTC)
Date: Sun, 27 May 2018 06:09:17 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Mark Felder <feld@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r334221 - head/etc
Message-ID: <20180527060917.GA3179@FreeBSD.org>
References: <201805251936.w4PJaQIf093393@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201805251936.w4PJaQIf093393@repo.freebsd.org>
User-Agent: Mutt/1.9.5 (2018-04-13)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 May 2018 06:09:18 -0000

On Fri, May 25, 2018 at 07:36:26PM +0000, Mark Felder wrote:
> New Revision: 334221
> URL: https://svnweb.freebsd.org/changeset/base/334221
> 
> Log:
>   rc.subr: Support loading environmental variables from a file
>   
> +	if [ -n "$_env_file" ] && [ -r "${_env_file}" ]; then

Style bug: "$_env_file" vs. "${_env_file}".  Also, isn't the -n check
redundant?

> +		set -a
> +		. $_env_file

Shouldn't it be quoted here as well (. "$_env_file")?

./danfe