From owner-svn-src-head@freebsd.org Sun Jul 22 02:17:25 2018 Return-Path: <owner-svn-src-head@freebsd.org> Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8075D103A132; Sun, 22 Jul 2018 02:17:25 +0000 (UTC) (envelope-from woodsb02@gmail.com) Received: from mail-ua0-x230.google.com (mail-ua0-x230.google.com [IPv6:2607:f8b0:400c:c08::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 12ABF81723; Sun, 22 Jul 2018 02:17:25 +0000 (UTC) (envelope-from woodsb02@gmail.com) Received: by mail-ua0-x230.google.com with SMTP id p22-v6so9734157uao.7; Sat, 21 Jul 2018 19:17:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+SEr2SL0kdy9BKEi+iq6lFWfc7vdzufOxh08b7KxAmM=; b=tGvCua68DeTFAc8FqIo0KEJJuzhKoEgJ+xR+eN5MbxbeHygZ6Ld4Fo1R8pZYqAK+XU 1QgwSf5nEU/dbIQ06T0IvfdlMnA+RD/fK0Jw1sVJeyIq57UJQ0LqFQA3jLciSgb5Em75 9auYnUX8isk58JXJrRzgYl+ZZx6oFjPhMEjm6hT01zec4gyrG49zfmraDC71W6dEiIHe QLTmjynBdBiE/CHGBpMYMPlxYbcWwetuGevRUNAVoRzKq6NTb+hrohAidwgpg4ew/P7S +gffQxlPcJq85ftrnn+eRy4B+mKSicXfLDkmRhNGt+sLLto5AYfEptQ0emOOA02JjU51 NRBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+SEr2SL0kdy9BKEi+iq6lFWfc7vdzufOxh08b7KxAmM=; b=N0K46a9uY2K2jf/gDdHpevREWIUUtLy98hnfdPcM6Q6LI9zRYj/MWDTyXcypF+MBQT SnK1SAIEAUmXb9AhiWew831fI+2ZubhLzT4cNuLY0kAhGvBYNFCCC8oe5OHFuWG4osmW d4JS5kk5lVkWVLedDRckUU5Xl0L4TF0m68JQtnvaxxJ6WEj3VtqtES0RoLmKqizsgq+D PxCrO/g9qkZi1VunYAdkKvUz1Gdb6gbD75lQnl3lewy6JenJt++XjFjouSW3wvKB9YGo bVq4wBiaf3hniAieSbNR/UoRfWJIzJmXXPnxOtCLx9mpv9oXS8M7ksmWYBsdyL099CQp qBLg== X-Gm-Message-State: AOUpUlHFWgd4BQkX3pCedW+POxO1A9X6BPG6bzf3FjER7zgt0io3QQCT xTNSf+wEAa1aUIwoh2kp9zjWRf1J0sWYgQ2vtqbEE18m X-Google-Smtp-Source: AAOMgpfPEYZgQsjF6k/40sOwZLDuJRsmaD/9JJcp2kV1N5jMwTyXiDBX+fS5i9Do72uYaiuCzsVBDig5PCtS4FNmcm0= X-Received: by 2002:ab0:13c7:: with SMTP id n7-v6mr5217681uae.47.1532225844288; Sat, 21 Jul 2018 19:17:24 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ab0:6a:0:0:0:0:0 with HTTP; Sat, 21 Jul 2018 19:17:23 -0700 (PDT) In-Reply-To: <CAOtMX2iynLZ=PD6EvLYShQVe0d1Fe2k6dPBk0W=uKRByPjQY7A@mail.gmail.com> References: <201806261807.w5QI7Hod072088@repo.freebsd.org> <CAOtMX2iynLZ=PD6EvLYShQVe0d1Fe2k6dPBk0W=uKRByPjQY7A@mail.gmail.com> From: Ben Woods <woodsb02@gmail.com> Date: Sun, 22 Jul 2018 10:17:23 +0800 Message-ID: <CAOc73CAg8pLcETVNFDs40O8kG9OmvdeQPVJ_qMY5Wv79juv4nw@mail.gmail.com> Subject: Re: svn commit: r335673 - in head: etc/defaults etc/rc.d lib/geom/eli share/man/man5 To: Alan Somers <asomers@freebsd.org> Cc: Ben Woods <woodsb02@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current <svn-src-head.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>, <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/> List-Post: <mailto:svn-src-head@freebsd.org> List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>, <mailto:svn-src-head-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sun, 22 Jul 2018 02:17:25 -0000 On 22 July 2018 at 00:41, Alan Somers <asomers@freebsd.org> wrote: > It looks like this change is causing several of geli's tests to fail in > CI. Could you please take a look? The failure mode is that "geli attach" > exits 0 when it should fail instead. > > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/ > lastCompletedBuild/testReport/ > > Hi Alan, Thanks for the heads up - you are quite right! I have proposed a fix here - can you please review and approve for me to commit if you are happy with it? https://reviews.freebsd.org/D16386 Regards, Ben