From owner-freebsd-arch@freebsd.org Thu Nov 21 17:44:00 2019 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 696B11C60C9 for ; Thu, 21 Nov 2019 17:44:00 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47Jn3z2HFPz3D1H for ; Thu, 21 Nov 2019 17:43:58 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82d.google.com with SMTP id r20so4552458qtp.13 for ; Thu, 21 Nov 2019 09:43:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=ZmeqjRT0qSjMnTfe3DaSqauxDX7ziCsG3L1W86+/WTc=; b=b1aBwdaeMpMgLBWkZ2w4cNYt53nHcZSV2CnJ3mk0y/AhOSIUhaazakJcNmDwcvQa8u yoRVwZcGmo7+kYrsuYdos1Dh3LPuXCzHnyFGvDZ7PccuPG8K5PyZqnxg+e7Vngttq3hT 097P+vL8TRDZ1tDNQa4NwajQrDLcLqvzsb31JlMc3hW4ekY1yF8o5t4Q6uOP6jwa6WBo uoznWVhEcPF4epgdbw2XIF3WQt7lyksfYD8IeNtg8nLTMGBvNJ251tn7vZsmLrQ7WVjI eN7j3GlQaPxTGbKXG+wLePyA5hQZ/ed8C82D9sjyro5BjoI3AiqACKivZVXQZuLRez62 AV/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=ZmeqjRT0qSjMnTfe3DaSqauxDX7ziCsG3L1W86+/WTc=; b=uJ607K5kTgqksZzTTSwBunAYDl0mWxw1lIEpFsHf4D170Hv2CJPIeE7UjkKyIj0tdh 6+1tj2EpReOSnaeu5R9OtaKlv/oMNo23rnFqOM0hgCLH+ne+gv0w2nDCIYcP5kDy/lhL DIbzamyUQA0m6sAtHZ3qwvW/TdOg67zwc++E8Dm/ssyE0cOF7rC6jl3XoJ+b/raXkUa8 3XJHLppnAqyGsW1hZnJy+1Fh2QuahOeHyQmDxDUUXgho5ay5bj/x+krEda2qqEKSs45V jZyuyu1+Yh7tL0NG3iYNN1i1ckCYPREVw6/f9uOldbFM2XXDe4UsfQ3HBpa9CYMyDdZp cNrA== X-Gm-Message-State: APjAAAV4tFoNSbS7kKajgkFix9butj4Dy0GCE3zkIQ+xxzsizoVWiY8k W2weuK2iEMFOWkRa7d2c2Wr279yQu4cmqiwOPfI3ZifQ X-Google-Smtp-Source: APXvYqyowZTBGM5FMnusloSpczl67qCcIeDhmuqC4udKMFs9hr95nmZ2wc4Uml8QNR62LjvH13cKMvCCpOUU0HYDqns= X-Received: by 2002:aed:3be9:: with SMTP id s38mr9837800qte.175.1574358237508; Thu, 21 Nov 2019 09:43:57 -0800 (PST) MIME-Version: 1.0 From: Warner Losh Date: Thu, 21 Nov 2019 10:43:46 -0700 Message-ID: Subject: Killing Giant for 13 To: "freebsd-arch@freebsd.org" X-Rspamd-Queue-Id: 47Jn3z2HFPz3D1H X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=b1aBwdae; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::82d) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-4.73 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-arch@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_ONE(0.00)[1]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[d.2.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; TO_DN_EQ_ADDR_ALL(0.00)[]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.73)[ip: (-9.36), ipnet: 2607:f8b0::/32(-2.29), asn: 15169(-1.97), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2019 17:44:00 -0000 I'd like to kill Giant in 13 and schedule a firm removal date. The issues are (a) old drivers that aren't MP safe (b) some console / ATKBD interactions (c) newbus and (d) a few stays that haven't been characterized. (a) should be deleted or updated before the deadline (b) should be fixed by $SOMEONE[tm] (c) there's some work underway to refine the locking protocols to allow one to not have Giant held (there's real questions about how effective it is when things sleep or contend) (d) I'm researching. Would there be support for setting a firm deadline for Giant removal of around June 2020? This would be months ahead of a speculative 13.0 timeline (Earliest would be December 2020, latest would be maybe October 2021, the exact details aren't super relevant for a June target date). This is a preliminary inquiry to get a feel for support for this option and to gather additional issues and requirements. Comments? Warner From owner-freebsd-arch@freebsd.org Thu Nov 21 18:57:57 2019 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 294101C805D for ; Thu, 21 Nov 2019 18:57:57 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47JpjJ0jnxz3JCh for ; Thu, 21 Nov 2019 18:57:55 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.129.235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 29CB826012B; Thu, 21 Nov 2019 19:57:52 +0100 (CET) Subject: Re: Killing Giant for 13 To: Warner Losh , "freebsd-arch@freebsd.org" References: From: Hans Petter Selasky Message-ID: <9460794e-9992-1b80-5bfc-e807204bd22f@selasky.org> Date: Thu, 21 Nov 2019 19:54:50 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47JpjJ0jnxz3JCh X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 2a01:4f8:c17:6c4b::2 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-4.93 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net:c]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; IP_SCORE(-2.63)[ip: (-9.17), ipnet: 2a01:4f8::/29(-2.32), asn: 24940(-1.64), country: DE(-0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2019 18:57:57 -0000 On 2019-11-21 18:43, Warner Losh wrote: > I'd like to kill Giant in 13 and schedule a firm removal date. > > The issues are (a) old drivers that aren't MP safe (b) some console / ATKBD > interactions (c) newbus and (d) a few stays that haven't been characterized. > > (a) should be deleted or updated before the deadline > (b) should be fixed by $SOMEONE[tm] > (c) there's some work underway to refine the locking protocols to allow one > to not have Giant held (there's real questions about how effective it is > when things sleep or contend) > (d) I'm researching. > > Would there be support for setting a firm deadline for Giant removal of > around June 2020? This would be months ahead of a speculative 13.0 timeline > (Earliest would be December 2020, latest would be maybe October 2021, the > exact details aren't super relevant for a June target date). > > This is a preliminary inquiry to get a feel for support for this option and > to gather additional issues and requirements. Comments? > +1 I'd like to be added as reviewer for Giant removal patches. --HPS From owner-freebsd-arch@freebsd.org Thu Nov 21 19:40:51 2019 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5B0911C8F54 for ; Thu, 21 Nov 2019 19:40:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47Jqfq1nX3z3LRM for ; Thu, 21 Nov 2019 19:40:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-5.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id E1BF7A6BE for ; Thu, 21 Nov 2019 19:40:50 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: CFT: Open Crypto Framework Changes: Round 1 From: John Baldwin To: "freebsd-arch@freebsd.org" References: Openpgp: preference=signencrypt Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: <921919dd-6291-61af-2dc6-768bcdbd5cff@FreeBSD.org> Date: Thu, 21 Nov 2019 11:40:48 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Nov 2019 19:40:51 -0000 On 8/2/19 3:46 PM, John Baldwin wrote: > A while back I ranted about what I perceived to be several issues with > our in-kernel framework. I've been working on a first round of changes > over the past several months and believe I've gotten far enough to be > a first milestone that's probably suitable for merging. At this point > what I would most appreciate is design review on what I've done so far > (though an eye towards the future wouldn't hurt). I have more changes I > think I'd like to make, but this is a big enough chunk to chew on for > now. > > The code: > > https://github.com/freebsd/freebsd/compare/master...bsdjhb:ocf_rework I have progressed further on this work and would like to merge it into the tree soon. Some changes since the last summary I gave are: - Key lengths are now in bytes instead of bits to match all the other '*len' fields. Key lengths are also only in the session parameters and are fixed for the lifetime of a session. - Various helper functions to reduce code duplication in drivers. - Sessions that use per-op keys (such as GELI) can now be created without having to specify an initial key. - I have converted all drivers and consumers in the tree and verified that they compile, but I have not tested all of them. I have tested the following drivers: - cryptosoft - aesni (AES only) - blake2 - ccr and the following consumers: - cryptodev - IPsec - ktls_ocf I have not tested the following: - ccp - aesni with sha - hifn - kgssapi_krb5 - ubsec - padlock - safe - GELI - armv8_crypto (aarch64) - glxsb (i386) - sec (ppc) - cesa (armv7) - cryptocteon (mips64) - nlmsec (mips64) Help with additional testing would be greatly appreciated. Note that for drivers an easy way to test is to run 'cryptocheck -vaz' before and after. The output from cryptocheck should be identical, and there should be no mismatches. Some of these drivers had some dubious behavior (e.g. trying to carry over IVs across requests within a session), though they may have worked for at least some IPsec use cases before. -- John Baldwin