From owner-freebsd-current@freebsd.org Sun Aug 11 02:03:14 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2674DABED2 for ; Sun, 11 Aug 2019 02:03:14 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670053.outbound.protection.outlook.com [40.107.67.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 465j1X4jvPz4Rc8 for ; Sun, 11 Aug 2019 02:03:12 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XjiyBY94bz23NCFFvacYoGook8A0nFtZ87MD+ishTUaP2ruo42R3qejI13HsgUzgIiZ7TXEW9sIlt8Wb/gM1SUjy2I/6UccCk3PjyuSU4g1SU7UCOJ67y+K9mxX1m9pQWPPE8RSABbBoD8dMWcmPkdmS40gqVm1wrlKOyM8zwSah/5WQpi5nbjgHtzdIRduM4P16Ed6eWiNEOSjJrgQ/oR/TaRwuVVKXY1M3eN9Pla3bi4XWqJt+lJ5sWvNw4sBuYhpuDfIDhpXwI8LpP9VnP4Wdu1B1/BIuNh5OddNMALD4jORaHoN77s9N6pYm9lXofyP3IRKuk8+Cd488ItZVgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=081Dsg6v+3u7FrPYA7iMLGkOYNdO7LFPGbXy9sj3W9E=; b=IyQqRernmceicedn8gCvRFe410rP+yAGs51NDBg1JS0v19J0z92og2nIm/tu5794y0NwMT2xlkATjscQi1umoDY45pjFKag6e4IXQv43ABJ/FrNyl7aB0wzUz8DWZEMXVUnJSXLZyN7WINWAWnRhNxP5gApea/gNYewmnhdvGIEUCKCPnEZ/hSS1xevdetZPYXgr5XW4efFmrtqdkU2j5D3czpi1KStvrd0kkapuRZwjSZ1x3Id0REatiFbR8E+gIdbFPXSDBfWcVm0KxKDMVcspBX7QKSqprnqoogj2wGxLCweO7zo9CeVseVRurwzYh7wSbe8PR9905Nd3qbhsMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none Received: from YTBPR01MB3616.CANPRD01.PROD.OUTLOOK.COM (10.255.12.82) by YTBPR01MB2909.CANPRD01.PROD.OUTLOOK.COM (10.255.45.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.15; Sun, 11 Aug 2019 02:03:10 +0000 Received: from YTBPR01MB3616.CANPRD01.PROD.OUTLOOK.COM ([fe80::fc05:2310:90ce:16e]) by YTBPR01MB3616.CANPRD01.PROD.OUTLOOK.COM ([fe80::fc05:2310:90ce:16e%6]) with mapi id 15.20.2157.022; Sun, 11 Aug 2019 02:03:10 +0000 From: Rick Macklem To: "freebsd-current@FreeBSD.org" Subject: RFC: should lseek(SEEK_DATA/SEEK_HOLE) return ENOTTY? Thread-Topic: RFC: should lseek(SEEK_DATA/SEEK_HOLE) return ENOTTY? Thread-Index: AQHVT+jQ5wsNrJT2jUSYLr8e3O7szQ== Date: Sun, 11 Aug 2019 02:03:10 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5031c7e1-804e-497e-c9ae-08d71e000fb1 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:YTBPR01MB2909; x-ms-traffictypediagnostic: YTBPR01MB2909: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0126A32F74 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(376002)(136003)(366004)(396003)(39850400004)(199004)(189003)(33656002)(8676002)(2351001)(6916009)(4744005)(99286004)(186003)(74316002)(476003)(14454004)(6506007)(316002)(786003)(102836004)(86362001)(305945005)(25786009)(7696005)(52536014)(256004)(46003)(478600001)(2501003)(66476007)(64756008)(66446008)(66946007)(66556008)(81156014)(2906002)(5660300002)(486006)(71200400001)(53936002)(81166006)(8936002)(71190400001)(6436002)(55016002)(9686003)(5640700003)(76116006); DIR:OUT; SFP:1101; SCL:1; SRVR:YTBPR01MB2909; H:YTBPR01MB3616.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: SielOKaYZug8pMDWRoW6FXr97YK4UKDAIBD/xTSvIwKuzpJwxRxFG9xXwe+WTnVrFL8cm0ldKtoGda93vKhhh1xEEgGWJz10GRRYiWNd8OUDRrKSywQ351al/fBk66lGd0l8hfy+A6Iyzyl6//0Wgs2LIJnIbm5q/n6qHSHVjuF6btsEcDEo1OgPf0wuDtKHiAKnURxI2JyoSSXWPpdU+J26ZuJlOgnNlJVvW9Sw+ZogkHKgvO9m9VL6YZRvDgPZtwB6EcQkxzDV1UBiov/mhw+5H0StBIB33Jc9HVTRaMF5PDEJUv8hjOa3cUniQ0Sv9/z/TbdWJvvqiUpwhhoyPH8mQ5oSf5YaWOExwpAwHhv7YGO/UYnxQ6Y8Pk1OOnTFwQ0JDcKGe1qkLErNgNR4HjDg5nVNdYHm9rU1rD3uu4E= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 5031c7e1-804e-497e-c9ae-08d71e000fb1 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2019 02:03:10.7807 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OmoQwW76xhCb5k7AUufIZUUJGdtHcWUiTq6XYROeeC+KJMj/9zBHzJg7QyRQHtZ/PA5C/h58OEQjifcB0eeuKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTBPR01MB2909 X-Rspamd-Queue-Id: 465j1X4jvPz4Rc8 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.67.53 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-4.42 / 15.00]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[uoguelph.ca]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-1.13)[ipnet: 40.64.0.0/10(-3.34), asn: 8075(-2.28), country: US(-0.05)]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; RCVD_IN_DNSWL_NONE(0.00)[53.67.107.40.list.dnswl.org : 127.0.3.0]; TO_DN_EQ_ADDR_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; MIME_TRACE(0.00)[0:+]; ARC_ALLOW(-1.00)[i=1] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Aug 2019 02:03:14 -0000 Hi, I've noticed that, if you do a lseek(SEEK_DATA/SEEK_HOLE) on a file that resides in a file system that does not support holes, ENOTTY is returned. This error isn't listed for lseek() and seems a liitle weird. I can see a couple of alternatives to this: 1 - Return a different error. Maybe ENXIO? or 2 - Have lseek() do the trivial implementation when the VOP_IOCTL() fails. - For SEEK_DATA, just return the offset given as argument and for SEEK_H= OLE return the file's size as the offset. What do others think? rick ps: The man page should be updated, whatever is done w.r.t. this. From owner-freebsd-current@freebsd.org Sun Aug 11 03:37:49 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 153CDAE1DB for ; Sun, 11 Aug 2019 03:37:49 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 465l6h0ZScz4WDb for ; Sun, 11 Aug 2019 03:37:47 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf1-f48.google.com with SMTP id c9so72102300lfh.4 for ; Sat, 10 Aug 2019 20:37:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o0yKnO72vP/FPH8QccE++7EiHJGnmsSWZq1kvmRSWmw=; b=PABYprtLtQmtuMAtqKqji6XriTCfWbk7lglvB6ADQtrcQ9UdbwXYyw6qfVFLxWAzNZ no9x82SRsvwjbRMRm3qtkBqiv8tqLmQ3SVRCqSDXVtoORozvmH4ijO79TRIRr87IQeag c2exgYNK/YmLLhKbkIDevK9EGESbMhZdwBffr82kuVUqk22SOd113Fq09avgb8wSP7aP PjkXAdIe7HoGZEh3bNMwnm2wh2v9BNLlZK1WhixVjmJw0ko/ShrpT8PF/i82JDOB+5yk VKScFATk9Voqg3zpJudztz0A5d3SqHpHh1MO66vXnr4VXdJTAeBCTdxFepMjA8asTc/L FdSA== X-Gm-Message-State: APjAAAXr/3UWyO8UFyL/nv5zOYISRrF9HOEdIUFUg0kKNQ5CasT4v45Y kEd5u7Nc1I/pGa1GlM/0VrJ5UVBwIEWP4FBLGgA= X-Google-Smtp-Source: APXvYqwv4jCCeB5ZsKrXGqJq8Mcy5jJBqbNd1lXvWZHlj7UqEPPSJTFjdAL9UlJ1/x7c7GB36QBEs5nIPDnTMinSx4w= X-Received: by 2002:a19:6904:: with SMTP id e4mr17018198lfc.156.1565494666212; Sat, 10 Aug 2019 20:37:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alan Somers Date: Sat, 10 Aug 2019 21:37:34 -0600 Message-ID: Subject: Re: RFC: should lseek(SEEK_DATA/SEEK_HOLE) return ENOTTY? To: Rick Macklem Cc: "freebsd-current@FreeBSD.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 465l6h0ZScz4WDb X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-3.25 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; IP_SCORE(-1.26)[ip: (-0.48), ipnet: 209.85.128.0/17(-3.38), asn: 15169(-2.40), country: US(-0.05)]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.993,0]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[48.167.85.209.list.dnswl.org : 127.0.5.0]; SUBJECT_ENDS_QUESTION(1.00)[]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Aug 2019 03:37:49 -0000 On Sat, Aug 10, 2019 at 8:03 PM Rick Macklem wrote: > > Hi, > > I've noticed that, if you do a lseek(SEEK_DATA/SEEK_HOLE) on a file that > resides in a file system that does not support holes, ENOTTY is returned. > > This error isn't listed for lseek() and seems a liitle weird. > > I can see a couple of alternatives to this: > 1 - Return a different error. Maybe ENXIO? > or > 2 - Have lseek() do the trivial implementation when the VOP_IOCTL() fails. > - For SEEK_DATA, just return the offset given as argument and for SEEK_HOLE > return the file's size as the offset. I vote option 2. > > What do others think? rick > ps: The man page should be updated, whatever is done w.r.t. this. From owner-freebsd-current@freebsd.org Sun Aug 11 07:04:10 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C38F6B1AD6 for ; Sun, 11 Aug 2019 07:04:10 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 465qhn6S91z4f3L for ; Sun, 11 Aug 2019 07:04:09 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wr1-x42e.google.com with SMTP id z1so101860731wru.13 for ; Sun, 11 Aug 2019 00:04:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=ohLeNyh+YTqCClrlWhpoRGFwP0ZGYR0ktwiVnpycr5o=; b=NVrbZrGp1qWkGE/eqx1gGG1ZOlhUq1L9NbNouCCejXr34a5Jr5BQAjlb5U5EjGb6Sr kmU6i6OHnqmkdRwJ0H1mf2MYTq+zIWHmVq+JjvdX0zAZ5EbC/48Vt+S4IczIws6aapnS A5aXqPSVYM7mbLZdjIHhueo1LjBMkd+2B/ZEBfyQt3SQK3+ftWBybQVvqh6HO+fUgSv9 Mn4JHnigmoaaTxMN+Xn70l9HeJGPxkO0CkSmxxpSH/usGSRCeZmjjxCAI6pSkuwvW1R3 kIb1r3SV2SVUiSNMxXQ8Jk+XkONjoDrDhqnu0G6h7jrvGbZjFVGx4Zly8MQytNoHwENl /B/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=ohLeNyh+YTqCClrlWhpoRGFwP0ZGYR0ktwiVnpycr5o=; b=M4jtRngSNEACeGMdVqVt2TvFs/phu1guCw8cawHytAJD06UAeBfDOXCeYY5e4sytC3 gLWv9sk32Y5ZWpMdHkhmuNrnv5C4beYY+fGxtvOPyg40587+K8tpnT3OjPeFmQkBzEoj C7SeA3kbDrVg2fr4stJkvDhuHnRrSuGw0FFvvUly9iZ+8z2aETHSjKtG28l4V8E0hl3G VpAAahnROR3E2skD/SSCcs5kRvrYRxqCBq3/vVR7JgL3XWjGPWVrDXJ4UesGqzKkPi2i BmP/GUzc5ClRJHBVE3TmMAbRY0lq2VWwvToi8kPLVmwzrSchlIJZ1IFSc1VhLn/NYQdK At4Q== X-Gm-Message-State: APjAAAVKZgvn6bq9AQ2+N2Avu9HRVUOTisa4Ox2CfG/IxSg98GU4BNeO o3+VpM8AIim8/bQinvy4eYI= X-Google-Smtp-Source: APXvYqwoJ3xXquRWTZk7nNSt6U4+ww6ssDp0xXLCfATFizsBt4CMriolUcN0dngnd9KebVPl+FgDPQ== X-Received: by 2002:a5d:4703:: with SMTP id y3mr18828468wrq.63.1565507047607; Sun, 11 Aug 2019 00:04:07 -0700 (PDT) Received: from ernst.home (p5B3BE66A.dip0.t-ipconnect.de. [91.59.230.106]) by smtp.gmail.com with ESMTPSA id v124sm16911671wmf.23.2019.08.11.00.04.06 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 11 Aug 2019 00:04:06 -0700 (PDT) Date: Sun, 11 Aug 2019 09:04:05 +0200 From: Gary Jennejohn To: Rick Macklem Cc: "freebsd-current@FreeBSD.org" Subject: Re: RFC: should lseek(SEEK_DATA/SEEK_HOLE) return ENOTTY? Message-ID: <20190811090405.50cc49b1@ernst.home> In-Reply-To: References: Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 465qhn6S91z4f3L X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=NVrbZrGp; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of gljennjohn@gmail.com designates 2a00:1450:4864:20::42e as permitted sender) smtp.mailfrom=gljennjohn@gmail.com X-Spamd-Result: default: False [-2.99 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[gljennjohn@gmail.com]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.99)[-0.994,0]; FROM_EQ_ENVFROM(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RECEIVED_SPAMHAUS_PBL(0.00)[106.230.59.91.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; FREEMAIL_REPLYTO(0.00)[gmail.com]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[e.2.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (-9.14), ipnet: 2a00:1450::/32(-3.05), asn: 15169(-2.40), country: US(-0.05)]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Aug 2019 07:04:10 -0000 On Sun, 11 Aug 2019 02:03:10 +0000 Rick Macklem wrote: > Hi, > > I've noticed that, if you do a lseek(SEEK_DATA/SEEK_HOLE) on a file that > resides in a file system that does not support holes, ENOTTY is returned. > > This error isn't listed for lseek() and seems a liitle weird. > ENOTTY is the standard error return for an unimplemented ioctl(2), and SEEK_HOLE ultimately becomes a call to fo_ioctl(). > I can see a couple of alternatives to this: > 1 - Return a different error. Maybe ENXIO? > or > 2 - Have lseek() do the trivial implementation when the VOP_IOCTL() fails. > - For SEEK_DATA, just return the offset given as argument and for SEEK_HOLE > return the file's size as the offset. > > What do others think? rick > ps: The man page should be updated, whatever is done w.r.t. this. > I also vote for option 2 -- Gary Jennejohn From owner-freebsd-current@freebsd.org Sun Aug 11 14:57:08 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2A978BAE63 for ; Sun, 11 Aug 2019 14:57:08 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4662BW5SmRz429X for ; Sun, 11 Aug 2019 14:57:07 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1565535426; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=uErKKDPVxRRj+/waSnAzvLTTGO/WXS571z7q5UyvyDwia1kXK/Ay/iHAz+mhY/z5DoM4Tel4uRRn5 0fqds59oBpoYIkYNo4XnRNghUDr6NydmH1Cm+pkydKQgzERmq8W/9i0fQuDsC6eMnaKKLbGdKt68+o IsO61/9Lw/Pgsg7DV/Ptp2swA8Tl10Jly7ibZioj903NHwGkmLb4B0/c6xliWfDClvv7NF4YfaAmqd DRNZf/LZAtzu+UZ8PDmeCSKZrQR3TNddoztMyRsMBZuNTYc5g7qb1qUXjOOaYlyuU/o2gaAUQ0k3Gg TgW5ObCvZPWi/cTfsMnryvkeS362u9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=lpa3d0k7nXlkaEUY7tXcE97SLA0oOC3lIjwddXtE4a8=; b=HMTqD3O7mh3UStjYIEWXehX8ayHDfCgQAII/dQvhvXzYbLl4w+Q8FsipZiMqjJsIrc01Cxh+4q/jb fiFHWdRDqJxh6o8wCRkCuCwLv/5kcBkFtwm7JsnEqt3L8rOUpP6RwsHxrOMpV4mAg88iokh6XE50bb FyMTQw/C/OS6h4BleGGyos3n8fDFVwqFkPX+CY7BmaVETL562LQGvPY5+Y5Z3GY6h8xEOwzDdyxnN/ zs2rOa9O+wMdbA4KGAQoUtCRrvDELHzGJwi1/9BNXSnsZCRJd3+f9CABODCes9UVZUY9tenCFIUDqk QNFY55R0uNhsFdqSEWLN9LOyJfrdpnA== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=lpa3d0k7nXlkaEUY7tXcE97SLA0oOC3lIjwddXtE4a8=; b=QDpzX5CaFWruys/W6k1A/8O46Mj/Z7qC8J6eF8EZOG9mFkjXio71xmz3acbYyDMmk9e2BNk2skLts zQKvSsDafK/8U6aa7+GU7hxb8wkGs5xeQLTS6YBUuxWhBZncj6vA129W6m29SXtP27w1+/qDmnb/zi 2Y1XycnPs6TF0YjUTlHDjtK1+FwqLXyD/bXCNaQZtVNjEbjosxXgAjP9yiHG3apt51arfieDf8lzNr L2myitTGpid36tMslSuZ64EoKsC69j2ay5lkQ+Z69TfLWgMjxK9JX0/cxFy97l8ZOUKoAoUsTPiokm rXWtyyxFJCZUBlj98iFpF738X+9PKhw== X-MHO-RoutePath: aGlwcGll X-MHO-User: 481bf7db-bc48-11e9-b67a-cdd75d6ce7a8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id 481bf7db-bc48-11e9-b67a-cdd75d6ce7a8; Sun, 11 Aug 2019 14:57:05 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x7BEv4DJ042060; Sun, 11 Aug 2019 08:57:04 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: RFC: should lseek(SEEK_DATA/SEEK_HOLE) return ENOTTY? From: Ian Lepore To: gljennjohn@gmail.com, Rick Macklem Cc: "freebsd-current@FreeBSD.org" Date: Sun, 11 Aug 2019 08:57:04 -0600 In-Reply-To: <20190811090405.50cc49b1@ernst.home> References: <20190811090405.50cc49b1@ernst.home> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4662BW5SmRz429X X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Aug 2019 14:57:08 -0000 On Sun, 2019-08-11 at 09:04 +0200, Gary Jennejohn wrote: > On Sun, 11 Aug 2019 02:03:10 +0000 > Rick Macklem wrote: > > > Hi, > > > > I've noticed that, if you do a lseek(SEEK_DATA/SEEK_HOLE) on a file > > that > > resides in a file system that does not support holes, ENOTTY is > > returned. > > > > This error isn't listed for lseek() and seems a liitle weird. > > > > ENOTTY is the standard error return for an unimplemented ioctl(2), > and SEEK_HOLE ultimately becomes a call to fo_ioctl(). > > > I can see a couple of alternatives to this: > > 1 - Return a different error. Maybe ENXIO? > > or > > 2 - Have lseek() do the trivial implementation when the VOP_IOCTL() > > fails. > > - For SEEK_DATA, just return the offset given as argument and > > for SEEK_HOLE > > return the file's size as the offset. > > > > What do others think? rick > > ps: The man page should be updated, whatever is done w.r.t. this. > > > > I also vote for option 2 > If SEEK_DATA and SEEK_HOLE don't return the standard "ioctl not supported" error code and return a fake result, how are you supposed to determine at runtime whether SEEK_HOLE is supported or not? -- Ian From owner-freebsd-current@freebsd.org Sun Aug 11 15:13:13 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4BCDFBB443 for ; Sun, 11 Aug 2019 15:13:13 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4662Y5146Zz42vc; Sun, 11 Aug 2019 15:13:12 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-f175.google.com with SMTP id z17so7755489ljz.0; Sun, 11 Aug 2019 08:13:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JIR2N0tnLvD+MSaDu7+7aYh3Ec2zFaFqQd1Z+yrjrSQ=; b=Frof5e4aA8e0bKVvkeO6FT6qe+IyDntiWvWtYn3HAoZOhxfbjj+VDF1Ghh00qC99kG LOx+jdBsog7wi03v0OVWKG65Iu8B2nRKXQJ6NinloQnRLWsjBw6oAxwK64pCd2Pu0C4J uWuhr5cAMTZsz5WRaXLDQayPWTQzeh+ci1NJERIu246a6NEhmecgCIhvSRoYZhoMcxpu 6T9MKKLb8fxxv3Ohk2LNyf4kAfSW71KKaks9t1vqSW0wFDn88+S18QvxLHQrPf9p2I76 QogbBMe6KNu0y7aHQoVN7nYhgaKSeifsQLM9MSO4XiXp7Ui2YmIEvIGie6Ta35K10Zxh 86pA== X-Gm-Message-State: APjAAAXd8kdHSxT6rNpkt0wihLvYE4iEzGQxtjuU9scqCSQnZjVafs+U uxGNAYuQXpgtyD7xhTgQV57w5EyINwliV6q0P6N3rBgT X-Google-Smtp-Source: APXvYqxMtMWkn5lYEvlN9X33Pd5hhjxZVcTuihd7fbhO8PzsIoo0RA7BiYz0ByxuCjw2jsIimaL+NtEtxBh0bi/4bN0= X-Received: by 2002:a2e:2c07:: with SMTP id s7mr6048290ljs.44.1565536390096; Sun, 11 Aug 2019 08:13:10 -0700 (PDT) MIME-Version: 1.0 References: <20190811090405.50cc49b1@ernst.home> In-Reply-To: From: Alan Somers Date: Sun, 11 Aug 2019 09:12:58 -0600 Message-ID: Subject: Re: RFC: should lseek(SEEK_DATA/SEEK_HOLE) return ENOTTY? To: Ian Lepore Cc: gljennjohn@gmail.com, Rick Macklem , "freebsd-current@FreeBSD.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4662Y5146Zz42vc X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.987,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Aug 2019 15:13:13 -0000 On Sun, Aug 11, 2019 at 8:57 AM Ian Lepore wrote: > > On Sun, 2019-08-11 at 09:04 +0200, Gary Jennejohn wrote: > > On Sun, 11 Aug 2019 02:03:10 +0000 > > Rick Macklem wrote: > > > > > Hi, > > > > > > I've noticed that, if you do a lseek(SEEK_DATA/SEEK_HOLE) on a file > > > that > > > resides in a file system that does not support holes, ENOTTY is > > > returned. > > > > > > This error isn't listed for lseek() and seems a liitle weird. > > > > > > > ENOTTY is the standard error return for an unimplemented ioctl(2), > > and SEEK_HOLE ultimately becomes a call to fo_ioctl(). > > > > > I can see a couple of alternatives to this: > > > 1 - Return a different error. Maybe ENXIO? > > > or > > > 2 - Have lseek() do the trivial implementation when the VOP_IOCTL() > > > fails. > > > - For SEEK_DATA, just return the offset given as argument and > > > for SEEK_HOLE > > > return the file's size as the offset. > > > > > > What do others think? rick > > > ps: The man page should be updated, whatever is done w.r.t. this. > > > > > > > I also vote for option 2 > > > > If SEEK_DATA and SEEK_HOLE don't return the standard "ioctl not > supported" error code and return a fake result, how are you supposed to > determine at runtime whether SEEK_HOLE is supported or not? > > -- Ian pathconf(2) will tell you. From owner-freebsd-current@freebsd.org Sun Aug 11 16:20:53 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4E9B6BC73E for ; Sun, 11 Aug 2019 16:20:53 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4664391JGyz45yt; Sun, 11 Aug 2019 16:20:52 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wm1-x32d.google.com with SMTP id 10so10070096wmp.3; Sun, 11 Aug 2019 09:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=OGQMgEzOrapv9chm7jotOh4O3vxL1LnawQcJ+4Gl8Wc=; b=axO+hVVDjCxb5ilhCgs/ALNmCXCpnAIn8yhal83jMVYmucrcfGpDMeZ0/bqjt61xRR EyUBj5CmuVeinOe0WLt3TRWnriR9L2b1OKtfhFrA9UvbFfpKN/dvwk8POt0c64fnNFpr 9KlZ4OgyPL9/erNL3HDKGA0r8gPgDlpMe407RrvOm4kvXn3LwaiNB+EkaNdhFfFbmIr3 MzxkDC8MSEa7MEXcp08nmfxIiumnO3c1G2bz+z6lA9VeRMpGEJi7olzJiLD4kxYbV86C AwaOGEKQW7f0fIDNaMOjKwOq6xKOfPL8l5m7DDXGMjudFa/UXD0NvkcHudZFLWSo9C/I uZ7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=OGQMgEzOrapv9chm7jotOh4O3vxL1LnawQcJ+4Gl8Wc=; b=TtXRVgUMEELSTKsrt2d4sm75VOBojf/3zTBTgBsj9sE9xIDwz3WWDsFvXmC+UUpofE XGfYbmtvyXqFp4zATIFCNLMUmslSBmV8As9/kUbbx7jP8Hecr+hfbf9Jf9cE0KfPM8OC OFYG4A6JU3HFh3TK7x8zhbVD5pL4TqIvdxiymTWek5TzBYx3QT7opl2ryn3QOVCeGRPK JI7demRhoLkPGIuif3IJorhpo89ARNgTeHSz/M0o49+9DlDGlcCNueMO3yoQtp09mkrL VLeIquCiBYFQol2E+KUM+bFjcJB/NSCT5Scq3TKL7aBd13YuEgdY8NTL6WqYAIDGcEbA VfVA== X-Gm-Message-State: APjAAAV7iKbHPKRaITLCj++EU+tK/7Z1bNsdkkuuyA4HK/kMaSIz0ye1 cmOynon6wFthJdm3VonHf07CL7fA X-Google-Smtp-Source: APXvYqyS+wxMhKz4upFJF1KRbXuhYDgk6yrSlezDGnWHbJI8sVVpJHIJ+eyE5SzhTCwhOm3bR+9HVA== X-Received: by 2002:a1c:9a46:: with SMTP id c67mr4126090wme.152.1565540451340; Sun, 11 Aug 2019 09:20:51 -0700 (PDT) Received: from ernst.home (p5B3BE66A.dip0.t-ipconnect.de. [91.59.230.106]) by smtp.gmail.com with ESMTPSA id j20sm9215339wre.65.2019.08.11.09.20.50 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 11 Aug 2019 09:20:50 -0700 (PDT) Date: Sun, 11 Aug 2019 18:20:49 +0200 From: Gary Jennejohn To: Ian Lepore Cc: Rick Macklem , "freebsd-current@FreeBSD.org" Subject: Re: RFC: should lseek(SEEK_DATA/SEEK_HOLE) return ENOTTY? Message-ID: <20190811182049.1e707887@ernst.home> In-Reply-To: References: <20190811090405.50cc49b1@ernst.home> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4664391JGyz45yt X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.979,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Aug 2019 16:20:53 -0000 On Sun, 11 Aug 2019 08:57:04 -0600 Ian Lepore wrote: > On Sun, 2019-08-11 at 09:04 +0200, Gary Jennejohn wrote: > > On Sun, 11 Aug 2019 02:03:10 +0000 > > Rick Macklem wrote: > > > > > Hi, > > > > > > I've noticed that, if you do a lseek(SEEK_DATA/SEEK_HOLE) on a file > > > that > > > resides in a file system that does not support holes, ENOTTY is > > > returned. > > > > > > This error isn't listed for lseek() and seems a liitle weird. > > > > > > > ENOTTY is the standard error return for an unimplemented ioctl(2), > > and SEEK_HOLE ultimately becomes a call to fo_ioctl(). > > > > > I can see a couple of alternatives to this: > > > 1 - Return a different error. Maybe ENXIO? > > > or > > > 2 - Have lseek() do the trivial implementation when the VOP_IOCTL() > > > fails. > > > - For SEEK_DATA, just return the offset given as argument and > > > for SEEK_HOLE > > > return the file's size as the offset. > > > > > > What do others think? rick > > > ps: The man page should be updated, whatever is done w.r.t. this. > > > > > > > I also vote for option 2 > > > > If SEEK_DATA and SEEK_HOLE don't return the standard "ioctl not > supported" error code and return a fake result, how are you supposed to > determine at runtime whether SEEK_HOLE is supported or not? > My understanding of what Rick wrote was that, upon receiving ENOTTY from the ioctl, lseek() would simply do what he described in (2). His wording seems perfectly clear to me. -- Gary Jennejohn From owner-freebsd-current@freebsd.org Sun Aug 11 17:00:45 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E29D9BD5DE for ; Sun, 11 Aug 2019 17:00:45 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4664x93l1hz49LH for ; Sun, 11 Aug 2019 17:00:45 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1565542844; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=MxkHds+nlohJg4w0Ml2qhNPQLRXoYNFCwp6D3xsoHtCuMSQ2Tap4sipGCxApIdFOfyln/mLgHmvUL B6ilM85cHxXUtV/gk1IHE4LPwdSu47lywt9cW+OoPqb7Y7UC5CsxVuKI8gOzzDe6NpbL2H7Spdsygk 1HhpZGxus9yITXPSG0HF3A2bt9HRMqUBG8MHl1Oflyk9kifbq5oMJqa0R8U27os/0K63qiug+1hLol L4P2V58qEgX7RePRcllNhdHODGGgg0LcLM8HVzfzMXDHnzhi6ybEAw3CHnEVoDgGc7diyE0CVpdlRU LXt1XXyRPBymYT0k26giPGWrovh12FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=PIFDt0J5QC1lROR1LH3LgkRvaCzVF/V+P6DVUZ28ssQ=; b=vRAVa3aW35ybqN59wc3wTUZkSSQ0LZiZjQuI1eJ9u0QHZ57OCfRXweYy7x4uP1cQkmHKc0K1fPd2l r+mgn5tqtGObqwy9LMQ0Ipw4XlGuhUw2r0ZQlYtPbprJ8I8OWzbRAkEM1+1jyprHJtLIb1pJewEiiL xrV1HpFU89YrPGFw7PLoYqpTH9Ko/b07xFK3x5EdDs2WhfRMTbb0G28xK/xT3OKfA9GkC7B+PQGA5q Z51n7n0WJG4NXSL6+ZKx3Ber/Fnf5pag6Yp4uXBy2CGcR6Ymps0wFOD0z4AoE7Q3nkPxLQbsB38pWF pttBLEHoJsGrqERH5UrSJzJ8quL6kXA== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=PIFDt0J5QC1lROR1LH3LgkRvaCzVF/V+P6DVUZ28ssQ=; b=jYUcCLMl40Q1JzPtJ/HsSOfKTnGCgQXp/QAYUa0SF2oAJUEbvUnMIs4L+sz5pWmlaRy8C0uVmYdSr dCYloogN9wxg1orhRmBP4BSyoNXdkAVzwvj+kLhzirV2DZTbK2WPpZgWDzc0wAs+1ZBUE05X1RawbJ vZEjSipJEsTPic3CC45eCKmSUMN0UbqxvXHHbPDKXXlymTM8bVRHGNiiOtQQymDHEkjhkjteBo9Z5g ZQgpyfBngnRfLXCVezYypD4WO3Km6LJcxzXUBr7glrJRy8PzQEOErUq20zjGouJAH0yH4xToXOFrz0 TwV8zX2JLvQgIeJHJa663YkFvIBujMA== X-MHO-RoutePath: aGlwcGll X-MHO-User: 8d2a4b76-bc59-11e9-b67a-cdd75d6ce7a8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id 8d2a4b76-bc59-11e9-b67a-cdd75d6ce7a8; Sun, 11 Aug 2019 17:00:42 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x7BH0fw8042377; Sun, 11 Aug 2019 11:00:41 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: RFC: should lseek(SEEK_DATA/SEEK_HOLE) return ENOTTY? From: Ian Lepore To: Alan Somers Cc: gljennjohn@gmail.com, Rick Macklem , "freebsd-current@FreeBSD.org" Date: Sun, 11 Aug 2019 11:00:41 -0600 In-Reply-To: References: <20190811090405.50cc49b1@ernst.home> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4664x93l1hz49LH X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Aug 2019 17:00:45 -0000 On Sun, 2019-08-11 at 09:12 -0600, Alan Somers wrote: > On Sun, Aug 11, 2019 at 8:57 AM Ian Lepore wrote: > > > > On Sun, 2019-08-11 at 09:04 +0200, Gary Jennejohn wrote: > > > On Sun, 11 Aug 2019 02:03:10 +0000 > > > Rick Macklem wrote: > > > > > > > Hi, > > > > > > > > I've noticed that, if you do a lseek(SEEK_DATA/SEEK_HOLE) on a > > > > file > > > > that > > > > resides in a file system that does not support holes, ENOTTY is > > > > returned. > > > > > > > > This error isn't listed for lseek() and seems a liitle weird. > > > > > > > > > > ENOTTY is the standard error return for an unimplemented > > > ioctl(2), > > > and SEEK_HOLE ultimately becomes a call to fo_ioctl(). > > > > > > > I can see a couple of alternatives to this: > > > > 1 - Return a different error. Maybe ENXIO? > > > > or > > > > 2 - Have lseek() do the trivial implementation when the > > > > VOP_IOCTL() > > > > fails. > > > > - For SEEK_DATA, just return the offset given as argument > > > > and > > > > for SEEK_HOLE > > > > return the file's size as the offset. > > > > > > > > What do others think? rick > > > > ps: The man page should be updated, whatever is done w.r.t. > > > > this. > > > > > > > > > > I also vote for option 2 > > > > > > > If SEEK_DATA and SEEK_HOLE don't return the standard "ioctl not > > supported" error code and return a fake result, how are you > > supposed to > > determine at runtime whether SEEK_HOLE is supported or not? > > > > -- Ian > > pathconf(2) will tell you. > Ahh, I wasn't aware of that. For option 2, lseek() has to not just return the info, but must also actually set the file position accordingly, and has to treat offset >= filesize as an error. -- Ian From owner-freebsd-current@freebsd.org Sun Aug 11 22:20:02 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 786F7C4260 for ; Sun, 11 Aug 2019 22:20:02 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660058.outbound.protection.outlook.com [40.107.66.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 466D1Y46mDz4Sq4; Sun, 11 Aug 2019 22:20:00 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OE41v+3IAqH3PHKQ4TEA88VomD1B83Zh5dcDkeOYs8RlYjLLA9xWKBa9NAgmkCF9WidzcB/z8QjMb9q9YSpvL93k0CPmzpFyoV1BY7aP9zJhiwDolqVYZmWyN4hO8DXzUh+n6IVGY1eD2TxKrr9/MraUKfd8wuVyDJBgI+oEZ1panu2nUdSdse9VYh9EEK0TLECJPouUsluX+74Rcp4KoQksWZPhmoGyHJ64Ea4Qatboh7xwBbhd3rkryu9JaBiBHPyGxy9xoJC0qPIl3pq2zzTK7Oq5ykbWSIlKZnMvN6zCaMu0pci2fSGG5NWdq92GLfOXdtbrieoMbKXnENoqRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XPBRfLnmf29p1Kblv4SEcx8GwIhaVC1iUV4mDTZjt/o=; b=Vqprb/Ec0AUWt6j2BS6GLX73NkIvjODIgQsNZcg3mZdyjjmYqlgMF1QXEHonAFYDMPXfT6PRO/Xwfg9ccNy+ByJ2Cw8XmKHflilXVuS4Kk2P97dk7gijU76Zz11mZAEMZ8JogkwF2JZkyGdwO/mMJlGXRbekbldY4Fx+2PKKtEu2AqWEOGEPLfr7nqLfyn1tk2ljKp3i9KXud1MpCnSJYJmZF8nFpFOmuJxdzQFnDbjKMFLyCfkPYaH7BQugQMRNvoeQEV10lPADVqyq5IDNc7E9CVpDTVYxKgh/FQwnKqbuy2td5kDNB4poMzgO0DgIJGzeYWnoOQ8HDd0OGrYvhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none Received: from YTBPR01MB3616.CANPRD01.PROD.OUTLOOK.COM (10.255.12.82) by YTBPR01MB3263.CANPRD01.PROD.OUTLOOK.COM (10.255.13.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.18; Sun, 11 Aug 2019 22:19:58 +0000 Received: from YTBPR01MB3616.CANPRD01.PROD.OUTLOOK.COM ([fe80::fc05:2310:90ce:16e]) by YTBPR01MB3616.CANPRD01.PROD.OUTLOOK.COM ([fe80::fc05:2310:90ce:16e%6]) with mapi id 15.20.2157.022; Sun, 11 Aug 2019 22:19:58 +0000 From: Rick Macklem To: Ian Lepore , Alan Somers CC: "gljennjohn@gmail.com" , "freebsd-current@FreeBSD.org" Subject: Re: RFC: should lseek(SEEK_DATA/SEEK_HOLE) return ENOTTY? Thread-Topic: RFC: should lseek(SEEK_DATA/SEEK_HOLE) return ENOTTY? Thread-Index: AQHVT+jQ5wsNrJT2jUSYLr8e3O7szab1hhuAgACEJgCAAARxAIAAHhmAgABUNyQ= Date: Sun, 11 Aug 2019 22:19:57 +0000 Message-ID: References: <20190811090405.50cc49b1@ernst.home> , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: df5090a6-66d9-4525-78b8-08d71eaa0b6b x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:YTBPR01MB3263; x-ms-traffictypediagnostic: YTBPR01MB3263: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0126A32F74 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(366004)(396003)(346002)(39850400004)(136003)(199004)(51914003)(189003)(316002)(25786009)(476003)(76176011)(786003)(229853002)(486006)(99286004)(55016002)(8936002)(186003)(102836004)(9686003)(54906003)(5660300002)(7696005)(6506007)(53546011)(110136005)(52536014)(11346002)(446003)(6436002)(46003)(8676002)(66446008)(14454004)(76116006)(81156014)(53936002)(81166006)(66556008)(66476007)(305945005)(86362001)(6246003)(64756008)(478600001)(33656002)(71200400001)(71190400001)(4326008)(74316002)(256004)(2906002)(66946007); DIR:OUT; SFP:1101; SCL:1; SRVR:YTBPR01MB3263; H:YTBPR01MB3616.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: vUIudxbLu37J8dm9XwNVuzcaRuEHZ6VVCoprISQQ2S61v7gDApLdK6LFLxD3zRodI9qCBW9Avz7FqvEVrlqnTrWllXsvg2u4UZYAmwetdjWwukcxjhTqUm+RgseZxW48vN7MIwku5uwvfEB2Hikap25i84vxE01UH3cXwFoPpnxwvwAGaFGakWriBRjOIdF431oWTa9b9LOiEELplgOaRNYMegaioK37y5Z17xWcW8OTTEUIvn+QMctDDKk5SA0tKQyanAKTUL7V90FwI0aR1cTvTA7R1w8yaUId2tJkEwdEnBS6LqBC3WBfBvbS0gKmt7PI/uGkrGWPBxf5a3sLIBtvFh4HTE+B002Fmtu5swjfNbwSf2ujbaER/LcsjqvFYobzw5sfgbayR7AunFddoFCfw6mgpO5Dfy6R1bNINzk= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: df5090a6-66d9-4525-78b8-08d71eaa0b6b X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2019 22:19:57.9891 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1jvBc/nPjAKtDJurlcWBGeaCgfPauLi9Pup0CDaPy/+IfPVHs5k7sPVpOZrjgJ2oErstB8tmiO41xU2ZOivdrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTBPR01MB3263 X-Rspamd-Queue-Id: 466D1Y46mDz4Sq4 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.66.58 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-4.38 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; ARC_ALLOW(-1.00)[i=1]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[uoguelph.ca]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.94)[-0.943,0]; RCVD_IN_DNSWL_NONE(0.00)[58.66.107.40.list.dnswl.org : 127.0.3.0]; IP_SCORE(-1.14)[ipnet: 40.64.0.0/10(-3.34), asn: 8075(-2.28), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; SUBJECT_ENDS_QUESTION(1.00)[]; FREEMAIL_CC(0.00)[gmail.com] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Aug 2019 22:20:02 -0000 Ian Lepore wrote: >On Sun, 2019-08-11 at 09:12 -0600, Alan Somers wrote: >> On Sun, Aug 11, 2019 at 8:57 AM Ian Lepore wrote: >> > >> > On Sun, 2019-08-11 at 09:04 +0200, Gary Jennejohn wrote: >> > > On Sun, 11 Aug 2019 02:03:10 +0000 >> > > Rick Macklem wrote: >> > > >> > > > Hi, >> > > > >> > > > I've noticed that, if you do a lseek(SEEK_DATA/SEEK_HOLE) on a >> > > > file >> > > > that >> > > > resides in a file system that does not support holes, ENOTTY is >> > > > returned. >> > > > >> > > > This error isn't listed for lseek() and seems a liitle weird. >> > > > >> > > >> > > ENOTTY is the standard error return for an unimplemented >> > > ioctl(2), >> > > and SEEK_HOLE ultimately becomes a call to fo_ioctl(). That's true and explains why it returns ENOTTY. However, lseek(2) is not io= ctl(2) and it doesn't list ENOTTY as an error. (Just to make things confusing, lseek(2) using SEEK_DATA/SEEK_HOLE appears = to be only a POSIX draft at this point, so POSIX doesn't really help w.r.t. w= hat errors should be returned for this case.) >> > > >> > > > I can see a couple of alternatives to this: >> > > > 1 - Return a different error. Maybe ENXIO? >> > > > or >> > > > 2 - Have lseek() do the trivial implementation when the >> > > > VOP_IOCTL() >> > > > fails. >> > > > - For SEEK_DATA, just return the offset given as argument >> > > > and >> > > > for SEEK_HOLE >> > > > return the file's size as the offset. >> > > > >> > > > What do others think? rick >> > > > ps: The man page should be updated, whatever is done w.r.t. >> > > > this. >> > > > >> > > >> > > I also vote for option 2 >> > > >> > >> > If SEEK_DATA and SEEK_HOLE don't return the standard "ioctl not >> > supported" error code and return a fake result, how are you >> > supposed to >> > determine at runtime whether SEEK_HOLE is supported or not? >> > >> > -- Ian >> >> pathconf(2) will tell you. >> > >Ahh, I wasn't aware of that. > >For option 2, lseek() has to not just return the info, but must also >actually set the file position accordingly, and has to treat offset >=3D >filesize as an error. Yes, this check is done below the VOP_IOCTL() layer for the file system (using vn_bmap_seekhole() or custom code). I think the easiest way to implement #2 is create a vop_stdioctl() and put = it into sys/kern/vfs_default.c. It would need to do this check. Interestingly, I had assumed the discussion would have been between leaving the errno alone vs changing the errno. I only threw in #2 for completeness sake. --> Now, it appears that #2 is the favourite. I'll wait for more responses before I propose a patch. Thanks for the comments, rick From owner-freebsd-current@freebsd.org Mon Aug 12 07:46:35 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 952CDA850E; Mon, 12 Aug 2019 07:46:35 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 466SbG4hL7z3x6w; Mon, 12 Aug 2019 07:46:34 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-pl1-f193.google.com with SMTP id c2so47540599plz.13; Mon, 12 Aug 2019 00:46:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bfIabdTHs8nmQNWDc3vNesAa9dnnuRt6RxNCllJF4y4=; b=uO9yfDK65T6BwyKbPXNUtYwhPL0NmUIA8CAJSyGVTTJDdv6PUTw7A3KTObexrJxuZZ hcdAYRtPDGCxFG9dTOIh6mO7SdWHS7uiSiMhJjV8k5W5dmCLXOTQ+xAIcdzEynvbFfFN qXc5gxvelStGnWUoX8v+gfjUDfrboST/w4jJZNVxP1nCzL7JmnmiR6V7dPE9Vr/yTRHZ lNX1LYbsLunTRgcq93PLkHaR1uVB2DSFELcnDAnjluWD6xC+JCxWvffrHQzJMOOFhv8M WsnOsxRxpTT6BW4ga13QI1dKPS6S4SgfFjeUU+8C6ZpbllW3wjyBiqJ67YHI8gCzAYHx oK3Q== X-Gm-Message-State: APjAAAUQv4CHDVrfCs+0ZMB55soaXWZKdV/D0ouYKpoUjwfj7kYTp1Ya JvbuYIbIGKaF+nIwxgk1P28iegai X-Google-Smtp-Source: APXvYqwwQMjE/V4jUGII6Rc+qEjLcYCtQB7WWCSjqcZ/AL/A/fhYKS5oFtHXYCN9iS738l9J3lnM3g== X-Received: by 2002:a17:902:bb81:: with SMTP id m1mr32098809pls.125.1565595992458; Mon, 12 Aug 2019 00:46:32 -0700 (PDT) Received: from [192.168.1.36] (broadband-82-140-206-197.atc.tvcom.ru. [82.140.206.197]) by smtp.googlemail.com with ESMTPSA id dw7sm11628532pjb.21.2019.08.12.00.46.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Aug 2019 00:46:31 -0700 (PDT) Subject: Re: rc script: manual stop vs system shutdown To: Ian Lepore , Warner Losh , "Rodney W. Grimes" Cc: FreeBSD Current , freebsd-rc@freebsd.org References: <2e50fb67-8a19-412b-19d2-14f5f20b61f8@FreeBSD.org> <201908011553.x71FrTCd060252@gndrsh.dnsmgr.net> From: Andriy Gapon Openpgp: preference=signencrypt Message-ID: <91d1a853-c449-481a-b001-7c1f54e28fdd@FreeBSD.org> Date: Mon, 12 Aug 2019 10:46:29 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 466SbG4hL7z3x6w X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of agapon@gmail.com designates 209.85.214.193 as permitted sender) smtp.mailfrom=agapon@gmail.com X-Spamd-Result: default: False [-4.14 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; RCVD_TLS_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RWL_MAILSPIKE_GOOD(0.00)[193.214.85.209.rep.mailspike.net : 127.0.0.18]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.972,0]; RCVD_IN_DNSWL_NONE(0.00)[193.214.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; IP_SCORE(-1.16)[ipnet: 209.85.128.0/17(-3.38), asn: 15169(-2.39), country: US(-0.05)]; FORGED_SENDER(0.30)[avg@FreeBSD.org,agapon@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[197.206.140.82.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[avg@FreeBSD.org,agapon@gmail.com] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Aug 2019 07:46:35 -0000 On 01/08/2019 22:51, Ian Lepore wrote: > On Thu, 2019-08-01 at 21:14 +0300, Andriy Gapon wrote: >> On 01/08/2019 19:12, Warner Losh wrote: >>> >>> >>> On Thu, Aug 1, 2019, 10:53 AM Rodney W. Grimes >>> > >>> wrote: >>> >>> > >>> > Is it possible in an rc script to distinguish between a manual stop >>> > (e.g., service foo stop) and a stop during a system shutdown (via >>> > rc.shutdown) ? >>> > Are there any marker variables for that? >>> > Or something in the global system state? >>> >>> Not that I can think of, but I like this idea, >>> I am sure that use cases exist. >>> >>> >>> What is the use case that needs to disambiguate the two cases... >> >> I have one use case in mind and it's a truly special case. >> I want rc.d/watchdogd to gracefully stop watchdogd and to disable the >> watchdog timer when the stop action is requested manually. And I want >> it to stop watchdogd and set the watchdog timer to a special shutdown >> timeout during the shutdown. If the special timeout is configured, of >> course. >> > > The shutdown timeout is already supported: you just set '-x ' > in watchdogd_flags in rc.conf; no changes to the rc.d script needed. > > I think probably you don't even need the first part of what you want. > The -x arg covers you in the reboot case; most people probably won't > use it. But if you are using it, and you want to truly kill the dog, > you would just do "watchdog -t 0" after "service watchdogd stop". If > you really felt the need to cover that with a single service command, > then how about using "service watchdogd cancel" where the cancel verb > does the -t 0 after killing the daemon? I guess that there is more than one way to achieve what I want or something similar to that. Rather than "expend words" on a theoretical discussion, I decided to do this: https://reviews.freebsd.org/D21221 However, I am still open to the discussion and suggestions. One thing that I would prefer, though, is to make the watchdogd service as smart as possible -- but not smarter :-) -- that is, I would prefer to do without adding any new command verbs to it. -- Andriy Gapon From owner-freebsd-current@freebsd.org Mon Aug 12 09:14:31 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4512EAB510; Mon, 12 Aug 2019 09:14:31 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 466VXj6k39z436B; Mon, 12 Aug 2019 09:14:29 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-pg1-f180.google.com with SMTP id w3so11961492pgt.13; Mon, 12 Aug 2019 02:14:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:openpgp:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=tzVpj/gNw2BPOSdi7D8ic5+J4emHm2UKnA7aX0gBpCE=; b=Pfq5Z1tZ6+xdCz+0PIhspeZrg+0fgHB4EilQKJErXGHrTvdQpq1UsyhzyfBpUjehXD +7xO/gdzErEX1WZG4//J44FF/jAwhsExyewfVSY8O6novRDN4BpppxNwpHRexxrkb/Rz N2odaTeC0A6Lt/rKn3PA4tQD6i5E6HCzpTJNk1XKwd5D5gGDNdwxEc+s9AVxTOsa0L69 I901uc8viJeG0N8TcmshPko+1PYKksQIJcT95hUaA9I8+DHKIFxBkiv+or1lsgJYU5aD SwJuwmmmy/6DhrAxVEEwcqyK0Uyn35PYHNMKpXt5dJ4pdyLueyenErkfhqzdIxRRp3o7 oVig== X-Gm-Message-State: APjAAAVLV/+AmiVlBNHtH+X6HFuVhaTpqRUTbnAeVlb+TN/xtwq31MC5 OVhGdP4Z3dIy2KGP8BCIH26s/G3z X-Google-Smtp-Source: APXvYqyT2wRdlodRhsXEykrwxx1iENAX6d/WvJS1tgUat84XhNRHRATXabADiahfhcs5Gi7dugZ3xg== X-Received: by 2002:a17:90a:21c1:: with SMTP id q59mr6511269pjc.6.1565601268101; Mon, 12 Aug 2019 02:14:28 -0700 (PDT) Received: from [192.168.1.36] (broadband-82-140-206-197.atc.tvcom.ru. [82.140.206.197]) by smtp.googlemail.com with ESMTPSA id c12sm14921067pfc.22.2019.08.12.02.14.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Aug 2019 02:14:27 -0700 (PDT) To: FreeBSD Current , "freebsd-hackers@freebsd.org" From: Andriy Gapon Subject: userret: assert td_lk_slocks == 0 Openpgp: preference=signencrypt Message-ID: <94110a73-3c55-e87e-96ae-475014e45596@FreeBSD.org> Date: Mon, 12 Aug 2019 12:14:25 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 466VXj6k39z436B X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of agapon@gmail.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=agapon@gmail.com X-Spamd-Result: default: False [-6.13 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-3.14)[ip: (-9.89), ipnet: 209.85.128.0/17(-3.38), asn: 15169(-2.39), country: US(-0.05)]; NEURAL_HAM_SHORT(-0.99)[-0.989,0]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[180.215.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FORGED_SENDER(0.30)[avg@FreeBSD.org,agapon@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[197.206.140.82.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[avg@FreeBSD.org,agapon@gmail.com] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Aug 2019 09:14:31 -0000 I am trying to debug a leak of a shared vnode lock and I noticed that there is no check for td_lk_slocks in userret. There are checks for td_rw_rlocks and td_sx_slocks. I wonder if there is any valid scenario where a thread is allowed to retain a shared lock manager lock across system calls. Thanks! -- Andriy Gapon From owner-freebsd-current@freebsd.org Mon Aug 12 10:46:07 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 759E6ADEA3; Mon, 12 Aug 2019 10:46:07 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 466XZR0yY1z48gv; Mon, 12 Aug 2019 10:46:06 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x7CAjoGY051464 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 12 Aug 2019 13:45:54 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x7CAjoGY051464 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x7CAjo7W051463; Mon, 12 Aug 2019 13:45:50 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 12 Aug 2019 13:45:50 +0300 From: Konstantin Belousov To: Andriy Gapon Cc: Ian Lepore , Warner Losh , "Rodney W. Grimes" , FreeBSD Current , freebsd-rc@freebsd.org Subject: Re: rc script: manual stop vs system shutdown Message-ID: <20190812104550.GA2738@kib.kiev.ua> References: <2e50fb67-8a19-412b-19d2-14f5f20b61f8@FreeBSD.org> <201908011553.x71FrTCd060252@gndrsh.dnsmgr.net> <91d1a853-c449-481a-b001-7c1f54e28fdd@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <91d1a853-c449-481a-b001-7c1f54e28fdd@FreeBSD.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-Rspamd-Queue-Id: 466XZR0yY1z48gv X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.91 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.91)[-0.908,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Aug 2019 10:46:07 -0000 On Mon, Aug 12, 2019 at 10:46:29AM +0300, Andriy Gapon wrote: > On 01/08/2019 22:51, Ian Lepore wrote: > > On Thu, 2019-08-01 at 21:14 +0300, Andriy Gapon wrote: > >> On 01/08/2019 19:12, Warner Losh wrote: > >>> > >>> > >>> On Thu, Aug 1, 2019, 10:53 AM Rodney W. Grimes > >>> > > >>> wrote: > >>> > >>> > > >>> > Is it possible in an rc script to distinguish between a manual stop > >>> > (e.g., service foo stop) and a stop during a system shutdown (via > >>> > rc.shutdown) ? > >>> > Are there any marker variables for that? > >>> > Or something in the global system state? > >>> > >>> Not that I can think of, but I like this idea, > >>> I am sure that use cases exist. > >>> > >>> > >>> What is the use case that needs to disambiguate the two cases... > >> > >> I have one use case in mind and it's a truly special case. > >> I want rc.d/watchdogd to gracefully stop watchdogd and to disable the > >> watchdog timer when the stop action is requested manually. And I want > >> it to stop watchdogd and set the watchdog timer to a special shutdown > >> timeout during the shutdown. If the special timeout is configured, of > >> course. > >> > > > > The shutdown timeout is already supported: you just set '-x ' > > in watchdogd_flags in rc.conf; no changes to the rc.d script needed. > > > > I think probably you don't even need the first part of what you want. > > The -x arg covers you in the reboot case; most people probably won't > > use it. But if you are using it, and you want to truly kill the dog, > > you would just do "watchdog -t 0" after "service watchdogd stop". If > > you really felt the need to cover that with a single service command, > > then how about using "service watchdogd cancel" where the cancel verb > > does the -t 0 after killing the daemon? > > I guess that there is more than one way to achieve what I want or > something similar to that. > Rather than "expend words" on a theoretical discussion, I decided to do > this: https://reviews.freebsd.org/D21221 > However, I am still open to the discussion and suggestions. > One thing that I would prefer, though, is to make the watchdogd service > as smart as possible -- but not smarter :-) -- that is, I would prefer > to do without adding any new command verbs to it. Did you considered exporting kern_shutdown.c:rebooting as a sysctl ? From owner-freebsd-current@freebsd.org Mon Aug 12 10:49:05 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9D29BAE052; Mon, 12 Aug 2019 10:49:05 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 466Xds3YjXz48sJ; Mon, 12 Aug 2019 10:49:05 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-ot1-x341.google.com with SMTP id c34so17030902otb.7; Mon, 12 Aug 2019 03:49:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=uBM1FAzsK84kstKTP657BIwgAzqQ8ZqZnFgsxMyzFW4=; b=SIf8MRxtg0Q50ipF5GtSIQg+27xLQ/x+F9MjasDTBMLfJGGszwMWFxo9jU7EYYPwN/ kKwzcmp1hCaxuzy589i0c5BhFfXY3HLf+1tmwjGk5Y7mVXNkGDHYj73bG+UNSYhrdsaq 1uMDaQrP4pPm4sXB/YcUu23TTfP77kOfODOyhFoPMQX8zoReY9aXzYKzOrWKrT7bDrR3 IPBBLzYaeTQ0+4iO3Q/YAW2euw4zBKemwExDneVp4ab65Xi/jgpPFMc/7PSyyM/Wukf3 Ja2z/2r38mNphELxID2L7VSHORhdOtvn/6EerTHpwFxZyG3o8m5Xv3EA7aP6hyAUoIY8 1dtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uBM1FAzsK84kstKTP657BIwgAzqQ8ZqZnFgsxMyzFW4=; b=Lx1sRjmWsU9/rb5PvHS3KdAetqSScLHa7YuVaCdIi7iMmESCB1hyzcedhLhrZ1PXPb 3wcrGe+bA0O65oI0D0VTNzYd7hJjXFky8vzocccHeBIWrCVHv4QWtj6qUVJJLsvSM2MW b35ys4oBISyH816HB7M53dwrsUbPxOhRb8F/CljLtM45bJlRHWN0vnqRMapidiNOqrJQ GQC21qjaCn+KaX7iYTw0q1Ae6zIiiO8LlMV0FyNCh6D5Z9G9Xg38AexNn1PPltdTZLJd xoy3Ii4/4WnxJ8hazlttHSx7gN+f0+NEhcLUgFJbrSqDb5/ZV6MwZlZImF2zfbIcoH1M P8+A== X-Gm-Message-State: APjAAAVp41iej1C4a4FegtV8NXiSXFZzEt2PNIxMOZTl/0Xw8x19c5Gf RvcGBaUX9g9FImyU7613ds0Egdd6AmGY2RBFDqffgA== X-Google-Smtp-Source: APXvYqw3sinxQGx9jkWCp74zJlcxGZgJCOpf1y7dBMzRZBP3nn/mNfNgR6krOKOttXxsxVmS8g/7fgs/CgKRVBgalYE= X-Received: by 2002:aca:b788:: with SMTP id h130mr15046815oif.85.1565606944173; Mon, 12 Aug 2019 03:49:04 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:2516:0:0:0:0:0 with HTTP; Mon, 12 Aug 2019 03:49:03 -0700 (PDT) In-Reply-To: <94110a73-3c55-e87e-96ae-475014e45596@FreeBSD.org> References: <94110a73-3c55-e87e-96ae-475014e45596@FreeBSD.org> From: Mateusz Guzik Date: Mon, 12 Aug 2019 12:49:03 +0200 Message-ID: Subject: Re: userret: assert td_lk_slocks == 0 To: Andriy Gapon Cc: FreeBSD Current , "freebsd-hackers@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 466Xds3YjXz48sJ X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.984,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Aug 2019 10:49:05 -0000 On 8/12/19, Andriy Gapon wrote: > > I am trying to debug a leak of a shared vnode lock and I noticed that > there is no check for td_lk_slocks in userret. There are checks for > td_rw_rlocks and td_sx_slocks. I wonder if there is any valid scenario > where a thread is allowed to retain a shared lock manager lock across > system calls. > These counters are not for debugging purposes. They are part of poor man's starvation prevention for writers. If the target lock is taken for reading and someone wants to take it for writing, a bit will be set to denote this fact and prevent more readers from showing up. However, this can lead to deadlocks so if someone already has a read lock on something, they can bypass the bit and grab the extra read lock anyway. No locks are allowed to leak back to userspace and witness should already handles checking this for readers as well. -- Mateusz Guzik From owner-freebsd-current@freebsd.org Mon Aug 12 10:50:52 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 81ABDAE2B3; Mon, 12 Aug 2019 10:50:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 466Xgw1zpyz499R; Mon, 12 Aug 2019 10:50:51 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x7CAoijf052609 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 12 Aug 2019 13:50:48 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x7CAoijf052609 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x7CAoijp052608; Mon, 12 Aug 2019 13:50:44 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 12 Aug 2019 13:50:44 +0300 From: Konstantin Belousov To: Andriy Gapon Cc: FreeBSD Current , "freebsd-hackers@freebsd.org" Subject: Re: userret: assert td_lk_slocks == 0 Message-ID: <20190812105044.GB2738@kib.kiev.ua> References: <94110a73-3c55-e87e-96ae-475014e45596@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <94110a73-3c55-e87e-96ae-475014e45596@FreeBSD.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-Rspamd-Queue-Id: 466Xgw1zpyz499R X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.92 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.92)[-0.919,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Aug 2019 10:50:52 -0000 On Mon, Aug 12, 2019 at 12:14:25PM +0300, Andriy Gapon wrote: > > I am trying to debug a leak of a shared vnode lock and I noticed that > there is no check for td_lk_slocks in userret. There are checks for > td_rw_rlocks and td_sx_slocks. I wonder if there is any valid scenario > where a thread is allowed to retain a shared lock manager lock across > system calls. There is a situation where thread returns while keeping the lockmgr lock busied. This is used by buffer cache to keep everybody hands away of async buffers until io is finished. But the ownership of the lock is erased, and the thread's slocks count is decremented. I think it should be correct to add the assert you proposed. From owner-freebsd-current@freebsd.org Mon Aug 12 10:55:59 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7D845AE758; Mon, 12 Aug 2019 10:55:59 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 466Xnp2Rzjz49xs; Mon, 12 Aug 2019 10:55:58 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-pl1-f178.google.com with SMTP id ay6so47776988plb.9; Mon, 12 Aug 2019 03:55:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=622/z6LLRa/0hDvDa9YnbGSjikbJQS8KpQBrj4MD4v0=; b=mm4NOqlTuTg/w1BHybWrmKAiB6AHM2zFfV2d/jCqHIhqIxUVFjkyxIp5f8dzfmS86Q ywmx0/BgIheXwAQ4Abx8mZSYAvdgYDXDp7hsx5QA6YwCqgc8Kt+TEiS8Sfyp4n8559Ge z0iGOL/U9kPyZOk2h+VMmdOUhl2QDaAxS32YS41w3Cb6KcBFz0BJnVhnuTxtb9Ca7m0X Pd+q3w7B7UPC6wUKeveI/LvJzkT23vxkmN70XItWVRHZce+q//c1xCPUZeSKz0rpmIuu rN5nMh1d32vuV84fkj571Ba7pBp78UjXTU5y+NdxUh1Pn9hdlJKICJzjUa6LNo0enxsm OuWA== X-Gm-Message-State: APjAAAXxmL5aml9R9A8IlpuGHNK7SeA4CLiyxxFEAJZjh9UXD6UAB/jY ob6TBGYuWAu4f8pxEfzUog3XW+JC X-Google-Smtp-Source: APXvYqxvObdhJTi7ubKhKRh7WjhMUKXtYkBxjz7GMUC7PaW1jws2fMrfiMGbhglKCqxFI+NSKyhLoA== X-Received: by 2002:a17:902:86:: with SMTP id a6mr32660625pla.244.1565607356391; Mon, 12 Aug 2019 03:55:56 -0700 (PDT) Received: from [192.168.1.36] (broadband-82-140-206-197.atc.tvcom.ru. [82.140.206.197]) by smtp.googlemail.com with ESMTPSA id a128sm123283225pfb.185.2019.08.12.03.55.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Aug 2019 03:55:55 -0700 (PDT) Subject: Re: userret: assert td_lk_slocks == 0 To: Mateusz Guzik Cc: FreeBSD Current , "freebsd-hackers@freebsd.org" References: <94110a73-3c55-e87e-96ae-475014e45596@FreeBSD.org> From: Andriy Gapon Openpgp: preference=signencrypt Message-ID: Date: Mon, 12 Aug 2019 13:55:53 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 466Xnp2Rzjz49xs X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of agapon@gmail.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=agapon@gmail.com X-Spamd-Result: default: False [-6.11 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_SHORT(-0.99)[-0.988,0]; FORGED_SENDER(0.30)[avg@FreeBSD.org,agapon@gmail.com]; FREEMAIL_TO(0.00)[gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[197.206.140.82.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[avg@FreeBSD.org,agapon@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[178.214.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-3.12)[ip: (-9.77), ipnet: 209.85.128.0/17(-3.38), asn: 15169(-2.39), country: US(-0.05)]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Aug 2019 10:55:59 -0000 On 12/08/2019 13:49, Mateusz Guzik wrote: > On 8/12/19, Andriy Gapon wrote: >> >> I am trying to debug a leak of a shared vnode lock and I noticed that >> there is no check for td_lk_slocks in userret. There are checks for >> td_rw_rlocks and td_sx_slocks. I wonder if there is any valid scenario >> where a thread is allowed to retain a shared lock manager lock across >> system calls. >> > > These counters are not for debugging purposes. They are part of poor > man's starvation prevention for writers. Yes, I realize that. > If the target lock is taken for reading and someone wants to take it for > writing, a bit will be set to denote this fact and prevent more readers > from showing up. However, this can lead to deadlocks so if someone > already has a read lock on something, they can bypass the bit and > grab the extra read lock anyway. > > No locks are allowed to leak back to userspace and witness should > already handles checking this for readers as well. Yes. But since we have those asserts for td_rw_rlocks and td_sx_slocks, wouldn't it make sense to add one for td_lk_slocks? If it's considered superfluous for FreeBSD, then at least I'll add it in the work's fork. -- Andriy Gapon From owner-freebsd-current@freebsd.org Mon Aug 12 10:58:02 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DF5ECAEA91; Mon, 12 Aug 2019 10:58:02 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 466Xr947Hqz4BMk; Mon, 12 Aug 2019 10:58:00 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-pg1-f171.google.com with SMTP id w10so49288009pgj.7; Mon, 12 Aug 2019 03:58:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4LqhkQRnmKW8hGKhSBsc8eCpnVHck4fPH6v4vmVJMq4=; b=IN4+dNiuN70ZzgU8emVMvScV0IlBINxa1vqjbnH+8gYVnuTRJPD9Mm3poq80fWWmX4 KILVcxWuyjO30Dp5iNxaGo98lCz7sw9kmovtCvXVerkObt6/DwurE0fOBuBB6Oz8oPYP zRXDGFCZZzH2yqwbIMHJ4mfMz9kM0tQ+/s5UZN2NJz4mSLS1k7FoL5GSSgN2Q6+jfcdM 3AthOsFJavRK8kBvqnXWDOA8dKt8Vp/cJ8Lg8HArFXZ4CZs5tgqeTrPc/iw1qSBGmmH6 Ld+3WNs2ZUV2+PgUuU2oxFogv1OBK5gqfK2/FJe+o3HjAjzw5FeNAHEyR8kOR1KmrjqX +MFw== X-Gm-Message-State: APjAAAX99ExnLKLGBC3f3J4TPU8ErevN4oe4kQnISjAkkXdSWBWWTl/6 Pi8gzsZK4ZofX6/7HYJQ+jJhlTg5 X-Google-Smtp-Source: APXvYqy5DNsFc12FFTeOQ5P+s16BN5HiNpdfevJTBnezWfOp0BW3LT+M8pLdzqZnyZUZ19VvZLhK4w== X-Received: by 2002:a17:90a:fa0a:: with SMTP id cm10mr7197125pjb.133.1565607479074; Mon, 12 Aug 2019 03:57:59 -0700 (PDT) Received: from [192.168.1.36] (broadband-82-140-206-197.atc.tvcom.ru. [82.140.206.197]) by smtp.googlemail.com with ESMTPSA id f6sm107879175pga.50.2019.08.12.03.57.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Aug 2019 03:57:58 -0700 (PDT) Subject: Re: rc script: manual stop vs system shutdown To: Konstantin Belousov Cc: Ian Lepore , Warner Losh , "Rodney W. Grimes" , FreeBSD Current , freebsd-rc@FreeBSD.org References: <2e50fb67-8a19-412b-19d2-14f5f20b61f8@FreeBSD.org> <201908011553.x71FrTCd060252@gndrsh.dnsmgr.net> <91d1a853-c449-481a-b001-7c1f54e28fdd@FreeBSD.org> <20190812104550.GA2738@kib.kiev.ua> From: Andriy Gapon Openpgp: preference=signencrypt Message-ID: <52b2eac3-83de-a7c7-5126-c742e2f195a8@FreeBSD.org> Date: Mon, 12 Aug 2019 13:57:55 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190812104550.GA2738@kib.kiev.ua> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 466Xr947Hqz4BMk X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of agapon@gmail.com designates 209.85.215.171 as permitted sender) smtp.mailfrom=agapon@gmail.com X-Spamd-Result: default: False [-6.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[FreeBSD.org]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; RCVD_IN_DNSWL_NONE(0.00)[171.215.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; IP_SCORE(-3.11)[ip: (-9.74), ipnet: 209.85.128.0/17(-3.38), asn: 15169(-2.39), country: US(-0.05)]; FORGED_SENDER(0.30)[avg@FreeBSD.org,agapon@gmail.com]; FREEMAIL_TO(0.00)[gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[197.206.140.82.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[avg@FreeBSD.org,agapon@gmail.com]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Aug 2019 10:58:03 -0000 On 12/08/2019 13:45, Konstantin Belousov wrote: > On Mon, Aug 12, 2019 at 10:46:29AM +0300, Andriy Gapon wrote: >> I guess that there is more than one way to achieve what I want or >> something similar to that. >> Rather than "expend words" on a theoretical discussion, I decided to do >> this: https://reviews.freebsd.org/D21221 >> However, I am still open to the discussion and suggestions. >> One thing that I would prefer, though, is to make the watchdogd service >> as smart as possible -- but not smarter :-) -- that is, I would prefer >> to do without adding any new command verbs to it. > > Did you considered exporting kern_shutdown.c:rebooting as a sysctl ? No, I didn't it. Thank you for the suggestion. Let me investigate it. -- Andriy Gapon From owner-freebsd-current@freebsd.org Mon Aug 12 11:03:42 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4B5E7AF47A; Mon, 12 Aug 2019 11:03:42 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 466Xyj3BKnz4CLs; Mon, 12 Aug 2019 11:03:41 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-pg1-f194.google.com with SMTP id x15so38948480pgg.8; Mon, 12 Aug 2019 04:03:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RRR0XCQP3z/2zeJdSqlcwArQibmy44WNvk4Q1dSuGKQ=; b=hee2lpAicXLeYWOmdUG+XVgLdVRreOaCW19jGN8V4W0X9waFVLY+WrOQR0QE5sOIYH Yh23sh8/jr0+v/qrNUbq5t+u3/yWxNx0VFm7lZbAXEQrnOiTPWp3jxlA3ld1guaPdPLF HU1XWC/dbe/7LEYt7AeWfOUQueCwR2anrSOuvjLI8mL2zWAbndJC8VgdVJVmEvzLj5j7 Uo59AGxbEpyn8DLCfrfcx5o3ohDSmweLxDCAh0anOyY7EqwF1bkTcUhQ6ZYqSElOgS1/ HZ+MsrW9fGgCuFvvpe8z6VsHN2z32Dh6HSC5H8qancY8SBGZ0UkYPR/fIFV78GueG5bf POpA== X-Gm-Message-State: APjAAAX0n/dXt4WV/8IL0/xTCvQnuUrUBMOGp7p9UPG8RCla1hbZT41E SuYK5qUwk9WTzs1Y30R/W9XSOO9C X-Google-Smtp-Source: APXvYqxzcVENPbG4JbzXIRY7wJfGw+78mMJWuwykNqLg5cba5jsC2yuq0ESBmVo9OEcEBG9NnWiIrg== X-Received: by 2002:a63:6d6:: with SMTP id 205mr30440430pgg.262.1565607818831; Mon, 12 Aug 2019 04:03:38 -0700 (PDT) Received: from [192.168.1.36] (broadband-82-140-206-197.atc.tvcom.ru. [82.140.206.197]) by smtp.googlemail.com with ESMTPSA id s24sm71032523pgm.3.2019.08.12.04.03.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Aug 2019 04:03:37 -0700 (PDT) Subject: Re: rc script: manual stop vs system shutdown From: Andriy Gapon To: Konstantin Belousov Cc: Ian Lepore , Warner Losh , "Rodney W. Grimes" , FreeBSD Current , freebsd-rc@FreeBSD.org References: <2e50fb67-8a19-412b-19d2-14f5f20b61f8@FreeBSD.org> <201908011553.x71FrTCd060252@gndrsh.dnsmgr.net> <91d1a853-c449-481a-b001-7c1f54e28fdd@FreeBSD.org> <20190812104550.GA2738@kib.kiev.ua> <52b2eac3-83de-a7c7-5126-c742e2f195a8@FreeBSD.org> Openpgp: preference=signencrypt Message-ID: <7a72dcf7-899f-a67b-d66a-cc48a094c7cf@FreeBSD.org> Date: Mon, 12 Aug 2019 14:03:34 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <52b2eac3-83de-a7c7-5126-c742e2f195a8@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 466Xyj3BKnz4CLs X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of agapon@gmail.com designates 209.85.215.194 as permitted sender) smtp.mailfrom=agapon@gmail.com X-Spamd-Result: default: False [-4.13 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; RWL_MAILSPIKE_GOOD(0.00)[194.215.85.209.rep.mailspike.net : 127.0.0.18]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_SHORT(-0.97)[-0.970,0]; FORGED_SENDER(0.30)[avg@FreeBSD.org,agapon@gmail.com]; FREEMAIL_TO(0.00)[gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[197.206.140.82.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[avg@FreeBSD.org,agapon@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[194.215.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.16)[ipnet: 209.85.128.0/17(-3.38), asn: 15169(-2.39), country: US(-0.05)]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Aug 2019 11:03:42 -0000 On 12/08/2019 13:57, Andriy Gapon wrote: > On 12/08/2019 13:45, Konstantin Belousov wrote: >> On Mon, Aug 12, 2019 at 10:46:29AM +0300, Andriy Gapon wrote: >>> I guess that there is more than one way to achieve what I want or >>> something similar to that. >>> Rather than "expend words" on a theoretical discussion, I decided to do >>> this: https://reviews.freebsd.org/D21221 >>> However, I am still open to the discussion and suggestions. >>> One thing that I would prefer, though, is to make the watchdogd service >>> as smart as possible -- but not smarter :-) -- that is, I would prefer >>> to do without adding any new command verbs to it. >> >> Did you considered exporting kern_shutdown.c:rebooting as a sysctl ? > > No, I didn't it. Thank you for the suggestion. > Let me investigate it. 'rebooting' seems to be too late, it's set when the actual reboot system call is made. rc.shutdown is run before that. I think that the kernel is generally[*] not aware of an imminent shutdown between the time init(8) is signaled and the time init(8) calls reboot(2). [*] -- except for cases where the kernel is an initiator of the shutdown. -- Andriy Gapon From owner-freebsd-current@freebsd.org Tue Aug 13 02:56:32 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4F4DBC961E for ; Tue, 13 Aug 2019 02:56:32 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from mail.nomadlogic.org (mail.nomadlogic.org [174.136.98.114]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.nomadlogic.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 466y6731WJz4KWH for ; Tue, 13 Aug 2019 02:56:31 +0000 (UTC) (envelope-from pete@nomadlogic.org) Received: from [192.168.1.206] (cpe-23-243-162-239.socal.res.rr.com [23.243.162.239]) by mail.nomadlogic.org (OpenSMTPD) with ESMTPSA id 1c56ff02 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO; Tue, 13 Aug 2019 02:49:49 +0000 (UTC) Subject: Re: 13.0 Current - r350702 exposed a Xorg failure To: "Clay Daniels Jr." , "freebsd-current@freebsd.org" References: From: Pete Wright Message-ID: <8b73d162-e293-2ead-b6b0-b79325b24346@nomadlogic.org> Date: Mon, 12 Aug 2019 19:49:49 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 466y6731WJz4KWH X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of pete@nomadlogic.org designates 174.136.98.114 as permitted sender) smtp.mailfrom=pete@nomadlogic.org X-Spamd-Result: default: False [-5.78 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[nomadlogic.org]; RECEIVED_SPAMHAUS_PBL(0.00)[239.162.243.23.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.984,0]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; IP_SCORE(-2.50)[ip: (-9.31), ipnet: 174.136.96.0/20(-2.89), asn: 25795(-0.24), country: US(-0.05)]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:25795, ipnet:174.136.96.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Aug 2019 02:56:32 -0000 On 8/9/19 8:56 PM, Clay Daniels Jr. wrote: > I was eager to load the new 13.0 Current snapshot yesterday as I wanted to > play with the new FUSE tools. I was running 13.0 Current r350491 from last > week and everything was going great. So last night, a little late I guess, > I wiped the older install and loaded r250702. Then I loaded Xorg, all 172 > packages, and loaded the drm-kmod video driver kernel modules, and then ran > startx (as user of course). I got errors & it was late so today I looked > closer. It said: > "xauth: file .serverauth.1039 does not exist" > > Well, this file is apparently something created automatically. I played > with the half-running install for a long time. It ran fine in console mode. > Then I the wiped it and reloaded the same newer r350702. No Go. > > Wiped the new r350702 and reloaded the older r350491 that was working just > fine last night. Same Problem....serverauth.xxx > > Now, I do know that the drm-kmod was the same (g20190710) that had worked > for me at least two times already. I do not know if the Xorg pkg is the > same. I couldn't find a date other than "latest". I'm writing this email > from my Linux partition. first thing that comes to mind, did you make sure to add your user to the "video" group?  this doesn't sound related though...this does sound like a local configuration issue.  iirc when i ran into this problem in the past it was due to permissions, either a .serverauth file owned by root or a UID that no longer exists. -p -- Pete Wright pete@nomadlogic.org @nomadlogicLA From owner-freebsd-current@freebsd.org Tue Aug 13 10:31:13 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B0D85AA44D for ; Tue, 13 Aug 2019 10:31:13 +0000 (UTC) (envelope-from yasu@utahime.org) Received: from gate.utahime.jp (gate.utahime.jp [183.180.29.210]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4678Bm18rGz4fd4 for ; Tue, 13 Aug 2019 10:31:11 +0000 (UTC) (envelope-from yasu@utahime.org) Received: from eastasia.home.utahime.org (eastasia.home.utahime.org [192.168.174.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by gate.utahime.jp (Postfix) with ESMTPS id EC55B4AB4; Tue, 13 Aug 2019 19:30:58 +0900 (JST) Received: from localhost (rolling.home.utahime.org [192.168.174.11]) (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by eastasia.home.utahime.org (Postfix) with ESMTPSA id DEACC11070; Tue, 13 Aug 2019 19:30:57 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.101.3 at eastasia.home.utahime.org Date: Tue, 13 Aug 2019 19:30:30 +0900 (JST) Message-Id: <20190813.193030.2237885695627385084.yasu@utahime.org> To: freebsd-current@freebsd.org Subject: Bug report commit request From: Yasuhiro KIMURA X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4678Bm18rGz4fd4 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of yasu@utahime.org designates 183.180.29.210 as permitted sender) smtp.mailfrom=yasu@utahime.org X-Spamd-Result: default: False [-0.42 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-0.92)[-0.917,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+a:spf-authorized.utahime.org]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[utahime.org]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-0.97)[-0.973,0]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(0.24)[ip: (0.29), ipnet: 183.180.0.0/16(0.14), asn: 2519(0.79), country: JP(-0.03)]; MV_CASE(0.50)[]; MID_CONTAINS_FROM(1.00)[]; NEURAL_SPAM_SHORT(0.03)[0.028,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:2519, ipnet:183.180.0.0/16, country:JP]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Aug 2019 10:31:13 -0000 Dear Committers, Would someone please commit following bug report? Bug 236564 - periodic.sh: Anticongestion function does not work as is expected. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236564 Best Regards. --- Yasuhiro KIMURA From owner-freebsd-current@freebsd.org Tue Aug 13 13:31:53 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EF21EAF956 for ; Tue, 13 Aug 2019 13:31:53 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 467DCD5y7Xz3LwV; Tue, 13 Aug 2019 13:31:52 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.129.235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 8021C2603E1; Tue, 13 Aug 2019 15:31:50 +0200 (CEST) Subject: Re: Boot still broken from r349133-r349160 - Was re:(Problem with USB after r349133) To: Scott Long , Nick Wolff Cc: "Clay Daniels Jr." , "Rodney W. Grimes" , lausts@acm.org, freebsd-current@freebsd.org, Jung-uk Kim References: <201907300011.x6U0BO8w046636@gndrsh.dnsmgr.net> From: Hans Petter Selasky Message-ID: <98c2c54e-6d77-4cca-78d5-fcffeb65b80c@selasky.org> Date: Tue, 13 Aug 2019 15:31:09 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 467DCD5y7Xz3LwV X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 88.99.82.50 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-4.96 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net:c]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; SUSPICIOUS_RECIPS(1.50)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.972,0]; RCPT_COUNT_SEVEN(0.00)[7]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; IP_SCORE(-3.19)[ip: (-9.35), ipnet: 88.99.0.0/16(-4.74), asn: 24940(-1.83), country: DE(-0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:88.99.0.0/16, country:DE]; FREEMAIL_CC(0.00)[gmail.com]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Aug 2019 13:31:54 -0000 Hi, After tearing ACPI apart, there appears to be an issue like following: 1) AcpiUtAcquireMutex() doesn't support recursion, but also fails to report an error when such a condition is occurring. Here is the backtrace of the illegal mutex recursion. > AcpiUtAcquireMutex() at AcpiUtAcquireMutex+0x1fc/frame 0xffffffff834815d0 > AcpiWalkNamespace() at AcpiWalkNamespace+0x8a/frame 0xffffffff83481640 > AcpiNsInitializeObjects() at AcpiNsInitializeObjects+0x9b/frame 0xffffffff834816c0 > AcpiExLoadTableOp() at AcpiExLoadTableOp+0x21c/frame 0xffffffff83481730 > AcpiExOpcode_6A_0T_1R() at AcpiExOpcode_6A_0T_1R+0x22e/frame 0xffffffff83481790 > AcpiDsExecEndOp() at AcpiDsExecEndOp+0x1dc/frame 0xffffffff83481830 > AcpiPsParseLoop() at AcpiPsParseLoop+0x75a/frame 0xffffffff83481880 > AcpiPsParseAml() at AcpiPsParseAml+0xfd/frame 0xffffffff834818d0 > AcpiPsExecuteMethod() at AcpiPsExecuteMethod+0x27d/frame 0xffffffff83481940 > AcpiNsEvaluate() at AcpiNsEvaluate+0x336/frame 0xffffffff834819b0 > AcpiEvaluateObject() at AcpiEvaluateObject+0x223/frame 0xffffffff83481a10 > AcpiEvaluateObjectTyped() at AcpiEvaluateObjectTyped+0xe0/frame 0xffffffff83481aa0 > acpi_EvaluateOSC() at acpi_EvaluateOSC+0xef/frame 0xffffffff83481b90 > acpi_cpu_attach() at acpi_cpu_attach+0x432/frame 0xffffffff83481cb0 > DEVICE_ATTACH() at DEVICE_ATTACH+0x87/frame 0xffffffff83481cf0 > device_attach() at device_attach+0xb9/frame 0xffffffff83481d80 > device_probe_and_attach() at device_probe_and_attach+0x106/frame 0xffffffff83481dc0 > bus_generic_attach() at bus_generic_attach+0x2c/frame 0xffffffff83481df0 > acpi_probe_children() at acpi_probe_children+0x77/frame 0xffffffff83481e30 > acpi_attach() at acpi_attach+0xbfe/frame 0xffffffff83482050 > DEVICE_ATTACH() at DEVICE_ATTACH+0x87/frame 0xffffffff83482090 > device_attach() at device_attach+0xb9/frame 0xffffffff83482120 > device_probe_and_attach() at device_probe_and_attach+0x106/frame 0xffffffff83482160 > bus_generic_attach() at bus_generic_attach+0x2c/frame 0xffffffff83482190 > nexus_acpi_attach() at nexus_acpi_attach+0x59/frame 0xffffffff834821b0 > DEVICE_ATTACH() at DEVICE_ATTACH+0x87/frame 0xffffffff834821f0 > device_attach() at device_attach+0xb9/frame 0xffffffff83482280 > device_probe_and_attach() at device_probe_and_attach+0x106/frame 0xffffffff834822c0 > bus_generic_new_pass() at bus_generic_new_pass+0xb5/frame 0xffffffff83482300 > BUS_NEW_PASS() at BUS_NEW_PASS+0x87/frame 0xffffffff83482340 > bus_set_pass() at bus_set_pass+0x8f/frame 0xffffffff83482360 > root_bus_configure() at root_bus_configure+0xe/frame 0xffffffff83482370 > configure() at configure+0x11/frame 0xffffffff83482390 > mi_startup() at mi_startup+0x2dc/frame 0xffffffff834823f0 > btext() at btext+0x2c > ACPI Error: AE_ALREADY_ACQUIRED, During WalkNamespace (20190703/nsinit-232) The illegal mutex recursion ends up leaking a lock, which later on causes a boot deadlock due to accesses to ACPI hanging forever. 2) This patch works around the issue. > diff --git a/sys/contrib/dev/acpica/components/utilities/utmutex.c b/sys/contrib/dev/acpica/components/utilities/utmutex.c > index 4853bf5c3a6..33a67a731c6 100644 > --- a/sys/contrib/dev/acpica/components/utilities/utmutex.c > +++ b/sys/contrib/dev/acpica/components/utilities/utmutex.c > @@ -378,6 +378,16 @@ AcpiUtAcquireMutex ( > > ThisThreadId = AcpiOsGetThreadId (); > > + if (AcpiGbl_MutexInfo[MutexId].ThreadId == ThisThreadId) > + { > + ACPI_ERROR ((AE_INFO, > + "Mutex [%s] already acquired by this thread [%u]", > + AcpiUtGetMutexName (MutexId), > + (UINT32) ThisThreadId)); > + > + return (AE_ALREADY_ACQUIRED); > + } > + > #ifdef ACPI_MUTEX_DEBUG > { > UINT32 --HPS On 2019-08-01 15:58, Scott Long wrote: > I’m 99% sure that the boot breakage is due to this commit: > > Author: jkim > Date: Tue Jul 9 18:02:36 2019 > New Revision: 349863 > URL: https://svnweb.freebsd.org/changeset/base/349863 > > Log: > MFV: r349861 > > Import ACPICA 20190703. > > I have two systems now that are affected, and both of them > are “fixed” by reverting this. I don’t know the root cause yet, > see my email to the svn-src-all mailing list. > From owner-freebsd-current@freebsd.org Tue Aug 13 21:07:00 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 95C65BCF6A for ; Tue, 13 Aug 2019 21:07:00 +0000 (UTC) (envelope-from clay.daniels.jr@gmail.com) Received: from mail-vs1-xe44.google.com (mail-vs1-xe44.google.com [IPv6:2607:f8b0:4864:20::e44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 467QJM6P3dz4QXq for ; Tue, 13 Aug 2019 21:06:59 +0000 (UTC) (envelope-from clay.daniels.jr@gmail.com) Received: by mail-vs1-xe44.google.com with SMTP id u3so73115570vsh.6 for ; Tue, 13 Aug 2019 14:06:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Voh9hX4cNhmUJMuJSBTcYD5pCtfvwZzvR055vyXxFnE=; b=jR8izrImLfoVzJnQ9QVuBuYWXWn1ifyTbmq7OHxCjww0Pz7f5ypTam8e5SZwSCR3Wx kBqMubbhi2CnHyrYzskQYGjsWL8Eu+ZJfauNRSMJquel6qFtAxF8isifGL53rws81vhg H1DHZgiqdLELQXv5cgt0z0dqtsMJGKVynJQtPMZDFYqyYQx+RKsOSHVJR1qpimWaePCJ 2o+n0gIJ9lsOxXkRfPS7bZ/lfT4HFBGbrQXJlspkZd5HyTHVCoParx96x322Qw8qji5w 4ZOKkx7jTLqAy98YAF+eMGjqjrAFeuMpvoTOM+Yvf9mcgPR7Hx/cmPK7ACoTXXxSV3HL mSZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Voh9hX4cNhmUJMuJSBTcYD5pCtfvwZzvR055vyXxFnE=; b=JnCUcPRaPQcWPphNq+2YViWOOQCyuYjltA86ykba98/MRk8jAbP0Zid3PiPSojPHbY eqxHC8Lj1Dag7wpIsiqO4Wp7eVF7T8702F9cJd89Zyr2D0Z7BLGCq/hAsbbWc2heIoQc m8VTF3FdoEvnoLE/p1Sb/qITG4L+KGahSKjiyi+Fio+aqQ76H0uRzmNN9DDgwXvbmVyl xa9ucxe/teJkTySBUR0j0YQM5+pWDmlTvTMZjOn0Gs6houtH5QI/JepbxeIA6Y6ewCSv EgxMetMIsxu0jk36jt555yQs4rUZEZktG3Be3tOWxdh8vpIz3WqerAUHPQuNlgIJi/Kg sFdg== X-Gm-Message-State: APjAAAUOWIVLe9PpH4G/18pexm0eNS91xJhlCupUwKfDygnvuQKc4Dbw bo7XLXC7LMVCvCXyU9EpO6sbiSswohCA+xMyCNquqb0= X-Google-Smtp-Source: APXvYqzF90ompa0nw1b0YpGd08vjfLEL7n7Ok5rM/asq9htAC1vIyqLBny3tnIP8SOosY74SAlqcnsjrRjYzR5TsxPQ= X-Received: by 2002:a67:e244:: with SMTP id w4mr28017237vse.176.1565730417854; Tue, 13 Aug 2019 14:06:57 -0700 (PDT) MIME-Version: 1.0 References: <8b73d162-e293-2ead-b6b0-b79325b24346@nomadlogic.org> In-Reply-To: <8b73d162-e293-2ead-b6b0-b79325b24346@nomadlogic.org> From: "Clay Daniels Jr." Date: Tue, 13 Aug 2019 16:06:44 -0500 Message-ID: Subject: Re: 13.0 Current - r350702 exposed a Xorg failure To: Pete Wright Cc: "freebsd-current@freebsd.org" X-Rspamd-Queue-Id: 467QJM6P3dz4QXq X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=jR8izrIm; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of claydanielsjr@gmail.com designates 2607:f8b0:4864:20::e44 as permitted sender) smtp.mailfrom=claydanielsjr@gmail.com X-Spamd-Result: default: False [-3.99 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.99)[-0.994,0]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (1.74), ipnet: 2607:f8b0::/32(-2.97), asn: 15169(-2.39), country: US(-0.05)]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[4.4.e.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Aug 2019 21:07:00 -0000 Thanks Pete, I did have the user in the video group, but I need to look into the permissions issue. I have tried to install Xorg several times since last Friday, including reverting to last weeks current, and never had any luck. Right now the FreeBSD partition is wiped clean. The new snapshot will be out day after tomorrow, but I may have time to try again before that. I certainly will let you know when I get this solved. It may be I would have better luck if I compiled the Xorg ports rather than just installing the binaries. But thanks for the advice. It cheers me up. Clay On Mon, Aug 12, 2019 at 9:49 PM Pete Wright wrote: > > > On 8/9/19 8:56 PM, Clay Daniels Jr. wrote: > > I was eager to load the new 13.0 Current snapshot yesterday as I wanted > to > > play with the new FUSE tools. I was running 13.0 Current r350491 from > last > > week and everything was going great. So last night, a little late I > guess, > > I wiped the older install and loaded r250702. Then I loaded Xorg, all 172 > > packages, and loaded the drm-kmod video driver kernel modules, and then > ran > > startx (as user of course). I got errors & it was late so today I looked > > closer. It said: > > "xauth: file .serverauth.1039 does not exist" > > > > Well, this file is apparently something created automatically. I played > > with the half-running install for a long time. It ran fine in console > mode. > > Then I the wiped it and reloaded the same newer r350702. No Go. > > > > Wiped the new r350702 and reloaded the older r350491 that was working > just > > fine last night. Same Problem....serverauth.xxx > > > > Now, I do know that the drm-kmod was the same (g20190710) that had worked > > for me at least two times already. I do not know if the Xorg pkg is the > > same. I couldn't find a date other than "latest". I'm writing this email > > from my Linux partition. > first thing that comes to mind, did you make sure to add your user to > the "video" group? this doesn't sound related though...this does sound > like a local configuration issue. iirc when i ran into this problem in > the past it was due to permissions, either a .serverauth file owned by > root or a UID that no longer exists. > > -p > > -- > Pete Wright > pete@nomadlogic.org > @nomadlogicLA > > From owner-freebsd-current@freebsd.org Tue Aug 13 21:58:28 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EF835BE785 for ; Tue, 13 Aug 2019 21:58:28 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 467RRm68qGz4TDp for ; Tue, 13 Aug 2019 21:58:28 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id D344CBE783; Tue, 13 Aug 2019 21:58:28 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D2FEFBE782; Tue, 13 Aug 2019 21:58:28 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 467RRm5HvYz4TDn; Tue, 13 Aug 2019 21:58:28 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-4.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 179BE110DF; Tue, 13 Aug 2019 21:58:27 +0000 (UTC) (envelope-from jhb@FreeBSD.org) To: current@FreeBSD.org Cc: x11@FreeBSD.org From: John Baldwin Subject: HEADSUP: drm-current-kmod now installs sources Openpgp: preference=signencrypt Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> Date: Tue, 13 Aug 2019 14:58:23 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Aug 2019 21:58:29 -0000 With help from zeising@ in particular, I've just committed a change to the drm-current-kmod port that makes it install sources into /usr/local/sys/modules by default. This will result in some behavior changes on HEAD (and only head for now): 1) When you build a kernel after installing the updated package, your buildkernel will now build DRM modules using the sources from the package. For developers at least I suspect this to be a win as if you have made changes to the kernel KBI you will always end up with matching modules installed into /boot/kernel alongside your kernel. 2) In order to use these modules, you need to update the 'kld_list' lines in your rc.conf to just list the modules without a path, e.g. "kld_list=i915kms" just as you would for other modules. This will prefer the module built with your kernel if one exists and fall back to the module in /boot/modules otherwise. If a change in current breaks the build of DRM modules, you have a couple of options: 1) Pass 'LOCAL_MODULES=' (empty string) on the command line of 'make buildkernel' to disable building the DRM modules. 2) Hack on the sources in /usr/local/sys/modules/drm-current-kmod to fix the compile breakage, perhaps using a patch from the mailing lists if one exists. 3) Wait for a new package/port version and update to that before doing a buildkernel. For developers this means even if you are doing testing on a box that doesn't use DRM, you can install the package so that kernel builds will try to compile it and hopefully spot KPI/KBI changes before they land in the tree so that the port/package can be patched in tandem with committing changes to HEAD. Note that even builds of work trees in git checkouts, etc. will find the DRM modules and try to build them if the package is installed. -- John Baldwin From owner-freebsd-current@freebsd.org Tue Aug 13 22:17:40 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 373E8BF069 for ; Tue, 13 Aug 2019 22:17:40 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 467Rsw0kRJz4VCy for ; Tue, 13 Aug 2019 22:17:40 +0000 (UTC) (envelope-from ian@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 16D76BF066; Tue, 13 Aug 2019 22:17:40 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 16999BF065 for ; Tue, 13 Aug 2019 22:17:40 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 467Rsv4x52z4VCx for ; Tue, 13 Aug 2019 22:17:39 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1565734658; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=l1yrGXrxQxxi8eRlhYit8LaRN74NUzmJNuTptkTFkvb4yC7EZFps6KjyHKOiYPIFfxy2bs/W8undm RzspFQGvyAi/OB4QLbIeUucbPb2yyEZYGyOpHDC5fO2WvJx/kttItvDZVsNMUOFK/ioH+D1O2EO2eu s58mvKaVOSnGuahHxQC/562Qw/CfwJXoyn/4UzT9S/lgrhTJchufSDP2zDbb6ERO6/dr/txRLzI4mw kbwu/VWQslDtWL+JiL1f7fPv2IH97VLOXaYdBYYNpCJOki3BAbCmyRm5YC6mYWl4Usi778nS5R0aBv T8TPQ7Q06ObY39wP/H0SewCegMQjOkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=WE4g9FeoeT+pc2LeGwpHwqIKb3mY8sNaO0IdMhzo+iQ=; b=XkEJRQMUBkmO6q37gVISOs7U+zIiFmcrxB7TyOqPY2+uzCxLQO2ddTFl/LiHHE23tVrLetaSAZEQ8 HXm1+xqHIZquOf7pdMol66wAohO/x02HTfdE2EcLf5UcAqxgD41/HSBSb0ITCI8V+ehLR2td4K21wG CyexzYxEMaUaIR1PECCsynin9PaKilr3kZYaArptGgAH27itinv48zCx5It7qvxc9XvtutS5G04dyt JgKvIC7I2FOysPidgsrL5iFZ7eV3jfv9/p1Ht6914DsDcnUrV4kGscHanJZlKm/lFpTrUh+2DK9rl7 7lfVLQnKUZSO17lUCBv4wJPV1vwgOKg== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=WE4g9FeoeT+pc2LeGwpHwqIKb3mY8sNaO0IdMhzo+iQ=; b=ltwPpaxVE9by7gFXkyKcnwlE6+GHSGLxoS1U4hnjddB+xTwvvO+YZYYwkQrpt23LfN0PH4+trDPWQ B4EASOKWhs0mkd2GV897KCT5ayZbzJtn95hZX58GesnwDMgbFo9+BgO1HjteQFGnEhuZ7ccycSw4hn l/GsZwBWLi4fzRRB4ZgSfx9eYWPtaejXBz7n/t/u97Mk/nLGf/NXEQ4KFDKXeQYpY8v8fHy3Cr5U4L FkMHrKCs+XYoQaHZZSybh3vuHMtWx4bCt3u4MRlF+8pG6HCvbZxZJb8YF30xRI3orP0E4T+I1N9bYD I+gEFc3KEAIbqqoonHQNgPWfcaLW4yQ== X-MHO-RoutePath: aGlwcGll X-MHO-User: 2770e436-be18-11e9-b67b-cdd75d6ce7a8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id 2770e436-be18-11e9-b67b-cdd75d6ce7a8; Tue, 13 Aug 2019 22:17:37 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x7DMHZfp051237; Tue, 13 Aug 2019 16:17:35 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: HEADSUP: drm-current-kmod now installs sources From: Ian Lepore To: John Baldwin , current@FreeBSD.org Cc: x11@FreeBSD.org Date: Tue, 13 Aug 2019 16:17:35 -0600 In-Reply-To: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 467Rsv4x52z4VCx X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.983,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Aug 2019 22:17:40 -0000 On Tue, 2019-08-13 at 14:58 -0700, John Baldwin wrote: > For developers this means even if you are doing testing on a box > that doesn't use DRM, you can install the package so that kernel > builds will try to compile it and hopefully spot KPI/KBI changes > before they land in the tree so that the port/package can be > patched in tandem with committing changes to HEAD. Note that even > builds of work trees in git checkouts, etc. will find the DRM > modules and try to build them if the package is installed. That last sentence sounds ominous. Are you saying that when I'm on my amd64 machine building from /my/sources/rpi using TARGET_ARCH=armv6 it's going to find /usr/local/sys/modules/drm-current-kmod and try to crossbuild it for armv6? How about when I'm doing a build of 11-stable for testing, but what's in my /usr/local is sources for a 13-current driver? -- Ian From owner-freebsd-current@freebsd.org Tue Aug 13 22:35:34 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 69480BF8C0 for ; Tue, 13 Aug 2019 22:35:34 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 467SGY73V8z4WJj for ; Tue, 13 Aug 2019 22:35:33 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id F081EBF8BC; Tue, 13 Aug 2019 22:35:33 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EF181BF8BA; Tue, 13 Aug 2019 22:35:33 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 467SGY5mkqz4WJh; Tue, 13 Aug 2019 22:35:33 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-ot1-f41.google.com with SMTP id k18so45769275otr.3; Tue, 13 Aug 2019 15:35:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=PxIY+qTSX+giCGO8xjpDCv0tnL1S0tTkUQ9UCS4XWtE=; b=Bqa9cbgEPArAvEIp517yqHcPXfJloBnUsfw2mkjZF9bdjmt9Ma8KrV0greBeH7iO+c v3kIz8eQkFrjRlh3RifkR6vn1CryrjfmmEn4c99Xqf+8aEE2uQXvz5ZSS13M1NDatMvv jSwx86uncAipWC3Tv0Y7BkmKg5I0CDfHY8xDqjT/DrVPZLaQEIf97/vmcM/EpvM8A51d 1cn8wzDPOPyfq141WwAQ7pXxWUJDAhqAEqsu10kOAVZRKE2R+q/ZtU78RjEIDF58k/Vd bxRBh/5o4O1GZyCnteIsu1PlKDHBE1ehEIMree6l0+tVrfpmnI+xy9yKXKZ2bpuLF5YA dRZw== X-Gm-Message-State: APjAAAV9uznS0Wq6u5C8U/XdDZmCyjXpbzEpxt7cYCAQNnBAijVo9hXX dGHwXQf0dIAZgwqyh4BPUxnV3BsP X-Google-Smtp-Source: APXvYqzY6S0SXiSeaf8surV/jyYZ6YzwO4h7SlT59N46JN6ghG0vvmmDFB7YAOWjLbHpJZt0Kl9bjg== X-Received: by 2002:a9d:6508:: with SMTP id i8mr31291956otl.355.1565735731851; Tue, 13 Aug 2019 15:35:31 -0700 (PDT) Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com. [209.85.210.54]) by smtp.gmail.com with ESMTPSA id k25sm4535783oig.50.2019.08.13.15.35.31 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 13 Aug 2019 15:35:31 -0700 (PDT) Received: by mail-ot1-f54.google.com with SMTP id g17so26918807otl.2; Tue, 13 Aug 2019 15:35:31 -0700 (PDT) X-Received: by 2002:a5d:85c3:: with SMTP id e3mr41664908ios.265.1565735731224; Tue, 13 Aug 2019 15:35:31 -0700 (PDT) MIME-Version: 1.0 References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> In-Reply-To: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Tue, 13 Aug 2019 15:35:20 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: HEADSUP: drm-current-kmod now installs sources To: John Baldwin Cc: current , x11@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 467SGY5mkqz4WJh X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.980,0]; TAGGED_FROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Aug 2019 22:35:34 -0000 This is super cool, thank you! Is it feasible to integrate other out-of-tree kmods in a similar way, e.g., nvidia-driver? On Tue, Aug 13, 2019 at 2:58 PM John Baldwin wrote: > > With help from zeising@ in particular, I've just committed a change > to the drm-current-kmod port that makes it install sources into > /usr/local/sys/modules by default. This will result in some behavior > changes on HEAD (and only head for now): > > 1) When you build a kernel after installing the updated package, > your buildkernel will now build DRM modules using the sources > from the package. For developers at least I suspect this to be > a win as if you have made changes to the kernel KBI you will > always end up with matching modules installed into /boot/kernel > alongside your kernel. > > 2) In order to use these modules, you need to update the 'kld_list' > lines in your rc.conf to just list the modules without a > path, e.g. "kld_list=i915kms" just as you would for other > modules. This will prefer the module built with your kernel if > one exists and fall back to the module in /boot/modules > otherwise. > > If a change in current breaks the build of DRM modules, you have a > couple of options: > > 1) Pass 'LOCAL_MODULES=' (empty string) on the command line of > 'make buildkernel' to disable building the DRM modules. > > 2) Hack on the sources in /usr/local/sys/modules/drm-current-kmod > to fix the compile breakage, perhaps using a patch from the > mailing lists if one exists. > > 3) Wait for a new package/port version and update to that before > doing a buildkernel. > > For developers this means even if you are doing testing on a box > that doesn't use DRM, you can install the package so that kernel > builds will try to compile it and hopefully spot KPI/KBI changes > before they land in the tree so that the port/package can be > patched in tandem with committing changes to HEAD. Note that even > builds of work trees in git checkouts, etc. will find the DRM > modules and try to build them if the package is installed. > > -- > John Baldwin > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" From owner-freebsd-current@freebsd.org Wed Aug 14 08:09:09 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EF7D9CAA6E for ; Wed, 14 Aug 2019 08:09:09 +0000 (UTC) (envelope-from grahamperrin@gmail.com) Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 467j0P1RVbz3xd5 for ; Wed, 14 Aug 2019 08:09:08 +0000 (UTC) (envelope-from grahamperrin@gmail.com) Received: by mail-wm1-x32b.google.com with SMTP id i63so3606993wmg.4 for ; Wed, 14 Aug 2019 01:09:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=24itqbS9HYgyBQucrO94W/7pxcBL7a2HTJ2qYYawpts=; b=j588S+YjVYTlehyU68Lq+t7cVDl3ig7ib2bjUwL5MLxWVoXsmvNZbaHt5n/DvEOHok 3qco4n75ANW6spTBqzOkUhSi2mk82SuHpyBV6XvY0OWxKa+q61u6T0q95o+VP6PUIRcU IzPDm9t5b+QsTkTJZdN0MP81CeXNnn4d+X7OXlFELMUVNejbs8zrRM7ekBaMaKMAzuFH wTaiwc1I9FWxmpTsGEMl6owDRvLKBcDDD3yap3tvkxXhUACCGxxW4SdfDEJBec0GM68E 86AF1g3wO991Tzr2H/Eo67FCRzOTJZMqt+PVS92R95PJFVUYKtawryHvBgxfBFuKXvRl e48A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=24itqbS9HYgyBQucrO94W/7pxcBL7a2HTJ2qYYawpts=; b=fJuBjfJTLyDiQxNtR7mRKGARnBVbnAulhxmW5A3VySBBZPE9XGNL1uvms4eJSKz/As 5zfQ13bw/8oGarRk2YnkpVTOwa7pDfpAtEuJilNup0/tNS1zmhu6KAd5Xbi1wAJQJXda J+x3YW5y3kWMuLAk8j7zoyWuWEDzIAju1SPLwKo0DGZ5FqeugqxTq51t2cQhXUtT7Qjv +HXREtRKcXuuSNJCfJWb4R0oD0vFMviOrHi6o8H7Va40WiRWq0KR+wi8PdPz8wcLPtOc 1DpaxaY3g9+bGax6EbM/fHULNATEdfBy68bODxlVHLAO9wHCXxyJSPVHLpr0NPoHFkuM p04A== X-Gm-Message-State: APjAAAUlAbN6L04P5kXFr3dGlLk5INVf/XVN2/q9ZPOJr28OsEPbaZN1 MhWiBHAe0EtgixGq3In7SnjTceVQllU= X-Google-Smtp-Source: APXvYqyoXleuZ5599msViUoJjW64l5d/7oJhrUHWIIW5SOkAJG2p2tJznqeqOfvjvLNBEjCYANCF6g== X-Received: by 2002:a05:600c:24d0:: with SMTP id 16mr6799872wmu.83.1565770146148; Wed, 14 Aug 2019 01:09:06 -0700 (PDT) Received: from [192.168.1.7] ([79.66.151.94]) by smtp.gmail.com with ESMTPSA id s64sm7486279wmf.16.2019.08.14.01.09.05 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 14 Aug 2019 01:09:05 -0700 (PDT) Subject: Re: 13.0 Current - r350702 exposed a Xorg failure To: "Clay Daniels Jr." References: Cc: "freebsd-current@freebsd.org" From: Graham Perrin Message-ID: <2972dce1-a7ff-4411-fd82-3336b6c319a2@gmail.com> Date: Wed, 14 Aug 2019 09:09:02 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Rspamd-Queue-Id: 467j0P1RVbz3xd5 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=j588S+Yj; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of grahamperrin@gmail.com designates 2a00:1450:4864:20::32b as permitted sender) smtp.mailfrom=grahamperrin@gmail.com X-Spamd-Result: default: False [-4.00 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-0.996,0]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RECEIVED_SPAMHAUS_PBL(0.00)[94.151.66.79.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[b.2.3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(0.00)[ip: (-9.34), ipnet: 2a00:1450::/32(-3.03), asn: 15169(-2.39), country: US(-0.05)]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 08:09:10 -0000 On 10/08/2019 04:56, Clay Daniels Jr. wrote: > drm-kmod was the same (g20190710) It's equally (if not more) important to consider what's installed by drm-kmod. Can you share output from these three commands? pkg info | grep kmod pciconf -lv | grep -C 3 display grep PORTS_MODULES /etc/make.conf Thanks. Also, FYI (to help understand the purpose of drm-kmod): pkg rquery %e drm-kmod From owner-freebsd-current@freebsd.org Wed Aug 14 08:12:00 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E2F1ACADCC for ; Wed, 14 Aug 2019 08:12:00 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 467j3h0rF7z3xtL; Wed, 14 Aug 2019 08:11:59 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-pf1-f196.google.com with SMTP id g2so53134345pfq.0; Wed, 14 Aug 2019 01:11:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=q8w5TSLccUEw/ER/WXes4RKUfapshyOgydTQSmNcqoo=; b=F8U6/4SgN5bwawqrUWM/BzPytKFgY//U6lM+sBzh5PaOl7FrztxaO88c8dwtJXqWst qnhLOs4ZZN7z7DbTy9ogk9zAGIZcLJvbrSsn579RCToWhQBUN9jF+bG7hRIZX7UImzU8 Y6NK/AKdt2lC/fv0owem/Ak0PKmAHA9JEbfwU1r1XmQm0jotAIwpWtUe0cQJq6CIe/kj om1Xhzw0Gt49ilNlG/sF+DhKh6suhTivwpcO4nFBg8YDkD+Mt6P44iHFFFJVT/dArYVP YU6+wjTNU2VYYgen3V5V7Xl++Mx2rBCs3+YTit7aEJ4bxNEyuGGDb5d53N9Fmv6NJQOc KslQ== X-Gm-Message-State: APjAAAW0DuFXIK6dtGC7AtA7t/LYiIsL1azkAsbu5p3Cx+2aNrP5MSOE Z+rw8/b5vlDdUIb5cQL2umDWoJ2qunc= X-Google-Smtp-Source: APXvYqw98WRxZkjewtlJCyUEVLDjVKKE7OS8B28T1g2VbuUC1yIyYbTorFy6mrK2boyWrEPnLNx1Wg== X-Received: by 2002:a62:8648:: with SMTP id x69mr17452359pfd.92.1565770317858; Wed, 14 Aug 2019 01:11:57 -0700 (PDT) Received: from [192.168.1.36] (broadband-82-140-193-12.atc.tvcom.ru. [82.140.193.12]) by smtp.googlemail.com with ESMTPSA id c13sm11526360pfi.17.2019.08.14.01.11.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Aug 2019 01:11:56 -0700 (PDT) Subject: Re: Boot still broken from r349133-r349160 - Was re:(Problem with USB after r349133) To: Hans Petter Selasky , Scott Long , Nick Wolff Cc: "Clay Daniels Jr." , "Rodney W. Grimes" , lausts@acm.org, freebsd-current@freebsd.org, Jung-uk Kim References: <201907300011.x6U0BO8w046636@gndrsh.dnsmgr.net> <98c2c54e-6d77-4cca-78d5-fcffeb65b80c@selasky.org> From: Andriy Gapon Message-ID: Date: Wed, 14 Aug 2019 11:11:53 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <98c2c54e-6d77-4cca-78d5-fcffeb65b80c@selasky.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 467j3h0rF7z3xtL X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of agapon@gmail.com designates 209.85.210.196 as permitted sender) smtp.mailfrom=agapon@gmail.com X-Spamd-Result: default: False [-2.65 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; RWL_MAILSPIKE_GOOD(0.00)[196.210.85.209.rep.mailspike.net : 127.0.0.18]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_HAM_SHORT(-0.98)[-0.984,0]; RCPT_COUNT_SEVEN(0.00)[8]; FORGED_SENDER(0.30)[avg@FreeBSD.org,agapon@gmail.com]; RECEIVED_SPAMHAUS_PBL(0.00)[12.193.140.82.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[avg@FreeBSD.org,agapon@gmail.com]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[196.210.85.209.list.dnswl.org : 127.0.5.0]; IP_SCORE(-1.16)[ipnet: 209.85.128.0/17(-3.37), asn: 15169(-2.39), country: US(-0.05)]; FREEMAIL_CC(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 08:12:00 -0000 On 13/08/2019 16:31, Hans Petter Selasky wrote: > 1) AcpiUtAcquireMutex() doesn't support recursion, but also fails to > report an error when such a condition is occurring. Here is the > backtrace of the illegal mutex recursion. I have an old patch that replaces hand-rolled ACPI platform primitives with thin wrappers around the standard kernel primitives. It covers locks and memory allocation. I don't recall what objections there were when I originally proposed that change. I still think that it is a good idea. The kernel code has quite a bit more testing and tooling around it than the ACPI-only things. -- Andriy Gapon From owner-freebsd-current@freebsd.org Wed Aug 14 10:06:07 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ED25DCDF2C for ; Wed, 14 Aug 2019 10:06:07 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 467lbM605Jz46Vl for ; Wed, 14 Aug 2019 10:06:07 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id CD88DCDF29; Wed, 14 Aug 2019 10:06:07 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CD400CDF28; Wed, 14 Aug 2019 10:06:07 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [176.58.89.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 467lbM50J0z46Vk; Wed, 14 Aug 2019 10:06:07 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 467lb52jtVz3l2S; Wed, 14 Aug 2019 10:05:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([127.0.0.1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [127.0.0.1]) (amavisd-new, port 10587) with ESMTPS id tbppElEBqUm2; Wed, 14 Aug 2019 10:05:53 +0000 (UTC) Received: from garnet.daemonic.se (unknown [IPv6:2001:470:dca9:201:99b8:b5f9:82da:aca0]) by mail.daemonic.se (Postfix) with ESMTPSA id 467lb460kvz3c7W; Wed, 14 Aug 2019 10:05:52 +0000 (UTC) Subject: Re: HEADSUP: drm-current-kmod now installs sources To: cem@freebsd.org, John Baldwin Cc: x11@freebsd.org, current References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> From: Niclas Zeising Message-ID: <70334396-f921-d2ba-9ea7-9b4ee786d3e8@freebsd.org> Date: Wed, 14 Aug 2019 12:05:39 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 467lbM50J0z46Vk X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.94)[-0.937,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 10:06:08 -0000 On 2019-08-14 00:35, Conrad Meyer wrote: > This is super cool, thank you! Is it feasible to integrate other > out-of-tree kmods in a similar way, e.g., nvidia-driver? > It should be possible to expand this to work with other ports that install kmods. I think the plan is to have drm-current-kmod work like this for a while, to shake out any bugs or other unexpected issues, and then look into converting more kmod ports. Regards -- Niclas Zeising From owner-freebsd-current@freebsd.org Wed Aug 14 16:08:54 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E1E3EB0986 for ; Wed, 14 Aug 2019 16:08:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 467vdy5jFdz4V8h for ; Wed, 14 Aug 2019 16:08:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id C1E45B0983; Wed, 14 Aug 2019 16:08:54 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C0665B0982; Wed, 14 Aug 2019 16:08:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 467vdy4SrJz4V8g; Wed, 14 Aug 2019 16:08:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-4.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 2917D1918D; Wed, 14 Aug 2019 16:08:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: HEADSUP: drm-current-kmod now installs sources To: Ian Lepore , current@FreeBSD.org Cc: x11@FreeBSD.org References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> From: John Baldwin Openpgp: preference=signencrypt Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: Date: Wed, 14 Aug 2019 09:08:51 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 16:08:54 -0000 On 8/13/19 3:17 PM, Ian Lepore wrote: > On Tue, 2019-08-13 at 14:58 -0700, John Baldwin wrote: >> For developers this means even if you are doing testing on a box >> that doesn't use DRM, you can install the package so that kernel >> builds will try to compile it and hopefully spot KPI/KBI changes >> before they land in the tree so that the port/package can be >> patched in tandem with committing changes to HEAD. Note that even >> builds of work trees in git checkouts, etc. will find the DRM >> modules and try to build them if the package is installed. > > That last sentence sounds ominous. Are you saying that when I'm on my > amd64 machine building from /my/sources/rpi using TARGET_ARCH=armv6 > it's going to find /usr/local/sys/modules/drm-current-kmod and try to > crossbuild it for armv6? Yes, meaning that you _can_ cross-build a DRM kernel module. This also means that if you are trying out a KPI change and have the package installed, make tinderbox will now catch a change that breaks the DRM drivers on only a subset of platforms (e.g. a powerpc or arm-only breakage that currently goes unnoticed when a developer is only doing build testing from an amd64 host). There are several ways you can disable this either globally or in more fine-grained ways: 1) You can set LOCALBASE to a different path either in a kernel config (via makeoptions) or when invoking buildkernel. For example, I mount my rpi's sdcard at /mnt on my amd64 laptop and then cross-build into it, so I could set LOCALBASE to /mnt/usr/local when building the rpi's kernel to honor any kmod packages installed on the rpi. 2) You can set LOCAL_MODULES (makeoptions, command line) to a list of modules to build (empty disables building any of them). 3) You could set LOCAL_MODULES in /etc/src.conf to affect all kernel builds. (You probably don't want to set LOCALBASE there as it probably affects other things.) 4) You can build the port with the SOURCES option disabled if you want to never build modules for a specific port. > How about when I'm doing a build of 11-stable for testing, but what's > in my /usr/local is sources for a 13-current driver? Given that the kmod's are supposed to be portable across branches, the build really shouldn't be breaking. But the same ability is still there to as above to disable builds either in general or for specific kernel configs or buildkernel invocations. -- John Baldwin From owner-freebsd-current@freebsd.org Wed Aug 14 16:22:22 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1DD97B1156 for ; Wed, 14 Aug 2019 16:22:22 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 467vxV01x0z4W46 for ; Wed, 14 Aug 2019 16:22:22 +0000 (UTC) (envelope-from ian@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id F1912B1152; Wed, 14 Aug 2019 16:22:21 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F1410B114E for ; Wed, 14 Aug 2019 16:22:21 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 467vxT49xwz4W40 for ; Wed, 14 Aug 2019 16:22:21 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1565799740; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=A+uncAbq4VO1uHIK0+kuZcCWkRElii1nLIGezQdL7FVCvgs3q+RPL9RhhUm/Zxj+c/gKCU5+b+eNB YYQo3PINiqcQytHENof72X+fXypenODB4hFf0CLhnlVIpdtsK2GXjJ0kxZJOtl3Ga8vX3zOw5wa7Mj BjV7pKUVUdbCy9mcZobTYCwFdwxxRYGaNOnRxDeX3SWjJfRNAtYGEQ5kY1xLBzP1xjaEB7+Jmww5p2 P92rdWTTSrdyjnB8h76fBm45Jmwpbs8a8KPAKb6qzMbdDktjpqWhV/wL+sN1a23tR7HXlZ8S2kTjmr 4Uyy1hUwhcAgTB2zmKwkSxe0trMX2bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=SeipzOWiKp+QUpvf1Y+5wmnqjg681LJPBLqcfKi+OUQ=; b=gI7mDBdLKjKgCdX5Vh16B91KCNTT8atSCUt3U9MRPaqn4rKjGxqGQelpjf5me2dxn/TjOo7eOoWHf B1eZy1jAlLzD8USsjDDeW16w76QgXybwKMJEMNbAZ6VJY6GsCaLBJVE6D7TORRzlxSHCzD+Q6HU6PA apumJ8SGvCC7uTmXle7iKwCOd0EluVsBI/Y19aCq4HAwV16L9LQ3CYnXGstZA4/JkbMcz02YDkjAVf mC4xMCsl14plukzMJ1Wd3qp4vyaw6Nj5CfXCpSjiD5Gu22ZVeC+bgwvR1gL8Q5oj+CB7BCiE3PcuGG mCqrSx/ss58YiIGqIArb4hEH2/PuEgQ== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=SeipzOWiKp+QUpvf1Y+5wmnqjg681LJPBLqcfKi+OUQ=; b=jZs1RcbYSDRxEByZ8SYvKL3AEzg1y/Ch6cY6qiF/GvCtPHyqLdAtUUakXqIRU8t+ThuagRKa7nLAs rw+RtY1tWDoK7ZESnbqrUs1BcL2bbe3opZ3eyS+9LNKxcwp5B0KFppjRhnjF81f9SIcqP2Au8imLZU jxsm0+oFk7NrhxT5xkQgg2kOCeAnr2rXSP0HLUOeK95jiRXKKJIs57NsN2DpX7zfXPPuKkw36RW5V9 i0g2dmW+NylbchAIU/xtc7QOsPeCJtWLfn9LcgfQi32bCg+qf/ae0jbAf6yih216SwRCo7Wmpv8S7v efRM1W5d7i1KeWN28kDwfg+5sirAGPQ== X-MHO-RoutePath: aGlwcGll X-MHO-User: aee05a76-beaf-11e9-b67b-cdd75d6ce7a8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id aee05a76-beaf-11e9-b67b-cdd75d6ce7a8; Wed, 14 Aug 2019 16:22:18 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x7EGMHsK055037; Wed, 14 Aug 2019 10:22:17 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> Subject: Re: HEADSUP: drm-current-kmod now installs sources From: Ian Lepore To: John Baldwin , current@FreeBSD.org Cc: x11@FreeBSD.org Date: Wed, 14 Aug 2019 10:22:17 -0600 In-Reply-To: References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 467vxT49xwz4W40 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 16:22:22 -0000 On Wed, 2019-08-14 at 09:08 -0700, John Baldwin wrote: > On 8/13/19 3:17 PM, Ian Lepore wrote: > > On Tue, 2019-08-13 at 14:58 -0700, John Baldwin wrote: > > > For developers this means even if you are doing testing on a box > > > that doesn't use DRM, you can install the package so that kernel > > > builds will try to compile it and hopefully spot KPI/KBI changes > > > before they land in the tree so that the port/package can be > > > patched in tandem with committing changes to HEAD. Note that > > > even > > > builds of work trees in git checkouts, etc. will find the DRM > > > modules and try to build them if the package is installed. > > > > That last sentence sounds ominous. Are you saying that when I'm on > > my > > amd64 machine building from /my/sources/rpi using TARGET_ARCH=armv6 > > it's going to find /usr/local/sys/modules/drm-current-kmod and try > > to > > crossbuild it for armv6? > > Yes, meaning that you _can_ cross-build a DRM kernel module. This > also means > that if you are trying out a KPI change and have the package > installed, make > tinderbox will now catch a change that breaks the DRM drivers on only > a subset > of platforms (e.g. a powerpc or arm-only breakage that currently goes > unnoticed when a developer is only doing build testing from an amd64 > host). > > There are several ways you can disable this either globally or in > more > fine-grained ways: > > 1) You can set LOCALBASE to a different path either in a kernel > config > (via makeoptions) or when invoking buildkernel. > > For example, I mount my rpi's sdcard at /mnt on my amd64 laptop > and > then cross-build into it, so I could set LOCALBASE to > /mnt/usr/local when > building the rpi's kernel to honor any kmod packages installed on > the rpi. > > 2) You can set LOCAL_MODULES (makeoptions, command line) to a list of > modules > to build (empty disables building any of them). > > 3) You could set LOCAL_MODULES in /etc/src.conf to affect all kernel > builds. > (You probably don't want to set LOCALBASE there as it probably > affects > other things.) > > 4) You can build the port with the SOURCES option disabled if you > want to > never build modules for a specific port. > > > How about when I'm doing a build of 11-stable for testing, but > > what's > > in my /usr/local is sources for a 13-current driver? > > Given that the kmod's are supposed to be portable across branches, > the build really shouldn't be breaking. But the same ability is > still > there to as above to disable builds either in general or for > specific kernel configs or buildkernel invocations. > This all sounds vaguely wrong, backwards, to me. A developer who is using a given module on their build system might want that module to be rebuilt automatically, but only if the build parameters match those of the running build host system. If my build host is running freebsd 12 amd64 and I'm doing a build for freebsd 13 armv7, I have no interest in automatic rebuilds of an amd64 driver module for a different OS arch and version just because that module happens to be installed on the system I use to do crossbuilds. My objections are theoretical... this automation just seems improperly designed to me. But it won't actually affect me in any way, because I don't build video driver modules from ports, and I don't run freebsd current on my build host machine. Probably the number of people doing crossbuilding is small enough that nobody else is going to object to this "the whole world is amd64" automation. -- Ian From owner-freebsd-current@freebsd.org Wed Aug 14 17:13:51 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 85C5DB2D57 for ; Wed, 14 Aug 2019 17:13:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 467x4v308hz4bTn for ; Wed, 14 Aug 2019 17:13:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id 664B1B2D55; Wed, 14 Aug 2019 17:13:51 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 65FD9B2D54; Wed, 14 Aug 2019 17:13:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 467x4v25Z7z4bTk; Wed, 14 Aug 2019 17:13:51 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-4.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id A3834199C7; Wed, 14 Aug 2019 17:13:50 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: HEADSUP: drm-current-kmod now installs sources To: Ian Lepore , current@FreeBSD.org Cc: x11@FreeBSD.org References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> From: John Baldwin Openpgp: preference=signencrypt Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: Date: Wed, 14 Aug 2019 10:13:48 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 17:13:51 -0000 On 8/14/19 9:22 AM, Ian Lepore wrote: > This all sounds vaguely wrong, backwards, to me. A developer who is > using a given module on their build system might want that module to be > rebuilt automatically, but only if the build parameters match those of > the running build host system. > > If my build host is running freebsd 12 amd64 and I'm doing a build for > freebsd 13 armv7, I have no interest in automatic rebuilds of an amd64 > driver module for a different OS arch and version just because that > module happens to be installed on the system I use to do crossbuilds. > > My objections are theoretical... this automation just seems improperly > designed to me. But it won't actually affect me in any way, because I > don't build video driver modules from ports, and I don't run freebsd > current on my build host machine. Probably the number of people doing > crossbuilding is small enough that nobody else is going to object to > this "the whole world is amd64" automation. You assume DRM is amd64-only when it is definitely not. It also has suitable guards in its Makefile to only build the relevant kernel modules on supported architectures. -- John Baldwin From owner-freebsd-current@freebsd.org Wed Aug 14 17:16:12 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 52F5EB2F8F for ; Wed, 14 Aug 2019 17:16:12 +0000 (UTC) (envelope-from theron.tarigo@gmail.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 467x7c0flPz4bp2 for ; Wed, 14 Aug 2019 17:16:12 +0000 (UTC) (envelope-from theron.tarigo@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id 13123B2F8B; Wed, 14 Aug 2019 17:16:12 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 12BD6B2F89; Wed, 14 Aug 2019 17:16:12 +0000 (UTC) (envelope-from theron.tarigo@gmail.com) Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 467x7b40Lcz4bny; Wed, 14 Aug 2019 17:16:11 +0000 (UTC) (envelope-from theron.tarigo@gmail.com) Received: by mail-pf1-x443.google.com with SMTP id d85so3462565pfd.2; Wed, 14 Aug 2019 10:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=VgDH7SNtfTkRPWWZOMN8ggGsplNmarYIsV+y9JplNsA=; b=LfE7qlmZ0Lsys4koCKsPT6aTo22zDsJ4ReF9HfxhTqwLYfa2K0WH5W0/kfYCmO6am7 IgvzRh4rymWErm6nNXLnt2IQNBz6aQTmS6W6Tv+h9jroeKcb2MveCcwILwLIEuR3cjqT Ddf8zGLPdjVfp0FxtTpZXeRoyZyI9U/1xTGOad/H4AWt7ucrbCq9G9SlNb0+ndvUQaEn ogkPlDkjlCkL0c372guIFTwYtwogrv9grcNGQv/eQIJdwlng/VFexvbZW9Pd1FgEUxKf vi32XiW4TwzYcDnrrRHwqvzscGbUuPy1uiuxxb8FUDKSBVNhRnj5fK5gEjbRK5eHmvfH aB2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=VgDH7SNtfTkRPWWZOMN8ggGsplNmarYIsV+y9JplNsA=; b=LEu0JUgQAmWUuUJKUaB57HjVV6c8VBJNiuENLpZxUHDTjyxylZFkZU8+PVH3FWiTCu 0nfT/him3OdkLrspumFl/FIxIGPoOiJczc5fECySyROp8aMQDDg3dJ3mn9irrGHfLGqD LoGqymmbG2weh/WW+dqJ2anDUelKzGpdKjhl8J/M8T8TuLDkjUMx1Gx47kXE+IqetM/u QQOlHxpNOMo1bIg6rLfyjyEQTzA2A5ht6jG9nP/iXe/pGWFVZ0EjmLrgRvxmN/rqthu+ hD6JJmUkm0sVbcGgoW3wyFVTNTsrS/86rmy6C8aJicIJw/0RKPBeeZ5pZ3XCinyRTurZ uyRQ== X-Gm-Message-State: APjAAAUEFpk0K8tmmjN4YxqkXekpUl/wUb3Xeuz56IqSoEZJVgFYF8/t DCl0lrIQXEHSp+nox52EOr4g+gxjzRM= X-Google-Smtp-Source: APXvYqwMH9ycKGklUB/cKkFcl3WL65eP6z5S+QpxptK4TVcchcjz+ChF7HLegjithQ69jm4CKVxnMw== X-Received: by 2002:a63:4562:: with SMTP id u34mr222227pgk.288.1565802969651; Wed, 14 Aug 2019 10:16:09 -0700 (PDT) Received: from [192.168.1.23] (c-73-170-47-221.hsd1.ca.comcast.net. [73.170.47.221]) by smtp.gmail.com with ESMTPSA id x17sm395190pff.62.2019.08.14.10.16.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Aug 2019 10:16:08 -0700 (PDT) Sender: Theron Tarigo Subject: Re: HEADSUP: drm-current-kmod now installs sources To: John Baldwin , Ian Lepore , current@FreeBSD.org Cc: x11@FreeBSD.org References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> From: Theron Message-ID: Date: Wed, 14 Aug 2019 10:16:07 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 467x7b40Lcz4bny X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=LfE7qlmZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of therontarigo@gmail.com designates 2607:f8b0:4864:20::443 as permitted sender) smtp.mailfrom=therontarigo@gmail.com X-Spamd-Result: default: False [-3.98 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; RECEIVED_SPAMHAUS_PBL(0.00)[221.47.170.73.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; IP_SCORE(0.00)[ip: (-0.37), ipnet: 2607:f8b0::/32(-2.98), asn: 15169(-2.39), country: US(-0.05)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; IP_SCORE_FREEMAIL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[3.4.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 17:16:12 -0000 CC @current, as I had originally intended. On 2019-08-14 09:08, John Baldwin wrote: > 1) You can set LOCALBASE to a different path either in a kernel config > (via makeoptions) or when invoking buildkernel. > > For example, I mount my rpi's sdcard at /mnt on my amd64 laptop and > then cross-build into it, so I could set LOCALBASE to /mnt/usr/local when > building the rpi's kernel to honor any kmod packages installed on the rpi. Normally LOCALBASE is interpreted by ports as the default for PREFIX, meaning it should be a path _within_ the target system, not the path to where it is mounted.  There is DESTDIR for that. Now for kernel build this is not a problem for the reason that LOCALBASE is being used just to find sources, not to build ports. However, given how that variable is normally used, it seems like a problem waiting to happen.  It would be better to use a variable specific to the purpose at hand. >> How about when I'm doing a build of 11-stable for testing, but what's >> in my /usr/local is sources for a 13-current driver? > Given that the kmod's are supposed to be portable across branches, > the build really shouldn't be breaking. But the same ability is still > there to as above to disable builds either in general or for > specific kernel configs or buildkernel invocations. The concern appears to be that there is no longer a clear way to separate what base source tree does from what is in the local system's configuration.  Is there any one single knob to tell /usr/src not to use any configuration from /usr/local? From owner-freebsd-current@freebsd.org Wed Aug 14 17:24:04 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1C4EDB355A for ; Wed, 14 Aug 2019 17:24:04 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 467xJg5Fk5z4cYg for ; Wed, 14 Aug 2019 17:24:03 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: by mailman.nyi.freebsd.org (Postfix) id B3FB8B3556; Wed, 14 Aug 2019 17:24:03 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B3A25B3555; Wed, 14 Aug 2019 17:24:03 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 467xJf3LK7z4cYf; Wed, 14 Aug 2019 17:24:02 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id a6e2876c; Wed, 14 Aug 2019 19:23:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=IBOoNh5tfz6ulJCSHwzCysvAD7s=; b=PQ9BqVLobaeyB1frFKq+dOgTTBo2 qwS41dc1LwlovkFgYqilcuqjuMfrpwo3Fydm9ZsdfJo0lLsurxW6/4F8krXd11X7 UNi7jfv++jRnPkLqP3T4v1NgxCr4g889PDGaDQHiht/vSacUdjqC8tTn+RPXoEkU B1ym8F9tzM4dB2I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=WPOqwDNhDeBlsfwVzXETwlh0st41SEtCumAt+AKajxB2u1LYwOxlYOVO sTLRajtdU6UboZTWde6Y3hVi1hHyu0BBM/1ls3i46IOKWrxlvHsrCbokqeCWvW1t PtacXQ87ExfZL1u2dEGEhHRFnRzSevKHVe4djmFG3F3g1Ny9GwE= Received: from skull.home.blih.net (ip-9.net-89-3-105.rev.numericable.fr [89.3.105.9]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 0652d351 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Wed, 14 Aug 2019 19:23:53 +0200 (CEST) Date: Wed, 14 Aug 2019 19:23:53 +0200 From: Emmanuel Vadot To: John Baldwin Cc: Ian Lepore , current@FreeBSD.org, x11@FreeBSD.org Subject: Re: HEADSUP: drm-current-kmod now installs sources Message-Id: <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> In-Reply-To: References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 467xJf3LK7z4cYf X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mail header.b=PQ9BqVLo; dmarc=none; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.177.182 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [-0.72 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mail]; NEURAL_HAM_MEDIUM(-0.84)[-0.837,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:212.83.177.182/32]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MV_CASE(0.50)[]; DMARC_NA(0.00)[bidouilliste.com]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.55)[0.548,0]; NEURAL_HAM_LONG(-0.88)[-0.876,0]; DKIM_TRACE(0.00)[bidouilliste.com:+]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(0.34)[ip: (-0.94), ipnet: 212.83.160.0/19(2.57), asn: 12876(0.09), country: FR(-0.01)]; ASN(0.00)[asn:12876, ipnet:212.83.160.0/19, country:FR]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 17:24:04 -0000 On Wed, 14 Aug 2019 10:13:48 -0700 John Baldwin wrote: > On 8/14/19 9:22 AM, Ian Lepore wrote: > > This all sounds vaguely wrong, backwards, to me. A developer who is > > using a given module on their build system might want that module to be > > rebuilt automatically, but only if the build parameters match those of > > the running build host system. > > > > If my build host is running freebsd 12 amd64 and I'm doing a build for > > freebsd 13 armv7, I have no interest in automatic rebuilds of an amd64 > > driver module for a different OS arch and version just because that > > module happens to be installed on the system I use to do crossbuilds. > > > > My objections are theoretical... this automation just seems improperly > > designed to me. But it won't actually affect me in any way, because I > > don't build video driver modules from ports, and I don't run freebsd > > current on my build host machine. Probably the number of people doing > > crossbuilding is small enough that nobody else is going to object to > > this "the whole world is amd64" automation. > > You assume DRM is amd64-only when it is definitely not. It also has > suitable guards in its Makefile to only build the relevant kernel > modules on supported architectures. I clearly don't want to spend time to build the drm and radeon modules when I'm hacking on arm64. Shouldn't LOCAL_MODULE have ${TARGET}.${TARGET_ARCH} as a subdirectory ? So when you install drm-kmod-* it will only install the source in /usr/local/modules/${TARGET}.${TARGET_ARCH}/ ? (or whatever the correct dir is). -- Emmanuel Vadot From owner-freebsd-current@freebsd.org Wed Aug 14 17:55:06 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6AF8AB4104 for ; Wed, 14 Aug 2019 17:55:06 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 467y0V2F1yz4fHy for ; Wed, 14 Aug 2019 17:55:06 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 4A788B4100; Wed, 14 Aug 2019 17:55:06 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4A281B40FF; Wed, 14 Aug 2019 17:55:06 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [176.58.89.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 467y0T6Mjnz4fHx; Wed, 14 Aug 2019 17:55:05 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 467y0R4lp7z3l2k; Wed, 14 Aug 2019 17:55:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new, port 10587) with ESMTPS id 3ygrqJCm1XTt; Wed, 14 Aug 2019 17:55:03 +0000 (UTC) Received: from garnet.daemonic.se (unknown [IPv6:2001:470:dca9:201:99b8:b5f9:82da:aca0]) by mail.daemonic.se (Postfix) with ESMTPSA id 467y0Q6f3Wz3c7W; Wed, 14 Aug 2019 17:55:02 +0000 (UTC) Subject: Re: HEADSUP: drm-current-kmod now installs sources To: Emmanuel Vadot , John Baldwin Cc: x11@FreeBSD.org, current@FreeBSD.org, Ian Lepore References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> From: Niclas Zeising Message-ID: Date: Wed, 14 Aug 2019 19:55:02 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 467y0T6Mjnz4fHx X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.94 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.94)[-0.943,0]; ASN(0.00)[asn:36236, ipnet:176.58.89.0/24, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 17:55:06 -0000 On 2019-08-14 19:23, Emmanuel Vadot wrote: > On Wed, 14 Aug 2019 10:13:48 -0700 > John Baldwin wrote: > >> On 8/14/19 9:22 AM, Ian Lepore wrote: >>> This all sounds vaguely wrong, backwards, to me. A developer who is >>> using a given module on their build system might want that module to be >>> rebuilt automatically, but only if the build parameters match those of >>> the running build host system. >>> >>> If my build host is running freebsd 12 amd64 and I'm doing a build for >>> freebsd 13 armv7, I have no interest in automatic rebuilds of an amd64 >>> driver module for a different OS arch and version just because that >>> module happens to be installed on the system I use to do crossbuilds. >>> >>> My objections are theoretical... this automation just seems improperly >>> designed to me. But it won't actually affect me in any way, because I >>> don't build video driver modules from ports, and I don't run freebsd >>> current on my build host machine. Probably the number of people doing >>> crossbuilding is small enough that nobody else is going to object to >>> this "the whole world is amd64" automation. >> >> You assume DRM is amd64-only when it is definitely not. It also has >> suitable guards in its Makefile to only build the relevant kernel >> modules on supported architectures. > > I clearly don't want to spend time to build the drm and radeon modules > when I'm hacking on arm64. > Shouldn't LOCAL_MODULE have ${TARGET}.${TARGET_ARCH} as a > subdirectory ? So when you install drm-kmod-* it will only install the > source in /usr/local/modules/${TARGET}.${TARGET_ARCH}/ ? (or whatever > the correct dir is). > I'm not sure what you're trying to accomplish. I might be misunderstanding completely, but, at least the drm ports have safeguards in their makefiles so they'll only be built for those arches where there is support, and only the modules needed, as an example, i915kms.ko will only be built on amd64 and i386, if that's what you're worried about. Regards -- Niclas Zeising From owner-freebsd-current@freebsd.org Wed Aug 14 18:03:35 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ADC4CB4B9E for ; Wed, 14 Aug 2019 18:03:35 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 467yBH2Qccz3CnF for ; Wed, 14 Aug 2019 18:03:35 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: by mailman.nyi.freebsd.org (Postfix) id 4FC1FB4B9B; Wed, 14 Aug 2019 18:03:35 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4F716B4B98; Wed, 14 Aug 2019 18:03:35 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 467yBF65wYz3CnB; Wed, 14 Aug 2019 18:03:33 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id 72b43d3d; Wed, 14 Aug 2019 20:03:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=0g5Z0PLZxChjRXgEaTHsr7wcBMo=; b=SUO8cdD6YGnXg/df9iELsEHZlsKc azAMx34hZQi3PrM+txxfp8MYKyC16HZIHJd/BC1QHGHfWkoQsdAvPCrMPIIJhhOp Bqmy16qRtLJ2/rUuB43zxWgkKqOpkC/Hm7Hl/maQfzfYwwD73u7EEQEWYxLjbvaa 53XTwWN+8zH3G1I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=jx7OXOYuKq+986sCY6UVLWeakuKFapWTxCRxTiRGTx6VjToM8RFqm28t nBx+IgSdY85fkt+DUuvhMrlBz2PUqlzU0cNMF/WMrEiI465lB3DSWG0O7rfI14c9 qRUXfdNDEBjJ6rj3Zn4HSl4PGLUoBdIotgRLR+y861PFGyccdE4= Received: from skull.home.blih.net (ip-9.net-89-3-105.rev.numericable.fr [89.3.105.9]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 5461d3f5 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Wed, 14 Aug 2019 20:03:32 +0200 (CEST) Date: Wed, 14 Aug 2019 20:03:31 +0200 From: Emmanuel Vadot To: Niclas Zeising Cc: John Baldwin , x11@FreeBSD.org, current@FreeBSD.org, Ian Lepore Subject: Re: HEADSUP: drm-current-kmod now installs sources Message-Id: <20190814200331.6a26325941779d1eab55a580@bidouilliste.com> In-Reply-To: References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 467yBF65wYz3CnB X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mail header.b=SUO8cdD6; dmarc=none; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.177.182 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [-0.64 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mail]; NEURAL_HAM_MEDIUM(-0.80)[-0.799,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:212.83.177.182/32]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MV_CASE(0.50)[]; DMARC_NA(0.00)[bidouilliste.com]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_LONG(-0.85)[-0.848,0]; NEURAL_SPAM_SHORT(0.56)[0.562,0]; DKIM_TRACE(0.00)[bidouilliste.com:+]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(0.35)[ip: (-0.93), ipnet: 212.83.160.0/19(2.57), asn: 12876(0.09), country: FR(-0.01)]; ASN(0.00)[asn:12876, ipnet:212.83.160.0/19, country:FR]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 18:03:35 -0000 On Wed, 14 Aug 2019 19:55:02 +0200 Niclas Zeising wrote: > On 2019-08-14 19:23, Emmanuel Vadot wrote: > > On Wed, 14 Aug 2019 10:13:48 -0700 > > John Baldwin wrote: > > > >> On 8/14/19 9:22 AM, Ian Lepore wrote: > >>> This all sounds vaguely wrong, backwards, to me. A developer who is > >>> using a given module on their build system might want that module to be > >>> rebuilt automatically, but only if the build parameters match those of > >>> the running build host system. > >>> > >>> If my build host is running freebsd 12 amd64 and I'm doing a build for > >>> freebsd 13 armv7, I have no interest in automatic rebuilds of an amd64 > >>> driver module for a different OS arch and version just because that > >>> module happens to be installed on the system I use to do crossbuilds. > >>> > >>> My objections are theoretical... this automation just seems improperly > >>> designed to me. But it won't actually affect me in any way, because I > >>> don't build video driver modules from ports, and I don't run freebsd > >>> current on my build host machine. Probably the number of people doing > >>> crossbuilding is small enough that nobody else is going to object to > >>> this "the whole world is amd64" automation. > >> > >> You assume DRM is amd64-only when it is definitely not. It also has > >> suitable guards in its Makefile to only build the relevant kernel > >> modules on supported architectures. > > > > I clearly don't want to spend time to build the drm and radeon modules > > when I'm hacking on arm64. > > Shouldn't LOCAL_MODULE have ${TARGET}.${TARGET_ARCH} as a > > subdirectory ? So when you install drm-kmod-* it will only install the > > source in /usr/local/modules/${TARGET}.${TARGET_ARCH}/ ? (or whatever > > the correct dir is). > > > > I'm not sure what you're trying to accomplish. I might be > misunderstanding completely, but, at least the drm ports have safeguards > in their makefiles so they'll only be built for those arches where there > is support, and only the modules needed, as an example, i915kms.ko will > only be built on amd64 and i386, if that's what you're worried about. > Regards > -- > Niclas Zeising Greg.V is making radeon/amdgpu building on aarch64. So when the ports will have support for it if I don't set some env variable I will spend some time building drm + amdgpu when I buildkernel on my amd64 13-CURRENT machine for aarch64. This is not something that I want to do. So what I said was that if I install drm-kmod-* on an amd64 machine this should only trigger a build of the module when I'm building an amd64 kernel, hence my proposal to only install sources in a ${TARGET}.$ {TARGET_ARCH} subdir. -- Emmanuel Vadot From owner-freebsd-current@freebsd.org Wed Aug 14 18:04:08 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 50160B4CCC for ; Wed, 14 Aug 2019 18:04:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 467yBw1LBdz3D3B for ; Wed, 14 Aug 2019 18:04:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id 2DD54B4CC7; Wed, 14 Aug 2019 18:04:08 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2D89DB4CC5; Wed, 14 Aug 2019 18:04:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 467yBw0Tbzz3D36; Wed, 14 Aug 2019 18:04:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-4.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 517EA19FBA; Wed, 14 Aug 2019 18:04:07 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: HEADSUP: drm-current-kmod now installs sources To: Emmanuel Vadot Cc: Ian Lepore , current@FreeBSD.org, x11@FreeBSD.org References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> From: John Baldwin Openpgp: preference=signencrypt Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: Date: Wed, 14 Aug 2019 11:04:03 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 18:04:08 -0000 On 8/14/19 10:23 AM, Emmanuel Vadot wrote: > On Wed, 14 Aug 2019 10:13:48 -0700 > John Baldwin wrote: > >> On 8/14/19 9:22 AM, Ian Lepore wrote: >>> This all sounds vaguely wrong, backwards, to me. A developer who is >>> using a given module on their build system might want that module to be >>> rebuilt automatically, but only if the build parameters match those of >>> the running build host system. >>> >>> If my build host is running freebsd 12 amd64 and I'm doing a build for >>> freebsd 13 armv7, I have no interest in automatic rebuilds of an amd64 >>> driver module for a different OS arch and version just because that >>> module happens to be installed on the system I use to do crossbuilds. >>> >>> My objections are theoretical... this automation just seems improperly >>> designed to me. But it won't actually affect me in any way, because I >>> don't build video driver modules from ports, and I don't run freebsd >>> current on my build host machine. Probably the number of people doing >>> crossbuilding is small enough that nobody else is going to object to >>> this "the whole world is amd64" automation. >> >> You assume DRM is amd64-only when it is definitely not. It also has >> suitable guards in its Makefile to only build the relevant kernel >> modules on supported architectures. > > I clearly don't want to spend time to build the drm and radeon modules > when I'm hacking on arm64. Didn't you when DRM2 was in base? Do you use MODULES_OVERRIDE now to limit the number of modules you are building? Setting LOCAL_MODULES would be no different to setting MODULES_OVERRIDE. If you aren't setting MODULES_OVERRIDE, then I don't buy your argument as the default set of modules dwarfs DRM several times over. -- John Baldwin From owner-freebsd-current@freebsd.org Wed Aug 14 18:04:26 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 20968B4E51 for ; Wed, 14 Aug 2019 18:04:26 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 467yCG01Frz3DJ9 for ; Wed, 14 Aug 2019 18:04:26 +0000 (UTC) (envelope-from ian@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 00201B4E4C; Wed, 14 Aug 2019 18:04:26 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F3F92B4E4B for ; Wed, 14 Aug 2019 18:04:25 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 467yCF5bjQz3DJ4 for ; Wed, 14 Aug 2019 18:04:25 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1565805863; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=CUUO3qVmscOPQd8tvCd2Wdr4BOitkB2myq0BchLWyx+Z7IkrchPGW6aQ7/ruHKDOc2EcRvcY1i89j KCFkHryr/Dm072rGtD1DmiR0fMkBhsFOK17mTCgPJUo/bnWwXUsklP1jeXMuSQgnzvRexGn3S41DJC PBbe0q376uOqe7WuFJ1Uz2/CSxCC7nKDhw9mx4AG1Gk//L4uvK5AnAX1XlxD+VCd+b5KDGJY0mntAo ha4js5yKhXGSlfkBL7nAftxUgMgBPrU3y07q/DEXC+EMEaPamPYlzeXco6bRH2NNUjsfR/VbrWtBqo H4pzSGXG6QrJnI/2/+7R9NAM5diSAnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=/JS/Q+nyRGXqcESnaEfkyCBgdHMRhAMOuxE7bsz1kQA=; b=lZdbW/bf9MZwTfnJi+flm44/69R4jDsIy4h34yFE3V0o54VHFa8lJW0XkZwCrRkEBUkIrXP0Ef4AQ tMPbrTZnlujYIIhsW/4Fca47s8oFNXTikkBqFcdluD7eLVGFmaQ1JkaJ4r8vTp6HKts6PzINtFEEoD 1JgXtFqv0bFjw5Y4XZYMtcgMtkxDDnKsMQQWy6xkOv6tOjWmo7Wev+mA9Q0pP31QEY1x3QvTMmsw6k Rm3Vr6lxuYYXcxfJRo9VPaeqJnO+Gsy65YsNwcw/HaL7GqgPtcEOPZTf1AFs6gjLuPkoLUHeKLomRp YBxDqa3kRdX3lGRnCNxj3C2CIdiegCw== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=/JS/Q+nyRGXqcESnaEfkyCBgdHMRhAMOuxE7bsz1kQA=; b=wspd3VGBWlXMBPdIplq1JxM0SdLCAESP6aX8DVMSp7vGD18j+vHbTfN1p4lubD9RTqG2jZspBHYgZ /PR+PsyZlWBk+uaRe0vJwWT1SVChj9GmlsIMMimrwhYlNxJZM3NC9hrXBpZYQBf/ej5xDPyRmn9IfB mAQL7t7Zv61jU9o7zqaLk71cn6tNifqVBRDuwNKZaIPpRJhlWmVICF1rpNA5RfR4tN0yvgf8RELvG6 hlgX6GJpfq9Oyu2mIdmmp1avO9vwhjDYIdAydjexqGacGS5ZlwL9C8tSZLc4irPTWn2WDjXyqP0+fV pGef+pBTTr2f6aMOZC9mArzmOzIEasw== X-MHO-RoutePath: aGlwcGll X-MHO-User: f0df667c-bebd-11e9-b67b-cdd75d6ce7a8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id f0df667c-bebd-11e9-b67b-cdd75d6ce7a8; Wed, 14 Aug 2019 18:04:22 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x7EI4KFL055387; Wed, 14 Aug 2019 12:04:20 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: HEADSUP: drm-current-kmod now installs sources From: Ian Lepore To: Niclas Zeising , Emmanuel Vadot , John Baldwin Cc: x11@FreeBSD.org, current@FreeBSD.org Date: Wed, 14 Aug 2019 12:04:20 -0600 In-Reply-To: References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 467yCF5bjQz3DJ4 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 18:04:26 -0000 On Wed, 2019-08-14 at 19:55 +0200, Niclas Zeising wrote: > On 2019-08-14 19:23, Emmanuel Vadot wrote: > > On Wed, 14 Aug 2019 10:13:48 -0700 > > John Baldwin wrote: > > > > > On 8/14/19 9:22 AM, Ian Lepore wrote: > > > > This all sounds vaguely wrong, backwards, to me. A developer > > > > who is > > > > using a given module on their build system might want that > > > > module to be > > > > rebuilt automatically, but only if the build parameters match > > > > those of > > > > the running build host system. > > > > > > > > If my build host is running freebsd 12 amd64 and I'm doing a > > > > build for > > > > freebsd 13 armv7, I have no interest in automatic rebuilds of > > > > an amd64 > > > > driver module for a different OS arch and version just because > > > > that > > > > module happens to be installed on the system I use to do > > > > crossbuilds. > > > > > > > > My objections are theoretical... this automation just seems > > > > improperly > > > > designed to me. But it won't actually affect me in any way, > > > > because I > > > > don't build video driver modules from ports, and I don't run > > > > freebsd > > > > current on my build host machine. Probably the number of > > > > people doing > > > > crossbuilding is small enough that nobody else is going to > > > > object to > > > > this "the whole world is amd64" automation. > > > > > > You assume DRM is amd64-only when it is definitely not. It also > > > has > > > suitable guards in its Makefile to only build the relevant kernel > > > modules on supported architectures. > > > > I clearly don't want to spend time to build the drm and radeon > > modules > > when I'm hacking on arm64. > > Shouldn't LOCAL_MODULE have ${TARGET}.${TARGET_ARCH} as a > > subdirectory ? So when you install drm-kmod-* it will only install > > the > > source in /usr/local/modules/${TARGET}.${TARGET_ARCH}/ ? (or > > whatever > > the correct dir is). > > > > I'm not sure what you're trying to accomplish. I might be > misunderstanding completely, but, at least the drm ports have > safeguards > in their makefiles so they'll only be built for those arches where > there > is support, and only the modules needed, as an example, i915kms.ko > will > only be built on amd64 and i386, if that's what you're worried about. > Regards I can't understand what you guys are not-understanding. New machinery has been added that says "if some module source code exists in this absolute fixed location on the build machine, then whenever you do any kernel build for any OS version or any arch, rebuild that module source code so that the the build machine's video drivers stay in sync with the build machine's kernel." Do you not see that for some of us, only a tiny fraction of the builds done (maybe none of them at all) involve the kernel for the build host machine or the video drivers for the build host machine? And yet, for us, every build we do will now inapppropriately rebuild this video driver module which has nothing to do with the machine the build is targeting. And it's not just about crossbuilds, because it's about versions too. Even when a developer is running 13-current and wants their video driver rebuilt and installed automatically along with the kernel, they're certainly going to want that to happen only when they're building 13-current. If they're doing a test-build for 12-stable they certainly aren't going to want to build and install that video driver. -- Ian From owner-freebsd-current@freebsd.org Wed Aug 14 18:08:03 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A8EA4B51CE for ; Wed, 14 Aug 2019 18:08:03 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 467yHR43cKz3Dcc for ; Wed, 14 Aug 2019 18:08:03 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 87C25B51CD; Wed, 14 Aug 2019 18:08:03 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 87665B51CA; Wed, 14 Aug 2019 18:08:03 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 467yHR30rzz3DcZ; Wed, 14 Aug 2019 18:08:03 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 1923E19FBC; Wed, 14 Aug 2019 18:08:03 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-wm1-f52.google.com with SMTP id o4so73308wmh.2; Wed, 14 Aug 2019 11:08:03 -0700 (PDT) X-Gm-Message-State: APjAAAUFECI+AYpCOjlVz7CWkwNd1H+Sv2NgOIbiZqtFi50x8KyXMHBa ycw/0uj1ziG2txFLEYAntnZLtUfbwZGAjrZ8PxI= X-Google-Smtp-Source: APXvYqyak8MfNpCQepUwGOKhNsO5G6MUb96PyMO2NKGm9Z+60XAMNUa8Ut5utBEtK7NplZdRW0TTheNUpLyyS5lb2I0= X-Received: by 2002:a1c:4087:: with SMTP id n129mr387517wma.3.1565806081949; Wed, 14 Aug 2019 11:08:01 -0700 (PDT) MIME-Version: 1.0 References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> In-Reply-To: From: Kyle Evans Date: Wed, 14 Aug 2019 13:06:56 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: HEADSUP: drm-current-kmod now installs sources To: Ian Lepore Cc: Niclas Zeising , Emmanuel Vadot , John Baldwin , x11@freebsd.org, current Content-Type: text/plain; charset="UTF-8" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 18:08:03 -0000 On Wed, Aug 14, 2019 at 1:04 PM Ian Lepore wrote: > > On Wed, 2019-08-14 at 19:55 +0200, Niclas Zeising wrote: > > On 2019-08-14 19:23, Emmanuel Vadot wrote: > > > On Wed, 14 Aug 2019 10:13:48 -0700 > > > John Baldwin wrote: > > > > > > > On 8/14/19 9:22 AM, Ian Lepore wrote: > > > > > This all sounds vaguely wrong, backwards, to me. A developer > > > > > who is > > > > > using a given module on their build system might want that > > > > > module to be > > > > > rebuilt automatically, but only if the build parameters match > > > > > those of > > > > > the running build host system. > > > > > > > > > > If my build host is running freebsd 12 amd64 and I'm doing a > > > > > build for > > > > > freebsd 13 armv7, I have no interest in automatic rebuilds of > > > > > an amd64 > > > > > driver module for a different OS arch and version just because > > > > > that > > > > > module happens to be installed on the system I use to do > > > > > crossbuilds. > > > > > > > > > > My objections are theoretical... this automation just seems > > > > > improperly > > > > > designed to me. But it won't actually affect me in any way, > > > > > because I > > > > > don't build video driver modules from ports, and I don't run > > > > > freebsd > > > > > current on my build host machine. Probably the number of > > > > > people doing > > > > > crossbuilding is small enough that nobody else is going to > > > > > object to > > > > > this "the whole world is amd64" automation. > > > > > > > > You assume DRM is amd64-only when it is definitely not. It also > > > > has > > > > suitable guards in its Makefile to only build the relevant kernel > > > > modules on supported architectures. > > > > > > I clearly don't want to spend time to build the drm and radeon > > > modules > > > when I'm hacking on arm64. > > > Shouldn't LOCAL_MODULE have ${TARGET}.${TARGET_ARCH} as a > > > subdirectory ? So when you install drm-kmod-* it will only install > > > the > > > source in /usr/local/modules/${TARGET}.${TARGET_ARCH}/ ? (or > > > whatever > > > the correct dir is). > > > > > > > I'm not sure what you're trying to accomplish. I might be > > misunderstanding completely, but, at least the drm ports have > > safeguards > > in their makefiles so they'll only be built for those arches where > > there > > is support, and only the modules needed, as an example, i915kms.ko > > will > > only be built on amd64 and i386, if that's what you're worried about. > > Regards > > I can't understand what you guys are not-understanding. New machinery > has been added that says "if some module source code exists in this > absolute fixed location on the build machine, then whenever you do any > kernel build for any OS version or any arch, rebuild that module source > code so that the the build machine's video drivers stay in sync with > the build machine's kernel." LOCAL_MODULES="" does seem like a sensible default when we're not building a native kernel. From owner-freebsd-current@freebsd.org Wed Aug 14 18:12:15 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 79BFCB5843 for ; Wed, 14 Aug 2019 18:12:15 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 467yNH1Tm6z3FD0 for ; Wed, 14 Aug 2019 18:12:15 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: by mailman.nyi.freebsd.org (Postfix) id 31156B5840; Wed, 14 Aug 2019 18:12:15 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 30BCBB583E; Wed, 14 Aug 2019 18:12:15 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 467yNG0cBqz3FCt; Wed, 14 Aug 2019 18:12:13 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id d09a8fe7; Wed, 14 Aug 2019 20:12:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=5BxfdNKFqPpjxUhif2pZoL48V2c=; b=bE+oH4HB/FBr0RsdyMcTCM4mMTqY Z5llMsk7BaOuRDTkVB7sGcC1HbjSwHrer8CmG9vSdujpbQiHriIzZWqOCkq/q6kr h+/J1fVAgFM4yRwQ4WaBJnptBFc/iiYSGxujFZjkZF0CQhaMvbYvCaZNkd1XuLz6 jKkddNb2+gotcjA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=tS2mj1O5yNBoLxjZBqKrK1VA/z4oq4SSgehaIoPD/PpCFOysItaeU8Ee 3aIEYXoySPWmWAEDRE4PVGRJSVbuYup7ejyAeU9bHCNEdiwPauA4TPRJGT0yskUJ G7tvXsexT9OYvz3v4MDJDiAyjKTakC81sV8ZcrBknlxJNYve/og= Received: from skull.home.blih.net (ip-9.net-89-3-105.rev.numericable.fr [89.3.105.9]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 47d63904 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Wed, 14 Aug 2019 20:12:12 +0200 (CEST) Date: Wed, 14 Aug 2019 20:12:12 +0200 From: Emmanuel Vadot To: John Baldwin Cc: Ian Lepore , current@FreeBSD.org, x11@FreeBSD.org Subject: Re: HEADSUP: drm-current-kmod now installs sources Message-Id: <20190814201212.5021af864778d5fc16c0f61a@bidouilliste.com> In-Reply-To: References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 467yNG0cBqz3FCt X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mail header.b=bE+oH4HB; dmarc=none; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.177.182 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [-0.48 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mail]; NEURAL_HAM_MEDIUM(-0.64)[-0.636,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:212.83.177.182/32:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MV_CASE(0.50)[]; DMARC_NA(0.00)[bidouilliste.com]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.58)[0.576,0]; NEURAL_HAM_LONG(-0.87)[-0.869,0]; DKIM_TRACE(0.00)[bidouilliste.com:+]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(0.35)[ip: (-0.92), ipnet: 212.83.160.0/19(2.57), asn: 12876(0.09), country: FR(-0.01)]; ASN(0.00)[asn:12876, ipnet:212.83.160.0/19, country:FR]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 18:12:15 -0000 On Wed, 14 Aug 2019 11:04:03 -0700 John Baldwin wrote: > On 8/14/19 10:23 AM, Emmanuel Vadot wrote: > > On Wed, 14 Aug 2019 10:13:48 -0700 > > John Baldwin wrote: > > > >> On 8/14/19 9:22 AM, Ian Lepore wrote: > >>> This all sounds vaguely wrong, backwards, to me. A developer who is > >>> using a given module on their build system might want that module to be > >>> rebuilt automatically, but only if the build parameters match those of > >>> the running build host system. > >>> > >>> If my build host is running freebsd 12 amd64 and I'm doing a build for > >>> freebsd 13 armv7, I have no interest in automatic rebuilds of an amd64 > >>> driver module for a different OS arch and version just because that > >>> module happens to be installed on the system I use to do crossbuilds. > >>> > >>> My objections are theoretical... this automation just seems improperly > >>> designed to me. But it won't actually affect me in any way, because I > >>> don't build video driver modules from ports, and I don't run freebsd > >>> current on my build host machine. Probably the number of people doing > >>> crossbuilding is small enough that nobody else is going to object to > >>> this "the whole world is amd64" automation. > >> > >> You assume DRM is amd64-only when it is definitely not. It also has > >> suitable guards in its Makefile to only build the relevant kernel > >> modules on supported architectures. > > > > I clearly don't want to spend time to build the drm and radeon modules > > when I'm hacking on arm64. > > Didn't you when DRM2 was in base? No, DRM2 was never connected for aarch64. > Do you use MODULES_OVERRIDE now to > limit the number of modules you are building? Most of the time yes, but if I don't set it, it shouldn't mean that I want to compile an out of tree module that I installed for another arch. > Setting LOCAL_MODULES would > be no different to setting MODULES_OVERRIDE. If you aren't setting > MODULES_OVERRIDE, then I don't buy your argument as the default set of > modules dwarfs DRM several times over. If nothing changes I will endup setting LOCAL_MODULES="" everytime but again this is not the problem, see above. > -- > John Baldwin > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" -- Emmanuel Vadot From owner-freebsd-current@freebsd.org Wed Aug 14 18:58:33 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D9E30B6C43 for ; Wed, 14 Aug 2019 18:58:33 +0000 (UTC) (envelope-from theron.tarigo@gmail.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 467zPj4Qfxz3J6v for ; Wed, 14 Aug 2019 18:58:33 +0000 (UTC) (envelope-from theron.tarigo@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id 977B9B6C3F; Wed, 14 Aug 2019 18:58:33 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9727BB6C3E; Wed, 14 Aug 2019 18:58:33 +0000 (UTC) (envelope-from theron.tarigo@gmail.com) Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 467zPh5yx0z3J6r; Wed, 14 Aug 2019 18:58:32 +0000 (UTC) (envelope-from theron.tarigo@gmail.com) Received: by mail-pg1-x541.google.com with SMTP id n190so47253pgn.0; Wed, 14 Aug 2019 11:58:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=qnVLL3XGJhGyvl8qPdkbm9/pahitNBKUYT+fg/2vOno=; b=Ufp6STO24qy0qtkt5+fCCYdGWQSp6+PoRJ0S1Uvq7qMeRiQ8Vj4Sfh6ASdDHN1fEsK cAKCnV8uW28lQTeGt4Q0PSRQffZt8sAfUANTujXboHGMcMOXi4Qp4WlhChmuqILVqwW2 LyqNtPb/abjh2SamZCbPIsTuxzYdTMg+SJun9qYrimMxQsJEoRhZhayVq1NgSVtjPGqJ ex93wGnrt47Wv7wBFyUsi5QNlHARAYicvpLIQBAPPlbA1tgCmcEMgCQXa19Tcsf6AHKg niATYm+a4VjFewTT6eyN+4U2kXQMbfDVZC6O+JZQl8i6GfhYhvF/zodNxoKdr5dmuROU 2uAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=qnVLL3XGJhGyvl8qPdkbm9/pahitNBKUYT+fg/2vOno=; b=KdGStMNpx2e6IVOvHoF/4PpwAf/J1SWcN/FsUbAbW80aInGgS2pv5ghu2oFIPgNwmU pSwA+zhzeB0z8dz9dUjXmmNtN9C2/vaGRsSB8/zfWWC1aTjcbcWw28Ptj8JfrncVleyl yhpr/LTpkyMnN7LG0j7IZpj2pjsxuLemmN8o0vgyp+NZ1kwuzCV4Xxi3iuvHObHLQHc/ +cMlZkEjUC0kHaSIMbupPwAe2p+iOwQ/f0/y9dKDO2COaD50caPy/5G4LDaGTuzZOhN9 6RA44o6HqJ2TW9Ga+KM21sDakPcvqrF4eMdqxVNYE/CEqAcmTWEZnsn7egrvA8zPjo+m Q92A== X-Gm-Message-State: APjAAAUMbMkLsA1YKbBpfKWhUW/P8nyn8YcQ7vYkYg7ruPa2I7IWZCO3 MjfcwLKaMnZOLxGbDMbrZKDpuYl+zj8= X-Google-Smtp-Source: APXvYqz1e+2V3JSiG2IRPzeVEL3QgPlCgr0b6ClZ2WNWajTGOUoOLggURpsDlHK3ivxq0n6Ne7v77A== X-Received: by 2002:a17:90b:907:: with SMTP id bo7mr1088741pjb.107.1565809111417; Wed, 14 Aug 2019 11:58:31 -0700 (PDT) Received: from [192.168.1.23] (c-73-170-47-221.hsd1.ca.comcast.net. [73.170.47.221]) by smtp.gmail.com with ESMTPSA id r12sm427172pgb.73.2019.08.14.11.58.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Aug 2019 11:58:30 -0700 (PDT) Sender: Theron Tarigo Subject: Re: HEADSUP: drm-current-kmod now installs sources To: Kyle Evans , Ian Lepore Cc: x11@freebsd.org, current , John Baldwin , Niclas Zeising References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> From: Theron Message-ID: <8ffd1652-2745-aeb3-5f12-b3aa84aebf57@gmail.com> Date: Wed, 14 Aug 2019 11:58:29 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 467zPh5yx0z3J6r X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Ufp6STO2; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of therontarigo@gmail.com designates 2607:f8b0:4864:20::541 as permitted sender) smtp.mailfrom=therontarigo@gmail.com X-Spamd-Result: default: False [-3.98 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.98)[-0.979,0]; RECEIVED_SPAMHAUS_PBL(0.00)[221.47.170.73.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; IP_SCORE(0.00)[ip: (-0.33), ipnet: 2607:f8b0::/32(-2.98), asn: 15169(-2.39), country: US(-0.05)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; MID_RHS_MATCH_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE_FREEMAIL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[1.4.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 18:58:33 -0000 On 2019-08-14 11:04, Ian Lepore wrote: > I can't understand what you guys are not-understanding. New machinery > has been added that says "if some module source code exists in this > absolute fixed location on the build machine, then whenever you do any > kernel build for any OS version or any arch, rebuild that module source > code so that the the build machine's video drivers stay in sync with > the build machine's kernel." > > Do you not see that for some of us, only a tiny fraction of the builds > done (maybe none of them at all) involve the kernel for the build host > machine or the video drivers for the build host machine? And yet, for > us, every build we do will now inapppropriately rebuild this video > driver module which has nothing to do with the machine the build is > targeting. Most of the kernel builds I do _are_ for the host machine, yet I don't want the new behavior either.  Why?  The build logic of the source tree should be self-contained and easily understandable. Looking all over the system and trying to automate fixes is what ports are for. Automated hacks for this sort of situation, that do the right thing 90% of the time but inevitably break down on other perfectly reasonable use cases, are one of the factors that pushed me away from the operating systems I used before FreeBSD. Managing the host's kernel and needed modules from source from a single tool certainly is useful, but I think it should be just that: a tool, used when appropriate, not a default behavior. This tool can be recommended to kmod port users/developers for local system work while everyone else may continue using source tree as expected. On 2019-08-14 11:06, Kyle Evans wrote: > LOCAL_MODULES="" does seem like a sensible default when we're not > building a native kernel. More generally there should be a switch for defeating any and all attempts to use anything "local" (non /usr/src). From owner-freebsd-current@freebsd.org Wed Aug 14 19:00:09 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8D9DAB6E9E for ; Wed, 14 Aug 2019 19:00:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 467zRY3FbJz3JP9 for ; Wed, 14 Aug 2019 19:00:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id 6F6E2B6E9C; Wed, 14 Aug 2019 19:00:09 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6F189B6E96; Wed, 14 Aug 2019 19:00:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 467zRY2H7sz3JP8; Wed, 14 Aug 2019 19:00:09 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-4.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 7775D1A596; Wed, 14 Aug 2019 19:00:08 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: HEADSUP: drm-current-kmod now installs sources To: Kyle Evans , Ian Lepore Cc: Niclas Zeising , Emmanuel Vadot , x11@freebsd.org, current References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> From: John Baldwin Openpgp: preference=signencrypt Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: Date: Wed, 14 Aug 2019 12:00:06 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 19:00:09 -0000 On 8/14/19 11:06 AM, Kyle Evans wrote: > LOCAL_MODULES="" does seem like a sensible default when we're not > building a native kernel. Unfortunately kern.post.mk has no way of knowing that as MACHINE_* are already set to the TARGET_* values by the time this target is invoked. Also, the 'make tinderbox' use case is a legit use case that some folks want (for CI, etc.) -- John Baldwin From owner-freebsd-current@freebsd.org Wed Aug 14 19:08:35 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B93CBB75EF for ; Wed, 14 Aug 2019 19:08:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 467zdH4P3gz3KKM for ; Wed, 14 Aug 2019 19:08:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id 968F3B75E6; Wed, 14 Aug 2019 19:08:35 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 952F2B75E5; Wed, 14 Aug 2019 19:08:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 467zdH30Pvz3KKK; Wed, 14 Aug 2019 19:08:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-4.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id A16211A6BE; Wed, 14 Aug 2019 19:08:34 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: HEADSUP: drm-current-kmod now installs sources To: Ian Lepore , Niclas Zeising , Emmanuel Vadot Cc: x11@FreeBSD.org, current@FreeBSD.org References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> From: John Baldwin Openpgp: preference=signencrypt Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: <728a43cf-5c01-9fc5-ec5d-9c7450b70430@FreeBSD.org> Date: Wed, 14 Aug 2019 12:08:29 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 19:08:35 -0000 On 8/14/19 11:04 AM, Ian Lepore wrote: > On Wed, 2019-08-14 at 19:55 +0200, Niclas Zeising wrote: > I can't understand what you guys are not-understanding. New machinery > has been added that says "if some module source code exists in this > absolute fixed location on the build machine, then whenever you do any > kernel build for any OS version or any arch, rebuild that module source > code so that the the build machine's video drivers stay in sync with > the build machine's kernel." To back up a bit, one thing I didn't say (and should have in the first email) is that this change is only in HEAD for now specifically to gain some experience for what the default policy should be. However, I'd at least like to _try_ it for a bit so we can get some data to determine that instead of only going on theory. And it's not just DRM though that is the only test case for now. Did you know that we shipped 11.3 release such that if you did 'pkg install virtualbox' and loaded the kernel module your machine panicked because the pre-built module was built for 11.2 and didn't work on 11.3? Certain kmods aren't suitable for binary-only distribution and need other options, and we need to figure out how to handle other options. -- John Baldwin From owner-freebsd-current@freebsd.org Wed Aug 14 19:56:12 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 11949B8E71 for ; Wed, 14 Aug 2019 19:56:12 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4680hC6kPrz3NJD for ; Wed, 14 Aug 2019 19:56:11 +0000 (UTC) (envelope-from ian@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id E618BB8E6E; Wed, 14 Aug 2019 19:56:11 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E5BC7B8E6B for ; Wed, 14 Aug 2019 19:56:11 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4680hC3s87z3NJ7 for ; Wed, 14 Aug 2019 19:56:11 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1565812570; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=H2zJze5IYgHUGb3lOO7yLzA4ipG97efPBy6dr24GKc8hk6YRyvbY80Y1k0uQ+wQZ4Ny2mFhEHUIQ1 fmsD+qtDxKgmxV7/ZK3qnqC49uD4sfHnk/xzZd8yLIBYBrKOd/IS0Vt5sy0QkbBczzbXNFMy9tzzq4 5zhNq6/20nWAusP1WptNKnCyb/PGqYCPdT6A0t+8p2dGQ0JHS9wiIhnAug5kk2r7n9raJ28tLx/TMg MrXZwrI4od3uaPXv7UAv3Y/3RTAbyn3Tj+YTGOrxg1IGPeGpwO9euScgTe+giDanl+T5QWJxXEFV3e vfRYhAMXnCS6AGkUG61cIMXOxN+mJOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=AxMitxiXZ6hpGup65d2CEWrcus4ZuEy/NyG+v6t5Ovo=; b=vRqZgri9szNpgSrEH+ZeIoSqs9ls/OwF9MDV6Bizw3OXi5d73WJ0iOjA+kBcqHejRogCOy/mf49CO hcqN68wUaxhKlPlRGsYcI2a9UuiXXj+PExBq2SdUMCYPXbPrD7nYWBPdMbyk3tHNCM3iSGNWWXJLUy kiCRLUdfkMOyuZcVioMuebQx52ttt/GnQSlkgFa3IHMHKDYzWej54qB8lc5h63JG1LRwfpA+Bsl6jp hwfuPyuMUBPZk6VkcM13hXnG1prOnrIuuy3XYePjgkXk5T61i3mS9+x9TuOGrwdMN2JZERlPB+tAiU Kl3HUFOKHObBO/kSzps6PDl2C4Ewn7w== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=AxMitxiXZ6hpGup65d2CEWrcus4ZuEy/NyG+v6t5Ovo=; b=k0Kvwjb5/CakOa+aMbHYUKPNYdNha18C7PiSV65eVCBHWocR0ya4Yk7Y1KUz0H5sr+r77QwAJJ4c5 eGM274s+Q5R0wLph4a9YUS8lulM0pN3h7Tcj7wqstNmE6oRRVD0v7dn6SaMm4ZkacDPdJxaWV3H6Gf zcm0oGj/eXkyWN07tvceue7+HR3O/xwlidiehMxLmgHRlCZytRGN0+YnzblKLoSZQSx1Hm08baRr83 lroSsaYjLHwAWaYlgcMb36JvrXeEv0WekKlstJoBnGIzXA9atbpclxJwDU4C8SeTV9x+YkaP/80Zth gtOTPYfw7bzAtZTPYcdpqoAmk0pHSIw== X-MHO-RoutePath: aGlwcGll X-MHO-User: 8d967493-becd-11e9-b67b-cdd75d6ce7a8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id 8d967493-becd-11e9-b67b-cdd75d6ce7a8; Wed, 14 Aug 2019 19:56:09 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x7EJu6Am055766; Wed, 14 Aug 2019 13:56:06 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <02c501907f6eca8f4bd9b44331ac6ab2e28d624f.camel@freebsd.org> Subject: Re: HEADSUP: drm-current-kmod now installs sources From: Ian Lepore To: John Baldwin , Kyle Evans Cc: Niclas Zeising , Emmanuel Vadot , x11@freebsd.org, current Date: Wed, 14 Aug 2019 13:56:06 -0600 In-Reply-To: References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4680hC3s87z3NJ7 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 19:56:12 -0000 On Wed, 2019-08-14 at 12:00 -0700, John Baldwin wrote: > On 8/14/19 11:06 AM, Kyle Evans wrote: > > LOCAL_MODULES="" does seem like a sensible default when we're not > > building a native kernel. > > Unfortunately kern.post.mk has no way of knowing that as MACHINE_* > are already set to the TARGET_* values by the time this target is > invoked. Also, the 'make tinderbox' use case is a legit use case > that some folks want (for CI, etc.) > BUILDHOST_ARCH!= uname -p .if ${BUILDHOST_ARCH} != ${TARGET_ARCH} Unfortunately, I don't think it's as easy to compare the buildhost running version with the version of source being built, unless the build is started from the top level so that Makefile.inc1 sets the variables. -- Ian From owner-freebsd-current@freebsd.org Wed Aug 14 20:00:13 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 30C63B90FE for ; Wed, 14 Aug 2019 20:00:13 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4680mr6LkZz3Ndm for ; Wed, 14 Aug 2019 20:00:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mailman.nyi.freebsd.org (Postfix) id D9C54B90FA; Wed, 14 Aug 2019 20:00:12 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D9815B90F9 for ; Wed, 14 Aug 2019 20:00:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4680mr1LS6z3Ndd for ; Wed, 14 Aug 2019 20:00:11 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x836.google.com with SMTP id z4so111593031qtc.3 for ; Wed, 14 Aug 2019 13:00:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eEZ3TvP1dXe1dZCRMnoG18tTcvcudZQn1Rnx5dzGoJg=; b=vVBIZKREOrYXSs36nMSoMmsXIQ0ocvAfpAK/OOMtAsrHI1ut2Z/hRhXbsLjvF6iGxp ywvNR0di6BPT1szjsYshvF7+OiZjsYPjasRjm0CxL8P+CrjOg7pFL79ObpyFceM2fJcl 4iqgp6LWElMclS0yU7D/ivJOtv0950wRbU3UCdSPZWLQrlqeizhudKXE2z4r18kbcYIz /NUyUaDlQRGFcg9H4TnnYo8tqYonjUHJsqrcPwILq9z0yAw/Fb4n/ZAVb3tCqamiyhUs q4TW5yo1pe1PtY/GgEuJRqQGADHoge+7GuxaRzG/sx5Vp1Bgj36jWqBXh8q79oRnP/kt /Nyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eEZ3TvP1dXe1dZCRMnoG18tTcvcudZQn1Rnx5dzGoJg=; b=HE3zqovt2meY4Z430Kv9PN3D6FwUmW8wZ9OErznnBm/knCxdBy2gteqbASEgPchWLG G0EHVzIecQPi2+YAja2fjS0s6XTnyeALAJ2TrbfioKb7qdx6ZfBn5ROS10Tfeup386Gz bOF/E46Uwrq00qAPPRyQCXA9Xv/+5tz8UxGMY/xDdYNorMC24d5ocWfYUp0YVVXq6f0w OzzVWztmVys+HXPf+OTlEd5hjtDLj62bKRSb3KGY2hp2i3kmR5wt3EoyPrBF7Cqfi7X/ MqpriKBR7lJFrOTRR8fXyOhBpdPp4tyh9BBdh2LSTzxI7TE5inIIAjBWkcM8cfvxDTzZ Pydw== X-Gm-Message-State: APjAAAXZdTTukU+/nLnPWC0kmuSRIwshViB82x409UnvYJWrNnKuYG6Q wst1aRlEHFmG+KQpW0Fys1g2hPtHd4v3nOO0Fq8x4A== X-Google-Smtp-Source: APXvYqyrq9F44mv+l8Qiqt8MsOee0ui6L7h0JZMn8G87yaRs60WWUkduNU3/4yk01XfrxD3mbuTs1kgd3Ykg+x61jyc= X-Received: by 2002:a0c:e5c6:: with SMTP id u6mr1029691qvm.102.1565812810876; Wed, 14 Aug 2019 13:00:10 -0700 (PDT) MIME-Version: 1.0 References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> <02c501907f6eca8f4bd9b44331ac6ab2e28d624f.camel@freebsd.org> In-Reply-To: <02c501907f6eca8f4bd9b44331ac6ab2e28d624f.camel@freebsd.org> From: Warner Losh Date: Wed, 14 Aug 2019 13:59:59 -0600 Message-ID: Subject: Re: HEADSUP: drm-current-kmod now installs sources To: Ian Lepore Cc: John Baldwin , Kyle Evans , x11@freebsd.org, current , Niclas Zeising X-Rspamd-Queue-Id: 4680mr1LS6z3Ndd X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=vVBIZKRE; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::836) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-5.93 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[current@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-1.00)[-0.996,0]; RCVD_IN_DNSWL_NONE(0.00)[6.3.8.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-2.94)[ip: (-9.27), ipnet: 2607:f8b0::/32(-2.98), asn: 15169(-2.39), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 20:00:13 -0000 On Wed, Aug 14, 2019 at 1:56 PM Ian Lepore wrote: > On Wed, 2019-08-14 at 12:00 -0700, John Baldwin wrote: > > On 8/14/19 11:06 AM, Kyle Evans wrote: > > > LOCAL_MODULES="" does seem like a sensible default when we're not > > > building a native kernel. > > > > Unfortunately kern.post.mk has no way of knowing that as MACHINE_* > > are already set to the TARGET_* values by the time this target is > > invoked. Also, the 'make tinderbox' use case is a legit use case > > that some folks want (for CI, etc.) > > > > BUILDHOST_ARCH!= uname -p > .if ${BUILDHOST_ARCH} != ${TARGET_ARCH} > > Unfortunately, I don't think it's as easy to compare the buildhost > running version with the version of source being built, unless the > build is started from the top level so that Makefile.inc1 sets the > variables. > We already know MACHINE_ARCH != TARGET_ARCH in Makefile.inc1 and already do different things based on it. But to be honest, I'd think there'd be times I'd absolutely want to build them all, and other times I wouldn't which strongly suggests some kind of knob specific for cross building the port/pkg-based kernel modules. We could then pass that knob into the kernel builds which would then not try to guess whether or not to build LOCAL_MODULES... Warner From owner-freebsd-current@freebsd.org Wed Aug 14 20:19:35 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CB84BB9940 for ; Wed, 14 Aug 2019 20:19:35 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4681CC51qjz3PgQ for ; Wed, 14 Aug 2019 20:19:35 +0000 (UTC) (envelope-from ian@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id AC36EB993E; Wed, 14 Aug 2019 20:19:35 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ABECCB9939 for ; Wed, 14 Aug 2019 20:19:35 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4681CC39Jqz3PgP for ; Wed, 14 Aug 2019 20:19:35 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1565813974; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=jBtTurwAk+TGEX5O672vQ4Nq07LKAS453xWtkDaG25L1O+qSZogHhKXKxRT+7Jrdg6Hbr5ej55vPm TvJ1rUFzUPTjjiwtDoC7Ha3/tD/zBv8ff6cBWPZe338v0Ul7012rptRAzMamol5NSnzJShoZEreT2w ERZcVlUFxIzxRozuXKShdHhJsILiV67tSfkP6ACiuhGliSFdUICCf5sUwZAAk6qj7ImoFT4LVKM5NL a4ijxEd9SxYKpZsSp8x+g16M9Q1OkQib9KwL06tXyQmtDQwZu3vtvxrdYeJTl3o0QEUs9WLPH1WIan l6GvmprEYFoX/91qjuGFVX2Y3VBd80g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=VU2DFjXf+s5TXDllr7wFD+mLArls6pSWOl7kAIX9Q0A=; b=QmgY0HkEXO+LlluVhXQc4UpblJAumwJzABgkfIAbfjTDUHmns8cKe19CbUWpUahP5vgRumBsf4k5u jNfP56wm/b8yiyIuafwq0LXYwsh/iKJ8zYDkX8WNQ8xQktOanJo79ILj6RoRAKXa+WPSHnaoQoOLdW 0EW3n7E6BVrI0iRGmfqIV/mvZ/AkE9Rp0QY8ct6+PA3eMkMUjkJmGRtX3MbsRT3HyR2/elJtnCQrFX Gs9D5q1VjQ/bcpYJjCw+tpvIH3wg0WWlkk8kIdc7WDvRJkLMnGoB3AfAYct/PRgPjPEFjgU11+Nq7U OzwaHj/6/lDAD0k0B1JSiUOny2PUk/A== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=VU2DFjXf+s5TXDllr7wFD+mLArls6pSWOl7kAIX9Q0A=; b=jOB3+jzIq0o/NmteTsPI+qFn966j3CusgAvO4LsKIISkE3npHqP/HynDWeOOiW69yNRm1wz6A3uNv LwhsFTa14YwduHaJv8CY3Fy9wnnBoqWoLrbohotKtoK1OxPs+69MOTvdmdvzOGGb18PEMJOvTvgKNp 0CPp+SsZQp4LgHiqcBDiV9414HtgjCXMGhzFPEMZzmfafeOf3KlicmwfMILBuzhDiEXaSCQ1467CN+ foNrbQFec5bzkFX5ELDg1H65VKF/9KSqpEKISlJp7pWYn0Cf1Xm5mqCpMPmVT94PAGrFnh36PkA7JR jKGfVW4sp5yNl5pGvZXn+4c92WOGYMw== X-MHO-RoutePath: aGlwcGll X-MHO-User: d351da40-bed0-11e9-b67b-cdd75d6ce7a8 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id d351da40-bed0-11e9-b67b-cdd75d6ce7a8; Wed, 14 Aug 2019 20:19:33 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id x7EKJVW9055856; Wed, 14 Aug 2019 14:19:31 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: HEADSUP: drm-current-kmod now installs sources From: Ian Lepore To: Warner Losh Cc: John Baldwin , Kyle Evans , x11@freebsd.org, current , Niclas Zeising Date: Wed, 14 Aug 2019 14:19:31 -0600 In-Reply-To: References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> <02c501907f6eca8f4bd9b44331ac6ab2e28d624f.camel@freebsd.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4681CC39Jqz3PgP X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 20:19:35 -0000 On Wed, 2019-08-14 at 13:59 -0600, Warner Losh wrote: > On Wed, Aug 14, 2019 at 1:56 PM Ian Lepore wrote: > > > On Wed, 2019-08-14 at 12:00 -0700, John Baldwin wrote: > > > On 8/14/19 11:06 AM, Kyle Evans wrote: > > > > LOCAL_MODULES="" does seem like a sensible default when we're > > > > not > > > > building a native kernel. > > > > > > Unfortunately kern.post.mk has no way of knowing that as > > > MACHINE_* > > > are already set to the TARGET_* values by the time this target is > > > invoked. Also, the 'make tinderbox' use case is a legit use case > > > that some folks want (for CI, etc.) > > > > > > > BUILDHOST_ARCH!= uname -p > > .if ${BUILDHOST_ARCH} != ${TARGET_ARCH} > > > > Unfortunately, I don't think it's as easy to compare the buildhost > > running version with the version of source being built, unless the > > build is started from the top level so that Makefile.inc1 sets the > > variables. > > > > We already know MACHINE_ARCH != TARGET_ARCH in Makefile.inc1 and > already do > different things based on it. But to be honest, I'd think there'd be > times > I'd absolutely want to build them all, and other times I wouldn't > which > strongly suggests some kind of knob specific for cross building the > port/pkg-based kernel modules. We could then pass that knob into the > kernel > builds which would then not try to guess whether or not to build > LOCAL_MODULES... > > This is just about AUTOMATICALLY deciding to build something, based on the presence of source code in an arbitrary fixed location outside of the source tree on the build machine. Anything set by the user should be honored without question, including LOCAL_MODULES. My point is only that the build machinery should not be deciding to build something the user didn't specify based on the existence of out- of-tree files on the build machine (I'd like to put the period right here in this sentence), unless there's a very high likelyhood that the build being done is for the build machine. Things like CI that want to include more than in-tree sources as part of the build should be handling that by setting appropriate knobs as part of invoking the build. -- Ian From owner-freebsd-current@freebsd.org Wed Aug 14 20:49:55 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B0963BAA66; Wed, 14 Aug 2019 20:49:55 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4681tB1jjYz3wrS; Wed, 14 Aug 2019 20:49:53 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id y0DMhtVKoIhW9y0DOhq0IF; Wed, 14 Aug 2019 14:49:51 -0600 X-Authority-Analysis: v=2.3 cv=FcFJO626 c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=FmdZ9Uzk2mMA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=ukcIUTkTVbqB7o9lrnYA:9 a=nP8rgmpX93VALr-r:21 a=DA6hQ6Newwfzqsrh:21 a=QEXdDO2ut3YA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from 5CG5030TVK-N.esitwifi.local (S0106788a207e2972.gv.shawcable.net [70.66.154.233]) by spqr.komquats.com (Postfix) with ESMTPSA id D19ABB9B; Wed, 14 Aug 2019 13:49:47 -0700 (PDT) Date: Wed, 14 Aug 2019 13:49:28 -0700 In-Reply-To: References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: HEADSUP: drm-current-kmod now installs sources To: freebsd-current@freebsd.org, Ian Lepore , Niclas Zeising , Emmanuel Vadot , John Baldwin CC: x11@FreeBSD.org,current@FreeBSD.org From: Cy Schubert Message-ID: X-CMAE-Envelope: MS4wfNjJ29sFSkY3pMn199DyQvSe3+UG1IS5BPt3uUzZde+OcIhIPtYpnF4XvkxrxoCa+9x85fM4ZzE6W2KFhBIvX6et5P4zNSkvV1nN6Ac3aTDUXo6MPGCC OIA5XYbj4XBBfrmECHGj/0H11rDpKiZgIyVpf2Vkp+/FO3EKEyCJA+ldw5+2dsqlSwav2fO1JEB6PnO+WLhaEXKiIGh0xp9QvsqMcYtS414PoSYul30MDJoM yw3uFkUosK/m+mY+hsxSQr8re2dlP2lxjo+YVIRK0VmSyjaUpbkD/EkJg7KE84RqE+OLm5k02KayjAmjAxKweTG6Oe41Ev7UaeQqLJIr4/TxDAv1tuUmDT3Q HvyW0r7Q X-Rspamd-Queue-Id: 4681tB1jjYz3wrS X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 64.59.136.137) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-5.39 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.94)[-0.940,0]; RCVD_IN_DNSWL_NONE(0.00)[137.136.59.64.list.dnswl.org : 127.0.5.0]; RCPT_COUNT_SEVEN(0.00)[7]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(-2.35)[ip: (-6.03), ipnet: 64.59.128.0/20(-3.17), asn: 6327(-2.46), country: CA(-0.09)]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11, 233.154.66.70.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 20:49:55 -0000 On August 14, 2019 11:04:20 AM PDT, Ian Lepore wrote: >On Wed, 2019-08-14 at 19:55 +0200, Niclas Zeising wrote: >> On 2019-08-14 19:23, Emmanuel Vadot wrote: >> > On Wed, 14 Aug 2019 10:13:48 -0700 >> > John Baldwin wrote: >> >=20 >> > > On 8/14/19 9:22 AM, Ian Lepore wrote: >> > > > This all sounds vaguely wrong, backwards, to me=2E A developer >> > > > who is >> > > > using a given module on their build system might want that >> > > > module to be >> > > > rebuilt automatically, but only if the build parameters match >> > > > those of >> > > > the running build host system=2E >> > > >=20 >> > > > If my build host is running freebsd 12 amd64 and I'm doing a >> > > > build for >> > > > freebsd 13 armv7, I have no interest in automatic rebuilds of >> > > > an amd64 >> > > > driver module for a different OS arch and version just because >> > > > that >> > > > module happens to be installed on the system I use to do >> > > > crossbuilds=2E >> > > >=20 >> > > > My objections are theoretical=2E=2E=2E this automation just seems >> > > > improperly >> > > > designed to me=2E But it won't actually affect me in any way, >> > > > because I >> > > > don't build video driver modules from ports, and I don't run >> > > > freebsd >> > > > current on my build host machine=2E Probably the number of >> > > > people doing >> > > > crossbuilding is small enough that nobody else is going to >> > > > object to >> > > > this "the whole world is amd64" automation=2E >> > >=20 >> > > You assume DRM is amd64-only when it is definitely not=2E It also >> > > has >> > > suitable guards in its Makefile to only build the relevant kernel >> > > modules on supported architectures=2E >> >=20 >> > I clearly don't want to spend time to build the drm and radeon >> > modules >> > when I'm hacking on arm64=2E >> > Shouldn't LOCAL_MODULE have ${TARGET}=2E${TARGET_ARCH} as a >> > subdirectory ? So when you install drm-kmod-* it will only install >> > the >> > source in /usr/local/modules/${TARGET}=2E${TARGET_ARCH}/ ? (or >> > whatever >> > the correct dir is)=2E >> >=20 >>=20 >> I'm not sure what you're trying to accomplish=2E I might be=20 >> misunderstanding completely, but, at least the drm ports have >> safeguards=20 >> in their makefiles so they'll only be built for those arches where >> there=20 >> is support, and only the modules needed, as an example, i915kms=2Eko >> will=20 >> only be built on amd64 and i386, if that's what you're worried about=2E >> Regards > >I can't understand what you guys are not-understanding=2E New machinery >has been added that says "if some module source code exists in this >absolute fixed location on the build machine, then whenever you do any >kernel build for any OS version or any arch, rebuild that module source >code so that the the build machine's video drivers stay in sync with >the build machine's kernel=2E" > >Do you not see that for some of us, only a tiny fraction of the builds >done (maybe none of them at all) involve the kernel for the build host >machine or the video drivers for the build host machine? And yet, for >us, every build we do will now inapppropriately rebuild this video >driver module which has nothing to do with the machine the build is >targeting=2E > >And it's not just about crossbuilds, because it's about versions too=2E= =20 >Even when a developer is running 13-current and wants their video >driver rebuilt and installed automatically along with the kernel, >they're certainly going to want that to happen only when they're >building 13-current=2E If they're doing a test-build for 12-stable they >certainly aren't going to want to build and install that video driver=2E > >-- Ian > >_______________________________________________ >freebsd-current@freebsd=2Eorg mailing list >https://lists=2Efreebsd=2Eorg/mailman/listinfo/freebsd-current >To unsubscribe, send any mail to >"freebsd-current-unsubscribe@freebsd=2Eorg" How about build/install when arch is the same as local machine arch? --=20 Pardon the typos and autocorrect, small keyboard in use=2E Cheers, Cy Schubert FreeBSD UNIX: Web: http://www=2EFreeBSD=2Eorg The need of the many outweighs the greed of the few=2E From owner-freebsd-current@freebsd.org Wed Aug 14 22:40:38 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 780C1BDD13; Wed, 14 Aug 2019 22:40:38 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.netplex.net", Issuer "RapidSSL RSA CA 2018" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4684Kx62HBz45gJ; Wed, 14 Aug 2019 22:40:37 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from [10.237.174.231] (mobile-166-171-186-249.mycingular.net [166.171.186.249]) (authenticated bits=0) by mail.netplex.net (8.15.1/8.15.1/NETPLEX) with ESMTPSA id x7EMeTGa056028 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Aug 2019 18:40:30 -0400 X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.netplex.net [204.213.176.9]); Wed, 14 Aug 2019 18:40:30 -0400 (EDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: HEADSUP: drm-current-kmod now installs sources From: Daniel Eischen X-Mailer: iPhone Mail (16G77) In-Reply-To: Date: Wed, 14 Aug 2019 18:40:28 -0400 Cc: freebsd-current@freebsd.org, x11@freebsd.org, current@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> To: jhb@freebsd.org X-Rspamd-Queue-Id: 4684Kx62HBz45gJ X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.90 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.91)[-0.906,0]; ASN(0.00)[asn:6062, ipnet:204.213.176.0/20, country:US]; NEURAL_HAM_LONG(-1.00)[-0.999,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 22:40:38 -0000 I've lost the original thread, but would the sources in /usr/local/sys/modul= es get built regardless of what MAKEOBJDIRPREFIX is? And, now that sources m= ay be installed by a port, what is the method for _just_ updating the source= s? Why do I even need to build and install the port? Personally, I would j= ust rather have the drm-kmod sources just imported into base and maintained t= here. If I have 2 or more different checked out base src trees, how do I ge= t the correct drm-kmod to go with them if there is only one /usr/local/sys/m= odules? Do I need multiple port trees just to pull in out of tree module so= urces? -- DE= From owner-freebsd-current@freebsd.org Wed Aug 14 22:59:15 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 076AABE645; Wed, 14 Aug 2019 22:59:15 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.95.76.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "troutmask", Issuer "troutmask" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4684lQ66G3z46tg; Wed, 14 Aug 2019 22:59:14 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost [127.0.0.1]) by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id x7EMx68X044605 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 14 Aug 2019 15:59:06 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id x7EMx6H5044604; Wed, 14 Aug 2019 15:59:06 -0700 (PDT) (envelope-from sgk) Date: Wed, 14 Aug 2019 15:59:06 -0700 From: Steve Kargl To: Daniel Eischen Cc: jhb@freebsd.org, freebsd-current@freebsd.org, x11@freebsd.org, current@freebsd.org Subject: Re: HEADSUP: drm-current-kmod now installs sources Message-ID: <20190814225906.GA34583@troutmask.apl.washington.edu> Reply-To: sgk@troutmask.apl.washington.edu References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 4684lQ66G3z46tg X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.90 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.90)[-0.897,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 22:59:15 -0000 On Wed, Aug 14, 2019 at 06:40:28PM -0400, Daniel Eischen wrote: > I've lost the original thread, but would the sources in > /usr/local/sys/modules get built regardless of what > MAKEOBJDIRPREFIX is? And, now that sources may be installed > by a port, what is the method for _just_ updating the sources? > Why do I even need to build and install the port? Personally, > I would just rather have the drm-kmod sources just imported > into base and maintained there. You're joking right? You remember drm and drm2 (aka drm-legacy-kmod). It was working just fine (for some) before its removal. My last panics were caused from forgetting to rebuild drm-legacy-kmod after installing a new kernel/world. -- Steve From owner-freebsd-current@freebsd.org Wed Aug 14 23:07:10 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 28017BECF8; Wed, 14 Aug 2019 23:07:10 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4684wZ0FKCz47fn; Wed, 14 Aug 2019 23:07:10 +0000 (UTC) (envelope-from lwhsu@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1129) id 010AF1EF6F; Wed, 14 Aug 2019 23:07:09 +0000 (UTC) Date: Wed, 14 Aug 2019 23:07:09 +0000 From: Li-Wen Hsu To: freebsd-testing@freebsd.org Cc: freebsd-current@freebsd.org, freebsd-stable@freebsd.org Subject: FreeBSD CI Weekly Report 2019-08-11 Message-ID: <20190814230709.GA89862@freefall.freebsd.org> Reply-To: freebsd-testing@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.11.4 (2019-03-13) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2019 23:07:10 -0000 (Please send the followup to freebsd-testing@ and note Reply-To is set.) FreeBSD CI Weekly Report 2019-08-11 =================================== Here is a summary of the FreeBSD Continuous Integration results for the period from 2019-08-05 to 2019-08-11. During this period, we have: * 2066 builds (91% (-4.8) passed, 9% (4.8) failed) were executed on aarch64, amd64, armv6, armv7, i386, mips, mips64, powerpc, powerpc64, powerpcspe, riscv64, sparc64 architectures for head, stable/12, stable/11 branches. * 343 test runs (85.1% (-2.3) passed, 14.9% (+2.3) unstable) were executed on amd64, i386, riscv64 architectures for head, stable/12, stable/11 branches. * 18 doc builds (100% (+0) passed) Test case status (on 2019-08-11 23:59): | Branch/Architecture | Total | Pass | Fail | Skipped | | ------------------- | ---------- | ---------- | ------- | ------- | | head/amd64 | 7507 (+47) | 7449 (+40) | 0 (0) | 58 (+7) | | head/i386 | 7505 (+47) | 7443 (+43) | 0 (0) | 62 (+4) | | 12-STABLE/amd64 | 7392 (+4) | 7348 (+4) | 0 (0) | 44 (0) | | 12-STABLE/i386 | 7390 (+4) | 7339 (+4) | 0 (0) | 51 (0) | | 11-STABLE/amd64 | 6845 (0) | 6801 (+4) | 0 (-1) | 44 (-3) | | 11-STABLE/i386 | 6843 (0) | 6763 (+3) | 34 (0) | 46 (-3) | (The statistics from experimental jobs are omitted) If any of the issues found by CI are in your area of interest or expertise please investigate the PRs listed below. The latest web version of this report is available at https://hackmd.io/s/HySDseqQB and archive is available at http://hackfoldr.org/freebsd-ci-report/, any help is welcome. ## News * [FCP 20190401-ci_policy: CI policy ](https://github.com/freebsd/fcp/blob/master/fcp-20190401-ci_policy.md) is in "feedback" state, please check and provide comments. * This week we added LINT kernel build job for aarch64: https://ci.freebsd.org/job/FreeBSD-head-aarch64-LINT/ We will add more LINT kernel build jobs for tier2 and tier3 soon. * Total test case number increased a lot by fusefs update in [r350665](https://svnweb.freebsd.org/changeset/base/350665). ## Failing Tests * https://ci.freebsd.org/job/FreeBSD-stable-11-i386-test/ * local.kyua.* (31 cases) * local.lutok.* (3 cases) ## Failing and Flaky Tests (from experimental jobs) * https://ci.freebsd.org/job/FreeBSD-head-amd64-dtrace_test/ * Flakey test case: common.misc.t_dtrace_contrib.tst_dynopt_d https://bugs.freebsd.org/237641 * https://ci.freebsd.org/job/FreeBSD-head-amd64-test_zfs/ * There are ~60 failing cases, including flakey ones, see https://ci.freebsd.org/job/FreeBSD-head-amd64-test_zfs/lastCompletedBuild/testReport/ for more details ## Disabled Tests * lib.libc.sys.mmap_test.mmap_truncate_signal https://bugs.freebsd.org/211924 * sys.fs.tmpfs.mount_test.large https://bugs.freebsd.org/212862 * sys.fs.tmpfs.link_test.kqueue https://bugs.freebsd.org/213662 * sys.kqueue.libkqueue.kqueue_test.main https://bugs.freebsd.org/233586 * sys.kern.ptrace_test.ptrace__PT_KILL_competing_stop https://bugs.freebsd.org/220841 * usr.bin.procstat.procstat_test.command_loogle.com/ine_arguments https://bugs.freebsd.org/233587 * usr.bin.procstat.procstat_test.environment https://bugs.freebsd.org/233588 * lib.libc.regex.exhaust_test.regcomp_too_big (i386 only) https://bugs.freebsd.org/237450 * sys.netinet.socket_afinet.socket_afinet_bind_zero (new) https://bugs.freebsd.org/238781 * sys.netpfil.pf.names.names * sys.netpfil.pf.synproxy.synproxy https://bugs.freebsd.org/238870 * sys.kern.ptrace_test.ptrace__follow_fork_child_detached_unrelated_debugger https://bugs.freebsd.org/239292 * sys.netpfil.pf.forward.v4 (i386 only) * sys.netpfil.pf.forward.v6 (i386 only) * sys.netpfil.pf.set_tos.v4 (i386 only) https://bugs.freebsd.org/239380 * sys.kern.ptrace_test.ptrace__follow_fork_both_attached_unrelated_debugger https://bugs.freebsd.org/239397 * sys.kern.ptrace_test.ptrace__parent_sees_exit_after_child_debugger https://bugs.freebsd.org/239399 * sys.kern.ptrace_test.ptrace__follow_fork_parent_detached_unrelated_debugger https://bugs.freebsd.org/239425 ## Issues ### Cause build fails * https://bugs.freebsd.org/233735 Possible build race: genoffset.o /usr/src/sys/sys/types.h: error: machine/endian.h: No such file or directory * https://bugs.freebsd.org/233769 Possible build race: ld: error: unable to find library -lgcc_s * https://bugs.freebsd.org/238828 Possible build race: lib/libsysdecode/tables.h:948: error: 'IPV6_MIN_MEMBERSHIPS' undeclared Patch available: https://reviews.freebsd.org/D21069 ### Cause kernel panics * https://bugs.freebsd.org/238870 sys.netpfil.pf.names.names and sys.netpfil.pf.synproxy.synproxy cause panic Patch exists: * https://reviews.freebsd.org/D20868 * https://reviews.freebsd.org/D20869 ### Open * https://bugs.freebsd.org/237077 possible race in build: /usr/src/sys/amd64/linux/linux_support.s:38:2: error: expected relocatable expression * https://bugs.freebsd.org/237403 Tests in sys/opencrypto should be converted to Python3 * https://bugs.freebsd.org/237641 Flakey test case: common.misc.t_dtrace_contrib.tst_dynopt_d * https://bugs.freebsd.org/237656 "Freed UMA keg (rtentry) was not empty (18 items). Lost 1 pages of memory." seen when running sys/netipsec tests * https://bugs.freebsd.org/237657 sys.kern.pdeathsig.signal_delivered_ptrace timing out periodically on i386 * https://bugs.freebsd.org/238781 sys.netinet.socket_afinet.socket_afinet_bind_zero does not work when mac_portacl(4) loaded * https://bugs.freebsd.org/239292 Flakey test case: sys.kern.ptrace_test.ptrace__follow_fork_child_detached_unrelated_debugger * https://bugs.freebsd.org/239380 sys.netpfil.pf.forward.{v4,v6} and sys.netpfil.pf.set_tos.v4 fail on i386 * https://bugs.freebsd.org/239397 Flakey test case: sys.kern.ptrace_test.ptrace__follow_fork_both_attached_unrelated_debugger * https://bugs.freebsd.org/239399 Flakey test case: sys.kern.ptrace_test.ptrace__parent_sees_exit_after_child_debugger * https://bugs.freebsd.org/239425 Flakey test case: sys.kern.ptrace_test.ptrace__follow_fork_parent_detached_unrelated_debugger ### Others * [Tickets related to testing@](https://preview.tinyurl.com/y9maauwg) From owner-freebsd-current@freebsd.org Thu Aug 15 00:50:20 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2AD60C11ED for ; Thu, 15 Aug 2019 00:50:20 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic305-21.consmr.mail.gq1.yahoo.com (sonic305-21.consmr.mail.gq1.yahoo.com [98.137.64.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4687Cb12nhz4D4b for ; Thu, 15 Aug 2019 00:50:18 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: yBUEpzUVM1nDtjE53n96ob5wEyQrsBWIacan7rRVf1CrrDSzx4uxB10rrL9F7pC i.JaFpWmEVunTpEiujUNBVqWP7Tba5p5dI5OniGiLpLBqsn9_4QpcSbHV6SbR05QVcqWNs.7WREc 8bRmRLCPzwyfDUScQ5um2G8aYiMSESEEsZ2SxISHT0vB8ns5kNl_kwoGYVoyZzluAoXexEfmzwCj klBoLDGWJVSxDHhFfGAM0fZN1_e6Y0yVVNqCuJ6w8zrVdCZVv.7oW5wTqzCAjNMG3zVuOH..Opkh AUeV32i6EfX21HRf8V9.IbY_BPuR78YWw4SwB9cslZV_ohSnE4dXGer8T73qyIwsYGwufLf2Axhy hdTgjcZ1Ru5z26tktwo4levg_.ubbGlD78xOsexENjLlE4610lLoXN6a2WnUrIOzgEMqVQsO42ET PXWSoRJufHti4s7PBeow51zgdFHS1EcVrJsnWYtFf_dsYjw5oZCe0IzhQ5RPI6kkkGGFJyElXkOs vdqfz1IlQ9Uzqh_Lyb3rxcvF1wJ1noD6QOpHu9RBlJ31PKueXKQU8oPtVCoZ271ouYu2JypBPmgv IDYmahVV1fe_4wB7VUWahKKqGyj7WSWseGUbgJvVSVt8Pddo_C8tza8Lym0Kss_i_F1JRRXXDPVM YvJ56e2ch5_LmlVxyqkYM2lNXiMXRhiipit517STqyabslcAkldOC21ph23Txeas5UqScHcWkZsv DIOn3styuS37JUBzPqZ5waobWGGeE5J97twgI.vH6W2QH5RUrv5h9SGzvH5IkjBTao4jQhK3aSdt HsMKJ.EcLUUILFfpQ_ausVv_7EP8SQMDBcJzdWHYxSPXQ.y8D3PYOZjdA1WCkisthLhF9ytAPwrq 3QKTbSWtw0NKT1xJPgVu3JYzYChiFzH5qT8EFGNu37x_z34M7wsCnmiC8FSTCcMb2ojrZSQWPleR sPBwV4gfGVYUxkzZO2NyJqiWW05p8VOtFtERLUqgpDj9vO4dk2GpLkcncQL_PD3zytFGtwBvANj. BQIIyCm1BxmOEv07RQwB0vH0JRfMSnqJbyZyO1tnfa18zhU.1QVHFm33A0ux9JSOfFxjvKvieTvX WYr56INX361w0uBtov8ZD1.yB.BAN.rbKH2qaB56rQd_P3GojJvZWq1j_RrvF8JZ81D9fB0wTBJ6 HZfkZhUHj30Wv8GBKzHYnIpEAsy18LfjEo.ANYL7LaXSUn3RvOAe7Sg3IM3fVKOgREMiiDSv77d4 nXJbWvrI- Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.gq1.yahoo.com with HTTP; Thu, 15 Aug 2019 00:50:17 +0000 Received: by smtp424.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 7b97c16bc29c4b81ec0c9212bb3d2886; Thu, 15 Aug 2019 00:50:15 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: head -r351056 self-hosted amd64 installworld fails with: "don't know how to make _testsDATA_FILESINS1_data/md5test-in. Stop" Message-Id: <10AA93AA-4FD7-47AF-BFD1-994AC5A8CC83@yahoo.com> Date: Wed, 14 Aug 2019 17:50:14 -0700 To: freebsd-current@freebsd.org X-Mailer: Apple Mail (2.3445.104.11) X-Rspamd-Queue-Id: 4687Cb12nhz4D4b X-Spamd-Bar: / X-Spamd-Result: default: False [-0.82 / 15.00]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; FREEMAIL_FROM(0.00)[yahoo.com]; TO_DN_NONE(0.00)[]; MV_CASE(0.50)[]; DKIM_TRACE(0.00)[yahoo.com:+]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.46)[-0.460,0]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.64)[-0.640,0]; MIME_GOOD(-0.10)[text/plain]; NEURAL_SPAM_SHORT(0.78)[0.782,0]; IP_SCORE_FREEMAIL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(0.00)[ip: (7.05), ipnet: 98.137.64.0/21(0.91), asn: 36647(0.73), country: US(-0.05)]; RCVD_IN_DNSWL_NONE(0.00)[84.64.137.98.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Aug 2019 00:50:20 -0000 While the buildworld buildkernel seemed to go okay, and so did = installkernel, installworld is failing with: =3D=3D=3D> lib/libc/tests/hash (install) install -o root -g wheel -m 555 hash_test = /usr/tests/lib/libc/hash/hash_test make[7]: don't know how to make _testsDATA_FILESINS1_data/md5test-in. = Stop make[7]: stopped in /usr/src/lib/libc/tests/hash *** Error code 2 The original context was -r350364 . =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-current@freebsd.org Thu Aug 15 00:55:24 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ACCC8C16AD; Thu, 15 Aug 2019 00:55:24 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.netplex.net", Issuer "RapidSSL RSA CA 2018" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4687KS2XMrz4DY6; Thu, 15 Aug 2019 00:55:24 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from [10.237.174.231] (mobile-166-171-186-249.mycingular.net [166.171.186.249]) (authenticated bits=0) by mail.netplex.net (8.15.1/8.15.1/NETPLEX) with ESMTPSA id x7F0tLKW025661 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 14 Aug 2019 20:55:22 -0400 X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.netplex.net [204.213.176.9]); Wed, 14 Aug 2019 20:55:23 -0400 (EDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: HEADSUP: drm-current-kmod now installs sources From: Daniel Eischen X-Mailer: iPhone Mail (16G77) In-Reply-To: <20190814225906.GA34583@troutmask.apl.washington.edu> Date: Wed, 14 Aug 2019 20:55:21 -0400 Cc: jhb@freebsd.org, freebsd-current@freebsd.org, x11@freebsd.org, current@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> <20190814225906.GA34583@troutmask.apl.washington.edu> To: sgk@troutmask.apl.washington.edu X-Rspamd-Queue-Id: 4687KS2XMrz4DY6 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-2.90 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.90)[-0.905,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; ASN(0.00)[asn:6062, ipnet:204.213.176.0/20, country:US] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Aug 2019 00:55:24 -0000 > On Aug 14, 2019, at 6:59 PM, Steve Kargl wrote: >=20 >> On Wed, Aug 14, 2019 at 06:40:28PM -0400, Daniel Eischen wrote: >> I've lost the original thread, but would the sources in >> /usr/local/sys/modules get built regardless of what >> MAKEOBJDIRPREFIX is? And, now that sources may be installed >> by a port, what is the method for _just_ updating the sources? >> Why do I even need to build and install the port? Personally, >> I would just rather have the drm-kmod sources just imported >> into base and maintained there. >=20 > You're joking right? =20 Not fully, no. > You remember drm and drm2 (aka drm-legacy-kmod).=20 Yes, I remember them. -- DE= From owner-freebsd-current@freebsd.org Thu Aug 15 04:16:18 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EAC89C618A for ; Thu, 15 Aug 2019 04:16:18 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 468CnF2x0Mz4Nft; Thu, 15 Aug 2019 04:16:16 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id y7BLh2UyySrVcy7BNhAnaD; Wed, 14 Aug 2019 22:16:14 -0600 X-Authority-Analysis: v=2.3 cv=L5ZjvNb8 c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=FmdZ9Uzk2mMA:10 a=CjxXgO3LAAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=bOBJMa80hsn8v-GN_v8A:9 a=CjuIK1q_8ugA:10 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id CB90512CE; Wed, 14 Aug 2019 21:16:06 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x7F4G5X5012651; Wed, 14 Aug 2019 21:16:05 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x7F4FwH8012344; Wed, 14 Aug 2019 21:16:05 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201908150416.x7F4FwH8012344@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Mark Millard , "Simon J. Gerraty" cc: freebsd-current@freebsd.org Subject: Re: head -r351056 self-hosted amd64 installworld fails with: "don't know how to make _testsDATA_FILESINS1_data/md5test-in. Stop" In-reply-to: <10AA93AA-4FD7-47AF-BFD1-994AC5A8CC83@yahoo.com> References: <10AA93AA-4FD7-47AF-BFD1-994AC5A8CC83@yahoo.com> Comments: In-reply-to Mark Millard message dated "Wed, 14 Aug 2019 17:50:14 -0700." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 14 Aug 2019 21:15:58 -0700 X-CMAE-Envelope: MS4wfDMQHPtq+dQcDR461Vd+s3i6CoI7w3axVcD/qH/na9wXdYPltvEO3R2rtferpph4Lr5M52JLxzcKknun5ifQaVLMie6iWHeUAV7eQEfGRV0QdQ6Ds5qI HLD4FQrtAd3qUCYEQCe79MmbnOVLypUIyGguTfg1iZxx0/MwxmQ2b9Km3HHMW1ezOT9FwjQA8UeFY8lOiiU2xZfYgh5mmseifxZI+YCDBY8+pMfR63I7I0p4 DbBUfb2DLqKYHJ3zQ59PQw== X-Rspamd-Queue-Id: 468CnF2x0Mz4Nft X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 64.59.136.139) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-4.86 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLYTO_EQ_FROM(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.971,0]; RCVD_IN_DNSWL_NONE(0.00)[139.136.59.64.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[yahoo.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-2.29)[ip: (-5.75), ipnet: 64.59.128.0/20(-3.16), asn: 6327(-2.46), country: CA(-0.09)]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Aug 2019 04:16:19 -0000 In message <10AA93AA-4FD7-47AF-BFD1-994AC5A8CC83@yahoo.com>, Mark Millard write s: > While the buildworld buildkernel seemed to go okay, and so did installkernel, > installworld is failing with: > > ===> lib/libc/tests/hash (install) > install -o root -g wheel -m 555 hash_test /usr/tests/lib/libc/hash/hash_t > est > make[7]: don't know how to make _testsDATA_FILESINS1_data/md5test-in. Stop > > make[7]: stopped in /usr/src/lib/libc/tests/hash > *** Error code 2 > > The original context was -r350364 . Revert r351055 and installworld complete for now. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few. From owner-freebsd-current@freebsd.org Thu Aug 15 05:58:08 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 88E22C80E3 for ; Thu, 15 Aug 2019 05:58:08 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from mx0b-00273201.pphosted.com (mx0b-00273201.pphosted.com [67.231.152.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.pphosted.com", Issuer "Thawte RSA CA 2018" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 468G2l4ChSz4ST0 for ; Thu, 15 Aug 2019 05:58:07 +0000 (UTC) (envelope-from sjg@juniper.net) Received: from pps.filterd (m0108160.ppops.net [127.0.0.1]) by mx0b-00273201.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x7F5rwqm021515; Wed, 14 Aug 2019 22:58:01 -0700 Received: from nam04-co1-obe.outbound.protection.outlook.com (mail-co1nam04lp2056.outbound.protection.outlook.com [104.47.45.56]) by mx0b-00273201.pphosted.com with ESMTP id 2ucwp588yg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 14 Aug 2019 22:58:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GLVXFbmWDdLq00j6hosNdhatrTA1IvX1yfUkw2QtVfcKK+Ii3/VtrTOFBZzX/21/Y/l70++BALnRjmRJ7x2Peb9c4/YIcJW+dF9A6QakMheNR5dezefv8PVkzDcMVd3SDdZKkWdQnKiCJkE8Jo0icwyrOL7+hDQK6qVWMU4TTN4khFsS3ByqXS9wFLQj/QIWc2M97iQDGRt/wm/n5JsI+CkmfZL5+oH35s4+3v2UWtqc3LfMq+1wGq8nhTlOZx1ng9lN/XpTl1huCAP/AtXl4/mIWy+PK5fdrIlo4xbXVqQ6izFAQQiBKL0ESExgRevxBytJB/Ce5OTFYY8tRB7E3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CHKbPgLjYJZ5HsivkQzXQ3/DzzLNzpME5n0m37Njt8A=; b=HVda6+7dOeLEraRuRgdXHLEcIgJtzi81nXOlHIB+6iqXWvzRibCf8jFaXZw/jdtoZIgnfFxyIEySEWtWD29Hxuxl98cU6lDWui44n/lXtC6aOrhB/taWOIF8fAPpMMFh3xPy2LYnWKF82GfU/rLzifr78k00i6L/2H5970098Id7463fpFKBzqWYXB5wDYsZ1XeCodFm89APz0CBftdIAI5NOfXRh5CgwKIL4J6im31MqLPLBE2kjrMAsYYwB3aAni/NwHm+H3kth9GzrZpfqEhf8M2aKnCBW8+oe4TujCkUeVWVaU63zRbad0d9UFRTpxTC3wfxZflgISwH6l6q1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 66.129.239.12) smtp.rcpttodomain=cschubert.com smtp.mailfrom=juniper.net; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=juniper.net; dkim=none (message not signed); arc=none Received: from CH2PR05CA0038.namprd05.prod.outlook.com (2603:10b6:610:38::15) by BL0PR05MB5618.namprd05.prod.outlook.com (2603:10b6:208:6c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.14; Thu, 15 Aug 2019 05:57:59 +0000 Received: from BY2NAM05FT032.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e52::206) by CH2PR05CA0038.outlook.office365.com (2603:10b6:610:38::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2199.6 via Frontend Transport; Thu, 15 Aug 2019 05:57:58 +0000 Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.12 as permitted sender) Received: from P-EXFEND-EQX-01.jnpr.net (66.129.239.12) by BY2NAM05FT032.mail.protection.outlook.com (10.152.100.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2199.6 via Frontend Transport; Thu, 15 Aug 2019 05:57:58 +0000 Received: from P-EXBEND-EQX-02.jnpr.net (10.104.8.53) by P-EXFEND-EQX-01.jnpr.net (10.104.8.54) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 14 Aug 2019 22:57:57 -0700 Received: from p-mailhub01.juniper.net (10.104.20.6) by P-EXBEND-EQX-02.jnpr.net (10.104.8.53) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 14 Aug 2019 22:57:57 -0700 Received: from kaos.jnpr.net (kaos.jnpr.net [172.23.50.162]) by p-mailhub01.juniper.net (8.14.4/8.11.3) with ESMTP id x7F5vu99030168; Wed, 14 Aug 2019 22:57:57 -0700 (envelope-from sjg@juniper.net) Received: by kaos.jnpr.net (Postfix, from userid 1377) id C240A3C007; Wed, 14 Aug 2019 22:57:56 -0700 (PDT) Received: from kaos.jnpr.net (localhost [127.0.0.1]) by kaos.jnpr.net (Postfix) with ESMTP id C099C3C006; Wed, 14 Aug 2019 22:57:56 -0700 (PDT) To: Cy Schubert CC: Mark Millard , , Subject: Re: head -r351056 self-hosted amd64 installworld fails with: "don't know how to make _testsDATA_FILESINS1_data/md5test-in. Stop" In-Reply-To: <201908150416.x7F4FwH8012344@slippy.cwsent.com> References: <10AA93AA-4FD7-47AF-BFD1-994AC5A8CC83@yahoo.com> <201908150416.x7F4FwH8012344@slippy.cwsent.com> Comments: In-reply-to: Cy Schubert message dated "Wed, 14 Aug 2019 21:15:58 -0700." From: "Simon J. Gerraty" X-Mailer: MH-E 8.6+git; nmh 1.7.1; GNU Emacs 26.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <5928.1565848676.1@kaos.jnpr.net> Content-Transfer-Encoding: quoted-printable Date: Wed, 14 Aug 2019 22:57:56 -0700 Message-ID: <8389.1565848676@kaos.jnpr.net> X-EXCLAIMER-MD-CONFIG: e3cb0ff2-54e7-4646-8a04-0dae4ac7b136 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:66.129.239.12; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(4636009)(39860400002)(136003)(346002)(396003)(376002)(2980300002)(199004)(189003)(316002)(81156014)(54906003)(81166006)(486006)(8676002)(186003)(47776003)(4744005)(305945005)(53416004)(70586007)(70206006)(76176011)(446003)(9686003)(476003)(2906002)(478600001)(126002)(7126003)(11346002)(7696005)(229853002)(336012)(55016002)(26005)(6916009)(23726003)(97876018)(50226002)(356004)(76506006)(97756001)(8746002)(50466002)(107886003)(6246003)(5660300002)(4326008)(53936002)(46406003)(8936002)(86362001)(6266002)(117636001); DIR:OUT; SFP:1102; SCL:1; SRVR:BL0PR05MB5618; H:P-EXFEND-EQX-01.jnpr.net; FPR:; SPF:SoftFail; LANG:en; PTR:InfoDomainNonexistent; A:1; MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 395eb44d-4523-47f3-a1a8-08d72145862a X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(4710121)(4711136)(1401327)(2017052603328); SRVR:BL0PR05MB5618; X-MS-TrafficTypeDiagnostic: BL0PR05MB5618: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:655; X-Forefront-PRVS: 01304918F3 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: DYjfpLV8lhsVdW1cn5rzz+bMuBcM1Z3T8Sg9SJ3oI1a85GTsYZi1Ni9MRFxSvM4Hyx6OZJs1HOS1yged5RedxoDjqrqBg9fSy80nT13Me8uJpNx9d/ts1rkHAMSJaC/mu+rc4jBvWZuXhic/0NakARQH2USc+0J/5cpdxH0HoZEzwDxTYOZ2HrF+CwXaI9EAxHpkRNyKNboL+/9MEMZN9szqh1djzFYzoBybXN+oOQ2ZpBzrekKKqe7EYD0q9brumx2ZFTNPliLb/hTSTp1cYO/aW5jc3NDcQ6TfYs9gkaGywpUZAr2fx6Odz0rTtxWBnm+u1L3vUeD3LUdPsUehU5b/vDwx+6Zi2rKMxwnn0Qi9WhGaO+ywme4pL62Z50+vdPHQl6lFsAo7u5I+RZ8HcCRGXO2cV9pponTzNc77DmA= X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Aug 2019 05:57:58.3335 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 395eb44d-4523-47f3-a1a8-08d72145862a X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.12]; Helo=[P-EXFEND-EQX-01.jnpr.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR05MB5618 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-08-15_02:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_spam_notspam policy=outbound_spam score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=703 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908150061 X-Rspamd-Queue-Id: 468G2l4ChSz4ST0 X-Spamd-Bar: ----- X-Spamd-Result: default: False [-5.45 / 15.00]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[juniper.net:s=PPS1017]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:67.231.152.164]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(-0.39)[ip: (-0.86), ipnet: 67.231.152.0/24(-0.34), asn: 22843(-0.70), country: US(-0.05)]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[juniper.net:+]; DMARC_POLICY_ALLOW(-0.50)[juniper.net,reject]; NEURAL_HAM_SHORT(-0.96)[-0.962,0]; RCVD_IN_DNSWL_LOW(-0.10)[164.152.231.67.list.dnswl.org : 127.0.3.1]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:22843, ipnet:67.231.152.0/24, country:US]; ARC_ALLOW(-1.00)[i=1]; RCVD_COUNT_SEVEN(0.00)[10]; FREEMAIL_CC(0.00)[yahoo.com] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Aug 2019 05:58:08 -0000 Cy Schubert wrote: > > installworld is failing with:=0D > >=0D > > =3D=3D=3D> lib/libc/tests/hash (install)=0D > > install -o root -g wheel -m 555 hash_test /usr/tests/lib/libc/hash= /hash_t=0D > > est=0D > > make[7]: don't know how to make _testsDATA_FILESINS1_data/md5test-in. = Stop=0D Sorry about that. Looks like more extensive fix is needed. > Revert r351055 and installworld complete for now.=0D From owner-freebsd-current@freebsd.org Thu Aug 15 16:21:49 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8F0C4ADDB1 for ; Thu, 15 Aug 2019 16:21:49 +0000 (UTC) (envelope-from sef@kithrup.com) Received: from kithrup.com (kithrup.com [96.79.110.97]) by mx1.freebsd.org (Postfix) with ESMTP id 468WtN56gVz42pJ for ; Thu, 15 Aug 2019 16:21:48 +0000 (UTC) (envelope-from sef@kithrup.com) Received: by kithrup.com (Postfix, from userid 1001) id 8E26A1B64B; Thu, 15 Aug 2019 09:21:47 -0700 (PDT) To: freebsd-current@freebsd.org Subject: Can't boot current under bhyve on current Message-Id: <20190815162147.8E26A1B64B@kithrup.com> Date: Thu, 15 Aug 2019 09:21:47 -0700 (PDT) From: Sean Eric Fagan X-Rspamd-Queue-Id: 468WtN56gVz42pJ X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of sef@kithrup.com designates 96.79.110.97 as permitted sender) smtp.mailfrom=sef@kithrup.com X-Spamd-Result: default: False [-5.40 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+a]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[kithrup.com]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(-2.10)[ip: (-7.00), ipnet: 96.64.0.0/11(-3.59), asn: 7922(0.13), country: US(-0.05)]; NEURAL_HAM_SHORT(-0.99)[-0.993,0]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7922, ipnet:96.64.0.0/11, country:US]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Aug 2019 16:21:49 -0000 I get: Loading kernel... /boot/kernel/kernel text=0x16c493c data=0x1c8b38+0x819238 syms=[0x8+0x180c18+0x8+0x19df0b] Loading configured modules... can't find '/boot/entropy' \ Note that I am using vm-bhyve as a management & control wrapper, so that was done by doing vm create VM-TEST ; vm install VM-TEST 13.0.iso Sean. From owner-freebsd-current@freebsd.org Thu Aug 15 16:48:28 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8A03FAE7A9 for ; Thu, 15 Aug 2019 16:48:28 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 468XT829qKz44RD for ; Thu, 15 Aug 2019 16:48:28 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id 48C2EAE7A7; Thu, 15 Aug 2019 16:48:28 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 48826AE7A5 for ; Thu, 15 Aug 2019 16:48:28 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 468XT72223z44RC for ; Thu, 15 Aug 2019 16:48:26 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x7FGmFig019961 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO) for ; Thu, 15 Aug 2019 19:48:18 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x7FGmFig019961 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x7FGmFmc019960 for current@freebsd.org; Thu, 15 Aug 2019 19:48:15 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 15 Aug 2019 19:48:15 +0300 From: Konstantin Belousov To: current@freebsd.org Subject: Stop installing /usr/bin/clang Message-ID: <20190815164815.GK2738@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.12.1 (2019-06-15) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-Rspamd-Queue-Id: 468XT72223z44RC X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com X-Spamd-Result: default: False [-2.98 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[current@freebsd.org]; HAS_XAW(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE_FREEMAIL(0.00)[]; TO_DN_NONE(0.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.976,0]; IP_SCORE(0.00)[ip: (-2.61), ipnet: 2001:470::/32(-4.47), asn: 6939(-3.04), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; FREEMAIL_ENVFROM(0.00)[gmail.com]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Aug 2019 16:48:28 -0000 Please look at https://reviews.freebsd.org/D21060 I propose to stop installing /usr/bin/clang, clang++, clang-cpp. It probably does not matter when all your software comes from ports or packages, but is actually very annoying when developing on FreeBSD. In particular, you never know which `clang' is called in the user environment, because it depends on the $PATH elements ordering. To clear some confusion: this has nothing to do with not installing compiler from base, /usr/bin/c{c,++,pp} are still there after the change is applied. It only to make clang on par with gcc, and to remove one thing that was quite time-consuming in multi-target environment for me during porting something large in FreeBSD userspace. From owner-freebsd-current@freebsd.org Thu Aug 15 17:00:25 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 139EDAED30 for ; Thu, 15 Aug 2019 17:00:25 +0000 (UTC) (envelope-from grahamperrin@gmail.com) Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 468Xkw0Dgnz45Km for ; Thu, 15 Aug 2019 17:00:23 +0000 (UTC) (envelope-from grahamperrin@gmail.com) Received: by mail-wr1-x42e.google.com with SMTP id s18so2062503wrn.1 for ; Thu, 15 Aug 2019 10:00:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=nGRYEdt/yvUCjnyg5vMsRQ5MI3N62QYyr+/17ElzMZg=; b=rkK0UA3J6LifoXrl+AnTMfyxTPaAoL4G91jCBKBBMJoCWi3ccQGxv5T31jij8+zlAR aF0gcopa7l2WSQ64UMJ5yS7g5ije7Ui5CmkVnGjTL/Hm0jIiOZQRzFBL0EBa2a2VQn+I 6hGX4GkgUiuJqiNycl9327g6DhgArtgYCfyVkbtDRqQ8HA4gYic4hNW8TYRKOmaRqlR3 PVnjkqXd7t/MCcAAw6rbyOIz7WK0EbbF2+UQe2/Z7gG9UIOsu6F57q68xOKePLuOejid svWa+jO6ZFl0sesQ+MDEjquxRamIVi+GrzlkhC0wJmP+fmMH1wj3UyqG1wTeZ2cnPD7J gzDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-transfer-encoding:content-language; bh=nGRYEdt/yvUCjnyg5vMsRQ5MI3N62QYyr+/17ElzMZg=; b=d1LyljfMrprunxps4SUb2kbnzUeEikcw70aN021hF06FbLq+mCGZmZPmkH5F+IsXwJ G9iHUXJo+5+F6BwqfRIFiq5mO4aDLAo9mLz9/pHoiYSiXeCzCpZiYyWyCrS9Krq+FJLY FWX+RfZTQdC6bHdnGgvb5nfHBATewUun3F+QRFYSpeVyELg6DtUdzadHCUqrjkccoBtO n+sIm/6ZG/VyiY3cdRbxloU78C2DejxUeBiXRYapP+k9C8182oJLHNGXh6FrDfl97Y4p JzUa4TG8JHhYbmS83/oW46t1E25jaeGt4mxIT2qoNtvGJd7V4Ha8omwFbHejTnpJplln 5oeg== X-Gm-Message-State: APjAAAXYU8DsZ7WiKTsf4116JO71UtXYgEQRsCI9QvMVV5BWEHrXcAgb 910rVbC+eerkhNGwBG1HgSeBbFgP6SE= X-Google-Smtp-Source: APXvYqwzt9Gewpi0BtyCuQTc7SlxcTrYKIl3gCj6kPOZ/lVfAWIu0VM/c6/AY9paUyqHL92l44G27A== X-Received: by 2002:adf:e710:: with SMTP id c16mr6698523wrm.292.1565888421484; Thu, 15 Aug 2019 10:00:21 -0700 (PDT) Received: from [192.168.1.7] ([79.66.151.94]) by smtp.gmail.com with ESMTPSA id b2sm7081144wrf.94.2019.08.15.10.00.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Aug 2019 10:00:20 -0700 (PDT) To: freebsd-current From: Graham Perrin Subject: =?UTF-8?Q?r351066_lib/libc/tests/hash_=28install=29_=e2=80=a6_don?= =?UTF-8?Q?=27t_know_how_to_make_=5ftestsDATA=5fFILESINS1=5fdata/md5test-in?= Message-ID: Date: Thu, 15 Aug 2019 18:00:17 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Rspamd-Queue-Id: 468Xkw0Dgnz45Km X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=rkK0UA3J; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of grahamperrin@gmail.com designates 2a00:1450:4864:20::42e as permitted sender) smtp.mailfrom=grahamperrin@gmail.com X-Spamd-Result: default: False [-4.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-0.997,0]; RECEIVED_SPAMHAUS_PBL(0.00)[94.151.66.79.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(0.00)[ip: (-9.15), ipnet: 2a00:1450::/32(-3.03), asn: 15169(-2.38), country: US(-0.05)]; RCVD_IN_DNSWL_NONE(0.00)[e.2.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Aug 2019 17:00:25 -0000 Whilst running make installworld && etcupdate … ===> lib/libc/tests/hash (install) install  -o root  -g wheel -m 555  hash_test /usr/tests/lib/libc/hash/hash_test make[7]: don't know how to make _testsDATA_FILESINS1_data/md5test-in. Stop … Photo: make.conf: PORTS_MODULES= graphics/gpu-firmware-kmod graphics/drm-legacy-kmod emulators/virtualbox-ose-kmod DEFAULT_VERSIONS+=samba=4.8 # # WITHOUT_LLVM_TARGET_AARCH64= # WITHOUT_LLVM_TARGET_ARM= # WITHOUT_LLVM_TARGET_MIPS= # WITHOUT_LLVM_TARGET_POWERPC= # WITHOUT_LLVM_TARGET_SPARC= # WITHOUT_LLVM_TARGET_X86= # WITHOUT_LLVM_TARGET_ALL= # ... mesa-dri doesn't use LLVM_DEFAULT. Set # in your make.conf if you want it to use LLVM_DEFAULT at your own risk. MESA_LLVM_VER=${LLVM_DEFAULT} DEFAULT_VERSIONS+=llvm=90 From owner-freebsd-current@freebsd.org Thu Aug 15 17:07:36 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 44314AF354 for ; Thu, 15 Aug 2019 17:07:36 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 468XvD12VZz46Ld; Thu, 15 Aug 2019 17:07:36 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Received: from freefall.freebsd.org (static-71-168-218-4.cmdnnj.fios.verizon.net [71.168.218.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jkim/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id ED9E64E60; Thu, 15 Aug 2019 17:07:35 +0000 (UTC) (envelope-from jkim@FreeBSD.org) Subject: =?UTF-8?Q?Re=3a_r351066_lib/libc/tests/hash_=28install=29_=e2=80=a6?= =?UTF-8?Q?_don=27t_know_how_to_make_=5ftestsDATA=5fFILESINS1=5fdata/md5test?= =?UTF-8?Q?-in?= To: Graham Perrin , freebsd-current References: From: Jung-uk Kim Autocrypt: addr=jkim@FreeBSD.org; prefer-encrypt=mutual; keydata= mQENBFJBztUBCAChqNyGqmFuNo0U7MBzsD+q/G6Cv0l7LGVrOAsgh34M8wIWhD+tztDWMVfn AhxNDd0ceCj2bYOe67sTQxAScEcbt2FfvPOLp9MEXb9qohZj172Gwkk7dnhOhZZKhVGVZKM4 NcsuBDUzgf4f3Vdzj4wg6WlqplnTZo8lPE4hZWvZHoFIyunPTJWenybeV1xnxK7JkUdSvQR0 fA59RfTTECMwTrSEfYGUnxIDBraxJ7Ecs/0hGQ7sljIj8WBvlRDU5fU1xfF35aw56T8POQRq F4E6RVJW3YGuTpSwgtGZOTfygcLRhAiq3dFC3JNLaTVTpM8PjOinJyt9AU6RoITGOKwDABEB AAG0Hkp1bmctdWsgS2ltIDxqa2ltQEZyZWVCU0Qub3JnPokBPQQTAQoAJwUCUkHO1QIbAwUJ E0/POwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRB8n5Ym/NvxRqyzB/wL7QtsIpeGfGIA ZPMtgXMucM3NWzomyQMln2j2efUkDKthzh9jBxgF53TjOr7imwIt0PT2k1bqctPrq5IRqnu9 mGroqaCLE3LG2/E3jEaao4k9PO6efwlioyivUo5NrqIQOQ4k3EAXw7d2y0Dk1VpTgdMrnUAB hj7lGlLqS4ydcrf24DdbCRGdEQwqd9DBeBgbWynxAJMgbZBhYVEyIHuQKkJ8qY0ibIPXXuF0 KYDeH0qUHtWV2K3srNyPtymUkBQD84Pl1GWRYx05XdUHDmnX0JV3lg0BfYJZgZv0ehPQrMfY Fd9abTkf9FHQYz1JtsC8wUuRgqElRd6+YAGf8Tt9uQENBFJBztUBCADLtSrP44El2VoJmH14 OFrlOgxzZnbn+Y/Gf1k12mJBiR+A+pBeRLD50p7AiTrjHRxO3cHcl9Dh0uf1VSbXgp8Or0ye iP/86fZPd4k5HXNmDTLL0HecPE08SCqGZ0W8vllQrokB1QxxRUB+fFMPJyMCjDAZ7P9fFTOS dTw1bJSTtOD8Sx8MpZUa9ti06bXFlVYDlaqSdgk181SSx+ZbSKkQR8CIMARlHwiLsa3Z9q9O EJr20HPyxe0AlTvwvFndH61hg7ds63eRvglwRnNON28VXO/lvKXq7Br/CiiyhFdKfINIx2Z5 htYq22tgGTW7mBURbIKoECFBTX9Lv6BXz6w9ABEBAAGJASUEGAEKAA8FAlJBztUCGwwFCRNP zzsACgkQfJ+WJvzb8UZcJQf+IsTCxUEqY7W/pT84sMg5/QD3s6ufTRncvq14fEOxCNq1Rf4Q 9P+tOFa8GZfKDGB2BFGIrW7uT5mlmKdK1vO6ZIA930y5kUsnCmBUEBJkE2ciSQk01aB/1o62 Q3Gk/F6BwtNY9OXiqF7AcAo+K/BMIaqb26QKeh+IIgK1NN9dQiq3ByTbl4zpGZa6MmsnnRTu mzGKt2nkz7vBzH6+hZp1OzGZikgjjhYWVFoJo1dvf/rv4obs0ZJEqFPQs/1Qa1dbkKBv6odB XJpPH0ssOluTY24d1XxTiKTwmWvHeQkOKRAIfD7VTtF4TesoZYkf7hsh3e3VwXhptSLFnEOi WwYofg== Message-ID: Date: Thu, 15 Aug 2019 13:07:28 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="43Qt9PxRGigVuFLYLIXG9RklRijHcFB7B" X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Aug 2019 17:07:36 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --43Qt9PxRGigVuFLYLIXG9RklRijHcFB7B Content-Type: multipart/mixed; boundary="WxPW9WR72zkZ7KIXgBKNTLRXX9q2HyQRb"; protected-headers="v1" From: Jung-uk Kim To: Graham Perrin , freebsd-current Message-ID: Subject: =?UTF-8?Q?Re=3a_r351066_lib/libc/tests/hash_=28install=29_=e2=80=a6?= =?UTF-8?Q?_don=27t_know_how_to_make_=5ftestsDATA=5fFILESINS1=5fdata/md5test?= =?UTF-8?Q?-in?= References: In-Reply-To: --WxPW9WR72zkZ7KIXgBKNTLRXX9q2HyQRb Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 19. 8. 15., Graham Perrin wrote: > Whilst running > make installworld && etcupdate >=20 > =E2=80=A6 > =3D=3D=3D> lib/libc/tests/hash (install) > install=C2=A0 -o root=C2=A0 -g wheel -m 555=C2=A0 hash_test > /usr/tests/lib/libc/hash/hash_test > make[7]: don't know how to make _testsDATA_FILESINS1_data/md5test-in. S= top > =E2=80=A6 >=20 > Photo: >=20 > make.conf: >=20 > PORTS_MODULES=3D graphics/gpu-firmware-kmod graphics/drm-legacy-kmod > emulators/virtualbox-ose-kmod > DEFAULT_VERSIONS+=3Dsamba=3D4.8 > # > >=20 > # WITHOUT_LLVM_TARGET_AARCH64=3D > # WITHOUT_LLVM_TARGET_ARM=3D > # WITHOUT_LLVM_TARGET_MIPS=3D > # WITHOUT_LLVM_TARGET_POWERPC=3D > # WITHOUT_LLVM_TARGET_SPARC=3D > # WITHOUT_LLVM_TARGET_X86=3D > # > >=20 > WITHOUT_LLVM_TARGET_ALL=3D > # ... mesa-dri doesn't use LLVM_DEFAULT. Set > > # in your make.conf if you want it to use LLVM_DEFAULT at your own risk= =2E > MESA_LLVM_VER=3D${LLVM_DEFAULT} > > DEFAULT_VERSIONS+=3Dllvm=3D90 I believe r351055 was the culprit. https://svnweb.freebsd.org/changeset/base/351055 Note r351067 reverted it. https://svnweb.freebsd.org/changeset/base/351067 Jung-uk Kim --WxPW9WR72zkZ7KIXgBKNTLRXX9q2HyQRb-- --43Qt9PxRGigVuFLYLIXG9RklRijHcFB7B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEl1bqgKaRyqfWXu/CfJ+WJvzb8UYFAl1VkVcACgkQfJ+WJvzb 8UY6qAf/YvHK7PU6AUhWUqKn/mGgpdH/E4X8CUfOfVQvQ9pert7mVxIvQkRmKzul GkEMCBhZNKrMJrhOtHX2Dh8vQdGlXw5YOI+4gRudT/E5o26sf/YcE1ex0V0h9t9O kc7KNts2MZdnKqfLaAW8VGCr/qVolHIRQYuz0dQzrj8pv97DD3QBeY1egzt9WCSf 9ZCagiB5PIRS4lCv9W004yUH1XXpMalCE1LlAPqPglFFQvZ6z0OsMgQLQzjpHb/r jXn/EzfuizPvaprQm0S4jL3H1KBcrZqcU22i+gGXSOp48HE9rby4ahkILRjXYzO1 ROqi2IzLAWrQkwB/QrAty7IuksGW3A== =+FX0 -----END PGP SIGNATURE----- --43Qt9PxRGigVuFLYLIXG9RklRijHcFB7B-- From owner-freebsd-current@freebsd.org Thu Aug 15 19:34:34 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4D1E1B4299 for ; Thu, 15 Aug 2019 19:34:34 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic301-3.consmr.mail.bf2.yahoo.com (sonic301-3.consmr.mail.bf2.yahoo.com [74.6.129.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 468c8n1wgWz4L9Z for ; Thu, 15 Aug 2019 19:34:33 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: 030GXngVM1n_Vr0nlvC0LzKLnUC.nErm0CjaGyBZtHn1LEGiqhBg74qbzVfQ72x Xha2eGhtbebjUX83wVo21U8Hyzxj40VicTkbenZ.Adywaa4uTkvSNY1_ofRiGDDyfJ__pJNpL8ii 2vRpCB70Amoipg5BmWXOdEMwzKOOYiVvHlSVDhXKBuqqo9MixUp.XzsUvuWzlxKJQLrBG7pdpqnS 8pdtR53B_9AuBqd2EaeYWeBvwFDGkkljCGApdG8iZ1r8mkscZGa8qfkYICCcKEgpi4yOUN7e6X9W TRXA5UeyhZYxX8JrApZ34HnewBtvPCFdQFxBrbAorEpkK1kFgHdPhrRTW_ut6vC_ITm_C8qCrnE2 _nB9f.ClUjdrECt3AaRLq0iHKtBjEWSGv93pXvZHnI4ky4uFnKOkUVexd.pL3cWQo8dp_MZxUhpB Pzwle.E74EmsSGjlUofWUYBjLxppgNOP0u2fTefEi6C0sLO71osEKJwfitB0.eT7G9pst3xN5JYB 39tut7hq_xabYiTtmqx0jpfCYszqPxHnfHSdrU3fODuaJZBZHhE.BXHbt9PycdW7.j0NY9qZtTHn uYrbih4ZFwRgIhk1oYgJtzcTPDMjzpPAzbq6ind_R2DjyhQL4CL.WKaMlLq6Ur76BNocD6oUXakk KocoWhMhHeUo1qxyodMDyM25z2sJXoHMCtQhMbolF5Mcb6wEDpcvILxfK6gvaAFvgR.mKqiT_Sws F1iEp6el8XqnVV42eckl4yDG84WRadFYMIu_Xb8riUWLFu2aW7A8w2CjHlV.X_nAziujVSQaIKTo V_bElqR.xrCCHCNtLwq2aK3zYpOcQO1NWetHcx8xMrwZmdUwpGUvX2mfoggk0tglILWjMmLxVUg7 myfv1wO9ltPlFYq1rpCGq5oEPTMSrnIQV68jGSp8TLCQuK9slPjTPn0NOrANz97BqjljtP.HRxbY RKjlLxmYwM0h2OsG2n5yeRt8Dy7vs53qrnDpkRE6iXoYhi2Tq3kRDTpzldW32ivKpqe0qLIeGOZM nzVVuWetTqI3tPoD03SXAvlxXOpEfmHJPcFTmBbuDqzSUwhNKRBd0Pa3Gxem2jTshFgblwMLbYHW xDScvjyFK6cZuSVVgdpovVUJ1puSezawc_lVAGpMZOvD80eUp9u1eZTkrdy0jFcppdt4mLvIX5.o VC_BkPbneiGHQ2OcHQu6wMBhjgDFtupSjgH2GNVMTVG29NLhjdu.uEO3btJSBJgdJulWda.bXPd2 uNwkQEPYJG1XDwqCi_Mvnww-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.bf2.yahoo.com with HTTP; Thu, 15 Aug 2019 19:34:32 +0000 Received: by smtp416.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID fda915bd6b5e78e4f695c2a6fec197b5; Thu, 15 Aug 2019 19:34:28 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: svn commit: r351100 - head/sys/dev/iicbus/twsi looks to be missing (uintmax_t) cast Message-Id: <52FBFD78-F69C-48F6-84CB-DCD071ED4C00@yahoo.com> Date: Thu, 15 Aug 2019 12:34:25 -0700 Cc: freebsd-arm@freebsd.org To: freebsd-current@freebsd.org X-Mailer: Apple Mail (2.3445.104.11) X-Rspamd-Queue-Id: 468c8n1wgWz4L9Z X-Spamd-Bar: - X-Spamd-Result: default: False [-1.58 / 15.00]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; FREEMAIL_FROM(0.00)[yahoo.com]; TO_DN_NONE(0.00)[]; MV_CASE(0.50)[]; DKIM_TRACE(0.00)[yahoo.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:26101, ipnet:74.6.128.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.88)[-0.876,0]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; NEURAL_SPAM_SHORT(0.70)[0.703,0]; NEURAL_HAM_LONG(-0.91)[-0.909,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (3.88), ipnet: 74.6.128.0/21(1.44), asn: 26101(1.16), country: US(-0.05)]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[42.129.6.74.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Aug 2019 19:34:34 -0000 A textually small nit for r351100 is that %ju normally goes with a (uintmax_t) cast, so more like: debugf(sc->dev, "Bus clock is at %ju\n", (uintmax_t)clk); %ju need not match up with uint64_t from: uint64_t clk; === Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-current@freebsd.org Thu Aug 15 21:47:55 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D6BFFB7455 for ; Thu, 15 Aug 2019 21:47:55 +0000 (UTC) (envelope-from clay.daniels.jr@gmail.com) Received: from mail-ua1-x92f.google.com (mail-ua1-x92f.google.com [IPv6:2607:f8b0:4864:20::92f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 468g6f5k83z4Slq for ; Thu, 15 Aug 2019 21:47:54 +0000 (UTC) (envelope-from clay.daniels.jr@gmail.com) Received: by mail-ua1-x92f.google.com with SMTP id g11so1358708uak.0 for ; Thu, 15 Aug 2019 14:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=wy+wlLG+jLeq1KF4qVtRVpBvirGApL8+D+1j5SbONsk=; b=lwzuxFITE1RkfE4+5ZM/V3RuAiklLnObeNrfna5DBWt50Suc+DxCP8lIWNw2euCw5g NUps83V65tZdY1BOS9vMUGNI2tT+YGVVSGeyzl/KPdt8QnepCThdnjLzSMfXHFOGERpE QLb5REf6/yir4rfihfCj6jgGudESCNmMiCoCBVTO0MXEE1MquH2wwRIY9HHmaoYqoI/e d357bw7vqeBTr4qA2eCU8EaH2jcDIZkkwC4eR0a+D6FrBT7+NTeXu0mvyUVbymThY0Pl bbdNrPvIdy4mKnmFlZUgLs0iPoBncAaCbzuroidQcyOWqd9a5XmZ9ZLLkTZNAlf1nzTa I0Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=wy+wlLG+jLeq1KF4qVtRVpBvirGApL8+D+1j5SbONsk=; b=IZriOHby7WEFNSC86tqI1ey9uiNfami+yc958H//rLFhITRny7nPHiFqbxFMfXRzVk 3JofyGojuP41fjkXS3ukmi20cavsiXzU3O8FT/J0FiZDX7/seEVG0Dp5NahL7QFsYBR4 ID7A5gzLUsLGWfiLg6OG5MgfDr0tZ+T/jF1eDt/EveRHiWlHf+2rjGF0nVxaAUdv0g30 fEnLePWa0ws+VtzTaBRBVVzvsEwnRouE+yC65z1ifRsF9sFC1m/eYFej0BuIlitQEQMx e1zZroXsMBFx033scxjWIxkqwjfc3dQeZ99mbm0kNfU7fd6ONiEQ6ajzeGztKl7sAdnH Zlmw== X-Gm-Message-State: APjAAAXH/IJqDuw9Ci53ml+UjbEQlHqiiypfyVzuvPvXdKVloJ4WSmIo gNux6/TTM+manM0OQq0bMiaci4OLdiyJZ2N/MQhir1lE/A== X-Google-Smtp-Source: APXvYqxz05JDzGpXwvkTkbpDGCxNHcibZhiz5ClZE+SWBOMsfCe7o1+33XbQcPqw0x1JYetjbrS/P5For5TQkCc18js= X-Received: by 2002:a9f:326f:: with SMTP id y44mr4989702uad.50.1565905673205; Thu, 15 Aug 2019 14:47:53 -0700 (PDT) MIME-Version: 1.0 From: "Clay Daniels Jr." Date: Thu, 15 Aug 2019 16:47:41 -0500 Message-ID: Subject: FreeBSD-13.0-CURRENT 20190815-r351067 is online To: "freebsd-current@freebsd.org" X-Rspamd-Queue-Id: 468g6f5k83z4Slq X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=lwzuxFIT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of claydanielsjr@gmail.com designates 2607:f8b0:4864:20::92f as permitted sender) smtp.mailfrom=claydanielsjr@gmail.com X-Spamd-Result: default: False [-2.18 / 15.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-0.997,0]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-9.86), ipnet: 2607:f8b0::/32(-2.96), asn: 15169(-2.38), country: US(-0.05)]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_IN_DNSWL_NONE(0.00)[f.2.9.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; TO_DN_EQ_ADDR_ALL(0.00)[]; HFILTER_URL_ONLY(1.82)[0.82758620689655]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Aug 2019 21:47:55 -0000 FreeBSD-13.0-CURRENT-amd64-20190815-r351067-disc1.iso.xz From owner-freebsd-current@freebsd.org Fri Aug 16 00:09:18 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BFDA0BAAB4 for ; Fri, 16 Aug 2019 00:09:18 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic313-14.consmr.mail.bf2.yahoo.com (sonic313-14.consmr.mail.bf2.yahoo.com [74.6.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 468kFp108Lz4Zb8 for ; Fri, 16 Aug 2019 00:09:17 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: 9Yo86jwVM1kT_6.76aFf481iY3laTyfjkftKP9z.Bb24Dim.DF_trdh3g2oLu7Y KkRHnyJvhY1eefVvgDMHvye8QiaR9zYMKlEQz4FbP2gFyVBZhrGUqOmMwHSMKrjjG1mQp1pxCNAJ kl4_yzHzkXjqGpEirzCVgX8Bhgaj2W066IIvEQ1jOHOW75IBoKPiZ5yJLyPKgiAMiocNhGNr2VZs Pr2jkYWGNGcaZqsHTx4lyamG5SvqRXrHRjnlKoGc1TCfUJzXITGHVWZYPergAcFomHEyeRhsKGY8 .OmCyWhjXQ5saIRUa3fGneFJ.ANAHxEAV1EFaXmvHhZLWjJa9pnH5Fcg.sZVIjFsgTC7LsTwSi7p XQ1jc7_U3TN8O4On68yGHnmQ_dxjiw8sv9xg2OgCxZbthxPDRlbDorLwzg5IcxQywh7NwBE10NZW wOuD7aBVFGpw4HTXqIoRdzqfMhe_mhL9AQxC.v7PR0_NJ2LGt6sAIYzCzHk420L9o7meQTDqvCKS tLfYG1xa.2DPmavZWBVICgf__5gOgD8ghLf_tJ5MPLyh81v23T4IIP0.KSvIPZDyeUilQjKWLo9Y BAN2UBCbji3aY.yK3A5pvz7ETS4Q0c3tvRIMyGwaZnvhtDN4OeDEDdmMwplXK5eKo.yxs9jxSnHR YW3UeoDE5.YNyxoQBZgZvZiiFUXtg9tGuPIlKjs6C9ep0kCnN4ffjgBwIBm7k0h_NZSP28UbxxgC W_nJXrGsM6wU5VE76m9fWqZQI33wh0NyrW8XP.lmToi0oy1_F9h5Y_DUUCH5qMZsgipraw33Zr3_ XEtQJHdf4jgPpf3IfY7HXK_rCON.LDMcyNv.gifi15r5XxtVEtFbGS0KrttQ7Hhw0Fb56MsCIrRu MhApROF.qt715M7BSyDY7BYf8OzckTynW6SHeOWpElrQesZjClw6XoZMnMNC9kQz3FyN.bJTrr9x KHhUSYPtlfqvqk52jkiKF4apViKQ1KuNOEBKtqfkYeehIAU2rvacF68nox9k7qmrHCwmSHRLicpp tSuF5qZclBsfFMopxlOWMCqQJohp2Ht6MUhrTkzCVAtLdFLmH7uAzSu4A2QWPSzVfyJX6iVvRsNT pvGAj2HEjWmkdXOO1FO7uyMmQjU0JNpR0NX94.JAdo_QUBe3L3CbjEX9PRIyBPeHSqFhAA8976ej kufHMSHdKR6ENWaRIo7DG.788Fz.9cAMlZRqkhDiFVPwly8fu5pl3JDspWtacWwTSNyy.OP7e.o_ cYAaFi9rBlqDe9qU2WbMvUWUVyRlHYw-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.bf2.yahoo.com with HTTP; Fri, 16 Aug 2019 00:09:17 +0000 Received: by smtp422.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 01bbee433c21d7a086bf792d72f25332; Fri, 16 Aug 2019 00:09:15 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: head -r351102 amd64 rebuilding itself but via devel/xtoolchain-llvm90 ( rc2: ports head -r509054 ) fails for boot2.out: ld.lld: error: undefined symbol: __ashldi3 Message-Id: Date: Thu, 15 Aug 2019 17:09:11 -0700 Cc: freebsd-amd64@freebsd.org To: freebsd-toolchain@freebsd.org, freebsd-current@freebsd.org X-Mailer: Apple Mail (2.3445.104.11) X-Rspamd-Queue-Id: 468kFp108Lz4Zb8 X-Spamd-Bar: - X-Spamd-Result: default: False [-1.49 / 15.00]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; FREEMAIL_FROM(0.00)[yahoo.com]; TO_DN_NONE(0.00)[]; MV_CASE(0.50)[]; DKIM_TRACE(0.00)[yahoo.com:+]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:26101, ipnet:74.6.128.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.85)[-0.847,0]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_SPAM_SHORT(0.74)[0.743,0]; NEURAL_HAM_LONG(-0.88)[-0.884,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (4.03), ipnet: 74.6.128.0/21(1.44), asn: 26101(1.16), country: US(-0.05)]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[124.133.6.74.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 00:09:18 -0000 My attempt to have -r351102 rebuild itself via devel/llvm90 (rc2) got: --- all_subdir_stand --- --- boot2.out --- ld.lld: error: undefined symbol: __ashldi3 >>> referenced by ufsread.c:234 (/usr/src/stand/libsa/ufsread.c:234) >>> boot2.o:(fsread) >>> referenced by ufsread.c:270 (/usr/src/stand/libsa/ufsread.c:270) >>> boot2.o:(fsread) >>> referenced by ufsread.c:295 (/usr/src/stand/libsa/ufsread.c:295) >>> boot2.o:(fsread) >>> referenced by ufsread.c:297 (/usr/src/stand/libsa/ufsread.c:297) >>> boot2.o:(fsread) *** [boot2.out] Error code 1 make[5]: stopped in /usr/src/stand/i386/boot2 .ERROR_TARGET=3D'boot2.out' = .ERROR_META_FILE=3D'/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd= 64.amd64/stand/i386/boot2/boot2.out.meta' .MAKE.LEVEL=3D'5' MAKEFILE=3D'' .MAKE.MODE=3D'meta missing-filemon=3Dyes missing-meta=3Dyes silent=3Dyes = verbose' _ERROR_CMD=3D'/usr/local/llvm90/bin/ld.lld -m elf_i386_fbsd -static -N = --gc-sections -Ttext 0x2000 -o boot2.out = /usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64.amd64/stand/i386/= btx/lib/crt0.o boot2.o sio.o;' .CURDIR=3D'/usr/src/stand/i386/boot2' .MAKE=3D'make' = .OBJDIR=3D'/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64.amd64/= stand/i386/boot2' .TARGETS=3D'all' = DESTDIR=3D'/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64.amd64/= tmp' LD_LIBRARY_PATH=3D'' MACHINE=3D'amd64' MACHINE_ARCH=3D'amd64' MAKEOBJDIRPREFIX=3D'' MAKESYSPATH=3D'/usr/src/share/mk' MAKE_VERSION=3D'20181221' = PATH=3D'/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64.amd64/tmp= /usr/sbin:/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64.amd64/t= mp/usr/bin:/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64.amd64/= tmp/legacy/usr/sbin:/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd= 64.amd64/tmp/legacy/usr/bin:/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr= /src/amd64.amd64/tmp/legacy/bin::/sbin:/bin:/usr/sbin:/usr/bin' SRCTOP=3D'/usr/src' OBJTOP=3D'/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64.amd64' .MAKE.MAKEFILES=3D'/usr/src/share/mk/sys.mk = /usr/src/share/mk/local.sys.env.mk /usr/src/share/mk/src.sys.env.mk = /root/src.configs/src.conf.amd64-xtoolchain-llvm.amd64-host = /usr/src/share/mk/bsd.mkopt.mk /usr/src/share/mk/src.sys.obj.mk = /usr/src/share/mk/auto.obj.mk /usr/src/share/mk/bsd.suffixes.mk = /root/src.configs/make.conf /usr/src/share/mk/local.sys.mk = /usr/src/share/mk/src.sys.mk /dev/null = /usr/src/stand/i386/boot2/Makefile /usr/src/share/mk/bsd.init.mk = /usr/src/share/mk/bsd.opts.mk /usr/src/share/mk/bsd.cpu.mk = /usr/src/share/mk/local.init.mk /usr/src/share/mk/src.init.mk = /usr/src/stand/i386/boot2/../Makefile.inc = /usr/src/share/mk/bsd.linker.mk = /usr/src/stand/i386/boot2/../../Makefile.inc = /usr/src/stand/i386/boot2/../../defs.mk /usr/src/share/mk/src.opts.mk = /usr/src/share/mk/bsd.own.mk /usr/src/share/mk/bsd.compiler.mk = /usr/src/share/mk/bsd.compiler.mk /usr/src/share/mk/bsd.prog.mk = /usr/src/share/mk/bsd.libnames.mk /usr/src/share/mk/src.libnames.mk = /usr/src/share/mk/bsd.nls.mk /usr/src/share/mk/bsd.confs.mk = /usr/src/share/mk/bsd.files.mk /usr/src/share/mk/bsd.dirs.mk = /usr/src/share/mk/bsd.incs.mk /usr/src/share/mk/bsd.links.mk = /usr/src/share/mk/bsd.man.mk /usr/src/share/mk/bsd.dep.mk = /usr/src/share/mk/bsd.clang-analyze.mk /usr/src/share/mk/bsd.obj.mk = /usr/src/share/mk/bsd.subdir.mk /usr/src/share/mk/bsd.sys.mk' .PATH=3D'. /usr/src/stand/i386/boot2' 1 error FYI: # uname -apKU FreeBSD FBSDFHUGE 13.0-CURRENT FreeBSD 13.0-CURRENT #29 r351102M: Thu = Aug 15 14:22:00 PDT 2019 = markmi@FBSDFHUGE:/usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/sys/= GENERIC-NODBG amd64 amd64 1300039 1300039 =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-current@freebsd.org Fri Aug 16 05:57:24 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B1E1EC10B3 for ; Fri, 16 Aug 2019 05:57:24 +0000 (UTC) (envelope-from nonameless@ukr.net) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 468szS2M5Tz3L6P for ; Fri, 16 Aug 2019 05:57:24 +0000 (UTC) (envelope-from nonameless@ukr.net) Received: by mailman.nyi.freebsd.org (Postfix) id 50CE4C10AE; Fri, 16 Aug 2019 05:57:24 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5092BC10AD for ; Fri, 16 Aug 2019 05:57:24 +0000 (UTC) (envelope-from nonameless@ukr.net) Received: from frv199.fwdcdn.com (frv199.fwdcdn.com [212.42.77.199]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "*.ukr.net", Issuer "Thawte RSA CA 2018" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 468szR1vB9z3L6N for ; Fri, 16 Aug 2019 05:57:22 +0000 (UTC) (envelope-from nonameless@ukr.net) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ukr.net; s=ffe; h=Content-Type:MIME-Version:Message-Id:References:In-Reply-To:Cc:To: Subject:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=YcG1mcZX4IKBoSiIHERaxDI0MSvPmwDW7vDWfogb+jw=; b=al7BqQ3nHwXjeCsJuFo13Me13f Qfai6JVgS8qNj6H8mlI+PDjCp2IcCRkem9n/mES1sbIQmdZ2LCtOY82ysIOt9tWvqyJofQTdzyXIc P6xhqWAGmQHMNTZ00s6RqfqmR0pFmmMQP334UT9VxJ80fe59eFDlG47IJXd9YimFWVuM=; Received: from [10.10.10.52] (helo=frv52.fwdcdn.com) by frv199.fwdcdn.com with smtp ID 1hyVEf-000M4H-Ju for current@freebsd.org; Fri, 16 Aug 2019 08:57:13 +0300 Date: Fri, 16 Aug 2019 08:57:13 +0300 From: nonameless@ukr.net Subject: Re: Stop installing /usr/bin/clang To: Konstantin Belousov Cc: current@freebsd.org Received: from nonameless@ukr.net by frv52.fwdcdn.com; Fri, 16 Aug 2019 08:57:13 +0300 In-Reply-To: <20190815164815.GK2738@kib.kiev.ua> References: <20190815164815.GK2738@kib.kiev.ua> X-Reply-Action: reply Message-Id: <1565934978.346522000.fx5o0ase@frv52.fwdcdn.com> X-Mailer: mail.ukr.net 5.0 MIME-Version: 1.0 X-Rspamd-Queue-Id: 468szR1vB9z3L6N X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=ukr.net header.s=ffe header.b=al7BqQ3n; dmarc=pass (policy=none) header.from=ukr.net; spf=pass (mx1.freebsd.org: domain of nonameless@ukr.net designates 212.42.77.199 as permitted sender) smtp.mailfrom=nonameless@ukr.net X-Spamd-Result: default: False [-4.89 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[ukr.net:s=ffe]; IP_SCORE(0.00)[ipnet: 212.42.77.0/24(-4.66), asn: 8856(-3.80), country: UA(0.08)]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[ukr.net]; R_SPF_ALLOW(-0.20)[+ip4:212.42.77.0/24]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; IP_SCORE_FREEMAIL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; DWL_DNSWL_LOW(-1.00)[ukr.net.dwl.dnswl.org : 127.0.5.1]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[ukr.net:+]; RCPT_COUNT_TWO(0.00)[2]; FROM_NO_DN(0.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.985,0]; MIME_BASE64_TEXT(0.10)[]; FREEMAIL_TO(0.00)[gmail.com]; DMARC_POLICY_ALLOW(-0.50)[ukr.net,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[ukr.net]; ASN(0.00)[asn:8856, ipnet:212.42.77.0/24, country:UA]; RCVD_TLS_LAST(0.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: binary X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 05:57:24 -0000 I see the same thing with base /usr/bin/ld and /usr/local/bin/ld from binutils. --- Original message --- From: "Konstantin Belousov"  Date: 15 August 2019, 19:48:37 Please look at https://reviews.freebsd.org/D21060 I propose to stop installing /usr/bin/clang, clang++, clang-cpp. It probably does not matter when all your software comes from ports or packages, but is actually very annoying when developing on FreeBSD. In particular, you never know which `clang' is called in the user environment, because it depends on the $PATH elements ordering. To clear some confusion: this has nothing to do with not installing compiler from base, /usr/bin/c{c,++,pp} are still there after the change is applied. It only to make clang on par with gcc, and to remove one thing that was quite time-consuming in multi-target environment for me during porting something large in FreeBSD userspace. _______________________________________________ freebsd-current@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-current To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" From owner-freebsd-current@freebsd.org Fri Aug 16 08:17:21 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C8C10C45AA for ; Fri, 16 Aug 2019 08:17:21 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 468x4x3pPHz3wmv for ; Fri, 16 Aug 2019 08:17:21 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id 8284DC45A9; Fri, 16 Aug 2019 08:17:21 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 82459C45A7 for ; Fri, 16 Aug 2019 08:17:21 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 468x4w2nztz3wmt for ; Fri, 16 Aug 2019 08:17:19 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x7G8HCeT036891 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 16 Aug 2019 11:17:15 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x7G8HCeT036891 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x7G8HC5O036890; Fri, 16 Aug 2019 11:17:12 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 16 Aug 2019 11:17:12 +0300 From: Konstantin Belousov To: nonameless@ukr.net Cc: current@freebsd.org Subject: Re: Stop installing /usr/bin/clang Message-ID: <20190816081712.GN2738@kib.kiev.ua> References: <20190815164815.GK2738@kib.kiev.ua> <1565934978.346522000.fx5o0ase@frv52.fwdcdn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1565934978.346522000.fx5o0ase@frv52.fwdcdn.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-Rspamd-Queue-Id: 468x4w2nztz3wmt X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com X-Spamd-Result: default: False [-2.98 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; HAS_XAW(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all:c]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.977,0]; RCPT_COUNT_TWO(0.00)[2]; IP_SCORE(0.00)[ip: (-2.59), ipnet: 2001:470::/32(-4.47), asn: 6939(-3.04), country: US(-0.05)]; FREEMAIL_TO(0.00)[ukr.net]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; FREEMAIL_ENVFROM(0.00)[gmail.com]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 08:17:21 -0000 On Fri, Aug 16, 2019 at 08:57:13AM +0300, nonameless@ukr.net wrote: > I see the same thing with base /usr/bin/ld and /usr/local/bin/ld from binutils. Yes but a direct ld use is very rare. When it is needed, usually the level of hackery applied is already high enough for the user to already know what she does. I did not see it causing issues practically, while multiple clangs in the path cause real problems. > > --- Original message --- > From: "Konstantin Belousov"  > Date: 15 August 2019, 19:48:37 > > Please look at https://reviews.freebsd.org/D21060 > I propose to stop installing /usr/bin/clang, clang++, clang-cpp. > > It probably does not matter when all your software comes from ports or > packages, but is actually very annoying when developing on FreeBSD. > In particular, you never know which `clang' is called in the user > environment, because it depends on the $PATH elements ordering. > > To clear some confusion: this has nothing to do with not installing > compiler from base, /usr/bin/c{c,++,pp} are still there after the change > is applied. It only to make clang on par with gcc, and to remove one > thing that was quite time-consuming in multi-target environment for me > during porting something large in FreeBSD userspace. > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" From owner-freebsd-current@freebsd.org Fri Aug 16 08:47:46 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5FA7FC500C for ; Fri, 16 Aug 2019 08:47:46 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 468xm21p24z3yCm for ; Fri, 16 Aug 2019 08:47:46 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from smtp.theravensnest.org (smtp.theravensnest.org [46.226.110.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: theraven) by smtp.freebsd.org (Postfix) with ESMTPSA id 05B3BBD7C for ; Fri, 16 Aug 2019 08:47:46 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from [10.164.186.150] (unknown [167.220.197.150]) by smtp.theravensnest.org (Postfix) with ESMTPSA id D3D842CC for ; Fri, 16 Aug 2019 08:47:19 +0000 (UTC) Subject: Re: Stop installing /usr/bin/clang To: freebsd-current@freebsd.org References: <20190815164815.GK2738@kib.kiev.ua> From: David Chisnall Message-ID: <03b695ff-afdb-85db-d1d3-b62111c346a9@FreeBSD.org> Date: Fri, 16 Aug 2019 09:47:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190815164815.GK2738@kib.kiev.ua> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 08:47:46 -0000 On 15/08/2019 17:48, Konstantin Belousov wrote: > Please look at https://reviews.freebsd.org/D21060 > I propose to stop installing /usr/bin/clang, clang++, clang-cpp. > > It probably does not matter when all your software comes from ports or > packages, but is actually very annoying when developing on FreeBSD. > In particular, you never know which `clang' is called in the user > environment, because it depends on the $PATH elements ordering. What is the confusion here? The binary that is invoked as clang is from the base system. The binary that is invoked as clang{version number} is from ports. If the user has built clang from source and has set up their path to put that first, then they will get a different clang, but there's no way we can stop that kind of behaviour. For reference, on my machine, I have: clang <- this one is from the base system clang60 <- this one if from ports clang70 <- this one if from ports clang80 <- this one if from ports clang-devel <- this one if from ports Nothing in my PATH order affects this. The only source of confusion that I regularly encounter comes from the fact that FreeBSD packages install clang80, when every other system installs clang-8, so I end up having to have a special case in CMake logic for finding specific versions of tools like clang-format on FreeBSD. That said, I don't know what the impact would be on configure scripts if we didn't have a clang binary. CMake seems to run ${CC} -v and parse the output, so it's quite happy finding that cc is clang (and the specific version). How do most autoconf things handle this? Apple shipped a gcc symlink to clang for years because, in the absence of a gcc binary, a load of programs detected /usr/bin/cc and decided not to enable any GNU extensions. We've managed to avoid having to do that, but how many things look for clang, gcc, and cc in the path and enable features based on which one they find? David From owner-freebsd-current@freebsd.org Fri Aug 16 09:07:25 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2D9F4C589E for ; Fri, 16 Aug 2019 09:07:25 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 468yBh3Lqgz403b for ; Fri, 16 Aug 2019 09:07:24 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: by mailman.nyi.freebsd.org (Postfix) id 73023C589D; Fri, 16 Aug 2019 09:07:24 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 72C2CC589B for ; Fri, 16 Aug 2019 09:07:24 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 468yBg09yKz403Z for ; Fri, 16 Aug 2019 09:07:22 +0000 (UTC) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (v-critter.freebsd.dk [192.168.55.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by phk.freebsd.dk (Postfix) with ESMTPS id 966521AF112 for ; Fri, 16 Aug 2019 09:07:13 +0000 (UTC) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.15.2/8.15.2) with ESMTPS id x7G97DGH005370 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO) for ; Fri, 16 Aug 2019 09:07:13 GMT (envelope-from phk@critter.freebsd.dk) Received: (from phk@localhost) by critter.freebsd.dk (8.15.2/8.15.2/Submit) id x7G97Dpc005369; Fri, 16 Aug 2019 09:07:13 GMT (envelope-from phk) To: current@freebsd.org Subject: Huawei mobile/wifi gadgets: HOWTO From: Poul-Henning Kamp MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <5367.1565946433.1@critter.freebsd.dk> Date: Fri, 16 Aug 2019 09:07:13 +0000 Message-ID: <5368.1565946433@critter.freebsd.dk> X-Rspamd-Queue-Id: 468yBg09yKz403Z X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of phk@critter.freebsd.dk designates 130.225.244.222 as permitted sender) smtp.mailfrom=phk@critter.freebsd.dk X-Spamd-Result: default: False [-2.30 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.98)[-0.983,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[current@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; NEURAL_HAM_LONG(-0.99)[-0.989,0]; RCVD_COUNT_THREE(0.00)[3]; DMARC_NA(0.00)[freebsd.dk]; NEURAL_HAM_SHORT(-0.39)[-0.387,0]; IP_SCORE(0.06)[ip: (0.09), ipnet: 130.225.0.0/16(0.09), asn: 1835(0.13), country: EU(-0.00)]; FORGED_SENDER(0.30)[phk@phk.freebsd.dk,phk@critter.freebsd.dk]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:1835, ipnet:130.225.0.0/16, country:EU]; FROM_NEQ_ENVFROM(0.00)[phk@phk.freebsd.dk,phk@critter.freebsd.dk]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 09:07:25 -0000 This seems to be sort of a FAQ, and I had a chance to spend a couple of quality minutes with one of these devices. The fundamental problem is that they come up as a CD device, with Windows software to do whatever it takes. Sending them a magic USB command enables other interfaces, including serial/modem, USB ethernet etc. The remaining issue is: How to get FreeBSD do send the magic string? A file in /etc/devd along these lines will do it: notify 1000 { match "system" "GEOM"; match "type" "CREATE"; match "cdev" "iso9660/MOBILEWIFI"; action "/usr/local/sbin/usb_modeswitch -v 0x12d1 -p 0x15ca -J"; }; It works by reacting to the CD device appearing, which seems to be a sure-fire indication that the device is in wrong mode. You may have to adjust the precise "cdev" name (ls /dev/iso9660) and vendor/product numbers (usbconfig dump_device_desc), and obviously you have to install the usb_modeswitch port. The -J argument seems to be what all newer Huawei devices want. Add ifconfig_ue0=DHCP in /etc/rc.conf, and you should be set. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. From owner-freebsd-current@freebsd.org Fri Aug 16 09:10:33 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DF8A8C5A51 for ; Fri, 16 Aug 2019 09:10:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 468yGK4jM9z40Ml; Fri, 16 Aug 2019 09:10:33 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x7G9APPj049395 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 16 Aug 2019 12:10:28 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x7G9APPj049395 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x7G9APP2049393; Fri, 16 Aug 2019 12:10:25 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 16 Aug 2019 12:10:25 +0300 From: Konstantin Belousov To: David Chisnall Cc: freebsd-current@freebsd.org Subject: Re: Stop installing /usr/bin/clang Message-ID: <20190816091025.GO2738@kib.kiev.ua> References: <20190815164815.GK2738@kib.kiev.ua> <03b695ff-afdb-85db-d1d3-b62111c346a9@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <03b695ff-afdb-85db-d1d3-b62111c346a9@FreeBSD.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-Rspamd-Queue-Id: 468yGK4jM9z40Ml X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.94)[-0.939,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 09:10:34 -0000 On Fri, Aug 16, 2019 at 09:47:41AM +0100, David Chisnall wrote: > On 15/08/2019 17:48, Konstantin Belousov wrote: > > Please look at https://reviews.freebsd.org/D21060 > > I propose to stop installing /usr/bin/clang, clang++, clang-cpp. > > > > It probably does not matter when all your software comes from ports or > > packages, but is actually very annoying when developing on FreeBSD. > > In particular, you never know which `clang' is called in the user > > environment, because it depends on the $PATH elements ordering. > > What is the confusion here? Between /usr/bin/clang and /usr/local/bin/clang. > The binary that is invoked as clang is from the base system. Not necessary. > The binary that is invoked as clang{version number} is from ports. This is irrelevant. > If the user has built clang from source and has set up > their path to put that first, then they will get a different clang, but > there's no way we can stop that kind of behaviour. This is irrelevant as well. You did not read neither review summary nor followups. clang also comes from devel/llvm. Users that want clang do install it, esp. when version in base is different. > > For reference, on my machine, I have: > > clang <- this one is from the base system > clang60 <- this one if from ports > clang70 <- this one if from ports > clang80 <- this one if from ports > clang-devel <- this one if from ports > > Nothing in my PATH order affects this. > > The only source of confusion that I regularly encounter comes from the > fact that FreeBSD packages install clang80, when every other system > installs clang-8, so I end up having to have a special case in CMake > logic for finding specific versions of tools like clang-format on FreeBSD. > > That said, I don't know what the impact would be on configure scripts if > we didn't have a clang binary. CMake seems to run ${CC} -v and parse > the output, so it's quite happy finding that cc is clang (and the > specific version). How do most autoconf things handle this? Apple > shipped a gcc symlink to clang for years because, in the absence of a > gcc binary, a load of programs detected /usr/bin/cc and decided not to > enable any GNU extensions. We've managed to avoid having to do that, > but how many things look for clang, gcc, and cc in the path and enable > features based on which one they find? I plan to ask for exp run with the patch after some more time to gather feedback. From owner-freebsd-current@freebsd.org Fri Aug 16 09:14:44 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3512DC5DE3 for ; Fri, 16 Aug 2019 09:14:44 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 468yM76SGgz40nx for ; Fri, 16 Aug 2019 09:14:43 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: by mailman.nyi.freebsd.org (Postfix) id DD43AC5DE2; Fri, 16 Aug 2019 09:14:43 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DD0C4C5DE1 for ; Fri, 16 Aug 2019 09:14:43 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 468yM65kmnz40nw for ; Fri, 16 Aug 2019 09:14:42 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x7G9Ecx9029930; Fri, 16 Aug 2019 02:14:38 -0700 (PDT) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: (from freebsd-rwg@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x7G9EcQd029929; Fri, 16 Aug 2019 02:14:38 -0700 (PDT) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <201908160914.x7G9EcQd029929@gndrsh.dnsmgr.net> Subject: Re: Stop installing /usr/bin/clang In-Reply-To: <20190816081712.GN2738@kib.kiev.ua> To: Konstantin Belousov Date: Fri, 16 Aug 2019 02:14:38 -0700 (PDT) CC: nonameless@ukr.net, current@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 468yM65kmnz40nw X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd-rwg@gndrsh.dnsmgr.net has no SPF policy when checking 69.59.192.140) smtp.mailfrom=freebsd-rwg@gndrsh.dnsmgr.net X-Spamd-Result: default: False [-0.47 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.57)[-0.568,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; IP_SCORE(0.05)[ip: (0.15), ipnet: 69.59.192.0/19(0.08), asn: 13868(0.05), country: US(-0.05)]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[dnsmgr.net]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-0.74)[-0.742,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.11)[-0.106,0]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; FREEMAIL_CC(0.00)[ukr.net]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 09:14:44 -0000 > On Fri, Aug 16, 2019 at 08:57:13AM +0300, nonameless@ukr.net wrote: > > I see the same thing with base?/usr/bin/ld and?/usr/local/bin/ld from binutils. > Yes but a direct ld use is very rare. When it is needed, usually the > level of hackery applied is already high enough for the user to already > know what she does. I did not see it causing issues practically, while > multiple clangs in the path cause real problems. Though I have accepted the change, I have now heard this "multiple foo in path" argument twice, could you please elaborate on it? If /usr/bin /bin are first I should get base stuff, if /usr/local/bin are first I should get local stuff, what exactly is this "real problems" your refering too? Is it that something is flipping paths around? If so that should be fixed! People have been using path to pick which overload order they prefer for decades, and if we have some how broken this.. well that should get fixed asap, not removing stuff out of base because something is broken by incorrect path manipulations. Regards, Rod > > --- Original message --- > > From: "Konstantin?Belousov"? > > Date: 15?August?2019,?19:48:37 > > > > Please look at https://reviews.freebsd.org/D21060 > > I propose to stop installing /usr/bin/clang, clang++, clang-cpp. > > > > It probably does not matter when all your software comes from ports or > > packages, but is actually very annoying when developing on FreeBSD. > > In particular, you never know which `clang' is called in the user > > environment, because it depends on the $PATH elements ordering. > > > > To clear some confusion: this has nothing to do with not installing > > compiler from base, /usr/bin/c{c,++,pp} are still there after the change > > is applied. It only to make clang on par with gcc, and to remove one > > thing that was quite time-consuming in multi-target environment for me > > during porting something large in FreeBSD userspace. > > _______________________________________________ > > freebsd-current@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > > -- Rod Grimes rgrimes@freebsd.org From owner-freebsd-current@freebsd.org Fri Aug 16 09:21:17 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 794D8C60E4 for ; Fri, 16 Aug 2019 09:21:17 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 468yVj144Yz418K for ; Fri, 16 Aug 2019 09:21:17 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id 248EDC60E2; Fri, 16 Aug 2019 09:21:17 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 24519C60E1 for ; Fri, 16 Aug 2019 09:21:17 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 468yVh1J7Gz418J for ; Fri, 16 Aug 2019 09:21:15 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id x7G9L7I2051903 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 16 Aug 2019 12:21:11 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua x7G9L7I2051903 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id x7G9L7r3051901; Fri, 16 Aug 2019 12:21:07 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 16 Aug 2019 12:21:07 +0300 From: Konstantin Belousov To: "Rodney W. Grimes" Cc: nonameless@ukr.net, current@freebsd.org Subject: Re: Stop installing /usr/bin/clang Message-ID: <20190816092107.GP2738@kib.kiev.ua> References: <20190816081712.GN2738@kib.kiev.ua> <201908160914.x7G9EcQd029929@gndrsh.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201908160914.x7G9EcQd029929@gndrsh.dnsmgr.net> User-Agent: Mutt/1.12.1 (2019-06-15) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-Rspamd-Queue-Id: 468yVh1J7Gz418J X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com X-Spamd-Result: default: False [-2.98 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; FREEMAIL_FROM(0.00)[gmail.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; IP_SCORE_FREEMAIL(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.978,0]; IP_SCORE(0.00)[ip: (-2.57), ipnet: 2001:470::/32(-4.47), asn: 6939(-3.04), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; FREEMAIL_CC(0.00)[ukr.net]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 09:21:17 -0000 On Fri, Aug 16, 2019 at 02:14:38AM -0700, Rodney W. Grimes wrote: > > On Fri, Aug 16, 2019 at 08:57:13AM +0300, nonameless@ukr.net wrote: > > > I see the same thing with base?/usr/bin/ld and?/usr/local/bin/ld from binutils. > > Yes but a direct ld use is very rare. When it is needed, usually the > > level of hackery applied is already high enough for the user to already > > know what she does. I did not see it causing issues practically, while > > multiple clangs in the path cause real problems. > > Though I have accepted the change, I have now heard this "multiple foo > in path" argument twice, could you please elaborate on it? I already did that more than once. Please read the review. > > If /usr/bin /bin are first I should get base stuff, > if /usr/local/bin are first I should get local stuff, > what exactly is this "real problems" your refering too? You cannot mandate the path elements order for user, there are multiple conflicting requirements which create loop in the elements ordering. Removing clang from /usr/bin removes one of the requirement. People have to put ~/bin in front of their $PATH and create symlink, which raises questions why should they do that, and makes awful experience for starting developing on FreeBSD. > > Is it that something is flipping paths around? If so that > should be fixed! People have been using path to pick which > overload order they prefer for decades, and if we have some > how broken this.. well that should get fixed asap, not > removing stuff out of base because something is broken by > incorrect path manipulations. > > Regards, > Rod > > > --- Original message --- > > > From: "Konstantin?Belousov"? > > > Date: 15?August?2019,?19:48:37 > > > > > > Please look at https://reviews.freebsd.org/D21060 > > > I propose to stop installing /usr/bin/clang, clang++, clang-cpp. > > > > > > It probably does not matter when all your software comes from ports or > > > packages, but is actually very annoying when developing on FreeBSD. > > > In particular, you never know which `clang' is called in the user > > > environment, because it depends on the $PATH elements ordering. > > > > > > To clear some confusion: this has nothing to do with not installing > > > compiler from base, /usr/bin/c{c,++,pp} are still there after the change > > > is applied. It only to make clang on par with gcc, and to remove one > > > thing that was quite time-consuming in multi-target environment for me > > > during porting something large in FreeBSD userspace. > > > _______________________________________________ > > > freebsd-current@freebsd.org mailing list > > > https://lists.freebsd.org/mailman/listinfo/freebsd-current > > > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > > _______________________________________________ > > freebsd-current@freebsd.org mailing list > > https://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > > > > > > -- > Rod Grimes rgrimes@freebsd.org From owner-freebsd-current@freebsd.org Fri Aug 16 09:21:26 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F21A9C6108 for ; Fri, 16 Aug 2019 09:21:26 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 468yVt1gQRz41DM; Fri, 16 Aug 2019 09:21:25 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x7G9LOff029957; Fri, 16 Aug 2019 02:21:24 -0700 (PDT) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: (from freebsd-rwg@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x7G9LOtm029956; Fri, 16 Aug 2019 02:21:24 -0700 (PDT) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <201908160921.x7G9LOtm029956@gndrsh.dnsmgr.net> Subject: Re: Stop installing /usr/bin/clang In-Reply-To: <20190816091025.GO2738@kib.kiev.ua> To: Konstantin Belousov Date: Fri, 16 Aug 2019 02:21:24 -0700 (PDT) CC: David Chisnall , freebsd-current@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 468yVt1gQRz41DM X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd-rwg@gndrsh.dnsmgr.net has no SPF policy when checking 69.59.192.140) smtp.mailfrom=freebsd-rwg@gndrsh.dnsmgr.net X-Spamd-Result: default: False [1.16 / 15.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-0.21)[-0.209,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[dnsmgr.net]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.16)[0.165,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.26)[0.259,0]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(0.05)[ip: (0.15), ipnet: 69.59.192.0/19(0.08), asn: 13868(0.05), country: US(-0.05)]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 09:21:27 -0000 > On Fri, Aug 16, 2019 at 09:47:41AM +0100, David Chisnall wrote: > > On 15/08/2019 17:48, Konstantin Belousov wrote: > > > Please look at https://reviews.freebsd.org/D21060 > > > I propose to stop installing /usr/bin/clang, clang++, clang-cpp. > > > > > > It probably does not matter when all your software comes from ports or > > > packages, but is actually very annoying when developing on FreeBSD. > > > In particular, you never know which `clang' is called in the user > > > environment, because it depends on the $PATH elements ordering. > > > > What is the confusion here? > Between /usr/bin/clang and /usr/local/bin/clang. Why is that a confusion? Any installed port that overloades a base system component expects to do exactly that type of thing. Why is clang special in this respect? > > The binary that is invoked as clang is from the base system. > Not necessary. > > > The binary that is invoked as clang{version number} is from ports. > This is irrelevant. > > > If the user has built clang from source and has set up > > their path to put that first, then they will get a different clang, but > > there's no way we can stop that kind of behaviour. > This is irrelevant as well. > > You did not read neither review summary nor followups. clang also > comes from devel/llvm. Users that want clang do install it, esp. when > version in base is different. Exactly what is installed from devel/llvm that was not covered below as clang-devel? And why is it any different than any other port of clang listed below? > > For reference, on my machine, I have: > > > > clang <- this one is from the base system > > clang60 <- this one if from ports > > clang70 <- this one if from ports > > clang80 <- this one if from ports > > clang-devel <- this one if from ports > > > > Nothing in my PATH order affects this. > > > > The only source of confusion that I regularly encounter comes from the > > fact that FreeBSD packages install clang80, when every other system > > installs clang-8, so I end up having to have a special case in CMake > > logic for finding specific versions of tools like clang-format on FreeBSD. > > > > That said, I don't know what the impact would be on configure scripts if > > we didn't have a clang binary. CMake seems to run ${CC} -v and parse > > the output, so it's quite happy finding that cc is clang (and the > > specific version). How do most autoconf things handle this? Apple > > shipped a gcc symlink to clang for years because, in the absence of a > > gcc binary, a load of programs detected /usr/bin/cc and decided not to > > enable any GNU extensions. We've managed to avoid having to do that, > > but how many things look for clang, gcc, and cc in the path and enable > > features based on which one they find? > > I plan to ask for exp run with the patch after some more time to gather > feedback. > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > -- Rod Grimes rgrimes@freebsd.org From owner-freebsd-current@freebsd.org Fri Aug 16 09:34:58 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 55DE7C6576 for ; Fri, 16 Aug 2019 09:34:58 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 468ypT6vjQz41wc for ; Fri, 16 Aug 2019 09:34:57 +0000 (UTC) (envelope-from hps@selasky.org) Received: by mailman.nyi.freebsd.org (Postfix) id EB4BDC6575; Fri, 16 Aug 2019 09:34:57 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EB10AC6574 for ; Fri, 16 Aug 2019 09:34:57 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [88.99.82.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 468ypS4fjmz41wb for ; Fri, 16 Aug 2019 09:34:56 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.129.235]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id A80E426038B; Fri, 16 Aug 2019 11:34:48 +0200 (CEST) Subject: Re: Huawei mobile/wifi gadgets: HOWTO To: Poul-Henning Kamp , current@freebsd.org References: <5368.1565946433@critter.freebsd.dk> From: Hans Petter Selasky Message-ID: <11dd0e79-312d-c571-f6dd-c1103833fcc5@selasky.org> Date: Fri, 16 Aug 2019 11:34:08 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <5368.1565946433@critter.freebsd.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 468ypS4fjmz41wb X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of hps@selasky.org designates 88.99.82.50 as permitted sender) smtp.mailfrom=hps@selasky.org X-Spamd-Result: default: False [-6.47 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.turbocat.net]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[selasky.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.984,0]; RCPT_COUNT_TWO(0.00)[2]; IP_SCORE(-3.19)[ip: (-9.36), ipnet: 88.99.0.0/16(-4.75), asn: 24940(-1.84), country: DE(-0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:88.99.0.0/16, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 09:34:58 -0000 On 2019-08-16 11:07, Poul-Henning Kamp wrote: > The remaining issue is: How to get FreeBSD do send the magic string? FreeBSD USB has several quirks for these devices: See for example: > /sys/dev/usb/usb_msctest.c:usb_msc_auto_quirk(struct usb_device *udev, uint8_t iface_index) > /sys/dev/usb/usb_msctest.h:usb_error_t usb_msc_auto_quirk(struct usb_device *udev, > /sys/dev/usb/usb_device.c: err = usb_msc_auto_quirk(udev, 0); And: usbconfig dump_quirk_names | grep -i UQ_MSC --HPS From owner-freebsd-current@freebsd.org Fri Aug 16 10:05:30 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 24B3FC730F for ; Fri, 16 Aug 2019 10:05:30 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 468zTj5pg2z43c2 for ; Fri, 16 Aug 2019 10:05:29 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id C643AC730D; Fri, 16 Aug 2019 10:05:29 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BE08FC730B for ; Fri, 16 Aug 2019 10:05:29 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 468zTh3MDlz43bt for ; Fri, 16 Aug 2019 10:05:28 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wm1-x32a.google.com with SMTP id 207so3588255wma.1 for ; Fri, 16 Aug 2019 03:05:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:reply-to:mime-version :content-transfer-encoding; bh=idUjDBR3U6N3ZDp9HGl53v8I9uE6QQ+nFnDpEEDfGVs=; b=eyVeUf6C2rImpxUZdRU4BlAUn5Ifu5eAG+fLlg3BJOZAFMMJblUrvNLXg3LAtVr4Dj io9Z8IIuT/NR97NwqqnXi9xEXvb/kz3vGcOEaNA40JzycEefJLQ1yADZQ8bBQOXTAvdT pNFLngxjjATdf28e70FoH2EUcbjoEiEX4GYaN08K5pX0kNx+sM8ZCzBft6rM2QLqcVyg DAcn1PAmn1gPr8pQNMqFv9IzZi2gHcr4wNVtGXSMZnAADGIue8Sq2Eqfe5G3hwb2/X6S vauUE6ctR0acLug70yG1dL2lkG2PHrBJCqil96wPIBDIBSWvXmbChvTF+uCjyM9Qs8bH v1jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:reply-to :mime-version:content-transfer-encoding; bh=idUjDBR3U6N3ZDp9HGl53v8I9uE6QQ+nFnDpEEDfGVs=; b=kL2uCHODrzxf4o3kz3QLiyJ635tZZj565TiJ4IkwZGF/rojTQFJbGaIVXKpIFaZsP8 JJ/K58ECVbcuptiQrzw+P8jbtB+4WjY9r99JADuxypTiHwipZekDzvJebtrBNy+kC5td waAJR/kG4EUy3tOTtN/4kqlGQ0nFoEEGC1KR/LZHYOIfV9Gbktq28/nW45MUeYfA6YdM +iIClxZ1XNHDW4DzaQvDzWZq/6nx1h1hw7yccTQvwSGW/5u+oVgQVTMXb/kKsWnWLVfz W8Cj45O34aO4Sq3WwAV/7uSkRnfKURyf5Zi3ATST0qr3cVeAj7zUmDryylKi/KuUNhbH 0KtQ== X-Gm-Message-State: APjAAAVw3lXkvgSntkrNY8gZBiHjJqFBbgY+OfdtKxHbwYILal7tznio ETkA3YbBlCRtuGWowfiozzoNL5xt X-Google-Smtp-Source: APXvYqwqN5v3X2OpsQOggVL7JyRYSjF9ug9bO9YEAMkcHhdoBXph1tPXFUfqlapCLKsX7DNMvjAszg== X-Received: by 2002:a1c:39c5:: with SMTP id g188mr6368430wma.167.1565949926284; Fri, 16 Aug 2019 03:05:26 -0700 (PDT) Received: from ernst.home (p5B3BE66A.dip0.t-ipconnect.de. [91.59.230.106]) by smtp.gmail.com with ESMTPSA id g12sm5310834wrv.9.2019.08.16.03.05.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2019 03:05:25 -0700 (PDT) Date: Fri, 16 Aug 2019 12:05:24 +0200 From: Gary Jennejohn To: current@freebsd.org Subject: problem with LOCAL_MODULES Message-ID: <20190816120524.21b7fd19@ernst.home> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 468zTh3MDlz43bt X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=eyVeUf6C; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of gljennjohn@gmail.com designates 2a00:1450:4864:20::32a as permitted sender) smtp.mailfrom=gljennjohn@gmail.com X-Spamd-Result: default: False [-4.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[gljennjohn@gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_NONE(0.00)[]; REPLYTO_ADDR_EQ_FROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-0.997,0]; RECEIVED_SPAMHAUS_PBL(0.00)[106.230.59.91.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[current@freebsd.org]; FREEMAIL_REPLYTO(0.00)[gmail.com]; IP_SCORE_FREEMAIL(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; IP_SCORE(0.00)[ip: (-9.55), ipnet: 2a00:1450::/32(-3.03), asn: 15169(-2.38), country: US(-0.05)]; RCVD_IN_DNSWL_NONE(0.00)[a.2.3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 10:05:30 -0000 I tried to build a kernel today and it failed in modules-all even though I had LOCAL_MODULES="" in /etc/src.conf, as recommended by jhb. That's wrong. It has to be LOCAL_MODULES=, otherwise /sys/conf/kern.post.mk seems to conclude that there should be a module under /usr/local/sys/modules with the name "". -- Gary Jennejohnl From owner-freebsd-current@freebsd.org Fri Aug 16 10:22:09 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7F072C7B32 for ; Fri, 16 Aug 2019 10:22:09 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 468zrx2lq3z44XF for ; Fri, 16 Aug 2019 10:22:09 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from smtp.theravensnest.org (smtp.theravensnest.org [46.226.110.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: theraven) by smtp.freebsd.org (Postfix) with ESMTPSA id 2D2B6C95E for ; Fri, 16 Aug 2019 10:22:09 +0000 (UTC) (envelope-from theraven@FreeBSD.org) Received: from [10.164.186.150] (unknown [167.220.197.150]) by smtp.theravensnest.org (Postfix) with ESMTPSA id 8ADFC2CD for ; Fri, 16 Aug 2019 10:21:42 +0000 (UTC) Subject: Re: Stop installing /usr/bin/clang To: freebsd-current@freebsd.org References: <20190815164815.GK2738@kib.kiev.ua> <03b695ff-afdb-85db-d1d3-b62111c346a9@FreeBSD.org> <20190816091025.GO2738@kib.kiev.ua> From: David Chisnall Message-ID: Date: Fri, 16 Aug 2019 11:22:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190816091025.GO2738@kib.kiev.ua> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 10:22:09 -0000 On 16/08/2019 10:10, Konstantin Belousov wrote: > You did not read neither review summary nor followups. This is needlessly insulting and this kind of attitude from you towards people on the mailing lists is one of the main reasons that my engagement with the FreeBSD project tends to be in brief bursts. If this were a one-off, then I would be happy to assume that you were unusually stressed, but this is a long-term repeated pattern of behaviour. I was not aware that devel/llvm was anything other than a meta-port that installed the latest devel/llvm{version} (I have only ever installed the packages when I need a specific version and so do not have the devel/llvm port installed). You could have clarified that. Instead, you chose to launch a personal attack. You are not Linus and the FreeBSD project does not need a Linus. David From owner-freebsd-current@freebsd.org Fri Aug 16 15:22:01 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D0A1CCE9FB; Fri, 16 Aug 2019 15:22:01 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4696Vx5FCFz4MpN; Fri, 16 Aug 2019 15:22:01 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 6B52DECA6; Fri, 16 Aug 2019 15:22:01 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-wr1-f52.google.com with SMTP id r3so1913561wrt.3; Fri, 16 Aug 2019 08:22:01 -0700 (PDT) X-Gm-Message-State: APjAAAW7DTNhkW3nmyqQTj2KYyXD0bXiZaSq4JngoTdPNguiYocKog5O dXF6rA/UGI5+ezz5ej+7+uXKhapqRQ9BqygtaDo= X-Google-Smtp-Source: APXvYqyE5JvzzdPSenrKUZhaXpQ90rhb0PHY6UqTMVylfTtcwVMlb6XNUzRdAzrO7UhCSBKKHScGyN8fGMqVAFofyXg= X-Received: by 2002:adf:a55d:: with SMTP id j29mr11178662wrb.275.1565968920360; Fri, 16 Aug 2019 08:22:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Kyle Evans Date: Fri, 16 Aug 2019 10:21:48 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: head -r351102 amd64 rebuilding itself but via devel/xtoolchain-llvm90 ( rc2: ports head -r509054 ) fails for boot2.out: ld.lld: error: undefined symbol: __ashldi3 To: Mark Millard Cc: freebsd-toolchain@freebsd.org, FreeBSD Current , freebsd-amd64@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 15:22:01 -0000 On Thu, Aug 15, 2019 at 7:09 PM Mark Millard wrote: > > My attempt to have -r351102 rebuild itself via devel/llvm90 (rc2) > got: > > --- all_subdir_stand --- > --- boot2.out --- > ld.lld: error: undefined symbol: __ashldi3 > >>> referenced by ufsread.c:234 (/usr/src/stand/libsa/ufsread.c:234) > >>> boot2.o:(fsread) > >>> referenced by ufsread.c:270 (/usr/src/stand/libsa/ufsread.c:270) > >>> boot2.o:(fsread) > >>> referenced by ufsread.c:295 (/usr/src/stand/libsa/ufsread.c:295) > >>> boot2.o:(fsread) > >>> referenced by ufsread.c:297 (/usr/src/stand/libsa/ufsread.c:297) > >>> boot2.o:(fsread) > *** [boot2.out] Error code 1 > > make[5]: stopped in /usr/src/stand/i386/boot2 > .ERROR_TARGET=3D'boot2.out' > .ERROR_META_FILE=3D'/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/am= d64.amd64/stand/i386/boot2/boot2.out.meta' > .MAKE.LEVEL=3D'5' > MAKEFILE=3D'' > .MAKE.MODE=3D'meta missing-filemon=3Dyes missing-meta=3Dyes silent=3Dyes = verbose' > _ERROR_CMD=3D'/usr/local/llvm90/bin/ld.lld -m elf_i386_fbsd -static -N --= gc-sections -Ttext 0x2000 -o boot2.out /usr/obj/amd64_xtoolchain-llvm/amd64= .amd64/usr/src/amd64.amd64/stand/i386/btx/lib/crt0.o boot2.o sio.o;' > .CURDIR=3D'/usr/src/stand/i386/boot2' > .MAKE=3D'make' > .OBJDIR=3D'/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64.amd64= /stand/i386/boot2' > .TARGETS=3D'all' > DESTDIR=3D'/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64.amd64= /tmp' > LD_LIBRARY_PATH=3D'' > MACHINE=3D'amd64' > MACHINE_ARCH=3D'amd64' > MAKEOBJDIRPREFIX=3D'' > MAKESYSPATH=3D'/usr/src/share/mk' > MAKE_VERSION=3D'20181221' > PATH=3D'/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64.amd64/tm= p/usr/sbin:/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64.amd64/t= mp/usr/bin:/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64.amd64/t= mp/legacy/usr/sbin:/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64= .amd64/tmp/legacy/usr/bin:/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/sr= c/amd64.amd64/tmp/legacy/bin::/sbin:/bin:/usr/sbin:/usr/bin' > SRCTOP=3D'/usr/src' > OBJTOP=3D'/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64.amd64' > .MAKE.MAKEFILES=3D'/usr/src/share/mk/sys.mk /usr/src/share/mk/local.sys.e= nv.mk /usr/src/share/mk/src.sys.env.mk /root/src.configs/src.conf.amd64-xto= olchain-llvm.amd64-host /usr/src/share/mk/bsd.mkopt.mk /usr/src/share/mk/sr= c.sys.obj.mk /usr/src/share/mk/auto.obj.mk /usr/src/share/mk/bsd.suffixes.m= k /root/src.configs/make.conf /usr/src/share/mk/local.sys.mk /usr/src/share= /mk/src.sys.mk /dev/null /usr/src/stand/i386/boot2/Makefile /usr/src/share/= mk/bsd.init.mk /usr/src/share/mk/bsd.opts.mk /usr/src/share/mk/bsd.cpu.mk /= usr/src/share/mk/local.init.mk /usr/src/share/mk/src.init.mk /usr/src/stand= /i386/boot2/../Makefile.inc /usr/src/share/mk/bsd.linker.mk /usr/src/stand/= i386/boot2/../../Makefile.inc /usr/src/stand/i386/boot2/../../defs.mk /usr/= src/share/mk/src.opts.mk /usr/src/share/mk/bsd.own.mk /usr/src/share/mk/bsd= .compiler.mk /usr/src/share/mk/bsd.compiler.mk /usr/src/share/mk/bsd.prog.m= k /usr/src/share/mk/bsd.libnames.mk /usr/src/share/mk/src.libnames.mk /usr/= src/share/mk/bsd.nls.mk /us > r/src/share/mk/bsd.confs.mk /usr/src/share/mk/bsd.files.mk /usr/src/shar= e/mk/bsd.dirs.mk /usr/src/share/mk/bsd.incs.mk /usr/src/share/mk/bsd.links.= mk /usr/src/share/mk/bsd.man.mk /usr/src/share/mk/bsd.dep.mk /usr/src/share= /mk/bsd.clang-analyze.mk /usr/src/share/mk/bsd.obj.mk /usr/src/share/mk/bsd= .subdir.mk /usr/src/share/mk/bsd.sys.mk' > .PATH=3D'. /usr/src/stand/i386/boot2' > 1 error > We've been iterating on a fix for this- this is the latest iteration: https://reviews.freebsd.org/D21291 Thanks, Kyle Evans From owner-freebsd-current@freebsd.org Fri Aug 16 18:11:27 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5E68DAA9AE for ; Fri, 16 Aug 2019 18:11:27 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 469BGQ65mTz4Ylb; Fri, 16 Aug 2019 18:11:24 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-4.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4917FFF6E; Fri, 16 Aug 2019 18:11:23 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: Can't boot current under bhyve on current To: Sean Eric Fagan , freebsd-current@freebsd.org References: <20190815162147.8E26A1B64B@kithrup.com> From: John Baldwin Openpgp: preference=signencrypt Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: <9933e6ab-63e9-c2ad-94eb-c8654d75ae99@FreeBSD.org> Date: Fri, 16 Aug 2019 11:11:19 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <20190815162147.8E26A1B64B@kithrup.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 18:11:27 -0000 On 8/15/19 9:21 AM, Sean Eric Fagan wrote: > I get: > > Loading kernel... > /boot/kernel/kernel text=0x16c493c data=0x1c8b38+0x819238 > syms=[0x8+0x180c18+0x8+0x19df0b] > Loading configured modules... > can't find '/boot/entropy' > \ > > Note that I am using vm-bhyve as a management & control wrapper, so that was > done by doing > > vm create VM-TEST ; vm install VM-TEST 13.0.iso I think vm-bhyve hides stderr output from bhyve by default, but there might be a flag to make it display the stderr output. Can you try doing that to see if bhyve is reporting an error? Alternatively, can you see if the bhyve process is still running? -- John Baldwin From owner-freebsd-current@freebsd.org Fri Aug 16 19:00:45 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DB09DABD21 for ; Fri, 16 Aug 2019 19:00:45 +0000 (UTC) (envelope-from sef@kithrup.com) Received: from kithrup.com (kithrup.com [96.79.110.97]) by mx1.freebsd.org (Postfix) with ESMTP id 469CMJ5SQFz4dRQ; Fri, 16 Aug 2019 19:00:44 +0000 (UTC) (envelope-from sef@kithrup.com) Received: by kithrup.com (Postfix, from userid 1001) id D88D41B84A; Fri, 16 Aug 2019 12:00:37 -0700 (PDT) To: freebsd-current@freebsd.org, jhb@FreeBSD.org Subject: Re: Can't boot current under bhyve on current In-Reply-To: <9933e6ab-63e9-c2ad-94eb-c8654d75ae99@FreeBSD.org> Message-Id: <20190816190037.D88D41B84A@kithrup.com> Date: Fri, 16 Aug 2019 12:00:37 -0700 (PDT) From: Sean Eric Fagan X-Rspamd-Queue-Id: 469CMJ5SQFz4dRQ X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of sef@kithrup.com designates 96.79.110.97 as permitted sender) smtp.mailfrom=sef@kithrup.com X-Spamd-Result: default: False [-5.29 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+a]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[kithrup.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(-2.01)[ip: (-7.21), ipnet: 96.64.0.0/11(-3.61), asn: 7922(0.83), country: US(-0.05)]; NEURAL_HAM_SHORT(-0.98)[-0.983,0]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7922, ipnet:96.64.0.0/11, country:US]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 19:00:45 -0000 >I think vm-bhyve hides stderr output from bhyve by default, but there might >be a flag to make it display the stderr output. Can you try doing that to see >if bhyve is reporting an error? Alternatively, can you see if the bhyve >process is still running? The log file from it is below. bhyve was still running, looping on vm ioctls, until I killed it. starting bhyve (run 1) bhyve exited with status 1 destroying network device tap1 stopped initialising [loader: bhyveload] [cpu: 1] [memory: 512M] [hostbridge: standard] [com ports: com1] [uuid: ad7532de-bec1-11e9-8a55-d05099c38c95] [utctime: yes] [debug mode: no] [primary disk: disk0.img] [primary disk dev: file] initialising network device tap0 failed to find virtual switch 'public' booting bhyveload -m 512M -e autoboot_delay=3 -d /VMs/VM-TEST/../.iso/FreeBSD-13.0-CURRENT-amd64-20190725-r350322-disc1.iso VM-TEST [bhyve options: -c 1 -m 512M -AHP -U ad7532de-bec1-11e9-8a55-d05099c38c95 -u] [bhyve devices: -s 0,hostbridge -s 31,lpc -s 4:0,virtio-blk,/VMs/VM-TEST/disk0.img -s 5:0,virtio-net,tap0,mac=58:9c:fc:04:34:69] [bhyve console: -l com1,stdio] [bhyve iso device: -s 3:0,ahci-cd,/VMs/VM-TEST/../.iso/FreeBSD-13.0-CURRENT-amd64-20190725-r350322-disc1.iso,ro] starting bhyve (run 1) bhyve exited with status 1 destroying network device tap0 stopped Alan was trying to help me debug this yesterday, and I manually ran bhyve, but had no errors, and it still didn't work. Thanks, Sean. From owner-freebsd-current@freebsd.org Fri Aug 16 19:43:42 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1B5D6ACE5D for ; Fri, 16 Aug 2019 19:43:42 +0000 (UTC) (envelope-from tsoome@me.com) Received: from pv50p00im-tydg10021701.me.com (pv50p00im-tydg10021701.me.com [17.58.6.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 469DJs2B1fz4gW6 for ; Fri, 16 Aug 2019 19:43:40 +0000 (UTC) (envelope-from tsoome@me.com) Received: from nazgul.lan (148-52-235-80.sta.estpak.ee [80.235.52.148]) by pv50p00im-tydg10021701.me.com (Postfix) with ESMTPSA id D44EB84054A; Fri, 16 Aug 2019 19:43:37 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: Can't boot current under bhyve on current From: Toomas Soome In-Reply-To: <20190816190037.D88D41B84A@kithrup.com> Date: Fri, 16 Aug 2019 22:43:35 +0300 Cc: freebsd-current@freebsd.org, "jhb@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <150E1309-A93F-4DDB-9A21-22609DE51B56@me.com> References: <20190816190037.D88D41B84A@kithrup.com> To: Sean Eric Fagan X-Mailer: Apple Mail (2.3445.104.11) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-08-16_09:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 mlxscore=0 mlxlogscore=980 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1812120000 definitions=main-1908160200 X-Rspamd-Queue-Id: 469DJs2B1fz4gW6 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.57 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:17.58.0.0/16]; FREEMAIL_FROM(0.00)[me.com]; MV_CASE(0.50)[]; DKIM_TRACE(0.00)[me.com:+]; DMARC_POLICY_ALLOW(-0.50)[me.com,quarantine]; NEURAL_HAM_SHORT(-0.97)[-0.973,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(0.00)[ipnet: 17.58.0.0/20(-2.92), asn: 714(-2.75), country: US(-0.05)]; RCVD_IN_DNSWL_LOW(-0.10)[54.6.58.17.list.dnswl.org : 127.0.5.1]; ASN(0.00)[asn:714, ipnet:17.58.0.0/20, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[148.52.235.80.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[me.com]; R_DKIM_ALLOW(-0.20)[me.com:s=1a1hai]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE_FREEMAIL(0.00)[]; DWL_DNSWL_LOW(-1.00)[me.com.dwl.dnswl.org : 127.0.5.1]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 19:43:42 -0000 Could you test with larger memory setup - instead of 512M, 1-2G? rgds, toomas > On 16 Aug 2019, at 22:00, Sean Eric Fagan wrote: >=20 >> I think vm-bhyve hides stderr output from bhyve by default, but there = might >> be a flag to make it display the stderr output. Can you try doing = that to see >> if bhyve is reporting an error? Alternatively, can you see if the = bhyve >> process is still running? >=20 > The log file from it is below. bhyve was still running, looping on vm = ioctls, > until I killed it. >=20 > starting bhyve (run 1) > bhyve exited with status 1 > destroying network device tap1 > stopped > initialising > [loader: bhyveload] > [cpu: 1] > [memory: 512M] > [hostbridge: standard] > [com ports: com1] > [uuid: ad7532de-bec1-11e9-8a55-d05099c38c95] > [utctime: yes] > [debug mode: no] > [primary disk: disk0.img] > [primary disk dev: file] > initialising network device tap0 > failed to find virtual switch 'public' > booting > bhyveload -m 512M -e autoboot_delay=3D3 -d = /VMs/VM-TEST/../.iso/FreeBSD-13.0-CURRENT-amd64-20190725-r350322-disc1.iso= VM-TEST > [bhyve options: -c 1 -m 512M -AHP -U > ad7532de-bec1-11e9-8a55-d05099c38c95 -u] > [bhyve devices: -s 0,hostbridge -s 31,lpc -s > 4:0,virtio-blk,/VMs/VM-TEST/disk0.img -s > 5:0,virtio-net,tap0,mac=3D58:9c:fc:04:34:69] > [bhyve console: -l com1,stdio] > [bhyve iso device: -s > = 3:0,ahci-cd,/VMs/VM-TEST/../.iso/FreeBSD-13.0-CURRENT-amd64-20190725-r3503= 22-disc1.iso,ro] > starting bhyve (run 1) > bhyve exited with status 1 > destroying network device tap0 > stopped >=20 > Alan was trying to help me debug this yesterday, and I manually ran = bhyve, but > had no errors, and it still didn't work. >=20 > Thanks, >=20 > Sean. > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to = "freebsd-current-unsubscribe@freebsd.org" From owner-freebsd-current@freebsd.org Fri Aug 16 20:07:30 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E3D78AD628 for ; Fri, 16 Aug 2019 20:07:30 +0000 (UTC) (envelope-from sef@kithrup.com) Received: from kithrup.com (kithrup.com [96.79.110.97]) by mx1.freebsd.org (Postfix) with ESMTP id 469DrL23Fyz4hh6; Fri, 16 Aug 2019 20:07:30 +0000 (UTC) (envelope-from sef@kithrup.com) Received: by kithrup.com (Postfix, from userid 1001) id F251D1B85B; Fri, 16 Aug 2019 13:07:28 -0700 (PDT) To: tsoome@me.com Subject: Re: Can't boot current under bhyve on current Cc: freebsd-current@freebsd.org, jhb@FreeBSD.org In-Reply-To: <150E1309-A93F-4DDB-9A21-22609DE51B56@me.com> Message-Id: <20190816200728.F251D1B85B@kithrup.com> Date: Fri, 16 Aug 2019 13:07:28 -0700 (PDT) From: Sean Eric Fagan X-Rspamd-Queue-Id: 469DrL23Fyz4hh6 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of sef@kithrup.com designates 96.79.110.97 as permitted sender) smtp.mailfrom=sef@kithrup.com X-Spamd-Result: default: False [-5.32 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+a]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[kithrup.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.981,0]; IP_SCORE(-2.04)[ip: (-7.39), ipnet: 96.64.0.0/11(-3.62), asn: 7922(0.85), country: US(-0.05)]; FREEMAIL_TO(0.00)[me.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7922, ipnet:96.64.0.0/11, country:US]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 20:07:30 -0000 >Could you test with larger memory setup - instead of 512M, 1-2G? I tried multiple vcpus and 1G of RAM; it made no difference (to either my attempting to boot the system I built, or the ISO; just confirmed the ISO with 1G). Sean. From owner-freebsd-current@freebsd.org Fri Aug 16 20:48:07 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5306CAE516 for ; Fri, 16 Aug 2019 20:48:07 +0000 (UTC) (envelope-from sef@kithrup.com) Received: from kithrup.com (kithrup.com [96.79.110.97]) by mx1.freebsd.org (Postfix) with ESMTP id 469FlB5J4wz4kdY; Fri, 16 Aug 2019 20:48:06 +0000 (UTC) (envelope-from sef@kithrup.com) Received: by kithrup.com (Postfix, from userid 1001) id D9D521B870; Fri, 16 Aug 2019 13:48:05 -0700 (PDT) To: freebsd-current@freebsd.org, jhb@FreeBSD.org Subject: Re: Can't boot current under bhyve on current In-Reply-To: <9933e6ab-63e9-c2ad-94eb-c8654d75ae99@FreeBSD.org> Message-Id: <20190816204805.D9D521B870@kithrup.com> Date: Fri, 16 Aug 2019 13:48:05 -0700 (PDT) From: Sean Eric Fagan X-Rspamd-Queue-Id: 469FlB5J4wz4kdY X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of sef@kithrup.com designates 96.79.110.97 as permitted sender) smtp.mailfrom=sef@kithrup.com X-Spamd-Result: default: False [-5.36 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+a]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[kithrup.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(-2.08)[ip: (-7.54), ipnet: 96.64.0.0/11(-3.63), asn: 7922(0.85), country: US(-0.05)]; NEURAL_HAM_SHORT(-0.98)[-0.982,0]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7922, ipnet:96.64.0.0/11, country:US]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 20:48:07 -0000 Ok, with debug=yes I see that it *is* running the VM -- but I have no serial console? This may be operator error here, which is a big relief. An update after I get back from the vet :). Thanks! Sean. From owner-freebsd-current@freebsd.org Fri Aug 16 21:37:20 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 10E88AFA0F; Fri, 16 Aug 2019 21:37:20 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 469Gqz6dNpz4p37; Fri, 16 Aug 2019 21:37:19 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-4.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4FF0411831; Fri, 16 Aug 2019 21:37:19 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: HEADSUP: drm-current-kmod now installs sources To: Daniel Eischen Cc: freebsd-current@freebsd.org, x11@freebsd.org, current@freebsd.org References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> From: John Baldwin Openpgp: preference=signencrypt Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: <4dab4e01-6910-8874-a457-c0468e5907f3@FreeBSD.org> Date: Fri, 16 Aug 2019 14:37:18 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 21:37:20 -0000 On 8/14/19 3:40 PM, Daniel Eischen wrote: > I've lost the original thread, but would the sources in /usr/local/sys/modules get built regardless of what MAKEOBJDIRPREFIX is? And, now that sources may be installed by a port, what is the method for _just_ updating the sources? Why do I even need to build and install the port? Personally, I would just rather have the drm-kmod sources just imported into base and maintained there. If I have 2 or more different checked out base src trees, how do I get the correct drm-kmod to go with them if there is only one /usr/local/sys/modules? Do I need multiple port trees just to pull in out of tree module sources? In some ways, installing sources for DRM is a compromise for the fact that we can't have DRM in the base source anymore (for various reasons). However, virtualbox is also probably in that camp as well. -- John Baldwin From owner-freebsd-current@freebsd.org Fri Aug 16 21:38:33 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 56495AFC2F for ; Fri, 16 Aug 2019 21:38:33 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 469GsP1cjxz4pDH for ; Fri, 16 Aug 2019 21:38:33 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id 376DCAFC2B; Fri, 16 Aug 2019 21:38:33 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3722AAFC29; Fri, 16 Aug 2019 21:38:33 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 469GsP0bXJz4pDF; Fri, 16 Aug 2019 21:38:33 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-4.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id E06E911832; Fri, 16 Aug 2019 21:38:31 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: HEADSUP: drm-current-kmod now installs sources To: Ian Lepore , Warner Losh Cc: Kyle Evans , x11@freebsd.org, current , Niclas Zeising References: <67ca217f-b7de-8707-c4de-51e3f895d06f@FreeBSD.org> <469b61c7c939b4e70f4304eaeb73eaae9b1d4c9a.camel@freebsd.org> <20190814192353.166bd3e7d1af44a55a61c915@bidouilliste.com> <02c501907f6eca8f4bd9b44331ac6ab2e28d624f.camel@freebsd.org> From: John Baldwin Openpgp: preference=signencrypt Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: Date: Fri, 16 Aug 2019 14:38:30 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 21:38:33 -0000 On 8/14/19 1:19 PM, Ian Lepore wrote: > On Wed, 2019-08-14 at 13:59 -0600, Warner Losh wrote: >> On Wed, Aug 14, 2019 at 1:56 PM Ian Lepore wrote: >> >>> On Wed, 2019-08-14 at 12:00 -0700, John Baldwin wrote: >>>> On 8/14/19 11:06 AM, Kyle Evans wrote: >>>>> LOCAL_MODULES="" does seem like a sensible default when we're >>>>> not >>>>> building a native kernel. >>>> >>>> Unfortunately kern.post.mk has no way of knowing that as >>>> MACHINE_* >>>> are already set to the TARGET_* values by the time this target is >>>> invoked. Also, the 'make tinderbox' use case is a legit use case >>>> that some folks want (for CI, etc.) >>>> >>> >>> BUILDHOST_ARCH!= uname -p >>> .if ${BUILDHOST_ARCH} != ${TARGET_ARCH} >>> >>> Unfortunately, I don't think it's as easy to compare the buildhost >>> running version with the version of source being built, unless the >>> build is started from the top level so that Makefile.inc1 sets the >>> variables. >>> >> >> We already know MACHINE_ARCH != TARGET_ARCH in Makefile.inc1 and >> already do >> different things based on it. But to be honest, I'd think there'd be >> times >> I'd absolutely want to build them all, and other times I wouldn't >> which >> strongly suggests some kind of knob specific for cross building the >> port/pkg-based kernel modules. We could then pass that knob into the >> kernel >> builds which would then not try to guess whether or not to build >> LOCAL_MODULES... >> >> > > This is just about AUTOMATICALLY deciding to build something, based on > the presence of source code in an arbitrary fixed location outside of > the source tree on the build machine. Anything set by the user should > be honored without question, including LOCAL_MODULES. > > My point is only that the build machinery should not be deciding to > build something the user didn't specify based on the existence of out- > of-tree files on the build machine (I'd like to put the period right > here in this sentence), unless there's a very high likelyhood that the > build being done is for the build machine. > > Things like CI that want to include more than in-tree sources as part > of the build should be handling that by setting appropriate knobs as > part of invoking the build. I talked with Warner some offline and I think having some knob that controls whether or not LOCAL_MODULES auto-populates and having make buildkernel default it to on/off for native/cross builds (but it can always be forcefully set on the command line) is fine with me. -- John Baldwin From owner-freebsd-current@freebsd.org Fri Aug 16 21:51:25 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0ABC0B08C9; Fri, 16 Aug 2019 21:51:25 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 469H8D5spBz4q3b; Fri, 16 Aug 2019 21:51:24 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x7GLpMhA032598; Fri, 16 Aug 2019 14:51:22 -0700 (PDT) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: (from freebsd-rwg@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x7GLpMqf032597; Fri, 16 Aug 2019 14:51:22 -0700 (PDT) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <201908162151.x7GLpMqf032597@gndrsh.dnsmgr.net> Subject: Re: HEADSUP: drm-current-kmod now installs sources In-Reply-To: <4dab4e01-6910-8874-a457-c0468e5907f3@FreeBSD.org> To: John Baldwin Date: Fri, 16 Aug 2019 14:51:22 -0700 (PDT) CC: Daniel Eischen , freebsd-current@freebsd.org, x11@freebsd.org, current@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 469H8D5spBz4q3b X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.93 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.93)[-0.934,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 21:51:25 -0000 > On 8/14/19 3:40 PM, Daniel Eischen wrote: > > I've lost the original thread, but would the sources in /usr/local/sys/modules get built regardless of what MAKEOBJDIRPREFIX is? And, now that sources may be installed by a port, what is the method for _just_ updating the sources? Why do I even need to build and install the port? Personally, I would just rather have the drm-kmod sources just imported into base and maintained there. If I have 2 or more different checked out base src trees, how do I get the correct drm-kmod to go with them if there is only one /usr/local/sys/modules? Do I need multiple port trees just to pull in out of tree module sources? > > In some ways, installing sources for DRM is a compromise for the fact that we > can't have DRM in the base source anymore (for various reasons). However, > virtualbox is also probably in that camp as well. I applaud this effort to provide a source compile mode for DRM, but I think it has come up a bit short on execution with numorious problems sited. I too am not real happy that /usr/local/src is going to get automatically invoked from my some odd 10+ src trees that are of various WIP's. I need a way to easily disable this both on a global scale, and on a per src tree way. Rather than a default to on with an opt out mechanism perhaps while we gain experience change this to a default to off with an opt in mechanism? Sadly I do not have proposed solution, but something better than what is there now needs to be found. Regards, -- Rod Grimes rgrimes@freebsd.org From owner-freebsd-current@freebsd.org Fri Aug 16 22:16:59 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A9C4DB130A for ; Fri, 16 Aug 2019 22:16:59 +0000 (UTC) (envelope-from sef@kithrup.com) Received: from kithrup.com (kithrup.com [96.79.110.97]) by mx1.freebsd.org (Postfix) with ESMTP id 469Hjk65DWz4rBH; Fri, 16 Aug 2019 22:16:58 +0000 (UTC) (envelope-from sef@kithrup.com) Received: by kithrup.com (Postfix, from userid 1001) id 5B4B61B8A4; Fri, 16 Aug 2019 15:16:57 -0700 (PDT) To: freebsd-current@freebsd.org, jhb@FreeBSD.org Subject: Re: Can't boot current under bhyve on current Message-Id: <20190816221657.5B4B61B8A4@kithrup.com> Date: Fri, 16 Aug 2019 15:16:57 -0700 (PDT) From: Sean Eric Fagan X-Rspamd-Queue-Id: 469Hjk65DWz4rBH X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of sef@kithrup.com designates 96.79.110.97 as permitted sender) smtp.mailfrom=sef@kithrup.com X-Spamd-Result: default: False [-4.32 / 15.00]; ARC_NA(0.00)[]; FAKE_REPLY(1.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+a]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[kithrup.com]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(-2.04)[ip: (-7.38), ipnet: 96.64.0.0/11(-3.62), asn: 7922(0.85), country: US(-0.05)]; NEURAL_HAM_SHORT(-0.98)[-0.981,0]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7922, ipnet:96.64.0.0/11, country:US]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 22:16:59 -0000 Ok, if I run the bhyve commands manually, then I get a serial console. So something is just borked with vm-bhyve and its use of tmux. Whew. (Now I don't know *what*, but that's at least progress in my diagnosis!) From owner-freebsd-current@freebsd.org Fri Aug 16 22:26:31 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 462B4B166F for ; Fri, 16 Aug 2019 22:26:31 +0000 (UTC) (envelope-from clay.daniels.jr@gmail.com) Received: from mail-ua1-x92e.google.com (mail-ua1-x92e.google.com [IPv6:2607:f8b0:4864:20::92e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 469Hwk3z6yz4rbn for ; Fri, 16 Aug 2019 22:26:30 +0000 (UTC) (envelope-from clay.daniels.jr@gmail.com) Received: by mail-ua1-x92e.google.com with SMTP id y7so2409788uae.10 for ; Fri, 16 Aug 2019 15:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iAuN3IZUwUjdWKZnfPdeh275rmVRlRhUkRSc+Rpu0e0=; b=ICcAOOjJywkgS74g1KKY1S414EwQBqAkxCxL3qLClKEOktwI2WPvUCNK0VFhPP4X5P r1cqgIqa3ifyxldlbILabe4DKTe9GluMCQ4ZHu/OuVwbrmbfnEXAHyP0/QkPT/jH9pA4 kLr+ONb2/47DLxWR1ZYMPInEATr8b0ZK2l/2+ulVz7c0XlD8OvkagueNk5DukIzckonZ a/T/rrMeEtDVZEqCi/72k3iu7jSHlzJMROb3eJ4FEmO5CqbV3Ek4AP0+mZgHlG4UAoAx /JGnz/IUvqHsrq+fKuucfKtDdOH9yjypn0Hd7VpLVYY8x2qMz8XcK9D6zG7PyttMbYUc 2+wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iAuN3IZUwUjdWKZnfPdeh275rmVRlRhUkRSc+Rpu0e0=; b=oVIoqSVU/bJasZwxf1SogthoWgSRYFYzHv2lME4Yp5Ucmn5TUCzEVIw4HwXsFR3Cys JpyOjqmvEWxWRmKsoMSMWQJpteZnilbiHe6Lz++llaEF74Q+otGGOkVRaT7nvj+8tP8H Mke69vXr+PWlR3OOICrhYbey9mEBIkoiGbvXaWhHjEgW1R3JvodAUVwFMWITiSMcEHDP gUvQTIS8dB3MkuBrqtPvmpZdsy9XbhvBdM+VXCQbYfq+THBNKU+CQkoMsnyoalrLS4mS FNwJl2qPI7uHQu2ShsUgoJS6ZdsWL3KK/amLlUmYX3LUWWiuoBLI4OREs2qhW83exq+x eu+Q== X-Gm-Message-State: APjAAAXFf8yn3k25aq2cHTcv1xetehQmSPza/RO0xo08d0kjDzuOOZoY bVm/WFIvhT8K6iTeVGqTHMt+do/rO4PPj8U6Yw== X-Google-Smtp-Source: APXvYqwVsstddFj7BMGVwZh/Ru/2JrIiqnx69Jb81f8C0LDC6GREBj2vpGVKIK4fBnkXOnqdmpFJ/1PRB/0XaoyJn5Q= X-Received: by 2002:a9f:326f:: with SMTP id y44mr2254155uad.50.1565994388975; Fri, 16 Aug 2019 15:26:28 -0700 (PDT) MIME-Version: 1.0 References: <2972dce1-a7ff-4411-fd82-3336b6c319a2@gmail.com> In-Reply-To: <2972dce1-a7ff-4411-fd82-3336b6c319a2@gmail.com> From: "Clay Daniels Jr." Date: Fri, 16 Aug 2019 17:26:16 -0500 Message-ID: Subject: Re: 13.0 Current - r350702 exposed a Xorg failure To: Graham Perrin Cc: "freebsd-current@freebsd.org" X-Rspamd-Queue-Id: 469Hwk3z6yz4rbn X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=ICcAOOjJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of claydanielsjr@gmail.com designates 2607:f8b0:4864:20::92e as permitted sender) smtp.mailfrom=claydanielsjr@gmail.com X-Spamd-Result: default: False [-4.00 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-0.998,0]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-9.62), ipnet: 2607:f8b0::/32(-2.96), asn: 15169(-2.38), country: US(-0.05)]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[e.2.9.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 22:26:31 -0000 Graham, I loaded yesterday's new 13.0 Current r351067 snapshot and re-installed FreeBSD. The basic install went well, and I gave my user operator, wheel, & video permissions. I loaded Xorg via the pkg install route, all 172 packages. I installed the drm-kmod pkg too. I rebooted and ran startx as user and it failed, basically did not create the .serverauth file. I pressed forward and did the install of my desktop, LXDE, with it's config files. Still no go. I have looked at your good suggestions and the results are at the end of this message. I had to copy them to paper as best I could. I guess you saw John Baldwin's email of 13 Aug about the changes in drm-kmod. I played with my /etc/rc.conf and set the line to leave out the path (/boot/modules/), just "kld_list="amdgpu.ko". That didn't work either. I was wondering at that point if Pete Wright may be on track with his suggestion that the permissions were set to root, but I don't think so, as it all seems to be user - user in the user home directory, root - wheel in /usr/local/bin where start lives, and root-wheel in /boot/modules where the kmod files are. Then I started playing with the /etc/rc.conf file and got some interesting results. My machine is an HP All in One thing manufactured in 2014. It has a AMD E3 processor with integrated Radeon graphics. I had been using the newer "amdgpu.ko" module for some weeks, at least through installs of Gnome, KDE, Xfce, and two or three weeks of LXDE and it worked fine. I tried first using John Baldwin's sugestion to leave out the path. Thant didn't work, and I really think this advice was for those who are 1. Installing from ports, not pkg, and 2. Compiling these modules into their kernel. Neither apply to me, at least not yet, but I'm always ready to try if needed. This is where it gets real interesting: I tried the older "radeonkms.ko", and rebooted. The loading messages did not look promising, but no real errors either. When I ran startx, it tried to load. I got a white screen, that changed to a blank one after "some" time, and was unresponsive. I had to use the power button to shutdown Bnd guess what? When I rebooted and performed a post-mortum, it had created an .serverauth file. So it makes we think the permissions are ok, but there are some problems with my machine and the amd kmod files. I looked in /boot/modules and both amdgpu.ko & radeonkms.ko had dates of Aug 11. So the problem keeps shifting, but I'm working on it. pkg info | grep kmod : drm-current-kmod-4.16.g20190806 DRM Modules for the linuxkpi-base KMS components drm-kmod-g20190806 Metaport of DRM Modules for the linuxkpi-base KMS components gpu-firmware-g20190620 pciconf -lv | grep -C 3 display : 6 lines that confirm my video setup: Kabini/Radeon HD 8280/R3 series AMD/ATI VGA grep PORTS_MODULES /etc/make.conf: FILE/DIRECTORY NOT FOUND pkg rquery %e drm-kmod : Message about the basic DRM metaport, no hard info, looks like a sales pitch :) Anyway, I continue to work on this, one step at a time. Open to any & all corrections and suggestions. The base install of r351067 is good, and I installed ports this time, so I may do a pkg delete drm-kmod and make it from the ports. Maybe it would suit my machine better. Clay On Wed, Aug 14, 2019 at 3:09 AM Graham Perrin wrote: > On 10/08/2019 04:56, Clay Daniels Jr. wrote: > > drm-kmod was the same (g20190710) > > It's equally (if not more) important to consider what's installed by > drm-kmod. > > Can you share output from these three commands? > > pkg info | grep kmod > > pciconf -lv | grep -C 3 display > > grep PORTS_MODULES /etc/make.conf > > Thanks. > > Also, FYI (to help understand the purpose of drm-kmod): > > pkg rquery %e drm-kmod > > From owner-freebsd-current@freebsd.org Fri Aug 16 22:40:52 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 219F9B1C40; Fri, 16 Aug 2019 22:40:52 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 469JFG6hF5z4sQ7; Fri, 16 Aug 2019 22:40:50 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id yktqhaQIhUIS2yktrhKmD8; Fri, 16 Aug 2019 16:40:48 -0600 X-Authority-Analysis: v=2.3 cv=N41X6F1B c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=FmdZ9Uzk2mMA:10 a=iKhvJSA4AAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=7aF8kCKqjz_Xlu4tSrwA:9 a=QEXdDO2ut3YA:10 a=odh9cflL3HIXMm4fY7Wr:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from 5CG5030TVK-N.esitwifi.local (S0106788a207e2972.gv.shawcable.net [70.66.154.233]) by spqr.komquats.com (Postfix) with ESMTPSA id B5A9464B; Fri, 16 Aug 2019 15:40:45 -0700 (PDT) Date: Fri, 16 Aug 2019 15:40:24 -0700 In-Reply-To: <201908162151.x7GLpMqf032597@gndrsh.dnsmgr.net> References: <201908162151.x7GLpMqf032597@gndrsh.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: HEADSUP: drm-current-kmod now installs sources To: freebsd-current@freebsd.org, "Rodney W. Grimes" , John Baldwin CC: Daniel Eischen ,x11@freebsd.org,current@freebsd.org From: Cy Schubert Message-ID: <5B38128E-4CC9-496B-A9FD-B4208B7C044D@cschubert.com> X-CMAE-Envelope: MS4wfPiGl0NtGPJxHJqo6QiBbFZ4VdkrtiRAZvWCloHznRUcIfe0FWCWE0oR//n4+H6RtzSFBzUDKL6BVV0qbDNuSBlbAI0h2ikNJoI7g1TB4+QZ9V1+zw+R ynjHbryA3dKAApzAbblKqZZxvQHBGQonwJ2cjrFZDkBHi85KRObIwLp4YsijYGcqQEfw6VB/Mu2mkOkH8HpiJpk51rql+SGq+2id1xsVTjckz6cpvuXu+0hK fmvTTVz7WfnvTAHugL5QTkiABr8lcWFbRrbh8IeWojdRKdfVOOFFDizKQe2cQJYhW10tB/mPfFmQ2JfKdziVPiNC8pVUQeA8PoilfJa5R1QbjbTnf6sbD9gq K0ks4reK X-Rspamd-Queue-Id: 469JFG6hF5z4sQ7 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 64.59.134.12) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-5.49 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.93)[-0.935,0]; RCVD_IN_DNSWL_NONE(0.00)[12.134.59.64.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; MID_RHS_MATCH_FROM(0.00)[]; IP_SCORE(-2.46)[ip: (-6.58), ipnet: 64.59.128.0/20(-3.16), asn: 6327(-2.45), country: CA(-0.09)]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11, 233.154.66.70.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 22:40:52 -0000 On August 16, 2019 2:51:22 PM PDT, "Rodney W=2E Grimes" wrote: >> On 8/14/19 3:40 PM, Daniel Eischen wrote: >> > I've lost the original thread, but would the sources in >/usr/local/sys/modules get built regardless of what MAKEOBJDIRPREFIX >is? And, now that sources may be installed by a port, what is the >method for _just_ updating the sources? Why do I even need to build >and install the port? Personally, I would just rather have the >drm-kmod sources just imported into base and maintained there=2E If I >have 2 or more different checked out base src trees, how do I get the >correct drm-kmod to go with them if there is only one >/usr/local/sys/modules? Do I need multiple port trees just to pull in >out of tree module sources? >>=20 >> In some ways, installing sources for DRM is a compromise for the fact >that we >> can't have DRM in the base source anymore (for various reasons)=2E=20 >However, >> virtualbox is also probably in that camp as well=2E > >I applaud this effort to provide a source compile mode for DRM, >but I think it has come up a bit short on execution with numorious >problems sited=2E > >I too am not real happy that /usr/local/src is going to get >automatically invoked from my some odd 10+ src trees that >are of various WIP's=2E I need a way to easily disable this >both on a global scale, and on a per src tree way=2E > >Rather than a default to on with an opt out mechanism perhaps >while we gain experience change this to a default to off with >an opt in mechanism? > >Sadly I do not have proposed solution, but something better >than what is there now needs to be found=2E > >Regards, Could we have a =2Esrc=2Econf in the root of the tree to configure this on= a tree by tree basis? --=20 Pardon the typos and autocorrect, small keyboard in use=2E Cheers, Cy Schubert FreeBSD UNIX: Web: http://www=2EFreeBSD=2Eorg The need of the many outweighs the greed of the few=2E From owner-freebsd-current@freebsd.org Fri Aug 16 22:52:13 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A6295B2404; Fri, 16 Aug 2019 22:52:13 +0000 (UTC) (envelope-from rozhuk.im@gmail.com) Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 469JVN5Cs3z4t6n; Fri, 16 Aug 2019 22:52:12 +0000 (UTC) (envelope-from rozhuk.im@gmail.com) Received: by mail-ed1-x544.google.com with SMTP id z51so6385806edz.13; Fri, 16 Aug 2019 15:52:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QQ+P+Ng5tnxhRu45jXcajLHerEMcrD0CHXDjrmPmXZk=; b=oAkVQDXsjVGaz7AzwWaxOhPgac7zM5jUEezxE8aGS/XhYhdEiynK+QvkD4qQm/BMq1 N8RpuogFIqevg6B7tSDLeE0vPnBHnzGheS82WeXoD6hobxcMrHn0g3QfXbjaNOeariEG ojDgkK40n5JikezVne9O9h6NkjeoQkq0TVIkezondw3sJjUPGWNWnxqczUJNXRnUPfMq 7vXcDP8JQDweoyXbEMw+SQWD7MhwB1WNp0fQ3TChdHAWqBZagHmyLwNqc36J30KX04nn F9iDkhGGVUcRboNejymY6R/M8XIv0VmEyodHVtzhQ+q2vO7i3LfQwWrskUJz4idTVi10 096Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QQ+P+Ng5tnxhRu45jXcajLHerEMcrD0CHXDjrmPmXZk=; b=LKZnKuK88Bisf7TUR6HPv8DoFpgalKwv4bPLM7rnQ2iDQRBLaKlsSZLyu6LOdhd48Z u74JdmE3JThofplDchTEzAXIpnwZno6i8r1/Pan6jUF+8Bz06XlO0Fm6y5qI+DJBkyy8 DKC2Mn3ylu2a70C6ZcRF2P4pUPZmgsWgvsaIj4C2RUAexAHTL62x99+rIO+W3QjytZbZ ZVcT4KYRd9kcgeib2sjq4ok9I7IyfISgE9S5ouR23OzhJHNvpe39+00I9BBXDw6j/sQK ThRT6mAsHzZg/xU5SbIDL9AaSI7JTb89CgDHmuVa0xZkR0zlbf8JU74MjoFSZSmfdOiI 3+ng== X-Gm-Message-State: APjAAAV8SRk+Ytk/iwEjAhE+yu44PoEftlFE0a8Uuj+FdsnAtZ1xFZ7n 2koIJFCfEfDp5p8XbOOqX3zklitQ X-Google-Smtp-Source: APXvYqyQxaO+2Ng9MUosAbfqGtcIrOKUd/0krFLe8LGJeh97s5UA/kKbxToK7NYZwxQrR92YNDFtDg== X-Received: by 2002:a50:ee0d:: with SMTP id g13mr13586848eds.113.1565995931280; Fri, 16 Aug 2019 15:52:11 -0700 (PDT) Received: from rimwks ([2001:470:1f15:3d8:7285:c2ff:fe37:5722]) by smtp.gmail.com with ESMTPSA id a18sm977738ejp.2.2019.08.16.15.52.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2019 15:52:10 -0700 (PDT) From: Rozhuk Ivan X-Google-Original-From: Rozhuk Ivan Date: Sat, 17 Aug 2019 01:52:08 +0300 To: Cy Schubert Cc: freebsd-current@freebsd.org, "Rodney W. Grimes" , John Baldwin , Daniel Eischen , x11@freebsd.org, current@freebsd.org Subject: Re: HEADSUP: drm-current-kmod now installs sources Message-ID: <20190817015208.2c8c29e0@rimwks> In-Reply-To: <5B38128E-4CC9-496B-A9FD-B4208B7C044D@cschubert.com> References: <201908162151.x7GLpMqf032597@gndrsh.dnsmgr.net> <5B38128E-4CC9-496B-A9FD-B4208B7C044D@cschubert.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd12.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 469JVN5Cs3z4t6n X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=oAkVQDXs; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of rozhukim@gmail.com designates 2a00:1450:4864:20::544 as permitted sender) smtp.mailfrom=rozhukim@gmail.com X-Spamd-Result: default: False [-3.48 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCPT_COUNT_SEVEN(0.00)[7]; NEURAL_HAM_SHORT(-0.98)[-0.978,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(0.00)[ip: (-0.16), ipnet: 2a00:1450::/32(-3.03), asn: 15169(-2.38), country: US(-0.05)]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[4.4.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 22:52:13 -0000 On Fri, 16 Aug 2019 15:40:24 -0700 Cy Schubert wrote: > On August 16, 2019 2:51:22 PM PDT, "Rodney W. Grimes" > wrote: > >> On 8/14/19 3:40 PM, Daniel Eischen wrote: > >> > I've lost the original thread, but would the sources in > >/usr/local/sys/modules get built regardless of what MAKEOBJDIRPREFIX > >is? And, now that sources may be installed by a port, what is the > >method for _just_ updating the sources? Why do I even need to build > >and install the port? Personally, I would just rather have the > >drm-kmod sources just imported into base and maintained there. If I > >have 2 or more different checked out base src trees, how do I get the > >correct drm-kmod to go with them if there is only one > >/usr/local/sys/modules? Do I need multiple port trees just to pull > >in out of tree module sources? > >> > >> In some ways, installing sources for DRM is a compromise for the > >> fact > >that we > >> can't have DRM in the base source anymore (for various reasons). > >However, > >> virtualbox is also probably in that camp as well. > > > >I applaud this effort to provide a source compile mode for DRM, > >but I think it has come up a bit short on execution with numorious > >problems sited. > > > >I too am not real happy that /usr/local/src is going to get > >automatically invoked from my some odd 10+ src trees that > >are of various WIP's. I need a way to easily disable this > >both on a global scale, and on a per src tree way. > > > >Rather than a default to on with an opt out mechanism perhaps > >while we gain experience change this to a default to off with > >an opt in mechanism? > > > >Sadly I do not have proposed solution, but something better > >than what is there now needs to be found. > > > >Regards, > > Could we have a .src.conf in the root of the tree to configure this > on a tree by tree basis? > > I use better way: /etc/make.conf: # Modules to build with kernel. PORTS_MODULES+= graphics/drm-fbsd12.0-kmod graphics/gpu-firmware-kmod + https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237290 From owner-freebsd-current@freebsd.org Fri Aug 16 23:32:29 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BF807B3164; Fri, 16 Aug 2019 23:32:29 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 469KNr1tjgz4vWG; Fri, 16 Aug 2019 23:32:27 +0000 (UTC) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x7GNWJ0T033027; Fri, 16 Aug 2019 16:32:19 -0700 (PDT) (envelope-from freebsd-rwg@gndrsh.dnsmgr.net) Received: (from freebsd-rwg@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id x7GNWI3x033026; Fri, 16 Aug 2019 16:32:18 -0700 (PDT) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <201908162332.x7GNWI3x033026@gndrsh.dnsmgr.net> Subject: Re: HEADSUP: drm-current-kmod now installs sources In-Reply-To: <20190817015208.2c8c29e0@rimwks> To: Rozhuk Ivan Date: Fri, 16 Aug 2019 16:32:18 -0700 (PDT) CC: Cy Schubert , freebsd-current@freebsd.org, "Rodney W. Grimes" , John Baldwin , Daniel Eischen , x11@freebsd.org, current@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 469KNr1tjgz4vWG X-Spamd-Bar: +++ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd-rwg@gndrsh.dnsmgr.net has no SPF policy when checking 69.59.192.140) smtp.mailfrom=freebsd-rwg@gndrsh.dnsmgr.net X-Spamd-Result: default: False [3.11 / 15.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(0.35)[0.345,0]; RCVD_TLS_LAST(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[dnsmgr.net]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.22)[0.221,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; IP_SCORE(0.05)[ip: (0.15), ipnet: 69.59.192.0/19(0.08), asn: 13868(0.05), country: US(-0.05)]; NEURAL_SPAM_LONG(0.10)[0.101,0]; RCPT_COUNT_SEVEN(0.00)[8]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; MID_RHS_MATCH_FROM(0.00)[]; SUSPICIOUS_RECIPS(1.50)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Aug 2019 23:32:29 -0000 > On Fri, 16 Aug 2019 15:40:24 -0700 > Cy Schubert wrote: > > > On August 16, 2019 2:51:22 PM PDT, "Rodney W. Grimes" > > wrote: > > >> On 8/14/19 3:40 PM, Daniel Eischen wrote: > > >> > I've lost the original thread, but would the sources in > > >/usr/local/sys/modules get built regardless of what MAKEOBJDIRPREFIX > > >is? And, now that sources may be installed by a port, what is the > > >method for _just_ updating the sources? Why do I even need to build > > >and install the port? Personally, I would just rather have the > > >drm-kmod sources just imported into base and maintained there. If I > > >have 2 or more different checked out base src trees, how do I get the > > >correct drm-kmod to go with them if there is only one > > >/usr/local/sys/modules? Do I need multiple port trees just to pull > > >in out of tree module sources? > > >> > > >> In some ways, installing sources for DRM is a compromise for the > > >> fact > > >that we > > >> can't have DRM in the base source anymore (for various reasons). > > >However, > > >> virtualbox is also probably in that camp as well. > > > > > >I applaud this effort to provide a source compile mode for DRM, > > >but I think it has come up a bit short on execution with numorious > > >problems sited. > > > > > >I too am not real happy that /usr/local/src is going to get > > >automatically invoked from my some odd 10+ src trees that > > >are of various WIP's. I need a way to easily disable this > > >both on a global scale, and on a per src tree way. > > > > > >Rather than a default to on with an opt out mechanism perhaps > > >while we gain experience change this to a default to off with > > >an opt in mechanism? > > > > > >Sadly I do not have proposed solution, but something better > > >than what is there now needs to be found. > > > > > >Regards, > > > > Could we have a .src.conf in the root of the tree to configure this > > on a tree by tree basis? > > > > > > > I use better way: > /etc/make.conf: That file is global to all src trees, so that does not achive the desired effect. > # Modules to build with kernel. > PORTS_MODULES+= graphics/drm-fbsd12.0-kmod graphics/gpu-firmware-kmod Can we some how trigger that from either a kernel conf file, or at least on a per src tree basis? Ala cy's .src.conf? > + > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237290 I do like the patch that makes these go into the obj dir, good stuff! -- Rod Grimes rgrimes@freebsd.org From owner-freebsd-current@freebsd.org Sat Aug 17 00:07:40 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6CF37B4092; Sat, 17 Aug 2019 00:07:40 +0000 (UTC) (envelope-from rozhuk.im@gmail.com) Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 469L9R1XHlz3CqK; Sat, 17 Aug 2019 00:07:39 +0000 (UTC) (envelope-from rozhuk.im@gmail.com) Received: by mail-ed1-x543.google.com with SMTP id g8so6506247edm.6; Fri, 16 Aug 2019 17:07:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WinDpy/Q1jb1jU809ItR6dn2vuwbvrym9xl5bB9Eiao=; b=TsFIDjIljm6S+FHmQe0122P+lc9/ljD2j5tEU6BHWGsK2LcvedkAXxZkJxIoqUz5FK T9mjnq4rEeofMNjjIWbMhgSIvCry+4HTeyFb5jkewT3wKVjZ9/x900jMZ0AFe9dNwttf 1K16dx3IDgzxnlfrkW0jM1nxnSZf85mZhVGGt6usLbCE0iSdE/45QOaRJYEoeKV0SVHw FqLm0Q7xYOSLdGWcdEJ8C4In4BrK4qpjS5mAhbL8JfIIXCJZfvZmiTm+jeN+Q00ZtC52 CRc5eVAmKgPFGWUnsL6Pa8A6+kyJlJ6i+iBxgg8LYXrIynEjSIxzPy/yzSC4BCtXS8o0 qR1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WinDpy/Q1jb1jU809ItR6dn2vuwbvrym9xl5bB9Eiao=; b=jc6DG4nAyqWkFKo4TRT3kKL5KWRxOAq9+thbZ7EaZlFUD5NJ79xbOFTR3uBL1iRxKC OTxBxRhiXZwxgxg8lnsT1A8rbVKFmkhVkXudEUy4AcuwUDAk+d/nivaATBw2y46hW/Qe wNLTDxcuQP7ZUo/zSwzmSL4rc7cSlrWsxAwb1ZFQ2pMgEaLQB/osdnl4u59/7nq6Wqdz lDRNelj8JI0+JaRG/kV1xqjUdZA+j6qQw4ZMqj1h2MkfEbxM6qxry6VxOhTP1ai2qL4T KJhxp4iNNceiPPNBAbq7z03usu2oDfBxg+wOfWGzckooXcK17nxGVJ4/8l4HWufjI/qg XJEA== X-Gm-Message-State: APjAAAXUtukdVZ1uqQXdNBd/I4NmkW2D2a9RFthgvozGLsRBNM1lsMXt F5ghEgo3rPWDgfVl6AhOFto= X-Google-Smtp-Source: APXvYqxnpOroV014lgagMcuLb4Blwv3Il/qoCnNfNuYMXuckcVScNbGAXDeI1DZ5iK1MsNDmfCoijA== X-Received: by 2002:a17:906:2642:: with SMTP id i2mr2916369ejc.202.1566000457723; Fri, 16 Aug 2019 17:07:37 -0700 (PDT) Received: from rimwks ([2001:470:1f15:3d8:7285:c2ff:fe37:5722]) by smtp.gmail.com with ESMTPSA id h2sm1346504edr.16.2019.08.16.17.07.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2019 17:07:36 -0700 (PDT) From: Rozhuk Ivan X-Google-Original-From: Rozhuk Ivan Date: Sat, 17 Aug 2019 03:07:35 +0300 To: "Rodney W. Grimes" Cc: Cy Schubert , freebsd-current@freebsd.org, John Baldwin , Daniel Eischen , x11@freebsd.org, current@freebsd.org Subject: Re: HEADSUP: drm-current-kmod now installs sources Message-ID: <20190817030735.49627ae5@rimwks> In-Reply-To: <201908162332.x7GNWI3x033026@gndrsh.dnsmgr.net> References: <20190817015208.2c8c29e0@rimwks> <201908162332.x7GNWI3x033026@gndrsh.dnsmgr.net> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd12.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 469L9R1XHlz3CqK X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=TsFIDjIl; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of rozhukim@gmail.com designates 2a00:1450:4864:20::543 as permitted sender) smtp.mailfrom=rozhukim@gmail.com X-Spamd-Result: default: False [-3.48 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCPT_COUNT_SEVEN(0.00)[7]; NEURAL_HAM_SHORT(-0.98)[-0.979,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(0.00)[ip: (0.03), ipnet: 2a00:1450::/32(-3.03), asn: 15169(-2.38), country: US(-0.05)]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TAGGED_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[3.4.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.5.4.1.0.0.a.2.list.dnswl.org : 127.0.5.0]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Aug 2019 00:07:40 -0000 On Fri, 16 Aug 2019 16:32:18 -0700 (PDT) "Rodney W. Grimes" wrote: > > > >> > I've lost the original thread, but would the sources in > > > >/usr/local/sys/modules get built regardless of what > > > >MAKEOBJDIRPREFIX is? And, now that sources may be installed by > > > >a port, what is the method for _just_ updating the sources? Why > > > >do I even need to build and install the port? Personally, I > > > >would just rather have the drm-kmod sources just imported into > > > >base and maintained there. If I have 2 or more different > > > >checked out base src trees, how do I get the correct drm-kmod to > > > >go with them if there is only one /usr/local/sys/modules? Do I > > > >need multiple port trees just to pull in out of tree module > > > >sources? > > > >> > > > >> In some ways, installing sources for DRM is a compromise for > > > >> the fact > > > >that we > > > >> can't have DRM in the base source anymore (for various > > > >> reasons). > > > >However, > > > >> virtualbox is also probably in that camp as well. > > > > > > > >I applaud this effort to provide a source compile mode for DRM, > > > >but I think it has come up a bit short on execution with > > > >numorious problems sited. > > > > > > > >I too am not real happy that /usr/local/src is going to get > > > >automatically invoked from my some odd 10+ src trees that > > > >are of various WIP's. I need a way to easily disable this > > > >both on a global scale, and on a per src tree way. > > > > > > > >Rather than a default to on with an opt out mechanism perhaps > > > >while we gain experience change this to a default to off with > > > >an opt in mechanism? > > > > > > > >Sadly I do not have proposed solution, but something better > > > >than what is there now needs to be found. > > > > > > > > > > Could we have a .src.conf in the root of the tree to configure > > > this on a tree by tree basis? > > > > > > > > > > > > I use better way: > > /etc/make.conf: > > That file is global to all src trees, > so that does not achive the desired effect. You can override this using env __MAKE_CONF=PATH_TO_MAKE.CONF SRCCONF=PATH_TO_SRC.CONF > > # Modules to build with kernel. > > PORTS_MODULES+= graphics/drm-fbsd12.0-kmod > > graphics/gpu-firmware-kmod > > Can we some how trigger that from either a kernel conf file, > or at least on a per src tree basis? Ala cy's .src.conf? I dont know, never use it. From owner-freebsd-current@freebsd.org Sat Aug 17 00:23:13 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1A17DB4B97; Sat, 17 Aug 2019 00:23:13 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 469LWN6txNz3Dry; Sat, 17 Aug 2019 00:23:12 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-4.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 9287612C3D; Sat, 17 Aug 2019 00:23:10 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: HEADSUP: drm-current-kmod now installs sources To: Rozhuk Ivan , Cy Schubert Cc: freebsd-current@freebsd.org, "Rodney W. Grimes" , Daniel Eischen , x11@freebsd.org, current@freebsd.org References: <201908162151.x7GLpMqf032597@gndrsh.dnsmgr.net> <5B38128E-4CC9-496B-A9FD-B4208B7C044D@cschubert.com> <20190817015208.2c8c29e0@rimwks> From: John Baldwin Openpgp: preference=signencrypt Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: Date: Fri, 16 Aug 2019 17:23:08 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <20190817015208.2c8c29e0@rimwks> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Aug 2019 00:23:13 -0000 On 8/16/19 3:52 PM, Rozhuk Ivan wrote: > On Fri, 16 Aug 2019 15:40:24 -0700 > I use better way: > /etc/make.conf: > # Modules to build with kernel. > PORTS_MODULES+= graphics/drm-fbsd12.0-kmod graphics/gpu-firmware-kmod This doesn't work for folks who use pre-built packages. -- John Baldwin From owner-freebsd-current@freebsd.org Sat Aug 17 00:23:47 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 72BEEB4CBE; Sat, 17 Aug 2019 00:23:47 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 469LX15PHGz3F21; Sat, 17 Aug 2019 00:23:45 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id ymVRh0grYsAGkymVShHE52; Fri, 16 Aug 2019 18:23:43 -0600 X-Authority-Analysis: v=2.3 cv=WeVylHpX c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=xqWC_Br6kY4A:10 a=FmdZ9Uzk2mMA:10 a=iKhvJSA4AAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=0Mig3gVM4nSJ48BHbokA:9 a=QEXdDO2ut3YA:10 a=odh9cflL3HIXMm4fY7Wr:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from [IPv6:2605:8d80:401:2fea:944b:68e3:c0df:ed4] (unknown [72.143.237.225]) by spqr.komquats.com (Postfix) with ESMTPSA id 33FE16FC; Fri, 16 Aug 2019 17:23:40 -0700 (PDT) Date: Fri, 16 Aug 2019 17:23:20 -0700 In-Reply-To: <201908162332.x7GNWI3x033026@gndrsh.dnsmgr.net> References: <201908162332.x7GNWI3x033026@gndrsh.dnsmgr.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: HEADSUP: drm-current-kmod now installs sources To: "Rodney W. Grimes" , Rozhuk Ivan CC: freebsd-current@freebsd.org, John Baldwin , Daniel Eischen , x11@freebsd.org, current@freebsd.org From: Cy Schubert Message-ID: X-CMAE-Envelope: MS4wfMlAH6Biq7uF++pWN5tWQxaYYl+D1/TFB0kNVJ5QfioHzjgDC6AiCQmcC0RmXECiTrlvkGkcAxNCiKGzWmQz/DcMkbSgbuJ85O0FATV3nTa/ZG2ZpKE/ 4/cE6qrhOOJzAaLrCSlMuq2EjlZQSlthIYbGaqr/SW0/0mtdiYCU6Meu2yVPBejdrpDNsz8RYLh1NDVaXccsJpZkv0UYyYuBq94neXQWPn9E1+LnKxd2ysmR gd580QUB+INN/qQjOfDXAgPPBIpluYYLaaP0LRpc/WIfJW7HJgh9DNwvRyvpKVwN5m3ALCKR1M0dOkxlRpuucknxhYt0Xnys6W/Uu3v2wPmP/FJmCUKDOsrh dWKRhaKd X-Rspamd-Queue-Id: 469LX15PHGz3F21 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 64.59.134.9) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-3.99 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_LAST(0.00)[]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; IP_SCORE(-2.43)[ip: (-6.43), ipnet: 64.59.128.0/20(-3.16), asn: 6327(-2.45), country: CA(-0.09)]; NEURAL_HAM_SHORT(-0.96)[-0.960,0]; RCVD_IN_DNSWL_NONE(0.00)[9.134.59.64.list.dnswl.org : 127.0.5.0]; RCPT_COUNT_SEVEN(0.00)[7]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; MID_RHS_MATCH_FROM(0.00)[]; SUSPICIOUS_RECIPS(1.50)[]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Aug 2019 00:23:47 -0000 On August 16, 2019 4:32:18 PM PDT, "Rodney W=2E Grimes" wrote: >> On Fri, 16 Aug 2019 15:40:24 -0700 >> Cy Schubert wrote: >>=20 >> > On August 16, 2019 2:51:22 PM PDT, "Rodney W=2E Grimes" >> > wrote: >> > >> On 8/14/19 3:40 PM, Daniel Eischen wrote: =20 >> > >> > I've lost the original thread, but would the sources in =20 >> > >/usr/local/sys/modules get built regardless of what >MAKEOBJDIRPREFIX >> > >is? And, now that sources may be installed by a port, what is the >> > >method for _just_ updating the sources? Why do I even need to >build >> > >and install the port? Personally, I would just rather have the >> > >drm-kmod sources just imported into base and maintained there=2E If >I >> > >have 2 or more different checked out base src trees, how do I get >the >> > >correct drm-kmod to go with them if there is only one >> > >/usr/local/sys/modules? Do I need multiple port trees just to >pull >> > >in out of tree module sources? =20 >> > >>=20 >> > >> In some ways, installing sources for DRM is a compromise for the >> > >> fact =20 >> > >that we =20 >> > >> can't have DRM in the base source anymore (for various reasons)=2E > =20 >> > >However, =20 >> > >> virtualbox is also probably in that camp as well=2E =20 >> > > >> > >I applaud this effort to provide a source compile mode for DRM, >> > >but I think it has come up a bit short on execution with numorious >> > >problems sited=2E >> > > >> > >I too am not real happy that /usr/local/src is going to get >> > >automatically invoked from my some odd 10+ src trees that >> > >are of various WIP's=2E I need a way to easily disable this >> > >both on a global scale, and on a per src tree way=2E >> > > >> > >Rather than a default to on with an opt out mechanism perhaps >> > >while we gain experience change this to a default to off with >> > >an opt in mechanism? >> > > >> > >Sadly I do not have proposed solution, but something better >> > >than what is there now needs to be found=2E >> > > >> > >Regards, =20 >> >=20 >> > Could we have a =2Esrc=2Econf in the root of the tree to configure th= is >> > on a tree by tree basis? >> >=20 >> >=20 >>=20 >>=20 >> I use better way: >> /etc/make=2Econf: > >That file is global to all src trees, >so that does not achive the desired effect=2E > >> # Modules to build with kernel=2E >> PORTS_MODULES+=3D graphics/drm-fbsd12=2E0-kmod graphics/gpu-firmware-km= od > >Can we some how trigger that from either a kernel conf file, >or at least on a per src tree basis? Ala cy's =2Esrc=2Econf? >=20 >> + >> https://bugs=2Efreebsd=2Eorg/bugzilla/show_bug=2Ecgi?id=3D237290 > >I do like the patch that makes these go into the obj dir, good stuff! Presently we can use $SRCCONF=2E It's a PITA=2E =2Esrc=2Econf would overri= de any preexisting variables=2E We could expand the concept to look in ~/=2Esrc=2Econf prior to $SRCTOP/= =2Esrc=2Econf=2E --=20 Pardon the typos and autocorrect, small keyboard in use=2E Cheers, Cy Schubert FreeBSD UNIX: Web: http://www=2EFreeBSD=2Eorg The need of the many outweighs the greed of the few=2E From owner-freebsd-current@freebsd.org Sat Aug 17 00:33:41 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2BDE3B531E for ; Sat, 17 Aug 2019 00:33:41 +0000 (UTC) (envelope-from rozhuk.im@gmail.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 469LlS6FT8z3FWY for ; Sat, 17 Aug 2019 00:33:40 +0000 (UTC) (envelope-from rozhuk.im@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id D651AB531A; Sat, 17 Aug 2019 00:33:40 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D5EB3B5319; Sat, 17 Aug 2019 00:33:40 +0000 (UTC) (envelope-from rozhuk.im@gmail.com) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 469LlS5HK0z3FWX; Sat, 17 Aug 2019 00:33:40 +0000 (UTC) (envelope-from rozhuk.im@gmail.com) Received: by mail-ed1-x52a.google.com with SMTP id h13so6525175edq.10; Fri, 16 Aug 2019 17:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PGyalhOEutjKMjWQ29xV8bmWk17705KdigrtnD82qx4=; b=JMDF+7I5rF0ZYtLwXArqRqX4LHH3TnghvprMiTve47XDEFi5OM8bD9tll5WGxZmvic Ra+0EChej1fY46H+uJRH21IHNeGwxafoa4NWQGoP28+gXI/YWSm1taNMTijsmttp9w0r lC6KFZ7a9aV4E8BpKq1w0Qw9WMTJAMA/2Sz6wBpey9rpDP82VcDw+GSJ46Zf9x2eEAY/ kjy4EJEoS7sc6Z5mpH00//qFhzHs3VPgYkZcPq5wtSqi50UHrfRtbpyDrLd8OhauWtCv lRZCCdDX1ZxxEjq4YEtYQjK015UuZpsyPgrrDVZupy9hLDTxBQUTGFacCb3LvayC83lV 8bVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PGyalhOEutjKMjWQ29xV8bmWk17705KdigrtnD82qx4=; b=B57p6wDQae66HFyAHb8VMs89Bih5tsF3YYXgLIrpj+S/ZnA7rVVUSdNTREE6EV1R+p b9er5DRxiOfJKKGbnxrIZi9gf0k6MGXdLxq0BPbxmPygAxp/8/SJPaem9fgha3kKSNWk smFqjLdhihUVhu7bcK4E0Ljxf4APXskD+V5Khd1Y3g+k5O1KeMdc9UDlMscIVcxMJ50l 8GORCbcB4CXdLA1taZprJMDeFRkWmYOjmZaBa4299FP/BDidBCZDHoga8RgvxAi89SdE hguWv1v3z7IOSp8RnGSsyC03b7Ux04z0tU7OtdWmhPo9QueAhY3Qcd7LSVEoQbHorgRT kiOg== X-Gm-Message-State: APjAAAV10JL6esyw1jnq2rRC/tDyCbqpCWBcf4lQl/SPGkoKzV/e12qD kkiyPQZX5gq+/ZGyJirUCNzy03DApf4= X-Google-Smtp-Source: APXvYqze0u749R9j09U2eWAFa1sGqXPbJ5MTlyUV2EWSHx72bn956piW6R8HaYfbGqP959xvY0gSvw== X-Received: by 2002:aa7:c74e:: with SMTP id c14mr13448820eds.223.1566002018994; Fri, 16 Aug 2019 17:33:38 -0700 (PDT) Received: from rimwks ([2001:470:1f15:3d8:7285:c2ff:fe37:5722]) by smtp.gmail.com with ESMTPSA id v15sm322350ejh.15.2019.08.16.17.33.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Aug 2019 17:33:37 -0700 (PDT) From: Rozhuk Ivan X-Google-Original-From: Rozhuk Ivan Date: Sat, 17 Aug 2019 03:33:35 +0300 To: John Baldwin Cc: Cy Schubert , freebsd-current@freebsd.org, "Rodney W. Grimes" , Daniel Eischen , x11@freebsd.org, current@freebsd.org Subject: Re: HEADSUP: drm-current-kmod now installs sources Message-ID: <20190817033335.0b78f052@rimwks> In-Reply-To: References: <201908162151.x7GLpMqf032597@gndrsh.dnsmgr.net> <5B38128E-4CC9-496B-A9FD-B4208B7C044D@cschubert.com> <20190817015208.2c8c29e0@rimwks> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd12.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 469LlS5HK0z3FWX X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.965,0]; TAGGED_FROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Aug 2019 00:33:41 -0000 On Fri, 16 Aug 2019 17:23:08 -0700 John Baldwin wrote: > > I use better way: > > /etc/make.conf: > > # Modules to build with kernel. > > PORTS_MODULES+= graphics/drm-fbsd12.0-kmod > > graphics/gpu-firmware-kmod > > This doesn't work for folks who use pre-built packages. > I update mine /usr/src via rsync from other mine server, so any changes made by port or me or ... will lost. Probably there is must be some solution like special folder where ports can store some file with port name, that automaticly go to PORTS_MODULES on build kernel. And probably pkg can do with this something for "folks who use pre-built packages". From owner-freebsd-current@freebsd.org Sat Aug 17 00:37:12 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6470DB552C; Sat, 17 Aug 2019 00:37:12 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 469LqX1zH3z3FkN; Sat, 17 Aug 2019 00:37:12 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-4.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 7180312D7A; Sat, 17 Aug 2019 00:37:11 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: HEADSUP: drm-current-kmod now installs sources To: "Rodney W. Grimes" Cc: Daniel Eischen , freebsd-current@freebsd.org, x11@freebsd.org, current@freebsd.org References: <201908162151.x7GLpMqf032597@gndrsh.dnsmgr.net> From: John Baldwin Openpgp: preference=signencrypt Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: <0aabe497-c0c1-c671-d336-4ede3f3cf931@FreeBSD.org> Date: Fri, 16 Aug 2019 17:37:08 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <201908162151.x7GLpMqf032597@gndrsh.dnsmgr.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Aug 2019 00:37:12 -0000 On 8/16/19 2:51 PM, Rodney W. Grimes wrote: >> On 8/14/19 3:40 PM, Daniel Eischen wrote: >>> I've lost the original thread, but would the sources in /usr/local/sys/modules get built regardless of what MAKEOBJDIRPREFIX is? And, now that sources may be installed by a port, what is the method for _just_ updating the sources? Why do I even need to build and install the port? Personally, I would just rather have the drm-kmod sources just imported into base and maintained there. If I have 2 or more different checked out base src trees, how do I get the correct drm-kmod to go with them if there is only one /usr/local/sys/modules? Do I need multiple port trees just to pull in out of tree module sources? >> >> In some ways, installing sources for DRM is a compromise for the fact that we >> can't have DRM in the base source anymore (for various reasons). However, >> virtualbox is also probably in that camp as well. > > I applaud this effort to provide a source compile mode for DRM, > but I think it has come up a bit short on execution with numorious > problems sited. Do you have a reported problem vs a theoretical problem? The only reported problem I've seen is that LOCAL_MODULES="" doesn't work. That and Cy reported a build error from a recent commit to head due to LOCAL_MODULES working as intended. > I too am not real happy that /usr/local/src is going to get > automatically invoked from my some odd 10+ src trees that > are of various WIP's. I need a way to easily disable this > both on a global scale, and on a per src tree way. Modulo the LOCAL_MODULES="" not working (you have to just use LOCAL_MODULES=) this already exists. You can set it in /etc/src.conf, in a kernel config, or on the command line. > Rather than a default to on with an opt out mechanism perhaps > while we gain experience change this to a default to off with > an opt in mechanism? It's head, not stable. We can't gain experience with something that isn't turned on. -- John Baldwin From owner-freebsd-current@freebsd.org Sat Aug 17 00:37:59 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9C6B5B56B5 for ; Sat, 17 Aug 2019 00:37:59 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 469LrR3gKJz3FvG for ; Sat, 17 Aug 2019 00:37:59 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: by mailman.nyi.freebsd.org (Postfix) id 7DBA4B56B3; Sat, 17 Aug 2019 00:37:59 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7D797B56B2 for ; Sat, 17 Aug 2019 00:37:59 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 469LrR2dXNz3FvF; Sat, 17 Aug 2019 00:37:59 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-4.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 0833D12D7B; Sat, 17 Aug 2019 00:37:58 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: problem with LOCAL_MODULES To: gljennjohn@gmail.com, current@freebsd.org References: <20190816120524.21b7fd19@ernst.home> From: John Baldwin Openpgp: preference=signencrypt Autocrypt: addr=jhb@FreeBSD.org; keydata= mQGiBETQ+XcRBADMFybiq69u+fJRy/0wzqTNS8jFfWaBTs5/OfcV7wWezVmf9sgwn8TW0Dk0 c9MBl0pz+H01dA2ZSGZ5fXlmFIsee1WEzqeJzpiwd/pejPgSzXB9ijbLHZ2/E0jhGBcVy5Yo /Tw5+U/+laeYKu2xb0XPvM0zMNls1ah5OnP9a6Ql6wCgupaoMySb7DXm2LHD1Z9jTsHcAQMD /1jzh2BoHriy/Q2s4KzzjVp/mQO5DSm2z14BvbQRcXU48oAosHA1u3Wrov6LfPY+0U1tG47X 1BGfnQH+rNAaH0livoSBQ0IPI/8WfIW7ub4qV6HYwWKVqkDkqwcpmGNDbz3gfaDht6nsie5Z pcuCcul4M9CW7Md6zzyvktjnbz61BADGDCopfZC4of0Z3Ka0u8Wik6UJOuqShBt1WcFS8ya1 oB4rc4tXfSHyMF63aPUBMxHR5DXeH+EO2edoSwViDMqWk1jTnYza51rbGY+pebLQOVOxAY7k do5Ordl3wklBPMVEPWoZ61SdbcjhHVwaC5zfiskcxj5wwXd2E9qYlBqRg7QeSm9obiBCYWxk d2luIDxqaGJARnJlZUJTRC5vcmc+iGAEExECACAFAkTQ+awCGwMGCwkIBwMCBBUCCAMEFgID AQIeAQIXgAAKCRBy3lIGd+N/BI6RAJ9S97fvbME+3hxzE3JUyUZ6vTewDACdE1stFuSfqMvM jomvZdYxIYyTUpC5Ag0ERND5ghAIAPwsO0B7BL+bz8sLlLoQktGxXwXQfS5cInvL17Dsgnr3 1AKa94j9EnXQyPEj7u0d+LmEe6CGEGDh1OcGFTMVrof2ZzkSy4+FkZwMKJpTiqeaShMh+Goj XlwIMDxyADYvBIg3eN5YdFKaPQpfgSqhT+7El7w+wSZZD8pPQuLAnie5iz9C8iKy4/cMSOrH YUK/tO+Nhw8Jjlw94Ik0T80iEhI2t+XBVjwdfjbq3HrJ0ehqdBwukyeJRYKmbn298KOFQVHO EVbHA4rF/37jzaMadK43FgJ0SAhPPF5l4l89z5oPu0b/+5e2inA3b8J3iGZxywjM+Csq1tqz hltEc7Q+E08AAwUIAL+15XH8bPbjNJdVyg2CMl10JNW2wWg2Q6qdljeaRqeR6zFus7EZTwtX sNzs5bP8y51PSUDJbeiy2RNCNKWFMndM22TZnk3GNG45nQd4OwYK0RZVrikalmJY5Q6m7Z16 4yrZgIXFdKj2t8F+x613/SJW1lIr9/bDp4U9tw0V1g3l2dFtD3p3ZrQ3hpoDtoK70ioIAjjH aIXIAcm3FGZFXy503DOA0KaTWwvOVdYCFLm3zWuSOmrX/GsEc7ovasOWwjPn878qVjbUKWwx Q4QkF4OhUV9zPtf9tDSAZ3x7QSwoKbCoRCZ/xbyTUPyQ1VvNy/mYrBcYlzHodsaqUDjHuW+I SQQYEQIACQUCRND5ggIbDAAKCRBy3lIGd+N/BCO8AJ9j1dWVQWxw/YdTbEyrRKOY8YZNwwCf afMAg8QvmOWnHx3wl8WslCaXaE8= Message-ID: Date: Fri, 16 Aug 2019 17:37:56 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <20190816120524.21b7fd19@ernst.home> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Aug 2019 00:37:59 -0000 On 8/16/19 3:05 AM, Gary Jennejohn wrote: > I tried to build a kernel today and it failed in modules-all even > though I had LOCAL_MODULES="" in /etc/src.conf, as recommended by > jhb. > > That's wrong. It has to be LOCAL_MODULES=, otherwise > /sys/conf/kern.post.mk seems to conclude that there should be a > module under /usr/local/sys/modules with the name "". I think this will permit both versions to work: Index: sys/conf/kern.post.mk =================================================================== --- kern.post.mk (revision 351151) +++ kern.post.mk (working copy) @@ -76,6 +76,7 @@ modules-${target}: cd $S/modules; ${MKMODULESENV} ${MAKE} \ ${target:S/^reinstall$/install/:S/^clobber$/cleandir/} .endif +.if !empty(LOCAL_MODULES) .for module in ${LOCAL_MODULES} @${ECHODIR} "===> ${module} (${target:S/^reinstall$/install/:S/^clobber$/cleandir/})" @cd ${LOCAL_MODULES_DIR}/${module}; ${MKMODULESENV} ${MAKE} \ @@ -83,6 +84,7 @@ modules-${target}: ${target:S/^reinstall$/install/:S/^clobber$/cleandir/} .endfor .endif +.endif .endfor # Handle ports (as defined by the user) that build kernel modules -- John Baldwin From owner-freebsd-current@freebsd.org Sat Aug 17 01:14:48 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A8871B64EB for ; Sat, 17 Aug 2019 01:14:48 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 469Mfw0Sg5z3HnP for ; Sat, 17 Aug 2019 01:14:47 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x742.google.com with SMTP id m10so6312046qkk.1 for ; Fri, 16 Aug 2019 18:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s481+qQgLeCjvbjQ5Aw+WgkK/JuZ/6+oufFbcbn7q9o=; b=EsrSyhn36/VodwNd6f9bWu8fN5ZWTJ9VEIjMckSveG9S6G43hL9I+e/KBnwIzVrTk+ sHe/02TpURq33ZG8VM3YsGfVvKlJkbDMg4sDPpX1uj6WnJdyNopI2WlDHWarcf6I2Ini nhPs5FM2mz2Rior2P5z6+8jpDlIJWeDRkd5q/yTan4ZHHXjWL5eKCRJvReZyyevtPk40 CAnkkVakdmx4ThWUKHtyc7vQM6I3SNaY9YSZfaGoqvX9RP7JUnV8E4+DhSh8WsRLmQba 6LSQYCrKCWg9Vsd0XVin3nKVRvqVQhmGrkkoCTOty62bAyvwsio+JE8NLBG8xSdepjMy GcPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s481+qQgLeCjvbjQ5Aw+WgkK/JuZ/6+oufFbcbn7q9o=; b=mK6xFFn7Ld2FRgP5p7Wshj6+/6KT+JNsJnqqFGyOcwnEoRHL0jBzd4AEEtCTomw64L vnRVeOGe31OxDJZxknBi18iPG8GDCdtCa7Bt+JXCZaj7OWDxB0eGoTdfiDeXHNy+Ql/L 1FTEZMDOT56AxY8lZ0mKBhO0mQCthpQhsZ3me55lCRUarUYlBXyRanooAh562MZXi6Mw G/wiXJXZow6ZFXsS/ZkJm7G6iCBzb9iy9nsYeAWuPTWmNR8hyQ/GExTndujrGa++HLQS j0iGERVXvVvyrYenhCvvEIdf6YwId19CnjGc0DgUP6RMKifW2Q+riXm8kxn1NRrmfEEj WVUQ== X-Gm-Message-State: APjAAAVr56bp3ycrMAx8kAiXjq3jkXVIjK+4c1bJXS1Xxh+jRrb/Kxys IwwAD1xpbNvCTgp8ryPuWZRHuMXDLzfJ5lnoqwJtRA== X-Google-Smtp-Source: APXvYqySBnSFsKPsiXooFY+qxSk3soMzElR8gjFEUlTFj/oOhmWlWkaecxRGhpiagjZKxH4Sb7il1lDOmstbP+rD1Z0= X-Received: by 2002:a05:620a:621:: with SMTP id 1mr8834992qkv.380.1566004486919; Fri, 16 Aug 2019 18:14:46 -0700 (PDT) MIME-Version: 1.0 References: <201908162151.x7GLpMqf032597@gndrsh.dnsmgr.net> <0aabe497-c0c1-c671-d336-4ede3f3cf931@FreeBSD.org> In-Reply-To: <0aabe497-c0c1-c671-d336-4ede3f3cf931@FreeBSD.org> From: Warner Losh Date: Fri, 16 Aug 2019 19:14:35 -0600 Message-ID: Subject: Re: HEADSUP: drm-current-kmod now installs sources To: John Baldwin Cc: "Rodney W. Grimes" , Daniel Eischen , FreeBSD Current , x11@freebsd.org, FreeBSD Current X-Rspamd-Queue-Id: 469Mfw0Sg5z3HnP X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=EsrSyhn3; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::742) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.39 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-0.98)[-0.978,0]; RCVD_IN_DNSWL_NONE(0.00)[2.4.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-0.41)[ip: (3.33), ipnet: 2607:f8b0::/32(-2.96), asn: 15169(-2.38), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Aug 2019 01:14:48 -0000 On Fri, Aug 16, 2019 at 6:37 PM John Baldwin wrote: > On 8/16/19 2:51 PM, Rodney W. Grimes wrote: > >> On 8/14/19 3:40 PM, Daniel Eischen wrote: > >>> I've lost the original thread, but would the sources in > /usr/local/sys/modules get built regardless of what MAKEOBJDIRPREFIX is? > And, now that sources may be installed by a port, what is the method for > _just_ updating the sources? Why do I even need to build and install the > port? Personally, I would just rather have the drm-kmod sources just > imported into base and maintained there. If I have 2 or more different > checked out base src trees, how do I get the correct drm-kmod to go with > them if there is only one /usr/local/sys/modules? Do I need multiple port > trees just to pull in out of tree module sources? > >> > >> In some ways, installing sources for DRM is a compromise for the fact > that we > >> can't have DRM in the base source anymore (for various reasons). > However, > >> virtualbox is also probably in that camp as well. > > > > I applaud this effort to provide a source compile mode for DRM, > > but I think it has come up a bit short on execution with numorious > > problems sited. > > Do you have a reported problem vs a theoretical problem? The > only reported problem I've seen is that LOCAL_MODULES="" doesn't > work. That and Cy reported a build error from a recent commit to > head due to LOCAL_MODULES working as intended. > And once it's working like it is supposed too, you can override it on a per-tree basis. But it needs to be on by default to avoid POLA. > > I too am not real happy that /usr/local/src is going to get > > automatically invoked from my some odd 10+ src trees that > > are of various WIP's. I need a way to easily disable this > > both on a global scale, and on a per src tree way. > > Modulo the LOCAL_MODULES="" not working (you have to just use > LOCAL_MODULES=) this already exists. You can set it in > /etc/src.conf, in a kernel config, or on the command line. > You can also per-tree settings on a src.conf if you want. Nanobsd overrides /etc/src.conf and others to set per-build defaults that are reproducible w/o host contamination, for example. We have half a dozen mechanisms for managing per-tree settings. > > Rather than a default to on with an opt out mechanism perhaps > > while we gain experience change this to a default to off with > > an opt in mechanism? > > It's head, not stable. We can't gain experience with something > that isn't turned Turned off by default violates POLA for people that pkg install the drm stuff. They expect it to just work, even if they rebuild the kernel. So for at least the non-cross-build cases, it should be on by default. People with special needs, like 10 trees, will have to tweak their defaults. We cannot set the defaults based on that. Most developers have one or two trees and can easily manage when they are building stuff for other systems, jail images, etc on a case by case basis. Warner From owner-freebsd-current@freebsd.org Sat Aug 17 02:03:32 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0DC74B7DC5 for ; Sat, 17 Aug 2019 02:03:32 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic305-21.consmr.mail.gq1.yahoo.com (sonic305-21.consmr.mail.gq1.yahoo.com [98.137.64.84]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 469Nl64Yf3z3LNx for ; Sat, 17 Aug 2019 02:03:30 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: QxeelpkVM1kGzNwbybrEjHZLkS6q_jdL1las9wq5DOp_4QlQQTaXztcyv03wHbP iD1vyLfc27I0J0GYm8KhCnfMzGhxshiVivbUiY1j17I7Pu3VMFaewu2mQdo3H_h7gGQzMi2or8o. U.RQlhv39osUdyR0vxFz5I.opat4MLXZzWu6yxY.mWayHDO2zAhJtTp84av09iUdc0tIl1o38QSC uC2mA0GNuQ8OKPQmIe26z83ukQ3SdxZsdtkoANGz835VLEt.i4wVCKCDJYvMNB3GnJsqSQjvl2Wt .OvwnrO6LSvnVu1a9KbwGZAHddzkblqowCPGkPPAiGKfFmn6t8UoccLT78ryRXpj9pfPZJgQauJm WoV7oahBVpN.L1tLlf2uvUzt9qxtZo.XElhYVotXR8BbjjOlbezvfxOog7KixMMmxhXf6BMmpdaa WA..rWx39EGqojrcM_KdzfSApPWCruFpHsGiNWMhz1AFgJR.Sv3ILc1t9Wc9otfHv6NZSBB03w8r YaovKiGbS1W6canERmmA08VyA0W3eW6d6j3M4ir9n8hyE0nkkUuOj.iOdNN2HlXPUDLD3SazwKB3 KRqk8efcT9AdxsyXi2L2pE8W_QQNIkNcJ0JMp3HfvxKLsVgIMeXGABQ9Ave87bvJLfl0tej5_1dZ Sq8LMBXBudQNJH1Fs6mpjhNzL6xUV1hdKD9vu1KNaI1SMD2cgaMSa1nWUiUzVBlJvMF2WVvGJbRB BnKFEiv2eEy.FrCzAvsKnRS03FzGzOEppfKKG_byLPofFF5pgT.HM1XS37EbdCVzWg7Ad8wOpfSc yjkbUT2jxVPyY2DYf9skWW1G_BoCvVpCNNN1xQwguX.fSRW.HRNKlYvtU7AkMq8sPKJkzchMHi.g VwzE2zjbq4czVcHeQZf.P4VJnNg3o_Ut6hE7oKa2sn9T.BCTZC_wYxUuQNpYpWaJuVqGpRw61cGZ syT.LowEO5eetMUqLNl6cw9nSwQV2W9Yo91eTvZuGaWmyx8QAGUGXfqXVYf8TKYeREyQ2mqMhHMG r14GAgTuwAVKjpZWqmO5pA00G2qHTsssI6K7ZogKRMhHs7AQg65Z3HKczf0_CFsxT3YrppWPus2P c_7Enpt7Av3WQzeByURC_rrDaKGAsn2EMtjokZ3M_SCUarvlJJSbJ3bmhduBCd6lY.cjyQGOKe5W UIv9A9F4Nn5eCSL_xgY6UjTXgr.nbGigvc7N6Sl.4s5yP3x33PXkQqrITgbXqB0O2VLoTNEP8Jfw OspHVY1DP6_0TorW1ig-- Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.gq1.yahoo.com with HTTP; Sat, 17 Aug 2019 02:03:28 +0000 Received: by smtp430.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID 1aacca21b0a81573129407b83cf9d069; Sat, 17 Aug 2019 02:03:23 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: head -r351153 amd64 upgrade installworld failure: realinstall_subdir_stand got: 'sh: cc: not found' (a race?) Message-Id: Date: Fri, 16 Aug 2019 19:03:22 -0700 To: freebsd-toolchain@freebsd.org, freebsd-current@freebsd.org X-Mailer: Apple Mail (2.3445.104.11) X-Rspamd-Queue-Id: 469Nl64Yf3z3LNx X-Spamd-Bar: - X-Spamd-Result: default: False [-1.21 / 15.00]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; FREEMAIL_FROM(0.00)[yahoo.com]; TO_DN_NONE(0.00)[]; MV_CASE(0.50)[]; DKIM_TRACE(0.00)[yahoo.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (6.74), ipnet: 98.137.64.0/21(0.91), asn: 36647(0.73), country: US(-0.05)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; SUBJECT_HAS_QUESTION(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.75)[-0.754,0]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com.dwl.dnswl.org : 127.0.5.0]; NEURAL_SPAM_SHORT(0.80)[0.800,0]; NEURAL_HAM_LONG(-0.75)[-0.755,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[84.64.137.98.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Aug 2019 02:03:32 -0000 The below installworld material was after an apparently successful buildworld buildkernel then installkernel . Wrong stage for a cc producing loader_lua.sym ? (This was a normal, system-clang based build context, attempting an upgrade from head -r351102 .) --- realinstall_subdir_stand --- cc -target x86_64-unknown-freebsd13.0 = --sysroot=3D/usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/tmp = -B/usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/tmp/usr/bin -O2 = -pipe -I/usr/src/stand/i386/btx/lib -nostdinc = -I/usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/stand/libsa32 = -I/usr/src/stand/libsa -D_STANDALONE -I/usr/src/sys = -Ddouble=3Djagged-little-pill -Dfloat=3Dfloaty-mcfloatface = -DLOADER_GELI_SUPPORT -I/usr/src/stand/libsa/geli -DLOADER_DISK_SUPPORT = -m32 -ffreestanding -mno-mmx -mno-sse -mno-avx -mno-avx2 -msoft-float = -march=3Di386 -I. -I/usr/src/stand/common -I/usr/src/contrib/lua/src = -I/usr/src/stand/common -I/usr/src/stand/liblua = -DLUA_FLOAT_TYPE=3DLUA_FLOAT_INT64 -DLOADER_CD9660_SUPPORT = -DLOADER_EXT2FS_SUPPORT -DLOADER_MSDOS_SUPPORT -DLOADER_UFS_SUPPORT = -DLOADER_GZIP_SUPPORT -DLOADER_BZIP2_SUPPORT -DLOADER_NET_SUPPORT = -DLOADER_NFS_SUPPORT -DLOADER_TFTP_SUPPORT -DLOADER_GPT_SUPPORT = -DLOADER_MBR_SUPPORT -DLOADER_ZFS_SUPPORT -I/usr/src/stand/libsa/zfs = -I/usr/src/sys/cddl/boot/zfs -Wall -I/usr/src--- = realinstall_subdir_usr.sbin --- . . . --- realinstall_subdir_stand --- /stand/i386 -DLOADER_PREFER_AMD64 -std=3Dgnu99 -Wno-format-zero-length = -Wsystem-headers -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int = -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value = -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion = -Wno-unused-local-typedef -Wno-address-of-packed-member -Wno-switch = -Wno-switch-enum -Wno-knr-promoted-parameter -Wno-parentheses -Oz = -Qunused-arguments ERROR-tried-to-rebuild-during-make-install -nostdlib = -static -Ttext 0x0 -Wl,--no-threads -Wl,--no-rosegment -o = loader_lua.sym = /usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/stand/i386/btx/lib/cr= t0.o main.o conf.o vers.o chain.o boot.o commands.o console.o devopen.o = interp.o interp_backslash.o interp_parse.o ls.o misc.o module.o = load_elf32.o load_elf32_obj.o reloc_elf32.o load_elf64.o = load_elf64_obj.o reloc_elf64.o disk.o part.o vdisk.o dev_net.o bcache.o = isapnp.o pnp.o interp_lua.o zfs_cmd.o = /usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/stand/liblua32/liblua= .a /usr/ob--- realinstall_subdir_share --- . . . --- realinstall_subdir_stand --- = j/amd64_clang/amd64.amd64/usr/src/amd64.amd64/stand/i386/libi386/libi386.a= = /usr/obj/amd64_clang/amd64.amd64/usr/src/amd64.amd64/stand/libsa32/libsa32= .a=20 --- realinstall_subdir_tests --- . . . --- realinstall_subdir_stand --- sh: cc: not found Repeating buildworld buildkernel and then trying installworld (without the -j28 I had used originally) completed. =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-current@freebsd.org Sat Aug 17 03:33:58 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9EED9B9BE5 for ; Sat, 17 Aug 2019 03:33:58 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic315-15.consmr.mail.bf2.yahoo.com (sonic315-15.consmr.mail.bf2.yahoo.com [74.6.134.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 469QlT4W2Gz3QfV for ; Sat, 17 Aug 2019 03:33:57 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: GLqdTsQVM1nUgkGP64uAH3Xj5tmynD9LarpL6K.hJdSaSqqEiXIeUHNs2HSbvw9 IF8gDpavpGKKBc0i34keWSi_.T20qDrHig2P9B_YkccY4nsS_vDg6mWlCaSp1MNbBsDhZb5yXapF hUhwO3.cVz5EWUA7qablF1RG42nyVZsxRbhTUFFCHHX89o1l0vTrTt0RBvuQLFpl3lAwUpNT.yMj OyyCYaGFpO2Net_H6uw_zJzkgJQ7cEaj_j4q2fREMiBA04VyuTwDHR6PA1.MW.GOH_71IfBOcija xfZT9glvkeoxHfyNiL9OKJuDv_8cSYiYzuxgTTuGGP6VHxx0wZC.2.O8v7rcxYd0PxeL0jW0Ayo3 p4L5HbeMhJwR6lXlFN0iPeC8QGF.F5l4Susd6dNnp_YE7aFLizFnwZQvmdTHueMq5YKsiTdF.jqL ITdWplEbTGXxCNasN6RZrChtGYy031iDBjTQ0DJvG0vJnoaAXDqTAkBgCj6LygkXdJTGx_46m1mU H.fgC7oI.16URk95UWuXErttBmYmRS7bRUWohi3B9NXA1i4SJggzaB2LpKJ4v5r8_5f4H6QxtOFa xPeChh7LcdC.73alXIICxHj5nBcdn2H8kH0LBEzxS4cFSOPXqJ9ATo6mG1L4fVhQsxHc54.pS4PH hIeyXw9S4NHwr61Ivp88B9wK.Ns1qZO0MMfjS85W5qy4H9jb6E4b1Z7wHy8kzKTuTgMiCci7VeHN Gq4_9qJlp8Ou_rsprjWnGhVoWQcjRKSTMsaOHdfPhSOA4pkgzeiVYPLKVtdEhad1goQDkIjnze1A GsV8TXsW70h90ad_lQA0s9oS1eoQIrKbfwK42RKMiZw07tS2qXNhx.fYvqMIHFM2H4yWQu1_9BP9 _vKJOJyKg46Rhh69KVs7HgdJhVpT2J9.0jxhG7NHuQDUu0neNjBLJedWXudSBxa068xxBv.RP_Py HzvlwqPTPkpFU9Czp8XzZanElMsppgbb6CMebvPrvcwpDfwIJKm4aiHnCob4AtvyCAHfEgHLa1W8 l7ygwIz5MfMavo1FQwL5ZbLEG42TeGHDKUmkUQKaUUajSS8WvCIOMp20Zw4Qh8lWePOClUTEthO5 b9l1Q.DFNoQgkkd2zo7tMi5C2IIZwWgUsGU8IRJR3FQV2M8EJytPti7Lio8Uf3697DqTd_te5Vy4 72d5KRiYYh6J2vZnXfHMIDHt4MkEek5k3VTTV_QL6dUOXS_EUVem.7e0efdFWOq._uXb2.zQ2YqP Y48babsypN2bjEmQX9sNtwIw- Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.bf2.yahoo.com with HTTP; Sat, 17 Aug 2019 03:33:56 +0000 Received: by smtp414.mail.bf1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID f375ee1dd864af8bc98847467957debb; Sat, 17 Aug 2019 03:33:53 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: amd64 head -r351153 self-built but via devel/llvm90: 'objcopy: elf_update() failed: Layout constraint violation' for gptboot.bin Message-Id: <82D7BB4B-14B5-4F6D-A19D-942F4598520E@yahoo.com> Date: Fri, 16 Aug 2019 20:33:51 -0700 Cc: freebsd-amd64@freebsd.org To: freebsd-toolchain@freebsd.org, freebsd-current@freebsd.org X-Mailer: Apple Mail (2.3445.104.11) X-Rspamd-Queue-Id: 469QlT4W2Gz3QfV X-Spamd-Bar: - X-Spamd-Result: default: False [-1.42 / 15.00]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; FREEMAIL_FROM(0.00)[yahoo.com]; TO_DN_NONE(0.00)[]; MV_CASE(0.50)[]; DKIM_TRACE(0.00)[yahoo.com:+]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; ASN(0.00)[asn:26101, ipnet:74.6.128.0/21, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.85)[-0.846,0]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_SPAM_SHORT(0.78)[0.776,0]; NEURAL_HAM_LONG(-0.85)[-0.852,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (4.84), ipnet: 74.6.128.0/21(1.44), asn: 26101(1.15), country: US(-0.05)]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[125.134.6.74.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Aug 2019 03:33:58 -0000 I upgraded to head -r351153 and then attempted a buildworld buildkernel via devel/llvm90 (rc2 via ports head -r509054), but that (from scratch) build attempt got: --- gptboot.bin --- objcopy: elf_update() failed: Layout constraint violation *** [gptboot.bin] Error code 1 make[5]: *** gptboot.bin removed make[5]: stopped in /usr/src/stand/i386/gptboot .ERROR_TARGET=3D'gptboot.bin' = .ERROR_META_FILE=3D'/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd= 64.amd64/stand/i386/gptboot/gptboot.bin.meta' .MAKE.LEVEL=3D'5' MAKEFILE=3D'' .MAKE.MODE=3D'meta missing-filemon=3Dyes missing-meta=3Dyes silent=3Dyes = verbose' _ERROR_CMD=3D'objcopy -S -O binary gptboot.out gptboot.bin;' .CURDIR=3D'/usr/src/stand/i386/gptboot' .MAKE=3D'make' = .OBJDIR=3D'/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64.amd64/= stand/i386/gptboot' .TARGETS=3D'all' = DESTDIR=3D'/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64.amd64/= tmp' LD_LIBRARY_PATH=3D'' MACHINE=3D'amd64' MACHINE_ARCH=3D'amd64' MAKEOBJDIRPREFIX=3D'' MAKESYSPATH=3D'/usr/src/share/mk' MAKE_VERSION=3D'20181221' = PATH=3D'/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64.amd64/tmp= /usr/sbin:/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64.amd64/t= mp/usr/bin:/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64.amd64/= tmp/legacy/usr/sbin:/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd= 64.amd64/tmp/legacy/usr/bin:/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr= /src/amd64.amd64/tmp/legacy/bin::/sbin:/bin:/usr/sbin:/usr/bin' SRCTOP=3D'/usr/src' OBJTOP=3D'/usr/obj/amd64_xtoolchain-llvm/amd64.amd64/usr/src/amd64.amd64' .MAKE.MAKEFILES=3D'/usr/src/share/mk/sys.mk = /usr/src/share/mk/local.sys.env.mk /usr/src/share/mk/src.sys.env.mk = /root/src.configs/src.conf.amd64-xtoolchain-llvm.amd64-host = /usr/src/share/mk/bsd.mkopt.mk /usr/src/share/mk/src.sys.obj.mk = /usr/src/share/mk/auto.obj.mk /usr/src/share/mk/bsd.suffixes.mk = /root/src.configs/make.conf /usr/src/share/mk/local.sys.mk = /usr/src/share/mk/src.sys.mk /dev/null = /usr/src/stand/i386/gptboot/Makefile /usr/src/share/mk/bsd.init.mk = /usr/src/share/mk/bsd.opts.mk /usr/src/share/mk/bsd.cpu.mk = /usr/src/share/mk/local.init.mk /usr/src/share/mk/src.init.mk = /usr/src/stand/i386/gptboot/../Makefile.inc = /usr/src/share/mk/bsd.linker.mk = /usr/src/stand/i386/gptboot/../../Makefile.inc = /usr/src/stand/i386/gptboot/../../defs.mk /usr/src/share/mk/src.opts.mk = /usr/src/share/mk/bsd.own.mk /usr/src/share/mk/bsd.compiler.mk = /usr/src/share/mk/bsd.compiler.mk /usr/src/share/mk/bsd.prog.mk = /usr/src/share/mk/bsd.libnames.mk /usr/src/share/mk/src.libnames.mk = /usr/src/share/mk/bsd.nls.mk /usr/src/share/mk/bsd.confs.mk = /usr/src/share/mk/bsd.files.mk /usr/src/share/mk/bsd.dirs.mk = /usr/src/share/mk/bsd.incs.mk /usr/src/share/mk/bsd.links.mk = /usr/src/share/mk/bsd.man.mk /usr/src/share/mk/bsd.dep.mk = /usr/src/share/mk/bsd.clang-analyze.mk /usr/src/share/mk/bsd.obj.mk = /usr/src/share/mk/bsd.subdir.mk /usr/src/share/mk/bsd.sys.mk' .PATH=3D'. /usr/src/stand/i386/gptboot /usr/src/stand/i386/boot2 = /usr/src/stand/i386/common /usr/src/stand/libsa' 1 error =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar) From owner-freebsd-current@freebsd.org Sat Aug 17 03:39:18 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 29309B9E93 for ; Sat, 17 Aug 2019 03:39:18 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660082.outbound.protection.outlook.com [40.107.66.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 469Qsc74Qfz3Qtj; Sat, 17 Aug 2019 03:39:16 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Puh3atZgbGbwJ0+KOhoJaAbhcHv8rYHawXy9cjtdpHAfLLkCJ1HAdbaKUA8kpKHuEVzZk+GkEI2r2/iJljupkPo+6NoLaOFSKAO2Co+OG/2CXgBk0cyvL2D5NDnB0tJvfpY9zYQjusx2SsbsfV0E1KkeQBaozEPYSQjNs8SiRvl5gYb0MEQ3LNh6K9EhxcmbCxop2hQLsHbvDK4KxX5LWyIOBSk4VQFCi0EjDB9dV2bRKndqCaYJOHr3Olx/EuSrGfAYV9wMWA3bKzGPDryVYh3nXv/OTNGFB7ZC5+Gvg/YFmuBqJOfOnLcc4LRvTp3aBRr+R/thIr7Thmh7sz7acQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2J7fudKVWyAZltsZQBzY5SggcWCnVbI+NWFsPeD5Olo=; b=d0i0N2v+CmyspqVpZvCuWfYCx+JE/uul31hoHukw62rAR6zK6FD0X5jfxAtMhPTQJVE2jOj23bUii2bzEFavHrvzwjbtuzGw7XNVGI94jUMd3FbzcmebzBbspozyI8QMBvM01e+Y7eZPxtYwckoArOBDhFufjsnPvjsaAlP82UZExQSUiRDqDiNCqU+gIurBNQbIV2hyYUYYLb+85hK5tQW14pYvcw0JOUUs5jQTZaDSzCMwod4nyRS8CByaA38+OXppnfpBSj9fh9zQvNXPNXJY9gGMzm6NlDzlp8aqn6DeihzaobHu/2C2DKkFNS10+EGLAysM3x8GdavQXefXpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none Received: from YTBPR01MB3616.CANPRD01.PROD.OUTLOOK.COM (10.255.12.82) by YTBPR01MB2544.CANPRD01.PROD.OUTLOOK.COM (10.255.46.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2178.16; Sat, 17 Aug 2019 03:39:14 +0000 Received: from YTBPR01MB3616.CANPRD01.PROD.OUTLOOK.COM ([fe80::fc05:2310:90ce:16e]) by YTBPR01MB3616.CANPRD01.PROD.OUTLOOK.COM ([fe80::fc05:2310:90ce:16e%6]) with mapi id 15.20.2178.016; Sat, 17 Aug 2019 03:39:14 +0000 From: Rick Macklem To: Ian Lepore , Alan Somers CC: "gljennjohn@gmail.com" , "freebsd-current@FreeBSD.org" Subject: Re: RFC: should lseek(SEEK_DATA/SEEK_HOLE) return ENOTTY? Thread-Topic: RFC: should lseek(SEEK_DATA/SEEK_HOLE) return ENOTTY? Thread-Index: AQHVT+jQ5wsNrJT2jUSYLr8e3O7szab1hhuAgACEJgCAAARxAIAAHhmAgAiMaxs= Date: Sat, 17 Aug 2019 03:39:14 +0000 Message-ID: References: <20190811090405.50cc49b1@ernst.home> , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 978b1049-e5f9-4329-2207-08d722c479dc x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:YTBPR01MB2544; x-ms-traffictypediagnostic: YTBPR01MB2544: x-ms-exchange-purlcount: 2 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2887; x-forefront-prvs: 0132C558ED x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(376002)(136003)(396003)(39860400002)(199004)(189003)(55016002)(53546011)(186003)(6246003)(966005)(9686003)(71190400001)(74316002)(5660300002)(52536014)(71200400001)(446003)(11346002)(102836004)(256004)(66476007)(229853002)(7696005)(99286004)(4326008)(8676002)(6506007)(53936002)(33656002)(81156014)(81166006)(76176011)(66946007)(66446008)(64756008)(66556008)(6306002)(6436002)(46003)(25786009)(2906002)(86362001)(8936002)(54906003)(786003)(316002)(110136005)(14454004)(76116006)(486006)(305945005)(478600001)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:YTBPR01MB2544; H:YTBPR01MB3616.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: oGsM1Xj0WSf+Q01xJbN5Xe4beadQZ5hRstVj+8G7uE/ex3U6ubwfmLDkbQVkvazBu3PzfII82ALU8+o2XN+A2QYdJGBDru6kxD2LuHBNdnWRjBzjtD7eTP4FloLiAcosDDJqRCaIS41Kpug6tOppJ1oa+vKRbbx31V8F7QU/0kfDH1adggoQAF2Pe/hvW/lgc2Ttvw0Xfmrz/FOAqOdqp9hTLnJH6ajPkmPEeIWRBiwnBTEPQsKI33b+kAPLZsefbvVPkBYlWUm2o72Dje8UHo6Hf79c+LX8HSR27cUs/molo8OZUYUNVmbMuGY6vN+5VpMBDNL78a8ZLV3n5Qhhr/BXUBeY4ojg2SrlnwZBqNMz0d2+DsMK23Dz14jCtZItx5yHhVXwShzhQlfqbPrnE/vjRP6/b7EFLAWnEhoKHL0= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 978b1049-e5f9-4329-2207-08d722c479dc X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2019 03:39:14.8579 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AmUK/bY26s314sWQvaBL5PW6d+0cC8qHxoKxpy6GHYMCLNdYcKfeoiGIzGi4pLlzSJNVbOYEwk4h51LlW4UoTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTBPR01MB2544 X-Rspamd-Queue-Id: 469Qsc74Qfz3Qtj X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.66.82 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-4.39 / 15.00]; MIME_TRACE(0.00)[0:+]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[uoguelph.ca]; TO_DN_SOME(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_HAM_SHORT(-0.94)[-0.940,0]; RCVD_IN_DNSWL_NONE(0.00)[82.66.107.40.list.dnswl.org : 127.0.3.0]; IP_SCORE(-1.15)[ipnet: 40.64.0.0/10(-3.39), asn: 8075(-2.30), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; SUBJECT_ENDS_QUESTION(1.00)[]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; ARC_ALLOW(-1.00)[i=1]; FREEMAIL_CC(0.00)[gmail.com] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Aug 2019 03:39:18 -0000 Ian Lepore wrote: >On Sun, 2019-08-11 at 09:12 -0600, Alan Somers wrote: >> On Sun, Aug 11, 2019 at 8:57 AM Ian Lepore wrote: >> > >> > On Sun, 2019-08-11 at 09:04 +0200, Gary Jennejohn wrote: >> > > On Sun, 11 Aug 2019 02:03:10 +0000 >> > > Rick Macklem wrote: >> > > >> > > > Hi, >> > > > >> > > > I've noticed that, if you do a lseek(SEEK_DATA/SEEK_HOLE) on a >> > > > file >> > > > that >> > > > resides in a file system that does not support holes, ENOTTY is >> > > > returned. >> > > > >> > > > This error isn't listed for lseek() and seems a liitle weird. >> > > > >> > > >> > > ENOTTY is the standard error return for an unimplemented >> > > ioctl(2), >> > > and SEEK_HOLE ultimately becomes a call to fo_ioctl(). >> > > >> > > > I can see a couple of alternatives to this: >> > > > 1 - Return a different error. Maybe ENXIO? >> > > > or >> > > > 2 - Have lseek() do the trivial implementation when the >> > > > VOP_IOCTL() >> > > > fails. >> > > > - For SEEK_DATA, just return the offset given as argument >> > > > and >> > > > for SEEK_HOLE >> > > > return the file's size as the offset. >> > > > >> > > > What do others think? rick >> > > > ps: The man page should be updated, whatever is done w.r.t. >> > > > this. >> > > > >> > > >> > > I also vote for option 2 >> > > >> > >> > If SEEK_DATA and SEEK_HOLE don't return the standard "ioctl not >> > supported" error code and return a fake result, how are you >> > supposed to >> > determine at runtime whether SEEK_HOLE is supported or not? >> > >> > -- Ian >> >> pathconf(2) will tell you. >> > >Ahh, I wasn't aware of that. > >For option 2, lseek() has to not just return the info, but must also >actually set the file position accordingly, and has to treat offset >=3D >filesize as an error. I have put a patch for this at https://reviews.freebsd.org/D21299 I listed markj@ as a reviewer, but anyone is welcome to review it, if they'= d like. Since vn_bmap_seekhole() can return ENOTTY, the above patch follows that convention as well. I also have a trivial patch to map errnos not specified for lseek() to EINV= AL. https://reviews.freebsd.org/D21300. Ditto above w.r.t. to reviewing it. rick From owner-freebsd-current@freebsd.org Sat Aug 17 07:46:31 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EE24DBE5B5 for ; Sat, 17 Aug 2019 07:46:31 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 469XLv3N4vz45nt for ; Sat, 17 Aug 2019 07:46:31 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id 71F55BE5B4; Sat, 17 Aug 2019 07:46:31 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 71B12BE5B3 for ; Sat, 17 Aug 2019 07:46:31 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 469XLv2NlCz45ns; Sat, 17 Aug 2019 07:46:31 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wm1-x343.google.com with SMTP id z23so5806259wmf.2; Sat, 17 Aug 2019 00:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=P5/yt50WJ3DfaQIvxi6tHvZqaCHp7huWSjvVzmaN230=; b=QtIOaBH7nUoCAvAooDV4ztBlm+QCD7ZMjzApX4sEPfzkJSu4eIEksTJ1y/yxzTeHmj MPYy3QaxVH5S5V8Et70pDhHA5VVDG5JcRAA/4Yyaz/rvDkthTsez9RcG9yy9/0Tiw77H fjh4xKrM4b49UY3D0Druij2GAw/9GcLF8QWJKIi1yScyz27Dfw/HKIC95N9Axie3uSUY ON1K6BGIzb0YOcsVQd/aGOA/D0HZS1MFL8ReQE4LZ9sSUYA6BWgqe7wmutfdAdyF0Hp1 qSd8SgTjCWW/T4Z1OK90RxjXTe9aXiJpgoMjxnUHD4ckzRZW1L5fPXpx/qX6iMJj1zcG lQNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=P5/yt50WJ3DfaQIvxi6tHvZqaCHp7huWSjvVzmaN230=; b=BHEn9sEzEG+chpTHsu8iYPIUiBvOjj0uwYte9UguKmqaaWAjjP1880HEOYShHj5sx0 dNc21/6FXAhrL4BgBzDKhYvmODfz+Pnb4KuSfeqrazmzbFAVQPb6bK+GMnP7DfenH2Df TXjBlCpCirvBiWrAKe8EzYpv9J5acKRHDyODKNTJNUudwQ6LM5Ov7tnF4AgPCQRK0aMx 6g3btoxOteMV+GnF7XUjc1XFmsmDvwkaNEIAnPE8vKbKXS7lDSxROaGIpoocNVgDcwAh kdlBObhIn7XgiE2v6TipYEU0y2llsjnSt7A7sKTv1wx0Q4ixnaL+tkNFFnvXIY+dsMwO lDVw== X-Gm-Message-State: APjAAAUmHOBKrxFOaenHJQKQFSm/tUS2s4ohiBQCekXtFF58tcPJG1vR bDBRJ+aGF8zrnv1bXa2RXxrMiPyW X-Google-Smtp-Source: APXvYqwoDE1uYa/6D0QCBYFHt2DXSuug8cbg4+Dcu4L6WizmH0TANXTQhOfZujZ/z1619n0yxMXpkw== X-Received: by 2002:a1c:2314:: with SMTP id j20mr10583514wmj.152.1566027989596; Sat, 17 Aug 2019 00:46:29 -0700 (PDT) Received: from ernst.home (p5B3BE66A.dip0.t-ipconnect.de. [91.59.230.106]) by smtp.gmail.com with ESMTPSA id r16sm16429130wrc.81.2019.08.17.00.46.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Aug 2019 00:46:28 -0700 (PDT) Date: Sat, 17 Aug 2019 09:46:27 +0200 From: Gary Jennejohn To: John Baldwin Cc: current@freebsd.org Subject: Re: problem with LOCAL_MODULES Message-ID: <20190817094627.64358949@ernst.home> In-Reply-To: References: <20190816120524.21b7fd19@ernst.home> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 469XLv2NlCz45ns X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.981,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Aug 2019 07:46:32 -0000 On Fri, 16 Aug 2019 17:37:56 -0700 John Baldwin wrote: > On 8/16/19 3:05 AM, Gary Jennejohn wrote: > > I tried to build a kernel today and it failed in modules-all even > > though I had LOCAL_MODULES="" in /etc/src.conf, as recommended by > > jhb. > > > > That's wrong. It has to be LOCAL_MODULES=, otherwise > > /sys/conf/kern.post.mk seems to conclude that there should be a > > module under /usr/local/sys/modules with the name "". > > I think this will permit both versions to work: > > Index: sys/conf/kern.post.mk > =================================================================== > --- kern.post.mk (revision 351151) > +++ kern.post.mk (working copy) > @@ -76,6 +76,7 @@ modules-${target}: > cd $S/modules; ${MKMODULESENV} ${MAKE} \ > ${target:S/^reinstall$/install/:S/^clobber$/cleandir/} > .endif > +.if !empty(LOCAL_MODULES) > .for module in ${LOCAL_MODULES} > @${ECHODIR} "===> ${module} (${target:S/^reinstall$/install/:S/^clobber$/cleandir/})" > @cd ${LOCAL_MODULES_DIR}/${module}; ${MKMODULESENV} ${MAKE} \ > @@ -83,6 +84,7 @@ modules-${target}: > ${target:S/^reinstall$/install/:S/^clobber$/cleandir/} > .endfor > .endif > +.endif > .endfor > > # Handle ports (as defined by the user) that build kernel modules > Nope, the same error as before with the patch applied and LOCAL_MODULES="" . -- Gary Jennejohn