From owner-freebsd-current@freebsd.org Mon Nov 4 04:01:02 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3ECD31B1D11 for ; Mon, 4 Nov 2019 04:01:02 +0000 (UTC) (envelope-from danfe@regency.nsu.ru) Received: from mxt.nsu.ru (mxt.nsu.ru [84.237.50.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 475zcD2Z9Yz3QYx; Mon, 4 Nov 2019 04:00:59 +0000 (UTC) (envelope-from danfe@regency.nsu.ru) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nsu.ru; s=email; h=In-Reply-To:Content-Type:Mime-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Mj3VkbakH9wrUw5et45pG1V3TGfnrv7NBfJ4U8F3j2o=; b=Dy8T2yHoNpu7V9xBnZBbaH8JDX RHGLhXBZYJJ1hfwBoztXLoYluiKo/uc4YthH5UyjdGHlwcPPuGNx0UbrlPYEg0AMBABn7dLx5d5hW FNDMjVX62+Gq7PYEBI9KE/IQNcmSmC24e2NsfG1pcIk9qbZznlwwE+lHHi/PNLqXQj5U=; Received: from mail.nsu.ru ([84.237.50.42] helo=zimbra.nsu.ru) by mxt.nsu.ru with esmtp (Exim 4.89) (envelope-from ) id 1iRTXt-0002ap-4f; Mon, 04 Nov 2019 11:00:49 +0700 Received: from localhost (localhost [127.0.0.1]) by zimbra.nsu.ru (Postfix) with ESMTP id 1937D8001A2; Mon, 4 Nov 2019 11:00:49 +0700 (+07) Received: from zimbra.nsu.ru ([127.0.0.1]) by localhost (zimbra.nsu.ru [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id moFHgCVtkvHB; Mon, 4 Nov 2019 11:00:48 +0700 (+07) Received: from localhost (localhost [127.0.0.1]) by zimbra.nsu.ru (Postfix) with ESMTP id A161680021F; Mon, 4 Nov 2019 11:00:48 +0700 (+07) X-Virus-Scanned: amavisd-new at zimbra.nsu.ru Received: from zimbra.nsu.ru ([127.0.0.1]) by localhost (zimbra.nsu.ru [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id vI9Th0MN0ogE; Mon, 4 Nov 2019 11:00:48 +0700 (+07) Received: from regency.nsu.ru (unknown [84.237.50.47]) by zimbra.nsu.ru (Postfix) with ESMTPS id 578858001A2; Mon, 4 Nov 2019 11:00:48 +0700 (+07) Received: from regency.nsu.ru (localhost [127.0.0.1]) by regency.nsu.ru (8.14.2/8.14.2) with ESMTP id xA440v0R057975; Mon, 4 Nov 2019 11:00:58 +0700 (+07) (envelope-from danfe@regency.nsu.ru) Received: (from danfe@localhost) by regency.nsu.ru (8.14.2/8.14.2/Submit) id xA440q2C057921; Mon, 4 Nov 2019 11:00:52 +0700 (+07) (envelope-from danfe) Date: Mon, 4 Nov 2019 11:00:52 +0700 From: Alexey Dokuchaev To: John Baldwin Cc: freebsd-current@FreeBSD.org, jkim@FreeBSD.org Subject: Re: make delete-old: missing some files? Message-ID: <20191104040052.GA62001@regency.nsu.ru> References: <20191018170519.GA15695@regency.nsu.ru> <20191023034208.GA97072@regency.nsu.ru> <20191027124036.GA87210@regency.nsu.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191027124036.GA87210@regency.nsu.ru> User-Agent: Mutt/1.4.2.1i X-KLMS-Rule-ID: 3 X-KLMS-Message-Action: skipped X-KLMS-AntiSpam-Status: not scanned, whitelist X-KLMS-AntiPhishing: not scanned, whitelist X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.3.30, not scanned, whitelist X-Rspamd-Queue-Id: 475zcD2Z9Yz3QYx X-Spamd-Bar: +++ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=nsu.ru header.s=email header.b=Dy8T2yHo; dmarc=pass (policy=none) header.from=nsu.ru; spf=pass (mx1.freebsd.org: domain of danfe@regency.nsu.ru designates 84.237.50.40 as permitted sender) smtp.mailfrom=danfe@regency.nsu.ru X-Spamd-Result: default: False [3.73 / 15.00]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[nsu.ru:s=email]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+a:mxt.nsu.ru]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MV_CASE(0.50)[]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_MEDIUM(1.00)[0.998,0]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[nsu.ru:+]; DMARC_POLICY_ALLOW(-0.50)[nsu.ru,none]; NEURAL_SPAM_LONG(0.97)[0.971,0]; IP_SCORE(0.96)[ip: (3.08), ipnet: 84.237.48.0/21(0.94), asn: 3335(0.75), country: RU(0.01)]; FORGED_SENDER(0.30)[danfe@nsu.ru,danfe@regency.nsu.ru]; SUBJECT_ENDS_QUESTION(1.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:3335, ipnet:84.237.48.0/21, country:RU]; FROM_NEQ_ENVFROM(0.00)[danfe@nsu.ru,danfe@regency.nsu.ru]; RCVD_COUNT_SEVEN(0.00)[8] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Nov 2019 04:01:02 -0000 On Sun, Oct 27, 2019 at 07:40:36PM +0700, Alexey Dokuchaev wrote: > On Thu, Oct 24, 2019 at 11:07:16AM -0700, John Baldwin wrote: > > On 10/22/19 8:42 PM, Alexey Dokuchaev wrote: > > > On Tue, Oct 22, 2019 at 04:34:53PM -0700, John Baldwin wrote: > > >> ... > > >> These are from the OpenSSL 1.1.1 commit. However, they are tagged as > > >> OLD_LIBS and check-old-libs and delete-old-libs should be automatically > > >> deleting these? Does 'make check-old' report these files as > > >> old libraries? > > > > > > I've manually placed one of those back on the filesystem and `make > > > check-old' reported it (twice!) under libraries. But after r353907 it > > > get cleaned up properly with `make delete-old'. > > > > Hmm, then 'make delete-old-libs' should already delete them without needing > > r353907. The issue with r353907 is if someone doesn't delete the > > actual libraries via 'make delete-old-libs' but then tries to debug an > > application that was using the old openssl and crashed, we'd no longer > > have debug symbols if the crash was in one of those libraries. That > > matters less for OpenSSL engines, but matters more for something like > > libutil, etc. hence why we delete debug symbols as part of delete-old-libs > > instead of delete-old. > > > > If 'make delete-old-libs' deletes these files already, then we should > > probably revert r353907. > > I've reverted r353907, and `make delete-old-libs' deleted those files. So what was the final decision, did you guys sort it out? I've seen that r353907 was MFC'ed while it was still being discussed, hence my question: https://svnweb.freebsd.org/base?view=revision&revision=354150. > Also, I've noticed that `lib/libdtrace.so.2' is listed twice in the > tools/build/mk/OptionalObsoleteFiles.inc, which is probably another bug. What about DTrace-related issues (this and the previous one)? ./danfe