From owner-freebsd-fs@freebsd.org Sun Apr 7 15:36:46 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2BAE91558EEF; Sun, 7 Apr 2019 15:36:46 +0000 (UTC) (envelope-from tech-lists@zyxst.net) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E390B9493B; Sun, 7 Apr 2019 15:36:43 +0000 (UTC) (envelope-from tech-lists@zyxst.net) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0AB95210F2; Sun, 7 Apr 2019 11:36:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 07 Apr 2019 11:36:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zyxst.net; h= date:from:to:cc:subject:message-id:mime-version:content-type; s= fm2; bh=zGCT3CmTqGVetzGIOhw9+7WNGXlGtzmRRN3f2L3hir0=; b=rvVQwxiy /6iuy4UT5mJ4m1DKrN4kYnmAMhyF9Vf1SiwX59TdN7FurJC8mO9uKxBV1SMmupKO CD5GCMck/PvWtXqCf1eNVXjVz6YK3PddO/0na+kp3GZKKib84gU1GvLXqbCUiKAH nBbI3X4vyflmrYvdrSmF0btZjUJRLaqRlxWJAHohh6nxqaxij/1Jd/RWuH3IlE5R cC5UUqNw0dqA9g1J4ud8dKkjwp3tjtynJOY8uVTYl+h/lNAC+JjA9mtLgVSWvaAg oa2BeFBzLRJLAFUAxm4RrdvbOYjtokYvUZ/dleCNTRj/Jh1mzdi6uyQS79UhaEdN iBCVTs8aihGpNQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=zGCT3CmTqGVetzGIOhw9+7WNGXlGt zmRRN3f2L3hir0=; b=blmSv60FoYttUdqu8MIev5VKQH6cRYgaJgaT2CeE4PR/N iutP4nr2YUA587XGq3G+sdmxbOfyKJfc/3elMsXtzoh3MqMVxKC0T7rbOYlkrYHP Y4XIJkLTXmVaJVoYWXVeiePMpas8XndxtqoSnSG+42pa6v3eZCuJQ03WI/YN3wP9 auIKQln52M16CMu/Du/pAvkee+VQW2/xFB5hg4VsOrR/rM823lZUhtGQoyTc2uCw dPTm7I7Xu6JX8ttVpaVFS/IJeqmAdeaBeHl8ZxlJoxUmJpNx4Tt2qQ9O1iWXWC8A 08vFAmWKHrFNVBOlToFcL+p33WDss7DnyBb+QAm9A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddruddugdekleculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvf fukfggtggufgesghdtreertdervdenucfhrhhomhepthgvtghhqdhlihhsthhsuceothgv tghhqdhlihhsthhsseiihiigshhtrdhnvghtqeenucfkphepkedvrdejtddrledurddutd dunecurfgrrhgrmhepmhgrihhlfhhrohhmpehtvggthhdqlhhishhtshesiiihgihsthdr nhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from rpi3.zyxst.net (rpi3.zyxst.net [82.70.91.101]) by mail.messagingengine.com (Postfix) with ESMTPA id 2F4FCE45F3; Sun, 7 Apr 2019 11:36:42 -0400 (EDT) Date: Sun, 7 Apr 2019 16:36:40 +0100 From: tech-lists To: freebsd-fs@freebsd.org Cc: freebsd-stable@freebsd.org Subject: about zfs and ashift and changing ashift on existing zpool Message-ID: <20190407153639.GA41753@rpi3.zyxst.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EVF5PPMfhYS0aIcm" Content-Disposition: inline User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: E390B9493B X-Spamd-Bar: --------- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=zyxst.net header.s=fm2 header.b=rvVQwxiy; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=blmSv60F; spf=pass (mx1.freebsd.org: domain of tech-lists@zyxst.net designates 66.111.4.27 as permitted sender) smtp.mailfrom=tech-lists@zyxst.net X-Spamd-Result: default: False [-9.18 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[zyxst.net:s=fm2,messagingengine.com:s=fm2]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:66.111.4.27]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[zyxst.net]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[4]; DKIM_TRACE(0.00)[zyxst.net:+,messagingengine.com:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[in2-smtp.messagingengine.com,in1-smtp.messagingengine.com,in2-smtp.messagingengine.com,in1-smtp.messagingengine.com,in2-smtp.messagingengine.com,in1-smtp.messagingengine.com]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.981,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:11403, ipnet:66.111.4.0/24, country:US]; IP_SCORE(-3.49)[ip: (-9.45), ipnet: 66.111.4.0/24(-4.59), asn: 11403(-3.35), country: US(-0.06)]; RCVD_IN_DNSWL_LOW(-0.10)[27.4.111.66.list.dnswl.org : 127.0.5.1] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Apr 2019 15:36:46 -0000 --EVF5PPMfhYS0aIcm Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, I have this in sysctl.conf on a desktop machine (12-stable): vfs.zfs.min_auto_ashift=3D12 this has not always been there. I guess the zpool pre-dates it. I only noticed it because have recently had to replace a disk in its zfs array when I saw this: % zpool status pool: storage state: ONLINE status: One or more devices is currently being resilvered. The pool will continue to function, possibly in a degraded state. action: Wait for the resilver to complete. scan: resilver in progress since Sun Apr 7 03:09:42 2019 3.46T scanned at 79.5M/s, 2.73T issued at 62.8M/s, 3.46T total 931G resilvered, 78.94% done, 0 days 03:22:41 to go config: NAME STATE READ WRITE CKSUM storage ONLINE 0 0 0 raidz1-0 ONLINE 0 0 0 replacing-0 ONLINE 0 0 1.65K ada2 ONLINE 0 0 0 ada1 ONLINE 0 0 0 block size: 512B configured, 4= 096B native ada3 ONLINE 0 0 0 ada4 ONLINE 0 0 0 What I'd like to know is: 1. is the above situation harmful to data 2. given that vfs.zfs.min_auto_ashift=3D12, why does it still say 512B configured for ada1 which is the new disk, or.. 3. does "configured" pertain to the pool, the disk, or both 4. what would be involved in making them all 4096B 5. does a 512B disk wear out faster than 4096B (all other things being equal) Given that the machine and disks were new in 2016, I can't understand why z= fs didn't default to 4096B on installation thanks, --=20 J. --EVF5PPMfhYS0aIcm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE8n3tWhxW11Ccvv9/s8o7QhFzNAUFAlyqGPwACgkQs8o7QhFz NAU4zQ//cpkfnOep4ZM6n3HiNrBZ6Jqcfam8VYoow7X3roQm5JoSiIj9lYd0BAOF qupSwygvQRx2L14MnfPfCHcIcJAi+Oj/hsT6t3GxyNnK5wcQr6ng24BQ0x6dnzgh OU2kxq0jn0S/NIs09IcAa4zaeXqxCcnIwHbyPAD8ilU261nibdrnqW+bzLUZarYj SXbap9G5MWA6U1mBZsmGdVRZpyGAM/G1xQ5BT+ovNezSr2ssABoAtSy9DsQnbgmU plpq697kZWRokNcV25ASlyK5+nC71RawxDQ/YnMAVU0ZWItAWUkyI1LLjXahZtDV lmBfNMcP79iAcxJvfca9tp4sESlUG3eV/kHnm6kgD9XLDXDyu7jQfpfbgpB+4a8o 0O/BzXpNQD78E3W4zHaKBVswman+KHbbzcXUGc6Icm2sS6BTExXJYFMtjZI9Zt9g ho13EYQWAAVRX0FZOGXkn4xFAOVU4o3D4WHdiDjS9bINNVY5h8Y0/f/L1Uv9I4CB S64UfdkqLFaI2YSikZjtwnRr7vhdwovRdErILkZCp0UrC0GnqWRknosd+Kc+1wQT 4/djfaI6W9aUWUlDSQfml8MW03Fm7BtISvCTzg/nAUm4PnNmxkT025FrR12LD/9Y 5heGKN/1HNTbEWu5uL2cGM85yA1nHAqBomdDPYzdHkRzUc+Fiu0= =PrOZ -----END PGP SIGNATURE----- --EVF5PPMfhYS0aIcm-- From owner-freebsd-fs@freebsd.org Sun Apr 7 20:58:41 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 70A53156A799 for ; Sun, 7 Apr 2019 20:58:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 0767771DE5 for ; Sun, 7 Apr 2019 20:58:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id BF874156A798; Sun, 7 Apr 2019 20:58:40 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AD051156A796 for ; Sun, 7 Apr 2019 20:58:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48A8871DDF for ; Sun, 7 Apr 2019 20:58:40 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 7CC5D8BC7 for ; Sun, 7 Apr 2019 20:58:39 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x37KwdHV024016 for ; Sun, 7 Apr 2019 20:58:39 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x37KwdG6024015 for fs@FreeBSD.org; Sun, 7 Apr 2019 20:58:39 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 233277] Panic when receiving incremental ZFS send (solaris assert: db->db_buf == ((void *)0)) Date: Sun, 07 Apr 2019 20:58:39 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: nhuff@acm.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Apr 2019 20:58:41 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233277 --- Comment #7 from Nathan Huff --- No it isn't helpful because the panic doesn't happen because invariants are= n't enabled on the release branches. Enabling them brings the panic back. Sorry for the noise. --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Sun Apr 7 21:01:07 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7CFA8156AAD9 for ; Sun, 7 Apr 2019 21:01:07 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id EAC53721C4 for ; Sun, 7 Apr 2019 21:01:06 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id A526B156AAD1; Sun, 7 Apr 2019 21:01:06 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8156A156AACD for ; Sun, 7 Apr 2019 21:01:06 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3F354721BD for ; Sun, 7 Apr 2019 21:01:06 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 023EB8CA2 for ; Sun, 7 Apr 2019 21:01:05 +0000 (UTC) (envelope-from bugzilla-noreply@FreeBSD.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x37L14MQ060714 for ; Sun, 7 Apr 2019 21:01:04 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x37L14sx060701 for fs@FreeBSD.org; Sun, 7 Apr 2019 21:01:04 GMT (envelope-from bugzilla-noreply@FreeBSD.org) Message-Id: <201904072101.x37L14sx060701@kenobi.freebsd.org> X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@FreeBSD.org using -f From: bugzilla-noreply@FreeBSD.org To: fs@FreeBSD.org Subject: Problem reports for fs@FreeBSD.org that need special attention Date: Sun, 7 Apr 2019 21:01:04 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Apr 2019 21:01:07 -0000 To view an individual PR, use: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=(Bug Id). The following is a listing of current problems submitted by FreeBSD users, which need special attention. These represent problem reports covering all versions including experimental development code and obsolete releases. Status | Bug Id | Description ------------+-----------+--------------------------------------------------- New | 203492 | mount_unionfs -o below causes panic Open | 144447 | [zfs] sharenfs fsunshare() & fsshare_main() non f Open | 211491 | System hangs after "Uptime" on reboot with ZFS Open | 221909 | [ZFS] Add a sysctl to toggle send_corrupt_data 4 problems total for which you should take action. From owner-freebsd-fs@freebsd.org Mon Apr 8 18:46:25 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1F2FF15653F8 for ; Mon, 8 Apr 2019 18:46:25 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 936F786E89 for ; Mon, 8 Apr 2019 18:46:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 5731C15653F6; Mon, 8 Apr 2019 18:46:24 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1CAEE15653F4 for ; Mon, 8 Apr 2019 18:46:24 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AF9B986E84 for ; Mon, 8 Apr 2019 18:46:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 018AB14A83 for ; Mon, 8 Apr 2019 18:46:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x38IkMZx085642 for ; Mon, 8 Apr 2019 18:46:22 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x38IkMHp085641 for fs@FreeBSD.org; Mon, 8 Apr 2019 18:46:22 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 235775] [FUSEFS]: Reuse cached attributes, when available and valid Date: Mon, 08 Apr 2019 18:46:21 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2019 18:46:25 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235775 --- Comment #3 from commit-hook@freebsd.org --- A commit references this bug: Author: asomers Date: Mon Apr 8 18:45:45 UTC 2019 New revision: 346043 URL: https://svnweb.freebsd.org/changeset/base/346043 Log: fusefs: cache file attributes FUSE_LOOKUP, FUSE_GETATTR, FUSE_SETATTR, FUSE_MKDIR, FUSE_LINK, FUSE_SYMLINK, FUSE_MKNOD, and FUSE_CREATE all return file attributes with= a cache validity period. fusefs will now cache the attributes, if the serv= er returns a non-zero cache validity period. This change does _not_ implement finite attr cache timeouts. That will follow as part of PR 235773. PR: 235775 Reported by: cem Sponsored by: The FreeBSD Foundation Changes: projects/fuse2/sys/fs/fuse/fuse_internal.c projects/fuse2/sys/fs/fuse/fuse_internal.h projects/fuse2/sys/fs/fuse/fuse_node.c projects/fuse2/sys/fs/fuse/fuse_node.h projects/fuse2/sys/fs/fuse/fuse_vnops.c projects/fuse2/tests/sys/fs/fusefs/allow_other.cc projects/fuse2/tests/sys/fs/fusefs/create.cc projects/fuse2/tests/sys/fs/fusefs/default_permissions.cc projects/fuse2/tests/sys/fs/fusefs/flush.cc projects/fuse2/tests/sys/fs/fusefs/fsync.cc projects/fuse2/tests/sys/fs/fusefs/getattr.cc projects/fuse2/tests/sys/fs/fusefs/locks.cc projects/fuse2/tests/sys/fs/fusefs/lookup.cc projects/fuse2/tests/sys/fs/fusefs/open.cc projects/fuse2/tests/sys/fs/fusefs/read.cc projects/fuse2/tests/sys/fs/fusefs/release.cc projects/fuse2/tests/sys/fs/fusefs/setattr.cc projects/fuse2/tests/sys/fs/fusefs/unlink.cc projects/fuse2/tests/sys/fs/fusefs/utils.cc projects/fuse2/tests/sys/fs/fusefs/write.cc --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Mon Apr 8 21:28:41 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7A67E1569797; Mon, 8 Apr 2019 21:28:41 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from vtr.rulingia.com (vtr.rulingia.com [IPv6:2001:19f0:5801:ebe:5400:1ff:fe53:30fd]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "vtr.rulingia.com", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7E20A8CD6A; Mon, 8 Apr 2019 21:28:40 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from server.rulingia.com (ppp59-167-167-3.static.internode.on.net [59.167.167.3]) by vtr.rulingia.com (8.15.2/8.15.2) with ESMTPS id x38LSSr5048704 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 9 Apr 2019 07:28:34 +1000 (AEST) (envelope-from peter@rulingia.com) X-Bogosity: Ham, spamicity=0.000000 Received: from server.rulingia.com (localhost.rulingia.com [127.0.0.1]) by server.rulingia.com (8.15.2/8.15.2) with ESMTPS id x38LSM2E045124 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 9 Apr 2019 07:28:23 +1000 (AEST) (envelope-from peter@server.rulingia.com) Received: (from peter@localhost) by server.rulingia.com (8.15.2/8.15.2/Submit) id x38LSM7M045123; Tue, 9 Apr 2019 07:28:22 +1000 (AEST) (envelope-from peter) Date: Tue, 9 Apr 2019 07:28:22 +1000 From: Peter Jeremy To: tech-lists Cc: freebsd-fs@freebsd.org, freebsd-stable@freebsd.org Subject: Re: about zfs and ashift and changing ashift on existing zpool Message-ID: <20190408212822.GD13734@server.rulingia.com> References: <20190407153639.GA41753@rpi3.zyxst.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jRHKVT23PllUwdXP" Content-Disposition: inline In-Reply-To: <20190407153639.GA41753@rpi3.zyxst.net> X-PGP-Key: http://www.rulingia.com/keys/peter.pgp User-Agent: Mutt/1.11.4 (2019-03-13) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Apr 2019 21:28:41 -0000 --jRHKVT23PllUwdXP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2019-Apr-07 16:36:40 +0100, tech-lists wrote: >storage ONLINE 0 0 0 > raidz1-0 ONLINE 0 0 0 > replacing-0 ONLINE 0 0 1.65K > ada2 ONLINE 0 0 0 > ada1 ONLINE 0 0 0 block size: 512B configured, = 4096B native > ada3 ONLINE 0 0 0 > ada4 ONLINE 0 0 0 > >What I'd like to know is: > >1. is the above situation harmful to data In general no. The only danger is that ZFS is updating the uberblock replicas at the start and end of the volume assuming 512B sectors which means you are at a higher risk or losing one of the replica sets if a power failure occurs during an uberblock update. >2. given that vfs.zfs.min_auto_ashift=3D12, why does it still say 512B > configured for ada1 which is the new disk, or.. The pool is configured with ashift=3D9. >3. does "configured" pertain to the pool, the disk, or both "configured" relates to the pool - all vdevs match the pool >4. what would be involved in making them all 4096B Rebuild the pool - backup/destroy/create/restore >5. does a 512B disk wear out faster than 4096B (all other things being > equal) It shouldn't. It does mean that the disk is doing read/modify/write at the physical sector level but that should be masked by the drive cache. >Given that the machine and disks were new in 2016, I can't understand why = zfs >didn't default to 4096B on installation I can't answer that easily. The current version of ZFS looks at the native disk blocksize to determine the pool ashift but I'm not sure how things were in 2016. Possibilities include: * The pool was built explicitly with ashift=3D9 * The initial disks reported 512B native (I think this is most likely) * That version of ZFS was using logical, rather than native blocksize. My guess (given that only ada1 is reporting a blocksize mismatch) is that your disks reported a 512B native blocksize. In the absence of any overrid= e, ZFS will then build an ashift=3D9 pool. --=20 Peter Jeremy --jRHKVT23PllUwdXP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAlyrvPZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi CzQbEg//dTqzj9xBLYWErHc7ot1sH54+Mnwsgu7bYthA6E2uXIjT3lqK1+2X68Yn NStQiv9SIljbrCVlyN6aejgx1dFuSsd90DGOpPtwdFvHx8QkXIcXl0xzyef5R+7q XNfSyltWVa/DxGnH+7ve98PaQQTIfgn3WG4zn4tx69+XwwMOkhPlF6E0TC4XnST9 o+Qpv9BGzkRGYZsYy4gNMRFVhvUhoZvTys+k2euC7x9onZ4L/OnbeY6CAD/1Wj54 lZpAVgBB6Ms+lUWVvDPVtIKqA3RoDvlwefLgdJee6gnlNZ1vzQ/KBVr2DnqgQtbu xFhZB9j1tph+P184HcH8fKziYa+fudXGI9A9y1snga2hVLDSnPX1MlC0tt+4uHYs PJqCVWj9nWrw/x0B5z9nVAbLK74qS6QAe9Eodjp0p0tJ8sh/hHzHEB5llK44l8TL mlzMdgf5/PZlw8N+1TfbU8TfNWej+ImDRUa2L8n/vgU695Z2fMYSOBnqo/S3ZlKj 77Z45V05bQqUGz4XSn9VLG6jo5joibpH/gwyjr3extFWkXTEK36ZWoMKxW1ndlzX +FX5tNDhj6psntcRlDj/S5embKFFElKvyV2/CWNrIwJZvxiQ0HCTyiaW56vdflUX r91OkXSjk17hEJB8Zh95JMr/zUcYybofIak/JviHml0vHof4mJ4= =yHzn -----END PGP SIGNATURE----- --jRHKVT23PllUwdXP-- From owner-freebsd-fs@freebsd.org Tue Apr 9 00:22:31 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1861C156D972; Tue, 9 Apr 2019 00:22:31 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from hz.grosbein.net (hz.grosbein.net [IPv6:2a01:4f8:d12:604::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id E25686B3E0; Tue, 9 Apr 2019 00:22:19 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [IPv6:2a03:3100:c:13:0:0:0:5]) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id x390M58m037896 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 9 Apr 2019 02:22:09 +0200 (CEST) (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net X-Envelope-To: kpn@neutralgood.org Received: from [10.58.0.4] ([10.58.0.4]) by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTPS id x390M4YI051921 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Tue, 9 Apr 2019 07:22:04 +0700 (+07) (envelope-from eugen@grosbein.net) Subject: Re: about zfs and ashift and changing ashift on existing zpool To: "Kevin P. Neal" , Peter Jeremy References: <20190407153639.GA41753@rpi3.zyxst.net> <20190408212822.GD13734@server.rulingia.com> <20190409000009.GA65388@neutralgood.org> Cc: freebsd-fs@freebsd.org, freebsd-stable@freebsd.org, tech-lists , freebsd-geom@freebsd.org, Alexander Motin From: Eugene Grosbein Message-ID: <9590cb82-64be-a2f9-a812-36f0ea324e4d@grosbein.net> Date: Tue, 9 Apr 2019 07:21:57 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20190409000009.GA65388@neutralgood.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_00,LOCAL_FROM,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Report: * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.0 SPF_PASS SPF: sender matches SPF record * 2.6 LOCAL_FROM From my domains X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on hz.grosbein.net X-Rspamd-Queue-Id: E25686B3E0 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; spf=permerror (mx1.freebsd.org: domain of eugen@grosbein.net uses mechanism not recognized by this client) smtp.mailfrom=eugen@grosbein.net X-Spamd-Result: default: False [-3.55 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; MX_INVALID(0.50)[greylisted]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[grosbein.net]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_PERMFAIL(0.00)[]; NEURAL_HAM_SHORT(-0.82)[-0.822,0]; RCPT_COUNT_SEVEN(0.00)[7]; IP_SCORE(-1.13)[ip: (-1.48), ipnet: 2a01:4f8::/29(-2.16), asn: 24940(-2.01), country: DE(-0.01)]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 00:22:31 -0000 09.04.2019 7:00, Kevin P. Neal wrote: >> My guess (given that only ada1 is reporting a blocksize mismatch) is that >> your disks reported a 512B native blocksize. In the absence of any override, >> ZFS will then build an ashift=9 pool. [skip] > smartctl 7.0 2018-12-30 r4883 [FreeBSD 11.2-RELEASE-p4 amd64] (local build) > Copyright (C) 2002-18, Bruce Allen, Christian Franke, www.smartmontools.org > > === START OF INFORMATION SECTION === > Vendor: SEAGATE > Product: ST2400MM0129 > Revision: C003 > Compliance: SPC-4 > User Capacity: 2,400,476,553,216 bytes [2.40 TB] > Logical block size: 512 bytes > Physical block size: 4096 bytes Maybe it't time to prefer "Physical block size" over "Logical block size" in relevant GEOMs like GEOM_DISK, so upper levels such as ZFS would do the right thing automatically. From owner-freebsd-fs@freebsd.org Tue Apr 9 00:48:33 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2CE47156E398 for ; Tue, 9 Apr 2019 00:48:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id A9AEC6C4C8 for ; Tue, 9 Apr 2019 00:48:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 6A8CB156E396; Tue, 9 Apr 2019 00:48:32 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 56973156E394 for ; Tue, 9 Apr 2019 00:48:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D94506C4C6 for ; Tue, 9 Apr 2019 00:48:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 0AFE817DDF for ; Tue, 9 Apr 2019 00:48:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x390mUKe035902 for ; Tue, 9 Apr 2019 00:48:30 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x390mU7R035900 for fs@FreeBSD.org; Tue, 9 Apr 2019 00:48:30 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 235773] [FUSEFS]: Missing real support for attr/dentry cache timeouts Date: Tue, 09 Apr 2019 00:48:30 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 00:48:33 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235773 --- Comment #3 from commit-hook@freebsd.org --- A commit references this bug: Author: asomers Date: Tue Apr 9 00:47:40 UTC 2019 New revision: 346046 URL: https://svnweb.freebsd.org/changeset/base/346046 Log: fusefs: implement attribute cache timeouts The FUSE protocol allows the server to specify the timeout period for the client's attribute and entry caches. This commit implements the timeout period for the attribute cache. The entry cache's timeout period is currently disabled because it panics, and is guarded by the vfs.fusefs.lookup_cache_expire sysctl. PR: 235773 Reported by: cem Sponsored by: The FreeBSD Foundation Changes: projects/fuse2/sys/fs/fuse/fuse_internal.c projects/fuse2/sys/fs/fuse/fuse_internal.h projects/fuse2/sys/fs/fuse/fuse_node.c projects/fuse2/sys/fs/fuse/fuse_node.h projects/fuse2/sys/fs/fuse/fuse_vnops.c projects/fuse2/tests/sys/fs/fusefs/getattr.cc projects/fuse2/tests/sys/fs/fusefs/lookup.cc --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Tue Apr 9 00:56:03 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 69C63156E5F1; Tue, 9 Apr 2019 00:56:03 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 899D16C811; Tue, 9 Apr 2019 00:56:02 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-oi1-x22e.google.com with SMTP id e5so12156013oii.0; Mon, 08 Apr 2019 17:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:openpgp:autocrypt:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pS0tp7ULDb5hmpCqEAmUjvYnnznYgybUw5Nmo28ViGY=; b=IR/iukTmsXrsCGfBSgUSld2DfCefYtOxh2kqbtBCn9hbEX16bEuKInQCccodC4pvtI AyutHssSIzGXlExW4C20zMTIHFXdbDyu2Yyh1bCidIFGkreYZ7JwYZ4BzIZ+/OyqDxxq JmFH0a/mkf8CTWJ+Nq939mt1lQ+UOryUuHT9whX1VsG4khH6igb4dLLA9QW2QA/dObwf iTdTJ81fsh5sW5wUOsxDVQ0TdKCxZ/GosuzvdiAP3QGp9vQCD+Sr+9ao8fIYkuDhBEpU CrCFVsIo7eOe3LrWsLUPRtkn1lrcrTqppiLdiBzAAuJZUA+gkEeQbGIZliWbqw4cbDCl oGSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:openpgp :autocrypt:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=pS0tp7ULDb5hmpCqEAmUjvYnnznYgybUw5Nmo28ViGY=; b=lSrxEjXhcNLnpvugBrSsGzoyHYB94jBM90fWdAS2kyVwcDM/hs8oIm24vgNDQ5Ii0m 6KUFSlY56AzKZ2f9/QJpXmNT5P0LtflX97iSSouXsC4hOdQ6xFAMIjuBIdCfyyv0qY3k V5TViyGerLDSnZ2mkqBdmPbh0PX4xMGEJgDV1thaPkw7EYL5BLUAevoHFl4/VwMcmibU Ahf600tiMHaEufOWhkpeEjEKOKX1hHSP2DNXWt61A9FqfkFLP52a1I0c5KA1DHEJOG33 B1ckhea+j36vwppHRzcO+uvDL2nwpFFDpRUGz5WJ/Y316E18gpPbUlxZVgmlvGh3iAK8 EAcQ== X-Gm-Message-State: APjAAAX5xxq2q+Gq0D/h5FsY19mn40PS67V37jx9HdOvDUC81RQUAbC0 va9GxGX9xbuSvfDNmDLI7lN7fnwV X-Google-Smtp-Source: APXvYqwJ2mJaH96f5FaMB6bTKpeuo+1/nJh3KlXc41DMxlDY2wrCEmo817F5qLqXD1CzzSxFOeN8Kg== X-Received: by 2002:aca:3504:: with SMTP id c4mr17896736oia.74.1554771361187; Mon, 08 Apr 2019 17:56:01 -0700 (PDT) Received: from spectre.mavhome.dp.ua ([2600:1700:3580:3560:228:f8ff:fe04:d12]) by smtp.gmail.com with ESMTPSA id 96sm13272087otf.17.2019.04.08.17.56.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Apr 2019 17:56:00 -0700 (PDT) Sender: Alexander Motin Subject: Re: about zfs and ashift and changing ashift on existing zpool To: Eugene Grosbein , "Kevin P. Neal" , Peter Jeremy Cc: freebsd-fs@freebsd.org, freebsd-stable@freebsd.org, tech-lists , freebsd-geom@freebsd.org References: <20190407153639.GA41753@rpi3.zyxst.net> <20190408212822.GD13734@server.rulingia.com> <20190409000009.GA65388@neutralgood.org> <9590cb82-64be-a2f9-a812-36f0ea324e4d@grosbein.net> From: Alexander Motin Openpgp: preference=signencrypt Autocrypt: addr=mav@FreeBSD.org; prefer-encrypt=mutual; keydata= mQENBFOzxAwBCADkPrax0pI2W/ig0CK9nRJJwsHitAGEZ2HZiFEuti+6/4UVxj81yr4ak/4g 9bKUyC7rMEAp/ZHNhd+MFCPAAcHPvtovnfykqE/vuosCS3wlSLloix2iKVLks0CwbLHGAyne 46lTQW74Xl/33c3W1Z6d8jD9gVFT/xaVzZ0U9xdzOmsYAZaAj4ki0tuxO9F7L+ct9grRe7iP g8t9hai7BL4ee3VRwk2JXnKb7UvBiVITKYWKz1jRvZIrjPokgEcCLOSlv7x/1kjuFnj3xWZU 7HSFFT8J93epBbrSSCsYsppIk2fZH41kaaFXsMQfTPH8wkeM6qwrvOh4HiQM08R+9tThABEB AAG0IUFsZXhhbmRlciBNb3RpbiA8bWF2QEZyZWVCU0Qub3JnPokBVwQTAQoAQQIbAwULCQgH AwUVCgkICwUWAwIBAAIeAQIXgAIZARYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMKuBQkN McyiAAoJEIMYw5VbqyJ/tuUIAOG3ONOSNYqjK4eTZ1TVh9jdUBAhWk5nhDFnODN49Wj0AbYm 7aIqy8O1hnCDSZG5LttjSAo3UfXJZDKQM0BLb0gpRMBnAYqO6tdolLNqAbPGJBnGoPjsh24y 6KcbDaNnis+lD4GwPXwQM+92wZGhCUFElPV9NciZGVS65TNIgk7X+yEjjhD1MSWKKijZ1r9Z zIt4OzUTxxNOvzdlABZS88nNRdJkatOQJPmFdd1mpP6UzTNCiLUo1pIqOEtJgvVVDYq5WHY6 tciWWYdmZG/tIBexJmv2mV2OLVjXR6ZeKmntVH14H72/wRHJuYHQC+r5SVRcWWayrThsY6jZ Yr4+raS5AQ0EU7PEDAEIAOZgWf2cJIu+58IzP2dkXE/urj3tr4OqrB/yHGWUf71Lz6D0Fi6Z AXgDtmcFLGPfMyWuLAvSM+xmoguk7zC4hRBYvQycmIhuqBq1jO1Wp/Z+lpoPM/1cDYLn8Flv mI/c40MhUZh345DA4jYWWaZNjQHUWVQ1fPf595vdVVMPT/abE8E5DaF6fSkRmqFTmfYRkfbt 3ytU8NdUapDcJVY7cEP2nJBVNZPnOIObR/ZIgSxjjrG5o34yXoqeup8JvwEv+/NylzzuyXEZ R1EdEIzQ/a1nh/0j4NXtzZEqKW4aTWlmSqb6wN8jh1OSOOqkYsfnE3nfxcZbxi4IRoNQYlm5 9R8AEQEAAYkBPAQYAQoAJgIbDBYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMLYBQkNMczM AAoJEIMYw5VbqyJ/TqgH/RQHClkvecE0262lwKoP/m0Mh4I5TLRgoJJn8S7G1BnqohYJkiLq A6xe6urGD7OqdNAl12UbrjWbdJV+zvea3vJoM4MZuYiYrGaXWxzFXqWJcPwMU9sAh8MRghHu uC5vgPb45Tnftw9/+n0i8GfVhQhOqepUGdQg4NPcXviSkoAvig6pp9Lcxisn0groUQKt15Gc sS9YcQWg3j9Hnipc6Mu416HX98Fb113NHJqc2geTHLkRyuBFOoyIqB6N9GKjzOAIzxxsVdl9 TevwGsrp4M4/RFzWbSgsbOnbE7454lmuVZGfReEjnUm8RHp9Q2UWKXlp3exlZjvOp/uVEpCg lz65AQ0EU7PEDAEIAOZgWf2cJIu+58IzP2dkXE/urj3tr4OqrB/yHGWUf71Lz6D0Fi6ZAXgD tmcFLGPfMyWuLAvSM+xmoguk7zC4hRBYvQycmIhuqBq1jO1Wp/Z+lpoPM/1cDYLn8FlvmI/c 40MhUZh345DA4jYWWaZNjQHUWVQ1fPf595vdVVMPT/abE8E5DaF6fSkRmqFTmfYRkfbt3ytU 8NdUapDcJVY7cEP2nJBVNZPnOIObR/ZIgSxjjrG5o34yXoqeup8JvwEv+/NylzzuyXEZR1Ed EIzQ/a1nh/0j4NXtzZEqKW4aTWlmSqb6wN8jh1OSOOqkYsfnE3nfxcZbxi4IRoNQYlm59R8A EQEAAYkBPAQYAQoAJgIbDBYhBOmM88TmnMPNDledVYMYw5VbqyJ/BQJZYMLYBQkNMczMAAoJ EIMYw5VbqyJ/TqgH/RQHClkvecE0262lwKoP/m0Mh4I5TLRgoJJn8S7G1BnqohYJkiLqA6xe 6urGD7OqdNAl12UbrjWbdJV+zvea3vJoM4MZuYiYrGaXWxzFXqWJcPwMU9sAh8MRghHuuC5v gPb45Tnftw9/+n0i8GfVhQhOqepUGdQg4NPcXviSkoAvig6pp9Lcxisn0groUQKt15GcsS9Y cQWg3j9Hnipc6Mu416HX98Fb113NHJqc2geTHLkRyuBFOoyIqB6N9GKjzOAIzxxsVdl9Tevw Gsrp4M4/RFzWbSgsbOnbE7454lmuVZGfReEjnUm8RHp9Q2UWKXlp3exlZjvOp/uVEpCglz4= Message-ID: Date: Mon, 8 Apr 2019 20:55:59 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <9590cb82-64be-a2f9-a812-36f0ea324e4d@grosbein.net> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 899D16C811 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=IR/iukTm; spf=pass (mx1.freebsd.org: domain of mavbsd@gmail.com designates 2607:f8b0:4864:20::22e as permitted sender) smtp.mailfrom=mavbsd@gmail.com X-Spamd-Result: default: False [-5.96 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[FreeBSD.org]; NEURAL_HAM_SHORT(-0.99)[-0.994,0]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_IN_DNSWL_NONE(0.00)[e.2.2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; IP_SCORE(-2.75)[ip: (-8.57), ipnet: 2607:f8b0::/32(-2.95), asn: 15169(-2.18), country: US(-0.06)]; FORGED_SENDER(0.30)[mav@FreeBSD.org,mavbsd@gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[mav@FreeBSD.org,mavbsd@gmail.com]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 00:56:03 -0000 On 08.04.2019 20:21, Eugene Grosbein wrote: > 09.04.2019 7:00, Kevin P. Neal wrote: > >>> My guess (given that only ada1 is reporting a blocksize mismatch) is that >>> your disks reported a 512B native blocksize. In the absence of any override, >>> ZFS will then build an ashift=9 pool. > > [skip] > >> smartctl 7.0 2018-12-30 r4883 [FreeBSD 11.2-RELEASE-p4 amd64] (local build) >> Copyright (C) 2002-18, Bruce Allen, Christian Franke, www.smartmontools.org >> >> === START OF INFORMATION SECTION === >> Vendor: SEAGATE >> Product: ST2400MM0129 >> Revision: C003 >> Compliance: SPC-4 >> User Capacity: 2,400,476,553,216 bytes [2.40 TB] >> Logical block size: 512 bytes >> Physical block size: 4096 bytes > > Maybe it't time to prefer "Physical block size" over "Logical block size" in relevant GEOMs > like GEOM_DISK, so upper levels such as ZFS would do the right thing automatically. No. It is a bad idea. Changing logical block size for existing disks will most likely result in breaking compatibility and inability to read previously written data. ZFS already uses physical block size when possible -- on pool creation or new vdev addition. When not possible (pool already created wrong) it just complains about it, so that user would know that his configuration is imperfect and he should not expect full performance. -- Alexander Motin From owner-freebsd-fs@freebsd.org Tue Apr 9 01:25:56 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9F336156F903; Tue, 9 Apr 2019 01:25:56 +0000 (UTC) (envelope-from imb@protected-networks.net) Received: from mail.protected-networks.net (mail.protected-networks.net [202.12.127.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.protected-networks.net", Issuer "Protected Networks CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id A66276DBC7; Tue, 9 Apr 2019 01:25:53 +0000 (UTC) (envelope-from imb@protected-networks.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= protected-networks.net; h=content-transfer-encoding :content-language:content-type:content-type:in-reply-to :mime-version:user-agent:date:date:message-id:from:from :references:subject:subject; s=201508; t=1554773144; bh=zK4gi2f4 X8bCWOeWwieqF63chhx0O+OD8z6e5dGhkDk=; b=mZLU7tL0+ZEHm8EOpdKJ6Nti RBC+CVDJzHXkUqthnI2hZECYa/09Myby4RBcQnPGJ/9nx7UWAhUo+HIDRaH/bz8l LVTZUheSMnCWRp2YIO/1/55KBCm4u2IEYOttHrYpAuOg++xCZ51ep1smWTZqzWkV MQxUbdoD/2XBqn274cs= Received: from toshi.auburn.protected-networks.net (toshi.auburn.protected-networks.net [192.168.1.10]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: imb@mail.protected-networks.net) by mail.protected-networks.net (Postfix) with ESMTPSA id 7D15F1285F; Mon, 8 Apr 2019 21:25:44 -0400 (EDT) Subject: Re: about zfs and ashift and changing ashift on existing zpool To: Alexander Motin , Eugene Grosbein , "Kevin P. Neal" , Peter Jeremy Cc: freebsd-fs@freebsd.org, freebsd-geom@freebsd.org, freebsd-stable@freebsd.org, tech-lists References: <20190407153639.GA41753@rpi3.zyxst.net> <20190408212822.GD13734@server.rulingia.com> <20190409000009.GA65388@neutralgood.org> <9590cb82-64be-a2f9-a812-36f0ea324e4d@grosbein.net> From: Michael Butler Openpgp: preference=signencrypt Message-ID: Date: Mon, 8 Apr 2019 21:25:43 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A66276DBC7 X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=protected-networks.net header.s=201508 header.b=mZLU7tL0; spf=pass (mx1.freebsd.org: domain of imb@protected-networks.net designates 202.12.127.228 as permitted sender) smtp.mailfrom=imb@protected-networks.net X-Spamd-Result: default: False [-1.83 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[protected-networks.net:s=201508]; NEURAL_HAM_MEDIUM(-0.85)[-0.853,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[protected-networks.net]; NEURAL_SPAM_SHORT(0.54)[0.542,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[protected-networks.net:+]; MX_GOOD(-0.01)[sarah.protected-networks.net,mail.protected-networks.net]; RCPT_COUNT_SEVEN(0.00)[8]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(-0.01)[country: US(-0.06)]; ASN(0.00)[asn:5716, ipnet:202.12.127.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 01:25:56 -0000 On 2019-04-08 20:55, Alexander Motin wrote: > On 08.04.2019 20:21, Eugene Grosbein wrote: >> 09.04.2019 7:00, Kevin P. Neal wrote: >> >>>> My guess (given that only ada1 is reporting a blocksize mismatch) is that >>>> your disks reported a 512B native blocksize. In the absence of any override, >>>> ZFS will then build an ashift=9 pool. >> >> [skip] >> >>> smartctl 7.0 2018-12-30 r4883 [FreeBSD 11.2-RELEASE-p4 amd64] (local build) >>> Copyright (C) 2002-18, Bruce Allen, Christian Franke, www.smartmontools.org >>> >>> === START OF INFORMATION SECTION === >>> Vendor: SEAGATE >>> Product: ST2400MM0129 >>> Revision: C003 >>> Compliance: SPC-4 >>> User Capacity: 2,400,476,553,216 bytes [2.40 TB] >>> Logical block size: 512 bytes >>> Physical block size: 4096 bytes >> >> Maybe it't time to prefer "Physical block size" over "Logical block size" in relevant GEOMs >> like GEOM_DISK, so upper levels such as ZFS would do the right thing automatically. > > No. It is a bad idea. Changing logical block size for existing disks > will most likely result in breaking compatibility and inability to read > previously written data. ZFS already uses physical block size when > possible -- on pool creation or new vdev addition. When not possible > (pool already created wrong) it just complains about it, so that user > would know that his configuration is imperfect and he should not expect > full performance. And some drives just present 512 bytes for both .. no idea if this is consistent with the underlying silicon :-( I built a ZFS pool on it using 4k blocks anyway. smartctl 7.0 2018-12-30 r4883 [FreeBSD 13.0-CURRENT amd64] (local build) Copyright (C) 2002-18, Bruce Allen, Christian Franke, www.smartmontools.org === START OF INFORMATION SECTION === Device Model: WDC WDS100T2B0A-00SM50 Serial Number: 1837B0803409 LU WWN Device Id: 5 001b44 8b99f7560 Firmware Version: X61190WD User Capacity: 1,000,204,886,016 bytes [1.00 TB] Sector Size: 512 bytes logical/physical Rotation Rate: Solid State Device Form Factor: 2.5 inches Device is: Not in smartctl database [for details use: -P showall] ATA Version is: ACS-4 T13/BSR INCITS 529 revision 5 SATA Version is: SATA 3.3, 6.0 Gb/s (current: 6.0 Gb/s) Local Time is: Mon Apr 8 21:22:15 2019 EDT SMART support is: Available - device has SMART capability. SMART support is: Enabled AAM feature is: Unavailable APM level is: 128 (minimum power consumption without standby) Rd look-ahead is: Enabled Write cache is: Enabled DSN feature is: Unavailable ATA Security is: Disabled, frozen [SEC2] Wt Cache Reorder: Unavailable imb From owner-freebsd-fs@freebsd.org Tue Apr 9 13:49:00 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 91A9615818F1; Tue, 9 Apr 2019 13:49:00 +0000 (UTC) (envelope-from tech-lists@zyxst.net) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6465B8E0A1; Tue, 9 Apr 2019 13:48:58 +0000 (UTC) (envelope-from tech-lists@zyxst.net) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0E18E267F3; Tue, 9 Apr 2019 09:48:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 09 Apr 2019 09:48:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zyxst.net; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=mtpK4gTSDshRbqxO5kmtZ2cf79p Yp/tAW7woEtuvG0M=; b=qT0Tq7+I4hxZHZo2SRy48vFO+Zcz3yc07UQi5r8KhKI XWzW4vjvJAx4wDG10nEn7Qnfa0jq/MLyoTC9V/yufHYWryJ07Gk0Sr/oapCMAdBa HX6uEKXjWVnFgmic2Pderx9bVjHgrMc8d4aLn0rGvFhbe3VCFAD9Hv4lHB0vX+IY F28OlYHpUXlAihHXGrjABz3CB/7hU67NwfDunGsCBRUuYBBNWgRjhRVhdiwB0KOb bLghsXOPPFzmZJPOO982mnM+cA++i6mvPcf2l4AXgBP0mVSakZpXVHEzL+IoaaWN g7tOmE8TVgHLo6VaIaPds3X1ezQahi9i4FIKoAzdxZg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=mtpK4g TSDshRbqxO5kmtZ2cf79pYp/tAW7woEtuvG0M=; b=ItuIyy8JjTl5Ap9gVp7ahF /QMKsMv95DOebF1egi92XxtJHWIOuliVft5HPGe9P4K5nRiZpnSAkI0+Vi9rCM91 uwZr3VT++z80DdmIgsoM70hsU5PmoKdbws8FTY02H7sUvk7T7Wln5iDgJ1Bh38Xg 2Nfx4bg1FHZysJSPNkERzTbFsQJZGz8AiV9CUrjVEag8GCHmznqEiOzCjsiO76D8 TnDKlVNGY1IpM3fPcfAGXqKS05liEcd7dnkzvkzH4GRwI3p9GtjGpVMKh0YuyU+A eTT4662yyXHSwiSzRTxYq2o0hfhz9y4X4AKUs0dJmtXuTFtHImTbeW0anPS2WXFQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudehgdeilecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjfgesghdtre ertdervdenucfhrhhomhepthgvtghhqdhlihhsthhsuceothgvtghhqdhlihhsthhsseii hiigshhtrdhnvghtqeenucffohhmrghinhepshhmrghrthhmohhnthhoohhlshdrohhrgh enucfkphepkedvrdejtddrledurddutddunecurfgrrhgrmhepmhgrihhlfhhrohhmpeht vggthhdqlhhishhtshesiiihgihsthdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from rpi3.zyxst.net (rpi3.zyxst.net [82.70.91.101]) by mail.messagingengine.com (Postfix) with ESMTPA id 402E1E4519; Tue, 9 Apr 2019 09:48:50 -0400 (EDT) Date: Tue, 9 Apr 2019 14:48:47 +0100 From: tech-lists To: freebsd-stable@freebsd.org Cc: freebsd-fs@freebsd.org Subject: Re: about zfs and ashift and changing ashift on existing zpool Message-ID: <20190409134847.GA57588@rpi3.zyxst.net> References: <20190407153639.GA41753@rpi3.zyxst.net> <20190408212822.GD13734@server.rulingia.com> <20190409000009.GA65388@neutralgood.org> <9590cb82-64be-a2f9-a812-36f0ea324e4d@grosbein.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uAKRQypu60I7Lcqm" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 6465B8E0A1 X-Spamd-Bar: --------- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=zyxst.net header.s=fm2 header.b=qT0Tq7+I; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=ItuIyy8J; spf=pass (mx1.freebsd.org: domain of tech-lists@zyxst.net designates 66.111.4.26 as permitted sender) smtp.mailfrom=tech-lists@zyxst.net X-Spamd-Result: default: False [-9.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[zyxst.net:s=fm2,messagingengine.com:s=fm2]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:66.111.4.26]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[zyxst.net]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[4]; DKIM_TRACE(0.00)[zyxst.net:+,messagingengine.com:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[in2-smtp.messagingengine.com,in1-smtp.messagingengine.com,in2-smtp.messagingengine.com,in1-smtp.messagingengine.com,in2-smtp.messagingengine.com,in1-smtp.messagingengine.com]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_SHORT(-1.00)[-0.997,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:11403, ipnet:66.111.4.0/24, country:US]; IP_SCORE(-3.39)[ip: (-8.97), ipnet: 66.111.4.0/24(-4.58), asn: 11403(-3.35), country: US(-0.06)]; RCVD_IN_DNSWL_LOW(-0.10)[26.4.111.66.list.dnswl.org : 127.0.5.1] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 13:49:00 -0000 --uAKRQypu60I7Lcqm Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 08, 2019 at 09:25:43PM -0400, Michael Butler wrote: >On 2019-04-08 20:55, Alexander Motin wrote: >> On 08.04.2019 20:21, Eugene Grosbein wrote: >>> 09.04.2019 7:00, Kevin P. Neal wrote: >>> >>>>> My guess (given that only ada1 is reporting a blocksize mismatch) is = that >>>>> your disks reported a 512B native blocksize. In the absence of any o= verride, >>>>> ZFS will then build an ashift=3D9 pool. >>> >>> [skip] >>> >>>> smartctl 7.0 2018-12-30 r4883 [FreeBSD 11.2-RELEASE-p4 amd64] (local b= uild) >>>> Copyright (C) 2002-18, Bruce Allen, Christian Franke, www.smartmontool= s.org >>>> >>>> =3D=3D=3D START OF INFORMATION SECTION =3D=3D=3D >>>> Vendor: SEAGATE >>>> Product: ST2400MM0129 >>>> Revision: C003 >>>> Compliance: SPC-4 >>>> User Capacity: 2,400,476,553,216 bytes [2.40 TB] >>>> Logical block size: 512 bytes >>>> Physical block size: 4096 bytes >>> >>> Maybe it't time to prefer "Physical block size" over "Logical block siz= e" in relevant GEOMs >>> like GEOM_DISK, so upper levels such as ZFS would do the right thing au= tomatically. >> >> No. It is a bad idea. Changing logical block size for existing disks >> will most likely result in breaking compatibility and inability to read >> previously written data. ZFS already uses physical block size when >> possible -- on pool creation or new vdev addition. When not possible >> (pool already created wrong) it just complains about it, so that user >> would know that his configuration is imperfect and he should not expect >> full performance. > >And some drives just present 512 bytes for both .. no idea if this is >consistent with the underlying silicon :-( I built a ZFS pool on it >using 4k blocks anyway. > >smartctl 7.0 2018-12-30 r4883 [FreeBSD 13.0-CURRENT amd64] (local build) >Copyright (C) 2002-18, Bruce Allen, Christian Franke, www.smartmontools.org > >=3D=3D=3D START OF INFORMATION SECTION =3D=3D=3D >Device Model: WDC WDS100T2B0A-00SM50 >Serial Number: 1837B0803409 >LU WWN Device Id: 5 001b44 8b99f7560 >Firmware Version: X61190WD >User Capacity: 1,000,204,886,016 bytes [1.00 TB] >Sector Size: 512 bytes logical/physical >Rotation Rate: Solid State Device >Form Factor: 2.5 inches >Device is: Not in smartctl database [for details use: -P showall] >ATA Version is: ACS-4 T13/BSR INCITS 529 revision 5 >SATA Version is: SATA 3.3, 6.0 Gb/s (current: 6.0 Gb/s) >Local Time is: Mon Apr 8 21:22:15 2019 EDT >SMART support is: Available - device has SMART capability. >SMART support is: Enabled >AAM feature is: Unavailable >APM level is: 128 (minimum power consumption without standby) >Rd look-ahead is: Enabled >Write cache is: Enabled >DSN feature is: Unavailable >ATA Security is: Disabled, frozen [SEC2] >Wt Cache Reorder: Unavailable Yeah it's weird isn't it. So it seems it's not an issue with zfs at all as far as I can see. This is one of the drives that was replaced, and it's identical to the other two making up the array. So not unreasonably ashift was 9, as all three drives making up the array were 512 logical/physical. =3D=3D=3D START OF INFORMATION SECTION =3D=3D=3D Model Family: Western Digital Black Device Model: WDC WD4001FAEX-00MJRA0 Firmware Version: 01.01L01 User Capacity: 4,000,787,030,016 bytes [4.00 TB] Sector Size: 512 bytes logical/physical Device is: In smartctl database [for details use: -P show] ATA Version is: ATA8-ACS (minor revision not indicated) SATA Version is: SATA 3.0, 6.0 Gb/s (current: 6.0 Gb/s) Local Time is: Tue Apr 9 12:47:01 2019 BST SMART support is: Available - device has SMART capability. SMART support is: Enabled I replaced one of them with an 8tb drive: TART OF INFORMATION SECTION =3D=3D=3D Model Family: Seagate Archive HDD Device Model: ST8000AS0002-1NA17Z Firmware Version: AR13 User Capacity: 8,001,563,222,016 bytes [8.00 TB] Sector Sizes: 512 bytes logical, 4096 bytes physical Rotation Rate: 5980 rpm Device is: In smartctl database [for details use: -P show] ATA Version is: ACS-2, ACS-3 T13/2161-D revision 3b SATA Version is: SATA 3.1, 6.0 Gb/s (current: 6.0 Gb/s) Local Time is: Tue Apr 9 12:55:55 2019 BST SMART support is: Available - device has SMART capability. SMART support is: Enabled so the 2nd drive is emulating 512. But ZFS seems to see through that and correctly determines it's a 4k drive. In any case, the fix was to make a new pool (which automatically set ashift to 12 when the 8Tb disk was added) then zfs send from the old pool to the new one, then destroy the old pool. Fortunately this was easy because the system had zfs installed as an afterthought. So no root-on-zfs. The OS is on a SSD. All I can say is that zpool performance of a 4k drive in an a9 zpool is non-ideal. The new pool feels quicker (even though the disks aren't built for speed), and I've learned something new :D --=20 J. --uAKRQypu60I7Lcqm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE8n3tWhxW11Ccvv9/s8o7QhFzNAUFAlysorQACgkQs8o7QhFz NAV/Gg/+I5X1JnOvyhBH/oWzvCGEHDfl0eoFHAAr19RAthGTpzXj/1n30c4Eu+HN spg/jkGa562PyNEg7N5/65Il+vSXNISDKvBXAbkY8oO0V5OjRyPEkOu2HxfLjZKl t9J4CMgYDgeVJgHJY2hfXUD68tLIgvmRIkCu97IR91W6HAesQToymk2ZAXIziI8m Zd2Q1JYnQjY8elsqRGp3S4NiCtxqDpiQfEz5xNCEX/sqN2E68vsQ3q0OadInnb2V ILreKKz4bqZeocU+VFxyLi1lHe7AGLe2rzXH3Fjd2Xd6xItXAGRBfPGpW5tevD2U cm2YRWIzCTfC4UN1PvepWgrh4YOS5luQGdRU4oM9p1HgmvdB6VZ4OKdKKu9Oc9Rt roC4oYZOjPGKkryQvE2SmhK4XvpExrHDEpz6VcxSoXWMVOfA5B049ZFVMd5xsHvQ wv+kMsxQsREkev7e58g+UqKI3LHwzStMJkOUFq44EOarlPiUfeciW7ODRoolRYCA splmuJBB7ugoFKBtTo6JVdDlpczhTk43zU8kX3CvvbC4We01KYWXrjynXGWUq3S8 1+NLb26Y0oYLzReTm5ewolCDK9UO17jAO6KnhIvSGkRyQNNcSpWJ7fvtLAyJP2YQ ai7QRSWpkl6R/JvK7U3Vm9t5YvYyKuOQZMLbECEu+nTrxugcvgw= =2AUJ -----END PGP SIGNATURE----- --uAKRQypu60I7Lcqm-- From owner-freebsd-fs@freebsd.org Tue Apr 9 17:24:00 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 42233156679B for ; Tue, 9 Apr 2019 17:24:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id CC2626F63F for ; Tue, 9 Apr 2019 17:23:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 8B6C9156679A; Tue, 9 Apr 2019 17:23:59 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 799FC1566799 for ; Tue, 9 Apr 2019 17:23:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 160B86F639 for ; Tue, 9 Apr 2019 17:23:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 55F4820CAB for ; Tue, 9 Apr 2019 17:23:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x39HNwEj040057 for ; Tue, 9 Apr 2019 17:23:58 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x39HNwkO040056 for fs@FreeBSD.org; Tue, 9 Apr 2019 17:23:58 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 235773] [FUSEFS]: Missing real support for attr/dentry cache timeouts Date: Tue, 09 Apr 2019 17:23:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 17:24:00 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235773 --- Comment #4 from commit-hook@freebsd.org --- A commit references this bug: Author: asomers Date: Tue Apr 9 17:23:35 UTC 2019 New revision: 346060 URL: https://svnweb.freebsd.org/changeset/base/346060 Log: fusefs: implement entry cache timeouts Follow-up to r346046. These two commits implement fuse cache timeouts for both entries and attributes. They also remove the vfs.fusefs.lookup_cache enable sysctl, which is no longer needed now that cache timeouts are honored. PR: 235773 Sponsored by: The FreeBSD Foundation Changes: projects/fuse2/sys/fs/fuse/fuse_internal.h projects/fuse2/sys/fs/fuse/fuse_node.c projects/fuse2/sys/fs/fuse/fuse_vnops.c projects/fuse2/tests/sys/fs/fusefs/lookup.cc --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Tue Apr 9 17:53:24 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 56C5015676ED for ; Tue, 9 Apr 2019 17:53:24 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EB6C070D98 for ; Tue, 9 Apr 2019 17:53:23 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from [192.168.1.15] (c-71-198-162-232.hsd1.ca.comcast.net [71.198.162.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id A362EF086 for ; Tue, 9 Apr 2019 17:53:23 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/10.17.1.190326 Date: Tue, 09 Apr 2019 10:53:20 -0700 Subject: Re: about zfs and ashift and changing ashift on existing zpool From: Ravi Pokala To: "freebsd-fs@freebsd.org" Message-ID: Thread-Topic: about zfs and ashift and changing ashift on existing zpool Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: 7bit X-Rspamd-Queue-Id: EB6C070D98 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.97 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.99)[-0.993,0]; NEURAL_HAM_SHORT(-0.97)[-0.973,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 17:53:24 -0000 -----Original Message----- Date: Mon, 8 Apr 2019 20:00:09 -0400 From: "Kevin P. Neal" To: Peter Jeremy Cc: tech-lists , freebsd-fs@freebsd.org, freebsd-stable@freebsd.org Subject: Re: about zfs and ashift and changing ashift on existing zpool Message-ID: <20190409000009.GA65388@neutralgood.org> Content-Type: text/plain; charset=us-ascii ... > Be careful with that. I've got a new pool I made with 4Kn drives that ZFS > failed to detect were 4Kn drives. The resulting ashift was 9, but I did > catch it early enough to avoid too much pain. Still, it shouldn't have > happened. I've since set the sysctl so it doesn't accidentally happen in > the future. ... > Logical block size: 512 bytes > Physical block size: 4096 bytes That is *NOT* an AF-4Kn drive, it is an AF-512e drive. To refresh everyone's memory: XXXn: "native" - logical block size == physical block size XXXe: "emulated" - logical block size < physical block size 512n: logical block size = 512B; physical block size = 512B - Retronym; basically everything commercially available before 2013 was 512n AF-512e: logical block size = 512B; physical block size > 512B - Uses a larger physical block size for greater media encoding efficiency - Retains the same 512B logical block size that software has been expecting for decades - Firmware performs read/modify/write as needed for changes smaller than the physical block size - I have only seen AF-512e drives with physical block size 4KB, but apparently there are some with even larger physical blocks out / on the horizon. AF-4Kn: logical block size = 4KB; physical block size = 4KB - Uses a 4KB physical block size for greater media encoding efficiency - Uses a 4KB logical block size, to avoid firmware having to do read/modify/write - Requires software to be updated to perform logical-block-sized operations AF-4Ke: logical block size = 4KB; physical block size > 4KB - I have not seen one of these, but I have heard references to them. And then there are SSDs, which might report 512B or 4KB as either their logical or physical block sizes, but which actually use much larger NAND program blocks, and even larger NAND erase blocks. But everything about SSD "geometry" is a lie anyway. Also: the FreeBSD GEOM stack is aware of the differences between physical and logical block sizes. For a drive device, GEOM reports the logical block size as the "sector" size, and the physical block size as the "stripe" size. I **think** some (all?) of the in-tree GEOMs will prefer to use "stripe"-sized IOs if possible, falling back to "sector"-sized IOs if necessary. Thanks, Ravi (rpokala@) From owner-freebsd-fs@freebsd.org Fri Apr 12 19:05:35 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 865301583A63 for ; Fri, 12 Apr 2019 19:05:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 204F588592 for ; Fri, 12 Apr 2019 19:05:35 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id D08E81583A62; Fri, 12 Apr 2019 19:05:34 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BDC8E1583A61 for ; Fri, 12 Apr 2019 19:05:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 546778858C for ; Fri, 12 Apr 2019 19:05:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 949E9670 for ; Fri, 12 Apr 2019 19:05:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x3CJ5XIw025627 for ; Fri, 12 Apr 2019 19:05:33 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x3CJ5X5S025626 for fs@FreeBSD.org; Fri, 12 Apr 2019 19:05:33 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 235774] [FUSEFS]: Need to evict invalidated cache contents on fuse_write_directbackend() Date: Fri, 12 Apr 2019 19:05:31 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2019 19:05:35 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235774 --- Comment #5 from commit-hook@freebsd.org --- A commit references this bug: Author: asomers Date: Fri Apr 12 19:05:08 UTC 2019 New revision: 346162 URL: https://svnweb.freebsd.org/changeset/base/346162 Log: fusefs: evict invalidated cache contents during write-through fusefs's default cache mode is "writethrough", although it currently works more like "write-around"; writes bypass the cache completely. Since writ= es bypass the cache, they were leaving stale previously-read data in the cac= he. This commit invalidates that stale data. It also adds a new global v_inval_buf_range method, like vtruncbuf but for a range of a file. PR: 235774 Reported by: cem Sponsored by: The FreeBSD Foundation Changes: projects/fuse2/sys/fs/fuse/fuse_io.c projects/fuse2/sys/kern/vfs_subr.c projects/fuse2/sys/sys/vnode.h projects/fuse2/tests/sys/fs/fusefs/write.cc --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Fri Apr 12 19:11:06 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BD6D31583E25 for ; Fri, 12 Apr 2019 19:11:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 5462888DF5 for ; Fri, 12 Apr 2019 19:11:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 0F1751583E23; Fri, 12 Apr 2019 19:11:06 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F07271583E22 for ; Fri, 12 Apr 2019 19:11:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 88C1288DED for ; Fri, 12 Apr 2019 19:11:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id B3C12696 for ; Fri, 12 Apr 2019 19:11:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x3CJB4tl034466 for ; Fri, 12 Apr 2019 19:11:04 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x3CJB43q034465 for fs@FreeBSD.org; Fri, 12 Apr 2019 19:11:04 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 235774] [FUSEFS]: Need to evict invalidated cache contents on fuse_write_directbackend() Date: Fri, 12 Apr 2019 19:11:04 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: cem@freebsd.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2019 19:11:06 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235774 --- Comment #6 from Conrad Meyer --- Awesome, thanks Alan! --=20 You are receiving this mail because: You are the assignee for the bug.= From owner-freebsd-fs@freebsd.org Fri Apr 12 23:22:06 2019 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 26CBB1588C7F for ; Fri, 12 Apr 2019 23:22:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id AA52091A6D for ; Fri, 12 Apr 2019 23:22:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 66B7F1588C7E; Fri, 12 Apr 2019 23:22:05 +0000 (UTC) Delivered-To: fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 53DDA1588C7D for ; Fri, 12 Apr 2019 23:22:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DA28291A6A for ; Fri, 12 Apr 2019 23:22:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id F02F62B0F for ; Fri, 12 Apr 2019 23:22:03 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x3CNM3V3089459 for ; Fri, 12 Apr 2019 23:22:03 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x3CNM39O089458 for fs@FreeBSD.org; Fri, 12 Apr 2019 23:22:03 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 234581] [fusefs] no VOP_ADVLOCK support Date: Fri, 12 Apr 2019 23:22:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: asomers@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: asomers@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc bug_status assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2019 23:22:06 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D234581 Alan Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |freebsd@moosefs.com Status|New |In Progress Assignee|fs@FreeBSD.org |asomers@FreeBSD.org --=20 You are receiving this mail because: You are the assignee for the bug.=